* peoplemerge coding | 00:00 | |
*** alcabrera is now known as alcabrera|afk | 00:00 | |
* vkmc parses JSON in client-side and it feels wrong | 00:00 | |
* kgriffs reviewing | 00:01 | |
* peoplemerge wishes he didn't tox pep8 | 00:01 | |
* flwang crossing fingers | 00:01 | |
flwang | because god is reviewing | 00:01 |
---|---|---|
peoplemerge | flwang: lol | 00:02 |
kgriffs | flwang: was creating the ping endpoint part of this bp? | 00:02 |
flwang | ah, yep | 00:02 |
kgriffs | oh wait... maybe it is already impl | 00:02 |
flwang | you mean I should mark this as partially implements? | 00:02 |
flwang | it has been merged last release | 00:03 |
kgriffs | right, I forgot | 00:03 |
kgriffs | ok, nevermind | 00:03 |
flwang | god is continually reviewing my patch | 00:03 |
* kgriffs is only a minor god | 00:04 | |
* kgriffs is not even as cool as Hercules | 00:04 | |
flwang | minor god is a god :D | 00:04 |
* vkmc wonders... is kgriffs sudo? | 00:05 | |
kgriffs | hmmm, idk | 00:05 |
* peoplemerge can't even fake a convincing god complex | 00:05 | |
kgriffs | let's test | 00:05 |
kgriffs | make me sandwich | 00:05 |
* kgriffs looks around for a sandwich | 00:06 | |
* flwang show me the money | 00:06 | |
* kgriffs sighs | 00:06 | |
vkmc | lol | 00:06 |
* kgriffs realizes he isn't sudo | 00:06 | |
flwang | if you're a fan's or starcraft | 00:06 |
* kgriffs drops a link https://xkcd.com/149/ | 00:06 | |
* peoplemerge grins at the xkcd | 00:07 | |
vkmc | \o/ xkcd | 00:07 |
peoplemerge | yep | 00:07 |
kgriffs | flwang: oooh, starcraft. Haven't played in a while but I used to be super addicted | 00:07 |
flwang | kgriffs: you're not alone, man | 00:07 |
openstackgerrit | A change was merged to openstack/marconi: Updated from global requirements https://review.openstack.org/106506 | 00:08 |
flwang | I love it so much when I at college | 00:08 |
kgriffs | now I just waste all my time on stupid casual games like Clash of Clans. <sigh> | 00:08 |
flwang | now there is sc2 | 00:08 |
kgriffs | yep. have you played it? | 00:08 |
flwang | kgriffs: I'm trying to pick it up to get some fun at the boring NZ | 00:09 |
kgriffs | heh | 00:09 |
kgriffs | we should play sometime. I'm no good, but it's fun | 00:09 |
kgriffs | and by no good, I mean nothing like the Koreans | 00:09 |
kgriffs | I mean, talk about god | 00:09 |
kgriffs | those guys are *insane* | 00:09 |
flwang | kgriffs: yep, there is a battlenet, so we can do that | 00:10 |
flwang | not sure if flaper87|afk like it | 00:10 |
flwang | may be we can schedule a war, US vs China vs Italy | 00:10 |
peoplemerge | hahaha | 00:11 |
vkmc | lol | 00:11 |
kgriffs | sweet | 00:12 |
kgriffs | in original SC, I had a friend who made a custom map of the world | 00:12 |
peoplemerge | vkmc: where r u located? | 00:12 |
kgriffs | playing it was like Risk - totally awesome | 00:12 |
vkmc | I'm a bit addicted to Game Thunder now... dunno if you know it | 00:12 |
peoplemerge | Risk - totally awesome | 00:12 |
flwang | interesting | 00:12 |
* kgriffs googles Game Thunder | 00:12 | |
vkmc | peoplemerge, I'm from Argentina :) | 00:12 |
vkmc | it's a MMO combat game | 00:13 |
* flwang have no idea what's the Game Thunder :( | 00:13 | |
vkmc | in Steam | 00:13 |
vkmc | free to play :) | 00:13 |
peoplemerge | vkmc: I was rooting for Argentina :) | 00:14 |
vkmc | the ugly part is that it doesn't run on GNU/Linux... but Wine comes to the rescue :D | 00:14 |
kgriffs | is it war thunder or game thunder? | 00:14 |
vkmc | kgriffs, http://warthunder.com/ | 00:14 |
kgriffs | ...because game thunder just brought up a flash games site | 00:14 |
kgriffs | got it | 00:14 |
kgriffs | hmmm. looks interesting. | 00:15 |
vkmc | peoplemerge, oh thanks :) I enjoyed the last game til the 120 minute :p | 00:15 |
flwang | kgriffs: I will practise sc and fling down the gauntlet, haha | 00:15 |
kgriffs | oh oh. | 00:15 |
kgriffs | :) | 00:16 |
flwang | i'm kidding | 00:16 |
flwang | but I will play it again recently, TBH, because NZ is a little bit boring :D | 00:16 |
kgriffs | heh | 00:18 |
kgriffs | back to work. ;) | 00:18 |
kgriffs | https://review.openstack.org/#/c/76555/13/tests/unit/queues/storage/test_pool_queues.py | 00:18 |
flwang | too simple? | 00:19 |
flwang | or the wrong place? | 00:19 |
kgriffs | no, I was just thinking, isn't the pool driver supposed to return the stats under an extra level of indirection? | 00:19 |
kgriffs | https://review.openstack.org/#/c/76555/13/marconi/queues/storage/pooling.py | 00:20 |
*** tongli has quit IRC | 00:20 | |
flwang | kgriffs: ah, I can see you're point | 00:21 |
*** tongli has joined #openstack-marconi | 00:21 | |
flwang | kgriffs: I may need to review the test case | 00:21 |
kgriffs | not sure... seems like that test case should be failing but it's not... didn't the patch get merged that enabled pool driver testing? | 00:22 |
kgriffs | flwang: in this one | 00:23 |
kgriffs | def health(self): | 00:23 |
malini | it did - it failed one of my patches :D | 00:23 |
kgriffs | ah | 00:23 |
kgriffs | hmm | 00:23 |
kgriffs | flwang: def health(self): | 00:23 |
kgriffs | https://review.openstack.org/#/c/76555/13/marconi/queues/storage/base.py | 00:23 |
kgriffs | L79 | 00:23 |
kgriffs | actually | 00:23 |
openstackgerrit | Sam Leong proposed a change to openstack/marconi: Use auth_token from keystonemiddleware https://review.openstack.org/108540 | 00:23 |
kgriffs | L83 | 00:23 |
kgriffs | remind me why we are using that extra overall_health dict? | 00:24 |
flwang | we was planning to add more KPI in the future | 00:25 |
flwang | and adding them at here to get a 'better' format, easy to extend | 00:25 |
flwang | for example, something are not related to backend, but the marconi server itself | 00:27 |
kgriffs | ah, ok | 00:29 |
kgriffs | https://review.openstack.org/#/c/76555/13/tests/functional/wsgi/v1_1/test_shards.py | 00:29 |
kgriffs | first off all, someone needs to rename these tests to pools, right? | 00:29 |
kgriffs | ;p | 00:30 |
kgriffs | but that aside, I think the health check belongs in a different test suite | 00:30 |
flwang | yes, actually, I found a lot of shard legacy code | 00:30 |
flwang | so you mean it's not necessary to add a test at here? | 00:30 |
kgriffs | well...actually | 00:30 |
kgriffs | hmmm | 00:30 |
kgriffs | I take that back. this would be testing the health operation when pooling is enabled? | 00:31 |
kgriffs | flwang: can you file a bug for this an any other instances that still need to be renamed? | 00:32 |
kgriffs | (shard ---> pool) | 00:32 |
flwang | kgriffs: no problem, sir | 00:32 |
kgriffs | cool | 00:32 |
flwang | kgriffs: and TBH, i'm a little bit confused where to put the health on pool test | 00:32 |
kgriffs | so, for functional tests I think this is the right place | 00:33 |
flwang | ok, then how about this https://review.openstack.org/#/c/76555/13/tests/unit/queues/storage/test_pool_queues.py | 00:33 |
kgriffs | malini: btw, I thought I remembered seeing some tests using jsonschema? | 00:33 |
malini | yes..we have a few functional tests | 00:33 |
kgriffs | malini: OK, I asked because I was thinking it would be good to validate the result of /health with jsonschema | 00:34 |
flwang | kgriffs: good point | 00:34 |
malini | good idea | 00:35 |
kgriffs | great, lets add that test | 00:35 |
kgriffs | flwang: I was looking at https://review.openstack.org/#/c/76555/13/tests/unit/queues/storage/test_pool_queues.py | 00:35 |
malini | We can add a schema chk here https://github.com/openstack/marconi/blob/master/tests/functional/wsgi/v1_1/test_queues.py#L241 | 00:35 |
kgriffs | it has a @testing.requires_mongodb decorator | 00:35 |
kgriffs | so, it won't run in the gate | 00:36 |
flwang | ah, yes | 00:36 |
flwang | I will fix that | 00:37 |
malini | flwang: do you need help adding the schema chk? | 00:37 |
flwang | malini: I will take a look at the code and will let you know if I need your sweet support :) | 00:37 |
kgriffs | flwang: hmmm | 00:37 |
malini | flwang: cool! This is a sample schema chk https://github.com/openstack/marconi/blob/master/tests/functional/wsgi/v1_1/test_messages.py#L129 | 00:38 |
flwang | kgriffs: should we just remove it and adding jsonschema check at the functional test | 00:38 |
flwang | kgriffs: given most of the cases have been covered by unit test | 00:38 |
kgriffs | I think the ping and health tests should maybe go in | 00:39 |
kgriffs | https://github.com/openstack/marconi/tree/master/marconi/tests/queues/transport/wsgi/v1_1 | 00:39 |
flwang | https://review.openstack.org/#/c/76555/13/marconi/tests/queues/transport/wsgi/v1_1/test_health.py | 00:40 |
kgriffs | yeah | 00:41 |
kgriffs | in test_pools you could check if it is returning a list of the stats/checks by pool | 00:41 |
flwang | do you think we a need a ping test at there? | 00:41 |
kgriffs | test_pools.py | 00:41 |
kgriffs | flwang: yeah, I guess so | 00:41 |
flwang | ok, I will add that in a separate patch | 00:42 |
kgriffs | hmm, do we have a ping functional test? | 00:42 |
kgriffs | malini: btw, I was looking at this test suite: https://review.openstack.org/#/c/76555/13/tests/functional/wsgi/v1_1/test_shards.py | 00:43 |
flwang | yes, at test_queues.py | 00:43 |
kgriffs | malini: that must only run if mongo is available? | 00:43 |
kgriffs | flwang: kk | 00:43 |
flwang | should we isolate it? | 00:44 |
flwang | now the /ping test is distributed in everywhere | 00:44 |
kgriffs | so, as you can see, our tests are a bit of a mess. :p | 00:44 |
flwang | kgriffs: yep | 00:44 |
flwang | we need a more clear test structure | 00:44 |
kgriffs | refactoring / DRYing up our tests should be a major theme for Kilo. | 00:45 |
malini | kgriffs: hmmm…yes..wonder how it is getting past the gate | 00:45 |
kgriffs | malini: ok, would you mind checking into that | 00:45 |
malini | sure | 00:45 |
kgriffs | flwang: I'd be OK with doing a followup patch to improve tests | 00:45 |
flwang | malini: seems there are many test require mongo(at least we label it), but seems our gate doesn't support mongo for now, right? | 00:46 |
kgriffs | jsonschema, ensure unit tests are running in the gate for pooled stuff | 00:46 |
flwang | kgriffs: yes | 00:46 |
kgriffs | ok | 00:47 |
kgriffs | in fact, I think this entire file here | 00:48 |
kgriffs | https://review.openstack.org/#/c/76555/13/tests/unit/queues/storage/test_pool_queues.py | 00:48 |
kgriffs | should be moved to... | 00:48 |
kgriffs | https://github.com/openstack/marconi/blob/master/marconi/tests/queues/transport/wsgi/v1_1/test_pools.py | 00:48 |
flwang | yes | 00:49 |
flwang | +1 | 00:49 |
flwang | both are unit test | 00:49 |
flwang | and test_pools.py can cover more | 00:50 |
malini | srry..had to step away | 00:50 |
flwang | kgriffs: so as for my patch, I will just remove the test case in https://review.openstack.org/#/c/76555/13/tests/unit/queues/storage/test_pool_queues.py | 00:50 |
flwang | given it has been covered in https://review.openstack.org/#/c/76555/13/marconi/tests/queues/transport/wsgi/v1_1/test_health.py | 00:50 |
flwang | any concern? | 00:50 |
malini | flwang: the gate does not support mongo now AFAIK..But the tempest tests are already running with trusty | 00:50 |
kgriffs | I submitted some comments, but as I said there, we can put stuff in a followup patch if you like | 00:50 |
malini | flwang: So we might be already close to being able to run mongo (if not already) at the gate | 00:51 |
kgriffs | flwang: actually, that may be OK | 00:51 |
flwang | kgriffs: I can address your comments today and submit a patch, then hope you can +2 tonight(my night) | 00:51 |
kgriffs | because test_pools runs all the v1_1base tests | 00:52 |
kgriffs | wait... does it? | 00:52 |
* kgriffs is confusing | 00:52 | |
* kgriffs is confusing and confused | 00:52 | |
flwang | does what? | 00:52 |
flwang | seems we really have a mess test structure | 00:53 |
kgriffs | yep, you said it | 00:53 |
* peoplemerge points out cheerfully we're changing that soon | 00:54 | |
flwang | kgriffs: what's your confusion? | 00:54 |
kgriffs | I thought I remembered a patch that caused us to test everything in a pooled config | 00:55 |
kgriffs | ah, there we are | 00:55 |
kgriffs | one sec | 00:57 |
kgriffs | wait, WAH? | 00:59 |
kgriffs | https://github.com/openstack/marconi/blob/master/marconi/tests/queues/transport/wsgi/v1_1/test_messages.py#L490 | 00:59 |
kgriffs | ok, so we have a pooled test there | 00:59 |
kgriffs | this test suite is missing a sqlalchemy pool test | 00:59 |
kgriffs | but you get the idea | 00:59 |
kgriffs | flwang: it would be great to get pooled tests in that new test_health.py | 01:00 |
kgriffs | like this: | 01:00 |
kgriffs | https://github.com/openstack/marconi/blob/master/marconi/tests/queues/transport/wsgi/v1_1/test_queue_lifecycle.py#L400 | 01:00 |
kgriffs | and this | 01:00 |
kgriffs | https://github.com/openstack/marconi/blob/master/marconi/tests/queues/transport/wsgi/v1_1/test_queue_lifecycle.py#L380 | 01:00 |
flwang | meeting now, leave the message for me, sorry about that | 01:01 |
kgriffs | no problem | 01:01 |
kgriffs | I actually gotta run now too | 01:01 |
kgriffs | cheers! | 01:01 |
vkmc | ttfn, heading off for the day! :) | 01:01 |
vkmc | take care! | 01:01 |
wpf | kgriffs: ping | 01:02 |
*** vkmc has quit IRC | 01:02 | |
kgriffs | o/ | 01:03 |
kgriffs | wpf: what's up? | 01:03 |
wpf | kgriffs: for the bug https://bugs.launchpad.net/marconi/+bug/1331228 | 01:04 |
wpf | in general ,do you think uncomment the code will work ? | 01:04 |
kgriffs | yeah, I think that is OK. Since the sqlalchemy message store is just for dev/test I'm not too concerned about the performance hit. | 01:05 |
kgriffs | (of having to clean up the messages for every request) | 01:05 |
wpf | kgriffs: Ok, Thanks , then I may work on it | 01:06 |
kgriffs | looks like that code was copied from the original sqlite driver | 01:07 |
kgriffs | has the right idea, but will need to be converted to use sqla syntax | 01:08 |
kgriffs | also, I'm not sure whether we still use julianday | 01:08 |
wpf | Ok | 01:08 |
wpf | I just want to confirm the idea is right | 01:08 |
kgriffs | yep, thanks! | 01:09 |
kgriffs | gotta run now, catch everyone later | 01:09 |
wpf | thanks | 01:09 |
*** oz_akan has joined #openstack-marconi | 01:20 | |
*** kgriffs is now known as kgriffs|afk | 01:23 | |
*** nosnos has joined #openstack-marconi | 01:40 | |
*** keith_newstadt has quit IRC | 01:44 | |
*** haomaiwang has joined #openstack-marconi | 01:50 | |
*** haomaiwang has quit IRC | 01:52 | |
peoplemerge | I wanna debug a unit test I run from tox but being old-school I'd like to set a breakpoint using a debugger. Anyone here do this? | 01:52 |
*** haomaiwa_ has joined #openstack-marconi | 01:53 | |
peoplemerge | I've found sometimes when you're new to a code base you can learn things that way than trying to extrapolate universes of possibilities | 01:53 |
*** alcabrera|afk is now known as alcabrera | 01:55 | |
malini | peoplemerge: hmm..I typically use pdb with nose | 02:03 |
peoplemerge | malini: ah great! | 02:03 |
malini | interestingly sriram could not get pdb running with nose, except by using a nose plugin. | 02:04 |
malini | I never had any issues to start with..Hope you get lucky and belong to my camp :) | 02:04 |
*** haomaiw__ has joined #openstack-marconi | 02:08 | |
*** haomaiwa_ has quit IRC | 02:11 | |
*** haomaiw__ has quit IRC | 02:12 | |
*** haomaiwang has joined #openstack-marconi | 02:12 | |
*** haomaiwang has quit IRC | 02:13 | |
*** haomaiwang has joined #openstack-marconi | 02:13 | |
peoplemerge | malini: how do you actually invoke? all I can find is a path that makes local changes to setup.cfg | 02:18 |
malini | peoplemerge: invoke pdb? | 02:19 |
peoplemerge | invoke nose tests with pdb outside of tox | 02:19 |
malini | I insert 'import pdb; pdb.set_trace()' wherever I want my breakpoint to be. | 02:19 |
malini | Then run the tests with 'nosetests -sv test_****.py' | 02:20 |
malini | The test will stop wherever you have the pdb stmt inserted | 02:20 |
malini | peoplemerge: are you familiar with pdb? | 02:22 |
peoplemerge | malini: nope I'm brand new :) | 02:23 |
peoplemerge | ImportError (No module named test_messages) | 02:23 |
malini | I found this link very helpful when getting started http://pythonconquerstheuniverse.wordpress.com/category/python-debugger/ | 02:23 |
peoplemerge | malini: cool, this looks like a great quick reference. pdb feels a lot like gdb | 02:24 |
peoplemerge | if I could only tell nose which test | 02:24 |
malini | wonder why nose is not finding your test module ..where are you running the nosetests command from? | 02:25 |
peoplemerge | I tried from the base dir my gitrepo is (currently /opt/stack/marconi) as well as /opt/stack/marconi/marconi/tests/queues/transport/wsgi/v1_1 where the test is | 02:25 |
peoplemerge | (test_messages.py) | 02:25 |
malini | let me try running tht | 02:27 |
*** haomaiw__ has joined #openstack-marconi | 02:29 | |
*** prashanthr_ has joined #openstack-marconi | 02:30 | |
prashanthr_ | flwang , flaper87|afk: Good morning :) | 02:30 |
prashanthr_ | Sorry to bug you again. | 02:30 |
prashanthr_ | Can you please review this https://review.openstack.org/#/c/97178/9 whenever you are free ? | 02:30 |
malini | peoplemerge: I dont get tht importerror | 02:30 |
prashanthr_ | thanks a lot :) | 02:30 |
malini | peoplemerge: 'nosetests -sv test_messages.py' is what I am using | 02:31 |
malini | from marconi/marconi/tests/queues/transport/wsgi/v1_1 | 02:31 |
*** haomaiwang has quit IRC | 02:32 | |
peoplemerge | hey, great this is better 'ImportError: No module named fixtures' | 02:33 |
peoplemerge | /opt/stack/marconi/marconi/tests/queues/transport/wsgi/v1_1$ /home/dave/.pyenv/versions/2.7.8/bin/nosetests -sv test_messages.py | 02:33 |
peoplemerge | I figured pyenv's nosetests is more likely to find all of the modules | 02:34 |
peoplemerge | seems like tox has found a way to find everything in requirements.txt whereas nose can't | 02:34 |
malini | thts because tox will create a brand new venv | 02:36 |
malini | But with nose, we are operating based on the assumption tht all dependencies are installed | 02:36 |
malini | try creating a new venv & pip install requirements.txt & test-requirements.txt | 02:37 |
peoplemerge | malini: trying now | 02:37 |
peoplemerge | looks like I'm just about in business, thx malini !! | 02:41 |
malini | woot! | 02:41 |
* peoplemerge is out | 02:42 | |
malini | me too | 02:42 |
malini | Happy patchsets to everybody on the other side of the continent | 02:43 |
*** malini has left #openstack-marconi | 02:45 | |
flwang | malini|afk: ping | 02:59 |
*** rossk has joined #openstack-marconi | 03:02 | |
*** tongli has quit IRC | 03:03 | |
openstackgerrit | Fei Long Wang proposed a change to openstack/marconi: Rename remaining 'shard' to 'pool' https://review.openstack.org/108565 | 03:16 |
*** oz_akan has quit IRC | 03:18 | |
*** oz_akan has joined #openstack-marconi | 03:18 | |
*** oz_akan has quit IRC | 03:23 | |
openstackgerrit | A change was merged to openstack/marconi: feat(v1.1): Default TTL and grace values https://review.openstack.org/106888 | 03:23 |
*** nosnos has quit IRC | 03:40 | |
*** chandankumar has joined #openstack-marconi | 04:03 | |
*** nosnos has joined #openstack-marconi | 04:06 | |
*** shakamunyi has joined #openstack-marconi | 04:06 | |
*** shakamunyi has quit IRC | 04:08 | |
*** oz_akan has joined #openstack-marconi | 04:19 | |
*** oz_akan_ has joined #openstack-marconi | 04:21 | |
*** oz_akan has quit IRC | 04:21 | |
*** oz_akan_ has quit IRC | 04:25 | |
*** haomaiw__ has quit IRC | 04:30 | |
*** haomaiwa_ has joined #openstack-marconi | 04:31 | |
*** oz_akan has joined #openstack-marconi | 05:22 | |
*** chandankumar has quit IRC | 05:25 | |
*** oz_akan has quit IRC | 05:26 | |
*** haomaiwa_ has quit IRC | 05:30 | |
*** haomaiwang has joined #openstack-marconi | 05:30 | |
*** haomai___ has joined #openstack-marconi | 05:55 | |
*** haomaiwang has quit IRC | 05:58 | |
*** k4n0 has joined #openstack-marconi | 05:59 | |
*** haomai___ has quit IRC | 06:00 | |
*** chandankumar has joined #openstack-marconi | 06:01 | |
*** haomaiwang has joined #openstack-marconi | 06:01 | |
*** haomaiw__ has joined #openstack-marconi | 06:02 | |
*** haomaiwang has quit IRC | 06:05 | |
*** oz_akan has joined #openstack-marconi | 06:22 | |
*** oz_akan has quit IRC | 06:26 | |
*** mkoderer has joined #openstack-marconi | 06:30 | |
*** chandankumar has quit IRC | 06:39 | |
*** k4n0 has quit IRC | 07:51 | |
*** oz_akan has joined #openstack-marconi | 07:56 | |
*** oz_akan has quit IRC | 08:00 | |
*** k4n0 has joined #openstack-marconi | 08:04 | |
*** k4n0 has quit IRC | 08:32 | |
*** k4n0 has joined #openstack-marconi | 08:49 | |
*** oz_akan has joined #openstack-marconi | 08:57 | |
*** oz_akan has quit IRC | 09:01 | |
*** prashanthr_ has quit IRC | 09:08 | |
*** alcabrera is now known as alcabrera|afk | 09:18 | |
*** k4n0 has quit IRC | 09:19 | |
*** oz_akan has joined #openstack-marconi | 09:23 | |
*** openstackgerrit has quit IRC | 09:31 | |
*** openstackgerrit has joined #openstack-marconi | 09:33 | |
*** haomaiw__ has quit IRC | 09:33 | |
*** haomaiwang has joined #openstack-marconi | 09:34 | |
*** k4n0 has joined #openstack-marconi | 09:38 | |
*** flaper87|afk has quit IRC | 09:54 | |
*** flaper87|afk has joined #openstack-marconi | 09:55 | |
*** oz_akan has quit IRC | 09:55 | |
*** flaper87|afk is now known as flaper87 | 09:55 | |
*** oz_akan has joined #openstack-marconi | 09:55 | |
*** nosnos has quit IRC | 09:58 | |
*** nosnos has joined #openstack-marconi | 09:58 | |
*** oz_akan has quit IRC | 10:00 | |
*** nosnos has quit IRC | 10:03 | |
*** haomaiw__ has joined #openstack-marconi | 10:19 | |
*** haomaiwang has quit IRC | 10:23 | |
*** oz_akan has joined #openstack-marconi | 10:56 | |
*** oz_akan has quit IRC | 11:01 | |
*** nosnos has joined #openstack-marconi | 11:13 | |
*** mwagner_lap has quit IRC | 11:24 | |
*** k4n0 has quit IRC | 11:28 | |
*** nosnos has quit IRC | 11:40 | |
*** tongli has joined #openstack-marconi | 11:48 | |
*** oz_akan has joined #openstack-marconi | 11:57 | |
*** oz_akan has quit IRC | 12:01 | |
*** whenry has quit IRC | 12:06 | |
*** prashanthr_ has joined #openstack-marconi | 12:10 | |
*** stannie has quit IRC | 12:34 | |
*** sriram has joined #openstack-marconi | 12:39 | |
*** vkmc has joined #openstack-marconi | 12:43 | |
*** vkmc has quit IRC | 12:43 | |
*** vkmc has joined #openstack-marconi | 12:43 | |
*** abettadapur has joined #openstack-marconi | 12:53 | |
*** mpanetta has joined #openstack-marconi | 13:00 | |
vkmc | morning! | 13:03 |
sriram | good morning vkmc :) | 13:05 |
*** Catherine has joined #openstack-marconi | 13:05 | |
vkmc | hi sriram! how are you? | 13:06 |
sriram | I'm doing great, how is your pursuit of AMQP going? | 13:07 |
vkmc | :) | 13:07 |
vkmc | it took an unexpected turn | 13:08 |
vkmc | not a good one though | 13:08 |
sriram | oh noes. | 13:08 |
vkmc | we discussed about it with kgriffs|afk yesterday | 13:08 |
*** rwsu has joined #openstack-marconi | 13:08 | |
vkmc | without entering into details... AMQP is capable of transporting/storing binary payload | 13:09 |
vkmc | and our mongodb backend cannot storage it | 13:09 |
sriram | Oh i see. | 13:09 |
*** mpanetta has quit IRC | 13:09 | |
*** mpanetta has joined #openstack-marconi | 13:10 | |
sriram | I think I read the final part of it yesterday, something about using msgpack. | 13:10 |
vkmc | yeah, we still need a lot of planning but that would be the first approach | 13:10 |
vkmc | this bp born yesterday evening https://blueprints.launchpad.net/marconi/+spec/store-messages-as-binary | 13:11 |
vkmc | and it looks this will be dropped to K... it requires so many changes | 13:11 |
sriram | nice. | 13:15 |
vkmc | anyhow...! | 13:16 |
vkmc | and you? what are you working on currently? | 13:17 |
sriram | nothing much on marconi right now, I had setup the benchmarking cluster, and implemented the benchmarking blueprint. | 13:18 |
sriram | will take up some tasks soon :) | 13:18 |
vkmc | yes... I have 'test the benchmarking tool' in my todo list | 13:18 |
vkmc | I couldn't play with it yet | 13:18 |
vkmc | it looks great | 13:18 |
sriram | nice! | 13:19 |
sriram | so did we decide on a meeting time? | 13:19 |
vkmc | we are having the meeting at the usual time today | 13:20 |
vkmc | I guess we are going to determine the meeting time there :) | 13:21 |
sriram | cool. | 13:21 |
*** amitgandhi has joined #openstack-marconi | 13:32 | |
*** Obulpathi has joined #openstack-marconi | 13:33 | |
*** ametts has joined #openstack-marconi | 13:39 | |
*** malini has joined #openstack-marconi | 13:47 | |
*** oz_akan has joined #openstack-marconi | 13:51 | |
*** tjanczuk has joined #openstack-marconi | 13:53 | |
*** ametts has quit IRC | 13:54 | |
*** cpallares has joined #openstack-marconi | 13:54 | |
*** balajiiyer has joined #openstack-marconi | 13:57 | |
*** chandankumar has joined #openstack-marconi | 14:06 | |
*** Catherine has left #openstack-marconi | 14:07 | |
*** cpallares has quit IRC | 14:20 | |
*** russellb has joined #openstack-marconi | 14:20 | |
russellb | kgriffs|afk: o/ just checking in on juno-2, ping when you have a few minutes today | 14:21 |
malini | Can I get some reviews on https://review.openstack.org/#/c/108051/ ? | 14:28 |
*** tonytan4ever has joined #openstack-marconi | 14:33 | |
*** cpallares has joined #openstack-marconi | 14:33 | |
*** ametts has joined #openstack-marconi | 14:34 | |
cpallares | malini, you around? | 14:47 |
*** chandankumar has quit IRC | 14:48 | |
*** celttechie has joined #openstack-marconi | 14:50 | |
malini | cpallares: o/ | 14:52 |
malini | how are you? | 14:52 |
peoplemerge_ | meeting is moved right? | 14:58 |
cpallares | malini, hi! I'm doing good and you? :) are we having the meeting today or tomorrow? | 15:00 |
malini | hmmmm... | 15:00 |
vkmc | hmm | 15:00 |
malini | I thought kgriffs|afk mentioned tht we'll have the meeting at the same time, one last time | 15:00 |
vkmc | he said that | 15:01 |
malini | what do we want to do? | 15:01 |
malini | wait for kgriffs|afk for 5 min? | 15:01 |
vkmc | how many are for the meeting? | 15:03 |
* peoplemerge_ votes tomorrow | 15:03 | |
malini | so far only peoplemerge, vkmc, cpallares & malini | 15:04 |
*** chandankumar has joined #openstack-marconi | 15:07 | |
* cpallares wonders where everyone is | 15:07 | |
*** kgriffs|afk is now known as kgriffs | 15:07 | |
kgriffs | o/ | 15:07 |
kgriffs | sorry folks | 15:07 |
kgriffs | got held up this morning | 15:08 |
kgriffs | shall we meet? | 15:08 |
cpallares | lol | 15:08 |
malini | the 4 of us voted to meet tomorrow :-P | 15:08 |
malini | but kgriffs has veto powers | 15:08 |
kgriffs | ah, just saw the backlog | 15:08 |
kgriffs | what time shall we meet tomorrow? | 15:09 |
malini | are we going to have two weekly meetings or one? | 15:09 |
kgriffs | Flavio's proposal was to alternate times every week | 15:10 |
kgriffs | so one meeting each week, but alternating times | 15:10 |
malini | kgriffs: what times? | 15:12 |
kgriffs | I think one of the times should be 2100 UTC - that should work for NZ and AU | 15:14 |
kgriffs | actually... hmmm | 15:14 |
*** ametts has quit IRC | 15:17 | |
kgriffs | yeah, I think 2100 is a pretty good bet | 15:18 |
malini | ok..Let's try tht out | 15:18 |
kgriffs | 9am in NZ, 11pm in Italy, 5pm EDT right? | 15:19 |
malini | yes | 15:21 |
malini | just a warning -you might get some opinions from my 2 yr old | 15:22 |
kgriffs | heh | 15:22 |
kgriffs | ok | 15:22 |
kgriffs | I will send an email | 15:23 |
prashanthr_ | good morning all :) | 15:25 |
kgriffs | malini: by the way, any progress on this bug? https://bugs.launchpad.net/marconi/+bug/1328111 | 15:25 |
kgriffs | prashanthr_: o/ | 15:25 |
prashanthr_ | kgriffs: Can you have a look at this https://review.openstack.org/#/c/97178/9 whenever you are free ? | 15:25 |
malini | kgriffs: no, I didn't get a chance to work on tht yet | 15:26 |
malini | I will unassign myself, till I am ready to pick it up | 15:26 |
kgriffs | ok. can you also move it to juno-3 ? | 15:27 |
kgriffs | prashanthr_: yep | 15:28 |
prashanthr_ | malini: thanks for the review :) | 15:30 |
malini | prashanthr_: you are welcome..Sorry it took so long | 15:31 |
prashanthr_ | malini: No problems at all ! | 15:31 |
kgriffs | WAH?! where did my patch go? did it get merged? | 15:33 |
* kgriffs does a little dance | 15:33 | |
*** sriram has quit IRC | 15:45 | |
*** sriram has joined #openstack-marconi | 15:46 | |
*** prashanthr_ has quit IRC | 15:49 | |
*** whenry has joined #openstack-marconi | 15:53 | |
*** abettadapur has quit IRC | 16:11 | |
*** abettadapur has joined #openstack-marconi | 16:42 | |
*** tonytan4ever has quit IRC | 16:46 | |
*** whenry has quit IRC | 17:27 | |
*** itisit has joined #openstack-marconi | 17:31 | |
*** sriram has quit IRC | 17:32 | |
*** chandankumar has quit IRC | 17:34 | |
*** sriram1 has joined #openstack-marconi | 17:35 | |
* peoplemerge is in the office now | 17:37 | |
*** ametts has joined #openstack-marconi | 17:49 | |
*** cpallares has quit IRC | 17:50 | |
*** cpallares has joined #openstack-marconi | 17:51 | |
*** tonytan4ever has joined #openstack-marconi | 17:52 | |
*** cpallares has quit IRC | 18:04 | |
*** cpallares has joined #openstack-marconi | 18:17 | |
*** celttechie has quit IRC | 18:23 | |
*** whenry has joined #openstack-marconi | 18:29 | |
openstackgerrit | Kurt Griffiths proposed a change to openstack/marconi: API v1.1 - Encapsulate message post bodies in a JSON object https://review.openstack.org/108795 | 18:30 |
kgriffs | flaper87, flwang: There are a few patches with a single +2 that need another pair of eyes on them | 18:34 |
*** balajiiyer has left #openstack-marconi | 18:34 | |
*** jay-atl has quit IRC | 18:34 | |
kgriffs | https://review.openstack.org/#/q/status:open+project:openstack/marconi,n,z | 18:34 |
kgriffs | malini: ^^ | 18:34 |
kgriffs | I will be looking at the redis patch right after lunch | 18:35 |
*** kgriffs is now known as kgriffs|afk | 18:37 | |
*** malini has quit IRC | 18:40 | |
*** amitgandhi has quit IRC | 18:42 | |
*** sriram1 has quit IRC | 18:42 | |
*** amitgandhi has joined #openstack-marconi | 18:42 | |
*** sriram has joined #openstack-marconi | 18:42 | |
*** whenry has quit IRC | 18:45 | |
*** celttechie has joined #openstack-marconi | 18:49 | |
*** shakamunyi has joined #openstack-marconi | 18:56 | |
*** ametts has quit IRC | 18:59 | |
*** Catherine has joined #openstack-marconi | 19:04 | |
*** Catherine has quit IRC | 19:05 | |
*** Catherine has joined #openstack-marconi | 19:05 | |
*** Catherin_ has joined #openstack-marconi | 19:06 | |
*** Catherine has quit IRC | 19:06 | |
*** Catherin_ has quit IRC | 19:15 | |
*** malini has joined #openstack-marconi | 19:18 | |
*** malini has quit IRC | 19:20 | |
*** malini has joined #openstack-marconi | 19:20 | |
*** kgriffs|afk is now known as kgriffs | 19:22 | |
* kgriffs rolls up sleeves and get reviewin' | 19:24 | |
vkmc | https://www.youtube.com/watch?v=d65TtqGp-9Q | 19:32 |
vkmc | ykaplan \o/ | 19:33 |
*** shakamunyi has quit IRC | 19:42 | |
*** oz_akan has quit IRC | 19:59 | |
kgriffs | malini: ping | 20:02 |
*** Catherine has joined #openstack-marconi | 20:12 | |
*** alcabrera|afk is now known as alcabrera | 20:15 | |
*** mpanetta has quit IRC | 20:15 | |
*** mpanetta has joined #openstack-marconi | 20:16 | |
*** sriram has quit IRC | 20:33 | |
*** abettadapur has quit IRC | 20:37 | |
peoplemerge | vkmc: nice | 20:37 |
vkmc | peoplemerge, o/ | 20:38 |
*** amitgandhi has quit IRC | 20:59 | |
*** amitgandhi has joined #openstack-marconi | 21:11 | |
*** Catherine has left #openstack-marconi | 21:12 | |
*** amitgand_ has joined #openstack-marconi | 21:13 | |
*** amitgandhi has quit IRC | 21:16 | |
*** mpanetta has quit IRC | 21:18 | |
*** tonytan4ever has quit IRC | 21:21 | |
*** Obulpathi has quit IRC | 21:22 | |
*** balajiiyer has joined #openstack-marconi | 21:32 | |
*** shakamunyi has joined #openstack-marconi | 21:32 | |
*** balajiiyer has quit IRC | 21:34 | |
*** balajiiyer has joined #openstack-marconi | 21:34 | |
malini | kgriffs: pong | 21:38 |
kgriffs | malini: ohai | 21:48 |
kgriffs | hey, so I was reviewing the redis patch | 21:49 |
kgriffs | I was thinking we should have prashanth build up a list of dependent patches which includes all the tests. I would like to put a "WIP" block on the patch that is currently at the head of the dep. chain | 21:50 |
kgriffs | we review them in turn, and then once everyone +2's them up to and including the tests, we can remove the WIP block and let everything merge | 21:50 |
malini | tht is a good idea, as long as we block just the patch at the top of the dependency chain | 21:51 |
kgriffs | yep. | 21:52 |
kgriffs | I've heard of other projects using that strategy, and I thought it would be a good idea in this case. I just don't want to merge any more patches w/o tests | 21:52 |
malini | I am always ready for that :) | 21:52 |
kgriffs | ok, cool. first person to see prashanth next should let him know. I will also drop a comment on the "head" patch. | 21:53 |
kgriffs | sound like a plan? | 21:53 |
*** balajiiyer has left #openstack-marconi | 21:53 | |
*** alcabrera is now known as alcabrera|afk | 21:54 | |
malini | yeap! | 21:56 |
*** shakamunyi has quit IRC | 21:56 | |
*** balajiiyer1 has joined #openstack-marconi | 21:56 | |
kgriffs | cool, thanks | 21:57 |
kgriffs | :) | 21:57 |
*** tongli has quit IRC | 21:59 | |
*** rwsu has quit IRC | 22:02 | |
*** itisit has quit IRC | 22:03 | |
*** oz_akan has joined #openstack-marconi | 22:12 | |
*** amitgand_ has quit IRC | 22:22 | |
*** oz_akan has quit IRC | 22:24 | |
*** oz_akan has joined #openstack-marconi | 22:24 | |
peoplemerge | malini: pdb ++ just got it to do what I wanted... from tests/unit/queues/transport/wsgi, | 22:45 |
peoplemerge | MARCONI_TESTS_CONFIGS_DIR=/opt/stack/marconi/tests/etc /home/dave/.pyenv/versions/2.7.8/bin/nosetests -sv test_v1_1.py | 22:45 |
peoplemerge | woot! | 22:45 |
*** cpallares has quit IRC | 22:54 | |
*** malini|afk has quit IRC | 23:16 | |
kgriffs | if anyone is around, I'd love to get some eyes on this: https://review.openstack.org/#/c/108795/ | 23:30 |
kgriffs | flaper87, flwang, peoplemerge, malini, wpf: ^^^ | 23:31 |
kgriffs | I gotta run now... might be on later. Thanks! | 23:32 |
*** whenry has joined #openstack-marconi | 23:33 | |
*** balajiiyer1 has quit IRC | 23:35 | |
*** kgriffs is now known as kgriffs|afk | 23:42 | |
malini | peoplemerge: yayy!! tht is good to know | 23:55 |
malini | I recently started using ipdb, which is pretty cool too | 23:56 |
malini | you can just do tabs & it lists object attributes etc. | 23:56 |
malini | The only catch is it doesn't play well with nose | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!