| *** kazsh has quit IRC | 00:02 | |
| *** eanylin has quit IRC | 00:09 | |
| *** JawonChoo has joined #openstack-meeting-5 | 00:32 | |
| *** kazsh_ has joined #openstack-meeting-5 | 00:39 | |
| *** kazsh_ has quit IRC | 00:43 | |
| *** kazsh_ has joined #openstack-meeting-5 | 00:43 | |
| *** kazsh_ has quit IRC | 00:45 | |
| *** kazsh has joined #openstack-meeting-5 | 00:45 | |
| *** jrist has joined #openstack-meeting-5 | 00:45 | |
| *** jrist has quit IRC | 00:45 | |
| *** jrist has joined #openstack-meeting-5 | 00:45 | |
| *** kazsh has quit IRC | 00:48 | |
| *** kazsh has joined #openstack-meeting-5 | 00:48 | |
| *** kazsh has quit IRC | 00:52 | |
| *** kazsh has joined #openstack-meeting-5 | 00:58 | |
| *** kazsh has quit IRC | 00:59 | |
| *** kazsh has joined #openstack-meeting-5 | 01:00 | |
| *** wxy| has joined #openstack-meeting-5 | 01:02 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 01:15 | |
| *** eanylin has joined #openstack-meeting-5 | 01:51 | |
| *** dougbtv_ has quit IRC | 02:05 | |
| *** markvoelker has quit IRC | 02:08 | |
| *** markvoelker has joined #openstack-meeting-5 | 02:08 | |
| *** dougbtv_ has joined #openstack-meeting-5 | 02:17 | |
| *** ricolin has joined #openstack-meeting-5 | 02:26 | |
| *** ramishra has joined #openstack-meeting-5 | 02:34 | |
| *** dougbtv_ has quit IRC | 02:36 | |
| *** dougbtv_ has joined #openstack-meeting-5 | 02:39 | |
| *** dougbtv__ has joined #openstack-meeting-5 | 02:56 | |
| *** dougbtv_ has quit IRC | 02:58 | |
| *** felipemonteiro has quit IRC | 03:12 | |
| *** rarcea has joined #openstack-meeting-5 | 03:26 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 03:35 | |
| *** rarcea has quit IRC | 03:40 | |
| *** markvoelker has quit IRC | 03:56 | |
| *** markvoelker has joined #openstack-meeting-5 | 03:57 | |
| *** markvoelker has quit IRC | 04:01 | |
| *** wxy| has quit IRC | 04:04 | |
| *** dougbtv__ has quit IRC | 04:12 | |
| *** dougbtv__ has joined #openstack-meeting-5 | 04:12 | |
| *** kazsh_ has joined #openstack-meeting-5 | 04:16 | |
| *** kazsh_ has quit IRC | 04:17 | |
| *** lamt has joined #openstack-meeting-5 | 04:43 | |
| *** zenirc369 has joined #openstack-meeting-5 | 04:52 | |
| *** wxy| has joined #openstack-meeting-5 | 05:14 | |
| *** lamt has quit IRC | 05:17 | |
| *** lamt has joined #openstack-meeting-5 | 05:29 | |
| *** felipemonteiro has quit IRC | 05:37 | |
| *** lamt has quit IRC | 05:53 | |
| *** lamt has joined #openstack-meeting-5 | 06:13 | |
| *** LanceHaig has joined #openstack-meeting-5 | 06:17 | |
| *** lamt has quit IRC | 06:26 | |
| *** skazi has joined #openstack-meeting-5 | 06:41 | |
| *** ralonsoh has joined #openstack-meeting-5 | 06:50 | |
| *** matrohon has joined #openstack-meeting-5 | 06:52 | |
| *** LanceHaig has quit IRC | 07:09 | |
| *** aarefiev_afk is now known as aarefiev | 08:16 | |
| *** derekh has joined #openstack-meeting-5 | 08:45 | |
| *** wxy| has quit IRC | 09:03 | |
| *** wxy| has joined #openstack-meeting-5 | 09:04 | |
| *** wxy| has quit IRC | 09:06 | |
| *** wxy| has joined #openstack-meeting-5 | 09:18 | |
| *** JawonChoo has quit IRC | 09:19 | |
| *** wxy| has quit IRC | 09:36 | |
| *** skazi_ has quit IRC | 09:38 | |
| *** skazi has quit IRC | 09:39 | |
| *** LanceHaig has joined #openstack-meeting-5 | 09:48 | |
| *** LanceHaig has quit IRC | 09:56 | |
| *** LanceHaig has joined #openstack-meeting-5 | 10:44 | |
| *** LanceHaig has quit IRC | 11:23 | |
| *** zenirc369 has quit IRC | 11:37 | |
| *** zenirc369 has joined #openstack-meeting-5 | 11:53 | |
| *** matrohon has quit IRC | 12:01 | |
| *** markvoelker has joined #openstack-meeting-5 | 12:23 | |
| *** skazi has joined #openstack-meeting-5 | 12:33 | |
| *** skazi_ has joined #openstack-meeting-5 | 12:36 | |
| *** LanceHaig has joined #openstack-meeting-5 | 12:39 | |
| *** jrist has quit IRC | 12:45 | |
| *** LanceHaig has quit IRC | 12:49 | |
| *** LanceHaig has joined #openstack-meeting-5 | 12:52 | |
| *** lamt has joined #openstack-meeting-5 | 12:53 | |
| *** LanceHaig has quit IRC | 12:54 | |
| *** jrist has joined #openstack-meeting-5 | 13:14 | |
| *** eanylin has quit IRC | 13:30 | |
| *** eanylin has joined #openstack-meeting-5 | 13:44 | |
| *** lamt has quit IRC | 13:52 | |
| *** felipemonteiro has joined #openstack-meeting-5 | 14:06 | |
| *** rarcea has joined #openstack-meeting-5 | 14:07 | |
| *** felipemonteiro_ has joined #openstack-meeting-5 | 14:09 | |
| *** felipemonteiro__ has joined #openstack-meeting-5 | 14:12 | |
| *** felipemonteiro has quit IRC | 14:12 | |
| *** krtaylor has quit IRC | 14:13 | |
| *** felipemonteiro_ has quit IRC | 14:15 | |
| *** zenirc369 has quit IRC | 14:30 | |
| *** eanylin has left #openstack-meeting-5 | 14:31 | |
| *** zenirc369 has joined #openstack-meeting-5 | 14:32 | |
| *** LanceHaig has joined #openstack-meeting-5 | 14:33 | |
| *** zenirc369 has quit IRC | 14:37 | |
| *** krtaylor has joined #openstack-meeting-5 | 14:42 | |
| *** krtaylor has quit IRC | 14:44 | |
| *** krtaylor has joined #openstack-meeting-5 | 14:48 | |
| *** lamt has joined #openstack-meeting-5 | 15:11 | |
| *** aarefiev is now known as aarefiev_afk | 15:15 | |
| *** dougbtv__ is now known as dougbtv | 15:18 | |
| *** mjturek has joined #openstack-meeting-5 | 15:30 | |
| *** matrohon has joined #openstack-meeting-5 | 15:40 | |
| *** dtantsur has joined #openstack-meeting-5 | 15:51 | |
| *** hshiina has joined #openstack-meeting-5 | 15:52 | |
| *** phuongnh has joined #openstack-meeting-5 | 15:57 | |
| TheJulia | o/ | 16:00 |
|---|---|---|
| dtantsur | o/ | 16:00 |
| TheJulia | #startmeeting ironic_bfv | 16:00 |
| openstack | Meeting started Thu May 18 16:00:45 2017 UTC and is due to finish in 60 minutes. The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| *** openstack changes topic to " (Meeting topic: ironic_bfv)" | 16:00 | |
| openstack | The meeting name has been set to 'ironic_bfv' | 16:00 |
| derekh | o/ | 16:00 |
| hshiina | o/ | 16:01 |
| TheJulia | Our agenda, as always https://wiki.openstack.org/wiki/Meetings/Ironic-BFV | 16:01 |
| TheJulia | #link https://wiki.openstack.org/wiki/Meetings/Ironic-BFV | 16:01 |
| mjturek | o/ | 16:01 |
| TheJulia | #topic Announcements/Reminders | 16:01 |
| *** openstack changes topic to "Announcements/Reminders (Meeting topic: ironic_bfv)" | 16:01 | |
| TheJulia | The only thing that I really have is that I want to apologize for being insanely busy the last few weeks. | 16:02 |
| mjturek | no worries TheJulia | 16:02 |
| TheJulia | Anyone have any announcements? | 16:03 |
| hshiina | TheJulia, never mind | 16:03 |
| mjturek | cinder driver is close to merging | 16:03 |
| TheJulia | \o/ | 16:03 |
| mjturek | we might need to do a follow up | 16:03 |
| mjturek | thanks for all your help hshiina and TheJulia | 16:03 |
| TheJulia | I saw, I noticed the boolean != none comments. Thank you hshiina! | 16:04 |
| hshiina | mjturek, TheJulia you're welcome | 16:04 |
| TheJulia | Well, I guess we are safe to move on! | 16:04 |
| dtantsur | I'd really, really like the patches to be smaller than this one | 16:04 |
| dtantsur | it's hard to review and it has A LOT of unit tests | 16:05 |
| mjturek | yeaaah understandable | 16:05 |
| TheJulia | #topic Current Status | 16:05 |
| *** openstack changes topic to "Current Status (Meeting topic: ironic_bfv)" | 16:05 | |
| TheJulia | Yeah, the tests are kind of... long. :( | 16:05 |
| TheJulia | I think that one is the worst patch length wise | 16:06 |
| TheJulia | FWIW | 16:06 |
| TheJulia | #link https://etherpad.openstack.org/p/Ironic-BFV | 16:06 |
| mjturek | there's a lot of redundancy in setup for each test, might be able to reduce that if it's something people want | 16:06 |
| mjturek | but might not be worth it at this point | 16:07 |
| TheJulia | Perhaps a follow-up might be good for that... | 16:07 |
| dtantsur | yeah, let's finally approve it and move on :) | 16:07 |
| mjturek | cool cool :) | 16:07 |
| dtantsur | I won't survive reviewing it again :) | 16:07 |
| mjturek | hahaha | 16:07 |
| TheJulia | Looking through the statuses, looks like it is up to date | 16:07 |
| TheJulia | It looks like some rebasing needs to be performed, and I need to update the deploy skip patch, I'll likely get to that while I'm in the air tomorrow. | 16:09 |
| *** tiendc has joined #openstack-meeting-5 | 16:09 | |
| TheJulia | Sorry I didn't get to it this week :( | 16:09 |
| TheJulia | I guess aside from getting the current rev landed and moving on to the next one, things look okay | 16:10 |
| TheJulia | Minor correction, there is -1 on a prior rev of https://review.openstack.org/#/c/413324/ that needs to be looked at and addressed. It was since rebased but not updated. | 16:11 |
| TheJulia | I've updated the ether pad. | 16:11 |
| TheJulia | Moving on... | 16:12 |
| mjturek | Yuriy's? | 16:12 |
| TheJulia | #topic Planning/Priorities | 16:12 |
| *** openstack changes topic to "Planning/Priorities (Meeting topic: ironic_bfv)" | 16:12 | |
| TheJulia | mjturek: yes | 16:12 |
| mjturek | ok cool | 16:12 |
| TheJulia | Next up is https://review.openstack.org/#/c/406290/ | 16:13 |
| TheJulia | I just clicked the rebase button | 16:13 |
| TheJulia | (and it worked \o/) | 16:13 |
| mjturek | yaaay | 16:13 |
| TheJulia | #info Next patch is https://review.openstack.org/#/c/406290/ | 16:13 |
| * dtantsur wonders who we can drag into reviewing the cinder driver patch | 16:14 | |
| TheJulia | dtantsur: technically I shouldn't, but the code has morphed quite a bit from the first rev. I guess I can at least give it a thumbs up from my point of view | 16:14 |
| dtantsur | fair enough | 16:15 |
| TheJulia | I'll look through the ones I've not touched recently that Joanna worked on and comment as such in the comments. | 16:15 |
| hshiina | cinder driver patch depends on it: https://review.openstack.org/#/c/460250/ | 16:16 |
| hshiina | it also needs review | 16:16 |
| mjturek | oh right | 16:16 |
| * dtantsur puts on his backlog | 16:16 | |
| TheJulia | hshiina: Thank you for raising that | 16:17 |
| TheJulia | #info https://review.openstack.org/#/c/460250/ is required for the cinder driver to land. | 16:17 |
| TheJulia | Beyond that, does anyone have any priorities or items that may be priorities that they wish to raise? | 16:18 |
| *** zenirc369 has joined #openstack-meeting-5 | 16:18 | |
| TheJulia | hshiina: Could you update the list order in the etherpad for the revision you pointed out? For some reason it is not working for me right now. | 16:19 |
| hshiina | TheJulia, sure | 16:19 |
| TheJulia | Thank you | 16:19 |
| derekh | there are a few patches that could do with an update, that depend on old versions of parent patches | 16:20 |
| derekh | I think this is the list and revision numbers they depend on http://paste.openstack.org/show/609943/ | 16:20 |
| *** matrohon has quit IRC | 16:21 | |
| TheJulia | derekh: Indeed, it would be a good time to rebase the outstanding ones that have few reviews right now. | 16:21 |
| joanna | o/ | 16:23 |
| TheJulia | mjturek: I clicked the button on the storage attach/detach ops, are you going to look at the ipxe template updates? | 16:23 |
| TheJulia | greetings joanna | 16:23 |
| joanna | :) | 16:23 |
| mjturek | TheJulia: sure, I'll take a look | 16:23 |
| TheJulia | mjturek: Awesome. I'll take care of the WIP one in the next few days and hopefully parent wise we should be in a fairly good position aside from client revisions | 16:24 |
| TheJulia | Anyway, I think we've covered priorities and plans for the next week or so, If there is nothing else anyone has to raise, then we can move on to discussion. | 16:25 |
| mjturek | sounds good | 16:25 |
| TheJulia | #topic Discussion | 16:25 |
| *** openstack changes topic to "Discussion (Meeting topic: ironic_bfv)" | 16:25 | |
| TheJulia | mjturek: You have two items it looks like. | 16:25 |
| mjturek | so dtantsur raised two good questions I'd like to discuss | 16:26 |
| * mjturek grabs the first one | 16:26 | |
| mjturek | https://review.openstack.org/#/c/366197/45/ironic/drivers/modules/storage/cinder.py@210 | 16:26 |
| mjturek | #link https://review.openstack.org/#/c/366197/45/ironic/drivers/modules/storage/cinder.py@210 | 16:26 |
| mjturek | it seems that non-BFV deployment might be clobbered if no targets are defined in this case | 16:27 |
| mjturek | should we be checking if no targets are defined and another storage interface is available? | 16:28 |
| TheJulia | So... validate would need to be called by nova | 16:28 |
| TheJulia | or the deployment (I think) (it is getting a little fuzzy at this point) | 16:29 |
| TheJulia | but it is a good point, they shouldn't be clobbered if it is not explicitly bfv | 16:29 |
| mjturek | cool | 16:29 |
| dtantsur | I'm just checking that it's intended if storage_interface=cinder and iscsi_boot=True, then a node fails storage validation if used without connectors | 16:29 |
| TheJulia | I think it needs an extra check | 16:29 |
| TheJulia | for that there actually are connectors | 16:30 |
| mjturek | multiple storage interfaces can be available right? | 16:30 |
| TheJulia | One per node | 16:30 |
| TheJulia | so yeah, I think it is just an extra conditional. | 16:30 |
| mjturek | ahh, so should a node with cinder as the storage_interface be allowed to do non-BFV deployment? | 16:30 |
| mjturek | I would've thought no | 16:31 |
| dtantsur | yeah, this is my question ^^^ | 16:31 |
| dtantsur | and if the answer is "no", how do we tell nova about that? | 16:31 |
| TheJulia | No, it should be possible | 16:31 |
| TheJulia | We're doing whatever nova has requested, so nova does need to call validate, but at the same time validate only needs to trigger if there are actually connectors | 16:32 |
| TheJulia | err | 16:32 |
| TheJulia | not connectors | 16:32 |
| TheJulia | targets | 16:32 |
| TheJulia | it is okay to have connectors | 16:32 |
| dtantsur | so what's the expected logic? | 16:32 |
| dtantsur | should we just drop that check? | 16:32 |
| TheJulia | Oh you know what | 16:34 |
| TheJulia | That catches a general misconfiguration on the node | 16:35 |
| TheJulia | sorry for the slow responses, juggling a conference call as well | 16:37 |
| dtantsur | I hear you, I have an API-WG meeting in parallel (just finished though) | 16:37 |
| TheJulia | If the node has the capability configured to iscsi boot, has a cinder storage interface conjured, but no connector info, then a deployment should fail. What we should do is also add targets to be checked, I think. | 16:38 |
| TheJulia | I may have broken it in two parts on purpose, I just don't remember right now | 16:38 |
| dtantsur | aha, and we expect nova to set the targets, so this should not be a problem, right? | 16:38 |
| TheJulia | Anyway, I'll look at and reply in depth | 16:38 |
| TheJulia | dtantsur: exactly | 16:39 |
| mjturek | ohhh | 16:39 |
| dtantsur | ok, I think I start to understand | 16:39 |
| mjturek | alright cool | 16:40 |
| TheJulia | I think were in a good place there | 16:40 |
| TheJulia | Next question? | 16:40 |
| mjturek | https://review.openstack.org/#/c/366197/40/ironic/drivers/modules/storage/cinder.py@232 | 16:40 |
| mjturek | there've been a couple comments saying that _abort_attach_volume should be replaced with detach_volumes | 16:41 |
| mjturek | the main difference seems to be the error handling and how many retries we do | 16:41 |
| mjturek | so if we want to use action retries here, I think that's more fuel to drop the function and call self.detach_volumes instead | 16:42 |
| TheJulia | I can agree with that :) | 16:42 |
| mjturek | so is there any reason we would only want to retry once here? | 16:43 |
| dtantsur | well, if there is no use retrying? | 16:43 |
| dtantsur | like e.g. cinder is down | 16:43 |
| dtantsur | not sure if it's a popular case though | 16:43 |
| mjturek | alright, well in follow up I'll propose removing it | 16:44 |
| mjturek | that sound good? | 16:45 |
| TheJulia | Sounds good to me | 16:45 |
| dtantsur | just make sure we still catch exceptions (to avoid masking the initial one) | 16:45 |
| mjturek | ack :) | 16:45 |
| mjturek | I'm good unless people have anything else! | 16:46 |
| * dtantsur hopes we finally land that patch | 16:46 | |
| TheJulia | I don't, just trying to remember why the retry detach logic | 16:46 |
| TheJulia | I'm sure it will come to me at 3am | 16:47 |
| mjturek | hahaha | 16:47 |
| dtantsur | that's how it works | 16:47 |
| TheJulia | #topic Open Discussion | 16:48 |
| *** openstack changes topic to "Open Discussion (Meeting topic: ironic_bfv)" | 16:48 | |
| TheJulia | Anything else to chat about today? | 16:48 |
| dtantsur | not from me | 16:48 |
| mjturek | i'm good :) | 16:48 |
| TheJulia | Awesome! | 16:48 |
| TheJulia | Thank you everyone! | 16:49 |
| mjturek | thanks all, ttyl | 16:49 |
| hshiina | thanks | 16:49 |
| TheJulia | #endmeeting | 16:49 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings" | 16:49 | |
| openstack | Meeting ended Thu May 18 16:49:23 2017 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:49 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/ironic_bfv/2017/ironic_bfv.2017-05-18-16.00.html | 16:49 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/ironic_bfv/2017/ironic_bfv.2017-05-18-16.00.txt | 16:49 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/ironic_bfv/2017/ironic_bfv.2017-05-18-16.00.log.html | 16:49 |
| *** ricolin has quit IRC | 16:49 | |
| *** dtantsur has left #openstack-meeting-5 | 16:49 | |
| *** hshiina has left #openstack-meeting-5 | 16:49 | |
| *** tiendc has quit IRC | 16:50 | |
| *** derekh has quit IRC | 16:58 | |
| *** ralonsoh has quit IRC | 17:00 | |
| *** zenirc369 has quit IRC | 17:09 | |
| *** phuongnh has quit IRC | 17:18 | |
| *** zenirc369 has joined #openstack-meeting-5 | 18:17 | |
| *** markvoelker has quit IRC | 18:19 | |
| *** markvoelker has joined #openstack-meeting-5 | 18:20 | |
| *** markvoelker has quit IRC | 18:24 | |
| *** marst has joined #openstack-meeting-5 | 18:32 | |
| *** lamt has quit IRC | 18:39 | |
| *** lamt has joined #openstack-meeting-5 | 18:42 | |
| *** zenirc369 has quit IRC | 19:23 | |
| *** krtaylor has quit IRC | 19:33 | |
| *** krtaylor has joined #openstack-meeting-5 | 19:37 | |
| *** krtaylor has quit IRC | 19:40 | |
| *** krtaylor has joined #openstack-meeting-5 | 19:41 | |
| *** dougbtv_ has joined #openstack-meeting-5 | 19:41 | |
| *** dougbtv has quit IRC | 19:41 | |
| *** dougbtv__ has joined #openstack-meeting-5 | 19:46 | |
| *** lamt has quit IRC | 19:49 | |
| *** dougbtv_ has quit IRC | 19:49 | |
| *** lamt has joined #openstack-meeting-5 | 19:51 | |
| *** leifmadsen has left #openstack-meeting-5 | 20:08 | |
| *** krtaylor has quit IRC | 20:34 | |
| *** ramishra has quit IRC | 20:40 | |
| *** jrist has quit IRC | 20:42 | |
| *** dougbtv__ has quit IRC | 20:45 | |
| *** rarcea has quit IRC | 20:46 | |
| *** jrist has joined #openstack-meeting-5 | 20:56 | |
| *** dougbtv__ has joined #openstack-meeting-5 | 20:58 | |
| *** dougbtv__ is now known as dougbtv | 20:58 | |
| *** dougbtv_ has joined #openstack-meeting-5 | 21:02 | |
| *** dougbtv has quit IRC | 21:05 | |
| *** dougbtv__ has joined #openstack-meeting-5 | 21:05 | |
| *** dougbtv_ has quit IRC | 21:07 | |
| *** dougbtv_ has joined #openstack-meeting-5 | 21:11 | |
| *** dougbtv has joined #openstack-meeting-5 | 21:13 | |
| *** dougbtv__ has quit IRC | 21:14 | |
| *** dougbtv_ has quit IRC | 21:15 | |
| *** jrist has quit IRC | 21:15 | |
| *** dougbtv_ has joined #openstack-meeting-5 | 21:16 | |
| *** dougbtv has quit IRC | 21:19 | |
| *** ramishra has joined #openstack-meeting-5 | 21:59 | |
| *** ramishra has quit IRC | 22:27 | |
| *** lamt has quit IRC | 23:14 | |
| *** lamt has joined #openstack-meeting-5 | 23:14 | |
| *** lamt has quit IRC | 23:22 | |
| *** felipemonteiro__ has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!