*** diablo_rojo has quit IRC | 00:00 | |
*** shaohe_feng has quit IRC | 00:02 | |
*** shaohe_feng has joined #openstack-meeting-alt | 00:04 | |
*** rcernin_ has joined #openstack-meeting-alt | 00:04 | |
*** rcernin has quit IRC | 00:04 | |
*** dtrainor has joined #openstack-meeting-alt | 00:07 | |
*** dalgaaf has quit IRC | 00:07 | |
*** dalgaaf has joined #openstack-meeting-alt | 00:09 | |
*** shaohe_feng has quit IRC | 00:13 | |
*** shaohe_feng has joined #openstack-meeting-alt | 00:13 | |
*** shaohe_feng has quit IRC | 00:23 | |
*** shaohe_feng has joined #openstack-meeting-alt | 00:24 | |
*** shaohe_feng has quit IRC | 00:33 | |
*** shaohe_feng has joined #openstack-meeting-alt | 00:34 | |
*** fnaval has quit IRC | 00:43 | |
*** shaohe_feng has quit IRC | 00:43 | |
*** shaohe_feng has joined #openstack-meeting-alt | 00:44 | |
*** hongbin has joined #openstack-meeting-alt | 00:44 | |
*** shaohe_feng has quit IRC | 00:54 | |
*** liuyulong_ has quit IRC | 00:54 | |
*** liuyulong_ has joined #openstack-meeting-alt | 00:54 | |
*** shaohe_feng has joined #openstack-meeting-alt | 00:55 | |
*** hongbin_ has joined #openstack-meeting-alt | 00:56 | |
*** jiaopengju has joined #openstack-meeting-alt | 00:56 | |
*** jiaopeng_ has joined #openstack-meeting-alt | 00:56 | |
*** hongbin has quit IRC | 00:58 | |
*** shaohe_feng has quit IRC | 01:04 | |
*** shaohe_feng has joined #openstack-meeting-alt | 01:06 | |
*** hiro-kobayashi has joined #openstack-meeting-alt | 01:08 | |
*** shaohe_feng has quit IRC | 01:14 | |
*** shaohe_feng has joined #openstack-meeting-alt | 01:16 | |
*** shaohe_feng has quit IRC | 01:24 | |
*** shaohe_feng has joined #openstack-meeting-alt | 01:25 | |
*** shaohe_feng has quit IRC | 01:35 | |
*** shaohe_feng has joined #openstack-meeting-alt | 01:37 | |
*** liuyulong_ is now known as liuyulong | 01:42 | |
*** hongbin_ has quit IRC | 01:45 | |
*** hongbin has joined #openstack-meeting-alt | 01:45 | |
*** shaohe_feng has quit IRC | 01:45 | |
*** shaohe_feng has joined #openstack-meeting-alt | 01:46 | |
*** diablo_rojo has joined #openstack-meeting-alt | 01:46 | |
*** yamahata has quit IRC | 01:54 | |
*** shaohe_feng has quit IRC | 01:55 | |
*** iyamahat_ has quit IRC | 01:56 | |
*** lei-zh has joined #openstack-meeting-alt | 01:56 | |
*** shaohe_feng has joined #openstack-meeting-alt | 01:57 | |
*** lei-zh has quit IRC | 01:59 | |
*** lei-zh has joined #openstack-meeting-alt | 01:59 | |
*** lei-zh has quit IRC | 01:59 | |
*** lei-zh has joined #openstack-meeting-alt | 02:00 | |
*** lei-zh has quit IRC | 02:01 | |
*** jiaopeng_ has quit IRC | 02:01 | |
*** lei-zh has joined #openstack-meeting-alt | 02:01 | |
*** jiaopeng_ has joined #openstack-meeting-alt | 02:02 | |
*** cloudrancher has quit IRC | 02:02 | |
*** cloudrancher has joined #openstack-meeting-alt | 02:04 | |
*** shaohe_feng has quit IRC | 02:05 | |
*** dave-mccowan has joined #openstack-meeting-alt | 02:07 | |
*** shaohe_feng has joined #openstack-meeting-alt | 02:09 | |
*** tetsuro has joined #openstack-meeting-alt | 02:12 | |
*** shaohe_feng has quit IRC | 02:16 | |
*** shaohe_feng has joined #openstack-meeting-alt | 02:16 | |
*** dave-mcc_ has joined #openstack-meeting-alt | 02:24 | |
*** dave-mccowan has quit IRC | 02:25 | |
*** shaohe_feng has quit IRC | 02:26 | |
*** shaohe_feng has joined #openstack-meeting-alt | 02:27 | |
*** weshay has quit IRC | 02:30 | |
*** kzaitsev_pi has quit IRC | 02:30 | |
*** rasca has quit IRC | 02:31 | |
*** rnoriega has quit IRC | 02:31 | |
*** rasca has joined #openstack-meeting-alt | 02:32 | |
*** rnoriega has joined #openstack-meeting-alt | 02:32 | |
*** weshay has joined #openstack-meeting-alt | 02:32 | |
*** shaohe_feng has quit IRC | 02:36 | |
*** shaohe_feng has joined #openstack-meeting-alt | 02:37 | |
*** diablo_rojo has quit IRC | 02:42 | |
*** shaohe_feng has quit IRC | 02:46 | |
*** shaohe_feng has joined #openstack-meeting-alt | 02:47 | |
*** diablo_rojo has joined #openstack-meeting-alt | 02:48 | |
*** brault has quit IRC | 02:53 | |
*** brault has joined #openstack-meeting-alt | 02:56 | |
*** lei-zh has quit IRC | 02:57 | |
*** shaohe_feng has quit IRC | 02:57 | |
*** lei-zh has joined #openstack-meeting-alt | 02:57 | |
*** shaohe_feng has joined #openstack-meeting-alt | 02:57 | |
*** lbragstad has quit IRC | 03:05 | |
*** shaohe_feng has quit IRC | 03:07 | |
*** shaohe_feng has joined #openstack-meeting-alt | 03:08 | |
*** shaohe_feng has quit IRC | 03:17 | |
*** shaohe_feng has joined #openstack-meeting-alt | 03:19 | |
*** markstur_ has quit IRC | 03:20 | |
*** lei-zh has quit IRC | 03:23 | |
*** lei-zh has joined #openstack-meeting-alt | 03:23 | |
*** janki has joined #openstack-meeting-alt | 03:25 | |
*** shaohe_feng has quit IRC | 03:27 | |
*** shaohe_feng has joined #openstack-meeting-alt | 03:30 | |
*** dave-mcc_ has quit IRC | 03:30 | |
*** janki has quit IRC | 03:31 | |
*** janki has joined #openstack-meeting-alt | 03:35 | |
*** shaohe_feng has quit IRC | 03:38 | |
*** diablo_rojo has quit IRC | 03:40 | |
*** shaohe_feng has joined #openstack-meeting-alt | 03:40 | |
*** shaohe_feng has quit IRC | 03:48 | |
*** lpetrut has joined #openstack-meeting-alt | 03:49 | |
*** shaohe_feng has joined #openstack-meeting-alt | 03:49 | |
*** shaohe_feng has quit IRC | 03:58 | |
*** shaohe_feng has joined #openstack-meeting-alt | 03:59 | |
*** hongbin has quit IRC | 04:08 | |
*** shaohe_feng has quit IRC | 04:08 | |
*** shaohe_feng has joined #openstack-meeting-alt | 04:09 | |
*** shaohe_feng has quit IRC | 04:19 | |
*** shaohe_feng has joined #openstack-meeting-alt | 04:21 | |
*** brault has quit IRC | 04:21 | |
*** brault has joined #openstack-meeting-alt | 04:22 | |
*** shaohe_feng has quit IRC | 04:29 | |
*** shaohe_feng has joined #openstack-meeting-alt | 04:30 | |
*** jchhatbar has joined #openstack-meeting-alt | 04:31 | |
*** janki has quit IRC | 04:31 | |
*** jchhatbar has quit IRC | 04:32 | |
*** jchhatbar has joined #openstack-meeting-alt | 04:33 | |
*** chyka has joined #openstack-meeting-alt | 04:36 | |
*** lpetrut has quit IRC | 04:39 | |
*** shaohe_feng has quit IRC | 04:39 | |
*** chyka has quit IRC | 04:40 | |
*** shaohe_feng has joined #openstack-meeting-alt | 04:40 | |
*** lei-zh has quit IRC | 04:48 | |
*** shaohe_feng has quit IRC | 04:49 | |
*** shaohe_feng has joined #openstack-meeting-alt | 04:53 | |
*** shaohe_feng has quit IRC | 05:00 | |
*** shaohe_feng has joined #openstack-meeting-alt | 05:01 | |
*** lei-zh has joined #openstack-meeting-alt | 05:06 | |
*** shaohe_feng has quit IRC | 05:10 | |
*** shaohe_feng has joined #openstack-meeting-alt | 05:11 | |
*** e0ne has joined #openstack-meeting-alt | 05:18 | |
*** tetsuro has quit IRC | 05:19 | |
*** shaohe_feng has quit IRC | 05:20 | |
*** e0ne has quit IRC | 05:20 | |
*** tetsuro has joined #openstack-meeting-alt | 05:22 | |
*** shaohe_feng has joined #openstack-meeting-alt | 05:22 | |
*** sridharg has joined #openstack-meeting-alt | 05:24 | |
*** rcernin_ has quit IRC | 05:25 | |
*** rcernin has joined #openstack-meeting-alt | 05:26 | |
*** markstur has joined #openstack-meeting-alt | 05:28 | |
*** shaohe_feng has quit IRC | 05:30 | |
*** shaohe_feng has joined #openstack-meeting-alt | 05:31 | |
*** lei-zh has quit IRC | 05:33 | |
*** links has joined #openstack-meeting-alt | 05:33 | |
*** lei-zh has joined #openstack-meeting-alt | 05:35 | |
*** shaohe_feng has quit IRC | 05:41 | |
*** shaohe_feng has joined #openstack-meeting-alt | 05:42 | |
*** markstur has quit IRC | 05:47 | |
*** shaohe_feng has quit IRC | 05:51 | |
*** shaohe_feng has joined #openstack-meeting-alt | 05:52 | |
*** mjura has joined #openstack-meeting-alt | 05:53 | |
*** lei-zh1 has joined #openstack-meeting-alt | 05:57 | |
*** lei-zh has quit IRC | 05:58 | |
*** alex_xu has quit IRC | 05:59 | |
*** shaohe_feng has quit IRC | 06:01 | |
*** shaohe_feng has joined #openstack-meeting-alt | 06:02 | |
*** alex_xu has joined #openstack-meeting-alt | 06:02 | |
*** lei-zh- has joined #openstack-meeting-alt | 06:05 | |
*** lei-zh1 has quit IRC | 06:06 | |
*** shaohe_feng has quit IRC | 06:11 | |
*** janki has joined #openstack-meeting-alt | 06:14 | |
*** jchhatbar has quit IRC | 06:14 | |
*** shaohe_feng has joined #openstack-meeting-alt | 06:14 | |
*** janki has quit IRC | 06:15 | |
*** shaohe_feng has quit IRC | 06:22 | |
*** shaohe_feng has joined #openstack-meeting-alt | 06:22 | |
*** shaohe_feng has quit IRC | 06:32 | |
*** shaohe_feng has joined #openstack-meeting-alt | 06:33 | |
*** alex_xu has quit IRC | 06:36 | |
*** alex_xu has joined #openstack-meeting-alt | 06:36 | |
*** lei-zh- has quit IRC | 06:38 | |
*** shaohe_feng has quit IRC | 06:42 | |
*** lei-zh has joined #openstack-meeting-alt | 06:42 | |
*** shaohe_feng has joined #openstack-meeting-alt | 06:44 | |
*** kopecmartin has joined #openstack-meeting-alt | 06:45 | |
*** tesseract has joined #openstack-meeting-alt | 06:48 | |
*** lpetrut has joined #openstack-meeting-alt | 06:50 | |
*** shaohe_feng has quit IRC | 06:52 | |
*** lei-zh has quit IRC | 06:53 | |
*** shaohe_feng has joined #openstack-meeting-alt | 06:53 | |
*** lei-zh has joined #openstack-meeting-alt | 06:53 | |
*** ttsiouts has joined #openstack-meeting-alt | 06:55 | |
*** lei-zh has quit IRC | 07:01 | |
*** lei-zh has joined #openstack-meeting-alt | 07:01 | |
*** yamamoto has joined #openstack-meeting-alt | 07:02 | |
*** shaohe_feng has quit IRC | 07:03 | |
*** pgadiya has joined #openstack-meeting-alt | 07:03 | |
*** pgadiya has quit IRC | 07:03 | |
*** shaohe_feng has joined #openstack-meeting-alt | 07:03 | |
*** peereb has joined #openstack-meeting-alt | 07:04 | |
*** jcoufal has joined #openstack-meeting-alt | 07:09 | |
*** ccamacho has joined #openstack-meeting-alt | 07:09 | |
*** rcernin has quit IRC | 07:11 | |
*** shaohe_feng has quit IRC | 07:13 | |
*** shaohe_feng has joined #openstack-meeting-alt | 07:14 | |
*** kzaitsev_pi has joined #openstack-meeting-alt | 07:17 | |
*** ttsiouts has quit IRC | 07:20 | |
*** shaohe_feng has quit IRC | 07:23 | |
*** shaohe_feng has joined #openstack-meeting-alt | 07:25 | |
*** rdopiera has joined #openstack-meeting-alt | 07:26 | |
*** rdopiera has quit IRC | 07:30 | |
*** rdopiera has joined #openstack-meeting-alt | 07:31 | |
*** shaohe_feng has quit IRC | 07:33 | |
*** shaohe_feng has joined #openstack-meeting-alt | 07:35 | |
*** shaohe_feng has quit IRC | 07:44 | |
*** florianf has joined #openstack-meeting-alt | 07:46 | |
*** florianf has quit IRC | 07:47 | |
*** florianf has joined #openstack-meeting-alt | 07:47 | |
*** shaohe_feng has joined #openstack-meeting-alt | 07:47 | |
*** rfolco__ has joined #openstack-meeting-alt | 07:47 | |
*** alexchadin has joined #openstack-meeting-alt | 07:49 | |
*** rfolco_ has quit IRC | 07:50 | |
*** yamahata has joined #openstack-meeting-alt | 07:53 | |
*** shaohe_feng has quit IRC | 07:54 | |
*** derekh has joined #openstack-meeting-alt | 07:55 | |
*** shaohe_feng has joined #openstack-meeting-alt | 07:55 | |
*** ttsiouts has joined #openstack-meeting-alt | 07:59 | |
*** shaohe_feng has quit IRC | 08:04 | |
*** e0ne has joined #openstack-meeting-alt | 08:05 | |
*** iyamahat has joined #openstack-meeting-alt | 08:05 | |
*** shaohe_feng has joined #openstack-meeting-alt | 08:05 | |
*** bfernando has joined #openstack-meeting-alt | 08:06 | |
*** PagliaccisCloud has quit IRC | 08:07 | |
*** PagliaccisCloud has joined #openstack-meeting-alt | 08:09 | |
*** iyamahat has quit IRC | 08:09 | |
*** hiro-kobayashi has quit IRC | 08:11 | |
*** chyka has joined #openstack-meeting-alt | 08:12 | |
*** shaohe_feng has quit IRC | 08:14 | |
*** shaohe_feng has joined #openstack-meeting-alt | 08:15 | |
*** ttsiouts has quit IRC | 08:16 | |
*** chyka has quit IRC | 08:16 | |
*** ttsiouts has joined #openstack-meeting-alt | 08:19 | |
*** shaohe_feng has quit IRC | 08:25 | |
*** shaohe_feng has joined #openstack-meeting-alt | 08:27 | |
*** macermak has joined #openstack-meeting-alt | 08:28 | |
*** tssurya has joined #openstack-meeting-alt | 08:35 | |
*** pbourke has quit IRC | 08:35 | |
*** shaohe_feng has quit IRC | 08:35 | |
*** shaohe_feng has joined #openstack-meeting-alt | 08:36 | |
*** yamahata has quit IRC | 08:40 | |
*** alex_xu has quit IRC | 08:45 | |
*** shaohe_feng has quit IRC | 08:45 | |
*** alex_xu has joined #openstack-meeting-alt | 08:46 | |
*** shaohe_feng has joined #openstack-meeting-alt | 08:46 | |
*** pbourke has joined #openstack-meeting-alt | 08:52 | |
*** hiro-kobayashi has joined #openstack-meeting-alt | 08:52 | |
*** priteau has joined #openstack-meeting-alt | 08:55 | |
*** shaohe_feng has quit IRC | 08:55 | |
*** ttsiouts has quit IRC | 08:56 | |
*** bertys has joined #openstack-meeting-alt | 08:57 | |
*** ttsiouts has joined #openstack-meeting-alt | 08:57 | |
*** shaohe_feng has joined #openstack-meeting-alt | 08:59 | |
*** masahito has joined #openstack-meeting-alt | 09:00 | |
masahito | #startmeeting blazar | 09:00 |
---|---|---|
openstack | Meeting started Tue Jul 17 09:00:16 2018 UTC and is due to finish in 60 minutes. The chair is masahito. Information about MeetBot at http://wiki.debian.org/MeetBot. | 09:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 09:00 |
*** openstack changes topic to " (Meeting topic: blazar)" | 09:00 | |
openstack | The meeting name has been set to 'blazar' | 09:00 |
masahito | Hi Blazar folks! | 09:00 |
masahito | #topic RollCall | 09:00 |
*** openstack changes topic to "RollCall (Meeting topic: blazar)" | 09:00 | |
priteau | o/ | 09:00 |
tetsuro | o/ | 09:00 |
bertys | o/ | 09:01 |
masahito | priteau, tetsuro, bertys: hello | 09:01 |
masahito | Today's agenda is | 09:01 |
priteau | Hi everyone | 09:01 |
masahito | 1. Non-client libraries release | 09:01 |
masahito | 2. Project Update in the Berlin summit | 09:01 |
masahito | 3. the gate failure | 09:01 |
masahito | 4. AOB | 09:01 |
masahito | and following review meeting. | 09:01 |
masahito | anything else? | 09:02 |
hiro-kobayashi | hi | 09:02 |
masahito | hiro-kobayashi: hi | 09:02 |
masahito | #topic Non-client release | 09:04 |
*** openstack changes topic to "Non-client release (Meeting topic: blazar)" | 09:04 | |
masahito | As we talked in the last meeting, I pushed the release patch for the blazar-nova 2.0.0 | 09:04 |
masahito | https://review.openstack.org/#/c/583159/ | 09:04 |
priteau | Great, thanks masahito | 09:05 |
masahito | The version number is aligned to the Blazar server's version. | 09:06 |
masahito | any comment? | 09:06 |
*** shaohe_feng has quit IRC | 09:06 | |
*** shaohe_feng has joined #openstack-meeting-alt | 09:06 | |
masahito | #topic Project Update in the Berlin summit | 09:08 |
*** openstack changes topic to "Project Update in the Berlin summit (Meeting topic: blazar)" | 09:08 | |
masahito | This item is also fyi. | 09:08 |
masahito | I mailed TC members wether we can have the session or not. But I've not received any response yet. | 09:09 |
hiro-kobayashi | Thank you for checking it! | 09:11 |
masahito | I hope they'll arrange the session series in the summit and we'll be included. | 09:11 |
priteau | CFP is closing on July 18th at 6:59 am UTC | 09:12 |
priteau | If we don't get any answer from TC by that time, should we submit a talk? | 09:12 |
priteau | I am sure that if there is actually a project update session, they will make sure we don't have a duplicate talk | 09:13 |
masahito | Yes, if possible I want to submit a talk. | 09:14 |
priteau | masahito: with the timezone difference you can still submit tomorrow :-) | 09:15 |
masahito | One issue I'm hitting is I'm involved in 3 talks already. | 09:15 |
*** shaohe_feng has quit IRC | 09:16 | |
*** derekh has quit IRC | 09:17 | |
*** shaohe_feng has joined #openstack-meeting-alt | 09:17 | |
*** derekh has joined #openstack-meeting-alt | 09:17 | |
priteau | Is that the maximum number of talks one can submit? | 09:17 |
masahito | Two of them are Blazar related talks. So I could do some update in those. | 09:18 |
masahito | priteau: yes. One person only can submit 3 talks regardless of main speaker or co-speaker. | 09:18 |
priteau | Who is attending Berlin by the way? | 09:20 |
priteau | I am not sure if I will be there yet | 09:20 |
masahito | I'll be there. | 09:20 |
hiro-kobayashi | I will not be there | 09:21 |
tetsuro | I'll be there | 09:21 |
masahito | If some of us can be there, it's okay to submit the update session by your name. | 09:22 |
bertys | Same as priteau, not sure if I will be there | 09:22 |
masahito | And if needed, I'm also okay to join the session later. | 09:22 |
priteau | So who could submit a project update talk if needed? tetsuro? | 09:23 |
masahito | Anyway. I try to ping them again, and if needed I'll submit a update session. | 09:24 |
tetsuro | but you can't masa, can you? | 09:24 |
masahito | One of my proposal is a talk with tetsuro. So I hope I can exit from tetsuro's talk :-) | 09:25 |
priteau | Heh | 09:25 |
tetsuro | I think that's more reasonable way to go. | 09:25 |
tetsuro | than I submit update session | 09:26 |
priteau | Sounds good | 09:26 |
*** shaohe_feng has quit IRC | 09:26 | |
masahito | okay, the problem is solved :-) | 09:26 |
masahito | #topic the gate failure | 09:27 |
*** openstack changes topic to "the gate failure (Meeting topic: blazar)" | 09:27 | |
*** shaohe_feng has joined #openstack-meeting-alt | 09:27 | |
masahito | I see the gate failure because of pylint update and the fix of the issue. https://review.openstack.org/#/c/583080/ | 09:27 |
hiro-kobayashi | Yes, please review it and merge it asap | 09:28 |
masahito | hiro-kobayashi: Thanks for digging it. | 09:28 |
hiro-kobayashi | I saw major projects like Cinder take the same approach: https://github.com/openstack/cinder/blob/master/tox.ini#L87 | 09:29 |
masahito | My one question is the required version of pytlint doesn't appear in requirements.txt, do it? | 09:30 |
priteau | hiro-kobayashi: Is pylint moved out of requirements.txt because it is in the openstack/requirements blacklist? | 09:30 |
hiro-kobayashi | Yes, it is not listed in the global-requirements. | 09:31 |
hiro-kobayashi | The latest version 2.0.0 which was released yesterday does not support python2. That's why it broke some tests. | 09:32 |
priteau | Some projects have it in their test-requirements.txt though. We could ask what's the recommended approach. | 09:33 |
masahito | I noticed pylint is removed from test-requirements.txt. tox.ini specifies requirements.txt not test-requirements.txt | 09:33 |
hiro-kobayashi | Doesn't those project hit gate failure? | 09:33 |
priteau | They use pylint==1.4.5 | 09:34 |
priteau | or pylint==1.7.1 | 09:34 |
priteau | hiro-kobayashi: If we remove pylint from test-requirements.txt, shouldn't we also remove it from lower-constraints.txt? | 09:35 |
hiro-kobayashi | I thinks lower-constraints contains more packages than listed in the requirements file. | 09:35 |
hiro-kobayashi | So, I think we can keep it. | 09:36 |
priteau | It's because it lists all dependencies, and their dependencies. | 09:36 |
masahito | IIRC, lower-constraints.txt is maintained by requirements repo. | 09:36 |
*** shaohe_feng has quit IRC | 09:36 | |
*** yamamoto has quit IRC | 09:37 | |
hiro-kobayashi | um, I don't know the maintenance policy of lower-constraints :-( | 09:37 |
hiro-kobayashi | ``Each project team may also optionally maintain a list of “lower bounds” constraints for the dependencies used to test the project in a lower-constraints.txt file`` by https://docs.openstack.org/project-team-guide/dependency-management.html#solution | 09:39 |
masahito | My thoughts for the upcomming milestone release, 1. remove pylint from test-requirements.txt (It could fix gate failure except openstack-tox-pylint), 2. find a right versioning of pylint. | 09:39 |
masahito | How do you think? | 09:39 |
*** shaohe_feng has joined #openstack-meeting-alt | 09:39 | |
priteau | hiro-kobayashi: yes, I think we have to maintain the file | 09:40 |
priteau | There is a little script in openstack/requirements to automatically generate it too | 09:40 |
priteau | masahito: isn't that what hiro-kobayashi's patch does? | 09:41 |
hiro-kobayashi | masahito: I think we should merge my patch asap. Then, upload a new patch if it does not meet with the OpenStack standard. | 09:41 |
hiro-kobayashi | I think we should move other patches forward. | 09:42 |
masahito | My concern is specifying package version in tox.ini. | 09:42 |
masahito | From my experience, this type of "special case" usually causes annoying issue later. | 09:43 |
masahito | hiro-kobayashi: I agree we should move forward. | 09:44 |
priteau | I added more details to the commit message | 09:45 |
hiro-kobayashi | thanks! | 09:45 |
masahito | okay, let's merge this patch and check openstack's standard. | 09:46 |
priteau | Gave a +2. We can fix lower-constraints and other issues later. | 09:46 |
hiro-kobayashi | OK | 09:47 |
*** shaohe_feng has quit IRC | 09:47 | |
*** jiaopeng_ has quit IRC | 09:47 | |
*** jiaopengju has quit IRC | 09:47 | |
*** jiaopen__ has joined #openstack-meeting-alt | 09:47 | |
masahito | Another idea is putting non-voting tag to py27 gate job :-) | 09:47 |
*** jiaopengju has joined #openstack-meeting-alt | 09:47 | |
*** shaohe_feng has joined #openstack-meeting-alt | 09:47 | |
masahito | Anyway, let's move on to next. | 09:48 |
masahito | #topic AOB | 09:48 |
*** openstack changes topic to "AOB (Meeting topic: blazar)" | 09:48 | |
masahito | Does someone have something to share or discuss? | 09:48 |
*** jiaopengju has quit IRC | 09:48 | |
priteau | Not from me | 09:48 |
masahito | fyi: Blazar is listed on project-navigator now. https://www.openstack.org/software/project-navigator#orchestration | 09:49 |
hiro-kobayashi | great! | 09:49 |
*** jiaopen__ has quit IRC | 09:50 | |
*** jiaopengju has joined #openstack-meeting-alt | 09:50 | |
*** jiaopeng_ has joined #openstack-meeting-alt | 09:50 | |
tetsuro | nice. | 09:50 |
priteau | I saw that recently, great news! | 09:50 |
hiro-kobayashi | The mouse looks bigger than other mascots... :-) | 09:50 |
bertys | fyi, Wiki page for upcoming PTG @ https://wiki.openstack.org/wiki/PTG/Stein/Etherpads, we may want to add Blazar too... | 09:50 |
masahito | Done | 09:52 |
bertys | thanks | 09:52 |
masahito | anything else? | 09:53 |
hiro-kobayashi | I have | 09:53 |
hiro-kobayashi | As you all know, I will change my job next month. | 09:53 |
hiro-kobayashi | The next weekly meeting is the last time for me to join as current position. | 09:54 |
priteau | We will miss you hiro-kobayashi! | 09:55 |
hiro-kobayashi | So, I’m sorry but I expect my contribution will considerably decrease. | 09:55 |
hiro-kobayashi | I will try to join as an individual contributor ;-) | 09:56 |
masahito | I'll miss you, too. I'm really appreciate your productive contributions and happy working with you. | 09:57 |
*** shaohe_feng has quit IRC | 09:57 | |
hiro-kobayashi | It was great to promote this project with you all! Thank you so much! | 09:58 |
*** shaohe_feng has joined #openstack-meeting-alt | 09:59 | |
masahito | I hope your next job is well and am looking forward to seeing you as an individual :-) | 09:59 |
hiro-kobayashi | thanks! | 10:00 |
bertys | thanks again hiro! Time to move to blazar irc? | 10:00 |
masahito | ah, yes. running out of time. | 10:01 |
masahito | moving to #openstack-blazar then let's start review meeting. | 10:01 |
masahito | #endmeeting | 10:01 |
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 10:01 | |
openstack | Meeting ended Tue Jul 17 10:01:41 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 10:01 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/blazar/2018/blazar.2018-07-17-09.00.html | 10:01 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/blazar/2018/blazar.2018-07-17-09.00.txt | 10:01 |
openstack | Log: http://eavesdrop.openstack.org/meetings/blazar/2018/blazar.2018-07-17-09.00.log.html | 10:01 |
*** bertys has quit IRC | 10:01 | |
*** shaohe_feng has quit IRC | 10:07 | |
*** shaohe_feng has joined #openstack-meeting-alt | 10:08 | |
*** lei-zh has quit IRC | 10:08 | |
*** ttsiouts has quit IRC | 10:16 | |
*** shaohe_feng has quit IRC | 10:17 | |
*** shaohe_feng has joined #openstack-meeting-alt | 10:20 | |
*** shaohe_feng has quit IRC | 10:28 | |
*** shaohe_feng has joined #openstack-meeting-alt | 10:30 | |
*** rdopiera has quit IRC | 10:35 | |
*** shaohe_feng has quit IRC | 10:38 | |
*** shaohe_feng has joined #openstack-meeting-alt | 10:40 | |
*** fanzhang has left #openstack-meeting-alt | 10:46 | |
*** shaohe_feng has quit IRC | 10:48 | |
*** shaohe_feng has joined #openstack-meeting-alt | 10:50 | |
*** shaohe_feng has quit IRC | 10:58 | |
*** sambetts|afk is now known as sambetts | 10:59 | |
*** noslzzp has joined #openstack-meeting-alt | 10:59 | |
*** shaohe_feng has joined #openstack-meeting-alt | 10:59 | |
*** tetsuro has quit IRC | 11:01 | |
*** hiro-kobayashi has quit IRC | 11:01 | |
*** macermak has quit IRC | 11:07 | |
*** shaohe_feng has quit IRC | 11:09 | |
*** masahito has quit IRC | 11:09 | |
*** shaohe_feng has joined #openstack-meeting-alt | 11:10 | |
*** d0ugal has quit IRC | 11:15 | |
*** ttsiouts has joined #openstack-meeting-alt | 11:16 | |
*** dave-mccowan has joined #openstack-meeting-alt | 11:18 | |
*** d0ugal has joined #openstack-meeting-alt | 11:18 | |
*** d0ugal has quit IRC | 11:18 | |
*** d0ugal has joined #openstack-meeting-alt | 11:18 | |
*** shaohe_feng has quit IRC | 11:19 | |
*** shaohe_feng has joined #openstack-meeting-alt | 11:20 | |
*** derekh has quit IRC | 11:22 | |
*** lennyb has quit IRC | 11:23 | |
*** shaohe_feng has quit IRC | 11:29 | |
*** shaohe_feng has joined #openstack-meeting-alt | 11:31 | |
*** janki has joined #openstack-meeting-alt | 11:39 | |
*** shaohe_feng has quit IRC | 11:39 | |
*** shaohe_feng has joined #openstack-meeting-alt | 11:40 | |
*** chyka has joined #openstack-meeting-alt | 11:48 | |
*** shaohe_feng has quit IRC | 11:50 | |
*** shaohe_feng has joined #openstack-meeting-alt | 11:52 | |
*** chyka has quit IRC | 11:52 | |
*** vgreen has joined #openstack-meeting-alt | 11:59 | |
*** shaohe_feng has quit IRC | 12:00 | |
*** shaohe_feng has joined #openstack-meeting-alt | 12:01 | |
*** alexchadin has quit IRC | 12:05 | |
*** edmondsw has joined #openstack-meeting-alt | 12:06 | |
*** ttsiouts has quit IRC | 12:09 | |
*** shaohe_feng has quit IRC | 12:10 | |
*** namnh has joined #openstack-meeting-alt | 12:10 | |
*** alexchadin has joined #openstack-meeting-alt | 12:13 | |
*** shaohe_feng has joined #openstack-meeting-alt | 12:15 | |
*** rfolco__ is now known as rfolco | 12:18 | |
*** ttsiouts has joined #openstack-meeting-alt | 12:20 | |
*** shaohe_feng has quit IRC | 12:20 | |
*** shaohe_feng has joined #openstack-meeting-alt | 12:22 | |
*** alexchadin has quit IRC | 12:25 | |
*** shaohe_feng has quit IRC | 12:31 | |
*** jiaopeng_ has quit IRC | 12:31 | |
*** jiaopengju has quit IRC | 12:31 | |
*** lbragstad has joined #openstack-meeting-alt | 12:31 | |
*** jiaopeng_ has joined #openstack-meeting-alt | 12:31 | |
*** jiaopengju has joined #openstack-meeting-alt | 12:31 | |
*** shaohe_feng has joined #openstack-meeting-alt | 12:33 | |
*** jiaopeng_ has quit IRC | 12:36 | |
*** jiaopengju has quit IRC | 12:36 | |
*** raildo has joined #openstack-meeting-alt | 12:40 | |
*** shaohe_feng has quit IRC | 12:41 | |
*** shaohe_feng has joined #openstack-meeting-alt | 12:41 | |
*** lbragstad has quit IRC | 12:41 | |
*** raildo has quit IRC | 12:45 | |
*** raildo has joined #openstack-meeting-alt | 12:46 | |
*** raildo has quit IRC | 12:50 | |
*** shaohe_feng has quit IRC | 12:51 | |
*** raildo has joined #openstack-meeting-alt | 12:52 | |
*** shaohe_feng has joined #openstack-meeting-alt | 12:53 | |
*** peereb has quit IRC | 12:56 | |
*** raildo has quit IRC | 13:00 | |
*** raildo has joined #openstack-meeting-alt | 13:00 | |
*** mjura has quit IRC | 13:01 | |
*** shaohe_feng has quit IRC | 13:01 | |
*** raildo has quit IRC | 13:03 | |
*** raildo has joined #openstack-meeting-alt | 13:03 | |
*** mjura has joined #openstack-meeting-alt | 13:04 | |
*** tpsilva has joined #openstack-meeting-alt | 13:05 | |
*** dustins has joined #openstack-meeting-alt | 13:05 | |
*** shaohe_feng has joined #openstack-meeting-alt | 13:07 | |
*** jaypipes is now known as was | 13:09 | |
*** was is now known as jaypipes | 13:10 | |
*** e0ne has quit IRC | 13:11 | |
*** munimeha1 has joined #openstack-meeting-alt | 13:11 | |
*** shaohe_feng has quit IRC | 13:12 | |
*** shaohe_feng has joined #openstack-meeting-alt | 13:14 | |
*** shaohe_feng has quit IRC | 13:22 | |
*** shaohe_feng has joined #openstack-meeting-alt | 13:24 | |
*** alexchadin has joined #openstack-meeting-alt | 13:30 | |
*** shaohe_feng has quit IRC | 13:32 | |
*** shaohe_feng has joined #openstack-meeting-alt | 13:33 | |
*** raildo has quit IRC | 13:35 | |
*** raildo has joined #openstack-meeting-alt | 13:36 | |
*** raildo has quit IRC | 13:37 | |
*** raildo has joined #openstack-meeting-alt | 13:37 | |
*** raildo has quit IRC | 13:38 | |
*** raildo has joined #openstack-meeting-alt | 13:39 | |
*** raildo has quit IRC | 13:41 | |
*** shaohe_feng has quit IRC | 13:42 | |
*** shaohe_feng has joined #openstack-meeting-alt | 13:44 | |
*** chhagarw has joined #openstack-meeting-alt | 13:47 | |
*** fnaval has joined #openstack-meeting-alt | 13:47 | |
*** shaohe_feng has quit IRC | 13:53 | |
*** shaohe_feng has joined #openstack-meeting-alt | 13:54 | |
*** manjeet has joined #openstack-meeting-alt | 13:59 | |
*** manjeet is now known as manjeets_ | 14:00 | |
*** hongbin has joined #openstack-meeting-alt | 14:00 | |
*** manjeets_ has quit IRC | 14:02 | |
*** manjeets_ has joined #openstack-meeting-alt | 14:03 | |
*** shaohe_feng has quit IRC | 14:03 | |
*** shaohe_feng has joined #openstack-meeting-alt | 14:04 | |
*** raildo has joined #openstack-meeting-alt | 14:07 | |
*** alexchad_ has joined #openstack-meeting-alt | 14:13 | |
*** shaohe_feng has quit IRC | 14:13 | |
*** alexchadin has quit IRC | 14:14 | |
*** shaohe_feng has joined #openstack-meeting-alt | 14:15 | |
*** alexchad_ has quit IRC | 14:17 | |
*** shaohe_feng has quit IRC | 14:23 | |
*** shaohe_feng has joined #openstack-meeting-alt | 14:26 | |
*** manjeets__ has joined #openstack-meeting-alt | 14:28 | |
*** alexchadin has joined #openstack-meeting-alt | 14:28 | |
*** manjeets_ has quit IRC | 14:31 | |
*** manjeets__ is now known as manjeets_ | 14:31 | |
*** manjeets__ has joined #openstack-meeting-alt | 14:33 | |
*** jcoufal_ has joined #openstack-meeting-alt | 14:34 | |
*** shaohe_feng has quit IRC | 14:34 | |
*** munimeha1 has quit IRC | 14:35 | |
*** shaohe_feng has joined #openstack-meeting-alt | 14:35 | |
*** manjeets_ has quit IRC | 14:36 | |
*** jcoufal has quit IRC | 14:36 | |
*** cloudrancher has quit IRC | 14:36 | |
*** cloudrancher has joined #openstack-meeting-alt | 14:37 | |
*** d0ugal has quit IRC | 14:37 | |
*** manjeets__ is now known as manjeets_ | 14:40 | |
*** shaohe_feng has quit IRC | 14:44 | |
*** gagehugo has joined #openstack-meeting-alt | 14:44 | |
*** shaohe_feng has joined #openstack-meeting-alt | 14:44 | |
*** d0ugal has joined #openstack-meeting-alt | 14:44 | |
*** AlanClark has joined #openstack-meeting-alt | 14:52 | |
*** shaohe_feng has quit IRC | 14:54 | |
*** shaohe_feng has joined #openstack-meeting-alt | 14:56 | |
*** lbragstad has joined #openstack-meeting-alt | 14:57 | |
*** namnh has quit IRC | 14:57 | |
*** alexchadin has quit IRC | 15:02 | |
*** manjeets_ has quit IRC | 15:03 | |
*** d0ugal has quit IRC | 15:03 | |
*** shaohe_feng has quit IRC | 15:05 | |
*** wxy| has joined #openstack-meeting-alt | 15:06 | |
*** shaohe_feng has joined #openstack-meeting-alt | 15:07 | |
*** ccamacho has quit IRC | 15:07 | |
*** florianf has quit IRC | 15:09 | |
*** ttsiouts has quit IRC | 15:09 | |
*** markstur has joined #openstack-meeting-alt | 15:10 | |
*** florianf has joined #openstack-meeting-alt | 15:11 | |
*** d0ugal has joined #openstack-meeting-alt | 15:14 | |
*** shaohe_feng has quit IRC | 15:15 | |
*** dgonzalez has left #openstack-meeting-alt | 15:15 | |
*** shaohe_feng has joined #openstack-meeting-alt | 15:16 | |
*** lpetrut has quit IRC | 15:23 | |
*** shaohe_feng has quit IRC | 15:25 | |
*** d0ugal has quit IRC | 15:26 | |
*** shaohe_feng has joined #openstack-meeting-alt | 15:26 | |
*** mjura has quit IRC | 15:27 | |
*** myoung is now known as myoung|biaf | 15:27 | |
*** shaohe_feng has quit IRC | 15:35 | |
*** shaohe_feng has joined #openstack-meeting-alt | 15:37 | |
*** yamahata has joined #openstack-meeting-alt | 15:41 | |
*** felipemonteiro has joined #openstack-meeting-alt | 15:41 | |
*** shaohe_feng has quit IRC | 15:46 | |
*** shaohe_feng has joined #openstack-meeting-alt | 15:46 | |
*** ttsiouts has joined #openstack-meeting-alt | 15:48 | |
*** ttsiouts has quit IRC | 15:48 | |
*** ttsiouts has joined #openstack-meeting-alt | 15:49 | |
*** ttsiouts has quit IRC | 15:54 | |
*** shaohe_feng has quit IRC | 15:56 | |
*** d0ugal has joined #openstack-meeting-alt | 15:57 | |
*** tesseract has quit IRC | 15:57 | |
*** shaohe_feng has joined #openstack-meeting-alt | 15:57 | |
*** chyka has joined #openstack-meeting-alt | 15:58 | |
lbragstad | #startmeeting keystone | 16:00 |
openstack | Meeting started Tue Jul 17 16:00:02 2018 UTC and is due to finish in 60 minutes. The chair is lbragstad. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
*** openstack changes topic to " (Meeting topic: keystone)" | 16:00 | |
openstack | The meeting name has been set to 'keystone' | 16:00 |
lbragstad | #link https://etherpad.openstack.org/p/keystone-weekly-meeting | 16:00 |
lbragstad | agenda ^ | 16:00 |
cmurphy | o/ | 16:00 |
jgrassler | Hello | 16:00 |
wxy| | o/ | 16:00 |
lbragstad | ping ayoung, breton, cmurphy, dstanek, gagehugo, hrybacki, knikolla, lamt, lbragstad, lwanderley, kmalloc, rodrigods, samueldmq, spilla, aselius, dpar, jdennis, ruan_he, wxy, sonuk | 16:00 |
gagehugo | o/ | 16:00 |
hrybacki | o/ | 16:00 |
knikolla | o/ | 16:00 |
*** dklyle has quit IRC | 16:00 | |
kmalloc | o/ | 16:01 |
lbragstad | we have a relatively light schedule today - so we'll give folks another minute or two to show up | 16:01 |
*** sonuk has joined #openstack-meeting-alt | 16:02 | |
sonuk | \o | 16:02 |
lbragstad | #topic release status | 16:03 |
*** openstack changes topic to "release status (Meeting topic: keystone)" | 16:03 | |
lbragstad | just a couple quick announcements | 16:03 |
lbragstad | we have non-client library freeze by the end of the weke | 16:03 |
lbragstad | week* | 16:03 |
lbragstad | #link https://releases.openstack.org/rocky/schedule.html#r-final-lib | 16:04 |
lbragstad | so if there is anything we need from an oslo/ksa perspective, we'll need to get those things squared away | 16:04 |
lbragstad | i don't think i have anything on my radar | 16:04 |
cmurphy | also ksm | 16:04 |
lbragstad | ++ yeah | 16:04 |
cmurphy | there's at least one ksm change that needs attention | 16:04 |
lbragstad | these are the open reviews | 16:06 |
lbragstad | #link https://review.openstack.org/#/q/project:openstack/keystonemiddleware+status:open | 16:06 |
*** shaohe_feng has quit IRC | 16:06 | |
lbragstad | cmurphy: which review were you referring to? | 16:07 |
*** shaohe_feng has joined #openstack-meeting-alt | 16:07 | |
cmurphy | lbragstad: well i guess there's more than one :) | 16:07 |
lbragstad | lol | 16:07 |
cmurphy | one i'm having trouble with is https://review.openstack.org/578008 would be good to have other eyes on it | 16:08 |
lbragstad | just the purpose of it? | 16:09 |
lbragstad | or something else? | 16:09 |
lbragstad | i'll be honest, i haven't looked at this one yet | 16:09 |
cmurphy | well we don't need to use the meeting to look at it, just wanted to highlight it | 16:10 |
lbragstad | i'll make a note to review it today | 16:10 |
*** bfernando has quit IRC | 16:11 | |
lbragstad | any other patches we need to get into ksa, ksm, or oslo libraries before Friday? | 16:11 |
lbragstad | note that oslo.limit will be exempt from the freeze since it's not revved past 1.0 yet | 16:12 |
*** ayoung has joined #openstack-meeting-alt | 16:12 | |
lbragstad | if someone does stumble across something we need to include, just say something | 16:13 |
lbragstad | along the same vein - requirements freeze is next week | 16:13 |
lbragstad | so we'll need to be mindful of versions we need, if any | 16:14 |
wxy| | https://review.openstack.org/#/c/583215/ this one in ksa, since it's a bug from s10 for a long time. | 16:14 |
lbragstad | wxy|: nice - i can review that today, too | 16:14 |
wxy| | lbragstad: thanks. | 16:15 |
lbragstad | thanks for the patch | 16:15 |
lbragstad | that's about all i had for release stuff | 16:16 |
lbragstad | #topic keystoneauth url discovery bug | 16:16 |
*** openstack changes topic to "keystoneauth url discovery bug (Meeting topic: keystone)" | 16:16 | |
kmalloc | that bug sucks. | 16:16 |
lbragstad | #link: https://bugs.launchpad.net/keystoneauth/+bug/1733052 | 16:16 |
openstack | Launchpad bug 1733052 in keystoneauth "Usage of internal URL in clouds.yaml causes a 404" [High,In progress] - Assigned to wangxiyuan (wangxiyuan) | 16:16 |
lbragstad | ^ that one you mean :) | 16:16 |
*** shaohe_feng has quit IRC | 16:16 | |
kmalloc | look closely at the code, we need to be sure we're not going to break anything | 16:16 |
lbragstad | i'm not entirely sure who put this on the schedule for today | 16:16 |
*** shaohe_feng has joined #openstack-meeting-alt | 16:17 | |
kmalloc | but we need to get that landed if possible | 16:17 |
kmalloc | i don't know who added it, but mordred, wxy|, me, and a few others have a vested interest in that bugfix landing | 16:17 |
kmalloc | it will unbreak some folks. | 16:17 |
*** d0ugal has quit IRC | 16:18 | |
lbragstad | sounds good | 16:18 |
mordred | yeah. it's important | 16:18 |
*** harlowja has joined #openstack-meeting-alt | 16:18 | |
mordred | it's definitely a thing we should fix in the client library and not in the services themselves ;) | 16:18 |
lbragstad | we'll looks like we just need some reviews | 16:18 |
*** myoung|biaf is now known as myoung | 16:19 | |
kmalloc | yep | 16:19 |
mordred | we should land it - because there are old clouds out there that are broken - but it's also fundamentally broken from the pov of the services | 16:19 |
lbragstad | is there anything we want to discuss about the fix? | 16:19 |
*** tssurya has quit IRC | 16:19 | |
mordred | and at some point someone should actually fix all of the services | 16:19 |
ayoung | looking | 16:19 |
*** jcoufal_ has quit IRC | 16:20 | |
kmalloc | nothing besides what has already been said. | 16:20 |
mordred | kmalloc: I could rage a bit more if it's helpful | 16:20 |
kmalloc | mordred: lol | 16:20 |
ayoung | why does it not have a test? | 16:20 |
wxy| | ayoung: oh, i'll add one later. | 16:21 |
ayoung | wxy|, I won't touch it without a test | 16:22 |
ayoung | tests first. Tests always | 16:22 |
lbragstad | ok - anything more on this topic? | 16:24 |
lbragstad | otherwise i'll open it up for discussion | 16:24 |
*** links has quit IRC | 16:24 | |
ayoung | has anyone looked at our test coverage numbers lately? | 16:24 |
lbragstad | yes | 16:25 |
lbragstad | we're around 92% in keystone server | 16:25 |
ayoung | how we looking? | 16:25 |
lbragstad | i would like to gate on coverage, but i'm not sure if we've tried that in the past | 16:26 |
lbragstad | #topic open discussion | 16:26 |
*** openstack changes topic to "open discussion (Meeting topic: keystone)" | 16:26 | |
ayoung | yeah...it would be great if a patch was immediately rejected if the lines of codes changed were not covered by a test | 16:26 |
*** shaohe_feng has quit IRC | 16:27 | |
lbragstad | does anyone know if other projects gate on test coverage? | 16:27 |
lbragstad | i'm not aware of that done by any of the other services | 16:27 |
gagehugo | I don't think so | 16:27 |
*** shaohe_feng has joined #openstack-meeting-alt | 16:28 | |
*** lpetrut has joined #openstack-meeting-alt | 16:28 | |
*** dklyle has joined #openstack-meeting-alt | 16:28 | |
ayoung | could we build it out of existing tools? | 16:29 |
lbragstad | what do you mean? | 16:29 |
ayoung | something like: upon checking, run test coverage. THen, from the git patch, get the new lines of code | 16:29 |
clarkb | one specific concern around using coverage in that way is it can legitimetely drop (say you delete a bunch of unused code that was only covered by test suite) | 16:29 |
lbragstad | we have a coverage job defined in our tox.ini | 16:29 |
clarkb | and no one has built a thing to address those concerns | 16:29 |
ayoung | and then query the test covereage output to make sure those lines were covered? | 16:29 |
ayoung | clarkb, I'm looking for "all new lines are covered by some code" | 16:30 |
ayoung | which is a way to move forward | 16:30 |
*** d0ugal has joined #openstack-meeting-alt | 16:30 | |
ayoung | deleting code would only fail if you ended up with a partial line change, and that line was uncovered | 16:30 |
ayoung | sounds like a great intern projec | 16:31 |
ayoung | t | 16:31 |
*** e0ne has joined #openstack-meeting-alt | 16:31 | |
ayoung | Oh, BTWE, I have some good news for people trying to develop on RHEL75 etc | 16:32 |
ayoung | http://adam.younglogic.com/2018/07/running-openstack-components-on-rhel-with-software-collections/ | 16:32 |
ayoung | which can be used to run upstream code in a supported way. ish | 16:33 |
ayoung | so for running the covereage code, I can use that | 16:33 |
ayoung | scl enable rh-python35 bash | 16:33 |
ayoung | tox -e cover | 16:33 |
* ayoung running now | 16:33 | |
kmalloc | i am -2 on a "if coverage goes down error" because of what clarkb said. | 16:33 |
ayoung | kmalloc, agreed | 16:34 |
lbragstad | yeah - that's a good point | 16:34 |
ayoung | I don't want to do it on percentage | 16:34 |
lbragstad | what about at least publishing it formally somewhere? | 16:34 |
lbragstad | (i don't think we do that either) | 16:34 |
ayoung | I want to do it on "if you are adding or modding a line of code in a patch, it needs a test." | 16:34 |
kmalloc | and there are legitimate cases (e.g. flask) that testing could not have been fully written without it being a massive 3000+ line patch | 16:34 |
kmalloc | and then tests on top of it | 16:35 |
ayoung | you can mock out a lot | 16:35 |
kmalloc | ok, let me just say this is a people problem not a tech problem. | 16:35 |
ayoung | disagree | 16:35 |
ayoung | this is something we can automate | 16:35 |
kmalloc | it is on us, reviewers to say "this needs tests" and look at the coverage report | 16:35 |
ayoung | and that makes it something not part of a code review | 16:35 |
kmalloc | it is not automatable | 16:35 |
kmalloc | there are too many variables | 16:36 |
knikolla | I tend to agree with kmalloc | 16:36 |
lbragstad | at some point you have to review the code and make sure it's doing what it's suppose to | 16:36 |
ayoung | lets give it a try | 16:36 |
ayoung | lbragstad, agreed, but automated checks for "you must have a test" are like automated pep8 | 16:36 |
kmalloc | mocking it all out is a terrible policy just to get past a hurdle of "well you're going to just undo these once the next patch lands" | 16:37 |
*** shaohe_feng has quit IRC | 16:37 | |
ayoung | ok, I have an idea | 16:37 |
mordred | this was first proposed at the cactus summit fwiw, and so far nobody has managed to build a thing that works enough to be usable | 16:37 |
mordred | HOWEVER | 16:37 |
ayoung | instead of making it a gerrit check | 16:37 |
mordred | it was first proposed at the cactus summit and people have wanted it ever since | 16:37 |
mordred | so I thik it would be welcome if someone can figure it out | 16:37 |
kmalloc | ayoung: if you can produce something legitimately reliable and handle the edge cases, i'll be the first to +2 it | 16:37 |
mordred | ++ | 16:37 |
ayoung | lets get a tool that at least we can run, that does a cover check + "these lines are covered or not" check | 16:38 |
kmalloc | and i'm fine trialing it in keystone | 16:38 |
* lbragstad would settle for publishing (not gating on) coverage reports as a way to encourage people to use it as a learning tool while filling the gaps | 16:38 | |
kmalloc | but i want a well designed tool. | 16:38 |
ayoung | step one is showing it can be done | 16:38 |
mordred | ayoung: yes. agree. a tool we can run is a GREAT step 1 | 16:38 |
kmalloc | lbragstad: it is published in the coverage run. | 16:38 |
kmalloc | we just need to look at it | 16:38 |
kmalloc | just like docs | 16:38 |
lbragstad | right... | 16:38 |
ayoung | step 4 is automating it. Not sure about 2 and 3, but I am sure there are steps there | 16:38 |
gagehugo | http://logs.openstack.org/58/580258/10/check/openstack-tox-cover/9140707/cover/ | 16:38 |
gagehugo | ^ example | 16:39 |
lbragstad | in addition to that i gues it would be nice to have a badge displaying the coverage of master | 16:39 |
*** shaohe_feng has joined #openstack-meeting-alt | 16:39 | |
ayoung | CLI is our worst offender, followed by LDAP (my quick scan) | 16:39 |
* kmalloc also very strongly believes the it is a fallacy that 100% code coverage means anything. it results in the terrible thing you see in a lot of java projects with bazillion mocks | 16:40 | |
mordred | ayoung: easy win - delete CLI :) | 16:40 |
kmalloc | mordred: ++ | 16:40 |
kmalloc | mordred: didn't we already do that in keystone? ;) | 16:40 |
ayoung | Didn't we try that already? | 16:40 |
kmalloc | keystoneclient has no cli | 16:41 |
kmalloc | osc is our cli | 16:41 |
ayoung | this is keystone-manage | 16:41 |
mordred | ah. | 16:41 |
*** dustins has quit IRC | 16:41 | |
mordred | deleting that is probably not a great idea | 16:41 |
lbragstad | keystone/cmd/cli.py | 16:41 |
kmalloc | we should be writing tests to test behavior | 16:41 |
clarkb | one approach some projects have taken is to run non voting coverage jobs in check to produce coverage reports for projects separately from the main unittes run | 16:41 |
ayoung | want me to open some bugs for that? | 16:41 |
kmalloc | if we are specifying behavior rather than "did you write a test that exercises the code" | 16:42 |
clarkb | this is done because python coverage impacts timing in ways that can break things and be difficult to fix | 16:42 |
*** kopecmartin has quit IRC | 16:42 | |
kmalloc | it is better. | 16:42 |
kmalloc | clarkb: our coverage report is voting, at least in check. | 16:42 |
kmalloc | iirc | 16:42 |
ayoung | "Mapping engine tester is untested" | 16:42 |
knikolla | is the current coverage job enough? if not, what is it missing? | 16:43 |
kmalloc | writing purely synthetic tests that shows the code behaves as it was written is a lot less useful than "here is the expected behavior, does it do that" | 16:43 |
kmalloc | and we tend to do a lot more of the former | 16:43 |
kmalloc | knikolla: i don't know what is missing from the coverage report being at least initially useful. | 16:43 |
lbragstad | i think it's initially useful - i guess i just want it to be more accessible? | 16:45 |
kmalloc | publish it alongside docs? make the coverage report a part of the dev docs? | 16:45 |
kmalloc | *coverage*->>docs.o.o/developer/keystone/coverage [not real url, but example] | 16:46 |
knikolla | sure | 16:46 |
kmalloc | i'm fine with that | 16:46 |
lbragstad | yeah - that might be a good idea | 16:46 |
*** shaohe_feng has quit IRC | 16:47 | |
kmalloc | it will make our docs job a LOT slower | 16:47 |
ayoung | so, when submitting a patch, run covereage, and make sure your new code is covered. When reviewing a patch, do the same. | 16:47 |
kmalloc | or we would need a docs-coverage publisher | 16:47 |
lbragstad | it only have to run unit tests? | 16:48 |
kmalloc | yeah it has to run all the unit tests | 16:48 |
kmalloc | docs does not have to do that today | 16:48 |
kmalloc | ayoung: but ftr we already do that on every patch: example of one I am working on http://logs.openstack.org/24/582724/1/check/openstack-tox-cover/7263f00/cover/ | 16:48 |
kmalloc | the report is already run in check [and if the job fails, the patch gets a -1] | 16:49 |
kmalloc | from zuul | 16:49 |
kmalloc | ayoung: right now, we just need to, as reviewers, look at that result :) | 16:49 |
ayoung | does not check every line is covered, or these would never get through | 16:49 |
*** shaohe_feng has joined #openstack-meeting-alt | 16:49 | |
*** julim has joined #openstack-meeting-alt | 16:49 | |
kmalloc | that is the job of reviewers | 16:49 |
ayoung | right | 16:49 |
knikolla | kmalloc: ++ | 16:49 |
kmalloc | 100% test coverage does not mean anything useful | 16:50 |
kmalloc | never has | 16:50 |
kmalloc | because you then have 1000000000 mocks. look at the bad pattern in a lot of bigger java (historically) projects | 16:50 |
kmalloc | does this test the bits of code you'd expect: yes/no, that is a human question | 16:50 |
ayoung | that gets into design issues. All I am saying is that changed lines of code need tests. | 16:51 |
ayoung | I'll see if I can automate that | 16:51 |
kmalloc | i have to step out of this convo, i am so opposed to this line of thinking as an automatable task... | 16:51 |
kmalloc | the only proposal I recommend at this point is: Reviewers, look at the coverage report please. and add it to the factors you use to review code | 16:52 |
lbragstad | anything else we want to cover with this topic? | 16:52 |
lbragstad | kmalloc: ++ | 16:52 |
knikolla | it's my failure as a reviewer if i let something in which isn't tested, and that tests don't cover edge cases or behaviors | 16:53 |
knikolla | i wouldn't trust the automation anyway because edge cases | 16:53 |
ayoung | "Never send a man to do a machines job." | 16:54 |
*** cloudrancher has quit IRC | 16:55 | |
ayoung | "Never send a Human to do a machine's job." is the proper quote | 16:55 |
*** cloudrancher has joined #openstack-meeting-alt | 16:55 | |
ayoung | so to see the lines that change from a patch looks like it is scriptable... | 16:55 |
ayoung | and then pull thyose line numbers out of cover: | 16:55 |
ayoung | for example, in cover/keystone_server_flask_common_py.html | 16:56 |
kmalloc | ayoung: i can point to concrete examples of why automation is very hard on this: any abstract base class that does NotImplementedError() is NOT tested | 16:57 |
ayoung | kmalloc, as I said, first step is tooling | 16:57 |
kmalloc | ayoung: the wsgi framework loaders don't get captured in unit tests and can't be | 16:57 |
kmalloc | because of how they load | 16:57 |
knikolla | a machine's job here would be aiding the reviewer to make a decision. the binary tested or not doesn't help me too much. what would help me would be a "here's where this changed line is tested from". | 16:57 |
*** noslzzp has quit IRC | 16:57 | |
kmalloc | this is why functional tests, a real keystone, is useful | 16:57 |
kmalloc | and behavior | 16:57 |
*** shaohe_feng has quit IRC | 16:57 | |
lbragstad | three minute check | 16:57 |
kmalloc | i'll go on record and say i'm a hard -2 on adding jobs that do coverage level checks until we have clear examples on it working and not forcing needing to mock things for the sake of "did we test this" | 16:58 |
kmalloc | knikolla: ++ better "we tested with testcase X and Y and Z" would be good | 16:59 |
kmalloc | but that is also *hard* | 16:59 |
lbragstad | alright - wrapping this up since we're out of time | 17:00 |
lbragstad | thanks for coming all! | 17:00 |
lbragstad | #endmeeting | 17:00 |
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 17:00 | |
openstack | Meeting ended Tue Jul 17 17:00:25 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 17:00 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/keystone/2018/keystone.2018-07-17-16.00.html | 17:00 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/keystone/2018/keystone.2018-07-17-16.00.txt | 17:00 |
openstack | Log: http://eavesdrop.openstack.org/meetings/keystone/2018/keystone.2018-07-17-16.00.log.html | 17:00 |
*** shaohe_feng has joined #openstack-meeting-alt | 17:00 | |
*** shaohe_feng has quit IRC | 17:08 | |
*** shaohe_feng has joined #openstack-meeting-alt | 17:08 | |
*** gagehugo has left #openstack-meeting-alt | 17:08 | |
*** chhagarw has quit IRC | 17:09 | |
*** lbragstad has quit IRC | 17:11 | |
*** wxy| has quit IRC | 17:11 | |
*** dtrainor has quit IRC | 17:15 | |
*** e0ne has quit IRC | 17:15 | |
*** dtrainor has joined #openstack-meeting-alt | 17:17 | |
*** shaohe_feng has quit IRC | 17:18 | |
*** shaohe_feng has joined #openstack-meeting-alt | 17:19 | |
*** e0ne has joined #openstack-meeting-alt | 17:21 | |
*** dustins has joined #openstack-meeting-alt | 17:22 | |
*** felipemonteiro_ has joined #openstack-meeting-alt | 17:26 | |
*** shaohe_feng has quit IRC | 17:28 | |
*** chhagarw has joined #openstack-meeting-alt | 17:29 | |
*** shaohe_feng has joined #openstack-meeting-alt | 17:29 | |
*** felipemonteiro has quit IRC | 17:30 | |
*** julim has quit IRC | 17:34 | |
*** shaohe_feng has quit IRC | 17:38 | |
*** shaohe_feng has joined #openstack-meeting-alt | 17:39 | |
*** sambetts is now known as sambetts|afk | 17:41 | |
*** sonuk has quit IRC | 17:44 | |
*** chhagarw has quit IRC | 17:45 | |
*** shaohe_feng has quit IRC | 17:49 | |
*** shaohe_feng has joined #openstack-meeting-alt | 17:49 | |
*** myoung is now known as myoung|lunch | 17:50 | |
*** harlowja has quit IRC | 17:54 | |
*** dustins has quit IRC | 17:59 | |
*** shaohe_feng has quit IRC | 17:59 | |
*** dustins has joined #openstack-meeting-alt | 17:59 | |
*** shaohe_feng has joined #openstack-meeting-alt | 18:00 | |
*** dustins has quit IRC | 18:04 | |
*** dustins has joined #openstack-meeting-alt | 18:08 | |
*** shaohe_feng has quit IRC | 18:09 | |
*** shaohe_feng has joined #openstack-meeting-alt | 18:11 | |
*** bfernando has joined #openstack-meeting-alt | 18:12 | |
*** janki has quit IRC | 18:14 | |
*** ianychoi has quit IRC | 18:14 | |
*** yamahata has quit IRC | 18:15 | |
*** e0ne has quit IRC | 18:15 | |
*** shaohe_feng has quit IRC | 18:19 | |
*** shaohe_feng has joined #openstack-meeting-alt | 18:21 | |
*** shaohe_feng has quit IRC | 18:30 | |
*** diablo_rojo has joined #openstack-meeting-alt | 18:31 | |
*** harlowja has joined #openstack-meeting-alt | 18:32 | |
*** shaohe_feng has joined #openstack-meeting-alt | 18:33 | |
*** shaohe_feng has quit IRC | 18:40 | |
*** shaohe_feng has joined #openstack-meeting-alt | 18:41 | |
*** vgreen has quit IRC | 18:46 | |
*** vgreen has joined #openstack-meeting-alt | 18:46 | |
*** lbragstad has joined #openstack-meeting-alt | 18:47 | |
*** myoung|lunch is now known as myoung | 18:47 | |
*** yamahata has joined #openstack-meeting-alt | 18:47 | |
*** e0ne has joined #openstack-meeting-alt | 18:49 | |
*** shaohe_feng has quit IRC | 18:50 | |
*** shaohe_feng has joined #openstack-meeting-alt | 18:50 | |
*** AlanClark has quit IRC | 18:56 | |
*** dustins has quit IRC | 18:56 | |
*** shaohe_feng has quit IRC | 19:00 | |
*** TxGirlGeek has joined #openstack-meeting-alt | 19:01 | |
*** shaohe_feng has joined #openstack-meeting-alt | 19:02 | |
*** panda is now known as panda|off | 19:03 | |
*** shaohe_feng has quit IRC | 19:11 | |
*** shaohe_feng has joined #openstack-meeting-alt | 19:11 | |
*** efried has quit IRC | 19:14 | |
*** efried has joined #openstack-meeting-alt | 19:14 | |
*** sridharg has quit IRC | 19:20 | |
*** shaohe_feng has quit IRC | 19:21 | |
*** shaohe_feng has joined #openstack-meeting-alt | 19:21 | |
*** shaohe_feng has quit IRC | 19:31 | |
*** shaohe_feng has joined #openstack-meeting-alt | 19:32 | |
*** dustins has joined #openstack-meeting-alt | 19:33 | |
*** dustins has quit IRC | 19:33 | |
*** dustins has joined #openstack-meeting-alt | 19:36 | |
*** shaohe_feng has quit IRC | 19:41 | |
*** e0ne has quit IRC | 19:41 | |
*** shaohe_feng has joined #openstack-meeting-alt | 19:41 | |
*** diablo_rojo has quit IRC | 19:47 | |
*** shaohe_feng has quit IRC | 19:52 | |
*** shaohe_feng has joined #openstack-meeting-alt | 19:52 | |
*** cloudrancher has quit IRC | 19:53 | |
*** cloudrancher has joined #openstack-meeting-alt | 19:54 | |
*** bfernando has quit IRC | 19:55 | |
*** shaohe_feng has quit IRC | 20:02 | |
*** tssurya has joined #openstack-meeting-alt | 20:04 | |
*** shaohe_feng has joined #openstack-meeting-alt | 20:05 | |
*** shaohe_feng has quit IRC | 20:12 | |
*** shaohe_feng has joined #openstack-meeting-alt | 20:13 | |
*** brault has quit IRC | 20:17 | |
*** brault has joined #openstack-meeting-alt | 20:18 | |
*** shaohe_feng has quit IRC | 20:22 | |
*** tssurya has quit IRC | 20:23 | |
*** shaohe_feng has joined #openstack-meeting-alt | 20:24 | |
*** lbragstad has quit IRC | 20:28 | |
*** raildo has quit IRC | 20:31 | |
*** priteau has quit IRC | 20:31 | |
*** shaohe_feng has quit IRC | 20:33 | |
*** shaohe_feng has joined #openstack-meeting-alt | 20:34 | |
*** lpetrut has quit IRC | 20:36 | |
*** brault has quit IRC | 20:37 | |
*** raildo has joined #openstack-meeting-alt | 20:38 | |
*** shaohe_feng has quit IRC | 20:43 | |
*** shaohe_feng has joined #openstack-meeting-alt | 20:44 | |
*** florianf has quit IRC | 20:50 | |
*** raildo has quit IRC | 20:50 | |
*** julim has joined #openstack-meeting-alt | 20:51 | |
*** vgreen has quit IRC | 20:53 | |
*** shaohe_feng has quit IRC | 20:53 | |
*** shaohe_feng has joined #openstack-meeting-alt | 20:54 | |
*** julim has quit IRC | 20:57 | |
*** d0ugal has quit IRC | 20:58 | |
*** d0ugal has joined #openstack-meeting-alt | 21:00 | |
*** d0ugal has quit IRC | 21:00 | |
*** d0ugal has joined #openstack-meeting-alt | 21:00 | |
*** jtomasek has quit IRC | 21:01 | |
*** shaohe_feng has quit IRC | 21:03 | |
*** shaohe_feng has joined #openstack-meeting-alt | 21:05 | |
*** jtomasek has joined #openstack-meeting-alt | 21:06 | |
*** shaohe_feng has quit IRC | 21:14 | |
*** shaohe_feng has joined #openstack-meeting-alt | 21:14 | |
*** kaisers1 has joined #openstack-meeting-alt | 21:17 | |
*** kaisers has quit IRC | 21:18 | |
*** shaohe_feng has quit IRC | 21:24 | |
*** shaohe_feng has joined #openstack-meeting-alt | 21:24 | |
*** felipemonteiro_ has quit IRC | 21:27 | |
*** shaohe_feng has quit IRC | 21:34 | |
*** slaweq has quit IRC | 21:34 | |
*** shaohe_feng has joined #openstack-meeting-alt | 21:35 | |
*** edmondsw has quit IRC | 21:36 | |
*** shaohe_feng has quit IRC | 21:44 | |
*** edmondsw_ has joined #openstack-meeting-alt | 21:45 | |
*** shaohe_feng has joined #openstack-meeting-alt | 21:46 | |
*** bfernando has joined #openstack-meeting-alt | 21:47 | |
*** edmondsw_ has quit IRC | 21:49 | |
*** shaohe_feng has quit IRC | 21:55 | |
*** shaohe_feng has joined #openstack-meeting-alt | 21:56 | |
*** bfernando has quit IRC | 22:01 | |
*** shaohe_feng has quit IRC | 22:05 | |
*** shaohe_feng has joined #openstack-meeting-alt | 22:06 | |
*** apetrich has quit IRC | 22:08 | |
*** slaweq has joined #openstack-meeting-alt | 22:11 | |
*** apetrich has joined #openstack-meeting-alt | 22:12 | |
*** shaohe_feng has quit IRC | 22:15 | |
*** slaweq has quit IRC | 22:16 | |
*** shaohe_feng has joined #openstack-meeting-alt | 22:16 | |
*** dave-mccowan has quit IRC | 22:16 | |
*** shaohe_feng has quit IRC | 22:25 | |
*** sambetts|afk has quit IRC | 22:26 | |
*** shaohe_feng has joined #openstack-meeting-alt | 22:28 | |
*** sambetts_ has joined #openstack-meeting-alt | 22:28 | |
*** myoung is now known as myoung|off | 22:31 | |
*** rcernin has joined #openstack-meeting-alt | 22:32 | |
*** shaohe_feng has quit IRC | 22:36 | |
*** jtomasek has quit IRC | 22:36 | |
*** shaohe_feng has joined #openstack-meeting-alt | 22:36 | |
*** shaohe_feng has quit IRC | 22:46 | |
*** shaohe_feng has joined #openstack-meeting-alt | 22:46 | |
*** lbragstad has joined #openstack-meeting-alt | 22:50 | |
*** tpsilva has quit IRC | 22:55 | |
*** shaohe_feng has quit IRC | 22:56 | |
*** shaohe_feng has joined #openstack-meeting-alt | 22:57 | |
*** dustins has quit IRC | 23:00 | |
*** shaohe_feng has quit IRC | 23:06 | |
*** shaohe_feng has joined #openstack-meeting-alt | 23:07 | |
*** number80 has quit IRC | 23:08 | |
*** number80 has joined #openstack-meeting-alt | 23:10 | |
*** slaweq has joined #openstack-meeting-alt | 23:11 | |
*** slaweq has quit IRC | 23:16 | |
*** shaohe_feng has quit IRC | 23:17 | |
*** shaohe_feng has joined #openstack-meeting-alt | 23:17 | |
*** shaohe_feng has quit IRC | 23:27 | |
*** shaohe_feng has joined #openstack-meeting-alt | 23:29 | |
*** shaohe_feng has quit IRC | 23:37 | |
*** shaohe_feng has joined #openstack-meeting-alt | 23:38 | |
*** cloudrancher has quit IRC | 23:43 | |
*** cloudrancher has joined #openstack-meeting-alt | 23:43 | |
*** chyka has quit IRC | 23:43 | |
*** shaohe_feng has quit IRC | 23:47 | |
*** shaohe_feng has joined #openstack-meeting-alt | 23:48 | |
*** cloudrancher has quit IRC | 23:56 | |
*** shaohe_feng has quit IRC | 23:58 | |
*** shaohe_feng has joined #openstack-meeting-alt | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!