| *** gyee has quit IRC | 00:01 | |
| *** rdopiera has quit IRC | 00:14 | |
| *** yamamoto has quit IRC | 00:35 | |
| *** yamamoto has joined #openstack-meeting-alt | 00:35 | |
| *** tetsuro has joined #openstack-meeting-alt | 00:42 | |
| *** Liang__ has joined #openstack-meeting-alt | 01:15 | |
| *** ricolin has joined #openstack-meeting-alt | 02:01 | |
| *** early has quit IRC | 02:11 | |
| *** wxy has quit IRC | 02:21 | |
| *** early has joined #openstack-meeting-alt | 02:30 | |
| *** lbragstad has quit IRC | 02:31 | |
| *** apetrich has quit IRC | 02:42 | |
| *** rcernin has quit IRC | 02:49 | |
| *** rcernin has joined #openstack-meeting-alt | 02:55 | |
| *** rcernin has quit IRC | 03:08 | |
| *** rcernin has joined #openstack-meeting-alt | 03:50 | |
| *** yamamoto has quit IRC | 04:19 | |
| *** Liang__ has quit IRC | 04:19 | |
| *** Liang__ has joined #openstack-meeting-alt | 04:23 | |
| *** vishakha has joined #openstack-meeting-alt | 04:24 | |
| *** markvoelker has joined #openstack-meeting-alt | 04:27 | |
| *** markvoelker has quit IRC | 04:33 | |
| *** yamamoto has joined #openstack-meeting-alt | 04:35 | |
| *** vishalmanchanda has joined #openstack-meeting-alt | 04:43 | |
| *** andrebeltrami has quit IRC | 04:49 | |
| *** diablo_rojo has quit IRC | 04:53 | |
| *** ircuser-1 has joined #openstack-meeting-alt | 06:55 | |
| *** slaweq has joined #openstack-meeting-alt | 07:00 | |
| *** apetrich has joined #openstack-meeting-alt | 07:11 | |
| *** ccamacho has joined #openstack-meeting-alt | 07:12 | |
| *** ttsiouts has joined #openstack-meeting-alt | 07:13 | |
| *** rdopiera has joined #openstack-meeting-alt | 07:43 | |
| *** rcernin has quit IRC | 07:47 | |
| *** ttsiouts has quit IRC | 07:49 | |
| *** ttsiouts has joined #openstack-meeting-alt | 07:57 | |
| *** ralonsoh has joined #openstack-meeting-alt | 07:57 | |
| *** rdopiera has quit IRC | 08:00 | |
| *** Liang__ has quit IRC | 08:01 | |
| *** Liang__ has joined #openstack-meeting-alt | 08:02 | |
| *** e0ne has joined #openstack-meeting-alt | 08:15 | |
| *** priteau has joined #openstack-meeting-alt | 08:50 | |
| *** links has joined #openstack-meeting-alt | 08:55 | |
| *** e0ne has quit IRC | 09:02 | |
| *** e0ne has joined #openstack-meeting-alt | 09:08 | |
| *** apetrich has quit IRC | 09:17 | |
| *** apetrich has joined #openstack-meeting-alt | 09:26 | |
| *** wxy has joined #openstack-meeting-alt | 09:31 | |
| *** Liang__ has quit IRC | 09:33 | |
| *** yaawang_ has quit IRC | 09:40 | |
| *** e0ne has quit IRC | 09:47 | |
| *** e0ne_ has joined #openstack-meeting-alt | 09:47 | |
| *** e0ne_ has quit IRC | 09:51 | |
| *** e0ne has joined #openstack-meeting-alt | 09:52 | |
| *** yamamoto has quit IRC | 10:01 | |
| *** yamamoto has joined #openstack-meeting-alt | 10:02 | |
| *** yamamoto has quit IRC | 10:02 | |
| *** derekh has joined #openstack-meeting-alt | 10:17 | |
| *** yaawang_ has joined #openstack-meeting-alt | 10:17 | |
| *** ttsiouts has quit IRC | 10:22 | |
| *** ttsiouts has joined #openstack-meeting-alt | 10:23 | |
| *** ttsiouts has quit IRC | 10:27 | |
| *** yamamoto has joined #openstack-meeting-alt | 10:38 | |
| *** yamamoto has quit IRC | 10:39 | |
| *** yamamoto has joined #openstack-meeting-alt | 10:40 | |
| *** e0ne has quit IRC | 10:42 | |
| *** e0ne has joined #openstack-meeting-alt | 10:43 | |
| *** e0ne has quit IRC | 10:44 | |
| *** e0ne has joined #openstack-meeting-alt | 10:45 | |
| *** e0ne has quit IRC | 10:46 | |
| *** e0ne has joined #openstack-meeting-alt | 10:46 | |
| *** yamamoto has quit IRC | 10:50 | |
| *** yamamoto has joined #openstack-meeting-alt | 11:00 | |
| *** derekh has quit IRC | 11:00 | |
| *** derekh has joined #openstack-meeting-alt | 11:00 | |
| *** purplerbot has joined #openstack-meeting-alt | 11:00 | |
| *** ttsiouts has joined #openstack-meeting-alt | 11:02 | |
| *** ttsiouts has quit IRC | 11:08 | |
| *** ttsiouts has joined #openstack-meeting-alt | 11:25 | |
| *** ttsiouts has quit IRC | 11:26 | |
| *** ttsiouts has joined #openstack-meeting-alt | 11:26 | |
| *** rfolco|rover has joined #openstack-meeting-alt | 11:36 | |
| *** tetsuro_ has joined #openstack-meeting-alt | 11:42 | |
| *** raildo has joined #openstack-meeting-alt | 11:44 | |
| *** tetsuro has quit IRC | 11:46 | |
| *** tetsuro_ has quit IRC | 11:51 | |
| *** tetsuro has joined #openstack-meeting-alt | 11:57 | |
| *** ttsiouts has quit IRC | 12:16 | |
| *** ttsiouts has joined #openstack-meeting-alt | 12:16 | |
| *** lkoranda has joined #openstack-meeting-alt | 12:19 | |
| *** lkoranda has quit IRC | 12:21 | |
| *** ttsiouts has quit IRC | 12:21 | |
| *** andrebeltrami has joined #openstack-meeting-alt | 12:24 | |
| *** ttsiouts has joined #openstack-meeting-alt | 12:25 | |
| *** lbragstad has joined #openstack-meeting-alt | 12:39 | |
| *** slaweq_ has joined #openstack-meeting-alt | 12:48 | |
| *** slaweq has quit IRC | 12:48 | |
| *** slaweq_ is now known as slaweq | 13:03 | |
| *** tetsuro has quit IRC | 13:15 | |
| *** ttsiouts has quit IRC | 13:18 | |
| *** ttsiouts has joined #openstack-meeting-alt | 13:19 | |
| *** ttsiouts has quit IRC | 13:19 | |
| *** ttsiouts has joined #openstack-meeting-alt | 13:19 | |
| *** e0ne has quit IRC | 13:37 | |
| *** e0ne has joined #openstack-meeting-alt | 13:37 | |
| *** priteau has quit IRC | 13:40 | |
| *** ricolin has quit IRC | 13:40 | |
| *** e0ne has quit IRC | 13:48 | |
| *** e0ne_ has joined #openstack-meeting-alt | 13:48 | |
| *** Liang__ has joined #openstack-meeting-alt | 13:52 | |
| *** Liang__ is now known as LiangFang | 13:53 | |
| *** rosmaita has joined #openstack-meeting-alt | 13:53 | |
| *** enriquetaso has joined #openstack-meeting-alt | 13:55 | |
| *** lpetrut has joined #openstack-meeting-alt | 13:56 | |
| *** priteau has joined #openstack-meeting-alt | 13:56 | |
| *** LiangFang has quit IRC | 13:57 | |
| *** eharney has joined #openstack-meeting-alt | 14:00 | |
| rosmaita | #startmeeting cinder | 14:00 |
|---|---|---|
| openstack | Meeting started Wed Jun 17 14:00:34 2020 UTC and is due to finish in 60 minutes. The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| *** openstack changes topic to " (Meeting topic: cinder)" | 14:00 | |
| openstack | The meeting name has been set to 'cinder' | 14:00 |
| enriquetaso | o/ | 14:00 |
| rosmaita | #topic roll call | 14:00 |
| *** openstack changes topic to "roll call (Meeting topic: cinder)" | 14:00 | |
| whoami-rajat | Hi | 14:00 |
| walshh_ | Hi | 14:00 |
| eharney | hi | 14:00 |
| enriquetaso | o/ | 14:00 |
| rajinir | hi | 14:00 |
| jungleboyj | o/ | 14:01 |
| *** tosky has joined #openstack-meeting-alt | 14:01 | |
| tosky | o/ | 14:01 |
| geguileo | hi! o/ | 14:01 |
| rosmaita | nice turnout! | 14:01 |
| rosmaita | #link https://etherpad.openstack.org/p/cinder-victoria-meetings | 14:01 |
| lseki | hi | 14:02 |
| rosmaita | #topic announcements | 14:02 |
| *** openstack changes topic to "announcements (Meeting topic: cinder)" | 14:02 | |
| smcginnis | o/ | 14:02 |
| rosmaita | thanks to everyone who filled out the poll to determine a good time for the virtual midcycle | 14:02 |
| rosmaita | which is next week! | 14:02 |
| rosmaita | the winner is:\ | 14:03 |
| rosmaita | Wednesday 24 June 1400-1600 UTC | 14:03 |
| rosmaita | so the first hour overlaps with the time of the usual cinder meeting | 14:03 |
| rosmaita | so everyone should be able to attend at least the first part | 14:03 |
| rosmaita | and we will need topics: | 14:03 |
| rosmaita | #link https://etherpad.opendev.org/p/cinder-victoria-mid-cycles | 14:04 |
| e0ne_ | hi | 14:04 |
| *** throne82_ has joined #openstack-meeting-alt | 14:04 | |
| rosmaita | since it's the week before spec freeze, anyone working on a spec who has questions or needs some guidance, the virtual midcycle would be a good place to get answers | 14:04 |
| rosmaita | anyone working on a spec should check out the virtual PTG etherpad | 14:05 |
| rosmaita | each spec was discussed, and there are comments on the etherpad | 14:05 |
| rosmaita | #link https://etherpad.opendev.org/p/victoria-ptg-cinder | 14:05 |
| rosmaita | and, of course, we can discuss other issues as well | 14:05 |
| hemna_ | mep | 14:05 |
| rosmaita | i know it's coming up fast, but this is a short cycle, and spec freeze is in 2 weeks | 14:06 |
| *** yamamoto has quit IRC | 14:06 | |
| whoami-rajat | rosmaita, we will have only 1 meeting right ? (of 2 hours) | 14:06 |
| jungleboyj | Crazy. | 14:07 |
| rosmaita | whoami-rajat: well, there will be part 2, but at week R-9 | 14:07 |
| rosmaita | so yes, just one meeting before spec freeze | 14:07 |
| whoami-rajat | rosmaita, yep. ack. | 14:07 |
| whoami-rajat | thanks | 14:07 |
| *** liuyulong has joined #openstack-meeting-alt | 14:07 | |
| rosmaita | #action rosmaita announcement to ML about virtual midcycle | 14:07 |
| rosmaita | we'll do bluejeans again as a videoconf technology | 14:08 |
| rosmaita | the other topic is that last time i looked, all devstack-based zuul jobs are broken | 14:08 |
| rosmaita | #link http://lists.openstack.org/pipermail/openstack-discuss/2020-June/015432.html | 14:09 |
| rosmaita | so recheck is futile until that's fixed | 14:09 |
| whoami-rajat | they've proposed a patch which is merged in master but when i looked at grenade failure, it shows error on previous code, not sure why | 14:09 |
| whoami-rajat | https://review.opendev.org/#/c/577955/27/lib/apache | 14:10 |
| tosky | the new uwsgi brought havoc | 14:10 |
| rosmaita | but the stable branches don't seem to be doing so well, either | 14:11 |
| tosky | whoami-rajat: grenade install the previous branch | 14:11 |
| rosmaita | #link https://zuul.opendev.org/t/openstack/builds?job_name=tempest-full# | 14:11 |
| smcginnis | I thought at least train was fixed as of yesterday. | 14:11 |
| tosky | so they sequence is: make grenade non-voting, make it non-voting also in the backport, fix the issue in the previous branch, reenable it | 14:11 |
| tosky | but yeah, until stein things should work, but not rocky | 14:12 |
| tosky | and queens | 14:12 |
| *** vishakha has quit IRC | 14:12 | |
| whoami-rajat | tosky, shouldn't it use the previous uwsgi version then? isn't it constrained for every release? | 14:12 |
| rosmaita | ok, so we think stein through master should work now? | 14:12 |
| whoami-rajat | i still see failure in my master patch i updated yesterday https://review.opendev.org/#/c/735513/ | 14:13 |
| *** gshippey_ has joined #openstack-meeting-alt | 14:13 | |
| tosky | uhm, but that was yesterday | 14:14 |
| tosky | whoami-rajat: this patch has recent results https://review.opendev.org/#/c/712832/ | 14:14 |
| rosmaita | hopefully ajaeger will send an update to the ML when everything is back to normal | 14:15 |
| rosmaita | #topic python2.7 compatibility issue | 14:15 |
| *** openstack changes topic to "python2.7 compatibility issue (Meeting topic: cinder)" | 14:15 | |
| whoami-rajat | oh, thanks tosky | 14:15 |
| *** enriquetaso has quit IRC | 14:15 | |
| *** knomura has joined #openstack-meeting-alt | 14:16 | |
| rosmaita | ok, so we've been talking about backports being more difficult now that master and ussuri are python3-only, and most of the stable branches are not | 14:16 |
| rosmaita | so, here's a case in point so we can see what we're up against | 14:16 |
| *** ttsiouts has quit IRC | 14:16 | |
| rosmaita | #link https://review.opendev.org/#/c/733100/ | 14:16 |
| rosmaita | open that link and take a look at the zuul results | 14:17 |
| *** enriquetaso has joined #openstack-meeting-alt | 14:17 | |
| *** ttsiouts has joined #openstack-meeting-alt | 14:17 | |
| rosmaita | also, since this is a driver change, there was third party ci run on it manually for stable/train | 14:17 |
| rosmaita | but, take alook at this: | 14:18 |
| rosmaita | #link https://review.opendev.org/#/c/733100/1/os_brick/privileged/scaleio.py | 14:18 |
| rosmaita | look at line 99 and think for a minute before opening the next link | 14:18 |
| rosmaita | #link https://launchpad.net/bugs/1883654 | 14:18 |
| openstack | Launchpad bug 1883654 in os-brick train "os-brick fail to get password from config file" [Undecided,In progress] - Assigned to hamza (alqtaishat) | 14:18 |
| rosmaita | so, you may remember hearing me say that we need to have good tests that will break on python3 only features | 14:19 |
| hemna_ | :( | 14:19 |
| rosmaita | and you may also notice that i +2'd the above patch | 14:19 |
| rosmaita | anyway, here's a test: | 14:20 |
| rosmaita | #link https://review.opendev.org/#/c/735989/6/os_brick/tests/privileged/test_scaleio.py | 14:20 |
| rosmaita | which is a 68 line test file to test a function that contains 4 statements | 14:20 |
| rosmaita | and i'm not even saying that's a great test | 14:20 |
| rosmaita | for instance, there's a pretty good chance that it doesn't work on windows | 14:20 |
| rosmaita | but, the point is that we need to up our test game | 14:21 |
| rosmaita | or at least i do :D | 14:21 |
| hemna_ | fwiw, there is no scaleio connector for windows | 14:21 |
| *** ttsiouts has quit IRC | 14:21 | |
| rosmaita | cool | 14:22 |
| rosmaita | but i guess this unit test would run anyway | 14:22 |
| whoami-rajat | i think i left a comment on master version of this patch regarding testing that method | 14:22 |
| rosmaita | the problem is using the tempfile | 14:22 |
| *** ttsiouts has joined #openstack-meeting-alt | 14:22 | |
| rosmaita | i believe you did | 14:22 |
| rosmaita | so bonus points for whoami-rajat | 14:23 |
| whoami-rajat | :D | 14:23 |
| whoami-rajat | we were just testing if the method was called but not going inside it | 14:23 |
| whoami-rajat | i'm not sure if it would've helped with this situation | 14:24 |
| enriquetaso | whoami-rajat++ | 14:24 |
| rosmaita | yeah, so the code wasn't completely un-tested | 14:24 |
| rosmaita | just not tested thoroughly enough | 14:24 |
| rosmaita | my main point is that reviewers should feel empowered to demand more tests | 14:25 |
| rosmaita | and reviewees need to be patient when more tests are demanded | 14:25 |
| whoami-rajat | rosmaita++ | 14:26 |
| rosmaita | any comments or observations before we move on? | 14:26 |
| rosmaita | i guess i have one more -- anyone guess why the third-party CI passed? | 14:26 |
| enriquetaso | I agree | 14:26 |
| rosmaita | because we made everyone move to Python 3!!! | 14:26 |
| eharney | :) | 14:27 |
| whoami-rajat | rosmaita, on stable branches also the CI running is py3? | 14:27 |
| whoami-rajat | i guess it's the same CI | 14:27 |
| rosmaita | so even if third-party CI is testing stable branches, we can't count on that to detect problems | 14:27 |
| rosmaita | ok, so in the next topic we can discuss why this is a particularly painful bug | 14:28 |
| rosmaita | #topic updating OSSN-0086 | 14:28 |
| *** openstack changes topic to "updating OSSN-0086 (Meeting topic: cinder)" | 14:28 | |
| rosmaita | ok, so the patch that introduced that bug is one of the patches addressing a security issue | 14:28 |
| rosmaita | the security issue had to be fixed in both cinder and os-brick | 14:29 |
| rosmaita | luckily, the cinder side of the fix doesn't contain this problem | 14:29 |
| rosmaita | (and hopefully doesn't contain a different one) | 14:29 |
| rosmaita | so, ussuri and master are python3 only, so we don't need to worry about those | 14:29 |
| rosmaita | but we do have T, S, R, and Q (plus some joker has proposed a backport from Q -> P) | 14:30 |
| rosmaita | at this point, ocata is dead to me, and pike is getting there | 14:30 |
| rosmaita | but we can discuss pike later | 14:30 |
| rosmaita | in the ossn, we promised to fix back to queens | 14:31 |
| rosmaita | so that's all i'm worried about now | 14:31 |
| rosmaita | here's the train patch, which still needs some work: | 14:31 |
| rosmaita | #link https://review.opendev.org/#/c/735989/ | 14:31 |
| rosmaita | in particular, smcginnis and jungleboyj please look at the release note on that patch | 14:32 |
| rosmaita | i tested locally, it will be a clean backport from T to S | 14:32 |
| rosmaita | so once we get train fixed, that will be big progress | 14:32 |
| jungleboyj | Ok. | 14:33 |
| rosmaita | so, the OSSN lists the patches. i will have to update it to include the new patch | 14:33 |
| rosmaita | we just released cinder and os-brick from train, i think we will have to do new releases? | 14:33 |
| *** yamamoto has joined #openstack-meeting-alt | 14:34 | |
| *** yamamoto has quit IRC | 14:34 | |
| rosmaita | so what we're looking at is: merge when gate is fixed, release new os-brick, wait for u-c change to merge, update cinder requirements, release new cinder | 14:34 |
| smcginnis | ++ | 14:34 |
| *** yamamoto has joined #openstack-meeting-alt | 14:34 | |
| rosmaita | ok, thanks, just wanted to make sure i wasn't being overly dramatic | 14:34 |
| jungleboyj | ++ | 14:34 |
| rosmaita | i'll include a similar release note on the new cinder release, just saying you only need to upgrade if you are using that particular backend and using python 2.7 | 14:35 |
| rosmaita | ok, so now when we get to Rocky and Queens, we don't release any more becuase they are in Extended Maintenance mode | 14:35 |
| rosmaita | the commit message for the cinder patch refers to the os-brick patch (which is now broken) | 14:36 |
| rosmaita | but it also mentions the OSSN, which i will update with the second brick patch | 14:37 |
| *** links has quit IRC | 14:37 | |
| rosmaita | and i think if the commit message on the second patch says "Fix regression", anyone grabbing the first patch will notice the second in the git log? | 14:37 |
| rosmaita | plus, i can send out an embarassing email to the ML giving operators a heads up | 14:38 |
| rosmaita | i guess that will take care of Rocky and Queens? | 14:38 |
| rosmaita | anyway, if anyone has a better suggestion, let me know | 14:38 |
| rosmaita | i am just thinking out loud here | 14:38 |
| rosmaita | so basically, what i really need is for stable cores to look for these patches | 14:39 |
| rosmaita | i will liberally ping people in IRC | 14:39 |
| jungleboyj | ++ | 14:39 |
| rosmaita | #topic expected behavior when the default volume type config option specifies a non-existent volume_type | 14:39 |
| *** openstack changes topic to "expected behavior when the default volume type config option specifies a non-existent volume_type (Meeting topic: cinder)" | 14:39 | |
| rosmaita | ok, the context is the work in Train to make sure that every volume has a volume_type | 14:40 |
| rosmaita | because we used to allow no type, and that caused problems | 14:41 |
| *** yamamoto has quit IRC | 14:41 | |
| rosmaita | so now we have __DEFAULT__ if an operator doesn't set a default type in the cinder conf | 14:41 |
| rosmaita | and we have a migration (i think in ussuri?) that makes any untyped volume __DEFAULT__ | 14:42 |
| rosmaita | (is that correct whoami-rajat ?) | 14:42 |
| whoami-rajat | rosmaita, yes | 14:42 |
| rosmaita | cool | 14:42 |
| whoami-rajat | basically it modifies the volumes,snapshots,encryption tables but yes | 14:42 |
| jungleboyj | Sounds familiar. :-) | 14:43 |
| rosmaita | ok, so there is a slight regression at the REST API layer (nothing to do with the database) | 14:43 |
| rosmaita | and in fixing that, i am having an argument with whoami-rajat about expected behavior | 14:43 |
| rosmaita | so the issue is that before train | 14:44 |
| rosmaita | if the operator mis-configured the default volume type | 14:44 |
| rosmaita | with a non-existent type | 14:44 |
| rosmaita | we would log a message, and let the build succeed with no volume type | 14:45 |
| hemna_ | the build ? | 14:45 |
| rosmaita | building the volume | 14:45 |
| rosmaita | the code in Train changes this so that instead of continuing the volume creation | 14:46 |
| rosmaita | an exception is raised, and no volume | 14:46 |
| enriquetaso | oh | 14:46 |
| rosmaita | i was thinking that the analog to the old behavior would be to allow the create to succeed, but with __DEFAULT__ as the volume type | 14:46 |
| eharney | failing the create is the right thing to do | 14:46 |
| whoami-rajat | #link https://review.opendev.org/#/c/639180/41/cinder/volume/volume_types.py | 14:46 |
| whoami-rajat | L#186 | 14:47 |
| hemna_ | I think failing is the right thing to do | 14:47 |
| rosmaita | well, except you get a 202 and only find out the volume create failed later | 14:47 |
| hemna_ | it's a misconfigured cinder | 14:47 |
| eharney | we want to fail the create because it also enables the case where an admin wants to make users select a volume type instead of defaulting to one | 14:47 |
| rosmaita | ok, what about this case | 14:48 |
| hemna_ | so the intention is to set an invalid default on purpose ? | 14:48 |
| rosmaita | no, but it's logged for the operator | 14:48 |
| rosmaita | all i'm saying is that we have __DEFAULT__, why not use it? | 14:48 |
| hemna_ | in eharney's case an invalid default is specified with no intention of fixing it ? | 14:48 |
| jungleboyj | The problem with failing is that it is an API change. Right? | 14:48 |
| eharney | do we check for an invalid volume type in the config at service start up? | 14:49 |
| rosmaita | not sure | 14:49 |
| rosmaita | the other place this will occur | 14:49 |
| whoami-rajat | i honestly don't remember exactly but this made sense as if we configure a wrong default type (the right one points to a specific backend) then the volumes will end up in a totally unexpected backend (with the __DEFAULT__ type) | 14:49 |
| hemna_ | failing should happen already for a volume type passed in that's invalid | 14:49 |
| jungleboyj | At one point in history we were checking bad defaults at start-up. | 14:49 |
| smcginnis | eharney: We probably should have a check on start up. | 14:49 |
| hemna_ | smcginnis +1 | 14:50 |
| rosmaita | ok, we can follow up with that | 14:50 |
| e0ne_ | smcginnis: +1. it's a good suggestion | 14:50 |
| jungleboyj | ++ | 14:50 |
| rosmaita | the other case is if a user creates a volume from an image | 14:50 |
| hemna_ | the only downside to that is that they have to start cinder w/o a default set, then create the volume type, then change the default in cinder.conf, then bounce cinder | 14:50 |
| rosmaita | you can put metadata on the image saying what volume type you want | 14:50 |
| hemna_ | vs w/o the start check, they can specify the missing type, then start cinder and create it. | 14:51 |
| rosmaita | and since that's done by end-users, they are bound to make mistakes | 14:51 |
| rosmaita | do we want to fail the build, or give them the default? | 14:51 |
| rosmaita | they used to get a successful build with no volume type | 14:52 |
| hemna_ | create should fail with invalid volume type | 14:52 |
| hemna_ | as it does today if you pass in an invalid type | 14:52 |
| eharney | yeah, i don't think we want to quietly use the default in the image case either | 14:52 |
| rosmaita | ok | 14:52 |
| hemna_ | we could do a check at startup and throw a warning | 14:53 |
| smcginnis | I agree. We either need to fail on startup, or we should fail the volume creation. | 14:53 |
| rosmaita | well, for the image case, we can't check at startup | 14:53 |
| jungleboyj | smcginnis: ++ | 14:53 |
| jungleboyj | Ok, then it sounds like we need to fail at creation. | 14:54 |
| rosmaita | ok, so the conclusion is: if a volume-type is mis-specified, we do not give you a default, we fail the create | 14:54 |
| eharney | yes | 14:54 |
| rosmaita | which actually makes sense | 14:54 |
| jungleboyj | Yes. | 14:54 |
| rosmaita | it's just different from pre-Train | 14:54 |
| whoami-rajat | but we already do it so we're fine :) | 14:55 |
| rosmaita | well, apparently we don't do it too much, or someone would have caught the bug earlier :) | 14:55 |
| eharney | for more justification: defaulting to a different type would be quite bad for someone who thinks they're using encrypted volumes but accidentally isn't | 14:55 |
| rosmaita | yeah, silently doing something that sort of works is never a good strategy | 14:56 |
| whoami-rajat | rosmaita, yep, that too! | 14:56 |
| rosmaita | i'll revise my patch to preserve the train behavior, then | 14:56 |
| rosmaita | ok, thanks for the discussion | 14:56 |
| rosmaita | #topic open discussion | 14:57 |
| *** openstack changes topic to "open discussion (Meeting topic: cinder)" | 14:57 | |
| rosmaita | LiangFang is having connection problems | 14:57 |
| rosmaita | but is asking people to please look at his patches for volume-local-cache | 14:57 |
| rosmaita | the brick patch is using six, which i think we don't want any more | 14:57 |
| rosmaita | but i forgot to actually leave that comment on the patch | 14:58 |
| jungleboyj | ++ | 14:58 |
| hemna_ | ok I'll take a look | 14:58 |
| rosmaita | hemna_ had some questions or observations in the cinder channel just before the meeting started | 14:58 |
| hemna_ | rosmaita thanks | 14:58 |
| enriquetaso | Hi, same request here for the NFS encryption patch https://review.opendev.org/#/c/597148/ | 14:58 |
| rosmaita | i had really good intentions to review both, but this unending security bug ate my time | 14:59 |
| hemna_ | so I was wondering why the volume's existing AZ isn't specified in the request spec during retype by default? | 14:59 |
| rosmaita | we will have to continue this in the cinder channel, horizon meets in 20 seconds | 14:59 |
| hemna_ | this ends up resulting in the scheduler picking a backend existing in a different AZ, which fails | 14:59 |
| hemna_ | heh ok | 14:59 |
| rosmaita | sorry about that | 15:00 |
| rosmaita | thanks everyone | 15:00 |
| rosmaita | #endmeeting | 15:00 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 15:00 | |
| enriquetaso | Thanks! | 15:00 |
| openstack | Meeting ended Wed Jun 17 15:00:15 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:00 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/cinder/2020/cinder.2020-06-17-14.00.html | 15:00 |
| whoami-rajat | thanks! | 15:00 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/cinder/2020/cinder.2020-06-17-14.00.txt | 15:00 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/cinder/2020/cinder.2020-06-17-14.00.log.html | 15:00 |
| jungleboyj | Thanks! | 15:00 |
| e0ne_ | #startmeeting horizon | 15:00 |
| openstack | Meeting started Wed Jun 17 15:00:37 2020 UTC and is due to finish in 60 minutes. The chair is e0ne_. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| *** openstack changes topic to " (Meeting topic: horizon)" | 15:00 | |
| openstack | The meeting name has been set to 'horizon' | 15:00 |
| vishalmanchanda | hi. | 15:01 |
| *** ttsiouts has quit IRC | 15:01 | |
| e0ne_ | hi | 15:01 |
| *** ttsiouts has joined #openstack-meeting-alt | 15:01 | |
| *** senrique_ has joined #openstack-meeting-alt | 15:01 | |
| e0ne_ | let's wait few minutes before start | 15:02 |
| *** enriquetaso has quit IRC | 15:05 | |
| e0ne_ | #topic Notices | 15:05 |
| *** openstack changes topic to "Notices (Meeting topic: horizon)" | 15:05 | |
| vishalmanchanda | let's start. | 15:05 |
| e0ne_ | vishalmanchanda: +1 | 15:05 |
| e0ne_ | courteous ping to amotoki | 15:06 |
| *** ttsiouts has quit IRC | 15:06 | |
| e0ne_ | this week we're reaching Victoria-1 milestone | 15:06 |
| *** rdopiera has joined #openstack-meeting-alt | 15:06 | |
| e0ne_ | #link https://releases.openstack.org/victoria/schedule.html | 15:06 |
| e0ne_ | I know, it's fast | 15:07 |
| e0ne_ | it's because this cycle is a bit shorter as usual | 15:07 |
| rdopiera | sorry, I didn't realize I got kicked into openstack-unauthenticated | 15:07 |
| e0ne_ | rdopiera: hi | 15:07 |
| e0ne_ | I'll cut horizon release tomorrow just to bump requirements for plugin | 15:07 |
| e0ne_ | *plugins | 15:08 |
| e0ne_ | vishalmanchanda: or you can do it yourself as a release liaison :) | 15:08 |
| vishalmanchanda | e0ne_: sure I will do that. | 15:08 |
| e0ne_ | that's all updates I've got this week | 15:09 |
| e0ne_ | I'll update our priorities list https://etherpad.opendev.org/p/horizon-release-priorities asap according to PTG discussions | 15:09 |
| e0ne_ | #topic Open Discussion | 15:10 |
| *** openstack changes topic to "Open Discussion (Meeting topic: horizon)" | 15:10 | |
| e0ne_ | do we have anything more to discuss? | 15:10 |
| *** knomura has quit IRC | 15:10 | |
| vishalmanchanda | e0ne_: yup. | 15:10 |
| vishalmanchanda | e0ne_: I have seen your comments on this patch https://review.opendev.org/#/c/708069/ | 15:11 |
| vishalmanchanda | e0ne_: thanks for reviewing it. It is the same what i have investigated so far. | 15:11 |
| e0ne_ | vishalmanchanda: yea.. I've finally tested it :) | 15:12 |
| vishalmanchanda | Now there is one problem with that i am unable to figure out how can we send details variable in this template https://review.opendev.org/#/c/708069/11/horizon/templates/horizon/_messages.html | 15:12 |
| *** knomura has joined #openstack-meeting-alt | 15:13 | |
| e0ne_ | vishalmanchanda: we can use this https://docs.djangoproject.com/en/3.0/ref/templates/builtins/#with | 15:13 |
| *** rosmaita has left #openstack-meeting-alt | 15:14 | |
| vishalmanchanda | e0ne_: I have tried to do the same what we have done here https://review.opendev.org/#/c/708069/11/horizon/static/horizon/js/horizon.messages.js@42. | 15:14 |
| vishalmanchanda | e0ne_: Ok I will take a look. | 15:14 |
| vishalmanchanda | e0ne_: But now you know the problem:). | 15:16 |
| vishalmanchanda | that's good. | 15:16 |
| e0ne_ | vishalmanchanda: another option is to use own middleware based on django.contrib.messages.middleware.MessageMiddleware | 15:16 |
| e0ne_ | vishalmanchanda: +1 | 15:16 |
| vishalmanchanda | hmm. | 15:16 |
| *** ttsiouts has joined #openstack-meeting-alt | 15:17 | |
| *** knomura has quit IRC | 15:17 | |
| vishalmanchanda | Also, I have pushed initial patch for cinder-user facing messages https://review.opendev.org/#/c/734161/ | 15:17 |
| e0ne_ | we can use custom middleware with a custom message class. I can try to do a PoC for it | 15:18 |
| vishalmanchanda | It is working fine and now I have to add some tests. | 15:18 |
| vishalmanchanda | e0ne_: thanks:) | 15:18 |
| e0ne_ | vishalmanchanda: awesome! I'm downloading it for tests now | 15:18 |
| *** knomura has joined #openstack-meeting-alt | 15:19 | |
| vishalmanchanda | that's all I have. | 15:20 |
| e0ne_ | thanks everybody for your contributions! see you next week! | 15:22 |
| vishalmanchanda | thanks! | 15:23 |
| e0ne_ | #endmeeting | 15:23 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 15:23 | |
| openstack | Meeting ended Wed Jun 17 15:23:26 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:23 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/horizon/2020/horizon.2020-06-17-15.00.html | 15:23 |
| *** knomura has quit IRC | 15:23 | |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/horizon/2020/horizon.2020-06-17-15.00.txt | 15:23 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/horizon/2020/horizon.2020-06-17-15.00.log.html | 15:23 |
| *** knomura has joined #openstack-meeting-alt | 15:24 | |
| *** knomura_ has joined #openstack-meeting-alt | 15:26 | |
| *** knomura has quit IRC | 15:29 | |
| *** knomura_ has quit IRC | 15:31 | |
| *** ttsiouts has quit IRC | 15:33 | |
| *** ttsiouts has joined #openstack-meeting-alt | 15:33 | |
| *** ttsiouts has quit IRC | 15:38 | |
| *** e0ne_ has quit IRC | 15:40 | |
| *** e0ne has joined #openstack-meeting-alt | 15:46 | |
| *** gyee has joined #openstack-meeting-alt | 15:58 | |
| *** e0ne has quit IRC | 16:01 | |
| *** senrique_ has quit IRC | 16:15 | |
| *** enriquetaso has joined #openstack-meeting-alt | 16:28 | |
| *** liuyulong has quit IRC | 16:56 | |
| *** diablo_rojo has joined #openstack-meeting-alt | 16:59 | |
| *** derekh has quit IRC | 17:01 | |
| *** lpetrut has quit IRC | 17:02 | |
| *** e0ne has joined #openstack-meeting-alt | 17:03 | |
| *** knomura has joined #openstack-meeting-alt | 17:25 | |
| *** knomura_ has joined #openstack-meeting-alt | 17:27 | |
| *** knomura__ has joined #openstack-meeting-alt | 17:29 | |
| *** knomura has quit IRC | 17:29 | |
| *** knomura__ has quit IRC | 17:31 | |
| *** knomura has joined #openstack-meeting-alt | 17:31 | |
| *** knomura_ has quit IRC | 17:31 | |
| *** knomura_ has joined #openstack-meeting-alt | 17:35 | |
| *** knomura has quit IRC | 17:35 | |
| *** knomura_ has quit IRC | 17:35 | |
| *** knomura has joined #openstack-meeting-alt | 17:36 | |
| *** knomura has quit IRC | 17:37 | |
| *** knomura has joined #openstack-meeting-alt | 17:38 | |
| *** knomura_ has joined #openstack-meeting-alt | 17:42 | |
| *** knomura has quit IRC | 17:42 | |
| *** e0ne has quit IRC | 17:43 | |
| *** knomura_ has quit IRC | 17:43 | |
| *** knomura has joined #openstack-meeting-alt | 17:43 | |
| *** knomura has quit IRC | 17:44 | |
| *** knomura has joined #openstack-meeting-alt | 17:44 | |
| *** knomura has quit IRC | 17:49 | |
| *** knomura has joined #openstack-meeting-alt | 17:51 | |
| *** knomura has quit IRC | 17:54 | |
| *** knomura has joined #openstack-meeting-alt | 17:55 | |
| *** knomura has quit IRC | 18:00 | |
| *** throne82_ has quit IRC | 18:13 | |
| *** jamesmcarthur has joined #openstack-meeting-alt | 18:47 | |
| *** jamesmcarthur has quit IRC | 18:54 | |
| *** jamesmcarthur has joined #openstack-meeting-alt | 18:55 | |
| *** jamesmcarthur_ has joined #openstack-meeting-alt | 18:59 | |
| *** jamesmcarthur has quit IRC | 19:01 | |
| *** rdopiera has quit IRC | 19:04 | |
| *** ralonsoh has quit IRC | 19:22 | |
| *** knomura has joined #openstack-meeting-alt | 19:22 | |
| *** knomura has quit IRC | 19:27 | |
| *** ttsiouts has joined #openstack-meeting-alt | 19:32 | |
| *** knomura has joined #openstack-meeting-alt | 19:38 | |
| *** vishalmanchanda has quit IRC | 19:38 | |
| *** knomura has quit IRC | 19:39 | |
| *** knomura has joined #openstack-meeting-alt | 19:39 | |
| *** ttsiouts has quit IRC | 19:42 | |
| *** ttsiouts has joined #openstack-meeting-alt | 19:43 | |
| *** knomura has quit IRC | 19:44 | |
| *** knomura has joined #openstack-meeting-alt | 19:44 | |
| *** jamesmcarthur_ has quit IRC | 19:45 | |
| *** knomura has quit IRC | 19:45 | |
| *** jamesmcarthur has joined #openstack-meeting-alt | 19:46 | |
| *** ttsiouts has quit IRC | 19:47 | |
| *** knomura_ has joined #openstack-meeting-alt | 19:47 | |
| *** knomura_ has quit IRC | 19:48 | |
| *** knomura_ has joined #openstack-meeting-alt | 19:50 | |
| *** knomura_ has quit IRC | 19:51 | |
| *** knomura has joined #openstack-meeting-alt | 19:52 | |
| *** knomura_ has joined #openstack-meeting-alt | 19:53 | |
| *** knomura has quit IRC | 19:56 | |
| *** knomura_ has quit IRC | 19:57 | |
| *** knomura has joined #openstack-meeting-alt | 20:01 | |
| *** knomura has quit IRC | 20:03 | |
| *** knomura_ has joined #openstack-meeting-alt | 20:05 | |
| *** knomura_ has quit IRC | 20:06 | |
| *** knomura has joined #openstack-meeting-alt | 20:06 | |
| *** senrique_ has joined #openstack-meeting-alt | 20:08 | |
| *** knomura has quit IRC | 20:08 | |
| *** knomura has joined #openstack-meeting-alt | 20:08 | |
| *** tsmith_ has joined #openstack-meeting-alt | 20:09 | |
| *** senrique_ has quit IRC | 20:09 | |
| *** enriquetaso has quit IRC | 20:10 | |
| *** timirnich_ has joined #openstack-meeting-alt | 20:11 | |
| *** tobberydberg_ has joined #openstack-meeting-alt | 20:12 | |
| *** tosky_ has joined #openstack-meeting-alt | 20:12 | |
| *** knomura has quit IRC | 20:13 | |
| *** tosky has quit IRC | 20:13 | |
| *** tosky_ is now known as tosky | 20:13 | |
| *** irclogbot_1 has quit IRC | 20:14 | |
| *** gyee has quit IRC | 20:17 | |
| *** purplerbot has quit IRC | 20:18 | |
| *** tobberydberg has quit IRC | 20:18 | |
| *** masayukig has quit IRC | 20:18 | |
| *** timirnich has quit IRC | 20:18 | |
| *** tsmith2 has quit IRC | 20:18 | |
| *** timirnich_ is now known as timirnich | 20:18 | |
| *** tsmith_ is now known as tsmith2 | 20:19 | |
| *** irclogbot_1 has joined #openstack-meeting-alt | 20:21 | |
| *** purplerbot has joined #openstack-meeting-alt | 20:23 | |
| *** masayukig has joined #openstack-meeting-alt | 20:24 | |
| *** enriquetaso has joined #openstack-meeting-alt | 20:26 | |
| *** gyee has joined #openstack-meeting-alt | 20:31 | |
| *** jamesmcarthur has quit IRC | 20:31 | |
| *** jamesmcarthur has joined #openstack-meeting-alt | 20:32 | |
| *** srwilkers has quit IRC | 20:35 | |
| *** timirnich has quit IRC | 20:36 | |
| *** jamesmcarthur has quit IRC | 20:37 | |
| *** dviroel has quit IRC | 20:39 | |
| *** knikolla has quit IRC | 20:40 | |
| *** knikolla has joined #openstack-meeting-alt | 20:42 | |
| *** timirnich has joined #openstack-meeting-alt | 20:43 | |
| *** dviroel has joined #openstack-meeting-alt | 20:44 | |
| *** timirnich has quit IRC | 20:48 | |
| *** priteau has quit IRC | 20:49 | |
| *** thgcorrea has quit IRC | 20:50 | |
| *** knikolla has quit IRC | 20:52 | |
| *** ttsiouts has joined #openstack-meeting-alt | 20:52 | |
| *** dviroel has quit IRC | 20:55 | |
| *** dviroel has joined #openstack-meeting-alt | 20:57 | |
| *** ttsiouts has quit IRC | 20:57 | |
| *** dviroel has quit IRC | 21:03 | |
| *** e0ne has joined #openstack-meeting-alt | 21:03 | |
| *** jamesmcarthur has joined #openstack-meeting-alt | 21:04 | |
| *** dviroel has joined #openstack-meeting-alt | 21:09 | |
| *** rfolco|rover has quit IRC | 21:12 | |
| *** jamesmcarthur has quit IRC | 21:13 | |
| *** dviroel has quit IRC | 21:17 | |
| *** srwilkers has joined #openstack-meeting-alt | 21:34 | |
| *** timirnich has joined #openstack-meeting-alt | 21:35 | |
| *** tosky has left #openstack-meeting-alt | 21:35 | |
| *** knikolla has joined #openstack-meeting-alt | 21:40 | |
| *** slaweq has quit IRC | 21:41 | |
| *** dviroel has joined #openstack-meeting-alt | 21:41 | |
| *** raildo has quit IRC | 21:42 | |
| *** gshippey_ has quit IRC | 21:42 | |
| *** jamesmcarthur has joined #openstack-meeting-alt | 21:50 | |
| *** jamesmcarthur has quit IRC | 21:54 | |
| *** e0ne has quit IRC | 22:19 | |
| *** knomura has joined #openstack-meeting-alt | 22:35 | |
| *** knomura has quit IRC | 22:39 | |
| *** rcernin has joined #openstack-meeting-alt | 22:42 | |
| *** gyee has quit IRC | 22:52 | |
| *** andrebeltrami has quit IRC | 23:53 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!