| *** tosky has quit IRC | 00:01 | |
| *** ianychoi has joined #openstack-meeting-alt | 00:14 | |
| *** macz_ has quit IRC | 00:15 | |
| *** knomura has joined #openstack-meeting-alt | 01:03 | |
| *** kevinz has joined #openstack-meeting-alt | 01:03 | |
| *** knomura has quit IRC | 01:08 | |
| *** jamesmcarthur has quit IRC | 01:13 | |
| *** jamesmcarthur has joined #openstack-meeting-alt | 01:15 | |
| *** jamesmcarthur has quit IRC | 01:36 | |
| *** jamesmcarthur has joined #openstack-meeting-alt | 01:38 | |
| *** jamesmcarthur has quit IRC | 01:43 | |
| *** jamesmcarthur has joined #openstack-meeting-alt | 01:48 | |
| *** tmazur has quit IRC | 01:50 | |
| *** baojg has joined #openstack-meeting-alt | 01:52 | |
| *** knomura has joined #openstack-meeting-alt | 01:54 | |
| *** knomura has quit IRC | 01:58 | |
| *** knomura has joined #openstack-meeting-alt | 02:15 | |
| *** macz_ has joined #openstack-meeting-alt | 02:16 | |
| *** knomura has quit IRC | 02:19 | |
| *** macz_ has quit IRC | 02:21 | |
| *** zzzeek has quit IRC | 02:30 | |
| *** zzzeek has joined #openstack-meeting-alt | 02:31 | |
| *** zzzeek has quit IRC | 02:36 | |
| *** zzzeek has joined #openstack-meeting-alt | 02:40 | |
| *** jamesmcarthur has quit IRC | 02:57 | |
| *** jamesmcarthur has joined #openstack-meeting-alt | 02:57 | |
| *** rcernin has quit IRC | 02:57 | |
| *** enriquetaso has joined #openstack-meeting-alt | 03:02 | |
| *** jamesmcarthur has quit IRC | 03:03 | |
| *** rcernin has joined #openstack-meeting-alt | 03:18 | |
| *** rcernin has quit IRC | 03:21 | |
| *** rcernin has joined #openstack-meeting-alt | 03:21 | |
| *** jamesmcarthur has joined #openstack-meeting-alt | 03:29 | |
| *** ricolin_ has joined #openstack-meeting-alt | 03:39 | |
| *** ricolin_ has quit IRC | 03:54 | |
| *** jamesmcarthur has quit IRC | 04:07 | |
| *** enriquetaso has quit IRC | 04:15 | |
| *** rcernin has quit IRC | 04:35 | |
| *** rcernin has joined #openstack-meeting-alt | 04:35 | |
| *** kiwi_36 has joined #openstack-meeting-alt | 04:40 | |
| *** gyee has quit IRC | 05:08 | |
| *** vishalmanchanda has joined #openstack-meeting-alt | 05:11 | |
| *** miniroy has joined #openstack-meeting-alt | 05:38 | |
| *** rcernin_ has joined #openstack-meeting-alt | 05:42 | |
| *** rcernin has quit IRC | 05:42 | |
| *** miniroy has quit IRC | 05:45 | |
| *** jamesmcarthur has joined #openstack-meeting-alt | 06:04 | |
| *** jamesmcarthur has quit IRC | 06:09 | |
| *** e0ne has joined #openstack-meeting-alt | 06:31 | |
| *** e0ne has quit IRC | 06:49 | |
| *** ralonsoh has joined #openstack-meeting-alt | 07:19 | |
| *** zzzeek has quit IRC | 07:28 | |
| *** rcernin_ has quit IRC | 07:28 | |
| *** zzzeek has joined #openstack-meeting-alt | 07:31 | |
| *** sfernand has quit IRC | 07:53 | |
| *** e0ne has joined #openstack-meeting-alt | 07:54 | |
| *** e0ne has quit IRC | 07:54 | |
| *** e0ne has joined #openstack-meeting-alt | 07:55 | |
| *** e0ne has quit IRC | 07:55 | |
| *** slaweq has joined #openstack-meeting-alt | 07:59 | |
| *** diablo_rojo__ has quit IRC | 08:01 | |
| *** slaweq has quit IRC | 08:04 | |
| *** rcernin_ has joined #openstack-meeting-alt | 08:06 | |
| *** slaweq has joined #openstack-meeting-alt | 08:10 | |
| *** e0ne has joined #openstack-meeting-alt | 08:21 | |
| *** e0ne has quit IRC | 08:22 | |
| *** rcernin_ has quit IRC | 08:26 | |
| *** tosky has joined #openstack-meeting-alt | 08:39 | |
| *** e0ne has joined #openstack-meeting-alt | 09:00 | |
| *** rfolco has joined #openstack-meeting-alt | 09:05 | |
| *** jamesmcarthur has joined #openstack-meeting-alt | 09:06 | |
| *** rdopiera has joined #openstack-meeting-alt | 09:16 | |
| *** e0ne has quit IRC | 09:20 | |
| *** e0ne has joined #openstack-meeting-alt | 09:21 | |
| *** e0ne has quit IRC | 09:25 | |
| *** e0ne has joined #openstack-meeting-alt | 09:26 | |
| *** e0ne has quit IRC | 09:26 | |
| *** jamesmcarthur has quit IRC | 09:28 | |
| *** derekh has joined #openstack-meeting-alt | 09:35 | |
| *** raildo has joined #openstack-meeting-alt | 12:16 | |
| *** knomura has joined #openstack-meeting-alt | 12:35 | |
| *** vishalmanchanda has quit IRC | 13:01 | |
| *** jamesmcarthur has joined #openstack-meeting-alt | 13:26 | |
| *** jamesmcarthur has quit IRC | 13:30 | |
| *** whoami-rajat__ has joined #openstack-meeting-alt | 13:46 | |
| *** michael-mcaleer has joined #openstack-meeting-alt | 13:48 | |
| *** e0ne has joined #openstack-meeting-alt | 13:55 | |
| *** rosmaita has joined #openstack-meeting-alt | 13:59 | |
| rosmaita | #startmeeting cinder | 14:00 |
|---|---|---|
| openstack | Meeting started Wed Jan 13 14:00:39 2021 UTC and is due to finish in 60 minutes. The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| *** openstack changes topic to " (Meeting topic: cinder)" | 14:00 | |
| openstack | The meeting name has been set to 'cinder' | 14:00 |
| rosmaita | #topic roll call | 14:00 |
| *** openstack changes topic to "roll call (Meeting topic: cinder)" | 14:00 | |
| michael-mcaleer | hi! | 14:00 |
| eharney | hi | 14:01 |
| whoami-rajat__ | Hi | 14:01 |
| tosky | o/ | 14:01 |
| e0ne | hi | 14:01 |
| rosmaita | hoping we get a few more people | 14:01 |
| *** enriquetaso has joined #openstack-meeting-alt | 14:01 | |
| *** liuyulong has joined #openstack-meeting-alt | 14:02 | |
| geguileo | hi! | 14:02 |
| rosmaita | ok, now we can start! :D | 14:03 |
| *** liuyulong has quit IRC | 14:03 | |
| rosmaita | #link https://etherpad.opendev.org/p/cinder-wallaby-meetings | 14:03 |
| rosmaita | #topic announcements | 14:03 |
| *** openstack changes topic to "announcements (Meeting topic: cinder)" | 14:03 | |
| jungleboyj | o/ | 14:03 |
| rosmaita | ok, as we discussed last week, the new driver merge deadline is milestone-2 | 14:03 |
| rosmaita | which is next week | 14:03 |
| enriquetaso | hi | 14:03 |
| rosmaita | so review priority is DRIVERS | 14:03 |
| rosmaita | #link http://lists.openstack.org/pipermail/openstack-discuss/2021-January/019720.html | 14:04 |
| rosmaita | also, that email missed a backup driver for S3 | 14:04 |
| rosmaita | which was proposed a while ago but has been sitting | 14:05 |
| rosmaita | finally found the link | 14:05 |
| rosmaita | #link https://review.opendev.org/c/openstack/cinder/+/746561 | 14:05 |
| rosmaita | that review requires a change to global-requirements | 14:06 |
| rosmaita | which has been approved by the requirements team | 14:06 |
| rosmaita | though currently Zuul disagrees | 14:06 |
| rosmaita | in any case, we can assume that the requirement is approved, so no reason to hold up reviews on that patch | 14:06 |
| e0ne | great! will review and test it | 14:07 |
| rosmaita | excellent! | 14:07 |
| rosmaita | i don't need to remind people that all you need to do is look at the cinder logo to see how important backends are to cinder | 14:07 |
| rosmaita | so these are the most important reviews right now | 14:07 |
| jungleboyj | :-) | 14:07 |
| rosmaita | and i will gently remind people who have other patches posted, that you can please review other peoples' patches to move things along | 14:08 |
| rosmaita | the email linked above has a link to the cinder docs, where we have a new driver review checklist that can guide you along | 14:08 |
| rosmaita | any questions or comments? | 14:09 |
| jungleboyj | Remind me when the deadline is? | 14:09 |
| rosmaita | not tomorrow, but the thursday after that | 14:09 |
| rosmaita | yeah | 14:09 |
| rosmaita | it is very close | 14:09 |
| jungleboyj | Ok. | 14:09 |
| rosmaita | only other announcement is the status of the cursive library | 14:10 |
| rosmaita | oslo has agreed to take over governance, and oslo and barbican will share core duties | 14:11 |
| rosmaita | (at least i think that's what they said) | 14:11 |
| rosmaita | (possibly shared governance) | 14:11 |
| rosmaita | in any case, the important point is that it will be brought back into the 'openstack' namespace | 14:11 |
| rosmaita | and we will have active, identifiable core reviewers to contact if we need to patch it | 14:12 |
| rosmaita | #topic Wallaby R-13 Bug Review | 14:13 |
| *** openstack changes topic to "Wallaby R-13 Bug Review (Meeting topic: cinder)" | 14:13 | |
| michael-mcaleer | thanks rosmaita | 14:13 |
| rosmaita | #link https://etherpad.opendev.org/p/cinder-wallaby-r13-bug-review | 14:13 |
| michael-mcaleer | quiet week again this week, only 2 bugs opened, one for cinder and one for python cinderlib | 14:13 |
| michael-mcaleer | bug_1: volume manager under reports allocated space #link https://bugs.launchpad.net/cinder/+bug/1910767 | 14:13 |
| openstack | Launchpad bug 1910767 in Cinder "volume manager under reports allocated space" [Medium,Triaged] | 14:13 |
| michael-mcaleer | I have set this to medium importance but it may warrant high, underreporting of allocated capacity could be very problematic | 14:14 |
| eharney | does this impact anything after the service has been up and running for a few minutes? (i.e. when volume stats have been gathered again) | 14:14 |
| michael-mcaleer | I had assumed that the periodic status check that go to the drivers would update the capacities also | 14:15 |
| eharney | i assume not, so it probably doesn't need to be a high prio bug | 14:15 |
| rosmaita | i agree with eharney here | 14:16 |
| michael-mcaleer | no problem, it was opened by waltboring so we might hear from him in the future about it | 14:16 |
| rosmaita | i wonder if there was a reason why it was implemented like this | 14:17 |
| rosmaita | i mean | 14:17 |
| rosmaita | only look at those 2 statuses at init | 14:17 |
| rosmaita | and then get better stats later | 14:17 |
| eharney | i kind of doubt it | 14:17 |
| jungleboyj | hemna: ^^^ | 14:18 |
| whoami-rajat__ | i think those are the 2 valid states right? other states may end up in error | 14:18 |
| rosmaita | ok, we can discuss on the bug report | 14:19 |
| michael-mcaleer | moving on to the next and final bug | 14:20 |
| michael-mcaleer | bug_2: Can't get volume usage #link https://bugs.launchpad.net/python-cinderclient/+bug/1911390 | 14:20 |
| openstack | Launchpad bug 1911390 in python-cinderclient "Can't get volume usage" [Wishlist,Triaged] | 14:20 |
| michael-mcaleer | this isnt a bug, more of a misinterpretation of what is returned to users, but I set it to wishlist incase its something that may be looked at in the future | 14:20 |
| eharney | if we want to keep it as wishlist it needs more detail about what it means | 14:20 |
| eharney | because i'm not sure what the complaint/request actually is | 14:21 |
| geguileo | and that's not something that's easy to report | 14:21 |
| michael-mcaleer | I read it like the user wanted/expected to get used capacity back | 14:21 |
| geguileo | if you have thin volumes and deduplication/compression on the backend... | 14:21 |
| eharney | i don't think we want to support that | 14:21 |
| geguileo | eharney: +1 | 14:21 |
| michael-mcaleer | geguileo I agree, from a driver maintainer perspective we would need to have a call that goes to our management server to get the current capacity | 14:21 |
| michael-mcaleer | and its not always black & white | 14:22 |
| geguileo | yeah, and it probably wouldn't be the same between different backends | 14:23 |
| eharney | i'd vote for "Won't Fix" | 14:23 |
| michael-mcaleer | ok, any objections to moving to wont fix? | 14:23 |
| e0ne | eharney: +1 | 14:24 |
| michael-mcaleer | ill change that now, thanks everyone | 14:24 |
| whoami-rajat__ | eharney +1 | 14:24 |
| rosmaita | you can say in the comment that they can provide more clarity about what exactly they are asking | 14:24 |
| rosmaita | if they object | 14:24 |
| michael-mcaleer | no prob ill do that | 14:24 |
| geguileo | +1 to won't fix, but with proper explanation on why we won't be fixing it | 14:24 |
| *** tmazur has joined #openstack-meeting-alt | 14:24 | |
| michael-mcaleer | does someone want to make that an action item for themselves with a proper explanation? | 14:25 |
| rosmaita | maybe ask for clarity first so we know what we're explaining | 14:25 |
| michael-mcaleer | will do ill ask that | 14:26 |
| michael-mcaleer | thats it from me this week, thanks everyone | 14:26 |
| rosmaita | thanks! | 14:26 |
| rosmaita | #topic Stable releases | 14:27 |
| *** openstack changes topic to "Stable releases (Meeting topic: cinder)" | 14:27 | |
| rosmaita | whoami-rajat__: that's you | 14:27 |
| whoami-rajat__ | thanks rosmaita | 14:27 |
| whoami-rajat__ | this is just a reminder that tomorrow is the last date for cycle-trailing releases | 14:27 |
| whoami-rajat__ | for us, it's cinderlib | 14:27 |
| whoami-rajat__ | a patch is blocking it and we need to finalize if we want to include it in the cinderlib victoria release or not | 14:28 |
| whoami-rajat__ | #link https://review.opendev.org/c/openstack/cinderlib/+/768533 | 14:28 |
| whoami-rajat__ | geguileo: ^^ need your opinion on the same | 14:28 |
| rosmaita | my question is that i think stable/vic cinderlib should be using stable/vic os-brick | 14:29 |
| rosmaita | is that a correct assumption? | 14:29 |
| e0ne | +1 | 14:29 |
| rosmaita | otherwise, there wouldn't seem to be any point in having stable cinderlib branches | 14:29 |
| e0ne | at least, it sounds like a right way to do | 14:30 |
| tosky | talking about stable releases, and even knowing that drivers have the highest review priority, there is a good amount of (I believe) clean backports that could get some attention | 14:30 |
| rosmaita | i think geguileo may be in another meeting | 14:31 |
| whoami-rajat__ | seems like that | 14:31 |
| whoami-rajat__ | i can ask him after the meeting | 14:32 |
| rosmaita | ok, otherwise, i think we merge https://review.opendev.org/c/openstack/cinderlib/+/768533 and update the hash for release | 14:32 |
| rosmaita | according to herve, there's a good chance the release publish job will fail without that change | 14:33 |
| rosmaita | or something like it, anyway | 14:33 |
| rosmaita | any comments or questions? | 14:33 |
| whoami-rajat__ | ack, should i go forward and merge it now? | 14:33 |
| eharney | maybe | 14:33 |
| whoami-rajat__ | it already has 2 +2s | 14:33 |
| eharney | i think the note about os-brick in the commit message doesn't match what's in the reqs? | 14:34 |
| rosmaita | i think you are correct | 14:35 |
| eharney | it says os-brick 4.0.1 but still only requires 2.7.0 | 14:35 |
| *** vishalmanchanda has joined #openstack-meeting-alt | 14:35 | |
| rosmaita | ok, i need to fix that | 14:36 |
| rosmaita | good catch | 14:36 |
| rosmaita | i'll check offline to make sure the l-c still work (pretty sure they will, but you never know) | 14:37 |
| rosmaita | look for a new patch set right after the meeting | 14:37 |
| geguileo | rosmaita: yes, sorry, I'm on another meeting. I'll review your updated patch later | 14:38 |
| rosmaita | thanks! | 14:38 |
| rosmaita | whoami-rajat__: anything else? | 14:38 |
| whoami-rajat__ | that's all from me | 14:38 |
| whoami-rajat__ | thanks! | 14:38 |
| rosmaita | great, thank you | 14:38 |
| rosmaita | #topic open discussion | 14:38 |
| *** openstack changes topic to "open discussion (Meeting topic: cinder)" | 14:39 | |
| rosmaita | if nobody has anything, this is 20 minutes of review time!!! | 14:39 |
| e0ne | just kindly ask for review https://review.opendev.org/c/openstack/cinder/+/767581 | 14:40 |
| e0ne | it has +2 from hemna | 14:40 |
| eharney | https://review.opendev.org/c/openstack/cinder/+/769552 had the lio-barbican job failing until someone said "I've never seen this many consecutive successful runs" | 14:40 |
| eharney | :) | 14:40 |
| eharney | had the lio-barbican job passing* | 14:40 |
| rosmaita | although apparently i spoke too soon, last run timed out! | 14:41 |
| rosmaita | but i still think it's worth merging, would seem to reduce the number of rechecks | 14:42 |
| whoami-rajat__ | i was going through bug https://bugs.launchpad.net/cinder/+bug/1873234 , and realised the default rpc timeout for cinder is changed from 60 to 120 secs here https://review.opendev.org/c/openstack/devstack/+/768323 | 14:43 |
| openstack | Launchpad bug 1873234 in devstack "lvchange -a causing RPC timeouts between c-api and c-vol on inap hosts in CI" [Undecided,New] | 14:43 |
| *** jamesmcarthur has joined #openstack-meeting-alt | 14:44 | |
| eharney | not really sure how lv activation could take 81 seconds unless there's something really wrong with that node, that seems odd | 14:44 |
| eharney | probably should read syslog when that occurs to see what it's doing | 14:45 |
| whoami-rajat__ | also the patch increases the rpc timeout for all backends, the change isn't specific for lvm which seems wrong | 14:46 |
| whoami-rajat__ | s/all backends/ irrespective of the backend | 14:46 |
| eharney | also, that command taking that long to return shouldn't cause an rpc timeout anyway, unless there's some other bug in cinder | 14:47 |
| hemna | mep | 14:48 |
| *** cliffparsons has quit IRC | 14:48 | |
| *** miniroy has joined #openstack-meeting-alt | 14:49 | |
| rosmaita | anything else? | 14:50 |
| rosmaita | ok, use these final 10 minutes wisely | 14:51 |
| rosmaita | #endmeeting | 14:51 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 14:51 | |
| openstack | Meeting ended Wed Jan 13 14:51:15 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:51 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/cinder/2021/cinder.2021-01-13-14.00.html | 14:51 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/cinder/2021/cinder.2021-01-13-14.00.txt | 14:51 |
| *** cliffparsons has joined #openstack-meeting-alt | 14:51 | |
| openstack | Log: http://eavesdrop.openstack.org/meetings/cinder/2021/cinder.2021-01-13-14.00.log.html | 14:51 |
| *** reddy1 has quit IRC | 14:54 | |
| *** miniroy has quit IRC | 14:54 | |
| *** reddy has joined #openstack-meeting-alt | 14:54 | |
| *** cliffparsons has left #openstack-meeting-alt | 14:54 | |
| *** reddy1 has joined #openstack-meeting-alt | 14:55 | |
| *** reddy has quit IRC | 14:59 | |
| e0ne | #startmeeting horizon | 15:00 |
| openstack | Meeting started Wed Jan 13 15:00:25 2021 UTC and is due to finish in 60 minutes. The chair is e0ne. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| *** openstack changes topic to " (Meeting topic: horizon)" | 15:00 | |
| openstack | The meeting name has been set to 'horizon' | 15:00 |
| e0ne | hi everybody | 15:00 |
| vishalmanchanda | hi all | 15:01 |
| tmazur | hi everyone! | 15:01 |
| amotoki | hi | 15:01 |
| e0ne | I hope you enjoyed Christmas and and New Year holidays | 15:02 |
| e0ne | let's start our the first meeting in 2021 | 15:04 |
| e0ne | #topic Notices | 15:04 |
| *** openstack changes topic to "Notices (Meeting topic: horizon)" | 15:04 | |
| e0ne | I spent last two weeks almost without my laptop, so there are no news from me | 15:05 |
| e0ne | just a reminder that next week we'll reach Wallaby-2 milestone | 15:05 |
| e0ne | nothing special for horizon deliveries | 15:06 |
| e0ne | but we discussed in the past that it would be good to have a short (1-2 hours) mid-cycle call around this date | 15:07 |
| rdopiera | o/ | 15:08 |
| e0ne | we can have a call instead ourIRC meeting if we want to have it | 15:08 |
| e0ne | I'll send a mail with this proposal later tonight | 15:09 |
| amotoki | I have no strong preference on it. | 15:10 |
| e0ne | amotoki: it's just a proposal, so let's do it a bit loud in the mailing list | 15:11 |
| tmazur | do we have separated etherpad for mid-cycle? | 15:11 |
| e0ne | maybe we'll catch some new contributors | 15:11 |
| e0ne | tmazur: not yet | 15:12 |
| *** macz_ has joined #openstack-meeting-alt | 15:13 | |
| e0ne | #topic Open Discussion | 15:14 |
| *** openstack changes topic to "Open Discussion (Meeting topic: horizon)" | 15:14 | |
| e0ne | there are some items in our etherpad | 15:14 |
| e0ne | #link https://etherpad.opendev.org/p/horizon-release-priorities | 15:14 |
| rdopiera | if you don't mind, I'd like to discss the plans for updating jquery -- amotoki mentioned in the review he would like to know it too | 15:15 |
| e0ne | lines #55-65 | 15:15 |
| e0ne | rdopiera: sure | 15:16 |
| e0ne | rdopiera: it's your turn | 15:17 |
| *** macz_ has quit IRC | 15:17 | |
| rdopiera | from the testing I did (which didn't include plugins, I will still need to see about that), it seems that we are ready to update it -- we don't have any outstanding breaking incompatibilities. There are some warnings in the version of Angular that we use, but they are not errors, just warnings | 15:18 |
| rdopiera | basically if we update the xstatic-jquery and xstatic-jquery-migrate and update the requirement versions, it will work | 15:19 |
| e0ne | does it pass integration tests? | 15:20 |
| amotoki | for reference rdopiera is talking about https://review.opendev.org/c/openstack/xstatic-jquery-migrate/+/764769 | 15:20 |
| rdopiera | it generates a lot of warnings in the js console, but we can fix them gradually | 15:22 |
| rdopiera | e0ne: I only managed to run the selenium headless tests on my machine, I can't get the integration tests running :( | 15:23 |
| e0ne | :( | 15:23 |
| e0ne | rdopiera: we should be able to do it on or gate | 15:24 |
| rdopiera | so the way I see it, my next steps would be testing the intergration tests and the plugins | 15:24 |
| e0ne | +1 | 15:24 |
| amotoki | my point in the above review is jquery-migrate 3.x assumes jquery 1.12.x or 2.2.x but our requirement says jquery>=1.8.2.1 | 15:25 |
| e0ne | at least, we have to test it with plugins which we've got on ourgates too | 15:25 |
| rdopiera | e0ne: to test it on the gate we would first need to merge the upgrade for xstatic-jquery-migrate and release it | 15:25 |
| amotoki | at least I think we need to bump the min ver of jquery to >=1.12.x | 15:25 |
| amotoki | * first | 15:25 |
| e0ne | amotoki: that's a good point. we should to resole it first | 15:25 |
| rdopiera | there is already a package for xstatic-jquery | 15:26 |
| amotoki | this does not affect the current runtime reqs as u-c already speifies 1.12.x | 15:26 |
| e0ne | amotoki: we can face issues with pip if we don't upgrade jquery | 15:26 |
| e0ne | also, we can't be sure that jquery-migrate works well in horizon with older jquery | 15:26 |
| rdopiera | actually we can be sure it doesn't | 15:27 |
| rdopiera | we need to upgrade both | 15:27 |
| rdopiera | at the same time | 15:27 |
| amotoki | why "at the same time"? | 15:27 |
| rdopiera | because either one of them will not work with older versions of the other | 15:28 |
| amotoki | rdopiera: which versions of jquery and jquery-migrate are you talking about? | 15:28 |
| amotoki | what I suggest is to bump the min ver of xstatic-jquery to >=1.12.x and then upgrade jquery-migrate to 3.x. I think it works well. | 15:30 |
| vishalmanchanda | e0ne: I think integration test pass with this change https://review.opendev.org/c/openstack/horizon/+/765301 | 15:30 |
| rdopiera | XStatic_jQuery-3.5.1.1 and the jquery-migrate from that patch linked above | 15:30 |
| amotoki | rdopiera: I see | 15:31 |
| amotoki | so you are trying to bump both to 3.x era directly | 15:31 |
| rdopiera | yes, I think it's the only sane way | 15:31 |
| amotoki | IIUC jquery-migrate 3.x helps us upgrade to jquery 3.x | 15:33 |
| amotoki | so I think jquery 1.12.x and jquery-migrate 3.x are compatbile. am I missing something? | 15:33 |
| *** knomura has quit IRC | 15:34 | |
| amotoki | hmm.... I might be wrong https://github.com/jquery/jquery-migrate/blob/master/package.json#L25-L27 | 15:35 |
| rdopiera | amotoki: it is compatible with 1.12, but not older | 15:35 |
| rdopiera | from docs: NOTE: To upgrade to jQuery 3.0, you first need version 1.12.x or 2.2.x. If you're using an older version, first upgrade to one of these versions using jQuery Migrate 1.x, to resolve any compatibility issues. For more information about the changes made in jQuery 3.0, see the upgrade guide and blog post. | 15:35 |
| amotoki | rdopiera: yeah, so my idea is to bump requirements in horizon from XStatic-jQuery>=1.8.2.1,<2 to XStatic-jQuery>=1.12.4.1(,<2) | 15:37 |
| amotoki | I am not sure we need to bump jquery to 3.x together. | 15:37 |
| rdopiera | we will want to ship jquery 3 sooner or later | 15:38 |
| rdopiera | preferably sooner | 15:38 |
| *** ricolin has quit IRC | 15:38 | |
| e0ne | rdopiera: +1 | 15:39 |
| amotoki | I am fine with jquery 3. | 15:39 |
| rdopiera | there is a bunch of CVEs fixed in it | 15:39 |
| amotoki | I am just talking about whether we need to bump both together. | 15:39 |
| amotoki | but it is mainly for developers so bumping both together would be okay perhaps | 15:40 |
| rdopiera | so we need to bump to 1.12 before we bump jquery-migrate, then we have to bump jquery-migrate before we bump jquery further | 15:40 |
| amotoki | rdopiera: I think so | 15:40 |
| amotoki | the first change can be done in the horizon repo. | 15:40 |
| rdopiera | fun fact: we've been using jquery 1.12 in osp13 for several years now | 15:41 |
| amotoki | ubuntu has python3-xstatic-jquery_1.12.4.1-2_all.deb too | 15:42 |
| amotoki | (ubuntu focal) | 15:43 |
| amotoki | perhaps cloud archive uses this version | 15:44 |
| e0ne | it seems to be safe to upgrade to 1.12.x | 15:44 |
| amotoki | e0ne: this is not a upgrade actually. this is just a min version bump. | 15:45 |
| e0ne | but I prefer to read it's changelog to verify that nothing is dropped | 15:45 |
| e0ne | amotoki: it's true only if jquery always respect to semver | 15:45 |
| *** jamesmcarthur has quit IRC | 15:45 | |
| amotoki | e0ne: we already uses xstatic-jquery 1.12.4.1 since 2018 | 15:46 |
| *** jamesmcarthur has joined #openstack-meeting-alt | 15:46 | |
| e0ne | amotoki: it's good | 15:46 |
| amotoki | I believe bumping the min version in horizon reqs has no issue | 15:47 |
| *** ricolin has joined #openstack-meeting-alt | 15:47 | |
| e0ne | +1 | 15:48 |
| amotoki | so our plan would be: (1) bump to jquery 1.12 (2) release jquery migrate and update the reqs (g-r, u-c and horizon reqs) (3) upgrade jquery to 3.x | 15:49 |
| amotoki | right? | 15:49 |
| e0ne | sound good to me | 15:51 |
| *** jamesmcarthur has quit IRC | 15:51 | |
| amotoki | there is one question: when should we have a checkpoit for horizon plugins? | 15:53 |
| amotoki | after (2) or after (3) | 15:53 |
| *** jamesmcarthur has joined #openstack-meeting-alt | 15:54 | |
| e0ne | we can delay it to (3) if we don't spend a lot of time between (2) and (3) | 15:55 |
| amotoki | anyway wallaby-2 milestone is approaching, so it is better to do it soon so taht plguins can fix issues if any | 15:55 |
| e0ne | +1 | 15:56 |
| amotoki | btw, please check L.55-63 in the etherpad on lower-constraints maintenance and horizon in requirements blacklist.txt. we have no time to discuss it. | 15:57 |
| e0ne | amotoki: will do it. thanks for raising this topic | 15:59 |
| e0ne | we're out of time. we can continue discussion in #openstack-horizon channel | 15:59 |
| e0ne | thanks everybody for your contributions | 16:00 |
| e0ne | #endmeeting | 16:00 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 16:00 | |
| amotoki | o/ | 16:00 |
| openstack | Meeting ended Wed Jan 13 16:00:06 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:00 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/horizon/2021/horizon.2021-01-13-15.00.html | 16:00 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/horizon/2021/horizon.2021-01-13-15.00.txt | 16:00 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/horizon/2021/horizon.2021-01-13-15.00.log.html | 16:00 |
| *** macz_ has joined #openstack-meeting-alt | 16:02 | |
| *** rnoriega_ is now known as rnoriega123 | 16:06 | |
| *** rnoriega123 is now known as rnoriega_ | 16:06 | |
| *** rnoriega_ is now known as rnoriega | 16:09 | |
| *** e0ne has quit IRC | 16:15 | |
| *** knomura has joined #openstack-meeting-alt | 16:29 | |
| *** jamesmcarthur has quit IRC | 16:32 | |
| *** knomura has quit IRC | 16:33 | |
| *** jamesmcarthur has joined #openstack-meeting-alt | 16:34 | |
| *** slaweq has quit IRC | 16:34 | |
| *** slaweq has joined #openstack-meeting-alt | 16:36 | |
| *** jamesmcarthur has quit IRC | 16:38 | |
| *** tosky has quit IRC | 16:41 | |
| *** tosky has joined #openstack-meeting-alt | 16:42 | |
| *** jamesmcarthur has joined #openstack-meeting-alt | 16:50 | |
| *** gyee has joined #openstack-meeting-alt | 17:00 | |
| *** e0ne has joined #openstack-meeting-alt | 17:11 | |
| *** michael-mcaleer has quit IRC | 17:18 | |
| *** jamesmcarthur has quit IRC | 17:29 | |
| *** jamesmcarthur has joined #openstack-meeting-alt | 17:30 | |
| *** rdopiera has quit IRC | 17:33 | |
| *** baojg has quit IRC | 17:41 | |
| *** baojg has joined #openstack-meeting-alt | 17:41 | |
| *** derekh has quit IRC | 18:07 | |
| *** baojg has quit IRC | 18:11 | |
| *** baojg has joined #openstack-meeting-alt | 18:11 | |
| *** baojg has quit IRC | 18:18 | |
| *** baojg has joined #openstack-meeting-alt | 18:19 | |
| *** ralonsoh has quit IRC | 18:20 | |
| *** e0ne has quit IRC | 18:39 | |
| *** jamesmcarthur has quit IRC | 19:06 | |
| *** jamesmcarthur_ has joined #openstack-meeting-alt | 19:11 | |
| *** sfernand has joined #openstack-meeting-alt | 19:24 | |
| *** baojg has quit IRC | 19:39 | |
| *** baojg has joined #openstack-meeting-alt | 19:39 | |
| *** jamesmcarthur_ has quit IRC | 19:54 | |
| *** jamesmcarthur has joined #openstack-meeting-alt | 19:54 | |
| *** whoami-rajat__ has quit IRC | 19:55 | |
| *** jamesmcarthur has quit IRC | 20:14 | |
| *** kiwi_36 has quit IRC | 20:18 | |
| *** slaweq has quit IRC | 20:41 | |
| *** knomura has joined #openstack-meeting-alt | 20:48 | |
| *** knomura has quit IRC | 20:53 | |
| *** e0ne has joined #openstack-meeting-alt | 21:00 | |
| *** e0ne has quit IRC | 21:01 | |
| *** vishalmanchanda has quit IRC | 21:41 | |
| *** baojg has quit IRC | 21:43 | |
| *** baojg has joined #openstack-meeting-alt | 21:44 | |
| *** rcernin has joined #openstack-meeting-alt | 21:59 | |
| *** rosmaita has quit IRC | 21:59 | |
| *** baojg has quit IRC | 22:52 | |
| *** baojg has joined #openstack-meeting-alt | 22:53 | |
| *** knomura has joined #openstack-meeting-alt | 23:16 | |
| *** knomura has quit IRC | 23:21 | |
| *** yamamoto has joined #openstack-meeting-alt | 23:32 | |
| *** baojg has quit IRC | 23:33 | |
| *** baojg has joined #openstack-meeting-alt | 23:34 | |
| *** tmazur has quit IRC | 23:51 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!