| rosmaita | #startmeeting cinder | 14:00 |
|---|---|---|
| opendevmeet | Meeting started Wed Sep 1 14:00:14 2021 UTC and is due to finish in 60 minutes. The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'cinder' | 14:00 |
| fabiooliveira | hi | 14:00 |
| rosmaita | #topic roll call | 14:00 |
| rosmaita | hello | 14:00 |
| whoami-rajat | Hi | 14:00 |
| sfernand | hi | 14:00 |
| walshh_ | hi | 14:00 |
| abishop | o/ | 14:00 |
| simondodsley | hi | 14:01 |
| enriquetaso | hi | 14:01 |
| rosmaita | good turnout! | 14:01 |
| rosmaita | #link https://etherpad.opendev.org/p/cinder-xena-meetings | 14:02 |
| rosmaita | let's get started | 14:02 |
| rosmaita | #topic announcements | 14:02 |
| jungleboyj | o/ | 14:02 |
| rosmaita | client library releases have to happen this week | 14:02 |
| rosmaita | namely, tomorrow | 14:02 |
| rosmaita | we have 2 libraries that fit this | 14:03 |
| rosmaita | cinderclient-brick-ext | 14:03 |
| rosmaita | https://review.opendev.org/q/project:openstack/python-brick-cinderclient-ext+status:open+branch:master | 14:03 |
| rosmaita | there are a few tiny patches sitting there, let's get them reviewed and merged | 14:03 |
| rosmaita | definitely need the dropping lower constraints patch merged | 14:04 |
| rosmaita | and the other 2 are very nice as well | 14:04 |
| rosmaita | and the other library, of course, is the fabulous cinderclient | 14:05 |
| rosmaita | https://review.opendev.org/q/project:openstack/python-cinderclient+status:open+branch:master | 14:05 |
| rosmaita | there are a couple of changes that look L, but that's because they remove a bunch of code | 14:06 |
| rosmaita | we need to talk about https://review.opendev.org/c/openstack/python-cinderclient/+/806817 however | 14:06 |
| rosmaita | that depends on mv 3.66 merging into cinder | 14:06 |
| rosmaita | i suspect no one saw my email about this, i think it was held up in the intertubes | 14:07 |
| rosmaita | #link http://lists.openstack.org/pipermail/openstack-discuss/2021-September/024580.html | 14:07 |
| enriquetaso | read the email, I was reviewing it earlier | 14:08 |
| rosmaita | so i have two questions: 1. what are the odds of https://review.opendev.org/c/openstack/cinder/+/789564 merging today? | 14:08 |
| rosmaita | i mean, does anyone have reservations about it? | 14:08 |
| rosmaita | it's ok to have reservations, it's just that it would be really helpful for me to know that | 14:09 |
| rosmaita | the other question is about the cinderclient patch, it turned out to be a bit more complicated than i expected | 14:10 |
| rosmaita | (i actually expected that it didn't require a code change, but i was sorely mistaken) | 14:10 |
| sfernand | reviewed this week and patch looks good.. Do you folks need someone to test it or something? | 14:10 |
| rosmaita | that patch is https://review.opendev.org/c/openstack/python-cinderclient/+/806817/ | 14:11 |
| jungleboyj | I was going to look at the in-use volumes one. I don't have reservations. | 14:11 |
| rosmaita | ok, thanks jungleboyj and sfernand ... so it is at least possible that mv 3.66 will merge into cinder | 14:12 |
| rosmaita | so then it comes down to whether https://review.opendev.org/c/openstack/python-cinderclient/+/806817/ is a good approach to handling it on the cinderclient side | 14:12 |
| rosmaita | so, please review as soon as possible and leave comments! | 14:13 |
| rosmaita | thank you | 14:13 |
| rosmaita | once we know what's going into cinderclient, i'll get the final release notes patch up | 14:13 |
| rosmaita | which will be easy for people to review | 14:13 |
| rosmaita | i looked at the requirements, which we updated aggressively in wallaby, and they look OK for xena | 14:14 |
| rosmaita | so I won't be proposing a requirements update | 14:14 |
| rosmaita | ok, the other exciting thing happening this week is | 14:14 |
| rosmaita | feature freeze and soft string freeze | 14:15 |
| rosmaita | these technically happen tomorrow, but I think we can say Friday | 14:15 |
| rosmaita | so, stuff not merged by Friday 20:00 UTC will require a feature freeze exception | 14:15 |
| abishop | I anticipate several exceptions will be requested | 14:16 |
| rosmaita | which consists of an email to the openstack-discuss list with "[cinder] xena FFE request" in the subject line | 14:16 |
| rosmaita | and in the body of your email say what blueprint and patch(es) you are requesting | 14:16 |
| sfernand | ack, netapp has two major features this release and we are kind of desperate for reviews | 14:16 |
| rosmaita | right, so if we get mv 3.66 sorted out in the next few hours, we can review features like crazy for the next few days | 14:17 |
| rosmaita | #link https://blueprints.launchpad.net/cinder/xena | 14:17 |
| rosmaita | review prioritization is: reviews associated with ^^ | 14:18 |
| sfernand | so should drop the feature freeze exception on Friday morning if necessary, right? | 14:18 |
| rosmaita | well, more like Friday afternoon | 14:18 |
| sfernand | ok | 14:19 |
| sfernand | I've notice there are some bps in the list that are not supposed to reach xena I guess | 14:19 |
| sfernand | like sizing-encrypted-volumes | 14:19 |
| rosmaita | i think it's traditional to have an FFE request deadline, I will say Tuesday 7 september at 20:00 UTC | 14:19 |
| rosmaita | sfernand: good point, i was forgetting | 14:19 |
| enriquetaso | sizing-encrypted-volumes is not going to make it for this Friday | 14:19 |
| enriquetaso | I'm still working on it | 14:20 |
| rosmaita | yes, let's all open the page and look at what is postponeable to Yoga | 14:20 |
| jungleboyj | rosmaita: ++ | 14:20 |
| rosmaita | https://blueprints.launchpad.net/cinder/xena | 14:20 |
| sfernand | I miss that etherpad with the critical patches to review for the release to be honest. It makes more easier to focus reviews on | 14:20 |
| rosmaita | sfernand: i agree entirely, thank you for bringing it up | 14:20 |
| rosmaita | enriquetaso: are you going to ask for an FFE, or is it more an early Yoga kind of thing? | 14:21 |
| enriquetaso | guess more an early Yoga kind of thing | 14:21 |
| rosmaita | ok, thanks, i will move it to Yoga | 14:22 |
| enriquetaso | what is a FFE? | 14:22 |
| geguileo | sfernand: shouldn't we be using the review priority for that purpose? | 14:22 |
| jungleboyj | Feature Freeze Exception | 14:22 |
| enriquetaso | thanks | 14:22 |
| enriquetaso | sadly I'm still too green on that | 14:22 |
| rosmaita | well, the problem is review priority disappears when a new PS is pushed to gerrit | 14:22 |
| jungleboyj | :-) | 14:23 |
| rosmaita | abishop: are you working on https://blueprints.launchpad.net/cinder/+spec/availabilityzone-and-volumetype-for-backup-restore | 14:23 |
| sfernand | geguileo: I believe this also works, just mentioned the etherpad because I was really used to it and also could drop some comments there | 14:23 |
| geguileo | sfernand: that is true, being able to write something there was helpful | 14:23 |
| abishop | I submitted the patch that implements that bp, so I'm just requesting reviews | 14:23 |
| whoami-rajat | i think we can do R+2 since feature freeze is so near? that doesn't disappear IIRC | 14:24 |
| sfernand | I think the integration with the people interest in have stuff merged works better | 14:24 |
| abishop | #link https://review.opendev.org/c/openstack/cinder/+/806260 | 14:24 |
| rosmaita | abishop: that's a different bp | 14:24 |
| abishop | the feature is entirely policy based, so doesn't need a mv or cinderclient change | 14:24 |
| abishop | oh, duh, wrong one :-/ | 14:24 |
| abishop | give me a moment | 14:24 |
| rosmaita | sure | 14:24 |
| abishop | no, I have not been working on that | 14:25 |
| abishop | not sure why it's assigned to me | 14:25 |
| rosmaita | ok, ,i will move it to yoga and you can decide if you want to abandon it | 14:25 |
| abishop | I worked on a similar feature that only affected the client, back in W | 14:25 |
| rosmaita | ok | 14:26 |
| rosmaita | fix-snapshot-create-force is the mv 3.66 patch we discussed earlier | 14:26 |
| rosmaita | i saw that TusharTgite has patches up for reset-state-robustification, so that's good | 14:27 |
| rosmaita | ok there are 3 netapp BPs, and open-e-jovian-dss | 14:27 |
| rosmaita | and hitachi consistency groups | 14:27 |
| rosmaita | nimble-change-location may not be a thing ... the developer who was working on it, is not any more, and i haven't heard anything from his successors | 14:28 |
| rosmaita | ok, so plenty of stuff for everyone to review | 14:29 |
| rosmaita | and as always, people who are waiting for reviews of bugfixes, etc., can help out | 14:30 |
| rosmaita | ok, final announcement | 14:30 |
| rosmaita | the first community goal for Yoga has been announced | 14:30 |
| rosmaita | #link https://review.opendev.org/c/openstack/governance/+/803783 | 14:30 |
| rosmaita | it's "implementing secure and consistent RBAC" | 14:30 |
| rosmaita | cinder strategy is to do this partly in Xena, partly in Yoga | 14:31 |
| rosmaita | #link https://review.opendev.org/c/openstack/cinder/+/763306 | 14:31 |
| rosmaita | ^^ has an "implementation strategy" section you can look at | 14:31 |
| rosmaita | and there's another patch that gives more technical details about the changes | 14:31 |
| rosmaita | #link https://review.opendev.org/c/openstack/cinder/+/803748 | 14:31 |
| rosmaita | ok, that's all from me | 14:32 |
| rosmaita | any announcements i missed? | 14:32 |
| rosmaita | #topic Request review of "user visible extra specs" feature | 14:33 |
| rosmaita | this is a legitimate request, we just saw that it's among the Xena features | 14:33 |
| rosmaita | #link https://review.opendev.org/c/openstack/cinder/+/806260 | 14:33 |
| rosmaita | abishop: any other comments about that? | 14:33 |
| abishop | just a repeat of what I mentioned already, the feature is entirely policy based, so doesn't need a mv or cinderclient change | 14:33 |
| rosmaita | great | 14:34 |
| abishop | that's it, thx! | 14:34 |
| rosmaita | #topic Backup user messages | 14:34 |
| rosmaita | whoami-rajat: that's you | 14:34 |
| whoami-rajat | hi | 14:34 |
| whoami-rajat | so Brian has a concern with the patch that we are doing some message handling in backup side which should be done with messages API | 14:35 |
| whoami-rajat | #link https://review.opendev.org/c/openstack/cinder/+/786627/19/cinder/backup/manager.py#490 | 14:35 |
| whoami-rajat | would appreciate more opinions on it | 14:35 |
| rosmaita | ok, everyone has opinions, please express them! | 14:37 |
| whoami-rajat | just to summarize, the concern is regarding the ``message_created`` variable which is checking if a previous user message was created and doesn't create more messages | 14:37 |
| rosmaita | yeah, my position on that may be overly cynical | 14:38 |
| rosmaita | but you can read the discussion on the patch | 14:38 |
| rosmaita | #topic stable release update | 14:39 |
| rosmaita | whoami-rajat: you again | 14:39 |
| whoami-rajat | thanks :D | 14:39 |
| whoami-rajat | so we've some progress | 14:39 |
| whoami-rajat | All open changes in stable/wallaby merged and I've proposed a release patch | 14:39 |
| rosmaita | i saw that, thanks for getting the release together | 14:39 |
| whoami-rajat | #link https://review.opendev.org/c/openstack/releases/+/806831 | 14:39 |
| whoami-rajat | thanks for all the reviews, specially Jay and Brian | 14:39 |
| whoami-rajat | np | 14:40 |
| whoami-rajat | and i just saw a comment from herve | 14:40 |
| whoami-rajat | which i think we can discuss now | 14:40 |
| whoami-rajat | there's a change for Pure storage driver, "652c3bf31 changed the minimum SDK version required for pure storage." | 14:40 |
| rosmaita | herve really does pay close attention! | 14:40 |
| whoami-rajat | which for Herve is asking a minor bump | 14:41 |
| jungleboyj | :-) | 14:41 |
| whoami-rajat | i think that makes sense? it's a driver change but also a requirements change | 14:41 |
| rosmaita | well, we decided that the change wasn't a block to backporting | 14:41 |
| rosmaita | and he's not objecting to that, so i think a minor version change is fine | 14:41 |
| whoami-rajat | ok, thanks for inputs | 14:42 |
| whoami-rajat | that's all for me | 14:42 |
| rosmaita | whoami-rajat: go ahead and update the patch, and I will re-vote on it | 14:42 |
| rosmaita | thanks! | 14:42 |
| whoami-rajat | and hope the reviews continue for victoria and ussuri as well :) | 14:42 |
| whoami-rajat | sure, thanks | 14:43 |
| rosmaita | #topic open discussion | 14:43 |
| rosmaita | just want to pass along a request from zenkuro, to please please please review the open-e-jovian-dss changes! | 14:43 |
| rosmaita | hay! this patch was review and Ive addressed recommendatyions and issues please review it https://review.opendev.org/c/openstack/cinder/+/806191 | 14:44 |
| rosmaita | also here is verry small patch that enables feature for driver https://review.opendev.org/c/openstack/cinder/+/806726/3 | 14:44 |
| rosmaita | and here is a naming and code style fix https://review.opendev.org/c/openstack/cinder/+/806559/5 | 14:44 |
| rosmaita | ^^ that's in zenkuro's own words | 14:44 |
| eharney | what's the deadline for https://review.opendev.org/c/openstack/cinder/+/789603 ? | 14:44 |
| rosmaita | it's a bugfix, so RC-week | 14:45 |
| rosmaita | let me check the date | 14:45 |
| rosmaita | week of 13 sept | 14:45 |
| rosmaita | so before 16 sept | 14:46 |
| eharney | i got lost working through where to validate what in my update to that, need to cycle back on it | 14:48 |
| rosmaita | btw, i have been using f-strings a lot lately, but i seem to remember that people don't like those? | 14:48 |
| rosmaita | i am finding them quite nice | 14:48 |
| eharney | they're good | 14:48 |
| whoami-rajat | we should also check grenade with this since the last patch broke gate (even though it was the stable/wallaby patch) | 14:48 |
| jungleboyj | Ok, so f"text" is valid? I have never seen it before. | 14:48 |
| rosmaita | it lets you do easy variable substitutions | 14:49 |
| rosmaita | without having to do all that % stuff | 14:49 |
| eharney | yeah we should be catching up on modern python features | 14:49 |
| * eharney *cough* type annotations | 14:49 | |
| jungleboyj | Hmmm. That is new to me. | 14:49 |
| jungleboyj | Ok. Sorry for the dumb comment on the review then. | 14:50 |
| rosmaita | np, it's a good chance to make sure we are all ok with using them | 14:50 |
| rosmaita | i somehow have this memory of someone saying "no f-strings in cinder" | 14:50 |
| rosmaita | but that may have been one of my cinder nightmares | 14:50 |
| rosmaita | or it's someone no longer working on the project | 14:51 |
| eharney | i don't remember that | 14:51 |
| abishop | it's a python feature that works great when it solves a problem, but if abused makes the code less readable | 14:51 |
| abishop | my $.02 | 14:51 |
| jungleboyj | Now that I look at it, it makes sense. | 14:52 |
| rosmaita | ok, so our official position is that f-strings, when used appropriately are fine | 14:52 |
| eharney | like with everything, just try to go for what is most readable | 14:52 |
| rosmaita | but if a particular string isn't readable, feel free to request a different kind of string | 14:52 |
| rosmaita | eharney: ++ | 14:52 |
| rosmaita | jungleboyj: i can't believe you spotted that extra space! | 14:52 |
| eharney | worrying about these rules too much has resulted in some pretty weird uses of parentheses when backslashes should have been used, so, don't over do it | 14:53 |
| jungleboyj | rosmaita: :-) For some reason that stuff stands out to me. The kids these days not using two spaces after a '.' drives me nuts. | 14:53 |
| rosmaita | :) i am a two-space-after-a-period kind of guy | 14:54 |
| rosmaita | let sphinx figure it out | 14:54 |
| jungleboyj | eharney: I updated my vote. We can fix the space later. | 14:54 |
| rosmaita | eharney: lmk if you are ok with the changes i made to https://review.opendev.org/c/openstack/cinder/+/789564 | 14:54 |
| rosmaita | thanks, jay | 14:55 |
| eharney | rosmaita: will do | 14:55 |
| rosmaita | cool, ty | 14:55 |
| rosmaita | whoami-rajat: you said something about a patch breaking grenade? | 14:56 |
| whoami-rajat | rosmaita, the encryption one, we moved the check from c-vol to c-api and when merged in wallaby it broke grenade job | 14:58 |
| eharney | we fixed that by running grenade where it needs to run now, right? | 14:58 |
| whoami-rajat | because grenade wasn't creating an encrypted volume type properly, but again we've to avoid similar scenario since it broke other project gates as well | 14:59 |
| rosmaita | did we have that problem in master? | 14:59 |
| eharney | yes | 14:59 |
| whoami-rajat | eharney, this was the fix https://review.opendev.org/c/openstack/grenade/+/803317 | 14:59 |
| eharney | because grenade was creating unusable types and relying on them to be created | 14:59 |
| rosmaita | i don't remember how we fixed it | 14:59 |
| whoami-rajat | we fixed how grenade creates encrypted volume types (which was the wrong way previously) | 15:00 |
| eharney | well the main takeaway is, we need to run grenade in our gate, did we fix that? | 15:00 |
| whoami-rajat | eharney, the problem is only visible when that patch merges in N-1 branch (like stable/wallaby in that case), because greande creates resources in SOURCE branch and then upgrades to target (N) branch | 15:01 |
| whoami-rajat | we already run greande in our gate | 15:02 |
| rosmaita | we are running grenade in gate and check | 15:02 |
| rosmaita | whoami-rajat: is grenade branched, unlike tempest? | 15:02 |
| whoami-rajat | rosmaita, yes, branched | 15:02 |
| eharney | i guess i'm not sure what the request is -- we go run grenade by hand looking for issues to make sure it works? | 15:02 |
| rosmaita | ok, so i guess you need to propose a backport of your patch? | 15:03 |
| whoami-rajat | eharney, I'm not sure either, somehow with backports we need to be careful if greande is running properly | 15:03 |
| whoami-rajat | rosmaita, someone proposed but since it wasn't needed for gate fix, it was abandoned | 15:04 |
| rosmaita | ok, but now it is needed? | 15:04 |
| rosmaita | (sorry, it's been a long day already, i am having trouble following the conversation) | 15:04 |
| rosmaita | and we are over time! | 15:05 |
| rosmaita | thanks everyone, please please please review review review | 15:05 |
| rosmaita | let's get to enriquetaso's bug squad meeting in cinder channel | 15:05 |
| whoami-rajat | until we backport [1] further, we are good for now [1] https://review.opendev.org/c/openstack/cinder/+/800268 | 15:05 |
| rosmaita | ok, thanks whoami-rajat | 15:05 |
| rosmaita | #endmeeting | 15:06 |
| opendevmeet | Meeting ended Wed Sep 1 15:06:01 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:06 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/cinder/2021/cinder.2021-09-01-14.00.html | 15:06 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/cinder/2021/cinder.2021-09-01-14.00.txt | 15:06 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/cinder/2021/cinder.2021-09-01-14.00.log.html | 15:06 |
| *** dviroel|ruck is now known as dviroel|out | 22:43 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!