| *** dviroel|out is now known as dviroel|ruck | 11:19 | |
| *** dviroel|ruck is now known as dviroel | 12:48 | |
| gouthamr | #startmeeting manila | 15:02 |
|---|---|---|
| opendevmeet | Meeting started Thu Sep 2 15:02:35 2021 UTC and is due to finish in 60 minutes. The chair is gouthamr. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:02 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:02 |
| opendevmeet | The meeting name has been set to 'manila' | 15:02 |
| carloss | o/ | 15:02 |
| gouthamr | courtesy ping: ganso vkmc dviroel tbarron felipe_rodrigues ecsantos vhari | 15:02 |
| haixin | o/ | 15:02 |
| ecsantos | o/ | 15:02 |
| dviroel | o/ | 15:02 |
| simondodsley | o/ | 15:02 |
| felipe_rodrigues | o/ | 15:02 |
| kafilat | o/ | 15:02 |
| archanaserver | o/ | 15:02 |
| caiquemello | o/ | 15:03 |
| vhari | o/ | 15:03 |
| gouthamr | hey everyone, thanks for joining - here's the agenda for this meeting: https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting | 15:03 |
| gouthamr | lets begin with | 15:03 |
| gouthamr | #topic Announcements | 15:03 |
| vkmc | o/ | 15:03 |
| fabiooliveira | o/ | 15:03 |
| tbarron | hi | 15:03 |
| gouthamr | we're at feature freeze; we're hoping to ship a release of python-manilaclient and stop merging feature-ful changes into manila and manila-ui for a few weeks | 15:04 |
| gouthamr | #link https://releases.openstack.org/xena/schedule.html | 15:04 |
| gouthamr | the xena release candidate is expected on Sep 17 | 15:05 |
| gouthamr | since strings in the manila project don't get translated - the feature freeze deadline is more applicable to the release of python-manilaclient | 15:06 |
| gouthamr | we'll discuss changes that are pending for that to happen in a bit | 15:06 |
| gouthamr | a reminder that we've a planning etherpad for the yoga cycle project teams gathering | 15:07 |
| gouthamr | #link https://etherpad.opendev.org/p/yoga-ptg-manila-planning (Manila Yoga PTG Planning etherpad) | 15:07 |
| gouthamr | ^ please add your topics to that etherpad - i'm looking at a couple of conflicts, and need to know what times i can adjust | 15:08 |
| gouthamr | that's all the announcements for today, lots going on | 15:09 |
| gouthamr | anyone else got any announcments? | 15:09 |
| gouthamr | #topic AIs from Last Week | 15:09 |
| gouthamr | External network access issues with devstack | 15:10 |
| gouthamr | #link http://lists.openstack.org/pipermail/openstack-discuss/2021-July/023631.html | 15:10 |
| gouthamr | we have a resolution \o/ | 15:10 |
| simondodsley | sounds good - haven't had a change to fully check it out yet. | 15:11 |
| gouthamr | thanks to slawek and team, the external network on devstack is now accessible to guest VMs | 15:11 |
| gouthamr | #link https://review.opendev.org/c/openstack/devstack/+/806267 | 15:11 |
| gouthamr | simondodsley: i saw a green run on the pure storage CI yesterday | 15:11 |
| simondodsley | excellent news - i've been too busy to check | 15:11 |
| gouthamr | on this for example: https://review.opendev.org/c/openstack/manila/+/801911 | 15:11 |
| gouthamr | http://openstack-logs.purestorage.com/11/801911/8/thirdparty-check/pure-devstack-manila-tempest-aio/9318499/ | 15:12 |
| gouthamr | good to pop this off and in time | 15:12 |
| simondodsley | fabulous - thanks for keeping on top of this and getting the solution | 15:12 |
| gouthamr | you're welcome.. lets move on to the meat of this meeting :) | 15:13 |
| gouthamr | #topic Reviews needing attention | 15:13 |
| gouthamr | #link https://etherpad.opendev.org/p/manila-xena-review-focus | 15:13 |
| gouthamr | unmerged changes begin at line 108 | 15:14 |
| gouthamr | BP: Manila share support Recycle Bin | 15:14 |
| gouthamr | #link https://review.opendev.org/c/openstack/manila/+/800753 | 15:14 |
| haixin | the db unit test still error,,,, | 15:15 |
| gouthamr | the client side of this looks good, but the server side's still being worked on | 15:15 |
| gouthamr | oh | 15:15 |
| haixin | other unit i will fix tomorrow | 15:15 |
| haixin | unit test | 15:15 |
| gouthamr | ack - its late in your day; | 15:17 |
| haixin | it is 23:17 now, :) | 15:18 |
| dviroel | almost tomorrow for you :P | 15:18 |
| gouthamr | we can fix this up and get it to merge in xena, without support in the xena manilaclient | 15:18 |
| gouthamr | which isn't the end of the world - but an option nevertheless | 15:18 |
| gouthamr | we've diligently kept client support to all API changes over the releases - extremely desirable since we think our users use manilaclient as much as the API; | 15:20 |
| gouthamr | i'll check about a client release exception, but no promises | 15:21 |
| dviroel | ++ | 15:21 |
| gouthamr | keep reviewing :) thanks for your hard work on this, haixin | 15:21 |
| gouthamr | next up, Scheduler Hints - Add Share Affinity/Anti-Affinity Scheduler Filters | 15:21 |
| haixin | haha | 15:21 |
| gouthamr | this one has no tempest tests to go with it, the master change looks well written, but some tests would be nice - the author's been responsive | 15:22 |
| haixin | i will add manila-ui update for Affinity/Anti-Affinity later | 15:23 |
| gouthamr | great, thanks haixin | 15:23 |
| gouthamr | this has the same issue with the manilaclient - https://review.opendev.org/c/openstack/python-manilaclient/+/806496 | 15:24 |
| * gouthamr feels nice about OSC support being added right away - thanks for insisting, maaritamm | 15:24 | |
| vkmc | maaritamm++ | 15:24 |
| carloss | ++ | 15:24 |
| gouthamr | Add share network to the share replica create API | 15:25 |
| gouthamr | #link https://review.opendev.org/c/openstack/manila/+/804578 | 15:25 |
| gouthamr | this one has a few comments that need to be addressed - i suspect it'll take longer to get these addressed | 15:26 |
| gouthamr | also has a python-manilaclient change: https://review.opendev.org/c/openstack/python-manilaclient/+/804579 | 15:26 |
| dviroel | i would like to see this one being tested in tempest, not sure if we are missing other details on that | 15:27 |
| gouthamr | yes | 15:27 |
| gouthamr | thanks for asking - the current direction seems to always put replicas on new networks, and CI doesn't seem to like that: https://review.opendev.org/c/openstack/manila-tempest-plugin/+/804589 | 15:28 |
| gouthamr | lets see what kiran says, carloss dviroel, can you add your votes on the patch | 15:28 |
| carloss | sure thing | 15:29 |
| dviroel | yep | 15:29 |
| gouthamr | thank you! next, Share server migration enhancements | 15:29 |
| gouthamr | #link https://review.opendev.org/c/openstack/manila/+/803623 | 15:29 |
| gouthamr | how's this one going, carloss | 15:29 |
| carloss | working on the most recent comments... I intend to post a new PS with changes soon | 15:30 |
| gouthamr | nice, thank you - i feel better about this since there's very limited API impact | 15:30 |
| carloss | thanks for reviewing gouthamr dviroel ganso | 15:30 |
| gouthamr | some validation is being added, but no new parameters - thanks for all the iterations, carloss | 15:31 |
| carloss | yes! complexity was reduced, I think we are in the right direction | 15:31 |
| carloss | yw :) | 15:31 |
| gouthamr | so is it a good time to abandon https://review.opendev.org/c/openstack/python-manilaclient/+/803626 | 15:31 |
| carloss | done :) | 15:32 |
| gouthamr | abandoned | 15:32 |
| gouthamr | forgotten | 15:32 |
| gouthamr | Replace "retrying" with "tenacity" | 15:32 |
| gouthamr | #link https://review.opendev.org/c/openstack/manila/+/801911 | 15:32 |
| gouthamr | beat this one into shape yesterday, ashrod98 and boden had done the bulk of the heavy lifting | 15:33 |
| carloss | great to see this moving! | 15:33 |
| gouthamr | its an internal change, no API impact - just wanted closure here prior to feature freeze if possible | 15:33 |
| gouthamr | and, carloss and felipe_rodrigues are using retry in a bunch of new and fancy places | 15:33 |
| gouthamr | so it would be nice to get this one merged, and the new method be used/tested in their patches | 15:34 |
| gouthamr | tenacity, and the retry wrapper in the utils module is *almost* a drop in replacement, but there were some creases that needed straightening | 15:35 |
| gouthamr | tbarron's reviewing this - can i have second reviewer/s for this change? | 15:35 |
| * gouthamr tests network | 15:37 | |
| * vhari network is alive :) | 15:38 | |
| gouthamr | thanks vhari | 15:38 |
| gouthamr | haixin carloss dviroel vkmc - can one of you help with this? | 15:39 |
| vkmc | yes yes | 15:39 |
| haixin | i will try | 15:40 |
| gouthamr | thank you :) it has my +1 - and whatever weirdness was showing up due to the retries in the generic driver is now addressed (we're doing the same number of retries as before) | 15:40 |
| gouthamr | [NetApp] Share server migration through SVM Migrate | 15:41 |
| gouthamr | #link https://review.opendev.org/c/openstack/manila/+/803624 | 15:41 |
| gouthamr | this change is isolated to the netapp driver, and it takes advantage of the changes brought in by https://review.opendev.org/c/openstack/manila/+/803623 | 15:42 |
| gouthamr | has two dviroels reviewing | 15:42 |
| * gouthamr thought the smarter guy was fviroel | 15:43 | |
| carloss | the love is still there! :D | 15:43 |
| carloss | thanks to all reviewers! I intend to submit a new patch today as well | 15:44 |
| gouthamr | awesome thanks carloss | 15:44 |
| gouthamr | [NetApp] Add FlexGroup volume support | 15:45 |
| gouthamr | #link https://review.opendev.org/c/openstack/manila/+/803622 | 15:45 |
| gouthamr | a bigger change, but still isolated to the driver | 15:45 |
| gouthamr | thanks for sharing the status on testing, nahimsouza - and for the work on this felipe_rodrigues | 15:45 |
| gouthamr | anything to bring up? | 15:45 |
| felipe_rodrigues | i dont think so.. I am finishing fixing the unit tests and I'll upload a new patch set soon | 15:46 |
| gouthamr | great, thanks! | 15:46 |
| gouthamr | [NetApp] Add readable replication support | 15:46 |
| gouthamr | https://review.opendev.org/c/openstack/manila/+/803621 | 15:46 |
| gouthamr | #link https://review.opendev.org/c/openstack/manila/+/803621 | 15:47 |
| gouthamr | we're keeping you busy felipe_rodrigues | 15:47 |
| gouthamr | how's this one looking?? | 15:47 |
| dviroel | lol | 15:47 |
| carloss | haha | 15:48 |
| carloss | :D | 15:48 |
| felipe_rodrigues | nahim is helping me | 15:49 |
| gouthamr | good stuff, thanks | 15:49 |
| felipe_rodrigues | he is fixing and answering the comments | 15:49 |
| gouthamr | ++ | 15:49 |
| felipe_rodrigues | he could add more about how it is going | 15:49 |
| gouthamr | that's the end of the list of changes for the manila repo | 15:50 |
| gouthamr | lets look at the client | 15:50 |
| gouthamr | OSC Implementation for Share Networks | 15:50 |
| gouthamr | #link https://review.opendev.org/c/openstack/python-manilaclient/+/805053 | 15:50 |
| gouthamr | ^ maaritamm found a cool bug yesterday, that i had confidently decorated/hidden with unit tests - but she's got her +2 there | 15:51 |
| gouthamr | carloss can you take another look? | 15:52 |
| carloss | sure thing | 15:52 |
| carloss | :) | 15:52 |
| gouthamr | thank you | 15:53 |
| gouthamr | Implement OSC share instance export location commands | 15:53 |
| gouthamr | #link https://review.opendev.org/c/openstack/python-manilaclient/+/805307 | 15:53 |
| gouthamr | should merge right after | 15:53 |
| gouthamr | Implement Share Group Type Commands | 15:53 |
| gouthamr | #link https://review.opendev.org/c/openstack/python-manilaclient/+/805064 | 15:53 |
| gouthamr | ^ eso is in mergo conflict | 15:53 |
| vkmc | fixiiiiiiiiiiiing | 15:54 |
| gouthamr | :D | 15:54 |
| gouthamr | thanks vkmc | 15:54 |
| gouthamr | carloss has reviewed this in the past, can we have second reviewer/s? | 15:55 |
| archanaserver | gouthamr: can i do this? | 15:56 |
| gouthamr | archanaserver: ofcourse thanks for volunteering | 15:57 |
| gouthamr | i can help review as well | 15:57 |
| gouthamr | are we missing any other changes in python-manilaclient that are ready? | 15:57 |
| gouthamr | i see a few OSC patches being worked on | 15:57 |
| gouthamr | #link https://review.opendev.org/c/openstack/python-manilaclient/+/801740 ([OSC] Implement Share Group Commands) | 15:59 |
| gouthamr | #link https://review.opendev.org/c/openstack/python-manilaclient/+/805466 (Implement OSC share quota update default class command) | 15:59 |
| gouthamr | archanaserver felipe_rodrigues: are we pursuing these for now? or okay to slip? | 16:00 |
| * gouthamr looks at the clock | 16:00 | |
| gouthamr | lets wrap up here, and continue on #openstack-manila | 16:01 |
| felipe_rodrigues | yeah... I've stopped to work on it, because I was focused on my patches.. But I am planning to finish until feature freeze | 16:01 |
| gouthamr | to anyone reading this from the meeting notes, eavesdrop in the #openstack-manila channel for the rest of the discussion | 16:01 |
| gouthamr | #link https://meetings.opendev.org/irclogs/%23openstack-manila/%23openstack-manila.2021-09-02.log.html | 16:01 |
| gouthamr | thanks felipe_rodrigues - makes sense | 16:02 |
| felipe_rodrigues | You added a new approach, so I need to change mine.. But, ok! | 16:02 |
| gouthamr | :D i do that | 16:02 |
| felipe_rodrigues | thanks | 16:02 |
| gouthamr | thanks all, lets hop on to #openstack-manila | 16:02 |
| gouthamr | #endmeeting | 16:02 |
| opendevmeet | Meeting ended Thu Sep 2 16:02:44 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:02 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/manila/2021/manila.2021-09-02-15.02.html | 16:02 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/manila/2021/manila.2021-09-02-15.02.txt | 16:02 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/manila/2021/manila.2021-09-02-15.02.log.html | 16:02 |
| *** dviroel is now known as dviroel|out | 21:01 | |
| *** bnemec is now known as bnemec-pto | 21:45 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!