| *** dviroel|rover is now known as dviroel|out | 00:19 | |
| *** dviroel|out is now known as dviroel|rover | 11:09 | |
| gouthamr | #startmeeting manila | 15:01 |
|---|---|---|
| opendevmeet | Meeting started Thu Oct 14 15:01:36 2021 UTC and is due to finish in 60 minutes. The chair is gouthamr. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
| opendevmeet | The meeting name has been set to 'manila' | 15:01 |
| gouthamr | courtesy ping: ganso vkmc dviroel carloss tbarron felipe_rodrigues ecsantos vhari fabiooliveira | 15:01 |
| felipe_rodrigues | o/ | 15:01 |
| fabiooliveira | o/ | 15:01 |
| ecsantos[m] | o/ | 15:01 |
| carloss | o/ | 15:01 |
| simondodsley | o/ | 15:01 |
| kafilat | o/ | 15:01 |
| nahimsouza | hi | 15:01 |
| LeoCampelo | o/ | 15:01 |
| caiquemello | o/ | 15:02 |
| vhari | o/ | 15:02 |
| haixin | o/ | 15:02 |
| gouthamr | hello everyone o/ thanks for joining! | 15:02 |
| gouthamr | lets get started.. | 15:02 |
| gouthamr | #topic Announcements | 15:02 |
| gouthamr | a couple of call outs regarding next week's PTG | 15:03 |
| tbarron | o/ | 15:03 |
| gouthamr | please see the updated timeslots for the various topics on our planning etherpad | 15:03 |
| gouthamr | #link https://etherpad.opendev.org/p/yoga-ptg-manila-planning | 15:03 |
| gouthamr | ^ this is different from last week - and hopefully the final schedule should work | 15:04 |
| gouthamr | our meetup will be held on Zoom | 15:05 |
| vkmc | o/ | 15:05 |
| gouthamr | you should be able to get onto the zoom call by clicking on the slot here: | 15:05 |
| gouthamr | #link https://ptg.opendev.org/ptg.html | 15:05 |
| gouthamr | carloss: thank you for running the last week's meeting :) | 15:07 |
| carloss | my pleasure gouthamr :) | 15:08 |
| gouthamr | as carloss mentioned last week, we'll begin PTG with a retrospective, a discussion about project health and plans at 1400 UTC on Monday, 18th Oct | 15:08 |
| gouthamr | #link https://etherpad.opendev.org/p/manila-xena-retrospective | 15:08 |
| gouthamr | ^ please add your thoughts there by that meeting | 15:09 |
| gouthamr | i'll send out an email to openstack-discuss canceling next week's irc meeting since it overlaps with the manila meeting | 15:10 |
| gouthamr | as we've done a few times in the past, we'll also drop the IRC meeting for the week after (28th Oct '21) | 15:11 |
| gouthamr | if anyone finds other relevant PTG discussions happening elsewhere, please feel free to link them on the planning etherpad | 15:13 |
| gouthamr | the foundation published the openstack user survey responses on to the mailing list | 15:14 |
| gouthamr | #link http://lists.openstack.org/pipermail/openstack-discuss/2021-October/025340.html (2021 User Survey Project Specific Feedback Responses) | 15:14 |
| gouthamr | you'll notice we had several questions on this survey (and somehow retained our old question from prior surveys as well) | 15:15 |
| gouthamr | we'll analyze this together next week; it is encouraging to see an increase in respondents over the past surveys | 15:16 |
| gouthamr | that's all the announcements i had... anyone else got any? | 15:16 |
| gouthamr | #topic Stale bug triage | 15:17 |
| gouthamr | #link https://ethercalc.openstack.org/kxz9jz7tuopk | 15:18 |
| gouthamr | this has been a recurring topic for the past few weeks - we're attempting to re-triage bugs that haven't been updated in a long time (>3 years) | 15:18 |
| gouthamr | we thought we could do a couple together as a team in today's meeting | 15:19 |
| gouthamr | vhari: which ones do we go after? | 15:19 |
| vhari | gouthamr, they are on LP etherpad | 15:20 |
| vhari | #link https://bugs.launchpad.net/manila/+bug/1631314 | 15:20 |
| vhari | we can take a look at ^^ | 15:20 |
| vhari | We picked two to review today https://etherpad.opendev.org/p/manila-bug-triage-pad-new | 15:21 |
| vhari | L:11-12 | 15:21 |
| gouthamr | hmm, no test code's changed - so this still gets encountered every now and then | 15:23 |
| gouthamr | its not a real world scenario either - i.e., our tests are trying to do something for the sake of verifying a behavior per all the notes in the bug report | 15:24 |
| gouthamr | dviroel's probably occupied - i wonder if this is an opportunity for this tempest decorator: https://docs.openstack.org/tempest/latest/library/decorators.html#tempest.lib.decorators.unstable_test | 15:25 |
| gouthamr | #link https://docs.openstack.org/tempest/latest/library/decorators.html#tempest.lib.decorators.unstable_test (tagging unstable tempest tests) | 15:25 |
| gouthamr | example usage: https://opendev.org/openstack/tempest/src/branch/master/tempest/scenario/test_network_advanced_server_ops.py#L267 | 15:26 |
| carloss | sounds like a good approach | 15:28 |
| carloss | would avoid rechecks on this known issue | 15:28 |
| fabiooliveira | I could add this tag on the tests | 15:28 |
| gouthamr | great, thank you fabiooliveira | 15:29 |
| carloss | fabiooliveira++ | 15:29 |
| gouthamr | ive dropped the asignee, can you grab the bug fabiooliveira | 15:30 |
| gouthamr | we can target this to yoga-1 | 15:30 |
| vhari | fabiooliveira++ | 15:31 |
| vhari | gouthamr, so a quick hint for stale bug reviewers .. | 15:32 |
| vhari | the idea is not to triage the bug during our review, rather update it approriately | 15:32 |
| vhari | for example this is the case where the bug is still relevant .. | 15:32 |
| vhari | the reviewer would add a comment to the bug as such | 15:32 |
| vhari | the comment will then remove the bug from stale -> to be triaged list | 15:32 |
| gouthamr | ++ | 15:32 |
| vhari | next on the stale bug | 15:32 |
| vhari | #link https://bugs.launchpad.net/manila/+bug/1660825 | 15:32 |
| * gouthamr scratches his head a bit | 15:33 | |
| tbarron | is the idea here that the manager would pass a dictionary of capability k/vs from the share type into the driver as another argument in, e.g. driver.create_share() ? | 15:35 |
| tbarron | so then the driver would never have to do database lookups? | 15:36 |
| gouthamr | yes | 15:36 |
| gouthamr | i think so | 15:36 |
| tbarron | This would require the change just mentioned in the manager, and then drivers that do the lookups would each need to change, right? | 15:36 |
| gouthamr | true | 15:37 |
| gouthamr | here's an example of such a lookup: https://opendev.org/openstack/manila/src/branch/master/manila/share/drivers/zfsonlinux/driver.py#L403 | 15:37 |
| tbarron | The first change could just go in pretty easily I think. Drivers could just ignore it. | 15:37 |
| felipe_rodrigues | I've seen some code in netapp side retrieving the specs using the type id | 15:37 |
| felipe_rodrigues | because it is not passed down | 15:37 |
| tbarron | Are there other DB lookups in drivers other than capabilities from share types? | 15:37 |
| gouthamr | ack - drivers get the provisioning call, and they lookup the share type for the other capabilities | 15:38 |
| felipe_rodrigues | QoS | 15:38 |
| tbarron | I like drivers not doing DB lookups. | 15:38 |
| felipe_rodrigues | tbarron++ | 15:38 |
| tbarron | or worse, db updates | 15:39 |
| gouthamr | so adding the extra specs blob as share_instance['capabilities'] should solve this issue | 15:40 |
| gouthamr | (and all the driver updates) | 15:41 |
| tbarron | i see, no need for a separate argument on the calls into the driver. | 15:41 |
| gouthamr | yes; if we can avoid changing the driver interface signature, it makes things easier | 15:42 |
| felipe_rodrigues | If the problem is the round trip to the db, there are more info from the type that we normally use.. only passing the capabilities down would fix just part of problem... | 15:43 |
| gouthamr | felipe_rodrigues: what else are we missing? | 15:44 |
| felipe_rodrigues | all extra specs.. | 15:45 |
| gouthamr | ah, yes | 15:45 |
| felipe_rodrigues | actually, the majority of NetApp round trip to the db is to retrieve the extra specs.. for the capabilities, I've not seen much | 15:46 |
| felipe_rodrigues | Anyway, a get to db I dont see as a big issue... as tbarron said, updates must be avoid | 15:46 |
| gouthamr | ah, yes - vkmc's update to the description adds that piece; we need all of the extra-specs since not all of them are in the share/instance models | 15:47 |
| gouthamr | cool, vhari - so this issue still exists and is multi-part | 15:48 |
| vhari | gouthamr, ack | 15:48 |
| vhari | gouthamr, that's all we had for stale bugs | 15:48 |
| gouthamr | its tagged Wishlist - which *could* mean RFE, but lets add that tag also | 15:49 |
| vhari | gouthamr, will do | 15:49 |
| gouthamr | the manager piece seems like a good first issue for someone trying to learn the code base | 15:49 |
| gouthamr | we can update drivers separately in subsequent patches | 15:50 |
| tbarron | +1 | 15:50 |
| gouthamr | great, i think we have time for triaging new bugs? | 15:51 |
| gouthamr | #topic Bug Triage (vhari) | 15:51 |
| vhari | gouthamr, not reviewing patches | 15:52 |
| vhari | :) if so lets take a look at #link https://bugs.launchpad.net/manila/+bug/1900755 | 15:52 |
| vhari | we had one new bug this week which is in progress .. ^^ bugs was added to etherpad | 15:53 |
| gouthamr | thanks vhari | 15:53 |
| gouthamr | "Seems like NetApp driver is not raising the error "SecurityServiceFailedAuth". We need to fix NetApp driver." | 15:53 |
| gouthamr | #link https://review.opendev.org/c/openstack/manila/+/764489 (Add exception for insufficient privileges when using security services) | 15:54 |
| gouthamr | was tagged a partial fix | 15:54 |
| gouthamr | gah, my bad | 15:55 |
| gouthamr | i'll re-open this bug | 15:55 |
| gouthamr | ecsantos[m]: were you working on the netapp driver portion of this bug-fix? | 15:56 |
| felipe_rodrigues | From what I know, we've not started working on it... | 15:57 |
| gouthamr | ack, ty felipe_rodrigues.. i've set this back to "in progress" | 15:58 |
| ecsantos[m] | gouthamr: yes I was, some time ago. I'm yet to work on a backport to Victoria that was asked in IRC, but it shouldn't be too much work | 15:58 |
| gouthamr | ecsantos[m]: great, ty.. | 15:59 |
| gouthamr | glad you bubbled this up, vhari (and for noticing this kiran pawar) - in my fervent insecurity about our bug bot, i missed the "partial-bug" call out in the commit message | 16:00 |
| vhari | gouthamr, yw :D | 16:01 |
| gouthamr | we're at the hour | 16:01 |
| gouthamr | if you have more to chat, please hop on over to #openstack-manila | 16:01 |
| gouthamr | thank you all for attending | 16:01 |
| fabiooliveira | :D | 16:01 |
| gouthamr | excited to see you all at the PTG next week! | 16:01 |
| gouthamr | #endmeeting | 16:02 |
| opendevmeet | Meeting ended Thu Oct 14 16:02:02 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:02 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/manila/2021/manila.2021-10-14-15.01.html | 16:02 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/manila/2021/manila.2021-10-14-15.01.txt | 16:02 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/manila/2021/manila.2021-10-14-15.01.log.html | 16:02 |
| *** dviroel|rover is now known as dviroel|rover|afk | 21:30 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!