| *** hemna8 is now known as hemna | 07:37 | |
| *** dviroel|out is now known as dviroel | 11:16 | |
| *** dviroel is now known as dviroel|biab | 12:10 | |
| *** dviroel|biab is now known as dviroel | 12:27 | |
| *** dasm|off is now known as dasm|rover | 13:14 | |
| *** dviroel is now known as dviroel|ruck | 13:44 | |
| *** dviroel|ruck is now known as dviroel | 13:48 | |
| gouthamr | #startmeeting manila | 15:00 |
|---|---|---|
| opendevmeet | Meeting started Thu Feb 3 15:00:29 2022 UTC and is due to finish in 60 minutes. The chair is gouthamr. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'manila' | 15:00 |
| gouthamr | courtesy ping: ganso vkmc dviroel carloss tbarron felipe_rodrigues ecsantos vhari fabiooliveira | 15:00 |
| carloss | o/ | 15:00 |
| ecsantos[m] | o/ | 15:00 |
| felipe_rodrigues | o/ | 15:00 |
| kafilat | o/ | 15:00 |
| andrebeltrami[m] | o/ | 15:00 |
| rfluisa | o/ | 15:00 |
| angiolucci | o/ | 15:00 |
| caiquemello[m] | o/ | 15:01 |
| fabiooliveira | o/ | 15:01 |
| sfernand | hi | 15:01 |
| gouthamr | \o hello everyone | 15:01 |
| nahimsouza[m] | o/ | 15:01 |
| ashrodri | o/ | 15:01 |
| gouthamr | thanks for joining... here's our agenda for today: https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting | 15:01 |
| gouthamr | lets get started with | 15:01 |
| gouthamr | #topic Announcements | 15:02 |
| gouthamr | a reminder that feature freeze deadline is nearing: Feb 25 is the Yoga-3 milestone and Client Library Freeze | 15:02 |
| gouthamr | #link https://releases.openstack.org/yoga/schedule.html | 15:02 |
| tbarron | Hi | 15:02 |
| gouthamr | we'll discuss the reviews in a bit | 15:03 |
| dviroel | o/ | 15:03 |
| gouthamr | apart from that, its been a quiet week for news.. | 15:03 |
| gouthamr | anyone else got any announcements? | 15:03 |
| gouthamr | alright, lets discuss reviews | 15:04 |
| gouthamr | #topic M-3 feature reviews tracking | 15:04 |
| gouthamr | #link https://etherpad.opendev.org/p/manila-yoga-review-focus | 15:04 |
| gouthamr | i forget who we tagged with reviewing the scheduler hints patches :) | 15:06 |
| sfernand | should multiple subnets be in the m3 as well? | 15:06 |
| gouthamr | #link https://review.opendev.org/c/openstack/manila/+/817379 | 15:06 |
| gouthamr | #link https://review.opendev.org/c/openstack/manila-tempest-plugin/+/816168 | 15:06 |
| gouthamr | #link https://review.opendev.org/c/openstack/python-manilaclient/+/817739 | 15:06 |
| gouthamr | #link https://review.opendev.org/c/openstack/manila-ui/+/814694 (manila-ui support for scheduler hints) | 15:06 |
| gouthamr | sfernand: yes, all feature changes should be merged by m3 | 15:07 |
| sfernand | ok will be include our links there | 15:07 |
| felipe_rodrigues | I'm part of reviewers for hints | 15:07 |
| felipe_rodrigues | adding myself in the etherpad | 15:07 |
| gouthamr | thanks felipe_rodrigues | 15:08 |
| gouthamr | i think this is nearly there | 15:08 |
| gouthamr | #link https://review.opendev.org/q/topic:%22bp%252Fmanila-share-support-recycle-bin%22+(status:open%20OR%20status:merged) (Recycle bin support) | 15:08 |
| felipe_rodrigues | tempest I'm trying to make it pass on NetApp CI | 15:08 |
| felipe_rodrigues | still failing | 15:09 |
| vhari | o/ | 15:09 |
| * vhari sry held up on another call | 15:10 | |
| gouthamr | felipe_rodrigues: oh, do you suspect it has to do with the job configuration? | 15:11 |
| gouthamr | https://netappopenstacklogserver.s3-us-west-1.amazonaws.com/logs/68/816168/5/upstream-check/manila-cDOT-manila-tempest-plugin-ss/2c6e793/2c6e793/console.html.txt | 15:11 |
| gouthamr | i don't see manila tempest plugin in your local.conf: https://netappopenstacklogserver.s3-us-west-1.amazonaws.com/logs/68/816168/5/upstream-check/manila-cDOT-manila-tempest-plugin-ss/2c6e793/2c6e793/logs/local.conf.txt | 15:12 |
| dviroel | "tempest list-plugins" -> nothing | 15:12 |
| felipe_rodrigues | Yeah, it seems a NetApp issue, not a problem with the patch itself | 15:12 |
| andrebeltrami[m] | I'll help felipe on that in our CI | 15:12 |
| felipe_rodrigues | thanks andrebeltrami[m] :) | 15:13 |
| gouthamr | ack; ty | 15:13 |
| andrebeltrami[m] | np | 15:14 |
| gouthamr | on the recycle bin changes, https://review.opendev.org/c/openstack/manila-tempest-plugin/+/802644 is still failing CI | 15:14 |
| gouthamr | we might have to run some tests locally and review this | 15:15 |
| gouthamr | carloss dviroel and i are assigned here.. | 15:16 |
| haixin | I need to update the micversion to 2.68 | 15:16 |
| gouthamr | haixin: oh, yes | 15:16 |
| haixin | I am still on Spring Festival holiday, I will change it after work | 15:17 |
| gouthamr | ack, and Happy New Year haixin :) | 15:17 |
| carloss | I'm finishing my tests on the change :) | 15:17 |
| carloss | should post an output soon | 15:17 |
| gouthamr | thanks carloss | 15:17 |
| carloss | yw :) | 15:17 |
| gouthamr | #link https://review.opendev.org/q/topic:bp%252Fmetadata-for-share-resources (Metadata for share resources) | 15:18 |
| gouthamr | ashrodri: what's the status with these? | 15:19 |
| ashrodri | shares metadata api changes (including admin-only) are ready for review, snapshots not quite but almost there. Running into issues with the CLI unit tests, and tempest tests are on the way | 15:20 |
| gouthamr | > snapshots not quite but almost there | 15:22 |
| gouthamr | are you hitting any major issues here? | 15:22 |
| ashrodri | unit test failure, though nothing big i think its a viewbuilder thing. | 15:23 |
| ashrodri | should have that fixed today | 15:23 |
| gouthamr | okay, thanks ashrodri; would the tempest tests be uploaded today as well? the shares patch is refactoring, and you mentioned needing to peel off an existing tempest test: | 15:24 |
| gouthamr | #link https://review.opendev.org/c/openstack/manila-tempest-plugin/+/826747 (remove share metadata test) | 15:24 |
| ashrodri | yeah I can do that | 15:25 |
| gouthamr | i want to drive some consensus here - we rarely if ever remove a tempest test | 15:25 |
| ashrodri | right, the test in question involved allowing a key ending with '.json' or '.xml' to be set but not deleted | 15:27 |
| dviroel | can we just skip the test in new api versions? if the test doesn't make sense anymore | 15:28 |
| ashrodri | i would consider that a bug, if werent for the fact that it was an intentional change and the test was made with that behavior in mind. I guess the question is whether to keep it that way, or let users set whatever keys they want and delete them too | 15:29 |
| gouthamr | dviroel: the problem exists in a layer above version control --> the route mapper which parses the endpoint shaves off ".xml" and ".json" at the end of the url before mapping | 15:30 |
| felipe_rodrigues | dviroel++ | 15:30 |
| gouthamr | https://github.com/openstack/manila/blob/a3aaea91494665a25bdccebf69d9e85e8475983d/manila/api/openstack/__init__.py#L55 | 15:31 |
| gouthamr | none of our APIs end with ".json" or ".xml" | 15:32 |
| gouthamr | but we had that special casing for some reason, this is something i don't really understand well... | 15:33 |
| ashrodri | I could potentially skip this test starting with the admin-only microversion (which also has tests on the way) since microversioning the refactored code doesnt make much sense to me | 15:33 |
| * dviroel looking - and blaming | 15:33 | |
| gouthamr | most of our URIs will have UUIDs at the end | 15:33 |
| gouthamr | the only place you'd ever have names and not UUIDs would be metadata and extra-specs | 15:33 |
| gouthamr | dviroel: i'll take the blame :D i asked for a test when we were putting that code in, assuming it'd never be a problem - i didn't anticipate us splitting out our routes the way ashrodri is doing | 15:34 |
| gouthamr | with ashrodri's changes, we now have the router handling the end portion of the URL properly | 15:35 |
| gouthamr | so there's no need for additional "connect"s | 15:35 |
| gouthamr | so we don't use that code path with metadata any more | 15:35 |
| gouthamr | s/don't/won't | 15:36 |
| gouthamr | https://review.opendev.org/c/openstack/manila/+/824648/9/manila/api/v2/router.py | 15:36 |
| dviroel | yeah, didn't have the chance to dig into ashrodri's work (sorry ashrodri) | 15:37 |
| felipe_rodrigues | since tempest is branchless, older stables branches will stop testing this wrong behavior | 15:40 |
| felipe_rodrigues | right ? | 15:40 |
| gouthamr | yes | 15:40 |
| gouthamr | a skipUnless(max_microversion<2.xx) could work - but its wonky; i'd like to see a proper explanation in code | 15:40 |
| gouthamr | if we do that | 15:40 |
| gouthamr | for posterity | 15:40 |
| felipe_rodrigues | Could it be treat as a bug fix and backport it to older releases ? so we could drop the test, since it does not make any sense for any branches | 15:41 |
| felipe_rodrigues | just the router part | 15:41 |
| gouthamr | it's possible, but is it worth it? | 15:42 |
| felipe_rodrigues | i dont think so.. kkk | 15:42 |
| felipe_rodrigues | i prefer the skip one | 15:42 |
| gouthamr | lets play this out for real users ---> we're letting them set something they can't ever delete | 15:42 |
| gouthamr | the only way to delete an "offending" key would be to delete the share or have an admin perform direct db changes | 15:43 |
| fabiooliveira | kkk = hahaha for brazilians | 15:43 |
| felipe_rodrigues | thks fabiooliveira | 15:43 |
| gouthamr | haha :) /me got that | 15:43 |
| gouthamr | i like to think the key was never offending to begin with | 15:44 |
| ashrodri | for users if they have a "foo=bar" and "foo.xml=bar" attempting to delete foo.xml, would actually delete foo which is not great | 15:44 |
| gouthamr | ^ +1 | 15:44 |
| gouthamr | so is the agreement that we skip the test? | 15:46 |
| gouthamr | or delete the test? | 15:46 |
| felipe_rodrigues | if the skip is possible, I'd prefer since older stables should check that behavior | 15:47 |
| felipe_rodrigues | I don't have a strong opnion on that.. I'm fine to delete too | 15:48 |
| carloss | I don't think it's a big of a problem to delete it tbh | 15:49 |
| dviroel | i'm ok with deletion too - a skip will need a little bit of context | 15:51 |
| gouthamr | thanks, i prefer deletion too | 15:52 |
| * dviroel rip test_try_delete_metadata_with_unsupport_format_key | 15:52 | |
| carloss | hahaha | 15:52 |
| vhari | :) | 15:52 |
| ashrodri | rip haha | 15:52 |
| gouthamr | alright, lets move on.. | 15:53 |
| gouthamr | #link https://review.opendev.org/q/topic:bp%252Fmultiple-share-network-subnets (Add support to multiple subnets per AZ) | 15:53 |
| gouthamr | how's this one going? | 15:53 |
| gouthamr | i see status updates inline | 15:54 |
| sfernand | ok so we removed all WIPs from patches, we have a few of them already with Zuul +1 | 15:54 |
| gouthamr | good stuff | 15:54 |
| sfernand | we basically forgot to make the alembic upgrade tests so we are working on it right now | 15:54 |
| sfernand | :( | 15:55 |
| ecsantos[m] | Container only waiting on the manila-tempest-plugin-lvm job to pass | 15:55 |
| gouthamr | ack ty | 15:55 |
| sfernand | andre is about to start testing our driver changes with the new tempests tests we implemented | 15:56 |
| sfernand | but should take some time to have the results | 15:56 |
| gouthamr | okay; you'll be posting them in review? | 15:57 |
| gouthamr | or do you have some CI smarts in place? | 15:57 |
| andrebeltrami[m] | maybe we need to post the results in an experimental pipeline | 15:58 |
| andrebeltrami[m] | to enable the new flags in our CI | 15:58 |
| andrebeltrami[m] | for NetApp driver | 15:59 |
| sfernand | andrebeltrami[m]: +1 | 15:59 |
| gouthamr | okay thanks for the updates | 15:59 |
| gouthamr | we have 1 min left | 15:59 |
| gouthamr | we can't do bug triage again here | 15:59 |
| gouthamr | vhari: are there ones we want to catch up on in #openstack-manila? | 16:00 |
| vhari | gouthamr, no new bugs .. good for now | 16:01 |
| gouthamr | ah good :) | 16:01 |
| gouthamr | awesome, thanks everyone for participating | 16:01 |
| gouthamr | and for reviewing patches | 16:01 |
| dviroel | ++ | 16:01 |
| fabiooliveira | o/ | 16:01 |
| gouthamr | see you all here next week, and on #openstack-manila in the meantime | 16:01 |
| gouthamr | #endmeeting | 16:01 |
| opendevmeet | Meeting ended Thu Feb 3 16:01:58 2022 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:01 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/manila/2022/manila.2022-02-03-15.00.html | 16:01 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/manila/2022/manila.2022-02-03-15.00.txt | 16:01 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/manila/2022/manila.2022-02-03-15.00.log.html | 16:01 |
| *** dviroel is now known as dviroel|lunch | 16:02 | |
| *** whoami-rajat__ is now known as whoami-rajat | 16:12 | |
| *** dviroel|lunch is now known as dviroel | 17:02 | |
| *** dviroel is now known as dviroel|afk | 20:50 | |
| *** dasm|rover is now known as dasm|off | 22:02 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!