| *** dasm|off is now known as dasm | 14:00 | |
| carloss | #startmeeting manila | 15:00 |
|---|---|---|
| opendevmeet | Meeting started Thu Feb 16 15:00:35 2023 UTC and is due to finish in 60 minutes. The chair is carloss. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'manila' | 15:00 |
| carthaca | hi | 15:00 |
| vhari | o/ | 15:00 |
| thiagoalvoravel | o/ | 15:01 |
| gouthamr | o/ | 15:01 |
| caiquemello[m] | 0/ | 15:01 |
| nahimsouza[m] | o/ | 15:01 |
| felipe_rodrigues | hi | 15:02 |
| MatheusAndrade[m] | o/ | 15:02 |
| haixin | o/ | 15:03 |
| carloss | today's meeting agenda: | 15:03 |
| carloss | #link https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting | 15:03 |
| carloss | courtesy ping: dviroel | 15:04 |
| HelenaDantas[m] | o/ | 15:04 |
| dviroel | o/ | 15:04 |
| ashrodri | o/ | 15:05 |
| carloss | o/ hello everyone! great quorum | 15:05 |
| luizsantos[m] | o/ | 15:05 |
| carloss | let's get started with our meeting agenda for today :) | 15:05 |
| carloss | the agenda is short. I want to focus on reviews for today. | 15:06 |
| carloss | #topic Announcements | 15:06 |
| carloss | Schedule and deadlines: | 15:06 |
| carloss | #link https://releases.openstack.org/antelope/schedule.html | 15:06 |
| carloss | this is feature freeze week! | 15:06 |
| carloss | and also client release week. we need to ship our client tomorrow tops. | 15:07 |
| carloss | one extra announcement: | 15:09 |
| carloss | the schedule for the OpenInfra summit in vancouver is live! | 15:09 |
| carloss | #link https://vancouver2023.openinfra.dev/a/schedule?_ga=2.76639381.1243381063.1676560116-1124383034.1671025814 | 15:09 |
| carloss | we had one manila talk accepted as a lightning talk! | 15:09 |
| carloss | and a lot of interesting things there :) | 15:10 |
| carloss | please check it out! | 15:10 |
| carloss | that's all I had for announcements. Do you have something else you'd like to share with us today? | 15:10 |
| carloss | taking silence as no :) | 15:12 |
| carloss | #topic Review Focus | 15:13 |
| carloss | so for today I want to do a check on a couple of changes: | 15:13 |
| gouthamr | o/ just remembered something :) | 15:14 |
| carloss | sure gouthamr | 15:15 |
| carloss | please go ahead | 15:15 |
| gouthamr | sorry for the interrupt | 15:15 |
| carloss | no worreis | 15:15 |
| gouthamr | but congratulations and thank you for becoming our PTL through the Bobcat release | 15:15 |
| dviroel | carloss++ | 15:16 |
| ashrodri | carloss++ | 15:16 |
| caiquemello[m] | carloss ++ | 15:16 |
| gouthamr | it’s a hard job herding cats and churning oceans - but we love that you are doing this for us :) | 15:16 |
| carloss | haha, thanks guys! really appreciated. I really think I have learned a lot in the role and that there is still motivation to continue. I love being a part of this community (many of you know I really do :)), so that makes the task more pleasant | 15:19 |
| gouthamr | ++ | 15:19 |
| carloss | and you have a huge part on this! so I'm happy to continue | 15:20 |
| carloss | and if you feel like being PTL some day, I am pretty sure we are open for a change of leadership, as they are very healthy! | 15:21 |
| carloss | I'd be happy to help you to get there! | 15:21 |
| vhari | carloss++ | 15:21 |
| carloss | thanks! | 15:21 |
| carloss | moving on... | 15:21 |
| carloss | #link https://etherpad.opendev.org/p/manila-antelope-review-focus (review focus etherpad) | 15:22 |
| carloss | so for today I want to do a check on a couple of changes: | 15:22 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/843832 (Share transfer between projects) | 15:24 |
| carloss | gouthamr and I have been reviewing this change lately and haixin has been solving comments in a blink of an eye | 15:24 |
| carloss | there are a couple of things we discovered on the reviews though: an issue when we have multiple share replicas and re-applying access rules to them | 15:24 |
| carloss | after some discussion, the three of us agreed on: blocking share transfers for replicated shares and redesign this on the upcoming PTG | 15:25 |
| carloss | I see some changes haixin made to the code, but I think we could fail earlier in the API and I have detailed it here: | 15:25 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/843832/comments/78f1849d_e067739a | 15:25 |
| carloss | but after discussing it with haixin a few minutes ago, we realized that only item 1 would fit, as we don't allow people creating replicas from shares that are not available, and the transfer leaves the share in a different status | 15:26 |
| haixin | i am working on it | 15:26 |
| carloss | I really think we can get this merged for this release. We are getting there, and if we need a feature freeze exception, I feel we can do it! | 15:27 |
| gouthamr | +1 | 15:28 |
| carloss | I am not very confident that the client will make it because we need to have the core merged + merge the client today | 15:28 |
| haixin | We also don't need to worry about the replicas quota when accept transfer. | 15:28 |
| carloss | ah, true - as we won't allow replicated shares to be transferred for now, it makes sense | 15:29 |
| carloss | so in the worst case scenario we merge the client next release, which happened a couple of times in the past | 15:29 |
| haixin | that is ok for me if have to merge next release. | 15:30 |
| carloss | awesome! thanks haixin | 15:30 |
| carloss | many thanks to the reviewers too! | 15:30 |
| ashrodri | haixin++ thanks for all your hard work on this! | 15:31 |
| carloss | haixin++ :) | 15:31 |
| carloss | next on the list: | 15:32 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/869707/ (Metadata share network subnet) | 15:32 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/869708/ (NetApp Driver modification) | 15:32 |
| carloss | #link https://review.opendev.org/c/openstack/python-manilaclient/+/869709 (Client) | 15:32 |
| carloss | this has received a couple of reviews | 15:32 |
| carloss | CI is not playing nice on the core change. felipe_rodrigues: this is open to a feature freeze exception, even though I think there's a chance we won't need it if reviewers are okay in the next pass | 15:33 |
| felipe_rodrigues | Thanks everyone for the reviews | 15:33 |
| carloss | the client change though: comments are there for some time. I *must* update the client release patch by EOD for me tops, so I can get at least one day for the release to happen. I believe there's a chance this will not make it in this client release too, so we will need to merge the client in the next release | 15:34 |
| felipe_rodrigues | I'm fine to merge the client in next release.. I can talk to customer about applying the patch .. it's much easier than server code | 15:35 |
| carloss | ack felipe_rodrigues | 15:35 |
| carloss | I would also like to ask: what are your plans on adding tests to this change, felipe_rodrigues? Asking because we don't have any functional tests coverage yet | 15:35 |
| felipe_rodrigues | Good point.. we can work on some functional tests as we did with snapshot metadata later | 15:36 |
| carloss | yep - snapshot metadata had the tests proposed with the change but took some time to get in. We have tested most scenarios manually. We can try to have some sort of focus on testing this before RC1 so we ensure we are not shipping any bugs | 15:37 |
| carloss | if issues are encountered, we can file bugs and propose as bugfixes | 15:38 |
| carloss | s/ We have tested most scenarios manually/ We have tested most scenarios manually for subnet metadata though | 15:38 |
| felipe_rodrigues | perfect! | 15:38 |
| carloss | thanks | 15:39 |
| felipe_rodrigues | yw | 15:39 |
| carloss | #link https://review.opendev.org/q/topic:bug%252F2000171 (Add quiesce_wait_time option to share replica promote API) | 15:39 |
| carloss | core change has landed | 15:39 |
| carloss | kpdev was quick on solving comments too :) | 15:39 |
| carloss | I believe the client is close and is a candidate for this release | 15:39 |
| carloss | to the reviewers: could you please circle back on this change and provide some feedback today? | 15:40 |
| carloss | also: | 15:41 |
| carloss | #link https://review.opendev.org/q/topic:bug%252F1988146 (Add default datasite to security service) | 15:41 |
| carloss | just saw the workflow on the core - thanks gouthamr | 15:41 |
| carloss | so we will have the client and the NetApp change for now | 15:41 |
| carloss | I think we are fine in terms of FFE | 15:42 |
| carloss | and last change from kpdev: | 15:42 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/859301 (Add 'state' column in 'services' table) | 15:42 |
| felipe_rodrigues | About quiesce_wait_time, I think we agreed functional tests to be added later.. | 15:43 |
| carloss | felipe_rodrigues: yes | 15:43 |
| carloss | good point - I'll ping kpdev on that later too | 15:44 |
| felipe_rodrigues | nice | 15:45 |
| carloss | continuing on the state column to the services table: even though the above it does not change the API, it does a db bump. Thanks for the reviews gouthamr - I am taking this as a temptative, but unsure if we would pursue a feature freeze exception | 15:45 |
| gouthamr | think we can; there's a little bit of an API impact -- i.e., introduction of a new "stopped" state | 15:45 |
| gouthamr | but, no change to the request/response schema or hence the clients | 15:46 |
| carloss | sure | 15:49 |
| carloss | okay - let's continue to give it a try | 15:49 |
| carloss | #link https://review.opendev.org/q/topic:bp/netapp-ontap-rest-api-client+status:open (NetApp ONTAP - REST API transition) | 15:49 |
| carloss | Now the biggest changes of this cycle. We had a collab review earlier this week and here's a link to the recordings: | 15:50 |
| carloss | #link https://www.youtube.com/watch?v=zCOm_g7HGWU (NetApp ZAPI -> Rest Collab Review) | 15:50 |
| carloss | The Structure change has merged but there are still 3 *major* changes under review. I am sure this will need a feature freeze exception. | 15:51 |
| carloss | for the features we are pursuing an FFE: I would like to target them to next Thursday tops | 15:53 |
| carloss | all of the changes we mentioned are features that qualify for feature freeze/client freeze. | 15:55 |
| carloss | we have a couple of bug fixes that can land after the freeze | 15:56 |
| carloss | is there something else you would like to bring up? | 15:56 |
| felipe_rodrigues | Do I need to send an email requesting the FFE for REST transition feature ? | 15:57 |
| carloss | usually we would ask everyone to send the emails, but I can just send the emails wrt the changes that are yet to merge and qualify for the exception | 15:58 |
| carloss | so: let's do our best to get the changes that are close to get merged today/tomorrow | 15:58 |
| felipe_rodrigues | thank you carloss | 15:58 |
| carloss | and I can send the email for the request, as I did last cycle | 15:58 |
| felipe_rodrigues | nice | 15:58 |
| carloss | np felipe_rodrigues | 15:59 |
| carloss | okay, we are at the top of the hour | 16:00 |
| carloss | sorry for not leaving time for bug triaging vhari :( | 16:00 |
| carloss | we can compensate next week :) | 16:00 |
| carloss | thank you everyone for joining today and for helping with reviews | 16:00 |
| carloss | let's continue chatting on the changes and on #openstack-manila! | 16:00 |
| carloss | #endmeeting | 16:01 |
| opendevmeet | Meeting ended Thu Feb 16 16:01:00 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:01 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/manila/2023/manila.2023-02-16-15.00.html | 16:01 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/manila/2023/manila.2023-02-16-15.00.txt | 16:01 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/manila/2023/manila.2023-02-16-15.00.log.html | 16:01 |
| *** dasm is now known as Guest5046 | 16:46 | |
| *** dasm is now known as Guest5052 | 18:10 | |
| *** dasm_ is now known as dasm|off | 23:55 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!