Wednesday, 2023-06-28

*** chuanm4 is now known as chuanm02:19
whoami-rajat#startmeeting cinder14:00
opendevmeetMeeting started Wed Jun 28 14:00:04 2023 UTC and is due to finish in 60 minutes.  The chair is whoami-rajat. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
opendevmeetThe meeting name has been set to 'cinder'14:00
whoami-rajat#topic roll call14:00
happystackerHello all14:00
eharneyhi14:00
rosmaitao/14:00
senriquehi14:00
toskyo/14:00
whoami-rajat#link https://etherpad.opendev.org/p/cinder-bobcat-meetings14:01
whoami-rajatguess who forgot this was the last wednesday of the month?14:01
Tony_Saad0/14:01
* whoami-rajat facepalms14:01
MatheusAndrade[m]o/14:01
jungleboyjo/14:02
thiagoalvoravelo/14:02
felipe_rodrigueso/14:02
luizsantos[m]o/14:03
whoami-rajatgood turnout today14:04
whoami-rajatlet's get started14:04
whoami-rajat#topic announcements14:04
whoami-rajatMilestone-2 (06 July)14:05
whoami-rajatwe have the Volume and target Driver freeze coming up next week14:05
whoami-rajat#link https://etherpad.opendev.org/p/cinder-2023-2-bobcat-drivers14:05
whoami-rajatI have created this etherpad to track the open drivers14:05
whoami-rajatcurrently there are only 2, Yadro and Lustre14:05
whoami-rajatif there are any other drivers which i missed, please add it to the list14:06
helenadantas[m]o/14:06
whoami-rajatothers, please review the drivers14:06
caiquemello[m]o/14:06
whoami-rajatnext, SQLAlchemy 2.0 resolution14:07
whoami-rajat#link https://review.opendev.org/c/openstack/governance/+/88708314:07
whoami-rajatJayF proposed a governance patch to provide details about migration to SQLAlchemy 2.014:07
whoami-rajatbasically they are planning to bump the requirements to sqlalchemy2.0 early in 2024.1 cycle14:07
whoami-rajatto get an idea of which projects are compatible with it and which are not14:08
whoami-rajatit is also mentioned that projects need to move away from sqlalchemy-migrate and implement alembic14:08
whoami-rajatthat work has already been done in Cinder, thanks to Stephen14:08
whoami-rajathopefully the requirement bump to sqlalchemy 2.0 won't affect cinder but let's see14:08
whoami-rajatwe will have sufficient amount of time to fix the gate14:09
whoami-rajatalso the resolution isn't final yet so there might be changes but above points should be constant, as they have been for past few cycles14:09
whoami-rajatnext, EM Discussion14:09
whoami-rajatthere is no update on this14:09
whoami-rajatwas just checking the TC meeting discussion and I guess Kristi or JayF is going to start a ML thread for continuing discussion from PTG14:10
whoami-rajatlet's see if we get an update this week14:10
whoami-rajatnot sure if we want to hold on our EOL patches till then14:10
whoami-rajatrosmaita, what are your thoughts? ^14:10
rosmaitanot sure, really14:11
rosmaitamaybe we could do one more announcement to give packagers a heads-up14:12
whoami-rajatsounds good14:12
rosmaitai think we can separate out the overall EM discussion from what's best for cinder right now14:12
whoami-rajatdo we want to use the old thread or create a new one?14:12
rosmaitai think create a new one14:12
whoami-rajatyeah true, not sure how long this discussion going to go14:12
rosmaitaso we can get something like "FINAL CALL FOR COMMENTS: " in the subject line14:13
whoami-rajatsure, i will take an action item for this14:13
whoami-rajatand good idea to separate it out from the EM discussion14:13
whoami-rajat#action whoami-rajat to send a mail regarding reminder for cinder branches being EOL14:14
rosmaitasounds good14:14
whoami-rajatthanks!14:14
whoami-rajatthat's all the announcements we had for today14:14
whoami-rajatanyone has anything else?14:15
whoami-rajatrosmaita, i did do a summary of your summary of PTG, not sure if you got time to go through it but apart from that, anything from PTG you would like to highlight?14:15
rosmaitai can't think of anything14:16
rosmaitai hope the poor turnout for the PTG was because of bad timing, not lack of interest14:16
rosmaitathat is, we already had the 2023.2 PTG virtually a few months ago14:16
whoami-rajatyeah, that could be the same reason why we weren't able to gather much topics for cinder sessions as well14:17
rosmaitaso maybe companies didn't think it was a priority to go to this one14:17
whoami-rajatagreed, doesn't seem the project is losing interest, it was just an event at odd time14:18
whoami-rajatok, guess that's all for announcements14:19
whoami-rajatlet's move to topics14:19
whoami-rajat#topic Bug: https://bugs.launchpad.net/cinder/+bug/200253514:19
whoami-rajatnot sure who added it, there is no IRC nick14:19
happystackermy bad it's me14:19
happystackerso it seems that there is a conversion from qcow2 to raw during the creation from an image14:20
whoami-rajatoh ok, please go ahead14:20
happystackerand the metadata of the volume is not updated 14:20
happystackerso it remains qcow214:20
happystackerwhile the block dev is raw14:21
happystackeras a result, when creating an instance the attachment shows qcow2 but it works fine14:21
happystackeruntil you want to resize it where an error is thrown14:21
happystackersaying that the format mismatch14:21
happystackerSo I have proposed a fix: https://review.opendev.org/c/openstack/cinder/+/88154914:22
whoami-rajatare you using the generic nfs driver or vendor nfs?14:22
eharneyis that the right gerrit link?14:22
happystackerI'm using powerstore but it happens in the nfs generic space14:23
happystackerweird14:23
happystackerhttps://review.opendev.org/c/openstack/cinder/+/88708114:23
happystackerthat's the right one14:23
senriqueI reproduced part of the problem of the launchpad bug.. 14:24
eharneyi think that patch has some problems but i'll review it more closely and comment there14:24
happystackersure, I'm still learning14:24
senriqueWhen creating a volume from a glance image.. cinder created a raw volume. This happens because the nfs driver first fetches the glance image glance and keeps using the same format. 14:24
eharney(it probably autodetects the wrong format when using raw images)14:25
senriquefetch the image to raw*14:25
whoami-rajathappystacker, is this config option enabled in your deployment? nfs_qcow2_volumes14:25
whoami-rajatand are you using a master deployment or an older version?14:25
happystackerYes, but it seems not to change anything14:25
happystackermaster deployment14:26
whoami-rajathmm, i think we have a problem but need to test it14:27
happystackerlet me know if I can help more14:28
whoami-rajatwe set the format during driver initialization to 'raw' https://github.com/openstack/cinder/blob/e673bcc368d3a24ec21713adbd83b4ab6cbcae18/cinder/volume/drivers/remotefs.py#L18014:28
whoami-rajatbut if we enable the qcow2 option, we switch the format to 'qcow2' https://github.com/openstack/cinder/blob/e673bcc368d3a24ec21713adbd83b4ab6cbcae18/cinder/volume/drivers/remotefs.py#L32614:29
whoami-rajatbut we will restart the service while doing the config change14:29
whoami-rajatso i guess it should be fine14:29
whoami-rajatanyway, as i said, need to be tested but it is possible that the format value is not assigned correctly in some cases14:30
senriquewhoami-rajat, in L530 `image_utils.fetch_to_raw`14:30
happystackerproblem happens here: https://github.com/openstack/cinder/blob/e673bcc368d3a24ec21713adbd83b4ab6cbcae18/cinder/volume/drivers/remotefs.py#L53014:30
happystackerso maybe we just can add a validation step which prevents the conversion if the qcow2 option is enabled?14:31
whoami-rajati think we always convert the qcow2 image to raw when we want to create a bootable volume from image14:32
whoami-rajatdo we support writing a qcow2 image to a qcow2 volume?14:32
happystackerAs for now, there is a check which verifies that both format are the same, if it's not the case, it'll update the metadata14:32
happystackerit's always converted yes14:32
eharneywe could support qcow2->qcow2, not sure if it tries to currently14:32
happystackerso if the conversion happens, then the metadata should be updated as well right?14:33
whoami-rajati remember disabling qcow2->qcow2 in glance but not sure what was the reason14:33
eharneyit looks like the key is checking the format when copying the image and doing the right thing when the volume is supposed to be a qcow2 format14:33
whoami-rajatyep we don't support it in glance cinder store, let me see if i can find the reason https://github.com/openstack/glance_store/blob/5a81f77bd48e46eac6ab0636f0f52dbceec4e8d3/glance_store/_drivers/cinder/nfs.py#L7214:35
eharneybecause the glance store is expecting to deal with cinder volumes that are raw, it doesn't support nfs snaps either14:35
eharneypresumably because that restriction is much easier than adding support for all of that14:36
happystackerok14:36
senriqueI'm not sure if possible but maybe we replace fetch_to_raw with `fetch_to_volume_format` https://github.com/openstack/cinder/blob/e673bcc368d3a24ec21713adbd83b4ab6cbcae18/cinder/image/image_utils.py#L82214:36
happystackerwhich means we need to keep the conversion14:36
happystackerbut update the metadata to reflect the change?14:37
happystackerso that the attachment will be raw based but not qcow214:37
whoami-rajathttps://github.com/openstack/glance_store/commit/85c7a06687291eba30510d63d3ee8b9e9cb33c5f14:37
whoami-rajatlooks like there is some problem with extend volume in case of qcow2->qcow2, as i see written in the commit message14:38
whoami-rajatbut don't remember anything else ...14:38
eharneyalso, we need to support writing images to qcow2 volumes to support nfs encrypted volumes14:40
senriquein that case.. i think updating the metadata looks good14:40
senriqueyes, nfs encryption works with qcow214:40
whoami-rajateharney, ack, i think your comments makes sense that we are lacking a lot of support around it so better to just block it14:40
whoami-rajatsenrique, i don't exactly know the reason why we call fetch to raw here but we do that in all other reference drivers like lvm, ceph etc14:42
whoami-rajatbut again they don't have to deal with qcow2 volumes14:43
whoami-rajatnot really sure14:43
whoami-rajatlet's continue this discussion in the next event, maybe good for midcycle -2 ? let's see14:46
whoami-rajatwe have another topic to discussi14:46
whoami-rajatdiscuss14:46
whoami-rajat#topic test_rebuild_volume_backed_server failing 100% on ceph job14:47
whoami-rajatsenrique, that's you14:47
senriqueCI was failing because of that14:47
senrique#link https://bugs.launchpad.net/cinder/+bug/202509614:47
senriquebut now the "test_rebuild_volume_backed_server" test is skipped for the Ceph job until the problem is fixed.14:47
senrique#link https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/88700314:48
senriquethat's all :)14:48
whoami-rajatsenrique, i analyzed the job results yesterday and found the issue14:48
whoami-rajatlet me see if it's still in my notes14:48
senriquei think the nfs job is failling with the same issue tho14:48
whoami-rajatcurrently we have a timeout of 20 seconds per GB on the nova side during reimage14:49
whoami-rajatwhich we optimistically set for a good deployment14:49
whoami-rajatbut our gate jobs are pretty slow with IO and hence takes more time14:49
whoami-rajatthe cinder logs tell the truth about the time taken for the operation14:50
whoami-rajatfirst log: 01:02:49.78274614:50
whoami-rajatlast log: 01:03:23.66118214:50
whoami-rajatso it's around 34 seconds which is greater than the timeout14:50
whoami-rajathence we fail on the nova side14:50
whoami-rajatJun 26 01:03:11.721921 np0034441113 nova-compute[97944]: ERROR oslo_messaging.rpc.server eventlet.timeout.Timeout: 20 seconds14:50
whoami-rajatI didn't know there was a bug report, i will add my analysis to it though dansmith has already proposed patches to fix it14:51
whoami-rajatthanks for linking the bug senrique 14:51
senriquethanks whoami-rajat, good report14:51
rosmaitathat's a good catch whoami-rajat14:52
eharneyi'm currently looking into cinder-tempest-plugin-cbak-ceph failures as well, unclear if those are related14:52
senrique++14:52
whoami-rajatsorry got busy updating the bug, will do it later14:57
whoami-rajatlet's move to open discussion for 3 minutes14:57
whoami-rajat#topic open discussion14:57
whoami-rajatthere is a big list of review requests today14:57
whoami-rajatplease take a look when you get some time14:58
happystackerthank you!14:58
drencromHi all. I just would like to have some eyes on https://review.opendev.org/c/openstack/cinder/+/868485, its been a while. Thanks14:58
rosmaitadrencrom: ack15:00
whoami-rajatwe are out of time15:00
whoami-rajatthanks everyone for attending15:00
whoami-rajat#endmeeting15:00
opendevmeetMeeting ended Wed Jun 28 15:00:26 2023 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:00
opendevmeetMinutes:        https://meetings.opendev.org/meetings/cinder/2023/cinder.2023-06-28-14.00.html15:00
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/cinder/2023/cinder.2023-06-28-14.00.txt15:00
opendevmeetLog:            https://meetings.opendev.org/meetings/cinder/2023/cinder.2023-06-28-14.00.log.html15:00
*** chuanm5 is now known as chuanm22:30

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!