Wednesday, 2024-09-04

*** bauzas_ is now known as bauzas00:15
*** mhen_ is now known as mhen01:39
*** bauzas_ is now known as bauzas02:46
*** bauzas_ is now known as bauzas03:02
*** bauzas_ is now known as bauzas03:31
*** bauzas_ is now known as bauzas04:00
*** bauzas_ is now known as bauzas04:08
*** bauzas_ is now known as bauzas05:15
*** bauzas_ is now known as bauzas05:39
*** bauzas_ is now known as bauzas09:20
*** geguileo is now known as Guest246910:37
*** bauzas_ is now known as bauzas10:44
*** bauzas_ is now known as bauzas13:39
jbernard#startmeeting cinder14:00
opendevmeetMeeting started Wed Sep  4 14:00:06 2024 UTC and is due to finish in 60 minutes.  The chair is jbernard. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
opendevmeetThe meeting name has been set to 'cinder'14:00
jbernard#topic roll call14:00
rosmaitao/14:00
whoami-rajat_hi14:00
*** whoami-rajat_ is now known as whoami-rajat14:00
jhorstmanno/14:00
akawaio/14:02
rosmaitawhoami-rajat: thanks for fixing that pep8 issue14:02
whoami-rajatrosmaita, np, it was really strange it started breaking in gate, i think maybe we bumped some requirement that caused it14:03
jbernard#link https://etherpad.opendev.org/p/cinder-dalmatian-meetings14:03
jungleboyjo/14:04
bryanneumanno/14:05
jbernardhello everyone14:05
jbernardthin adgenda for today :)14:05
jbernardso, technically feature freeze was last week14:06
jbernardthere still one or two that we would like to land14:06
jbernard#link https://etherpad.opendev.org/p/cinder-dalmatian-reviews14:06
jbernardwe were able to get get to all of patches on the list in some capacity14:07
jbernardnot all were merged, some were moved to post-release14:07
jbernardbut overall, I think we got the majority of what was needed14:07
jbernardwhich is pretty good considering our review bandwidth14:08
jbernardthank you to everyone that both reviewed patches and reponded to review notes to help get patches in14:08
jbernardthe patches that haven't yet landed are at the top of the list for unfreeze14:10
jbernardim working on hightlights for the release team this week14:10
jbernardthat's about all ive got for today14:11
jbernardill open things up for discussion14:12
jbernard#topic open discussion14:12
eharneyi have a question about an API patch i have up14:12
eharneyhttps://review.opendev.org/c/openstack/cinder/+/926914  <- does this need a microversion change?14:12
jbernardeharney: would a newer client fail against a service that didn't have this patch?14:16
eharneyno14:16
jbernardmaybe you're thinking the same thing then, maybe a microversion is needed?14:16
jbernards/is/isn't14:17
jbernardwhoami-rajat: ^ curious your thoughts14:17
eharneysome requests that would previously fail will now be accepted which technically meets the requirements we document for needing a microversion, i think14:17
eharneywhether this matters in this instance is less obvious14:18
jbernardi dont think it costs us anything to bump it, maybe it's better to be safe14:19
eharneythe cost is forever maintaining two different paths down the api parameter validation code :)14:20
jbernardfair14:21
jbernardi need to re-read our requirements doc to have a more informed opinion14:22
whoami-rajatso we are relaxing the request for snapshot description to accept more characters, specifically newline14:23
whoami-rajatwe are also removing the character restriction i see which was previously 'minLength': 0, 'maxLength': 25514:23
whoami-rajatideally it should require MV bump but it seems overkill for a change like this ...14:23
eharneythe length restrictions don't change14:23
toskyjust remember that any tempest tests for that feature (I've seen a WIP) will apply to all releases, so the tests may need a flag (unless this is a fix and it is backported to all active branches :)14:24
eharneygood point14:25
whoami-rajati see, the validation is done by _validate_description_non_mandatory_remove_white_spaces and it is consistent with what volume schemas for description does14:27
whoami-rajatthe QA team has been strict about MVs and have blocked some of my past changes for similar reasons, on the other hand this one is a low impact change so we can let it slide, not sure TBH14:29
eharneyi'll just go with the microversion plan, i think14:30
eharneythere is some other weirdness about differences in volumes/snapshots name fields, but i'm a lot more suspicious about adding support for newlines in names14:31
eharney(which is currently allowed for volumes)14:32
*** bauzas_ is now known as bauzas14:36
jbernardanything else?  Else we can all get back to things14:37
jhorstmannI am currently looking for feedback on my idea for a cinder driver providing local storage by transparently migrating data using the device mapper clone target.14:37
jhorstmannI reached out on openstack-discuss, but got no response so far (https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/DYCKN6KEIRMM34SMKHWQU6HSJD3URMFN)14:37
jhorstmannIs this something which could be interesting for upstream?14:37
jbernardjhorstmann: that's an interesting idea, sorry I missed it14:38
jbernardjhorstmann: ill try to get a response to you14:39
jbernardjhorstmann: on the list14:39
jhorstmannno worries, that's why I am asking again :)14:39
jhorstmannthank you14:40
mhenbefore everyone leaves just a small thing14:40
jbernardsure14:40
mhenregarding the new image encryption standardization14:40
mhenwe got a new comment on the glance patchset https://review.opendev.org/c/openstack/glance/+/92629514:41
whoami-rajatjhorstmann, I haven't read the full email but will it be able to provide all the required functionalities needed for a cinder driver? https://docs.openstack.org/cinder/latest/reference/support-matrix.html#required-driver-functions14:41
mhenthat will also influence the cinder patchset https://review.opendev.org/c/openstack/cinder/+/92629814:41
mhenthere is some discussion necessary regarding introduction of a new container_format or disk_format for images14:41
mhenif you can please participate in the popup meeting on monday https://meetings.opendev.org/#Image_Encryption_Popup-Team_Meeting14:42
mhenit didn't happen this week but will likely next week14:42
rosmaitamhen: ack14:43
mhenthanks14:44
whoami-rajatmhen, so the luks inspector Dan has proposed would likely fail your changes with image_format as luks since both mean different things?14:44
jhorstmannwhoami-rajat: I have read that list and I have to admit that I currently do not have a solution for everything. Especially how to handle snapshots will be tricky. I wanted to present the general idea and see if there is interested first14:44
whoami-rajatjhorstmann, ah ok, i should've read the full email, it mentions this, so i didn't want you to put too many efforts and eventually end up in a condition where we won't accept the driver hence wanted to highlight we've a list of required features14:45
whoami-rajatwe can surely discuss this at the PTG14:46
whoami-rajati think if we don't have the required features, the tempest test will start failing for that particular driver14:46
whoami-rajatwhich we can maybe skip in the driver CI (yes, we will need to add a new CI for it)14:46
whoami-rajatbut we can discuss these details during PTG14:46
mhenwhoami-rajat: likely; due to the request from glance we avoided changing container_format or disk_format for encrypted images until now and handled this purely via special metadata properties but it seems that we will want to introduce new container_ or disk_format values after all to better represent those images and make them more clearly identifiable by the inspector14:47
jhorstmannwhoami-rajat: so far I can check volume CRD, attach/detach (though not while volumes are still being copied). currently working on host assisted volume migration, which should be possible14:48
whoami-rajatmhen, ok, understood, yeah the CVE was a big pain hence i understand Dan's concern of us not repeating similar mistake again14:49
jhorstmannwhoami-rajat: discussion at the PTG sounds good14:50
jbernardjhorstmann: that's a perfect venue for a topic like this, looking forward to it14:50
whoami-rajatjhorstmann, thanks for proposing the idea, would appreciate your notes on setting it up :)14:51
whoami-rajathost assisted migration shouldn't require much from driver side since most of the work is handled by cinder only14:52
whoami-rajatbut good to test the workflow14:52
jhorstmannwhoami-rajat: there is a brief instruction on setup hidden in footnote [4] of the email14:53
whoami-rajatjhorstmann, got it, looks straightforward, thanks14:55
jbernardok, last call14:57
jhorstmannjbernard, whoami-rajat: please note that there is a bug in the driver version linked in the mail leading to volumes being attached read-only, because I forgot to move 'access_mode' metadata14:58
jbernardjhorstmann: do you have a link to a version that includes a fix for this?14:58
jhorstmannjbernard: I will provide one as a reply to my original mail, okay?15:00
jbernardjhorstmann: perfect15:01
jbernardok, thank you everone15:01
jbernard#endmeeting15:01
opendevmeetMeeting ended Wed Sep  4 15:01:52 2024 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:01
opendevmeetMinutes:        https://meetings.opendev.org/meetings/cinder/2024/cinder.2024-09-04-14.00.html15:01
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/cinder/2024/cinder.2024-09-04-14.00.txt15:01
opendevmeetLog:            https://meetings.opendev.org/meetings/cinder/2024/cinder.2024-09-04-14.00.log.html15:01
jungleboyjThank you!15:02
whoami-rajatthanks!15:02
jhorstmannthank you15:03
*** bauzas_ is now known as bauzas16:03
*** geguileo is now known as Guest250016:08
*** bauzas_ is now known as bauzas16:44
*** bauzas_ is now known as bauzas17:41
*** bauzas_ is now known as bauzas18:39
*** bauzas_ is now known as bauzas19:24
*** bauzas_ is now known as bauzas19:40
*** bauzas_ is now known as bauzas20:04
*** bauzas_ is now known as bauzas21:10
*** bauzas_ is now known as bauzas23:09
*** bauzas_ is now known as bauzas23:26

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!