| *** mhen_ is now known as mhen | 02:39 | |
| *** chuanm9 is now known as chuanm | 12:21 | |
| carloss | #startmeeting manila | 15:00 |
|---|---|---|
| opendevmeet | Meeting started Thu Nov 7 15:00:11 2024 UTC and is due to finish in 60 minutes. The chair is carloss. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'manila' | 15:00 |
| carloss | courtesy ping: dviroel vhari gouthamr carthaca msaravan pulluri ashrodri | 15:00 |
| haixin | o/ | 15:00 |
| vhari | hi | 15:00 |
| dviroel | o/ | 15:00 |
| gireesh | 0/ | 15:01 |
| gouthamr | o/ | 15:02 |
| ashrodri | o/ | 15:03 |
| kpdev | o/ | 15:03 |
| carloss | hello everyone | 15:03 |
| carloss | feels good to be back | 15:03 |
| carloss | it's been 3 weeks without our regular weekly meetings | 15:04 |
| carloss | let's get started with today's agenda: | 15:04 |
| carloss | #link https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting | 15:04 |
| carloss | #topic Announcements | 15:05 |
| carloss | Schedule and Deadlines: | 15:05 |
| carloss | #link https://releases.openstack.org/epoxy/schedule.html | 15:05 |
| carloss | we're 1 week away from m-1 | 15:05 |
| carloss | s/m-1/epoxy-1 | 15:05 |
| carloss | so we should be looking at the things we are targeting for this milestone | 15:06 |
| carloss | we currently have 26 bugs being targeted for this milestone: | 15:06 |
| carloss | #link https://launchpad.net/manila/+milestone/epoxy-1 (Bugs targeted to Epoxy 1) | 15:07 |
| carloss | of course we've been carrying over some things, but would be nice if each of us could look into this list and check for fixes that are waiting for the review | 15:07 |
| carloss | so we can merge them within the deadline | 15:07 |
| carloss | and second thing on announcements: | 15:07 |
| carloss | PTG summary and recordings | 15:07 |
| carloss | I have posted the PTG summary on the mailing list last week: | 15:07 |
| carloss | #link https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/message/Y6FIN2WLS52G34GT5NYT4LI52I3BSVEN/ | 15:08 |
| carloss | and also made all of the recordings available on the OpenStack manil youtube channel: | 15:08 |
| carloss | #link https://www.youtube.com/playlist?list=PLnpzT0InFrqDHGfSDPhiGtSeXd36mrI3T | 15:08 |
| carloss | if you missed something or would like to get back to a discussion we had, please take a look at the recordings | 15:08 |
| carloss | and thank you very much for your participation on PTG. The engagement and discussions were great | 15:09 |
| carloss | I'm looking forward to getting a lot accomplished over the cycle | 15:09 |
| carloss | that's all I had in terms of announcements | 15:09 |
| carloss | Is there an announcement you'd like to share with us today? | 15:09 |
| carloss | taking silence as no... | 15:12 |
| carloss | #topic Review focus | 15:12 |
| carloss | #link https://etherpad.opendev.org/p/manila-epoxy-review-focus (Epoxy review focus etherpad) | 15:13 |
| carloss | I see a lot of fixes were added to the etherpad | 15:13 |
| carloss | thanks for keeping it updated | 15:13 |
| carloss | for the first two changes, there aren't many updates | 15:14 |
| carloss | let's start with: | 15:14 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/931050 (Allow to update access rule for type 'ip') | 15:14 |
| carloss | thanks for keeping up with reviews on this change, haixin | 15:14 |
| carloss | we need some more eyes | 15:14 |
| haixin | :) | 15:14 |
| * carloss includes himself on this list | 15:15 | |
| carloss | gireesh ashrodri gouthamr: could you please take a look at the core and client changes for it? | 15:15 |
| gouthamr | ack; swamped, but will do soon | 15:16 |
| gireesh | ack | 15:16 |
| carloss | tyvm | 15:16 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/932397 (decorate all missing *_update methods with db_retry on deadlock) | 15:17 |
| carloss | interesting one, can be really useful for deadlocks on db updates | 15:18 |
| carloss | kpdev: thanks for working on this change | 15:18 |
| carloss | jayaanand ashrodri gireesh can I have your eyes on this change? | 15:20 |
| carloss | also, in the next one: | 15:20 |
| gireesh | sure | 15:20 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/932912 ([Netapp] make deleted volume retention period configurable) | 15:20 |
| carloss | we also have | 15:21 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/932414 (Add new policy `list_all_projects` for share/share-snapshot) | 15:21 |
| carloss | and | 15:21 |
| gouthamr | ^^ ++ | 15:21 |
| gouthamr | i like this direction | 15:22 |
| gouthamr | a lot like i was checking with the "filter by host" behavior - we shouldn't be hardcoding the context.is_admin check anywhere, thanks kpdev | 15:22 |
| kpdev | ok | 15:23 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/932600 (Improve get all instances with share data) | 15:23 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/933902 (Add config to allow share server migration with replicas) | 15:23 |
| carloss | thanks for the prompt feedback, gouthamr | 15:23 |
| carloss | so, a lot of changes, I'll add some review assignments in the etherpad to avoid the pings for each of them | 15:24 |
| carloss | so please keep looking at the etherapd | 15:25 |
| kpdev | we need quick review on https://review.opendev.org/c/openstack/manila-specs/+/933558/ | 15:26 |
| kpdev | this was discussed in ptg | 15:26 |
| carloss | ack, thanks | 15:27 |
| carloss | added to the list and will take a look | 15:27 |
| carloss | and tag more people in the etherpad too | 15:28 |
| carloss | any other change to bring up in $topic? | 15:28 |
| carloss | taking silence as no | 15:30 |
| carloss | #topic Bug Triage (vhari) | 15:30 |
| vhari | ty carl | 15:30 |
| carloss | #link https://etherpad.openstack.org/p/manila-bug-triage-pad-new (Bug Triage etherpad) | 15:30 |
| vhari | s/carl/carloss, | 15:30 |
| vhari | let's dive in :) | 15:30 |
| vhari | #link https://bugs.launchpad.net/manila/+bug/1929936 | 15:31 |
| vhari | looking for minor triage today | 15:31 |
| carloss | we've been added to this as affected | 15:33 |
| carloss | but I'm not 100% sure if we support that | 15:33 |
| carloss | so some research is required on my end | 15:33 |
| vhari | ack | 15:33 |
| carloss | I can take a look at it and respond | 15:34 |
| vhari | carloss tyvm for looking into it | 15:34 |
| vhari | should we follow up in a couple of weeks and decide next steps? | 15:35 |
| carloss | yep, that sounds good | 15:36 |
| vhari | ack | 15:36 |
| vhari | moving on | 15:36 |
| vhari | #link https://bugs.launchpad.net/manila/+bug/2085788 | 15:36 |
| carloss | interesting | 15:38 |
| carloss | thanks for the report, gouthamr | 15:38 |
| carloss | a lot of details in the bug | 15:38 |
| carloss | gireesh: can we have someone from the netapp team taking a look? | 15:38 |
| gireesh | sure | 15:39 |
| carloss | thank you! :D | 15:39 |
| vhari | ty gireesh .. | 15:39 |
| carloss | I'd say it's a medium prio for now | 15:39 |
| vhari | pls let us know if additional info is required | 15:39 |
| carloss | ++ | 15:39 |
| vhari | last but not least #link https://bugs.launchpad.net/manila/+bug/2086767 | 15:40 |
| carloss | that's an RFE for the human readable export location feature | 15:41 |
| carloss | > If not provided, it defaults to the project identifier, leading to names like: "{project_id}_{mount_point_name}". And this prefix can't be removed (setting it to empty string leads to names like "_{mount_point_name}"). | 15:42 |
| carloss | however, this part sounds more like an issue with the current implementation | 15:42 |
| carloss | I believe if this is fully customized, we'd get to the issue that we discussed in the specification | 15:44 |
| carloss | which is: possible duplication of the export paths | 15:44 |
| carloss | project id was added to help us making this unique | 15:44 |
| gouthamr | is there really a concern setting this to a short, pre-determined string either? | 15:47 |
| gouthamr | like "share" | 15:47 |
| gouthamr | or "mnt" | 15:47 |
| carloss | yeah, don't think there is a concern | 15:47 |
| gouthamr | sylvand suggests making the prefix: "{project_id}_" instead of "{project_id}" (where we add the underscore to concatenate the real mount point name | 15:48 |
| carloss | oh 🤔 | 15:49 |
| carloss | i missed that, sorry | 15:49 |
| carloss | so yes, it makes sense | 15:49 |
| carloss | wait | 15:49 |
| carloss | it is already doing that, no? | 15:50 |
| carloss | "Currently when providing mount_point_name, a prefix is systematically added. If not provided, it defaults to the project identifier, leading to names like: "{project_id}_{mount_point_name}"" | 15:50 |
| gouthamr | just a slight change in logic on how the prefix is being inferred | 15:51 |
| gouthamr | if the administrator doesn't provide one, assume it is "{project_id}_" | 15:51 |
| gouthamr | but if the administrator provides a prefix, use it instead | 15:51 |
| gouthamr | that would allow the administrator to provide an empty string ("") as the prefix | 15:52 |
| gouthamr | ^ this is the behavior sylvand suggests | 15:52 |
| gouthamr | https://github.com/openstack/manila/blob/8f69ccbb2f9339c5d3ae9e609961456f3d4a5153/manila/share/api.py#L1195-L1196 | 15:54 |
| gouthamr | he'd like a behavior here to turn off the prefix | 15:54 |
| gouthamr | i'm okay with that if we can clarify that this could lead to collisions later in the driver.. and in case of DHSS=False, across tenants | 15:55 |
| carloss | sounds fair | 15:56 |
| carloss | will update my comment | 15:56 |
| carloss | we're almost at the hour | 15:57 |
| carloss | is there something else you'd like to add? | 15:57 |
| gouthamr | there is no difference between allowing an empty prefix or a constant, non templated prefix | 15:57 |
| vhari | all set for bugs | 15:57 |
| vhari | and back to you carloss :) | 15:57 |
| carloss | great, thanks for the input | 15:58 |
| carloss | let's wrap up this meeting | 15:58 |
| carloss | and get back to #openstack-manila | 15:58 |
| carloss | thank you for participating | 15:58 |
| carloss | have a great day! | 15:59 |
| carloss | #endmeeting | 15:59 |
| opendevmeet | Meeting ended Thu Nov 7 15:59:03 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:59 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/manila/2024/manila.2024-11-07-15.00.html | 15:59 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/manila/2024/manila.2024-11-07-15.00.txt | 15:59 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/manila/2024/manila.2024-11-07-15.00.log.html | 15:59 |
| *** tosky_ is now known as tosky | 23:40 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!