| *** mhen_ is now known as mhen | 03:04 | |
| carloss | #startmeeting manila | 15:00 |
|---|---|---|
| opendevmeet | Meeting started Thu Jan 30 15:00:44 2025 UTC and is due to finish in 60 minutes. The chair is carloss. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'manila' | 15:00 |
| carloss | courtesy ping: dviroel vhari carthaca msaravan pulluri ashrodri | 15:01 |
| vhari_ | hi | 15:01 |
| gireesh | hi | 15:03 |
| kpdev | hi | 15:04 |
| carloss | hello folks | 15:04 |
| carloss | our meeting agenda for today: | 15:04 |
| carloss | #link https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting | 15:05 |
| carloss | starting with | 15:05 |
| carloss | #topic Announcements | 15:05 |
| carloss | Schedule and Deadlines | 15:05 |
| carloss | #link https://releases.openstack.org/epoxy/schedule.html | 15:05 |
| carloss | we're less than a month away from feature freeze | 15:06 |
| carloss | and next week we'll have our mid cycle | 15:06 |
| carloss | and that's all I had for $topic | 15:08 |
| carloss | is there an announcement you would like to share with us? | 15:08 |
| carloss | taking silence as no | 15:10 |
| carloss | #topic Mid cycle | 15:10 |
| carloss | #link https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/6FIBBTSC4SKDNL5D2G2LKYRYPHDBP4QY/ | 15:10 |
| carloss | I've sent the details of the next mid cycle to the mailing list | 15:10 |
| carloss | please take a look at the email | 15:11 |
| carloss | we'll meet on meetpad, next Wednesday and Thursday, from 14 to 16 UTC | 15:11 |
| carloss | so please join us and add the features you would like to host collab reviews to the etherpad | 15:11 |
| carloss | as well as other topics you would like to discuss | 15:11 |
| carloss | do you have any questions regarding the mid cycle? | 15:12 |
| carloss | #topic Review Focus | 15:14 |
| carloss | #link https://etherpad.opendev.org/p/manila-epoxy-review-focus (Epoxy review focus etherpad) | 15:14 |
| carloss | a couple of updates to the etherpad | 15:14 |
| carloss | there are still changes that are waiting on reviews | 15:14 |
| carloss | #link https://review.opendev.org/c/openstack/python-manilaclient/+/931914 (Allow to update access rule for type 'ip') | 15:15 |
| carloss | ^ only the client is missing, the other patches were merged | 15:15 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/929091 (Pass share network subnet metadata updates to backend drivers) | 15:15 |
| carloss | likely a good candidate for a collab review | 15:15 |
| carloss | I see a change being updated to WIP | 15:16 |
| kpdev | https://review.opendev.org/c/openstack/manila/+/929091 is not WIP | 15:16 |
| kpdev | its ready to review | 15:16 |
| carloss | yep, didn't mean the share network subnet one is wip | 15:17 |
| carloss | I meant "[Netapp] Add support for prune deleted volumes" | 15:17 |
| carloss | was grabbing the link for it | 15:17 |
| carloss | as for share encryption, we had a quick chat last week | 15:17 |
| carloss | kpdev: thanks for submitting updates to the spec | 15:17 |
| carloss | I believe the mid cycle is a good opportunity to bring it up for a wider audience | 15:18 |
| kpdev | ack | 15:18 |
| carloss | and now we can look at the spec too, to have a good picture | 15:18 |
| carloss | is there any other change you'd like to bring up? | 15:18 |
| carloss | #topic Bug Triage | 15:19 |
| carloss | #link https://etherpad.openstack.org/p/manila-bug-triage-pad-new (Bug Triage etherpad) | 15:20 |
| carloss | vhari_: o/ | 15:20 |
| vhari_ | carloss, ty | 15:22 |
| vhari_ | sry network issue using _ | 15:22 |
| vhari_ | so we had no new bugs this week :) | 15:22 |
| vhari_ | looking at a stale bug | 15:23 |
| vhari_ | #link https://bugs.launchpad.net/manila/+bug/1813095 | 15:23 |
| vhari_ | need to know if this is impacting ci | 15:23 |
| vhari_ | and if it needs further triage | 15:24 |
| carloss | hmm, it might | 15:25 |
| carloss | but not sure how often | 15:25 |
| carloss | I mean, the CI seemed okay in the past with it | 15:25 |
| carloss | and there were some failures here and there | 15:25 |
| vhari_ | ack | 15:26 |
| carloss | I think finding an assignee would be nice | 15:26 |
| carloss | maybe I can ask it to a student | 15:26 |
| vhari_ | ++ | 15:26 |
| carloss | but yeah, priority seems right | 15:27 |
| vhari_ | would you like to assign it to yourself till then or track on etherpad? | 15:27 |
| carloss | yep, I can do it | 15:27 |
| vhari_ | awesome tyvm carloss :) | 15:28 |
| carloss | vhari_: thank you! | 15:28 |
| vhari_ | you bet | 15:28 |
| vhari_ | so that makes it a wrap for bugs folks | 15:28 |
| *** vhari_ is now known as vhari | 15:30 | |
| carloss | awesome, thank you | 15:30 |
| carloss | #topic Open Discussion | 15:30 |
| carloss | this is something I should've reported a bug for already | 15:31 |
| * carloss has been quite busy this week | 15:31 | |
| carloss | but I found a bug caused by one change that merged recently | 15:31 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/931050 (Allow to update access level of access rule) | 15:31 |
| carloss | kpdev: I believe that not only the cephfs nfs driver when using standalone ganesha might be broken | 15:32 |
| carloss | but other drivers might be as well | 15:32 |
| carloss | it's a big regression for us | 15:32 |
| carloss | the thing is: some places got the update_access method updated | 15:33 |
| carloss | but this wasn't forwarded to the protocol helper | 15:33 |
| carloss | I have proposed an initial fix to the cephfs driver | 15:33 |
| carloss | #link #link https://review.opendev.org/c/openstack/manila/+/940334 ([cephfs] Fix access rule update) | 15:33 |
| carloss | #undo | 15:33 |
| opendevmeet | Removing item from minutes: #link https://review.opendev.org/c/openstack/manila/+/940334 | 15:33 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/940334 ([cephfs] Fix access rule update) | 15:34 |
| carloss | it is failing unit tests, yes | 15:34 |
| carloss | but it just works on my env | 15:34 |
| carloss | kpdev: can you please look at the other driver jobs and help us triage it? | 15:34 |
| carloss | otherwise, there will be a lot of drivers broken | 15:34 |
| carloss | and we'll need to think how to address it. | 15:34 |
| kpdev | I have not passed update_access to protocol helper assuming they dont support update_access | 15:35 |
| carloss | they don't, but if we change the method signature, we need to update the callers as well | 15:35 |
| carloss | that's what happened | 15:35 |
| kpdev | in that case, the driver owner if feels that their drivers support it, can anyway implement driver specific code | 15:35 |
| carloss | the thing is: it broke the driver that doesn't support it | 15:36 |
| carloss | and it shouldnt have happened. | 15:36 |
| kpdev | if driver does not support it, how it broke it. Ideally it should be No-op for those drivers | 15:37 |
| carloss | #link https://paste.opendev.org/show/bEdjM5K2XhrkjDqHOblS/ (CephFS NFS driver broken) | 15:38 |
| kpdev | I will update the missing protocol helpers to pass update_rules down, if it helps | 15:38 |
| carloss | every time we create/delete access rules, it throws that exception | 15:38 |
| kpdev | you mean, its mandatory to pass new params to protocol helpers otherwise this throws exception ? | 15:39 |
| carloss | in the case of the ganesha helper, this is what happened: | 15:41 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/931050/10/manila/share/drivers/ganesha/__init__.py | 15:41 |
| carloss | line 53 updated the signature | 15:41 |
| carloss | and also added update_rules there | 15:41 |
| carloss | so every time we call protocol_helper.update_access should also have been updated | 15:42 |
| carloss | it would not be necessary if update_rules was a non-positional parameter | 15:42 |
| carloss | but as it is positional, we have to specify it always | 15:42 |
| carloss | > you mean, its mandatory to pass new params to protocol helpers otherwise this throws exception ? | 15:43 |
| carloss | I mean that if we updated the protocol helpers, we need to update their callers | 15:43 |
| carloss | otherwise we will be breaking allow/deny access for all of the drivers | 15:43 |
| carloss | that don't do it | 15:43 |
| kpdev | ok, is there any other driver broke ? | 15:44 |
| carloss | that's what I need help figuring out :) | 15:44 |
| kpdev | I will update yours pr https://review.opendev.org/c/openstack/manila/+/940334 and fix there | 15:44 |
| carloss | ah, thanks - I can update the one I've uploaded | 15:44 |
| carloss | but for others I will definitely need help | 15:45 |
| carloss | so we can look at the jobs and try to figure out if they are broken or not | 15:45 |
| carloss | and also look at the code from the change and ensure that the callers of the methods are also updated | 15:46 |
| kpdev | ok | 15:46 |
| carloss | thank you for helping with that | 15:47 |
| carloss | one last thing for open discussion | 15:48 |
| carloss | #link https://www.socallinuxexpo.org/scale/22x/schedule/thursday (OpenInfra Days NA) | 15:48 |
| carloss | the schedule for OpenInfra Days NA is available | 15:48 |
| carloss | a couple of zorillas have talks accepted | 15:48 |
| carloss | so if you're attending, come say hi :D | 15:49 |
| carloss | the event will happen on March 6th and 7th, and will be co-located with SCALE | 15:50 |
| carloss | #link https://www.socallinuxexpo.org/scale/22x (scale linux 22x) | 15:50 |
| carloss | alright, that's all I had | 15:50 |
| carloss | is there something else you'd like to bring up? | 15:51 |
| carloss | taking silence as no | 15:51 |
| carloss | let's get back some minutes to our days | 15:52 |
| carloss | and get back to #openstack-manila | 15:52 |
| carloss | thanks for participating | 15:52 |
| carloss | have a great day | 15:52 |
| carloss | #endmeeting | 15:52 |
| opendevmeet | Meeting ended Thu Jan 30 15:52:25 2025 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:52 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/manila/2025/manila.2025-01-30-15.00.html | 15:52 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/manila/2025/manila.2025-01-30-15.00.txt | 15:52 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/manila/2025/manila.2025-01-30-15.00.log.html | 15:52 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!