| *** mhen_ is now known as mhen | 02:42 | |
| carloss | #startmeeting manila | 15:00 |
|---|---|---|
| opendevmeet | Meeting started Thu Feb 20 15:00:06 2025 UTC and is due to finish in 60 minutes. The chair is carloss. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'manila' | 15:00 |
| carloss | courtesy ping: dviroel vhari gouthamr carthaca msaravan pulluri ashrodri | 15:00 |
| haixin | o/ hi, | 15:00 |
| vhari | hi | 15:00 |
| ashrodri | o/ | 15:02 |
| msaravan | Hi | 15:03 |
| carloss | o/ hello everyone and welcome | 15:04 |
| carloss | I believe more people will join as the meeting goes, so let's get started | 15:04 |
| kpdev | hi | 15:04 |
| carloss | our meeting agenda for today: | 15:04 |
| carloss | #link https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting (Weekly meeting agenda) | 15:04 |
| carloss | #tl;k | 15:04 |
| carloss | #undo | 15:05 |
| opendevmeet | Removing item from minutes: #link https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting | 15:05 |
| carloss | #link https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting (Weekly meeting agenda) | 15:05 |
| gireesh | hi | 15:05 |
| carloss | #topic Feature freeze | 15:05 |
| * carloss needs to get used to the laptop keyboard | 15:05 | |
| carloss | #undo | 15:06 |
| opendevmeet | Removing item from minutes: #topic Feature freeze | 15:06 |
| carloss | #topic Announcements | 15:06 |
| carloss | not lack of caffeine, I promise, only using a different setup today that is leading me to more mistakes :) | 15:06 |
| carloss | Schedule and Deadlines | 15:07 |
| carloss | #link https://releases.openstack.org/epoxy/schedule.html | 15:07 |
| vhari | :) | 15:07 |
| carloss | we're 1 week away from feature freeze | 15:07 |
| carloss | we'll get to the features and patches in a bit | 15:07 |
| carloss | we also already have our PTG dates | 15:08 |
| carloss | #link https://openinfra.org/ptg/ (Openinfra PTG) | 15:08 |
| carloss | it will happen from April 7th to 11th | 15:09 |
| carloss | so ~2 months to go | 15:09 |
| carloss | please subscribe to the PTG using the link I sent | 15:11 |
| carloss | I have already registered the Manila team to the PTG | 15:11 |
| carloss | so we'll just need to wait for now | 15:11 |
| carloss | in the meantime, if you would like to start proposing topics | 15:11 |
| carloss | I have created the planning etherpad | 15:11 |
| carloss | #link https://etherpad.opendev.org/p/flamingo-ptg-manila-planning (Flamingo PTG planning etherpad) | 15:11 |
| carloss | so back to schedule and deadlines | 15:11 |
| carloss | we'll have our bugsquash two weeks from now | 15:12 |
| carloss | as we discussed. I'll send an email to the openstack-discuss mailing list soon | 15:12 |
| carloss | as we agreed, it will take place on Monday and Tuesday, as part of the Manila team will be travelling to attend the OpenInfra days NA | 15:13 |
| carloss | fun fact, Monday and Tuesday of the bugsquash will be the carnival days in Brazil. Nothing better than a bugsquash to get in the carnival mood :p | 15:14 |
| carloss | alright, that's all I had for $topic | 15:14 |
| carloss | is there an announcement you' like to share? | 15:15 |
| carloss | taking silence as no | 15:16 |
| carloss | #topic Feature freeze | 15:16 |
| carloss | #link https://etherpad.opendev.org/p/manila-epoxy-review-focus (Review focus etherpad) | 15:16 |
| carloss | I have updated the etherpad and added a couple of changes that were missing from this list | 15:17 |
| carloss | there are some bug fixes listed at the bottom and they can be merged past m-3 | 15:17 |
| carloss | but would be important to get them in before RC1 | 15:17 |
| carloss | let's go through the list | 15:18 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/940464 (Fix access rule update) | 15:19 |
| carloss | doesn't need to be targeted to m-3 | 15:19 |
| carloss | but that's a high priority patch. It fixes some drivers while creating/deleting access rules | 15:19 |
| carloss | haixin: I believe you'd have some muscle memory on this change | 15:21 |
| carloss | could you please take a look as well? | 15:21 |
| haixin | I will review this patch tomorrow, my company has been too busy recently | 15:21 |
| carloss | I've also asked gouthamr to take a look when he has the chance | 15:21 |
| haixin | sure | 15:21 |
| carloss | ashrodri: thanks for reviewing it as well | 15:21 |
| carloss | haixin: ack, no problem at all and thank yo very much for helping | 15:21 |
| carloss | now let's get to some m-3 eligible patches | 15:22 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/929091 (Pass share network subnet metadata updates to backend drivers (kpdev)) | 15:22 |
| carloss | kpdev: I left the comment about the microversion but that is really a question... I know we haven't microversioned the same kind of update for share metadata | 15:22 |
| carloss | but I would like to start that discussion and know your thoughts and the thoughts from other reviews | 15:23 |
| kpdev | yes, working on it | 15:23 |
| carloss | I think the change looks great, but as I asked, we need to test this (unit and functional) | 15:23 |
| carloss | I've proposed this change just to get the state of things in case we merge this feature as is: | 15:23 |
| carloss | #link https://review.opendev.org/c/openstack/manila-tempest-plugin/+/942236 | 15:23 |
| carloss | apparently, seems to behave fine, but we should look at the jobs individually | 15:24 |
| carloss | I've looked at some of them this morning | 15:24 |
| carloss | kpdev: thanks for working on the updates | 15:24 |
| carloss | is there something else related to this change that you'd like to add? | 15:24 |
| * gouthamr wakes up | 15:25 | |
| carloss | kpdev: and thanks for your patience with reviews on this change. I don't think this is at risk | 15:25 |
| gouthamr | many tests may not run on the master branch of Manila tempest plugin | 15:25 |
| * carloss waves at gouthamr | 15:26 | |
| gouthamr | think we found microversion related failures in the dummy driver jobs in older branches | 15:26 |
| carloss | gouthamr: yes :) | 15:26 |
| gouthamr | it’d be nice to repeat that depends on to a manila patch to stable branches - just because we’re short of time and it’d be bad to break the gate now | 15:27 |
| carloss | ++ | 15:28 |
| gouthamr | chain of depends on patches, just to be sure.. Manila->tempest plugin->Manila (2024.2) | 15:28 |
| gouthamr | alternatively we could have an experimental pipeline with older stable branch versions of the dummy driver job in the plugin that we could invoke whenever we want | 15:29 |
| carloss | yeah, that works | 15:30 |
| carloss | let me push a new patch on 2024.2 to test that | 15:30 |
| gouthamr | ++ thanks carloss | 15:31 |
| carloss | np | 15:32 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/942372 | 15:32 |
| carloss | let's wait and see | 15:32 |
| carloss | next up | 15:33 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/934676 ([Netapp] Add support for prune deleted volumes (kpdev)) | 15:33 |
| carloss | waiting for some more reviewers for a while | 15:33 |
| carloss | thanks ashrodri gireesh and chuanm for looking at it | 15:34 |
| kpdev | need review from NetApp engineers | 15:34 |
| carloss | ++ would be nice to get some eyes | 15:34 |
| carloss | netapp CI is not voting on the changes, so it would be important to see some testing output even manually | 15:34 |
| carloss | or someone acking the change | 15:35 |
| carloss | gireesh could you please circle back? | 15:35 |
| carloss | I'll take a look at it. gouthamr, msaravan could you please review this change as well? | 15:35 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/941084 (NetApp: delete vlan even if ipspace is reused) | 15:37 |
| gouthamr | yep | 15:37 |
| carloss | gouthamr: thank you | 15:37 |
| carloss | the change I just linked is also a bug fix, which has a bit more of code proposed to fix the issue | 15:37 |
| carloss | I think this can also be targeted to rc1 | 15:37 |
| carloss | (same for prune volumes change) | 15:38 |
| gireesh | sure caloss | 15:38 |
| carloss | gireesh: thanks | 15:38 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/942216 (NetApp - Restrict LIF Creation Per HA Pair) | 15:38 |
| carloss | this is a new feature being added to the netapp driver | 15:38 |
| carloss | not thousands of lines of code, so hopefully easier to review | 15:39 |
| gouthamr | this seems like a bugfix? | 15:39 |
| msaravan | its a small feature, requested by SAP | 15:40 |
| gouthamr | ah, okay, no plans of back porting this? | 15:40 |
| gireesh | we will not backport this | 15:41 |
| msaravan | if SAP needs, we'll do. Otherwise, we'll not. | 15:41 |
| gouthamr | on a quick glance it appears to be a serious problem to avoid data loss on node failure | 15:41 |
| gireesh | will check with SAP, if needed we can backport this | 15:42 |
| carloss | so considering that the impact of this change is limited to the driver and also the problem it is fixing, I think we should be okay if we merge it in case we have someone from netapp acking/testing and enough reviews from reviewers | 15:43 |
| gouthamr | +1 | 15:44 |
| gireesh | thanks Goutham and caloss | 15:44 |
| carloss | ack, thank you! | 15:45 |
| carloss | kpdev msaravan gouthamr can I have your eyes on this change? | 15:45 |
| carloss | I'll also review it | 15:45 |
| msaravan | Sure, definitely | 15:45 |
| carloss | thank you | 15:45 |
| gouthamr | ack | 15:45 |
| carloss | and last but not least on things that should have m3 as a target date to merge | 15:46 |
| carloss | #link https://review.opendev.org/c/openstack/manila/+/928081 (Allow services API to filter by ensuring) | 15:46 |
| carloss | this change bumps the API and follows a feature that I implemented last cycle | 15:46 |
| carloss | zuul was failing on this change and I left it aside for most of the cycle and focused on other priorities (my bad) | 15:47 |
| carloss | if you feel it is okay and that we will have enough time to review it, fine | 15:47 |
| * gouthamr likes the self-code-review | 15:47 | |
| carloss | otherwise this can wait a bit more | 15:47 |
| gouthamr | seems small enough to look | 15:48 |
| carloss | haha, I usually do that for either explaining something that might be attention points for reviewers, or in things that I forgot to do before submitting the change but I caught after submission | 15:49 |
| carloss | just trying to keep everything documented :) | 15:49 |
| carloss | cool, thank you | 15:50 |
| carloss | we need more eyes on this | 15:50 |
| carloss | kpdev gireesh ashrodri: could you please take a look? this change also has a client change related, which is much simples | 15:50 |
| carloss | s/simples/simpler | 15:50 |
| kpdev | ack | 15:50 |
| carloss | #link https://review.opendev.org/c/openstack/python-manilaclient/+/929327 | 15:50 |
| carloss | thank you | 15:50 |
| carloss | I will do my best to add some tempest testing for it soon as well. This change is also moving the filters to the database (better performance and better way to filter the results) | 15:51 |
| carloss | so I think it would be important to test to ensure that there are no regressions | 15:51 |
| carloss | I'll also use the same approach as the share network metadata updates we just did to ensure this won't break anything on stable branches | 15:52 |
| carloss | so that's all for things eligible for feature freeze | 15:52 |
| carloss | we have a couple of other bug fixes listed as well | 15:53 |
| carloss | #link https://etherpad.opendev.org/p/manila-epoxy-review-focus#L53 | 15:53 |
| carloss | please take a look at them, we have a couple of reviewers tagged in the etherpad but please review these changes if you have a chance to | 15:54 |
| carloss | and not limit ourselves to the people I either voluntold or are tagged in the etherpad | 15:55 |
| carloss | that's all I had for $topic | 15:55 |
| carloss | is there something else you'd like to bring up? | 15:55 |
| carloss | #topic Open Discussion | 15:56 |
| carloss | 4 minutes for open discussion | 15:56 |
| carloss | vhari: sorry for using all of the meeting time on the feature freeze topic and not leaving any space for bug triaging | 15:57 |
| carloss | and you mentioned with me that there are no new bugs this week, which is great | 15:57 |
| vhari | no probs carloss | 15:57 |
| carloss | thanks for working on the list anyways | 15:57 |
| carloss | vhari++ | 15:57 |
| carloss | we'll cover the list next week | 15:57 |
| vhari | was a quiet week for bugs no arrivals actually :) | 15:57 |
| carloss | :D | 15:57 |
| carloss | alright, let's wrap up | 15:58 |
| carloss | thank you for participating and let's get back to our feature freeze stuff | 15:58 |
| carloss | hope you have a great week | 15:58 |
| ashrodri | ++ | 15:58 |
| carloss | (or what's remaining of it) | 15:58 |
| carloss | chat on #openstack-manila | 15:59 |
| carloss | #endmeeting | 15:59 |
| opendevmeet | Meeting ended Thu Feb 20 15:59:03 2025 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:59 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/manila/2025/manila.2025-02-20-15.00.html | 15:59 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/manila/2025/manila.2025-02-20-15.00.txt | 15:59 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/manila/2025/manila.2025-02-20-15.00.log.html | 15:59 |
| *** mhen_ is now known as mhen | 19:48 | |
| *** jhorstmann is now known as Guest9655 | 22:17 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!