Thursday, 2021-04-08

« Wednesday, 2021-04-07 Index Friday, 2021-04-09 »
*** yasufum has joined #openstack-meeting00:01
*** mlavalle has quit IRC00:10
*** jmasud has joined #openstack-meeting00:15
*** jmasud has quit IRC00:31
*** macz_ has joined #openstack-meeting00:37
*** jmasud has joined #openstack-meeting00:44
*** macz_ has quit IRC00:47
*** jmasud has quit IRC01:05
*** jmasud has joined #openstack-meeting01:20
*** spotz has quit IRC01:32
*** rh-jelabarre has quit IRC01:37
*** xinranwang has joined #openstack-meeting02:01
*** rcernin has quit IRC02:30
*** evrardjp has quit IRC02:33
*** evrardjp has joined #openstack-meeting02:33
*** rcernin has joined #openstack-meeting02:57
*** rcernin has quit IRC03:01
*** manpreet has joined #openstack-meeting03:13
*** jmasud has quit IRC03:18
*** rcernin has joined #openstack-meeting03:25
*** rcernin has quit IRC03:29
*** psachin has joined #openstack-meeting03:31
*** rcernin has joined #openstack-meeting03:47
*** jmasud has joined #openstack-meeting03:54
*** vishalmanchanda has joined #openstack-meeting04:15
*** manubk has joined #openstack-meeting05:05
*** haleyb has quit IRC05:13
*** haleyb has joined #openstack-meeting05:15
*** xinranwang has quit IRC05:31
*** udesale has joined #openstack-meeting05:37
*** ralonsoh has joined #openstack-meeting05:53
*** slaweq has joined #openstack-meeting06:01
*** e0ne has joined #openstack-meeting06:43
*** e0ne has quit IRC06:43
*** jmasud has quit IRC06:43
*** tosky has joined #openstack-meeting06:45
*** alecuyer has joined #openstack-meeting06:50
*** yamamoto_ has joined #openstack-meeting06:52
*** dklyle has quit IRC06:54
*** yamamoto has quit IRC06:55
*** ociuhandu has joined #openstack-meeting07:01
*** rpittau|afk is now known as rpittau07:01
*** ociuhandu has quit IRC07:13
*** ociuhandu has joined #openstack-meeting07:14
*** ociuhandu has quit IRC07:19
*** ociuhandu has joined #openstack-meeting07:19
*** ociuhandu has joined #openstack-meeting07:21
*** ociuhandu has quit IRC07:25
*** ociuhandu has joined #openstack-meeting07:26
*** lpetrut has joined #openstack-meeting07:47
*** ociuhandu has quit IRC07:59
*** ociuhandu has joined #openstack-meeting07:59
*** ociuhandu has quit IRC08:04
*** ociuhandu has joined #openstack-meeting08:04
*** rcernin has quit IRC08:13
*** ociuhandu has quit IRC08:27
*** ociuhandu has joined #openstack-meeting08:28
*** ociuhandu has quit IRC08:33
*** ociuhandu has joined #openstack-meeting08:33
*** rcernin has joined #openstack-meeting08:43
*** rcernin has quit IRC08:55
*** ociuhandu has quit IRC09:07
*** ociuhandu has joined #openstack-meeting09:08
*** ociuhandu has quit IRC09:13
*** rcernin has joined #openstack-meeting09:14
*** rcernin has quit IRC09:18
*** e0ne has joined #openstack-meeting09:39
*** e0ne has quit IRC09:39
*** rcernin has joined #openstack-meeting09:46
*** rcernin has quit IRC09:46
*** rcernin has joined #openstack-meeting09:47
*** ociuhandu has joined #openstack-meeting09:57
*** ociuhandu_ has joined #openstack-meeting09:59
*** ociuhandu has quit IRC10:02
*** ociuhandu_ has quit IRC10:03
*** e0ne has joined #openstack-meeting10:05
*** dsariel has joined #openstack-meeting10:24
*** manubk has quit IRC10:26
*** ociuhandu has joined #openstack-meeting10:34
*** baojg has quit IRC10:37
*** baojg has joined #openstack-meeting10:38
*** yamamoto_ has quit IRC10:39
*** ociuhandu has quit IRC10:39
*** dsariel has quit IRC10:48
*** yamamoto has joined #openstack-meeting11:09
*** baojg has quit IRC11:11
*** baojg has joined #openstack-meeting11:12
*** dsariel has joined #openstack-meeting11:12
*** rh-jelabarre has joined #openstack-meeting11:24
*** kopecmartin has quit IRC11:26
*** yamamoto has quit IRC11:31
*** kopecmartin has joined #openstack-meeting11:48
*** kopecmartin has quit IRC11:49
*** pots has quit IRC11:49
*** pots has joined #openstack-meeting11:49
*** kopecmartin has joined #openstack-meeting11:50
*** yasufum has quit IRC11:53
*** zaneb has joined #openstack-meeting11:57
*** zaneb has quit IRC11:59
*** ociuhandu has joined #openstack-meeting12:02
*** ociuhandu has quit IRC12:02
*** psachin has quit IRC12:08
*** yamamoto has joined #openstack-meeting12:10
*** yamamoto has quit IRC12:24
*** baojg has quit IRC12:30
*** baojg has joined #openstack-meeting12:31
*** yamamoto has joined #openstack-meeting12:40
*** rcernin_ has joined #openstack-meeting12:58
*** zaneb has joined #openstack-meeting12:59
*** rcernin has quit IRC12:59
*** yamamoto has quit IRC13:00
*** yamamoto has joined #openstack-meeting13:02
*** yamamoto has quit IRC13:06
*** yamamoto has joined #openstack-meeting13:34
*** whoami-rajat has joined #openstack-meeting13:34
*** yamamoto has quit IRC13:41
*** yamamoto has joined #openstack-meeting13:41
*** rcernin_ has quit IRC13:42
*** GlaciErrDev has joined #openstack-meeting13:46
*** GlaciErrDev has quit IRC13:50
*** rosmaita has joined #openstack-meeting13:58
abhishekk#startmeeting glance14:00
openstackMeeting started Thu Apr  8 14:00:28 2021 UTC and is due to finish in 60 minutes.  The chair is abhishekk. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
*** openstack changes topic to " (Meeting topic: glance)"14:00
openstackThe meeting name has been set to 'glance'14:00
abhishekk#topic roll call14:00
*** openstack changes topic to "roll call (Meeting topic: glance)"14:00
dansmitho/14:00
abhishekk#link https://etherpad.openstack.org/p/glance-team-meeting-agenda14:00
abhishekko/14:00
abhishekklets wait couple of minutes for others to join14:01
dansmithhoping for at least rosmaita so I can bug him about reviews :)14:01
abhishekkhe will be around :D14:01
rosmaitai should have some time today14:01
rosmaitao/14:01
jokkeo/14:01
abhishekkcool, lets start14:02
*** GlaciErrDev has joined #openstack-meeting14:02
abhishekk#topic Updates14:02
*** openstack changes topic to "Updates (Meeting topic: glance)"14:02
abhishekk#link  https://etherpad.opendev.org/p/xena-ptg-glance-planning14:02
abhishekkSo most of the topics are final14:02
abhishekkRBAC related discussion will be on Wednesday, and cross-project discussion with cinder will be either on Thursday or Friday14:03
rosmaitacan we make it thursday?14:03
abhishekkWe could have couple of empty slots, so if you have anything in mind please add it to planning etherpad14:04
abhishekkrosmaita, yep, Thursday then14:04
abhishekkI will update the etherpad accordingly14:04
abhishekkany questions?14:05
abhishekkcool, moving ahead14:05
abhishekk#topic release/periodic jobs update14:05
*** openstack changes topic to "release/periodic jobs update (Meeting topic: glance)"14:05
rosmaitathanks!14:06
abhishekkWe are good with release, I will be tagging stable releases next week14:06
dansmithwill we do an rc2 for the bug fix that merged today?14:06
dansmithor just backport after the release?14:06
abhishekkI think backport should be better one14:07
dansmithack14:07
*** yasufum has joined #openstack-meeting14:08
abhishekkPeriodic job, one failure due to mirroring14:08
abhishekkelse it is green14:08
abhishekkmoving ahead14:09
abhishekk#topic glance/glance-store job14:09
*** openstack changes topic to "glance/glance-store job (Meeting topic: glance)"14:09
abhishekkSo recently we added one job in glance-store to run glance functional tests14:09
abhishekkas it is a voting job, it is failing on glance-store change14:10
abhishekkand we can not add depends on as it requires depends on both the patches (glance-store as well as glance) which is not possible due to circular dependency issue14:10
jokkethat was the point of it, right? ;)14:10
dansmithyeah, so what this shows, is that you're breaking the library14:10
abhishekkglance_store: https://review.opendev.org/c/openstack/glance_store/+/78220014:10
dansmiththe voting of it is doing exactly what we want, IMHO, which is to make sure a glance_store change does not break glance14:11
abhishekkyeah, so workaround is to skip those tests, right?14:11
dansmithI'll have to look at the failure and cause, but I'd say no14:11
abhishekkglance: https://review.opendev.org/c/openstack/glance/+/78474814:11
dansmithyep, I've got them up and will look after my meetings this morning14:12
abhishekkack14:12
abhishekkthank you14:12
abhishekkmoving ahead14:13
abhishekk#topic Possible improvement for image upload speed14:13
*** openstack changes topic to "Possible improvement for image upload speed (Meeting topic: glance)"14:13
abhishekk#link https://bugs.launchpad.net/glance/+bug/192195314:13
openstackLaunchpad bug 1921953 in Glance "The upload of image is slow" [Undecided,New]14:13
abhishekkI think whoever added this topic didn't mentioned that this improvement is specific to swift store14:14
*** lpetrut has quit IRC14:14
abhishekkand neither he/she is around at the moment14:14
dansmithand,14:14
dansmiththere's no link to the proposed patch that I can see, right?14:15
abhishekkNope;14:15
GlaciErrDevHi! Right14:15
GlaciErrDevi'll prepare patch14:15
abhishekkGlaciErrDev, I think this should go as improvement rather than bug14:15
dansmithagree14:15
GlaciErrDevSure14:16
GlaciErrDevThanks14:16
abhishekkso if possible please submit a design spec14:16
abhishekkare you aware about glance-specs ?14:16
GlaciErrDevno14:16
abhishekk#link https://github.com/openstack/glance-specs14:16
GlaciErrDevthank you14:16
abhishekkok, here you can find specific template and also refer other available specifications14:17
jokkeGlaciErrDev: so what changes are you actually proposing? Is it just swift store driver change to call some other function in swiftclient or something more complex?14:17
abhishekkjokke, I guess former one14:17
abhishekkGlaciErrDev, and if you still have some doubts we can sync after the meeting and I can explain you more about the specs14:18
GlaciErrDevI've just used ThreadPoolExecutor to execute in parallel `put_object` from swift14:18
dansmithGlaciErrDev: if you're talking about a new thread per block, that could cause glance memory usage to skyrocket during upload, which is why we should have a spec14:18
abhishekk++14:19
GlaciErrDevactually this call `manager.get_connection().put_object(...)`14:19
GlaciErrDevI see14:19
jokkeYeah, I'd be very cautious about that. While one might find good performance increase in single operation we need to make sure we stay stable and perform well when there is 10s of them inflight14:20
dansmithyup14:21
GlaciErrDevI've tested with one upload operation a time...14:21
abhishekkGlaciErrDev, so first submit a spec, you can also add your results in the specs14:21
GlaciErrDevabhishekk ok, will do it14:22
jokkeGlaciErrDev: like abhishekk said, put your findings and what you did in a spec (lite should be sufficient as there is no API change involved) and lets see if it makes sense14:22
abhishekkIf required I will walk you through it14:22
GlaciErrDevabhishekk probably it will help me a lot14:23
abhishekkcool, GlaciErrDev thank you,14:23
GlaciErrDevThanks!14:23
abhishekkwe will sync after the meeting14:23
abhishekkmoving ahead14:23
abhishekk#topic XS reviews14:23
*** openstack changes topic to "XS reviews (Meeting topic: glance)"14:23
abhishekkthis must be Steap14:24
Steapyeah14:24
abhishekkstage is yours14:24
Steap1 got an XS review and I think abhishekk marked a bunch of bugs ready to close14:25
Steaphttps://review.opendev.org/c/openstack/python-glanceclient/+/784465 is an old Py3 issue we missed14:25
Steapit does not seem to be triggered, but we might want to be safe14:25
abhishekkSteap, I have added comments on the bugs and haven't got any replies on them yet, so those one with no replies we can close them14:26
Steapyeah there is a list at https://etherpad.opendev.org/p/glance-bug-tracker14:26
Steapyou left them 1 week, right?14:26
abhishekkyeah14:27
abhishekkI haven't said that on bug to revert within a week or else we will close it14:27
Steaphehe I give them 1 month, you're not as nice as me14:27
abhishekk:D14:28
Steapso, -10 bugs \o/14:29
abhishekkyep, and there are some stable branch related bugs as well at the bottom14:29
abhishekkSo I guess that's it from this topic, please have a look at review pointed by Steap14:30
abhishekkMoving to Open discussion14:30
abhishekk#topic Open discussion14:30
*** openstack changes topic to "Open discussion (Meeting topic: glance)"14:30
abhishekkOpen question for rosmaita14:31
abhishekk#link https://review.opendev.org/c/openstack/glance/+/78366814:31
rosmaita?14:31
jokkeSteap: abhishekk: about the socketIO ... where is that coming from? I can't seem to find it in the stdlib socket docs14:31
dansmithjust a poke for him to circle back to that so I can revise :)14:31
Steaphm14:32
Steapweird14:32
rosmaitaok, consider me poked14:32
Steapjokke: oh it's in the code for sure, but seems undocumented14:32
*** yamamoto has quit IRC14:33
jokkeSteap: so it's not coming from the python-socketio package we do not depend on?14:33
abhishekkjokke, I have just verified by dir(socket)14:33
Steapjokke: no, it's socket.SocketIO14:34
abhishekk#link https://review.opendev.org/c/openstack/glance/+/78389314:35
abhishekkrosmaita, Steap I have fixed your comments/suggestions on above patch14:35
SteapThanks, I'll recheck14:36
abhishekkcool14:36
jokkeabhishekk: 3.7.7 does not have it14:36
jokkeI just did dir(socket) there14:36
abhishekkoh, I have 3.6.914:36
Steapreally?14:37
jokkeI think e need test going with that patch which actually executes the codepath14:37
Steapyeah I'm not sure when this code is triggered14:38
rosmaitadansmith: commented on your patch14:38
jokkesorry, my bad there is indeed SocketIO in 3.7.714:38
Steappython3 -c "import socket; print('SocketIO' in dir(socket))"14:38
SteapTrue14:38
jokkeyup14:38
dansmithrosmaita: thanks14:38
jokkeSteap: abhishekk: so that established, as there is no documentation of that do we know it actually works same way or at all? Back to the point, if we did not catch socket._fileobject missing, we likely should have a test touching thta codepath showing that the SocketIO actually works as intended14:41
abhishekkSteap, could you please add the test ?14:42
SteapHonestly, I'm not sure what this code does. My reasoning here is that _fileobject is 100% sure to crash on us, while SocketIO seems to be the usual fix in projects that went from py2 to py3 :)14:42
abhishekkneither do I, I will try to work on the test then14:43
SteapMaybe the code is never actually used and we can just remove it14:43
* Steap likes to dream14:43
jokkeI'll put that into my list of things to look at too to figure out what we actually do there. Thanks!14:43
abhishekkjokke, cool, thank you14:44
abhishekkanything else?14:44
jokkeabhishekk: whoami-rajat: btw about that glance_store patch ... I missed my opportunity at the time14:44
abhishekkanything to mention?14:45
dansmithabhishekk: one more thing14:45
whoami-rajatah is it already discussed? sorry i missed it14:45
dansmithI think rosmaita's type is fixed here: https://review.opendev.org/c/openstack/glance/+/78389314:45
dansmithand hoping anyone else that had comments has done so, so can we merge?14:45
jokkeIs there no way to not break glance on that? (I'm not sure the test change apart from lots of extra mocking looked like there was logic change) if that breaks the store python API that basically would need major version bump on glance_store14:45
dansmithjokke: it looks to me like it's just breaking the fact that glance is mocking the internals of glance_store14:46
dansmithjokke: which isn't technically a violation, and more just a problem of glance_store not exporting a stable Fixture for tests I think14:46
*** e0ne has quit IRC14:46
dansmithjokke: I think putting the glance test fix in front of the glance_store patch will probably make it work14:46
dansmithbut I need to test.. it's just that glance is providing the client mock that glance_store ends up using I think14:47
dansmithbut I just briefly looked over it here in the meetnig14:47
abhishekkdansmith, regarding https://review.opendev.org/c/openstack/glance/+/78389314:47
whoami-rajatjust to give my thoughts, my patch changes mostly the whole functional flow of current glance cinder to a new one so all old methods used are invalid hence the test fails14:47
abhishekkif there are no more objections by tomorrow then we can move ahead with this14:47
jokkedansmith: yeah same, you might be right it was just los of changes in the tests but indeed looks like loads of mocking14:47
dansmithjokke: yeah I think it's just the mocking, unfortunately14:48
dansmithabhishekk: okay14:48
abhishekkI think during X we should also try to put efforts in our tests to remove mocking as much as possible14:48
dansmithabhishekk: you mean across the seam of glance/glance_store right?14:49
jokkein that case I'd suggest to put a patch to skip that test in glance functional with heavy todo note, merge the _store path, release the store and drop the skip. Rather than drop the whole test job to get it merged14:49
whoami-rajatI would like if we made that job non-voting and i can propose a WIP fix to glance if it breaks and we can merge that patch when glance store releases but that's just my thoughts to make my work easier14:49
dansmithjokke: I really think we can make the glance tests account for both cases and then merge the glance_store patch after that14:50
dansmithi.e without skips or disabling the test14:50
jokkedansmith: that would be great if you want to put your testing/mocking wizardry into action. I wouldn't even dare to try ;P14:50
dansmithI don't think it'll be that bad, but yes I'll be glad to try before we do something more drastic14:51
abhishekkthat will be great,14:51
jokkeHihi ... what comes to testing and specially mocking axe and sledgehammer tends to be my finetuning tools :P14:52
abhishekkLast option would be report a bug in LP, skip the tests, release glance-store and then fix the bug14:52
jokkeabhishekk: yeah, well anyways if Dan can figure out way not needing to do that, even better. But I'd just rather not disable the whole job cause it works as intended :P14:54
abhishekkack14:54
dansmithI got it14:54
dansmithwill push up in a few14:54
jokke<314:54
abhishekkcool14:55
abhishekkanything else ?14:55
* jokke needs to start designing "mockwizzard" pointy hat14:55
jokkeso we can send one to dansmith14:55
jokkenothing else from me14:55
abhishekkok, time to wrap up14:56
abhishekkthank you all14:56
abhishekk#endmeeting14:56
*** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/"14:56
openstackMeeting ended Thu Apr  8 14:56:38 2021 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)14:56
openstackMinutes:        http://eavesdrop.openstack.org/meetings/glance/2021/glance.2021-04-08-14.00.html14:56
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/glance/2021/glance.2021-04-08-14.00.txt14:56
openstackLog:            http://eavesdrop.openstack.org/meetings/glance/2021/glance.2021-04-08-14.00.log.html14:56
*** rosmaita has left #openstack-meeting14:58
*** dklyle has joined #openstack-meeting14:58
*** spotz has joined #openstack-meeting14:58
*** dklyle has quit IRC15:02
*** dklyle has joined #openstack-meeting15:02
*** GlaciErrDev has quit IRC15:08
*** belmoreira has joined #openstack-meeting15:11
*** yasufum has quit IRC15:29
*** macz_ has joined #openstack-meeting15:32
*** mlavalle has joined #openstack-meeting15:35
*** yamamoto has joined #openstack-meeting15:35
*** yamamoto has quit IRC15:47
*** jmasud has joined #openstack-meeting15:54
*** yasufum has joined #openstack-meeting15:56
*** rpittau is now known as rpittau|bbl15:57
*** jmasud has quit IRC16:10
*** ociuhandu has joined #openstack-meeting16:15
*** ociuhandu has quit IRC16:21
*** belmoreira has quit IRC16:22
*** vishalmanchanda has quit IRC16:34
*** armstrong has joined #openstack-meeting16:39
*** benj_ has quit IRC17:14
*** udesale has quit IRC17:24
*** rpittau|bbl is now known as rpittau17:44
*** lpetrut has joined #openstack-meeting18:11
*** timburke_ has joined #openstack-meeting18:11
*** timburke has quit IRC18:13
*** lpetrut has quit IRC18:14
*** jmasud has joined #openstack-meeting18:26
*** benj_ has joined #openstack-meeting18:33
*** yamamoto has joined #openstack-meeting18:38
*** jmasud has quit IRC18:39
*** yamamoto has quit IRC18:45
*** jmasud has joined #openstack-meeting18:50
*** yasufum has quit IRC18:57
*** whoami-rajat has quit IRC19:02
*** ociuhandu has joined #openstack-meeting19:29
*** manpreet has quit IRC19:43
*** jmasud has quit IRC19:49
*** timburke_ has quit IRC19:58
*** timburke_ has joined #openstack-meeting19:59
*** rcernin_ has joined #openstack-meeting20:06
*** ociuhandu has quit IRC20:09
*** browny has quit IRC20:22
*** kopecmartin has quit IRC20:24
*** kopecmartin has joined #openstack-meeting20:24
*** tosky_ has joined #openstack-meeting20:25
*** janders has quit IRC20:26
*** janders8 has joined #openstack-meeting20:26
*** rcernin_ has quit IRC20:26
*** rledisez has quit IRC20:26
*** trident has quit IRC20:26
*** Steap has quit IRC20:26
*** tosky has quit IRC20:26
*** trident has joined #openstack-meeting20:28
*** rcernin_ has joined #openstack-meeting20:28
*** tosky_ is now known as tosky20:28
*** rcernin_ has quit IRC20:32
*** slaweq has quit IRC20:41
*** rcernin_ has joined #openstack-meeting20:43
*** rcernin_ has quit IRC20:50
*** rcernin has joined #openstack-meeting20:50
*** ociuhandu has joined #openstack-meeting21:07
*** armstrong has quit IRC21:09
*** alecuyer has quit IRC21:10
*** ociuhandu has quit IRC21:12
*** rledisez has joined #openstack-meeting21:13
*** rpittau is now known as rpittau|afk21:17
*** rcernin has quit IRC21:31
*** rcernin has joined #openstack-meeting21:56
*** rcernin has quit IRC22:02
*** rcernin has joined #openstack-meeting22:11
*** yamamoto has joined #openstack-meeting22:15
*** yamamoto has quit IRC22:32
*** yamamoto has joined #openstack-meeting22:32
*** macz_ has quit IRC23:06
*** tosky has quit IRC23:38
« Wednesday, 2021-04-07 Index Friday, 2021-04-09 »

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!