| *** weshay_ has joined #openstack-mistral | 00:28 | |
| *** weshay has quit IRC | 00:32 | |
| *** weshay has joined #openstack-mistral | 00:43 | |
| *** weshay_ has quit IRC | 00:44 | |
| *** harlowja has quit IRC | 01:10 | |
| *** threestrands_ has joined #openstack-mistral | 01:33 | |
| *** threestrands has quit IRC | 01:36 | |
| *** nguyenhai93 has quit IRC | 01:47 | |
| *** nguyenhai93 has joined #openstack-mistral | 01:48 | |
| openstackgerrit | Bob Haddleton proposed openstack/mistral master: Update default Docker configuration and documentation https://review.openstack.org/572664 | 03:10 |
|---|---|---|
| *** rbrady has quit IRC | 04:00 | |
| *** harlowja has joined #openstack-mistral | 04:17 | |
| *** hardikjasani has joined #openstack-mistral | 04:20 | |
| *** harlowja has quit IRC | 04:45 | |
| *** jaosorior has joined #openstack-mistral | 05:52 | |
| *** jaosorior has quit IRC | 06:47 | |
| *** gkadam has joined #openstack-mistral | 07:18 | |
| *** openstackgerrit has quit IRC | 07:19 | |
| *** jpich has joined #openstack-mistral | 07:55 | |
| *** threestrands_ has quit IRC | 08:03 | |
| *** shardy has joined #openstack-mistral | 08:05 | |
| *** lxkong has quit IRC | 08:29 | |
| *** gkadam has quit IRC | 09:25 | |
| *** openstackgerrit has joined #openstack-mistral | 09:40 | |
| openstackgerrit | chenge proposed openstack/mistral master: Amend the spelling error of a word https://review.openstack.org/572714 | 09:40 |
| *** jaosorior has joined #openstack-mistral | 10:08 | |
| *** lxkong has joined #openstack-mistral | 10:45 | |
| *** thrash|g0ne is now known as thrash | 11:20 | |
| opetrenko_ | Well then, I want to crate workflow that can get alarm, reboot instance then check if instance finished rebooting and regarding if state is still EROR rebuild instance or not. Need some help to create that workflow. Little bit of idea there http://paste.openstack.org/show/722791/ | 11:23 |
| openstackgerrit | Brad P. Crochet proposed openstack/mistral master: Use trusts by default in OpenStack action calls https://review.openstack.org/572448 | 11:25 |
| opetrenko_ | d0ugal: can you help with that? | 11:32 |
| *** gkadam has joined #openstack-mistral | 11:49 | |
| d0ugal | opetrenko_: Which bit do you need help with? | 12:19 |
| d0ugal | opetrenko_: In some of the TripleO workflows we wait for Heat stacks to reach a state | 12:20 |
| d0ugal | You can probably use a similar approach to wait for the instance to come online | 12:20 |
| d0ugal | https://github.com/openstack/tripleo-common/blob/master/workbooks/stack.yaml#L69-L80 | 12:20 |
| d0ugal | so you will want to wait for the instance state and then either finish or start the rebuild | 12:20 |
| d0ugal | Does that make sense? | 12:21 |
| opetrenko_ | I need a help with checking state of instance | 12:23 |
| *** AlexeyAbashkin has joined #openstack-mistral | 12:29 | |
| *** shardy has quit IRC | 12:39 | |
| *** shardy has joined #openstack-mistral | 12:43 | |
| *** jaosorior has quit IRC | 13:20 | |
| *** hardikjasani has quit IRC | 13:20 | |
| d0ugal | opetrenko_: right, I am not very familiar with the nova actions, but I guess you can use nova.server_get and then the response will have the status. You can then use on-complete to change the behaviour depending on the contents of the result | 13:41 |
| d0ugal | for example... | 13:41 |
| d0ugal | https://github.com/openstack/tripleo-common/blob/master/workbooks/baremetal.yaml#L218-L220 | 13:43 |
| d0ugal | That is actually on-success, you probably want that rather than on-complete | 13:43 |
| d0ugal | but that calls two different tasks based on YAQL expression. You can do something similar but with the result of the task | 13:44 |
| d0ugal | I would use "mistral run-action nova.servers_get '{...input...}' to see what the result looks like. | 13:44 |
| d0ugal | opetrenko_: ^ | 13:44 |
| d0ugal | hope that helps! | 13:44 |
| *** Alexey_Abashkin has joined #openstack-mistral | 13:51 | |
| *** AlexeyAbashkin has quit IRC | 13:53 | |
| *** Alexey_Abashkin is now known as AlexeyAbashkin | 13:53 | |
| opetrenko_ | Got a question | 14:04 |
| opetrenko_ | how can I extract OS-EXT-STS:vm_state from result of nova.servers_get | 14:05 |
| d0ugal | opetrenko_: I don't know exactly what the result of nova.servers_get looks like, can you show me an example? but I suspect it will be something like <% task().result.vm_state %> | 14:06 |
| opetrenko_ | http://paste.openstack.org/show/722805/ | 14:08 |
| opetrenko_ | the problem is that OS:vm_state: value needed | 14:13 |
| opetrenko_ | but there is 2 : | 14:13 |
| openstackgerrit | Brad P. Crochet proposed openstack/mistral master: Register the collect_timing keystone_authtoken option https://review.openstack.org/572788 | 14:19 |
| *** AlexeyAbashkin has quit IRC | 14:28 | |
| d0ugal | openstackgerrit: task().result.get("OS-EXT-STS:vm_state") | 14:29 |
| d0ugal | oops | 14:29 |
| d0ugal | opetrenko_: task().result.get("OS-EXT-STS:vm_state") | 14:29 |
| opetrenko_ | oh, thx | 14:29 |
| *** AlexeyAbashkin has joined #openstack-mistral | 14:36 | |
| therve | d0ugal: Hey have you seen http://paste.openstack.org/show/722743/ wrt the resolve_outputs stuff? | 14:46 |
| *** shardy has quit IRC | 14:47 | |
| *** shardy has joined #openstack-mistral | 14:47 | |
| d0ugal | therve: I only spotted that apetrich tried it with no luck | 14:50 |
| d0ugal | but I have not had a chance to try again today | 14:50 |
| therve | Ok double checking would be cool | 14:51 |
| therve | At least I don't have another idea for now :) | 14:51 |
| d0ugal | Right | 14:51 |
| d0ugal | I'll see what I can do | 14:51 |
| therve | At it seems to make sense to me why that happens too | 14:51 |
| therve | Though, we probably need to work around it in tripleo-common | 14:51 |
| therve | Which I can do if you want | 14:51 |
| openstackgerrit | Brad P. Crochet proposed openstack/python-mistralclient master: Revert "Adding environment-get-definition for easy environment-update" https://review.openstack.org/572111 | 15:01 |
| openstackgerrit | Brad P. Crochet proposed openstack/python-mistralclient master: Add --export option to environment-get https://review.openstack.org/572799 | 15:01 |
| openstackgerrit | Brad P. Crochet proposed openstack/mistral master: Register the collect_timing keystone_authtoken option https://review.openstack.org/572788 | 15:08 |
| *** lxkong has quit IRC | 15:12 | |
| *** AlexeyAbashkin has quit IRC | 15:14 | |
| *** AlexeyAbashkin has joined #openstack-mistral | 15:16 | |
| openstackgerrit | Brad P. Crochet proposed openstack/mistral master: Register the collect_timing keystone_authtoken option https://review.openstack.org/572788 | 15:16 |
| d0ugal | therve: sure, if you have time that would be great. I am juggling a bunch of things this week. | 15:17 |
| therve | Cool will do | 15:17 |
| d0ugal | apetrich: it is mistralclient tempest tests that are failing | 15:19 |
| d0ugal | apetrich: not mistral-tempest-plugin | 15:19 |
| d0ugal | ... or I am going crazy | 15:20 |
| d0ugal | apetrich: http://logs.openstack.org/36/572136/1/check/python-mistralclient-devstack-dsvm/088fa08/job-output.txt.gz#_2018-06-04_16_18_35_649021 | 15:20 |
| d0ugal | pgaxatte: Just trying to figure out how we fix your patch ^ | 15:20 |
| d0ugal | oh and some of these failures are the collect_timing bug thrash is working on | 15:21 |
| apetrich | I was talking about this http://logs.openstack.org/36/572136/1/check/python-mistralclient-devstack-dsvm/088fa08/job-output.txt.gz#_2018-06-04_16_18_35_890969 | 15:21 |
| apetrich | d0ugal, ^^ | 15:21 |
| pgaxatte | d0ugal: oh I did not see the error :) | 15:22 |
| apetrich | but yeah they are mistralclient | 15:22 |
| d0ugal | apetrich: right, but that is still in mistralclient | 15:22 |
| d0ugal | apetrich: so we probably need a different fix | 15:22 |
| apetrich | that's what I was thinking | 15:22 |
| d0ugal | pgaxatte: np | 15:22 |
| pgaxatte | d0ugal, I don't get how this small patch can generate these strange errors | 15:24 |
| d0ugal | pgaxatte: yeah, it can be pretty confusing :) | 15:25 |
| d0ugal | apetrich: so I think we just need --force here? https://github.com/openstack/python-mistralclient/blob/master/mistralclient/tests/functional/cli/v2/base_v2.py#L155-L160 | 15:25 |
| d0ugal | apetrich: but I don't understand how that passed previously... | 15:25 |
| apetrich | me neither | 15:26 |
| apetrich | a try except there | 15:26 |
| d0ugal | :) | 15:27 |
| d0ugal | try/except everywhere! | 15:27 |
| d0ugal | pgaxatte: Are you happy for me to update your patch? | 15:29 |
| pgaxatte | d0ugal sure go ahead | 15:29 |
| openstackgerrit | Dougal Matthews proposed openstack/python-mistralclient master: Fix force parameter being always added to URL in execution delete https://review.openstack.org/572136 | 15:34 |
| pgaxatte | d0ugal, sounds good to me. any idea why the test needs --force? | 15:36 |
| openstackgerrit | Adriano Petrich proposed openstack/mistral master: Make cron-triggers not play catchup https://review.openstack.org/572813 | 15:37 |
| apetrich | pgaxatte, they just deleted any executions after the test no matter what. just cleaning | 15:38 |
| apetrich | pgaxatte, is not the tests but the clean up after a test that needs force now | 15:38 |
| d0ugal | pgaxatte: The tests user mistral master, mistral master requires that --force is used when deleting running executions (it is unsafe). | 15:38 |
| d0ugal | but given that it is only testing code we don't mind that it is unsafe | 15:38 |
| d0ugal | but yeah, as apetrich said it is just the cleanup code | 15:39 |
| d0ugal | I am not 100% this will fix it, we will see in the CI results in a bit. | 15:39 |
| pgaxatte | apetrich: ok but before the implementation of the --force, the running workflows were not cleaned? | 15:40 |
| d0ugal | pgaxatte: they were cleaned, but --force wasn't required. | 15:41 |
| d0ugal | Sorry, it is a bit confusing :) | 15:41 |
| pgaxatte | d0ugal I say this should do the trick since the force flag was always set :) | 15:41 |
| d0ugal | pgaxatte: hopefully | 15:42 |
| apetrich | deleting running executions is unsafe. if you do you might see a storm of errors in the logs of objects being referenced that no longer exits | 15:42 |
| d0ugal | pgaxatte: just to clarify... | 15:42 |
| apetrich | the --force was created to limit those errors to the times that you are ok with that | 15:42 |
| d0ugal | pgaxatte: mistral execution-delete UUID <- this command worked on any execution up until queens. However, it was unsafe to delete a running execution (you should stop it first). To stop users making that mistake we required they pass --force (a bit like git push --force is dangerous). | 15:43 |
| apetrich | we don't care much what happens the env during tests after the test has run. so it was deleting all kinds of executions and that was fine | 15:43 |
| pgaxatte | ok so if I understand correctly the old behavior was to not care whether or not the workflows you delete were still running or not? | 15:43 |
| d0ugal | pgaxatte: correct | 15:43 |
| d0ugal | pgaxatte: and now with rocky (git master) we care if the execution is still running | 15:43 |
| d0ugal | and the mistake we made was to release it in mistralclient so it works with master but not with queens | 15:44 |
| pgaxatte | ok thanks for the explanations! | 15:44 |
| *** jpich has quit IRC | 15:44 | |
| d0ugal | np | 15:45 |
| pgaxatte | hopefully some people are stuck in ancient release, like me :D | 15:45 |
| d0ugal | haha, I'm sure many people are | 15:45 |
| d0ugal | but I guess they don't usually have an old API and the newest client :) | 15:45 |
| d0ugal | but I am glad somebody is testing us! | 15:45 |
| d0ugal | I wonder if we could have a mistralclient CI job to test against the most recent stable Mistral | 15:46 |
| d0ugal | apetrich, thrash: ^ how hard would that be? :) | 15:46 |
| pgaxatte | I'm happy to report this | 15:46 |
| pgaxatte | btw I have a subject of discussion for you guys but it's gonna wait tomorrow because I gotta go home :) | 15:49 |
| d0ugal | Phew, my brain is fried. | 15:49 |
| pgaxatte | bye! | 15:49 |
| d0ugal | cta | 15:49 |
| d0ugal | oops | 15:50 |
| d0ugal | cya | 15:50 |
| d0ugal | Proof of a tired brain ^ | 15:50 |
| *** shardy has quit IRC | 16:03 | |
| *** shardy has joined #openstack-mistral | 16:04 | |
| *** gkadam has quit IRC | 16:15 | |
| *** apetrich has quit IRC | 16:34 | |
| *** apetrich has joined #openstack-mistral | 16:35 | |
| thrash | d0ugal: probably not too difficult... | 16:47 |
| *** AlexeyAbashkin has quit IRC | 16:57 | |
| *** shardy has quit IRC | 17:13 | |
| openstackgerrit | Doug Hellmann proposed openstack/mistral-lib master: fix tox python3 overrides https://review.openstack.org/572909 | 19:27 |
| *** toure is now known as toure|gone | 21:56 | |
| *** lxkong has joined #openstack-mistral | 22:01 | |
| openstackgerrit | Brad P. Crochet proposed openstack/python-mistralclient master: Add --export to get commands and deprecate get-definition https://review.openstack.org/573020 | 22:05 |
| *** threestrands has joined #openstack-mistral | 22:51 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!