*** threestrands has quit IRC | 00:25 | |
*** threestrands has joined #openstack-mistral | 00:28 | |
*** threestrands has quit IRC | 01:35 | |
*** threestrands has joined #openstack-mistral | 01:35 | |
*** threestrands has quit IRC | 01:36 | |
*** threestrands has joined #openstack-mistral | 01:37 | |
*** threestrands has quit IRC | 01:37 | |
*** threestrands has joined #openstack-mistral | 01:37 | |
*** threestrands has quit IRC | 01:38 | |
*** threestrands has joined #openstack-mistral | 01:38 | |
*** threestrands has quit IRC | 01:38 | |
*** threestrands has joined #openstack-mistral | 01:38 | |
*** threestrands has quit IRC | 01:39 | |
*** threestrands has joined #openstack-mistral | 01:40 | |
*** threestrands has quit IRC | 01:40 | |
*** threestrands has joined #openstack-mistral | 01:40 | |
*** threestrands has quit IRC | 01:41 | |
*** threestrands has joined #openstack-mistral | 02:11 | |
*** threestrands has quit IRC | 02:11 | |
*** threestrands has joined #openstack-mistral | 02:11 | |
*** d0ugal_ has joined #openstack-mistral | 02:50 | |
*** d0ugal has quit IRC | 02:51 | |
*** threestrands has quit IRC | 03:13 | |
*** hardikjasani has joined #openstack-mistral | 05:41 | |
*** jaewook_oh has quit IRC | 06:03 | |
*** AlexeyAbashkin has joined #openstack-mistral | 07:04 | |
*** gkadam has joined #openstack-mistral | 07:07 | |
pgaxatte | hello | 07:14 |
---|---|---|
*** jistr|mtgs is now known as jistr | 07:22 | |
openstackgerrit | Pierre Gaxatte proposed openstack/python-mistralclient master: Fix force parameter being always added to URL in execution delete https://review.openstack.org/572136 | 07:23 |
*** Alexey_Abashkin has joined #openstack-mistral | 07:34 | |
*** AlexeyAbashkin has quit IRC | 07:35 | |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 07:35 | |
*** AlexeyAbashkin has quit IRC | 07:46 | |
*** jaosorior has joined #openstack-mistral | 07:52 | |
*** AlexeyAbashkin has joined #openstack-mistral | 07:56 | |
*** jpich has joined #openstack-mistral | 07:57 | |
*** jaosorior has quit IRC | 08:10 | |
*** shardy has joined #openstack-mistral | 08:14 | |
*** AlexeyAbashkin has quit IRC | 08:23 | |
*** AlexeyAbashkin has joined #openstack-mistral | 08:26 | |
d0ugal_ | pgaxatte: thanks for the fix, sorry - that was stupid! | 08:29 |
*** d0ugal_ has quit IRC | 08:29 | |
*** d0ugal has joined #openstack-mistral | 08:29 | |
openstackgerrit | Andras Kovi proposed openstack/mistral master: Use register_session_conf_options API https://review.openstack.org/572300 | 08:33 |
*** AlexeyAbashkin has quit IRC | 08:33 | |
*** AlexeyAbashkin has joined #openstack-mistral | 08:38 | |
*** AlexeyAbashkin has quit IRC | 08:45 | |
*** jaosorior has joined #openstack-mistral | 08:54 | |
pgaxatte | d0ugal: no problem. I saw that this morning and thought I'd fix it quickly to let the tests run asap | 08:56 |
d0ugal | apetrich: Any idea what the collect_timing failures mean? | 09:20 |
apetrich | d0ugal, I thought thrash was looking over it so I just resigned to complain, but I can have a look | 09:21 |
apetrich | d0ugal, right now I have the foggest | 09:21 |
d0ugal | lol | 09:21 |
d0ugal | apetrich: same | 09:21 |
d0ugal | apetrich: it seems to be blocking everything | 09:22 |
d0ugal | which is an issue for making releases | 09:22 |
apetrich | d0ugal, I'm on it | 09:22 |
d0ugal | apetrich: thanks, I am trying to understand it a bit too... | 09:22 |
d0ugal | but not much luck so far. | 09:22 |
apetrich | d0ugal, there's this right https://bugs.launchpad.net/keystone/+bug/1775140 | 09:27 |
openstack | Launchpad bug 1775140 in Mistral "Keystoneauth does not consistently add the collect-timing parameter" [Medium,Confirmed] - Assigned to Brad P. Crochet (brad-9) | 09:27 |
d0ugal | aha | 09:27 |
apetrich | trying to understand what Instead of registering the options one by one in mistral, if mistral use "register_session_conf_options", this kind of error will never happen. | 09:28 |
apetrich | means | 09:28 |
*** AlexeyAbashkin has joined #openstack-mistral | 09:31 | |
*** AlexeyAbashkin has quit IRC | 09:50 | |
d0ugal | apetrich: so I guess we shouldn't register the config options manually outselves? | 09:52 |
apetrich | yeah | 09:52 |
apetrich | I'm testing that but my stack just died | 09:52 |
apetrich | I'm rebooting it | 09:53 |
apetrich | otherwise I have to spun another one | 09:53 |
d0ugal | apetrich: k | 09:53 |
d0ugal | apetrich: https://review.openstack.org/#/c/572788/3/mistral/utils/openstack/keystone.py | 09:53 |
d0ugal | It looks like thrash opted to the new option manually - which is a decent workaround for now. | 09:53 |
apetrich | yeah I saw that but I'm trying to do the register_session_conf_options | 09:54 |
apetrich | just to make it clean if I don't get it to work before lunch I think we +2 that and worry later :( | 09:54 |
* apetrich hates worring later | 09:54 | |
d0ugal | apetrich: I already +W | 09:54 |
d0ugal | lol | 09:54 |
apetrich | lol | 09:55 |
apetrich | fair | 09:55 |
d0ugal | Everything is blocked, I don't think I have a choice | 09:55 |
* apetrich is worring later | 09:55 | |
apetrich | agreed | 09:55 |
d0ugal | I'll reopen the bug tho, we need to fix it properly asap | 09:55 |
d0ugal | (I'll reopen the bug once it is closed by the Closes-Bug thing) | 09:55 |
apetrich | so using the register_session_conf_options might be messy | 10:01 |
*** AlexeyAbashkin has joined #openstack-mistral | 10:02 | |
apetrich | because we already register a bunch of stuff. I'm getting "oslo_config.cfg.DuplicateOptError: duplicate option: cafile" that might or not be a valid complain | 10:02 |
apetrich | I need to see if I"m using it right | 10:02 |
openstackgerrit | Dougal Matthews proposed openstack/python-mistralclient master: Fix force parameter being always added to URL in execution delete https://review.openstack.org/572136 | 10:11 |
openstackgerrit | Dougal Matthews proposed openstack/python-mistralclient master: Revert "Adding environment-get-definition for easy environment-update" https://review.openstack.org/572111 | 10:12 |
openstackgerrit | Dougal Matthews proposed openstack/python-mistralclient master: Add --export option to environment-get https://review.openstack.org/572799 | 10:12 |
openstackgerrit | Dougal Matthews proposed openstack/python-mistralclient master: Add --export to get commands and deprecate get-definition https://review.openstack.org/573020 | 10:12 |
d0ugal | apetrich: damn | 10:13 |
d0ugal | apetrich: Maybe we just need to remove every duplicate? | 10:13 |
*** AlexeyAbashkin has quit IRC | 10:13 | |
*** Alexey_Abashkin has joined #openstack-mistral | 10:13 | |
apetrich | d0ugal, I did +2 on brads solution also | 10:13 |
apetrich | d0ugal, not seeing the duplicates though. It might be a bit of magic | 10:14 |
d0ugal | hmm | 10:14 |
d0ugal | apetrich: https://github.com/openstack/mistral/blob/76ddff39cb878fc6d0f38eb5d2bcd07c2dcd3eb5/mistral/config.py#L407 | 10:14 |
d0ugal | Different group, but could that be the issue? | 10:15 |
apetrich | d0ugal, I've removed that and still complains of cafile | 10:15 |
apetrich | :) | 10:15 |
d0ugal | oh | 10:15 |
apetrich | I was expecting for it to complain about insecure but still cafile | 10:15 |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 10:16 | |
openstackgerrit | Dougal Matthews proposed openstack/mistral master: Fix the call to start_workflow from events triggers https://review.openstack.org/570535 | 10:17 |
openstackgerrit | Dougal Matthews proposed openstack/mistral master: Fix the call to start_workflow from events triggers https://review.openstack.org/570535 | 10:17 |
d0ugal | apetrich: oh! https://review.openstack.org/#/c/572300/2/mistral/utils/openstack/keystone.py | 10:18 |
d0ugal | https://review.openstack.org/#/c/572300/2 | 10:18 |
d0ugal | Andras already done it? | 10:18 |
apetrich | yeah | 10:18 |
apetrich | just saw his comment | 10:18 |
d0ugal | I totally missed that | 10:18 |
d0ugal | apetrich: I removed the +W from brads to give us a moment to think | 10:19 |
apetrich | Andras solution works | 10:21 |
apetrich | just tested | 10:21 |
*** AlexeyAbashkin has quit IRC | 10:23 | |
d0ugal | apetrich: does it change the config? | 10:24 |
d0ugal | "Additionally, it would require a new section in the config file and would be a backward incompatible change" | 10:24 |
d0ugal | I am trying to understand the impact of that. | 10:24 |
*** AlexeyAbashkin has joined #openstack-mistral | 10:25 | |
d0ugal | If nothing else we would want a release note and maybe some docs need updated? | 10:25 |
d0ugal | also, Andras did +2 thrash's patch - so he seems happy with that fix too | 10:27 |
apetrich | I don't see the change in the /etc/mistral/mistral.conf but that was where the cafile was complaining | 10:27 |
d0ugal | Right | 10:27 |
apetrich | do we have a migration for anything other the db? because if we could just read from the old key and add to the new key it would be better | 10:28 |
apetrich | more transparent | 10:28 |
d0ugal | apetrich: I don't believe so | 10:30 |
d0ugal | apetrich: I think for that you'd need to have both config names and then copy it into the new one. maybe? | 10:30 |
d0ugal | apetrich: I am going to go with the smaller, lower risk patch. | 10:31 |
d0ugal | We can try to refactor this after, but I'd really like to avoid a backwards incompatible change here | 10:31 |
d0ugal | It could be quite painful and not very useful. | 10:32 |
apetrich | right now this is what I have under keystone_authtoken http://paste.openstack.org/show/722868/ | 10:34 |
apetrich | so I think we go with thrash's solution | 10:34 |
d0ugal | ack | 10:35 |
apetrich | agreed on the "quite painful and not very useful" | 10:35 |
d0ugal | I'm fine with backwards incompatible changes for good reasons :) | 10:36 |
*** Alexey_Abashkin has joined #openstack-mistral | 10:38 | |
*** AlexeyAbashkin has quit IRC | 10:39 | |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 10:39 | |
*** apetrich has quit IRC | 10:40 | |
opetrenko_ | Hi guys, anyone knows is it possible to execute mistral workflow after stack created? | 10:49 |
*** AlexeyAbashkin has quit IRC | 11:01 | |
thrash | d0ugal: So, the long-term solution is definitely andras' solution. | 11:09 |
d0ugal | thrash: yup | 11:09 |
thrash | d0ugal: then we won't get hit by this. | 11:09 |
d0ugal | Glad we agree :) | 11:09 |
openstackgerrit | Dougal Matthews proposed openstack/mistral-dashboard master: Add the restructuredtext check to the flake8 job https://review.openstack.org/573187 | 11:10 |
openstackgerrit | Dougal Matthews proposed openstack/mistral master: Add the restructuredtext check to the flake8 job https://review.openstack.org/573188 | 11:10 |
thrash | d0ugal: not sure that we'd *require* config file changes now, as I believe these two params are optional | 11:10 |
thrash | d0ugal: but if they introduced a required param, that would be the case. | 11:11 |
thrash | IIUC | 11:11 |
openstackgerrit | Dougal Matthews proposed openstack/mistral-extra master: Add the restructuredtext check to the flake8 job https://review.openstack.org/573189 | 11:12 |
openstackgerrit | Dougal Matthews proposed openstack/mistral-lib master: Add the restructuredtext check to the flake8 job https://review.openstack.org/573190 | 11:12 |
openstackgerrit | Dougal Matthews proposed openstack/python-mistralclient master: Add the restructuredtext check to the flake8 job https://review.openstack.org/573191 | 11:12 |
d0ugal | thrash: yeah, makes sense. | 11:13 |
thrash | d0ugal: I guess what I don't understand is the need for a new section? | 11:18 |
d0ugal | thrash: Yeah, I don't fully get that either. | 11:19 |
d0ugal | thrash: bbiab, lunch! | 11:19 |
thrash | d0ugal: enjoy! | 11:19 |
thrash | biab, heading to the office | 11:20 |
*** thrash is now known as thrash|biab | 11:20 | |
opetrenko_ | Can anyone help me detect, why this workbook doesn't work? http://paste.openstack.org/show/722873/ | 11:27 |
*** rbrady has joined #openstack-mistral | 11:49 | |
*** rbrady has quit IRC | 11:49 | |
*** rbrady has joined #openstack-mistral | 11:49 | |
*** AlexeyAbashkin has joined #openstack-mistral | 11:51 | |
*** thrash|biab is now known as thrash | 12:02 | |
*** katkapilatova has joined #openstack-mistral | 12:03 | |
openstackgerrit | Merged openstack/mistral master: Register the collect_timing keystone_authtoken option https://review.openstack.org/572788 | 12:10 |
*** apetrich has joined #openstack-mistral | 12:30 | |
openstackgerrit | Dougal Matthews proposed openstack/mistral master: Add the restructuredtext check to the flake8 job https://review.openstack.org/573188 | 12:45 |
d0ugal | opetrenko_: How does it not work? Do you get an error? | 12:46 |
opetrenko_ | yeah, I found that list_join is heat feature not mistral | 12:47 |
opetrenko_ | but there is another question: how can i pass template name to heat.stacks_create? | 12:47 |
*** toure|gone is now known as toure | 12:50 | |
d0ugal | opetrenko_: there are two ways... | 12:52 |
d0ugal | action: heat.stacks_create template=pop.yaml | 12:52 |
d0ugal | or | 12:52 |
d0ugal | action: heat.stacks_create | 12:53 |
d0ugal | input: | 12:53 |
d0ugal | template=pop.yaml | 12:53 |
d0ugal | opetrenko_: to use tripleo examples again, here is an inline input: | 12:53 |
d0ugal | https://github.com/openstack/tripleo-common/blob/master/workbooks/baremetal.yaml#L30 | 12:53 |
d0ugal | and then the input on multiple lines: | 12:53 |
d0ugal | https://github.com/openstack/tripleo-common/blob/master/workbooks/baremetal.yaml#L38-L41 | 12:53 |
*** hardikjasani has quit IRC | 13:01 | |
d0ugal | apetrich: Fancy some easy review points? | 13:07 |
d0ugal | apetrich: a few at the top here: https://review.openstack.org/#/q/owner:dougal%2540redhat.com+status:open | 13:07 |
*** AlexeyAbashkin has quit IRC | 13:08 | |
*** Alexey_Abashkin has joined #openstack-mistral | 13:08 | |
apetrich | sure | 13:08 |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 13:10 | |
d0ugal | apetrich: and more importantly, can you take a look at https://review.openstack.org/#/c/572799/ | 13:11 |
*** apetrich has quit IRC | 13:13 | |
thrash | d0ugal: found an old trusts-related patch. Gonna see how it functions... | 13:16 |
thrash | d0ugal: https://review.openstack.org/#/c/462056/8 | 13:16 |
thrash | d0ugal: about to push an update to that. | 13:16 |
openstackgerrit | Brad P. Crochet proposed openstack/mistral master: Add user creds trusts to db https://review.openstack.org/462056 | 13:17 |
d0ugal | thrash: Great | 13:18 |
thrash | d0ugal: I think it's a more comprehensive patch than mine tbh. | 13:18 |
pgaxatte | d0ugal: about https://review.openstack.org/#/c/572136/ maybe the --force is ignored because it passed after the wf id? | 13:18 |
openstackgerrit | Dougal Matthews proposed openstack/python-mistralclient master: Fix force parameter being always added to URL in execution delete https://review.openstack.org/572136 | 13:19 |
d0ugal | pgaxatte: no, I think that is okay. The number of failures reduced. I missed one. Just updated it. Some of the errors I don't understand (yet) | 13:19 |
pgaxatte | oh alright | 13:19 |
d0ugal | thrash: oh yeah, I sort of remember seeing that patch and not understanding it. | 13:20 |
thrash | d0ugal: lol | 13:20 |
d0ugal | thrash: please add a release note to it if nothing else:) | 13:20 |
thrash | d0ugal: I probably should have run tox before pushing it. lol | 13:20 |
thrash | d0ugal: will do. | 13:20 |
d0ugal | yolo | 13:21 |
thrash | d0ugal: I will add the release note once I see it working | 13:23 |
d0ugal | thrash: sure. | 13:24 |
*** apetrich has joined #openstack-mistral | 13:26 | |
*** openstackgerrit has quit IRC | 13:34 | |
*** AlexeyAbashkin has quit IRC | 13:43 | |
*** AlexeyAbashkin has joined #openstack-mistral | 13:50 | |
*** openstackgerrit has joined #openstack-mistral | 13:51 | |
openstackgerrit | Brad P. Crochet proposed openstack/mistral master: Add user creds trusts to db https://review.openstack.org/462056 | 13:51 |
*** Alexey_Abashkin has joined #openstack-mistral | 14:02 | |
*** AlexeyAbashkin has quit IRC | 14:02 | |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 14:02 | |
*** gkadam has quit IRC | 14:03 | |
*** gkadam has joined #openstack-mistral | 14:04 | |
*** katkapilatova has quit IRC | 14:04 | |
d0ugal | apetrich: https://review.openstack.org/#/c/572799/ | 14:28 |
d0ugal | Can you review that one? | 14:28 |
apetrich | sure. in a moment | 14:29 |
d0ugal | It looks like https://review.openstack.org/572136 is going to pass now too | 14:32 |
d0ugal | \o/ | 14:32 |
d0ugal | pgaxatte: ^ | 14:32 |
d0ugal | (hopefully I didn't jinx it) | 14:32 |
d0ugal | Well, there is a pep8 error, but I have that fixed - just waiting to see the devstack result. | 14:32 |
apetrich | d0ugal, nice! tests are passing | 14:33 |
apetrich | \o/ | 14:34 |
openstackgerrit | Brad P. Crochet proposed openstack/mistral-lib master: Add param for trustor_user_id https://review.openstack.org/573261 | 14:37 |
apetrich | d0ugal, and then "Saferestart as soon as jobs finish" for ci-centos | 14:37 |
openstackgerrit | Brad P. Crochet proposed openstack/mistral master: Add user creds trusts to db https://review.openstack.org/462056 | 14:37 |
d0ugal | apetrich: I don't follow? | 14:37 |
openstackgerrit | Andras Kovi proposed openstack/mistral master: Use register_session_conf_options API https://review.openstack.org/572300 | 14:38 |
apetrich | d0ugal, they are saferebooting the ci. just when tests passes. so the queue is going to probably be stuck until it finishes the running jobs | 14:38 |
openstackgerrit | Dougal Matthews proposed openstack/python-mistralclient master: Fix force parameter being always added to URL in execution delete https://review.openstack.org/572136 | 14:38 |
*** Alexey_Abashkin has joined #openstack-mistral | 14:38 | |
d0ugal | apetrich: oh, damn | 14:38 |
d0ugal | apetrich: where did you see that? | 14:39 |
apetrich | ci-users list | 14:39 |
apetrich | just now | 14:39 |
d0ugal | ah well | 14:39 |
*** AlexeyAbashkin has quit IRC | 14:41 | |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 14:41 | |
*** thrash is now known as thrash|biab | 14:43 | |
openstackgerrit | Chen proposed openstack/python-mistralclient master: Remove PyPI downloads https://review.openstack.org/573272 | 14:44 |
*** apetrich has quit IRC | 14:48 | |
opetrenko_ | Another question | 15:02 |
*** apetrich has joined #openstack-mistral | 15:04 | |
opetrenko_ | d0ugal: For example I have 2 yamls. First yaml is heat template. Second yaml is mistral workbook, where I try to use heat.stacks_create with template described in first yaml. How can I pass this template to heat action, because when I try to just use input:\n template: pop.yaml I get http://paste.openstack.org/show/722903/ | 15:06 |
*** d0ugal has quit IRC | 15:07 | |
*** thrash|biab is now known as thrash | 15:08 | |
*** Alexey_Abashkin has joined #openstack-mistral | 15:20 | |
*** AlexeyAbashkin has quit IRC | 15:22 | |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 15:22 | |
*** AlexeyAbashkin has quit IRC | 15:22 | |
*** apetrich has quit IRC | 15:22 | |
*** AlexeyAbashkin has joined #openstack-mistral | 15:23 | |
*** Alexey_Abashkin has joined #openstack-mistral | 15:37 | |
*** AlexeyAbashkin has quit IRC | 15:37 | |
*** Alexey_Abashkin is now known as AlexeyAbashkin | 15:37 | |
*** AlexeyAbashkin has quit IRC | 15:53 | |
*** jpich has quit IRC | 16:41 | |
*** gkadam has quit IRC | 17:14 | |
*** openstackgerrit has quit IRC | 17:34 | |
*** openstackgerrit has joined #openstack-mistral | 17:59 | |
openstackgerrit | Toure Dunnon proposed openstack/mistral-extra master: Add Ansible actions to Mistral https://review.openstack.org/514360 | 17:59 |
*** apetrich has joined #openstack-mistral | 18:11 | |
*** gkadam has joined #openstack-mistral | 18:51 | |
openstackgerrit | Merged openstack/python-mistralclient master: Revert "Adding environment-get-definition for easy environment-update" https://review.openstack.org/572111 | 18:59 |
openstackgerrit | Merged openstack/python-mistralclient master: Add --export option to environment-get https://review.openstack.org/572799 | 18:59 |
openstackgerrit | Merged openstack/mistral master: Fix the call to start_workflow from events triggers https://review.openstack.org/570535 | 18:59 |
*** toure is now known as toure|biab | 19:23 | |
*** d0ugal has joined #openstack-mistral | 19:29 | |
openstackgerrit | Dougal Matthews proposed openstack/python-mistralclient stable/queens: Add --export option to environment-get https://review.openstack.org/573418 | 19:34 |
openstackgerrit | Dougal Matthews proposed openstack/python-mistralclient stable/pike: Add --export option to environment-get https://review.openstack.org/573419 | 19:34 |
openstackgerrit | Dougal Matthews proposed openstack/python-mistralclient stable/ocata: Add --export option to environment-get https://review.openstack.org/573420 | 19:34 |
d0ugal | apetrich: Can you take a look at this ASAP tomorrow? https://review.openstack.org/#/c/572136/ | 19:35 |
d0ugal | apetrich: I want to land it before doing the releases | 19:35 |
apetrich | d0ugal, I can do now if it is urgent | 19:36 |
d0ugal | apetrich: That is up to you. It can wait, but it is also small - the --force fix. | 19:36 |
apetrich | d0ugal, oh that's simple | 19:36 |
apetrich | yeah lgtm | 19:36 |
d0ugal | apetrich: Thank you! | 19:37 |
apetrich | np | 19:37 |
d0ugal | That means it should be merged by morning and I can do the release patches first thing :) | 19:37 |
apetrich | neat | 19:37 |
apetrich | fixing that is really important to me :( | 19:37 |
d0ugal | Aye, me too. Thankfully it wasn't bad in the end. | 19:39 |
openstackgerrit | Dougal Matthews proposed openstack/mistral master: Make cron-triggers not play catchup https://review.openstack.org/572813 | 19:46 |
*** toure|biab is now known as toure | 20:07 | |
*** gkadam has quit IRC | 20:11 | |
*** d0ugal has quit IRC | 20:21 | |
openstackgerrit | Merged openstack/python-mistralclient master: Fix force parameter being always added to URL in execution delete https://review.openstack.org/572136 | 22:10 |
*** toure is now known as toure|gone | 22:15 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!