Thursday, 2018-06-07

*** threestrands has quit IRC00:25
*** threestrands has joined #openstack-mistral00:28
*** threestrands has quit IRC01:35
*** threestrands has joined #openstack-mistral01:35
*** threestrands has quit IRC01:36
*** threestrands has joined #openstack-mistral01:37
*** threestrands has quit IRC01:37
*** threestrands has joined #openstack-mistral01:37
*** threestrands has quit IRC01:38
*** threestrands has joined #openstack-mistral01:38
*** threestrands has quit IRC01:38
*** threestrands has joined #openstack-mistral01:38
*** threestrands has quit IRC01:39
*** threestrands has joined #openstack-mistral01:40
*** threestrands has quit IRC01:40
*** threestrands has joined #openstack-mistral01:40
*** threestrands has quit IRC01:41
*** threestrands has joined #openstack-mistral02:11
*** threestrands has quit IRC02:11
*** threestrands has joined #openstack-mistral02:11
*** d0ugal_ has joined #openstack-mistral02:50
*** d0ugal has quit IRC02:51
*** threestrands has quit IRC03:13
*** hardikjasani has joined #openstack-mistral05:41
*** jaewook_oh has quit IRC06:03
*** AlexeyAbashkin has joined #openstack-mistral07:04
*** gkadam has joined #openstack-mistral07:07
pgaxattehello07:14
*** jistr|mtgs is now known as jistr07:22
openstackgerritPierre Gaxatte proposed openstack/python-mistralclient master: Fix force parameter being always added to URL in execution delete  https://review.openstack.org/57213607:23
*** Alexey_Abashkin has joined #openstack-mistral07:34
*** AlexeyAbashkin has quit IRC07:35
*** Alexey_Abashkin is now known as AlexeyAbashkin07:35
*** AlexeyAbashkin has quit IRC07:46
*** jaosorior has joined #openstack-mistral07:52
*** AlexeyAbashkin has joined #openstack-mistral07:56
*** jpich has joined #openstack-mistral07:57
*** jaosorior has quit IRC08:10
*** shardy has joined #openstack-mistral08:14
*** AlexeyAbashkin has quit IRC08:23
*** AlexeyAbashkin has joined #openstack-mistral08:26
d0ugal_pgaxatte: thanks for the fix, sorry - that was stupid!08:29
*** d0ugal_ has quit IRC08:29
*** d0ugal has joined #openstack-mistral08:29
openstackgerritAndras Kovi proposed openstack/mistral master: Use register_session_conf_options API  https://review.openstack.org/57230008:33
*** AlexeyAbashkin has quit IRC08:33
*** AlexeyAbashkin has joined #openstack-mistral08:38
*** AlexeyAbashkin has quit IRC08:45
*** jaosorior has joined #openstack-mistral08:54
pgaxatted0ugal: no problem. I saw that this morning and thought I'd fix it quickly to let the tests run asap08:56
d0ugalapetrich: Any idea what the collect_timing failures mean?09:20
apetrichd0ugal, I thought thrash was looking over it so I just resigned to complain, but I can have a look09:21
apetrichd0ugal, right now I have the foggest09:21
d0ugallol09:21
d0ugalapetrich: same09:21
d0ugalapetrich: it seems to be blocking everything09:22
d0ugalwhich is an issue for making releases09:22
apetrichd0ugal, I'm on it09:22
d0ugalapetrich: thanks, I am trying to understand it a bit too...09:22
d0ugalbut not much luck so far.09:22
apetrichd0ugal, there's this right https://bugs.launchpad.net/keystone/+bug/177514009:27
openstackLaunchpad bug 1775140 in Mistral "Keystoneauth does not consistently add the collect-timing parameter" [Medium,Confirmed] - Assigned to Brad P. Crochet (brad-9)09:27
d0ugalaha09:27
apetrichtrying to understand what Instead of registering the options one by one in mistral, if mistral use "register_session_conf_options", this kind of error will never happen.09:28
apetrichmeans09:28
*** AlexeyAbashkin has joined #openstack-mistral09:31
*** AlexeyAbashkin has quit IRC09:50
d0ugalapetrich: so I guess we shouldn't register the config options manually outselves?09:52
apetrichyeah09:52
apetrichI'm testing that but my stack just died09:52
apetrichI'm rebooting it09:53
apetrichotherwise I have to spun another one09:53
d0ugalapetrich: k09:53
d0ugalapetrich: https://review.openstack.org/#/c/572788/3/mistral/utils/openstack/keystone.py09:53
d0ugalIt looks like thrash opted to the new option manually - which is a decent workaround for now.09:53
apetrichyeah I saw that but I'm trying to do the register_session_conf_options09:54
apetrichjust to make it clean if I don't get it to work before lunch I think we +2 that and worry later :(09:54
* apetrich hates worring later09:54
d0ugalapetrich: I already +W09:54
d0ugallol09:54
apetrichlol09:55
apetrichfair09:55
d0ugalEverything is blocked, I don't think I have a choice09:55
* apetrich is worring later09:55
apetrichagreed09:55
d0ugalI'll reopen the bug tho, we need to fix it properly asap09:55
d0ugal(I'll reopen the bug once it is closed by the Closes-Bug thing)09:55
apetrichso using the register_session_conf_options might be messy10:01
*** AlexeyAbashkin has joined #openstack-mistral10:02
apetrichbecause we already register a bunch of stuff. I'm getting "oslo_config.cfg.DuplicateOptError: duplicate option: cafile" that might or not be a valid complain10:02
apetrichI need to see if I"m using it right10:02
openstackgerritDougal Matthews proposed openstack/python-mistralclient master: Fix force parameter being always added to URL in execution delete  https://review.openstack.org/57213610:11
openstackgerritDougal Matthews proposed openstack/python-mistralclient master: Revert "Adding environment-get-definition for easy environment-update"  https://review.openstack.org/57211110:12
openstackgerritDougal Matthews proposed openstack/python-mistralclient master: Add --export option to environment-get  https://review.openstack.org/57279910:12
openstackgerritDougal Matthews proposed openstack/python-mistralclient master: Add --export to get commands and deprecate get-definition  https://review.openstack.org/57302010:12
d0ugalapetrich: damn10:13
d0ugalapetrich: Maybe we just need to remove every duplicate?10:13
*** AlexeyAbashkin has quit IRC10:13
*** Alexey_Abashkin has joined #openstack-mistral10:13
apetrichd0ugal, I did +2 on brads solution also10:13
apetrichd0ugal, not seeing the duplicates though. It might be a bit of magic10:14
d0ugalhmm10:14
d0ugalapetrich: https://github.com/openstack/mistral/blob/76ddff39cb878fc6d0f38eb5d2bcd07c2dcd3eb5/mistral/config.py#L40710:14
d0ugalDifferent group, but could that be the issue?10:15
apetrichd0ugal, I've removed that and still complains of cafile10:15
apetrich:)10:15
d0ugaloh10:15
apetrichI was expecting for it to complain about insecure but still cafile10:15
*** Alexey_Abashkin is now known as AlexeyAbashkin10:16
openstackgerritDougal Matthews proposed openstack/mistral master: Fix the call to start_workflow from events triggers  https://review.openstack.org/57053510:17
openstackgerritDougal Matthews proposed openstack/mistral master: Fix the call to start_workflow from events triggers  https://review.openstack.org/57053510:17
d0ugalapetrich: oh! https://review.openstack.org/#/c/572300/2/mistral/utils/openstack/keystone.py10:18
d0ugalhttps://review.openstack.org/#/c/572300/210:18
d0ugalAndras already done it?10:18
apetrichyeah10:18
apetrichjust saw his comment10:18
d0ugalI totally missed that10:18
d0ugalapetrich: I removed the +W from brads to give us a moment to think10:19
apetrichAndras solution works10:21
apetrichjust tested10:21
*** AlexeyAbashkin has quit IRC10:23
d0ugalapetrich: does it change the config?10:24
d0ugal"Additionally, it would require a new section in the config file and would be a backward incompatible change"10:24
d0ugalI am trying to understand the impact of that.10:24
*** AlexeyAbashkin has joined #openstack-mistral10:25
d0ugalIf nothing else we would want a release note and maybe some docs need updated?10:25
d0ugalalso, Andras did +2 thrash's patch - so he seems happy with that fix too10:27
apetrichI don't see the change in the /etc/mistral/mistral.conf but that was where the cafile was complaining10:27
d0ugalRight10:27
apetrichdo we have a migration for anything other the db? because if we could just read from the old key and add to the new key it would be better10:28
apetrichmore transparent10:28
d0ugalapetrich: I don't believe so10:30
d0ugalapetrich: I think for that you'd need to have both config names and then copy it into the new one. maybe?10:30
d0ugalapetrich: I am going to go with the smaller, lower risk patch.10:31
d0ugalWe can try to refactor this after, but I'd really like to avoid a backwards incompatible change here10:31
d0ugalIt could be quite painful and not very useful.10:32
apetrichright now this is what I have under keystone_authtoken http://paste.openstack.org/show/722868/10:34
apetrichso I think we go with thrash's solution10:34
d0ugalack10:35
apetrichagreed on the "quite painful and not very useful"10:35
d0ugalI'm fine with backwards incompatible changes for good reasons :)10:36
*** Alexey_Abashkin has joined #openstack-mistral10:38
*** AlexeyAbashkin has quit IRC10:39
*** Alexey_Abashkin is now known as AlexeyAbashkin10:39
*** apetrich has quit IRC10:40
opetrenko_Hi guys, anyone knows is it possible to execute mistral workflow after stack created?10:49
*** AlexeyAbashkin has quit IRC11:01
thrashd0ugal: So, the long-term solution is definitely andras' solution.11:09
d0ugalthrash: yup11:09
thrashd0ugal: then we won't get hit by this.11:09
d0ugalGlad we agree :)11:09
openstackgerritDougal Matthews proposed openstack/mistral-dashboard master: Add the restructuredtext check to the flake8 job  https://review.openstack.org/57318711:10
openstackgerritDougal Matthews proposed openstack/mistral master: Add the restructuredtext check to the flake8 job  https://review.openstack.org/57318811:10
thrashd0ugal: not sure that we'd *require* config file changes now, as I believe these two params are optional11:10
thrashd0ugal: but if they introduced a required param, that would be the case.11:11
thrashIIUC11:11
openstackgerritDougal Matthews proposed openstack/mistral-extra master: Add the restructuredtext check to the flake8 job  https://review.openstack.org/57318911:12
openstackgerritDougal Matthews proposed openstack/mistral-lib master: Add the restructuredtext check to the flake8 job  https://review.openstack.org/57319011:12
openstackgerritDougal Matthews proposed openstack/python-mistralclient master: Add the restructuredtext check to the flake8 job  https://review.openstack.org/57319111:12
d0ugalthrash: yeah, makes sense.11:13
thrashd0ugal: I guess what I don't understand is the need for a new section?11:18
d0ugalthrash: Yeah, I don't fully get that either.11:19
d0ugalthrash: bbiab, lunch!11:19
thrashd0ugal: enjoy!11:19
thrashbiab, heading to the office11:20
*** thrash is now known as thrash|biab11:20
opetrenko_Can anyone help me detect, why this workbook doesn't work? http://paste.openstack.org/show/722873/11:27
*** rbrady has joined #openstack-mistral11:49
*** rbrady has quit IRC11:49
*** rbrady has joined #openstack-mistral11:49
*** AlexeyAbashkin has joined #openstack-mistral11:51
*** thrash|biab is now known as thrash12:02
*** katkapilatova has joined #openstack-mistral12:03
openstackgerritMerged openstack/mistral master: Register the collect_timing keystone_authtoken option  https://review.openstack.org/57278812:10
*** apetrich has joined #openstack-mistral12:30
openstackgerritDougal Matthews proposed openstack/mistral master: Add the restructuredtext check to the flake8 job  https://review.openstack.org/57318812:45
d0ugalopetrenko_: How does it not work? Do you get an error?12:46
opetrenko_yeah, I found that list_join is heat feature not mistral12:47
opetrenko_but there is another question: how can i pass template name to heat.stacks_create?12:47
*** toure|gone is now known as toure12:50
d0ugalopetrenko_: there are two ways...12:52
d0ugalaction: heat.stacks_create template=pop.yaml12:52
d0ugalor12:52
d0ugalaction: heat.stacks_create12:53
d0ugalinput:12:53
d0ugal  template=pop.yaml12:53
d0ugalopetrenko_: to use tripleo examples again, here is an inline input:12:53
d0ugalhttps://github.com/openstack/tripleo-common/blob/master/workbooks/baremetal.yaml#L3012:53
d0ugaland then the input on multiple lines:12:53
d0ugalhttps://github.com/openstack/tripleo-common/blob/master/workbooks/baremetal.yaml#L38-L4112:53
*** hardikjasani has quit IRC13:01
d0ugalapetrich: Fancy some easy review points?13:07
d0ugalapetrich: a few at the top here: https://review.openstack.org/#/q/owner:dougal%2540redhat.com+status:open13:07
*** AlexeyAbashkin has quit IRC13:08
*** Alexey_Abashkin has joined #openstack-mistral13:08
apetrichsure13:08
*** Alexey_Abashkin is now known as AlexeyAbashkin13:10
d0ugalapetrich: and more importantly, can you take a look at https://review.openstack.org/#/c/572799/13:11
*** apetrich has quit IRC13:13
thrashd0ugal: found an old trusts-related patch. Gonna see how it functions...13:16
thrashd0ugal: https://review.openstack.org/#/c/462056/813:16
thrashd0ugal: about to push an update to that.13:16
openstackgerritBrad P. Crochet proposed openstack/mistral master: Add user creds trusts to db  https://review.openstack.org/46205613:17
d0ugalthrash: Great13:18
thrashd0ugal: I think it's a more comprehensive patch than mine tbh.13:18
pgaxatted0ugal: about https://review.openstack.org/#/c/572136/ maybe the --force is ignored because it passed after the wf id?13:18
openstackgerritDougal Matthews proposed openstack/python-mistralclient master: Fix force parameter being always added to URL in execution delete  https://review.openstack.org/57213613:19
d0ugalpgaxatte: no, I think that is okay. The number of failures reduced. I missed one. Just updated it. Some of the errors I don't understand (yet)13:19
pgaxatteoh alright13:19
d0ugalthrash: oh yeah, I sort of remember seeing that patch and not understanding it.13:20
thrashd0ugal: lol13:20
d0ugalthrash: please add a release note to it if nothing else:)13:20
thrashd0ugal: I probably should have run tox before pushing it. lol13:20
thrashd0ugal: will do.13:20
d0ugalyolo13:21
thrashd0ugal: I will add the release note once I see it working13:23
d0ugalthrash: sure.13:24
*** apetrich has joined #openstack-mistral13:26
*** openstackgerrit has quit IRC13:34
*** AlexeyAbashkin has quit IRC13:43
*** AlexeyAbashkin has joined #openstack-mistral13:50
*** openstackgerrit has joined #openstack-mistral13:51
openstackgerritBrad P. Crochet proposed openstack/mistral master: Add user creds trusts to db  https://review.openstack.org/46205613:51
*** Alexey_Abashkin has joined #openstack-mistral14:02
*** AlexeyAbashkin has quit IRC14:02
*** Alexey_Abashkin is now known as AlexeyAbashkin14:02
*** gkadam has quit IRC14:03
*** gkadam has joined #openstack-mistral14:04
*** katkapilatova has quit IRC14:04
d0ugalapetrich: https://review.openstack.org/#/c/572799/14:28
d0ugalCan you review that one?14:28
apetrichsure. in a moment14:29
d0ugalIt looks like https://review.openstack.org/572136 is going to pass now too14:32
d0ugal\o/14:32
d0ugalpgaxatte: ^14:32
d0ugal(hopefully I didn't jinx it)14:32
d0ugalWell, there is a pep8 error, but I have that fixed - just waiting to see the devstack result.14:32
apetrichd0ugal, nice! tests are passing14:33
apetrich\o/14:34
openstackgerritBrad P. Crochet proposed openstack/mistral-lib master: Add param for trustor_user_id  https://review.openstack.org/57326114:37
apetrichd0ugal, and then "Saferestart as soon as jobs finish" for ci-centos14:37
openstackgerritBrad P. Crochet proposed openstack/mistral master: Add user creds trusts to db  https://review.openstack.org/46205614:37
d0ugalapetrich: I don't follow?14:37
openstackgerritAndras Kovi proposed openstack/mistral master: Use register_session_conf_options API  https://review.openstack.org/57230014:38
apetrichd0ugal, they are saferebooting the ci. just when tests passes. so the queue is going to probably be stuck until it finishes the running jobs14:38
openstackgerritDougal Matthews proposed openstack/python-mistralclient master: Fix force parameter being always added to URL in execution delete  https://review.openstack.org/57213614:38
*** Alexey_Abashkin has joined #openstack-mistral14:38
d0ugalapetrich: oh, damn14:38
d0ugalapetrich: where did you see that?14:39
apetrichci-users list14:39
apetrichjust now14:39
d0ugalah well14:39
*** AlexeyAbashkin has quit IRC14:41
*** Alexey_Abashkin is now known as AlexeyAbashkin14:41
*** thrash is now known as thrash|biab14:43
openstackgerritChen proposed openstack/python-mistralclient master: Remove PyPI downloads  https://review.openstack.org/57327214:44
*** apetrich has quit IRC14:48
opetrenko_Another question15:02
*** apetrich has joined #openstack-mistral15:04
opetrenko_d0ugal: For example I have 2 yamls. First yaml is heat template. Second yaml is mistral workbook, where I try to use heat.stacks_create with template described in first yaml. How can I pass this template to heat action, because when I try to just use input:\n template: pop.yaml I get http://paste.openstack.org/show/722903/15:06
*** d0ugal has quit IRC15:07
*** thrash|biab is now known as thrash15:08
*** Alexey_Abashkin has joined #openstack-mistral15:20
*** AlexeyAbashkin has quit IRC15:22
*** Alexey_Abashkin is now known as AlexeyAbashkin15:22
*** AlexeyAbashkin has quit IRC15:22
*** apetrich has quit IRC15:22
*** AlexeyAbashkin has joined #openstack-mistral15:23
*** Alexey_Abashkin has joined #openstack-mistral15:37
*** AlexeyAbashkin has quit IRC15:37
*** Alexey_Abashkin is now known as AlexeyAbashkin15:37
*** AlexeyAbashkin has quit IRC15:53
*** jpich has quit IRC16:41
*** gkadam has quit IRC17:14
*** openstackgerrit has quit IRC17:34
*** openstackgerrit has joined #openstack-mistral17:59
openstackgerritToure Dunnon proposed openstack/mistral-extra master: Add Ansible actions to Mistral  https://review.openstack.org/51436017:59
*** apetrich has joined #openstack-mistral18:11
*** gkadam has joined #openstack-mistral18:51
openstackgerritMerged openstack/python-mistralclient master: Revert "Adding environment-get-definition for easy environment-update"  https://review.openstack.org/57211118:59
openstackgerritMerged openstack/python-mistralclient master: Add --export option to environment-get  https://review.openstack.org/57279918:59
openstackgerritMerged openstack/mistral master: Fix the call to start_workflow from events triggers  https://review.openstack.org/57053518:59
*** toure is now known as toure|biab19:23
*** d0ugal has joined #openstack-mistral19:29
openstackgerritDougal Matthews proposed openstack/python-mistralclient stable/queens: Add --export option to environment-get  https://review.openstack.org/57341819:34
openstackgerritDougal Matthews proposed openstack/python-mistralclient stable/pike: Add --export option to environment-get  https://review.openstack.org/57341919:34
openstackgerritDougal Matthews proposed openstack/python-mistralclient stable/ocata: Add --export option to environment-get  https://review.openstack.org/57342019:34
d0ugalapetrich: Can you take a look at this ASAP tomorrow? https://review.openstack.org/#/c/572136/19:35
d0ugalapetrich: I want to land it before doing the releases19:35
apetrichd0ugal, I can do now if it is urgent19:36
d0ugalapetrich: That is up to you. It can wait, but it is also small - the --force fix.19:36
apetrichd0ugal, oh that's simple19:36
apetrichyeah lgtm19:36
d0ugalapetrich: Thank you!19:37
apetrichnp19:37
d0ugalThat means it should be merged by morning and I can do the release patches first thing :)19:37
apetrichneat19:37
apetrichfixing that is really important to me :(19:37
d0ugalAye, me too. Thankfully it wasn't bad in the end.19:39
openstackgerritDougal Matthews proposed openstack/mistral master: Make cron-triggers not play catchup  https://review.openstack.org/57281319:46
*** toure|biab is now known as toure20:07
*** gkadam has quit IRC20:11
*** d0ugal has quit IRC20:21
openstackgerritMerged openstack/python-mistralclient master: Fix force parameter being always added to URL in execution delete  https://review.openstack.org/57213622:10
*** toure is now known as toure|gone22:15

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!