Friday, 2018-06-08

*** shardy has quit IRC00:41
*** shardy has joined #openstack-mistral00:41
*** thrash is now known as thrash|g0ne01:07
*** AlexeyAbashkin has joined #openstack-mistral05:48
*** Alexey_Abashkin has joined #openstack-mistral05:54
*** opetrenko_ has quit IRC05:54
*** opetrenko_ has joined #openstack-mistral05:55
*** AlexeyAbashkin has quit IRC05:55
*** Alexey_Abashkin is now known as AlexeyAbashkin05:55
*** jaosorior has quit IRC06:58
*** d0ugal has joined #openstack-mistral07:03
*** Alexey_Abashkin has joined #openstack-mistral07:23
*** jistr is now known as jistr|reloc07:25
*** AlexeyAbashkin has quit IRC07:26
*** Alexey_Abashkin is now known as AlexeyAbashkin07:26
d0ugalMorning!07:58
*** shardy has quit IRC07:59
d0ugal#startmeeting mistral08:00
openstackMeeting started Fri Jun  8 08:00:01 2018 UTC and is due to finish in 60 minutes.  The chair is d0ugal. Information about MeetBot at http://wiki.debian.org/MeetBot.08:00
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.08:00
*** openstack changes topic to " (Meeting topic: mistral)"08:00
openstackThe meeting name has been set to 'mistral'08:00
d0ugalWho is around for the Mistral office hour today?  https://etherpad.openstack.org/p/mistral-office-hours08:00
d0ugalrakhmerov, apetrich, bobh, mcdoker181818 ^08:00
d0ugalAs usual, add your IRC nick to line 16 in the etherpad if you want a reminder ping in the future!08:01
*** shardy has joined #openstack-mistral08:01
d0ugalI am going to be proposing the Rocky Milestone 2 releases today.08:03
*** jpich has joined #openstack-mistral08:05
*** gkadam has joined #openstack-mistral08:06
*** AlexeyAbashkin has quit IRC08:06
d0ugaland by today, I mean "now" :)08:10
d0ugalhttps://review.openstack.org/57361008:10
*** shardy has quit IRC08:13
*** jistr|reloc is now known as jistr08:19
therved0ugal: Is it a good time to chat about https://review.openstack.org/572807 ?08:27
d0ugaltherve: Sure08:27
d0ugalI'm just doing milestone 2 administrivia08:28
therved0ugal: https://review.openstack.org/573306 I think is the fix, hopefully that'll be confirmed08:28
therveBut it requires a heatclient release, so I was wondering if we can find a workaround08:28
*** AlexeyAbashkin has joined #openstack-mistral08:28
d0ugalRight08:29
d0ugalDo we know where it is called from?08:29
therveYes, serialization code08:29
d0ugalThat is what I suspected. Got a link to relevant line handy?08:30
therveHum I don't have the full traceback anymore08:30
thervehttps://github.com/openstack/mistral/blob/master/mistral/serialization.py#L106 was the one in mistral I remember08:31
therveThen it got in jsonutils08:31
*** shardy has joined #openstack-mistral08:31
d0ugalRight08:32
d0ugaltherve: I guess a workaround would be for the mistral actions to set loaded=True?08:32
therved0ugal: Hum maybe. Just the get_stack one though08:33
d0ugalRight08:33
d0ugalIt would be a fairly nasty hack, but I don't have any other immediate ideas08:33
therved0ugal: So there is no way in the workflow to operate on the result of the action before it's serialized?08:34
d0ugaltherve: No, I don't think so08:34
therveRight08:35
therveIn which case the client release is probably the best way then08:35
d0ugalYeah08:36
d0ugalI guess my work around in the workflow would be good enough for now?08:36
d0ugalUntil the release I mean08:37
therveI guess08:37
therveIt doesn't prevent the double request08:37
d0ugalWell, it means we have one slow inefficient request :)08:37
d0ugalbut it does mean we store that output in the action execution table in mistral.08:38
openstackgerritMerged openstack/mistral-extra master: fix tox python3 overrides  https://review.openstack.org/57296908:47
openstackgerritMerged openstack/mistral-dashboard master: fix tox python3 overrides  https://review.openstack.org/57296808:52
*** Alexey_Abashkin has joined #openstack-mistral09:00
*** d0ugal_ has joined #openstack-mistral09:00
*** d0ugal has quit IRC09:00
*** d0ugal_ has quit IRC09:00
*** AlexeyAbashkin has quit IRC09:01
*** Alexey_Abashkin is now known as AlexeyAbashkin09:01
*** d0ugal has joined #openstack-mistral09:01
d0ugal#endmeeting09:01
*** openstack changes topic to " (Meeting topic: test)"09:01
openstackMeeting ended Fri Jun  8 09:01:10 2018 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)09:01
openstackMinutes:        http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-06-08-08.00.html09:01
openstackMinutes (text): http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-06-08-08.00.txt09:01
openstackLog:            http://eavesdrop.openstack.org/meetings/mistral/2018/mistral.2018-06-08-08.00.log.html09:01
d0ugalSorry if I missed anything at the end there. My laptop decided it was a good time to turn off.09:01
openstackgerritMerged openstack/python-mistralclient master: fix tox python3 overrides  https://review.openstack.org/57334309:31
openstackgerritDougal Matthews proposed openstack/mistral stable/queens: Register the collect_timing keystone_authtoken option  https://review.openstack.org/57364209:31
*** jaosorior has joined #openstack-mistral09:36
*** thrash|g0ne is now known as thrash10:05
openstackgerritDougal Matthews proposed openstack/mistral-dashboard master: Add the restructuredtext check to the flake8 job  https://review.openstack.org/57318710:30
openstackgerritDougal Matthews proposed openstack/python-mistralclient master: Add the restructuredtext check to the flake8 job  https://review.openstack.org/57319110:32
openstackgerritDougal Matthews proposed openstack/mistral-extra master: Add the restructuredtext check to the flake8 job  https://review.openstack.org/57318910:32
*** shardy has quit IRC10:46
*** shardy has joined #openstack-mistral10:48
openstackgerritDougal Matthews proposed openstack/mistral master: Add missing query paramater `scope` to the workbook api  https://review.openstack.org/55503011:16
*** shardy has quit IRC11:19
*** shardy has joined #openstack-mistral11:20
*** mcdoker1818 has joined #openstack-mistral11:52
*** AlexeyAbashkin has quit IRC11:53
*** AlexeyAbashkin has joined #openstack-mistral11:54
mcdoker1818d0ugal: Hi, why didn't you add the test method to Action interface?11:56
mcdoker1818https://github.com/openstack/mistral/blob/master/mistral/actions/base.py11:56
mcdoker1818https://github.com/openstack/mistral-lib/blob/master/mistral_lib/actions/base.py11:57
*** AlexeyAbashkin has quit IRC12:12
*** AlexeyAbashkin has joined #openstack-mistral12:12
d0ugalmcdoker1818: because it doesn't do anything and isn't used :)12:20
d0ugalbut you can of course add it if you need it for something12:20
d0ugalI wanted to keep it as simple as possible.12:20
openstackgerritKim Bao Long proposed openstack/mistral master: Remove NotImplementedError exception  https://review.openstack.org/57367912:23
*** AlexeyAbashkin has quit IRC12:30
*** AlexeyAbashkin has joined #openstack-mistral12:33
mcdoker1818@d0ugal I want to use this method for stub creation.12:34
mcdoker1818Every test method of action will return stub data. And we have a task property if it equals true then we execute test method but not run.12:34
mcdoker1818We have a workflow with 500 tasks. Every execution of this workflow takes long time and HW12:34
mcdoker1818I think about http servier-stub for openstack or test stub method to make life of a workflow writer easy.12:35
mcdoker1818How do you test a your workflows? Do you always use a real openstack environment12:35
d0ugalmcdoker1818: yes, we test it in a OpenStack environment12:35
d0ugalmcdoker1818: You can still add a test method to your actions if you want it.12:36
d0ugalmcdoker1818: https://review.openstack.org/#/c/553389/12:36
d0ugalI experimented recently by unit testing workflows.12:37
d0ugalIt works, but it is a little messy.12:37
d0ugalAlso, be warned that it uses private Mistral internals - so there is a chance they will change.12:37
*** AlexeyAbashkin has quit IRC12:41
*** AlexeyAbashkin has joined #openstack-mistral12:41
mcdoker1818https://blueprints.launchpad.net/mistral/+spec/mistral-dry-run12:41
mcdoker1818:d0ugal I thought about something like that.12:46
d0ugalI know that blueprint, I think that is why some of the actions have test methods but I don't think it was ever used12:47
d0ugalI don't believe in adding code that isn't used yet :)12:47
mcdoker1818:D12:48
*** ninag has joined #openstack-mistral12:54
*** ninag has quit IRC12:54
*** AlexeyAbashkin has quit IRC12:56
*** AlexeyAbashkin has joined #openstack-mistral12:57
*** d0ugal_ has joined #openstack-mistral13:08
*** d0ugal has quit IRC13:08
*** d0ugal_ has quit IRC13:08
*** d0ugal has joined #openstack-mistral13:08
*** d0ugal has quit IRC13:08
*** d0ugal has joined #openstack-mistral13:08
*** jaosorior has quit IRC13:29
*** mcdoker1818 has quit IRC13:59
*** mmethot_ has joined #openstack-mistral14:17
*** shardy has quit IRC14:18
*** mmethot has quit IRC14:20
*** shardy has joined #openstack-mistral14:21
*** AlexeyAbashkin has quit IRC14:21
*** mmethot_ has quit IRC14:22
*** jistr is now known as jistr|mtg14:28
*** mmethot has joined #openstack-mistral14:51
*** shardy has quit IRC15:02
openstackgerritDougal Matthews proposed openstack/python-mistralclient master: Add --debug to get the full traceback  https://review.openstack.org/57373615:03
d0ugalthrash: ^ trying to figure out that nonetype error.15:03
thrashd0ugal: ack15:03
thrashd0ugal: will watch15:03
d0ugalthrash: the check queue is kinda huge, so it might take a while :)15:06
d0ugalMaybe a result for after your PTO15:06
thrashlol15:07
*** d0ugal has quit IRC15:14
*** jistr|mtg is now known as jistr15:16
*** thrash is now known as thrash|biab15:34
*** jpich has quit IRC16:46
*** jtomasek has quit IRC16:52
*** mcdoker1818 has joined #openstack-mistral17:08
*** gkadam has quit IRC17:11
*** thrash|biab is now known as thrash17:24
*** mcdoker1818 has quit IRC20:52
*** harlowja has joined #openstack-mistral22:30
openstackgerritMerged openstack/mistral stable/queens: Register the collect_timing keystone_authtoken option  https://review.openstack.org/57364222:40
openstackgerritMerged openstack/mistral-lib master: fix tox python3 overrides  https://review.openstack.org/57290922:54
*** mmethot_ has joined #openstack-mistral23:23
*** mmethot has quit IRC23:25
*** mmethot_ has quit IRC23:31

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!