| *** wanghao has joined #openstack-mogan | 00:26 | |
| zhenguo | morning mogan! | 01:02 |
|---|---|---|
| zhenguo | liusheng: hi, please look at this https://review.openstack.org/#/c/471243/ and this https://review.openstack.org/#/c/471236/ | 01:14 |
| liusheng | zhenguo: ok | 01:17 |
| wanghao | morning! | 01:19 |
| wanghao | zhenguo: ping | 01:20 |
| zhenguo | wanghao: pong | 01:20 |
| wanghao | zhenguo: about your comment with specify port_id when creating service | 01:20 |
| wanghao | ports = self._get_available_ports(context, context.project_id, | 01:20 |
| wanghao | port_ids_requested, client) | 01:20 |
| zhenguo | wanghao: you can refer to nova neutronv2 implementation | 01:20 |
| wanghao | zhenguo: this function will check if the ports are existing too I think | 01:21 |
| zhenguo | wanghao: you mean list all ports then check if it exists? | 01:21 |
| wanghao | zhenguo: not all ports, just user speicfied. | 01:22 |
| wanghao | zhenguo: I know your concern, we should add more check about in-use and fixIP | 01:23 |
| wanghao | zhenguo: I just think we didn't need to use show_port one by one. | 01:23 |
| zhenguo | wanghao: yes, I tested it yesterday, currently it can use port which already used by other server | 01:23 |
| zhenguo | wanghao: let me check | 01:24 |
| wanghao | zhenguo: yep, that we should check. | 01:24 |
| wanghao | zhenguo: I just reuse the network checking to check if those ports are existing. | 01:25 |
| zhenguo | wanghao: please look at this https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L1584-L1597 | 01:29 |
| wanghao | zhenguo: yes, I got this | 01:30 |
| wanghao | zhenguo: I mean I didn't use show_port to check existing one by one. | 01:30 |
| wanghao | zhenguo: but I used other logic to check exising. | 01:31 |
| wanghao | zhenguo: I think the purpose is same | 01:31 |
| zhenguo | wanghao: seems it's ok, but not sure if list_ports can show the details | 01:31 |
| wanghao | zhenguo: sure I will check it. | 01:32 |
| zhenguo | wanghao: thanks | 01:32 |
| wanghao | zhenguo: :) np, just let's on same page. | 01:32 |
| wanghao | zhenguo: https://developer.openstack.org/api-ref/networking/v2/?expanded=list-ports-detail | 01:35 |
| wanghao | zhenguo: we can get what we want from list ports | 01:35 |
| zhenguo | wanghao: yes, but if a project has many ports, we should use one API to list all the port details | 01:37 |
| zhenguo | wanghao: and when claiming a server, we may only specify one or two ports, | 01:37 |
| zhenguo | wanghao: not sure which is better | 01:38 |
| wanghao | zhenguo: so I used search_opts to filter ports | 01:38 |
| zhenguo | wanghao: aha, yes, | 01:38 |
| wanghao | zhenguo: indeed, I'm not sure which is better. | 01:39 |
| wanghao | zhenguo: do you think server in mogan may have more than two nics? | 01:39 |
| wanghao | zhenguo: I'm not sure that | 01:40 |
| zhenguo | wanghao: yes, they can have more ports | 01:40 |
| zhenguo | wanghao: if you can specify the port_ids, it's ok to list port details as they are all we needed. | 01:40 |
| wanghao | zhenguo: emm, yes, it's a little depend on how neutron implements the filter ports. | 01:41 |
| zhenguo | wanghao: hah, yes | 01:41 |
| wanghao | zhenguo: if it filters ports in DB layer, that will be greater them show port one by one. | 01:42 |
| wanghao | zhenguo: well, okay, maybe I should ask hanzhang for this question. haha | 01:42 |
| zhenguo | wanghao: hah, yes, we should ask some neutron guys | 01:43 |
| zhenguo | wanghao: in fact, I also want to get some neutron guys to help refactor the network part, but seems hanzhang is busy currently with downstream work | 01:44 |
| wanghao | zhenguo: :) haha yes | 01:47 |
| wanghao | zhenguo: he is very busy now... | 01:47 |
| wanghao | zhenguo: anyway, I just ask hanzhang for this, neutron implement the filtering in db layer. | 01:48 |
| zhenguo | wanghao: hah | 01:48 |
| wanghao | zhenguo: so we can use it safety | 01:48 |
| zhenguo | wanghao: that's cool | 01:49 |
| openstackgerrit | Merged openstack/mogan master: Optimize the link address https://review.openstack.org/471236 | 01:57 |
| openstackgerrit | Merged openstack/mogan master: Fix some typos in Mogan doc https://review.openstack.org/471243 | 01:57 |
| openstackgerrit | wanghao proposed openstack/mogan master: Specify neutron port when creating servers https://review.openstack.org/470824 | 02:06 |
| * zhenguo brb | 02:08 | |
| openstackgerrit | wanghao proposed openstack/mogan master: Specify neutron port when creating servers https://review.openstack.org/470824 | 02:09 |
| *** litao__ has joined #openstack-mogan | 02:16 | |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan-specs master: Node aggregates https://review.openstack.org/470927 | 02:46 |
| zhenguo | liusheng: can you help to check whether this is a tempest error or just need to recheck https://review.openstack.org/#/c/471192/ ? | 02:52 |
| liusheng | zhenguo: let me check | 02:53 |
| zhenguo | liusheng: thanks | 02:54 |
| liusheng | zhenguo: sorry, I have made a mistake broken the tempest gate :( | 03:23 |
| zhenguo | liusheng: but not sure why other patches pass the gate, because they are not rebased? | 03:23 |
| openstackgerrit | liusheng proposed openstack/mogan master: Fix the test_flavor_show tempest test https://review.openstack.org/471565 | 03:24 |
| liusheng | zhenguo: yes, patches will randomly pass the gate... | 03:24 |
| zhenguo | liusheng: hah | 03:24 |
| openstackgerrit | liusheng proposed openstack/mogan master: Fix the test_flavor_show tempest test https://review.openstack.org/471565 | 03:25 |
| zhenguo | liusheng: why that could happen? | 03:28 |
| zhenguo | liusheng: as I understand when you create the flavor, you must know it's public or private | 03:28 |
| liusheng | zhenguo: I use a statement: bool(data_utils.rand_int_id(0, 1)) to randomly generate the value of "is_public". lol | 03:29 |
| liusheng | zhenguo: in preparing resource | 03:30 |
| zhenguo | liusheng: why | 03:30 |
| zhenguo | liusheng: seems that should be two test cases. | 03:30 |
| liusheng | zhenguo: just tried to make the preparaed flavors' is_public has two possible values | 03:31 |
| zhenguo | liusheng: maybe you can just change it to public | 03:31 |
| liusheng | zhenguo:yes, that is ok, you prefer this ? | 03:32 |
| zhenguo | liusheng: and add another case later to test using private flavor | 03:32 |
| liusheng | zhenguo: ok | 03:32 |
| liusheng | zhenguo: I can update the patch | 03:32 |
| zhenguo | liusheng: yes, I would like to add different test cases for that | 03:32 |
| liusheng | zhenguo: ok | 03:32 |
| zhenguo | liusheng: ok, thanks | 03:32 |
| * zhenguo brb | 03:34 | |
| openstackgerrit | liusheng proposed openstack/mogan master: Fix the test_flavor_show tempest test https://review.openstack.org/471565 | 03:43 |
| openstackgerrit | liusheng proposed openstack/mogan master: Add support for scheduler_hints https://review.openstack.org/463534 | 03:49 |
| openstackgerrit | Merged openstack/mogan master: [DOC] Move gmr to Advanced testing and guides section https://review.openstack.org/471192 | 04:04 |
| openstackgerrit | liusheng proposed openstack/mogan master: Fix the test_flavor_show tempest test https://review.openstack.org/471565 | 04:24 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Fix the test_flavor_show tempest test https://review.openstack.org/471565 | 05:05 |
| *** dims has quit IRC | 05:09 | |
| openstackgerrit | Rajat Sharma proposed openstack/mogan master: Use get_rpc_transport instead of get_transport https://review.openstack.org/471587 | 05:23 |
| *** dims has joined #openstack-mogan | 05:41 | |
| *** wanghao_ has joined #openstack-mogan | 06:24 | |
| *** wanghao has quit IRC | 06:25 | |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: [DOC] Add states and transitons diagram https://review.openstack.org/471293 | 06:35 |
| zhenguo | hi all, I added a simple states trasation diagram http://111.20.68.219:7950/docs/states.html , please help to review this https://review.openstack.org/#/c/471293/ | 06:46 |
| openstackgerrit | Merged openstack/mogan master: Fix the test_flavor_show tempest test https://review.openstack.org/471565 | 06:47 |
| openstackgerrit | Rajat Sharma proposed openstack/mogan master: Use get_rpc_transport instead of get_transport https://review.openstack.org/471587 | 07:05 |
| *** wanghao_ has quit IRC | 07:19 | |
| *** wanghao has joined #openstack-mogan | 07:19 | |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: [DOC] Add sample config and policy files to mogan docs https://review.openstack.org/471637 | 08:38 |
| *** wanghao_ has joined #openstack-mogan | 09:02 | |
| *** wanghao has quit IRC | 09:06 | |
| openstackgerrit | liusheng proposed openstack/mogan master: Add support for scheduler_hints https://review.openstack.org/463534 | 09:09 |
| *** wanghao_ has quit IRC | 09:24 | |
| openstackgerrit | Merged openstack/mogan master: Use get_rpc_transport instead of get_transport https://review.openstack.org/471587 | 09:41 |
| zhenguo | liusheng: seems we discussed this before https://bugs.launchpad.net/mogan/+bug/1696378 | 10:05 |
| openstack | Launchpad bug 1696378 in Mogan "Return node uuid with server for admins" [Undecided,New] | 10:05 |
| * zhenguo away | 10:08 | |
| *** litao__ has quit IRC | 11:38 | |
| -openstackstatus- NOTICE: The Gerrit service on review.openstack.org is being restarted now to clear some excessive connection counts while we debug the intermittent request failures reported over the past few minutes | 20:05 | |
| *** RuiChen has quit IRC | 21:29 | |
| *** Kevin_Zheng has quit IRC | 21:29 | |
| *** openstack has joined #openstack-mogan | 23:16 | |
| *** Kevin_Zheng has joined #openstack-mogan | 23:21 | |
| *** RuiChen has joined #openstack-mogan | 23:21 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!