Thursday, 2017-06-08

*** wanghao has joined #openstack-mogan00:31
zhenguomorning mogan!00:58
*** litao__ has joined #openstack-mogan01:19
liushengzhenguo: morning, do we have meeting later ?01:49
zhenguoliusheng: sure01:50
liushengzhenguo: got it01:51
zhenguohi all, please move to #openstack-meeting, the weekly meeting will happen soon!02:00
shaohe_fengzhenguo: morning02:33
*** liusheng has quit IRC02:46
*** liusheng has joined #openstack-mogan02:46
* zhenguo brb02:59
wanghaozhenguo: need to leave for a while,  so you can send me the ironic's report, I will check it out.03:00
zhenguowanghao: ok03:00
wanghaozhenguo: I will write a draft  and we can discuss it afternoon03:01
wanghaozhenguo: thanks03:01
* wanghao leave for a while03:02
*** luyao has quit IRC03:12
*** luyao has joined #openstack-mogan03:13
openstackgerritliusheng proposed openstack/mogan master: DOCS: add documentation about testing
zhenguoliusheng: just talked with liudong, he will prepare the server group bp03:34
liushengzhenguo: cool, thanks liudong03:36
liushengzhenguo: so maybe just leave the scheduler_hints patch to wait liudong's patch, in case I need to do some adjustments03:37
zhenguoliusheng: ok, you can talk with him03:38
zhenguohi all, there are still some bugs open, please feel free to take03:42
openstackgerritZhenguo Niu proposed openstack/mogan-specs master: Node aggregates
zhenguoliusheng: for flavor extra specs, I think we don't need a separated endpoint, how about just patch the flavor?07:06
zhenguoit's really weird of the flavor API, we use put to update the flavor, and patch to update the extra specs but it's not a real patch07:07
liushengzhenguo: yes, I also think so07:12
liushengzhenguo: looks weird07:12
zhenguoliusheng: I find this
zhenguoliusheng: maybe we can just remove the extraspec and access endpoints07:13
zhenguoliusheng: and maybe we can control only return flavor access info to admin?07:15
liushengzhenguo: don't we need a deprecation cycle. lol07:16
liushengzhenguo: just kidding07:16
zhenguoliusheng: hah07:16
zhenguoliusheng: all flavor implementation seems a bit a weird including the object function07:16
liushengzhenguo: I am ok to remove thoese07:16
zhenguoliusheng: need a refactor to all flavor things07:17
* zhenguo brb07:20
liushengzhenguo: yes, maybe we can keep the flavor api more simple07:20
liushengzhenguo: I can abandon the patch if you want to start to refactor the flavor implementation07:21
zhenguoliusheng: I can just get rid of the extra spec endpoint as first patch07:32
liushengzhenguo: ok07:32
zhenguoliusheng: I remember we discussed the node_uuid with server return before07:33
zhenguoliusheng: how about just return it to admin?07:33
liushengzhenguo: control that by policy check ?07:33
zhenguoliusheng: does nova do that based on policy?07:34
zhenguoliusheng: or by the role07:34
zhenguoliusheng: we don't need to return a hash value to normal users like nova, just to admin is enough07:34
liushengzhenguo: ok, I am not sure if there is use cacse that normal users need that info07:35
liushengzhenguo: I am ok07:35
zhenguoliusheng: ok07:36
zhenguoliusheng: another strange thing, why we use rpc_server everywhere in server api, why call it rpc_server instead of db_server?07:56
liushengzhenguo: where we use rpc_server if we can only need to acess db ?07:58
zhenguoliusheng: you can search the server api file, at the beginning of every method, we get a rpc_server07:59
zhenguoliusheng: but in fact, it only call server.get, not sure why named it as rpc_server, not related to rpc07:59
liushengzhenguo: maybe that is just a wrong name of a server08:01
liushengzhenguo: rpc_server = self._resource or self._get_resource(server_uuid)08:01
zhenguoliusheng: hah08:02
zhenguoliusheng: maybe db_server is better08:02
liushengzhenguo: it is not the rpc server08:02
liushengzhenguo: yes08:02
zhenguoliusheng: mind to help clean it up?08:02
liushengzhenguo: my pleasure :D08:02
zhenguoliusheng: thanks, hah08:02
openstackgerritliusheng proposed openstack/mogan master: Rename the rpc_server variable with db_server
zhenguoliusheng: cool08:08
liushengzhenguo: lol08:09
zhenguoliushegn: aha, also find in flavor api file, also contain such rpc_xxx, maybe also in other apis08:10
*** litao__ has quit IRC08:13
*** litao__ has joined #openstack-mogan08:23
zhenguoliusheng, shaohe_feng: please have a look at this when you got time, in fact I alrady updated the document :D08:27
liushengzhenguo: cool!, looks good08:31
openstackgerritZhenguo Niu proposed openstack/mogan master: Use PATCH method for flavor update
zhenguoliusheng: FYI, during the period you were on vacation, I built a ubuntu whole disk image in our lab, you can try to provison a server through mogan with that image.08:51
liushengzhenguo: cool, let me try08:51
zhenguoliusheng: hah08:51
* zhenguo brb08:52
shaohe_fengzhenguo: OK.08:56
zhenguoliusheng, shaohe_feng: please help to do more reviews on specs, in order to not block the following coding work, thanks09:20
liushengzhenguo: ok09:21
openstackgerritZhenguo Niu proposed openstack/mogan master: Use PATCH method for flavor update
openstackgerritliusheng proposed openstack/mogan master: Rename the rpc_server variable with db_server
*** wanghao has quit IRC10:04
*** litao__ has quit IRC11:53
*** harlowja has quit IRC20:08
*** harlowja has joined #openstack-mogan23:57

Generated by 2.15.3 by Marius Gedminas - find it at!