| *** wanghao has joined #openstack-mogan | 00:50 | |
| zhenguo | morning mogan! | 00:56 |
|---|---|---|
| wanghao | morning! | 01:14 |
| *** litao__ has joined #openstack-mogan | 01:15 | |
| openstackgerrit | wanghao proposed openstack/mogan master: Specify neutron port when creating servers https://review.openstack.org/470824 | 01:20 |
| wanghao | zhenguo: ping | 01:20 |
| zhenguo | wanghao: pong | 01:20 |
| wanghao | zhenguo: I updated the description of port_uuid as you commented, but I think it's better to keep the exlustion explain for port_id and network_id | 01:21 |
| wanghao | zhenguo: that make sense to you? | 01:21 |
| zhenguo | wanghao: yes, it should be there, hah | 01:21 |
| wanghao | zhenguo: hah cool | 01:21 |
| zhenguo | wanghao: the patch looks most good, I will test it when my env is ready, thanks for the update! | 01:22 |
| wanghao | zhenguo: sure np. | 01:22 |
| openstackgerrit | wanghao proposed openstack/mogan master: Specify neutron port when creating servers https://review.openstack.org/470824 | 01:24 |
| zhenguo | shaohe_feng: when you are online, please remember to review, we got a long review queue :D | 01:29 |
| * zhenguo really need to get more core reviewers... | 01:30 | |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan-specs master: New flavor for baremetal servers https://review.openstack.org/454113 | 02:20 |
| zhenguo | hi all, please help to review the node aggregates spec: https://review.openstack.org/#/c/470927/4/specs/pike/approved/node-aggregate.rst | 02:22 |
| zhenguo | liusheng: hi, should we add a multi-tenant ironic dvsm gate? | 03:29 |
| liusheng | zhenguo: what does that for ? | 03:30 |
| zhenguo | liusheng: ironic env with networking-generic-switch | 03:31 |
| zhenguo | liusheng: but not sure if we need it or just ironic need test it | 03:31 |
| liusheng | zhenguo: sorry, I don't know much about that :(, but for now, the tempest job can only run in admin context | 03:34 |
| zhenguo | liusheng: hah, that need to be improved | 03:34 |
| liusheng | zhenguo: yes, may need to dig more | 03:35 |
| zhenguo | liusheng: yes, please do it | 03:35 |
| liusheng | zhenguo: ok, will try :D | 03:35 |
| zhenguo | liusheng: thanks | 03:36 |
| zhenguo | liusheng: and I want to change to use ironic attach/detach vif api instead of listing all ports then choose one by ourselves | 03:37 |
| zhenguo | liusheng: but that means we will lose the ability of specifying port_type | 03:37 |
| liusheng | zhenguo: so how about support both ? | 03:39 |
| zhenguo | liusheng: it's hard, as attach/detach vif api doesn't support to pass someting like port | 03:40 |
| zhenguo | liusheng: need to ask ironic support this | 03:41 |
| zhenguo | liusheng: we can discuss this during the meeting to see if there's someone need this feature now or we can wait ironic support it | 03:45 |
| liusheng | zhenguo: yes, we can discuss more | 03:46 |
| zhenguo | liusheng: ok | 03:47 |
| zhenguo | liusheng: and please remember to do more reviews :) | 03:48 |
| liusheng | zhenguo: ok sure, I am just backed from a internal meeting :D | 03:48 |
| zhenguo | liusheng: hah, ok | 03:49 |
| *** wanghao has quit IRC | 06:15 | |
| *** wanghao has joined #openstack-mogan | 06:16 | |
| *** wanghao_ has joined #openstack-mogan | 06:19 | |
| *** wanghao has quit IRC | 06:23 | |
| wanghao_ | zhenguo: ping | 06:37 |
| wanghao_ | zhenguo: some comments for node aggregates | 06:37 |
| zhenguo | wanghao_: thanks | 06:38 |
| wanghao_ | zhenguo: np | 06:38 |
| * zhenguo brb | 06:47 | |
| litao__ | zhenguo: ping | 06:51 |
| *** wanghao_ has quit IRC | 07:13 | |
| *** wanghao has joined #openstack-mogan | 07:14 | |
| zhenguo | litao__: pong | 07:16 |
| zhenguo | liusheng: need your opinion on this https://review.openstack.org/#/c/472157/ | 07:56 |
| liusheng | zhenguo: ok | 07:56 |
| liusheng | zhenguo: is this ok with your new flavor model ? | 07:59 |
| zhenguo | liusheng: yes, only change the extra specs part | 07:59 |
| zhenguo | liusheng: after that landed, I will move extra_specs table to flavor, seems no need to use a new table and object if we don't have a specific api endpoint for it | 08:00 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan-specs master: New flavor for baremetal servers https://review.openstack.org/454113 | 08:02 |
| zhenguo | liusheng: And with the new flavor model, maybe we can just change to use Placement, hah | 08:03 |
| liusheng | zhenguo: ok, got it | 08:04 |
| liusheng | zhenguo: we don's user json_schema to validate the patch data ? | 08:24 |
| liusheng | zhenguo: s/we/shy | 08:24 |
| zhenguo | liusheng: yes, | 08:24 |
| liusheng | zhenguo: why | 08:24 |
| zhenguo | liushegn: as we add a WSME.validator for patch data | 08:24 |
| liusheng | zhenguo: others interfaces all use json_schema | 08:25 |
| liusheng | zhenguo: any particularity of patch data ? | 08:26 |
| zhenguo | liusheng: patch data is a bit different | 08:26 |
| zhenguo | liusheng: we limited the op and which filed can be update | 08:26 |
| zhenguo | liusheng: and as I understand no difference with json schema check and WSME validator | 08:27 |
| liusheng | zhenguo: got it, similar with server's patch api | 08:28 |
| zhenguo | liusheng: yes | 08:28 |
| zhenguo | liusheng: but I find a problem | 08:28 |
| zhenguo | liusheng: we don't have a decorator for json schema check | 08:28 |
| liusheng | zhenguo: where need a decorator for json schema check ? | 08:29 |
| zhenguo | liusheng: I mean instead of explicitly call json_schema_check during every API, seems it's better to add a decorator for that, wdyt? | 08:30 |
| liusheng | zhenguo: maybe not a good idea, we may need to check 1 input parameter of the api method by json schema check. but we cannot ensure which parameter need to be check for every api methods. | 08:33 |
| zhenguo | liusheng: we only add json schema for request body | 08:34 |
| zhenguo | liusheng: but seems not easy to discovery which one is body, alwasy the last one? | 08:34 |
| liusheng | zhenguo: hah, that will add limitation of possible new api interface in the future | 08:35 |
| zhenguo | liusheng: hah, we can leave it as is now | 08:36 |
| liusheng | zhenguo: yes, for your patch, I prefer to agree your opinion | 08:37 |
| zhenguo | liusheng: thanks, I will ping shaohe_feng to see it | 08:37 |
| zhenguo | zhangyang: are you around? | 08:39 |
| zhenguo | zhangyang: do you have a real requirement for specifying port type when claiming a server? I plan to drop it provisionally | 08:40 |
| *** wanghao_ has joined #openstack-mogan | 09:04 | |
| *** wanghao has quit IRC | 09:07 | |
| * zhenguo brb | 09:08 | |
| *** wanghao_ has quit IRC | 09:31 | |
| openstackgerrit | liusheng proposed openstack/mogan master: Tempest: add tests for server states interfaces https://review.openstack.org/473760 | 09:39 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Change to use server metadata instead of extra https://review.openstack.org/473184 | 09:58 |
| *** liujiong has quit IRC | 10:09 | |
| liusheng | zhenguo: I have add a patch about tempest cases of server state APIs | 10:23 |
| liusheng | zhenguo: but seems, the rebuild case cannot pass | 10:23 |
| liusheng | zhenguo: but it can pass in my local env | 10:31 |
| zhenguo | liusheng: let me check, is there some clue in the logs? | 10:53 |
| liusheng | Jun 13 10:14:38.168934 ubuntu-xenial-osic-cloud1-s3500-9283043 ironic-conductor[10423]: ERROR ironic.drivers.modules.agent [-] node 240fc407-b298-44c8-a69d-2fdad8cd6d49 command status errored: {u'message': u'Command execution failed: Unable to stat device /dev/vda1 after attempting to verify 3 times.', u'code': 500, u'type': u'CommandExecutionError', u'details': u'Unable to stat device /dev/vda1 after attempting to verify 3 times.'} | 10:54 |
| liusheng | zhenguo: above error in ironic-conductor's log | 10:54 |
| zhenguo | liusheng: maybe need to recehck to see | 10:55 |
| zhenguo | liusheng: not sure if it's related to us | 10:55 |
| liusheng | zhenguo: ok | 10:55 |
| zhenguo | liusheng: seems all tempest gate failed | 10:55 |
| liusheng | zhenguo: yes, just found that :( | 10:57 |
| zhenguo | liusheng: all failed with the same log | 10:57 |
| liusheng | zhenguo: but that is not same as my patch | 10:57 |
| liusheng | zhenguo: in my patch, it failed because rebuid server failed | 10:58 |
| zhenguo | liusheng: I checked anothe one, is the same as you provided | 10:58 |
| zhenguo | liusheng: in fact, rebuild and create use a same workflow in ironic | 10:58 |
| liusheng | zhenguo: let me check, but in https://review.openstack.org/#/c/472157/, I found it failed in cleanup period | 10:59 |
| zhenguo | liusheng: let's recheck first | 11:00 |
| liusheng | zhenguo: ok | 11:00 |
| liusheng | zhenguo: if the states API patch can merged, we have more job to check the servers action | 11:02 |
| liusheng | zhenguo: :D | 11:02 |
| zhenguo | liusheng: thanks for helping improve this :D | 11:02 |
| liusheng | zhenguo: np | 11:03 |
| zhenguo | liusheng: btw, are you interested in looking into the placement service | 11:03 |
| liusheng | zhenguo: ok, sure, I can try | 11:04 |
| zhenguo | liusheng: thanks | 11:04 |
| zhenguo | liusheng: if it's possible, the node aggregates spec should be changed to be a totally diferent one | 11:05 |
| liusheng | zhenguo: seems your patch remove many flavor functional tests, lol | 11:05 |
| zhenguo | liusheng: hah, yes | 11:05 |
| zhenguo | liusheng: as it removed one api endpoint | 11:05 |
| liusheng | zhenguo: yes, we didn't have many functional tests | 11:06 |
| liusheng | hah | 11:06 |
| zhenguo | liusheng: lol | 11:06 |
| zhenguo | liusheng: I know adding tests is a bit boring, but please focus on that, as we really need it, thanks for sticking on it :D | 11:07 |
| liusheng | zhenguo: sure, no problem :D | 11:10 |
| openstackgerrit | Merged openstack/mogan master: DOCS: add documentation about testing https://review.openstack.org/472028 | 11:19 |
| liusheng | zhenguo: according to the error log, when we delelted a server, the port of the server may still in use and don | 11:41 |
| liusheng | zhenguo: and don't be deleted immediatly | 11:41 |
| liusheng | zhenguo: that will cause the cleanup process failed because temptest try to clean security group | 11:42 |
| zhenguo | liusheng: how do you judge the node already deleted? | 11:42 |
| liusheng | zhenguo: we have disscussed about this, since the deletion api of server is a async call | 11:46 |
| liusheng | zhenguo: Details: {u'message': u'Security Group 44270d21-12d3-490b-be66-d66a13e0da87 in use.', u'detail': u'', u'type': u'SecurityGroupInUse'} | 11:46 |
| zhenguo | liusheng: you check it go to deleted status or removed from db? | 11:46 |
| liusheng | zhenguo: no, just send a server deletion request and check the http status | 11:47 |
| zhenguo | liusheng: that's not the right approach | 11:49 |
| zhenguo | liusheng: I remember we discussed this before | 11:50 |
| zhenguo | liusheng: the deleting API will return immediately | 11:50 |
| liusheng | zhenguo: yes | 11:50 |
| zhenguo | liusheng: you need to check the server notfound | 11:51 |
| liusheng | zhenguo: oh, seems I know the reason | 11:52 |
| zhenguo | liusheng: hah | 11:52 |
| liusheng | zhenguo: I have do some changes to split the test cases | 11:52 |
| zhenguo | liusheng: ok, | 11:52 |
| *** litao__ has quit IRC | 11:55 | |
| * zhenguo away | 12:00 | |
| openstackgerrit | liusheng proposed openstack/mogan master: Ensure the servers deleted completely in tempest's resource_cleanup https://review.openstack.org/473806 | 12:10 |
| *** openstackgerrit has quit IRC | 12:18 | |
| *** openstackgerrit has joined #openstack-mogan | 12:19 | |
| openstackgerrit | Merged openstack/mogan master: Use PATCH method for flavor update https://review.openstack.org/472157 | 12:19 |
| openstackgerrit | Merged openstack/mogan master: Change the missing node_type to resource_class https://review.openstack.org/473327 | 12:59 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!