| *** wanghao has joined #openstack-mogan | 00:24 | |
| *** litao__ has joined #openstack-mogan | 00:52 | |
| *** litao__ has quit IRC | 00:53 | |
| *** litao__ has joined #openstack-mogan | 00:53 | |
| zhenguo | morning mogan | 00:54 |
|---|---|---|
| litao__ | morning mogan | 00:55 |
| liusheng | morning | 00:55 |
| liusheng | zhenguo: the patch https://review.openstack.org/#/c/473806/ to fix the issue, sorry for my fault | 00:55 |
| zhenguo | liusheng: hah, thanks | 00:56 |
| litao__ | zhenguo: I want to add limit and sort functions in list operations, wdyt? | 00:56 |
| zhenguo | litao__: sure, please go ahead | 00:57 |
| litao__ | in BP or Bug? | 00:57 |
| zhenguo | litao__: bug is enough | 00:57 |
| litao__ | OK | 00:57 |
| zhenguo | litao__: not conflict with Xinran's patch to add filters, right? | 00:58 |
| litao__ | maybe a little, but i will rebase it | 00:58 |
| liusheng | zhenguo, litao__ should we need to consider searchlight ? | 00:59 |
| zhenguo | liusheng: if so, it worth a BP :D | 01:00 |
| zhenguo | liusheng, litao__: but not sure if it's easy to integrate with SL, need to add more notifications? | 01:00 |
| liusheng | zhenguo: we don't need to implement filter and pagination/sort functionalities | 01:00 |
| liusheng | zhenguo: yes | 01:00 |
| liusheng | zhenguo: if we consider SL | 01:01 |
| zhenguo | liusheng, litao__: if there's no block for us to integrate with SL, I think that's the right approach | 01:01 |
| * litao__ zhenguo: so you suggest to use SL? | 01:02 | |
| liusheng | Nova have decided to avoid adding more pagination/sort functions | 01:02 |
| litao__ | so you suggest to use SL? | 01:02 |
| litao__ | zhenguo: | 01:02 |
| zhenguo | litao__, liusheng: seems that's the right approach | 01:03 |
| zhenguo | litao__: we got a SL core here, you can ping Kevin_Zheng, if you want to know more about it | 01:04 |
| litao__ | zhenguo: ok, thanks, i will ping him for more details if needed | 01:04 |
| zhenguo | litao__: ok | 01:04 |
| liusheng | also need to let Xinran know this | 01:05 |
| litao__ | so i will summit a BP firstly. | 01:05 |
| zhenguo | litao__: ok | 01:05 |
| liusheng | litao__: maybe need a bp in SL, not in Mogan | 01:05 |
| liusheng | litao__: Mogan just need to add more notification implementations | 01:05 |
| zhenguo | liusheng, litao__: let's wait for Kevin_zheng | 01:06 |
| litao__ | zhenguo: OK | 01:07 |
| zhangyang | zhenguo: sorry the last day i was off, i think we do not have requirement for port type now. | 01:09 |
| zhenguo | zhangyang: ok, thanks for the feedback | 01:09 |
| zhenguo | hi all, I plan to drop port type support provisionally, wdyt? | 01:10 |
| litao__ | agree | 01:13 |
| Kevin_Zheng | what | 01:18 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Change to use server metadata instead of extra https://review.openstack.org/473184 | 01:18 |
| Kevin_Zheng | cannot write plugin in SL for non-official project | 01:19 |
| Kevin_Zheng | but we can do out-of-tree first | 01:19 |
| litao__ | 😬 | 01:20 |
| *** liujiong has joined #openstack-mogan | 01:20 | |
| zhenguo | Kevin_Zheng: you mean add a SL plugin in mogan repo? | 01:20 |
| zhenguo | is there some sample for us | 01:20 |
| liusheng | is the requirement urgent ? | 01:21 |
| Kevin_Zheng | no you could add some private file and a conf | 01:21 |
| Kevin_Zheng | all projects in sl are plugins | 01:21 |
| zhenguo | oh, if so, we can wait to be official, no rush | 01:21 |
| Kevin_Zheng | just files, you add your file and enable it | 01:21 |
| liusheng | Kevin_Zheng: does plugin loaded by stevedore entry points ? | 01:22 |
| litao__ | Kevin_Zheng: Add files in mogan or SL? | 01:22 |
| zhenguo | litao__: SL will not accept non-offical plugin, so it shouldbe in mogan | 01:23 |
| liusheng | zhenguo: maybe not in Mogan, in a independent repo | 01:23 |
| zhenguo | liusheng: that's too complex | 01:23 |
| liusheng | zhenguo: not very complex | 01:23 |
| liusheng | zhenguo: there is a tool to generate basic frame | 01:24 |
| zhenguo | liusheng: you need to add a repo, just for a Sl plugin? | 01:24 |
| liusheng | zhenguo: repo can put in github temporary | 01:24 |
| litao__ | liusheng: need more workload? | 01:25 |
| zhenguo | liusheng: why not just place it in mogan repo like other devstack plugins | 01:25 |
| zhenguo | liusheng: then we copy the files to SL and run when setup devstack env | 01:26 |
| liusheng | zhenguo: just personal thought but, the plugin will be put into SL, not in Mogan, not similar with Mogan | 01:26 |
| liusheng | zhenguo: it is very easy to put it in independent repo | 01:26 |
| liusheng | zhenguo: I am ok to put it in Mogan tree | 01:27 |
| zhenguo | liusheng: I know it's easy, but should that be under openstack namespace | 01:27 |
| zhenguo | liusheng: if not, I think it's a bit odd | 01:27 |
| liusheng | zhenguo: lol, I may think it in Mogan is a bit odd :D | 01:28 |
| zhenguo | liusheng: and I'm not quite sure if we should integrate with SL if it's not accept non-official project now | 01:28 |
| zhenguo | liusheng: maybe integrate with Sl is more odd | 01:28 |
| zhenguo | lol | 01:28 |
| liusheng | so I just asked is this requirement urgent ? | 01:29 |
| zhenguo | liusheng: not sure, if HFBank want to run it in production, maybe list with pagination is required? | 01:30 |
| zhenguo | zhangyang: wdyt? | 01:30 |
| litao__ | zhenguo: I think it is necessary | 01:30 |
| litao__ | zhenguo: in production | 01:30 |
| zhenguo | maybe we can just do it ourselves if it's necessary | 01:31 |
| zhenguo | until we are afficial, wdyt? | 01:31 |
| zhenguo | s/afficial/official | 01:31 |
| litao__ | zhenguo: | 01:33 |
| litao__ | you mean we don't do it currently? | 01:33 |
| zhenguo | litao__: no, I mean we don't need SL currently | 01:33 |
| zhenguo | litao__: just do as your fist proposal | 01:33 |
| litao__ | yes , maybe | 01:35 |
| litao__ | zhenguo: so i will do as traditional method | 01:36 |
| zhenguo | litao__: yes, | 01:36 |
| zhenguo | liusheng: wdyt? | 01:36 |
| liusheng | zhenguo: I may prefer we put effort on other things if the requirement is not urgent :( | 01:37 |
| zhenguo | liusheng: so, let's wait zhangyang or liudong 's feedback to see | 01:38 |
| litao__ | zhenguo: yes | 01:38 |
| liusheng | we have many things need to do, which help to become official project | 01:39 |
| zhenguo | yes, but not everyone full involved in | 01:39 |
| liusheng | hah | 01:39 |
| zhenguo | I think it's hard to control | 01:40 |
| zhenguo | as you may want to do more things, but there's no task, as all task has owners | 01:40 |
| zhenguo | If this happening, please feel free to take over anyone from me, lol | 01:41 |
| liusheng | tests, review, docs, every things make Mogan more like a official project is urgent, hah | 01:42 |
| zhenguo | liusheng: sure | 01:42 |
| zhenguo | https://etherpad.openstack.org/p/MoganWhiteBoard | 01:42 |
| zhenguo | everyone can find more things to do here | 01:42 |
| liusheng | zhenguo: do we have the required items/problems which required to become official project we disscussed ? | 01:45 |
| zhenguo | liusheng: no, | 01:45 |
| liusheng | zhenguo: maybe it is better also to paste it in the etherpad | 01:45 |
| zhenguo | liusheng: not hard requirement, | 01:46 |
| liusheng | zhenguo: last meeting, I remember you have mentioned about 10+ items | 01:46 |
| zhenguo | liusheng: but one big thing is the community don't know what Mogan is, lol | 01:46 |
| liusheng | zhenguo: hah | 01:46 |
| zhenguo | liusheng: that's all help to make others know what we are | 01:47 |
| zhenguo | liusheng: docs, mails, presentations... | 01:47 |
| liusheng | zhenguo: yes, but more than these, we have other things to do help | 01:48 |
| zhenguo | liusheng: and we must follow the 4 opens | 01:48 |
| liusheng | zhenguo: how aobut sending a meeting summary to ML after weekly meeting ? | 01:48 |
| zhenguo | we need to discuss in public more | 01:48 |
| zhenguo | liusheng: yes, wanghao will do that | 01:49 |
| zhenguo | liusheng: not meeting summary, just present our task update | 01:49 |
| zhenguo | to let the community aware what we are doing | 01:49 |
| liusheng | zhenguo: oh, thanks wanghao, I remember that | 01:49 |
| liusheng | zhenguo: yes, really need that | 01:49 |
| zhenguo | liusheng: we will send it weekly after meeting, so please remember to update the ehterpad | 01:50 |
| liusheng | zhenguo: ok | 01:50 |
| zhenguo | liusheng: As we are all in a same TZ, I would like to have a 'review hour' every day, wdyt? | 01:52 |
| liusheng | zhenguo: hah, sounds good | 01:53 |
| zhenguo | liusheng: at least core must attend, and as there are only 3 cores currently, if one is absent, we can't land patch | 01:53 |
| zhenguo | liusheng: need to get more cores | 01:53 |
| zhenguo | liusheng: will discuss during tommorow's meeting | 01:54 |
| liusheng | zhenguo: yes, sure | 01:54 |
| * zhenguo brb | 01:58 | |
| litao__ | : I summited a bug :https://bugs.launchpad.net/devstack/+bug/1692767, maybe we can add unit tests in spare time | 02:00 |
| openstack | Launchpad bug 1692767 in devstack "[devstack] keystone service fails to start after reboot" [Undecided,In progress] - Assigned to Kirill Zaitsev (kzaitsev) | 02:00 |
| * litao__ sorry, the true link is https://bugs.launchpad.net/mogan/+bug/1697813 | 02:02 | |
| openstack | Launchpad bug 1697813 in Mogan "Add unit tests for mgaon" [Undecided,New] | 02:02 |
| wanghao | litao__: cool | 02:08 |
| wanghao | zhenguo: ping | 02:08 |
| wanghao | zhenguo: I see your comments in manage node spec. For image, we can get it directly from driver, but for flavor I think user should specify it since it's a resource in Mogan. | 02:10 |
| openstackgerrit | Merged openstack/mogan master: Tempest: Add tests for keypairs functionalities https://review.openstack.org/473196 | 02:10 |
| zhenguo | wanghao: but how can users know the resource class that the node should be? | 02:12 |
| zhenguo | wanghao: only operators know that, so i think operators need to prepare that, they need to set resource class to the node first, then that node can be managed by mogan | 02:12 |
| zhenguo | litao__: thanks | 02:13 |
| wanghao | zhenguo: yes, for Ironic, that should be in the process of adopting node in Ironic. | 02:13 |
| wanghao | zhenguo: and operators need to create a flavor in Mogan, and user use it to manage node. | 02:14 |
| wanghao | zhenguo: or your idea is Mogan will create the flavor automatically when adopting the node | 02:14 |
| wanghao | ? | 02:14 |
| zhenguo | wanghao: yes, ironic can adopt any nodes, but for mogan, we can keep the process simple | 02:14 |
| wanghao | zhenguo: so in my understand, your way is that user didn't need to care the flavor or image. | 02:15 |
| zhenguo | wanghao: we can only care about what nodes we can manage, if the node resources not associate with a mogan flavor, we can't adopt it. | 02:15 |
| zhenguo | wanghao: yes, I would perfer operators prepare all things before | 02:16 |
| zhenguo | wanghao: but for images, maybe we don't care, if ironic can't provide that information, we can adop it with the server image field empty | 02:16 |
| wanghao | zhenguo: so that means Mogan will check if the existing flavor match the resource class, right? | 02:17 |
| wanghao | zhenguo: yes, that could be | 02:17 |
| zhenguo | wanghao: yes, they can include in the manageable node list, but when we do adopt action, we need to check the flavor | 02:18 |
| wanghao | zhenguo: ok I see, so the rules for manageable node are three: 1. without instance_uuid in Ironic, 2 active stats 3, have resource class | 02:19 |
| zhenguo | wanghao: I think so, need to see others' opinion on that part :D | 02:19 |
| wanghao | zhenguo: cool, | 02:20 |
| zhenguo | wanghao: hah | 02:20 |
| wanghao | zhenguo: basically I think it's fine, since that depend on driver's implemention. | 02:20 |
| wanghao | zhenguo: you can implement it as you want. | 02:20 |
| zhenguo | wanghao: yes, every driver want to support adopting, they need to provide such things | 02:21 |
| wanghao | zhenguo: yes, We can just throw a example in Spec, in fact, I think this spec don't care how driver implement it. | 02:22 |
| zhenguo | wanghao: yes, | 02:22 |
| litao__ | zhenguo: Check flavor is in order to do other operations such as rebuilding after adoption？ | 02:23 |
| wanghao | zhenguo: so the rules will be more flexible for drivrs. | 02:23 |
| zhenguo | litao__: we need a flavor to show the server detail hardware profile | 02:24 |
| wanghao | litao__: maybe, but I think more important thing is to match the service in Mogan and node in Ironic. | 02:24 |
| zhenguo | wanghao: yes, but they must adhere to the rules mogan defined :D | 02:25 |
| wanghao | zhenguo: of course | 02:25 |
| wanghao | zhenguo: not every node could be managed by Mogan. | 02:26 |
| zhenguo | wanghao: yes, we only mange nodes fully prepared by operators | 02:26 |
| wanghao | zhenguo: right | 02:27 |
| zhenguo | wanghao: we need to add a docs for operators later | 02:27 |
| wanghao | zhenguo: exactly | 02:32 |
| wanghao | zhenguo: like Ironic adopt process | 02:32 |
| zhenguo | wanghao: yes | 02:32 |
| litao__ | zhenguo,wanghao:ok | 02:34 |
| wanghao | zhenguo: do you think in adopting API, flavor_uuid is needed? | 02:36 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Remove unneeded *encoding: utf-8* https://review.openstack.org/474028 | 02:36 |
| zhenguo | wanghao: no, it's not needed | 02:36 |
| openstackgerrit | liusheng proposed openstack/mogan master: Ensure the servers deleted completely in tempest's resource_cleanup https://review.openstack.org/473806 | 02:37 |
| openstackgerrit | liusheng proposed openstack/mogan master: Tempest: add tests for server states interfaces https://review.openstack.org/473760 | 02:37 |
| wanghao | zhenguo: since I think is there a problem that may there are many flavors have same resource class | 02:37 |
| zhenguo | wanghao: aha, that's a problem | 02:37 |
| wanghao | zhenguo: yes, you know that Mogan can check the resource class match the flavor when getting the manageable nodes. | 02:38 |
| zhenguo | wanghao: let's think more about whether a flavor should associated more than one resoure class | 02:38 |
| wanghao | zhenguo: but if there are many flavors matched, how Mogan to choose one? | 02:39 |
| zhenguo | wanghao: I think we should limit it as one flavor should be associated with one resouce class | 02:39 |
| zhenguo | wanghao: will update my spec | 02:39 |
| wanghao | zhenguo: but consider this case, same resource class, different extra_specs? | 02:40 |
| zhenguo | wanghao: oh, good point | 02:40 |
| wanghao | zhenguo: since resource class is just a string that operator set it. | 02:40 |
| wanghao | zhenguo: it's very possible. | 02:41 |
| zhenguo | wanghao: yes, I understand | 02:41 |
| zhenguo | wanghao: so please add flavor_uuid back to adopting API :D | 02:41 |
| wanghao | zhenguo: emm, okay | 02:41 |
| zhenguo | wanghao: manageable nodes only provide resouce class instead of flavor uuid | 02:42 |
| wanghao | zhenguo: yes | 02:42 |
| zhenguo | wanghao: users need to choose one flavor with the resouces class, that's the right approach, thanks | 02:42 |
| wanghao | zhenguo: so we need user to decide which flavor you want to use. | 02:42 |
| wanghao | right | 02:42 |
| openstackgerrit | liusheng proposed openstack/mogan master: Tempest: Add test for node listing api https://review.openstack.org/473204 | 02:42 |
| zhenguo | wanghao: ok | 02:42 |
| zhenguo | litao__: hi, I updated this https://review.openstack.org/#/c/473184/ according your comments | 02:45 |
| openstackgerrit | wanghao proposed openstack/mogan-specs master: Manage existing nodes in Mogan https://review.openstack.org/459967 | 02:45 |
| litao__ | zhenguo: great | 02:50 |
| * zhenguo brb | 03:09 | |
| openstackgerrit | liusheng proposed openstack/mogan master: Tempest: add tests for server states interfaces https://review.openstack.org/473760 | 03:12 |
| openstackgerrit | liusheng proposed openstack/mogan master: Rename the rpc_server/rpc_flavor variable with db_server/db_flavor https://review.openstack.org/472133 | 03:29 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Remove unneeded *encoding: utf-8* https://review.openstack.org/474028 | 03:46 |
| shaohe_feng | zhenguo: I'm coming back | 04:32 |
| shaohe_feng | zhenguo: from Shanghai. | 04:32 |
| zhenguo | shaohe_feng: welcome back! | 04:47 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Following up patch of 6673dbb88fd35d8491248fc94bdc6365d352703a https://review.openstack.org/474055 | 04:49 |
| shaohe_feng | zhenguo: thanks. | 05:08 |
| liusheng | zhenguo: same error occured in rebuilding tempest test cases | 06:21 |
| zhenguo | liusheng: you can run it successfully in you local env? | 06:22 |
| liusheng | zhenguo: yes | 06:22 |
| liusheng | zhenguo: Jun 14 03:45:12.825925 ubuntu-xenial-osic-cloud1-s3700-9301861 ironic-conductor[11001]: ERROR ironic.drivers.modules.agent [-] node c471693e-ed12-4ce2-b2ba-b396fa40fb4e command status errored: {u'message': u'Command execution failed: Unable to stat device /dev/vda2 after attempting to verify 3 times.', u'code': 500, u'type': u'CommandExecutionError', u'details': u'Unable to stat device /dev/vda2 after attempting to verify 3 times.'} | 06:23 |
| liusheng | zhenguo: werid error | 06:23 |
| zhenguo | liusheng: I saw this error on my patch yesterday, but recheck fixed it | 06:25 |
| liusheng | zhenguo: really, I only found the error in my patch | 06:25 |
| liusheng | zhenguo: which one ? | 06:25 |
| zhenguo | liusheng: aha, sorry, it's your patch log :D | 06:32 |
| *** shaohe_feng has quit IRC | 07:08 | |
| *** shaohe_feng has joined #openstack-mogan | 07:15 | |
| zhenguo | liusheng: the purpose of flavor.disabled https://github.com/openstack/nova/commit/f371198 | 07:52 |
| liusheng | zhenguo: thanks for the reference, let me take a look | 07:53 |
| liusheng | zhenguo: got it, so maybe we should also add the limitation that dont' allow delete flavor there is server using it ? | 07:57 |
| zhenguo | liusheng: yes, I think so, in this senario, they should disable the flavor | 07:58 |
| liusheng | zhenguo: just asked zhenyu, Nova don't have the api yet, not sure is there any plan | 08:00 |
| zhenguo | liusheng: hah, we can do first | 08:00 |
| liusheng | zhenguo: hah sure | 08:01 |
| zhenguo | liusheng: we provide the ability to disable flavor, then don't allow users delete flavor if it's used, seems the right approach | 08:02 |
| liusheng | zhenguo: not sure, if we need to temporarily skip the rebuilding test case and file a bug, wdyt ? | 08:02 |
| zhenguo | liusheng: yes, but you can keep the patch open | 08:03 |
| liusheng | zhenguo: dont' allow users delete the flavor may shouldn't depend on the disable/enable | 08:03 |
| zhenguo | liusheng: and for rebuilding, the currently implementation is simple, we need to allow specify image and configdrive when rebuilding | 08:03 |
| zhenguo | liusheng: you mean check disabled first before deleting? | 08:04 |
| liusheng | zhenguo: yes, I just wondered why we dont' support specifying a new image in rebuilding lol | 08:04 |
| zhenguo | liusheng: hah | 08:05 |
| zhenguo | liusheng: that need to be improved | 08:05 |
| liusheng | zhenguo: no, maybe when a flavor still in use by a server, we shouldn't delete it. but we can disable it to forbiden being use by new server | 08:06 |
| liusheng | zhenguo: as your reference described, wdyt ? | 08:06 |
| zhenguo | liusheng: for flavors, maybe we can introduce a new 'reference' field, when claiming a server with that, the reference++ and when deleting server we make reference--, and check if reference before deleting flavor | 08:06 |
| zhenguo | liusheng: you mean automatically disable the server if deleting not allowed | 08:07 |
| liusheng | zhenguo: or filter query servers by flavor id before deleting flavor? | 08:07 |
| liusheng | zhenguo: no disable mannually | 08:07 |
| zhenguo | liusheng: query servers may time consuming | 08:08 |
| liusheng | zhenguo: but make logical simple | 08:08 |
| zhenguo | liusheng: how about the 'reference' field proposal | 08:08 |
| liusheng | zhenguo: hmm, I am not sure if we will support "resize". hah | 08:09 |
| zhenguo | liusheng: hah, sure no resize support, but maybe valence can make it possible, not sure | 08:09 |
| liusheng | zhenguo: sure ? the "resize" may not only relate the cpu, ram, disks | 08:10 |
| zhenguo | liusheng: not quite sure | 08:11 |
| liusheng | zhenguo: oh, but seems we cannot support, we also cannot support migration, hah | 08:11 |
| zhenguo | liusheng: after boot from volume supported, maybe we can support migration | 08:11 |
| zhenguo | liusheng: for diskless server | 08:12 |
| liusheng | zhenguo: hah, think too much | 08:12 |
| zhenguo | liusheng: hah | 08:12 |
| zhenguo | liusheng: ironic will support boot from volume soon... | 08:13 |
| liusheng | zhenguo: according to the referece, seems disable operation performed manually | 08:13 |
| liusheng | zhenguo: hope that | 08:13 |
| zhenguo | liusheng: yes, we need admins disable the server themselves | 08:14 |
| zhenguo | liusheng: and if they issue a delete request for a server which used, then just return error | 08:14 |
| liusheng | zhenguo: is this wrong ? | 08:15 |
| zhenguo | liusheng: yes, notallowed, hah | 08:16 |
| zhenguo | liusheng: return forbbiden | 08:16 |
| liusheng | zhenguo: oh, I see | 08:16 |
| zhenguo | liusheng: with error, the flavor is been using by some servers | 08:16 |
| zhenguo | liusheng: and please take a look at this https://review.openstack.org/#/c/474055/ which gets rid of the extra specs table/object | 08:18 |
| zhenguo | liusheng: for all such things we just use one PATCH method, which make things more clear | 08:18 |
| liusheng | zhenguo: yeah, I am looking | 08:18 |
| zhenguo | liusheng: but for flavor access, maybe also need a separated endpoint. | 08:19 |
| liusheng | zhenguo: because the access projects is a list of project ids, right ? | 08:20 |
| zhenguo | liusheng: because we don't show it to users, not like extra specs | 08:21 |
| liusheng | zhenguo: got it | 08:22 |
| openstackgerrit | liusheng proposed openstack/mogan master: Tempest: add tests for server states interfaces https://review.openstack.org/473760 | 08:25 |
| liusheng | zhenguo: I just skip the rebuilding test case ^^ | 08:25 |
| zhenguo | liusheng: cool | 08:26 |
| liusheng | zhenguo: do you still have following patches after the above patch ? | 08:34 |
| zhenguo | liusheng: no, hah | 08:56 |
| liusheng | zhenguo: I have commented | 08:56 |
| zhenguo | liusheng: thanks, will check | 08:57 |
| zhenguo | FYI, we got a presentation selected on OpenStack Days China next month. | 08:58 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Following up patch of 6673dbb88fd35d8491248fc94bdc6365d352703a https://review.openstack.org/474055 | 09:26 |
| zhenguo | liusheng: hi, wrt https://review.openstack.org/#/c/473184/ , IIRC, metadata is a reserved name in DB model, you can help to confirm it | 09:29 |
| liusheng | zhenguo: if so, how about named it server_metadata ? | 09:33 |
| zhenguo | liusheng: you mean change the db field name? | 09:33 |
| zhenguo | liusheng: or change all things to server_metadata | 09:34 |
| zhenguo | liusheng: server.server_metadata seems odd | 09:34 |
| liusheng | zhenguo: hah | 09:34 |
| liusheng | zhenguo: yes, seems, the metadata is a reserved name, it is not blocking | 09:38 |
| liusheng | zhenguo: you can just update others I commented | 09:38 |
| zhenguo | liusheng: ok, thanks, and I think that's the reason why ironic node use extra, hah | 09:38 |
| liusheng | zhenguo: hah | 09:39 |
| liusheng | zhenguo: the description field in your new flavor model also don't allow to be update ? | 09:40 |
| zhenguo | liusheng: I think so, but we can discuss | 09:41 |
| zhenguo | liusheng: we will show the description with deployed server | 09:41 |
| zhenguo | liusheng: if it changed, may make users confusing | 09:41 |
| *** liusheng has quit IRC | 09:42 | |
| *** liusheng has joined #openstack-mogan | 09:42 | |
| liusheng | zhenguo: ok, make sense to me | 09:43 |
| *** wanghao has quit IRC | 09:43 | |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Change to use server metadata instead of extra https://review.openstack.org/473184 | 09:46 |
| zhenguo | Xinran: will you take over luyao's patch https://review.openstack.org/#/c/469766/ ? | 09:47 |
| liusheng | zhenguo: I just given your a little -l for your flavor spec patch :-D | 09:49 |
| zhenguo | liusheng: hah, got it, will check | 09:49 |
| Xinran | zhenguo, yes | 09:49 |
| liusheng | zhenguo: btw, do you know where to get the private key of the keypair of our physical env ? | 09:50 |
| zhenguo | liusheng: I just import my puglic key | 09:51 |
| zhenguo | you can use that keypair directly on our env | 09:51 |
| liusheng | zhenguo: ok got it | 09:51 |
| zhenguo | Xinran: ok, thanks, you can go ahead and drop port_type support | 09:51 |
| *** liujiong has quit IRC | 09:58 | |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan-specs master: New flavor for baremetal servers https://review.openstack.org/454113 | 09:58 |
| * zhenguo away | 10:00 | |
| Xinran | zhenguo, so just call ironic vif_attach/detach is enough? | 10:07 |
| *** litao__ has quit IRC | 12:03 | |
| *** openstackgerrit has quit IRC | 13:18 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!