| *** wanghao has joined #openstack-mogan | 00:40 | |
| *** wanghao has quit IRC | 00:41 | |
| *** wanghao has joined #openstack-mogan | 00:42 | |
| *** shaohe_feng has joined #openstack-mogan | 00:51 | |
| *** litao__ has joined #openstack-mogan | 01:05 | |
| *** zhenguo_ has joined #openstack-mogan | 01:06 | |
| openstackgerrit | Tao Li proposed openstack/python-moganclient master: Add the CLI for managing server https://review.openstack.org/501777 | 01:09 |
|---|---|---|
| openstackgerrit | Tao Li proposed openstack/python-moganclient master: Add the CLI for managing server https://review.openstack.org/501777 | 01:10 |
| *** zhenguo_ is now known as zhenguo | 01:15 | |
| zhenguo | morning mogan! | 01:16 |
| openstackgerrit | Tao Li proposed openstack/python-moganclient master: Add the CLI for managing server https://review.openstack.org/501777 | 01:28 |
| openstackgerrit | liusheng proposed openstack/python-moganclient master: Support to getting managebale servers https://review.openstack.org/499474 | 01:36 |
| openstackgerrit | liusheng proposed openstack/python-moganclient master: Add the CLI for managing server https://review.openstack.org/501777 | 01:36 |
| openstackgerrit | liusheng proposed openstack/python-moganclient master: Add the CLI for managing server https://review.openstack.org/501777 | 01:39 |
| liusheng | zhenguo: hi zhenguo, what format do you like for the network info of manageable servers ? | 01:47 |
| zhenguo | liusheng: not sure, you mean the ports/portgropus? | 01:48 |
| liusheng | zhenguo: yes, currently, it formatted like: 'uuid=935ff2f1-89ca-4d6e-b7ab-286c01dc40bb; neutron_port_id=0c19889a-67f1-443a-85a9-21afcedcfc92; address=52:54:00:01:c6:db' | 01:49 |
| liusheng | zhenguo: looks a bit ugly | 01:49 |
| zhenguo | liusheng: yes | 01:49 |
| zhenguo | liusheng: what do you expect to get from that? | 01:49 |
| liusheng | zhenguo: don't have a good choice :( | 01:50 |
| zhenguo | liusheng: hha, in fact, the API response is not very good now | 01:50 |
| zhenguo | liusheng: the network info should be more generic | 01:50 |
| liusheng | zhenguo: you mean like normal servser's ? | 01:51 |
| zhenguo | liusheng: no | 01:51 |
| zhenguo | liusheng: just for manageable servers for other drivers | 01:51 |
| liusheng | zhenguo: oh | 01:52 |
| zhenguo | liusheng: what we expect to get from a manageable server | 01:52 |
| zhenguo | liusheng: not sure | 01:52 |
| zhenguo | liusheng: seems uuid is useless? | 01:52 |
| zhenguo | liusheng: and we can't get the portgroup informations now, like which port it includes | 01:52 |
| liusheng | zhenguo: yes, all the info is only for showing to admins, when managing server, we don't need any of these infos | 01:53 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Add preserve_on_delete to server nic object https://review.openstack.org/501940 | 01:53 |
| openstackgerrit | Tao Li proposed openstack/python-moganclient master: Add the CLI for managing server https://review.openstack.org/501777 | 01:56 |
| zhenguo | liusheng: maybe at least we can get rid of the port/portgroup uuid | 01:57 |
| liusheng | litao__: please.. don't revert.. | 01:57 |
| litao__ | liusheng: revert what? | 01:58 |
| liusheng | litao__: please comppare with my patchset | 01:58 |
| litao__ | liusheng: I cherry pick your patch | 01:59 |
| liusheng | litao__: no, you revert some thing I changed | 01:59 |
| litao__ | liusheng: I solved the failed unit test cases | 02:00 |
| liusheng | litao__:no.. please seem my comments in your patch | 02:01 |
| litao__ | liusheng: Yes, I have seen your comments | 02:04 |
| litao__ | liusheng: Why not use '--' for node_uuid? | 02:05 |
| liusheng | zhenguo: your patch dependent on wanghao's patch, you shouldn't change something that blong to the dependent patch | 02:05 |
| liusheng | zhenguo: more concise | 02:05 |
| zhenguo | s/zhenguo/litao__ | 02:06 |
| liusheng | zhenguo: why need a --node_uuid, it is redundant | 02:06 |
| liusheng | zhenguo: oh, sorry. litao__ ^^ | 02:06 |
| zhenguo | lol | 02:06 |
| * zhenguo brb | 02:06 | |
| litao__ | liusheng: OK | 02:08 |
| liusheng | litao__: and as a said, the failue in gate for wanghao's patch, it is don't becasue the code of test, I can run successfully with the test in my env, but it cannot pass in gate | 02:10 |
| liusheng | litao__: it is because the formatted network info is from a dict of response. dict in python is unordered. in different env, it may have different order | 02:10 |
| litao__ | liusheng: maybe should change a way to test it | 02:11 |
| liusheng | litao__: we need to change the formatter of the networks info than the current way | 02:11 |
| liusheng | litao__: and the the current looks like: 'uuid=935ff2f1-89ca-4d6e-b7ab-286c01dc40bb; neutron_port_id=0c19889a-67f1-443a-85a9-21afcedcfc92; address=52:54:00:01:c6:db' | 02:12 |
| liusheng | litao__: it looks a bit ugly in "manageable list" command | 02:12 |
| liusheng | litao__: maybe we can shwo oly mac address, not sure if this can meet you requirements ? | 02:13 |
| litao__ | liusheng: I aslo need neutron_port_id | 02:16 |
| litao__ | s/aslo/also/ | 02:16 |
| liusheng | litao__: for what ? | 02:16 |
| litao__ | liusheng: If neutron_port_is is not None, mogan considers the bare metal node to be plugged vif, so I will use it to check mac address in neutron | 02:18 |
| litao__ | liusheng: check the mac address in neutron port and ironic port | 02:20 |
| liusheng | litao__: oh | 02:20 |
| liusheng | litao__: seems for "openstack port list" command you can specify mac address with --mac-address | 02:22 |
| liusheng | litao__: and for "openstack baremetal port list" you can also specify mac address with --address | 02:23 |
| litao__ | liusheng: Yes, so I should check it to ensure its correctness | 02:23 |
| litao__ | liusheng: Because it is input manually | 02:25 |
| liusheng | litao__: maybe, do you have any suggestion of the output of the "manageable server list" ? | 02:26 |
| liusheng | litao__: I have tested, it may be very long of the "port" and "port group" fields, it looks ugly | 02:26 |
| litao__ | liusheng: Maybe we don't use the uuid | 02:28 |
| litao__ | liusheng: currently | 02:28 |
| liusheng | litao__: it depends on you, you are users. hah | 02:29 |
| liusheng | litao__: I can help to drop the "uuid" field and fix the test in wanghao's patch, but you want to do it youself. you'd better to change it in wanghao's patch | 02:32 |
| openstackgerrit | wanghao proposed openstack/python-moganclient master: Support to getting managebale servers https://review.openstack.org/499474 | 02:34 |
| litao__ | liusheng: only drop in mogan client? | 02:34 |
| liusheng | litao__: steps: 1. update your master code; 2. "git review -d" you patch; 3. git rebase -i master, then it will show you a interactive window, you need chenge the "pick" to "edit" in the front of which patch you want to change; 4 modify the code and then type"git rebase --contition" | 02:34 |
| liusheng | litao__: yes | 02:34 |
| wanghao | litao__: liusheng: waite | 02:35 |
| wanghao | litao__: I'm here, what changes you want to do to my patch? | 02:35 |
| liusheng | wanghao: apoligize, I have do some change on you patch, currectly the gate failure is not because the test code, so please wait to change the test code | 02:36 |
| wanghao | liusheng: I saw your change in setup.cfg, that's ok | 02:37 |
| liusheng | wanghao: it is because the formatted network info is from a dict, dict in python is unordered, so the formatted netinfo may be different in different env | 02:37 |
| wanghao | liusheng: yeah, I updated the order in list, | 02:37 |
| liusheng | wanghao: no, it may cannot work, in my env it can pass, but in gate not | 02:38 |
| liusheng | wanghao: that because the output is random | 02:38 |
| liusheng | wanghao: s/random/ different in different envs | 02:38 |
| wanghao | liusheng: emm, I see | 02:38 |
| liusheng | wanghao: you know dict in python is unordered | 02:39 |
| wanghao | yes | 02:39 |
| wanghao | liusheng: maybe need to change a little logic in test code. | 02:39 |
| liusheng | wanghao: and as we disscussed, seems the current way of fomattered network is looks a bit ugly, wdyt ? | 02:40 |
| liusheng | wanghao: maybe change the formatter | 02:40 |
| liusheng | zhenguo: it looks very long in my testing | 02:40 |
| wanghao | liusheng: litao__: you didn't want the uuid | 02:40 |
| wanghao | right? | 02:41 |
| liusheng | wanghao, litao__ you are users, hah | 02:41 |
| wanghao | maybe add some \n will be good, | 02:41 |
| wanghao | but I'm not sure that's a good idea to remove the uuid from the result. | 02:41 |
| litao__ | wanghao: It is not used currently, But i am not sure in the future | 02:42 |
| liusheng | wanghao: if both of you don't need that, I prefer to drop it. seems neutron port uuid is enough | 02:42 |
| wanghao | liusheng: litao__: first of all, this api is NOT only for input of manage existing API. | 02:44 |
| liusheng | wanghao: and a nit, it is better to use manageable_server than "ms" in test name, more explict, and sometimes when we run tests, it may show a list of the tests, the more explict test names is more convenient | 02:44 |
| liusheng | wanghao: yes | 02:44 |
| wanghao | liusheng: litao__: more important, this API will show the users or operators to check what kind of node he will manage. | 02:45 |
| wanghao | so some information maybe is useless in manage server API, but it's usefully for users. | 02:45 |
| wanghao | liusheng: okay | 02:45 |
| wanghao | liusheng: will update it. | 02:45 |
| liusheng | wanghao: but for output of CLI, sometims it is not necessary to show all the things, if user need more info, they can get the full reponse body from api, right ? | 02:46 |
| wanghao | liusheng: yes, so we introduce the '--long' args, isn't? | 02:47 |
| liusheng | wanghao: like Nova, even for "server list --long", it only show the most important info to users | 02:47 |
| liusheng | wanghao: maybe the "--long" is more detailed than without --long, but sometimes, maybe the api response body including huge info | 02:48 |
| liusheng | wanghao: just because I tested in my env, it looks ugly, if you need that to show, I am ok to keep that | 02:50 |
| wanghao | liusheng: I see your point, that's easy to change the code to only show neturon_port_id, but I'm not sure if it's worth we do that. | 02:53 |
| wanghao | liusheng: you know the nova show, it will call nova and neutron API both to show the information to user. | 02:53 |
| wanghao | liusheng: sometime, it depended on what we define the 'important' thing. | 02:54 |
| liusheng | wanghao: yes, hah | 02:54 |
| liusheng | wanghao: if you only want to fix the test failue, you can add a sorted() in the _ports_formatter() method of the port.items() | 02:55 |
| wanghao | liusheng: emm, I want to add \n in string to show better. | 02:56 |
| wanghao | liusheng: and the sorted() too. | 02:56 |
| liusheng | wanghao: ok, it is ok, and you'd also to sort the items | 02:56 |
| liusheng | zhenguo: yes | 02:56 |
| liusheng | wanghao: ^ | 02:56 |
| wanghao | cool | 02:56 |
| litao__ | wanghao,liusheng cool | 02:58 |
| openstackgerrit | wanghao proposed openstack/python-moganclient master: Support to getting managebale servers https://review.openstack.org/499474 | 03:08 |
| litao__ | zhenguo,liusheng ：https://review.openstack.org/#/c/481544/ | 03:24 |
| liusheng | litao__: ok | 03:24 |
| zhenguo | litao__: ok | 03:24 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Return node name with server API object https://review.openstack.org/502379 | 03:24 |
| wanghao | liusheng: ping | 03:27 |
| liusheng | wanghao: pong | 03:27 |
| wanghao | liusheng: did you see this error: ls: cannot access '/var/run/uwsgi/mogan-api-wsgi.socket': No such file or directory | 03:27 |
| wanghao | I can't start the mogan-api under uwsgi mode. | 03:27 |
| wanghao | there is no socket, how to create it? | 03:28 |
| wanghao | I try to restart the apache2, but it didn't work. | 03:28 |
| liusheng | wanghao: if you install with devstack ,it should created that automatically | 03:28 |
| wanghao | liusheng: could I create it by myself | 03:29 |
| wanghao | liusheng: my devstack has some issues | 03:29 |
| liusheng | wanghao: you can try the 2# step in doc/source/installation/configure-mogan-api-uwsgi.rst | 03:30 |
| wanghao | liusheng: great, thanks! | 03:31 |
| liusheng | wanghao: np | 03:32 |
| zhenguo | liusheng: seems we only send notifications of server creation now, right? | 03:39 |
| liusheng | zhenguo: yeah, need to implement more | 03:41 |
| zhenguo | liusheng: seems delete notification should be added as well, and it's easy :D | 03:45 |
| liusheng | zhenguo: yes, they all are similar | 03:45 |
| zhenguo | liusheng: can you please add some before we cutting release, only basic ones are enough | 03:46 |
| liusheng | zhenguo: ok, will try | 03:47 |
| zhenguo | liusheng: thanks | 03:47 |
| liusheng | zhenguo: np | 03:47 |
| zhenguo | liusheng: I find test_create_key_pairs_with_over_quota_limit takes more than 20s | 03:48 |
| zhenguo | liusheng: seems we will create more than 100 keypairs there | 03:48 |
| liusheng | zhenguo: ... so many | 03:48 |
| zhenguo | liusheng: will try to set the quota config option to 1 | 03:49 |
| liusheng | zhenguo: sorry, I have someting and have to go, ttyl | 03:49 |
| zhenguo | liusheng: ok | 03:49 |
| liusheng | zhenguo: maybe set it for tests | 03:49 |
| zhenguo | liusheng: sure | 03:49 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Reduce test_keypair time consuming https://review.openstack.org/502388 | 05:10 |
| *** wanghao_ has joined #openstack-mogan | 05:33 | |
| *** wanghao has quit IRC | 05:34 | |
| openstackgerrit | ShaoHe Feng proposed openstack/mogan master: Doc revise: command create uWSG conf command. https://review.openstack.org/502394 | 06:22 |
| openstackgerrit | wanghao proposed openstack/python-moganclient master: Support to getting managebale servers https://review.openstack.org/499474 | 06:23 |
| shaohe_feng | zhenguo: do we must need uWSGI? | 06:28 |
| zhenguo | shaohe_feng: not a must | 06:40 |
| shaohe_feng | zhenguo: Got it. Thanks. | 06:55 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Return node name with server API object https://review.openstack.org/502379 | 06:55 |
| zhenguo | shaohe_feng: np | 06:56 |
| zhenguo | shaohe_feng: see my replies here https://review.openstack.org/#/c/502021/ | 06:56 |
| openstackgerrit | Merged openstack/mogan master: Doc revise: command create uWSG conf command. https://review.openstack.org/502394 | 07:35 |
| shaohe_feng | zhenguo: do we need change mogan code for GMR support? | 07:43 |
| shaohe_feng | zhenguo: got it. it is a list. | 07:43 |
| zhenguo | shaohe_feng: for GMR seems yes, you can find the initial patch of that | 07:44 |
| shaohe_feng | zhenguo: merge two list, maybe generate duplicated element. | 07:46 |
| shaohe_feng | zhenguo: use "+". | 07:46 |
| zhenguo | shaohe_feng: yes, but for addresses, seems we can ensure there's no collisions | 07:47 |
| shaohe_feng | zhenguo: OK,got it. we can make sure no collisions. | 07:48 |
| zhenguo | shaohe_feng: yes | 07:48 |
| zhenguo | liusheng: I changed to use another way to return node with server https://review.openstack.org/#/c/502379/ | 07:53 |
| liusheng | zhenguo: ok, will check it | 07:54 |
| zhenguo | liusheng: and this https://review.openstack.org/#/c/502388/ , which really reduced the time consuming | 07:56 |
| liusheng | zhenguo: store both uuid and name ? | 07:56 |
| zhenguo | liusheng: yes | 07:56 |
| zhenguo | liusheng: and only expose name to users | 07:56 |
| liusheng | zhenguo: hmm, why don't name it "node_name" if we store both node_uuid and node_name | 07:57 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Check usable portgroups and ports https://review.openstack.org/502410 | 07:57 |
| zhenguo | liusheng: you mean in the API object | 07:58 |
| zhenguo | ? | 07:58 |
| liusheng | zhenguo: seems this look more explict | 07:58 |
| zhenguo | liusheng: it may not name | 07:58 |
| zhenguo | liusheng: depends on driver | 07:58 |
| liusheng | zhenguo: in db and internal logical | 07:58 |
| liusheng | zhenguo: oh | 07:58 |
| zhenguo | liusheng: as we discussed before | 07:58 |
| zhenguo | liusheng: we don't expose node_uuid to users with API | 07:59 |
| liusheng | zhenguo: yes, I aggree that, | 07:59 |
| liusheng | zhenguo: just concern it may improve readability in internal | 08:00 |
| liusheng | zhenguo: code readability | 08:00 |
| zhenguo | liusheng: as we don't return node_uuid, so seems it's ok | 08:00 |
| liusheng | zhenguo: ok | 08:01 |
| * zhenguo brb | 08:05 | |
| openstackgerrit | Merged openstack/mogan master: Reduce test_keypair time consuming https://review.openstack.org/502388 | 08:07 |
| shaohe_feng | zhenguo: I check the initial patch. The commit message is: Guru is a mechanism whereby developers and system administrators can generate a report about the state of a running Zaqar executable. | 08:17 |
| shaohe_feng | zhenguo: I check the initial patch. The commit message is: Guru is a mechanism whereby developers and system administrators can generate a report about the state of a running Zaqar executable. | 08:18 |
| shaohe_feng | zhenguo: So is it only for Zaqar? | 08:18 |
| zhenguo | shaohe_feng: no, seems we copied the Zaqar patch, but it's for mogan | 08:19 |
| shaohe_feng | zhenguo: OK. got it. | 08:19 |
| zhenguo | litao__: for ports and portgroups, you can just keep the current implementation | 08:20 |
| litao__ | zhenguo: OK | 08:20 |
| zhenguo | litao__: and about bind with server, seems we also need to check whether the port already bind with someone | 08:21 |
| zhenguo | litao__: if there's already a device id with the port, how do we handle it, just override? | 08:21 |
| litao__ | zhenguo: Yes, I need to add some check and rollback it when failed | 08:22 |
| zhenguo | litao__: ok, besides that, the patch looks good to me :D | 08:22 |
| litao__ | zhenguo: I think neutron will override it | 08:22 |
| zhenguo | liusheng: you mean bind will override it? | 08:23 |
| litao__ | zhenguo: But need to ensure | 08:23 |
| zhenguo | litao__: yes it will | 08:23 |
| zhenguo | litao__: but just want to clarify, should we just override it | 08:23 |
| litao__ | zhenguo: I check the neutron implementation firstly | 08:23 |
| zhenguo | litao__: ok | 08:23 |
| zhenguo | liusheng: seems with litao__'s patch landed, there will be some problems with our client | 08:24 |
| zhenguo | liusheng: if flavor or image is None, our formatter will raise error | 08:24 |
| litao__ | zhenguo: Yes, my client patch solve this issue | 08:25 |
| *** liusheng has quit IRC | 08:25 | |
| zhenguo | litao__: ok, got it | 08:25 |
| *** liusheng has joined #openstack-mogan | 08:26 | |
| litao__ | zhenguo: neutron will override the device id when we have bond the port | 08:39 |
| zhenguo | litao__: ok | 08:39 |
| litao__ | zhenguo: so we also override it | 08:40 |
| zhenguo | litao__: I think we should | 08:40 |
| litao__ | zhenguo: OK | 08:40 |
| litao__ | zhenguo: If so, we needn't to rollback the binding when some step is failed | 08:43 |
| litao__ | zhenguo: Because it is override | 08:43 |
| zhenguo | litao__: seems it's ok, we can improve later if there's problems with that | 08:44 |
| litao__ | zhenguo: OK | 08:46 |
| zhenguo | litao__: let's try to land it | 08:46 |
| litao__ | zhenguo: sure | 08:50 |
| zhenguo | liusheng: do you have a chance to have a look at this https://review.openstack.org/#/c/502021/ ? | 08:50 |
| liusheng | zhenguo: ok, looking | 08:51 |
| zhenguo | Xinran: see my replies here https://review.openstack.org/#/c/502379/ | 08:52 |
| shaohe_feng | zhenguo: this is ironic doc. https://docs.openstack.org/ironic/pike/configuration/ | 08:53 |
| shaohe_feng | zhenguo: it about config | 08:53 |
| shaohe_feng | zhenguo: it has a Configuration Options link, which describe every options | 08:54 |
| zhenguo | shaohe_feng: yes | 08:54 |
| zhenguo | shaohe_feng: but seems sample config file also include that info | 08:54 |
| shaohe_feng | zhenguo: but I does not find it in our link: http://mogan.readthedocs.io/en/latest/ | 08:54 |
| zhenguo | shaohe_feng: we don't follow along with ironic on that part, lol | 08:55 |
| liusheng | zhenguo: +2+Aed | 08:55 |
| zhenguo | liusheng: thanks | 08:55 |
| zhenguo | shaohe_feng: but you can help to improve it | 08:55 |
| zhenguo | liusheng: our docs is based on which repo now? | 08:56 |
| zhenguo | liusheng: seems I updated the docs last week, but RTD not got updated | 08:56 |
| liusheng | zhenguo: which doc. mogan doc ? | 08:56 |
| zhenguo | liusheng: RTD | 08:57 |
| shaohe_feng | zhenguo: OK. do we also need it? Add it in our task list? | 08:57 |
| liusheng | zhenguo: seems based on your onw repo. hah | 08:57 |
| zhenguo | shaohe_feng: it's simple, not need to add all things there | 08:57 |
| zhenguo | liusheng: oh, let me check and update | 08:57 |
| zhenguo | shaohe_feng: we will only add bps there | 08:58 |
| shaohe_feng | zhenguo: can we generate this doc from our python code? | 08:58 |
| zhenguo | shaohe_feng: yes, | 08:59 |
| zhenguo | shaohe_feng: but you can confirm with ironic docs, not that sure, lol | 08:59 |
| openstackgerrit | Tao Li proposed openstack/mogan master: Manage existing BMs: Part-2 https://review.openstack.org/481544 | 09:04 |
| liusheng | zhenguo: under my account, only python-moganclient is based on the openstack repo | 09:04 |
| zhenguo | liusheng: yes, it's ok | 09:05 |
| liusheng | zhenguo: ok | 09:05 |
| zhenguo | liusheng: our api docs can't based on mogan repo directly | 09:05 |
| liusheng | zhenguo: oh, it is based on your private repo | 09:07 |
| zhenguo | liusheng: yes, and I will sync the private repo with upstrem if needed | 09:07 |
| zhenguo | liusheng: build failed again | 09:10 |
| liusheng | zhenguo: :( | 09:11 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Check usable portgroups and ports https://review.openstack.org/502410 | 09:26 |
| zhenguo | liusheng, shaohe_feng: litao__'s patch seem ok to me, need your reviews | 09:28 |
| liusheng | zhenguo: based on my previous review, it is also ok for me | 09:29 |
| zhenguo | liusheng: hah, let's wait for jenkins opnion | 09:30 |
| liusheng | zhenguo: yeah | 09:30 |
| openstackgerrit | Merged openstack/mogan master: Fix addresses show within one network https://review.openstack.org/502021 | 09:33 |
| *** wanghao_ has quit IRC | 09:34 | |
| zhenguo | liusheng: maybe you can help to update wanghao's patch? | 09:35 |
| liusheng | zhenguo: I just going to do that, hah | 09:35 |
| zhenguo | liusheng: hah | 09:35 |
| zhenguo | shaohe_feng: please look at the latest built docs http://mogan.readthedocs.io/en/latest/ | 09:41 |
| zhenguo | liusheng: after trying to add oslo requirements to my private repo, the RTD built successfully again | 09:41 |
| liusheng | zhenguo: olso_policy ? | 09:41 |
| zhenguo | liusheng: yes | 09:42 |
| zhenguo | liusheng, shaohe_feng: and this https://review.openstack.org/#/c/501940/ needs your review | 09:43 |
| liusheng | zhenguo: do you like dirrectly showing formmatted json in CLI ? | 09:48 |
| liusheng | litao__ ^ | 09:54 |
| liusheng | litao__: any thoughts ? | 09:54 |
| liusheng | an example when listing manageable servers: | 09:55 |
| liusheng | -+-----------------------------------------------------------------+- | 09:55 |
| liusheng | | Ports | | 09:55 |
| liusheng | -+-----------------------------------------------------------------+- | 09:55 |
| liusheng | | [ | | 09:55 |
| liusheng | | { | | 09:55 |
| liusheng | | "neutron_port_id": "37729e38-2498-4fd0-8efd-6c7770a5743e", | | 09:55 |
| liusheng | | "uuid": "a95c5758-5e09-47eb-83e1-f57f94bb2798", | | 09:55 |
| liusheng | | "address": "52:54:00:bc:f0:fe" | | 09:55 |
| liusheng | | }, | | 09:55 |
| liusheng | | { | | 09:55 |
| liusheng | | "neutron_port_id": "b6c127d4-a85d-4748-97a3-d3b179ccdc74", | | 09:55 |
| liusheng | | "uuid": "eab40555-b3aa-47f8-b069-41277477ba78", | | 09:55 |
| liusheng | | "address": "52:54:00:84:88:4c" | | 09:55 |
| liusheng | | } | | 09:55 |
| liusheng | | ] | | 09:55 |
| liusheng | -+-----------------------------------------------------------------+- | 09:55 |
| zhenguo | liusheng: seems ok for now | 09:56 |
| liusheng | zhenguo: maybe this is more explict and not very ugly, hah | 09:56 |
| zhenguo | liusheng: lol | 09:56 |
| zhenguo | liusheng: we can improve later | 09:56 |
| shaohe_feng | it looks well. | 09:56 |
| liusheng | zhenguo: not sure if litao__ and wanghao like this | 09:57 |
| zhenguo | liusheng: maybe also need to change the API side | 09:57 |
| liusheng | zhenguo: it is from API side | 09:57 |
| zhenguo | liusheng: yes, the API side maybe need to be improved | 09:57 |
| shaohe_feng | zhenguo: should we disable_service heat and cinder? | 09:57 |
| zhenguo | shaohe_feng: we don't support that presently | 09:58 |
| liusheng | zhenguo: yes, but for currently response from API, seems no a very pretty way to format to show in CLI | 09:58 |
| zhenguo | liusheng: yes, so just show like that | 09:58 |
| shaohe_feng | zhenguo: OK. the link you send me: https://docs.openstack.org/ironic/latest/contributor/ironic-multitenant-networking.html | 09:58 |
| zhenguo | shaohe_feng: aha, you can combine that with our local.conf sample | 09:59 |
| shaohe_feng | zhenguo: yes. the link disable them. but our doc does not disable them explictly. http://mogan.readthedocs.io/en/latest/contributor/dev-quickstart.html | 09:59 |
| zhenguo | shaohe_feng: please see the ENABLED_SERVICES | 10:00 |
| zhenguo | shaohe_feng: we only enable those services | 10:00 |
| zhenguo | liusheng, shaohe_feng: we should enrich the Installation, Users, and Admins Guide there | 10:01 |
| liusheng | zhenguo: at least for admin guide and installation, I think so | 10:02 |
| zhenguo | yes | 10:02 |
| zhenguo | I added how to build images to Installations guide and how to specify partitions on Users guide | 10:03 |
| zhenguo | for admins, we should add how to use our flavors and aggregaes as well | 10:03 |
| zhenguo | also the affinity zone | 10:03 |
| shaohe_feng | zhenguo: I just wonder what's the default behavior if we do not disable these service explictly? | 10:06 |
| zhenguo | shaohe_feng: it will follow ENABLED_SERVICES | 10:06 |
| shaohe_feng | zhenguo: OK. then we do not need disable them explictly | 10:10 |
| zhenguo | shaohe_feng: yes | 10:11 |
| zhenguo | shaohe_feng: do you find the docs updated? | 10:11 |
| shaohe_feng | zhenguo: which docs? | 10:12 |
| zhenguo | shaohe_feng: I moved the Contributors Guide to the top | 10:12 |
| zhenguo | shaohe_feng: and add a db migrations doc under that section | 10:12 |
| shaohe_feng | zhenguo: let me check | 10:12 |
| openstackgerrit | liusheng proposed openstack/python-moganclient master: Support to getting managebale servers https://review.openstack.org/499474 | 10:14 |
| shaohe_feng | zhenguo: yes, I find a db migrations doc under Contributors Guide | 10:14 |
| shaohe_feng | zhenguo: but the Contributors Guide is not on the top | 10:14 |
| zhenguo | shaohe_feng: oh, under the Instruction, lol | 10:15 |
| shaohe_feng | zhenguo: the order is: Introduction, Installation Guide, User Guide, Administrator Guide, Configuration Guide, Contributor Guide | 10:15 |
| zhenguo | shaohe_feng: Introduction | 10:15 |
| zhenguo | shaohe_feng: not that order, you can refresh your patch | 10:15 |
| shaohe_feng | zhenguo: yes. it under Introduction | 10:16 |
| zhenguo | liusheng, shaohe_feng: please have a look at this https://review.openstack.org/#/c/502410/ | 10:18 |
| shaohe_feng | zhenguo: OK. | 10:20 |
| shaohe_feng | zhenguo: in local config, we create a 3 VMs | 10:22 |
| zhenguo | shaohe_feng: ye | 10:22 |
| shaohe_feng | zhenguo: in really physical evn, should we do some special config? | 10:22 |
| zhenguo | shaohe_feng: devstack is not for physical env | 10:23 |
| zhenguo | shaohe_feng: you need to manually enroll you node afterwards | 10:23 |
| shaohe_feng | zhenguo: got it. | 10:25 |
| openstackgerrit | liusheng proposed openstack/python-moganclient master: Add the CLI for managing server https://review.openstack.org/501777 | 10:26 |
| shaohe_feng | zhenguo: so kolla can help to build a really physical evn? | 10:29 |
| zhenguo | shaohe_feng: I think so | 10:33 |
| liusheng | shaohe_feng, zhenguo please help to review the two server managing client patches | 10:35 |
| zhenguo | liusheng: ok | 10:35 |
| openstackgerrit | Merged openstack/mogan master: Manage existing BMs: Part-2 https://review.openstack.org/481544 | 10:53 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Return node name with server API object https://review.openstack.org/502379 | 11:06 |
| shaohe_feng | zhenguo: about https://review.openstack.org/#/c/502410/2 | 11:16 |
| shaohe_feng | zhenguo: I give a comments. | 11:17 |
| zhenguo | shaohe_feng: thansk | 11:19 |
| zhenguo | shaohe_feng: but I didn't find why | 11:19 |
| zhenguo | shaohe_feng: actually I need t o get whether the portgroup include a port | 11:20 |
| shaohe_feng | zhenguo: let me see. | 11:25 |
| zhenguo | shaohe_feng: please take a look at this https://review.openstack.org/#/c/499474/ , it works as expected on my test | 11:33 |
| shaohe_feng | zhenguo: ok, call you. | 11:36 |
| openstackgerrit | Merged openstack/python-moganclient master: Support to getting managebale servers https://review.openstack.org/499474 | 11:41 |
| *** litao__ has quit IRC | 11:53 | |
| *** harlowja has joined #openstack-mogan | 16:54 | |
| *** wxy_ has joined #openstack-mogan | 20:16 | |
| *** zhangyang_ has joined #openstack-mogan | 20:18 | |
| *** wxy has quit IRC | 20:24 | |
| *** zhangyang has quit IRC | 20:24 | |
| *** zhangyang_ is now known as zhangyang | 20:24 | |
| *** wxy_ is now known as wxy | 20:24 | |
| *** openstackgerrit has quit IRC | 20:48 | |
| *** openstackgerrit has joined #openstack-mogan | 21:21 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/mogan master: Updated from global requirements https://review.openstack.org/502671 | 21:39 |
| *** harlowja has quit IRC | 22:14 | |
| *** harlowja has joined #openstack-mogan | 22:50 | |
| *** harlowja has quit IRC | 23:06 | |
| *** harlowja has joined #openstack-mogan | 23:17 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!