Tuesday, 2017-09-12

*** wanghao has joined #openstack-mogan00:21
*** wanghao has quit IRC00:35
*** wanghao has joined #openstack-mogan00:47
*** litao__ has joined #openstack-mogan01:12
wanghaoliusheng: thanks God sheng to update the client patch,  I'd like the current format of json. thanks!01:25
liushengwanghao: lol, np :D01:25
zhenguoliusheng: why there's no '--' with the node_uuid here https://review.openstack.org/#/c/501777/13/moganclient/osc/v1/manageable_server.py ?01:36
liushengzhenguo: I don't think we need that01:36
zhenguoliusheng: why01:36
liushengzhenguo: why need  ?01:37
zhenguoliusheng: name and uuid are both without --01:37
liushengzhenguo: yes01:37
zhenguoliusheng: is there any other command seems like that?01:37
liushengzhenguo: only them are the main parameter, many commands in openstack CLI like that01:37
zhenguoliusheng: like what?01:38
zhenguoliusheng: but when I use that, seems confused01:38
zhenguoliusheng: not sure which one is name and which one is node01:38
liushengzhenguo: the help message is explict, and it is explict if you only type "openstack baremetalcompute server manage"01:39
zhenguoliusheng: not sure is easy to use01:40
liushengzhenguo: many openstack commands like this, and we save the --node_uuid to make the command more concise01:41
zhenguoliusheng: ok01:42
liushengzhenguo: and because this command only have the two main parameters, description and metadata are optional, I think it is suite to make the command like this01:43
zhenguoliusheng: ok, just keep the current implementation01:45
liushengzhenguo: ok01:46
zhenguoliusheng: seems we forgot to format the addresses for server creation response01:48
zhenguoliusheng: creation could be empty, so no need to format, but managing seems not01:49
liushengzhenguo: seems yes,01:49
zhenguoliusheng: just format it?01:50
zhenguoliusheng: oh, seems hard to format01:50
liushengzhenguo: let me check the managing reponse01:50
zhenguoliusheng: as it may not belongs to neutron01:50
liushengzhenguo: yes01:50
zhenguoliusheng: but if it's not belongs to neutron, we just ignore that, so it's empty, right?01:51
zhenguoliusheng: so seems it's ok to just follow the current addresses formater01:52
liushengzhenguo: may don't, the manage API is a sync call, right ?01:52
zhenguoliusheng: yes01:52
liushengzhenguo: if so, not sure if the reponse will always include the network info01:54
zhenguoliusheng: it's an rpc call, so it alwasy with that01:54
liushengzhenguo: for server creation, because it is a cast method, before creating network, we return it01:54
zhenguoliusheng: no01:54
zhenguoliusheng: for creation, we always don't return the netowrk01:54
liushengzhenguo: yes, I mean in the creating process, we return after sent the cast invoke01:55
zhenguoliusheng: yes01:55
liushengzhenguo: before constructing the network info, right ?01:56
zhenguoliusheng: sure01:56
zhenguoliusheng: but manaing is different01:56
liushengzhenguo: but for manage API, we will return after all the processing01:56
liushengzhenguo: yes01:56
liushengzhenguo: so maybe for managing, it will always return the network info, right ?01:56
zhenguoliusheng: sure01:56
zhenguoliusheng: aren't we just taking about this? hah01:57
liushengzhenguo: hah01:57
zhenguoliusheng: but for managing, if it's not have neutron port, we don't save it01:58
liushengzhenguo: is it possible a server without neutron port after managing ?01:59
zhenguoliusheng: yes01:59
liushengzhenguo: oh, if so01:59
zhenguoliusheng; so the formatter should also take this into account01:59
liushengzhenguo: maybe we don't need to format01:59
zhenguoliusheng: ?]01:59
zhenguoliusheng: you can ignore the formater only if there's no addresses return02:00
liushengzhenguo: oh, got it02:00
zhenguoliusheng: hah02:01
liushengzhenguo: may we need to extract these formatters for common use02:03
zhenguoliusheng: seems yes, at least for addresses formatter02:03
liushengzhenguo: yes, and seems we lack of rebuild command for now, it will also use the formatters02:04
zhenguoliusheng: oh, yes02:04
liushengzhenguo: I can cook another patch for extract all these formatters02:05
zhenguoliusheng: oh02:05
zhenguoliusheng: ok02:05
zhenguoliusheng: so, this one is ready to go?02:05
liushengzhenguo: I think so, up to you, hah02:05
zhenguo liusheng: hah, will +2 that02:06
liushengzhenguo: ok02:06
zhenguoliusheng: you can +A now, lol02:06
liushengzhenguo: ok02:07
zhenguoliusheng: I still have 3 patches not landed yet https://review.openstack.org/#/q/project:openstack/mogan+owner:self+status:open02:08
zhenguoliusheng: please have a look when you got time02:08
zhenguoliusheng: then we can prepare the release02:08
liushengzhenguo: oh, sorry, will review now02:08
zhenguoliusheng: thanks02:08
openstackgerritMerged openstack/python-moganclient master: Add the CLI for managing server  https://review.openstack.org/50177702:11
openstackgerritMerged openstack/mogan master: Updated from global requirements  https://review.openstack.org/50267102:15
litao__liusheng: Thanks for merging and update the patch, cool02:34
liushenglitao__: np :)02:35
zhenguoliusheng: seems we can't create stable/pike02:40
zhenguoliusheng: but a release under queens02:40
liushengzhenguo: hmm, what's your way ?02:41
zhenguoliusheng: like this https://review.openstack.org/#/c/498479/02:41
liushengzhenguo: can we non-official project use releases repo to release ?02:42
zhenguoliusheng: seems yes02:42
liushengzhenguo: not sure, if so maybe we miss the deadline of Pike :(02:42
zhenguoliusheng: yes02:42
liushengzhenguo: :(02:43
zhenguoliusheng: anyway, it's ok, we can just tag a 0.1.0 under queens02:43
liushengzhenguo: hah, that is ok02:44
zhenguoliusheng: https://github.com/openstack/sushy02:45
zhenguoliusheng: it's not an official project02:45
liushengzhenguo: seems we cannot create the main version, but the small version is ok02:45
zhenguoliusheng: yes02:45
liushengzhenguo: oh02:45
zhenguoliusheng: but you can find sushy under openstack/releases02:46
zhenguoliusheng: I will put a patch to add mogan and moganclient02:46
zhenguoliusheng: then we can release02:46
liushengzhenguo: ok, cool02:46
zhenguoliusheng: let me try to see if we can add there02:46
zhenguoliusheng: but under queens02:47
liushengzhenguo: you need to add the user openstackci as a maintainer of the pypi repo02:47
zhenguoliusheng: yes02:47
zhenguoliusheng: it's a must when you create project under openstack02:47
liushengzhenguo: oh02:48
openstackgerritMerged openstack/mogan master: Check usable portgroups and ports  https://review.openstack.org/50241002:48
zhenguoliusheng: another way, we can release under _independent instead of pike, queens, ...02:56
openstackgerritMerged openstack/mogan master: Add preserve_on_delete to server nic object  https://review.openstack.org/50194002:56
zhenguoshaohe_feng: please have a look at this https://review.openstack.org/#/c/502379/ when you are online02:57
liushengzhenguo: that seems for the independent release project, a project with independent release tag02:57
zhenguoliusheng: yes02:58
liushengzhenguo: but we are not independent release project02:58
zhenguoliusheng: but seems we'd better not independent, hah02:58
liushengzhenguo: yes02:58
zhenguoliusheng: so we wil underneath queens02:58
zhenguoliusheng: seems you can +A this https://review.openstack.org/#/c/502741/02:59
liushengzhenguo: done03:00
liushengzhenguo: hah03:00
zhenguoliusheng; hah03:00
liushengzhenguo: I think  it is ok03:00
zhenguoliusheng: ok03:01
openstackgerritMerged openstack/python-moganclient master: Updated from global requirements  https://review.openstack.org/50274103:06
zhenguoliusheng: do we need to build a release notes link on RTD?03:10
liushengzhenguo: does other projects do this ?03:10
zhenguoliusheng: not sure03:12
zhenguoliusheng: official projects do03:12
liushengzhenguo: not sure if it can work with RTD03:12
zhenguoliusheng: lol03:12
zhenguoliusheng: don't be afraid of RTD03:13
liushengzhenguo: hah03:13
zhenguoliusheng: let me try03:13
liushengzhenguo: ok03:14
zhenguoliusheng: http://mogan.readthedocs.io/projects/releasenotes/en/latest/unreleased.html03:23
liushengzhenguo: cool03:23
openstackgerritliusheng proposed openstack/python-moganclient master: Extract the formatter methods as common utils  https://review.openstack.org/50288403:47
openstackgerritMerged openstack/mogan master: Return node name with server API object  https://review.openstack.org/50237904:26
openstackgerritZhenguo Niu proposed openstack/mogan master: Set server node for managed servers  https://review.openstack.org/50289005:42
zhenguoliusheng: seems we can't use relesenotes as we will not create a branch06:20
liushengzhenguo: oh, maybe it combine with a release06:21
zhenguoliusheng: yes06:21
zhenguoliusheng: https://github.com/openstack/ironic/blob/master/releasenotes/source/pike.rst06:21
zhenguoliusheng: we will just tag the current branch06:21
zhenguoliusheng: seems zun also don't have a releasenotes yet https://github.com/openstack/zun/tree/master/releasenotes/notes06:26
liushengzhenguo: hah, they are already official06:26
zhenguoliusheng: yes06:26
liushengzhenguo: I think we have do better than many official projects06:27
zhenguoliusheng: lol06:27
liushengzhenguo: many official projects are inactive and may don't have enriched features. hah06:28
zhenguoliusheng: but releasenotes seems used to track the current release stuff(pike, queens, ...)06:29
zhenguoliusheng: we don't have such a release06:29
liushengzhenguo: even 0.1.0 cannot ?06:30
zhenguoliusheng: you mean tag?06:30
liushengzhenguo: yes06:30
zhenguoliusheng: no06:30
liushengzhenguo: :(06:30
zhenguoliusheng: release project will help to create the specific branch's source file06:30
zhenguoliusheng: we don't have any branch06:31
liushengzhenguo: can we just add a branch ?06:31
zhenguoliusheng: how06:31
liushengzhenguo: oh, maybe we can only create branch by change in releases repo ..06:33
zhenguoliusheng: you can't06:33
liushengzhenguo: cannot propose change in stable/pike of releases repo, right ?06:34
zhenguoliusheng: seems yes, you can check the patch comments I sent yu06:34
zhenguoliusheng: this one https://review.openstack.org/#/c/498479/06:35
zhenguoliusheng: check ttx's comments06:35
liushengzhenguo: oh, unless we are  cycle-with-intermediary06:36
zhenguoliusheng: tag seems enough for us06:37
zhenguoliusheng: do we really need a branch?06:37
wanghaoliusheng: ping06:38
liushengzhenguo: not sure, but maybe we need a release, that users can use mogan in pypi06:38
zhenguoliusheng: yes, tag will cause a release06:38
zhenguoliusheng: which like a stacit branch06:39
wanghaoliusheng: I found we should update the doc of uwsgi06:39
wanghaoOn deb-based systems copy or symlink the file ``apache-mogan.template`` to06:39
wanghao   ``/etc/apache2/sites-available/mogan.conf``. For rpm-based systems the file06:39
wanghao   should go into ``/etc/httpd/conf.d/mogan.conf``.06:39
zhenguoliusheng: branch will go on but tag  won't, that's the difference06:39
wanghaoliusheng: I saw now it should be mogan-api-wsgi.conf, right?06:40
liushengwanghao: actually, I think the name is unrelated06:41
liushengwanghao: maybe in productive  deployment, the name of file may be not like devstack env06:43
wanghaoliusheng: yes, I see, but I feel mogan-api-wsgi.conf is more clear.06:43
* zhenguo brb06:44
wanghaoliusheng: anyway, it is fine too,  but I found another bug: tee/etc/tmpfiles.d/uwsgi.conf06:45
liushengwanghao: not sure, but I may prefer mogan.conf is more like in productive usages. current the mogan-api-wsgi.conf is just set by devstack scripts06:45
wanghaothere is no blank between tee and /etc/...06:45
wanghao: )06:45
liushengwanghao: hah, it has been fixed by shaohe06:45
liushengwanghao: you can check the latest code06:45
wanghaoliusheng: : ) cool06:45
shaohe_fengzhenguo: sorry, just online.06:55
zhenguoshaohe_feng: please take a look at this https://review.openstack.org/#/c/502884/07:02
zhenguoliusheng, shaohe_feng, wanghao, litao__, Xinran: seems we can only create a release under queens, a tag instead of a branch07:05
zhenguoregarding the releasenotes, do you have suggestions, should be under queens07:07
*** kong has quit IRC07:08
openstackgerritliusheng proposed openstack/mogan master: Add more notifications for server create/delete  https://review.openstack.org/50289807:08
shaohe_fengzhenguo: in really physical evn, should I config the dell swith plugin for neturon07:08
zhenguoshaohe_feng: no07:08
zhenguoshaohe_feng: enable networking-generic-switch07:09
zhenguoliusheng: anyway, I can build a releasenotes for 0.1.0 like this http://mogan.readthedocs.io/projects/releasenotes/en/latest/unreleased.html07:12
liushengzhenguo: that looks cool07:13
zhenguoliusheng: ok07:13
liushengzhenguo: it is 0.0.0, hah07:13
zhenguoliusheng: we need to manually create a 0.1.0 under private repo07:13
liushengzhenguo: oh, yes07:14
openstackgerritMerged openstack/python-moganclient master: Extract the formatter methods as common utils  https://review.openstack.org/50288407:14
zhenguoliusheng: in fact, release project will help to create that07:14
zhenguoliusheng: but we can't leverage that07:14
liushengzhenguo: yes07:14
zhenguoliusheng: as we missed the time for Pike07:14
openstackgerritliusheng proposed openstack/mogan master: Add more notifications for server create/delete  https://review.openstack.org/50289807:14
zhenguoliusheng: is therea delete error notification?07:15
liushengzhenguo: just checked nova, there isn't07:15
zhenguoliusheng; oh07:15
liushengzhenguo: I was thinking that maybe we need to enrich the notification payload for the different actions, we only include basic server info now07:16
zhenguoliusheng: seems yes07:17
liushengzhenguo: ok, in nova, the nofication payload almost includes all the info of server07:17
zhenguoliusheng: yes please follow that, lol07:17
liushengzhenguo: ok07:18
zhenguoliusheng: should we mark managed server nics as preserve_on_delete?07:20
liushengzhenguo: after managing, it is a normal server, user may delete the server and release the node for reuse, maybe it is better don't, otherwise, users need to clean the ports, right ?07:22
liushengzhenguo: maybe ask wanghao and litao, not sure, hah07:22
zhenguoliusheng: seems yes, wanghao, litao__, do you have concerns if I remove the ports for managed server when deleting it07:23
wanghaozhenguo: you mean delete a managed server, right07:26
zhenguowanghao: yes07:26
wanghaozhenguo: if you want to delete it, I think you should clean the ports like other servers.07:26
zhenguowanghao: yes07:26
wanghaozhenguo: since we will introduce another feature, unmanage server,  that will not remove the ports.07:27
wanghaoin Queens.07:27
zhenguowanghao: hah, ok07:27
zhenguowanghao: btw, we can't create branch for pike07:27
zhenguowanghao: our first release will under queens07:28
wanghaozhenguo: ....07:28
wanghaozhenguo: why can't create branch?07:28
zhenguowangaho: as pike was released :(07:28
zhenguowanghao: they don't accept us to create a release under pike now07:29
zhenguowanghao: but anyway, a release under queens also ok07:29
wanghaozhenguo: emm, that's okay07:29
wanghaozhenguo: at least we know that what time we should create a release now... hahhaha07:30
zhenguowanghao: lol07:30
zhenguowanghao: but we need to handle the releasenotes ourselves07:30
zhenguowanghao: release project will not help to create a releasentoes until we cut queens07:31
wanghaozhenguo: you mean we need create a pike releasenote by ourselves now?07:33
zhenguowanghao: not pike07:33
zhenguowanghao: but 0.1.007:33
zhenguowanghao: not sure if that07:34
zhenguowanghao: like this http://mogan.readthedocs.io/projects/releasenotes/en/latest/unreleased.html#new-features07:34
zhenguowanghao: when we announce the first release with this07:34
wanghaozhenguo: this page is made from our releasenotes automatically. right?07:37
openstackgerritZhenguo Niu proposed openstack/mogan master: Following up patch of 26508fd131bdfacbe4e2ed20fa636d19a8d00e88  https://review.openstack.org/50289007:37
shaohe_fengzhenguo: who determine to create the branch?07:37
shaohe_fengzhenguo: Our code is on github.07:38
shaohe_fengzhenguo: Why cat not create a branch.07:39
zhenguowanghao: no, I build it manually07:43
zhenguowanghao: by leveraging readthedocs07:44
zhenguoshaohe_feng: openstack07:44
zhenguoshaohe_feng: in fact, we are not the owner of the repo07:44
zhenguoliusheng, shaohe_feng, wanghao: this https://review.openstack.org/#/c/502890/ is the last thing I want to clean up before we cutting release07:45
litao__zhenguo: Yes, I agree to delete network , and unmanage doesn't remove network07:46
zhenguolitao__: ok, already update the patch07:46
zhenguoliusheng, wanghao: I will update the releasenotes to only include features that cant't get from current openstack ecosystem, wdyt?08:03
wanghaozhenguo: emmmm,  this sounds not like other project did.08:05
zhenguoliusheng, wanghao: yes08:05
zhenguowanghao: we are not real release08:05
wanghaozhenguo: or  we can split those releasenotes to two parts.08:05
liushengzhenguo: why don't just like current ?08:06
zhenguowanghao: as I understand we just want to highlight the advanced features08:06
liushengzhenguo: it looks good for me, hah08:06
zhenguoliusheng: as there would be more08:06
liushengzhenguo: any problem if more ?08:06
wanghaozhenguo: one: feature only we have,  two: other import features that means mogan has grow up.08:06
zhenguowanghao: but we can't, there's no such approach08:06
zhenguoliusheng: no body want to read that more08:07
wanghaozhenguo: we can edit our releasenotes in code tree.08:07
zhenguoliusheng, wanghao: we really done many things with the first release08:07
liushengzhenguo: oh, currently, the release notes only can be classfy by branch, right ?08:07
zhenguowanghao; there's no that tree08:08
zhenguowanghao: that's done by openstack/release08:08
liushengzhenguo: indeed08:08
zhenguoliusheng: yes08:08
zhenguoliusheng, wanghao: I don't want to show what openstack can provide in our release notes08:08
zhenguoliusheng, wanghao: I mean only for this release08:09
wanghaozhenguo: a,  I see,  we must make a releasenotes by ourself using readthdocs08:09
zhenguoliusheng, wanghao: we can follow others from queens08:09
zhenguowanghao: yes08:09
liushengzhenguo: ok08:09
wanghaozhenguo: that's fair, sure08:09
zhenguook, so just highligh some advanced features08:10
liushengzhenguo: yes08:10
zhenguoand from next cycle, we need to be add releasenotes like other projects08:10
zhenguofirst release always hard, hah08:10
wanghaozhenguo: if we can follow the branch,  we just need to add releasenotes in our code tree. right?08:28
wanghaoopenstack/release  will create the releasenotes for every projects according the releasenotes docs.08:28
zhenguowanghao: yes08:28
wanghaozhenguo: okay08:29
zhenguowanghao: next release will leverage that08:29
openstackgerritMerged openstack/mogan master: Following up patch of 26508fd131bdfacbe4e2ed20fa636d19a8d00e88  https://review.openstack.org/50289008:57
zhenguoliusheng: anything more want to be added with the notifications patch?09:01
liushengzhenguo: just want to make the notification payload including more info, like nics09:03
zhenguoliusheng: ok09:04
liushengzhenguo: sorry, need to attend zhuli's pre-defence09:04
* liusheng brb09:04
zhenguoliusheng: ok09:04
openstackgerritZhenguo Niu proposed openstack/mogan master: Update release notes  https://review.openstack.org/50292409:06
shaohe_fengzhenguo: This releas note is the last patch of this release?09:08
zhenguoshaohe_feng: for our 0.1.009:19
*** wanghao has quit IRC09:32
*** wanghao has joined #openstack-mogan09:32
openstackgerritZhenguo Niu proposed openstack/mogan master: Correct typos on docs  https://review.openstack.org/50293109:33
*** wanghao has quit IRC09:33
*** wanghao has joined #openstack-mogan09:33
*** wanghao has quit IRC09:34
*** wanghao has joined #openstack-mogan09:34
*** wanghao has quit IRC09:34
*** wanghao has joined #openstack-mogan09:35
*** wanghao has quit IRC09:35
*** wanghao has joined #openstack-mogan09:36
*** wanghao has quit IRC09:36
*** wanghao has joined #openstack-mogan09:36
*** wanghao has quit IRC09:37
*** wanghao has joined #openstack-mogan09:37
*** wanghao has quit IRC09:38
*** wanghao has joined #openstack-mogan09:38
openstackgerritZhenguo Niu proposed openstack/mogan master: [DOC] Add flavor manage and customize instructions  https://review.openstack.org/50295911:26
zhenguoliusheng: can we change the 'list availabiliy zone' column name?11:47
zhenguoliusheng: it's 'availability_zone' now11:47
zhenguoliusheng: maybe something like 'Zone Name' ?11:48
*** litao__ has quit IRC11:51
liushengzhenguo: sonds good11:53
*** Kevin_Zheng has joined #openstack-mogan15:30
*** wanghao has quit IRC16:35
*** Kevin_Zheng has quit IRC18:59
*** kong has joined #openstack-mogan23:33

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!