| *** wanghao has joined #openstack-mogan | 00:36 | |
| *** Kevin_Zheng has quit IRC | 00:47 | |
| *** litao__ has joined #openstack-mogan | 00:50 | |
| *** wanghao has quit IRC | 00:50 | |
| *** wanghao has joined #openstack-mogan | 01:00 | |
| openstackgerrit | liusheng proposed openstack/mogan master: Add more notifications for server create/delete https://review.openstack.org/502898 | 01:23 |
|---|---|---|
| openstackgerrit | liusheng proposed openstack/mogan master: Enrich the payload of notifications of server creation https://review.openstack.org/503550 | 01:23 |
| zhenguo | morning mogan! | 01:29 |
| zhenguo | liusheng, shaohe_feng, wanghao, litao__, Xinran: I would like to cancel the weekly meeting today, do you have something want to discuss? | 01:33 |
| litao__ | zhenguo: no | 01:34 |
| liusheng | zhenguo: no special thing | 01:34 |
| zhenguo | ok | 01:35 |
| zhenguo | liusheng: when attaching/detaching interfaces on client side, should it be add/remove port or interface? | 01:49 |
| liusheng | zhenguo: with net-id specified ? | 01:50 |
| zhenguo | liusheng: no, I mean the CLI name | 01:50 |
| liusheng | zhenguo: oh, you want to use attach/detach ? | 01:52 |
| zhenguo | liusheng: no, we use server add/remove interface now | 01:54 |
| zhenguo | liusheng: but seems no use server add/remove port | 01:54 |
| liusheng | zhenguo: port seems better | 01:55 |
| openstackgerrit | liusheng proposed openstack/mogan master: Add more notifications for server create/delete https://review.openstack.org/502898 | 01:58 |
| openstackgerrit | liusheng proposed openstack/mogan master: Enrich the payload of notifications of server creation https://review.openstack.org/503550 | 01:58 |
| openstackgerrit | liusheng proposed openstack/mogan master: Add more notifications for server create/delete https://review.openstack.org/502898 | 01:59 |
| wanghao | zhenguo: no special thing, I'm preparing to add some new releasenotes in our code tree. | 02:02 |
| zhenguo | wanghao: there's a patch up to cleanup the releasenotes https://review.openstack.org/#/c/502924/ | 02:03 |
| wanghao | zhenguo: I see | 02:05 |
| wanghao | zhenguo: I was thought we didn't need to delete our releasenotes from tree, just change the readthedocs. | 02:06 |
| wanghao | zhenguo: Now seems readthedocs is based on those releasenotes too, right? | 02:06 |
| zhenguo | wanghao: that will included in queens release notes | 02:06 |
| zhenguo | wanghao: based on our repo | 02:07 |
| wanghao | zhenguo: could we move them to another folder, not delete them? | 02:07 |
| zhenguo | wanghao: I dont' like to add that more release notes | 02:08 |
| zhenguo | wanghao: as openstack already can provide that | 02:08 |
| zhenguo | wanghao: seems we do many duplicated things | 02:08 |
| wanghao | zhenguo: didn't catch that, OpenStack make the release notes based on those releasenotes from every project, right? | 02:09 |
| zhenguo | wanghao: official project | 02:10 |
| zhenguo | wanghao: and for a long time there's no any releasentoes | 02:10 |
| zhenguo | wanghao: they just focus on the current release, and don't add the before things | 02:10 |
| zhenguo | wanghao: we will be under queens, as we are way past the pike :( | 02:11 |
| wanghao | zhenguo: so you mean now we just add some important features for 0.1.0 release. | 02:12 |
| zhenguo | wanghao: yes, and during queens cycle, we can follow others | 02:12 |
| wanghao | zhenguo: and we can add more new releasenotes in queens cycle. | 02:13 |
| zhenguo | wangaho: yes | 02:13 |
| zhenguo | wanghao: yes, with new features | 02:13 |
| zhenguo | wanghao: and you can help to remind others to add releasenotes with their patch | 02:13 |
| wanghao | zhenguo: sure | 02:14 |
| zhenguo | wanghao: thanks | 02:14 |
| zhenguo | wanghao: please do more reviews if you got time, as someone mentioned that core candidates must got enough reviews as much as core reviewers during a period, and must be continuous. | 02:32 |
| zhenguo | wanghao: I think you should be able to :D | 02:32 |
| openstackgerrit | Merged openstack/python-moganclient master: Updated from global requirements https://review.openstack.org/503669 | 02:32 |
| wanghao | zhenguo: haha, thanks. | 02:33 |
| wanghao | zhenguo: I will try my best. | 02:34 |
| zhenguo | wanghao: hah | 02:34 |
| openstackgerrit | liusheng proposed openstack/mogan master: Add more notifications for server create/delete https://review.openstack.org/502898 | 02:37 |
| openstackgerrit | Zhenguo Niu proposed openstack/python-moganclient master: Replace interface with port for attaching/detaching interfaces https://review.openstack.org/503894 | 02:40 |
| zhenguo | liusheng: I just replace the add/remove interface command name above | 02:42 |
| liusheng | zhenguo: ok | 02:42 |
| zhenguo | liusheng: how about making a release for client today and mogan tomorrow? | 02:51 |
| liusheng | zhenguo: it is ok, I am going to add rebuild support today | 02:52 |
| openstackgerrit | liusheng proposed openstack/mogan master: Fix two issues in API sample files https://review.openstack.org/503898 | 02:55 |
| *** wanghao has quit IRC | 02:55 | |
| *** wanghao has joined #openstack-mogan | 03:00 | |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Update release notes https://review.openstack.org/502924 | 03:06 |
| *** wanghao_ has joined #openstack-mogan | 03:15 | |
| *** wanghao has quit IRC | 03:15 | |
| zhenguo | liusheng: does server groups list support all_tenants parameter http://mogan.readthedocs.io/projects/api-ref/en/latest/v1/index.html#list-servergroups ? | 03:29 |
| liusheng | zhenguo: yes | 03:30 |
| zhenguo | liusheng: ok | 03:30 |
| *** liusheng has left #openstack-mogan | 03:31 | |
| *** liusheng has joined #openstack-mogan | 03:31 | |
| openstackgerrit | liusheng proposed openstack/python-moganclient master: Add support for rebuilding server https://review.openstack.org/503932 | 03:55 |
| openstackgerrit | liusheng proposed openstack/mogan master: Fix two issues in API sample files https://review.openstack.org/503898 | 03:59 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Revise some API docs https://review.openstack.org/503956 | 05:22 |
| *** openstack has joined #openstack-mogan | 05:32 | |
| zhenguo | liusheng: seems something wrong with the gate | 05:38 |
| zhenguo | liusheng: BaremetalComputeAPINodesTest | 05:38 |
| openstackgerrit | Zhenguo Niu proposed openstack/python-moganclient master: Add --long parameter to flavor list cmd https://review.openstack.org/503961 | 05:51 |
| liusheng | zhenguo: seems gate has been broken | 06:08 |
| zhenguo | liusheng: yes | 06:08 |
| zhenguo | liusheng: something wrong with node test | 06:09 |
| liusheng | zhenguo: node test ? | 06:09 |
| zhenguo | liusheng: BaremetalComputeAPINodesTest | 06:09 |
| liusheng | zhenguo: oh | 06:09 |
| zhenguo | liusheng: you can try on you local env | 06:09 |
| *** lin_yang has quit IRC | 06:10 | |
| liusheng | zhenguo: I found the problem, but not sure, let me try to fix | 06:10 |
| zhenguo | liusheng: ok, thansk | 06:12 |
| openstackgerrit | liusheng proposed openstack/mogan master: Correct log formatting statements https://review.openstack.org/503969 | 06:16 |
| zhenguo | liusheng: please take a look at this https://review.openstack.org/#/c/503956/ | 06:40 |
| liusheng | zhenguo: done | 06:43 |
| zhenguo | liusheng: thanks | 06:43 |
| liusheng | zhenguo: np | 06:44 |
| openstackgerrit | liusheng proposed openstack/python-moganclient master: Add support for rebuilding server https://review.openstack.org/503932 | 06:47 |
| openstackgerrit | liusheng proposed openstack/mogan master: Fix gate https://review.openstack.org/503978 | 07:03 |
| zhenguo | liusheng: please have a look at this https://review.openstack.org/#/c/503961/ | 07:41 |
| zhenguo | liusheng: seems this fixed the gate https://review.openstack.org/#/c/503978/ , thanks | 07:54 |
| liusheng | zhenguo: np :D | 07:55 |
| zhenguo | liusheng: do you have anything else want to add to client? | 07:56 |
| liusheng | zhenguo: nothing else | 07:56 |
| zhenguo | liusheng: ok, let's try to land the up patches, then prepare a release patch | 07:56 |
| liusheng | zhenguo: ok | 07:57 |
| *** wanghao has joined #openstack-mogan | 07:58 | |
| *** wanghao_ has quit IRC | 08:02 | |
| zhenguo | liusheng: do you think it's better to also format flavor resource and aggregates with show and create like list | 08:05 |
| liusheng | zhenguo: yeah, I think so | 08:06 |
| zhenguo | liusheng: ok, will add a following up patch then | 08:06 |
| liusheng | zhenguo: ok, thank | 08:06 |
| zhenguo | liusheng: and this one https://review.openstack.org/#/c/503894/ | 08:09 |
| zhenguo | liusheng: also maybe we can +A directly to make it land before relese :P | 08:09 |
| liusheng | zhenguo: hah I am just doing that | 08:10 |
| zhenguo | liusheng: hah | 08:10 |
| openstackgerrit | Merged openstack/python-moganclient master: Add support for rebuilding server https://review.openstack.org/503932 | 08:16 |
| openstackgerrit | Merged openstack/python-moganclient master: Replace interface with port for attaching/detaching interfaces https://review.openstack.org/503894 | 08:16 |
| openstackgerrit | Merged openstack/python-moganclient master: Add --long parameter to flavor list cmd https://review.openstack.org/503961 | 08:16 |
| zhenguo | liusheng: seems you need to buld the client doc again | 08:19 |
| liusheng | zhenguo: done | 08:22 |
| openstackgerrit | Merged openstack/mogan master: Fix gate https://review.openstack.org/503978 | 08:31 |
| *** wanghao_ has joined #openstack-mogan | 08:40 | |
| *** wanghao has quit IRC | 08:40 | |
| openstackgerrit | Zhenguo Niu proposed openstack/python-moganclient master: Format flavor resources and aggregates output https://review.openstack.org/504007 | 08:46 |
| zhenguo | liusheng: oh, seems we don't support to create flavor with resource aggregates now | 08:51 |
| zhenguo | liusheng: on client side | 08:51 |
| liusheng | zhenguo: need to support specifying that ? | 08:52 |
| zhenguo | liusheng: yes, otherwise we can't create flavor with aggregates | 08:53 |
| zhenguo | liusheng: and we the option should be --resource instead of --resources as we will repeat it to set multi key/value pair | 08:54 |
| liusheng | zhenguo: fair enough | 09:01 |
| openstackgerrit | liusheng proposed openstack/mogan master: Correct log formatting statements https://review.openstack.org/503969 | 09:05 |
| zhenguo | liusheng: will make a patch for that | 09:07 |
| zhenguo | liusheng: but need your help on this https://review.openstack.org/#/c/504007/ | 09:07 |
| liusheng | zhenguo: ok | 09:07 |
| liusheng | zhenguo: ok | 09:07 |
| zhenguo | liusheng: not sure why it sometimes failed | 09:07 |
| liusheng | zhenguo: unrelate with the change ? | 09:07 |
| zhenguo | liusheng: no, with this change | 09:08 |
| liusheng | zhenguo: let me check | 09:08 |
| zhenguo | liusheng: thanks | 09:08 |
| *** wanghao_ has quit IRC | 09:28 | |
| *** wanghao has joined #openstack-mogan | 09:28 | |
| zhenguo | liusheng: not sure why partitions got lost from API side | 09:28 |
| liusheng | zhenguo: partitions of server? | 09:29 |
| zhenguo | liusheng: yes | 09:29 |
| liusheng | zhenguo: not sure why your flavor patch cannot pass, it is ok locally | 09:31 |
| zhenguo | liusheng: randomly | 09:31 |
| liusheng | zhenguo: according to the error message, the "resources" field is a string | 09:31 |
| zhenguo | liusheng: yes, not sure why it can be a tring | 09:31 |
| zhenguo | *string | 09:31 |
| liusheng | zhenguo: you mean even in local env, it is string randomly ? | 09:33 |
| zhenguo | liusheng: yes | 09:33 |
| zhenguo | liusheng: on my local env, and everytime the test case is not same | 09:34 |
| zhenguo | liusheng: seems there are some races in the tests | 09:34 |
| zhenguo | liusheng: seems they all reference the same fake object | 09:34 |
| liusheng | zhenguo: yes, I see, that because the fake_flavor is a class attribute, maybe put it in setup() method | 09:37 |
| zhenguo | liusheng: yes | 09:37 |
| liusheng | zhenguo: because you have updated the object | 09:37 |
| zhenguo | liusheng: yes | 09:38 |
| liusheng | zhenguo: or deepcopy a object | 09:38 |
| zhenguo | liusheng: please help to try, thanks | 09:38 |
| liusheng | zhenguo: ok | 09:39 |
| *** wanghao has quit IRC | 09:39 | |
| openstackgerrit | Zhenguo Niu proposed openstack/python-moganclient master: Add flavor resource aggregates support https://review.openstack.org/504019 | 09:39 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Add partitions to server API object https://review.openstack.org/504020 | 09:43 |
| openstackgerrit | Zhenguo Niu proposed openstack/python-moganclient master: Format server partitions output https://review.openstack.org/504022 | 10:05 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: Add partitions to server API object https://review.openstack.org/504020 | 10:30 |
| openstackgerrit | Merged openstack/mogan master: Updated from global requirements https://review.openstack.org/503633 | 10:30 |
| openstackgerrit | Merged openstack/mogan master: Fix two issues in API sample files https://review.openstack.org/503898 | 10:31 |
| openstackgerrit | Zhenguo Niu proposed openstack/mogan master: [Devstack] Update the flavor resource parameter https://review.openstack.org/504025 | 10:37 |
| *** litao__ has quit IRC | 10:57 | |
| openstackgerrit | liusheng proposed openstack/python-moganclient master: Format flavor resources and aggregates output https://review.openstack.org/504007 | 11:32 |
| zhenguo | liusheng: is that ok? | 11:34 |
| liusheng | zhenguo: yes | 11:34 |
| zhenguo | liusheng: cool | 11:34 |
| zhenguo | liusheng: please check other client up patches | 11:34 |
| liusheng | zhenguo: ok | 11:34 |
| openstackgerrit | Merged openstack/python-moganclient master: Format server partitions output https://review.openstack.org/504022 | 11:42 |
| openstackgerrit | Merged openstack/python-moganclient master: Format flavor resources and aggregates output https://review.openstack.org/504007 | 11:46 |
| openstackgerrit | Zhenguo Niu proposed openstack/python-moganclient master: Add flavor resource aggregates support https://review.openstack.org/504019 | 11:54 |
| zhenguo | liusheng: not sure why 'locked' also not return with server API object | 11:55 |
| liusheng | zhenguo: rebuild also don't return | 11:56 |
| zhenguo | liusheng: locked? | 11:56 |
| liusheng | zhenguo: oh, I misunderstood. hah | 11:57 |
| liusheng | zhenguo: let me check | 11:57 |
| zhenguo | liusheng: but seems not related to client | 11:57 |
| liusheng | zhenguo: it didn't return in API side ? | 11:58 |
| zhenguo | liusheng: yes | 11:58 |
| zhenguo | liusheng: we can fix that later | 11:59 |
| zhenguo | liusheng: quite easy, just need to add a field to API object | 11:59 |
| liusheng | zhenguo: yes | 11:59 |
| zhenguo | liusheng: thishttps://review.openstack.org/#/c/504019/ is the last one if you don't find other issues | 12:00 |
| liusheng | zhenguo: yes | 12:04 |
| zhenguo | liusheng: how's that patch, any objections? | 12:09 |
| liusheng | zhenguo: I am testing ,hah | 12:09 |
| zhenguo | liusheng: ok | 12:09 |
| liusheng | zhenguo: +2 +A ed | 12:10 |
| zhenguo | liusheng: lol | 12:10 |
| zhenguo | liusheng: so nothing else need to be addressed? | 12:10 |
| liusheng | zhenguo: I think so, hah | 12:10 |
| zhenguo | liusheng: ok | 12:11 |
| openstackgerrit | Merged openstack/python-moganclient master: Add flavor resource aggregates support https://review.openstack.org/504019 | 12:15 |
| zhenguo | liusheng: ok, landed | 12:15 |
| zhenguo | liusheng: we release 0.1.0, right? | 12:17 |
| liusheng | zhenguo: I think we are ready! | 12:18 |
| zhenguo | liusheng: ok, my release patch is also ready, lol | 12:18 |
| zhenguo | liusheng: https://review.openstack.org/#/c/504041/ | 12:20 |
| zhenguo | liusheng: please check if the hash is right | 12:20 |
| zhenguo | liusheng: mogan gate will be broken without this https://review.openstack.org/#/c/504025/ | 12:22 |
| liusheng | zhenguo: +Aed | 12:23 |
| zhenguo | liusheng: thanks | 12:23 |
| zhenguo | liusheng: seems the release patch failed | 12:23 |
| zhenguo | liusheng: seems must be in the in the governance list | 12:24 |
| liusheng | zhenguo: :( | 12:25 |
| zhenguo | liusheng: sigh | 12:25 |
| liusheng | zhenguo: only official project can leverage releases | 12:25 |
| zhenguo | liusheng: but how others? | 12:25 |
| liusheng | zhenguo: there is non-official project released in releases repo ? | 12:26 |
| zhenguo | liusheng: seems there is | 12:26 |
| liusheng | zhenguo: which one | 12:26 |
| liusheng | zhenguo: is it exist in governance ? | 12:26 |
| zhenguo | liusheng: not checked | 12:27 |
| zhenguo | liusheng: maybe changed to use other release model | 12:27 |
| zhenguo | liusheng: I have to go, maybe we can do it tommorow | 12:28 |
| liusheng | zhenguo: ok, I also need to go, bye | 12:29 |
| zhenguo | bye | 12:29 |
| * zhenguo away | 12:29 | |
| openstackgerrit | Merged openstack/mogan master: [Devstack] Update the flavor resource parameter https://review.openstack.org/504025 | 13:06 |
| *** shaohe_feng has quit IRC | 14:08 | |
| *** shaohe_feng has joined #openstack-mogan | 14:12 | |
| openstackgerrit | Merged openstack/mogan master: Revise some API docs https://review.openstack.org/503956 | 14:28 |
| openstackgerrit | Merged openstack/mogan master: Correct log formatting statements https://review.openstack.org/503969 | 15:01 |
| openstackgerrit | Merged openstack/mogan master: Enrich the payload of notifications of server creation https://review.openstack.org/503550 | 15:03 |
| openstackgerrit | Merged openstack/mogan master: Add more notifications for server create/delete https://review.openstack.org/502898 | 15:07 |
| openstackgerrit | Merged openstack/mogan master: [DOC] Add flavor manage and customize instructions https://review.openstack.org/502959 | 15:07 |
| *** Kevin_Zheng has joined #openstack-mogan | 21:38 | |
| *** openstackstatus has joined #openstack-mogan | 23:11 | |
| *** ChanServ sets mode: +v openstackstatus | 23:11 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!