openstackgerrit | lifeless proposed a change to stackforge/monasca-agent: Remove hardcoded version. https://review.openstack.org/115468 | 02:01 |
---|---|---|
*** cindyo has quit IRC | 02:31 | |
*** sandywalsh has quit IRC | 03:05 | |
*** sandywalsh has joined #openstack-monasca | 03:06 | |
*** garyh has quit IRC | 04:09 | |
*** garyh has joined #openstack-monasca | 04:49 | |
*** openstackgerrit has quit IRC | 10:10 | |
*** tongli has joined #openstack-monasca | 12:42 | |
*** cindyo has joined #openstack-monasca | 14:15 | |
*** dschroeder has joined #openstack-monasca | 14:49 | |
*** aviau has quit IRC | 14:53 | |
*** rhochmuth has joined #openstack-monasca | 15:03 | |
*** rhochmuth has left #openstack-monasca | 15:04 | |
*** rhochmuth has joined #openstack-monasca | 15:04 | |
*** aviau has joined #openstack-monasca | 15:08 | |
*** openstackgerrit has joined #openstack-monasca | 15:12 | |
cindyo | proposing this change: https://review.openstack.org/115676 | 15:31 |
cindyo | don’t know why openstackgerrit didn’t notify the room | 15:31 |
cindyo | tongli: looking at openstack-infra room I see they removed the zuul comments. this seems to be affecting our room notificaitons | 15:35 |
tongli | hmmm. just this channel or all channels? | 15:36 |
cindyo | they removed all comments. not sure how you hooked in our room notifications | 15:36 |
tongli | hmmm, we still have openstackstatus and openstackgerrit in this channel. | 15:37 |
tongli | it should work. | 15:37 |
cindyo | my last review didn’t get seen | 15:38 |
tongli | posted review comments or submitted a patch set? | 15:38 |
cindyo | a new review | 15:38 |
tongli | I do not think review comments get on irc channel. | 15:38 |
cindyo | ok, only commits to master? | 15:38 |
tongli | I believe it is only the merge, patch submit. | 15:38 |
tongli | yeah. | 15:39 |
tongli | I do not think review comments get on the channel. that will be a lot of flood, I think. | 15:39 |
cindyo | tongli: the initial review only used to get posted, see the one from lifeless above, it has not been approved | 15:40 |
cindyo | if we can live with just merges that’s ok, it means you might not get a chance to review it | 15:40 |
tongli | hmmm, I do not actually know there is something there for review comments to be posted (notified ) in the channel. | 15:41 |
cindyo | i guess if you want to be involved in the view you can sign up to be notified by your email | 15:42 |
cindyo | in the review | 15:42 |
tongli | merges and patch set submission should be ok. | 15:42 |
tongli | that is right. | 15:42 |
tongli | if you reveiw a patch set, then you will be receiving the emails when there is new review comments. | 15:42 |
openstackgerrit | A change was merged to stackforge/python-monascaclient: use keystone endpoint when api url is not input https://review.openstack.org/115676 | 15:52 |
*** aviau has quit IRC | 15:59 | |
*** aviau has joined #openstack-monasca | 16:12 | |
openstackgerrit | Tim Kuhlman proposed a change to stackforge/monasca-notification: Move from using zookeeper to track partition offsets to kafka https://review.openstack.org/115705 | 16:49 |
*** rhochmuth has quit IRC | 17:11 | |
*** ChanServ sets mode: +v openstackstatus | 18:07 | |
*** cindyo has quit IRC | 18:12 | |
*** cindyo has joined #openstack-monasca | 19:08 | |
*** robbybb has joined #openstack-monasca | 19:37 | |
openstackgerrit | A change was merged to stackforge/monasca-agent: Updating metric names to match new format https://review.openstack.org/115102 | 22:01 |
cindyo | sandywalsh: do you typically have a pipeline per unique rule set? The rule set example has trigger_name uuid, and request_id trigger def | 22:11 |
openstackgerrit | Tim Kuhlman proposed a change to stackforge/monasca-persister: Add a tar.gz to the package step https://review.openstack.org/115813 | 22:54 |
*** dschroeder has quit IRC | 23:08 | |
*** robbybb111 has joined #openstack-monasca | 23:45 | |
openstackgerrit | lifeless proposed a change to stackforge/monasca-agent: Remove hardcoded version https://review.openstack.org/115468 | 23:47 |
*** robbybb has quit IRC | 23:50 | |
*** openstackgerrit has quit IRC | 23:54 | |
*** cindyo has quit IRC | 23:56 | |
*** openstackgerrit has joined #openstack-monasca | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!