| *** enikher has joined #openstack-net-bgpvpn | 07:44 | |
| *** enikher has left #openstack-net-bgpvpn | 07:47 | |
| *** tmorin has joined #openstack-net-bgpvpn | 08:16 | |
| *** matrohon has joined #openstack-net-bgpvpn | 08:42 | |
| *** enikher has joined #openstack-net-bgpvpn | 09:06 | |
| *** timirnich has quit IRC | 09:52 | |
| *** timirnich has joined #openstack-net-bgpvpn | 10:03 | |
| *** enikher has quit IRC | 10:08 | |
| *** enikher has joined #openstack-net-bgpvpn | 10:08 | |
| *** enikher1 has joined #openstack-net-bgpvpn | 11:11 | |
| *** enikher has quit IRC | 11:15 | |
| *** tmorin has quit IRC | 11:50 | |
| *** doude has quit IRC | 11:50 | |
| *** doude has joined #openstack-net-bgpvpn | 11:51 | |
| *** openstack has joined #openstack-net-bgpvpn | 12:03 | |
| *** tmorin has joined #openstack-net-bgpvpn | 12:10 | |
| *** timirnich has quit IRC | 12:32 | |
| *** openstackgerrit_ has quit IRC | 12:32 | |
| *** openstackgerrit has quit IRC | 12:32 | |
| *** openstackgerrit has joined #openstack-net-bgpvpn | 12:33 | |
| *** openstackgerrit_ has joined #openstack-net-bgpvpn | 12:33 | |
| *** timirnich has joined #openstack-net-bgpvpn | 12:44 | |
| openstackgerrit | Mathieu Rohon proposed openstack/networking-bgpvpn: Fix rendering issues on block diagrams https://review.openstack.org/281244 | 12:53 |
|---|---|---|
| *** enikher has joined #openstack-net-bgpvpn | 13:40 | |
| *** enikher1 has quit IRC | 13:43 | |
| *** matrohon has quit IRC | 13:50 | |
| *** matrohon has joined #openstack-net-bgpvpn | 14:00 | |
| enikher | tmorin: matrohon: Hey bgpvpn masters. Could you have a look on this: http://logs.openstack.org/14/280214/4/check/gate-networking-bgpvpn-pep8/dfb986c/console.html | 14:26 |
| enikher | I do not change anything on this packages. | 14:27 |
| matrohon | enikher : well something's going wrong with this test... same issue here : https://review.openstack.org/#/c/281244/ | 14:27 |
| matrohon | enikher : I'll investigate asap | 14:28 |
| enikher | matrohon:https://github.com/vim-scripts/Python-mode-klen/blob/master/pymode/libs/pylama/lint/pylama_pylint/pylint/checkers/exceptions.py#L94-L98 | 14:30 |
| matrohon | enikher, does this ceck has been added recently? | 14:32 |
| matrohon | enikher, probably du to a bump in the version of pylint... | 14:33 |
| matrohon | doude : ^ | 14:33 |
| enikher | matrohon: could be | 14:34 |
| matrohon | doude : the opencontrail driver is breaking the bgpvpn's gate | 14:34 |
| doude | matrohon: I see that. On the master ? | 14:35 |
| enikher | matrohon: what I don't understand is which line it refers to: W:147,12: Exception doesn't inherit from standard "Exception" class (nonstandard-exception) | 14:36 |
| enikher | matrohon: doude: what does W:147.12 mean | 14:36 |
| doude | I don't now | 14:36 |
| doude | that's not only due to the contrail driver code | 14:38 |
| matrohon | doude : you're right sorry for blaming you :) | 14:39 |
| doude | is it on master ? | 14:39 |
| matrohon | yep | 14:39 |
| enikher | doude: yes | 14:39 |
| doude | perhaps a neutron evolution | 14:39 |
| matrohon | doude, I think about a bump of pylint in requirements | 14:40 |
| enikher | I am setting up a tox env at the moment with pylint>1.5 | 14:40 |
| enikher | :-) | 14:41 |
| doude | k | 14:41 |
| matrohon | pylint 1.4.5, | 14:41 |
| matrohon | enikher, you want to force pylint to >1.5? | 14:41 |
| enikher | no I will just remove pylint<1.5 | 14:42 |
| matrohon | enikher, +1 | 14:42 |
| enikher | matrohon: can we as well remove astroid<1.4? | 14:42 |
| enikher | what is that aboute? | 14:42 |
| matrohon | enikher, no idea! :) | 14:42 |
| enikher | it was on duty of the master: 9db191c3 (Thomas Morin 2015-11-30 11:40:23 +0100 18) astroid<1.4 | 14:43 |
| enikher | tmorin: ^ | 14:43 |
| enikher | #link https://review.openstack.org/#/c/251290/ | 14:46 |
| enikher | mhh I remeber that we did that on purpose... | 14:47 |
| enikher | AttributeError: 'module' object has no attribute 'GeneratorExp' | 14:50 |
| enikher | ERROR: InvocationError: '/opt/stack/networking-bgpvpn/.tox/pep8/bin/pylint --version' | 14:50 |
| enikher | astroid.DictComp, astroid.GeneratorExp) | 14:50 |
| enikher | AttributeError: 'module' object has no attribute 'GeneratorExp' | 14:50 |
| enikher | ERROR: InvocationError: '/opt/stack/networking-bgpvpn/.tox/pep8/bin/pylint --version' | 14:50 |
| enikher | so I will remove the version limitation as well for astroid. | 14:51 |
| enikher | ok that look better... I will push acommit | 14:55 |
| openstackgerrit | Nikolas Hermanns proposed openstack/networking-bgpvpn: Fixing pylint upgrade issues https://review.openstack.org/281321 | 15:03 |
| enikher | doude: whats your name in gerrit again? | 15:07 |
| tmorin | hi enikher | 15:08 |
| tmorin | doude is Edouard Thuleau | 15:08 |
| doude | yes | 15:09 |
| tmorin | hi doude :) | 15:12 |
| doude | hi tmorin | 15:12 |
| tmorin | enikher, matrohon: astroid is used by pylint, they have mutual version dependencies, if you pin pylint to <1.5 you have to pin astroid as well | 15:13 |
| tmorin | I don't understand the reason for these issues: http://logs.openstack.org/14/280214/4/check/gate-networking-bgpvpn-pep8/dfb986c/console.html#_2016-02-15_14_26_44_010 | 15:14 |
| tmorin | the logs show that pylint is run with version 1.4.5 | 15:14 |
| enikher | with my new fix we will use pylint 1.6 and it will work. I tested localy | 15:15 |
| enikher | https://review.openstack.org/#/c/281321/ | 15:15 |
| tmorin | not 1.6 , rather 1.5.4 it seems | 15:16 |
| enikher | http://logs.openstack.org/21/281321/1/check/gate-networking-bgpvpn-pep8/b08f4f3/console.html#_2016-02-17_15_12_19_679 | 15:16 |
| tmorin | I had done the pylint pining some time ago, because the first 1.5.x releases were introducing lots of regressions | 15:16 |
| enikher | :-) you are right | 15:16 |
| openstackgerrit | Merged openstack/networking-bgpvpn: Fixing pylint upgrade issues https://review.openstack.org/281321 | 15:16 |
| tmorin | if things now work with only few changes with pylint 1.5.4, then fine :) | 15:16 |
| enikher | ok already merged :-) | 15:16 |
| enikher | matrohon was fast | 15:16 |
| openstackgerrit | Nikolas Hermanns proposed openstack/networking-bgpvpn: Initialize Heat plugin https://review.openstack.org/280214 | 15:17 |
| matrohon | enikher, it was blocking avery other patches, so it needed a quick +2+A :) | 15:17 |
| tmorin | matrohon: ok :) | 15:17 |
| tmorin | but I really find this new import ordering very ugly | 15:18 |
| tmorin | especially forcing imports *after* code, like in https://review.openstack.org/#/c/281321/1/networking_bgpvpn/neutron/db/migration/alembic_migrations/versions/liberty/expand/3600132c6147_add_router_association_table.py ... is very very ugly | 15:18 |
| tmorin | don't you think ? | 15:18 |
| tmorin | matrohon: did you saw my comment on https://review.openstack.org/#/c/281244/ ? | 15:22 |
| enikher | tmorin: " forcing imports *after* code" now the import is on top of the file or not? | 15:27 |
| enikher | https://review.openstack.org/#/c/281321/1/networking_bgpvpn/neutron/db/migration/alembic_migrations/versions/liberty/expand/3600132c6147_add_router_association_table.py | 15:27 |
| tmorin | enikher: hmm... you're correct... :) | 15:27 |
| tmorin | I don't know what to say now | 15:27 |
| tmorin | maybe I should get more sleep :) | 15:27 |
| enikher | :-D | 15:28 |
| tmorin | still, I liked having basic imports (like six, or system libs) at the top of the files | 15:28 |
| enikher | that is always helpful | 15:28 |
| enikher | I also hade why pylint is doing so.. I think sometimes it even males sense to import inside the code. but I know that looks quite ugly. | 15:29 |
| matrohon | tmorin, I see you're paying a lot of attention to the beauty of bgpvpn today :) | 15:35 |
| tmorin | matrohon: not today, *every* day | 15:37 |
| tmorin | and night ! ;) | 15:37 |
| openstackgerrit | Merged openstack/networking-bgpvpn: Fix rendering issues on block diagrams https://review.openstack.org/281244 | 15:47 |
| openstackgerrit | Nikolas Hermanns proposed openstack/networking-bgpvpn: Initialize Heat plugin https://review.openstack.org/280214 | 15:54 |
| enikher | tmorin: ^ :) | 15:56 |
| enikher | matrohon: ^ do you have time to review this? | 16:00 |
| tmorin | thanks | 16:01 |
| tmorin | I had a look, and I have one comment left | 16:01 |
| openstackgerrit | Thomas Morin proposed openstack/networking-bgpvpn: OVS Agent extension for bagpipe driver https://review.openstack.org/281358 | 16:08 |
| openstackgerrit | Thomas Morin proposed openstack/networking-bgpvpn: OVS Agent extension for bagpipe driver https://review.openstack.org/281358 | 16:53 |
| openstackgerrit | Thomas Morin proposed openstack/networking-bgpvpn: OVS Agent extension for bagpipe driver https://review.openstack.org/281358 | 16:55 |
| openstackgerrit | Nikolas Hermanns proposed openstack/networking-bgpvpn: Initialize Heat plugin https://review.openstack.org/280214 | 17:15 |
| *** matrohon has quit IRC | 17:15 | |
| enikher | tmorin: sorry I missed your last comment. I have uploaded a new version now | 17:16 |
| *** tmorin has quit IRC | 17:18 | |
| *** timirnich has quit IRC | 17:34 | |
| *** timirnich has joined #openstack-net-bgpvpn | 17:39 | |
| *** enikher has left #openstack-net-bgpvpn | 18:44 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!