| *** vthapar has joined #openstack-net-bgpvpn | 04:10 | |
| *** vthapar has quit IRC | 05:56 | |
| *** enikher has joined #openstack-net-bgpvpn | 08:31 | |
| *** matrohon has joined #openstack-net-bgpvpn | 08:35 | |
| *** tmorin has joined #openstack-net-bgpvpn | 08:38 | |
| tmorin | hi enikher | 08:41 |
|---|---|---|
| tmorin | I've one last comment/question on https://review.openstack.org/280214 | 08:41 |
| tmorin | I'm still unclear why there is this comment on bgpvpn_id / parent thing | 08:42 |
| tmorin | to me, it seems that things are fine as-is, since we've agreed that it is better | 08:42 |
| tmorin | .. | 08:42 |
| tmorin | ...better no to have association as sub-resources of BGPVPN in Heat templates | 08:43 |
| *** matrohon has quit IRC | 08:47 | |
| tmorin | enikher: ^^ | 08:47 |
| enikher | give me a second... I am troubleshooting at the moment :-) | 08:48 |
| *** openstackgerrit has quit IRC | 10:02 | |
| *** openstackgerrit has joined #openstack-net-bgpvpn | 10:03 | |
| openstackgerrit | Thomas Morin proposed openstack/networking-bgpvpn: OVS Agent extension for bagpipe driver https://review.openstack.org/281358 | 10:40 |
| enikher | tmorin: mmhhh, ok I delete my comment it does not make snce anymore | 12:06 |
| enikher | tmorin: another thing "_id" | 12:06 |
| enikher | tmorin: you said that would be more consistent to remove _id. But the code asks explicitly for id. So not the name of the network. Or is there something like find_bgpvpn_by_id_or_name? | 12:07 |
| enikher | tmorin: there are other parts of heat where this is done in the same qay I do it | 12:10 |
| *** tmorin has quit IRC | 12:52 | |
| *** matrohon has joined #openstack-net-bgpvpn | 13:00 | |
| *** tmorin has joined #openstack-net-bgpvpn | 13:26 | |
| tmorin | enicker: reading againt what is done in Heat elsewhere, we see both: for instances sometimes the name of the property for a network is 'network', sometimes it is 'network_id', although in both cases, what has to be provided is a network uuid | 13:29 |
| tmorin | examples: | 13:29 |
| tmorin | https://github.com/openstack/heat-templates/blob/master/hot/servers_in_new_neutron_net.yaml#L59 | 13:29 |
| tmorin | https://github.com/openstack/heat-templates/blob/master/hot/servers_in_new_neutron_net.yaml#L80 | 13:29 |
| tmorin | I'm ok with keeping _id | 13:35 |
| *** vthapar has joined #openstack-net-bgpvpn | 14:01 | |
| enikher | :-) enikher not enicker... I have seen this sorry.. | 14:23 |
| enikher | tmorin: ^ | 14:23 |
| tmorin | ah, my mistake... :-( | 14:24 |
| tmorin | so we could do both with or without _id | 14:24 |
| tmorin | but I agree to keep _id | 14:24 |
| tmorin | so... one comment to remove and we can move forward with this change ! | 14:25 |
| enikher | mmhhh I think the problem is that we do not have find-name-or-id | 14:25 |
| enikher | that it would not care if it is id or name | 14:25 |
| enikher | but never the less | 14:25 |
| enikher | I think we can keep it | 14:26 |
| enikher | :-)! | 14:26 |
| enikher | done | 14:27 |
| matrohon | enikher : your patch is the occasion for me to have a closer look at heat. I'll test the full stack and +2 if it works! | 14:46 |
| matrohon | enikher, thanks for this great enhancment | 14:46 |
| enikher | matrohon: mmhh that means it will need longer? | 14:59 |
| enikher | :-( | 14:59 |
| enikher | I had the hope to finish that toayd :'( | 14:59 |
| matrohon | enikher, well, you can consider that your part of the work is finished :) | 15:21 |
| matrohon | enikher, do you have a strong dead line for this patch to merge? | 15:22 |
| *** enikher has quit IRC | 15:25 | |
| *** enikher has joined #openstack-net-bgpvpn | 15:28 | |
| *** vthapar has quit IRC | 15:44 | |
| *** enikher1 has joined #openstack-net-bgpvpn | 15:53 | |
| *** tmorin has quit IRC | 15:56 | |
| *** enikher has quit IRC | 15:56 | |
| *** tmorin has joined #openstack-net-bgpvpn | 15:56 | |
| openstackgerrit | Mathieu Rohon proposed openstack/networking-bgpvpn: remove neutron-client@liberty dependency https://review.openstack.org/281954 | 16:47 |
| *** enikher1 has quit IRC | 16:56 | |
| *** tmorin has quit IRC | 17:03 | |
| *** matrohon has quit IRC | 17:38 | |
| *** enikher has joined #openstack-net-bgpvpn | 21:40 | |
| *** enikher1 has joined #openstack-net-bgpvpn | 23:12 | |
| *** enikher has quit IRC | 23:16 | |
| *** enikher1 has quit IRC | 23:17 | |
| *** openstackgerrit has quit IRC | 23:47 | |
| *** openstackgerrit_ is now known as openstackgerrit | 23:47 | |
| *** openstackgerrit_ has joined #openstack-net-bgpvpn | 23:47 | |
| *** openstackgerrit_ is now known as openstackgerrit | 23:48 | |
| *** openstackgerrit_ has joined #openstack-net-bgpvpn | 23:49 | |
| *** openstackgerrit_ has quit IRC | 23:55 | |
| *** openstackgerrit_ has joined #openstack-net-bgpvpn | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!