Tuesday, 2015-02-17

*** seizadi has joined #openstack-neutron00:00
*** aranjan has quit IRC00:01
*** afazekas has quit IRC00:01
*** moha_hunt has quit IRC00:02
*** suresh12 has joined #openstack-neutron00:03
*** markvoelker has joined #openstack-neutron00:04
*** luqas__ has joined #openstack-neutron00:07
*** manishg has quit IRC00:08
*** manishg_ has joined #openstack-neutron00:08
*** markvoelker has quit IRC00:09
*** luqas has quit IRC00:09
*** leenheer has quit IRC00:12
HenryGotherwiseguy: ping00:13
*** sbalukoff has quit IRC00:13
*** mlavalle has quit IRC00:15
*** seizadi has quit IRC00:16
*** baoli has joined #openstack-neutron00:19
HenryGotherwiseguy: Left you a question here: https://review.openstack.org/15590600:21
*** nlahouti has quit IRC00:23
*** nlahouti has joined #openstack-neutron00:25
*** nlahouti has quit IRC00:26
*** Longgeek has joined #openstack-neutron00:27
*** dims_ has quit IRC00:27
openstackgerritJuergen Brendel proposed openstack/neutron: ARP spoofing patch: Low level ebtables integration  https://review.openstack.org/14113000:28
*** sbalukoff has joined #openstack-neutron00:29
*** dims__ has joined #openstack-neutron00:30
*** nlahouti has joined #openstack-neutron00:30
*** manishg_ has quit IRC00:35
openstackgerritYushiro FURUKAWA proposed openstack/neutron: Enable to apply policies to resources with special plural  https://review.openstack.org/14599800:40
*** ramishra_ has joined #openstack-neutron00:44
*** leenheer has joined #openstack-neutron00:44
*** leenheer has quit IRC00:45
*** vinsh_ has quit IRC00:45
*** tomoe_ has joined #openstack-neutron00:45
*** tomoe__ has joined #openstack-neutron00:46
*** zhhuabj has quit IRC00:47
*** zhhuabj has joined #openstack-neutron00:48
*** tomoe_ has quit IRC00:50
*** manishg has joined #openstack-neutron00:51
*** pavel_bondar has quit IRC00:52
*** SridharRamaswamy has joined #openstack-neutron00:52
*** SridharRamaswamy has quit IRC00:52
*** pavel_bondar has joined #openstack-neutron00:52
*** SridharRamaswamy has joined #openstack-neutron00:52
*** aranjan has joined #openstack-neutron00:54
*** SridharRamaswamy has quit IRC00:57
*** yamamoto has quit IRC00:57
*** leenheer has joined #openstack-neutron01:00
*** Longgeek has quit IRC01:00
*** ramishra_ has quit IRC01:02
*** seizadi has joined #openstack-neutron01:02
*** ramishra_ has joined #openstack-neutron01:05
*** ramishra_ has quit IRC01:05
*** markvoelker has joined #openstack-neutron01:05
*** ramishra_ has joined #openstack-neutron01:06
*** ramishra_ has quit IRC01:06
otherwiseguyHenryG: pong01:07
* otherwiseguy reads the question01:07
*** ramishra_ has joined #openstack-neutron01:07
* HenryG waits for response01:08
*** ramishra_ has quit IRC01:08
*** markvoelker has quit IRC01:11
otherwiseguyHenryG: response left on patch.01:11
*** seizadi has quit IRC01:11
*** vinsh has joined #openstack-neutron01:11
*** ramishra_ has joined #openstack-neutron01:12
HenryGotherwiseguy: Got it, thanks. So the commit msg isn't *quite* true. ;)01:13
otherwiseguyHenryG: Would really like to get the patches that have passed all tests merged as soon as possible. 15 changes w/ 111 files +724/-1124 gets kind of hard to maintain.01:14
HenryGotherwiseguy: I'll help them along01:14
otherwiseguyHenryG: That makes you a wonderful person in my book.01:15
HenryGotherwiseguy: I just want to make sure markmcclain and amotoki are OK with the first one, https://review.openstack.org/15306701:16
*** jamielennox is now known as jamielennox|away01:16
HenryGotherwiseguy: Once that is OK'd we can open the sluice gates01:16
otherwiseguyHenryG: If they aren't, I may have to give up. :) Changing it at this point means editing 111 files. :)01:16
otherwiseguyAnd by "give up" I mean, cry, drink heavily for a bit, and begin again.01:17
*** banix has quit IRC01:19
*** zzzeek has quit IRC01:21
*** signed8bit is now known as signed8bit_ZZZzz01:22
*** zzzeek has joined #openstack-neutron01:23
*** seizadi has joined #openstack-neutron01:23
*** banix has joined #openstack-neutron01:23
*** addnull has left #openstack-neutron01:25
*** manishg has quit IRC01:26
*** baoli has quit IRC01:27
*** nlahouti has quit IRC01:27
*** a_le has quit IRC01:28
*** Longgeek has joined #openstack-neutron01:28
*** Longgeek has quit IRC01:28
*** nlahouti has joined #openstack-neutron01:28
*** nlahouti has quit IRC01:29
*** Longgeek has joined #openstack-neutron01:30
*** jamielennox|away is now known as jamielennox01:31
*** tiswanso has quit IRC01:34
*** xuhanp has joined #openstack-neutron01:35
*** a_le has joined #openstack-neutron01:36
*** nlahouti has joined #openstack-neutron01:36
openstackgerritHenry Gessau proposed openstack/neutron: Fix the api job  https://review.openstack.org/15643601:36
*** zzzeek has quit IRC01:39
*** yamamoto_ has joined #openstack-neutron01:40
*** shwetaap has joined #openstack-neutron01:40
*** jamielennox is now known as jamielennox|away01:41
*** avozza is now known as zz_avozza01:56
*** apuimedo has quit IRC02:00
*** zhenq has joined #openstack-neutron02:02
*** kickinz1 is now known as kickinz1|afk02:04
*** trad511 has quit IRC02:06
*** nlahouti has quit IRC02:07
*** markvoelker has joined #openstack-neutron02:08
HenryGotherwiseguy: another question on https://review.openstack.org/15510102:08
*** _cjones_ has quit IRC02:09
*** jamielennox|away is now known as jamielennox02:09
*** shwetaap1 has joined #openstack-neutron02:09
*** shwetaap has quit IRC02:12
*** markvoelker has quit IRC02:13
*** manishg has joined #openstack-neutron02:13
*** tiswanso has joined #openstack-neutron02:13
*** salv-orlando has quit IRC02:13
*** pal has joined #openstack-neutron02:13
*** vinsh has quit IRC02:17
*** manishg has quit IRC02:18
*** manishg has joined #openstack-neutron02:18
*** manishg has quit IRC02:23
*** erkules_ has joined #openstack-neutron02:29
*** ramishra_ has quit IRC02:30
*** a_le has quit IRC02:30
*** erkules has quit IRC02:31
*** ramishra_ has joined #openstack-neutron02:31
otherwiseguyHenryG: Yeah, that was mistakenly left in after I was getting a weird timeout related to new test that was added since I initially wrote the patch. Removing now.02:31
openstackgerritTerry Wilson proposed openstack/neutron: Remove root_helper arg from AsyncProcess  https://review.openstack.org/15510102:33
otherwiseguyHenryG: ^02:33
HenryGotherwiseguy: ack, waiting for jenkins results02:34
otherwiseguyHenryG: Thanks again for all of the review. I know it is not a very entertaining patch set to review. :)02:35
otherwiseguyTomorrow morning I'll start working on the L3 Agent patch test failures--hopefully a pretty easy fix.02:36
*** pal has quit IRC02:36
*** shwetaap1 has quit IRC02:36
*** shwetaap has joined #openstack-neutron02:36
*** dims__ has quit IRC02:40
*** a_le has joined #openstack-neutron02:40
*** ramishra_ has quit IRC02:43
*** tomoe__ has quit IRC02:46
*** manishg has joined #openstack-neutron02:46
*** ramishra_ has joined #openstack-neutron02:53
*** hichihara has quit IRC02:54
*** yalie has left #openstack-neutron02:57
*** yalie has joined #openstack-neutron02:57
*** amuller has quit IRC02:57
*** zhenq has quit IRC03:01
*** armax has joined #openstack-neutron03:06
*** armax has quit IRC03:06
*** marun has quit IRC03:07
*** vinsh has joined #openstack-neutron03:09
*** markvoelker has joined #openstack-neutron03:09
*** yalie has left #openstack-neutron03:11
*** salv-orlando has joined #openstack-neutron03:14
*** markvoelker has quit IRC03:14
*** manishg has quit IRC03:21
*** manishg has joined #openstack-neutron03:22
*** manishg has quit IRC03:26
openstackgerritShweta P proposed openstack/neutron: Passes the plugin context variable in the ML2 Extension Driver API  https://review.openstack.org/15275903:28
*** anish_ has joined #openstack-neutron03:32
*** aepifanov has joined #openstack-neutron03:34
*** bradjones has quit IRC03:34
*** pal has joined #openstack-neutron03:38
*** dims__ has joined #openstack-neutron03:40
openstackgerritMerged openstack/python-neutronclient: Add ip_version to extra dhcp opts  https://review.openstack.org/14201503:43
*** amotoki_ has joined #openstack-neutron03:43
*** vinsh has quit IRC03:45
*** Ajay__ has joined #openstack-neutron03:45
*** amotoki_ has quit IRC03:45
*** dims__ has quit IRC03:45
*** aepifanov has quit IRC03:46
*** tomoe_ has joined #openstack-neutron03:46
openstackgerritMerged openstack/python-neutronclient: Split base function of v2_0.Client into a separate class  https://review.openstack.org/15051203:46
openstackgerritDane LeBlanc proposed openstack/neutron: Include IPv6 SLAAC addresses implicitly for port create/update  https://review.openstack.org/11333903:48
openstackgerritMerged openstack/python-neutronclient: Fix for incorrect parameter in user-id error message in shell.py  https://review.openstack.org/15382903:49
*** tomoe_ has quit IRC03:50
*** emagana has joined #openstack-neutron03:51
openstackgerritDane LeBlanc proposed openstack/neutron: Include IPv6 SLAAC addresses implicitly for port create/update  https://review.openstack.org/11333903:52
*** seizadi has quit IRC03:53
*** tomoe_ has joined #openstack-neutron03:55
*** reed has quit IRC03:56
*** claudiub has quit IRC03:56
*** achanda has joined #openstack-neutron03:56
openstackgerritMerged openstack/neutron-vpnaas: Add index on tenant_id  https://review.openstack.org/15450604:03
openstackgerritMerged openstack/neutron: OVS DVR: Use a right mac address value to compose a flow  https://review.openstack.org/15433004:03
*** Longgeek has quit IRC04:04
*** ramishra_ has quit IRC04:08
*** suresh12 has quit IRC04:09
*** moshele has joined #openstack-neutron04:09
*** markvoelker has joined #openstack-neutron04:10
*** Marga_ has quit IRC04:12
*** moshele has quit IRC04:16
*** markvoelker has quit IRC04:16
*** nlahouti has joined #openstack-neutron04:19
*** ramishra_ has joined #openstack-neutron04:20
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Use python binding instead of ovs-ofctl command  https://review.openstack.org/15394604:22
*** leenheer has joined #openstack-neutron04:22
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: Make l2pop UT independent from OVS  https://review.openstack.org/11862004:22
*** ajmiller_ is now known as ajmiller04:22
*** nlahouti has quit IRC04:23
*** nlahouti has joined #openstack-neutron04:23
*** coolsvap_ is now known as coolsvap04:31
*** yamamoto_ has quit IRC04:33
*** SridharRamaswamy has joined #openstack-neutron04:35
*** yamamoto_ has joined #openstack-neutron04:35
*** Marga_ has joined #openstack-neutron04:36
*** emagana_ has joined #openstack-neutron04:37
*** Ajay__ has quit IRC04:37
*** tiswanso has quit IRC04:38
*** SridharRamaswamy has quit IRC04:39
*** SridharRamaswamy has joined #openstack-neutron04:39
*** emagana has quit IRC04:40
*** jckasper has joined #openstack-neutron04:52
*** jckasper_ has quit IRC04:53
*** anilvenkata has joined #openstack-neutron04:54
*** Marga_ has quit IRC04:55
*** Marga_ has joined #openstack-neutron04:55
openstackgerritSudhakar Babu Gariganti proposed openstack/neutron: setup_tunnel_br enhance to use DeferredOVSBridge  https://review.openstack.org/15628904:55
*** trinaths has joined #openstack-neutron04:57
openstackgerritSudhakar Babu Gariganti proposed openstack/neutron: setup_tunnel_br enhance to use DeferredOVSBridge  https://review.openstack.org/15628904:59
*** radez is now known as radez_g0n305:01
*** leenheer has left #openstack-neutron05:02
*** coolsvap is now known as coolsvap_05:02
openstackgerritSudhakar Babu Gariganti proposed openstack/neutron: setup_tunnel_br enhanced to use DeferredOVSBridge  https://review.openstack.org/15628905:05
*** vthapar has joined #openstack-neutron05:06
*** trinaths1 has joined #openstack-neutron05:08
*** banix has quit IRC05:08
*** coolsvap_ is now known as coolsvap05:09
*** _cjones_ has joined #openstack-neutron05:10
*** trinaths has quit IRC05:10
*** nikil89_ has joined #openstack-neutron05:11
*** nikil89_ is now known as naggappan05:11
*** markvoelker has joined #openstack-neutron05:12
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS UT: Fix some confusions between local vlan id and segmentation id  https://review.openstack.org/15646405:12
*** aepifanov has joined #openstack-neutron05:14
*** _cjones_ has quit IRC05:14
*** yamahata has joined #openstack-neutron05:14
*** gildub has quit IRC05:14
*** devlaps has quit IRC05:16
*** markvoelker has quit IRC05:17
*** pradipta has joined #openstack-neutron05:22
*** dane_leblanc_ has joined #openstack-neutron05:22
*** manishg has joined #openstack-neutron05:23
*** dane_leblanc has quit IRC05:23
*** murugan has joined #openstack-neutron05:24
*** _cjones_ has joined #openstack-neutron05:26
*** ajmiller has quit IRC05:27
*** ramishra_ has quit IRC05:27
*** yfried has quit IRC05:31
*** manishg has quit IRC05:37
*** yshafrir has joined #openstack-neutron05:37
*** manishg has joined #openstack-neutron05:37
*** ramishra_ has joined #openstack-neutron05:41
*** manishg has quit IRC05:42
*** achanda has quit IRC05:43
openstackgerritSachi King proposed openstack/neutron: Return exception when attempting to add duplicate VIP  https://review.openstack.org/14263005:45
*** achanda has joined #openstack-neutron05:46
*** pcaruana has quit IRC05:47
*** killer_prince is now known as lazy_prince05:48
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Use python binding instead of ovs-ofctl command  https://review.openstack.org/15394605:52
*** SridharG has joined #openstack-neutron05:52
*** _cjones_ has quit IRC05:53
*** coolsvap is now known as coolsvap_05:53
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Use python binding instead of ovs-ofctl command  https://review.openstack.org/15394605:56
*** ramishra_ has quit IRC05:57
*** saju_m has joined #openstack-neutron05:57
*** seizadi has joined #openstack-neutron06:00
*** coolsvap_ is now known as coolsvap06:00
openstackgerritSudhakar Babu Gariganti proposed openstack/neutron: setup_tunnel_br enhanced to use DeferredOVSBridge  https://review.openstack.org/15628906:05
openstackgerritSudhakar Babu Gariganti proposed openstack/neutron: setup_tunnel_br enhanced to use DeferredOVSBridge  https://review.openstack.org/15628906:06
*** anish__ has joined #openstack-neutron06:06
*** ramishra_ has joined #openstack-neutron06:06
*** anish_ has quit IRC06:07
openstackgerritSudhakar Babu Gariganti proposed openstack/neutron: setup_tunnel_br enhanced to use DeferredOVSBridge  https://review.openstack.org/15628906:08
*** anshul has joined #openstack-neutron06:08
*** Marga_ has quit IRC06:09
*** markvoelker has joined #openstack-neutron06:13
*** SridharRamaswam1 has joined #openstack-neutron06:15
*** SridharRamaswamy has quit IRC06:16
*** cipcosma has joined #openstack-neutron06:17
*** tflynn_ has joined #openstack-neutron06:18
*** markvoelker has quit IRC06:19
*** tflynn has quit IRC06:21
*** seizadi has quit IRC06:22
*** tflynn_ has quit IRC06:22
*** seizadi has joined #openstack-neutron06:22
*** SridharRamaswam1 has quit IRC06:25
*** seizadi1 has joined #openstack-neutron06:26
*** seizadi has quit IRC06:27
*** seizadi1 has quit IRC06:30
*** kickinz1|afk is now known as kickinz106:30
*** seizadi has joined #openstack-neutron06:30
*** zz_avozza is now known as avozza06:31
*** anish__ has quit IRC06:34
*** ramishra_ has quit IRC06:34
*** anish_ has joined #openstack-neutron06:35
*** seizadi has quit IRC06:40
*** seizadi has joined #openstack-neutron06:41
*** vinsh has joined #openstack-neutron06:45
*** Murali has joined #openstack-neutron06:47
*** saju_m has quit IRC06:48
*** vinsh has quit IRC06:50
*** irenab has joined #openstack-neutron06:52
*** yamamoto_ has quit IRC06:57
openstackgerritPraveen Kumar SM proposed openstack/neutron: DHCP Service LoadBalancing Scheduler  https://review.openstack.org/13701706:57
*** aranjan has quit IRC06:57
*** yamahata has quit IRC07:00
*** aranjan has joined #openstack-neutron07:00
openstackgerritAmandeep proposed openstack/python-neutronclient: Ambiguous cli output between "None" and NoneType  https://review.openstack.org/15648907:01
*** neeti has joined #openstack-neutron07:03
*** seizadi1 has joined #openstack-neutron07:05
*** seizadi has quit IRC07:05
*** evgenyf has joined #openstack-neutron07:07
*** salv-orlando has quit IRC07:07
*** leenheer has joined #openstack-neutron07:09
*** seizadi1 has quit IRC07:09
*** saju_m has joined #openstack-neutron07:09
*** yfried has joined #openstack-neutron07:09
*** seizadi has joined #openstack-neutron07:09
*** yamamoto_ has joined #openstack-neutron07:10
*** tflynn has joined #openstack-neutron07:12
*** yamamoto_ has quit IRC07:12
*** yfried_ has joined #openstack-neutron07:13
*** tflynn has joined #openstack-neutron07:13
*** seizadi1 has joined #openstack-neutron07:13
*** yfried has quit IRC07:14
openstackgerritSudhakar Babu Gariganti proposed openstack/neutron: setup_tunnel_br enhanced to use DeferredOVSBridge  https://review.openstack.org/15628907:14
*** seizadi has quit IRC07:14
*** markvoelker has joined #openstack-neutron07:15
*** seizadi has joined #openstack-neutron07:17
*** seizadi1 has quit IRC07:18
*** dims__ has joined #openstack-neutron07:18
*** yfried_ is now known as yfried|afk07:19
*** scheuran has joined #openstack-neutron07:19
*** markvoelker has quit IRC07:21
*** mzbik has joined #openstack-neutron07:21
*** dims__ has quit IRC07:23
*** thomasem has quit IRC07:23
*** thomasem has joined #openstack-neutron07:24
*** yfried|afk is now known as yfried_07:25
*** aranjan has quit IRC07:25
*** gridinv has joined #openstack-neutron07:29
*** ZZelle has quit IRC07:32
*** ZZelle has joined #openstack-neutron07:32
*** ramishra_ has joined #openstack-neutron07:35
*** yfried_ is now known as yfried|afk07:35
*** nyechiel_ has joined #openstack-neutron07:36
openstackgerritSudhakar Babu Gariganti proposed openstack/neutron: setup_tunnel_br enhanced to use DeferredOVSBridge  https://review.openstack.org/15628907:38
*** seizadi has quit IRC07:39
*** seizadi has joined #openstack-neutron07:40
*** ramishra_ has quit IRC07:40
*** devvesa has joined #openstack-neutron07:41
*** shwetaap has quit IRC07:41
*** lihit has joined #openstack-neutron07:41
*** nlahouti1 has joined #openstack-neutron07:42
*** gridinv has quit IRC07:43
*** nlahouti has quit IRC07:44
*** seizadi1 has joined #openstack-neutron07:44
*** seizadi has quit IRC07:44
*** nlahouti1 has quit IRC07:46
*** moshele has joined #openstack-neutron07:47
*** achanda has quit IRC07:47
*** moshele has quit IRC07:48
*** ParsectiX has joined #openstack-neutron07:48
*** seizadi1 has quit IRC07:49
*** seizadi has joined #openstack-neutron07:49
*** nyechiel_ has quit IRC07:51
*** nyechiel_ has joined #openstack-neutron07:51
*** seizadi1 has joined #openstack-neutron07:52
*** yfried|afk is now known as yfried_07:53
*** mkerrin has joined #openstack-neutron07:54
*** achanda has joined #openstack-neutron07:54
*** seizadi has quit IRC07:54
*** seizadi1 has quit IRC07:56
*** rm_work is now known as rm_work|away07:57
*** nmagnezi has joined #openstack-neutron07:59
*** pal has quit IRC08:01
*** leenheer has quit IRC08:02
*** kawa2014 has joined #openstack-neutron08:08
*** lihit has joined #openstack-neutron08:09
*** lihit has quit IRC08:09
*** fifieldt has joined #openstack-neutron08:09
*** belmoreira has joined #openstack-neutron08:09
*** chlong has quit IRC08:11
*** belmoreira has quit IRC08:14
*** pask81 has joined #openstack-neutron08:14
*** pal has joined #openstack-neutron08:17
*** markvoelker has joined #openstack-neutron08:17
*** seizadi has joined #openstack-neutron08:18
*** gridinv has joined #openstack-neutron08:20
*** achanda has quit IRC08:20
*** markvoelker has quit IRC08:22
*** achanda has joined #openstack-neutron08:24
*** sbelous has quit IRC08:24
*** aranjan has joined #openstack-neutron08:26
*** ronis has joined #openstack-neutron08:27
*** seizadi has quit IRC08:27
*** aepifanov has quit IRC08:28
*** aepifanov has joined #openstack-neutron08:28
*** achanda has quit IRC08:30
*** aranjan has quit IRC08:30
*** tflynn has quit IRC08:34
*** tflynn has joined #openstack-neutron08:35
*** matrohon has joined #openstack-neutron08:36
*** ramishra_ has joined #openstack-neutron08:36
*** achanda has joined #openstack-neutron08:37
*** salv-orlando has joined #openstack-neutron08:38
*** ramishra_ has quit IRC08:41
openstackgerritLionel Zerbib proposed openstack/python-neutronclient: Add rate limiting security groups rules CLI extension  https://review.openstack.org/15620508:42
*** tflynn has quit IRC08:42
*** jpena has joined #openstack-neutron08:45
*** achanda has quit IRC08:47
*** ivar-lazzaro has quit IRC08:47
*** anilvenkata has left #openstack-neutron08:47
*** jistr has joined #openstack-neutron08:51
*** roeyc has joined #openstack-neutron08:52
*** jlibosva has joined #openstack-neutron08:53
*** mkerrin has quit IRC08:53
*** _cjones_ has joined #openstack-neutron08:54
*** fifieldt has quit IRC08:56
*** _cjones_ has quit IRC08:58
*** jp_at_hp has joined #openstack-neutron08:59
*** karimb has joined #openstack-neutron09:00
*** obondarev_ is now known as obondarev09:03
*** a_le has quit IRC09:07
*** a_le has joined #openstack-neutron09:08
*** salv-orlando has quit IRC09:15
*** markvoelker has joined #openstack-neutron09:18
*** aix has quit IRC09:21
*** a_le_ has joined #openstack-neutron09:21
*** ygbo has joined #openstack-neutron09:22
*** markvoelker has quit IRC09:23
*** a_le has quit IRC09:24
*** jlanoux has joined #openstack-neutron09:25
*** avozza is now known as zz_avozza09:26
*** ihrachyshka has joined #openstack-neutron09:26
*** aranjan has joined #openstack-neutron09:27
*** dsneddon has quit IRC09:30
*** yfried_ is now known as yfried|afk09:31
*** aranjan has quit IRC09:31
*** nivtuckio has joined #openstack-neutron09:35
*** yfried|afk is now known as yfried_09:38
openstackgerritMiguel Angel Ajo proposed openstack/neutron: Refactor the ProcessMonitor API  https://review.openstack.org/15446409:39
*** apuimedo has joined #openstack-neutron09:44
*** karimb has quit IRC09:45
*** aix has joined #openstack-neutron09:48
*** tomoe_ has quit IRC09:51
*** zz_avozza is now known as avozza09:55
*** arif-ali has joined #openstack-neutron10:00
*** moshele has joined #openstack-neutron10:02
openstackgerritFawad Khaliq proposed openstack/neutron: pg-ci test commit (do not review)  https://review.openstack.org/15652910:02
*** salv-orlando has joined #openstack-neutron10:03
*** aix has quit IRC10:05
*** avozza is now known as zz_avozza10:06
*** saju_m has quit IRC10:09
*** a_le_ has quit IRC10:09
*** aix has joined #openstack-neutron10:17
openstackgerritBradley Jones proposed openstack/neutron: Advertise mtu over dhcp  https://review.openstack.org/15587410:18
*** markvoelker has joined #openstack-neutron10:19
*** afazekas has joined #openstack-neutron10:23
*** markvoelker has quit IRC10:24
*** yfried_ is now known as yfried|afk10:24
*** ajo has joined #openstack-neutron10:25
*** zz_avozza is now known as avozza10:26
*** jlanoux_ has joined #openstack-neutron10:27
*** aranjan has joined #openstack-neutron10:28
*** jlanoux has quit IRC10:30
*** aranjan has quit IRC10:32
*** ilyashakhat_ has quit IRC10:32
*** ilyashakhat has joined #openstack-neutron10:32
*** shilpa_ has joined #openstack-neutron10:34
*** ramishra_ has joined #openstack-neutron10:38
*** saju_m has joined #openstack-neutron10:39
*** sbelous has joined #openstack-neutron10:40
*** ramishra_ has quit IRC10:43
*** jlanoux has joined #openstack-neutron10:43
*** yfried|afk is now known as yfried_10:44
*** jlanoux_ has quit IRC10:45
*** txomon|fon has quit IRC10:51
*** tomoe_ has joined #openstack-neutron10:51
*** txomon|fon has joined #openstack-neutron10:53
*** yfried_ is now known as yfried|afk10:54
*** yfried|afk is now known as yfried_10:56
*** tomoe_ has quit IRC10:56
openstackgerritAman Kumar proposed openstack/neutron: External Networks in ML2 have invalid providernet types  https://review.openstack.org/14954610:58
*** nivtuckio has quit IRC10:58
*** pc_m has joined #openstack-neutron10:59
openstackgerritFawad Khaliq proposed openstack/neutron: pg-ci test commit (do not review)  https://review.openstack.org/15652911:01
*** salv-orlando has quit IRC11:02
*** anish_ has quit IRC11:09
openstackgerritP. Watsalya Mishra proposed openstack/python-neutronclient: "neutron help router-update" help info updated  https://review.openstack.org/14100611:20
*** markvoelker has joined #openstack-neutron11:20
*** markvoelker has quit IRC11:25
*** jlanoux_ has joined #openstack-neutron11:27
*** aranjan has joined #openstack-neutron11:28
*** jlanoux has quit IRC11:30
*** jordandh has quit IRC11:30
*** jordandh has joined #openstack-neutron11:31
*** bobmel has quit IRC11:31
*** bobmel has joined #openstack-neutron11:31
*** dims__ has joined #openstack-neutron11:32
*** aranjan has quit IRC11:33
*** yamamoto has joined #openstack-neutron11:37
*** ramishra_ has joined #openstack-neutron11:39
*** jlanoux has joined #openstack-neutron11:43
*** ramishra_ has quit IRC11:43
*** jlanoux_ has quit IRC11:46
*** shilpa_ has quit IRC11:48
*** SridharG has left #openstack-neutron11:54
*** sbelous has quit IRC12:02
*** salv-orlando has joined #openstack-neutron12:02
*** yamamoto has quit IRC12:02
*** johnbelamaric1 has quit IRC12:07
*** johnbelamaric has joined #openstack-neutron12:12
openstackgerritMiguel Angel Ajo proposed openstack/neutron: Refactor the ProcessMonitor API  https://review.openstack.org/15446412:14
*** avozza is now known as zz_avozza12:14
*** banix has joined #openstack-neutron12:19
*** markvoelker has joined #openstack-neutron12:21
openstackgerritYoni Shafrir proposed openstack/neutron: Adding support for Keepalived health check script.  https://review.openstack.org/15656312:23
openstackgerritYoni Shafrir proposed openstack/neutron: Adding support for Keepalived health check script.  https://review.openstack.org/15656312:25
*** markvoelker has quit IRC12:26
*** amuller has joined #openstack-neutron12:26
openstackgerritYoni Shafrir proposed openstack/neutron: Adding support for Keepalived health check script.  https://review.openstack.org/15656312:27
openstackgerritYoni Shafrir proposed openstack/neutron: Adding support for Keepalived health check script.  https://review.openstack.org/15656312:28
openstackgerritMiguel Angel Ajo proposed openstack/neutron: WIP: Testing for bug/1421772  https://review.openstack.org/15656612:29
*** aranjan has joined #openstack-neutron12:29
openstackgerritVivekanandan Narasimhan proposed openstack/neutron: Hyper-V: Fixes security groups issue  https://review.openstack.org/15082612:29
*** mzbik_ has joined #openstack-neutron12:31
*** pal has quit IRC12:31
*** mzbik has quit IRC12:33
*** aranjan has quit IRC12:33
*** zhenq has joined #openstack-neutron12:34
*** tomoe_ has joined #openstack-neutron12:38
*** ramishra_ has joined #openstack-neutron12:40
*** yfried_ is now known as yfried|afk12:41
*** yfried|afk is now known as yfried_12:43
*** ramishra_ has quit IRC12:44
*** baoli has joined #openstack-neutron12:44
*** pradipta has quit IRC12:49
*** baoli has quit IRC12:49
*** baoli has joined #openstack-neutron12:50
*** salv-orlando has quit IRC12:50
*** salv-orlando has joined #openstack-neutron12:50
*** markvoelker has joined #openstack-neutron12:52
*** banix has quit IRC12:57
*** yamamoto has joined #openstack-neutron12:57
*** zz_avozza is now known as avozza13:05
*** avozza is now known as zz_avozza13:07
*** trinaths1 has quit IRC13:08
*** irenab has quit IRC13:08
*** yamamoto has quit IRC13:12
openstackgerritMiguel Angel Ajo proposed openstack/neutron: Refactor the ProcessMonitor API  https://review.openstack.org/15446413:13
*** jckasper has quit IRC13:13
*** irenab has joined #openstack-neutron13:14
*** irenab has quit IRC13:15
*** zz_avozza is now known as avozza13:15
*** mwagner_lap has quit IRC13:15
*** irenab has joined #openstack-neutron13:16
*** tiswanso has joined #openstack-neutron13:18
*** ParsectiX has quit IRC13:20
*** Marga_ has joined #openstack-neutron13:22
*** saju_m has quit IRC13:27
*** irenab has quit IRC13:28
*** aranjan has joined #openstack-neutron13:30
*** aranjan has quit IRC13:35
*** bjornar has quit IRC13:36
*** yfried_ is now known as yfried|afk13:37
*** yfried|afk is now known as yfried_13:38
*** claudiub has joined #openstack-neutron13:39
*** pal has joined #openstack-neutron13:40
*** afazekas has quit IRC13:40
*** ramishra_ has joined #openstack-neutron13:40
*** Marga_ has quit IRC13:44
*** ramishra_ has quit IRC13:45
*** neeti has quit IRC13:47
*** jckasper has joined #openstack-neutron13:47
*** amotoki has quit IRC13:49
*** HenryG has quit IRC13:49
*** vthapar has quit IRC13:51
*** dane_leblanc_ has quit IRC13:52
*** HenryG has joined #openstack-neutron13:52
*** amotoki has joined #openstack-neutron13:54
*** amotoki has quit IRC13:54
*** belmoreira has joined #openstack-neutron13:54
*** FJB has joined #openstack-neutron13:55
openstackgerritgaryk proposed openstack/neutron: Fix parameters in exception handling  https://review.openstack.org/15659013:55
*** radez_g0n3 is now known as radez13:56
*** yshafrir has quit IRC13:58
*** rushil has joined #openstack-neutron13:59
*** tiswanso has quit IRC14:01
openstackgerritJustin Hammond proposed openstack/python-neutronclient: Client command extension support  https://review.openstack.org/14831814:01
*** trown|outttypeww is now known as trown14:02
*** sgordon is now known as steveg14:02
*** irenab has joined #openstack-neutron14:03
*** avozza is now known as zz_avozza14:04
*** csoukup has joined #openstack-neutron14:06
*** SridharG has joined #openstack-neutron14:09
*** banix has joined #openstack-neutron14:10
*** tidwellr has joined #openstack-neutron14:10
*** signed8bit_ZZZzz is now known as signed8bit14:10
*** signed8bit is now known as signed8bit_ZZZzz14:10
*** signed8bit_ZZZzz is now known as signed8bit14:10
*** changbl has quit IRC14:10
*** tomoe__ has joined #openstack-neutron14:11
*** dane_leblanc has joined #openstack-neutron14:11
*** tomoe_ has quit IRC14:13
*** Marga_ has joined #openstack-neutron14:15
*** kbringard has joined #openstack-neutron14:16
*** anshul has quit IRC14:17
*** FJB has quit IRC14:19
*** Marga_ has quit IRC14:20
*** rpothier has joined #openstack-neutron14:20
*** watanabe_isao has quit IRC14:20
*** tiswanso has joined #openstack-neutron14:21
*** tiswanso has quit IRC14:22
*** tiswanso has joined #openstack-neutron14:22
*** maishsk has joined #openstack-neutron14:24
openstackgerritIhar Hrachyshka proposed openstack/neutron-vpnaas: Fallback to new l3 agent main() location  https://review.openstack.org/15660214:25
*** tiswanso has quit IRC14:26
*** johnbelamaric has quit IRC14:26
*** tiswanso has joined #openstack-neutron14:27
*** shwetaap has joined #openstack-neutron14:28
*** xuhanp has quit IRC14:28
*** johnbelamaric has joined #openstack-neutron14:28
otherwiseguymarkmcclain: ping14:29
*** regXboi has joined #openstack-neutron14:29
*** shwetaap1 has joined #openstack-neutron14:29
*** murugan has quit IRC14:30
*** aranjan has joined #openstack-neutron14:31
otherwiseguymarkmcclain: Does the explanation/TODO I added to https://review.openstack.org/#/c/153067/ address your concerns? Two cores have +2'd the patch, and one has +1'd, but they wanted to give you a chance to comment.14:31
*** anish_ has joined #openstack-neutron14:31
*** pradk has quit IRC14:32
*** shwetaap has quit IRC14:32
*** aranjan has quit IRC14:35
*** ramishra_ has joined #openstack-neutron14:39
*** pradk has joined #openstack-neutron14:39
*** zz_jgrimm is now known as jgrimm14:40
*** mzbik_ has quit IRC14:40
*** tomoe__ has quit IRC14:42
*** ramishra_ has quit IRC14:43
ihrachyshkaotherwiseguy, ajo, do you know what's the big reason to have netns_cleanup tool monkey-patched?14:45
*** yamamoto has joined #openstack-neutron14:46
otherwiseguyihrachyshka: I can't immediately think of any reason for it to be.14:47
* otherwiseguy looks14:47
*** tomoe_ has joined #openstack-neutron14:47
ihrachyshkaotherwiseguy, I wonder whether we should move cli tools into e.g. neutron/cmd/tools/... and all patched entry points for agents and services into neutron/cmd/{agents,services}, and monkey patch only the latter14:48
*** localloop127 has joined #openstack-neutron14:48
otherwiseguyihrachyshka: looks like its been that way since markmcclain wrote it, maybe he knows?14:49
ihrachyshkaotherwiseguy, though that would mean that we run tools unpatched while we test them in patched unit test env...14:49
otherwiseguy ihrachyshka: if it hasn't hurt anything yet being monkeypatched when it didn't need to be, maybe just leave everything under cmd with patched __init__.py and get more complicated only if we have to?14:52
ihrachyshkaotherwiseguy, yeah, but at the same time there is stuff in the tree that runs unpatched, and I hate it :)14:53
ihrachyshkaotherwiseguy, so it's a change for one side or another14:53
ihrachyshkaprobably patching everything is the right thing..14:53
ajoihrachyshka, not sure, I guess because we're using eventlet without calling the native methods?14:54
ajowhere native=eventlet specific methods14:54
*** dboik has joined #openstack-neutron14:55
ajoihrachyshka, why would you like to un-monkeypatch?14:55
otherwiseguyihrachyshka: Have you considered just migrating everything off of eventlet as the fix? :)14:55
otherwiseguydepth-first fixing FTW :)14:55
ajo:D14:56
ihrachyshkaotherwiseguy, hehe, oslo team would celebrate the fact for several months once it occurs14:56
*** zz_avozza is now known as avozza14:56
ajothe change in neutron would be massive14:56
otherwiseguyihrachyshka: Be the hero we need. :D14:56
*** lazy_prince is now known as killer_prince14:56
ihrachyshkaotherwiseguy, though... I don't believe neutron community is capable to start writing thread safe code in python immediately14:56
ihrachyshkaotherwiseguy, I know multiple places in the code that rely on specific sections to not yield14:57
otherwiseguyihrachyshka: Some of us have C backgrounds and have done all kinds of work with threads. :)14:57
*** tiswanso has quit IRC14:57
ihrachyshkaotherwiseguy, yeah, I know. I wrote in C before neutron. something for bind9 with all kinds of weird paranoid locks14:58
ihrachyshkaotherwiseguy, but it's not a general thing I guess14:58
ihrachyshkaotherwiseguy, it's so easy to rely on eventlet not to yield14:58
ihrachyshka'rely' as in 'hope'14:58
*** banix has quit IRC15:00
*** mwagner_lap has joined #openstack-neutron15:01
*** mestery_ is now known as mestery15:01
*** irenab has quit IRC15:03
*** dims__ has quit IRC15:03
*** dims__ has joined #openstack-neutron15:04
*** dims__ has quit IRC15:04
*** trad511 has joined #openstack-neutron15:04
*** tflynn has joined #openstack-neutron15:04
*** dims__ has joined #openstack-neutron15:05
*** banix has joined #openstack-neutron15:05
*** tflynn has quit IRC15:05
*** tflynn has joined #openstack-neutron15:06
*** seizadi has joined #openstack-neutron15:06
*** julien_ZTE has joined #openstack-neutron15:07
*** amotoki has joined #openstack-neutron15:07
*** absubram has joined #openstack-neutron15:09
*** salv-orlando has quit IRC15:11
*** salv-orlando has joined #openstack-neutron15:13
*** maishsk has quit IRC15:14
*** carl_baldwin has joined #openstack-neutron15:16
*** shaohe_feng has joined #openstack-neutron15:16
*** Marga_ has joined #openstack-neutron15:16
*** a_le has joined #openstack-neutron15:16
*** tarun has quit IRC15:16
*** marrusl has quit IRC15:18
*** rm_work|away is now known as rm_work15:18
*** Murali has quit IRC15:18
*** txomon|fon has quit IRC15:19
*** tflynn has quit IRC15:19
*** maishsk has joined #openstack-neutron15:19
*** tflynn has joined #openstack-neutron15:19
*** marrusl has joined #openstack-neutron15:20
*** Marga_ has quit IRC15:21
*** Networkn3rd has joined #openstack-neutron15:21
ihrachyshkaamotoki, hey!15:22
amotokiihrachyshka: hi15:23
ihrachyshkaamotoki, re https://review.openstack.org/#/c/155412/1/neutron/cmd/agents/plugins/bigswitch/restproxy_agent.py15:23
ihrachyshkaamotoki, do you think we should make the same for all services?15:23
ihrachyshkaamotoki, or just 3party?15:23
*** nmagnezi has quit IRC15:23
*** jaypipes has quit IRC15:24
amotokiihrachyshka: I think it is specific to thirdparty. In general, it is good to keep these kind of things in cmd/*15:25
ihrachyshkaamotoki, but it's not clear where to divide agent code into cmd part and library part15:25
amotokiihrachyshka: When looking at nova/cmd for example, they have similar contents in cmd repo15:25
*** seizadi1 has joined #openstack-neutron15:25
ihrachyshkaamotoki, I think that was one of concerns from markmcclain that I move parts of agent code deliberately15:26
*** tiswanso has joined #openstack-neutron15:26
*** seizadi has quit IRC15:26
*** jobewan has joined #openstack-neutron15:27
ihrachyshkaamotoki, obviously dumb main() would mean another level of traceback (entry_point calls to dumb main(), dumb main() calls to real main())15:27
*** vinsh has joined #openstack-neutron15:27
amotokiihrachyshka: yeah, it is difficult... dumb main() vs small stuff.15:28
*** naggappan has quit IRC15:28
markmcclainso reading the scrollback is that we're scattering stuff everywhere in teh code base15:28
*** yfried_ has quit IRC15:28
ihrachyshkaamotoki, so I would better not leave two different approaches in the tree and make everything uniform (either have all real main()s in neutron/cmd, or dumb only for all services)15:28
*** seizadi has joined #openstack-neutron15:29
ihrachyshkamarkmcclain, would dumb main()s that only call to real main() located in the old location work for you?15:29
markmcclainwhat's the utility of the indirection?15:29
*** nlahouti has joined #openstack-neutron15:30
ihrachyshkamarkmcclain, having eventlet monkey_patch consolidated in one place and applied to all entry points15:30
*** seizadi1 has quit IRC15:30
markmcclainihrachyshka: what if we're doing it wrong?15:30
markmcclainie what if eventlet and monkeypatching is the real problem15:30
ihrachyshkamarkmcclain, elaborate15:30
ihrachyshkamarkmcclain, ah, well... yeah, that's a problem15:30
ihrachyshkabut it's not something we can solve now15:31
openstackgerritAnn Kamyshnikova proposed openstack/neutron: Skip DBDuplicateEntry exception in security group creation  https://review.openstack.org/15578915:31
ihrachyshkaeven oslo libs are not ready to drop it15:31
ihrachyshkamarkmcclain, in long term, sure we should switch to threads15:31
*** aranjan has joined #openstack-neutron15:31
markmcclainihrachyshka: I thought many of the oslo threads will just work with threads15:32
*** seizadi1 has joined #openstack-neutron15:32
markmcclainit was using other forms of concurrency that might not work (asyncio, gevent directly, etc)15:32
*** achanda has joined #openstack-neutron15:32
markmcclains/oslo threads/oslo libs/15:32
ihrachyshkamarkmcclain, I agree we should look into this direction15:33
otherwiseguymarkmcclain: if you have a couple of seconds to respond to my response to your concerns on run_as_root patch (https://review.openstack.org/#/c/153067), I'd be very appreciative. :)15:33
*** seizadi has quit IRC15:33
markmcclainotherwiseguy: it is on my stack of things to catch up on after the long weekend15:33
ihrachyshkamarkmcclain, but I have plenty of examples where neutron code is just not ready to switch contexts deliberately15:33
*** jobewan has quit IRC15:34
*** tiswanso has quit IRC15:34
*** nlahouti has quit IRC15:34
*** tiswanso has joined #openstack-neutron15:34
*** tflynn has quit IRC15:34
markmcclainihrachyshka: example?15:35
ihrachyshkamarkmcclain, neutron/agent/l3/router_processing_queue.py15:35
ihrachyshkamarkmcclain, the way we fill in the queue assumes we don't yield randomly15:36
*** seizadi has joined #openstack-neutron15:36
*** aranjan has quit IRC15:36
markmcclaineventlet naturally yeilds randomly15:36
*** shilpa_ has joined #openstack-neutron15:36
ihrachyshkamarkmcclain, not at all15:36
*** seizadi1 has quit IRC15:37
*** Aish has joined #openstack-neutron15:37
openstackgerritMerged openstack/neutron: Remove RPC dependency to create FIP agent gw port  https://review.openstack.org/15372915:37
ihrachyshkamarkmcclain, it yields in special magic cases everyone should keep in his mind15:37
markmcclainit's the reason we find so many random deadlocks15:37
markmcclainmost devs don't expect eventlet to yield in teh places it does15:37
*** tomoe_ has quit IRC15:37
*** tflynn has joined #openstack-neutron15:37
ihrachyshkayeah, but they are not actually random, it's just that keeping all places where it may yield in mind is hard15:37
markmcclainnot certain I agree with taht… we'll often find devs adding log messages for other purposes that then cascade into other layers15:38
ihrachyshkasure, logs can yield (sometimes)15:39
*** Marga_ has joined #openstack-neutron15:39
*** manishg has joined #openstack-neutron15:40
ihrachyshkamarkmcclain, btw I feel dejavu, we had similar conversation ~ a year ago :)15:40
amotokiagree. we are using many libs and small change (with output) leads to eventlet yield changes.,, it seems random from most devs.15:40
*** seizadi1 has joined #openstack-neutron15:40
*** seizadi has quit IRC15:40
*** Marga_ has quit IRC15:40
ihrachyshkaamotoki, if it would yield truly randomly, we would get deadlocks every minute :)15:41
*** pal has quit IRC15:41
*** Marga_ has joined #openstack-neutron15:41
markmcclainihrachyshka: it is kind of is15:41
*** achanda has quit IRC15:41
*** maishsk has quit IRC15:41
markmcclainihrachyshka: all you need is a slow worker or slower connection and the timings can change significantly15:42
markmcclainit's the reason why nova tests can variable between runs with nova-net and neutron15:42
ihrachyshkamarkmcclain, zzzeek from oslo.db actually pushs for using threads. we'll see how it goes.15:42
*** maishsk has joined #openstack-neutron15:42
markmcclainihrachyshka: yeah… his commentary was a good explanation of the issue15:43
markmcclainihrachyshka: several components of openstack-infra use native threads and have for some time :)15:43
ihrachyshkamarkmcclain, that's nova legacy, playing with async was huge that time I guess :D15:44
*** seizadi1 has quit IRC15:44
*** devvesa_ has joined #openstack-neutron15:44
openstackgerritMerged openstack/neutron: Setup br-tun in secure fail mode to avoid broadcast storms  https://review.openstack.org/15532815:44
*** maishsk has quit IRC15:44
*** tiswanso has quit IRC15:44
markmcclainyeah and also some parts started with twisted in early iterations15:45
ihrachyshkamarkmcclain, do you want us to consider threads for the next cycle? not complete switch, but adding a threading mode15:45
markmcclainihrachyshka: I do think looking at threads in some of the agents is something we should consider15:45
*** seizadi has joined #openstack-neutron15:45
ihrachyshkamarkmcclain, right, we may try to switch one by one. cool, I'll think about it more.15:45
*** maishsk has joined #openstack-neutron15:45
*** seizadi has quit IRC15:46
markmcclainihrachyshka: right they're isolated in a way that we have that option15:46
markmcclainit's also the reason why moving everything to a central cmd module makes me uneasy15:47
*** devvesa has quit IRC15:47
openstackgerritAnn Kamyshnikova proposed openstack/neutron: Skip DBDuplicateEntry exception in security group creation  https://review.openstack.org/15578915:48
*** a_le has quit IRC15:48
ihrachyshkamarkmcclain, it won't be hard to split neutron/cmd/ into two parts, one patched and one unpatched, later if we want to do it15:49
markmcclainihrachyshka: it's more that we end of moving option definition out of the location where they are used15:49
*** xgerman has joined #openstack-neutron15:49
*** tflynn has quit IRC15:49
markmcclainnot certain I want to repeat the anti-pattern we have in common/constants15:49
*** tflynn has joined #openstack-neutron15:50
ihrachyshkamarkmcclain, that's why I ask whether putting dumb main()s under neutron/cmd/... instead would be a better options15:50
markmcclainexcept what do you dumb mains() avoid? three lines of explict monkeypatching?15:51
*** zzzeek has joined #openstack-neutron15:51
*** rdo has quit IRC15:51
markmcclains/you/the/15:51
* markmcclain needs more coffee this morning 15:51
*** maishsk has quit IRC15:51
*** a_le has joined #openstack-neutron15:52
*** pal has joined #openstack-neutron15:52
ihrachyshkamarkmcclain, it avoids loosing monkey patch randomly during refactoring. it also makes sure we monkey patch before any other imports.15:52
ihrachyshkamarkmcclain, we got monkey_patch() lost before during l3 agent refactoring15:52
ihrachyshkamarkmcclain, https://bugs.launchpad.net/neutron/+bug/141738615:53
openstackLaunchpad bug 1417386 in neutron "AttributeError: _oslo_messaging_localcontext errors found in neutron l3-agent logs" [High,In progress] - Assigned to Ihar Hrachyshka (ihar-hrachyshka)15:53
*** rdo has joined #openstack-neutron15:53
*** Marga_ has quit IRC15:53
*** r-daneel has joined #openstack-neutron15:54
*** manishg has quit IRC15:54
ihrachyshkamarkmcclain, also see https://review.openstack.org/#/c/154642/1/specs/eventlet-best-practices.rst for some context on how to use eventlet in sane way.15:55
*** ajmiller has joined #openstack-neutron15:56
markmcclainright.. that's in my review queue15:57
*** marun has joined #openstack-neutron15:57
ihrachyshkamarkmcclain, ok, I think I will now stop bothering you too much and allow you to do some actual work. :) thanks for the chat.15:58
roaethow can I search review.openstack for the change Merge "Split base function of v2_0.Client into a separate class"? I am getting 'invalid operators' in the search area15:59
amotokiihrachyshka: let me think a bit more tomorrow. I started to think thim main() looks better, but I had beer tonight and am going to bed.16:00
ihrachyshkaamotoki, enjoy! no rush :)16:00
roaetnevermind was searching wrong project D:16:00
*** sdague has quit IRC16:00
ihrachyshkaamotoki, you can also reply to corresponding thread in openstack-dev@16:00
*** tiswanso has joined #openstack-neutron16:01
amotokiihrachyshka: sure. I just remember you sent a mail to the dev list.16:01
*** baoli has quit IRC16:01
*** marun has quit IRC16:01
roaetamotoki: Ah you leaving? I was wondering if the changes to https://review.openstack.org/#/c/148318/ would suffice, but I understand you're probably sleepy heh.16:01
*** sdague has joined #openstack-neutron16:02
roaetit's failing jenkins... somehow, but I'll figure it out. silly rebases16:02
*** achanda has joined #openstack-neutron16:05
amotokiroaet: yeah, leaving now. Let me check tomorrow or the other day.16:06
roaetamotoki: it's cool. I'll fix the UT, I appreciate your time.16:06
amotokiroaet: re: another question from you "how can I search..." what is the problem?16:06
*** achanda has quit IRC16:06
roaetamotoki: I figured it out, thank you. I was searching the wrong project. I wanted to search by 'commit title' but merged+project was fine.16:07
amotokiroaet: I think the easiest way is to input CHnage-ID.16:07
*** tflynn has quit IRC16:07
roaetamotoki: i know the commit is yours, but I'm getting failures on SSL+client. Trying to solve the UT fails.16:08
*** jorgem has joined #openstack-neutron16:08
amotokiroaet: thanks. sorry if there is some actual failure.16:09
openstackgerritPaul Michali proposed openstack/neutron-vpnaas: VPNaaS Enable coverage testing for functional tests  https://review.openstack.org/15588916:09
roaetamotoki: I will debug. I am sure it's just randomness.16:09
*** MarkB1 has joined #openstack-neutron16:10
*** armax has joined #openstack-neutron16:11
*** reed has joined #openstack-neutron16:11
*** amotoki has quit IRC16:13
*** roeyc has quit IRC16:14
*** Sam______ has joined #openstack-neutron16:14
Sam______Hi neutron people !16:14
Sam______I'm looking for a way to get all not assigned Ip of a neutron network16:14
Sam______is that possible plz ?16:15
Sam______I want to select an Ip according to certain fact, and make a nova boot with a fixed IP16:15
Sam______but I'm unable to find the way to retrieve all free ip ...16:15
openstackgerritJustin Hammond proposed openstack/python-neutronclient: Client command extension support  https://review.openstack.org/14831816:17
*** aranjan has joined #openstack-neutron16:17
enikanorov__Sam______: you may inspect target subnet and already allocated ports16:21
enikanorov__that should give you a range of available IPs, you need to exclude allocated16:21
*** tflynn has joined #openstack-neutron16:22
*** aranjan has quit IRC16:22
*** changbl has joined #openstack-neutron16:26
Sam______enikanorov__: thanks, I was wondering if there is a wrapper in nutron for that like neutron subnet <my_subnet> get-free-ip16:28
*** ramishra_ has joined #openstack-neutron16:31
prometheanfireso.... about parsing intface names and us sucking at it...16:33
openstackgerritIhar Hrachyshka proposed openstack/neutron-vpnaas: Fallback to new l3 agent main() location  https://review.openstack.org/15660216:33
prometheanfireI'm working on getting interface names properly, not via iproute2 since it's next to imposible with all the interface types and all16:33
prometheanfirehere's the changeset currently https://review.openstack.org/#/c/154128/416:33
prometheanfireI want to just poll sysfs for it instead16:34
prometheanfireI asked the iproute2 devs how we should pull interface names from them and they said we shouldn't (something I also heavilly agree with)16:34
prometheanfirehttp://marc.info/?l=linux-netdev&m=14241866481638916:34
prometheanfireso, what should be the method we pull names with?16:34
prometheanfirethe current method in that changeset doesn't work with macvlan, but that could be fixed easilly16:36
prometheanfirebut it's always going to be another thing16:36
haleybprometheanfire: i think there was a change recently to lok in /sys/class/net for tap devices, https://review.openstack.org/#/c/154021/ so perhaps that is best?16:37
*** SridharRamaswamy has joined #openstack-neutron16:37
*** seizadi has joined #openstack-neutron16:38
haleybi think that was something shemminger mentioned16:38
*** nlahouti has joined #openstack-neutron16:38
*** gridinv has quit IRC16:39
prometheanfireya, I generally prefer to look in sys for this type of thing16:40
prometheanfireI wanted to do it for another change as well but went another way (we were using modinfo, which didn't work for built ins)16:41
prometheanfireya, that change is good16:41
haleybi just wonder what in ip_lib would need to change16:41
*** manishg has joined #openstack-neutron16:41
prometheanfireneutron/agent/linux/ip_lib.py16:41
*** ronis has quit IRC16:41
prometheanfire101 class IPWrapper(SubProcessBase):16:42
haleybyes, the evil parser of /sbin/ip :)16:42
prometheanfire110     def get_devices(self, exclude_loopback=False):16:42
openstackgerritenikanorov proposed openstack/neutron: Unify logic that determines liveliness of DHCP agent  https://review.openstack.org/15289116:42
prometheanfiresince we are just getting info in that method it's easier16:42
*** tflynn has quit IRC16:42
prometheanfireand it fixes a single bug16:42
*** shaohe_feng has quit IRC16:45
*** pal has quit IRC16:47
*** ihrachyshka has quit IRC16:49
*** Marga_ has joined #openstack-neutron16:49
*** coolsvap is now known as coolsvap_16:51
*** devvesa_ has quit IRC16:52
*** rwsu has joined #openstack-neutron16:52
anteayaobondarev: have you considered venturing into the nova channel?16:54
anteayaobondarev: and talking to the nova devs?16:54
openstackgerritSwaminathan Vasudevan proposed openstack/neutron: Get rid of rpc to fetch fip agent port on agent.  https://review.openstack.org/15373516:56
*** nivtuckio has joined #openstack-neutron16:57
openstackgerritSwaminathan Vasudevan proposed openstack/neutron: Fix FIP agent gw port delete based on external net  https://review.openstack.org/14585916:57
amullerarmax: Can you take a look at https://review.openstack.org/#/c/155813/ again?16:58
amullerarmax: Only change since Gary +2'd and Rajeev and Swami +1'd is that I simplified the functional tests and added some more info the commit message, no changes to the actual agent fix16:58
amullerarmax: I'd like to merge that today if possible so that my VMs could stop crashing every time I forget not to run that one test =D16:59
*** carlp has joined #openstack-neutron16:59
*** mlavalle has joined #openstack-neutron17:00
*** scheuran has quit IRC17:00
*** simon-AS559 has joined #openstack-neutron17:00
*** Aish has quit IRC17:01
*** Guest31726 is now known as dank_17:01
*** matrohon has quit IRC17:01
*** claudiub_ has joined #openstack-neutron17:04
*** marun has joined #openstack-neutron17:04
prometheanfireis it odd to -1 your own changeset17:04
prometheanfire?17:04
amullerprometheanfire: not at all17:05
*** baoli has joined #openstack-neutron17:05
amullerprometheanfire: you could also mark as WIP and explain what's left to do in the commit message17:05
haleybmarking WIP will also stop it from merging accidentally17:06
*** ivar-lazzaro has joined #openstack-neutron17:06
*** claudiub has quit IRC17:07
*** ivar-lazzaro has quit IRC17:09
*** ivar-lazzaro has joined #openstack-neutron17:10
*** evgenyf has quit IRC17:10
*** ramishra_ has quit IRC17:10
*** emagana_ has quit IRC17:10
*** _cjones_ has joined #openstack-neutron17:10
*** ygbo has quit IRC17:11
*** julien_ZTE has quit IRC17:11
*** julien_ZTE has joined #openstack-neutron17:12
*** julien_ZTE has quit IRC17:12
*** jlanoux has quit IRC17:12
*** julien_ZTE has joined #openstack-neutron17:13
*** changbl has quit IRC17:13
*** pask81 has quit IRC17:15
*** simon-AS5591 has joined #openstack-neutron17:15
*** julien_ZTE has quit IRC17:17
*** simon-AS559 has quit IRC17:18
openstackgerritgaryk proposed openstack/neutron: Fix parameters in exception handling  https://review.openstack.org/15659017:18
*** moshele has quit IRC17:20
*** shilpa_ has quit IRC17:20
*** aepifanov has quit IRC17:20
*** belmoreira has quit IRC17:21
*** MarkB1 has quit IRC17:21
*** simon-AS5591 has left #openstack-neutron17:21
openstackgerritBrent Eagles proposed openstack/neutron: Make shallow copy of attribute map a little deeper  https://review.openstack.org/15667017:21
*** doude has quit IRC17:21
*** a_le has quit IRC17:22
*** jorgem has quit IRC17:23
*** carl_baldwin has quit IRC17:23
*** tflynn has joined #openstack-neutron17:23
*** jistr has quit IRC17:24
*** jaypipes has joined #openstack-neutron17:26
*** Networkn3rd has quit IRC17:26
*** dboik_ has joined #openstack-neutron17:28
*** jobewan has joined #openstack-neutron17:29
*** annegent_ has joined #openstack-neutron17:29
*** dboik_ has quit IRC17:29
*** dboik_ has joined #openstack-neutron17:30
*** Aish has joined #openstack-neutron17:31
*** tflynn has quit IRC17:32
*** SridharG1 has joined #openstack-neutron17:32
*** dboik has quit IRC17:32
*** SridharG has quit IRC17:32
*** a_le has joined #openstack-neutron17:35
*** SridharG has joined #openstack-neutron17:36
*** SridharG1 has quit IRC17:36
*** suresh12 has joined #openstack-neutron17:37
*** nyechiel_ has quit IRC17:37
*** SridharG has left #openstack-neutron17:40
*** jprovazn has joined #openstack-neutron17:42
*** pal has joined #openstack-neutron17:45
*** cipcosma has quit IRC17:45
*** thedodd has joined #openstack-neutron17:46
*** dboik_ has quit IRC17:47
*** jorgem has joined #openstack-neutron17:47
*** dboik has joined #openstack-neutron17:47
*** SridharRamaswamy has quit IRC17:50
*** cipcosma has joined #openstack-neutron17:50
*** rotbeard has joined #openstack-neutron17:50
*** carl_baldwin has joined #openstack-neutron17:52
*** marrusl has quit IRC17:54
pc_mdougwig: ping17:54
*** carl_baldwin_ has joined #openstack-neutron17:55
*** carl_baldwin has quit IRC17:56
*** carl_baldwin_ is now known as carl_baldwin17:56
*** tflynn has joined #openstack-neutron17:56
*** Aish has left #openstack-neutron17:58
pc_mHi folks! I'm seeing some odd things with cross project dependencies and am wondering if I'm missing some steps, can anyone advise?17:58
anteayapc_m: what are you seeing?17:58
anteayaand since they are new it might be a bug17:58
*** yamamoto has quit IRC17:59
*** anish_ has quit IRC17:59
pc_mHere's the scenario... I have the latest neutron code on my machine. In the neutron-vpnaas repo, I patch in (git review -d) code that is out for review.17:59
anteayawhich patch?17:59
*** jschwarz has joined #openstack-neutron18:00
*** ronis has joined #openstack-neutron18:00
pc_mWhen I run UTs, they fail because the patch set is not up to date with the latest.18:00
pc_m14439118:00
*** wverdugo500 has joined #openstack-neutron18:00
pc_mHowever, for the developer, the patch set is working. I think he has an older neutron commit.18:00
anteayaso your question is about your unit test failure?18:01
pc_mSo, that had me wondering how one can make sure they have the two in sync.18:01
pc_manteaya: I was able to solve the unit test failure, by rebasing. What is disturbing, is that the python27 passes in the review18:02
anteayalet's start again18:02
*** aepifanov has joined #openstack-neutron18:02
*** dsneddon has joined #openstack-neutron18:03
anteayaso far this has nothing to do with cross repo dependencies18:03
*** tflynn has quit IRC18:03
pc_mIf it had the latest neutron, it should have failed18:03
anteayaso for starters what is the exact command you ran to get the patch to your local environment?18:03
pc_mOK. Let me try to replay this scenario. I'm not being clear...18:03
anteayaI'm trying to reproduce18:04
pc_mCode revuew 144391 passes python27 in Jenkins.18:04
anteayawhat is the exact git review -d command you used?18:04
pc_mOn my system, I did a update of my neutron repo to match latest upstream.18:04
pc_mIn the VPN repo, I did 'git review -d 144391'18:04
pc_mWhen I run 'tox -e py27', the tests fail.18:05
pc_mThe failure is because of a change that was made in neutron, and was missing a change in neutron-vpnaas. Commit 1fed46b2 fixes that.18:06
pc_mIf I rebased this neutron-vpnaas view with latest upstream, the code gets the commit for 1fed46b2 and tests pass.18:06
*** yamahata has joined #openstack-neutron18:06
pc_mQuestions are... why is the Jenkins test passing (and it is working in the committer repo AFIK)?18:07
pc_mIf there is a change in our local neutron repo, how do we make sure that our local neutron-vpnaas is indeed picking up the change?18:08
pc_manteaya: That's what I'm wondering. Does that make sense (the questions at least)?18:08
anteayaI'm trying to follow you18:08
anteayaI find when we talk you are usually way ahead of me using different words that I would use for things18:09
anteayaso I am trying to catch up to you18:09
jamielennoxhi mestery, any word on that neutronclient release?18:09
pc_mMy guess on the second question is that I need to run setup.py install in the neutron directory so that the neutron-vpnaas gets the updated egg18:09
anteayalet's deal with one thing at a time18:09
*** jpena has quit IRC18:09
anteayaon gerrit18:09
*** ZZelle_ has joined #openstack-neutron18:09
pc_manteaya: sorry, I'm probably using the wrong terms.18:10
mesteryjamielennox: I'm awaiting one more patch which I hope will merge today/tomorrow, then I'll cut it. Sound ok?18:10
openstackgerritTerry Wilson proposed openstack/neutron-vpnaas: Stop storing and passing root_helper  https://review.openstack.org/15669018:10
openstackgerritTerry Wilson proposed openstack/neutron-vpnaas: Remove remaining root_helper references  https://review.openstack.org/15669118:10
pc_manteaya: sure...go ahead...18:10
anteayapc_m: so when neutron master changes, does neutron-vpnaas pick that up?18:10
jamielennoxmestery: yep - that's fine, just checking you hadn't forgotten - thanks18:10
mesteryjamielennox: No worries, and thanks for following up!18:10
anteayapc_m: for the neutron-vpnaas gerrit patches?18:10
*** harlowja_away is now known as harlowja_18:10
*** carl_baldwin has quit IRC18:11
openstackgerritTerry Wilson proposed openstack/neutron-fwaas: Stop storing and passing root_helper  https://review.openstack.org/15669218:11
*** emagana has joined #openstack-neutron18:12
pc_manteaya: Yeah, I guess that is the question. Neutron had a change, which broke VPN repo (not exactly sure when that happened, but the fix on neutron-vpnaas went in on 2/12).18:13
anteayaas of right now18:13
anteayado neutron-vpnaas patches incorporate lastest neutron master for testing?18:13
pc_manteaya: With patch set 35 of 144391, it went up on 2/15 (appears to not have picked up that change).18:13
*** ihrachyshka has joined #openstack-neutron18:13
roaetanyone run into 'str' does not support the buffer interface when installing sphinx into py34 tox env?18:13
*** annegent_ has quit IRC18:14
pc_manteaya: I'm not sure exactly how that works. It uses an egg file18:14
*** carl_baldwin has joined #openstack-neutron18:14
anteayaso if neutron-vpnaas patches are not picking up changes to neutron master then that is something that needs to be addressed18:14
anteayaI am not sure either, who wrote the tests18:14
pc_manteaya: The unit tests? they've been around for a long time.18:15
*** emagana has quit IRC18:15
anteayaas for your local neutron-vpnaas knowing about a local neutron change, that isn't something that gerrit can control18:15
anteayathe set up in the tests for neutron-vpnaas to depend on neutron18:15
pc_manteaya: sure. Just wondering if setup.py install is the way to sync those locally.18:16
*** jbonjean has quit IRC18:16
anteayaonce the service was split out, neutron-vpnaas needed to know about neutron to consume it, yes?18:16
anteayapc_m: let's work on one issue at a time18:16
otherwiseguypc_m: anteaya: btw, my root_helper patches could potentially break some of the *aaS stuff. I've gone through and tried to get the "fix" patches put up for review with Depends-On headers. I think we should be fine as long as we follow the depends.18:16
*** MentalRay has joined #openstack-neutron18:16
*** jbonjean has joined #openstack-neutron18:17
anteayabecause if the way your zuul tests are set up doesn't incorporate latest neutron master, that needs to be addressed18:17
otherwiseguyIn any case, once those start merging, I'll definitely be around for doing in quick fixups that need to be done.18:17
anteayaotherwiseguy: thanks for jumping in18:17
pc_motherwiseguy: That's what happened in one case. root_helper was changed in neutron, but not in neutron_vpnaas. However, a fix went into neutron-vpnaas for that on 1/12.18:18
*** moshele has joined #openstack-neutron18:18
*** achanda has joined #openstack-neutron18:18
*** thedodd has quit IRC18:18
pc_motherwiseguy: What's confusing me, is that there is a commit to neutron-vpnaas with a patch on 1/15 that passes, but does not have the VPN side fix.18:18
otherwiseguypc_m: at least after I kill root_helper entirely that particular change shouldn't cause breakage in the future. :)18:18
otherwiseguy(and by kill, I mean kill the passing of it everywhere)18:19
*** kawa2014 has quit IRC18:19
pc_motherwiseguy: So we have review 144391 with patch set 35 on 2/15, which should have the fix from 2/12, but does not. However, it passes Jenkins UT.18:20
*** leenheer has joined #openstack-neutron18:21
*** jbonjean has quit IRC18:21
* pc_m I meant 2/12 on the date that the fix went in above (not 1/12)18:21
*** SridharRamaswamy has joined #openstack-neutron18:22
*** jp_at_hp has quit IRC18:22
*** julien_ZTE has joined #openstack-neutron18:22
pc_motherwiseguy: anteaya: I could image that the developer maybe forgot a rebase on neutron-vpnaas repo, but am wondering if that should have been detected, and why the jenkins passed for UT (gate-neutron-vpnaas-python27)18:22
otherwiseguypc_m: I'm currently on a conference call, so my attention is a bit divided right now. :)18:23
pc_motherwiseguy: understood.18:23
pc_motherwiseguy: me too :)18:23
*** nlahouti has quit IRC18:24
*** changbl has joined #openstack-neutron18:24
anteayaokay18:25
anteayaso it is possible this is a legitimate bug in dependencies18:25
openstackgerritArmando Migliaccio proposed openstack/neutron: Add callbacks-based system to Neutron  https://review.openstack.org/15377418:25
openstackgerritArmando Migliaccio proposed openstack/neutron: Break coupling between ML2 and L3 during delete operation  https://review.openstack.org/15547018:25
openstackgerritArmando Migliaccio proposed openstack/neutron: Break coupling between ML2 and L3 during create/update operations  https://review.openstack.org/15377518:25
openstackgerritArmando Migliaccio proposed openstack/neutron: Decouple L3 and service plugins during DVR router migration  https://review.openstack.org/15474918:25
openstackgerritArmando Migliaccio proposed openstack/neutron: Decouple L3 base and VPN service plugins during router operations  https://review.openstack.org/15377618:25
*** nlahouti has joined #openstack-neutron18:25
anteayait is also possible that neutron-vpnaas is not testing off of latest neutron master18:25
anteayaso let's confirm that neutron-vpnaas tests use latest neutron master when testing18:26
pc_manteaya: That's what I'm worried about (not using latest neutron for some resone)18:26
anteayacan we agree on this is a first place to being18:26
anteayaokay18:26
pc_manteaya: That would be great18:26
anteayaso can you find the code that sets up the tests?18:26
anteayait should be in openstack-infra/project-config18:26
pc_mOK. I'll look18:27
*** jlibosva has quit IRC18:28
*** dane_leblanc_ has joined #openstack-neutron18:30
*** saju_m has joined #openstack-neutron18:30
anteayathanks18:30
anteayalet me know how you do18:30
*** jbonjean has joined #openstack-neutron18:31
anteayaI'd suggest zuul/layout.yaml and jenkins/project.yaml for starters18:31
*** irenab has joined #openstack-neutron18:31
*** julien_ZTE has quit IRC18:31
dougwigpc_m, anteaya - yes, there is a definite wart that currently neutron/neutron-*aas are testing master of each other, and having either out of date puts you in undefined land.18:32
*** carl_baldwin has quit IRC18:32
dougwigpc_m, anteaya - i'm floating this: https://review.openstack.org/#/c/154736/  as the ultimate solution, which is to get rid of this cross-repo intermingling.18:32
*** dane_leblanc has quit IRC18:33
dougwigwe don't so much have cross-repo dependencies, but rather dangerously co-mingled internal interfaces.18:33
anteayathat sounds like the phrase I was looking for18:33
pc_mdougwig: So in this case, it looks like a neutron-vpnaas commit, which is not up to date, is using a not up-to-date neutron.18:34
*** moshele has quit IRC18:34
*** dane_leblanc_ has quit IRC18:34
*** pal has quit IRC18:35
*** aranjan has joined #openstack-neutron18:35
pc_mdougwig: If it was using latest master on neutron, I would have thought it would have failed. Confused to say the least.18:37
*** jschwarz has quit IRC18:37
*** tomoe_ has joined #openstack-neutron18:38
dougwigso, we need to be testing master, but re-used tox environments let neutron get stale.  which will over get worse over time.  hmm.18:38
dougwigis there a way to make tox do the moral equivalent of 'git pull' on the neutron egg regularly?18:39
*** spandhe has joined #openstack-neutron18:40
*** devlaps has joined #openstack-neutron18:40
*** martingc_ is now known as martingc18:40
pc_mdougwig: So are you saying that Jenkins is reusing the tox environment?18:40
dougwigpc_m: no, jenkins does not.  it starts fresh every time.18:40
dougwigbut un-rebased patches may not have lockstep-necessary changes.18:41
openstackgerritSwaminathan Vasudevan proposed openstack/neutron: Fix FIP agent gw port delete based on external net  https://review.openstack.org/14585918:41
*** ramishra_ has joined #openstack-neutron18:41
pc_mdougwig: So I'm confused on why PS 35 passed jenkins with out of date vpn code18:41
*** tomoe_ has quit IRC18:42
openstackgerritBrent Eagles proposed openstack/neutron: Make shallow copy of attribute map a little deeper  https://review.openstack.org/15667018:43
pc_mdougwig: I would have thought neutron would have the latest code (with the change to root_helper), and this patch set does not have your 2/12 fix, so it should have failed, but it passed.18:44
anteayadougwig: where is the code that sets up the tests now for neutron-vpnaas?18:44
anteayathe part that says use this neutron egg18:45
pc_mdougwig: I did a "git review -d 144391" and it does not have the changes you made.18:45
*** jasondotstar has joined #openstack-neutron18:45
pc_mdougwig: and once I rebased in my area, everything was fine (it had the changes and passed the tests).18:45
*** ramishra_ has quit IRC18:46
dougwiganteaya: in tox.ini, when it's setting up dependencies.  the *aas repos have a special line for including neutron.18:47
*** moha_hunt has joined #openstack-neutron18:47
dougwigok, step back, i'd have to look at the code in question to see why that instance worked. but, i'm not sure it's worth the time, since there is a greater problem identified, it will continue to plague us, and the only way out of it is to break this co-mingled dance.  IMO.18:48
pc_mdougwig: So that is taking latest from git.openstack.org for neutron?18:48
anteayahttp://git.openstack.org/cgit/openstack/neutron-vpnaas/tree/tox.ini#n1318:48
anteayaso an egg is an archive yes?18:48
*** s3wong has joined #openstack-neutron18:48
anteayasome kind of package18:48
anteayaanyone know how often it gets created?18:49
pc_manteaya: yeah as far as I know.18:49
pc_manteaya: Wondering if it is not getting updated....18:49
anteayadoesn't seem that it is18:49
pc_manteaya: Right.18:49
*** devlaps has quit IRC18:49
pc_manteaya: Should the whole gating process, when a commit is approved, update the egg?18:50
*** jkyle1 has quit IRC18:50
anteayasounds like that is what is happening18:51
anteayaso somehow the dependency doesn't contain the latest code though18:51
anteayado we have a clear example of that?18:51
*** irenab has quit IRC18:51
dougwiganteaya: the egg is what setup.py/setup.cfg builds.18:51
anteayaawesome18:52
dougwigpc_m: gate gets fresh eggs, since it starts with bare vms.18:52
dougwigand now i'm getting hungry.18:52
dougwiganyone want breakfast?18:52
anteayaso what happened on the out of date code?18:52
* anteaya likes that idea18:52
anteaya'cept I have already had some18:52
anteayalunch is what I need next18:52
*** dane_leblanc has joined #openstack-neutron18:54
*** carl_baldwin has joined #openstack-neutron18:54
pc_mdougwig: hmm. I'm at a loss as to why this job is passing for the patch set.18:55
*** stefanb has quit IRC18:55
*** MentalRay has quit IRC18:55
roaetMeh. I can't figure out why my unit test is failing. Anyone noticing any issues with Security Groups' test_list_*_extend_* tests on py34?18:57
armaxroaet: looking18:57
roaetarmax: http://logs.openstack.org/18/148318/12/check/gate-python-neutronclient-python34/a133ec4/18:57
roaetif that helps18:57
roaetit's neutronclient either way.18:58
*** dboik_ has joined #openstack-neutron18:58
*** dboik_ has quit IRC19:01
banixroaet: the recheck passed19:01
*** dane_leblanc has quit IRC19:01
roaetAh.. sweet. banix thanks. I think there is a problem then on the SG tests.19:01
*** tiswanso has quit IRC19:01
roaetI think it failed due to the querystring being out of order.19:01
*** dboik_ has joined #openstack-neutron19:01
*** dboik has quit IRC19:01
roaetfields=name&id=myid1&id=myid3&id=myid2 vs fields=name&id=myid1&id=myid2&id=myid319:02
*** tiswanso_ has joined #openstack-neutron19:02
roaetI guess I can report that19:02
*** SridharRamaswam1 has joined #openstack-neutron19:04
banixroaet: sounds like it19:04
*** ihrachyshka has quit IRC19:04
*** SridharRamaswamy has quit IRC19:05
*** dane_leblanc has joined #openstack-neutron19:07
*** stefanb has joined #openstack-neutron19:10
*** ajo has quit IRC19:13
*** annegent_ has joined #openstack-neutron19:15
*** jprovazn has quit IRC19:16
*** irenab has joined #openstack-neutron19:17
*** openstackgerrit has quit IRC19:20
*** tflynn has joined #openstack-neutron19:20
*** annegent_ has quit IRC19:20
*** openstackgerrit has joined #openstack-neutron19:20
*** marun_ has joined #openstack-neutron19:21
*** ajo has joined #openstack-neutron19:22
*** marun has quit IRC19:23
*** markmcclain has quit IRC19:24
*** markmcclain has joined #openstack-neutron19:24
*** julien_ZTE has joined #openstack-neutron19:28
*** marun_ is now known as marun19:39
*** annegent_ has joined #openstack-neutron19:40
*** julien_ZTE has quit IRC19:42
openstackgerritMerged openstack/neutron: Delete qg device during DVR-SNAT router deletion  https://review.openstack.org/15581319:42
*** ramishra_ has joined #openstack-neutron19:42
*** ramishra_ has quit IRC19:47
prometheanfireso, what do you think of this?  https://gist.github.com/prometheanfire/2fb592e3eaa699f55f8919:47
prometheanfirehaven't changed the tests yet, but it'll fix errors methinks :P19:48
roaetbanix: is there a way to get the recheck on my change?19:48
roaet(as it is still showing -1)19:48
*** a_le has quit IRC19:49
banixroaet: it hasn’t finished; i think it will finish shortly19:50
banixroaet: http://status.openstack.org/zuul/19:50
*** nivtuckio has quit IRC19:50
roaetbanix: oh! i forgot all about that. Thanks again.19:51
*** a_le has joined #openstack-neutron19:51
banixroaet: python34 which had failed, passed a while back and that’s why i said the rechek has passed19:52
roaetbanix: yeah. I thought it'd only check failed ones. but yea19:52
roaetVery helpful reminder. thank you :)19:53
banixroaet: np19:53
openstackgerritManish Godara proposed openstack/neutron: Add filter for provider network attributes in ML2  https://review.openstack.org/12491719:54
*** irenab has quit IRC19:57
*** a_le has quit IRC20:02
*** a_le has joined #openstack-neutron20:02
*** SridharRamaswam1 has quit IRC20:03
*** Marga_ has quit IRC20:03
*** MentalRay has joined #openstack-neutron20:04
openstackgerritTerry Wilson proposed openstack/neutron: Remove root_helper arg from DHCP agent  https://review.openstack.org/15518820:08
rdohi all, anyone know of a way to manage the default security group? i.e. setting the template? I want to ensure that every tenant I create gets, say, port 22 open by default20:08
*** SridharRamaswamy has joined #openstack-neutron20:09
pc_mdougwig: ping20:11
*** tiswanso_ has quit IRC20:13
*** rushil_ has joined #openstack-neutron20:14
*** aranjan has quit IRC20:15
openstackgerritTerry Wilson proposed openstack/neutron: Remove root_helper arg from L3 Agent  https://review.openstack.org/15521220:15
*** rushil has quit IRC20:15
openstackgerritTerry Wilson proposed openstack/neutron: Remove root_helper arg from linux interface  https://review.openstack.org/15552220:15
*** aranjan has joined #openstack-neutron20:16
*** _cjones_ has quit IRC20:16
*** _cjones_ has joined #openstack-neutron20:16
openstackgerritTerry Wilson proposed openstack/neutron: Remove remaining root_helper args from plugins  https://review.openstack.org/15552320:17
openstackgerritTerry Wilson proposed openstack/neutron: Remove root_helper arg from sanity checks  https://review.openstack.org/15590520:17
haleybmarun: you made a change the other day for functional testing, right?  I now see this error running tox, "ERROR: InvocationError: could not find executable 'dsvm-functional:'" and reverting your change fixes it20:17
haleyband i'm just running a unit test20:17
openstackgerritTerry Wilson proposed openstack/neutron: Remove remaining uses of passing root_helper  https://review.openstack.org/15590620:17
*** leenheer has quit IRC20:18
*** annegent_ has quit IRC20:18
*** jordandh has quit IRC20:19
*** rpothier has quit IRC20:20
*** jordandh has joined #openstack-neutron20:20
*** jorgem has quit IRC20:21
*** jorgem has joined #openstack-neutron20:22
*** ronis has quit IRC20:25
openstackgerritFei Long Wang proposed openstack/neutron: Fix metering agent failure when chain missing  https://review.openstack.org/15619820:26
*** dboik_ has quit IRC20:28
*** dboik has joined #openstack-neutron20:30
*** leenheer has joined #openstack-neutron20:31
*** aranjan has quit IRC20:32
*** achanda has quit IRC20:36
*** annegent_ has joined #openstack-neutron20:41
*** tiswanso has joined #openstack-neutron20:42
*** MentalRay has quit IRC20:42
*** _cjones_ has quit IRC20:42
*** csoukup has quit IRC20:42
*** ramishra_ has joined #openstack-neutron20:43
*** dboik has quit IRC20:43
*** dboik has joined #openstack-neutron20:44
*** dboik has quit IRC20:44
amullerhaleyb: marun: Seeing the same symptom20:44
*** saju_m has quit IRC20:44
amullermarun: I think we're copying the rootwrap stuff for enviornments other than the functional one20:45
haleybamuller: seems marun is offline?  i'm looking at it now20:45
*** dboik has joined #openstack-neutron20:45
amullerhaleyb: it's done in tox.ini20:45
amullerthe new copy directive20:45
haleybyes, i'm assuming it should move lower in the file20:45
amullerhaleyb: the fix would be to make sure it happens only for the dsvm-functional env20:45
amullerand possibly the functional env, I'm not sure about that20:45
*** smcquaid has joined #openstack-neutron20:47
*** aranjan has joined #openstack-neutron20:47
*** ramishra_ has quit IRC20:48
*** Marga_ has joined #openstack-neutron20:48
*** vinsh has quit IRC20:48
*** csoukup has joined #openstack-neutron20:49
openstackgerritCarl Baldwin proposed openstack/neutron: Move Floating IP processing to Router classes  https://review.openstack.org/14286320:50
*** smcquaid has quit IRC20:50
*** jgrimm is now known as zz_jgrimm20:51
*** annegent_ has quit IRC20:53
*** cipcosma has quit IRC20:54
*** suresh12 has quit IRC20:56
openstackgerritBrian Haley proposed openstack/neutron: Un-break tox for unit tests  https://review.openstack.org/15676720:57
haleybamuller: try that ^^20:58
*** zz_jgrimm is now known as jgrimm20:58
HenryGhaleyb: amuller: I think you folks might just need to get a newer tox?20:59
*** leenheer has quit IRC20:59
haleybHenryG: well, when i revert that things are fine, and i'm on the one shipping with 14.0420:59
HenryGhaleyb: what version is that?21:00
HenryGtox --version21:00
haleyb1.6.0 imported from /usr/lib/python2.7/dist-packages/tox/__init__.pyc21:00
*** leenheer has joined #openstack-neutron21:00
openstackgerritRajeev Grover proposed openstack/neutron: WIP fix for _get_external_device_interface_name trace  https://review.openstack.org/15635721:00
*** localloop127 has quit IRC21:00
haleybHenryG:  this was a brand-new cloned repo too21:00
*** moshele has joined #openstack-neutron21:01
HenryGhaleyb: understood, just noting that the feature in tox.ini works with tox 1.8.121:01
haleybwhich is probaly why it passed the gate21:02
clarkb1.6.0 had the broken parameter substituion iirc21:02
clarkblet me double check that21:02
*** SridharRamaswamy has quit IRC21:03
haleybi'll update the commit string to mention the version of tox i'm running, but i think my change would work for both21:03
clarkbah no that was 1.6.221:03
*** SridharRamaswamy has joined #openstack-neutron21:04
haleybi suppose i could pip update too, but i shouldn't have to do that21:04
*** marun has quit IRC21:04
HenryGhaleyb: Both marun and I tried {[testenv]commands} and it didn't work21:04
*** moshele has quit IRC21:05
haleybHenryG: well it gets the unit tests working again :)  i can duplicate the other line, but what is the correct fix - force a tox update on everyone?21:06
*** jorgem has quit IRC21:07
*** suresh12 has joined #openstack-neutron21:08
*** localloop127 has joined #openstack-neutron21:08
openstackgerritBrian Haley proposed openstack/neutron: Un-break tox for unit tests  https://review.openstack.org/15676721:09
*** _cjones_ has joined #openstack-neutron21:11
*** jorgem has joined #openstack-neutron21:11
HenryGhaleyb: The way it was before my oblivious comment caused Maru to mess it up for you. :)  --> https://review.openstack.org/#/c/146113/31/tox.ini21:11
*** achanda has joined #openstack-neutron21:11
openstackgerritRajeev Grover proposed openstack/neutron: Prevent race conditions on DVR FIP resources  https://review.openstack.org/15342221:11
*** achanda has quit IRC21:11
HenryGhaleyb: You might want to replicate his inline comments from there.21:12
*** achanda has joined #openstack-neutron21:12
*** matrohon has joined #openstack-neutron21:12
haleybHenryG: thanks, i'll put the comments in21:12
*** watanabe_isao has joined #openstack-neutron21:14
openstackgerritBrian Haley proposed openstack/neutron: Un-break tox for unit tests  https://review.openstack.org/15676721:15
*** drjones has joined #openstack-neutron21:16
*** _cjones_ has quit IRC21:16
*** rushil_ has quit IRC21:17
*** annegent_ has joined #openstack-neutron21:17
*** aix has quit IRC21:20
*** moshele has joined #openstack-neutron21:21
*** suresh12 has quit IRC21:21
*** Marga_ has quit IRC21:24
*** Marga_ has joined #openstack-neutron21:25
*** Marga_ has quit IRC21:25
*** Marga_ has joined #openstack-neutron21:25
haleybHenryG: guess the other option is to change that minversion line to 1.8, which is where that option was added.  My "brand new" 14.04 VM does have 1.8.1, so it's just my old workstation (that i don't always to a pip update on) that's broken21:29
*** annegent_ has quit IRC21:29
*** Sam______ has quit IRC21:29
*** a_le has quit IRC21:30
*** drjones has quit IRC21:31
*** a_le has joined #openstack-neutron21:31
*** _cjones_ has joined #openstack-neutron21:31
HenryGhaleyb: That makes sense to me, but I don't want to cause pain21:32
HenryGhaleyb: I always run bleeding edge on all the things ;)21:32
haleybyes, bumping the version will cause someone else to scream when they don't have 1.8, then i'd be on the hot seat21:33
*** jorgem1 has joined #openstack-neutron21:33
*** changbl has quit IRC21:33
*** rotbeard has quit IRC21:34
HenryGhaleyb: If things get hot just open a window :)21:34
*** mwagner_lap has quit IRC21:35
*** jorgem has quit IRC21:35
openstackgerritMatthew Thode proposed openstack/neutron: Fixes bug in interface handling of ip_lib.py  https://review.openstack.org/15412821:35
haleybHenryG: or go roll around in the 100 tons of snow in my yard :)21:36
HenryGhaleyb: tell me about it! It's a real winter this year.21:37
*** changbl has joined #openstack-neutron21:38
haleybcomplete with great skiing :)21:39
prometheanfireI'd like feedback on the switch to getting interface names from sysfs instead of trying to parse iproute2 if any of you have time https://review.openstack.org/#/c/154128/21:41
Apsuprometheanfire: +121:41
prometheanfirealways welcome :P21:42
*** rm_work is now known as rm_work|away21:44
*** ramishra_ has joined #openstack-neutron21:44
openstackgerritPaul Michali proposed openstack/neutron-vpnaas: VPNaaS Enable coverage testing for functional tests  https://review.openstack.org/15588921:46
*** ramishra_ has quit IRC21:49
*** julien_ZTE has joined #openstack-neutron21:49
*** aranjan has quit IRC21:49
*** changbl has quit IRC21:51
*** zzzeek has quit IRC21:51
*** changbl has joined #openstack-neutron21:52
*** aranjan has joined #openstack-neutron21:54
*** aepifanov has quit IRC21:55
*** vinsh has joined #openstack-neutron21:56
*** banix has quit IRC21:57
*** jordandh has quit IRC21:59
*** jorgem1 has quit IRC22:00
*** jordandh has joined #openstack-neutron22:01
openstackgerritMerged openstack/neutron: Fix FIP agent gw port delete based on external net  https://review.openstack.org/14585922:01
*** leenheer has quit IRC22:02
*** marun has joined #openstack-neutron22:02
*** aranjan has quit IRC22:03
marunHenryG, haleyb, amuller: stop using distro-packaged python anything22:03
marunit's instantly outdated22:03
marunfine for long-running services, stupid for developers22:03
*** obondarev_ has joined #openstack-neutron22:04
marundevstack is working on stopping the insanity: https://review.openstack.org/#/c/156594/22:04
*** SridharRamaswamy has quit IRC22:05
haleybmarun: easily enough said, but the minversion in tox.ini says 1.6 is fine and it's not any more22:06
*** obondarev has quit IRC22:06
marunhaleyb: I'm not sure I understand why updating that version wouldn't have been your first choice, then.22:06
marunhaleyb: it's not like we're talking about stuff that has to be packaged for production22:07
haleybbecause i looked at your change and saw what got broken?22:07
prometheanfiremarun: if it's within the requirements.txt limits >=1.2.3,<2.3.4 then what does it matter?22:07
marunprometheanfire: you're assuming tox is in our requirements.txt22:07
*** thomasem has quit IRC22:08
marunprometheanfire: it's kind of a hole22:08
*** SridharRamaswamy has joined #openstack-neutron22:08
prometheanfireit is22:08
marunprometheanfire: where?22:08
prometheanfirefor tox specificly22:08
prometheanfireI was agreeing that it is a hole :D22:08
marunah22:08
marunhaleyb: I'm sorry for not fixing this sooner.22:09
marunhaleyb: armax and I were discussing the issue earlier - he ran into it too - but I didn't have a chance to get to it yet.22:09
prometheanfireI wonder if it should be in test-requiremetts22:09
haleybmarun: i can change the minversion, until HenryG pointed out the page he cited i had no idea why it was working that way22:09
haleybprometheanfire: tox.ini does specify a version22:10
prometheanfirethat helps22:10
marunprometheanfire: I'm assuming the reason for not having it in requirements is that invocation is generally outside of the venv22:10
prometheanfireya22:10
*** achanda has quit IRC22:10
*** salv-orlando has quit IRC22:10
prometheanfireI see that reason22:10
prometheanfirewe don't even run tests through tox22:11
marunhaleyb: Maybe it's best that we go back to how I originally had it.22:11
prometheanfirewe use distro installed python packages :P22:11
prometheanfireso it's harder22:11
HenryGhaleyb: If you set minversion in tox.ini, what happens if you use tox < minversion ?22:11
marunprometheanfire: just what we need, more friction22:11
haleybERROR: tox version is 1.6, required is at least 1.822:11
haleybHenryG: ^^22:11
prometheanfiremarun: this is all on our side (distro packaging)22:11
prometheanfirewe allow for testinging before install22:12
marunas a python developer, I pretty much hate distro packaging of python deps22:12
prometheanfireall other distros don't (that I know of)22:12
marunbut i'm a developer.22:12
prometheanfireI think we do it very well in gentoo :P22:12
*** crc32 has joined #openstack-neutron22:12
marundistro packages are not for developers22:12
prometheanfirehow is what we install diferent?22:12
*** changbl has quit IRC22:12
prometheanfirespecific to gentoo? we just install the pypi version 99% of the time22:13
*** salv-orlando has joined #openstack-neutron22:13
marunprometheanfire: I have zero interest in the extra work of packaging something that is already consumable.22:13
prometheanfirethe other 1% is when upstream hasn't merged a fix22:13
prometheanfirewe need stable, testable systems :P22:13
marunprometheanfire: but I work for rh, so... :/22:13
prometheanfireLOL22:13
prometheanfireya22:13
prometheanfireI'm sorry22:13
marunit's good for folks that need something as stable as possible.22:14
marunhaleyb, HenryG: so, stick to old version of tox to make life easier for everyone that is using distro-supplied tox?22:14
prometheanfireI know, just the dichotomy22:15
prometheanfirewe have tox 1.8.1 stable in tree if it matters :D22:15
haleybif the correct version of tox was installed in .tox (like the rest of the world that it installs)... but that doesn't work since it's the one running things22:15
*** jobewan has quit IRC22:15
HenryGmarun: My vote is minver 1.8 in tox.ini - sorry haleyb22:15
openstackgerritZengfa Gao proposed openstack/neutron: Add unit tests to ha.py for L3 agent  https://review.openstack.org/15680122:15
haleybmarun: i'm fine changing new version, just happy to resolve issue22:16
*** julien_ZTE has quit IRC22:16
haleyblet me update the review22:17
*** crc32 has quit IRC22:18
marunhaleyb: thank you for doing that22:20
HenryGhaleyb: marun: I'm off to hear about type hints in Python! I'll check in later tonight to see where things are with tox.22:20
*** leenheer has joined #openstack-neutron22:21
*** shwetaap1 has quit IRC22:23
marunhaleyb: I'll get that fix merged asap to minimize the trouble this is causing folks.22:23
*** leenheer has quit IRC22:23
openstackgerritBrian Haley proposed openstack/neutron: Un-break tox for unit tests  https://review.openstack.org/15676722:23
haleybmarun: thanks, and it might have only bit two luddites on this channel :)22:24
marunhaleyb: definitely not :)22:24
marunhaleyb: both armando and I saw it this morning too22:24
openstackgerritAssaf Muller proposed openstack/neutron: Introduce ip address monitor  https://review.openstack.org/14964722:24
openstackgerritAssaf Muller proposed openstack/neutron: Change metadata driver unit tests to use monitored spawn  https://review.openstack.org/15505822:24
openstackgerritAssaf Muller proposed openstack/neutron: Replace keepalived notifier bash script with Python ip monitor  https://review.openstack.org/12538422:24
openstackgerritAssaf Muller proposed openstack/neutron: Reuse nova batch notifier  https://review.openstack.org/12801322:24
openstackgerritAssaf Muller proposed openstack/neutron: Remove unused L3 HA RPC method  https://review.openstack.org/15537022:24
marunamuller: Oh, I do love the smell of patch series in the morning22:25
haleybthat one-liner worked on my "new" VM with 1.8.122:25
amullermarun: just the first one is updated, https://review.openstack.org/14964722:25
amullercarl_baldwin: I addressed reviewr comments from armax and amotoki22:25
marunamuller: oh, I love that even more :D22:25
*** aranjan has joined #openstack-neutron22:26
marunamuller: I can taste the gate churn from here....22:26
* marun hides22:26
amullercarl_baldwin: marun: armax: Feel free to take a look again22:26
*** suresh12 has joined #openstack-neutron22:26
amullermarun: I tried just pushing the first one but git review went insane and I couldn't be bothered to re-remember the full paths via git push22:26
amullermarun: so, now you get the entire series :)22:26
amullermarun: rebasing the rest of the series and the entire feature should be working now22:27
*** dboik has quit IRC22:28
marunamuller: cool22:28
carl_baldwinamuller: ack22:28
*** achanda has joined #openstack-neutron22:29
*** crc32 has joined #openstack-neutron22:31
*** suresh12 has quit IRC22:31
*** Marga_ has quit IRC22:32
*** moshele has quit IRC22:32
*** Marga_ has joined #openstack-neutron22:32
*** manishg has quit IRC22:34
*** manishg has joined #openstack-neutron22:35
maruncarl_baldwin: hi22:36
maruncarl_baldwin: re: https://review.openstack.org/#/c/15680122:36
maruncarl_baldwin: do you have any relationship with the patch author?22:36
carl_baldwinmarun: hi22:36
* carl_baldwin looking...22:36
carl_baldwinmarun: Yes, I work with him.22:36
maruncarl_baldwin: I'm concerned that the proposed tests is mock-heavy and would act as little more than change detectors22:37
amullercarl_baldwin: Can you get him on IRC?22:37
*** zzzeek has joined #openstack-neutron22:37
maruncarl_baldwin: if he's looking for something to do, maybe we can direct him in a more fruitful direction.22:37
carl_baldwinmarun: amuller:  I’ll see if he’s around.22:37
*** rotbart has joined #openstack-neutron22:37
*** tiswanso has quit IRC22:37
maruncarl_baldwin: thank you22:38
marun!22:38
*** Zengfa has joined #openstack-neutron22:40
carl_baldwinmarun: amuller: meet Zengfa22:41
marunZengfa: hi!22:41
ZengfaHi22:42
amullerZengfa: Heya22:42
openstackgerritSwaminathan Vasudevan proposed openstack/neutron: Get rid of rpc to fetch fip agent port on agent.  https://review.openstack.org/15373522:42
marunZengfa: re: https://review.openstack.org/#/c/15680122:42
marunZengfa: I'm assuming you were following the existing strategy of mocking things in an attempt to be consistent.22:43
marunZengfa: I don't think that strategy is worth replicating, though.22:43
marunZengfa: this style of testing often does more to increase maintenance cost than improve quality22:44
marunZengfa: see: http://googletesting.blogspot.com/2015/01/testing-on-toilet-change-detector-tests.html22:44
marunZengfa: I would much rather see you refactor the target code so that it can be tested with a minimum of mocking.22:44
amullerJust a small unrelated note to what Maru is saying: ensure_keepalived_alive will be going away very soon via https://review.openstack.org/#/c/153162/22:44
*** Networkn3rd has joined #openstack-neutron22:44
*** Marga_ has quit IRC22:44
marunZengfa: does that make sense?22:44
amullerZengfa: So I guess other units would be more worthwhile your effort, I'd just remove the last test22:44
*** Marga_ has joined #openstack-neutron22:44
*** ramishra_ has joined #openstack-neutron22:45
*** regXboi has quit IRC22:45
*** pasha117 has joined #openstack-neutron22:45
*** leenheer has joined #openstack-neutron22:45
Zengfamarun: I will look at the changes, then modify it later.22:46
*** pc_m has quit IRC22:46
marunZengfa: I'm assuming that was for amuller?22:46
*** suresh12 has joined #openstack-neutron22:47
*** rotbart has quit IRC22:47
*** seizadi has quit IRC22:48
*** seizadi1 has joined #openstack-neutron22:48
Zengfaamuller: I just noticed that there is no unit testing for this class, I think we should have the tests. I am new to the testings, will look at this to see what I should change.22:48
amullerZengfa: We do have functional testing for the L3 agent and HA routers22:49
amullerIt's higher level testing, and it covers a lot of the code22:49
*** zhenq has quit IRC22:49
*** pavel_bondar has quit IRC22:49
*** ramishra_ has quit IRC22:49
amullerIt doesn't replace the lack of unit tests. If there's units that you find are not covered, it'd be great if you could test them, we just have to find an effective way to do so.22:49
amullerThere's no reason to mock stuff that doesn't interact with the system, for example22:50
*** ivar-laz_ has joined #openstack-neutron22:52
amullerZengfa: It'd keep mocking to a minimum. For example the add_notifiers function doesn't interact with the system directly, it's a few layers down, you could mock that22:52
*** manishg has quit IRC22:52
*** manishg has joined #openstack-neutron22:53
Zengfaamuller: Thanks for your suggestion. I will look at my changes, try to improve it.22:54
openstackgerritRonak Shah proposed openstack/neutron: Nuage core plugin decomposition  https://review.openstack.org/15682322:54
amullerZengfa: Sounds good :) I'll try to review your next patchsets quickly22:55
*** ivar-lazzaro has quit IRC22:55
*** MentalRay has joined #openstack-neutron22:56
*** jkyle1 has joined #openstack-neutron22:56
*** manishg has quit IRC22:57
*** jorgem has joined #openstack-neutron22:58
amullermarun: the ip monitor functional tests are still failing at the gate: https://jenkins01.openstack.org/job/check-neutron-dsvm-functional/3371/console22:59
amullerAlthough I solved all of that crap locally22:59
*** jorgem has quit IRC22:59
amullernow I really don't know why it says no filter found22:59
*** jorgem has joined #openstack-neutron22:59
*** localloop127 has quit IRC23:00
*** manishg has joined #openstack-neutron23:01
*** jckasper has quit IRC23:03
*** zhenq has joined #openstack-neutron23:04
*** matrohon has quit IRC23:04
*** Marga_ has quit IRC23:05
*** amuller has quit IRC23:05
*** Marga_ has joined #openstack-neutron23:06
*** thedodd has joined #openstack-neutron23:07
marunZZelle_: I'm really sorry that I've been so slow in reviewing this past week :/23:07
openstackgerritBrian Haley proposed openstack/neutron: Check if routing rule exists before adding  https://review.openstack.org/15233023:08
*** aranjan has quit IRC23:08
*** chlong has joined #openstack-neutron23:08
*** leenheer has quit IRC23:08
*** kbringard has quit IRC23:09
*** hichihara has joined #openstack-neutron23:10
*** csoukup has quit IRC23:11
*** julien_ZTE has joined #openstack-neutron23:12
*** seizadi1 has quit IRC23:13
*** gduan has joined #openstack-neutron23:16
*** garyduan has quit IRC23:18
*** julien_ZTE has quit IRC23:19
ZZelle_marun, hi, no pb23:21
*** yamamoto has joined #openstack-neutron23:21
marunZZelle_: I'm juggling too much, and have been climbing a curve to provide some help on the infra side.23:22
marunZZelle_: I do want to see us get to the point of being able to do api and scenario testing this cycle, and your and John's work is critical to both of thos.23:22
marunZZelle_: in-tree testing, I mean23:23
*** yuanying has joined #openstack-neutron23:23
*** leenheer has joined #openstack-neutron23:24
*** leenheer has quit IRC23:24
*** leenheer has joined #openstack-neutron23:25
*** signed8bit has quit IRC23:25
*** Networkn3rd has quit IRC23:26
*** Networkn3rd has joined #openstack-neutron23:28
*** aranjan has joined #openstack-neutron23:28
*** pradk has quit IRC23:29
*** yamamoto has quit IRC23:29
*** bobmel has quit IRC23:31
*** bobmel has joined #openstack-neutron23:31
*** gildub has joined #openstack-neutron23:32
*** nlahouti has quit IRC23:32
*** Networkn3rd has quit IRC23:32
*** jobewan has joined #openstack-neutron23:34
*** leenheer has quit IRC23:34
*** leenheer has joined #openstack-neutron23:35
*** MentalRay has quit IRC23:35
*** shwetaap has joined #openstack-neutron23:36
*** zhenq has quit IRC23:36
*** aranjan has quit IRC23:39
*** ramishra_ has joined #openstack-neutron23:45
*** ivar-laz_ has quit IRC23:48
*** ivar-lazzaro has joined #openstack-neutron23:49
*** _cjones_ has quit IRC23:50
*** shaohe_feng has joined #openstack-neutron23:50
*** ramishra_ has quit IRC23:50
*** signed8bit has joined #openstack-neutron23:52
*** yamamoto has joined #openstack-neutron23:52
*** shwetaap has quit IRC23:52
*** _cjones_ has joined #openstack-neutron23:53
*** rotbart has joined #openstack-neutron23:53
*** ZZelle_ has quit IRC23:53
*** zhenq has joined #openstack-neutron23:53
*** jobewan has quit IRC23:54
*** nlahouti has joined #openstack-neutron23:55
*** nlahouti1 has joined #openstack-neutron23:55
*** aranjan has joined #openstack-neutron23:56
*** manishg has quit IRC23:58
*** manishg has joined #openstack-neutron23:59
*** manishg has quit IRC23:59
*** ajmiller has quit IRC23:59
openstackgerritMerged openstack/neutron: Add run_as_root option to utils.execute  https://review.openstack.org/15306723:59
*** manishg has joined #openstack-neutron23:59
*** nlahouti has quit IRC23:59
*** julien_ZTE has joined #openstack-neutron23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!