*** baoli has quit IRC | 00:01 | |
*** nlahouti has joined #openstack-neutron | 00:02 | |
*** leenheer has quit IRC | 00:03 | |
*** manishg has quit IRC | 00:03 | |
*** rms_13 has joined #openstack-neutron | 00:04 | |
*** aranjan_ has joined #openstack-neutron | 00:04 | |
*** aranjan has quit IRC | 00:05 | |
*** nlahouti1 has quit IRC | 00:06 | |
*** aranjan_ has quit IRC | 00:06 | |
*** julien_ZTE has quit IRC | 00:07 | |
*** julien_ZTE has joined #openstack-neutron | 00:07 | |
*** carl_baldwin has quit IRC | 00:08 | |
*** thedodd has quit IRC | 00:12 | |
*** shwetaap has joined #openstack-neutron | 00:13 | |
*** Marga_ has quit IRC | 00:13 | |
*** Marga_ has joined #openstack-neutron | 00:14 | |
*** nlahouti has quit IRC | 00:15 | |
*** stanzgy has quit IRC | 00:16 | |
openstackgerrit | Derek Higgins proposed openstack/neutron: Revert "Add the rebinding chance in _bind_port_if_needed" https://review.openstack.org/156853 | 00:17 |
---|---|---|
*** mlavalle has quit IRC | 00:17 | |
*** nlahouti has joined #openstack-neutron | 00:17 | |
*** Marga_ has quit IRC | 00:18 | |
*** aranjan has joined #openstack-neutron | 00:18 | |
*** Marga_ has joined #openstack-neutron | 00:18 | |
*** leenheer has joined #openstack-neutron | 00:19 | |
*** aranjan has quit IRC | 00:22 | |
*** marun has quit IRC | 00:23 | |
*** r-daneel has quit IRC | 00:26 | |
*** jaypipes has quit IRC | 00:27 | |
*** carl_baldwin has joined #openstack-neutron | 00:27 | |
*** banix has joined #openstack-neutron | 00:28 | |
*** shwetaap has quit IRC | 00:29 | |
*** shwetaap has joined #openstack-neutron | 00:29 | |
openstackgerrit | Isaku Yamahata proposed openstack/neutron: ml2: extension driver isn't passed dbentry to extension result dict https://review.openstack.org/129178 | 00:30 |
*** pal has joined #openstack-neutron | 00:32 | |
*** dims__ has quit IRC | 00:33 | |
*** dims__ has joined #openstack-neutron | 00:33 | |
*** dims__ has quit IRC | 00:33 | |
*** moha_hunt has quit IRC | 00:34 | |
*** dims__ has joined #openstack-neutron | 00:35 | |
*** banix has quit IRC | 00:35 | |
*** markvoelker has quit IRC | 00:37 | |
*** pal has quit IRC | 00:37 | |
*** markvoelker has joined #openstack-neutron | 00:37 | |
*** johnbelamaric has quit IRC | 00:39 | |
openstackgerrit | Isaku Yamahata proposed openstack/neutron: ml2: extension driver isn't passed dbentry to extension result dict https://review.openstack.org/129178 | 00:39 |
*** banix has joined #openstack-neutron | 00:39 | |
*** markvoelker has quit IRC | 00:42 | |
*** seizadi has joined #openstack-neutron | 00:42 | |
openstackgerrit | Matthew Thode proposed openstack/neutron: Fixes bug in interface handling of ip_lib.py https://review.openstack.org/154128 | 00:44 |
*** david-lyle has quit IRC | 00:44 | |
*** seizadi has quit IRC | 00:44 | |
*** banix has quit IRC | 00:46 | |
*** ramishra_ has joined #openstack-neutron | 00:46 | |
*** Marga_ has quit IRC | 00:49 | |
*** pasha117 has quit IRC | 00:50 | |
*** ramishra_ has quit IRC | 00:51 | |
*** pasha117 has joined #openstack-neutron | 00:51 | |
*** banix has joined #openstack-neutron | 00:52 | |
*** jasondotstar has quit IRC | 00:55 | |
*** nlahouti has quit IRC | 00:57 | |
*** tomoe_ has joined #openstack-neutron | 00:57 | |
*** tomoe_ has quit IRC | 00:57 | |
*** avozza is now known as zz_avozza | 00:58 | |
*** reed has quit IRC | 00:58 | |
*** zz_avozza is now known as avozza | 00:58 | |
*** tomoe_ has joined #openstack-neutron | 01:01 | |
*** jordandh has quit IRC | 01:01 | |
openstackgerrit | Shiv Haris proposed openstack/neutron: Do not review. https://review.openstack.org/152383 | 01:02 |
*** MentalRay has joined #openstack-neutron | 01:03 | |
*** yamamoto has quit IRC | 01:03 | |
*** nlahouti has joined #openstack-neutron | 01:04 | |
*** absubram has quit IRC | 01:05 | |
*** johnbelamaric has joined #openstack-neutron | 01:06 | |
*** jordandh has joined #openstack-neutron | 01:07 | |
*** ivar-lazzaro has quit IRC | 01:08 | |
*** avozza is now known as zz_avozza | 01:08 | |
openstackgerrit | Merged openstack/neutron: Un-break tox for unit tests https://review.openstack.org/156767 | 01:08 |
*** ivar-lazzaro has joined #openstack-neutron | 01:09 | |
*** manishg has joined #openstack-neutron | 01:10 | |
*** ivar-lazzaro has quit IRC | 01:10 | |
*** manishg has quit IRC | 01:11 | |
*** manishg has joined #openstack-neutron | 01:11 | |
*** ivar-lazzaro has joined #openstack-neutron | 01:11 | |
*** tomoe_ has quit IRC | 01:14 | |
*** xgerman has quit IRC | 01:15 | |
*** shaohe_feng has quit IRC | 01:16 | |
*** achanda has quit IRC | 01:17 | |
*** johnbelamaric has quit IRC | 01:19 | |
*** aranjan has joined #openstack-neutron | 01:19 | |
*** rook has joined #openstack-neutron | 01:19 | |
*** leenheer has quit IRC | 01:19 | |
*** rook is now known as Guest30462 | 01:20 | |
*** leenheer has joined #openstack-neutron | 01:20 | |
*** suresh12 has quit IRC | 01:21 | |
*** tomoe_ has joined #openstack-neutron | 01:21 | |
*** zzzeek has quit IRC | 01:22 | |
*** tomoe_ has quit IRC | 01:22 | |
*** aranjan has quit IRC | 01:24 | |
*** mwagner_lap has joined #openstack-neutron | 01:24 | |
*** a_le has quit IRC | 01:25 | |
prometheanfire | neutron failing tests atm? | 01:27 |
openstackgerrit | Rajeev Grover proposed openstack/neutron: WIP fix for _get_external_device_interface_name trace https://review.openstack.org/156357 | 01:30 |
*** zzzeek has joined #openstack-neutron | 01:31 | |
*** banix has quit IRC | 01:32 | |
*** santosh has joined #openstack-neutron | 01:32 | |
*** banix has joined #openstack-neutron | 01:35 | |
*** yamamoto has joined #openstack-neutron | 01:36 | |
*** a_le has joined #openstack-neutron | 01:36 | |
*** tomoe_ has joined #openstack-neutron | 01:37 | |
*** jordandh has quit IRC | 01:39 | |
*** jordandh has joined #openstack-neutron | 01:41 | |
*** tomoe_ has quit IRC | 01:43 | |
*** spandhe has quit IRC | 01:46 | |
*** ramishra_ has joined #openstack-neutron | 01:47 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS UT: Fix some confusions between local vlan id and segmentation id https://review.openstack.org/156464 | 01:48 |
openstackgerrit | Miguel Lavalle proposed openstack/neutron: Move Floating IP processing to Router classes https://review.openstack.org/142863 | 01:51 |
openstackgerrit | Miguel Lavalle proposed openstack/neutron: Refactor management of namespaces in the L3 Agent https://review.openstack.org/147744 | 01:51 |
*** ramishra_ has quit IRC | 01:51 | |
*** aranjan has joined #openstack-neutron | 01:52 | |
*** rwsu is now known as rwsu-afk | 01:54 | |
openstackgerrit | Terry Wilson proposed openstack/neutron: Remove remaining uses of passing root_helper https://review.openstack.org/155906 | 01:57 |
*** salv-orlando has quit IRC | 01:58 | |
*** markvoelker has joined #openstack-neutron | 01:59 | |
*** zz_avozza is now known as avozza | 01:59 | |
*** Marga_ has joined #openstack-neutron | 02:01 | |
*** rms_13 has quit IRC | 02:01 | |
*** Marga_ has quit IRC | 02:02 | |
*** Marga_ has joined #openstack-neutron | 02:02 | |
*** pal has joined #openstack-neutron | 02:03 | |
openstackgerrit | Merged openstack/neutron-fwaas: Add index on tenant_id https://review.openstack.org/154492 | 02:04 |
*** signed8bit is now known as signed8bit_ZZZzz | 02:04 | |
*** aranjan has quit IRC | 02:05 | |
*** shwetaap has quit IRC | 02:07 | |
*** banix has quit IRC | 02:07 | |
*** briancline has quit IRC | 02:09 | |
*** briancline has joined #openstack-neutron | 02:09 | |
*** changbl has joined #openstack-neutron | 02:10 | |
*** banix has joined #openstack-neutron | 02:11 | |
*** david-lyle has joined #openstack-neutron | 02:11 | |
*** SridharRamaswamy has quit IRC | 02:11 | |
openstackgerrit | Isaku Yamahata proposed openstack/neutron: internal callers of create_{network, subnet, port} ignore extension https://review.openstack.org/129773 | 02:13 |
*** jordandh has quit IRC | 02:14 | |
*** _cjones_ has quit IRC | 02:18 | |
*** jordandh has joined #openstack-neutron | 02:20 | |
openstackgerrit | Terry Wilson proposed openstack/neutron: Stop using passed root_helper in ip_lib https://review.openstack.org/145829 | 02:22 |
openstackgerrit | Terry Wilson proposed openstack/neutron: Remove root_helper arg for ovs_lib https://review.openstack.org/154914 | 02:26 |
*** erkules has joined #openstack-neutron | 02:28 | |
*** xgerman has joined #openstack-neutron | 02:28 | |
openstackgerrit | Terry Wilson proposed openstack/neutron: Remove root_helper arg for ovs_lib https://review.openstack.org/154914 | 02:30 |
*** erkules_ has quit IRC | 02:31 | |
openstackgerrit | Terry Wilson proposed openstack/neutron: Remove root_helper arg from external_process https://review.openstack.org/154959 | 02:32 |
openstackgerrit | Terry Wilson proposed openstack/neutron: Remove root_helper arg from IptablesManager https://review.openstack.org/154969 | 02:32 |
openstackgerrit | Terry Wilson proposed openstack/neutron: Remove root_helper arg from IpsetManager https://review.openstack.org/154980 | 02:33 |
*** Guest30462 has quit IRC | 02:33 | |
openstackgerrit | Terry Wilson proposed openstack/neutron: Remove root_helper arg from SecurityGroupAgentRpc https://review.openstack.org/155013 | 02:33 |
otherwiseguy | mestery: doing some rebasing because the ovs_lib root_helper patch needed to be updated due to a recent change. | 02:34 |
openstackgerrit | Terry Wilson proposed openstack/neutron: Remove root_helper arg from linuxbridge https://review.openstack.org/155014 | 02:34 |
openstackgerrit | Terry Wilson proposed openstack/neutron: Remove root_helper arg from AsyncProcess https://review.openstack.org/155101 | 02:35 |
openstackgerrit | Terry Wilson proposed openstack/neutron: Remove root_helper arg from DHCP agent https://review.openstack.org/155188 | 02:35 |
otherwiseguy | mestery: so approvals just disappeard. :/ | 02:37 |
otherwiseguy | But the merges would have failed otherwise. | 02:37 |
*** leenheer has quit IRC | 02:38 | |
openstackgerrit | Sachi King proposed openstack/neutron: Return exception when attempting to add duplicate VIP https://review.openstack.org/142630 | 02:38 |
*** manishg has quit IRC | 02:42 | |
*** s3wong has quit IRC | 02:42 | |
openstackgerrit | Brent Eagles proposed openstack/neutron: Refactor RESOURCE_ATTRIBUTE_MAP cleanup https://review.openstack.org/156670 | 02:44 |
*** nlahouti has quit IRC | 02:45 | |
mestery | otherwiseguy: Looking again | 02:45 |
mestery | otherwiseguy: Need to wait for jeknins to pass now | 02:47 |
*** ramishra_ has joined #openstack-neutron | 02:48 | |
otherwiseguy | mestery: yeah. hopefully no other breaking changes. | 02:48 |
mestery | otherwiseguy: Ack | 02:48 |
otherwiseguy | mestery: The l3 agent patch and above depend on merging some *aaS changes I have (which depend on the next patch up, the ip_lib change). | 02:48 |
otherwiseguy | Lots of moving parts. :) | 02:49 |
mestery | yeah no kidding | 02:49 |
otherwiseguy | but hopefully we can avoid breaking things. | 02:49 |
otherwiseguy | But if something does break, should be easy fixes. | 02:49 |
mestery | yes | 02:50 |
*** yuanying has quit IRC | 02:51 | |
*** ramishra_ has quit IRC | 02:52 | |
*** apuimedo has quit IRC | 02:53 | |
*** tiswanso has joined #openstack-neutron | 02:54 | |
*** avozza is now known as zz_avozza | 02:56 | |
openstackgerrit | Terry Wilson proposed openstack/neutron: Remove root_helper arg from L3 Agent https://review.openstack.org/155212 | 02:57 |
*** tiswanso has quit IRC | 02:58 | |
*** radez is now known as radez_g0n3 | 02:58 | |
*** tiswanso has joined #openstack-neutron | 02:59 | |
*** salv-orlando has joined #openstack-neutron | 02:59 | |
openstackgerrit | Terry Wilson proposed openstack/neutron: Remove root_helper arg from L3 Agent https://review.openstack.org/155212 | 03:00 |
*** a_le has quit IRC | 03:01 | |
*** jordandh has quit IRC | 03:01 | |
openstackgerrit | Merged openstack/neutron: Fix the api job https://review.openstack.org/156436 | 03:02 |
*** pal has quit IRC | 03:03 | |
openstackgerrit | Merged openstack/neutron: OVS UT: Fix some confusions between local vlan id and segmentation id https://review.openstack.org/156464 | 03:03 |
*** carl_baldwin has quit IRC | 03:07 | |
*** xgerman has quit IRC | 03:09 | |
*** xgerman has joined #openstack-neutron | 03:11 | |
*** sthillma has joined #openstack-neutron | 03:12 | |
*** boris-42 has quit IRC | 03:12 | |
*** jordandh has joined #openstack-neutron | 03:12 | |
*** sthillma has quit IRC | 03:12 | |
*** xuhanp has joined #openstack-neutron | 03:12 | |
*** yamahata has quit IRC | 03:13 | |
*** tomoe_ has joined #openstack-neutron | 03:17 | |
*** xgerman has quit IRC | 03:20 | |
*** harlowja_ is now known as harlowja_away | 03:22 | |
*** tomoe_ has quit IRC | 03:24 | |
*** Marga_ has quit IRC | 03:25 | |
yamamoto | armax: ping | 03:27 |
armax | yamamoto: pong | 03:27 |
*** tomoe_ has joined #openstack-neutron | 03:28 | |
yamamoto | armax: how do you think setup_dvr_mac_flows_on_all_brs/dvr_mac_address_update refactoring part of https://review.openstack.org/#/c/153946/ ? | 03:28 |
armax | yamamoto, me looks | 03:28 |
*** xuhanp has quit IRC | 03:29 | |
* armax looks | 03:29 | |
yamamoto | armax: if you and vivek like it, i might consider "backporting" to reduce the size of the patch. | 03:29 |
armax | yamamoto: ok, give me a few to go over it | 03:30 |
yamamoto | armax: no hurry at all. thank you | 03:30 |
armax | yamamoto: thank you! | 03:30 |
yamamoto | armax: and i have another question... | 03:31 |
armax | shoot | 03:31 |
*** a_le has joined #openstack-neutron | 03:31 | |
yamamoto | armax: i want to make ovs-agent use ryu. ie. add ryu to its requirement | 03:32 |
yamamoto | armax: what do you think a proper way to do it? | 03:32 |
armax | ok | 03:32 |
yamamoto | armax: an idea is add it to global-req and neutron's req | 03:32 |
yamamoto | armax: alternative is introduce per-agent requirement | 03:32 |
armax | yamamoto: yeah..even thought that’s a bit too aggressive | 03:32 |
yamamoto | armax: i guess the latter is better wrt decomp effort | 03:33 |
armax | yamamoto: how do you intend to use ryu in the agent? | 03:33 |
*** tomoe_ has quit IRC | 03:33 | |
yamamoto | armax: basically use ryu instead of ovs-ofctl | 03:33 |
armax | yamamoto: but that would need to be conditional on some sort of env setting, would it not? | 03:34 |
yamamoto | armax: ? | 03:34 |
yamamoto | armax: you mean a knob to switch between ovs-ofctl and ryu? | 03:35 |
armax | yamamoto: ya | 03:35 |
*** david-lyle has quit IRC | 03:35 | |
armax | yamamoto: are you proposing ryu in lieu of ovs-ofctl? | 03:35 |
*** david-lyle has joined #openstack-neutron | 03:35 | |
yamamoto | armax: i don't plan to have such a knob. it would be "nice-to-have" but not worth the effort IMO. | 03:35 |
yamamoto | armax: yes | 03:36 |
yamamoto | armax: https://review.openstack.org/#/c/153946/ is WIP patch for it. | 03:36 |
*** yuanying has joined #openstack-neutron | 03:37 | |
armax | yamamoto: in that case, then having ryu part of the requirements would be reasonable | 03:37 |
*** a_le has quit IRC | 03:38 | |
*** a_le has joined #openstack-neutron | 03:38 | |
armax | yamamoto: but there’s something that tells me that’s not the nicest thing to do | 03:38 |
armax | :) | 03:38 |
*** xgerman has joined #openstack-neutron | 03:39 | |
armax | I wonder how terrible it would be to consider ryu an external depedency just like ovs | 03:39 |
armax | that would be installed via devstack for instance | 03:39 |
*** david-lyle has quit IRC | 03:40 | |
yamamoto | armax: how do you think making devstack looks at per-driver/plugin/etc requirement.txt in neutron tree? | 03:40 |
armax | yamamoto: I tried to document that in the devref | 03:41 |
*** yuanying has quit IRC | 03:41 | |
*** yuanying_ has joined #openstack-neutron | 03:41 | |
yamamoto | armax: eg. neutron/plugins/$Q_AGENT/requirements.txt | 03:41 |
armax | yamamoto: technically speaking that becomes an extra.s hook responsibility | 03:41 |
yamamoto | armax: i meant, even for in-tree drivers like OVS. | 03:42 |
armax | yamamoto: not sure I follow | 03:42 |
*** xuhanp has joined #openstack-neutron | 03:42 | |
yamamoto | armax: so that i can just add ryu to neutron/plugins/openvswitch/requirement.txt in my patch | 03:42 |
*** a_le_ has joined #openstack-neutron | 03:43 | |
*** coolsvap_ is now known as coolsvap | 03:43 | |
yamamoto | armax: my understanding is while ovs stays in tree for a while it's planned be restructured to be similar to out-of-tree plugins | 03:44 |
yamamoto | armax: right? | 03:44 |
armax | yamamoto: well…if ryu is becoming your de facto binding for ovs agent, I don’t think that warrants a per-agent requirement file | 03:44 |
yamamoto | armax: but not every users of neutron will use ovs-agent | 03:45 |
armax | yamamoto: agreed, that’s why I am still pondering... | 03:45 |
armax | :) | 03:45 |
armax | yamamoto: after all, today ovs is installed out of band too… | 03:46 |
*** dane_leblanc has quit IRC | 03:46 | |
*** tomoe_ has joined #openstack-neutron | 03:46 | |
yamamoto | armax: right | 03:47 |
*** a_le has quit IRC | 03:47 | |
yamamoto | armax: the problem of out-of-band installation is i can't give jenkins a try for my patch :) | 03:47 |
armax | yamamoto: I know..that’s why it’s problematic | 03:48 |
*** ramishra_ has joined #openstack-neutron | 03:49 | |
*** dims__ has quit IRC | 03:49 | |
*** salv-orlando has quit IRC | 03:51 | |
*** shwetaap has joined #openstack-neutron | 03:53 | |
*** ramishra_ has quit IRC | 03:53 | |
*** tomoe_ has quit IRC | 03:53 | |
*** amotoki has joined #openstack-neutron | 03:54 | |
armax | yamamoto: it sounds like this is a topic for a neutron meeting or the mailing list, because if we want Jenking to give it a go…and we don’t want to hold the requirement we might need to come up with something, either in project-config (e.g. like an experimental job) and/or devstack | 03:55 |
armax | yamamoto: we wouldn’t want to swap ovs-ofctl with ryu in one go though, I feel people would want a transitionary plan | 03:55 |
*** aranjan has joined #openstack-neutron | 03:56 | |
yamamoto | armax: sure. i'll add an agenda item or post to ML | 03:57 |
yamamoto | armax: i think requirement thing and "ovs-ofctl vs ryu" thing are actually separate topics | 03:57 |
*** MentalRay has quit IRC | 03:57 | |
prometheanfire | I think neutron doesn't mount /sys | 03:58 |
prometheanfire | well, the tests | 03:58 |
prometheanfire | http://logs.openstack.org/28/154128/6/check/check-tempest-dsvm-neutron-pg/bf01ca8/logs/df.txt.gz | 03:58 |
*** ramishra_ has joined #openstack-neutron | 03:58 | |
prometheanfire | my change needs /sys/class/net | 03:58 |
yamamoto | does "On Demand Agenda" on wiki mean "feel free to add your favorite topic" ? | 03:59 |
otherwiseguy | yamamoto: as someone who has recently gone through the add-a-knob-for-ovs work...it is definitely quite a bit of work. | 03:59 |
*** tomoe_ has joined #openstack-neutron | 03:59 | |
yamamoto | otherwiseguy: sure. for ofctl-vs-ryu it's worse as openflow would need a far larger "neutral api" than ovsdb | 04:02 |
HenryG | arosen: ping | 04:02 |
otherwiseguy | yamamoto: also, thanks for all of the reviews. you often catch things I've missed. | 04:04 |
yamamoto | otherwiseguy: no problem. it's my joy. | 04:06 |
*** tomoe_ has quit IRC | 04:06 | |
*** pal has joined #openstack-neutron | 04:10 | |
*** aranjan has quit IRC | 04:13 | |
*** Marga_ has joined #openstack-neutron | 04:14 | |
*** yatin has joined #openstack-neutron | 04:15 | |
*** Marga_ has quit IRC | 04:18 | |
*** Marga_ has joined #openstack-neutron | 04:19 | |
*** rotbart has quit IRC | 04:19 | |
*** david-lyle has joined #openstack-neutron | 04:22 | |
*** david-lyle is now known as david-lyle_afk | 04:23 | |
*** tflynn_ has joined #openstack-neutron | 04:24 | |
*** tflynn has quit IRC | 04:27 | |
*** shaohe_feng has joined #openstack-neutron | 04:28 | |
*** tflynn_ has quit IRC | 04:28 | |
*** achanda has joined #openstack-neutron | 04:29 | |
*** santosh_ has joined #openstack-neutron | 04:30 | |
*** killer_prince is now known as lazy_prince | 04:31 | |
*** signed8bit_ZZZzz has quit IRC | 04:32 | |
*** santosh has quit IRC | 04:32 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Use python binding instead of ovs-ofctl command https://review.openstack.org/153946 | 04:33 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: Make l2pop UT independent from OVS https://review.openstack.org/118620 | 04:33 |
roaet | amotoki: Hey there! Good morning, maybe? | 04:33 |
amotoki | roaet: hi | 04:34 |
amotoki | roaet: good afternoon :) now around 130pm | 04:34 |
roaet | amotoki: while the fate of my change (https://review.openstack.org/#/c/148318/) is unsure, as the client core, I just want to make sure I satisfied all your comments. I mentioned it earlier today (yesterday for you). Not sure if you remember, but due diligence commands I try. | 04:35 |
roaet | amotoki: japan? | 04:35 |
amotoki | roaet: yes. | 04:36 |
amotoki | roaet: looking. in the morning, i was ooo for meetings. | 04:36 |
roaet | I dream to visit that place some day. Big fan of the culture and language, though I can't speak it anymore (or write it). I slept since the school days. | 04:36 |
*** shaohe_feng has quit IRC | 04:37 | |
amotoki | roaet: there are many discussions from last night (on my side). | 04:37 |
roaet | amotoki: yes... ha. | 04:38 |
roaet | amotoki: that's what I was alluding to as far as fate being unsure. If the meeting tomorrow chooses to allow it to go I'd at least like to know that the code is quality from your perspective. | 04:39 |
*** ramishra_ has quit IRC | 04:39 | |
openstackgerrit | Andrew Boik proposed openstack/neutron: WIP: Support multiple IPv6 prefixes on internal router ports https://review.openstack.org/156360 | 04:41 |
*** tomoe_ has joined #openstack-neutron | 04:41 | |
*** ramishra_ has joined #openstack-neutron | 04:42 | |
openstackgerrit | IWAMOTO Toshihiro proposed openstack/neutron: Add availability_zone support https://review.openstack.org/149940 | 04:42 |
*** gildub has quit IRC | 04:42 | |
amotoki | roaet: perhaps in the next Neturon meeting or cross project meeting. I am not sure "Tuesday meeting" mark mentioned.. | 04:43 |
roaet | amotoki: it is a meeting today (for you) in openstack-meeting-3 | 04:43 |
roaet | 1530 UTC. | 04:44 |
roaet | I plan on being there, and your insight as client-core would be appreciated | 04:45 |
*** achanda has quit IRC | 04:45 | |
amotoki | roaet: got it. I just saw the mail to my private address. | 04:45 |
*** tomoe_ has quit IRC | 04:48 | |
*** dims__ has joined #openstack-neutron | 04:50 | |
*** xgerman has quit IRC | 04:52 | |
*** achanda has joined #openstack-neutron | 04:52 | |
*** xgerman_ has joined #openstack-neutron | 04:52 | |
openstackgerrit | Merged openstack/neutron: Stop using passed root_helper in ip_lib https://review.openstack.org/145829 | 04:52 |
*** seizadi has joined #openstack-neutron | 04:52 | |
*** ramishra_ has quit IRC | 04:53 | |
*** tiswanso has quit IRC | 04:54 | |
*** dims__ has quit IRC | 04:54 | |
*** dane_leblanc has joined #openstack-neutron | 04:56 | |
*** xgerman_ has quit IRC | 04:57 | |
*** xgerman__ has joined #openstack-neutron | 04:57 | |
*** seizadi has quit IRC | 04:59 | |
*** shilpa_ has joined #openstack-neutron | 04:59 | |
*** seizadi has joined #openstack-neutron | 04:59 | |
*** achanda has quit IRC | 04:59 | |
*** ramishra_ has joined #openstack-neutron | 04:59 | |
*** shwetaap has quit IRC | 05:00 | |
*** achanda has joined #openstack-neutron | 05:00 | |
*** shwetaap has joined #openstack-neutron | 05:01 | |
*** jckasper has joined #openstack-neutron | 05:02 | |
*** dane_leblanc has quit IRC | 05:02 | |
*** jckasper has quit IRC | 05:02 | |
*** jckasper has joined #openstack-neutron | 05:02 | |
*** xgerman__ has quit IRC | 05:03 | |
*** seizadi has quit IRC | 05:03 | |
*** pal has quit IRC | 05:04 | |
*** pal_ has joined #openstack-neutron | 05:04 | |
*** seizadi has joined #openstack-neutron | 05:04 | |
*** _cjones_ has joined #openstack-neutron | 05:04 | |
*** ramishra_ has quit IRC | 05:06 | |
*** claudiub_ has quit IRC | 05:08 | |
*** seizadi1 has joined #openstack-neutron | 05:08 | |
*** seizadi has quit IRC | 05:08 | |
*** anish_ has joined #openstack-neutron | 05:09 | |
*** banix has quit IRC | 05:09 | |
otherwiseguy | HenryG: dougwig: thanks for the reviews/approvals. The L3 agent patch depends on https://review.openstack.org/#/c/156690/, which I've got re-checking and has passed the py27 test that was failing because the ip_lib patch hadn't merged. Once the aforementioned vpnaas patch merges, it should be safe to merge the L3 agent patch and above patches (up to the final one which there are some comments for me to address). | 05:09 |
*** dane_leblanc has joined #openstack-neutron | 05:09 | |
*** aranjan has joined #openstack-neutron | 05:10 | |
otherwiseguy | I've done my best to avoid breaking things, but I wouldn't be entirely surprised if something has slipped through somewhere. The fixes should be very easy if something does slip through, though. | 05:10 |
dougwig | otherwiseguy: sorry for my schizophrenic over commenting. I needed to stop typing hours ago. :) | 05:10 |
otherwiseguy | dougwig: Comments are good. I like comments. :) | 05:11 |
*** achanda has quit IRC | 05:11 | |
*** leenheer has joined #openstack-neutron | 05:11 | |
*** seizadi has joined #openstack-neutron | 05:12 | |
*** seizadi1 has quit IRC | 05:12 | |
*** pal_ has quit IRC | 05:12 | |
HenryG | otherwiseguy: You're welcome. It's late here, I'll check the L3 agent patch tomorrow. | 05:12 |
*** santosh_ has quit IRC | 05:13 | |
*** ramishra_ has joined #openstack-neutron | 05:13 | |
otherwiseguy | dougwig: on the neutron-is-a-library thing, I can see your point. I was hoping that it was a very limited-use library and that I found everything that used it. :) An argument could be made that anything using neutron's neutron.agent.linux.utils.execute should be using oslo_concurrency.processutils.execute. | 05:14 |
otherwiseguy | But I can see not wanting to crash somebody's program too. :) | 05:14 |
*** rkukura has quit IRC | 05:14 | |
otherwiseguy | I'll take a look at it tomorrow. | 05:15 |
otherwiseguy | HenryG: Yeah, late here too. Sleeeeep. | 05:15 |
otherwiseguy | dougwig: HenryG: Thanks to you both, again. Good night. :) | 05:16 |
dougwig | otherwiseguy: this is how I hope to resolve these issues: https://review.openstack.org/#/c/154736/ | 05:16 |
dougwig | and now i'm really out of here. :) | 05:16 |
*** seizadi1 has joined #openstack-neutron | 05:16 | |
*** seizadi has quit IRC | 05:16 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: test_l2population: Use a local copy of ofagent mech driver https://review.openstack.org/150239 | 05:16 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: ofagent: Vendor code decomposition https://review.openstack.org/149941 | 05:16 |
*** trinaths has joined #openstack-neutron | 05:17 | |
*** ajmiller has joined #openstack-neutron | 05:18 | |
*** dkehn has quit IRC | 05:19 | |
*** seizadi has joined #openstack-neutron | 05:19 | |
*** seizadi1 has quit IRC | 05:20 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: Fix a usage error of joinedload + filter in l3 scheduler https://review.openstack.org/149458 | 05:23 |
*** pal has joined #openstack-neutron | 05:23 | |
*** tflynn has joined #openstack-neutron | 05:23 | |
*** jckasper has quit IRC | 05:23 | |
*** ajmiller has quit IRC | 05:24 | |
*** seizadi1 has joined #openstack-neutron | 05:25 | |
*** seizadi has quit IRC | 05:26 | |
*** seizadi has joined #openstack-neutron | 05:29 | |
*** seizadi1 has quit IRC | 05:30 | |
*** zhenq has quit IRC | 05:30 | |
*** zhenq has joined #openstack-neutron | 05:30 | |
*** belmoreira has joined #openstack-neutron | 05:31 | |
*** jckasper has joined #openstack-neutron | 05:33 | |
*** leenheer has quit IRC | 05:33 | |
*** yamahata has joined #openstack-neutron | 05:33 | |
*** zhenq has quit IRC | 05:34 | |
*** seizadi1 has joined #openstack-neutron | 05:34 | |
*** seizadi has quit IRC | 05:34 | |
*** salv-orlando has joined #openstack-neutron | 05:36 | |
*** leenheer has joined #openstack-neutron | 05:36 | |
openstackgerrit | Merged openstack/neutron: Remove root_helper arg for ovs_lib https://review.openstack.org/154914 | 05:38 |
*** seizadi has joined #openstack-neutron | 05:38 | |
*** _cjones_ has quit IRC | 05:38 | |
openstackgerrit | Matthew Thode proposed openstack/neutron: Fixes bug in interface handling of ip_lib.py https://review.openstack.org/154128 | 05:38 |
*** seizadi1 has quit IRC | 05:38 | |
*** _cjones_ has joined #openstack-neutron | 05:39 | |
*** aranjan_ has joined #openstack-neutron | 05:40 | |
*** aranjan has quit IRC | 05:40 | |
prometheanfire | this should be fun | 05:40 |
*** jckasper_ has joined #openstack-neutron | 05:42 | |
*** zzzeek has quit IRC | 05:43 | |
*** ramishra_ has quit IRC | 05:44 | |
*** seizadi has quit IRC | 05:44 | |
*** seizadi has joined #openstack-neutron | 05:45 | |
*** seizadi has quit IRC | 05:45 | |
*** jckasper has quit IRC | 05:46 | |
*** leenheer has quit IRC | 05:51 | |
*** rotbeard has joined #openstack-neutron | 05:51 | |
*** achanda has joined #openstack-neutron | 05:53 | |
*** nlahouti has joined #openstack-neutron | 05:55 | |
*** yshafrir has joined #openstack-neutron | 05:55 | |
*** saju_m has joined #openstack-neutron | 05:56 | |
*** nlahouti1 has joined #openstack-neutron | 05:58 | |
*** Murali has joined #openstack-neutron | 06:00 | |
*** nlahouti has quit IRC | 06:00 | |
*** crc32 has quit IRC | 06:03 | |
*** markvoelker has quit IRC | 06:03 | |
*** armax has quit IRC | 06:04 | |
*** markvoelker has joined #openstack-neutron | 06:04 | |
*** yfried_ has joined #openstack-neutron | 06:04 | |
*** zz_avozza is now known as avozza | 06:05 | |
*** anshul has joined #openstack-neutron | 06:06 | |
*** ajo_ has joined #openstack-neutron | 06:08 | |
*** markvoelker has quit IRC | 06:08 | |
*** cipcosma has joined #openstack-neutron | 06:10 | |
*** ajo has quit IRC | 06:11 | |
*** nlahouti1 has quit IRC | 06:13 | |
*** nlahouti has joined #openstack-neutron | 06:13 | |
*** avozza is now known as zz_avozza | 06:15 | |
*** tflynn has quit IRC | 06:15 | |
*** tflynn has joined #openstack-neutron | 06:16 | |
*** jamielennox is now known as jamielennox|away | 06:17 | |
*** Marga_ has quit IRC | 06:20 | |
*** achanda has quit IRC | 06:20 | |
*** SridharG has joined #openstack-neutron | 06:22 | |
*** achanda has joined #openstack-neutron | 06:22 | |
*** irenab has joined #openstack-neutron | 06:24 | |
*** tflynn has quit IRC | 06:26 | |
*** tflynn has joined #openstack-neutron | 06:27 | |
*** neeti has joined #openstack-neutron | 06:30 | |
*** zhenq has joined #openstack-neutron | 06:31 | |
*** aepifanov has joined #openstack-neutron | 06:31 | |
*** achanda has quit IRC | 06:32 | |
*** ivar-laz_ has joined #openstack-neutron | 06:33 | |
*** ajo_ is now known as ajo | 06:35 | |
*** zhenq has quit IRC | 06:35 | |
*** vthapar has joined #openstack-neutron | 06:36 | |
openstackgerrit | Merged openstack/neutron: Hyper-V: Fixes security groups issue https://review.openstack.org/150826 | 06:36 |
*** ivar-lazzaro has quit IRC | 06:37 | |
*** lazy_prince is now known as killer_prince | 06:37 | |
*** ivar-laz_ has quit IRC | 06:38 | |
*** shwetaap has quit IRC | 06:41 | |
*** jprovazn has joined #openstack-neutron | 06:42 | |
*** killer_prince is now known as lazy_prince | 06:44 | |
*** rkukura has joined #openstack-neutron | 06:46 | |
*** leenheer has joined #openstack-neutron | 06:48 | |
trinaths | Hi Neutroners, Happy Morning | 06:48 |
*** markvoelker has joined #openstack-neutron | 06:53 | |
*** dane_leblanc has quit IRC | 06:55 | |
*** achanda has joined #openstack-neutron | 06:56 | |
openstackgerrit | Merged openstack/neutron: Search in /sys/class/net for network devices https://review.openstack.org/154021 | 06:58 |
*** pal has quit IRC | 06:58 | |
*** markvoelker has quit IRC | 06:58 | |
*** pal has joined #openstack-neutron | 06:58 | |
openstackgerrit | Yoni Shafrir proposed openstack/neutron: Adding support for Keepalived health check script. https://review.openstack.org/156563 | 06:59 |
*** julien_ZTE has quit IRC | 07:04 | |
*** tomoe_ has joined #openstack-neutron | 07:04 | |
*** julien_ZTE has joined #openstack-neutron | 07:04 | |
*** julien_ZTE has quit IRC | 07:04 | |
*** julien_ZTE has joined #openstack-neutron | 07:05 | |
*** tomoe_ has quit IRC | 07:06 | |
*** tflynn has quit IRC | 07:06 | |
*** tomoe_ has joined #openstack-neutron | 07:09 | |
*** Tarun has joined #openstack-neutron | 07:09 | |
*** julien_ZTE has quit IRC | 07:09 | |
*** tomoe_ has quit IRC | 07:11 | |
*** leenheer has quit IRC | 07:13 | |
*** mzbik has joined #openstack-neutron | 07:16 | |
Tarun | Hi I want to add a new message which would be localized in neutron code. So based on accept-language parameter from request it would be translated. i have made necessary changes but was not able to test it. My request packet does not contain this accept-language header. Could someone please tell me how this parameter could be set. | 07:16 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Use python binding instead of ovs-ofctl command https://review.openstack.org/153946 | 07:21 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: Make l2pop UT independent from OVS https://review.openstack.org/118620 | 07:21 |
*** _cjones_ has quit IRC | 07:23 | |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: test_l2population: Use a local copy of ofagent mech driver https://review.openstack.org/150239 | 07:23 |
openstackgerrit | YAMAMOTO Takashi proposed openstack/neutron: ofagent: Vendor code decomposition https://review.openstack.org/149941 | 07:23 |
*** _cjones_ has joined #openstack-neutron | 07:24 | |
openstackgerrit | Yoni Shafrir proposed openstack/neutron: Adding support for Keepalived health check script. https://review.openstack.org/156563 | 07:25 |
*** _cjones_ has quit IRC | 07:28 | |
*** tomoe_ has joined #openstack-neutron | 07:28 | |
*** blinky42 has quit IRC | 07:30 | |
*** tomoe_ has quit IRC | 07:30 | |
*** ZZelle has quit IRC | 07:32 | |
*** tomoe_ has joined #openstack-neutron | 07:32 | |
*** ZZelle has joined #openstack-neutron | 07:32 | |
*** garyk has joined #openstack-neutron | 07:33 | |
garyk | yshafrir: you there? | 07:34 |
garyk | yshafrir: can you please add DocImpact into the commit message for https://review.openstack.org/#/c/156563/ | 07:34 |
*** nmagnezi has joined #openstack-neutron | 07:35 | |
*** scheuran has joined #openstack-neutron | 07:40 | |
yshafrir | garyk, i added it | 07:46 |
*** kawa2014 has joined #openstack-neutron | 07:46 | |
yshafrir | garyk, for some reason i can't see it either | 07:46 |
yshafrir | garyk, i'll add it again | 07:46 |
garyk | yshafrir: thanks! let me know when you do and I will give my thiumbs up | 07:47 |
*** aranjan_ has quit IRC | 07:47 | |
yshafrir | garyk, thanks ! | 07:47 |
*** vitorc has quit IRC | 07:49 | |
*** salv-orlando has quit IRC | 07:51 | |
openstackgerrit | Yoni Shafrir proposed openstack/neutron: Adding support for Keepalived health check script. https://review.openstack.org/156563 | 07:52 |
yshafrir | garyk, added the DocImpact | 07:52 |
garyk | Thanks | 07:53 |
*** afazekas has joined #openstack-neutron | 07:54 | |
*** markvoelker has joined #openstack-neutron | 07:54 | |
*** vitorc has joined #openstack-neutron | 07:55 | |
*** aranjan has joined #openstack-neutron | 07:58 | |
*** markvoelker has quit IRC | 07:59 | |
*** boris-42 has joined #openstack-neutron | 08:00 | |
*** aranjan has quit IRC | 08:02 | |
openstackgerrit | Jaume Devesa proposed openstack/neutron: Update midonet plugin requirements https://review.openstack.org/156912 | 08:05 |
*** julien_ZTE has joined #openstack-neutron | 08:05 | |
*** jistr has joined #openstack-neutron | 08:08 | |
*** nyechiel_ has joined #openstack-neutron | 08:09 | |
*** chlong has quit IRC | 08:10 | |
*** ronis has joined #openstack-neutron | 08:11 | |
*** vitorc has quit IRC | 08:11 | |
*** evgenyf has joined #openstack-neutron | 08:11 | |
*** nlahouti has quit IRC | 08:12 | |
*** yamamoto has quit IRC | 08:13 | |
*** blinky42 has joined #openstack-neutron | 08:14 | |
*** moshele has joined #openstack-neutron | 08:15 | |
*** yamahata has quit IRC | 08:15 | |
*** yamahata has joined #openstack-neutron | 08:16 | |
*** vitorc has joined #openstack-neutron | 08:16 | |
openstackgerrit | Ann Kamyshnikova proposed openstack/neutron: Add a functional test that checks HA router is configured on a restarted agent https://review.openstack.org/153953 | 08:17 |
*** pask81 has joined #openstack-neutron | 08:17 | |
*** devvesa has joined #openstack-neutron | 08:18 | |
*** ajo has quit IRC | 08:18 | |
*** zhenq has joined #openstack-neutron | 08:20 | |
*** yuanying_ has quit IRC | 08:21 | |
*** shaohe_feng has joined #openstack-neutron | 08:22 | |
*** aepifanov has quit IRC | 08:22 | |
*** yuanying has joined #openstack-neutron | 08:22 | |
*** zhenq has quit IRC | 08:24 | |
*** stanzgy has joined #openstack-neutron | 08:26 | |
*** bjornar has joined #openstack-neutron | 08:27 | |
*** yuanying has quit IRC | 08:27 | |
*** yuanying has joined #openstack-neutron | 08:28 | |
openstackgerrit | Mike Kolesnik proposed openstack/neutron: Add proccess monitor to keepalived https://review.openstack.org/153162 | 08:29 |
*** yuanying has quit IRC | 08:30 | |
*** yuanying has joined #openstack-neutron | 08:31 | |
*** achanda has quit IRC | 08:31 | |
*** jlanoux has joined #openstack-neutron | 08:31 | |
*** ajo has joined #openstack-neutron | 08:35 | |
*** morgabra has quit IRC | 08:39 | |
*** asadoughi has quit IRC | 08:39 | |
*** jkyle1 has quit IRC | 08:40 | |
prometheanfire | akamyshnikova: ping, about the commit message you commented on | 08:41 |
*** asadoughi has joined #openstack-neutron | 08:41 | |
*** doude has joined #openstack-neutron | 08:41 | |
akamyshnikova | prometheanfire, hi, it is just a suggestion :) | 08:42 |
prometheanfire | well, I was hoping you'd know what to do about the failures | 08:43 |
*** morgabra has joined #openstack-neutron | 08:43 | |
prometheanfire | no mater what I try I can't construct a find command that works | 08:43 |
*** yuanying has quit IRC | 08:48 | |
*** salv-orlando has joined #openstack-neutron | 08:48 | |
*** yuanying has joined #openstack-neutron | 08:48 | |
*** jpena has joined #openstack-neutron | 08:49 | |
*** evgenyf has quit IRC | 08:49 | |
*** yuanying has quit IRC | 08:52 | |
*** jkyle1 has joined #openstack-neutron | 08:54 | |
*** markvoelker has joined #openstack-neutron | 08:55 | |
*** yuanying has joined #openstack-neutron | 08:55 | |
*** ajo has quit IRC | 08:56 | |
*** hjensas has joined #openstack-neutron | 08:58 | |
*** aranjan has joined #openstack-neutron | 08:59 | |
*** yuanying has quit IRC | 09:00 | |
*** markvoelker has quit IRC | 09:00 | |
*** salv-orlando has quit IRC | 09:01 | |
*** matrohon has joined #openstack-neutron | 09:01 | |
*** ajo has joined #openstack-neutron | 09:01 | |
*** salv-orlando has joined #openstack-neutron | 09:01 | |
akamyshnikova | prometheanfire, I'm afraid I don't, I just though it is WIP change | 09:02 |
*** yuanying has joined #openstack-neutron | 09:03 | |
*** aranjan has quit IRC | 09:03 | |
prometheanfire | it's definitely WIP | 09:08 |
prometheanfire | it's breaking me though | 09:08 |
prometheanfire | Command: ['sudo', 'ip', 'netns', 'exec', 'foo', 'find', '"/sys/class/net -type l"'] | 09:08 |
prometheanfire | Stderr: 'find: `"/sys/class/net -type l"\': No such file or directory\n' | 09:08 |
prometheanfire | but this works | 09:08 |
prometheanfire | sudo ip netns exec foo find /sys/class/net -type l | 09:08 |
prometheanfire | no idea | 09:08 |
openstackgerrit | Yoni Shafrir proposed openstack/neutron: Removing a router twice from the same agent shouldn't cause an error https://review.openstack.org/148883 | 09:08 |
*** yamamoto has joined #openstack-neutron | 09:10 | |
*** salv-orlando has quit IRC | 09:10 | |
*** salv-orlando has joined #openstack-neutron | 09:10 | |
*** severson_ has quit IRC | 09:10 | |
*** severson_ has joined #openstack-neutron | 09:11 | |
*** yamamoto has quit IRC | 09:12 | |
*** aepifanov has joined #openstack-neutron | 09:12 | |
*** severson_ has quit IRC | 09:14 | |
*** sseverson has joined #openstack-neutron | 09:15 | |
*** yamamoto has joined #openstack-neutron | 09:15 | |
*** stanzgy has quit IRC | 09:17 | |
*** ygbo has joined #openstack-neutron | 09:17 | |
*** yuanying has quit IRC | 09:18 | |
*** hichihara has quit IRC | 09:23 | |
*** jlibosva has joined #openstack-neutron | 09:23 | |
*** julien_ZTE has quit IRC | 09:24 | |
*** tomoe_ has quit IRC | 09:28 | |
*** tomoe_ has joined #openstack-neutron | 09:28 | |
*** tomoe_ has quit IRC | 09:30 | |
*** anilvenkata has joined #openstack-neutron | 09:31 | |
*** salv-orlando has quit IRC | 09:32 | |
*** salv-orlando has joined #openstack-neutron | 09:32 | |
*** yamamoto has quit IRC | 09:33 | |
*** salv-orlando has quit IRC | 09:35 | |
*** salv-orlando has joined #openstack-neutron | 09:36 | |
*** sbelous has joined #openstack-neutron | 09:37 | |
openstackgerrit | Isaku Yamahata proposed openstack/neutron: internal callers of create_{network, subnet, port} ignore extension https://review.openstack.org/129773 | 09:38 |
*** yamamoto has joined #openstack-neutron | 09:42 | |
*** maishsk has joined #openstack-neutron | 09:45 | |
*** salv-orlando has quit IRC | 09:45 | |
maishsk | good morning to you all | 09:45 |
maishsk | question - is it possible to apply a security group to a floating IP ? | 09:46 |
*** salv-orlando has joined #openstack-neutron | 09:46 | |
*** zz_avozza is now known as avozza | 09:46 | |
*** yamamoto has quit IRC | 09:46 | |
maishsk | I think it is neutron port-update --security-group <blah> | 09:46 |
*** apuimedo has joined #openstack-neutron | 09:46 | |
*** mkerrin has joined #openstack-neutron | 09:46 | |
maishsk | am I correct? | 09:46 |
*** gridinv has joined #openstack-neutron | 09:47 | |
*** ihrachyshka has joined #openstack-neutron | 09:49 | |
*** salv-orl_ has joined #openstack-neutron | 09:49 | |
*** salv-orl_ has quit IRC | 09:51 | |
*** salv-orlando has quit IRC | 09:51 | |
*** salv-orlando has joined #openstack-neutron | 09:51 | |
*** obondarev_ has quit IRC | 09:55 | |
*** obondarev has joined #openstack-neutron | 09:56 | |
*** salv-orlando has quit IRC | 09:56 | |
*** markvoelker has joined #openstack-neutron | 09:56 | |
*** salv-orlando has joined #openstack-neutron | 09:56 | |
*** lori|away is now known as lori | 09:57 | |
*** evgenyf has joined #openstack-neutron | 09:58 | |
boris-42 | garyk: hi hi | 09:58 |
boris-42 | garyk: could you please take a look one more time at https://review.openstack.org/#/c/155789/ | 09:59 |
boris-42 | garyk: it fails quite often in rally gates=) | 09:59 |
*** ollivier has joined #openstack-neutron | 09:59 | |
*** aranjan has joined #openstack-neutron | 10:00 | |
garyk | boris-42: sure. rally is giving me too many sleepless nights | 10:01 |
*** markvoelker has quit IRC | 10:02 | |
*** dsneddon has quit IRC | 10:02 | |
boris-42 | garyk: lol | 10:03 |
*** aranjan has quit IRC | 10:04 | |
boris-42 | garyk: thank you | 10:06 |
akamyshnikova | garyk, thanks! | 10:06 |
akamyshnikova | salv-orlando, mestery hi! Could you take a look at this change https://review.openstack.org/#/c/155789/ too? | 10:07 |
garyk | boris-42: please stop working on rally - it gives me too many headaches :) | 10:08 |
*** zhenq has joined #openstack-neutron | 10:09 | |
*** jp_at_hp has joined #openstack-neutron | 10:10 | |
openstackgerrit | Numan Siddique proposed openstack/neutron-vpnaas: Fix the ipsec conn issue when peer addr is fqdn https://review.openstack.org/145005 | 10:10 |
*** numan has joined #openstack-neutron | 10:10 | |
boris-42 | garyk: hehe | 10:11 |
*** jamiec has quit IRC | 10:13 | |
*** zhenq has quit IRC | 10:13 | |
*** yamahata has quit IRC | 10:15 | |
*** numan has quit IRC | 10:16 | |
*** xuhanp has quit IRC | 10:16 | |
*** jamiec has joined #openstack-neutron | 10:17 | |
openstackgerrit | Miguel Angel Ajo proposed openstack/neutron: WIP: Reorders firewall security group/members calls. https://review.openstack.org/156566 | 10:17 |
ajo | hanzhang ^ | 10:18 |
ajo | if you can take a look to that commit | 10:18 |
ajo | I found something via an error message that I included into the ipset implementation | 10:18 |
*** saju_m has quit IRC | 10:25 | |
*** obondarev has quit IRC | 10:25 | |
*** obondarev_ has joined #openstack-neutron | 10:25 | |
*** britthou_ has joined #openstack-neutron | 10:25 | |
*** julien_ZTE has joined #openstack-neutron | 10:26 | |
*** Apsu has quit IRC | 10:26 | |
*** saju_m has joined #openstack-neutron | 10:27 | |
*** britthouser has quit IRC | 10:27 | |
*** MentalRay has joined #openstack-neutron | 10:28 | |
*** numan has joined #openstack-neutron | 10:28 | |
*** p01s0n has joined #openstack-neutron | 10:28 | |
*** MentalRay has quit IRC | 10:29 | |
*** Apsu has joined #openstack-neutron | 10:29 | |
*** evgenyf has quit IRC | 10:32 | |
*** yamamoto has joined #openstack-neutron | 10:33 | |
*** zhenq has joined #openstack-neutron | 10:34 | |
*** nyechiel__ has joined #openstack-neutron | 10:34 | |
*** nyechiel_ has quit IRC | 10:36 | |
*** zhenq has quit IRC | 10:38 | |
*** yamamoto has quit IRC | 10:38 | |
*** shaohe_feng has quit IRC | 10:39 | |
*** yatin has quit IRC | 10:39 | |
*** yamamoto has joined #openstack-neutron | 10:52 | |
*** yamamoto has quit IRC | 10:58 | |
*** obondarev_ has quit IRC | 10:59 | |
*** obondarev has joined #openstack-neutron | 11:00 | |
*** yamamoto has joined #openstack-neutron | 11:00 | |
*** aranjan has joined #openstack-neutron | 11:00 | |
*** yamamoto has quit IRC | 11:02 | |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: Don't monkey patch netns_cleanup https://review.openstack.org/155373 | 11:02 |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: tests: monkey patch stdlib before importing other modules https://review.openstack.org/153225 | 11:02 |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: Monkey patch all the code inside neutron/cmd/eventlet/... https://review.openstack.org/156942 | 11:02 |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron-vpnaas: Explicitly monkey patch VPN agent https://review.openstack.org/156602 | 11:02 |
*** aranjan has quit IRC | 11:05 | |
*** kbyrne has quit IRC | 11:09 | |
*** kbyrne has joined #openstack-neutron | 11:13 | |
*** nyechiel__ has quit IRC | 11:17 | |
*** nyechiel__ has joined #openstack-neutron | 11:17 | |
*** stanzgy has joined #openstack-neutron | 11:18 | |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: Moved several services into neutron.cmd.eventlet https://review.openstack.org/155374 | 11:19 |
*** dims__ has joined #openstack-neutron | 11:19 | |
*** amotoki has quit IRC | 11:20 | |
*** nyechiel has joined #openstack-neutron | 11:21 | |
*** p01s0n has quit IRC | 11:21 | |
*** nyechiel__ has quit IRC | 11:21 | |
*** smcgough has left #openstack-neutron | 11:22 | |
*** stanzgy has quit IRC | 11:23 | |
*** evgenyf has joined #openstack-neutron | 11:24 | |
*** stanzgy has joined #openstack-neutron | 11:25 | |
*** tomoe_ has joined #openstack-neutron | 11:25 | |
*** kawa2014 has quit IRC | 11:26 | |
*** saju_m has quit IRC | 11:31 | |
*** bobmel has quit IRC | 11:31 | |
*** bobmel has joined #openstack-neutron | 11:31 | |
*** saju_m has joined #openstack-neutron | 11:32 | |
openstackgerrit | Numan Siddique proposed openstack/neutron-vpnaas: Fix the ipsec conn issue when peer addr is fqdn https://review.openstack.org/145005 | 11:34 |
openstackgerrit | Henry Gessau proposed openstack/neutron: Remove root_helper arg from external_process https://review.openstack.org/154959 | 11:36 |
*** moha_hunt has joined #openstack-neutron | 11:37 | |
*** aix has joined #openstack-neutron | 11:37 | |
*** humble_ has joined #openstack-neutron | 11:38 | |
openstackgerrit | Henry Gessau proposed openstack/neutron: Remove root_helper arg from IptablesManager https://review.openstack.org/154969 | 11:39 |
*** pc_m has joined #openstack-neutron | 11:41 | |
ihrachyshka | HenryG, heh, you're on board with killing helper, nice | 11:43 |
*** chlong has joined #openstack-neutron | 11:44 | |
*** mzbik has quit IRC | 11:53 | |
openstackgerrit | Derek Higgins proposed openstack/neutron: Revert "Add the rebinding chance in _bind_port_if_needed" https://review.openstack.org/156853 | 11:53 |
*** derekh has joined #openstack-neutron | 11:53 | |
HenryG | ihrachyshka: yes, trying to get the patch sequence through the gate | 11:54 |
*** nyechiel has quit IRC | 11:54 | |
derekh | Hi all, tripleo-ci appears to be suffering from at least 2 (probably 3) regressions that have snuck in since friday, this revert https://review.openstack.org/#/c/156853/ seems to fix one of them | 11:55 |
openstackgerrit | Henry Gessau proposed openstack/neutron: Remove root_helper arg from IpsetManager https://review.openstack.org/154980 | 11:55 |
derekh | I havn't looked into the problem have to track down the other problems | 11:55 |
*** rpothier has joined #openstack-neutron | 11:58 | |
*** aix_ has joined #openstack-neutron | 11:58 | |
*** aix_ has quit IRC | 11:59 | |
*** aix has quit IRC | 11:59 | |
*** aix has joined #openstack-neutron | 11:59 | |
*** aix has quit IRC | 12:00 | |
*** aix has joined #openstack-neutron | 12:00 | |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: Moved several services into neutron.cmd.eventlet https://review.openstack.org/155374 | 12:01 |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: Move entry points for some 3party plugins into neutron.cmd.eventlet https://review.openstack.org/155412 | 12:01 |
*** aranjan has joined #openstack-neutron | 12:01 | |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: Move entry points for some 3party plugins into neutron.cmd.eventlet https://review.openstack.org/155412 | 12:02 |
*** zhenq has joined #openstack-neutron | 12:04 | |
*** aranjan has quit IRC | 12:05 | |
*** yatin has joined #openstack-neutron | 12:05 | |
*** obondarev_ has joined #openstack-neutron | 12:07 | |
*** zhenq has quit IRC | 12:09 | |
*** jistr has quit IRC | 12:09 | |
*** obondarev has quit IRC | 12:09 | |
ZZelle | salv-orlando, hi | 12:11 |
*** jistr has joined #openstack-neutron | 12:12 | |
*** steveg is now known as sgordon | 12:14 | |
*** obondarev_ has quit IRC | 12:18 | |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: Moved several services into neutron.cmd.eventlet https://review.openstack.org/155374 | 12:19 |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: Move entry points for plugin agents into neutron.cmd.eventlet https://review.openstack.org/155412 | 12:19 |
*** salv-orlando has quit IRC | 12:20 | |
*** MentalRay has joined #openstack-neutron | 12:20 | |
openstackgerrit | Praveen Kumar SM proposed openstack/neutron: DHCP Service LoadBalancing Scheduler https://review.openstack.org/137017 | 12:21 |
*** NellyK has joined #openstack-neutron | 12:23 | |
*** nyechiel has joined #openstack-neutron | 12:24 | |
*** apuimedo has quit IRC | 12:28 | |
openstackgerrit | Praveen Kumar SM proposed openstack/neutron: DHCP Service LoadBalancing Scheduler https://review.openstack.org/137017 | 12:31 |
*** NellyK has quit IRC | 12:32 | |
*** NellyK has joined #openstack-neutron | 12:33 | |
*** signed8bit has joined #openstack-neutron | 12:37 | |
*** signed8bit is now known as signed8bit_ZZZzz | 12:37 | |
*** signed8bit_ZZZzz is now known as signed8bit | 12:37 | |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: Monkey patch all the code inside neutron/cmd/eventlet/... https://review.openstack.org/156942 | 12:37 |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: Don't monkey patch netns_cleanup https://review.openstack.org/155373 | 12:37 |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: Moved several services into neutron.cmd.eventlet https://review.openstack.org/155374 | 12:37 |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: tests: monkey patch stdlib before importing other modules https://review.openstack.org/153225 | 12:37 |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron: Move entry points for plugin agents into neutron.cmd.eventlet https://review.openstack.org/155412 | 12:37 |
*** amotoki has joined #openstack-neutron | 12:37 | |
*** NellyK has quit IRC | 12:40 | |
*** sgordon is now known as steveg | 12:42 | |
eezhova | amotoki, could you please take a look at https://review.openstack.org/#/c/138708/ ? | 12:42 |
amotoki | eezhova: will look after writing a mail. | 12:45 |
eezhova | amotoki, thanks | 12:45 |
*** shilpa_ has quit IRC | 12:47 | |
*** radez_g0n3 is now known as radez | 12:48 | |
*** seizadi has joined #openstack-neutron | 12:50 | |
*** amuller has joined #openstack-neutron | 12:51 | |
ihrachyshka | amotoki, fyi I've updated monkey patches to leave dumb main()s inside neutron/cmd/eventlet/... | 12:51 |
*** pal has quit IRC | 12:51 | |
amotoki | ihrachyshka: I am not sure everyone like my idea. I hope it help the situation. | 12:52 |
ihrachyshka | amotoki, we'll see. :) salv was also for one liners. | 12:52 |
ihrachyshka | amotoki, drivers meeting is in several hours | 12:53 |
ihrachyshka | amotoki, afaik this will be one of the points to discuss | 12:53 |
amotoki | ihrachyshka: yeah. I need to spend some more hours before going to bed. | 12:54 |
*** trinaths has left #openstack-neutron | 12:54 | |
*** seizadi1 has joined #openstack-neutron | 12:54 | |
*** seizadi has quit IRC | 12:54 | |
*** seizadi has joined #openstack-neutron | 12:58 | |
*** seizadi1 has quit IRC | 12:59 | |
*** aix has quit IRC | 12:59 | |
*** seizadi1 has joined #openstack-neutron | 13:01 | |
*** yatin has quit IRC | 13:01 | |
*** signed8bit has quit IRC | 13:02 | |
*** aranjan has joined #openstack-neutron | 13:02 | |
*** seizadi has quit IRC | 13:02 | |
*** baoli has joined #openstack-neutron | 13:03 | |
*** baoli has quit IRC | 13:04 | |
*** baoli has joined #openstack-neutron | 13:05 | |
*** seizadi1 has quit IRC | 13:05 | |
*** seizadi has joined #openstack-neutron | 13:05 | |
*** jaypipes has joined #openstack-neutron | 13:05 | |
*** aranjan has quit IRC | 13:06 | |
*** signed8bit has joined #openstack-neutron | 13:07 | |
*** yamamoto has joined #openstack-neutron | 13:08 | |
*** markvoelker has joined #openstack-neutron | 13:11 | |
*** seizadi has quit IRC | 13:11 | |
*** neeti has quit IRC | 13:12 | |
*** aix has joined #openstack-neutron | 13:12 | |
*** seizadi has joined #openstack-neutron | 13:13 | |
*** rpothier has quit IRC | 13:15 | |
*** obondarev has joined #openstack-neutron | 13:17 | |
*** anilvenkata has left #openstack-neutron | 13:17 | |
*** zigo has quit IRC | 13:18 | |
*** jprovazn has quit IRC | 13:19 | |
*** zigo has joined #openstack-neutron | 13:20 | |
*** jprovazn has joined #openstack-neutron | 13:21 | |
openstackgerrit | Henry Gessau proposed openstack/neutron: Remove root_helper arg from SecurityGroupAgentRpc https://review.openstack.org/155013 | 13:24 |
*** salv-orlando has joined #openstack-neutron | 13:25 | |
openstackgerrit | Henry Gessau proposed openstack/neutron: Remove root_helper arg from linuxbridge https://review.openstack.org/155014 | 13:25 |
*** moshele has quit IRC | 13:25 | |
*** seizadi has quit IRC | 13:26 | |
*** signed8bit has quit IRC | 13:27 | |
*** signed8b_ has joined #openstack-neutron | 13:27 | |
*** seizadi has joined #openstack-neutron | 13:27 | |
*** shwetaap has joined #openstack-neutron | 13:34 | |
*** anish_ has quit IRC | 13:35 | |
*** aix has quit IRC | 13:37 | |
*** shaohe_feng has joined #openstack-neutron | 13:38 | |
*** rotbeard has quit IRC | 13:38 | |
*** seizadi has quit IRC | 13:41 | |
*** bobmel has quit IRC | 13:42 | |
*** bobmel has joined #openstack-neutron | 13:42 | |
*** humble_ has quit IRC | 13:43 | |
*** kawa2014 has joined #openstack-neutron | 13:44 | |
openstackgerrit | Merged openstack/neutron: Skip DBDuplicateEntry exception in security group creation https://review.openstack.org/155789 | 13:46 |
*** ramishra_ has joined #openstack-neutron | 13:49 | |
*** trown has quit IRC | 13:49 | |
*** evanjfraser has quit IRC | 13:49 | |
openstackgerrit | Miguel Angel Ajo proposed openstack/neutron: WIP: Investigating the cause for bug/1421772 https://review.openstack.org/156566 | 13:49 |
*** krtaylor has quit IRC | 13:50 | |
*** saju_m has quit IRC | 13:50 | |
*** trown has joined #openstack-neutron | 13:50 | |
*** evanjfraser has joined #openstack-neutron | 13:51 | |
*** krtaylor has joined #openstack-neutron | 13:56 | |
*** yamamoto has quit IRC | 14:00 | |
*** jckasper_ has quit IRC | 14:00 | |
*** annegent_ has joined #openstack-neutron | 14:01 | |
*** kbringard has joined #openstack-neutron | 14:02 | |
*** aranjan has joined #openstack-neutron | 14:03 | |
*** aix has joined #openstack-neutron | 14:03 | |
*** aranjan has quit IRC | 14:07 | |
*** yamamoto has joined #openstack-neutron | 14:08 | |
*** moha_hunt has quit IRC | 14:08 | |
mestery | otherwiseguy: Are all of your root helper patches merged now? A quick glance leads me to think yes! | 14:13 |
*** wverdugo5001 has joined #openstack-neutron | 14:13 | |
openstackgerrit | Merged openstack/neutron: Remove root_helper arg from external_process https://review.openstack.org/154959 | 14:13 |
*** dims__ has quit IRC | 14:15 | |
openstackgerrit | Merged openstack/neutron: Remove root_helper arg from IptablesManager https://review.openstack.org/154969 | 14:16 |
*** ramishra_ has quit IRC | 14:17 | |
*** annegent_ has quit IRC | 14:18 | |
*** annegent_ has joined #openstack-neutron | 14:19 | |
*** dims__ has joined #openstack-neutron | 14:20 | |
*** shilpa_ has joined #openstack-neutron | 14:20 | |
*** dims__ has quit IRC | 14:20 | |
*** dims__ has joined #openstack-neutron | 14:21 | |
openstackgerrit | Henry Gessau proposed openstack/neutron: Remove root_helper arg from AsyncProcess https://review.openstack.org/155101 | 14:21 |
*** localloop127 has joined #openstack-neutron | 14:21 | |
openstackgerrit | Henry Gessau proposed openstack/neutron: Remove root_helper arg from DHCP agent https://review.openstack.org/155188 | 14:22 |
*** tiswanso has joined #openstack-neutron | 14:23 | |
openstackgerrit | Merged openstack/neutron: Remove root_helper arg from IpsetManager https://review.openstack.org/154980 | 14:24 |
*** dims__ has quit IRC | 14:25 | |
*** jckasper has joined #openstack-neutron | 14:26 | |
*** evgenyf has quit IRC | 14:27 | |
*** shilpa_ has quit IRC | 14:27 | |
*** dboik has joined #openstack-neutron | 14:29 | |
*** changbl has quit IRC | 14:32 | |
*** rushil has joined #openstack-neutron | 14:32 | |
*** localloop127 has quit IRC | 14:33 | |
*** yshafrir has quit IRC | 14:35 | |
*** Guest37356 has joined #openstack-neutron | 14:35 | |
*** jgrimm is now known as zz_jgrimm | 14:38 | |
*** baoli has quit IRC | 14:39 | |
*** shwetaap1 has joined #openstack-neutron | 14:39 | |
*** baoli has joined #openstack-neutron | 14:39 | |
*** baoli has quit IRC | 14:42 | |
*** shwetaap has quit IRC | 14:42 | |
*** ramishra_ has joined #openstack-neutron | 14:43 | |
*** seizadi has joined #openstack-neutron | 14:43 | |
*** baoli has joined #openstack-neutron | 14:43 | |
otherwiseguy | mestery: they are at least in process. | 14:43 |
*** imcsk8 has quit IRC | 14:45 | |
*** imcsk8 has joined #openstack-neutron | 14:45 | |
*** kkuznetsova has joined #openstack-neutron | 14:45 | |
otherwiseguy | mestery: Looks like some more rebasing done overnight. Still have about 13 patches to go. :) | 14:45 |
*** localloop127 has joined #openstack-neutron | 14:46 | |
*** vthapar has quit IRC | 14:46 | |
*** kkuznetsova has quit IRC | 14:46 | |
*** kkuznetsova has joined #openstack-neutron | 14:47 | |
*** rotbeard has joined #openstack-neutron | 14:47 | |
*** seizadi has quit IRC | 14:47 | |
*** anshul has quit IRC | 14:48 | |
*** Guest37356 is now known as dims__ | 14:49 | |
*** shaohe_feng has quit IRC | 14:49 | |
amotoki | ihrachyshka: question on oslo.log. do we need to migrate graduated oslo.log in Kilo? I tried to search the status, but I can't find out the exact status. | 14:50 |
*** ajo has quit IRC | 14:51 | |
*** ajo has joined #openstack-neutron | 14:51 | |
mestery | otherwiseguy: ack | 14:51 |
roaet | amotoki: good evening(?) | 14:52 |
otherwiseguy | mestery: which means most of my day will be spent staring at zuul and fixing things as soon as they go off the rails. :p | 14:52 |
amotoki | roaet: good night? | 14:52 |
mestery | otherwiseguy: Ping me as you need merge help my friend :) | 14:52 |
otherwiseguy | mestery: count on it. :) | 14:53 |
roaet | that works haha. in regards to your comments on https://review.openstack.org/#/c/148318/12 if I put the underscore in front of the module (which I absolutely support and it makes sense to not show fox-* commands), would you be opposed to me adding a special case to allow fox_sockets to be tested still? | 14:53 |
ihrachyshka | amotoki, I don't think it was officially releaseds. | 14:53 |
ihrachyshka | amotoki, no email on it in openstack-dev@ | 14:54 |
ihrachyshka | amotoki, so even if there are pypi packages, they are not considered final for consumption | 14:54 |
amotoki | ihrachyshka: I think so too, but we no longer has openstack.common.log in oslo-incubator. | 14:54 |
ihrachyshka | amotoki, I prefer not to consume stuff that is not blessed by oslo team | 14:54 |
*** krtaylor has quit IRC | 14:54 | |
ihrachyshka | amotoki, right, I guess guys are in the middle of graduating it | 14:54 |
ihrachyshka | amotoki, do you have specific need for incubator version? a bug in mind? | 14:55 |
amotoki | ihrachyshka: yes, agree. it seems better I check the status to them. | 14:55 |
ihrachyshka | amotoki, for kilo, we're going to consider oslo.policy, but that's all I guess | 14:55 |
amotoki | ihrachyshka: no, i don't see any specific topic which needs to be updated. | 14:55 |
*** krtaylor has joined #openstack-neutron | 14:55 | |
ihrachyshka | amotoki, (policy is also not yet released) | 14:55 |
*** shaohe_feng has joined #openstack-neutron | 14:55 | |
amotoki | ihrachyshka: I just noticed it when I worked plugin decomposition and I could not find log from incubator. this raised me a question. | 14:57 |
ihrachyshka | amotoki, ack. do plugins maintain their own copy of incubator files? | 14:57 |
pc_m | ihrachyshka: Can we talk about https://review.openstack.org/#/c/156602? | 14:57 |
*** yfried_ has quit IRC | 14:57 | |
ihrachyshka | amotoki, I hope so since I'm not going to make sure I don't break them updating oslo files in neutron :) | 14:57 |
ihrachyshka | amotoki, *aas repos consuming neutron oslo modules is more than enough to make me busy | 14:58 |
amotoki | ihrachyshka: if a plugin consumes some modules from incubator, i think it is good to copy it. | 14:58 |
ihrachyshka | pc_m, sure | 14:58 |
pc_m | ihrachyshka: Would like to understand what we're doing (as I'm not that familiar with the monkey patching stuff). | 14:58 |
ihrachyshka | amotoki, for *aas repos, it's different. hence I am asking. | 14:58 |
amotoki | ihrachyshka: ah, i see. for *aas, it is better to sync with neutorn. they are all upstream repositories. | 14:59 |
amotoki | ihrachyshka: s/sync with/consume from/ | 14:59 |
*** salv-orlando has quit IRC | 15:00 | |
pc_m | ihrachyshka: In PS2 it looked like it was importing from neutron.agent, and if not there, would import from neutron.cmd.agents to call main() on the L3 agent. | 15:00 |
ihrachyshka | pc_m, so, now instead of calling monkey_patch() in random places in neutron/..., we consolidate it into neutron/cmd/eventlet/__init__.py and put all entry points for all agents that run with eventlet on there, so that monkey_patch() is called for them when import is done. but since vpn agent reuses l3 agent main() and assumes it's monkey patched, and since it's not the case with new scheme, we need to patch stdlib explicit | 15:00 |
ihrachyshka | ly. | 15:00 |
ihrachyshka | amotoki, right. | 15:00 |
ihrachyshka | pc_m, right, the initial idea was to move actual main() functions under neutron/cmd/... | 15:00 |
ihrachyshka | pc_m, but then there was a concern that we probably want to avoid this shuffling | 15:01 |
*** armax has joined #openstack-neutron | 15:01 | |
ihrachyshka | pc_m, so instead of this, we just put dump main() functions under neutron/cmd/eventlet/... that just call to 'real' main() located under old path | 15:01 |
*** salv-orlando has joined #openstack-neutron | 15:02 | |
amotoki | ihrachyshka: pc_m: where we should place main() is another headache. Some reason they are located in the main code (e.g., neutron/agent/dhcp_agent.py) is to ensure monkey-patched :-( | 15:03 |
*** evgenyf has joined #openstack-neutron | 15:03 | |
amotoki | we will discuss it in 30 minutes, so we can defer the discussion. | 15:04 |
ihrachyshka | right. | 15:04 |
ihrachyshka | pc_m, drivers meeting is in <30 mins | 15:04 |
ihrachyshka | pc_m, it's on agenda, you can join for details | 15:04 |
*** jordandh has quit IRC | 15:04 | |
*** aranjan has joined #openstack-neutron | 15:04 | |
*** jordandh has joined #openstack-neutron | 15:04 | |
pc_m | ihrachyshka: I think I better, as I'm trying to wrap my head around all this. | 15:04 |
pc_m | ihrachyshka: I'm fuzzy on what the monkey patching does and why it's needed. | 15:05 |
*** ramishra_ has quit IRC | 15:05 | |
*** pal has joined #openstack-neutron | 15:05 | |
ihrachyshka | pc_m, well... then you can start from eventlet docs, it should give some grasp | 15:06 |
amotoki | pc_m: briefly speaking, eventlet needs modified version of some standard modules. it is what monkey patch does. | 15:06 |
pc_m | ihrachyshka: WIll do... It seems that it is dynamically modifying attributes, but I'm trying to understand what is being modified and why. | 15:07 |
pc_m | ihrachyshka: | 15:07 |
ihrachyshka | pc_m, right, it replaces some parts of stdlib to make them non blocking but yielding to other green threads. | 15:07 |
ihrachyshka | pc_m, http://eventlet.net/doc/patching.html#monkeypatching-the-standard-library | 15:07 |
ihrachyshka | you can get an idea of the list of modules patches | 15:07 |
ihrachyshka | *patched | 15:07 |
*** aranjan has quit IRC | 15:09 | |
pc_m | ihrachyshka: thanks, starting to get clearer. | 15:10 |
pc_m | ihrachyshka: Can you elaborate on why it is needed now for the vpn agent, whereas we didn't before? | 15:11 |
openstackgerrit | Terry Wilson proposed openstack/neutron-vpnaas: Remove remaining root_helper references https://review.openstack.org/156691 | 15:12 |
*** nmagnezi has quit IRC | 15:12 | |
*** sseverson has quit IRC | 15:14 | |
*** sseverson has joined #openstack-neutron | 15:14 | |
*** irenab has quit IRC | 15:14 | |
*** numan has quit IRC | 15:16 | |
*** pal_ has joined #openstack-neutron | 15:16 | |
*** marun has joined #openstack-neutron | 15:17 | |
*** pal has quit IRC | 15:19 | |
openstackgerrit | Rajeev Grover proposed openstack/neutron: fix for _get_external_device_interface_name trace https://review.openstack.org/156357 | 15:22 |
ihrachyshka | pc_m, because before the changes that I refer to in commit message, importing neutron.agent.l3_agent would monkey patch your stdlib for you. but now that eventlet.monkey_patch() calls are being consolidated in a separate file, it's no longer the case. since we don't want vpn agent to unintentionally switch to non-patched mode, we need to make sure it patches stdlib on its own. | 15:22 |
*** zz_jgrimm is now known as jgrimm | 15:22 | |
*** dkehn has joined #openstack-neutron | 15:22 | |
pc_m | ihrachyshka: Ah. that makes more sense now | 15:26 |
pc_m | ihrachyshka: thanks! | 15:26 |
ihrachyshka | pc_m, ur welcome | 15:26 |
openstackgerrit | Rajeev Grover proposed openstack/neutron: fix for _get_external_device_interface_name trace https://review.openstack.org/156357 | 15:31 |
*** devlaps has joined #openstack-neutron | 15:32 | |
*** ollivier has quit IRC | 15:33 | |
*** spradeepv has joined #openstack-neutron | 15:36 | |
*** Murali has quit IRC | 15:36 | |
*** amuller has quit IRC | 15:36 | |
*** shivharis has joined #openstack-neutron | 15:38 | |
openstackgerrit | Brian Haley proposed openstack/neutron: Check if routing rule exists before adding https://review.openstack.org/152330 | 15:39 |
*** dane_leblanc has joined #openstack-neutron | 15:40 | |
*** tomoe_ has quit IRC | 15:41 | |
*** zhenq has joined #openstack-neutron | 15:42 | |
*** zzzeek has joined #openstack-neutron | 15:43 | |
openstackgerrit | Miguel Angel Ajo proposed openstack/neutron: WIP: Investigating the cause for bug/1421772 https://review.openstack.org/156566 | 15:45 |
*** carl_baldwin has joined #openstack-neutron | 15:45 | |
*** dboik has quit IRC | 15:45 | |
*** carl_baldwin has quit IRC | 15:45 | |
*** carl_baldwin has joined #openstack-neutron | 15:46 | |
*** shilpa_ has joined #openstack-neutron | 15:47 | |
openstackgerrit | Pavel Bondar proposed openstack/neutron: Refactor db_base_plugin_v2.py to use new IPAM https://review.openstack.org/153236 | 15:47 |
*** Sukhdev has joined #openstack-neutron | 15:48 | |
*** aranjan has joined #openstack-neutron | 15:51 | |
*** a_le_ has quit IRC | 15:51 | |
*** shilpa_ has quit IRC | 15:52 | |
*** dboik has joined #openstack-neutron | 15:52 | |
*** aranjan has quit IRC | 15:53 | |
*** pasha117 has quit IRC | 15:53 | |
*** dboik_ has joined #openstack-neutron | 15:54 | |
*** tomoe_ has joined #openstack-neutron | 15:55 | |
*** tomoe_ has quit IRC | 15:56 | |
*** moshele has joined #openstack-neutron | 15:56 | |
*** dboik has quit IRC | 15:57 | |
*** yamahata has joined #openstack-neutron | 15:58 | |
openstackgerrit | Merged openstack/python-neutronclient: Add unit tests for agentscheduler related commands https://review.openstack.org/138708 | 15:59 |
*** tomoe_ has joined #openstack-neutron | 16:00 | |
*** a_le has joined #openstack-neutron | 16:00 | |
*** rm_work|away is now known as rm_work | 16:04 | |
*** anshul has joined #openstack-neutron | 16:04 | |
*** csoukup has joined #openstack-neutron | 16:04 | |
*** spradeepv has left #openstack-neutron | 16:05 | |
openstackgerrit | Merged openstack/neutron: Remove root_helper arg from SecurityGroupAgentRpc https://review.openstack.org/155013 | 16:09 |
*** stanzgy has quit IRC | 16:10 | |
*** evgenyf has quit IRC | 16:10 | |
*** xgerman has joined #openstack-neutron | 16:12 | |
openstackgerrit | Terry Wilson proposed openstack/neutron: Remove root_helper arg from L3 Agent https://review.openstack.org/155212 | 16:13 |
otherwiseguy | HenryG: mestery: The next patch up for review/merge for root_helper is the vpnaas patch that will need to be merged before the l3_agent neutron patch is merged | 16:16 |
mestery | otherwiseguy: Link? | 16:16 |
*** neeti has joined #openstack-neutron | 16:16 | |
otherwiseguy | mestery: doh. https://review.openstack.org/#/c/156690/ | 16:16 |
HenryG | otherwiseguy: I am keeping an eye on the patches in queue | 16:17 |
otherwiseguy | HenryG: thanks! | 16:17 |
otherwiseguy | (me too) :) | 16:17 |
*** ollivier has joined #openstack-neutron | 16:17 | |
*** carl_baldwin_ has joined #openstack-neutron | 16:19 | |
otherwiseguy | Trying to catch issues as early as possible. Kind of weird that my second vpnaas patch which depends on the l3agent stuff fails py27 as though the l3agent patch wasn't dependent (even though I can see it pull the l3agent patch in zuul). If I checkout the l3agent review directly and put it in .tox/py27/src/neutron, the py27 test passes. | 16:19 |
*** ParsectiX has joined #openstack-neutron | 16:19 | |
*** carl_baldwin has quit IRC | 16:19 | |
*** carl_baldwin_ is now known as carl_baldwin | 16:19 | |
*** hjensas has quit IRC | 16:19 | |
*** dboik_ has quit IRC | 16:19 | |
*** dboik has joined #openstack-neutron | 16:20 | |
*** dboik_ has joined #openstack-neutron | 16:22 | |
*** ollivier has quit IRC | 16:23 | |
*** pradk has joined #openstack-neutron | 16:24 | |
*** mlavalle has joined #openstack-neutron | 16:25 | |
*** dboik has quit IRC | 16:25 | |
*** mlavalle has quit IRC | 16:26 | |
*** steveg is now known as sgordon | 16:27 | |
*** mlavalle has joined #openstack-neutron | 16:27 | |
*** ajmiller has joined #openstack-neutron | 16:27 | |
*** sgordon has quit IRC | 16:27 | |
*** sgordon has joined #openstack-neutron | 16:27 | |
*** david-lyle_afk is now known as david-lyle | 16:28 | |
roaet | Similar to adding the command extensibility to the client to bridge the gap, we have a bp for auth extensibility as well, and it is also ready to be reviewed (once we push it). | 16:30 |
mestery | roaet: In the client? | 16:31 |
roaet | mestery: yes, since there is no way to not use keystone or noauth | 16:31 |
roaet | mestery: https://blueprints.launchpad.net/python-neutronclient/+spec/pluggable-neutronclient-auth | 16:31 |
mestery | amotoki: ^^^^ Can you review this one? | 16:31 |
roaet | mestery: tbh they are literally the same thing to us but we just.. made two blueprints so it wasn't dorky. | 16:31 |
ihrachyshka | mestery, markmcclain, armax, salv-orlando: we will also need https://review.openstack.org/#/c/156602/ on vpnaas side before merging https://review.openstack.org/155374 | 16:31 |
otherwiseguy | HenryG: weird, in the gate test the vpnaas patch py27 failed (https://jenkins02.openstack.org/job/gate-neutron-vpnaas-python27/46/console) because it passes root_helper to RouterInfo, which should still have support for the argument until the L3Agent patch (https://review.openstack.org/#/c/155212/11/neutron/agent/l3/router_info.py) removes it. | 16:32 |
amotoki | mestery: sure, but i can't have enough time on this. probally this weekend. | 16:32 |
otherwiseguy | and the l3agent patch isn't in the gate yet. | 16:32 |
roaet | amotoki: it is no rush, our review hasn't even been pushed. We'll try to get one out this friday | 16:32 |
*** armax has quit IRC | 16:32 | |
roaet | mestery: amotoki I appreciate your time. | 16:33 |
*** armax has joined #openstack-neutron | 16:33 | |
HenryG | otherwiseguy: Is the gate basing *aas patches on neutron patches? | 16:33 |
*** avozza is now known as zz_avozza | 16:33 | |
amotoki | roaet: nice. there are several hardcoding logic in auth logic and i believe your bp help to address the situation :) | 16:33 |
roaet | amotoki: I kind of added the noauth hardcoding :/ | 16:33 |
amotoki | roaet: on the other hand, i wonder it fits OSC/SDK more. | 16:34 |
otherwiseguy | HenryG: I specifically broke the vpnaas patches into two bits so I could do Depends-On: $ip_lib_patch in one and Depends-On: $l3_agent_patch in another. Don't know why it would be pulling in something that is just in the check queue... | 16:34 |
dougwig | marun: is now good? what I was thinking would not need a co-gate. can you expand on that? | 16:34 |
*** ronis has quit IRC | 16:35 | |
roaet | amotoki: it is a similar situation, some providers' users rely on the python-* clients, but with auth the way it is they don't work. | 16:35 |
marun | dougwig: regarding interface stability, we need explicit contracts. | 16:35 |
otherwiseguy | anteaya: ^ (starting with HenryG: weird, in the gate tests) | 16:35 |
marun | dougwig: without explicit contracts, we would need to co-gate to avoid breakage. | 16:35 |
roaet | amotoki: I am all for putting in the effort to fix up OSC/SDK but we will need time to begin that deprecation cycle. | 16:35 |
dougwig | marun: right, totally agree. i even said that in the spec. :) | 16:36 |
amotoki | roaet: understandable. | 16:36 |
marun | dougwig: ok, I need to read it. I've been spending too much time on non-neutron stuff. | 16:36 |
markmcclain | roaet: but we don't support any alternate auth today | 16:36 |
marun | dougwig: how about I go do that now and come back to you to discuss? | 16:36 |
dougwig | ok, great. | 16:36 |
markmcclain | so not seeing how deprecation cycle would apply here | 16:37 |
roaet | markmcclain: that is very true | 16:37 |
amotoki | roaet: i see noauth inconsistency among *client too :-( [just a comment] | 16:37 |
marun | roaet: so does the client support noauth today? | 16:37 |
roaet | marun: yes | 16:37 |
roaet | marun: I added it awhile ago. | 16:37 |
roaet | but we never actually finished the bp | 16:37 |
roaet | Where it needed the pluggable part. | 16:37 |
marun | roaet: ah, ok. | 16:38 |
ihrachyshka | otherwiseguy, I saw some bugs due to Depends-On | 16:38 |
ihrachyshka | otherwiseguy, I suspect it's not really ready for advanced usage | 16:38 |
* ihrachyshka is going to remove the tag from one of his patches due to bugs | 16:38 | |
marun | ihrachyshka: what kind of bug? | 16:38 |
amotoki | roaet: could you send a mail to dev list about how we should support pluggable auth in client (OSC vs *client)? I beleive not a small nubmer of folks are interested in this topic | 16:38 |
roaet | amotoki: I will do that. thank you. | 16:39 |
amotoki | roaet: it is not specific to neutroclient. | 16:39 |
otherwiseguy | anteaya: basically, very confused how https://review.openstack.org/156690 in neutron-vpnaas can fail a test on what looks like a change that should only be made in https://review.openstack.org/#/c/155212/ which it doesn't depend-on and isn't yet in the gate queue. | 16:39 |
*** thedodd has joined #openstack-neutron | 16:39 | |
*** changbl has joined #openstack-neutron | 16:39 | |
ihrachyshka | marun, jenkins claiming merge conflicts and still setting V+1 as in: https://review.openstack.org/155374 | 16:39 |
roaet | amotoki: ok. | 16:39 |
ihrachyshka | marun, I reported it to fungi at #openstack-infra | 16:39 |
marun | ihrachyshka: hmmm... | 16:39 |
*** pal_ has quit IRC | 16:40 | |
ihrachyshka | marun, btw there are no real conflicts, it's just reporting those | 16:40 |
marun | ihrachyshka: I wonder if the merge conflicts are related to that, though. | 16:40 |
marun | ihrachyshka: Maybe | 16:40 |
ihrachyshka | marun, that's what fungi suggested, I leave it to his discretion :) | 16:40 |
marun | ihrachyshka: we started seeing all kinds of spurious merge conflict errors in january, not sure if it has anything to do with the depends-on feature or not. | 16:41 |
*** radez is now known as radez_g0n3 | 16:41 | |
*** gridinv has quit IRC | 16:41 | |
ihrachyshka | marun, right, I saw those too, but I suspect my case is different | 16:41 |
marun | ihrachyshka: but I guess it would make sense if a single depends-on would ripple through to things that don't even use it | 16:41 |
*** a_le_ has joined #openstack-neutron | 16:42 | |
*** dboik_ has quit IRC | 16:42 | |
*** a_le has quit IRC | 16:42 | |
anteaya | otherwiseguy: looking at status.o.o/zuul right now zuul believes the dependency tree is 155014,12 -> 155101,13 -> 155188,11 -> 156690,1 -> 155212,11 | 16:43 |
*** SridharG has left #openstack-neutron | 16:43 | |
*** nlahouti has joined #openstack-neutron | 16:43 | |
anteaya | otherwiseguy: currently 155212,11 is the only one being tested in check, the whole stack relationship is represented in check right now | 16:43 |
anteaya | what is the failure for 156690,1? | 16:44 |
anteaya | let's start there | 16:44 |
*** pradipta has joined #openstack-neutron | 16:44 | |
otherwiseguy | anteaya: which looks right, the 156690,1 seems to be failing because it passes root_helper arg to RouterInfo, which is removed in 155212,11 which depends on 156690, not the other way. | 16:45 |
anteaya | then the dependency chain is not represented in the way that zuul understand | 16:45 |
anteaya | s | 16:45 |
anteaya | so perhaps take a look at that as a first step | 16:46 |
*** rwsu-afk is now known as rwsu | 16:46 | |
* otherwiseguy is confused | 16:46 | |
*** banix_ has joined #openstack-neutron | 16:46 | |
otherwiseguy | The dependency chain *looks* right to me. | 16:46 |
anteaya | okay | 16:46 |
anteaya | then if the failure is caused by something that is removed in the child patch | 16:47 |
*** dboik_ has joined #openstack-neutron | 16:47 | |
anteaya | the failure makes sense, does it not | 16:47 |
anteaya | since the parent patch in that relationship doesn't know about it | 16:47 |
*** ParsectiX has quit IRC | 16:47 | |
anteaya | if the failure in 156690,1 is fixed in 155212,11 | 16:48 |
anteaya | and 155212,11 is a child of 156690,1 | 16:48 |
anteaya | then 156690,1 is failing | 16:48 |
anteaya | is that accurate? | 16:48 |
*** ParsectiX has joined #openstack-neutron | 16:48 | |
otherwiseguy | Wait, no, the dep looks wrong to me. Got my arrows backward. | 16:48 |
anteaya | otherwiseguy: okay then | 16:48 |
anteaya | try again with the dependencies in the intended direction | 16:48 |
*** scheuran has quit IRC | 16:49 | |
*** ParsectiX has quit IRC | 16:50 | |
*** ParsectiX has joined #openstack-neutron | 16:51 | |
*** afazekas has quit IRC | 16:51 | |
otherwiseguy | anteaya: Actually I can't read line numbers. it is another patch that has merged in my tree that causes it to break, a couple lines below what I was looking at. | 16:52 |
*** neeti has quit IRC | 16:52 | |
* otherwiseguy swears off long chains of patches that touch external projects | 16:53 | |
otherwiseguy | anteaya: thanks for looking at it. sorry to be a bit slow today. :) | 16:54 |
anteaya | it happens | 16:54 |
anteaya | so jim found it then | 16:54 |
anteaya | the problem with fixing things that introduce complexity is that they become more complex | 16:55 |
openstackgerrit | Terry Wilson proposed openstack/neutron: Remove root_helper arg from linux interface https://review.openstack.org/155522 | 16:55 |
openstackgerrit | Terry Wilson proposed openstack/neutron: Remove remaining root_helper args from plugins https://review.openstack.org/155523 | 16:55 |
*** hjensas has joined #openstack-neutron | 16:55 | |
*** anshul has quit IRC | 16:55 | |
openstackgerrit | Terry Wilson proposed openstack/neutron: Remove root_helper arg from sanity checks https://review.openstack.org/155905 | 16:56 |
openstackgerrit | Terry Wilson proposed openstack/neutron: Remove remaining uses of passing root_helper https://review.openstack.org/155906 | 16:56 |
*** jlibosva has quit IRC | 16:56 | |
*** irenab has joined #openstack-neutron | 16:56 | |
*** Marga_ has joined #openstack-neutron | 16:58 | |
*** Marga_ has quit IRC | 16:58 | |
*** Marga_ has joined #openstack-neutron | 16:59 | |
*** rushil has quit IRC | 17:00 | |
otherwiseguy | anteaya: Keeping 20 patches spanning 4 projects organized in my brain isn't working as well as I'd hoped. ;) | 17:01 |
*** banix_ is now known as banix | 17:01 | |
anteaya | well we all have our limitations | 17:01 |
openstackgerrit | Derek Higgins proposed openstack/neutron: Revert "Remove RPC dependency to create FIP agent gw port" https://review.openstack.org/157063 | 17:01 |
*** shivharis has quit IRC | 17:01 | |
*** s3wong has joined #openstack-neutron | 17:02 | |
*** coolsvap is now known as coolsvap_ | 17:03 | |
*** leenheer has joined #openstack-neutron | 17:03 | |
*** moshele has quit IRC | 17:03 | |
derekh | Hi All, tripleo-ci has been broken for the last few days, dues to 3 regressions, 2 of them look like they are in neutron | 17:03 |
derekh | https://bugs.launchpad.net/tripleo/+bug/1423228 and | 17:03 |
openstack | Launchpad bug 1423228 in tripleo "L3 agent for nova compute could not be found" [Critical,Triaged] - Assigned to Derek Higgins (derekh) | 17:03 |
derekh | https://bugs.launchpad.net/tripleo/+bug/1421835 | 17:03 |
openstack | Launchpad bug 1421835 in neutron "Timeout reached while waiting for callback for node" [Undecided,In progress] - Assigned to Derek Higgins (derekh) | 17:04 |
derekh | I've submitted reverts for both, could somebody look into them please | 17:04 |
*** seizadi has joined #openstack-neutron | 17:04 | |
openstackgerrit | Terry Wilson proposed openstack/neutron-vpnaas: Stop storing and passing root_helper https://review.openstack.org/156690 | 17:04 |
*** belmoreira has quit IRC | 17:05 | |
*** kfox1111 has joined #openstack-neutron | 17:05 | |
otherwiseguy | HenryG: hopefully that ^ should get the vpnaas patch across the gate. The Iptables patch merging broke that patch. | 17:05 |
kfox1111 | any neutron developers wake? | 17:05 |
derekh | Here are the reverts https://review.openstack.org/#/c/156853/ https://review.openstack.org/#/c/157063/ | 17:05 |
kfox1111 | I've got a fairly serious floating ip schedualing issue thats affecting our production cloud. :/ | 17:06 |
HenryG | otherwiseguy: thanks | 17:06 |
*** annegent_ has quit IRC | 17:06 | |
*** SridharRamaswamy has joined #openstack-neutron | 17:06 | |
otherwiseguy | HenryG: though I probably should have mentioned that *after* it passes checks. | 17:06 |
*** luqas___ has joined #openstack-neutron | 17:06 | |
derekh | kfox1111, is this the problem your hitting by any chance ? | 17:06 |
kfox1111 | floating ip's are getting schedualed to the wrong router. | 17:06 |
derekh | https://bugs.launchpad.net/tripleo/+bug/1423228 | 17:06 |
openstack | Launchpad bug 1423228 in tripleo "L3 agent for nova compute could not be found" [Critical,Triaged] - Assigned to Derek Higgins (derekh) | 17:06 |
derekh | kfox1111, ahh ok, not the same thing | 17:07 |
kfox1111 | no. different bug. | 17:07 |
* otherwiseguy is now scared he has broken something anytime derekh mentions reverts | 17:07 | |
kfox1111 | I have two external networks, two routers in a tenant, attached to a tenant network, | 17:07 |
kfox1111 | and floating ip's on both networks. | 17:07 |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron-vpnaas: Explicitly monkey patch VPN agent https://review.openstack.org/156602 | 17:07 |
kfox1111 | with icehouse, it worked very nicely. | 17:07 |
*** irenab has quit IRC | 17:07 | |
kfox1111 | just upgraded to juno, | 17:08 |
ihrachyshka | salv-orlando, armax: ^^ | 17:08 |
ihrachyshka | the reworked vpnaas patch | 17:08 |
kfox1111 | and all new associations go to one of the two routers | 17:08 |
*** luqas__ has quit IRC | 17:08 | |
marun | dougwig: hi | 17:08 |
dougwig | marun: hiya | 17:08 |
kfox1111 | serious issue. :/ | 17:08 |
derekh | otherwiseguy, not looking in your direction this time ;-) | 17:08 |
*** jlanoux_ has joined #openstack-neutron | 17:08 | |
*** dmellado has quit IRC | 17:08 | |
kfox1111 | odly, the floating ip's that were setup before the upgrade are all still working, and attached to the correct routers. | 17:09 |
kfox1111 | so I think its a schedualing bug. | 17:09 |
kfox1111 | Does anyone know where that code is? | 17:09 |
marun | dougwig: I'm not sure I understand the rationale for creating a library. | 17:09 |
marun | dougwig: I'm hearing rumblings that there are tooling/infra issues that are suggesting this course of action. | 17:09 |
*** amotoki has quit IRC | 17:10 | |
dougwig | marun: makes it easy to put the library in pypi, and from there global-requirements and the requirements files of the folks that depend on it. | 17:10 |
*** a_le_ has quit IRC | 17:10 | |
marun | dougwig: what's stopping neutron from being that thing? | 17:10 |
marun | dougwig: I'm not really clear on why it's easier to publish a library vs neutron itself. | 17:11 |
*** jlanoux has quit IRC | 17:11 | |
*** irenab has joined #openstack-neutron | 17:12 | |
*** dmellado has joined #openstack-neutron | 17:12 | |
dougwig | if you publish neutron, because python has no access controls, there's nothing stopping anyone from reaching in and using one of the non-library modules. i'm also not sure that I want to contemplate the joys of having potentially one version of neutron in a requirements file while the OS installs another. | 17:12 |
marun | OS? | 17:12 |
dougwig | redhat/ubuntu/etc | 17:12 |
marun | I'm not sure what that has to do with anything | 17:12 |
marun | requirements files and distro packaging are always going to conflict | 17:13 |
dougwig | repos are cheap, and tooling expects one python package per repo. what's the argument for not separating? | 17:13 |
marun | dougwig: cost | 17:13 |
marun | dougwig: it might be an eventually desirable goal | 17:13 |
*** SridharRamaswamy has quit IRC | 17:13 | |
*** pask81 has quit IRC | 17:13 | |
marun | dougwig: but to be clear, I see the need for enforceable interface stability | 17:13 |
dougwig | the really hard part (and it is massive), i'm not sure has anything to do with one or two repos. | 17:14 |
marun | dougwig: the immediate need to externalize to a library is a nicety that doesn't preclude interface stability | 17:14 |
dougwig | true, but it does provide an easy structure to communicate to potential contributors/helpers. | 17:14 |
marun | dougwig: I'm a bit surprised that you're not admitting the cost of multiple repos. | 17:14 |
*** jistr has quit IRC | 17:15 | |
marun | dougwig: it's a cost that might be worth it in some cases, but it's a cost nonetheless | 17:15 |
*** irenab has quit IRC | 17:15 | |
*** jkyle1 has quit IRC | 17:15 | |
marun | dougwig: clearly delineated module paths in the neutron repo would accomplish most of what you want, though. | 17:15 |
marun | dougwig: I'm not saying that a library doesn't have advantates. | 17:15 |
dougwig | it's a cost, but after fighting with neutron as both a library and a not-library for a cycle now, it's a cost i'm personally wiling to bear tenfold. the communication of where the lines are drawn has not been simple or successful. | 17:16 |
marun | dougwig: but in your proposed spec I see no mention of the tradeoffs | 17:16 |
*** SridharRamaswamy has joined #openstack-neutron | 17:16 | |
*** devvesa has quit IRC | 17:16 | |
marun | dougwig: it reads as if externalizing is the only path forward with little discussion as to why | 17:16 |
dougwig | i can add an alternative for that, for sure. | 17:16 |
marun | dougwig: not just as an alternative | 17:16 |
marun | I think there needs to be pretty comprehensive documentation as to why a lib is the best way forward | 17:17 |
marun | rather than just treating it as a foregone conclusion | 17:17 |
marun | The fact that we're waiting until vancouver to contemplate a split of the reference control plane suggests that we may need similar oversight around libification. | 17:17 |
openstackgerrit | Swaminathan Vasudevan proposed openstack/neutron: Get rid of rpc to fetch fip agent port on agent. https://review.openstack.org/153735 | 17:18 |
marun | Which suggests that for kilo, stabilizing interfaces in the current repo may be the best you can hope for. | 17:18 |
*** a_le has joined #openstack-neutron | 17:18 | |
*** ihrachyshka has quit IRC | 17:18 | |
*** pcm_ has joined #openstack-neutron | 17:18 | |
*** jobewan has joined #openstack-neutron | 17:18 | |
marun | dougwig: The issues about pypi/requirements aside, I think there is just as much opportunity for stabilization in-tree as out. | 17:19 |
dougwig | there is a matching etherpad, which just lists the paths forward without picking one. i believe a summit session is planned for this. is that more in line with what you're wanting? | 17:19 |
marun | dougwig: I think so, yes. | 17:19 |
dougwig | ok, let me make sure the in-tree option is in there. | 17:19 |
marun | dougwig: Have you considered that it should be possible to demarcate parts of the neutron tree that are safe to consume, and those that are not, and enforce with hacking rules in other projects? | 17:20 |
dougwig | i'm not sure how much real work we can get done in kilo (the real work being the interface stabilization), just based on time. getting the library plumbing setup in the meantime as a jumpstart was simply because most of that is sitting on your thumbs time. the hard part is the work that you're alluding to. | 17:20 |
dougwig | marun: yes, but that seems like more hassle than just using a lib, IMO. | 17:21 |
marun | dougwig: I think that's understating the hassle of a lib, frankly, at least in the short-term. | 17:21 |
marun | dougwig: I get the sense that you've set your mind to wanting a lib as a goal. | 17:21 |
*** Tarun has quit IRC | 17:21 | |
*** aepifanov has quit IRC | 17:21 | |
marun | dougwig: I would encourage you to see libification as an implementation detail. | 17:22 |
marun | dougwig: There's more than one way to skin this cat. | 17:22 |
*** chlong has quit IRC | 17:22 | |
marun | dougwig: not saying that it won't be the way we end up going | 17:22 |
marun | dougwig: just that it's by no means certain in the near term. | 17:22 |
marun | dougwig: and you can still get what you want without it | 17:22 |
dougwig | ok, so let's assume the repo exists, a skeleton, a 0.1 in pypi, and requirements is dealt with in the openstack/ projects. the additional hassle at that point is that you have to move code when you refactor it from repo to repo instead of rename. are there others? the benefits can be: automatic checking for some interface tests, stricter hacking/lint | 17:23 |
dougwig | rules, and a smaller piece for the docs folks to chew on at a time. | 17:23 |
dougwig | as well as i think it'd be easier to apply stricter scrutiny in the new place. | 17:24 |
*** armax has quit IRC | 17:24 | |
openstackgerrit | Merged openstack/neutron: Don't monkey patch netns_cleanup https://review.openstack.org/155373 | 17:25 |
*** jlanoux_ has quit IRC | 17:25 | |
marun | dougwig: that is completely ignoring the cost to neutron | 17:26 |
marun | dougwig: I get that your goal is making things easier/better for out-of-tree. | 17:27 |
marun | dougwig: but it makes neutron itself less understandable and harder to maintain. | 17:27 |
marun | dougwig: it splits reviewer effort | 17:27 |
*** raildo_ is now known as raildo | 17:28 | |
marun | dougwig: again, there is nothing preventing doing the stabilization in the tree itself and ensuring that neutron remains coherent | 17:28 |
dougwig | ahh, interesting. i was viewing it as easier for neutron, and adding greater focus to the servers/agents/ml2/etc. | 17:28 |
otherwiseguy | huh, several root_helper patches in the gate just came up CANCELED. Hadn't seen that before. | 17:28 |
marun | dougwig: to be fair, this is my gut instinct talking | 17:28 |
*** kawa2014 has quit IRC | 17:29 | |
marun | dougwig: I can't pretend that I'm the voice of reason or anything. | 17:29 |
dougwig | i viewed it as more of getting some of the uninteresting guts out of the core SDN controller stuff. | 17:29 |
*** leenheer has quit IRC | 17:29 | |
*** leenheer has joined #openstack-neutron | 17:29 | |
marun | dougwig: the irony being that we're contemplating splitting that stuff out entirely | 17:29 |
marun | dougwig: there's a summit session scheduled for vancouver | 17:30 |
dougwig | the ref impl one, or another? | 17:30 |
marun | dougwig: so it may be premature to move the common stuff out if we haven't decided that we want to separate out the stuff you're trying to save | 17:30 |
marun | save -> benefit | 17:30 |
marun | dougwig: ref | 17:30 |
marun | dougwig: again, I don't want to block any work that stabilizes the parts of neutron that out-of-tree depends on | 17:32 |
*** tiswanso has quit IRC | 17:33 | |
*** dane_leblanc has quit IRC | 17:33 | |
*** tiswanso_ has joined #openstack-neutron | 17:34 | |
*** matrohon has quit IRC | 17:34 | |
openstackgerrit | Carl Baldwin proposed openstack/neutron: Introduce External IPAM Interface https://review.openstack.org/134339 | 17:34 |
*** _cjones_ has joined #openstack-neutron | 17:36 | |
*** anish_ has joined #openstack-neutron | 17:36 | |
*** ivar-lazzaro has joined #openstack-neutron | 17:37 | |
*** manishg has joined #openstack-neutron | 17:37 | |
*** manishg has quit IRC | 17:37 | |
carl_baldwin | miguel: ping | 17:37 |
openstackgerrit | Mohammad Banikazemi proposed openstack/neutron: Combining sec groups member update RPC calls https://review.openstack.org/155145 | 17:37 |
*** seizadi has quit IRC | 17:38 | |
*** seizadi1 has joined #openstack-neutron | 17:38 | |
*** manishg has joined #openstack-neutron | 17:38 | |
*** ronis has joined #openstack-neutron | 17:38 | |
derekh | Ok, I gotta run, we've pull reverts for both of those regressions into tripleo, but it would be great to get a perminant fix https://review.openstack.org/#/c/156853/ https://review.openstack.org/#/c/157063/ | 17:38 |
*** ivar-laz_ has joined #openstack-neutron | 17:39 | |
derekh | The two commits with the regressions are https://review.openstack.org/#/c/153729/ and https://review.openstack.org/#/c/141044/ | 17:39 |
derekh | I don't have irc handles for people involved | 17:39 |
*** EmilienM is now known as EmilienM|afk | 17:40 | |
derekh | And the bugs are here https://bugs.launchpad.net/tripleo/+bug/1423228 https://bugs.launchpad.net/tripleo/+bug/1421835 | 17:40 |
openstack | Launchpad bug 1423228 in tripleo "L3 agent for nova compute could not be found" [Critical,Triaged] - Assigned to Derek Higgins (derekh) | 17:40 |
*** britthou_ has quit IRC | 17:40 | |
openstack | Launchpad bug 1421835 in neutron "Timeout reached while waiting for callback for node" [Undecided,In progress] - Assigned to Derek Higgins (derekh) | 17:40 |
*** dane_leblanc has joined #openstack-neutron | 17:41 | |
*** ivar-lazzaro has quit IRC | 17:42 | |
*** ollivier has joined #openstack-neutron | 17:42 | |
*** harlowja_away is now known as harlowja_ | 17:42 | |
*** rushil has joined #openstack-neutron | 17:43 | |
*** anshul has joined #openstack-neutron | 17:43 | |
*** shivharis has joined #openstack-neutron | 17:43 | |
*** seizadi1 has quit IRC | 17:43 | |
*** seizadi has joined #openstack-neutron | 17:44 | |
*** shaohe_feng has quit IRC | 17:44 | |
kfox1111 | ok, so its definately the server that's schedualing the floating ip to the wrong router. the client never passes that information. | 17:44 |
kfox1111 | having a real hard time figuring out where it actually gets schedualed though. :/ | 17:44 |
*** ygbo has quit IRC | 17:44 | |
*** manishg has quit IRC | 17:44 | |
*** shivharis has quit IRC | 17:45 | |
*** manishg has joined #openstack-neutron | 17:45 | |
openstackgerrit | Carl Baldwin proposed openstack/neutron: WIP Move port processing to router classes https://review.openstack.org/154513 | 17:46 |
*** s3wong has quit IRC | 17:47 | |
*** _cjones_ has quit IRC | 17:48 | |
*** _cjones_ has joined #openstack-neutron | 17:48 | |
*** dasm has joined #openstack-neutron | 17:49 | |
*** derekh has quit IRC | 17:49 | |
*** hjensas has quit IRC | 17:49 | |
*** pcm_ has quit IRC | 17:50 | |
*** Sukhdev has quit IRC | 17:50 | |
*** aepifanov has joined #openstack-neutron | 17:51 | |
*** suresh12 has joined #openstack-neutron | 17:52 | |
*** thedodd has quit IRC | 17:54 | |
*** garyk has quit IRC | 17:54 | |
openstackgerrit | Kobi Samoray proposed openstack/neutron: VMWare NSXv: id fields should be nullable https://review.openstack.org/157084 | 17:55 |
*** annegentle has joined #openstack-neutron | 17:55 | |
*** annegentle has quit IRC | 17:56 | |
*** annegentle has joined #openstack-neutron | 17:56 | |
openstackgerrit | Carl Baldwin proposed openstack/neutron: Get rid of rpc to fetch fip agent port on agent. https://review.openstack.org/153735 | 17:59 |
*** SumitNaiksatam has joined #openstack-neutron | 18:00 | |
*** jorgem has joined #openstack-neutron | 18:01 | |
*** morgabra has quit IRC | 18:02 | |
*** morgabra has joined #openstack-neutron | 18:02 | |
openstackgerrit | Brian Haley proposed openstack/neutron: Add support for a public endpoint url https://review.openstack.org/157087 | 18:02 |
*** aranjan has joined #openstack-neutron | 18:02 | |
*** flaviof has joined #openstack-neutron | 18:04 | |
*** absubram has joined #openstack-neutron | 18:06 | |
*** dsneddon has joined #openstack-neutron | 18:08 | |
*** bobmel has quit IRC | 18:10 | |
*** ivar-laz_ has quit IRC | 18:10 | |
*** bobmel has joined #openstack-neutron | 18:10 | |
*** ivar-lazzaro has joined #openstack-neutron | 18:10 | |
*** yamahata has quit IRC | 18:12 | |
*** stefanb has quit IRC | 18:14 | |
*** pradipta has quit IRC | 18:14 | |
*** vishwanathj has joined #openstack-neutron | 18:15 | |
*** jkyle1 has joined #openstack-neutron | 18:16 | |
*** krtaylor has quit IRC | 18:16 | |
*** ParsectiX has quit IRC | 18:16 | |
*** lazy_prince is now known as killer_prince | 18:17 | |
kfox1111 | hmm... so the table that stores the info is floatingips.router_id | 18:17 |
kfox1111 | its set wrong there too. | 18:17 |
*** ParsectiX has joined #openstack-neutron | 18:17 | |
kfox1111 | but that would explain why older entries still work, since they were schedualed to the right routers already. | 18:17 |
openstackgerrit | Juergen Brendel proposed openstack/neutron: ARP spoofing patch: Low level ebtables integration https://review.openstack.org/141130 | 18:18 |
openstackgerrit | Juergen Brendel proposed openstack/neutron: ARP spoofing patch: Data structures for rules. https://review.openstack.org/157097 | 18:18 |
*** ParsectiX has quit IRC | 18:19 | |
*** ParsectiX has joined #openstack-neutron | 18:19 | |
*** haleyb has quit IRC | 18:19 | |
otherwiseguy | HenryG: mestery: Ok, https://review.openstack.org/#/c/156690/ take 2 has passed checks. | 18:19 |
HenryG | otherwiseguy: great! | 18:20 |
*** zz_avozza is now known as avozza | 18:21 | |
*** leenheer has quit IRC | 18:21 | |
kfox1111 | ok, is this the schedualing code here? /usr/lib/python2.7/site-packages/neutron/db/l3_db.py:def _get_router_for_floatingip | 18:22 |
*** jamespd has quit IRC | 18:23 | |
*** johnbelamaric has joined #openstack-neutron | 18:23 | |
mestery | otherwiseguy: Looks good! dougwig: See ^^^ from otherwiseguy. | 18:24 |
*** seizadi1 has joined #openstack-neutron | 18:24 | |
otherwiseguy | HenryG: it's especially good because neutron-vpnaas is currently broken without it. (oops) | 18:24 |
*** seizadi has quit IRC | 18:24 | |
otherwiseguy | As evidenced by ihar's 156602,4 patch failing because of the root_helper change in the iptables stuff. | 18:25 |
HenryG | otherwiseguy: dougwig's neutron-lib can't get here fast enough | 18:25 |
mestery | lol | 18:25 |
* otherwiseguy is not sure he would have started the root_helper removal stuff it he had known exactly how much of a pita it was | 18:26 | |
otherwiseguy | :p | 18:26 |
dougwig | HenryG: why are you only +1 on that patch? | 18:27 |
HenryG | dougwig: I am not *aas core | 18:27 |
dougwig | ah, missed that. | 18:27 |
* otherwiseguy disappears for a quick lunch | 18:28 | |
*** maishsk has quit IRC | 18:28 | |
pc_m | otherwiseguy: HenryG Just seeing all this... is this the sequencing of commits for root_helper removal? VPN change is needed before Neutron. | 18:28 |
*** maishsk has joined #openstack-neutron | 18:28 | |
*** ParsectiX has quit IRC | 18:28 | |
otherwiseguy | pc_m: some changes before, some after. | 18:29 |
*** maishsk has quit IRC | 18:29 | |
*** vivek-ebay has joined #openstack-neutron | 18:29 | |
pc_m | I can review vpn, which commit? | 18:29 |
*** amuller has joined #openstack-neutron | 18:29 | |
*** ParsectiX has joined #openstack-neutron | 18:29 | |
kfox1111 | ok. I have a diff of the icehouse/juno snippet of the schedualer in https://bugs.launchpad.net/neutron/+bug/1422476. Can someone take a look and see if that may be the bug? | 18:29 |
openstack | Launchpad bug 1422476 in neutron "floating ip scheduled to wrong router" [Undecided,New] | 18:29 |
otherwiseguy | I missed the Iptables dependency mattering, so should have done a little better on the order. pc_m 156609, but it is now in gate. | 18:29 |
HenryG | pc_m: there was a minor mishap, but it's got +A now | 18:29 |
*** maishsk has joined #openstack-neutron | 18:30 | |
pc_m | HenryG: Yeah. I noticed problems yesterday with Jenkins failing in VPN repo. | 18:30 |
* otherwiseguy really disappears for lunch before he gets in trouble with Sarah | 18:30 | |
mestery | pc_m: I just merged the Vyatta VPN driver, FYI. Looked good to me, they even had (minimal) CI running VPN API tests which passed ;) | 18:30 |
pc_m | mestery: Great, it looked good to me. | 18:30 |
mestery | pc_m: Cool | 18:30 |
pc_m | mestery: HenryG I've been seeing other oddities with VPN testing lately. Mentioned to Dooug, but I don't think we every isolated the problem | 18:31 |
mestery | pc_m: Yikes! | 18:31 |
pc_m | Short version... commit to Neutron that broke VPN, fix committed to VPN on 2/12. Another VPN patch didn't rebased, but pushed up a change. It PASSED Jenkins! | 18:32 |
pc_m | I pulled the patch down and ran it, and it failed. It didn't have the 2/12 fix. I rebased, and it passed tests. | 18:32 |
pc_m | I have no idea why Jenkins passed on that code. | 18:33 |
HenryG | pc_m: I think the gate sometimes inserts dependencies to sequence jobs | 18:34 |
HenryG | pc_m: You can see it in zuul, the dots linked with lines | 18:34 |
pc_m | HenryG: So it applied the 2/12 fix to the commit that was upstreamed? | 18:34 |
amuller | carl_baldwin: Hey Carl, could you ping Rajeev please? | 18:34 |
*** britthouser has joined #openstack-neutron | 18:34 | |
amuller | carl_baldwin: about https://bugs.launchpad.net/neutron/+bug/1421497 | 18:35 |
openstack | Launchpad bug 1421497 in neutron "Gateway clear generates a TRACE - AttributeError in get_int_device_name in DVR routers" [Undecided,In progress] - Assigned to Rajeev Grover (rajeev-grover) | 18:35 |
carl_baldwin | amuller: Let me see if I can locate him. Gotta fire up Lync. | 18:35 |
HenryG | pc_m: depends on what was in the gate at the time. Hard to tell afterwards. | 18:36 |
pc_m | The patch was pushed on 2/15 and did not have the 2/12 fix. | 18:36 |
pc_m | HenryG: https://review.openstack.org/#/c/144391/ patch 3 | 18:37 |
pc_m | HenryG: It passed gate-neutron-vpnaas-python27, but if you try that code in a local repo, it fails | 18:37 |
* pc_m a scary false negative | 18:38 | |
*** haleyb has joined #openstack-neutron | 18:38 | |
*** maishsk has quit IRC | 18:38 | |
carl_baldwin | amuller: I’ve sent a ping. | 18:39 |
pc_m | HenryG: BTW, do you know, if I change a file in local neutron repo, and then run UT in vpn repo, will it "see" those changes? Do I have to do a setup.py install to see them? Change requirements.txt to point to local repo? | 18:39 |
amuller | carl_baldwin: Thank you | 18:39 |
amuller | carl_baldwin: If I understand correctly my fix introduced another regression | 18:40 |
*** dane_leblanc has quit IRC | 18:40 | |
pc_m | HenryG: VPN uses an egg for Neutron. Wondering how that all works together. | 18:40 |
amuller | with that DVR gateway removal business | 18:40 |
HenryG | pc_m: I think dougwig is the person to ask that | 18:41 |
pc_m | HenryG: OK. | 18:42 |
*** SridharRamaswamy has quit IRC | 18:43 | |
*** s3wong has joined #openstack-neutron | 18:43 | |
pc_m | mestery: Can you look at https://review.openstack.org/#/c/155889/? | 18:43 |
amuller | carl_baldwin: The chain goes: 1) https://review.openstack.org/#/c/151882/1/neutron/agent/l3/agent.py, 2) https://review.openstack.org/#/c/155813/6/neutron/agent/l3/agent.py, and now 3) https://review.openstack.org/#/c/156357/5/neutron/agent/l3/agent.py | 18:43 |
*** dane_leblanc has joined #openstack-neutron | 18:43 | |
mestery | pc_m: Looking | 18:43 |
pc_m | mestery: Thank you | 18:43 |
*** jkyle1 has quit IRC | 18:44 | |
mestery | pc_m: +2/+A | 18:44 |
*** Rajeev_ has joined #openstack-neutron | 18:45 | |
pc_m | mestery: Thanks! | 18:45 |
openstackgerrit | Merged openstack/neutron: tests: monkey patch stdlib before importing other modules https://review.openstack.org/153225 | 18:48 |
*** seizadi1 has quit IRC | 18:50 | |
*** seizadi has joined #openstack-neutron | 18:50 | |
*** tomoe_ has quit IRC | 18:51 | |
jckasper | marun: ping | 18:51 |
marun | jckasper: hi | 18:51 |
jckasper | marun: running into tox issues with a recent patch of yours | 18:52 |
marun | jckasper: I'm guessing it's giving you an error about dsvm-functional? | 18:52 |
openstackgerrit | Merged openstack/neutron: Monkey patch all the code inside neutron/cmd/eventlet/... https://review.openstack.org/156942 | 18:52 |
jckasper | marun: yep. | 18:52 |
marun | jckasper: if you rebase, you should get an error that tells you that a newer version of tox is required | 18:52 |
marun | jckasper: the fix for setting tox minversion merged yesterday | 18:53 |
*** saju_m has joined #openstack-neutron | 18:53 | |
jckasper | marun: breaking the auto-rebase logic. ok. thanks | 18:53 |
*** krtaylor has joined #openstack-neutron | 18:53 | |
marun | jckasper: breaking the auto-rebase logic? | 18:53 |
jckasper | marun: internal rebuild of kilo | 18:53 |
marun | jckasper: ah, ok | 18:53 |
jckasper | marun: do you have patch # for yesterday's fix ? | 18:54 |
marun | jckasper: just a second | 18:54 |
marun | jckasper: 71ea690727e0006b02e86c901e7efc2d2c1fff70 | 18:54 |
jckasper | marun: Thanks | 18:55 |
marun | jckasper: oh, did you mean gerrit or git id? | 18:55 |
marun | that's the git id | 18:55 |
jckasper | marun: gerrit, preferably | 18:55 |
marun | jckasper: I56313d0a22dbc4007142b8bb4890d1ac8bebff94 | 18:55 |
*** achanda has joined #openstack-neutron | 18:56 | |
*** anish_ has quit IRC | 18:56 | |
*** seizadi has quit IRC | 18:57 | |
*** seizadi1 has joined #openstack-neutron | 18:57 | |
openstackgerrit | Swaminathan Vasudevan proposed openstack/neutron: Fix static strings with labels for DVR https://review.openstack.org/143568 | 18:57 |
*** avozza is now known as zz_avozza | 18:58 | |
*** armax has joined #openstack-neutron | 18:58 | |
*** nlahouti has quit IRC | 19:00 | |
*** a_le has quit IRC | 19:02 | |
*** EmilienM|afk is now known as EmilienM | 19:02 | |
*** zhhuabj has quit IRC | 19:02 | |
*** beagles is now known as beagles_brb | 19:02 | |
*** rushil has quit IRC | 19:03 | |
*** nlahouti has joined #openstack-neutron | 19:04 | |
*** a_le has joined #openstack-neutron | 19:05 | |
*** rms_13 has joined #openstack-neutron | 19:06 | |
*** stanzgy has joined #openstack-neutron | 19:06 | |
*** trad511 has quit IRC | 19:06 | |
*** pradk has quit IRC | 19:07 | |
*** annegentle has quit IRC | 19:08 | |
*** tiswanso_ has quit IRC | 19:09 | |
*** SridharRamaswamy has joined #openstack-neutron | 19:09 | |
*** tiswanso_ has joined #openstack-neutron | 19:10 | |
*** stanzgy has quit IRC | 19:10 | |
openstackgerrit | Carl Baldwin proposed openstack/neutron: WIP Move port processing to router classes https://review.openstack.org/154513 | 19:11 |
*** carl_baldwin has quit IRC | 19:11 | |
*** suresh12 has quit IRC | 19:13 | |
*** achanda has quit IRC | 19:14 | |
*** zhhuabj has joined #openstack-neutron | 19:14 | |
*** nyechiel has quit IRC | 19:16 | |
*** spandhe has joined #openstack-neutron | 19:17 | |
*** beagles_brb is now known as beagles | 19:17 | |
*** jp_at_hp has quit IRC | 19:17 | |
dougwig | pc_m: no, it will not see those changes. you can modify tox.ini to pull a gerrit branch/review instead of master if you want to test together. | 19:17 |
*** anshul has quit IRC | 19:18 | |
*** trad511 has joined #openstack-neutron | 19:20 | |
*** nlahouti has quit IRC | 19:20 | |
*** achanda has joined #openstack-neutron | 19:21 | |
*** leenheer has joined #openstack-neutron | 19:21 | |
*** leenheer has quit IRC | 19:22 | |
*** moha_hunt has joined #openstack-neutron | 19:22 | |
*** suresh12 has joined #openstack-neutron | 19:24 | |
pc_m | dougwig: So if I'm, say testing code from a review for VPN repo, and I want to make some changes in the neutron repo, how do I make sure vpn code sees the change? | 19:24 |
openstackgerrit | Merged openstack/neutron-vpnaas: Stop storing and passing root_helper https://review.openstack.org/156690 | 19:24 |
*** pradk has joined #openstack-neutron | 19:25 | |
*** moshele has joined #openstack-neutron | 19:26 | |
*** marun has quit IRC | 19:28 | |
*** annegentle has joined #openstack-neutron | 19:29 | |
*** Marga_ has quit IRC | 19:29 | |
*** tiswanso_ has quit IRC | 19:29 | |
*** Marga_ has joined #openstack-neutron | 19:30 | |
openstackgerrit | Sridhar Ramaswamy proposed openstack/neutron-vpnaas: Implementation of Brocade Vyatta VPNaaS Plugin https://review.openstack.org/154720 | 19:30 |
*** inara` has joined #openstack-neutron | 19:30 | |
*** raginbaj- has joined #openstack-neutron | 19:30 | |
*** trad511 has quit IRC | 19:30 | |
*** leenheer has joined #openstack-neutron | 19:31 | |
*** annegentle has quit IRC | 19:31 | |
*** inara has quit IRC | 19:31 | |
*** raginbajin has quit IRC | 19:31 | |
*** SridharRamaswam1 has joined #openstack-neutron | 19:31 | |
*** yarker has quit IRC | 19:31 | |
*** raginbaj- is now known as raginbajin | 19:31 | |
*** ivar-lazzaro has quit IRC | 19:32 | |
*** SridharRamaswamy has quit IRC | 19:32 | |
*** ivar-lazzaro has joined #openstack-neutron | 19:33 | |
*** tflynn has joined #openstack-neutron | 19:33 | |
*** dane_leblanc has quit IRC | 19:34 | |
*** yarker has joined #openstack-neutron | 19:34 | |
HenryG | pc_m: 1. post a gerrit review for the neutron change | 19:44 |
*** tiswanso has joined #openstack-neutron | 19:45 | |
HenryG | pc_m: 2. Change the requirements.txt in vpnaas to point to the gerrit ref | 19:45 |
otherwiseguy | HenryG: Looks like the linuxbridge patch after passing functional in check is failing for some reason in gate. Does this look familiar to you at all? https://jenkins07.openstack.org/job/gate-neutron-dsvm-functional/1554/console | 19:46 |
pc_m | HenryG: Was hoping there wasn't such a heavy handed way to do that. | 19:46 |
otherwiseguy | Just a random eventlet timeout. | 19:47 |
HenryG | otherwiseguy: I hope it's not because of the eventlet patches that just got merged? | 19:48 |
openstackgerrit | Manish Godara proposed openstack/neutron: ML2: remove underscore from public method https://review.openstack.org/157120 | 19:48 |
*** pc_m has quit IRC | 19:48 | |
*** crc32 has joined #openstack-neutron | 19:48 | |
*** nlahouti has joined #openstack-neutron | 19:49 | |
otherwiseguy | HenryG: passes locally when checked out with git-review. I'll rebase locally off of master and see what happens. | 19:50 |
HenryG | otherwiseguy: I just tried it (rebased on master) and it fails same as gate :( | 19:52 |
*** pc_m has joined #openstack-neutron | 19:52 | |
otherwiseguy | HenryG: ugh. I got rid of the processutils.execute stuff to specifically avoid having to worry about eventlet changes. : | 19:52 |
otherwiseguy | :-p | 19:52 |
* pc_m losst power for a sec | 19:52 | |
*** Marga_ has quit IRC | 19:53 | |
HenryG | pc_m: I noticed a flicker | 19:53 |
*** Aish has joined #openstack-neutron | 19:53 | |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron-vpnaas: Remove remaining root_helper references https://review.openstack.org/156691 | 19:53 |
openstackgerrit | Merged openstack/neutron-vpnaas: VPNaaS Enable coverage testing for functional tests https://review.openstack.org/155889 | 19:54 |
pc_m | HenryG: Was hoping it wasn't so heavy handed. I'm trying to work on VPN, and just want to say, do some debug logging or slight change in neutron. Would rather not have to push a change to do that. | 19:54 |
*** dane_leblanc has joined #openstack-neutron | 19:55 | |
*** ivar-laz_ has joined #openstack-neutron | 19:55 | |
HenryG | pc_m: Maybe dougwig has some tricks up his sleave | 19:55 |
*** ZZelle_ has joined #openstack-neutron | 19:57 | |
HenryG | otherwiseguy: shouldn't other patches be failing the functional job too? | 19:57 |
*** jorgem has quit IRC | 19:58 | |
otherwiseguy | HenryG: I just ran it locally rebased off master and it passed. Maybe it is sporadic? Maybe I'm just special? :) | 19:58 |
*** ivar-lazzaro has quit IRC | 19:58 | |
HenryG | otherwiseguy: recheck recheck recheck | 19:59 |
*** moshele has quit IRC | 20:01 | |
*** ivar-laz_ has quit IRC | 20:04 | |
*** ivar-lazzaro has joined #openstack-neutron | 20:05 | |
*** cipcosma has quit IRC | 20:05 | |
*** saju_m has quit IRC | 20:05 | |
*** vishwanathj has quit IRC | 20:06 | |
*** aix has quit IRC | 20:08 | |
*** jprovazn has quit IRC | 20:08 | |
*** achanda has quit IRC | 20:09 | |
openstackgerrit | Zengfa Gao proposed openstack/neutron: Use common agent.linux.utils.ensure_dir method https://review.openstack.org/154103 | 20:10 |
*** achanda has joined #openstack-neutron | 20:17 | |
*** fandi has joined #openstack-neutron | 20:17 | |
*** cipcosma has joined #openstack-neutron | 20:17 | |
*** fandi has quit IRC | 20:18 | |
*** maishsk has joined #openstack-neutron | 20:18 | |
*** fandi has joined #openstack-neutron | 20:20 | |
openstackgerrit | Justin Hammond proposed openstack/python-neutronclient: Client command extension support https://review.openstack.org/148318 | 20:22 |
openstackgerrit | Merged openstack/neutron: Get rid of rpc to fetch fip agent port on agent. https://review.openstack.org/153735 | 20:24 |
*** devlaps has quit IRC | 20:27 | |
*** Sukhdev has joined #openstack-neutron | 20:27 | |
*** manishg_ has joined #openstack-neutron | 20:28 | |
openstackgerrit | Brian Haley proposed openstack/neutron: Add support for a public endpoint url https://review.openstack.org/157087 | 20:28 |
*** vivek-ebay has quit IRC | 20:29 | |
*** manishg has quit IRC | 20:31 | |
*** marun has joined #openstack-neutron | 20:33 | |
openstackgerrit | Justin Hammond proposed openstack/python-neutronclient: Client command extension support https://review.openstack.org/148318 | 20:35 |
*** yfried_ has joined #openstack-neutron | 20:36 | |
*** marun has quit IRC | 20:39 | |
*** fandi has quit IRC | 20:39 | |
*** yamahata has joined #openstack-neutron | 20:40 | |
*** maishsk has quit IRC | 20:40 | |
*** devlaps has joined #openstack-neutron | 20:44 | |
*** moshele has joined #openstack-neutron | 20:45 | |
*** shwetaap has joined #openstack-neutron | 20:47 | |
*** jamespd has joined #openstack-neutron | 20:48 | |
*** _cjones_ has quit IRC | 20:48 | |
*** trad511 has joined #openstack-neutron | 20:48 | |
*** shwetaap1 has quit IRC | 20:49 | |
*** rotbeard has quit IRC | 20:52 | |
*** vivek-ebay has joined #openstack-neutron | 20:53 | |
dougwig | pc_m: are you having to do double-repo changes that often? if i may, what modules are affected? might need some immediate refactoring. | 20:54 |
openstackgerrit | Yanping Qu proposed openstack/neutron-vpnaas: Add IPSec encap mode validation to Cisco VPNaas https://review.openstack.org/157145 | 21:02 |
*** banix has quit IRC | 21:03 | |
*** ParsectiX has quit IRC | 21:03 | |
*** ParsectiX has joined #openstack-neutron | 21:04 | |
pc_m | dougwig: I'm trying to debug the issue with neutron_vpnaas.conf and 2x loading service driver. To do that, I'm running VPN UTs in a debugger. | 21:04 |
*** aix has joined #openstack-neutron | 21:04 | |
pc_m | dougwig: What I'd like to do, is add a LOG.debug and other things, in the neutron code that is called, but I can't (normally), as it is not picking up the change. | 21:05 |
pc_m | dougwig: Looks like the UT uses TOX.INI that gets neutron egg from github. | 21:05 |
pc_m | dougwig: What I have been able to do... is go to .tox/py27/... and tweak the neutron files there. | 21:06 |
pc_m | dougwig: Was hoping there was some way to, when running UTs for VPN, be able to use neutron files from my local repo. | 21:06 |
*** jorgem has joined #openstack-neutron | 21:06 | |
dougwig | hmm, you'd have to run them outside tox (the venv.) | 21:07 |
pc_m | dougwig: Is there a way to tell tox to use a local repo vs repo (egg) from github? | 21:07 |
pc_m | dougwig: Thinking out loud, like create an egg from local repo and use that somehow? | 21:08 |
*** matrohon has joined #openstack-neutron | 21:08 | |
dougwig | i think that's what runtests.sh without the venv is still used for in neutron. in the service repos, not as they stand today. | 21:08 |
dougwig | well, if you cd into your neutron and do "pip install -e .", then it looks like an installed egg to anything else. | 21:08 |
dougwig | but you'll need to run the tests outside the venv. | 21:09 |
*** cipcosma has quit IRC | 21:10 | |
pc_m | don't think I've every used runtests.sh | 21:10 |
pc_m | dougwig: Does runtests.sh run w/o venv? | 21:11 |
openstackgerrit | Rajeev Grover proposed openstack/neutron: fix for _get_external_device_interface_name trace https://review.openstack.org/156357 | 21:11 |
dougwig | pc_m: there is a flag for it to do so, yes. | 21:11 |
*** moshele has quit IRC | 21:12 | |
*** _cjones_ has joined #openstack-neutron | 21:14 | |
pc_m | dougwig: Will have to peek into that. | 21:14 |
*** johnbelamaric has quit IRC | 21:14 | |
*** johnbelamaric has joined #openstack-neutron | 21:14 | |
*** vivek-ebay has quit IRC | 21:14 | |
pc_m | dougwig: I wonder if in tox.ini I can specify deps =local-repo somehow (says it can be URL or FILE) | 21:15 |
dougwig | yep, you could even have it pull from an env var if it's set. | 21:15 |
*** rotbeard has joined #openstack-neutron | 21:16 | |
pc_m | dougwig: Know the syntax? I can't seem to find it. Was wondering if I could create an egg and then point to that? | 21:17 |
dougwig | more runtests.sh | 21:18 |
dougwig | -N | 21:18 |
dougwig | oh, for the tox thing? i'd have to google it. | 21:18 |
*** aranjan has quit IRC | 21:19 | |
clarkb | deps= is anything you can feed to pip | 21:19 |
pc_m | yeah, googling, but not finding. | 21:19 |
clarkb | local repo is alawys installed | 21:19 |
clarkb | but you can say deps=. too | 21:19 |
pc_m | clarkb: thanks. Will look at what pip takes :) | 21:19 |
clarkb | we did that somewhere for some reason | 21:19 |
clarkb | I think pbr if you want an example | 21:19 |
pc_m | clarkb: I'm in neutron_vpnaas repo, and want to use local neutron repo in dependencies (instead of github) | 21:20 |
*** aranjan has joined #openstack-neutron | 21:20 | |
openstackgerrit | Ihar Hrachyshka proposed openstack/neutron-vpnaas: Explicitly monkey patch VPN agent https://review.openstack.org/156602 | 21:21 |
*** zhenq has quit IRC | 21:21 | |
*** SumitNaiksatam has quit IRC | 21:21 | |
*** SumitNaiksatam has joined #openstack-neutron | 21:22 | |
pc_m | clarkb: Looking for a way to tweak files in neutron repo, and be able to access those (local) changes, from neutron_vpnaas repo | 21:22 |
clarkb | just have something else install neutron with your changes? | 21:23 |
pc_m | clarkb: Thinking maybe I could do that with deps= in tox.ini somehow. | 21:23 |
pc_m | clarkb: Sorry, didn't follow that. | 21:24 |
clarkb | whenever you make neutron changes just install them to whatever env you need them | 21:24 |
clarkb | keep in mind that tox won't update things so isn't a great solution unless you don't change much | 21:24 |
*** jorgem has quit IRC | 21:25 | |
pc_m | clarkb: Ah. so, make the change and install into my .tox/py27/src/ area? | 21:25 |
pc_m | clarkb: How do I do the install? | 21:25 |
clarkb | pc_m: yup .tox/py27/bin/pip install -U $pathtoneutron | 21:26 |
*** seizadi has joined #openstack-neutron | 21:26 | |
pc_m | clarkb: Awesome! | 21:26 |
*** seizadi1 has quit IRC | 21:26 | |
*** jordandh has quit IRC | 21:27 | |
pc_m | clarkb: That is perfect! Exactly what I wanted to do. Thanks! | 21:30 |
*** carl_baldwin has joined #openstack-neutron | 21:31 | |
*** banix has joined #openstack-neutron | 21:32 | |
*** jordandh has joined #openstack-neutron | 21:32 | |
*** vivek-ebay has joined #openstack-neutron | 21:32 | |
*** nmagnezi has joined #openstack-neutron | 21:33 | |
pc_m | dougwig: On this conf file loading issue... Where is cfg.CONF.config_dir set? | 21:35 |
*** jpena has quit IRC | 21:38 | |
*** baoli has quit IRC | 21:38 | |
*** nmagnezi has quit IRC | 21:38 | |
*** manishg_ has quit IRC | 21:39 | |
*** dasm has quit IRC | 21:39 | |
openstackgerrit | Matthew Thode proposed openstack/neutron: replaces enumeration method used to get a list of interfaces https://review.openstack.org/154128 | 21:40 |
*** tiswanso has quit IRC | 21:41 | |
*** seizadi has quit IRC | 21:41 | |
*** seizadi has joined #openstack-neutron | 21:41 | |
amuller | otherwiseguy: Do you remember (Or anyone else) the tag I put in a commit message if I want my patch to depend on a patch from another repo? | 21:42 |
openstackgerrit | Carl Baldwin proposed openstack/neutron: Move Floating IP processing to Router classes https://review.openstack.org/142863 | 21:42 |
amuller | Or a link for more information about that new feature? | 21:42 |
openstackgerrit | Merged openstack/neutron: Update midonet plugin requirements https://review.openstack.org/156912 | 21:42 |
otherwiseguy | amuller: Depends-On: | 21:42 |
otherwiseguy | ${change_id} | 21:43 |
amuller | otherwiseguy: Would this allow me to make changes in oslo rootwrap, and have a patch in neutron use those changes, without the oslo patch being merged? | 21:43 |
amuller | (I want to debug some rootwrap filtering crap) | 21:43 |
otherwiseguy | amuller: yes. | 21:43 |
* amuller does a little dance | 21:43 | |
amuller | otherwiseguy: Thanks, I'll try that | 21:44 |
otherwiseguy | amuller: I have noticed on the VPNaaS repo, the py27 test seems to check out from neutron master and use that so even though Depends-On: pulls in the neutron patch, it doesn't actually use it during the test. (I *think*) | 21:44 |
otherwiseguy | But the neutron tests I've seen seem to look like Depends-On is "doing the right thing". | 21:45 |
amuller | OK we'll see | 21:45 |
*** Rajeev_ has quit IRC | 21:45 | |
*** suresh12 has quit IRC | 21:46 | |
carl_baldwin | mlavalle: ping | 21:46 |
mlavalle | carl_baldwin: pong | 21:47 |
carl_baldwin | mlavalle: I was just resolving merge conflicts and wondered if you were actively working on https://review.openstack.org/#/c/147744/20 | 21:47 |
carl_baldwin | mlavalle: If not, I could take a crack at the conflicts. | 21:47 |
mlavalle | carl_baldwin: I am not at this instant but I will over the next hour or so. I am aware it is outdated | 21:48 |
carl_baldwin | mlavalle: I’ve also notice you’ve uploaded a few new patch sets for the patch before it. I wondered if that was on purpose or if that was due to “git review” rebasing them together. | 21:49 |
*** claudiub has joined #openstack-neutron | 21:49 | |
mlavalle | carl_baldwin: sorry.... ;-( I now realize I forgot your advice as far as not rebasing. I won't forget this time around | 21:50 |
mlavalle | carl_baldwin: it was git review rebasing | 21:50 |
carl_baldwin | mlavalle: No worries, it happens. I know what to do if things go badly. Fortunately, I don’t think anything went badly this time around because I was through addressing feedback on the patch. | 21:51 |
*** trad511 has quit IRC | 21:51 | |
*** jamielennox|away is now known as jamielennox | 21:51 | |
carl_baldwin | mlavalle: the conflict on your patch was trivial. I’m uploading now... | 21:51 |
openstackgerrit | Carl Baldwin proposed openstack/neutron: Refactor management of namespaces in the L3 Agent https://review.openstack.org/147744 | 21:51 |
carl_baldwin | mlavalle: ^ | 21:51 |
*** tomoe_ has joined #openstack-neutron | 21:52 | |
mlavalle | carl_baldwin: I expected so. it ws the same last night. That is why I wasn't so worried about it | 21:52 |
*** tomoe__ has joined #openstack-neutron | 21:53 | |
*** tomoe_ has quit IRC | 21:53 | |
mlavalle | carl_baldwin: now that we are talking, I made a comment in PS 18 in dvr_snat_ns.py. Have you had a chance to look at it? Any advice? | 21:55 |
*** trad511 has joined #openstack-neutron | 21:55 | |
carl_baldwin | mlavalle: looking... | 21:56 |
carl_baldwin | mlavalle: Let’s just leave it for another patch. I’m happy with the progress this patch has made. | 21:57 |
*** tomoe__ has quit IRC | 21:58 | |
mlavalle | carl_baldwin: the other question is amuller suggested to add some functional testing for the namespace manager (the conext manager that handles the namespaces clean up). I think it is a good idea. Should it be part of this patchset or should I create a follow up patchset? | 21:59 |
amuller | mlavalle: Patches should contain the tests in the patch itself | 22:00 |
amuller | I *highly* dislike testing after the fact | 22:00 |
mlavalle | amuller: thanks for the guidance :-) | 22:01 |
amuller | mlavalle: To explain my position a bit - People often forget, often innocently, to add the tests via a follow up patch, or as a task it just takes a much lower priority since you have a million fires to put out at any given moment | 22:02 |
amuller | mlavalle: We could also slip in regressions by the time your tests merge | 22:02 |
amuller | And since this area is changing so fast these days... | 22:02 |
mlavalle | amuller: I totally agree..... thanks for taking the time to comment (and the reviews) | 22:03 |
amuller | we're introduced multiple regressions in the DVR / FIP / namespaces area in the last couple of weeks | 22:03 |
amuller | we've* | 22:03 |
*** aranjan_ has joined #openstack-neutron | 22:03 | |
openstackgerrit | Kevin Fox proposed openstack/neutron: Fixes regression with multiple external routers and floating ips. https://review.openstack.org/157167 | 22:05 |
*** aranjan has quit IRC | 22:05 | |
amuller | mlavalle: ^ There ya go :) | 22:05 |
*** aranjan has joined #openstack-neutron | 22:06 | |
*** aranjan_ has quit IRC | 22:06 | |
*** karimb has joined #openstack-neutron | 22:08 | |
mlavalle | amuller: now that we are talking, in https://review.openstack.org/#/c/147744/18/neutron/agent/l3/namespaces.py you suggested removing method _get_ns_name. I left that method only to be able to patch it in the functional test. It is not used anywhere else. But I don't find a way to handle namespaces names in test_ha_router_failover in the functional test | 22:08 |
*** kfox1111 has quit IRC | 22:08 | |
amuller | mlavalle: I'll take a look | 22:08 |
mlavalle | amuller: thanks :-) | 22:08 |
*** changbl has quit IRC | 22:09 | |
*** Marga_ has joined #openstack-neutron | 22:13 | |
carl_baldwin | mlavalle: Either way would be fine for me. | 22:13 |
*** Marga_ has quit IRC | 22:13 | |
mlavalle | carl_baldwin: thanks | 22:13 |
*** Marga_ has joined #openstack-neutron | 22:13 | |
*** moshele has joined #openstack-neutron | 22:13 | |
*** seizadi has quit IRC | 22:14 | |
*** seizadi has joined #openstack-neutron | 22:15 | |
openstackgerrit | Rob Pothier proposed openstack/neutron: Add MTU selection to ML2 and OVS MD https://review.openstack.org/156318 | 22:15 |
*** seizadi1 has joined #openstack-neutron | 22:15 | |
*** seizadi has quit IRC | 22:15 | |
*** Rajeev has joined #openstack-neutron | 22:16 | |
*** baoli has joined #openstack-neutron | 22:20 | |
*** ronis has quit IRC | 22:22 | |
amuller | mlavalle: I think the solution is similar to what exists on HEAD, you define a TestAgent and a TestRouterNamespace class | 22:23 |
amuller | the TestRouterNamespace class overrides RouterNamespace.__init__ | 22:23 |
*** ParsectiX has quit IRC | 22:23 | |
amuller | allowing you to remove _get_ns_name | 22:23 |
*** ParsectiX has joined #openstack-neutron | 22:24 | |
amuller | mlavalle: and we'd have to override the creation of RouterNamespace as well | 22:24 |
amuller | which would imply the introduction of a factory method of RouterNamespace | 22:25 |
*** pc_m has quit IRC | 22:25 | |
amuller | because right now its created in RouterInfo.__init__, in the middle of it, that's hard to override | 22:25 |
mlavalle | amuller: correct, that is where I got stuck... | 22:25 |
amuller | it's possible to add a class method to RouterNamespace that would return an instance of itself | 22:26 |
amuller | then we override that in the test code | 22:26 |
mlavalle | I had thought of a TestRouterNamespace, but didn't get to the factory method. That factory method exists purely for testing purposes, right? | 22:27 |
mlavalle | amuller: ^^^ | 22:27 |
amuller | it would be used in the real code, and overridden in the test code | 22:27 |
*** trad511 has quit IRC | 22:27 | |
*** Sukhdev has quit IRC | 22:27 | |
*** jordandh has quit IRC | 22:27 | |
amuller | mlavalle: this isn't ideal either because as you said you wouldnt write a factory method if you didnt have this weird test requirement, but I think that overal this approach is better | 22:28 |
amuller | because you don't have that static get_ns_name that you don't need | 22:28 |
amuller | mlavalle: would it be possible to get rid of that static method for the FIP namespace and SNAT namespace classes as well? | 22:28 |
mlavalle | amuller: yeah, the factory method could be used in the real code. But we don't need to, right? | 22:29 |
openstackgerrit | Carl Baldwin proposed openstack/neutron: WIP Move port processing to router classes https://review.openstack.org/154513 | 22:29 |
amuller | mlavalle: well you'd have to I think | 22:29 |
amuller | otherwise what good would it do to override it, if it isn't actually used when creating a router | 22:29 |
amuller | mlavalle: reading your comment here btw: https://review.openstack.org/#/c/147744/18/neutron/agent/l3/dvr_snat_ns.py | 22:29 |
mlavalle | amuller: Yes, we can remove the static method in SNAT namespace as well | 22:29 |
*** jordandh has joined #openstack-neutron | 22:30 | |
*** achanda has quit IRC | 22:30 | |
amuller | mlavalle: yiykes, you're saying the SNAT namespace and interface is created twice | 22:31 |
*** jckasper has quit IRC | 22:31 | |
*** marun has joined #openstack-neutron | 22:33 | |
openstackgerrit | Julien Anguenot proposed openstack/neutron: Neutron pydevd debugger support https://review.openstack.org/126546 | 22:35 |
mlavalle | amuller: the snat namespace and the internal interface are created twice. Even worst, the first creation in internal_network_added happens "behind the scenes" when the OVS interface driver plugs the interface and doesn't find the namespace | 22:36 |
openstackgerrit | Justin Hammond proposed openstack/python-neutronclient: Client command extension support https://review.openstack.org/148318 | 22:36 |
*** signed8b_ is now known as signed8bit_ZZZzz | 22:36 | |
amuller | mlavalle: yeah I get the same looking at the code, that's so weird | 22:36 |
amuller | mlavalle: Maybe you could ask Rajeev about this | 22:37 |
mlavalle | amuller: when we get to external_gateway_added, it calls again _internal_network_added and connects againg the interface, after explicitely creating the namespace | 22:38 |
mlavalle | amuller: ok, I'll follow up with him. Thanks for the time and advice | 22:38 |
amuller | mlavalle: But, back to our problem, we have a general problem of wanting a namespace name before the Namespace class is instantiated | 22:38 |
amuller | mlavalle: maybe we could eliminate this specific usage, I don't know, but the problem remains | 22:38 |
*** localloop127 has quit IRC | 22:39 | |
mlavalle | amuller: correct, that is the conumdrum. In my opinion, in internal_network_added we should attempt to connect an internal interface if the namespace doesn't exist yet. That is a sign that the external router hasn't been added | 22:40 |
*** johnbelamaric has quit IRC | 22:40 | |
mlavalle | amuller: shouldn't attempt^^^ | 22:40 |
mlavalle | amuller: and therefore, we don't have the need for snat namespace yet. I will ask Rajeev and share back with you, either here or in gerrit | 22:42 |
amuller | mlavalle: I see that in the FipNamespace class there's a get_name method, but it's not a class/static method, and it uses internal state. This implies that no place in the code actually needs the FIP namespace name before its created | 22:42 |
mlavalle | amuller: yes, the fip namespace is different | 22:43 |
*** baoli has quit IRC | 22:43 | |
amuller | mlavalle: So for the regular RouterNamespace only the functional tests need that static method, for the SNATNamespace, is there any place other than the problematic place you found? | 22:43 |
amuller | if we could get rid of these usages and end up removing the static accessors that'd be... Swell :) | 22:43 |
*** banix has quit IRC | 22:44 | |
mlavalle | amuller: it's only the problematic place and the functional test again.... | 22:44 |
amuller | ok | 22:44 |
amuller | mlavalle: For the functional tests we have a plan at least | 22:44 |
amuller | Let's see what Rajeev says about that weird usage | 22:44 |
mlavalle | amuller: yes and i'll follow up with Rajeev | 22:45 |
mlavalle | amuller: thanks for the time. very useful :-) | 22:45 |
amuller | Thanks for being open to suggestions! Most people aren't | 22:45 |
mlavalle | :-) | 22:46 |
rms_13 | Has anybody lately run devstack and ran into neutron failure while attempting to create network. (with NoSuchOptError: no such option: policy_file) | 22:46 |
*** achanda has joined #openstack-neutron | 22:46 | |
*** trad511 has joined #openstack-neutron | 22:46 | |
*** rotbeard has quit IRC | 22:46 | |
mlavalle | amuller: I'll be 55 on 3/6.... I know I don't own the truth :-) | 22:46 |
*** matrohon has quit IRC | 22:47 | |
amuller | mlavalle: Hah :) | 22:47 |
amuller | Do you think you'll be coming to Vancouver? | 22:47 |
mlavalle | amuller: I will. See you there... | 22:47 |
amuller | Sounds good :) | 22:47 |
*** moshele has quit IRC | 22:48 | |
amuller | We must do another Neutron get together again, and get dougwig to pay for everyone again. I don't know but I like that idea. | 22:48 |
roaet | dougwig pays for everyone? That's great! | 22:48 |
*** crc32 has quit IRC | 22:48 | |
mlavalle | amuller: +1 to that | 22:48 |
mlavalle | I've always known dougwig is a great guy | 22:49 |
*** yamahata_ has quit IRC | 22:51 | |
*** isq has joined #openstack-neutron | 22:51 | |
*** jordandh has quit IRC | 22:54 | |
*** baoli has joined #openstack-neutron | 22:55 | |
*** tim_o has joined #openstack-neutron | 22:56 | |
*** dane_leblanc has quit IRC | 22:57 | |
tim_o | I've setup a CI environment, and am in the process of getting log files posted. Question: about how long will it take to get our CI accepted? I've been triggering off Gerrit events for Neutron for some time now. | 23:00 |
*** trad511 has quit IRC | 23:00 | |
*** openstackgerrit has quit IRC | 23:00 | |
roaet | tim_o: I'm not sure about that one, but I know the #openstack-infra folk might be more able to answer that. | 23:00 |
*** openstackgerrit has joined #openstack-neutron | 23:00 | |
*** matrohon has joined #openstack-neutron | 23:01 | |
*** claudiub has quit IRC | 23:01 | |
tim_o | well, they actually pointed me this way...hmm | 23:01 |
clarkb | right | 23:01 |
roaet | oh. | 23:01 |
clarkb | infra has no say on which accounts vote on which projects | 23:01 |
clarkb | that is managed by the projects directly through their CI groups | 23:02 |
roaet | then i am definitely wrong, my apologies :( | 23:02 |
*** kbringard has quit IRC | 23:02 | |
*** seizadi1 has quit IRC | 23:03 | |
tim_o | any idea on how I ping the Neutron CI group? I've been looking for an email alias... | 23:04 |
*** carl_baldwin has quit IRC | 23:05 | |
*** jordandh has joined #openstack-neutron | 23:06 | |
clarkb | tim_o: you want to ping the owners of that group which is neutron-release according to https://review.openstack.org/#/admin/groups/510,info neutron-release is https://review.openstack.org/#/admin/groups/150,members | 23:06 |
clarkb | tim_o: worst case send mail to the dev list, tag it neutron, and ask there | 23:06 |
*** pradk has quit IRC | 23:08 | |
*** matrohon has quit IRC | 23:09 | |
anteaya | it is mestery and emagma | 23:09 |
anteaya | those are the two neutron ci group members | 23:10 |
anteaya | I believe | 23:10 |
dougwig | tim_o: do you have a gerrit account for your CI? | 23:11 |
tim_o | thank you all! | 23:11 |
tim_o | I have my own to receive the gerrit events, I request a CI account some time ago...not sure what happened to the request though | 23:12 |
tim_o | as part of that request, my account was activated. Using that to receive gerrit events to trigger builds for some weeks... | 23:12 |
dougwig | there's nothing official on the neutron side. you need your CI gerrit account, to be posting results on gerrit reviews, have your info in the CI wikis, and note your CI in whatever plugin/driver you're reviewing that needs it, and then the reviewers will peek at it for conformance. | 23:12 |
clarkb | tim_o: CI accounts are self service now, see http://ci.openstack.org/third_party.html#creating-a-service-account | 23:13 |
tim_o | I did that, some time ago. Cannot find it now though... | 23:13 |
dougwig | you need to solve that before anyone on the neutron side can verify your CI. :) | 23:13 |
*** trad511 has joined #openstack-neutron | 23:13 | |
tim_o | http://ci.openstack.org/third_party.html#creating-a-service-account <-- did this, and have the emails also. How best to proceed...any ideas? | 23:15 |
dougwig | is your CI using that account, and posting results? | 23:15 |
*** hichihara has joined #openstack-neutron | 23:15 | |
tim_o | I was told to use my launchpad account for the CI...I was never given a CI (?) | 23:16 |
tim_o | Not posting yet as I've been testing it out | 23:16 |
dougwig | that link you posted. the account you got from that. not your launchpad. | 23:16 |
tim_o | 'silent' from Jenkins standpoint | 23:17 |
dougwig | work on switching to using your CI account, which you self-registered, and then getting results posted. | 23:18 |
*** chlong has joined #openstack-neutron | 23:18 | |
*** jordandh has quit IRC | 23:18 | |
tim_o | Not sure I ever received the CI account login. Maybe best to re-submit the request? | 23:20 |
tim_o | or will that cause issues? | 23:20 |
*** SumitNaiksatam has quit IRC | 23:20 | |
rms_13 | Even after the refactoring of oslo library and corresponding changes in neutron, I see some occurance where we are using old oslo modules. For example, "from oslo.config import cfg" | 23:20 |
*** shwetaap1 has joined #openstack-neutron | 23:20 | |
rms_13 | Isnt this a bug? | 23:21 |
*** jordandh has joined #openstack-neutron | 23:21 | |
tim_o | I will submit a CI request for Neutron, thanks again | 23:21 |
tim_o | in the future I'll be doing CI builds other projects, can I use the same CI? | 23:23 |
*** matrohon has joined #openstack-neutron | 23:23 | |
*** gildub has joined #openstack-neutron | 23:23 | |
*** shwetaap has quit IRC | 23:24 | |
*** trad511 has quit IRC | 23:25 | |
*** karimb has quit IRC | 23:25 | |
*** karimb has joined #openstack-neutron | 23:25 | |
anteaya | tim_o: you don't recieve the ci login, you create it | 23:27 |
*** yamamoto has quit IRC | 23:27 | |
*** yamamoto has joined #openstack-neutron | 23:28 | |
tim_o | Thanks will create one here then. It will need it's own email address in launchpad I assume. | 23:30 |
*** bobmel has quit IRC | 23:31 | |
*** leenheer has quit IRC | 23:31 | |
*** bobmel has joined #openstack-neutron | 23:31 | |
*** trad511 has joined #openstack-neutron | 23:32 | |
*** aranjan has quit IRC | 23:32 | |
*** aranjan has joined #openstack-neutron | 23:34 | |
dougwig | it's own email, yes. it does not need launchpad. | 23:34 |
*** csoukup has quit IRC | 23:34 | |
*** MentalRay has quit IRC | 23:34 | |
*** Aish has left #openstack-neutron | 23:34 | |
*** leenheer has joined #openstack-neutron | 23:35 | |
*** jordandh has quit IRC | 23:35 | |
clarkb | dougwig: it does actually, thats how you authenticate to the web ui to change things | 23:35 |
clarkb | like ssh pubkeys | 23:35 |
clarkb | (you log into gerrit with your lp openid to do that, changing ssh keys in lp itself won't change the keys in gerrit) | 23:36 |
*** ollivier has quit IRC | 23:36 | |
*** yamamoto has quit IRC | 23:37 | |
dougwig | ahh, that must be new? i'm fairly certain i'm from the old days, and just never change things. :) | 23:38 |
clarkb | its part of being self service, we let the old accounts stay as they were and are directing folks that need updates to old accounts to follow the new self service process | 23:38 |
dougwig | gotcha. | 23:39 |
dougwig | tim_o: clarkb certainly has better answers than i do here. | 23:39 |
*** krtaylor has quit IRC | 23:40 | |
*** karimb has quit IRC | 23:41 | |
*** marun has quit IRC | 23:43 | |
*** amuller has quit IRC | 23:45 | |
*** dboik_ has quit IRC | 23:47 | |
*** dims_ has joined #openstack-neutron | 23:49 | |
*** johnbelamaric has joined #openstack-neutron | 23:49 | |
*** dims__ has quit IRC | 23:51 | |
anteaya | gus: are you around? | 23:52 |
*** aepifanov has quit IRC | 23:52 | |
gus | anteaya: yep. | 23:52 |
anteaya | hello | 23:52 |
anteaya | how are you? | 23:53 |
gus | Sorry for missing the meeting btw - I was double booked and didn't realise until after I went into radio blackout. | 23:53 |
anteaya | np | 23:53 |
*** matrohon has quit IRC | 23:53 | |
anteaya | wanted to catch up with you | 23:53 |
anteaya | nova meeting is tomorrow and would like to have the latest status | 23:53 |
anteaya | were you able to read the logs from the meeting? | 23:53 |
gus | Not yet, it's the first thing on today's list. | 23:53 |
anteaya | okay well I'll make a cup of tea | 23:54 |
anteaya | how long before I bug you again? | 23:54 |
gus | 30mins should be fine. | 23:54 |
anteaya | sounds good | 23:54 |
anteaya | thank you | 23:54 |
*** tflynn_ has joined #openstack-neutron | 23:56 | |
*** a_le has quit IRC | 23:56 | |
*** jordandh has joined #openstack-neutron | 23:56 | |
*** jobewan has quit IRC | 23:56 | |
*** a_le has joined #openstack-neutron | 23:57 | |
*** tflynn__ has joined #openstack-neutron | 23:57 | |
*** a_le has quit IRC | 23:57 | |
*** tflynn__ has quit IRC | 23:57 | |
*** ivar-laz_ has joined #openstack-neutron | 23:58 | |
*** tflynn__ has joined #openstack-neutron | 23:58 | |
*** ivar-laz_ has quit IRC | 23:58 | |
*** a_le has joined #openstack-neutron | 23:58 | |
*** ivar-laz_ has joined #openstack-neutron | 23:58 | |
*** tflynn has quit IRC | 23:59 | |
*** ivar-lazzaro has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!