Wednesday, 2015-02-18

*** baoli has quit IRC00:01
*** nlahouti has joined #openstack-neutron00:02
*** leenheer has quit IRC00:03
*** manishg has quit IRC00:03
*** rms_13 has joined #openstack-neutron00:04
*** aranjan_ has joined #openstack-neutron00:04
*** aranjan has quit IRC00:05
*** nlahouti1 has quit IRC00:06
*** aranjan_ has quit IRC00:06
*** julien_ZTE has quit IRC00:07
*** julien_ZTE has joined #openstack-neutron00:07
*** carl_baldwin has quit IRC00:08
*** thedodd has quit IRC00:12
*** shwetaap has joined #openstack-neutron00:13
*** Marga_ has quit IRC00:13
*** Marga_ has joined #openstack-neutron00:14
*** nlahouti has quit IRC00:15
*** stanzgy has quit IRC00:16
openstackgerritDerek Higgins proposed openstack/neutron: Revert "Add the rebinding chance in _bind_port_if_needed"  https://review.openstack.org/15685300:17
*** mlavalle has quit IRC00:17
*** nlahouti has joined #openstack-neutron00:17
*** Marga_ has quit IRC00:18
*** aranjan has joined #openstack-neutron00:18
*** Marga_ has joined #openstack-neutron00:18
*** leenheer has joined #openstack-neutron00:19
*** aranjan has quit IRC00:22
*** marun has quit IRC00:23
*** r-daneel has quit IRC00:26
*** jaypipes has quit IRC00:27
*** carl_baldwin has joined #openstack-neutron00:27
*** banix has joined #openstack-neutron00:28
*** shwetaap has quit IRC00:29
*** shwetaap has joined #openstack-neutron00:29
openstackgerritIsaku Yamahata proposed openstack/neutron: ml2: extension driver isn't passed dbentry to extension result dict  https://review.openstack.org/12917800:30
*** pal has joined #openstack-neutron00:32
*** dims__ has quit IRC00:33
*** dims__ has joined #openstack-neutron00:33
*** dims__ has quit IRC00:33
*** moha_hunt has quit IRC00:34
*** dims__ has joined #openstack-neutron00:35
*** banix has quit IRC00:35
*** markvoelker has quit IRC00:37
*** pal has quit IRC00:37
*** markvoelker has joined #openstack-neutron00:37
*** johnbelamaric has quit IRC00:39
openstackgerritIsaku Yamahata proposed openstack/neutron: ml2: extension driver isn't passed dbentry to extension result dict  https://review.openstack.org/12917800:39
*** banix has joined #openstack-neutron00:39
*** markvoelker has quit IRC00:42
*** seizadi has joined #openstack-neutron00:42
openstackgerritMatthew Thode proposed openstack/neutron: Fixes bug in interface handling of ip_lib.py  https://review.openstack.org/15412800:44
*** david-lyle has quit IRC00:44
*** seizadi has quit IRC00:44
*** banix has quit IRC00:46
*** ramishra_ has joined #openstack-neutron00:46
*** Marga_ has quit IRC00:49
*** pasha117 has quit IRC00:50
*** ramishra_ has quit IRC00:51
*** pasha117 has joined #openstack-neutron00:51
*** banix has joined #openstack-neutron00:52
*** jasondotstar has quit IRC00:55
*** nlahouti has quit IRC00:57
*** tomoe_ has joined #openstack-neutron00:57
*** tomoe_ has quit IRC00:57
*** avozza is now known as zz_avozza00:58
*** reed has quit IRC00:58
*** zz_avozza is now known as avozza00:58
*** tomoe_ has joined #openstack-neutron01:01
*** jordandh has quit IRC01:01
openstackgerritShiv Haris proposed openstack/neutron: Do not review.  https://review.openstack.org/15238301:02
*** MentalRay has joined #openstack-neutron01:03
*** yamamoto has quit IRC01:03
*** nlahouti has joined #openstack-neutron01:04
*** absubram has quit IRC01:05
*** johnbelamaric has joined #openstack-neutron01:06
*** jordandh has joined #openstack-neutron01:07
*** ivar-lazzaro has quit IRC01:08
*** avozza is now known as zz_avozza01:08
openstackgerritMerged openstack/neutron: Un-break tox for unit tests  https://review.openstack.org/15676701:08
*** ivar-lazzaro has joined #openstack-neutron01:09
*** manishg has joined #openstack-neutron01:10
*** ivar-lazzaro has quit IRC01:10
*** manishg has quit IRC01:11
*** manishg has joined #openstack-neutron01:11
*** ivar-lazzaro has joined #openstack-neutron01:11
*** tomoe_ has quit IRC01:14
*** xgerman has quit IRC01:15
*** shaohe_feng has quit IRC01:16
*** achanda has quit IRC01:17
*** johnbelamaric has quit IRC01:19
*** aranjan has joined #openstack-neutron01:19
*** rook has joined #openstack-neutron01:19
*** leenheer has quit IRC01:19
*** rook is now known as Guest3046201:20
*** leenheer has joined #openstack-neutron01:20
*** suresh12 has quit IRC01:21
*** tomoe_ has joined #openstack-neutron01:21
*** zzzeek has quit IRC01:22
*** tomoe_ has quit IRC01:22
*** aranjan has quit IRC01:24
*** mwagner_lap has joined #openstack-neutron01:24
*** a_le has quit IRC01:25
prometheanfireneutron failing tests atm?01:27
openstackgerritRajeev Grover proposed openstack/neutron: WIP fix for _get_external_device_interface_name trace  https://review.openstack.org/15635701:30
*** zzzeek has joined #openstack-neutron01:31
*** banix has quit IRC01:32
*** santosh has joined #openstack-neutron01:32
*** banix has joined #openstack-neutron01:35
*** yamamoto has joined #openstack-neutron01:36
*** a_le has joined #openstack-neutron01:36
*** tomoe_ has joined #openstack-neutron01:37
*** jordandh has quit IRC01:39
*** jordandh has joined #openstack-neutron01:41
*** tomoe_ has quit IRC01:43
*** spandhe has quit IRC01:46
*** ramishra_ has joined #openstack-neutron01:47
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS UT: Fix some confusions between local vlan id and segmentation id  https://review.openstack.org/15646401:48
openstackgerritMiguel Lavalle proposed openstack/neutron: Move Floating IP processing to Router classes  https://review.openstack.org/14286301:51
openstackgerritMiguel Lavalle proposed openstack/neutron: Refactor management of namespaces in the L3 Agent  https://review.openstack.org/14774401:51
*** ramishra_ has quit IRC01:51
*** aranjan has joined #openstack-neutron01:52
*** rwsu is now known as rwsu-afk01:54
openstackgerritTerry Wilson proposed openstack/neutron: Remove remaining uses of passing root_helper  https://review.openstack.org/15590601:57
*** salv-orlando has quit IRC01:58
*** markvoelker has joined #openstack-neutron01:59
*** zz_avozza is now known as avozza01:59
*** Marga_ has joined #openstack-neutron02:01
*** rms_13 has quit IRC02:01
*** Marga_ has quit IRC02:02
*** Marga_ has joined #openstack-neutron02:02
*** pal has joined #openstack-neutron02:03
openstackgerritMerged openstack/neutron-fwaas: Add index on tenant_id  https://review.openstack.org/15449202:04
*** signed8bit is now known as signed8bit_ZZZzz02:04
*** aranjan has quit IRC02:05
*** shwetaap has quit IRC02:07
*** banix has quit IRC02:07
*** briancline has quit IRC02:09
*** briancline has joined #openstack-neutron02:09
*** changbl has joined #openstack-neutron02:10
*** banix has joined #openstack-neutron02:11
*** david-lyle has joined #openstack-neutron02:11
*** SridharRamaswamy has quit IRC02:11
openstackgerritIsaku Yamahata proposed openstack/neutron: internal callers of create_{network, subnet, port} ignore extension  https://review.openstack.org/12977302:13
*** jordandh has quit IRC02:14
*** _cjones_ has quit IRC02:18
*** jordandh has joined #openstack-neutron02:20
openstackgerritTerry Wilson proposed openstack/neutron: Stop using passed root_helper in ip_lib  https://review.openstack.org/14582902:22
openstackgerritTerry Wilson proposed openstack/neutron: Remove root_helper arg for ovs_lib  https://review.openstack.org/15491402:26
*** erkules has joined #openstack-neutron02:28
*** xgerman has joined #openstack-neutron02:28
openstackgerritTerry Wilson proposed openstack/neutron: Remove root_helper arg for ovs_lib  https://review.openstack.org/15491402:30
*** erkules_ has quit IRC02:31
openstackgerritTerry Wilson proposed openstack/neutron: Remove root_helper arg from external_process  https://review.openstack.org/15495902:32
openstackgerritTerry Wilson proposed openstack/neutron: Remove root_helper arg from IptablesManager  https://review.openstack.org/15496902:32
openstackgerritTerry Wilson proposed openstack/neutron: Remove root_helper arg from IpsetManager  https://review.openstack.org/15498002:33
*** Guest30462 has quit IRC02:33
openstackgerritTerry Wilson proposed openstack/neutron: Remove root_helper arg from SecurityGroupAgentRpc  https://review.openstack.org/15501302:33
otherwiseguymestery: doing some rebasing because the ovs_lib root_helper patch needed to be updated due to a recent change.02:34
openstackgerritTerry Wilson proposed openstack/neutron: Remove root_helper arg from linuxbridge  https://review.openstack.org/15501402:34
openstackgerritTerry Wilson proposed openstack/neutron: Remove root_helper arg from AsyncProcess  https://review.openstack.org/15510102:35
openstackgerritTerry Wilson proposed openstack/neutron: Remove root_helper arg from DHCP agent  https://review.openstack.org/15518802:35
otherwiseguymestery: so approvals just disappeard. :/02:37
otherwiseguyBut the merges would have failed otherwise.02:37
*** leenheer has quit IRC02:38
openstackgerritSachi King proposed openstack/neutron: Return exception when attempting to add duplicate VIP  https://review.openstack.org/14263002:38
*** manishg has quit IRC02:42
*** s3wong has quit IRC02:42
openstackgerritBrent Eagles proposed openstack/neutron: Refactor RESOURCE_ATTRIBUTE_MAP cleanup  https://review.openstack.org/15667002:44
*** nlahouti has quit IRC02:45
mesteryotherwiseguy: Looking again02:45
mesteryotherwiseguy: Need to wait for jeknins to pass now02:47
*** ramishra_ has joined #openstack-neutron02:48
otherwiseguymestery: yeah. hopefully no other breaking changes.02:48
mesteryotherwiseguy: Ack02:48
otherwiseguymestery: The l3 agent patch and above depend on merging some *aaS changes I have (which depend on the next patch up, the ip_lib change).02:48
otherwiseguyLots of moving parts. :)02:49
mesteryyeah no kidding02:49
otherwiseguybut hopefully we can avoid breaking things.02:49
otherwiseguyBut if something does break, should be easy fixes.02:49
mesteryyes02:50
*** yuanying has quit IRC02:51
*** ramishra_ has quit IRC02:52
*** apuimedo has quit IRC02:53
*** tiswanso has joined #openstack-neutron02:54
*** avozza is now known as zz_avozza02:56
openstackgerritTerry Wilson proposed openstack/neutron: Remove root_helper arg from L3 Agent  https://review.openstack.org/15521202:57
*** tiswanso has quit IRC02:58
*** radez is now known as radez_g0n302:58
*** tiswanso has joined #openstack-neutron02:59
*** salv-orlando has joined #openstack-neutron02:59
openstackgerritTerry Wilson proposed openstack/neutron: Remove root_helper arg from L3 Agent  https://review.openstack.org/15521203:00
*** a_le has quit IRC03:01
*** jordandh has quit IRC03:01
openstackgerritMerged openstack/neutron: Fix the api job  https://review.openstack.org/15643603:02
*** pal has quit IRC03:03
openstackgerritMerged openstack/neutron: OVS UT: Fix some confusions between local vlan id and segmentation id  https://review.openstack.org/15646403:03
*** carl_baldwin has quit IRC03:07
*** xgerman has quit IRC03:09
*** xgerman has joined #openstack-neutron03:11
*** sthillma has joined #openstack-neutron03:12
*** boris-42 has quit IRC03:12
*** jordandh has joined #openstack-neutron03:12
*** sthillma has quit IRC03:12
*** xuhanp has joined #openstack-neutron03:12
*** yamahata has quit IRC03:13
*** tomoe_ has joined #openstack-neutron03:17
*** xgerman has quit IRC03:20
*** harlowja_ is now known as harlowja_away03:22
*** tomoe_ has quit IRC03:24
*** Marga_ has quit IRC03:25
yamamotoarmax: ping03:27
armaxyamamoto: pong03:27
*** tomoe_ has joined #openstack-neutron03:28
yamamotoarmax: how do you think setup_dvr_mac_flows_on_all_brs/dvr_mac_address_update refactoring part of https://review.openstack.org/#/c/153946/ ?03:28
armaxyamamoto, me looks03:28
*** xuhanp has quit IRC03:29
* armax looks03:29
yamamotoarmax: if you and vivek like it, i might consider "backporting" to reduce the size of the patch.03:29
armaxyamamoto: ok, give me a few to go over it03:30
yamamotoarmax: no hurry at all.  thank you03:30
armaxyamamoto: thank you!03:30
yamamotoarmax: and i have another question...03:31
armaxshoot03:31
*** a_le has joined #openstack-neutron03:31
yamamotoarmax: i want to make ovs-agent use ryu.  ie. add ryu to its requirement03:32
yamamotoarmax: what do you think a proper way to do it?03:32
armaxok03:32
yamamotoarmax: an idea is add it to global-req and neutron's req03:32
yamamotoarmax: alternative is introduce per-agent requirement03:32
armaxyamamoto: yeah..even thought that’s a bit too aggressive03:32
yamamotoarmax: i guess the latter is better wrt decomp effort03:33
armaxyamamoto: how do you intend to use ryu in the agent?03:33
*** tomoe_ has quit IRC03:33
yamamotoarmax: basically use ryu instead of ovs-ofctl03:33
armaxyamamoto: but that would need to be conditional on some sort of env setting, would it not?03:34
yamamotoarmax: ?03:34
yamamotoarmax: you mean a knob to switch between ovs-ofctl and ryu?03:35
armaxyamamoto: ya03:35
*** david-lyle has quit IRC03:35
armaxyamamoto: are you proposing ryu in lieu of ovs-ofctl?03:35
*** david-lyle has joined #openstack-neutron03:35
yamamotoarmax: i don't plan to have such a knob.  it would be "nice-to-have" but not worth the effort IMO.03:35
yamamotoarmax: yes03:36
yamamotoarmax: https://review.openstack.org/#/c/153946/ is WIP patch for it.03:36
*** yuanying has joined #openstack-neutron03:37
armaxyamamoto: in that case, then having ryu part of the requirements would be reasonable03:37
*** a_le has quit IRC03:38
*** a_le has joined #openstack-neutron03:38
armaxyamamoto: but there’s something that tells me that’s not the nicest thing to do03:38
armax:)03:38
*** xgerman has joined #openstack-neutron03:39
armaxI wonder how terrible it would be to consider ryu an external depedency just like ovs03:39
armaxthat would be installed via devstack for instance03:39
*** david-lyle has quit IRC03:40
yamamotoarmax: how do you think making devstack looks at per-driver/plugin/etc requirement.txt in neutron tree?03:40
armaxyamamoto: I tried to document that in the devref03:41
*** yuanying has quit IRC03:41
*** yuanying_ has joined #openstack-neutron03:41
yamamotoarmax: eg. neutron/plugins/$Q_AGENT/requirements.txt03:41
armaxyamamoto: technically speaking that becomes an extra.s hook responsibility03:41
yamamotoarmax: i meant, even for in-tree drivers like OVS.03:42
armaxyamamoto: not sure I follow03:42
*** xuhanp has joined #openstack-neutron03:42
yamamotoarmax: so that i can just add ryu to neutron/plugins/openvswitch/requirement.txt in my patch03:42
*** a_le_ has joined #openstack-neutron03:43
*** coolsvap_ is now known as coolsvap03:43
yamamotoarmax: my understanding is while ovs stays in tree for a while it's planned be restructured to be similar to out-of-tree plugins03:44
yamamotoarmax: right?03:44
armaxyamamoto: well…if ryu is becoming your de facto binding for ovs agent, I don’t think that warrants a per-agent requirement file03:44
yamamotoarmax: but not every users of neutron will use ovs-agent03:45
armaxyamamoto: agreed, that’s why I am still pondering...03:45
armax:)03:45
armaxyamamoto: after all, today ovs is installed out of band too…03:46
*** dane_leblanc has quit IRC03:46
*** tomoe_ has joined #openstack-neutron03:46
yamamotoarmax: right03:47
*** a_le has quit IRC03:47
yamamotoarmax: the problem of out-of-band installation is i can't give jenkins a try for my patch :)03:47
armaxyamamoto: I know..that’s why it’s problematic03:48
*** ramishra_ has joined #openstack-neutron03:49
*** dims__ has quit IRC03:49
*** salv-orlando has quit IRC03:51
*** shwetaap has joined #openstack-neutron03:53
*** ramishra_ has quit IRC03:53
*** tomoe_ has quit IRC03:53
*** amotoki has joined #openstack-neutron03:54
armaxyamamoto: it sounds like this is a topic for a neutron meeting or the mailing list, because if we want Jenking to give it a go…and we don’t want to hold the requirement we might need to come up with something, either in project-config (e.g. like an experimental job) and/or devstack03:55
armaxyamamoto: we wouldn’t want to swap ovs-ofctl with ryu in one go though, I feel people would want a transitionary plan03:55
*** aranjan has joined #openstack-neutron03:56
yamamotoarmax: sure.  i'll add an agenda item or post to ML03:57
yamamotoarmax: i think requirement thing and "ovs-ofctl vs ryu" thing are actually separate topics03:57
*** MentalRay has quit IRC03:57
prometheanfireI think neutron doesn't mount /sys03:58
prometheanfirewell, the tests03:58
prometheanfirehttp://logs.openstack.org/28/154128/6/check/check-tempest-dsvm-neutron-pg/bf01ca8/logs/df.txt.gz03:58
*** ramishra_ has joined #openstack-neutron03:58
prometheanfiremy change needs /sys/class/net03:58
yamamotodoes "On Demand Agenda" on wiki mean "feel free to add your favorite topic" ?03:59
otherwiseguyyamamoto: as someone who has recently gone through the add-a-knob-for-ovs work...it is definitely quite a bit of work.03:59
*** tomoe_ has joined #openstack-neutron03:59
yamamotootherwiseguy: sure.  for ofctl-vs-ryu it's worse as openflow would need a far larger "neutral api" than ovsdb04:02
HenryGarosen: ping04:02
otherwiseguyyamamoto: also, thanks for all of the reviews. you often catch things I've missed.04:04
yamamotootherwiseguy: no problem.  it's my joy.04:06
*** tomoe_ has quit IRC04:06
*** pal has joined #openstack-neutron04:10
*** aranjan has quit IRC04:13
*** Marga_ has joined #openstack-neutron04:14
*** yatin has joined #openstack-neutron04:15
*** Marga_ has quit IRC04:18
*** Marga_ has joined #openstack-neutron04:19
*** rotbart has quit IRC04:19
*** david-lyle has joined #openstack-neutron04:22
*** david-lyle is now known as david-lyle_afk04:23
*** tflynn_ has joined #openstack-neutron04:24
*** tflynn has quit IRC04:27
*** shaohe_feng has joined #openstack-neutron04:28
*** tflynn_ has quit IRC04:28
*** achanda has joined #openstack-neutron04:29
*** santosh_ has joined #openstack-neutron04:30
*** killer_prince is now known as lazy_prince04:31
*** signed8bit_ZZZzz has quit IRC04:32
*** santosh has quit IRC04:32
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Use python binding instead of ovs-ofctl command  https://review.openstack.org/15394604:33
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: Make l2pop UT independent from OVS  https://review.openstack.org/11862004:33
roaetamotoki: Hey there! Good morning, maybe?04:33
amotokiroaet: hi04:34
amotokiroaet: good afternoon :) now around 130pm04:34
roaetamotoki: while the fate of my change (https://review.openstack.org/#/c/148318/) is unsure, as the client core, I just want to make sure I satisfied all your comments. I mentioned it earlier today (yesterday for you). Not sure if you remember, but due diligence commands I try.04:35
roaetamotoki: japan?04:35
amotokiroaet: yes.04:36
amotokiroaet: looking. in the morning, i was ooo for meetings.04:36
roaetI dream to visit that place some day. Big fan of the culture and language, though I can't speak it anymore (or write it). I slept since the school days.04:36
*** shaohe_feng has quit IRC04:37
amotokiroaet: there are many discussions from last night (on my side).04:37
roaetamotoki: yes... ha.04:38
roaetamotoki: that's what I was alluding to as far as fate being unsure. If the meeting tomorrow chooses to allow it to go I'd at least like to know that the code is quality from your perspective.04:39
*** ramishra_ has quit IRC04:39
openstackgerritAndrew Boik proposed openstack/neutron: WIP: Support multiple IPv6 prefixes on internal router ports  https://review.openstack.org/15636004:41
*** tomoe_ has joined #openstack-neutron04:41
*** ramishra_ has joined #openstack-neutron04:42
openstackgerritIWAMOTO Toshihiro proposed openstack/neutron: Add availability_zone support  https://review.openstack.org/14994004:42
*** gildub has quit IRC04:42
amotokiroaet: perhaps in the next Neturon meeting or cross project meeting. I am not sure "Tuesday meeting" mark mentioned..04:43
roaetamotoki: it is a meeting today (for you) in openstack-meeting-304:43
roaet1530 UTC.04:44
roaetI plan on being there, and your insight as client-core would be appreciated04:45
*** achanda has quit IRC04:45
amotokiroaet: got it. I just saw the mail to my private address.04:45
*** tomoe_ has quit IRC04:48
*** dims__ has joined #openstack-neutron04:50
*** xgerman has quit IRC04:52
*** achanda has joined #openstack-neutron04:52
*** xgerman_ has joined #openstack-neutron04:52
openstackgerritMerged openstack/neutron: Stop using passed root_helper in ip_lib  https://review.openstack.org/14582904:52
*** seizadi has joined #openstack-neutron04:52
*** ramishra_ has quit IRC04:53
*** tiswanso has quit IRC04:54
*** dims__ has quit IRC04:54
*** dane_leblanc has joined #openstack-neutron04:56
*** xgerman_ has quit IRC04:57
*** xgerman__ has joined #openstack-neutron04:57
*** seizadi has quit IRC04:59
*** shilpa_ has joined #openstack-neutron04:59
*** seizadi has joined #openstack-neutron04:59
*** achanda has quit IRC04:59
*** ramishra_ has joined #openstack-neutron04:59
*** shwetaap has quit IRC05:00
*** achanda has joined #openstack-neutron05:00
*** shwetaap has joined #openstack-neutron05:01
*** jckasper has joined #openstack-neutron05:02
*** dane_leblanc has quit IRC05:02
*** jckasper has quit IRC05:02
*** jckasper has joined #openstack-neutron05:02
*** xgerman__ has quit IRC05:03
*** seizadi has quit IRC05:03
*** pal has quit IRC05:04
*** pal_ has joined #openstack-neutron05:04
*** seizadi has joined #openstack-neutron05:04
*** _cjones_ has joined #openstack-neutron05:04
*** ramishra_ has quit IRC05:06
*** claudiub_ has quit IRC05:08
*** seizadi1 has joined #openstack-neutron05:08
*** seizadi has quit IRC05:08
*** anish_ has joined #openstack-neutron05:09
*** banix has quit IRC05:09
otherwiseguyHenryG: dougwig: thanks for the reviews/approvals. The L3 agent patch depends on https://review.openstack.org/#/c/156690/, which I've got re-checking and has passed the py27 test that was failing because the ip_lib patch hadn't merged. Once the aforementioned vpnaas patch merges, it should be safe to merge the L3 agent patch and above patches (up to the final one which there are some comments for me to address).05:09
*** dane_leblanc has joined #openstack-neutron05:09
*** aranjan has joined #openstack-neutron05:10
otherwiseguyI've done my best to avoid breaking things, but I wouldn't be entirely surprised if something has slipped through somewhere. The fixes should be very easy if something does slip through, though.05:10
dougwigotherwiseguy: sorry for my schizophrenic over commenting. I needed to stop typing hours ago.  :)05:10
otherwiseguydougwig: Comments are good. I like comments. :)05:11
*** achanda has quit IRC05:11
*** leenheer has joined #openstack-neutron05:11
*** seizadi has joined #openstack-neutron05:12
*** seizadi1 has quit IRC05:12
*** pal_ has quit IRC05:12
HenryGotherwiseguy: You're welcome. It's late here, I'll check the L3 agent patch tomorrow.05:12
*** santosh_ has quit IRC05:13
*** ramishra_ has joined #openstack-neutron05:13
otherwiseguydougwig: on the neutron-is-a-library thing, I can see your point. I was hoping that it was a very limited-use library and that I found everything that used it. :) An argument could be made that anything using neutron's neutron.agent.linux.utils.execute should be using oslo_concurrency.processutils.execute.05:14
otherwiseguyBut I can see not wanting to crash somebody's program too. :)05:14
*** rkukura has quit IRC05:14
otherwiseguyI'll take a look at it tomorrow.05:15
otherwiseguyHenryG: Yeah, late here too. Sleeeeep.05:15
otherwiseguydougwig: HenryG: Thanks to you both, again. Good night. :)05:16
dougwigotherwiseguy: this is how I hope to resolve these issues: https://review.openstack.org/#/c/154736/05:16
dougwigand now i'm really out of here.  :)05:16
*** seizadi1 has joined #openstack-neutron05:16
*** seizadi has quit IRC05:16
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: test_l2population: Use a local copy of ofagent mech driver  https://review.openstack.org/15023905:16
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: ofagent: Vendor code decomposition  https://review.openstack.org/14994105:16
*** trinaths has joined #openstack-neutron05:17
*** ajmiller has joined #openstack-neutron05:18
*** dkehn has quit IRC05:19
*** seizadi has joined #openstack-neutron05:19
*** seizadi1 has quit IRC05:20
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: Fix a usage error of joinedload + filter in l3 scheduler  https://review.openstack.org/14945805:23
*** pal has joined #openstack-neutron05:23
*** tflynn has joined #openstack-neutron05:23
*** jckasper has quit IRC05:23
*** ajmiller has quit IRC05:24
*** seizadi1 has joined #openstack-neutron05:25
*** seizadi has quit IRC05:26
*** seizadi has joined #openstack-neutron05:29
*** seizadi1 has quit IRC05:30
*** zhenq has quit IRC05:30
*** zhenq has joined #openstack-neutron05:30
*** belmoreira has joined #openstack-neutron05:31
*** jckasper has joined #openstack-neutron05:33
*** leenheer has quit IRC05:33
*** yamahata has joined #openstack-neutron05:33
*** zhenq has quit IRC05:34
*** seizadi1 has joined #openstack-neutron05:34
*** seizadi has quit IRC05:34
*** salv-orlando has joined #openstack-neutron05:36
*** leenheer has joined #openstack-neutron05:36
openstackgerritMerged openstack/neutron: Remove root_helper arg for ovs_lib  https://review.openstack.org/15491405:38
*** seizadi has joined #openstack-neutron05:38
*** _cjones_ has quit IRC05:38
openstackgerritMatthew Thode proposed openstack/neutron: Fixes bug in interface handling of ip_lib.py  https://review.openstack.org/15412805:38
*** seizadi1 has quit IRC05:38
*** _cjones_ has joined #openstack-neutron05:39
*** aranjan_ has joined #openstack-neutron05:40
*** aranjan has quit IRC05:40
prometheanfirethis should be fun05:40
*** jckasper_ has joined #openstack-neutron05:42
*** zzzeek has quit IRC05:43
*** ramishra_ has quit IRC05:44
*** seizadi has quit IRC05:44
*** seizadi has joined #openstack-neutron05:45
*** seizadi has quit IRC05:45
*** jckasper has quit IRC05:46
*** leenheer has quit IRC05:51
*** rotbeard has joined #openstack-neutron05:51
*** achanda has joined #openstack-neutron05:53
*** nlahouti has joined #openstack-neutron05:55
*** yshafrir has joined #openstack-neutron05:55
*** saju_m has joined #openstack-neutron05:56
*** nlahouti1 has joined #openstack-neutron05:58
*** Murali has joined #openstack-neutron06:00
*** nlahouti has quit IRC06:00
*** crc32 has quit IRC06:03
*** markvoelker has quit IRC06:03
*** armax has quit IRC06:04
*** markvoelker has joined #openstack-neutron06:04
*** yfried_ has joined #openstack-neutron06:04
*** zz_avozza is now known as avozza06:05
*** anshul has joined #openstack-neutron06:06
*** ajo_ has joined #openstack-neutron06:08
*** markvoelker has quit IRC06:08
*** cipcosma has joined #openstack-neutron06:10
*** ajo has quit IRC06:11
*** nlahouti1 has quit IRC06:13
*** nlahouti has joined #openstack-neutron06:13
*** avozza is now known as zz_avozza06:15
*** tflynn has quit IRC06:15
*** tflynn has joined #openstack-neutron06:16
*** jamielennox is now known as jamielennox|away06:17
*** Marga_ has quit IRC06:20
*** achanda has quit IRC06:20
*** SridharG has joined #openstack-neutron06:22
*** achanda has joined #openstack-neutron06:22
*** irenab has joined #openstack-neutron06:24
*** tflynn has quit IRC06:26
*** tflynn has joined #openstack-neutron06:27
*** neeti has joined #openstack-neutron06:30
*** zhenq has joined #openstack-neutron06:31
*** aepifanov has joined #openstack-neutron06:31
*** achanda has quit IRC06:32
*** ivar-laz_ has joined #openstack-neutron06:33
*** ajo_ is now known as ajo06:35
*** zhenq has quit IRC06:35
*** vthapar has joined #openstack-neutron06:36
openstackgerritMerged openstack/neutron: Hyper-V: Fixes security groups issue  https://review.openstack.org/15082606:36
*** ivar-lazzaro has quit IRC06:37
*** lazy_prince is now known as killer_prince06:37
*** ivar-laz_ has quit IRC06:38
*** shwetaap has quit IRC06:41
*** jprovazn has joined #openstack-neutron06:42
*** killer_prince is now known as lazy_prince06:44
*** rkukura has joined #openstack-neutron06:46
*** leenheer has joined #openstack-neutron06:48
trinathsHi Neutroners, Happy Morning06:48
*** markvoelker has joined #openstack-neutron06:53
*** dane_leblanc has quit IRC06:55
*** achanda has joined #openstack-neutron06:56
openstackgerritMerged openstack/neutron: Search in /sys/class/net for network devices  https://review.openstack.org/15402106:58
*** pal has quit IRC06:58
*** markvoelker has quit IRC06:58
*** pal has joined #openstack-neutron06:58
openstackgerritYoni Shafrir proposed openstack/neutron: Adding support for Keepalived health check script.  https://review.openstack.org/15656306:59
*** julien_ZTE has quit IRC07:04
*** tomoe_ has joined #openstack-neutron07:04
*** julien_ZTE has joined #openstack-neutron07:04
*** julien_ZTE has quit IRC07:04
*** julien_ZTE has joined #openstack-neutron07:05
*** tomoe_ has quit IRC07:06
*** tflynn has quit IRC07:06
*** tomoe_ has joined #openstack-neutron07:09
*** Tarun has joined #openstack-neutron07:09
*** julien_ZTE has quit IRC07:09
*** tomoe_ has quit IRC07:11
*** leenheer has quit IRC07:13
*** mzbik has joined #openstack-neutron07:16
TarunHi I want to add a new message which would be localized in neutron code. So based on accept-language parameter from request it would be translated. i have made necessary changes but was not able to test it. My request packet does not contain this accept-language header. Could someone please tell me how this parameter could be set.07:16
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: OVS-agent: Use python binding instead of ovs-ofctl command  https://review.openstack.org/15394607:21
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: Make l2pop UT independent from OVS  https://review.openstack.org/11862007:21
*** _cjones_ has quit IRC07:23
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: test_l2population: Use a local copy of ofagent mech driver  https://review.openstack.org/15023907:23
openstackgerritYAMAMOTO Takashi proposed openstack/neutron: ofagent: Vendor code decomposition  https://review.openstack.org/14994107:23
*** _cjones_ has joined #openstack-neutron07:24
openstackgerritYoni Shafrir proposed openstack/neutron: Adding support for Keepalived health check script.  https://review.openstack.org/15656307:25
*** _cjones_ has quit IRC07:28
*** tomoe_ has joined #openstack-neutron07:28
*** blinky42 has quit IRC07:30
*** tomoe_ has quit IRC07:30
*** ZZelle has quit IRC07:32
*** tomoe_ has joined #openstack-neutron07:32
*** ZZelle has joined #openstack-neutron07:32
*** garyk has joined #openstack-neutron07:33
garykyshafrir: you there?07:34
garykyshafrir: can you please add DocImpact into the commit message for https://review.openstack.org/#/c/156563/07:34
*** nmagnezi has joined #openstack-neutron07:35
*** scheuran has joined #openstack-neutron07:40
yshafrirgaryk, i added it07:46
*** kawa2014 has joined #openstack-neutron07:46
yshafrirgaryk, for some reason i can't see it either07:46
yshafrirgaryk, i'll add it again07:46
garykyshafrir: thanks! let me know when you do and I will give my thiumbs up07:47
*** aranjan_ has quit IRC07:47
yshafrirgaryk, thanks !07:47
*** vitorc has quit IRC07:49
*** salv-orlando has quit IRC07:51
openstackgerritYoni Shafrir proposed openstack/neutron: Adding support for Keepalived health check script.  https://review.openstack.org/15656307:52
yshafrirgaryk, added the DocImpact07:52
garykThanks07:53
*** afazekas has joined #openstack-neutron07:54
*** markvoelker has joined #openstack-neutron07:54
*** vitorc has joined #openstack-neutron07:55
*** aranjan has joined #openstack-neutron07:58
*** markvoelker has quit IRC07:59
*** boris-42 has joined #openstack-neutron08:00
*** aranjan has quit IRC08:02
openstackgerritJaume Devesa proposed openstack/neutron: Update midonet plugin requirements  https://review.openstack.org/15691208:05
*** julien_ZTE has joined #openstack-neutron08:05
*** jistr has joined #openstack-neutron08:08
*** nyechiel_ has joined #openstack-neutron08:09
*** chlong has quit IRC08:10
*** ronis has joined #openstack-neutron08:11
*** vitorc has quit IRC08:11
*** evgenyf has joined #openstack-neutron08:11
*** nlahouti has quit IRC08:12
*** yamamoto has quit IRC08:13
*** blinky42 has joined #openstack-neutron08:14
*** moshele has joined #openstack-neutron08:15
*** yamahata has quit IRC08:15
*** yamahata has joined #openstack-neutron08:16
*** vitorc has joined #openstack-neutron08:16
openstackgerritAnn Kamyshnikova proposed openstack/neutron: Add a functional test that checks HA router is configured on a restarted agent  https://review.openstack.org/15395308:17
*** pask81 has joined #openstack-neutron08:17
*** devvesa has joined #openstack-neutron08:18
*** ajo has quit IRC08:18
*** zhenq has joined #openstack-neutron08:20
*** yuanying_ has quit IRC08:21
*** shaohe_feng has joined #openstack-neutron08:22
*** aepifanov has quit IRC08:22
*** yuanying has joined #openstack-neutron08:22
*** zhenq has quit IRC08:24
*** stanzgy has joined #openstack-neutron08:26
*** bjornar has joined #openstack-neutron08:27
*** yuanying has quit IRC08:27
*** yuanying has joined #openstack-neutron08:28
openstackgerritMike Kolesnik proposed openstack/neutron: Add proccess monitor to keepalived  https://review.openstack.org/15316208:29
*** yuanying has quit IRC08:30
*** yuanying has joined #openstack-neutron08:31
*** achanda has quit IRC08:31
*** jlanoux has joined #openstack-neutron08:31
*** ajo has joined #openstack-neutron08:35
*** morgabra has quit IRC08:39
*** asadoughi has quit IRC08:39
*** jkyle1 has quit IRC08:40
prometheanfireakamyshnikova: ping, about the commit message you commented on08:41
*** asadoughi has joined #openstack-neutron08:41
*** doude has joined #openstack-neutron08:41
akamyshnikovaprometheanfire, hi, it is just a suggestion :)08:42
prometheanfirewell, I was hoping you'd know what to do about the failures08:43
*** morgabra has joined #openstack-neutron08:43
prometheanfireno mater what I try I can't construct a find command that works08:43
*** yuanying has quit IRC08:48
*** salv-orlando has joined #openstack-neutron08:48
*** yuanying has joined #openstack-neutron08:48
*** jpena has joined #openstack-neutron08:49
*** evgenyf has quit IRC08:49
*** yuanying has quit IRC08:52
*** jkyle1 has joined #openstack-neutron08:54
*** markvoelker has joined #openstack-neutron08:55
*** yuanying has joined #openstack-neutron08:55
*** ajo has quit IRC08:56
*** hjensas has joined #openstack-neutron08:58
*** aranjan has joined #openstack-neutron08:59
*** yuanying has quit IRC09:00
*** markvoelker has quit IRC09:00
*** salv-orlando has quit IRC09:01
*** matrohon has joined #openstack-neutron09:01
*** ajo has joined #openstack-neutron09:01
*** salv-orlando has joined #openstack-neutron09:01
akamyshnikovaprometheanfire, I'm afraid I don't, I just though it is WIP change09:02
*** yuanying has joined #openstack-neutron09:03
*** aranjan has quit IRC09:03
prometheanfireit's definitely WIP09:08
prometheanfireit's breaking me though09:08
prometheanfireCommand: ['sudo', 'ip', 'netns', 'exec', 'foo', 'find', '"/sys/class/net -type l"']09:08
prometheanfireStderr: 'find: `"/sys/class/net -type l"\': No such file or directory\n'09:08
prometheanfirebut this works09:08
prometheanfiresudo ip netns exec foo find /sys/class/net -type l09:08
prometheanfireno idea09:08
openstackgerritYoni Shafrir proposed openstack/neutron: Removing a router twice from the same agent shouldn't cause an error  https://review.openstack.org/14888309:08
*** yamamoto has joined #openstack-neutron09:10
*** salv-orlando has quit IRC09:10
*** salv-orlando has joined #openstack-neutron09:10
*** severson_ has quit IRC09:10
*** severson_ has joined #openstack-neutron09:11
*** yamamoto has quit IRC09:12
*** aepifanov has joined #openstack-neutron09:12
*** severson_ has quit IRC09:14
*** sseverson has joined #openstack-neutron09:15
*** yamamoto has joined #openstack-neutron09:15
*** stanzgy has quit IRC09:17
*** ygbo has joined #openstack-neutron09:17
*** yuanying has quit IRC09:18
*** hichihara has quit IRC09:23
*** jlibosva has joined #openstack-neutron09:23
*** julien_ZTE has quit IRC09:24
*** tomoe_ has quit IRC09:28
*** tomoe_ has joined #openstack-neutron09:28
*** tomoe_ has quit IRC09:30
*** anilvenkata has joined #openstack-neutron09:31
*** salv-orlando has quit IRC09:32
*** salv-orlando has joined #openstack-neutron09:32
*** yamamoto has quit IRC09:33
*** salv-orlando has quit IRC09:35
*** salv-orlando has joined #openstack-neutron09:36
*** sbelous has joined #openstack-neutron09:37
openstackgerritIsaku Yamahata proposed openstack/neutron: internal callers of create_{network, subnet, port} ignore extension  https://review.openstack.org/12977309:38
*** yamamoto has joined #openstack-neutron09:42
*** maishsk has joined #openstack-neutron09:45
*** salv-orlando has quit IRC09:45
maishskgood morning to you all09:45
maishskquestion - is it possible to apply a security group to a floating IP ?09:46
*** salv-orlando has joined #openstack-neutron09:46
*** zz_avozza is now known as avozza09:46
*** yamamoto has quit IRC09:46
maishskI think it is neutron port-update --security-group <blah>09:46
*** apuimedo has joined #openstack-neutron09:46
*** mkerrin has joined #openstack-neutron09:46
maishskam I correct?09:46
*** gridinv has joined #openstack-neutron09:47
*** ihrachyshka has joined #openstack-neutron09:49
*** salv-orl_ has joined #openstack-neutron09:49
*** salv-orl_ has quit IRC09:51
*** salv-orlando has quit IRC09:51
*** salv-orlando has joined #openstack-neutron09:51
*** obondarev_ has quit IRC09:55
*** obondarev has joined #openstack-neutron09:56
*** salv-orlando has quit IRC09:56
*** markvoelker has joined #openstack-neutron09:56
*** salv-orlando has joined #openstack-neutron09:56
*** lori|away is now known as lori09:57
*** evgenyf has joined #openstack-neutron09:58
boris-42garyk: hi hi09:58
boris-42garyk: could you please take a look one more time at https://review.openstack.org/#/c/155789/09:59
boris-42garyk: it fails quite often in rally gates=)09:59
*** ollivier has joined #openstack-neutron09:59
*** aranjan has joined #openstack-neutron10:00
garykboris-42: sure. rally is giving me too many sleepless nights10:01
*** markvoelker has quit IRC10:02
*** dsneddon has quit IRC10:02
boris-42garyk: lol10:03
*** aranjan has quit IRC10:04
boris-42garyk: thank you10:06
akamyshnikovagaryk, thanks!10:06
akamyshnikovasalv-orlando, mestery hi! Could you take a look at this change https://review.openstack.org/#/c/155789/ too?10:07
garykboris-42: please stop working on rally - it gives me too many headaches :)10:08
*** zhenq has joined #openstack-neutron10:09
*** jp_at_hp has joined #openstack-neutron10:10
openstackgerritNuman Siddique proposed openstack/neutron-vpnaas: Fix the ipsec conn issue when peer addr is fqdn  https://review.openstack.org/14500510:10
*** numan has joined #openstack-neutron10:10
boris-42garyk: hehe10:11
*** jamiec has quit IRC10:13
*** zhenq has quit IRC10:13
*** yamahata has quit IRC10:15
*** numan has quit IRC10:16
*** xuhanp has quit IRC10:16
*** jamiec has joined #openstack-neutron10:17
openstackgerritMiguel Angel Ajo proposed openstack/neutron: WIP: Reorders firewall security group/members calls.  https://review.openstack.org/15656610:17
ajohanzhang ^10:18
ajoif you can take a look to that commit10:18
ajoI found something via an error message that I included into the ipset implementation10:18
*** saju_m has quit IRC10:25
*** obondarev has quit IRC10:25
*** obondarev_ has joined #openstack-neutron10:25
*** britthou_ has joined #openstack-neutron10:25
*** julien_ZTE has joined #openstack-neutron10:26
*** Apsu has quit IRC10:26
*** saju_m has joined #openstack-neutron10:27
*** britthouser has quit IRC10:27
*** MentalRay has joined #openstack-neutron10:28
*** numan has joined #openstack-neutron10:28
*** p01s0n has joined #openstack-neutron10:28
*** MentalRay has quit IRC10:29
*** Apsu has joined #openstack-neutron10:29
*** evgenyf has quit IRC10:32
*** yamamoto has joined #openstack-neutron10:33
*** zhenq has joined #openstack-neutron10:34
*** nyechiel__ has joined #openstack-neutron10:34
*** nyechiel_ has quit IRC10:36
*** zhenq has quit IRC10:38
*** yamamoto has quit IRC10:38
*** shaohe_feng has quit IRC10:39
*** yatin has quit IRC10:39
*** yamamoto has joined #openstack-neutron10:52
*** yamamoto has quit IRC10:58
*** obondarev_ has quit IRC10:59
*** obondarev has joined #openstack-neutron11:00
*** yamamoto has joined #openstack-neutron11:00
*** aranjan has joined #openstack-neutron11:00
*** yamamoto has quit IRC11:02
openstackgerritIhar Hrachyshka proposed openstack/neutron: Don't monkey patch netns_cleanup  https://review.openstack.org/15537311:02
openstackgerritIhar Hrachyshka proposed openstack/neutron: tests: monkey patch stdlib before importing other modules  https://review.openstack.org/15322511:02
openstackgerritIhar Hrachyshka proposed openstack/neutron: Monkey patch all the code inside neutron/cmd/eventlet/...  https://review.openstack.org/15694211:02
openstackgerritIhar Hrachyshka proposed openstack/neutron-vpnaas: Explicitly monkey patch VPN agent  https://review.openstack.org/15660211:02
*** aranjan has quit IRC11:05
*** kbyrne has quit IRC11:09
*** kbyrne has joined #openstack-neutron11:13
*** nyechiel__ has quit IRC11:17
*** nyechiel__ has joined #openstack-neutron11:17
*** stanzgy has joined #openstack-neutron11:18
openstackgerritIhar Hrachyshka proposed openstack/neutron: Moved several services into neutron.cmd.eventlet  https://review.openstack.org/15537411:19
*** dims__ has joined #openstack-neutron11:19
*** amotoki has quit IRC11:20
*** nyechiel has joined #openstack-neutron11:21
*** p01s0n has quit IRC11:21
*** nyechiel__ has quit IRC11:21
*** smcgough has left #openstack-neutron11:22
*** stanzgy has quit IRC11:23
*** evgenyf has joined #openstack-neutron11:24
*** stanzgy has joined #openstack-neutron11:25
*** tomoe_ has joined #openstack-neutron11:25
*** kawa2014 has quit IRC11:26
*** saju_m has quit IRC11:31
*** bobmel has quit IRC11:31
*** bobmel has joined #openstack-neutron11:31
*** saju_m has joined #openstack-neutron11:32
openstackgerritNuman Siddique proposed openstack/neutron-vpnaas: Fix the ipsec conn issue when peer addr is fqdn  https://review.openstack.org/14500511:34
openstackgerritHenry Gessau proposed openstack/neutron: Remove root_helper arg from external_process  https://review.openstack.org/15495911:36
*** moha_hunt has joined #openstack-neutron11:37
*** aix has joined #openstack-neutron11:37
*** humble_ has joined #openstack-neutron11:38
openstackgerritHenry Gessau proposed openstack/neutron: Remove root_helper arg from IptablesManager  https://review.openstack.org/15496911:39
*** pc_m has joined #openstack-neutron11:41
ihrachyshkaHenryG, heh, you're on board with killing helper, nice11:43
*** chlong has joined #openstack-neutron11:44
*** mzbik has quit IRC11:53
openstackgerritDerek Higgins proposed openstack/neutron: Revert "Add the rebinding chance in _bind_port_if_needed"  https://review.openstack.org/15685311:53
*** derekh has joined #openstack-neutron11:53
HenryGihrachyshka: yes, trying to get the patch sequence through the gate11:54
*** nyechiel has quit IRC11:54
derekhHi all, tripleo-ci appears to be suffering from at least 2 (probably 3) regressions that have snuck in since friday, this revert https://review.openstack.org/#/c/156853/ seems to fix one of them11:55
openstackgerritHenry Gessau proposed openstack/neutron: Remove root_helper arg from IpsetManager  https://review.openstack.org/15498011:55
derekhI havn't looked into the problem have to track down the other problems11:55
*** rpothier has joined #openstack-neutron11:58
*** aix_ has joined #openstack-neutron11:58
*** aix_ has quit IRC11:59
*** aix has quit IRC11:59
*** aix has joined #openstack-neutron11:59
*** aix has quit IRC12:00
*** aix has joined #openstack-neutron12:00
openstackgerritIhar Hrachyshka proposed openstack/neutron: Moved several services into neutron.cmd.eventlet  https://review.openstack.org/15537412:01
openstackgerritIhar Hrachyshka proposed openstack/neutron: Move entry points for some 3party plugins into neutron.cmd.eventlet  https://review.openstack.org/15541212:01
*** aranjan has joined #openstack-neutron12:01
openstackgerritIhar Hrachyshka proposed openstack/neutron: Move entry points for some 3party plugins into neutron.cmd.eventlet  https://review.openstack.org/15541212:02
*** zhenq has joined #openstack-neutron12:04
*** aranjan has quit IRC12:05
*** yatin has joined #openstack-neutron12:05
*** obondarev_ has joined #openstack-neutron12:07
*** zhenq has quit IRC12:09
*** jistr has quit IRC12:09
*** obondarev has quit IRC12:09
ZZellesalv-orlando, hi12:11
*** jistr has joined #openstack-neutron12:12
*** steveg is now known as sgordon12:14
*** obondarev_ has quit IRC12:18
openstackgerritIhar Hrachyshka proposed openstack/neutron: Moved several services into neutron.cmd.eventlet  https://review.openstack.org/15537412:19
openstackgerritIhar Hrachyshka proposed openstack/neutron: Move entry points for plugin agents into neutron.cmd.eventlet  https://review.openstack.org/15541212:19
*** salv-orlando has quit IRC12:20
*** MentalRay has joined #openstack-neutron12:20
openstackgerritPraveen Kumar SM proposed openstack/neutron: DHCP Service LoadBalancing Scheduler  https://review.openstack.org/13701712:21
*** NellyK has joined #openstack-neutron12:23
*** nyechiel has joined #openstack-neutron12:24
*** apuimedo has quit IRC12:28
openstackgerritPraveen Kumar SM proposed openstack/neutron: DHCP Service LoadBalancing Scheduler  https://review.openstack.org/13701712:31
*** NellyK has quit IRC12:32
*** NellyK has joined #openstack-neutron12:33
*** signed8bit has joined #openstack-neutron12:37
*** signed8bit is now known as signed8bit_ZZZzz12:37
*** signed8bit_ZZZzz is now known as signed8bit12:37
openstackgerritIhar Hrachyshka proposed openstack/neutron: Monkey patch all the code inside neutron/cmd/eventlet/...  https://review.openstack.org/15694212:37
openstackgerritIhar Hrachyshka proposed openstack/neutron: Don't monkey patch netns_cleanup  https://review.openstack.org/15537312:37
openstackgerritIhar Hrachyshka proposed openstack/neutron: Moved several services into neutron.cmd.eventlet  https://review.openstack.org/15537412:37
openstackgerritIhar Hrachyshka proposed openstack/neutron: tests: monkey patch stdlib before importing other modules  https://review.openstack.org/15322512:37
openstackgerritIhar Hrachyshka proposed openstack/neutron: Move entry points for plugin agents into neutron.cmd.eventlet  https://review.openstack.org/15541212:37
*** amotoki has joined #openstack-neutron12:37
*** NellyK has quit IRC12:40
*** sgordon is now known as steveg12:42
eezhovaamotoki, could you please take a look at https://review.openstack.org/#/c/138708/ ?12:42
amotokieezhova: will look after writing a mail.12:45
eezhovaamotoki, thanks12:45
*** shilpa_ has quit IRC12:47
*** radez_g0n3 is now known as radez12:48
*** seizadi has joined #openstack-neutron12:50
*** amuller has joined #openstack-neutron12:51
ihrachyshkaamotoki, fyi I've updated monkey patches to leave dumb main()s inside neutron/cmd/eventlet/...12:51
*** pal has quit IRC12:51
amotokiihrachyshka: I am not sure everyone like my idea. I hope it help the situation.12:52
ihrachyshkaamotoki, we'll see. :) salv was also for one liners.12:52
ihrachyshkaamotoki, drivers meeting is in several hours12:53
ihrachyshkaamotoki, afaik this will be one of the points to discuss12:53
amotokiihrachyshka: yeah. I need to spend some more hours before going to bed.12:54
*** trinaths has left #openstack-neutron12:54
*** seizadi1 has joined #openstack-neutron12:54
*** seizadi has quit IRC12:54
*** seizadi has joined #openstack-neutron12:58
*** seizadi1 has quit IRC12:59
*** aix has quit IRC12:59
*** seizadi1 has joined #openstack-neutron13:01
*** yatin has quit IRC13:01
*** signed8bit has quit IRC13:02
*** aranjan has joined #openstack-neutron13:02
*** seizadi has quit IRC13:02
*** baoli has joined #openstack-neutron13:03
*** baoli has quit IRC13:04
*** baoli has joined #openstack-neutron13:05
*** seizadi1 has quit IRC13:05
*** seizadi has joined #openstack-neutron13:05
*** jaypipes has joined #openstack-neutron13:05
*** aranjan has quit IRC13:06
*** signed8bit has joined #openstack-neutron13:07
*** yamamoto has joined #openstack-neutron13:08
*** markvoelker has joined #openstack-neutron13:11
*** seizadi has quit IRC13:11
*** neeti has quit IRC13:12
*** aix has joined #openstack-neutron13:12
*** seizadi has joined #openstack-neutron13:13
*** rpothier has quit IRC13:15
*** obondarev has joined #openstack-neutron13:17
*** anilvenkata has left #openstack-neutron13:17
*** zigo has quit IRC13:18
*** jprovazn has quit IRC13:19
*** zigo has joined #openstack-neutron13:20
*** jprovazn has joined #openstack-neutron13:21
openstackgerritHenry Gessau proposed openstack/neutron: Remove root_helper arg from SecurityGroupAgentRpc  https://review.openstack.org/15501313:24
*** salv-orlando has joined #openstack-neutron13:25
openstackgerritHenry Gessau proposed openstack/neutron: Remove root_helper arg from linuxbridge  https://review.openstack.org/15501413:25
*** moshele has quit IRC13:25
*** seizadi has quit IRC13:26
*** signed8bit has quit IRC13:27
*** signed8b_ has joined #openstack-neutron13:27
*** seizadi has joined #openstack-neutron13:27
*** shwetaap has joined #openstack-neutron13:34
*** anish_ has quit IRC13:35
*** aix has quit IRC13:37
*** shaohe_feng has joined #openstack-neutron13:38
*** rotbeard has quit IRC13:38
*** seizadi has quit IRC13:41
*** bobmel has quit IRC13:42
*** bobmel has joined #openstack-neutron13:42
*** humble_ has quit IRC13:43
*** kawa2014 has joined #openstack-neutron13:44
openstackgerritMerged openstack/neutron: Skip DBDuplicateEntry exception in security group creation  https://review.openstack.org/15578913:46
*** ramishra_ has joined #openstack-neutron13:49
*** trown has quit IRC13:49
*** evanjfraser has quit IRC13:49
openstackgerritMiguel Angel Ajo proposed openstack/neutron: WIP: Investigating the cause for bug/1421772  https://review.openstack.org/15656613:49
*** krtaylor has quit IRC13:50
*** saju_m has quit IRC13:50
*** trown has joined #openstack-neutron13:50
*** evanjfraser has joined #openstack-neutron13:51
*** krtaylor has joined #openstack-neutron13:56
*** yamamoto has quit IRC14:00
*** jckasper_ has quit IRC14:00
*** annegent_ has joined #openstack-neutron14:01
*** kbringard has joined #openstack-neutron14:02
*** aranjan has joined #openstack-neutron14:03
*** aix has joined #openstack-neutron14:03
*** aranjan has quit IRC14:07
*** yamamoto has joined #openstack-neutron14:08
*** moha_hunt has quit IRC14:08
mesteryotherwiseguy: Are all of your root helper patches merged now? A quick glance leads me to think yes!14:13
*** wverdugo5001 has joined #openstack-neutron14:13
openstackgerritMerged openstack/neutron: Remove root_helper arg from external_process  https://review.openstack.org/15495914:13
*** dims__ has quit IRC14:15
openstackgerritMerged openstack/neutron: Remove root_helper arg from IptablesManager  https://review.openstack.org/15496914:16
*** ramishra_ has quit IRC14:17
*** annegent_ has quit IRC14:18
*** annegent_ has joined #openstack-neutron14:19
*** dims__ has joined #openstack-neutron14:20
*** shilpa_ has joined #openstack-neutron14:20
*** dims__ has quit IRC14:20
*** dims__ has joined #openstack-neutron14:21
openstackgerritHenry Gessau proposed openstack/neutron: Remove root_helper arg from AsyncProcess  https://review.openstack.org/15510114:21
*** localloop127 has joined #openstack-neutron14:21
openstackgerritHenry Gessau proposed openstack/neutron: Remove root_helper arg from DHCP agent  https://review.openstack.org/15518814:22
*** tiswanso has joined #openstack-neutron14:23
openstackgerritMerged openstack/neutron: Remove root_helper arg from IpsetManager  https://review.openstack.org/15498014:24
*** dims__ has quit IRC14:25
*** jckasper has joined #openstack-neutron14:26
*** evgenyf has quit IRC14:27
*** shilpa_ has quit IRC14:27
*** dboik has joined #openstack-neutron14:29
*** changbl has quit IRC14:32
*** rushil has joined #openstack-neutron14:32
*** localloop127 has quit IRC14:33
*** yshafrir has quit IRC14:35
*** Guest37356 has joined #openstack-neutron14:35
*** jgrimm is now known as zz_jgrimm14:38
*** baoli has quit IRC14:39
*** shwetaap1 has joined #openstack-neutron14:39
*** baoli has joined #openstack-neutron14:39
*** baoli has quit IRC14:42
*** shwetaap has quit IRC14:42
*** ramishra_ has joined #openstack-neutron14:43
*** seizadi has joined #openstack-neutron14:43
*** baoli has joined #openstack-neutron14:43
otherwiseguymestery: they are at least in process.14:43
*** imcsk8 has quit IRC14:45
*** imcsk8 has joined #openstack-neutron14:45
*** kkuznetsova has joined #openstack-neutron14:45
otherwiseguymestery: Looks like some more rebasing done overnight. Still have about 13 patches to go. :)14:45
*** localloop127 has joined #openstack-neutron14:46
*** vthapar has quit IRC14:46
*** kkuznetsova has quit IRC14:46
*** kkuznetsova has joined #openstack-neutron14:47
*** rotbeard has joined #openstack-neutron14:47
*** seizadi has quit IRC14:47
*** anshul has quit IRC14:48
*** Guest37356 is now known as dims__14:49
*** shaohe_feng has quit IRC14:49
amotokiihrachyshka: question on oslo.log. do we need to migrate graduated oslo.log in Kilo? I tried to search the status, but I can't find out the exact status.14:50
*** ajo has quit IRC14:51
*** ajo has joined #openstack-neutron14:51
mesteryotherwiseguy: ack14:51
roaetamotoki: good evening(?)14:52
otherwiseguymestery: which means most of my day will be spent staring at zuul and fixing things as soon as they go off the rails. :p14:52
amotokiroaet: good night?14:52
mesteryotherwiseguy: Ping me as you need merge help my friend :)14:52
otherwiseguymestery: count on it. :)14:53
roaetthat works haha. in regards to your comments on https://review.openstack.org/#/c/148318/12 if I put the underscore in front of the module (which I absolutely support and it makes sense to not show fox-* commands), would you be opposed to me adding a special case to allow fox_sockets to be tested still?14:53
ihrachyshkaamotoki, I don't think it was officially releaseds.14:53
ihrachyshkaamotoki, no email on it in openstack-dev@14:54
ihrachyshkaamotoki, so even if there are pypi packages, they are not considered final for consumption14:54
amotokiihrachyshka: I think so too, but we no longer has openstack.common.log in oslo-incubator.14:54
ihrachyshkaamotoki, I prefer not to consume stuff that is not blessed by oslo team14:54
*** krtaylor has quit IRC14:54
ihrachyshkaamotoki, right, I guess guys are in the middle of graduating it14:54
ihrachyshkaamotoki, do you have specific need for incubator version? a bug in mind?14:55
amotokiihrachyshka: yes, agree. it seems better I check the status to them.14:55
ihrachyshkaamotoki, for kilo, we're going to consider oslo.policy, but that's all I guess14:55
amotokiihrachyshka: no, i don't see any specific topic which needs to be updated.14:55
*** krtaylor has joined #openstack-neutron14:55
ihrachyshkaamotoki, (policy is also not yet released)14:55
*** shaohe_feng has joined #openstack-neutron14:55
amotokiihrachyshka: I just noticed it when I worked plugin decomposition and I could not find log from incubator. this raised me a question.14:57
ihrachyshkaamotoki, ack. do plugins maintain their own copy of incubator files?14:57
pc_mihrachyshka: Can we talk about https://review.openstack.org/#/c/156602?14:57
*** yfried_ has quit IRC14:57
ihrachyshkaamotoki, I hope so since I'm not going to make sure I don't break them updating oslo files in neutron :)14:57
ihrachyshkaamotoki, *aas repos consuming neutron oslo modules is more than enough to make me busy14:58
amotokiihrachyshka: if a plugin consumes some modules from incubator, i think it is good to copy it.14:58
ihrachyshkapc_m, sure14:58
pc_mihrachyshka: Would like to understand what we're doing (as I'm not that familiar with the monkey patching stuff).14:58
ihrachyshkaamotoki, for *aas repos, it's different. hence I am asking.14:58
amotokiihrachyshka: ah, i see. for *aas, it is better to sync with neutorn. they are all upstream repositories.14:59
amotokiihrachyshka: s/sync with/consume from/14:59
*** salv-orlando has quit IRC15:00
pc_mihrachyshka: In PS2 it looked like it was importing from neutron.agent, and if not there, would import from neutron.cmd.agents to call main() on the L3 agent.15:00
ihrachyshkapc_m, so, now instead of calling monkey_patch() in random places in neutron/..., we consolidate it into neutron/cmd/eventlet/__init__.py and put all entry points for all agents that run with eventlet on there, so that monkey_patch() is called for them when import is done. but since vpn agent reuses l3 agent main() and assumes it's monkey patched, and since it's not the case with new scheme, we need to patch stdlib explicit15:00
ihrachyshkaly.15:00
ihrachyshkaamotoki, right.15:00
ihrachyshkapc_m, right, the initial idea was to move actual main() functions under neutron/cmd/...15:00
ihrachyshkapc_m, but then there was a concern that we probably want to avoid this shuffling15:01
*** armax has joined #openstack-neutron15:01
ihrachyshkapc_m, so instead of this, we just put dump main() functions under neutron/cmd/eventlet/... that just call to 'real' main() located under old path15:01
*** salv-orlando has joined #openstack-neutron15:02
amotokiihrachyshka: pc_m: where we should place main() is another headache. Some reason they are located in the main code (e.g., neutron/agent/dhcp_agent.py) is to ensure monkey-patched :-(15:03
*** evgenyf has joined #openstack-neutron15:03
amotokiwe will discuss it in 30 minutes, so we can defer the discussion.15:04
ihrachyshkaright.15:04
ihrachyshkapc_m, drivers meeting is in <30 mins15:04
ihrachyshkapc_m, it's on agenda, you can join for details15:04
*** jordandh has quit IRC15:04
*** aranjan has joined #openstack-neutron15:04
*** jordandh has joined #openstack-neutron15:04
pc_mihrachyshka: I think I better, as I'm trying to wrap my head around all this.15:04
pc_mihrachyshka: I'm fuzzy on what the monkey patching does and why it's needed.15:05
*** ramishra_ has quit IRC15:05
*** pal has joined #openstack-neutron15:05
ihrachyshkapc_m, well... then you can start from eventlet docs, it should give some grasp15:06
amotokipc_m: briefly speaking, eventlet needs modified version of some standard modules. it is what monkey patch does.15:06
pc_mihrachyshka: WIll do... It seems that it is dynamically modifying attributes, but I'm trying to understand what is being modified and why.15:07
pc_mihrachyshka:15:07
ihrachyshkapc_m, right, it replaces some parts of stdlib to make them non blocking but yielding to other green threads.15:07
ihrachyshkapc_m, http://eventlet.net/doc/patching.html#monkeypatching-the-standard-library15:07
ihrachyshkayou can get an idea of the list of modules patches15:07
ihrachyshka*patched15:07
*** aranjan has quit IRC15:09
pc_mihrachyshka: thanks, starting to get clearer.15:10
pc_mihrachyshka: Can you elaborate on why it is needed now for the vpn agent, whereas we didn't before?15:11
openstackgerritTerry Wilson proposed openstack/neutron-vpnaas: Remove remaining root_helper references  https://review.openstack.org/15669115:12
*** nmagnezi has quit IRC15:12
*** sseverson has quit IRC15:14
*** sseverson has joined #openstack-neutron15:14
*** irenab has quit IRC15:14
*** numan has quit IRC15:16
*** pal_ has joined #openstack-neutron15:16
*** marun has joined #openstack-neutron15:17
*** pal has quit IRC15:19
openstackgerritRajeev Grover proposed openstack/neutron: fix for _get_external_device_interface_name trace  https://review.openstack.org/15635715:22
ihrachyshkapc_m, because before the changes that I refer to in commit message, importing neutron.agent.l3_agent would monkey patch your stdlib for you. but now that eventlet.monkey_patch() calls are being consolidated in a separate file, it's no longer the case. since we don't want vpn agent to unintentionally switch to non-patched mode, we need to make sure it patches stdlib on its own.15:22
*** zz_jgrimm is now known as jgrimm15:22
*** dkehn has joined #openstack-neutron15:22
pc_mihrachyshka: Ah. that makes more sense now15:26
pc_mihrachyshka: thanks!15:26
ihrachyshkapc_m, ur welcome15:26
openstackgerritRajeev Grover proposed openstack/neutron: fix for _get_external_device_interface_name trace  https://review.openstack.org/15635715:31
*** devlaps has joined #openstack-neutron15:32
*** ollivier has quit IRC15:33
*** spradeepv has joined #openstack-neutron15:36
*** Murali has quit IRC15:36
*** amuller has quit IRC15:36
*** shivharis has joined #openstack-neutron15:38
openstackgerritBrian Haley proposed openstack/neutron: Check if routing rule exists before adding  https://review.openstack.org/15233015:39
*** dane_leblanc has joined #openstack-neutron15:40
*** tomoe_ has quit IRC15:41
*** zhenq has joined #openstack-neutron15:42
*** zzzeek has joined #openstack-neutron15:43
openstackgerritMiguel Angel Ajo proposed openstack/neutron: WIP: Investigating the cause for bug/1421772  https://review.openstack.org/15656615:45
*** carl_baldwin has joined #openstack-neutron15:45
*** dboik has quit IRC15:45
*** carl_baldwin has quit IRC15:45
*** carl_baldwin has joined #openstack-neutron15:46
*** shilpa_ has joined #openstack-neutron15:47
openstackgerritPavel Bondar proposed openstack/neutron: Refactor db_base_plugin_v2.py to use new IPAM  https://review.openstack.org/15323615:47
*** Sukhdev has joined #openstack-neutron15:48
*** aranjan has joined #openstack-neutron15:51
*** a_le_ has quit IRC15:51
*** shilpa_ has quit IRC15:52
*** dboik has joined #openstack-neutron15:52
*** aranjan has quit IRC15:53
*** pasha117 has quit IRC15:53
*** dboik_ has joined #openstack-neutron15:54
*** tomoe_ has joined #openstack-neutron15:55
*** tomoe_ has quit IRC15:56
*** moshele has joined #openstack-neutron15:56
*** dboik has quit IRC15:57
*** yamahata has joined #openstack-neutron15:58
openstackgerritMerged openstack/python-neutronclient: Add unit tests for agentscheduler related commands  https://review.openstack.org/13870815:59
*** tomoe_ has joined #openstack-neutron16:00
*** a_le has joined #openstack-neutron16:00
*** rm_work|away is now known as rm_work16:04
*** anshul has joined #openstack-neutron16:04
*** csoukup has joined #openstack-neutron16:04
*** spradeepv has left #openstack-neutron16:05
openstackgerritMerged openstack/neutron: Remove root_helper arg from SecurityGroupAgentRpc  https://review.openstack.org/15501316:09
*** stanzgy has quit IRC16:10
*** evgenyf has quit IRC16:10
*** xgerman has joined #openstack-neutron16:12
openstackgerritTerry Wilson proposed openstack/neutron: Remove root_helper arg from L3 Agent  https://review.openstack.org/15521216:13
otherwiseguyHenryG: mestery: The next patch up for review/merge for root_helper is the vpnaas patch that will need to be merged before the l3_agent neutron patch is merged16:16
mesteryotherwiseguy: Link?16:16
*** neeti has joined #openstack-neutron16:16
otherwiseguymestery: doh. https://review.openstack.org/#/c/156690/16:16
HenryGotherwiseguy: I am keeping an eye on the patches in queue16:17
otherwiseguyHenryG: thanks!16:17
otherwiseguy(me too) :)16:17
*** ollivier has joined #openstack-neutron16:17
*** carl_baldwin_ has joined #openstack-neutron16:19
otherwiseguyTrying to catch issues as early as possible. Kind of weird that my second vpnaas patch which depends on the l3agent stuff fails py27 as though the l3agent patch wasn't dependent (even though I can see it pull the l3agent patch in zuul). If I checkout the l3agent review directly and put it in .tox/py27/src/neutron, the py27 test passes.16:19
*** ParsectiX has joined #openstack-neutron16:19
*** carl_baldwin has quit IRC16:19
*** carl_baldwin_ is now known as carl_baldwin16:19
*** hjensas has quit IRC16:19
*** dboik_ has quit IRC16:19
*** dboik has joined #openstack-neutron16:20
*** dboik_ has joined #openstack-neutron16:22
*** ollivier has quit IRC16:23
*** pradk has joined #openstack-neutron16:24
*** mlavalle has joined #openstack-neutron16:25
*** dboik has quit IRC16:25
*** mlavalle has quit IRC16:26
*** steveg is now known as sgordon16:27
*** mlavalle has joined #openstack-neutron16:27
*** ajmiller has joined #openstack-neutron16:27
*** sgordon has quit IRC16:27
*** sgordon has joined #openstack-neutron16:27
*** david-lyle_afk is now known as david-lyle16:28
roaetSimilar to adding the command extensibility to the client to bridge the gap, we have a bp for auth extensibility as well, and it is also ready to be reviewed (once we push it).16:30
mesteryroaet: In the client?16:31
roaetmestery: yes, since there is no way to not use keystone or noauth16:31
roaetmestery: https://blueprints.launchpad.net/python-neutronclient/+spec/pluggable-neutronclient-auth16:31
mesteryamotoki: ^^^^ Can you review this one?16:31
roaetmestery: tbh they are literally the same thing to us but we just.. made two blueprints so it wasn't dorky.16:31
ihrachyshkamestery, markmcclain, armax, salv-orlando: we will also need https://review.openstack.org/#/c/156602/ on vpnaas side before merging https://review.openstack.org/15537416:31
otherwiseguyHenryG: weird, in the gate test the vpnaas patch py27 failed (https://jenkins02.openstack.org/job/gate-neutron-vpnaas-python27/46/console) because it passes root_helper to RouterInfo, which should still have support for the argument until the L3Agent patch (https://review.openstack.org/#/c/155212/11/neutron/agent/l3/router_info.py) removes it.16:32
amotokimestery: sure, but i can't have enough time on this. probally this weekend.16:32
otherwiseguyand the l3agent patch isn't in the gate yet.16:32
roaetamotoki: it is no rush, our review hasn't even been pushed. We'll try to get one out this friday16:32
*** armax has quit IRC16:32
roaetmestery: amotoki I appreciate your time.16:33
*** armax has joined #openstack-neutron16:33
HenryGotherwiseguy: Is the gate basing *aas patches on neutron patches?16:33
*** avozza is now known as zz_avozza16:33
amotokiroaet: nice. there are several hardcoding logic in auth logic and i believe your bp help to address the situation :)16:33
roaetamotoki: I kind of added the noauth hardcoding :/16:33
amotokiroaet: on the other hand, i wonder it fits OSC/SDK more.16:34
otherwiseguyHenryG: I specifically broke the vpnaas patches into two bits so I could do Depends-On: $ip_lib_patch in one and Depends-On: $l3_agent_patch in another. Don't know why it would be pulling in something that is just in the check queue...16:34
dougwigmarun: is now good?  what I was thinking would not need a co-gate.  can you expand on that?16:34
*** ronis has quit IRC16:35
roaetamotoki: it is a similar situation, some providers' users rely on the python-* clients, but with auth the way it is they don't work.16:35
marundougwig: regarding interface stability, we need explicit contracts.16:35
otherwiseguyanteaya: ^ (starting with HenryG: weird, in the gate tests)16:35
marundougwig: without explicit contracts, we would need to co-gate to avoid breakage.16:35
roaetamotoki: I am all for putting in the effort to fix up OSC/SDK but we will need time to begin that deprecation cycle.16:35
dougwigmarun: right, totally agree.  i even said that in the spec.  :)16:36
amotokiroaet: understandable.16:36
marundougwig: ok, I need to read it.  I've been spending too much time on non-neutron stuff.16:36
markmcclainroaet: but we don't support any alternate auth today16:36
marundougwig: how about I go do that now and come back to you to discuss?16:36
dougwigok, great.16:36
markmcclainso not seeing how deprecation cycle would apply here16:37
roaetmarkmcclain: that is very true16:37
amotokiroaet: i see noauth inconsistency among *client too :-(    [just a comment]16:37
marunroaet: so does the client support noauth today?16:37
roaetmarun: yes16:37
roaetmarun: I added it awhile ago.16:37
roaetbut we never actually finished the bp16:37
roaetWhere it needed the pluggable part.16:37
marunroaet: ah, ok.16:38
ihrachyshkaotherwiseguy, I saw some bugs due to Depends-On16:38
ihrachyshkaotherwiseguy, I suspect it's not really ready for advanced usage16:38
* ihrachyshka is going to remove the tag from one of his patches due to bugs16:38
marunihrachyshka: what kind of bug?16:38
amotokiroaet: could you send a mail to dev list about how we should support pluggable auth in client (OSC vs *client)? I beleive not a small nubmer of folks are interested in this topic16:38
roaetamotoki: I will do that. thank you.16:39
amotokiroaet: it is not specific to neutroclient.16:39
otherwiseguyanteaya: basically, very confused how https://review.openstack.org/156690 in neutron-vpnaas can fail a test on what looks like a change that should only be made in https://review.openstack.org/#/c/155212/ which it doesn't depend-on and isn't yet in the gate queue.16:39
*** thedodd has joined #openstack-neutron16:39
*** changbl has joined #openstack-neutron16:39
ihrachyshkamarun, jenkins claiming merge conflicts and still setting V+1 as in: https://review.openstack.org/15537416:39
roaetamotoki: ok.16:39
ihrachyshkamarun, I reported it to fungi at #openstack-infra16:39
marunihrachyshka: hmmm...16:39
*** pal_ has quit IRC16:40
ihrachyshkamarun, btw there are no real conflicts, it's just reporting those16:40
marunihrachyshka: I wonder if the merge conflicts are related to that, though.16:40
marunihrachyshka: Maybe16:40
ihrachyshkamarun, that's what fungi suggested, I leave it to his discretion :)16:40
marunihrachyshka: we started seeing all kinds of spurious merge conflict errors in january, not sure if it has anything to do with the depends-on feature or not.16:41
*** radez is now known as radez_g0n316:41
*** gridinv has quit IRC16:41
ihrachyshkamarun, right, I saw those too, but I suspect my case is different16:41
marunihrachyshka: but I guess it would make sense if a single depends-on would ripple through to things that don't even use it16:41
*** a_le_ has joined #openstack-neutron16:42
*** dboik_ has quit IRC16:42
*** a_le has quit IRC16:42
anteayaotherwiseguy: looking at status.o.o/zuul right now zuul believes the dependency tree is 155014,12 -> 155101,13 -> 155188,11 -> 156690,1 -> 155212,1116:43
*** SridharG has left #openstack-neutron16:43
*** nlahouti has joined #openstack-neutron16:43
anteayaotherwiseguy: currently 155212,11 is the only one being tested in check, the whole stack relationship is represented in check right now16:43
anteayawhat is the failure for 156690,1?16:44
anteayalet's start there16:44
*** pradipta has joined #openstack-neutron16:44
otherwiseguyanteaya: which looks right, the 156690,1 seems to be failing because it passes root_helper arg to RouterInfo, which is removed in 155212,11 which depends on 156690, not the other way.16:45
anteayathen the dependency chain is not represented in the way that zuul understand16:45
anteayas16:45
anteayaso perhaps take a look at that as a first step16:46
*** rwsu-afk is now known as rwsu16:46
* otherwiseguy is confused16:46
*** banix_ has joined #openstack-neutron16:46
otherwiseguyThe dependency chain *looks* right to me.16:46
anteayaokay16:46
anteayathen if the failure is caused by something that is removed in the child patch16:47
*** dboik_ has joined #openstack-neutron16:47
anteayathe failure makes sense, does it not16:47
anteayasince the parent patch in that relationship doesn't know about it16:47
*** ParsectiX has quit IRC16:47
anteayaif the failure in 156690,1 is fixed in 155212,1116:48
anteayaand 155212,11 is a child of 156690,116:48
anteayathen 156690,1 is failing16:48
anteayais that accurate?16:48
*** ParsectiX has joined #openstack-neutron16:48
otherwiseguyWait, no, the dep looks wrong to me. Got my arrows backward.16:48
anteayaotherwiseguy: okay then16:48
anteayatry again with the dependencies in the intended direction16:48
*** scheuran has quit IRC16:49
*** ParsectiX has quit IRC16:50
*** ParsectiX has joined #openstack-neutron16:51
*** afazekas has quit IRC16:51
otherwiseguyanteaya: Actually I can't read line numbers. it is another patch that has merged in my tree that causes it to break, a couple lines below what I was looking at.16:52
*** neeti has quit IRC16:52
* otherwiseguy swears off long chains of patches that touch external projects16:53
otherwiseguyanteaya: thanks for looking at it. sorry to be a bit slow today. :)16:54
anteayait happens16:54
anteayaso jim found it then16:54
anteayathe problem with fixing things that introduce complexity is that they become more complex16:55
openstackgerritTerry Wilson proposed openstack/neutron: Remove root_helper arg from linux interface  https://review.openstack.org/15552216:55
openstackgerritTerry Wilson proposed openstack/neutron: Remove remaining root_helper args from plugins  https://review.openstack.org/15552316:55
*** hjensas has joined #openstack-neutron16:55
*** anshul has quit IRC16:55
openstackgerritTerry Wilson proposed openstack/neutron: Remove root_helper arg from sanity checks  https://review.openstack.org/15590516:56
openstackgerritTerry Wilson proposed openstack/neutron: Remove remaining uses of passing root_helper  https://review.openstack.org/15590616:56
*** jlibosva has quit IRC16:56
*** irenab has joined #openstack-neutron16:56
*** Marga_ has joined #openstack-neutron16:58
*** Marga_ has quit IRC16:58
*** Marga_ has joined #openstack-neutron16:59
*** rushil has quit IRC17:00
otherwiseguyanteaya: Keeping 20 patches spanning 4 projects organized in my brain isn't working as well as I'd hoped. ;)17:01
*** banix_ is now known as banix17:01
anteayawell we all have our limitations17:01
openstackgerritDerek Higgins proposed openstack/neutron: Revert "Remove RPC dependency to create FIP agent gw port"  https://review.openstack.org/15706317:01
*** shivharis has quit IRC17:01
*** s3wong has joined #openstack-neutron17:02
*** coolsvap is now known as coolsvap_17:03
*** leenheer has joined #openstack-neutron17:03
*** moshele has quit IRC17:03
derekhHi All, tripleo-ci has been broken for the last few days, dues to 3 regressions, 2 of them look like they are in neutron17:03
derekhhttps://bugs.launchpad.net/tripleo/+bug/1423228 and17:03
openstackLaunchpad bug 1423228 in tripleo "L3 agent for nova compute could not be found" [Critical,Triaged] - Assigned to Derek Higgins (derekh)17:03
derekhhttps://bugs.launchpad.net/tripleo/+bug/142183517:03
openstackLaunchpad bug 1421835 in neutron "Timeout reached while waiting for callback for node" [Undecided,In progress] - Assigned to Derek Higgins (derekh)17:04
derekhI've submitted reverts for both, could somebody look into them please17:04
*** seizadi has joined #openstack-neutron17:04
openstackgerritTerry Wilson proposed openstack/neutron-vpnaas: Stop storing and passing root_helper  https://review.openstack.org/15669017:04
*** belmoreira has quit IRC17:05
*** kfox1111 has joined #openstack-neutron17:05
otherwiseguyHenryG: hopefully that ^ should get the vpnaas patch across the gate. The Iptables patch merging broke that patch.17:05
kfox1111any neutron developers wake?17:05
derekhHere are the reverts https://review.openstack.org/#/c/156853/  https://review.openstack.org/#/c/157063/17:05
kfox1111I've got a fairly serious floating ip schedualing issue thats affecting our production cloud. :/17:06
HenryGotherwiseguy: thanks17:06
*** annegent_ has quit IRC17:06
*** SridharRamaswamy has joined #openstack-neutron17:06
otherwiseguyHenryG: though I probably should have mentioned that *after* it passes checks.17:06
*** luqas___ has joined #openstack-neutron17:06
derekhkfox1111, is this the problem your hitting by any chance ?17:06
kfox1111floating ip's are getting schedualed to the wrong router.17:06
derekhhttps://bugs.launchpad.net/tripleo/+bug/142322817:06
openstackLaunchpad bug 1423228 in tripleo "L3 agent for nova compute could not be found" [Critical,Triaged] - Assigned to Derek Higgins (derekh)17:06
derekhkfox1111, ahh ok, not the same thing17:07
kfox1111no. different bug.17:07
* otherwiseguy is now scared he has broken something anytime derekh mentions reverts 17:07
kfox1111I have two external networks, two routers in a tenant, attached to a tenant network,17:07
kfox1111and floating ip's on both networks.17:07
openstackgerritIhar Hrachyshka proposed openstack/neutron-vpnaas: Explicitly monkey patch VPN agent  https://review.openstack.org/15660217:07
kfox1111with icehouse, it worked very nicely.17:07
*** irenab has quit IRC17:07
kfox1111just upgraded to juno,17:08
ihrachyshkasalv-orlando, armax: ^^17:08
ihrachyshkathe reworked vpnaas patch17:08
kfox1111and all new associations go to one of the two routers17:08
*** luqas__ has quit IRC17:08
marundougwig: hi17:08
dougwigmarun: hiya17:08
kfox1111serious issue. :/17:08
derekhotherwiseguy, not looking in your direction this time ;-)17:08
*** jlanoux_ has joined #openstack-neutron17:08
*** dmellado has quit IRC17:08
kfox1111odly, the floating ip's that were setup before the upgrade are all still working, and attached to the correct routers.17:09
kfox1111so I think its a schedualing bug.17:09
kfox1111Does anyone know where that code is?17:09
marundougwig: I'm not sure I understand the rationale for creating a library.17:09
marundougwig: I'm hearing rumblings that there are tooling/infra issues that are suggesting this course of action.17:09
*** amotoki has quit IRC17:10
dougwigmarun: makes it easy to put the library in pypi, and from there global-requirements and the requirements files of the folks that depend on it.17:10
*** a_le_ has quit IRC17:10
marundougwig: what's stopping neutron from being that thing?17:10
marundougwig: I'm not really clear on why it's easier to publish a library vs neutron itself.17:11
*** jlanoux has quit IRC17:11
*** irenab has joined #openstack-neutron17:12
*** dmellado has joined #openstack-neutron17:12
dougwigif you publish neutron, because python has no access controls, there's nothing stopping anyone from reaching in and using one of the non-library modules.  i'm also not sure that I want to contemplate the joys of having potentially one version of neutron in a requirements file while the OS installs another.17:12
marunOS?17:12
dougwigredhat/ubuntu/etc17:12
marunI'm not sure what that has to do with anything17:12
marunrequirements files and distro packaging are always going to conflict17:13
dougwigrepos are cheap, and tooling expects one python package per repo.  what's the argument for not separating?17:13
marundougwig: cost17:13
marundougwig: it might be an eventually desirable goal17:13
*** SridharRamaswamy has quit IRC17:13
*** pask81 has quit IRC17:13
marundougwig: but to be clear, I see the need for enforceable interface stability17:13
dougwigthe really hard part (and it is massive), i'm not sure has anything to do with one or two repos.17:14
marundougwig: the immediate need to externalize to a library is a nicety that doesn't preclude interface stability17:14
dougwigtrue, but it does provide an easy structure to communicate to potential contributors/helpers.17:14
marundougwig: I'm a bit surprised that you're not admitting the cost of multiple repos.17:14
*** jistr has quit IRC17:15
marundougwig: it's a cost that might be worth it in some cases, but it's a cost nonetheless17:15
*** irenab has quit IRC17:15
*** jkyle1 has quit IRC17:15
marundougwig: clearly delineated module paths in the neutron repo would accomplish most of what you want, though.17:15
marundougwig: I'm not saying that a library doesn't have advantates.17:15
dougwigit's a cost, but after fighting with neutron as both a library and a not-library for a cycle now, it's a cost i'm personally wiling to bear tenfold. the communication of where the lines are drawn has not been simple or successful.17:16
marundougwig: but in your proposed spec I see no mention of the tradeoffs17:16
*** SridharRamaswamy has joined #openstack-neutron17:16
*** devvesa has quit IRC17:16
marundougwig: it reads as if externalizing is the only path forward with little discussion as to why17:16
dougwigi can add an alternative for that, for sure.17:16
marundougwig: not just as an alternative17:16
marunI think there needs to be pretty comprehensive documentation as to why a lib is the best way forward17:17
marunrather than just treating it as a foregone conclusion17:17
marunThe fact that we're waiting until vancouver to contemplate a split of the reference control plane suggests that we may need similar oversight around libification.17:17
openstackgerritSwaminathan Vasudevan proposed openstack/neutron: Get rid of rpc to fetch fip agent port on agent.  https://review.openstack.org/15373517:18
marunWhich suggests that for kilo, stabilizing interfaces in the current repo may be the best you can hope for.17:18
*** a_le has joined #openstack-neutron17:18
*** ihrachyshka has quit IRC17:18
*** pcm_ has joined #openstack-neutron17:18
*** jobewan has joined #openstack-neutron17:18
marundougwig: The issues about pypi/requirements aside, I think there is just as much opportunity for stabilization in-tree as out.17:19
dougwigthere is a matching etherpad, which just lists the paths forward without picking one.  i believe a summit session is planned for this.  is that more in line with what you're wanting?17:19
marundougwig: I think so, yes.17:19
dougwigok, let me make sure the in-tree option is in there.17:19
marundougwig: Have you considered that it should be possible to demarcate parts of the neutron tree that are safe to consume, and those that are not, and enforce with hacking rules in other projects?17:20
dougwigi'm not sure how much real work we can get done in kilo (the real work being the interface stabilization), just based on time.  getting the library plumbing setup in the meantime as a jumpstart was simply because most of that is sitting on your thumbs time.  the hard part is the work that you're alluding to.17:20
dougwigmarun: yes, but that seems like more hassle than just using a lib, IMO.17:21
marundougwig: I think that's understating the hassle of a lib, frankly, at least in the short-term.17:21
marundougwig: I get the sense that you've set your mind to wanting a lib as a goal.17:21
*** Tarun has quit IRC17:21
*** aepifanov has quit IRC17:21
marundougwig: I would encourage you to see libification as an implementation detail.17:22
marundougwig: There's more than one way to skin this cat.17:22
*** chlong has quit IRC17:22
marundougwig: not saying that it won't be the way we end up going17:22
marundougwig: just that it's by no means certain in the near term.17:22
marundougwig: and you can still get what you want without it17:22
dougwigok, so let's assume the repo exists, a skeleton, a 0.1 in pypi, and requirements is dealt with in the openstack/ projects.  the additional hassle at that point is that you have to move code when you refactor it from repo to repo instead of rename.  are there others?  the benefits can be: automatic checking for some interface tests, stricter hacking/lint17:23
dougwigrules, and a smaller piece for the docs folks to chew on at a time.17:23
dougwigas well as i think it'd be easier to apply stricter scrutiny in the new place.17:24
*** armax has quit IRC17:24
openstackgerritMerged openstack/neutron: Don't monkey patch netns_cleanup  https://review.openstack.org/15537317:25
*** jlanoux_ has quit IRC17:25
marundougwig: that is completely ignoring the cost to neutron17:26
marundougwig: I get that your goal is making things easier/better for out-of-tree.17:27
marundougwig: but it makes neutron itself less understandable and harder to maintain.17:27
marundougwig: it splits reviewer effort17:27
*** raildo_ is now known as raildo17:28
marundougwig: again, there is nothing preventing doing the stabilization in the tree itself and ensuring that neutron remains coherent17:28
dougwigahh, interesting.  i was viewing it as easier for neutron, and adding greater focus to the servers/agents/ml2/etc.17:28
otherwiseguyhuh, several root_helper patches in the gate just came up CANCELED. Hadn't seen that before.17:28
marundougwig: to be fair, this is my gut instinct talking17:28
*** kawa2014 has quit IRC17:29
marundougwig: I can't pretend that I'm the voice of reason or anything.17:29
dougwigi viewed it as more of getting some of the uninteresting guts out of the core SDN controller stuff.17:29
*** leenheer has quit IRC17:29
*** leenheer has joined #openstack-neutron17:29
marundougwig: the irony being that we're contemplating splitting that stuff out entirely17:29
marundougwig: there's a summit session scheduled for vancouver17:30
dougwigthe ref impl one, or another?17:30
marundougwig: so it may be premature to move the common stuff out if we haven't decided that we want to separate out the stuff you're trying to save17:30
marunsave -> benefit17:30
marundougwig: ref17:30
marundougwig: again, I don't want to block any work that stabilizes the parts of neutron that out-of-tree depends on17:32
*** tiswanso has quit IRC17:33
*** dane_leblanc has quit IRC17:33
*** tiswanso_ has joined #openstack-neutron17:34
*** matrohon has quit IRC17:34
openstackgerritCarl Baldwin proposed openstack/neutron: Introduce External IPAM Interface  https://review.openstack.org/13433917:34
*** _cjones_ has joined #openstack-neutron17:36
*** anish_ has joined #openstack-neutron17:36
*** ivar-lazzaro has joined #openstack-neutron17:37
*** manishg has joined #openstack-neutron17:37
*** manishg has quit IRC17:37
carl_baldwinmiguel: ping17:37
openstackgerritMohammad Banikazemi proposed openstack/neutron: Combining sec groups member update RPC calls  https://review.openstack.org/15514517:37
*** seizadi has quit IRC17:38
*** seizadi1 has joined #openstack-neutron17:38
*** manishg has joined #openstack-neutron17:38
*** ronis has joined #openstack-neutron17:38
derekhOk, I gotta run, we've pull reverts for both of those regressions into tripleo, but it would be great to get a perminant fix https://review.openstack.org/#/c/156853/ https://review.openstack.org/#/c/157063/17:38
*** ivar-laz_ has joined #openstack-neutron17:39
derekhThe two commits with the regressions are https://review.openstack.org/#/c/153729/ and https://review.openstack.org/#/c/141044/17:39
derekhI don't have irc handles for people involved17:39
*** EmilienM is now known as EmilienM|afk17:40
derekhAnd the bugs are here https://bugs.launchpad.net/tripleo/+bug/1423228 https://bugs.launchpad.net/tripleo/+bug/142183517:40
openstackLaunchpad bug 1423228 in tripleo "L3 agent for nova compute could not be found" [Critical,Triaged] - Assigned to Derek Higgins (derekh)17:40
*** britthou_ has quit IRC17:40
openstackLaunchpad bug 1421835 in neutron "Timeout reached while waiting for callback for node" [Undecided,In progress] - Assigned to Derek Higgins (derekh)17:40
*** dane_leblanc has joined #openstack-neutron17:41
*** ivar-lazzaro has quit IRC17:42
*** ollivier has joined #openstack-neutron17:42
*** harlowja_away is now known as harlowja_17:42
*** rushil has joined #openstack-neutron17:43
*** anshul has joined #openstack-neutron17:43
*** shivharis has joined #openstack-neutron17:43
*** seizadi1 has quit IRC17:43
*** seizadi has joined #openstack-neutron17:44
*** shaohe_feng has quit IRC17:44
kfox1111ok, so its definately the server that's schedualing the floating ip to the wrong router. the client never passes that information.17:44
kfox1111having a real hard time figuring out where it actually gets schedualed though. :/17:44
*** ygbo has quit IRC17:44
*** manishg has quit IRC17:44
*** shivharis has quit IRC17:45
*** manishg has joined #openstack-neutron17:45
openstackgerritCarl Baldwin proposed openstack/neutron: WIP Move port processing to router classes  https://review.openstack.org/15451317:46
*** s3wong has quit IRC17:47
*** _cjones_ has quit IRC17:48
*** _cjones_ has joined #openstack-neutron17:48
*** dasm has joined #openstack-neutron17:49
*** derekh has quit IRC17:49
*** hjensas has quit IRC17:49
*** pcm_ has quit IRC17:50
*** Sukhdev has quit IRC17:50
*** aepifanov has joined #openstack-neutron17:51
*** suresh12 has joined #openstack-neutron17:52
*** thedodd has quit IRC17:54
*** garyk has quit IRC17:54
openstackgerritKobi Samoray proposed openstack/neutron: VMWare NSXv: id fields should be nullable  https://review.openstack.org/15708417:55
*** annegentle has joined #openstack-neutron17:55
*** annegentle has quit IRC17:56
*** annegentle has joined #openstack-neutron17:56
openstackgerritCarl Baldwin proposed openstack/neutron: Get rid of rpc to fetch fip agent port on agent.  https://review.openstack.org/15373517:59
*** SumitNaiksatam has joined #openstack-neutron18:00
*** jorgem has joined #openstack-neutron18:01
*** morgabra has quit IRC18:02
*** morgabra has joined #openstack-neutron18:02
openstackgerritBrian Haley proposed openstack/neutron: Add support for a public endpoint url  https://review.openstack.org/15708718:02
*** aranjan has joined #openstack-neutron18:02
*** flaviof has joined #openstack-neutron18:04
*** absubram has joined #openstack-neutron18:06
*** dsneddon has joined #openstack-neutron18:08
*** bobmel has quit IRC18:10
*** ivar-laz_ has quit IRC18:10
*** bobmel has joined #openstack-neutron18:10
*** ivar-lazzaro has joined #openstack-neutron18:10
*** yamahata has quit IRC18:12
*** stefanb has quit IRC18:14
*** pradipta has quit IRC18:14
*** vishwanathj has joined #openstack-neutron18:15
*** jkyle1 has joined #openstack-neutron18:16
*** krtaylor has quit IRC18:16
*** ParsectiX has quit IRC18:16
*** lazy_prince is now known as killer_prince18:17
kfox1111hmm... so the table that stores the info is floatingips.router_id18:17
kfox1111its set wrong there too.18:17
*** ParsectiX has joined #openstack-neutron18:17
kfox1111but that would explain why older entries still work, since they were schedualed to the right routers already.18:17
openstackgerritJuergen Brendel proposed openstack/neutron: ARP spoofing patch: Low level ebtables integration  https://review.openstack.org/14113018:18
openstackgerritJuergen Brendel proposed openstack/neutron: ARP spoofing patch: Data structures for rules.  https://review.openstack.org/15709718:18
*** ParsectiX has quit IRC18:19
*** ParsectiX has joined #openstack-neutron18:19
*** haleyb has quit IRC18:19
otherwiseguyHenryG: mestery: Ok, https://review.openstack.org/#/c/156690/ take 2 has passed checks.18:19
HenryGotherwiseguy: great!18:20
*** zz_avozza is now known as avozza18:21
*** leenheer has quit IRC18:21
kfox1111ok, is this the schedualing code here? /usr/lib/python2.7/site-packages/neutron/db/l3_db.py:def _get_router_for_floatingip18:22
*** jamespd has quit IRC18:23
*** johnbelamaric has joined #openstack-neutron18:23
mesteryotherwiseguy: Looks good! dougwig: See ^^^ from otherwiseguy.18:24
*** seizadi1 has joined #openstack-neutron18:24
otherwiseguyHenryG: it's especially good because neutron-vpnaas is currently broken without it. (oops)18:24
*** seizadi has quit IRC18:24
otherwiseguyAs evidenced by ihar's 156602,4 patch failing because of the root_helper change in the iptables stuff.18:25
HenryGotherwiseguy: dougwig's neutron-lib can't get here fast enough18:25
mesterylol18:25
* otherwiseguy is not sure he would have started the root_helper removal stuff it he had known exactly how much of a pita it was18:26
otherwiseguy:p18:26
dougwigHenryG: why are you only +1 on that patch?18:27
HenryGdougwig: I am not *aas core18:27
dougwigah, missed that.18:27
* otherwiseguy disappears for a quick lunch18:28
*** maishsk has quit IRC18:28
pc_motherwiseguy: HenryG Just seeing all this... is this the sequencing of commits for root_helper removal? VPN change is needed before Neutron.18:28
*** maishsk has joined #openstack-neutron18:28
*** ParsectiX has quit IRC18:28
otherwiseguypc_m: some changes before, some after.18:29
*** maishsk has quit IRC18:29
*** vivek-ebay has joined #openstack-neutron18:29
pc_mI can review vpn, which commit?18:29
*** amuller has joined #openstack-neutron18:29
*** ParsectiX has joined #openstack-neutron18:29
kfox1111ok. I have a diff of the icehouse/juno snippet of the schedualer in https://bugs.launchpad.net/neutron/+bug/1422476. Can someone take a look and see if that may be the bug?18:29
openstackLaunchpad bug 1422476 in neutron "floating ip scheduled to wrong router" [Undecided,New]18:29
otherwiseguyI missed the Iptables dependency mattering, so should have done a little better on the order. pc_m 156609, but it is now in gate.18:29
HenryGpc_m: there was a minor mishap, but it's got +A now18:29
*** maishsk has joined #openstack-neutron18:30
pc_mHenryG: Yeah. I noticed problems yesterday with Jenkins failing in VPN repo.18:30
* otherwiseguy really disappears for lunch before he gets in trouble with Sarah18:30
mesterypc_m: I just merged the Vyatta VPN driver, FYI. Looked good to me, they even had (minimal) CI running VPN API tests which passed ;)18:30
pc_mmestery: Great, it looked good to me.18:30
mesterypc_m: Cool18:30
pc_mmestery: HenryG I've been seeing other oddities with VPN testing lately. Mentioned to Dooug, but I don't think we every isolated the problem18:31
mesterypc_m: Yikes!18:31
pc_mShort version... commit to Neutron that broke VPN, fix committed to VPN on 2/12. Another VPN patch didn't rebased, but pushed up a change. It PASSED Jenkins!18:32
pc_mI pulled the patch down and ran it, and it failed. It didn't have the 2/12 fix. I rebased, and it passed tests.18:32
pc_mI have no idea why Jenkins passed on that code.18:33
HenryGpc_m: I think the gate sometimes inserts dependencies to sequence jobs18:34
HenryGpc_m: You can see it in zuul, the dots linked with lines18:34
pc_mHenryG: So it applied the 2/12 fix to the commit that was upstreamed?18:34
amullercarl_baldwin: Hey Carl, could you ping Rajeev please?18:34
*** britthouser has joined #openstack-neutron18:34
amullercarl_baldwin: about https://bugs.launchpad.net/neutron/+bug/142149718:35
openstackLaunchpad bug 1421497 in neutron "Gateway clear generates a TRACE - AttributeError in get_int_device_name in DVR routers" [Undecided,In progress] - Assigned to Rajeev Grover (rajeev-grover)18:35
carl_baldwinamuller: Let me see if I can locate him.  Gotta fire up Lync.18:35
HenryGpc_m: depends on what was in the gate at the time. Hard to tell afterwards.18:36
pc_mThe patch was pushed on 2/15 and did not have the 2/12 fix.18:36
pc_mHenryG: https://review.openstack.org/#/c/144391/ patch 318:37
pc_mHenryG: It passed gate-neutron-vpnaas-python27, but if you try that code in a local repo, it fails18:37
* pc_m a scary false negative18:38
*** haleyb has joined #openstack-neutron18:38
*** maishsk has quit IRC18:38
carl_baldwinamuller: I’ve sent a ping.18:39
pc_mHenryG: BTW, do you know, if I change a file in local neutron repo, and then run UT in vpn repo, will it "see" those changes? Do I have to do a setup.py install to see them? Change requirements.txt to point to local repo?18:39
amullercarl_baldwin: Thank you18:39
amullercarl_baldwin: If I understand correctly my fix introduced another regression18:40
*** dane_leblanc has quit IRC18:40
pc_mHenryG: VPN uses an egg for Neutron. Wondering how that all works together.18:40
amullerwith that DVR gateway removal business18:40
HenryGpc_m: I think dougwig is the person to ask that18:41
pc_mHenryG: OK.18:42
*** SridharRamaswamy has quit IRC18:43
*** s3wong has joined #openstack-neutron18:43
pc_mmestery: Can you look at https://review.openstack.org/#/c/155889/?18:43
amullercarl_baldwin: The chain goes: 1) https://review.openstack.org/#/c/151882/1/neutron/agent/l3/agent.py, 2) https://review.openstack.org/#/c/155813/6/neutron/agent/l3/agent.py, and now 3) https://review.openstack.org/#/c/156357/5/neutron/agent/l3/agent.py18:43
*** dane_leblanc has joined #openstack-neutron18:43
mesterypc_m: Looking18:43
pc_mmestery: Thank you18:43
*** jkyle1 has quit IRC18:44
mesterypc_m: +2/+A18:44
*** Rajeev_ has joined #openstack-neutron18:45
pc_mmestery: Thanks!18:45
openstackgerritMerged openstack/neutron: tests: monkey patch stdlib before importing other modules  https://review.openstack.org/15322518:48
*** seizadi1 has quit IRC18:50
*** seizadi has joined #openstack-neutron18:50
*** tomoe_ has quit IRC18:51
jckaspermarun: ping18:51
marunjckasper: hi18:51
jckaspermarun: running into tox issues with a recent patch of yours18:52
marunjckasper: I'm guessing it's giving you an error about dsvm-functional?18:52
openstackgerritMerged openstack/neutron: Monkey patch all the code inside neutron/cmd/eventlet/...  https://review.openstack.org/15694218:52
jckaspermarun:  yep.18:52
marunjckasper: if you rebase, you should get an error that tells you that a newer version of tox is required18:52
marunjckasper: the fix for setting tox minversion merged yesterday18:53
*** saju_m has joined #openstack-neutron18:53
jckaspermarun:  breaking the auto-rebase logic.  ok.  thanks18:53
*** krtaylor has joined #openstack-neutron18:53
marunjckasper: breaking the auto-rebase logic?18:53
jckaspermarun: internal rebuild of kilo18:53
marunjckasper: ah, ok18:53
jckaspermarun: do you have patch # for yesterday's fix ?18:54
marunjckasper: just a second18:54
marunjckasper: 71ea690727e0006b02e86c901e7efc2d2c1fff7018:54
jckaspermarun: Thanks18:55
marunjckasper: oh, did you mean gerrit or git id?18:55
marunthat's the git id18:55
jckaspermarun: gerrit, preferably18:55
marunjckasper: I56313d0a22dbc4007142b8bb4890d1ac8bebff9418:55
*** achanda has joined #openstack-neutron18:56
*** anish_ has quit IRC18:56
*** seizadi has quit IRC18:57
*** seizadi1 has joined #openstack-neutron18:57
openstackgerritSwaminathan Vasudevan proposed openstack/neutron: Fix static strings with labels for DVR  https://review.openstack.org/14356818:57
*** avozza is now known as zz_avozza18:58
*** armax has joined #openstack-neutron18:58
*** nlahouti has quit IRC19:00
*** a_le has quit IRC19:02
*** EmilienM|afk is now known as EmilienM19:02
*** zhhuabj has quit IRC19:02
*** beagles is now known as beagles_brb19:02
*** rushil has quit IRC19:03
*** nlahouti has joined #openstack-neutron19:04
*** a_le has joined #openstack-neutron19:05
*** rms_13 has joined #openstack-neutron19:06
*** stanzgy has joined #openstack-neutron19:06
*** trad511 has quit IRC19:06
*** pradk has quit IRC19:07
*** annegentle has quit IRC19:08
*** tiswanso_ has quit IRC19:09
*** SridharRamaswamy has joined #openstack-neutron19:09
*** tiswanso_ has joined #openstack-neutron19:10
*** stanzgy has quit IRC19:10
openstackgerritCarl Baldwin proposed openstack/neutron: WIP Move port processing to router classes  https://review.openstack.org/15451319:11
*** carl_baldwin has quit IRC19:11
*** suresh12 has quit IRC19:13
*** achanda has quit IRC19:14
*** zhhuabj has joined #openstack-neutron19:14
*** nyechiel has quit IRC19:16
*** spandhe has joined #openstack-neutron19:17
*** beagles_brb is now known as beagles19:17
*** jp_at_hp has quit IRC19:17
dougwigpc_m: no, it will not see those changes.  you can modify tox.ini to pull a gerrit branch/review instead of master if you want to test together.19:17
*** anshul has quit IRC19:18
*** trad511 has joined #openstack-neutron19:20
*** nlahouti has quit IRC19:20
*** achanda has joined #openstack-neutron19:21
*** leenheer has joined #openstack-neutron19:21
*** leenheer has quit IRC19:22
*** moha_hunt has joined #openstack-neutron19:22
*** suresh12 has joined #openstack-neutron19:24
pc_mdougwig: So if I'm, say testing code from a review for VPN repo, and I want to make some changes in the neutron repo, how do I make sure vpn code sees the change?19:24
openstackgerritMerged openstack/neutron-vpnaas: Stop storing and passing root_helper  https://review.openstack.org/15669019:24
*** pradk has joined #openstack-neutron19:25
*** moshele has joined #openstack-neutron19:26
*** marun has quit IRC19:28
*** annegentle has joined #openstack-neutron19:29
*** Marga_ has quit IRC19:29
*** tiswanso_ has quit IRC19:29
*** Marga_ has joined #openstack-neutron19:30
openstackgerritSridhar Ramaswamy proposed openstack/neutron-vpnaas: Implementation of Brocade Vyatta VPNaaS Plugin  https://review.openstack.org/15472019:30
*** inara` has joined #openstack-neutron19:30
*** raginbaj- has joined #openstack-neutron19:30
*** trad511 has quit IRC19:30
*** leenheer has joined #openstack-neutron19:31
*** annegentle has quit IRC19:31
*** inara has quit IRC19:31
*** raginbajin has quit IRC19:31
*** SridharRamaswam1 has joined #openstack-neutron19:31
*** yarker has quit IRC19:31
*** raginbaj- is now known as raginbajin19:31
*** ivar-lazzaro has quit IRC19:32
*** SridharRamaswamy has quit IRC19:32
*** ivar-lazzaro has joined #openstack-neutron19:33
*** tflynn has joined #openstack-neutron19:33
*** dane_leblanc has quit IRC19:34
*** yarker has joined #openstack-neutron19:34
HenryGpc_m: 1. post a gerrit review for the neutron change19:44
*** tiswanso has joined #openstack-neutron19:45
HenryGpc_m: 2. Change the requirements.txt in vpnaas to point to the gerrit ref19:45
otherwiseguyHenryG: Looks like the linuxbridge patch after passing functional in check is failing for some reason in gate. Does this look familiar to you at all? https://jenkins07.openstack.org/job/gate-neutron-dsvm-functional/1554/console19:46
pc_mHenryG: Was hoping there wasn't such a heavy handed way to do that.19:46
otherwiseguyJust a random eventlet timeout.19:47
HenryGotherwiseguy: I hope it's not because of the eventlet patches that just got merged?19:48
openstackgerritManish Godara proposed openstack/neutron: ML2: remove underscore from public method  https://review.openstack.org/15712019:48
*** pc_m has quit IRC19:48
*** crc32 has joined #openstack-neutron19:48
*** nlahouti has joined #openstack-neutron19:49
otherwiseguyHenryG: passes locally when checked out with git-review. I'll rebase locally off of master and see what happens.19:50
HenryGotherwiseguy: I just tried it (rebased on master) and it fails same as gate :(19:52
*** pc_m has joined #openstack-neutron19:52
otherwiseguyHenryG: ugh. I got rid of the processutils.execute stuff to specifically avoid having to worry about eventlet changes. :19:52
otherwiseguy:-p19:52
* pc_m losst power for a sec19:52
*** Marga_ has quit IRC19:53
HenryGpc_m: I noticed a flicker19:53
*** Aish has joined #openstack-neutron19:53
openstackgerritIhar Hrachyshka proposed openstack/neutron-vpnaas: Remove remaining root_helper references  https://review.openstack.org/15669119:53
openstackgerritMerged openstack/neutron-vpnaas: VPNaaS Enable coverage testing for functional tests  https://review.openstack.org/15588919:54
pc_mHenryG: Was hoping it wasn't so heavy handed.  I'm trying to work on VPN, and just want to say, do some debug logging or slight change in neutron. Would rather not have to push a change to do that.19:54
*** dane_leblanc has joined #openstack-neutron19:55
*** ivar-laz_ has joined #openstack-neutron19:55
HenryGpc_m: Maybe dougwig has some tricks up his sleave19:55
*** ZZelle_ has joined #openstack-neutron19:57
HenryGotherwiseguy: shouldn't other patches be failing the functional job too?19:57
*** jorgem has quit IRC19:58
otherwiseguyHenryG: I just ran it locally rebased off master and it passed. Maybe it is sporadic? Maybe I'm just special? :)19:58
*** ivar-lazzaro has quit IRC19:58
HenryGotherwiseguy: recheck recheck recheck19:59
*** moshele has quit IRC20:01
*** ivar-laz_ has quit IRC20:04
*** ivar-lazzaro has joined #openstack-neutron20:05
*** cipcosma has quit IRC20:05
*** saju_m has quit IRC20:05
*** vishwanathj has quit IRC20:06
*** aix has quit IRC20:08
*** jprovazn has quit IRC20:08
*** achanda has quit IRC20:09
openstackgerritZengfa Gao proposed openstack/neutron: Use common agent.linux.utils.ensure_dir method  https://review.openstack.org/15410320:10
*** achanda has joined #openstack-neutron20:17
*** fandi has joined #openstack-neutron20:17
*** cipcosma has joined #openstack-neutron20:17
*** fandi has quit IRC20:18
*** maishsk has joined #openstack-neutron20:18
*** fandi has joined #openstack-neutron20:20
openstackgerritJustin Hammond proposed openstack/python-neutronclient: Client command extension support  https://review.openstack.org/14831820:22
openstackgerritMerged openstack/neutron: Get rid of rpc to fetch fip agent port on agent.  https://review.openstack.org/15373520:24
*** devlaps has quit IRC20:27
*** Sukhdev has joined #openstack-neutron20:27
*** manishg_ has joined #openstack-neutron20:28
openstackgerritBrian Haley proposed openstack/neutron: Add support for a public endpoint url  https://review.openstack.org/15708720:28
*** vivek-ebay has quit IRC20:29
*** manishg has quit IRC20:31
*** marun has joined #openstack-neutron20:33
openstackgerritJustin Hammond proposed openstack/python-neutronclient: Client command extension support  https://review.openstack.org/14831820:35
*** yfried_ has joined #openstack-neutron20:36
*** marun has quit IRC20:39
*** fandi has quit IRC20:39
*** yamahata has joined #openstack-neutron20:40
*** maishsk has quit IRC20:40
*** devlaps has joined #openstack-neutron20:44
*** moshele has joined #openstack-neutron20:45
*** shwetaap has joined #openstack-neutron20:47
*** jamespd has joined #openstack-neutron20:48
*** _cjones_ has quit IRC20:48
*** trad511 has joined #openstack-neutron20:48
*** shwetaap1 has quit IRC20:49
*** rotbeard has quit IRC20:52
*** vivek-ebay has joined #openstack-neutron20:53
dougwigpc_m: are you having to do double-repo changes that often?  if i may, what modules are affected?  might need some immediate refactoring.20:54
openstackgerritYanping Qu proposed openstack/neutron-vpnaas: Add IPSec encap mode validation to Cisco VPNaas  https://review.openstack.org/15714521:02
*** banix has quit IRC21:03
*** ParsectiX has quit IRC21:03
*** ParsectiX has joined #openstack-neutron21:04
pc_mdougwig: I'm trying to debug the issue with neutron_vpnaas.conf and 2x loading service driver. To do that, I'm running VPN UTs in a debugger.21:04
*** aix has joined #openstack-neutron21:04
pc_mdougwig: What I'd like to do, is add a LOG.debug and other things, in the neutron code that is called, but I can't (normally), as it is not picking up the change.21:05
pc_mdougwig: Looks like the UT uses TOX.INI that gets neutron egg from github.21:05
pc_mdougwig: What I have been able to do... is go to .tox/py27/... and tweak the neutron files there.21:06
pc_mdougwig: Was hoping there was some way to, when running UTs for VPN, be able to use neutron files from my local repo.21:06
*** jorgem has joined #openstack-neutron21:06
dougwighmm, you'd have to run them outside tox (the venv.)21:07
pc_mdougwig: Is there a way to tell tox to use a local repo vs repo (egg) from github?21:07
pc_mdougwig: Thinking out loud, like create an egg from local repo and use that somehow?21:08
*** matrohon has joined #openstack-neutron21:08
dougwigi think that's what runtests.sh without the venv is still used for in neutron.  in the service repos, not as they stand today.21:08
dougwigwell, if you cd into your neutron and do "pip install -e .", then it looks like an installed egg to anything else.21:08
dougwigbut you'll need to run the tests outside the venv.21:09
*** cipcosma has quit IRC21:10
pc_mdon't think I've every used runtests.sh21:10
pc_mdougwig: Does runtests.sh run w/o venv?21:11
openstackgerritRajeev Grover proposed openstack/neutron: fix for _get_external_device_interface_name trace  https://review.openstack.org/15635721:11
dougwigpc_m: there is a flag for it to do so, yes.21:11
*** moshele has quit IRC21:12
*** _cjones_ has joined #openstack-neutron21:14
pc_mdougwig: Will have to peek into that.21:14
*** johnbelamaric has quit IRC21:14
*** johnbelamaric has joined #openstack-neutron21:14
*** vivek-ebay has quit IRC21:14
pc_mdougwig: I wonder if in tox.ini I can specify deps =local-repo somehow (says it can be URL or FILE)21:15
dougwigyep, you could even have it pull from an env var if it's set.21:15
*** rotbeard has joined #openstack-neutron21:16
pc_mdougwig: Know the syntax? I can't seem to find it. Was wondering if I could create an egg and then point to that?21:17
dougwigmore runtests.sh21:18
dougwig-N21:18
dougwigoh, for the tox thing?  i'd have to google it.21:18
*** aranjan has quit IRC21:19
clarkbdeps= is anything you can feed to pip21:19
pc_myeah, googling, but not finding.21:19
clarkblocal repo is alawys installed21:19
clarkbbut you can say deps=. too21:19
pc_mclarkb: thanks. Will look at what pip takes :)21:19
clarkbwe did that somewhere for some reason21:19
clarkbI think pbr if you want an example21:19
pc_mclarkb: I'm in neutron_vpnaas repo, and want to use local neutron repo in dependencies (instead of github)21:20
*** aranjan has joined #openstack-neutron21:20
openstackgerritIhar Hrachyshka proposed openstack/neutron-vpnaas: Explicitly monkey patch VPN agent  https://review.openstack.org/15660221:21
*** zhenq has quit IRC21:21
*** SumitNaiksatam has quit IRC21:21
*** SumitNaiksatam has joined #openstack-neutron21:22
pc_mclarkb: Looking for a way to tweak files in neutron repo, and be able to access those (local) changes, from neutron_vpnaas repo21:22
clarkbjust have something else install neutron with your changes?21:23
pc_mclarkb: Thinking maybe I could do that with deps= in tox.ini somehow.21:23
pc_mclarkb: Sorry, didn't follow that.21:24
clarkbwhenever you make neutron changes just install them to whatever env you need them21:24
clarkbkeep in mind that tox won't update things so isn't a great solution unless you don't change much21:24
*** jorgem has quit IRC21:25
pc_mclarkb: Ah. so, make the change and install into my .tox/py27/src/ area?21:25
pc_mclarkb: How do I do the install?21:25
clarkbpc_m: yup .tox/py27/bin/pip install -U $pathtoneutron21:26
*** seizadi has joined #openstack-neutron21:26
pc_mclarkb: Awesome!21:26
*** seizadi1 has quit IRC21:26
*** jordandh has quit IRC21:27
pc_mclarkb: That is perfect! Exactly what I wanted to do. Thanks!21:30
*** carl_baldwin has joined #openstack-neutron21:31
*** banix has joined #openstack-neutron21:32
*** jordandh has joined #openstack-neutron21:32
*** vivek-ebay has joined #openstack-neutron21:32
*** nmagnezi has joined #openstack-neutron21:33
pc_mdougwig: On this conf file loading issue... Where is cfg.CONF.config_dir set?21:35
*** jpena has quit IRC21:38
*** baoli has quit IRC21:38
*** nmagnezi has quit IRC21:38
*** manishg_ has quit IRC21:39
*** dasm has quit IRC21:39
openstackgerritMatthew Thode proposed openstack/neutron: replaces enumeration method used to get a list of interfaces  https://review.openstack.org/15412821:40
*** tiswanso has quit IRC21:41
*** seizadi has quit IRC21:41
*** seizadi has joined #openstack-neutron21:41
amullerotherwiseguy: Do you remember (Or anyone else) the tag I put in a commit message if I want my patch to depend on a patch from another repo?21:42
openstackgerritCarl Baldwin proposed openstack/neutron: Move Floating IP processing to Router classes  https://review.openstack.org/14286321:42
amullerOr a link for more information about that new feature?21:42
openstackgerritMerged openstack/neutron: Update midonet plugin requirements  https://review.openstack.org/15691221:42
otherwiseguyamuller: Depends-On:21:42
otherwiseguy${change_id}21:43
amullerotherwiseguy: Would this allow me to make changes in oslo rootwrap, and have a patch in neutron use those changes, without the oslo patch being merged?21:43
amuller(I want to debug some rootwrap filtering crap)21:43
otherwiseguyamuller: yes.21:43
* amuller does a little dance21:43
amullerotherwiseguy: Thanks, I'll try that21:44
otherwiseguyamuller: I have noticed on the VPNaaS repo, the py27 test seems to check out from neutron master and use that so even though Depends-On: pulls in the neutron patch, it doesn't actually use it during the test. (I *think*)21:44
otherwiseguyBut the neutron tests I've seen seem to look like Depends-On is "doing the right thing".21:45
amullerOK we'll see21:45
*** Rajeev_ has quit IRC21:45
*** suresh12 has quit IRC21:46
carl_baldwinmlavalle: ping21:46
mlavallecarl_baldwin: pong21:47
carl_baldwinmlavalle: I was just resolving merge conflicts and wondered if you were actively working on https://review.openstack.org/#/c/147744/2021:47
carl_baldwinmlavalle: If not, I could take a crack at the conflicts.21:47
mlavallecarl_baldwin: I am not at this instant but I will over the next hour or so. I am aware it is outdated21:48
carl_baldwinmlavalle: I’ve also notice you’ve uploaded a few new patch sets for the patch before it.  I wondered if that was on purpose or if that was due to “git review” rebasing them together.21:49
*** claudiub has joined #openstack-neutron21:49
mlavallecarl_baldwin: sorry.... ;-( I now realize I forgot your advice as far as not rebasing. I won't forget this time around21:50
mlavallecarl_baldwin: it was git review rebasing21:50
carl_baldwinmlavalle: No worries, it happens.  I know what to do if things go badly.  Fortunately, I don’t think anything went badly this time around because I was through addressing feedback on the patch.21:51
*** trad511 has quit IRC21:51
*** jamielennox|away is now known as jamielennox21:51
carl_baldwinmlavalle: the conflict on your patch was trivial.  I’m uploading now...21:51
openstackgerritCarl Baldwin proposed openstack/neutron: Refactor management of namespaces in the L3 Agent  https://review.openstack.org/14774421:51
carl_baldwinmlavalle: ^21:51
*** tomoe_ has joined #openstack-neutron21:52
mlavallecarl_baldwin: I expected so. it ws the same last night. That is why I wasn't so worried about it21:52
*** tomoe__ has joined #openstack-neutron21:53
*** tomoe_ has quit IRC21:53
mlavallecarl_baldwin: now that we are talking, I made a comment in PS 18 in dvr_snat_ns.py. Have you had a chance to look at it? Any advice?21:55
*** trad511 has joined #openstack-neutron21:55
carl_baldwinmlavalle: looking...21:56
carl_baldwinmlavalle: Let’s just leave it for another patch.  I’m happy with the progress this patch has made.21:57
*** tomoe__ has quit IRC21:58
mlavallecarl_baldwin: the other question is amuller suggested to add some functional testing for the namespace manager (the conext manager that handles the namespaces clean up). I think it is a good idea. Should it be part of this patchset or should I create a follow up patchset?21:59
amullermlavalle: Patches should contain the tests in the patch itself22:00
amullerI *highly* dislike testing after the fact22:00
mlavalleamuller: thanks for the guidance :-)22:01
amullermlavalle: To explain my position a bit - People often forget, often innocently, to add the tests via a follow up patch, or as a task it just takes a much lower priority since you have a million fires to put out at any given moment22:02
amullermlavalle: We could also slip in regressions by the time your tests merge22:02
amullerAnd since this area is changing so fast these days...22:02
mlavalleamuller: I totally agree..... thanks for taking the time to comment (and the reviews)22:03
amullerwe're introduced multiple regressions in the DVR / FIP / namespaces area in the last couple of weeks22:03
amullerwe've*22:03
*** aranjan_ has joined #openstack-neutron22:03
openstackgerritKevin Fox proposed openstack/neutron: Fixes regression with multiple external routers and floating ips.  https://review.openstack.org/15716722:05
*** aranjan has quit IRC22:05
amullermlavalle: ^ There ya go :)22:05
*** aranjan has joined #openstack-neutron22:06
*** aranjan_ has quit IRC22:06
*** karimb has joined #openstack-neutron22:08
mlavalleamuller: now that we are talking, in https://review.openstack.org/#/c/147744/18/neutron/agent/l3/namespaces.py you suggested removing method _get_ns_name. I left that method only to be able to patch it in the functional test. It is not used anywhere else. But I don't find a way to handle namespaces names in test_ha_router_failover in the functional test22:08
*** kfox1111 has quit IRC22:08
amullermlavalle: I'll take a look22:08
mlavalleamuller: thanks :-)22:08
*** changbl has quit IRC22:09
*** Marga_ has joined #openstack-neutron22:13
carl_baldwinmlavalle: Either way would be fine for me.22:13
*** Marga_ has quit IRC22:13
mlavallecarl_baldwin: thanks22:13
*** Marga_ has joined #openstack-neutron22:13
*** moshele has joined #openstack-neutron22:13
*** seizadi has quit IRC22:14
*** seizadi has joined #openstack-neutron22:15
openstackgerritRob Pothier proposed openstack/neutron: Add MTU selection to ML2 and OVS MD  https://review.openstack.org/15631822:15
*** seizadi1 has joined #openstack-neutron22:15
*** seizadi has quit IRC22:15
*** Rajeev has joined #openstack-neutron22:16
*** baoli has joined #openstack-neutron22:20
*** ronis has quit IRC22:22
amullermlavalle: I think the solution is similar to what exists on HEAD, you define a TestAgent and a TestRouterNamespace class22:23
amullerthe TestRouterNamespace class overrides RouterNamespace.__init__22:23
*** ParsectiX has quit IRC22:23
amullerallowing you to remove _get_ns_name22:23
*** ParsectiX has joined #openstack-neutron22:24
amullermlavalle: and we'd have to override the creation of RouterNamespace as well22:24
amullerwhich would imply the introduction of a factory method of RouterNamespace22:25
*** pc_m has quit IRC22:25
amullerbecause right now its created in RouterInfo.__init__, in the middle of it, that's hard to override22:25
mlavalleamuller: correct, that is where I got stuck...22:25
amullerit's possible to add a class method to RouterNamespace that would return an instance of itself22:26
amullerthen we override that in the test code22:26
mlavalleI had thought of a TestRouterNamespace, but didn't get to the factory method. That factory method exists purely for testing purposes, right?22:27
mlavalleamuller: ^^^22:27
amullerit would be used in the real code, and overridden in the test code22:27
*** trad511 has quit IRC22:27
*** Sukhdev has quit IRC22:27
*** jordandh has quit IRC22:27
amullermlavalle: this isn't ideal either because as you said you wouldnt write a factory method if you didnt have this weird test requirement, but I think that overal this approach is better22:28
amullerbecause you don't have that static get_ns_name that you don't need22:28
amullermlavalle: would it be possible to get rid of that static method for the FIP namespace and SNAT namespace classes as well?22:28
mlavalleamuller: yeah, the factory method could be used in the real code. But we don't need to, right?22:29
openstackgerritCarl Baldwin proposed openstack/neutron: WIP Move port processing to router classes  https://review.openstack.org/15451322:29
amullermlavalle: well you'd have to I think22:29
amullerotherwise what good would it do to override it, if it isn't actually used when creating a router22:29
amullermlavalle: reading your comment here btw: https://review.openstack.org/#/c/147744/18/neutron/agent/l3/dvr_snat_ns.py22:29
mlavalleamuller: Yes, we can remove the static method in SNAT namespace as well22:29
*** jordandh has joined #openstack-neutron22:30
*** achanda has quit IRC22:30
amullermlavalle: yiykes, you're saying the SNAT namespace and interface is created twice22:31
*** jckasper has quit IRC22:31
*** marun has joined #openstack-neutron22:33
openstackgerritJulien Anguenot proposed openstack/neutron: Neutron pydevd debugger support  https://review.openstack.org/12654622:35
mlavalleamuller: the snat namespace and the internal interface are created twice. Even worst, the first creation in internal_network_added happens "behind the scenes" when the OVS interface driver plugs the interface and doesn't find the namespace22:36
openstackgerritJustin Hammond proposed openstack/python-neutronclient: Client command extension support  https://review.openstack.org/14831822:36
*** signed8b_ is now known as signed8bit_ZZZzz22:36
amullermlavalle: yeah I get the same looking at the code, that's so weird22:36
amullermlavalle: Maybe you could ask Rajeev about this22:37
mlavalleamuller: when we get to external_gateway_added, it calls again _internal_network_added and connects againg the interface, after explicitely creating the namespace22:38
mlavalleamuller: ok, I'll follow up with him. Thanks for the time and advice22:38
amullermlavalle: But, back to our problem, we have a general problem of wanting a namespace name before the Namespace class is instantiated22:38
amullermlavalle: maybe we could eliminate this specific usage, I don't know, but the problem remains22:38
*** localloop127 has quit IRC22:39
mlavalleamuller: correct, that is the conumdrum. In my opinion, in internal_network_added we should attempt to connect an internal interface if the namespace doesn't exist yet. That is a sign that the external router hasn't been added22:40
*** johnbelamaric has quit IRC22:40
mlavalleamuller: shouldn't attempt^^^22:40
mlavalleamuller: and therefore, we don't have the need for snat namespace yet. I will ask Rajeev and share back with you, either here or in gerrit22:42
amullermlavalle: I see that in the FipNamespace class there's a get_name method, but it's not a class/static method, and it uses internal state. This implies that no place in the code actually needs the FIP namespace name before its created22:42
mlavalleamuller: yes, the fip namespace is different22:43
*** baoli has quit IRC22:43
amullermlavalle: So for the regular RouterNamespace only the functional tests need that static method, for the SNATNamespace, is there any place other than the problematic place you found?22:43
amullerif we could get rid of these usages and end up removing the static accessors that'd be... Swell :)22:43
*** banix has quit IRC22:44
mlavalleamuller: it's only the problematic place and the functional test again....22:44
amullerok22:44
amullermlavalle: For the functional tests we have a plan at least22:44
amullerLet's see what Rajeev says about that weird usage22:44
mlavalleamuller: yes and i'll follow up with Rajeev22:45
mlavalleamuller: thanks for the time. very useful :-)22:45
amullerThanks for being open to suggestions! Most people aren't22:45
mlavalle:-)22:46
rms_13Has anybody lately run devstack and ran into neutron failure while attempting to create network. (with NoSuchOptError: no such option: policy_file)22:46
*** achanda has joined #openstack-neutron22:46
*** trad511 has joined #openstack-neutron22:46
*** rotbeard has quit IRC22:46
mlavalleamuller: I'll be 55 on 3/6.... I know I don't own the truth :-)22:46
*** matrohon has quit IRC22:47
amullermlavalle: Hah :)22:47
amullerDo you think you'll be coming to Vancouver?22:47
mlavalleamuller: I will. See you there...22:47
amullerSounds good :)22:47
*** moshele has quit IRC22:48
amullerWe must do another Neutron get together again, and get dougwig to pay for everyone again. I don't know but I like that idea.22:48
roaetdougwig pays for everyone? That's great!22:48
*** crc32 has quit IRC22:48
mlavalleamuller: +1 to that22:48
mlavalleI've always known dougwig is a great guy22:49
*** yamahata_ has quit IRC22:51
*** isq has joined #openstack-neutron22:51
*** jordandh has quit IRC22:54
*** baoli has joined #openstack-neutron22:55
*** tim_o has joined #openstack-neutron22:56
*** dane_leblanc has quit IRC22:57
tim_oI've setup a CI environment, and am in the process of getting log files posted.  Question: about how long will it take to get our CI accepted?  I've been triggering off Gerrit events for Neutron for some time now.23:00
*** trad511 has quit IRC23:00
*** openstackgerrit has quit IRC23:00
roaettim_o: I'm not sure about that one, but I know the #openstack-infra folk might be more able to answer that.23:00
*** openstackgerrit has joined #openstack-neutron23:00
*** matrohon has joined #openstack-neutron23:01
*** claudiub has quit IRC23:01
tim_owell, they actually pointed me this way...hmm23:01
clarkbright23:01
roaetoh.23:01
clarkbinfra has no say on which accounts vote on which projects23:01
clarkbthat is managed by the projects directly through their CI groups23:02
roaetthen i am definitely wrong, my apologies :(23:02
*** kbringard has quit IRC23:02
*** seizadi1 has quit IRC23:03
tim_oany idea on how I ping the Neutron CI group?  I've been looking for an email alias...23:04
*** carl_baldwin has quit IRC23:05
*** jordandh has joined #openstack-neutron23:06
clarkbtim_o: you want to ping the owners of that group which is neutron-release according to https://review.openstack.org/#/admin/groups/510,info neutron-release is https://review.openstack.org/#/admin/groups/150,members23:06
clarkbtim_o: worst case send mail to the dev list, tag it neutron, and ask there23:06
*** pradk has quit IRC23:08
*** matrohon has quit IRC23:09
anteayait is mestery and emagma23:09
anteayathose are the two neutron ci group members23:10
anteayaI believe23:10
dougwigtim_o: do you have a gerrit account for your CI?23:11
tim_othank you all!23:11
tim_oI have my own to receive the gerrit events, I request a CI account some time ago...not sure what happened to the request though23:12
tim_oas part of that request, my account was activated.  Using that to receive gerrit events to trigger builds for some weeks...23:12
dougwigthere's nothing official on the neutron side.  you need your CI gerrit account, to be posting results on gerrit reviews, have your info in the CI wikis, and note your CI in whatever plugin/driver you're reviewing that needs it, and then the reviewers will peek at it for conformance.23:12
clarkbtim_o: CI accounts are self service now, see http://ci.openstack.org/third_party.html#creating-a-service-account23:13
tim_oI did that, some time ago.  Cannot find it now though...23:13
dougwigyou need to solve that before anyone on the neutron side can verify your CI.  :)23:13
*** trad511 has joined #openstack-neutron23:13
tim_ohttp://ci.openstack.org/third_party.html#creating-a-service-account <-- did this, and have the emails also.  How best to proceed...any ideas?23:15
dougwigis your CI using that account, and posting results?23:15
*** hichihara has joined #openstack-neutron23:15
tim_oI was told to use my launchpad account for the CI...I was never given a CI (?)23:16
tim_oNot posting yet as I've been testing it out23:16
dougwigthat link you posted.  the account you got from that.  not your launchpad.23:16
tim_o'silent' from Jenkins standpoint23:17
dougwigwork on switching to using your CI account, which you self-registered, and then getting results posted.23:18
*** chlong has joined #openstack-neutron23:18
*** jordandh has quit IRC23:18
tim_oNot sure I ever received the CI account login.  Maybe best to re-submit the request?23:20
tim_oor will that cause issues?23:20
*** SumitNaiksatam has quit IRC23:20
rms_13Even after the refactoring of oslo library and corresponding changes in neutron, I see some occurance where we are using old oslo modules. For example, "from oslo.config import cfg"23:20
*** shwetaap1 has joined #openstack-neutron23:20
rms_13Isnt this a bug?23:21
*** jordandh has joined #openstack-neutron23:21
tim_oI will submit a CI request for Neutron, thanks again23:21
tim_oin the future I'll be doing CI builds other projects, can I use the same CI?23:23
*** matrohon has joined #openstack-neutron23:23
*** gildub has joined #openstack-neutron23:23
*** shwetaap has quit IRC23:24
*** trad511 has quit IRC23:25
*** karimb has quit IRC23:25
*** karimb has joined #openstack-neutron23:25
anteayatim_o: you don't recieve the ci login, you create it23:27
*** yamamoto has quit IRC23:27
*** yamamoto has joined #openstack-neutron23:28
tim_oThanks will create one here then.  It will need it's own email address in launchpad I assume.23:30
*** bobmel has quit IRC23:31
*** leenheer has quit IRC23:31
*** bobmel has joined #openstack-neutron23:31
*** trad511 has joined #openstack-neutron23:32
*** aranjan has quit IRC23:32
*** aranjan has joined #openstack-neutron23:34
dougwigit's own email, yes.  it does not need launchpad.23:34
*** csoukup has quit IRC23:34
*** MentalRay has quit IRC23:34
*** Aish has left #openstack-neutron23:34
*** leenheer has joined #openstack-neutron23:35
*** jordandh has quit IRC23:35
clarkbdougwig: it does actually, thats how you authenticate to the web ui to change things23:35
clarkblike ssh pubkeys23:35
clarkb(you log into gerrit with your lp openid to do that, changing ssh keys in lp itself won't change the keys in gerrit)23:36
*** ollivier has quit IRC23:36
*** yamamoto has quit IRC23:37
dougwigahh, that must be new?  i'm fairly certain i'm from the old days, and just never change things.  :)23:38
clarkbits part of being self service, we let the old accounts stay as they were and are directing folks that need updates to old accounts to follow the new self service process23:38
dougwiggotcha.23:39
dougwigtim_o: clarkb certainly has better answers than i do here.23:39
*** krtaylor has quit IRC23:40
*** karimb has quit IRC23:41
*** marun has quit IRC23:43
*** amuller has quit IRC23:45
*** dboik_ has quit IRC23:47
*** dims_ has joined #openstack-neutron23:49
*** johnbelamaric has joined #openstack-neutron23:49
*** dims__ has quit IRC23:51
anteayagus: are you around?23:52
*** aepifanov has quit IRC23:52
gusanteaya: yep.23:52
anteayahello23:52
anteayahow are you?23:53
gusSorry for missing the meeting btw - I was double booked and didn't realise until after I went into radio blackout.23:53
anteayanp23:53
*** matrohon has quit IRC23:53
anteayawanted to catch up with you23:53
anteayanova meeting is tomorrow and would like to have the latest status23:53
anteayawere you able to read the logs from the meeting?23:53
gusNot yet, it's the first thing on today's list.23:53
anteayaokay well I'll make a cup of tea23:54
anteayahow long before I bug you again?23:54
gus30mins should be fine.23:54
anteayasounds good23:54
anteayathank you23:54
*** tflynn_ has joined #openstack-neutron23:56
*** a_le has quit IRC23:56
*** jordandh has joined #openstack-neutron23:56
*** jobewan has quit IRC23:56
*** a_le has joined #openstack-neutron23:57
*** tflynn__ has joined #openstack-neutron23:57
*** a_le has quit IRC23:57
*** tflynn__ has quit IRC23:57
*** ivar-laz_ has joined #openstack-neutron23:58
*** tflynn__ has joined #openstack-neutron23:58
*** ivar-laz_ has quit IRC23:58
*** a_le has joined #openstack-neutron23:58
*** ivar-laz_ has joined #openstack-neutron23:58
*** tflynn has quit IRC23:59
*** ivar-lazzaro has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!