| opendevreview | Ade Lee proposed openstack/neutron-tempest-plugin master: WIP - testing adding key type for ecc keys https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/807660 | 01:06 |
|---|---|---|
| opendevreview | Ade Lee proposed openstack/neutron master: WIP/DNM - Add FIPS enabled jobs https://review.opendev.org/c/openstack/neutron/+/797537 | 02:34 |
| opendevreview | Merged openstack/neutron master: Don't use singleton in routes.middleware.RoutesMiddleware https://review.opendev.org/c/openstack/neutron/+/807335 | 02:39 |
| opendevreview | Slawek Kaplonski proposed openstack/neutron stable/wallaby: Don't use singleton in routes.middleware.RoutesMiddleware https://review.opendev.org/c/openstack/neutron/+/807632 | 06:09 |
| opendevreview | Slawek Kaplonski proposed openstack/neutron stable/victoria: Don't use singleton in routes.middleware.RoutesMiddleware https://review.opendev.org/c/openstack/neutron/+/807633 | 06:09 |
| opendevreview | Slawek Kaplonski proposed openstack/neutron stable/ussuri: Don't use singleton in routes.middleware.RoutesMiddleware https://review.opendev.org/c/openstack/neutron/+/807634 | 06:09 |
| opendevreview | Slawek Kaplonski proposed openstack/neutron stable/train: Don't use singleton in routes.middleware.RoutesMiddleware https://review.opendev.org/c/openstack/neutron/+/807635 | 06:10 |
| opendevreview | Slawek Kaplonski proposed openstack/neutron stable/stein: Don't use singleton in routes.middleware.RoutesMiddleware https://review.opendev.org/c/openstack/neutron/+/807636 | 06:10 |
| opendevreview | Slawek Kaplonski proposed openstack/neutron stable/rocky: Don't use singleton in routes.middleware.RoutesMiddleware https://review.opendev.org/c/openstack/neutron/+/807637 | 06:10 |
| opendevreview | Slawek Kaplonski proposed openstack/neutron stable/queens: Don't use singleton in routes.middleware.RoutesMiddleware https://review.opendev.org/c/openstack/neutron/+/807638 | 06:10 |
| opendevreview | Elvira García Ruiz proposed openstack/neutron master: Remove the 'port_object' unneeded parameter https://review.opendev.org/c/openstack/neutron/+/767186 | 07:26 |
| opendevreview | Merged openstack/ovsdbapp master: Add support for OVN NB Logical_Router_Policy table https://review.opendev.org/c/openstack/ovsdbapp/+/683355 | 07:51 |
| opendevreview | Slawek Kaplonski proposed openstack/neutron master: Use ovs constants from neutron-lib https://review.opendev.org/c/openstack/neutron/+/797120 | 07:54 |
| opendevreview | Slawek Kaplonski proposed openstack/neutron master: Remove ovs agent's common constants module https://review.opendev.org/c/openstack/neutron/+/797121 | 07:54 |
| slaweq | ralonsoh: lajoskatona: hi, can You take a look at https://review.opendev.org/c/openstack/neutron/+/797121/ and it's parent change when You will have some time? Thx in advance :) | 07:56 |
| ralonsoh | let me check | 07:56 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron-lib master: Improve "get_collection_count" method https://review.opendev.org/c/openstack/neutron-lib/+/807686 | 08:41 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron-lib master: Improve "get_collection_count" method https://review.opendev.org/c/openstack/neutron-lib/+/807686 | 08:42 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: Improve "get_collection_count" calls https://review.opendev.org/c/openstack/neutron/+/807687 | 08:50 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Update the DHCP options when the metadata port is modified https://review.opendev.org/c/openstack/neutron/+/807692 | 09:14 |
| opendevreview | Kevin Li proposed openstack/neutron master: update subport status when trunk/subport create/delete is triggerred https://review.opendev.org/c/openstack/neutron/+/807076 | 09:21 |
| opendevreview | Arkady Shtempler proposed openstack/neutron-tempest-plugin master: Refactoring - Use existing Tempest APIs in "QoS bandwidth limit rule" tests https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/806977 | 09:43 |
| slaweq | ralonsoh: can You maybe check https://review.opendev.org/c/openstack/neutron/+/799226 ? | 10:24 |
| slaweq | You already gave +1 to it, now zuul is +1 so maybe You can approve it? | 10:25 |
| ralonsoh | let me check | 10:25 |
| slaweq | ralonsoh: and also https://review.opendev.org/c/openstack/neutron/+/800059 if You have a minute | 10:26 |
| ralonsoh | ah yesm this one | 10:26 |
| ralonsoh | slaweq, https://review.opendev.org/c/openstack/neutron/+/800059 | 10:27 |
| ralonsoh | what happens if the range is /16 | 10:27 |
| ralonsoh | the number of ARP entries will be insane | 10:27 |
| slaweq | ralonsoh: with current patch it will just be skipped | 10:28 |
| slaweq | only /32 will be added to arp table | 10:28 |
| slaweq | https://review.opendev.org/c/openstack/neutron/+/800059/3/neutron/agent/l3/dvr_local_router.py#333 | 10:28 |
| slaweq | so basically neutron will behave the same way as before but without ugly stacktrace when e.g. /16 is added to the allowed_address_pairs | 10:28 |
| ralonsoh | slaweq, so I don't understand the patch | 10:29 |
| slaweq | because it will not try to add it to arp entries | 10:29 |
| ralonsoh | what if allowed address pairs is /16? | 10:29 |
| ralonsoh | or /24? | 10:29 |
| slaweq | ralonsoh: without that patch neutron l3 agent will try to add such /16 as 1 entry to arp table | 10:29 |
| ralonsoh | I know | 10:29 |
| slaweq | and that will fail as only single ip addresses can be added there | 10:29 |
| slaweq | and with that patch such /16 cidr will be skipped | 10:30 |
| ralonsoh | but I thought we were going to iterate over the network | 10:30 |
| slaweq | in first approach I tried that | 10:30 |
| ralonsoh | so we need to document this limtation | 10:30 |
| slaweq | but indeed it could be insane so I decided not to do that | 10:30 |
| slaweq | ralonsoh: ok, I can send follow up with docs update | 10:31 |
| ralonsoh | slaweq++ | 10:31 |
| slaweq | ralonsoh++ thx | 10:31 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Metadata ports device_owner is "network:distributed" only https://review.opendev.org/c/openstack/neutron/+/807707 | 11:44 |
| *** eagles_ is now known as eagles | 12:25 | |
| opendevreview | Merged openstack/neutron master: Agent RPC step size in config. https://review.opendev.org/c/openstack/neutron/+/802596 | 12:33 |
| opendevreview | Merged openstack/neutron master: [DVR] Fix update of the MTU in the SNAT namespace https://review.opendev.org/c/openstack/neutron/+/799226 | 12:33 |
| opendevreview | Lajos Katona proposed openstack/neutron master: CI: add experimental jobs to be executed with n-lib master https://review.opendev.org/c/openstack/neutron/+/807722 | 13:33 |
| lajoskatona | slaweq: Hi, could please you check these taas related patches: https://review.opendev.org/c/openstack/tap-as-a-service/+/803422 & https://review.opendev.org/c/openstack/tap-as-a-service/+/804707 if You have some time? | 13:34 |
| opendevreview | Slawek Kaplonski proposed openstack/neutron master: DVR: Populate ARP entries of the allowed_address_pairs to the routers https://review.opendev.org/c/openstack/neutron/+/601336 | 13:34 |
| lajoskatona | slaweq: if these are merged I think we can progress with the tests move to neutron-tempest-plugin: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/803752 | 13:35 |
| slaweq | lajoskatona: sure, I will check them in few minutes | 13:39 |
| lajoskatona | slaweq: thanks | 13:40 |
| opendevreview | Merged openstack/tap-as-a-service master: Use payload for PORT PRECOMMIT_DELETE event https://review.opendev.org/c/openstack/tap-as-a-service/+/803422 | 13:54 |
| opendevreview | Slawek Kaplonski proposed openstack/neutron stable/queens: [L3] Use processing queue for network update events https://review.opendev.org/c/openstack/neutron/+/803584 | 14:00 |
| slaweq | #startmeeting networking | 14:00 |
| opendevmeet | Meeting started Tue Sep 7 14:00:32 2021 UTC and is due to finish in 60 minutes. The chair is slaweq. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'networking' | 14:00 |
| slaweq | hi | 14:00 |
| mlavalle | o/ | 14:00 |
| ralonsoh | hi | 14:00 |
| haleyb | hi | 14:00 |
| elvira | hi | 14:00 |
| bcafarel | o/ | 14:01 |
| rubasov | o/ | 14:01 |
| liuyulong | hi there | 14:01 |
| lajoskatona | Hi | 14:01 |
| slaweq | ok, let's start | 14:02 |
| slaweq | #topic Announcements | 14:02 |
| slaweq | Xena cycle calendar https://releases.openstack.org/xena/schedule.html | 14:02 |
| slaweq | we are almost there | 14:02 |
| obondarev | hi | 14:02 |
| slaweq | last week we reached Xena-3 milestone and we did final release for python-neutronclient | 14:02 |
| slaweq | next week is Xena RC-1 week | 14:03 |
| slaweq | so we should focus now on bug fixes, not new RFEs | 14:03 |
| slaweq | next one | 14:03 |
| slaweq | October PTG | 14:03 |
| opendevreview | liuyulong proposed openstack/neutron-lib master: Leave *_ALL_TABLES to Neutron https://review.opendev.org/c/openstack/neutron-lib/+/807224 | 14:03 |
| slaweq | etherpad https://etherpad.opendev.org/p/neutron-yoga-ptg | 14:03 |
| slaweq | please add Your topics there :) | 14:04 |
| slaweq | and that are basically all announcements from me today | 14:04 |
| slaweq | anything else You want to announce/remind to the team? | 14:05 |
| slaweq | if not, let's move on | 14:06 |
| slaweq | #topic Blueprints | 14:06 |
| liuyulong | I have one. | 14:07 |
| slaweq | sorry liuyulong | 14:07 |
| slaweq | go on | 14:07 |
| liuyulong | Since, there is few people to attend neutron L3 meeting, maybe we can merge it to the team meeting. | 14:07 |
| slaweq | I'm fine with that | 14:08 |
| liuyulong | I had some one person meetings. : ) | 14:08 |
| ralonsoh | I'm ok with this | 14:08 |
| slaweq | but I think it's more decision of the "ptl elect" now :) | 14:09 |
| liuyulong | And I noticed that some bugs were discussed in team meeting as well. | 14:09 |
| lajoskatona | as I remember we touched this on one of the l3 meetings, I am fine with it | 14:09 |
| liuyulong | As in L3 meeting, we mostly are talking about bugs. : ) | 14:09 |
| slaweq | if there is nobody agains, I will add it as a topic in the team meeting and will propose removal of L3 subteam meeting | 14:10 |
| liuyulong | OK, I think we have a sonsensus then. : ) | 14:11 |
| mlavalle | +1 | 14:11 |
| slaweq | yes, thx liuyulong for bringing it up to the discussion | 14:11 |
| slaweq | let's get back to the BPs | 14:12 |
| liuyulong | s/consensus | 14:12 |
| slaweq | I already moved all not finished BPs from Xena-3 to neutron-next now | 14:12 |
| slaweq | as we agreed last week | 14:12 |
| slaweq | I don't think we have a lot to discuss about BPs today but if anyone has got any updates/questions, feel free to raise it now | 14:13 |
| slaweq | ok, I guess this means "no updates" for today | 14:14 |
| slaweq | so let's move on | 14:14 |
| slaweq | #topic Bugs | 14:14 |
| slaweq | haleyb: You were bug deputy, any bugs to discuss now? | 14:15 |
| haleyb | There was one critical bug i left off the email since i thought it was embargoed | 14:15 |
| haleyb | https://bugs.launchpad.net/neutron/+bug/1942179 | 14:15 |
| haleyb | but it's not now and the fix has merged | 14:15 |
| haleyb | guess the bot isn't working | 14:15 |
| haleyb | "neutron api worker leaks memory when processing requests to not existing controllers" | 14:16 |
| slaweq | its status is "fix released" now I see | 14:16 |
| haleyb | thanks for the fix slaweq :) | 14:16 |
| slaweq | and backports are proposed to stable branches also | 14:16 |
| slaweq | yw | 14:16 |
| slaweq | thx ralonsoh for help debugging that issue, it was funny one :) | 14:17 |
| ralonsoh | for sure | 14:17 |
| amotoki | I really wonder how you identified the cause of this | 14:17 |
| ralonsoh | slaweq found the cause and I debugged the issue, finding the leak in this evenlet local var | 14:18 |
| slaweq | amotoki: I was going through different places in code from stacktrace, starting where that log about 404 was logged | 14:18 |
| slaweq | we were trying various things but finally we narrowed it down by simple trying to skip parts of the code and seeing if issue still happens or not | 14:19 |
| slaweq | and if not, then going deeper there | 14:19 |
| haleyb | there was one bug about RBAC and SGs that might require discussion, or at least there was a question at the end so i'll raise it here | 14:20 |
| haleyb | https://bugs.launchpad.net/neutron/+bug/1942615 | 14:20 |
| haleyb | "SG shared through RBAC mechanism can't be used to spawn instances" | 14:20 |
| slaweq | thx haleyb :) | 14:20 |
| slaweq | actually I wanted to raise it here too | 14:20 |
| haleyb | slaweq: all yours | 14:21 |
| slaweq | please read the bug description, main question is there actually | 14:21 |
| slaweq | I was trying to explain it there but if something is not clear, please ask now :) | 14:21 |
| ralonsoh | I agree with not changing the API but adding an additional parameter (that implies a change in Nova and Neutron) | 14:21 |
| slaweq | there is also one more possibility which I didn't mentioned in the bug description | 14:22 |
| slaweq | but we discussed it yesterday with ralonsoh | 14:22 |
| slaweq | we can document, that if user wants to use shared SG, first he should create port with that SG using neutron API | 14:23 |
| amotoki | this issue sounds similar to a topic on all_projects=true/false behavior related horizon network listing dsicussed in the recent meetings | 14:23 |
| slaweq | and then pass port to the nova API | 14:23 |
| slaweq | that way no changes in code would be required | 14:23 |
| amotoki | tenant_id filter was added to nova due to listing with admin roles in neutron API | 14:23 |
| ralonsoh | amotoki, kind of, the goal is to list everything related to a single project but including the shared SGs to this project | 14:24 |
| amotoki | ralonsoh: exactly. perhaps I understand the problem | 14:24 |
| lajoskatona | To document to create port with SG sounds reasonable as for QoS the WoW is the same for minimum bandwidth | 14:25 |
| amotoki | tenant_id filter is used to avoid all SG from all projects when the API is called with admin role but it is not friendly with RBAC mechanism | 14:25 |
| slaweq | amotoki: that's true | 14:26 |
| amotoki | introducing all_projects filter to the listing API would work. when all_projects=false is specifed, the API can return all resources visible to the project (without admin-ness) | 14:28 |
| ralonsoh | but admin will see everything | 14:29 |
| amotoki | all_projects=true keeps the current behavior including specifying project_id/tenant_id filter. | 14:29 |
| ralonsoh | perfect then | 14:29 |
| ralonsoh | that could work, yes | 14:29 |
| slaweq | so in nova we would need to change request to be done with all_projects=false | 14:30 |
| slaweq | and without tenant_id filter | 14:30 |
| slaweq | right? | 14:30 |
| amotoki | slaweq: that is what in my mind | 14:30 |
| slaweq | that could work indeed | 14:31 |
| slaweq | but it will work only when ralonsoh will implement his "all_projects" RFE | 14:31 |
| slaweq | it was on you ralonsoh, right? | 14:31 |
| ralonsoh | ? | 14:31 |
| ralonsoh | not really | 14:31 |
| slaweq | hmm | 14:31 |
| slaweq | ok | 14:31 |
| slaweq | I think we discussed something similar recently | 14:32 |
| slaweq | wasn't that RFE? | 14:32 |
| slaweq | I will need to look for it in the meetings' logs | 14:32 |
| ralonsoh | sorry I'm lost here | 14:33 |
| amotoki | another solution is to allow users to query resources with shared=true (resources shared by RBAC) | 14:33 |
| ralonsoh | this is more explicit | 14:33 |
| opendevreview | Merged openstack/neutron stable/wallaby: Don't use singleton in routes.middleware.RoutesMiddleware https://review.opendev.org/c/openstack/neutron/+/807632 | 14:33 |
| opendevreview | Merged openstack/neutron stable/victoria: Don't use singleton in routes.middleware.RoutesMiddleware https://review.opendev.org/c/openstack/neutron/+/807633 | 14:33 |
| opendevreview | Merged openstack/neutron stable/ussuri: Remove dhcp_extra_opt value after first newline character https://review.opendev.org/c/openstack/neutron/+/806750 | 14:33 |
| amotoki | IIRC shared attribute is not avaialbe for all resources with RBAC support so it would be more straight-forward | 14:34 |
| opendevreview | Merged openstack/neutron master: Skip FIP check if VALIDATE_MIGRATION is not True https://review.opendev.org/c/openstack/neutron/+/806942 | 14:34 |
| amotoki | s/so/but/ | 14:34 |
| amotoki | and this solution would still require double APi listing calls (but it would be a good short-term solution) | 14:35 |
| ralonsoh | just one qq: when using all_projects and tenant_id, how can admin user retrieve only its own SG+shared? | 14:35 |
| opendevreview | Merged openstack/neutron-lib master: Improve "get_collection_count" method https://review.opendev.org/c/openstack/neutron-lib/+/807686 | 14:36 |
| amotoki | ralonsoh: it cannot even with all_projects=false withotu tenant_id. if we really need this, 'shared' filter would be required. | 14:37 |
| amotoki | that is my quick thought but i might be wrong. | 14:38 |
| opendevreview | Lucas Alvares Gomes proposed openstack/neutron stable/wallaby: Skip FIP check if VALIDATE_MIGRATION is not True https://review.opendev.org/c/openstack/neutron/+/807735 | 14:38 |
| ralonsoh | this is what I was thinking | 14:38 |
| opendevreview | Lucas Alvares Gomes proposed openstack/neutron stable/victoria: Skip FIP check if VALIDATE_MIGRATION is not True https://review.opendev.org/c/openstack/neutron/+/807736 | 14:38 |
| ralonsoh | so I think we should propose "shared" flag | 14:38 |
| opendevreview | Lucas Alvares Gomes proposed openstack/neutron stable/ussuri: Skip FIP check if VALIDATE_MIGRATION is not True https://review.opendev.org/c/openstack/neutron/+/807737 | 14:38 |
| amotoki | ralonsoh: good idea. looks straight-forward | 14:38 |
| slaweq | and then we would need to modify nova to make additional API request for shared SGs when it will not find anything in own tenant, right? | 14:39 |
| amotoki | perhaps yes | 14:39 |
| slaweq | ok, sounds reasonable for me | 14:40 |
| slaweq | I will propose docs update for now to document how it can be used currently | 14:40 |
| opendevreview | Lucas Alvares Gomes proposed openstack/networking-ovn stable/train: Skip FIP check if VALIDATE_MIGRATION is not True https://review.opendev.org/c/openstack/networking-ovn/+/807738 | 14:40 |
| slaweq | and then will work on that "shared" filter in next cycle | 14:40 |
| slaweq | will that works for You? | 14:40 |
| amotoki | yes | 14:40 |
| ralonsoh | yes | 14:41 |
| slaweq | ++ | 14:41 |
| lajoskatona | +1 | 14:41 |
| slaweq | thx a lot | 14:41 |
| slaweq | haleyb: any other bugs to discuss today? | 14:41 |
| haleyb | slaweq: you had a wishlist bug, i'll mention but maybe people can just discuss in bug | 14:42 |
| haleyb | https://bugs.launchpad.net/neutron/+bug/1942294 | 14:42 |
| haleyb | "Is allow_overlapping_ips config option still needed really?" | 14:42 |
| slaweq | ahh, right | 14:42 |
| slaweq | I almost forgot about it :) | 14:42 |
| haleyb | i don't know myself if anyone uses that, but *think* most people set it to True, right? | 14:43 |
| slaweq | I recently noticed we have that option in Neutron still but do You know if it is used for anything still? | 14:43 |
| ralonsoh | right, I think this is useless since Nova removed all network related | 14:44 |
| obondarev | +1 | 14:44 |
| amotoki | I cannot remember the history and the exact context. haleyb cannot remember it either. I will comment in the bug after checking it. | 14:44 |
| slaweq | do You think we can still deprecate it that cycle? | 14:45 |
| slaweq | or should we wait with that to Yoga? | 14:45 |
| lajoskatona | As nova networking was removed from nova, we can remove it as I see | 14:45 |
| ralonsoh | +1 | 14:45 |
| amotoki | I think we can deprecate it. If someone depends on it, they can report/raise it | 14:45 |
| amotoki | * deprecate it in this cycle | 14:46 |
| haleyb | my only suggestion would be to make the code as if it's set to True | 14:46 |
| haleyb | i.e. there is a single 'if' in neutron | 14:46 |
| ralonsoh | right | 14:46 |
| obondarev | default is False | 14:47 |
| slaweq | haleyb: what do You think by "make the code as it's set to True"? | 14:47 |
| haleyb | slaweq: in the ipam code use | 14:47 |
| haleyb | subnet_list = [{'id': s.id, 'cidr': s.cidr} | 14:47 |
| haleyb | for s in network.subnets] | 14:47 |
| amotoki | https://github.com/openstack/neutron/blob/master/neutron/db/ipam_backend_mixin.py#L244-L248 | 14:48 |
| ralonsoh | "false" was the safe value but Neutron supports this | 14:48 |
| haleyb | afaik distros set it to True, right? | 14:48 |
| ralonsoh | and Nova does not care | 14:48 |
| slaweq | yes, all tools which I saw sets it to true | 14:48 |
| slaweq | ok, I will mark option as deprecated and will change code in neutron so it will be run as | 14:48 |
| slaweq | it's set to True | 14:48 |
| slaweq | thx for the comments on that | 14:49 |
| haleyb | +1 | 14:49 |
| slaweq | any other bugs for today? :) | 14:50 |
| haleyb | no, fixes proposed for everything else i think, that's all i had | 14:50 |
| slaweq | thx haleyb | 14:50 |
| slaweq | this week our bug deputy is lajoskatona | 14:51 |
| slaweq | next week will be amotoki - is that ok for You amotoki? | 14:51 |
| amotoki | yes. I will be on vacation till next Mon and be back next Tue. I can cover most of the week so it would not be a problem. | 14:51 |
| slaweq | thx | 14:51 |
| slaweq | so that's all regarding bugs for today | 14:52 |
| slaweq | #topic On Demand Agenda | 14:52 |
| slaweq | I have one more quick topic for today | 14:52 |
| slaweq | Rehome ovs constants to neutron-lib https://review.opendev.org/q/topic:%22rehome-ovs-constants%22+(status:open%20OR%20status:merged) | 14:52 |
| slaweq | there are some patches proposed by me there | 14:52 |
| slaweq | and liuyulong has different opinion about it | 14:52 |
| slaweq | I wanted to discuss it with the team | 14:52 |
| slaweq | should we rehome those constants to neutron-lib? wdyt? | 14:53 |
| liuyulong | Surely, I moved some comments to commit message of this patch https://review.opendev.org/c/openstack/neutron-lib/+/807224 | 14:53 |
| ralonsoh | yes, n-lib should be the place for those constants. About speeding up the development, you can always add new constants to Neutron with a TODO to rehome them later | 14:53 |
| ralonsoh | that will allow you to send patches to Neutron without waiting for n-lib | 14:54 |
| amotoki | yes, I am personally fine with this as OVS constants are used in various repos as we had discussions before. | 14:54 |
| amotoki | can we move them to neutron_lib.constants to more a specific place? | 14:54 |
| amotoki | neutron_lib.constants grows | 14:54 |
| ralonsoh | agree | 14:54 |
| lajoskatona | +1, I undesratnd that with n-lib releases can be harder to work, but it's a place where Neutron related things are collected to one repo | 14:55 |
| liuyulong | How to deal with the problems of these cases? ralonsoh | 14:55 |
| liuyulong | 1. Since the qos "VALID_RULE_TYPES" is moved to neutron-lib, | 14:55 |
| liuyulong | we have done some extra works: | 14:55 |
| liuyulong | a. copy the new list back, do the Neutron only development works [1]. | 14:55 |
| liuyulong | b. move the list back to neutron-lib [2] | 14:55 |
| liuyulong | c. waiting for neutron-lib to have a new release [3] | 14:55 |
| liuyulong | d. update neutron to use constants from neutron-lib [4] | 14:55 |
| liuyulong | 2. They are going to move the "*_BR_ALL_TABLES" to neutron-lib [5], | 14:55 |
| liuyulong | and doing the same work of rotating Neutron [6]. For these tables, | 14:55 |
| liuyulong | at least two WIP features will have works on these tables [7][8]. | 14:55 |
| liuyulong | So, let them copy these list back to neutron again? Then add a | 14:55 |
| liuyulong | TODO node? It wastes not only developer time, but also code | 14:55 |
| liuyulong | reviewers bandwidth. | 14:55 |
| liuyulong | [1] https://review.opendev.org/c/openstack/neutron/+/796363/15/neutron/services/qos/constants.py | 14:55 |
| liuyulong | [2] https://review.opendev.org/c/openstack/neutron-lib/+/804378 | 14:55 |
| liuyulong | [3] https://review.opendev.org/c/openstack/neutron/+/803462 | 14:55 |
| liuyulong | [4] https://review.opendev.org/c/openstack/neutron/+/804380 | 14:55 |
| liuyulong | [5] https://review.opendev.org/c/openstack/neutron/+/797121/8/neutron/plugins/ml2/drivers/openvswitch/agent/common/constants.py#b1 | 14:55 |
| liuyulong | [6] https://review.opendev.org/c/openstack/neutron/+/797120/ | 14:55 |
| liuyulong | [7] https://review.opendev.org/c/openstack/neutron-specs/+/797798/12/specs/xena/node-local-ip.rst@259 | 14:55 |
| liuyulong | [8] https://review.opendev.org/c/openstack/neutron/+/804213 | 14:56 |
| ralonsoh | of course we don't have time in this meeting to review all of this | 14:56 |
| ralonsoh | I'll reply on the reviews | 14:56 |
| liuyulong | The main problem is how to define "common use"? | 14:56 |
| liuyulong | A list of constants is "common used"? | 14:56 |
| ralonsoh | in this specific case: OVS constants are "common use" | 14:57 |
| liuyulong | A list of constants which is used only by Neutron is "common used"? | 14:57 |
| ralonsoh | other plugins should be aware of OVS trables, OFs, etc | 14:57 |
| amotoki | at least we had an example on OVS tables. it is better to define table numbers in a single place. | 14:57 |
| liuyulong | sure, see the commit message here, https://review.opendev.org/c/openstack/neutron-lib/+/807224 | 14:58 |
| liuyulong | I just move all the arguments here. | 14:58 |
| liuyulong | amotoki, it's fine to place one singe table to neutron-lib. | 14:58 |
| slaweq | we are almost out of time, let's continue it in the review of the patches | 14:59 |
| liuyulong | But, the combination list if "_ALL_TABLE" is used by neutron only. | 14:59 |
| slaweq | at least team is aware of that :) | 14:59 |
| slaweq | thx for attending the meeting | 14:59 |
| slaweq | have a great week :) | 14:59 |
| slaweq | #endmeeting | 14:59 |
| opendevmeet | Meeting ended Tue Sep 7 14:59:45 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:59 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/networking/2021/networking.2021-09-07-14.00.html | 14:59 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/networking/2021/networking.2021-09-07-14.00.txt | 14:59 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/networking/2021/networking.2021-09-07-14.00.log.html | 14:59 |
| lajoskatona | Bye | 14:59 |
| slaweq | #startmeeting neutron_ci | 15:00 |
| opendevmeet | Meeting started Tue Sep 7 15:00:12 2021 UTC and is due to finish in 60 minutes. The chair is slaweq. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
| opendevmeet | The meeting name has been set to 'neutron_ci' | 15:00 |
| slaweq | hi again :) | 15:00 |
| lajoskatona | Hi | 15:00 |
| bcafarel | o/ long time no see :) | 15:00 |
| ralonsoh | hi | 15:00 |
| amotoki | slaweq: which review or place is good for discussion on the OVS constaints? | 15:00 |
| amotoki | sorry for bothering the startmeeting :p | 15:00 |
| obondarev | hi | 15:01 |
| ralonsoh | next friday in the drivers meeting? | 15:01 |
| slaweq | amotoki: one of the patches in the list https://review.opendev.org/q/topic:%22rehome-ovs-constants%22+(status:open%20OR%20status:merged) | 15:01 |
| amotoki | slaweq: thanks | 15:01 |
| slaweq | we need to discuss it somewhere :) | 15:01 |
| amotoki | :) | 15:02 |
| slaweq | ok, let's now start ci meeting :) | 15:02 |
| slaweq | Grafana dashboard: http://grafana.openstack.org/dashboard/db/neutron-failure-rate | 15:03 |
| slaweq | #topic Actions from previous meetings | 15:04 |
| slaweq | ralonsoh to check fullstack issue https://bugs.launchpad.net/neutron/+bug/1942190 | 15:04 |
| ralonsoh | I didn't see the cause | 15:05 |
| ralonsoh | but I didn't find any other related fail | 15:05 |
| slaweq | isn't that this issue with dhcp agent? | 15:05 |
| ralonsoh | (one sec0 | 15:05 |
| ralonsoh | (wrong link...) | 15:05 |
| ralonsoh | Yes, the patch: https://review.opendev.org/c/openstack/neutron/+/807134 | 15:06 |
| slaweq | but this don't works as expected :/ | 15:06 |
| ralonsoh | nope, still working on this | 15:07 |
| slaweq | ralonsoh: can I assign that bug to You then? | 15:07 |
| ralonsoh | ok, perfect | 15:07 |
| slaweq | thx | 15:07 |
| slaweq | next one | 15:08 |
| slaweq | slaweq to check how to run advanced image tests in serial | 15:08 |
| slaweq | I was checking if there would be possibility to run it like we do run tempest.scenario and slow tests in "-full" jobs | 15:09 |
| slaweq | so first all scenario tests except slow are run, and then as next step only slow tests are run | 15:09 |
| slaweq | but for that we would need to have some new toxenv defined in tempest | 15:09 |
| slaweq | there's no way to do it differently I think | 15:09 |
| ralonsoh | so do you mean to create another CI job? | 15:09 |
| slaweq | I spoke with gmann yesterday and he told me that he will try to check it | 15:10 |
| slaweq | ralonsoh: nope | 15:10 |
| slaweq | I wanted to mark tests which requires advanced image as "advanced" or something like that | 15:10 |
| slaweq | maybe even "slow" | 15:10 |
| lajoskatona | I wanted to ask if that is an option or not to add new tag | 15:11 |
| slaweq | and then do something like is in tempest here: https://github.com/openstack/tempest/blob/master/tox.ini#L115 | 15:11 |
| slaweq | lajoskatona: You can add whatever tag You want | 15:11 |
| slaweq | basically using same decorator from tempest | 15:11 |
| slaweq | then You can filter tests to be run based on that decorator | 15:11 |
| ralonsoh | ahhh | 15:12 |
| slaweq | but we don't have proper toxenv to be run by zuul | 15:12 |
| slaweq | alternative would be to have extra ci jobs to run only those "slow/advanced" tests | 15:12 |
| lajoskatona | its @attr dcorator, am I right? | 15:12 |
| slaweq | that's doable only with changes in neutron-tempest plugin | 15:13 |
| slaweq | lajoskatona: right | 15:13 |
| slaweq | so it's doable with changes in neutron-tempest-plugin repo but we would have 4 extra scenario jobs | 15:13 |
| slaweq | which isn't great solution for sure | 15:13 |
| slaweq | I will also check if there is possibility to maybe mark some tests as they can't be run in parallel | 15:16 |
| slaweq | maybe that would be enough | 15:16 |
| slaweq | I will definitelly continue investigation on that topic | 15:16 |
| slaweq | #action slaweq to check if tests can be marked as they can't run in parallel | 15:17 |
| slaweq | ok, let's move on | 15:17 |
| slaweq | #topic stadium projects | 15:17 |
| slaweq | any updates here? | 15:17 |
| lajoskatona | nothing, we have some fixes this week for n-d-r, but everything else seems ok | 15:18 |
| bcafarel | one from me on neutron-vpnaas, I was looking into fixing stable barnches so the periodic jobs do not generate as much spam | 15:18 |
| bcafarel | train is almost there with https://review.opendev.org/c/openstack/neutron-vpnaas/+/805969 but I am bit stuck on the tempest error | 15:19 |
| bcafarel | the job (old automaticall converted for zuulv3) does not find neutron-tempest-plugin, though it is listed and checked out :/ | 15:19 |
| bcafarel | pointers welcome :) | 15:19 |
| slaweq | bcafarel: "all-plugin" tox env is used there | 15:20 |
| slaweq | it's deprecated and I know it was causing some problems | 15:20 |
| opendevreview | Oleg Bondarev proposed openstack/neutron master: Add Local IP Extension and DB https://review.opendev.org/c/openstack/neutron/+/804523 | 15:20 |
| opendevreview | Oleg Bondarev proposed openstack/neutron master: Local IP RPC server-agent interface https://review.opendev.org/c/openstack/neutron/+/807116 | 15:20 |
| slaweq | maybe You should try to change it to "all" toxenv? | 15:20 |
| bcafarel | oh yes I remember that one! | 15:20 |
| bcafarel | slaweq++ I will try that | 15:20 |
| slaweq | ++ | 15:20 |
| slaweq | if it's not that, please ping me, I can take a look once again | 15:21 |
| slaweq | and try to help :) | 15:21 |
| bcafarel | will do thanks :) | 15:21 |
| bcafarel | and for older versions I wonder if we should move them to EOL (train is already 8-9 fixes to repair the gates) | 15:21 |
| bcafarel | I know elod was motivated to at least keep stein running but it was a sea of red in last DNM test patch | 15:22 |
| slaweq | You mean eol older than train or train? | 15:22 |
| bcafarel | older than train (where hopefully I can get zuul +1 soon) | 15:22 |
| slaweq | if they are broken, and there are no maintainers, I think we can eol them already | 15:23 |
| slaweq | I can take care of it if You want | 15:23 |
| bcafarel | yes please, you know the "paperwork" better | 15:24 |
| slaweq | sure, I will | 15:24 |
| slaweq | #action slaweq to start eol'ing vpnaas stein and older branches | 15:24 |
| bcafarel | thanks! | 15:25 |
| slaweq | ok, next one | 15:25 |
| slaweq | #topic Stable branches | 15:25 |
| slaweq | any issues with Neutron's stable branches? | 15:25 |
| bcafarel | all good on "active" branches (recent backports) | 15:25 |
| slaweq | great | 15:25 |
| slaweq | thx for taking care of it :) | 15:26 |
| bcafarel | the CVE backport for example went fine up to queens :) | 15:26 |
| slaweq | yeah, I saw that one | 15:26 |
| slaweq | ok, let's move on | 15:27 |
| slaweq | #topic Grafana | 15:27 |
| slaweq | http://grafana.openstack.org/dashboard/db/neutron-failure-rate | 15:27 |
| slaweq | functional tests job is finally in better shape this week | 15:28 |
| slaweq | thx to otherwiseguy fix which we merged last week | 15:28 |
| slaweq | in fullstack the only issue I saw was this issue with port provisioning | 15:28 |
| ralonsoh | which one? | 15:28 |
| slaweq | which one what? patch from otherwiseguy or fullstack issue? | 15:29 |
| ralonsoh | fullstack issue | 15:29 |
| slaweq | https://bugs.launchpad.net/neutron/+bug/1942190 | 15:29 |
| ralonsoh | ah sorry, yes | 15:29 |
| slaweq | anything else regarding grafana for today? | 15:30 |
| slaweq | I guess we can move on then | 15:32 |
| slaweq | regarding fullstack, I saw only that one issue which we already discussed | 15:32 |
| slaweq | #topic tempest/scenario | 15:32 |
| slaweq | here I found (again) few oom-killer issues | 15:33 |
| slaweq | and one failure of test_overlapping_sec_grp_rules in linuxbridge job: | 15:33 |
| slaweq | https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_e2e/807134/3/check/neutron-tempest-plugin-scenario-linuxbridge/e2e97f7/testr_results.html | 15:33 |
| slaweq | IIRC this was already seen by Alex who did that scenario test | 15:33 |
| slaweq | and it's probably reported as Linuxbridge bug | 15:33 |
| slaweq | I will need to look for it and eventually talk with Alex about it | 15:34 |
| slaweq | #slaweq to check test_overlapping_sec_grp_rules failure in linuxbridge | 15:35 |
| slaweq | and that's basically all regarding tempest tests what I had for today :) | 15:36 |
| slaweq | it's not bad this week | 15:36 |
| slaweq | anything else You want to add here? | 15:36 |
| ralonsoh | no, thanks | 15:36 |
| slaweq | so let's go to the last topic for today | 15:36 |
| bcafarel | all good (and we saw a good rate of patches merged) | 15:36 |
| slaweq | #topic Periodic | 15:36 |
| slaweq | it seems that neutron-ovn-tempest-ovs-master-fedora is broken (again) | 15:37 |
| slaweq | every day it fails with same errors, like https://zuul.openstack.org/build/c9ad43989706459f84e1b203092f32c4 | 15:37 |
| slaweq | and this time it seems for me like it can be some valid bug, as it's failing on same tests every day | 15:37 |
| ralonsoh | always failing the same tests? | 15:38 |
| ralonsoh | yes | 15:39 |
| slaweq | at least this week as those jobs I checked today | 15:39 |
| ralonsoh | so we did something on 2021-08-23 | 15:39 |
| slaweq | we or Fedora :) | 15:40 |
| slaweq | ralonsoh: I wonder if errors from https://14bc9da0ccb50e1a0478-6b466cd24fe60c196767959ed246eea2.ssl.cf2.rackcdn.com/periodic/opendev.org/openstack/neutron/master/neutron-ovn-tempest-ovs-master-fedora/c9ad439/controller/logs/screen-q-svc.txt are somehow related | 15:41 |
| ralonsoh | i was checking that | 15:41 |
| slaweq | I'm talking about those: "oslo_db.exception.DBReferenceError: (pymysql.err.IntegrityError) (1452, 'Cannot add or update a child row: a foreign key constraint fails (`neutron`.`ovn_revision_numbers`, CONSTRAINT `ovn_revision_numbers_ibfk_1` FOREIGN KEY (`standard_attr_id`) REFERENCES `standardattributes` (`id`) ON DELETE SET NULL)')" | 15:42 |
| slaweq | any volunteer to check it? I think we should open new LP bug and check that one as it may be something in our code | 15:43 |
| ralonsoh | I can open the LP bug | 15:44 |
| ralonsoh | and maybe check it | 15:44 |
| slaweq | thx ralonsoh | 15:44 |
| slaweq | let's do it that way, if someone will have time, can check it | 15:44 |
| slaweq | #action ralonsoh to open bug about failing neutron-ovn-tempest-ovs-master-fedora periodic job | 15:45 |
| slaweq | and that's all what I had for today | 15:45 |
| slaweq | do You have anything else to discuss? | 15:45 |
| slaweq | if not, I will let You go a bit earlier :) | 15:46 |
| bcafarel | all good here | 15:46 |
| lajoskatona | +1 | 15:46 |
| slaweq | ok, thx for attending the meeting | 15:46 |
| ralonsoh | bye | 15:46 |
| slaweq | see You online and have a great evening :) | 15:46 |
| slaweq | o/ | 15:46 |
| slaweq | #endmeeting | 15:46 |
| opendevmeet | Meeting ended Tue Sep 7 15:46:55 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:46 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/neutron_ci/2021/neutron_ci.2021-09-07-15.00.html | 15:46 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/neutron_ci/2021/neutron_ci.2021-09-07-15.00.txt | 15:46 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/neutron_ci/2021/neutron_ci.2021-09-07-15.00.log.html | 15:46 |
| lajoskatona | Bye | 15:47 |
| bcafarel | o/ | 15:48 |
| opendevreview | Merged openstack/tap-as-a-service master: Tests: remove tempest plugin from taas repository https://review.opendev.org/c/openstack/tap-as-a-service/+/804707 | 15:51 |
| opendevreview | Anton Vazhnetsov proposed openstack/ovsdbapp master: nb: fix route.output_port name https://review.opendev.org/c/openstack/ovsdbapp/+/807749 | 15:52 |
| opendevreview | Merged openstack/neutron stable/ussuri: Don't use singleton in routes.middleware.RoutesMiddleware https://review.opendev.org/c/openstack/neutron/+/807634 | 16:03 |
| opendevreview | Rodolfo Alonso proposed openstack/neutron master: [OVN] Update the DHCP options when the metadata port is modified https://review.opendev.org/c/openstack/neutron/+/807692 | 16:47 |
| opendevreview | Merged openstack/neutron stable/rocky: Don't use singleton in routes.middleware.RoutesMiddleware https://review.opendev.org/c/openstack/neutron/+/807637 | 18:05 |
| opendevreview | Arkady Shtempler proposed openstack/neutron-tempest-plugin master: Refactoring - Use existing Tempest APIs in "QoS bandwidth limit rule" tests https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/806977 | 18:32 |
| opendevreview | Merged openstack/networking-odl master: Enable tls-proxy support for test job https://review.opendev.org/c/openstack/networking-odl/+/796789 | 19:40 |
| opendevreview | Merged openstack/neutron stable/queens: Don't use singleton in routes.middleware.RoutesMiddleware https://review.opendev.org/c/openstack/neutron/+/807638 | 19:56 |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: ovn: use stateless NAT rules for FIPs https://review.opendev.org/c/openstack/neutron/+/804807 | 20:39 |
| opendevreview | Ghanshyam proposed openstack/neutron-tempest-plugin master: DNM: testing combined regex https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/807800 | 21:00 |
| opendevreview | Ghanshyam proposed openstack/neutron-tempest-plugin master: DNM: testing combined regex https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/807800 | 21:02 |
| opendevreview | Ghanshyam proposed openstack/neutron-tempest-plugin master: DNM: testing combined regex https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/807800 | 21:03 |
| opendevreview | Ghanshyam proposed openstack/neutron-tempest-plugin master: DNM: testing combined regex https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/807800 | 21:08 |
| opendevreview | Merged openstack/neutron stable/train: Don't use singleton in routes.middleware.RoutesMiddleware https://review.opendev.org/c/openstack/neutron/+/807635 | 21:09 |
| opendevreview | Ghanshyam proposed openstack/neutron-tempest-plugin master: DNM: testing combined regex https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/807800 | 22:01 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!