Friday, 2023-04-14

opendevreviewMiro Tomaska proposed openstack/neutron master: Fix intermittent failures in finding metada port in SB DB  https://review.opendev.org/c/openstack/neutron/+/87854904:33
opendevreviewMerged openstack/neutron master: Do not check the context object in ``TestMeteringPlugin``  https://review.opendev.org/c/openstack/neutron/+/88033806:00
slaweqhi lajoskatona, ykarel  and ralonsoh, please review https://review.opendev.org/q/topic:issue/OSP-20968+status:open when You will have few minutes. I really want to get those patches merged and propose new tag for neutron-tempest-plugin then. I need it for our d/s testing too :)06:34
slaweqthx in advance06:34
opendevreviewMerged openstack/neutron-fwaas master: Use neutron-lib policy rules  https://review.opendev.org/c/openstack/neutron-fwaas/+/87694606:37
lajoskatonaslaweq: +106:51
slaweqThx06:51
opendevreviewLajos Katona proposed openstack/networking-odl master: CI: Add periodic weekly job with sqlalchemy main  https://review.opendev.org/c/openstack/networking-odl/+/87241606:52
opendevreviewMerged openstack/neutron-dynamic-routing master: [sqlalchemy-20] Add reader context to ``get_bgp_peers``  https://review.opendev.org/c/openstack/neutron-dynamic-routing/+/88029907:04
ykarelslaweq, ack07:20
opendevreviewSlawek Kaplonski proposed openstack/neutron master: WIP [S-RBAC] Switch to new policies by default  https://review.opendev.org/c/openstack/neutron/+/87982707:52
opendevreviewSlawek Kaplonski proposed openstack/neutron master: WIP [S-RBAC] Switch to new policies by default  https://review.opendev.org/c/openstack/neutron/+/87982708:30
opendevreviewSlawek Kaplonski proposed openstack/neutron master: [S-RBAC] Get availability zone API available for READER role  https://review.opendev.org/c/openstack/neutron/+/88046108:40
opendevreviewSlawek Kaplonski proposed openstack/neutron master: [S-RBAC] Get availability zone API available for READER role  https://review.opendev.org/c/openstack/neutron/+/88046108:40
slaweqralonsoh ^^ yet another small fix for bug found when I switched to new policies by default :)08:43
slaweqplease review when You will have time08:43
opendevreviewSahid Orentino Ferdjaoui proposed openstack/neutron master: dhcp: fix network.segments condition when no segments  https://review.opendev.org/c/openstack/neutron/+/88013108:53
opendevreviewSahid Orentino Ferdjaoui proposed openstack/neutron master: dhcp: fix network.segments condition when no segments  https://review.opendev.org/c/openstack/neutron/+/88013108:55
opendevreviewBence Romsics proposed openstack/neutron master: port-hints: api extension  https://review.opendev.org/c/openstack/neutron/+/87008109:40
opendevreviewBence Romsics proposed openstack/neutron master: port-hint-ovs-tx-steering: agent side  https://review.opendev.org/c/openstack/neutron/+/87290509:41
opendevreviewBence Romsics proposed openstack/neutron master: port-hint-ovs-tx-steering: shim extension  https://review.opendev.org/c/openstack/neutron/+/87311309:41
opendevreviewBence Romsics proposed openstack/neutron master: DNM debug logs and dev helper scripts  https://review.opendev.org/c/openstack/neutron/+/87290609:42
ralonsohslaweq, do we need to backport https://review.opendev.org/c/openstack/neutron/+/879891? I think so, up to Z10:05
ralonsohright?10:05
slaweqyes10:05
slaweqand https://review.opendev.org/c/openstack/neutron/+/880461/ too10:05
ralonsohcool, I'll approve the first one now10:06
ralonsohslaweq, https://review.opendev.org/c/openstack/neutron/+/88046110:06
ralonsohcan you write Closes-Bug? 10:06
slaweqthx10:06
ralonsohjust to create the link  in the commit message10:06
opendevreviewSlawek Kaplonski proposed openstack/neutron master: [S-RBAC] Get availability zone API available for READER role  https://review.opendev.org/c/openstack/neutron/+/88046110:06
ralonsoh+110:06
slaweqdone10:06
slaweqthx10:08
ralonsohslaweq, trivial stuff but needed for your n-lib patch related to the context elevated10:13
ralonsohhttps://review.opendev.org/q/I5d7eb73606428841caa24ce1e38d1bebd5db0a9b10:13
ralonsohbefore creating new releases for stable branches10:14
slaweqthx10:14
slaweqI +2 both backports10:14
slaweqbut lajoskatona or bcafarel needs to take a look also10:14
lajoskatonaslaweq, ralonsoh: checking10:47
opendevreviewyatin proposed openstack/neutron master: [DNM] debug ovn skip level  https://review.opendev.org/c/openstack/neutron/+/87876111:13
opendevreviewSlawek Kaplonski proposed openstack/neutron master: WIP [S-RBAC] Switch to new policies by default  https://review.opendev.org/c/openstack/neutron/+/87982711:23
opendevreviewSlawek Kaplonski proposed openstack/neutron master: WIP [S-RBAC] Switch to new policies by default  https://review.opendev.org/c/openstack/neutron/+/87982711:23
opendevreviewMerged openstack/neutron master: [S-RBAC] Allow network owners to get ports from that network  https://review.opendev.org/c/openstack/neutron/+/87989112:02
opendevreviewMerged openstack/neutron stable/2023.1: Do not check the context object in ``TestMeteringPlugin``  https://review.opendev.org/c/openstack/neutron/+/88034012:02
opendevreviewMerged openstack/neutron stable/zed: Do not check the context object in ``TestMeteringPlugin``  https://review.opendev.org/c/openstack/neutron/+/88034112:02
opendevreviewArnau Verdaguer proposed openstack/neutron master: [Trunk] Copy trunk's live-migration info to subports  https://review.opendev.org/c/openstack/neutron/+/88048312:08
*** obondarev_ is now known as obondarev13:18
opendevreviewRodolfo Alonso proposed openstack/ovsdbapp master: Add Interface paramteres to ``OvsdbIdl.add_port`` method.  https://review.opendev.org/c/openstack/ovsdbapp/+/87356613:49
ralonsohslaweq, https://review.opendev.org/c/openstack/neutron/+/88046113:50
ralonsohtrivial pep8 error13:50
opendevreviewRodolfo Alonso proposed openstack/neutron master: [S-RBAC] Get availability zone API available for READER role  https://review.opendev.org/c/openstack/neutron/+/88046113:51
opendevreviewSlawek Kaplonski proposed openstack/neutron master: [S-RBAC] Get availability zone API available for READER role  https://review.opendev.org/c/openstack/neutron/+/88046113:52
opendevreviewSlawek Kaplonski proposed openstack/neutron master: WIP [S-RBAC] Switch to new policies by default  https://review.opendev.org/c/openstack/neutron/+/87982713:53
slaweqralonsoh fixed, thx13:53
opendevreviewArnau Verdaguer proposed openstack/neutron master: [Trunk] Copy trunk's live-migration info to subports  https://review.opendev.org/c/openstack/neutron/+/88048313:53
ralonsohping ykarel, mlavalle, mtomaska, slawek, obondarev, sahid, tobias-urdin, lajoskatona, amotoki 14:00
mlavalleo/14:00
slaweqo/14:00
ralonsoh#startmeeting neutron_drivers14:00
opendevmeetMeeting started Fri Apr 14 14:00:39 2023 UTC and is due to finish in 60 minutes.  The chair is ralonsoh. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
opendevmeetThe meeting name has been set to 'neutron_drivers'14:00
ralonsohhello14:00
lajoskatonao/14:00
obondarevo/14:00
dvo-plvhello14:01
ralonsohthe agenda: https://wiki.openstack.org/wiki/Meetings/NeutronDrivers14:01
ralonsohok, let's start because the agenda is packed today14:01
ralonsohfirst topic 14:02
ralonsoh#link https://bugs.launchpad.net/neutron/+bug/201233214:02
ralonsohfrom liu14:02
ralonsohbut I don't think he is here14:02
rubasovo/14:02
ralonsohdo you want to discuss it?14:02
ralonsohor do you want me to ping the author to be present?14:03
lajoskatonawe can I suppose14:03
ralonsohok then14:03
mlavalleralonsoh: can I make a suggestion?14:03
ralonsohsure14:03
lajoskatonaThe idea looks ok, and as amotoki commented a similar aproach what we have for routes can be used for allowed-addresses also14:04
mlavalledvo-plv is here. why don't we discuss his RFE?14:04
lajoskatona+114:04
ralonsohmlavalle, we have already started with this one14:04
slaweqI think that https://bugs.launchpad.net/neutron/+bug/2012332 is reasonable request and I'm +1 on this14:05
ralonsohmy question about this new API is that, eventually, you need to update the port14:05
ralonsohso you'll take the same time14:05
slaweqI don't really think there is much to discuss there, amotoki basically summarized it in his comment perfectly14:05
ralonsohyes and we are providing the same API for routes14:06
obondarevI also think it more about user experience than performance14:06
ralonsohbut that will improve the server time?14:06
slaweqtime maybe yes but it will be atomic API (similar to what we have for extra routes) so14:06
ralonsohobondarev, exactly14:06
slaweq++14:06
lajoskatona+114:06
mlavalle I'm ok with this RFE14:06
ralonsohperfect, I think there is agreement14:07
ralonsohone qq: do we need spec?14:07
mlavalleamotoki summarized well the point14:07
ralonsoh(IMO I don't think so)14:07
mlavalleI don't think so either?14:07
slaweqno spec needed IMO14:07
mlavalle+114:07
obondarevyeah, looks it just about adding new API extension, not much to rework14:07
ralonsohperfect, I'll update the bug after this meeting14:08
ralonsohthanks folks14:08
ralonsohok, lajoskatona, if you don't mind, I'll jump to the last one14:08
ralonsohnext topic14:09
ralonsoh#link https://bugs.launchpad.net/neutron/+bug/201354014:09
ralonsoh[RFE] Add support for Napatech LinkVirt SmartNICs14:09
lajoskatonato the ERSPAN RFE(https://bugs.launchpad.net/neutron/+bug/2015471 )?14:09
lajoskatonaok, so no14:09
ralonsohdvo-plv, please, go on14:09
dvo-plvHello, we are here14:09
lajoskatonabut sure, this one hangs since long time in nova-specs14:09
dvo-plvwe would like to add support for our nix to the openstack14:10
dvo-plvwe need to add support for dpdk vf representor port14:11
dvo-plvbase approach we disccused with Sean some time ago14:11
dvo-plvin the first itteration we suggested to us separate os-vif plugin like Agilio14:12
dvo-plvBut during the disscussion with Sean he would like to extend default openvswitch driver with virtio-forwarder nic type14:13
dvo-plvwe provide poc code 14:13
dvo-plvfrom our specific we have next socket name stdvio + vf number14:13
lajoskatonaby POC you mean this series: https://review.opendev.org/q/topic:Napatech_SmartNIC_support ?14:15
dvo-plvexactly14:15
ralonsohso basically you are re-using the VIFPortProfileOVSRepresentor14:15
ralonsohwhen a port is created14:16
dvo-plvyes14:16
ralonsohbut what is different from OVS with HW offload?14:16
dvo-plvwe need to set dpdk port type to the ovs port14:17
dvo-plvand past socket to the qemu layer 14:17
dvo-plvpass*14:17
dvo-plvwith custom name stdvio + vf number14:17
dvo-plvhttps://review.opendev.org/c/openstack/neutron/+/869510/3/neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py#21714:18
dvo-plvwe form socket here14:18
ralonsohwhy this is not done in os-vif?14:18
ralonsoh(we had this conversation some years ago when agilio implemented this code in ovs agent)14:19
dvo-plvbecause we need to fill details for nova to create qemu command with socekt path14:19
dvo-plvwe are open for code changes according to your better vision14:20
sahidi guess dvo-plv is just following the current implementation14:20
ralonsohok, we can discuss this in the patches14:21
dvo-plvyes, we tried to make less changes according to the Sean's vision14:21
obondarevso you need to create neutron port with specific parameters first, and then pass it to nova?14:21
dvo-plvWe need to form socket name and pass this socket to the nova to form qemu command, also we need to form vf number for ovs command14:22
dvo-plvovs-vsctl add-port br-int representor6 -- set Interface representor6 type=dpdk "options:dpdk-devargs=0000:65:00.0,representor=[6]14:22
dvo-plvthis is ovs command which we need for out port14:22
obondarevah, I see14:23
dvo-plvrepresentor=[6] this vf numver forms with next formual14:23
dvo-plvvf_num = int(slot) * 8 + int(func)14:23
ralonsohyes but this is provided by Nova, not in the Neutron port definition14:23
ralonsohthe PCI address and the VF is retrieved from Nova and the VF14:23
ralonsohwhat do you need to create a Neutron port? this is related to another question: type=dpdk, this is a new datapath in OVS?14:24
dvo-plvI believe no, this datapath is supporter by vanilla ovs14:24
dvo-plvyes, we get pci in the nova, but neutron form details dict here 14:25
dvo-plvhttps://review.opendev.org/c/openstack/neutron/+/869510/3/neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py#19314:25
dvo-plvso we follow the existing approach14:26
ralonsohso you need to set the vnic type and populate the port profile14:26
ralonsohI'm askign that because this is not in the nova spec14:26
ralonsohand I would like to have this somewhere14:27
dvo-plvyes, we need to fill port profile with dpdk port type and socket name 14:27
ralonsohif we agreed not to request a spec for this feature, at least we'll need some kind of documentation14:28
dvo-plvokay, How we need to screen this information. does it should be done formwhere in the RFE?14:28
ralonsoh^^ folks?14:28
lajoskatonagood question14:28
ralonsohthat could also be written in the docs, in https://review.opendev.org/c/openstack/neutron/+/86951014:28
lajoskatonado we have now such details in contrib docs?14:28
ralonsohnothing14:29
lajoskatonabut anyway we can find a place for such docs, so I think we can go with it, and find a place where we can document it14:29
mlavalleon the Nova side, sean-k-mooney has indicated that he is ready to approve the spec pending we support this RFE14:29
lajoskatonayes he left a +1 already on it14:30
mlavalleso I think it is ok not to request yet another spec, and add our condiferations to the existing one14:30
sahid+114:30
sean-k-mooneythis is the dpdk hardware offload topic. if so then yes. im not sure there is enough detailin the spec for other but readign the code the general approhc look ok14:31
mlavalleand require good documentation on the Neutron side14:31
mlavalleyep, we have code to look at14:31
ralonsohit will be needed some kind of description both in the RFE and the docs (the last one is important)14:31
sean-k-mooneymlavalle: if there are any detail form the neutron side that you think shoudl be added to the exsitng nova spec we could add them to capture that agrement14:32
mlavallesean-k-mooney: yeah, that was my point. lt's use the same spec14:32
sean-k-mooneyack14:32
obondarev+114:32
mlavalleyou expect us to review it anyways14:32
lajoskatona+114:32
sean-k-mooneyin which case ya i was about to say i would like to see +1s form the neutron core team before we merge it14:33
mlavalleyeap, I got that message :-)14:33
ralonsohok, I'll add this spec to the list to be tracked weekly14:33
mlavalleloud and clear14:33
sean-k-mooney:)14:33
ralonsohso please, Neutrinos, check and review this spec14:33
lajoskatonaack14:33
mlavalleit's here: https://review.opendev.org/c/openstack/nova-specs/+/85929014:34
slaweqack14:34
sean-k-mooneyone thing i was wondering about is do wew want to detail what tests shoudl eb run in the third party ci in the spec or not14:34
ralonsohwe discussed that in the PTG14:34
ralonsohfirst is to implement the CI14:34
ralonsohit doesn't matter if we run basic tests14:34
ralonsohbut at least it should run in real HW14:34
dvo-plvwe are open to provide third-party ci/cd14:35
dvo-plvBut we would like what type of the teset we need to execute14:35
opendevreviewSlawek Kaplonski proposed openstack/neutron master: WIP [S-RBAC] Switch to new policies by default  https://review.opendev.org/c/openstack/neutron/+/87982714:35
sean-k-mooneythe netwroking basic ops senario tests and test cover span, attach/detach and move operations14:36
ralonsohI'll reply to this in the spec, but is expected to run basic tempest/neutron-tempest-plugin tests14:36
dvo-plvAlso we need to know to understand setup configuration for those tesets14:36
dvo-plvokay14:36
mlavallein that case, let's formalize it in the spec, as suggested by sean-k-mooney. it will serve to document the approach and provide guidance to dvo-plv and his team14:36
dvo-plvgreat, thank you14:36
ralonsohjust as a formality, is the RFE approved?14:37
ralonsoh+1 from me14:37
mlavalle+114:37
lajoskatona+114:37
obondarev+114:37
slaweq+114:37
ralonsohthanks folks, I'll comment that in the bug after the meeting14:37
dvo-plvso, what is the conclustion, Does community need something from our side 14:37
mlavalledvo-plv: let's contnue the conversation in the spec and the rest of the patches14:38
ralonsohthe conclusion is that 1) Neutron accepts this RFE14:38
dvo-plvokay, thank you14:38
ralonsoh2) we agreed on reviewing a common spec14:38
ralonsohand 3) we are expecting some kind of CI to test the code14:38
mlavallegood summary14:38
mlavalle3 points, like very good summary14:39
mlavalleevery^^^14:39
dvo-plvWe think that we will be ready to provide ci in 1-1.5 month from today14:39
ralonsohthat will be perfect, we can review and accept the code meanwhile (I guess)14:39
ralonsohif that doesn't break any existing functionality14:40
dvo-plvShould we join to some additional meeting ?14:40
dvo-plvfor code or doc or ci review ?14:40
ralonsohdvo-plv, not really (but you can attend to any Neutron or Nova meeting)14:40
mlavalleyou are always welcome to the neutron meeting on tuesday 14)) utc14:40
mlavallebut not a requirement14:40
mlavallegerrit is our medium of communication14:41
ralonsohok, let's move14:41
ralonsohthe agenda is packed today14:41
ralonsohnext topic14:41
dvo-plvthank you, have a good day14:41
ralonsoh#link https://bugs.launchpad.net/neutron/+bug/201547114:41
ralonsoh[RFE] Add ERSPAN for tap-as-a-service with OVS and OVN14:41
ralonsohlajoskatona, please14:41
lajoskatonathanks14:41
lajoskatonaSo tap-as-a-service currently can mirror OVS or SRIOV ports' traffic to another Neutron port14:42
lajoskatonabut there is the ERSPAN which is basically also mirroring but mirroring in a tunnel (a GRE variant)14:42
lajoskatonaand both OVS and OVN support ERSPAN, so the idea is to add this kind of mirroring to taas14:43
opendevreviewyatin proposed openstack/neutron master: [DNM] Validate ovn grenade fix  https://review.opendev.org/c/openstack/neutron/+/87876114:43
lajoskatonaI tried to summarize this in the RFE, so there are questions how this can be used with current API and similar things14:44
ralonsohso, add an extra driver for OVS and create a new one for OVN14:44
lajoskatonaand for OVN a new driver is necessary for sure as that is not there in taas currently14:44
ralonsohis that correct?14:44
lajoskatonafor OVS it is just the extension of the current driver14:45
ralonsohah ok ok14:45
ralonsohjust out of curiosity (if that doesnt' take too much time)14:45
ralonsohwhat changes in OVS implementation?14:45
ralonsoh(related to the ERSPAN and current model in the RFE)14:46
lajoskatonawith OVS you can create a port which is the source port on the bridge (br-int) for the mirror like ovs-vsctl add-port br-int -- .......14:46
lajoskatonacurrently the driver creates frlows and there's an extra bridge br-tap with more flows, and that filters and directs the traffic to be mirrored to the destination port14:47
lajoskatonabut with this ERSPAN OVS creates the tunnel from the erspan port on br-int and the admin is responsible to be something on the other end of the tunnel (it can be for example a floatin-ip also, but usually something outside the cloud14:48
lajoskatonajust if you are courious I tried to doc how the current mirrring works with OVS: https://review.opendev.org/c/openstack/tap-as-a-service/+/82838214:49
mlavallein the rfe you state that "With ERSPAN this model is not that useful:" in regards to the  N:1 relationship between tap-flows and tap-services. can you elaborate a bit? Why is it not that useful?14:49
mlavalleand thanks for the doc. Yes, I've always felt taas was light on docs14:50
lajoskatonawith OVS/OVN ERSPAN there will be one new port for every source14:51
mlavallebecause that is the way it is defined?14:52
slaweqis the intention here to replace "legacy" mirroring with this new solution or just add new possibility and keep both maintained?14:52
lajoskatonayes both the OVS and OVN implementation do that14:53
rubasovlajoskatona will correct me if I misunderstood, but with erspan the mirror destination would be an arbitrary IP:port and not a neutron port14:53
ralonsoh^^ same question14:53
mlavalleI think we will keep the legacy and add a new additional way to do it14:53
lajoskatonaIt's an extension of the old/legacy14:53
lajoskatonarubasov: yes exactly14:53
mlavallerubasov: ahhh, that is a good clarification. thanks14:54
lajoskatonaas I said the destination for erspan would be out of the cloud14:54
mlavalleyeap, now I get it14:54
rubasovand the current tap flow + tap service can refer to neutron ports only (both source and destination)14:54
lajoskatonayes that is an important difference, thanks14:54
mlavallethat clarification is important because provides the rationale as to how to model this in the API14:55
mlavallenow I lean towards "to introduce a new API for ERSPAN to make as simple as possible"14:56
ralonsohok, I see the difference now but the implementation (including the alternatives proposed), API changes and mech driver prticulars, demand a spec14:56
lajoskatonaack14:56
ralonsohin any case, I'm in favor of this improvement (both for OVS and OVN)14:57
obondarev+1 for this rfe and a spec14:57
mlavalleyeap14:57
ralonsoh+114:57
mlavallegood proposal14:57
mlavalle+114:57
slaweq+114:57
lajoskatonaThanks for the discussion14:58
ralonsohperfect then, I'll update the launchpad bug14:58
lajoskatonathanks ralonsoh14:58
ralonsohthere is one more but let's keep it for the next week14:58
ralonsohwe had enough for today and this week14:58
mlavallewe made good progress this week14:58
ralonsohso let's close for today and have a nice weekend!14:58
mlavallemore than I expected14:58
mlavalleo/14:59
rubasovo/14:59
ralonsoh#endmeeting14:59
opendevmeetMeeting ended Fri Apr 14 14:59:07 2023 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)14:59
opendevmeetMinutes:        https://meetings.opendev.org/meetings/neutron_drivers/2023/neutron_drivers.2023-04-14-14.00.html14:59
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/neutron_drivers/2023/neutron_drivers.2023-04-14-14.00.txt14:59
opendevmeetLog:            https://meetings.opendev.org/meetings/neutron_drivers/2023/neutron_drivers.2023-04-14-14.00.log.html14:59
lajoskatonahave a nice weekend, bye14:59
ralonsohsee you folks14:59
obondarevo/14:59
slaweqo/14:59
opendevreviewSlawek Kaplonski proposed openstack/neutron master: WIP [S-RBAC] Switch to new policies by default  https://review.opendev.org/c/openstack/neutron/+/87982715:08
opendevreviewyatin proposed openstack/neutron master: [DNM] Check custom playbook  https://review.opendev.org/c/openstack/neutron/+/88026915:29
opendevreviewMerged openstack/neutron master: [sqlalchemy-20] Add reader context to ``get_ports_on_host_by_subnet``  https://review.opendev.org/c/openstack/neutron/+/88029815:35
opendevreviewRodolfo Alonso proposed openstack/neutron stable/2023.1: [sqlalchemy-20] Add reader context to ``get_ports_on_host_by_subnet``  https://review.opendev.org/c/openstack/neutron/+/88049615:38
opendevreviewyatin proposed openstack/neutron master: Run periodic jobs in experimental queue too  https://review.opendev.org/c/openstack/neutron/+/88053916:02
opendevreviewMerged openstack/ovsdbapp master: Add Interface paramteres to ``OvsdbIdl.add_port`` method.  https://review.opendev.org/c/openstack/ovsdbapp/+/87356616:50
*** EugenMayer41 is now known as EugenMayer419:17
*** EugenMayer48 is now known as EugenMayer419:32

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!