| opendevreview | ZhouHeng proposed openstack/neutron master: Improve ACL comparison efficiency https://review.opendev.org/c/openstack/neutron/+/885449 | 00:16 |
|---|---|---|
| opendevreview | ZhouHeng proposed openstack/neutron master: Improve ACL comparison efficiency https://review.opendev.org/c/openstack/neutron/+/885449 | 00:19 |
| opendevreview | Liushy proposed openstack/neutron-fwaas master: Support l3 stateless firewall based on OVN https://review.opendev.org/c/openstack/neutron-fwaas/+/845756 | 03:34 |
| opendevreview | Merged openstack/neutron master: Add a default goto table=94 for openvswitch fw https://review.opendev.org/c/openstack/neutron/+/907382 | 05:36 |
| opendevreview | yatin proposed openstack/neutron master: [DNM] check lp #2067869 https://review.opendev.org/c/openstack/neutron/+/921091 | 06:05 |
| *** elodilles_ooo is now known as elodilles | 06:32 | |
| zigo | slaweq: Hi there! We're trying to implement bagpipe, to have 2 local network routed between 2 OpenStack region, and we came across this patch: | 08:57 |
| zigo | https://review.opendev.org/c/openstack/networking-bagpipe/+/662305 | 08:57 |
| zigo | We're surprised that it's only modifying the tests, but not what the plugin actually does. I know it's been 5 years, but do you remember the details? | 08:57 |
| sahid | o/ | 09:23 |
| sahid | any chance to make this one happening https://review.opendev.org/c/openstack/neutron/+/907250 :-) | 09:23 |
| lajoskatona | sahid: Hi, on my list | 09:55 |
| sahid | lajoskatona: ++ thanks | 10:02 |
| opendevreview | Lajos Katona proposed openstack/os-ken master: Add periodic weekly job for os-ken https://review.opendev.org/c/openstack/os-ken/+/915273 | 11:31 |
| opendevreview | Lajos Katona proposed openstack/neutron-tempest-plugin master: UM only: change zed to use unmaintained/ https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/917696 | 11:38 |
| opendevreview | Luis Tomas Bolivar proposed openstack/ovn-bgp-agent master: Ensure cr-lrp ports are exposed https://review.opendev.org/c/openstack/ovn-bgp-agent/+/921279 | 11:49 |
| opendevreview | Merged openstack/neutron master: Make openstack-tox-py311-with-sqlalchemy-master non-voting https://review.opendev.org/c/openstack/neutron/+/920896 | 12:18 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/neutron master: ml2/ovs: avoid reconfig bridges/flows when reconnecting to OVS https://review.opendev.org/c/openstack/neutron/+/920819 | 12:51 |
| opendevreview | Mohammed Naser proposed openstack/neutron unmaintained/zed: [ML2/OVN] Add gateway_port support for FIP https://review.opendev.org/c/openstack/neutron/+/921035 | 13:35 |
| opendevreview | Luis Tomas Bolivar proposed openstack/ovn-bgp-agent master: Ensure cr-lrp ports are exposed https://review.opendev.org/c/openstack/ovn-bgp-agent/+/921279 | 13:42 |
| opendevreview | Luis Tomas Bolivar proposed openstack/ovn-bgp-agent master: Ensure cr-lrp ports are exposed https://review.opendev.org/c/openstack/ovn-bgp-agent/+/921279 | 13:43 |
| mnaser | does anyone know if there has been a change in linters for stable/2023.1 or something? | 13:46 |
| mnaser | https://review.opendev.org/c/openstack/neutron/+/921034 is a back port of change (that passed in zed and 2023.2 and master) and yet somehow it was unhappy in 2023.1 | 13:46 |
| haleyb | #startmeeting networking | 14:00 |
| opendevmeet | Meeting started Tue Jun 4 14:00:41 2024 UTC and is due to finish in 60 minutes. The chair is haleyb. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| opendevmeet | The meeting name has been set to 'networking' | 14:00 |
| haleyb | Ping list: bcafarel, elvira, frickler, mlavalle, mtomaska, obondarev, slaweq, tobias-urdin, ykarel, lajoskatona, jlibosva, averdagu, amotoki, haleyb, ralonsoh | 14:00 |
| mlavalle | \o | 14:00 |
| obondarev | o/ | 14:00 |
| ihrachys | o/ | 14:00 |
| ykarel | o/ | 14:00 |
| frickler | \o | 14:01 |
| rubasov | o/ | 14:01 |
| bcafarel | o/ | 14:01 |
| slaweq | o/ | 14:01 |
| haleyb | good crowd let's get started | 14:01 |
| haleyb | #topic announcements | 14:01 |
| haleyb | We are now in Dalmatian release week (R - 17) | 14:02 |
| haleyb | #link https://releases.openstack.org/dalmatian/schedule.html | 14:02 |
| lajoskatona | o/ | 14:02 |
| haleyb | so if there any features that haven't been proposed please get them out soon as we are more than halfway through cycle | 14:03 |
| haleyb | Reminder: If you have a topic for the drivers meeting on Friday, please add it to the wiki @ https://wiki.openstack.org/wiki/Meetings/NeutronDrivers | 14:04 |
| haleyb | i might take this Friday off since there are no current topics afaik, will send an email thursday if canceled | 14:04 |
| haleyb | lajoskatona: how was Openinfra Day Budapest yesterday? | 14:05 |
| lajoskatona | it was quiet | 14:06 |
| haleyb | :( | 14:06 |
| lajoskatona | a lot of AI topics | 14:06 |
| lajoskatona | an digital souverignity (sorryI can't write it ....) | 14:06 |
| lajoskatona | Sovereignty | 14:07 |
| lajoskatona | those were in the middle of all discussions and presentations | 14:07 |
| haleyb | AI does consume all the oxygen in the room compared to cloud and kubernetes these days | 14:07 |
| bcafarel | that looks in line with Paris day (and same from Berlin from what I heard) | 14:07 |
| lajoskatona | last week on another conf in Budapest in 2 hours there was a | 14:08 |
| lajoskatona | presentation which said that AI regenerate legacy code | 14:08 |
| lajoskatona | and another that stated that we are dynosaurs and we (developers) will just become extinct :-) | 14:08 |
| haleyb | and it fixed all the bugs while doing it? | 14:09 |
| lajoskatona | (it later changed that we have to use AI well and it will help us a lot) | 14:09 |
| slaweq | yeap | 14:09 |
| lajoskatona | you mean the bugs it created alone with artifical intellingence? I am abel to create bugs with m human intelligence | 14:09 |
| haleyb | we all are :) | 14:10 |
| mlavalle | I'm very good at that | 14:10 |
| ihrachys | AI is just a compute and network hungry workload *shrugs* | 14:10 |
| haleyb | that it is... | 14:12 |
| haleyb | alright, we can bash AI all day, any other announcements? | 14:12 |
| haleyb | #topic bugs | 14:12 |
| mlavalle | thnaks for the update lajoskatona :-) | 14:13 |
| haleyb | lucas was the deputy last week, but i didn't see a report on the ML | 14:13 |
| haleyb | did anyone have any bugs to talk about? i will look quickly in the meanwhile | 14:14 |
| haleyb | #link https://bugs.launchpad.net/neutron/+bug/2067515 | 14:15 |
| haleyb | neutron-lib: add a job running neutron unit test suite (maybe non-voting) | 14:15 |
| haleyb | this was something ihrachys noticed when a neutron-lib change broke the neutron gate | 14:16 |
| haleyb | although neutron-lib has this same job, it runs only neutron-lib unit tests | 14:16 |
| ihrachys | we disabled votes for the job now, so it's not as pressing. still good to have an early warning. | 14:16 |
| haleyb | right, but the next step is - is it possible to run the neutron unit tests in the neutron-lib gate? which would have detected the issue | 14:17 |
| haleyb | i'm not sure that's possible | 14:17 |
| haleyb | ihrachys: i actually wanted to talk about making that job non-voting today but realized i never pushed my comment to the patch | 14:18 |
| ihrachys | I'm sure it's possible! perhaps not as easy? I dunno. ykarel is it possible / easy? | 14:18 |
| haleyb | the only thing i worry about non-voting is that noone notices when there's a real bug there | 14:18 |
| ykarel | ihrachys, haleyb i think should be possible and not that hard | 14:19 |
| ykarel | consider similar jobs run in requirements patches | 14:19 |
| haleyb | and having the latest sqlalchemy running correctly is a good thing | 14:19 |
| ihrachys | haleyb let ci folks track if this job starts crashing? they do periodic group watching at charts I think. | 14:19 |
| ykarel | a run https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b27/920454/1/check/cross-neutron-py311/b27fe41/testr_results.html | 14:19 |
| haleyb | ihrachys: true, we are much better now at noticing | 14:19 |
| ihrachys | (and ideally, we have a non-voting job in neutron-lib and don't even merge anything without first checking how it fares) | 14:20 |
| ykarel | +! | 14:20 |
| haleyb | ihrachys: yes, that would be ideal, then we could make the neutron job voting again since it shouldn't break | 14:21 |
| ihrachys | ykarel I'll be impolite and ask - is it something ci group will take care of? | 14:21 |
| ihrachys | :) | 14:21 |
| ykarel | haleyb, it can still break as sqlalchemy patches are not gated | 14:21 |
| ykarel | so we can keep it still non-voting | 14:22 |
| ykarel | ihrachys, yes sure, i think you already have a bug for that so can be tracked there | 14:22 |
| haleyb | ykarel: sure, understood | 14:22 |
| ihrachys | ykarel ++ I don't think it's a good idea to keep it voting. it's exposed to the world, not isolated with constraints. | 14:22 |
| ykarel | +1 agree | 14:22 |
| haleyb | ykarel: can you take that bug and propose a neutron-lib patch? | 14:23 |
| ykarel | ack will do | 14:24 |
| ihrachys | ykarel thank you. | 14:24 |
| haleyb | ykarel: thanks! | 14:25 |
| haleyb | i only noticed one other bug | 14:26 |
| haleyb | #link https://bugs.launchpad.net/neutron/+bug/2067871 | 14:26 |
| haleyb | No support on using domain name for ovn connection string in ml2_conf.ini | 14:26 |
| ihrachys | thought there was a fix in python-ovs from otherwiseguy for this | 14:27 |
| haleyb | since the help message states tcp:IP:PORT is the format, using a dns name is more of a enhancement | 14:27 |
| haleyb | ihrachys: oh, i don't know | 14:27 |
| ihrachys | I think this https://github.com/openvswitch/ovs/commit/4d55a364ff60d894dce4e2e97a489d81520dc663 | 14:27 |
| ykarel | i recall it's in ovs3.1 | 14:27 |
| ykarel | ok so 3.2 as per above commit :) | 14:27 |
| haleyb | it's unclear from that commit message it relates to this imho | 14:28 |
| ihrachys | unless it was backported. anyhoo, pretty recent. we needed it to point clients to a round-robin backed by k8s dns. | 14:29 |
| ykarel | apart from the ovs3.1 python3-unbound is required for that to work | 14:29 |
| haleyb | but the link to the ML is clearer | 14:29 |
| ykarel | s/ovs3.1/ovs3.2 | 14:29 |
| ihrachys | haleyb and yet it is related, 99% sure :) | 14:29 |
| ihrachys | this was a discrepancy between python-ovs and C behavior (the latter was resolving before) | 14:30 |
| haleyb | ihrachys: ack, so it seems if we bump the requirement, change the help text and add a test we should be good | 14:31 |
| haleyb | i can add that info to the bug | 14:32 |
| ihrachys | meh. I don't think we promised anywhere it will work?.. | 14:32 |
| ihrachys | we can definitely mention somewhere that DNS may work, depending on your OVS version. | 14:32 |
| haleyb | oh, this is in ovs not ovsdbapp | 14:33 |
| haleyb | doh | 14:33 |
| ihrachys | yep | 14:33 |
| lajoskatona | Perhaps 2 bugs for os-ken: https://bugs.launchpad.net/neutron/+bug/2067970 & https://bugs.launchpad.net/neutron/+bug/2067973 | 14:34 |
| lajoskatona | both marked as vulnerability and as I see both come from a non-Neutron usecase which we don't test in Openstack CI most probably | 14:35 |
| haleyb | that second one is private so maybe not visible | 14:35 |
| ihrachys | both are 404 for me | 14:35 |
| ihrachys | so probably not a good idea to discuss it here :) | 14:36 |
| lajoskatona | ahh, ok | 14:36 |
| lajoskatona | just a general thing to think about then: if it is not Openstack usecase how to handle this? do we want to take responsibility to the code part of os-ken that is not used by Openstack | 14:37 |
| lajoskatona | just inherited from ryu? | 14:37 |
| ihrachys | (not idea what we are talking about but) if it's not used, just yank it. | 14:37 |
| ihrachys | that we carry dead code is a problem in itself imo | 14:38 |
| lajoskatona | It can be a topic of some of the coming meetings, driver or later the PTG perhaps to collect all these | 14:39 |
| haleyb | lajoskatona: maybe propose that in the bug | 14:39 |
| haleyb | to remove the unused (broken) code | 14:40 |
| lajoskatona | haleyb: ack, I check them and add comment to them | 14:40 |
| haleyb | +1 | 14:40 |
| haleyb | and just an update on the cover job bug | 14:41 |
| haleyb | #link https://bugs.launchpad.net/neutron/+bug/2065821 | 14:41 |
| haleyb | we landed a workaround that helps, using --concurrency 4 | 14:41 |
| haleyb | i've tried different versions of the coverage tool and memory consumption seems similar | 14:41 |
| haleyb | so i guess we've always been on the edge of failure | 14:42 |
| haleyb | i'm still running tests and will update the bug and ML with more info | 14:42 |
| haleyb | the side-effect was learning about sql 'selectin' queries | 14:43 |
| haleyb | i filed a bug for that and have two patches in-flight | 14:43 |
| haleyb | #link https://launchpad.net/bugs/2067770 | 14:43 |
| ihrachys | I saw them bloody red. is it an intrinsic problem with the switch or just some oversights when pushing? is there a lot more work there? | 14:43 |
| haleyb | ihrachys: the neutron-lib patch needs to land first, https://review.opendev.org/c/openstack/neutron-lib/+/920936 | 14:44 |
| haleyb | with that applied locally things are fine | 14:44 |
| ihrachys | ah. we need that non-voting job to run neutron tests :) | 14:44 |
| haleyb | env TOX_ENV_SRC_MODULES=../neutron-lib tox -e py3 -- neutron.tests.unit.db | 14:44 |
| haleyb | ^^ that will use a local neutron-lib change | 14:45 |
| ihrachys | is there a way to run full neutron check pipeline against a neutron-lib patch? | 14:45 |
| ykarel | depends-on will do that | 14:45 |
| haleyb | ihrachys: no since it's a library, unless something has changed | 14:45 |
| ihrachys | ykarel doesn't it still use neutron-lib released version? | 14:45 |
| ykarel | it should use neutron-lib from git atleast in devstack jobs | 14:46 |
| slaweq | we have in experimental/periodic queue job which uses neutron-lib from master | 14:46 |
| ykarel | for orther too it should work but can cross check | 14:46 |
| slaweq | for that job depends-on should works | 14:46 |
| ihrachys | that's news to me. you are saying it pulls master neutron-lib in devstack? | 14:46 |
| ykarel | yeap if there is depends-on | 14:46 |
| haleyb | and the sqlalchemy job does too, but the patch has to have landed | 14:46 |
| ihrachys | I mean, SOME jobs like that sqlalchemy definitely check out from git and for them depends-on will work. for the rest - I dunno, I had different perception but I'd rely on ykarel who knows 100x more than me. | 14:47 |
| slaweq | ykarel that's also new for me - IIRC in the past depends on wasn't working as neutron-lib was always installed from package | 14:47 |
| ykarel | https://github.com/openstack/devstack/blob/92d70a854322be9cb22f574618d7663be9a4e649/lib/neutron#L531 | 14:47 |
| ykarel | so need to check if there is required-projects contain neutron-lib, if it does then only will work | 14:48 |
| haleyb | ykarel: right, but that assumes the neutron-lib patch has merged, correct? | 14:48 |
| ihrachys | not necessarily. I think depends-on will prepare git clones in the env to include the patch depended-upon. then devstack will checkout from these "cooked" repos. | 14:49 |
| ykarel | depends-on with unmerged patches should also test that | 14:49 |
| ihrachys | ok. I guess we can post a depends-on DNM patch and confirm in logs, should be easier than continuing arguing :p | 14:49 |
| ykarel | but the requirement is it should be in required-projects list, now thinking more i don't think we have that as we want to test with u-c | 14:49 |
| ykarel | so what slaweq said if experimental jobs have that set, those could be used for such tests | 14:50 |
| haleyb | ykarel: so i should be able to add a depends-on to my neutron patch? you can explain later | 14:50 |
| ykarel | +1 | 14:50 |
| ihrachys | right. well, having SOME jobs tested against the patch is better than nothing. | 14:50 |
| ykarel | yes for test atleast we can hack it | 14:51 |
| haleyb | but please take a look at the patches, i think the neutron-lib is easy enough - https://review.opendev.org/q/topic:%22orm-selectin%22 | 14:51 |
| lajoskatona | +1, thanks | 14:52 |
| ihrachys | that's one of those cases where a single line change affects every single code path. reviewing the diff is 1% of validation. | 14:52 |
| haleyb | jlibosva is deputy this week, can someone at RH ping him since i don't see him in channel | 14:52 |
| ihrachys | he's busy with an escalation but I will ping, sec. | 14:52 |
| haleyb | sure, just so he knows | 14:53 |
| haleyb | anyone have other bugs to discuss? | 14:53 |
| haleyb | #topic on-demand | 14:54 |
| haleyb | open floor for any other topics | 14:54 |
| ihrachys | I want this in https://review.opendev.org/c/openstack/neutron-lib/+/917855 and then cut neutron-lib that is netaddr1 compliant | 14:55 |
| ihrachys | (this is the last bit for this) | 14:55 |
| frickler | regarding the n-d-r spec you discussed on friday, I would prefer to just maintain n-d-r in the state it currently is, no new features added | 14:55 |
| haleyb | ihrachys: will take a look | 14:55 |
| frickler | at least I don't have review capacity for anything more | 14:56 |
| haleyb | frickler: was that https://bugs.launchpad.net/neutron/+bug/2064120 ? | 14:56 |
| frickler | yes | 14:57 |
| ihrachys | frickler there's another spec related to bgp where I was pushing for reusing the API for n-d-r. Wonder if this project is on life support, what Neutron project as a whole should do with it. APIs are still part of api-ref, so neutron as a whole care. | 14:57 |
| frickler | ihrachys: which spec are you referring to? | 14:58 |
| ihrachys | https://review.opendev.org/c/openstack/neutron-specs/+/920681 | 14:58 |
| frickler | also I don't mind if other neutron cores review n-d-r patches, it is just that I myself mostly won't other than real bug fixes | 14:59 |
| ihrachys | but may mix n-d-r and bgpvpn; I'm a bit shaky on who's who. | 14:59 |
| haleyb | and ovn-agent | 14:59 |
| frickler | ah, hadn't seens that one yet, will take a look later | 15:00 |
| haleyb | or whatever it's called :) | 15:00 |
| ihrachys | haleyb those pesky ovn engineers. | 15:00 |
| haleyb | we are at top of hour, thanks for attending and good discussions, let's go fix those bugs | 15:00 |
| haleyb | and ci meeting is irc right now | 15:00 |
| haleyb | #endmeeting | 15:01 |
| opendevmeet | Meeting ended Tue Jun 4 15:01:10 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:01 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/networking/2024/networking.2024-06-04-14.00.html | 15:01 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/networking/2024/networking.2024-06-04-14.00.txt | 15:01 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/networking/2024/networking.2024-06-04-14.00.log.html | 15:01 |
| lajoskatona | o/ | 15:01 |
| opendevreview | Miguel Lavalle proposed openstack/neutron master: Fix trunk test_subport_delete functional test https://review.opendev.org/c/openstack/neutron/+/921296 | 15:01 |
| slaweq | o/ | 15:01 |
| ihrachys | frickler capacity concerns are totally understood. that's something for neutron team to clarify - if there's no cap to help the project stay alive, then api deprecation decisions or reprioritization may have to happen. | 15:01 |
| ykarel | #startmeeting neutron_ci | 15:01 |
| opendevmeet | Meeting started Tue Jun 4 15:01:31 2024 UTC and is due to finish in 60 minutes. The chair is ykarel. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
| opendevmeet | The meeting name has been set to 'neutron_ci' | 15:01 |
| ykarel | Ping list: bcafarel, lajoskatona, mlavalle, mtomaska, ralonsoh, ykarel, jlibosva, elvira | 15:01 |
| mlavalle | o/ | 15:01 |
| haleyb | o/ | 15:01 |
| mlavalle | only irc today, right? | 15:02 |
| bcafarel | o/ | 15:02 |
| ykarel | yeap | 15:03 |
| lajoskatona | o/ | 15:04 |
| ykarel | hello everyone, let's start with topics from previous week | 15:04 |
| ykarel | #topic Actions from previous meetings | 15:04 |
| ykarel | lajoskatona to look at failures at sfc and bagpipe | 15:05 |
| lajoskatona | I checked but to tell the truth I have to check again since I forgot totally what I have done with it :-( | 15:06 |
| ykarel | lajoskatona reported https://bugs.launchpad.net/neutron/+bug/2067452 for bagpipe | 15:06 |
| ykarel | atleast i recall ^ :) | 15:06 |
| lajoskatona | ykarel: you saved me | 15:06 |
| ykarel | these are still failing but can discuss in next section | 15:07 |
| lajoskatona | I reported an issue for exabgp, and they promised that it will be fixed in next exabp release | 15:07 |
| ykarel | thx much | 15:07 |
| ykarel | next one on me | 15:07 |
| ykarel | ykarel to report lp for volume tests | 15:07 |
| ykarel | i reported https://bugs.launchpad.net/openstacksdk/+bug/2067869, cinder team looking at that | 15:07 |
| ykarel | #topic Stable branches | 15:08 |
| ykarel | bcafarel, any update | 15:08 |
| bcafarel | mostly good on the backports that went in | 15:08 |
| bcafarel | haleyb: semi-related I found https://review.opendev.org/c/openstack/neutron/+/919516 2023.2 which was cherry-picked from (now merged) 2023.1 probably good to push | 15:09 |
| haleyb | bcafarel: i'll remove my -W think that looks ok | 15:10 |
| haleyb | but there is no grenade job | 15:10 |
| haleyb | that's where the error was obvious | 15:10 |
| ykarel | thx bcafarel for the update | 15:11 |
| ykarel | #topic Stadium projects | 15:11 |
| slaweq | why there is no grenade job at all there? | 15:11 |
| slaweq | is that 'normal'? | 15:11 |
| lajoskatona | perhaps it is not executed on non-slurp? 2023.2 was non/slurp am I right? | 15:12 |
| slaweq | but 'regular' grenade jobs should still be run there | 15:12 |
| lajoskatona | that is true | 15:13 |
| slaweq | slurp means we support and test upgrade from the N-2 release | 15:13 |
| slaweq | but non-slurp still can be upgraded from N-1 | 15:13 |
| ykarel | seems we just missing ovn grenade from check/gate | 15:13 |
| ykarel | +1 to what slaweq said | 15:13 |
| slaweq | ykarel you can assign this as AI for me - I will check why this job is not run there | 15:14 |
| haleyb | grenade is usually only in check queue | 15:14 |
| slaweq | and will propose fix if needed | 15:14 |
| ykarel | #action slaweq to include ovn grenade jobs in check queue | 15:14 |
| haleyb | for 2023.2 | 15:14 |
| slaweq | thx | 15:14 |
| ykarel | neutron-ovn-grenade-multinode | 15:15 |
| ykarel | getting back to stadium | 15:15 |
| ykarel | sfc/bagpipe failures | 15:16 |
| ykarel | https://zuul.openstack.org/builds?job_name=openstack-tox-py312&project=openstack/networking-bagpipe | 15:16 |
| ykarel | for bagpipe we already have https://bugs.launchpad.net/neutron/+bug/2067452 | 15:16 |
| ykarel | https://zuul.openstack.org/builds?job_name=networking-sfc-tempest&project=openstack%2Fnetworking-sfc&branch=master&skip=0 | 15:16 |
| ykarel | lajoskatona, can you also check sfc failures | 15:16 |
| lajoskatona | sure, I will | 15:16 |
| ykarel | #action lajoskatona to check sfc failures | 15:17 |
| ykarel | #topic Rechecks | 15:17 |
| ykarel | there were comparatively more rechecks/bare rechecks last week due to various known issues | 15:18 |
| ykarel | sqlalchemy-master, cover jobs, etc | 15:19 |
| ykarel | #topic Unit tests | 15:19 |
| ykarel | openstack-tox-py311-with-sqlalchemy-master got broken with neutron-lib changes | 15:19 |
| ykarel | Already Fixed with https://review.opendev.org/c/openstack/neutron/+/920897 | 15:19 |
| ykarel | Ask for adding non-voting job in neutron-lib https://bugs.launchpad.net/neutron/+bug/2067515 | 15:19 |
| ykarel | i will push that change | 15:19 |
| ykarel | #action ykarel to include neutron unit-test job in neutron-lib to catch such issues | 15:20 |
| ykarel | For cover job we already have workaround applied, lajoskatona looking for actual fixes | 15:20 |
| ykarel | #topic fullstack/functional | 15:21 |
| lajoskatona | that is haleyb, or am I? | 15:21 |
| haleyb | that's still me | 15:21 |
| lajoskatona | :-) | 15:21 |
| lajoskatona | just to be sure :-) | 15:21 |
| ykarel | sorry it's haleyb :) | 15:22 |
| haleyb | how easy is it to use a different machine type for a job? | 15:22 |
| haleyb | or node type or whatever it's called | 15:22 |
| haleyb | i.e. moar memory | 15:23 |
| haleyb | i'll have to look | 15:23 |
| lajoskatona | with the label you can select, like: label: nested-virt-ubuntu-focal as I recall | 15:23 |
| ykarel | ci nodes are mostly 8 gb nodes | 15:23 |
| ykarel | there are some providers provides higher config nodes for specific use cases | 15:24 |
| haleyb | ykarel: ack, 8gb is sometimes not enough, i'll look for other options | 15:24 |
| ykarel | for some cases we enable swap if 8gb is not enough | 15:25 |
| lajoskatona | ask on infra channel if that is possible | 15:25 |
| haleyb | ykarel: ah, the change you propsed | 15:25 |
| ykarel | if it need real ram then need to look for labels with high configuration | 15:25 |
| haleyb | i was even thinking of splitting the testing up, as long as it's combined in the end | 15:26 |
| ykarel | if you looking for that cover job, using some swap should be enough as seen in that test patch | 15:27 |
| haleyb | ykarel: ack, i'll look closer at your patch might be the easiest option | 15:27 |
| ykarel | ack | 15:27 |
| ykarel | #topic fullstack/functional | 15:28 |
| ykarel | - https://4329afd232bc8c0f7e08-a692672d2d4a5288ede7d6f3bc2193fe.ssl.cf5.rackcdn.com/periodic/opendev.org/openstack/neutron/master/neutron-functional-with-sqlalchemy-master/5e7fbe9/testr_results.html | 15:28 |
| ykarel | - https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_c48/periodic/opendev.org/openstack/neutron/master/neutron-fullstack-with-uwsgi-fips/c48922c/testr_results.html | 15:28 |
| ykarel | seen those once, need to dig further | 15:29 |
| ykarel | any volunteer to check those? | 15:29 |
| mlavalle | I'll check one | 15:29 |
| mlavalle | whichever | 15:29 |
| ykarel | k thx, i can check other than | 15:30 |
| ykarel | #action mlavalle to check failures in neutron-functional | 15:30 |
| ykarel | #action ykarel to check failures in neutron-fullstack | 15:30 |
| mlavalle | btw, proposed fix for another failure: https://review.opendev.org/c/openstack/neutron/+/921296 | 15:30 |
| ykarel | thx mlavalle | 15:31 |
| mlavalle | I'll address ihrachys comment and will be good to go | 15:31 |
| ykarel | thx | 15:31 |
| ykarel | #topic Periodic | 15:31 |
| ykarel | centos stream 8 jobs needs to be dropped from unmaintained/yoga as failing since 8-stream EOL https://blog.centos.org/2023/04/end-dates-are-coming-for-centos-stream-8-and-centos-linux-7/ | 15:31 |
| ykarel | - https://zuul.openstack.org/build/fe688f48eefd4c55b38456f1c479b56a | 15:31 |
| ykarel | - https://zuul.openstack.org/build/d060a6a68352463ea8df596cc954172c | 15:31 |
| ykarel | so the jobs needs to be dropped from unmaintained/yoga | 15:32 |
| ykarel | any volunteer to push that patch? | 15:32 |
| ykarel | i can push it then | 15:33 |
| ykarel | #action ykarel to push patch to drop centos 8-stream jobs | 15:34 |
| ykarel | #topic Grafana | 15:34 |
| ykarel | https://grafana.opendev.org/d/f913631585/neutron-failure-rate | 15:34 |
| ykarel | let's have quick look at grafana too | 15:34 |
| ykarel | there some spike in gate queue, and those are known issue with nova | 15:35 |
| ykarel | in check some are known issues, and others looks patch specific | 15:36 |
| ykarel | anything to add? | 15:36 |
| mlavalle | not from me | 15:37 |
| lajoskatona | nothing from me | 15:37 |
| ykarel | ack | 15:38 |
| ykarel | #topic On Demand | 15:38 |
| ykarel | anything else you would like to raise here? | 15:38 |
| mlavalle | nothing from me | 15:39 |
| bcafarel | all good | 15:39 |
| ykarel | thx everyone for joining, in that case let's close and have everyone 20 minutes back | 15:40 |
| ykarel | #endmeeting | 15:40 |
| opendevmeet | Meeting ended Tue Jun 4 15:40:38 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:40 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/neutron_ci/2024/neutron_ci.2024-06-04-15.01.html | 15:40 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/neutron_ci/2024/neutron_ci.2024-06-04-15.01.txt | 15:40 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/neutron_ci/2024/neutron_ci.2024-06-04-15.01.log.html | 15:40 |
| lajoskatona | Bye | 15:40 |
| slaweq | bye | 15:41 |
| opendevreview | Gaudenz Steinlin proposed openstack/neutron master: Use transient systemd units in Process fixture https://review.opendev.org/c/openstack/neutron/+/919834 | 15:43 |
| opendevreview | Gaudenz Steinlin proposed openstack/neutron master: Add L3 HA fullstack failover tests https://review.opendev.org/c/openstack/neutron/+/917429 | 15:43 |
| opendevreview | Gaudenz Steinlin proposed openstack/neutron master: Add conntrackd support to HA routers in L3 agent https://review.opendev.org/c/openstack/neutron/+/917430 | 15:43 |
| mnaser | https://review.opendev.org/c/openstack/neutron/+/921034 -- does anyone know why a back ported change would just blow up randomly and be fine in zed and 2023.2 but not 2023.1 ? | 15:46 |
| mnaser | I wanna avoid the recheck hammer | 15:46 |
| ihrachys | haleyb question: let's say a new stable release of n-lib is cut; and let's say there's a neutron patch that someone wants to backport to this stable branch; but the patch would require the newly cut release, and it would not work without it. is it allowed to bump minimal version in reqs.txt in stable branches? | 15:58 |
| mnaser | is the neutron gate broken? | 16:06 |
| mnaser | https://review.opendev.org/c/openstack/neutron/+/914697 | 16:06 |
| mnaser | this change only ran docs and pep8 | 16:07 |
| mnaser | oh its happening to many `master` changes | 16:07 |
| ihrachys | haleyb ^^ | 16:08 |
| * haleyb is in downstream meetings at the moment, but wonders if maybe the zuul negate patch broke something? | 16:09 | |
| haleyb | https://review.opendev.org/c/openstack/neutron/+/920977 | 16:09 |
| haleyb | not sure what else would cause such issues | 16:09 |
| mnaser | https://review.opendev.org/c/openstack/neutron/+/907382 this for example even landed without testing | 16:10 |
| mnaser | let me see | 16:10 |
| mnaser | its gotta be that imho | 16:10 |
| haleyb | sigh | 16:11 |
| ihrachys | but the RE2 patch gate run all jobs | 16:13 |
| haleyb | it did. the test patch never got far enough to run any tests from waht i can tell | 16:14 |
| * haleyb looks for other negate:true instances | 16:17 | |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: Revert "Use RE2 compatible regex for irrelevant-files" https://review.opendev.org/c/openstack/neutron/+/921306 | 16:17 |
| ihrachys | posted for in case we want to land it, so that it collects logs | 16:17 |
| ihrachys | runs jobs here https://zuul.opendev.org/t/openstack/status#921306 | 16:18 |
| haleyb | i think they're all missing a trailing $ perhaps? | 16:19 |
| ihrachys | there was also one for tempest plugin https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/920979 | 16:19 |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron-tempest-plugin master: Revert "Use RE2 compatible regex for irrelevant-files" https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/921307 | 16:20 |
| ihrachys | haleyb I have to leave for today. I will check later if $ patch is up and review. you can ping with link here and I will eventually check it. | 16:21 |
| haleyb | ihrachys: ack, thanks, let me throw up a patch and see | 16:22 |
| ihrachys | btw checked and I don't think we have any in-flight Workflow+1 patches for neutron so we won't land anything on top without testing, at least (assuming everyone is aware of this happening) | 16:24 |
| haleyb | i will keep an eye | 16:24 |
| mnaser | some landed without that but they went through gate so I guess its ok™ | 16:25 |
| ihrachys | lol. let's hope. worst case we'll have to include their reverts into RE2 revert (or a fix for $) | 16:25 |
| haleyb | the OVS one did, which had passed previously at least | 16:25 |
| * haleyb is just doing the commit message now in his change | 16:25 | |
| opendevreview | Brian Haley proposed openstack/neutron master: Add missing '$' to regex lines zuul.d/* https://review.opendev.org/c/openstack/neutron/+/921309 | 16:26 |
| haleyb | it that seems to work i'll propose a n-t-p one | 16:26 |
| haleyb | mnaser: and i don't know why the 2023.1 gate is being more picky regarding pep8 | 16:28 |
| ihrachys | it's running check jobs as it should. does this affect check, right? | 16:28 |
| haleyb | ihrachys: it should affect both, i'll create a test job too | 16:29 |
| opendevreview | Brian Haley proposed openstack/neutron master: DNM: test regex fix https://review.opendev.org/c/openstack/neutron/+/921310 | 16:30 |
| ihrachys | nope, the DNM runs just docs and pep | 16:32 |
| haleyb | it shouldn't need a depends-on, but i'll try one | 16:32 |
| * haleyb shakes fist at the gate | 16:32 | |
| opendevreview | Brian Haley proposed openstack/neutron master: DNM: test regex fix https://review.opendev.org/c/openstack/neutron/+/921310 | 16:33 |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: DNM: test revert for RE2 https://review.opendev.org/c/openstack/neutron/+/921311 | 16:33 |
| haleyb | that looks better at least | 16:34 |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: DNM: test revert for RE2 https://review.opendev.org/c/openstack/neutron/+/921311 | 16:35 |
| ihrachys | haleyb so I think revert runs all jobs; and yours doesn't still | 16:37 |
| ihrachys | mine DNM for revert: https://zuul.opendev.org/t/openstack/status#921311 | 16:37 |
| ihrachys | your DNM for fix: https://zuul.opendev.org/t/openstack/status#921310 | 16:37 |
| ihrachys | haleyb I'd suggest to land revert now and think about a proper fix later when yatin can join too. ok now I really have to leave. see you. | 16:38 |
| haleyb | yup. so what does (?!(project)) mean in regex context? did we just get the syntax wrong? | 16:38 |
| haleyb | ihrachys: right, gate fixed is priority | 16:38 |
| haleyb | https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_expressions/Cheatsheet has an explanation | 16:43 |
| haleyb | x(?!y) Matches "x" only if "x" is not followed by "y" | 16:44 |
| haleyb | so zuul.d not followed by project.yaml ? | 16:45 |
| opendevreview | Brian Haley proposed openstack/neutron master: Add missing '$' to regex lines zuul.d/* https://review.opendev.org/c/openstack/neutron/+/921309 | 16:54 |
| opendevreview | Brian Haley proposed openstack/neutron master: DNM: test regex fix https://review.opendev.org/c/openstack/neutron/+/921310 | 16:54 |
| opendevreview | Brian Haley proposed openstack/neutron master: Add missing '$' to regex lines zuul.d/* https://review.opendev.org/c/openstack/neutron/+/921309 | 17:06 |
| opendevreview | Brian Haley proposed openstack/neutron master: DNM: test regex fix https://review.opendev.org/c/openstack/neutron/+/921310 | 17:07 |
| ihrachys | haleyb the reverts got +1 from zuul. we need another vote? | 17:43 |
| haleyb | ihrachys: the neutron one is still running, right? | 17:45 |
| ihrachys | nevermind, it's arm | 17:45 |
| ihrachys | haleyb so what does negate in irrelevant files mean? "ignore everything that doesn't match the filter?" | 17:49 |
| ihrachys | if so, perhaps we made it so that only changes to zuuk.d/project.yaml ran the jobs? we can post a patch touching the file and see if it triggers more jobs. sec. | 17:49 |
| opendevreview | Ihar Hrachyshka proposed openstack/neutron master: DNM testing if touching project.yaml runs all jobs https://review.opendev.org/c/openstack/neutron/+/921315 | 17:51 |
| haleyb | right, i'm thinking it was saying 'everything in zuul.d except for this one file' ? | 17:51 |
| ihrachys | haleyb so I touched the file and see that this runs all jobs | 17:52 |
| ihrachys | but the meaning of the filter before the change was "any file that is in zuul.d that is not project.yaml is irrelevant" | 17:52 |
| ihrachys | which is different meaning. | 17:53 |
| ihrachys | so negate is not the right way to go about it, I think; it's not a matter of a regex fix | 17:54 |
| haleyb | ihrachys: i think my later change was closer to that meaning, but the DNM didn't run much | 17:55 |
| ihrachys | which of? ETOOMANYDNMs | 17:56 |
| haleyb | https://review.opendev.org/c/openstack/neutron/+/921309 - i added the entire directory, then negated one file | 17:56 |
| haleyb | i based that on what i saw ironic do | 17:57 |
| haleyb | but RE is like my kryptonite | 17:57 |
| ihrachys | hm. but I think these filters are ORed. so you have "anything in zuul.d is irrelevant OR anything that is not zuul.d/project.yaml is irrelevant" | 17:58 |
| haleyb | i assumed this was correct, https://opendev.org/openstack/ironic/commit/df6342d1ab2dfaeff84733896ecee40c1b1225e4 | 17:59 |
| haleyb | but yes, these are ORed together | 17:59 |
| ihrachys | welll... no bandit job e.g. here: https://review.opendev.org/c/openstack/ironic/+/921294 | 18:01 |
| ihrachys | so maybe they also broke it; but their use of these regexes was not as prominent. | 18:01 |
| haleyb | we can always be smart, step back and say "what do we want to call irrelevant in zuul.d?" | 18:02 |
| haleyb | :) | 18:02 |
| haleyb | ^zuul.d/(?!(project)).*\.yaml - i worry this doesn't mean what i think it means | 18:03 |
| ihrachys | last time bandit job ran for ironic was May 22: https://zuul.opendev.org/t/openstack/builds?job_name=ironic-tox-bandit&project=openstack/ironic | 18:03 |
| ihrachys | believe it or not, RE patch landed May 23 | 18:03 |
| ihrachys | haleyb you mean, list all files as positive matches instead? | 18:04 |
| haleyb | TheJulia: ^^ curious regarding RE2 ironic patch imo | 18:04 |
| ihrachys | haleyb this means: anything in zuul.d that is not project.yaml. which is a more narrow filter than 'anything in the tree that is not zuul.d/project.yaml' | 18:05 |
| haleyb | ihrachys: no, just that my understanding of the RE syntax is wrong | 18:05 |
| TheJulia | huh what? | 18:05 |
| ihrachys | TheJulia I think you disabled bandit job unintentionally with https://review.opendev.org/c/openstack/ironic/+/920276 | 18:05 |
| haleyb | TheJulia: neutron was able to disable part of our gate, so i went looking for other RE2 changes, just noticed the ironic one | 18:06 |
| TheJulia | yup, sure looks like it | 18:06 |
| ihrachys | haleyb "part" really does some heavy lifting lol | 18:06 |
| haleyb | ihrachys: ok s/part/most | 18:07 |
| haleyb | ihrachys: it's almost like the filter should just be ^zuul.d/project\.yaml with no negate | 18:08 |
| ihrachys | haleyb well no. the idea is to not trigger jobs defined in project.yaml for changes in other yamls; (and vice versa) | 18:10 |
| TheJulia | haleyb: thanks for spotting that | 18:10 |
| haleyb | TheJulia: you might want to look at other ironic* repos too | 18:10 |
| haleyb | and i spotted by copying and failing | 18:10 |
| TheJulia | I just pinged the person who pushed the changes | 18:10 |
| ihrachys | TheJulia wonder if other projects could be affected in a similar way. I suspect there may have been a lot of copying across repo boundaries. :) | 18:11 |
| TheJulia | yeah, quite possible | 18:11 |
| ihrachys | haleyb I am not even sure RE2 would support it. see e.g. here: https://groups.google.com/g/re2-dev/c/SPgvHH3TULs some suggests that RE2 is not a good place to support this. | 18:17 |
| ihrachys | https://github.com/google/re2/issues/156 | 18:18 |
| ihrachys | "As a matter of principle, RE2 does not support constructs for which only backtracking solutions are known to exist. Thus, backreferences and look-around assertions are not supported." and then closed | 18:18 |
| ihrachys | *shrugs* | 18:18 |
| haleyb | yeah, this is considered a negative look-ahead | 18:19 |
| haleyb | ihrachys: so if i put this expression, ^zuul\.d/(?!(project)).*\.yaml into regex101.com along with some test filenames, it doesn't match zuul.d/project.yaml but does match other files with zuul.d prefix | 18:28 |
| opendevreview | Brian Haley proposed openstack/neutron master: Fix regex lines zuul.d/* files https://review.opendev.org/c/openstack/neutron/+/921309 | 18:38 |
| opendevreview | Brian Haley proposed openstack/neutron master: DNM: test regex fix https://review.opendev.org/c/openstack/neutron/+/921310 | 18:39 |
| opendevreview | Brian Haley proposed openstack/neutron master: Fix regex lines in zuul.d/* files https://review.opendev.org/c/openstack/neutron/+/921309 | 19:04 |
| opendevreview | Brian Haley proposed openstack/neutron master: DNM: test regex fix https://review.opendev.org/c/openstack/neutron/+/921310 | 19:05 |
| *** jlibosva is now known as Guest8615 | 19:20 | |
| opendevreview | Brian Haley proposed openstack/neutron-tempest-plugin master: Fix regex lines in zuul.d/* files https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/921330 | 19:31 |
| haleyb | mlavalle: you around? | 19:50 |
| haleyb | if so there are two reverts we need to land, https://review.opendev.org/q/topic:%22files-negate%22 | 19:51 |
| opendevreview | Brian Haley proposed openstack/neutron-tempest-plugin master: DNM: test regex fix https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/921334 | 20:03 |
| opendevreview | Merged openstack/neutron-tempest-plugin master: Fix regex lines in zuul.d/* files https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/921330 | 23:22 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!