Thursday, 2024-06-06

opendevreviewIhar Hrachyshka proposed openstack/neutron master: Fix regex lines in zuul.d/* files  https://review.opendev.org/c/openstack/neutron/+/92130900:38
haleybihrachys: i can take a look tomorrow, but i would like to get https://review.opendev.org/c/openstack/neutron-lib/+/920936 in if we are releasing neutron-lib, just need to test that first but depends on the gate being correct02:13
opendevreviewyatin proposed openstack/neutron master: Add some swap to tox-cover job  https://review.opendev.org/c/openstack/neutron/+/92142005:29
opendevreviewyatin proposed openstack/neutron master: Add some swap to tox-cover job  https://review.opendev.org/c/openstack/neutron/+/92142005:44
opendevreviewyatin proposed openstack/neutron master: Fix regex lines in zuul.d/* files  https://review.opendev.org/c/openstack/neutron/+/92130906:10
*** ykarel__ is now known as ykarel06:34
slaweqykarel__ lajoskatona hi, can You check https://review.opendev.org/c/openstack/neutron-lib/+/920936 maybe? IMO it is good to go and neutron_tempest_plugin jobs there shows it should not break anything06:58
lajoskatonaslaweq: yes, alone it seems harmless :-)07:17
ykarelack slaweq 07:23
slaweqlajoskatona what do you mean by 'alone'? It was tested with neutron by the neutron-tempest-plugin jobs07:27
lajoskatonaslaweq: I mean without the neutron part of it to change the lazy to select-in07:29
slaweqahh, ok07:34
slaweqso do You think we should wait with it and test it together with neutron change?07:35
slaweqykarel can You maybe check https://review.opendev.org/c/openstack/neutron-lib/+/920870/ also? Thx in advance07:35
ykarelack done07:39
opendevreviewyatin proposed openstack/neutron-lib master: Add neutron unit test job in check queue  https://review.opendev.org/c/openstack/neutron-lib/+/92142208:08
opendevreviewyatin proposed openstack/neutron master: [DNM] check cover job with swap  https://review.opendev.org/c/openstack/neutron/+/92064808:17
ykarellajoskatona, slaweq please check https://review.opendev.org/c/openstack/neutron/+/92142008:21
lajoskatonaykarel: done08:28
opendevreviewyatin proposed openstack/neutron-lib master: Add neutron unit test job in check queue  https://review.opendev.org/c/openstack/neutron-lib/+/92142208:42
opendevreviewMerged openstack/neutron-lib master: Add 'selectin' as a supported lazy relationship attribute  https://review.opendev.org/c/openstack/neutron-lib/+/92093609:19
opendevreviewLajos Katona proposed openstack/neutron-tempest-plugin master: UM only: change zed to use unmaintained/  https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/91769609:30
dpawlikykarel: hey o/ May I ask you to merge https://review.opendev.org/c/openstack/neutron/+/921035 ?10:11
dpawlikykarel: review is also welcome ;) 10:11
dpawlikcc haleyb 10:12
ykareldpawlik, ack, there looks some issue in 2023.1 backport, that needs to be cleared10:16
opendevreviewMerged openstack/neutron-lib master: [api-ref] Add note about no validation of the target_tenant in RBAC API  https://review.opendev.org/c/openstack/neutron-lib/+/92087010:17
opendevreviewdaniel.pawlik proposed openstack/neutron stable/2023.1: [ML2/OVN] Add gateway_port support for FIP  https://review.opendev.org/c/openstack/neutron/+/92103410:28
dpawlikykarel: ack. Fixed pep8, let's see the gates now10:29
ykareldpawlik, thx10:35
opendevreviewyatin proposed openstack/neutron stable/2024.1: [stable only] Fix KeyError in set_gateway_mtu  https://review.opendev.org/c/openstack/neutron/+/92143710:48
opendevreviewyatin proposed openstack/neutron stable/2023.2: [stable only] Fix KeyError in set_gateway_mtu  https://review.opendev.org/c/openstack/neutron/+/92143810:49
opendevreviewyatin proposed openstack/neutron stable/2024.1: [stable only] Fix KeyError in set_gateway_mtu  https://review.opendev.org/c/openstack/neutron/+/92143710:49
opendevreviewyatin proposed openstack/neutron stable/2023.2: [stable only] Fix KeyError in set_gateway_mtu  https://review.opendev.org/c/openstack/neutron/+/92143810:50
opendevreviewyatin proposed openstack/neutron stable/2023.2: [stable only] Fix KeyError in set_gateway_mtu  https://review.opendev.org/c/openstack/neutron/+/92143810:50
opendevreviewyatin proposed openstack/neutron stable/2023.2: [stable only] Fix KeyError in set_gateway_mtu  https://review.opendev.org/c/openstack/neutron/+/92143810:52
opendevreviewyatin proposed openstack/neutron stable/2023.2: [stable only] Fix KeyError in set_gateway_mtu  https://review.opendev.org/c/openstack/neutron/+/92143810:53
opendevreviewyatin proposed openstack/neutron stable/2023.2: [stable only] Fix KeyError in set_gateway_mtu  https://review.opendev.org/c/openstack/neutron/+/92143810:58
opendevreviewyatin proposed openstack/neutron stable/2023.1: [stable only] Fix KeyError in set_gateway_mtu  https://review.opendev.org/c/openstack/neutron/+/92144011:00
opendevreviewyatin proposed openstack/neutron unmaintained/zed: [stable only] Fix KeyError in set_gateway_mtu  https://review.opendev.org/c/openstack/neutron/+/92144111:00
opendevreviewNiklas Schwarz proposed openstack/neutron-vpnaas master: Add type annotations  https://review.opendev.org/c/openstack/neutron-vpnaas/+/91141211:06
opendevreviewNiklas Schwarz proposed openstack/neutron-vpnaas master: Add type annotations  https://review.opendev.org/c/openstack/neutron-vpnaas/+/91141211:12
lajoskatonaykarel, slaweq: could you please check when you have few free minutes the unmaintained/zed related patch in n-t-p: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/917696 ?11:52
ykarelack11:56
opendevreviewMerged openstack/neutron master: Add some swap to tox-cover job  https://review.opendev.org/c/openstack/neutron/+/92142012:24
opendevreviewMerged openstack/neutron master: Fix regex lines in zuul.d/* files  https://review.opendev.org/c/openstack/neutron/+/92130912:24
opendevreviewBrian Haley proposed openstack/neutron master: Change to use selectin for DB load strategy  https://review.opendev.org/c/openstack/neutron/+/92093313:35
ykarelhaleyb, depends-on will not work now as that's merged13:36
haleybykarel: i was going to ask slaweq about that, i wanted to run the experimental jobs yesterday but waited for gate fix13:36
ykarelyeap there are some experimental jobs which run with neutron-lib from source13:38
slaweqlajoskatona: done13:39
slaweqhaleyb what did you wanted to ask me?13:39
haleybslaweq: regarding the selectin neutron change, you mentioned to run experimental jobs. but i think it needed a depends-on. now that the neutron-lib change has merged, will experimental pick it up in test run?13:40
haleyblocally i can verify it passes unit tests with that change13:41
opendevreviewMerged openstack/neutron-tempest-plugin master: UM only: change zed to use unmaintained/  https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/91769613:46
opendevreviewBrian Haley proposed openstack/neutron master: Change OVN client to account for nested networks  https://review.opendev.org/c/openstack/neutron/+/90750414:41
ihrachyshaleyb about leader-only connection discussion (re backlog for ovs socket)15:25
haleybihrachys: hey15:26
ihrachyshaleyb assuming secondaries proxy to leader as needed (for writes), if we switch to secondaries, maybe it's better because now only secondaries will have to reconnect?15:26
ihrachysthe number of secondaries is like 2 or 4; compare to number of agents15:26
haleybihrachys: i'm just curious what the performance impact would be15:27
ihrachyssecondaries will be more loaded; leader will probably be less loaded (assuming number of chassis is higher than the number of members in raft)15:28
ihrachys(just a hunch, obv I don't have numbers)15:28
ihrachysalso probably some lag in request handling because secondaries now have to proxy?15:28
ihrachysotherwiseguy why do we connect to leader in raft?15:29
haleybihrachys: yeah, we typically have 3 members in cluster, but it's the connections from neutron-server threads that are the bulk of connections. total chassis (compute node) count is from 10-100 (?) at a guess15:31
haleybi'm willing to take any suggestions to our OVN team (one is in-channel here), just figured a small backlog bump would be a no-brainer15:32
ihrachyshaleyb ah you are saying it's north db that hits you? thought SB.15:37
haleybihrachys: port 6641, that's NB right?15:37
ihrachysyeah I mixed things; I think we had discussions with Ilya before about agents.15:40
haleybihrachys: and if making it configurable is the way, i guess that means ovsdb-server needs to have a new argument? as there is no config file argument afaik15:43
ihrachyshaleyb there is! Ilya implemented it in 3.2 or 3.315:49
ihrachysthere is now --config-file=file15:49
ihrachysit was added in context of inactivity probe setting but can be used for other things too. but I think now it's either config file or args, not both15:50
opendevreviewyatin proposed openstack/neutron master: [DNM] check lp #2067869  https://review.opendev.org/c/openstack/neutron/+/92109115:51
haleybihrachys: so then how do i backport that to an older version? pesky customers15:52
ihrachys:D downstream / for backports, maybe keep hardcoding15:56
haleybthat's unfortunately not how our tooling works, would mean a private archive i'd have to maintain for infinity, the whole upstream-first thing16:02
opendevreviewIhar Hrachyshka proposed openstack/neutron master: DNM: run all ovs connections as leader-only=false  https://review.opendev.org/c/openstack/neutron/+/92146116:27
ihrachyshaleyb I posted ^ for giggles but I now hear from Ilya that maybe it will just work. to quote, "perception of performance impact of connecting to a follower is a little outdated. ... I encourage you to scale test the non-leader-only and see."16:49
haleybslaweq: so i think the experimental jobs for selectin patch https://review.opendev.org/c/openstack/neutron/+/920933 looked ok? hard to exactly tell16:58
haleybihrachys: will just work as in non-leader-only? i wonder if anyone has tested it in production16:59
ihrachyshaleyb yes; I don't know, probably not :)17:02
haleybhey $large-telco, try this :-o17:03
ihrachyswhat could go wrong17:03
ihrachysin other news, lemme merge that selectin patch17:04
haleybi think the neutron-lib change merged, i'll have to propose a new version17:05
ihrachysI was just joking about one liners that blow up the world17:06
haleybi didn't even notice :)17:10
slaweqhaleyb I see that on this your patch it was using neutron-lib from master, in  e.g. job https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_357/920933/3/experimental/neutron-ovn-tempest-with-neutron-lib-master/357f9fa/job-output.txt19:38
slaweqso should be good19:38
slaweqif You want to see exactly what sql queries are made by neutron, You can configure in that job variable which will enable logging of all sql queries made by neutron19:39
slaweqlet me find example19:39
haleybslaweq: ack, thanks for looking. i'll get a neutron-lib release out to move things along19:39
slaweqhttps://review.opendev.org/c/openstack/neutron-tempest-plugin/+/890419/7/zuul.d/master_jobs.yaml19:40
slaweqthis was old patch hich enbled logging of sql queries in keystone, nova and neutron19:41
slaweqbut watch out - neutron server log file is about 1.5 GB on this patch IIRC19:41
haleyb8-o19:41
slaweqYou can do similar change in your patch in neutron-lib-master job and see then if patch really works19:42
slaweq:)19:42
ihrachyslol haleyb the patch to switch to leaderless connections just passed green like it's nothing https://review.opendev.org/c/openstack/neutron/+/92146119:59
ihrachysdo we have multinode raft jobs though?20:01
haleyb¯\_(ツ)_/¯20:49
haleybihrachys: https://review.opendev.org/c/openstack/releases/+/92147721:00
opendevreviewMerged openstack/neutron master: Bump oslo.service to 3.5.0  https://review.opendev.org/c/openstack/neutron/+/92107921:19

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!