opendevreview | Ihar Hrachyshka proposed openstack/neutron master: Fix regex lines in zuul.d/* files https://review.opendev.org/c/openstack/neutron/+/921309 | 00:38 |
---|---|---|
haleyb | ihrachys: i can take a look tomorrow, but i would like to get https://review.opendev.org/c/openstack/neutron-lib/+/920936 in if we are releasing neutron-lib, just need to test that first but depends on the gate being correct | 02:13 |
opendevreview | yatin proposed openstack/neutron master: Add some swap to tox-cover job https://review.opendev.org/c/openstack/neutron/+/921420 | 05:29 |
opendevreview | yatin proposed openstack/neutron master: Add some swap to tox-cover job https://review.opendev.org/c/openstack/neutron/+/921420 | 05:44 |
opendevreview | yatin proposed openstack/neutron master: Fix regex lines in zuul.d/* files https://review.opendev.org/c/openstack/neutron/+/921309 | 06:10 |
*** ykarel__ is now known as ykarel | 06:34 | |
slaweq | ykarel__ lajoskatona hi, can You check https://review.opendev.org/c/openstack/neutron-lib/+/920936 maybe? IMO it is good to go and neutron_tempest_plugin jobs there shows it should not break anything | 06:58 |
lajoskatona | slaweq: yes, alone it seems harmless :-) | 07:17 |
ykarel | ack slaweq | 07:23 |
slaweq | lajoskatona what do you mean by 'alone'? It was tested with neutron by the neutron-tempest-plugin jobs | 07:27 |
lajoskatona | slaweq: I mean without the neutron part of it to change the lazy to select-in | 07:29 |
slaweq | ahh, ok | 07:34 |
slaweq | so do You think we should wait with it and test it together with neutron change? | 07:35 |
slaweq | ykarel can You maybe check https://review.opendev.org/c/openstack/neutron-lib/+/920870/ also? Thx in advance | 07:35 |
ykarel | ack done | 07:39 |
opendevreview | yatin proposed openstack/neutron-lib master: Add neutron unit test job in check queue https://review.opendev.org/c/openstack/neutron-lib/+/921422 | 08:08 |
opendevreview | yatin proposed openstack/neutron master: [DNM] check cover job with swap https://review.opendev.org/c/openstack/neutron/+/920648 | 08:17 |
ykarel | lajoskatona, slaweq please check https://review.opendev.org/c/openstack/neutron/+/921420 | 08:21 |
lajoskatona | ykarel: done | 08:28 |
opendevreview | yatin proposed openstack/neutron-lib master: Add neutron unit test job in check queue https://review.opendev.org/c/openstack/neutron-lib/+/921422 | 08:42 |
opendevreview | Merged openstack/neutron-lib master: Add 'selectin' as a supported lazy relationship attribute https://review.opendev.org/c/openstack/neutron-lib/+/920936 | 09:19 |
opendevreview | Lajos Katona proposed openstack/neutron-tempest-plugin master: UM only: change zed to use unmaintained/ https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/917696 | 09:30 |
dpawlik | ykarel: hey o/ May I ask you to merge https://review.opendev.org/c/openstack/neutron/+/921035 ? | 10:11 |
dpawlik | ykarel: review is also welcome ;) | 10:11 |
dpawlik | cc haleyb | 10:12 |
ykarel | dpawlik, ack, there looks some issue in 2023.1 backport, that needs to be cleared | 10:16 |
opendevreview | Merged openstack/neutron-lib master: [api-ref] Add note about no validation of the target_tenant in RBAC API https://review.opendev.org/c/openstack/neutron-lib/+/920870 | 10:17 |
opendevreview | daniel.pawlik proposed openstack/neutron stable/2023.1: [ML2/OVN] Add gateway_port support for FIP https://review.opendev.org/c/openstack/neutron/+/921034 | 10:28 |
dpawlik | ykarel: ack. Fixed pep8, let's see the gates now | 10:29 |
ykarel | dpawlik, thx | 10:35 |
opendevreview | yatin proposed openstack/neutron stable/2024.1: [stable only] Fix KeyError in set_gateway_mtu https://review.opendev.org/c/openstack/neutron/+/921437 | 10:48 |
opendevreview | yatin proposed openstack/neutron stable/2023.2: [stable only] Fix KeyError in set_gateway_mtu https://review.opendev.org/c/openstack/neutron/+/921438 | 10:49 |
opendevreview | yatin proposed openstack/neutron stable/2024.1: [stable only] Fix KeyError in set_gateway_mtu https://review.opendev.org/c/openstack/neutron/+/921437 | 10:49 |
opendevreview | yatin proposed openstack/neutron stable/2023.2: [stable only] Fix KeyError in set_gateway_mtu https://review.opendev.org/c/openstack/neutron/+/921438 | 10:50 |
opendevreview | yatin proposed openstack/neutron stable/2023.2: [stable only] Fix KeyError in set_gateway_mtu https://review.opendev.org/c/openstack/neutron/+/921438 | 10:50 |
opendevreview | yatin proposed openstack/neutron stable/2023.2: [stable only] Fix KeyError in set_gateway_mtu https://review.opendev.org/c/openstack/neutron/+/921438 | 10:52 |
opendevreview | yatin proposed openstack/neutron stable/2023.2: [stable only] Fix KeyError in set_gateway_mtu https://review.opendev.org/c/openstack/neutron/+/921438 | 10:53 |
opendevreview | yatin proposed openstack/neutron stable/2023.2: [stable only] Fix KeyError in set_gateway_mtu https://review.opendev.org/c/openstack/neutron/+/921438 | 10:58 |
opendevreview | yatin proposed openstack/neutron stable/2023.1: [stable only] Fix KeyError in set_gateway_mtu https://review.opendev.org/c/openstack/neutron/+/921440 | 11:00 |
opendevreview | yatin proposed openstack/neutron unmaintained/zed: [stable only] Fix KeyError in set_gateway_mtu https://review.opendev.org/c/openstack/neutron/+/921441 | 11:00 |
opendevreview | Niklas Schwarz proposed openstack/neutron-vpnaas master: Add type annotations https://review.opendev.org/c/openstack/neutron-vpnaas/+/911412 | 11:06 |
opendevreview | Niklas Schwarz proposed openstack/neutron-vpnaas master: Add type annotations https://review.opendev.org/c/openstack/neutron-vpnaas/+/911412 | 11:12 |
lajoskatona | ykarel, slaweq: could you please check when you have few free minutes the unmaintained/zed related patch in n-t-p: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/917696 ? | 11:52 |
ykarel | ack | 11:56 |
opendevreview | Merged openstack/neutron master: Add some swap to tox-cover job https://review.opendev.org/c/openstack/neutron/+/921420 | 12:24 |
opendevreview | Merged openstack/neutron master: Fix regex lines in zuul.d/* files https://review.opendev.org/c/openstack/neutron/+/921309 | 12:24 |
opendevreview | Brian Haley proposed openstack/neutron master: Change to use selectin for DB load strategy https://review.opendev.org/c/openstack/neutron/+/920933 | 13:35 |
ykarel | haleyb, depends-on will not work now as that's merged | 13:36 |
haleyb | ykarel: i was going to ask slaweq about that, i wanted to run the experimental jobs yesterday but waited for gate fix | 13:36 |
ykarel | yeap there are some experimental jobs which run with neutron-lib from source | 13:38 |
slaweq | lajoskatona: done | 13:39 |
slaweq | haleyb what did you wanted to ask me? | 13:39 |
haleyb | slaweq: regarding the selectin neutron change, you mentioned to run experimental jobs. but i think it needed a depends-on. now that the neutron-lib change has merged, will experimental pick it up in test run? | 13:40 |
haleyb | locally i can verify it passes unit tests with that change | 13:41 |
opendevreview | Merged openstack/neutron-tempest-plugin master: UM only: change zed to use unmaintained/ https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/917696 | 13:46 |
opendevreview | Brian Haley proposed openstack/neutron master: Change OVN client to account for nested networks https://review.opendev.org/c/openstack/neutron/+/907504 | 14:41 |
ihrachys | haleyb about leader-only connection discussion (re backlog for ovs socket) | 15:25 |
haleyb | ihrachys: hey | 15:26 |
ihrachys | haleyb assuming secondaries proxy to leader as needed (for writes), if we switch to secondaries, maybe it's better because now only secondaries will have to reconnect? | 15:26 |
ihrachys | the number of secondaries is like 2 or 4; compare to number of agents | 15:26 |
haleyb | ihrachys: i'm just curious what the performance impact would be | 15:27 |
ihrachys | secondaries will be more loaded; leader will probably be less loaded (assuming number of chassis is higher than the number of members in raft) | 15:28 |
ihrachys | (just a hunch, obv I don't have numbers) | 15:28 |
ihrachys | also probably some lag in request handling because secondaries now have to proxy? | 15:28 |
ihrachys | otherwiseguy why do we connect to leader in raft? | 15:29 |
haleyb | ihrachys: yeah, we typically have 3 members in cluster, but it's the connections from neutron-server threads that are the bulk of connections. total chassis (compute node) count is from 10-100 (?) at a guess | 15:31 |
haleyb | i'm willing to take any suggestions to our OVN team (one is in-channel here), just figured a small backlog bump would be a no-brainer | 15:32 |
ihrachys | haleyb ah you are saying it's north db that hits you? thought SB. | 15:37 |
haleyb | ihrachys: port 6641, that's NB right? | 15:37 |
ihrachys | yeah I mixed things; I think we had discussions with Ilya before about agents. | 15:40 |
haleyb | ihrachys: and if making it configurable is the way, i guess that means ovsdb-server needs to have a new argument? as there is no config file argument afaik | 15:43 |
ihrachys | haleyb there is! Ilya implemented it in 3.2 or 3.3 | 15:49 |
ihrachys | there is now --config-file=file | 15:49 |
ihrachys | it was added in context of inactivity probe setting but can be used for other things too. but I think now it's either config file or args, not both | 15:50 |
opendevreview | yatin proposed openstack/neutron master: [DNM] check lp #2067869 https://review.opendev.org/c/openstack/neutron/+/921091 | 15:51 |
haleyb | ihrachys: so then how do i backport that to an older version? pesky customers | 15:52 |
ihrachys | :D downstream / for backports, maybe keep hardcoding | 15:56 |
haleyb | that's unfortunately not how our tooling works, would mean a private archive i'd have to maintain for infinity, the whole upstream-first thing | 16:02 |
opendevreview | Ihar Hrachyshka proposed openstack/neutron master: DNM: run all ovs connections as leader-only=false https://review.opendev.org/c/openstack/neutron/+/921461 | 16:27 |
ihrachys | haleyb I posted ^ for giggles but I now hear from Ilya that maybe it will just work. to quote, "perception of performance impact of connecting to a follower is a little outdated. ... I encourage you to scale test the non-leader-only and see." | 16:49 |
haleyb | slaweq: so i think the experimental jobs for selectin patch https://review.opendev.org/c/openstack/neutron/+/920933 looked ok? hard to exactly tell | 16:58 |
haleyb | ihrachys: will just work as in non-leader-only? i wonder if anyone has tested it in production | 16:59 |
ihrachys | haleyb yes; I don't know, probably not :) | 17:02 |
haleyb | hey $large-telco, try this :-o | 17:03 |
ihrachys | what could go wrong | 17:03 |
ihrachys | in other news, lemme merge that selectin patch | 17:04 |
haleyb | i think the neutron-lib change merged, i'll have to propose a new version | 17:05 |
ihrachys | I was just joking about one liners that blow up the world | 17:06 |
haleyb | i didn't even notice :) | 17:10 |
slaweq | haleyb I see that on this your patch it was using neutron-lib from master, in e.g. job https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_357/920933/3/experimental/neutron-ovn-tempest-with-neutron-lib-master/357f9fa/job-output.txt | 19:38 |
slaweq | so should be good | 19:38 |
slaweq | if You want to see exactly what sql queries are made by neutron, You can configure in that job variable which will enable logging of all sql queries made by neutron | 19:39 |
slaweq | let me find example | 19:39 |
haleyb | slaweq: ack, thanks for looking. i'll get a neutron-lib release out to move things along | 19:39 |
slaweq | https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/890419/7/zuul.d/master_jobs.yaml | 19:40 |
slaweq | this was old patch hich enbled logging of sql queries in keystone, nova and neutron | 19:41 |
slaweq | but watch out - neutron server log file is about 1.5 GB on this patch IIRC | 19:41 |
haleyb | 8-o | 19:41 |
slaweq | You can do similar change in your patch in neutron-lib-master job and see then if patch really works | 19:42 |
slaweq | :) | 19:42 |
ihrachys | lol haleyb the patch to switch to leaderless connections just passed green like it's nothing https://review.opendev.org/c/openstack/neutron/+/921461 | 19:59 |
ihrachys | do we have multinode raft jobs though? | 20:01 |
haleyb | ¯\_(ツ)_/¯ | 20:49 |
haleyb | ihrachys: https://review.opendev.org/c/openstack/releases/+/921477 | 21:00 |
opendevreview | Merged openstack/neutron master: Bump oslo.service to 3.5.0 https://review.opendev.org/c/openstack/neutron/+/921079 | 21:19 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!