Friday, 2015-03-13

*** annegentle has quit IRC00:02
*** markvoelker has quit IRC00:03
*** achanda has quit IRC00:03
*** iamjarvo has joined #openstack-nova00:04
openstackgerritKent Wang proposed openstack/nova: Adds Not Null constraint to KeyPair name  https://review.openstack.org/16323000:04
*** iamjarvo has quit IRC00:06
*** markvoelker has joined #openstack-nova00:08
*** Marga_ has quit IRC00:15
*** vmtrooper has joined #openstack-nova00:17
*** Longgeek has joined #openstack-nova00:18
*** angdraug has quit IRC00:18
*** claudiub has quit IRC00:20
*** vmtrooper has quit IRC00:22
*** pixelbeat has quit IRC00:27
*** Marga_ has joined #openstack-nova00:27
*** ybathia has quit IRC00:27
*** dims has joined #openstack-nova00:32
*** Longgeek has quit IRC00:32
*** dave-mccowan has quit IRC00:33
*** marun has quit IRC00:42
openstackgerritJoe Julian proposed openstack/nova: log meaningful error message on download exception  https://review.openstack.org/16403900:42
*** jaypipes has quit IRC00:45
*** dave-mccowan has joined #openstack-nova00:50
*** mwagner_lap has quit IRC00:53
openstackgerrityunhong-jiang proposed openstack/nova: Use VirtCPUModel in compute resource tracker.  https://review.openstack.org/14813900:54
*** liusheng has quit IRC00:56
*** annegentle has joined #openstack-nova00:58
*** asettle is now known as asettle-mtg01:00
*** ijw has joined #openstack-nova01:03
*** annegentle has quit IRC01:03
*** ijw has quit IRC01:05
*** ijw has joined #openstack-nova01:05
*** baoli has joined #openstack-nova01:07
*** promulo__ has joined #openstack-nova01:09
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Verify all quotas before updating the db  https://review.openstack.org/16366801:09
*** promulo has quit IRC01:12
*** rwsu is now known as rwsu-afk01:13
*** annashen has quit IRC01:19
*** apuimedo has quit IRC01:20
*** dsanders has quit IRC01:21
*** I has joined #openstack-nova01:25
*** I is now known as Guest5989701:25
*** otter768 has joined #openstack-nova01:27
openstackgerrityuntongjin proposed openstack/nova: Move policy enforcement into REST API layer for v2.1 api volume_attachment  https://review.openstack.org/15937601:29
*** otter768 has quit IRC01:32
*** dave-mccowan has quit IRC01:33
*** yamahata has quit IRC01:33
*** rmoe has quit IRC01:34
*** annashen has joined #openstack-nova01:39
*** amotoki has joined #openstack-nova01:39
*** park has joined #openstack-nova01:41
*** baoli has quit IRC01:42
*** baoli has joined #openstack-nova01:43
openstackgerritJosh Gachnang proposed openstack/nova: Add support for cleaning in Ironic driver  https://review.openstack.org/16147401:43
*** amotoki has quit IRC01:44
alex_xugmann: good morning, can you reach Ken'ichi, need some help from him :)01:44
*** popw has joined #openstack-nova01:45
*** gokrokve has joined #openstack-nova01:45
gmannalex_xu: good morning. actually he is not in yet.01:46
gmannalex_xu: ll tell him once he comes.01:46
alex_xugmann: ok, got it, waiting for him, thanks :)01:46
*** gokrokve_ has quit IRC01:49
*** gokrokve has quit IRC01:50
*** sdake has joined #openstack-nova01:50
*** rmoe has joined #openstack-nova01:51
*** tsekiyama has joined #openstack-nova01:52
*** sdake__ has joined #openstack-nova01:52
*** Marga_ has quit IRC01:53
*** sdake has quit IRC01:56
*** annegentle has joined #openstack-nova01:59
*** patrickeast has quit IRC02:02
*** Marga_ has joined #openstack-nova02:03
*** annegentle has quit IRC02:04
*** sbfox has joined #openstack-nova02:04
*** vmtrooper has joined #openstack-nova02:06
*** harlowja is now known as harlowja_away02:07
*** asselin has quit IRC02:09
*** david8hu has quit IRC02:10
*** david8hu has joined #openstack-nova02:10
*** asselin has joined #openstack-nova02:10
*** vmtrooper has quit IRC02:11
*** Madkiss has quit IRC02:11
*** Madkiss has joined #openstack-nova02:12
*** Madkiss has quit IRC02:12
*** Madkiss has joined #openstack-nova02:12
*** asettle-mtg has quit IRC02:13
dimscyeoh: alex_xu: In the nova meeting today, this microversion support in python-novaclient came up https://review.openstack.org/#/c/152569/ (http://eavesdrop.openstack.org/meetings/nova/2015/nova.2015-03-12-21.00.log.html). Please take a look if you get a chance. there was a question about service type (v2 vs v21) i think02:14
dimsthanks!02:14
*** dims has quit IRC02:14
alex_xudims, thanks, will take a look it asap02:15
*** marun has joined #openstack-nova02:16
*** Longgeek has joined #openstack-nova02:18
*** unicell has quit IRC02:19
*** annegentle has joined #openstack-nova02:19
*** andreykurilin has quit IRC02:22
*** andreykurilin has joined #openstack-nova02:22
*** marun has quit IRC02:22
*** ijw has quit IRC02:22
*** ozamiatin has quit IRC02:23
*** kudryashova has quit IRC02:23
*** kudryashova has joined #openstack-nova02:23
*** ozamiatin has joined #openstack-nova02:23
*** annegentle has quit IRC02:25
*** tsekiyama has quit IRC02:26
*** annegentle has joined #openstack-nova02:26
*** erkules_ has joined #openstack-nova02:26
openstackgerritYangLei proposed openstack/nova: Use the right instance object  https://review.openstack.org/16374502:27
*** tsekiyama has joined #openstack-nova02:27
*** ijw has joined #openstack-nova02:28
*** erkules has quit IRC02:29
*** ijw has quit IRC02:29
*** ijw has joined #openstack-nova02:30
*** baoli has quit IRC02:32
*** baoli has joined #openstack-nova02:32
openstackgerritShaoHe Feng proposed openstack/nova: remove the redundant policy check for SecurityGroupsOutputController  https://review.openstack.org/15936902:33
*** sbfox has quit IRC02:33
*** dims has joined #openstack-nova02:34
*** Longgeek has quit IRC02:35
*** tsekiyama has quit IRC02:36
*** haomaiwang has joined #openstack-nova02:38
*** kaisers1 has joined #openstack-nova02:38
*** dims has quit IRC02:39
*** kaisers has quit IRC02:40
*** devlaps has quit IRC02:43
*** achanda has joined #openstack-nova02:44
*** annegentle has quit IRC02:46
*** sdake__ has quit IRC02:49
*** baoli has quit IRC02:54
*** amotoki has joined #openstack-nova02:55
*** dsanders has joined #openstack-nova02:57
*** royce has joined #openstack-nova02:59
*** amotoki has quit IRC03:00
*** annashen has quit IRC03:05
*** annashen has joined #openstack-nova03:07
openstackgerritEli Qiao proposed openstack/nova: Handle exception when attaching interface failed  https://review.openstack.org/10917803:07
*** sdake has joined #openstack-nova03:08
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_count_reserved_ips  https://review.openstack.org/16162203:13
*** annashen has quit IRC03:18
*** jaypipes has joined #openstack-nova03:18
*** sdake__ has joined #openstack-nova03:19
*** nelsnelson has joined #openstack-nova03:19
*** annashen has joined #openstack-nova03:19
*** sbfox has joined #openstack-nova03:21
*** sdake has quit IRC03:22
*** gyee has quit IRC03:23
*** royce has quit IRC03:24
*** shyama has joined #openstack-nova03:27
*** otter768 has joined #openstack-nova03:28
*** xylan has joined #openstack-nova03:28
*** annashen has quit IRC03:30
*** Longgeek has joined #openstack-nova03:31
*** otter768 has quit IRC03:33
openstackgerritLingxian Kong proposed openstack/nova: Raise exception when using invalid az for vm creation  https://review.openstack.org/16384203:34
*** ijw has quit IRC03:36
*** diegows has quit IRC03:38
*** zzzeek has quit IRC03:40
*** annashen has joined #openstack-nova03:40
*** Longgeek has quit IRC03:41
*** asettle has joined #openstack-nova03:42
*** annashen has quit IRC03:43
*** annashen has joined #openstack-nova03:44
*** shyama has quit IRC03:46
*** shyama has joined #openstack-nova03:46
*** annashen has quit IRC03:47
*** tsekiyama has joined #openstack-nova03:49
*** annashen has joined #openstack-nova03:49
*** ijw has joined #openstack-nova03:51
*** Longgeek has joined #openstack-nova03:52
*** gokrokve has joined #openstack-nova03:53
*** ijw has quit IRC03:53
*** tsekiyama has quit IRC03:53
*** ijw has joined #openstack-nova03:53
openstackgerritJoe Gordon proposed openstack/nova: Stop installing everything to run pep8  https://review.openstack.org/16402003:55
*** vmtrooper has joined #openstack-nova03:55
*** nelsnelson has quit IRC03:57
*** annashen has quit IRC03:59
*** rushiagr_away is now known as rushiagr03:59
*** vmtrooper has quit IRC03:59
*** annashen has joined #openstack-nova04:04
*** annashen has quit IRC04:06
*** liusheng has joined #openstack-nova04:06
*** gokrokve has quit IRC04:09
*** sdake__ has quit IRC04:09
*** amotoki has joined #openstack-nova04:11
*** annashen has joined #openstack-nova04:11
*** amotoki has quit IRC04:15
*** Marga_ has quit IRC04:16
*** deepthi has joined #openstack-nova04:17
*** dsanders has quit IRC04:20
*** annashen has quit IRC04:23
*** unicell has joined #openstack-nova04:23
*** dboik_ has quit IRC04:34
*** Marga_ has joined #openstack-nova04:37
*** annashen has joined #openstack-nova04:39
openstackgerritJoe Gordon proposed openstack/nova: Stop installing everything to run pep8  https://review.openstack.org/16402004:43
*** mtanino has quit IRC04:46
*** Longgeek has quit IRC04:47
*** sbfox has quit IRC04:49
*** annashen has quit IRC04:54
*** annashen has joined #openstack-nova04:56
*** ijw has quit IRC05:05
*** coolsvap|afk is now known as coolsvap05:14
*** exploreshaifali has joined #openstack-nova05:14
*** swamireddy is now known as swamireddy_sick_05:16
*** vigneshvar has joined #openstack-nova05:24
*** asettle has quit IRC05:26
*** sbfox has joined #openstack-nova05:28
*** otter768 has joined #openstack-nova05:29
*** otter768 has quit IRC05:34
*** annashen has quit IRC05:37
*** exploreshaifali has quit IRC05:38
*** annashen has joined #openstack-nova05:40
*** Nikolay_St has quit IRC05:41
*** vmtrooper has joined #openstack-nova05:43
*** annashen has quit IRC05:44
*** exploreshaifali has joined #openstack-nova05:47
*** Longgeek has joined #openstack-nova05:48
*** vmtrooper has quit IRC05:48
*** sbfox has quit IRC05:48
*** annashen has joined #openstack-nova05:53
*** unicell has quit IRC05:53
*** lpetrut has joined #openstack-nova05:54
*** unicell has joined #openstack-nova05:54
*** veena has joined #openstack-nova05:55
*** exploreshaifali has quit IRC05:55
*** sbfox has joined #openstack-nova05:58
*** eliqiao has joined #openstack-nova06:05
*** ankit_ag has joined #openstack-nova06:10
*** achanda has quit IRC06:10
*** markvoelker has quit IRC06:11
*** annashen has quit IRC06:11
*** markvoelker has joined #openstack-nova06:12
*** achanda has joined #openstack-nova06:13
*** markvoelker has quit IRC06:16
*** Sukhdev has joined #openstack-nova06:18
*** vigneshvar has quit IRC06:19
*** Longgeek has quit IRC06:21
*** amotoki has joined #openstack-nova06:23
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex  https://review.openstack.org/16203006:23
*** armax has quit IRC06:25
openstackgerritChris Friesen proposed openstack/nova: Fix up server group policy validation  https://review.openstack.org/16274606:25
*** achanda has quit IRC06:28
*** oro_ has joined #openstack-nova06:29
*** oro has joined #openstack-nova06:29
*** royce has joined #openstack-nova06:33
*** achanda has joined #openstack-nova06:34
*** achanda has quit IRC06:38
*** markvoelker has joined #openstack-nova06:42
*** Sukhdev has quit IRC06:43
openstackgerritChris Friesen proposed openstack/nova: Fix "down" nova-compute service spuriously marked as "up"  https://review.openstack.org/16306006:44
*** rushiagr is now known as rushiagr_away06:45
*** markvoelker has quit IRC06:47
*** mrda is now known as mrda-weekend06:49
*** jcoufal has joined #openstack-nova06:51
gmannlifeless: does testscenario (testscenarios.WithScenarios) runs with nose?06:52
*** coolsvap is now known as coolsvap|afk06:54
*** browne has quit IRC06:57
*** romainh has joined #openstack-nova06:58
*** afazekas has joined #openstack-nova07:04
veenaHi, I cloned stable/icehouse and running tests using "tox -e py27" and stuck at "from oslo.serialization import jsonutils Unimplemented block at ../../relaxng.c:3825" for around 30 minutes. What does this imply? Is it hung? Am I missing anything?07:04
*** pkoniszewski has joined #openstack-nova07:07
*** bkopilov has quit IRC07:08
*** coolsvap has joined #openstack-nova07:09
*** romainh has left #openstack-nova07:09
*** Longgeek has joined #openstack-nova07:18
*** dims has joined #openstack-nova07:23
*** sbfox has quit IRC07:24
*** dims has quit IRC07:27
*** bkopilov has joined #openstack-nova07:28
*** otter768 has joined #openstack-nova07:30
*** sahid has joined #openstack-nova07:30
*** jamielennox has quit IRC07:31
*** oro_ has quit IRC07:32
*** bkopilov has quit IRC07:32
*** oro has quit IRC07:32
*** vmtrooper has joined #openstack-nova07:32
*** jamielennox has joined #openstack-nova07:34
*** ijw has joined #openstack-nova07:34
*** otter768 has quit IRC07:35
*** ijw has quit IRC07:35
*** ijw has joined #openstack-nova07:36
*** vmtrooper has quit IRC07:37
*** ijw has quit IRC07:38
*** ijw has joined #openstack-nova07:39
*** jamielennox has quit IRC07:39
*** mpavone has joined #openstack-nova07:39
*** Nikolay_St has joined #openstack-nova07:40
*** Longgeek has quit IRC07:41
*** Longgeek has joined #openstack-nova07:41
*** markvoelker has joined #openstack-nova07:43
*** lpetrut has quit IRC07:43
*** TobiasE has joined #openstack-nova07:44
*** apuimedo has joined #openstack-nova07:47
openstackgerritStephen Ahn proposed openstack/nova: libvirt: Rollback status when cold migrate failed  https://review.openstack.org/14426107:48
*** markvoelker has quit IRC07:48
*** exploreshaifali has joined #openstack-nova07:48
Anticimexwhere has https://blueprints.launchpad.net/nova/+spec/support-keystone-v3-api gone?07:50
Anticimexhow does one use keystone v3 ~everywhere today, but map this to nova if nova is stuck on v2 still?07:50
xylanhi, guys, I fired a bug in the launchpad, 'resize failed because of instance's invalid availability zone property', it's very easy to understand and reproduce.07:53
xylanthe patch is here: https://review.openstack.org/16384207:53
xylanvery appreciated that you can help to review and welcome any comments.07:53
*** jamielennox|away has joined #openstack-nova07:55
*** jamielennox|away is now known as jamielennox07:55
*** coolsvap has quit IRC07:59
*** markus_z has joined #openstack-nova08:00
*** xylan has quit IRC08:02
*** xylan has joined #openstack-nova08:02
*** dulek has joined #openstack-nova08:09
*** veena has quit IRC08:11
*** jistr has joined #openstack-nova08:12
*** matrohon has joined #openstack-nova08:21
*** openstackgerrit has quit IRC08:21
*** openstackgerrit has joined #openstack-nova08:21
openstackgerritHans Lindgren proposed openstack/nova: Replace conductor get_ec2_ids() with new Instance.ec2_ids attribute  https://review.openstack.org/15806608:24
openstackgerritHans Lindgren proposed openstack/nova: Add EC2Ids object and link to Instance object as optional attribute  https://review.openstack.org/14974608:24
openstackgerritHans Lindgren proposed openstack/nova: Remove unused metadata conductor parameter  https://review.openstack.org/14974708:24
openstackgerritHans Lindgren proposed openstack/nova: Remove and deprecate conductor get_ec2_ids()  https://review.openstack.org/14974908:24
*** adelinatuvenie has joined #openstack-nova08:28
*** jlanoux has joined #openstack-nova08:38
*** lpetrut has joined #openstack-nova08:39
*** obondarev_ has quit IRC08:42
*** obondarev has joined #openstack-nova08:42
*** markvoelker has joined #openstack-nova08:44
*** jistr has quit IRC08:46
*** vivekd has joined #openstack-nova08:48
*** markvoelker has quit IRC08:48
*** park has quit IRC08:52
*** lpetrut has quit IRC08:53
*** andreykurilin_ has joined #openstack-nova08:53
*** veena has joined #openstack-nova08:57
*** amotoki has quit IRC08:57
*** erkules_ is now known as erkules08:57
openstackgerritAlexis Lee proposed openstack/nova: Move InstanceClaimTestCase.test_claim_and_audit  https://review.openstack.org/13605408:57
*** erkules has quit IRC08:57
*** erkules has joined #openstack-nova08:57
openstackgerritAlexis Lee proposed openstack/nova: Update some ResizeClaimTestCase tests  https://review.openstack.org/13868608:57
openstackgerritAlexis Lee proposed openstack/nova: Use migration object in resource_tracker  https://review.openstack.org/7932408:57
*** jistr has joined #openstack-nova09:04
fricklerveena: The tox test runs for 30 minutes on a fast server, depending on your machine, it may also take much longer, did you try to wait for an hour and see whether it then finishes09:04
fricklerveena: the messages about namespace deprecation are to be expected09:05
*** pask81 has joined #openstack-nova09:07
bauzasveena: make sure you install all the required libs before running tox here http://docs.openstack.org/developer/nova/devref/development.environment.html09:09
bauzasveena: but in general, we don't run all the tests locally, only the ones that are changed09:10
openstackgerritRajesh Tailor proposed openstack/nova: Allow force-delete irrespective of VM task_state  https://review.openstack.org/16379809:12
*** ndipanov has joined #openstack-nova09:12
*** abhishekkk has joined #openstack-nova09:12
veenabauzas: Okay, thank you09:14
openstackgerritgaryk proposed openstack/nova: Compute: no longer need to pass flavor to the spawn method  https://review.openstack.org/16265209:16
*** Longgeek has quit IRC09:16
fricklerveena: what distro are you using? relaxng.c belongs to libxml2, I'm seeing a similar message on my local Gentoo box, but not on Ubuntu09:17
veenafrickler: am using Ubuntu 14.0409:18
openstackgerritgaryk proposed openstack/nova: libvirt: remove unnecessary flavor parameter  https://review.openstack.org/16294609:19
*** romainh has joined #openstack-nova09:19
*** mhorban has quit IRC09:20
*** amotoki has joined #openstack-nova09:20
*** lpetrut has joined #openstack-nova09:20
*** vmtrooper has joined #openstack-nova09:21
*** bnemec has quit IRC09:24
*** bnemec has joined #openstack-nova09:25
*** vmtrooper has quit IRC09:26
*** zz_johnthetubagu is now known as johnthetubaguy09:29
*** otter768 has joined #openstack-nova09:31
*** andreykurilin_ has quit IRC09:31
*** andreykurilin_ has joined #openstack-nova09:32
*** vivekd has quit IRC09:34
*** otter768 has quit IRC09:35
openstackgerritjichenjc proposed openstack/nova: Fix wrong log when reschedule is disabled  https://review.openstack.org/16412409:38
*** lpetrut has quit IRC09:42
*** dims has joined #openstack-nova09:42
*** lpetrut has joined #openstack-nova09:42
*** lpetrut has quit IRC09:43
*** markvoelker has joined #openstack-nova09:45
*** dims has quit IRC09:47
*** vigneshvar has joined #openstack-nova09:47
*** bkopilov has joined #openstack-nova09:49
*** markvoelker has quit IRC09:49
sahidndipanov: hi, can you have a look at this https://review.openstack.org/#/c/159106/09:49
sahidit is something we probably want to see merged09:50
ndipanovsahid, looking09:51
*** eglynn has joined #openstack-nova09:54
*** dims has joined #openstack-nova09:54
*** bkopilov has quit IRC09:55
*** royce has quit IRC09:56
*** lpetrut has joined #openstack-nova09:56
*** eglynn-officeafk has joined #openstack-nova09:57
veenafrickler: Could you get over that?09:57
*** derekh has joined #openstack-nova09:57
veenafrickler: am still stuck in that. But will wait for an hr as you suggested.09:58
*** TobiasE has quit IRC10:02
openstackgerritshihanzhang proposed openstack/nova: Fix AggregateCoreFilter return incorrect value  https://review.openstack.org/16412810:03
*** TobiasE has joined #openstack-nova10:04
*** moshele has joined #openstack-nova10:05
*** sluo_wfh has quit IRC10:08
*** igordcard_ has joined #openstack-nova10:13
*** moshele has quit IRC10:15
*** nellysmitt has joined #openstack-nova10:17
*** Longgeek has joined #openstack-nova10:17
*** vigneshvar has quit IRC10:19
*** lucasagomes has joined #openstack-nova10:21
*** lpetrut has quit IRC10:21
fricklerveena: Looks like tox might indeed be getting stuck somehow on 14.04, I would suggest using 12.04 when working with Icehouse10:25
*** Longgeek has quit IRC10:32
openstackgerritjichenjc proposed openstack/nova: Code clean up db.instance_get_all_by_host()  https://review.openstack.org/16413210:37
*** kolesovdv has joined #openstack-nova10:39
*** andreykurilin_ has quit IRC10:39
*** vigneshvar has joined #openstack-nova10:40
openstackgerritgaryk proposed openstack/nova: Neutron: configure requested amount of fixed_ips  https://review.openstack.org/16386410:41
*** aix has joined #openstack-nova10:44
openstackgerritAmandeep proposed openstack/nova: Server details include ID as well as Name  https://review.openstack.org/16413610:44
*** ildikov_ has quit IRC10:45
*** markvoelker has joined #openstack-nova10:46
openstackgerritSean Dague proposed openstack/nova: refactor policy fixtures to allow use of real policy  https://review.openstack.org/16171010:47
openstackgerritSean Dague proposed openstack/nova: implement user negative testing for flavor manage  https://review.openstack.org/16042310:47
veenafrickler: It worked for me :) Thanks10:48
*** markvoelker has quit IRC10:50
*** lpetrut has joined #openstack-nova10:50
*** jamielennox has quit IRC10:55
*** pixelbeat has joined #openstack-nova10:56
*** harlowja_away has quit IRC10:59
*** dulek_ has joined #openstack-nova11:00
*** erlon has joined #openstack-nova11:01
*** jamielennox|away has joined #openstack-nova11:02
*** jamielennox|away is now known as jamielennox11:02
*** dulek has quit IRC11:03
*** exploreshaifali has quit IRC11:03
*** mpaolino has joined #openstack-nova11:06
openstackgerritSean Dague proposed openstack/nova: Revert "Removed useless method _get_default_deleted_value."  https://review.openstack.org/16414011:06
openstackgerritSean Dague proposed openstack/nova: Revert "Removed useless method _get_default_deleted_value."  https://review.openstack.org/16414011:08
openstackgerritjichenjc proposed openstack/nova: use block_dev.get_bdm_swap_list in compute api  https://review.openstack.org/16414111:09
*** vmtrooper has joined #openstack-nova11:10
openstackgerritjichenjc proposed openstack/nova: Code clean up db.instance_get_all_by_host()  https://review.openstack.org/16413211:12
*** aysyd has joined #openstack-nova11:13
sdaguendipanov / johnthetubaguy - you guys up for a fast revert of a corrupt your data bug - https://review.openstack.org/#/c/164140/ ?11:13
*** jamielennox has quit IRC11:14
*** vmtrooper has quit IRC11:15
johnthetubaguysdague: makes sense, I can't remember the rule, can we just fast approve these?11:15
sdaguewell it's been out there long enough that I don't have an issue with waiting for 2 +2s11:16
sdaguebut I figured if both of you looked, that would be good11:16
johnthetubaguysdague: good point, just checked that11:16
sdagueI'll try to build some tests later today11:16
johnthetubaguysdague: I can't remember what we said about deprecating shadow tables now… I kinda remember it came up11:16
ndipanovwhat the...11:17
sdagueyeh, I think it did, but regardless, this was a change that assumed a certain integrity in our data, which did not exist11:17
johnthetubaguysdague: yep11:17
openstackgerritAmandeep proposed openstack/nova: Server details include ID as well as Name  https://review.openstack.org/16413611:18
*** aysyd has quit IRC11:20
ndipanovoh wow11:20
*** lpetrut has quit IRC11:21
lifelessgmann: I don't know. Nose ooes some risky things unittest API wise.11:22
lifelessgmann: WithScenarios is probably ok, though its preferred to use discovery layer multiplication which I rather suspect won't play nice with nose11:23
lifelessgmann: IMBW11:23
ndipanovsdague, shadow tables crap neads to die11:23
sdaguendipanov: so... no real complaint here on that11:23
*** pask81 has quit IRC11:23
sdaguebut that's a bigger fix11:24
*** jamielennox|away has joined #openstack-nova11:24
*** jamielennox|away is now known as jamielennox11:24
ndipanovsdague, yeah - just saying11:24
sdagueI'm going to try to get these tests to actually test things correctly as well11:24
ndipanovon a bright side I think no one is using it at all11:25
ndipanovfor good reasons11:25
openstackgerritPawel Koniszewski proposed openstack/nova: Add ability to pause instance during live migration  https://review.openstack.org/16383611:25
*** krykowski has joined #openstack-nova11:26
openstackgerritMike Durnosvistov proposed openstack/nova: libvirt: Resize down an instance booted from a volume  https://review.openstack.org/15296411:27
openstackgerritMike Durnosvistov proposed openstack/nova: libvirt: don't allow to resize down the default ephemeral disk  https://review.openstack.org/15864611:27
*** otter768 has joined #openstack-nova11:32
*** dave-mccowan has joined #openstack-nova11:32
*** bauzas is now known as bauwser11:32
*** otter768 has quit IRC11:36
*** haomaiwang has quit IRC11:37
*** eliqiao has quit IRC11:37
*** baoli has joined #openstack-nova11:41
veenaThere are no test cases related to nova/virt/libvirt/driver.py in nova icehouse release, There is no test_driver.py file in nova/tests/virt/libvirt. Are they ignored or implemented in some other files?11:41
*** ildikov_ has joined #openstack-nova11:43
*** baoli has quit IRC11:44
sdaguegit grep libvirt in nova/tests11:44
sdaguethere were a bunch of them11:44
*** baoli has joined #openstack-nova11:44
*** exploreshaifali has joined #openstack-nova11:45
bauwserveena: seriously ? mmm, and why not nova.tests.virt.libvirt.test_driver ? :)11:45
*** jcoufal_ has joined #openstack-nova11:45
bauwserveena: keep in mind that tests.unit has just been provided on last release11:46
*** markvoelker has joined #openstack-nova11:46
*** deepthi has quit IRC11:47
bauwserveena: oh right11:47
openstackgerritHans Lindgren proposed openstack/nova: Remove and deprecate unused conductor service calls  https://review.openstack.org/13366411:48
openstackgerritHans Lindgren proposed openstack/nova: Refactor some service tests and make them not require db  https://review.openstack.org/13366511:48
openstackgerritHans Lindgren proposed openstack/nova: Convert service and servicegroup to objects  https://review.openstack.org/13366311:48
openstackgerritHans Lindgren proposed openstack/nova: Add a fixture for the NovaObject indirection API  https://review.openstack.org/16414611:48
*** jcoufal has quit IRC11:49
*** vigneshvar has quit IRC11:51
veenabauwser: not tests/unit.11:51
veenabauwser: nova.tests.virt.drivers.test_driver.py would have been there11:51
*** markvoelker has quit IRC11:51
veenabauwser: Are those functions in driver.py tested in some other file? Why are they being ignored?11:52
*** dulek___ has joined #openstack-nova11:53
*** bkopilov has joined #openstack-nova11:53
*** IanGovett has joined #openstack-nova11:55
sdaguejohnthetubaguy / ndipanov ok, I think I've got a safety check test, but it needs some cleaning up, and I have an errand to run. So should have it posted in a couple of errors.11:55
sdaguehours11:55
johnthetubaguyawesome11:55
bauwserveena: do a git blame nova/tests/unit/virt/libvirt/test_driver.py on the master branch and you'll see old paths11:56
ndipanovsdague, cool11:56
*** dulek_ has quit IRC11:56
veenabauwser: I did a git clone of stable/icehouse. In stable/juno it is there. But not in icehouse11:57
*** mwagner_lap has joined #openstack-nova11:57
*** diegows has joined #openstack-nova11:57
bauwserveena: eh, just clone the repo, you'll have the stable branches within11:57
bauwserveena: ie. git clone https://github.com/openstack/nova, period.11:58
bauwserveena: and then git checkout <stable/branch>11:58
*** samueldmq has joined #openstack-nova11:59
*** mpaolino has quit IRC12:00
johnthetubaguydansmith: it would be good to catch up about the objects blueprint, seems like we are having patches after the feature proposal freeze, but otherwise we have all the big stuff merged now? Maybe it should be marked as implemented?12:00
veenabauwser: Doing that now. will update you12:01
*** lpetrut has joined #openstack-nova12:02
bauwsersdague: have you seen my comment on the scheduler log bug ?12:02
bauwsersdague: https://bugs.launchpad.net/nova/+bug/1431291 #212:03
openstackLaunchpad bug 1431291 in OpenStack Compute (nova) "Scheduler Failures are no longer logged with enough detail for a site admin to do problem determination" [High,Confirmed] - Assigned to Sylvain Bauza (sylvain-bauza)12:03
bauwsersdague: I was basically saying that instance_uuids were no longer part of the request_spec and we should rather find other way to provide a request ID12:03
bauwsersdague: so I was proposing to use the reservation_id field12:04
*** aysyd has joined #openstack-nova12:04
*** ndipanov is now known as ndipanoff12:04
*** igordcard_ has quit IRC12:05
*** markvoelker has joined #openstack-nova12:07
veenabauwser: Followed the steps Error - fatal: cannot stat path 'nova/tests/unit/virt/libvirt/test_driver.py': No such file or directory12:07
*** eliqiao has joined #openstack-nova12:08
openstackgerritRadoslav Gerganov proposed openstack/nova-specs: VMware: Native HTML5 consoles for VMware  https://review.openstack.org/12728312:08
*** rajesht has joined #openstack-nova12:09
*** lucasagomes is now known as lucas-hungry12:09
*** irenab has quit IRC12:10
*** irenab has joined #openstack-nova12:11
*** lpetrut has quit IRC12:13
*** Longgeek has joined #openstack-nova12:15
*** eliqiao has quit IRC12:16
bauwserveena: you didn't read what I said, do a git blame on the master branch12:17
bauwserveena: not on the icehouse stable branch12:17
*** vladikr has joined #openstack-nova12:18
*** bkopilov has quit IRC12:20
*** exploreshaifali has quit IRC12:23
*** TobiasE has quit IRC12:23
*** Marga_ has quit IRC12:24
*** edleafe is now known as figleaf12:25
*** raildo has joined #openstack-nova12:28
*** rajesht has quit IRC12:29
*** adelinatuvenie has quit IRC12:29
*** lpetrut has joined #openstack-nova12:30
*** Longgeek has quit IRC12:31
*** ferest has joined #openstack-nova12:32
*** rajesht has joined #openstack-nova12:34
figleafalaski: jaypipes-afk: new revision pushed for https://review.openstack.org/#/c/160507/ to address your concerns12:34
rajeshtdansmith: please review "Allow force-delete irrespective of VM task_state"12:35
rajeshtdansmith: https://review.openstack.org/#/c/163798/12:35
openstackgerritMike Durnosvistov proposed openstack/nova: Using Instance object instead of db call  https://review.openstack.org/14932212:35
*** lpetrut has quit IRC12:35
*** rajesht has quit IRC12:37
*** dprince has joined #openstack-nova12:42
figleafPaulMurray: the PciDevTracker bug fix merged, so your compute node init patch needs rebasing.12:47
openstackgerritMichal Rostecki proposed openstack/nova: Adding security groups to existing ports  https://review.openstack.org/16378012:48
*** kaufer has joined #openstack-nova12:49
*** toan-tran has joined #openstack-nova12:51
sahidjaypipes: hello, are you going to work on this or can i try to rebase and address comments ?12:55
sahidhttps://review.openstack.org/#/c/152689/12:55
*** mriedem_away is now known as mriedem12:58
*** vmtrooper has joined #openstack-nova12:59
*** veena has quit IRC13:00
*** dulek has joined #openstack-nova13:01
*** b3nt_pin is now known as seagulls13:01
*** dulek___ has quit IRC13:02
openstackgerritsahid proposed openstack/nova: compute: introduce binary constants  https://review.openstack.org/15736313:03
openstackgerritsahid proposed openstack/nova: db: clean tests to verify enable service option  https://review.openstack.org/16416813:03
*** lucas-hungry is now known as lucasagomes13:03
*** ildikov_ has quit IRC13:04
*** dkliban_afk is now known as dkliban13:04
*** dulek has quit IRC13:04
*** vmtrooper has quit IRC13:04
*** dulek_ has joined #openstack-nova13:04
*** Nikolay_St has quit IRC13:05
*** READ10 has joined #openstack-nova13:06
*** eharney has joined #openstack-nova13:06
openstackgerritwuhao proposed openstack/nova: Add previous page links for Nova GET servers API  https://review.openstack.org/16416913:06
*** xyang1 has joined #openstack-nova13:06
openstackgerritSylvain Bauza proposed openstack/nova: Remove FK on service_id and make service_id nullable  https://review.openstack.org/15531913:06
*** ildikov_ has joined #openstack-nova13:08
*** ijw has quit IRC13:09
*** exploreshaifali has joined #openstack-nova13:10
*** kolesovdv has quit IRC13:13
sdaguebauwser: request id is not useful13:14
sdaguethat's not a persistent thing13:14
bauwsersdague: erm agreed13:14
*** neelashah has joined #openstack-nova13:14
bauwsersdague: you're right, I was checking it13:14
bauwsersdague: I'm just wondering what is persisted so that a nova show could present it13:15
sdagueanyway, I'm writing the test case for the data corruption now, then I'll look about what kind of scheduler reporting is an option.13:15
*** vigneshvar has joined #openstack-nova13:15
bauwsersdague: as I said, there is only the first instance object which is provided in the request_spec dict13:15
*** rfolco has joined #openstack-nova13:15
*** markvoelker has quit IRC13:16
bauwsersdague: and that's also something I'm working on for the RequestSpec object BP13:16
*** lpetrut has joined #openstack-nova13:16
sdaguehonestly, first instance might be good enough in most cases13:17
*** markvoelker has joined #openstack-nova13:17
sdaguebut, I need to go do this other thing first13:17
bauwsersdague: then that's something I can add it13:19
*** park has joined #openstack-nova13:19
*** neelashah has quit IRC13:21
*** dboik has joined #openstack-nova13:21
*** Marga_ has joined #openstack-nova13:23
*** mpaolino has joined #openstack-nova13:24
jaypipessahid: I will work on that this weekend.13:25
bauwserweek*end*13:25
*** neelashah has joined #openstack-nova13:27
*** popw1 has joined #openstack-nova13:29
dansmithjohnthetubaguy: which patches are merging that you think are freeze-worthy?13:29
dansmithjohnthetubaguy: there are cleanups I still need to merge before kilo in order to get ready for o.vo, and I cleared those with folks yesterday on the meeting13:30
openstackgerritAbhishek Kekane proposed openstack/nova: Allow force-delete irrespective of VM task_state  https://review.openstack.org/16379813:30
sahidjaypipes: ack13:30
johnthetubaguydansmith: OK, those sound fine, just wondering what the blueprint tracking should look like13:31
*** mpaolino has quit IRC13:31
dansmithjohnthetubaguy: if you want to mark it as implemented and let me still merge a few more cleanups against it, then that's cool, but since it was an umbrella BP, marking it "implemented" seems like just an arbitrary thing we can do whenever you want :)13:32
*** mpovolny has joined #openstack-nova13:32
dansmithi.e. it doesn't represent a thing that is either done or not13:32
*** popw has quit IRC13:32
*** dulek has joined #openstack-nova13:32
*** otter768 has joined #openstack-nova13:33
*** dulek_ has quit IRC13:33
johnthetubaguydansmith: OK, I will check with ttx on tuesday, technically he has to review any exceptions, but I am fine with that13:37
johnthetubaguyfine with leaving it open, that is13:37
*** otter768 has quit IRC13:37
dansmithjohnthetubaguy: exceptions to being left open in LP you mean?13:37
dansmithjohnthetubaguy: these cleanups aren't an exception, they're "almost bugs" :)13:37
dansmithjohnthetubaguy: anyway, I need to get them proposed and then we can discuss their bugness or not13:38
johnthetubaguydansmith: ah, closing it off and treating it as an important-ish bug might work better then13:39
dansmithjohnthetubaguy: okay, I'll let you mind the process loopholes :)13:39
johnthetubaguylol13:40
dansmithjohnthetubaguy: so on this https://review.openstack.org/#/c/163798/213:40
dansmithjohnthetubaguy: allowing force_delete to bypass the task_state just means that a user can hammer the API because the delete isn't completing fast enough13:40
*** setuid has quit IRC13:40
dansmithjohnthetubaguy: I'm surprised you're okay with that premise13:40
johnthetubaguydansmith: yeah, I was just rethinking that idea… but I couldn't come up with a better idea yet13:41
dansmithjohnthetubaguy: well, admins can reset-state to clear it and let it try again13:41
dansmithjohnthetubaguy: I would like it to not be something that needs support intervention,13:42
dansmithbut I also know that given the opportunity to hit the button more, I'd do it13:42
*** dave-mccowan has quit IRC13:42
*** setuid has joined #openstack-nova13:43
dansmithjohnthetubaguy: we could have a configurable retry limit where if updated_at is more than 120 seconds old and task_state is deleting, then let them go again13:43
*** thomasem has joined #openstack-nova13:43
johnthetubaguydansmith: yeah, for such and edge case, I can see that being the best bet...13:43
*** abhishekkk has quit IRC13:43
johnthetubaguydansmith: sounds like too much effort, but I see your point13:43
bauwserjohnthetubaguy: you said tuesday about exceptions ?13:44
openstackgerritsahid proposed openstack/nova: compute: make test rpcapi more flexible  https://review.openstack.org/16417713:44
bauwserjohnthetubaguy: I had a question yesterday about tues vs. thurs for FF, but I don't remember what's it13:44
mriedemdansmith: johnthetubaguy: keep in mind that https://review.openstack.org/#/c/163515/ should keep us out of this state of not being able to delete error'ed instances a bit13:44
dansmithjohnthetubaguy: it just seems like a weird exception to make, why not let me retry a stop() command if I think it has been ignored?13:44
mriedemif we are getting stuck instances, we probably aren't reverting task state in the proper places on failure13:44
*** _gryf is now known as _gryf|afk13:44
dansmithmriedem: yes, the example in the commit message is for the message being lost because rabbit gets shot in the head,13:45
dansmithwhich this wouldn't cover right?\13:45
* dansmith checks rpcapi13:45
*** thomasem has quit IRC13:45
mriedemoh, well, then all bets are off i guess :)13:46
*** thomasem has joined #openstack-nova13:46
openstackgerritSean Dague proposed openstack/nova: Add shadow table empty verification  https://review.openstack.org/16417813:46
sdagueso that's the test case for the corruption issue that zzzeek posted about13:46
PaulMurrayfigleaf, thanks - already did rebase on it, so all good - pushing changes shortly13:46
figleafPaulMurray: ack13:46
dansmithmriedem: yeah, it's a cast13:47
johnthetubaguydansmith: I was assuming non-persistent queues so the message got lost with the rabbit reboot, and never made it to compute, but totally agreed its too aggressive13:48
*** mikehn_ has quit IRC13:48
dansmithjohnthetubaguy: right, I think that's the assumption in the patch13:48
johnthetubaguydansmith: I think we run persistent to avoid that, actually13:49
*** mikehn has joined #openstack-nova13:49
johnthetubaguyalthough I get confused about what that really means now…13:50
*** dboik has quit IRC13:50
dansmithjohnthetubaguy: so actually, I'm not sure that patch is doing what it thinks it is13:50
dansmithjohnthetubaguy: because it's setting task_state=None on the decorator, which I think equates to "must be None"13:50
*** dboik has joined #openstack-nova13:50
*** park has quit IRC13:51
dansmithoh, no it does, I was reading the decorator wrong the other day13:51
johnthetubaguydansmith: yeah, I had to re-read that too, (None,) is the other way13:52
dansmithwell, I had misread the bit at the top, which converted task_state to a set if it wasn't13:53
dansmithand I thought =None would become =(None,), but it won't13:53
johnthetubaguybauwser: the deadline is Thursday, but things that look very unlikely tend to get kicked out on the Tuesday, as with all deadlines we have really.13:53
*** ferest has quit IRC13:53
*** obutenko_ has joined #openstack-nova13:54
sdaguemriedem: you want to review the fix for your issue from yesterday - https://review.openstack.org/#/c/163970/ ?13:55
mriedemat some point13:55
mriedemseveral plates spinning atm13:55
sdagueok13:55
*** dave-mccowan has joined #openstack-nova13:56
alex_xujohnthetubaguy: emmm.....I think we can decide to defer db layer policy patches to L, still have about 30 patches. we can't merge them in one week.13:58
johnthetubaguyalex_xu: ah, understood, how do you want to handle that, if you WIP or abandon them, we can avoid the -2 faf?13:58
alex_xujohnthetubaguy: yes, I can WIP them, and tell the team set WIP them13:59
*** dansmith is now known as superdan13:59
*** thangp has joined #openstack-nova13:59
openstackgerritMichal Rostecki proposed openstack/nova: Adding security groups to existing ports  https://review.openstack.org/16378014:00
sahidjaypipes, superdan if you can add this into your queue, nothing hurry just a clean https://review.openstack.org/#/c/157363/14:00
alex_xujohnthetubaguy: v2.1 related policy patches just left 5 patches, still have chance finish them.14:00
johnthetubaguyalex_xu: cool, lets focus on those, I guess they are in the etherpad already? https://etherpad.openstack.org/p/kilo-nova-priorities-tracking14:00
alex_xujohnthetubaguy: no, I can update in that etherpad14:01
*** apuimedo has quit IRC14:01
superdansahid: my queueth overfloweth :/14:01
sahidsuperdan: ask you manager to give you budget for more memory :)14:02
superdanheh14:02
superdansahid: you know, we could make the constants be "service names" instead of "binaries"14:02
*** ankit_ag has quit IRC14:03
johnthetubaguyalex_xu: shall we merge this one? then mark the BP as partially complete? https://review.openstack.org/#/c/160269/14:03
superdansahid: mdbooth had comments on that verbiage, I wonder if it would be more clear if we intentionally had the discrepancy so people know what "binary" we're talking about14:03
*** jecarey has joined #openstack-nova14:03
mdboothsuperdan: Nah, I rowed back on that.14:04
sahidsuperdan: hum... i tried to keep the same convention with use for the query14:04
superdanmdbooth: I'm talking about sahid's patch14:04
mdboothsuperdan: Yeah, that's where I started on that particular review trail. Didn't I row back on that patch?14:04
mdboothCertainly intended to.14:04
superdanoh, I didn't realize you started from his patch14:05
superdanokay14:05
mdboothThe 'binary' moniker is from 201014:05
mdboothSo it's confusing, but not worth changing.14:05
superdanright, but he's adding constants which are really "service names" so even though changing the db layer would be heavy, we _could_ call the list of constants something else if it would make it clearer14:05
*** Nikolay_St has joined #openstack-nova14:05
*** apuimedo has joined #openstack-nova14:06
*** r-daneel has joined #openstack-nova14:06
mdboothsuperdan: Yeah, once I saw it came from the db, I decided that consistency was the best option14:06
superdanokay14:06
mdboothNothing worse than a thing with multiple names in different places14:06
superdanflavor and instance_type? :)14:06
alex_xujohnthetubaguy: it's ok merge it.14:06
*** mpovolny has quit IRC14:06
mdboothsuperdan: for eg14:06
superdanand then danpb using "flavour" in all his specs :)14:06
*** dims has quit IRC14:06
johnthetubaguyalex_xu: I will abandon the other ones that are "obvious"14:06
*** jaypipes is now known as leakypipes14:07
sahid:)14:07
*** dims has joined #openstack-nova14:07
*** shyama has quit IRC14:07
alex_xujohnthetubaguy: ok14:07
bauwsersuperdan: quick question, do I need to bump an Object version if I change a field to be nullable ?14:09
alex_xujohnthetubaguy: I updated the v2.1 patches in etherpad under " API v2.1 / microversions" section https://etherpad.openstack.org/p/kilo-nova-priorities-tracking14:09
superdanbauwser: yeah14:09
superdanbauwser: I'm going to start working on that patch for you as soon as I get coffee14:09
bauwsersuperdan: erm, why ? I would think it would be needed if I would change a field to be non-nullable - because previous clients could not provide it - but changing a field to be nullable just means that we leave the clients do or not14:10
bauwsersuperdan: old ones will still provide it14:11
johnthetubaguyalex_xu: ah, so the only ones we want before kilo for that blueprint (https://blueprints.launchpad.net/nova/+spec/v3-api-policy) are the ones on the etherpad, just to check?14:11
openstackgerritJohn Garbutt proposed openstack/python-novaclient: Adds support for x509 certificates as keypairs  https://review.openstack.org/13645814:12
*** pkoniszewski has quit IRC14:12
alex_xum/14:12
superdanbauwser: because if we try to pass a newer one with field=None to an older client, it needs to know to kick it back for backporting14:13
superdanbauwser: and then you have to figure out how to replace the value :)14:13
sdaguealex_xu: honestly, the db layer policy patches are pretty easy14:14
sdaguewhy don't you think we can actually get them up and merged14:14
bauwsersuperdan: mmm I see14:15
sdagueI'd rather get that bit finished than only be half finished in kilo.14:15
*** dboik has quit IRC14:15
*** Longgeek has joined #openstack-nova14:15
*** Ananci has joined #openstack-nova14:16
*** nelsnelson has joined #openstack-nova14:16
*** amotoki has quit IRC14:16
*** nelsnelson has quit IRC14:16
bauwsersuperdan: well, I was knowing that no new clients would have called the old ones by not providing a field, but that's understandable14:16
*** dboik has joined #openstack-nova14:16
bauwsersuperdan: here, the thing is that old Juno computes will provide a service_id field while new Kilo won't14:16
bauwsersuperdan: so that's why there will be no call from a new to an old14:16
alex_xusdague: there are a lot of patches https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/v3-api-policy,n,z14:17
bauwsersuperdan: but that's fine14:17
bauwsersuperdan: I'll provide the backport anyway14:17
superdanbauwser: yeah, but you shouldn't just cut the rules because you know that, IMHO.. gets too confusing down the road14:17
alex_xusdague: if we think we have confidence merge them, I will continue update them14:17
bauwsersuperdan: agreed, that's my point - I understand the rules, I'm not a freaky bad teacher doing heroin14:17
* alex_xu network is super slow, may drop the line anytime14:18
superdanbauwser: uh, what? :)14:18
*** afazekas has quit IRC14:18
*** vigneshvar has quit IRC14:18
bauwsersuperdan: eh, not heroin, metamphetamine14:18
bauwsersuperdan: sorry, just been binge watching Better Call Saul14:19
superdanhuh, I've never heard of that14:19
sdaguealex_xu: I'd say lets try to get them in14:20
bauwserBreaking Bad then ?14:20
*** dboik has quit IRC14:21
alex_xusdague: ok, glad to hear that :)14:21
sdaguealex_xu: instead of -1ing patches for that, I'd ask you to fix the patches in question14:21
*** bkopilov has joined #openstack-nova14:21
superdanbauwser: but the teacher didn't _do_ the meth, just cooked it...14:21
*** nelsnelson has joined #openstack-nova14:21
bauwsercall me Jesse and you would be Walter...14:21
*** dboik has joined #openstack-nova14:21
alex_xusdague: ok, will fix them soon14:21
superdanman, this took a weird turn.. :P14:21
bauwser:)14:21
*** dims is now known as dimsum__14:21
alex_xujohnthetubaguy: ^^ change the plan, continue update db layer patches14:22
dimsum__bauwser: i binge watched Breaking Bad. Better Call Saul seems ok so far14:23
johnthetubaguyalex_xu: OK, it would be good to get it all done if we can, I mean still work raising the most important fixes first14:23
*** Nikolay_St has quit IRC14:23
alex_xujohnthetubaguy: ok, got it14:23
sdagueit looks like the cells v2 stuff is basically just stacked on https://review.openstack.org/#/c/159266/ needing a config tweak?14:25
*** popw has joined #openstack-nova14:25
mriedemsdague: would be nice to get the cells job passing14:27
mriedemi have one patch up to fix one thing14:27
mriedemalaski: bauwser: was this still a thing being reviewed? http://logs.openstack.org/78/163978/1/check/check-tempest-dsvm-cells/f6d2cd2/logs/screen-n-api.txt.gz?level=TRACE#_2015-03-12_21_55_13_41714:27
*** popw1 has quit IRC14:27
mriedemi think that's a large majority of the remaining failures i'm seeing14:27
sdaguemriedem: patch url?14:28
alaskisdague: yep, going to be addressing that shortly14:28
mriedemhttps://review.openstack.org/#/c/157185/ ?14:28
mriedemyeah that's the one sdague ^14:28
alaskimriedem: yes, those two should fix it14:29
mriedemalaski: are you +2 on https://review.openstack.org/#/c/157185/ ?14:29
mriedemwell, let me just check jenkins14:29
mriedemstill busted http://logs.openstack.org/85/157185/7/check/check-tempest-dsvm-cells/8acbe4d/logs/screen-n-api.txt.gz?level=TRACE#_2015-03-11_12_18_37_77514:30
sdaguemriedem: so that doesn't change any tempest test failures14:31
sdagueit's 11 fails before that and 11 after14:31
alaskimriedem: there are two patches14:31
mriedemha14:31
mriedemoops14:31
openstackgerritAlex Xu proposed openstack/nova: Remove db layer hard-code permission checks for service_get_by_host*  https://review.openstack.org/15034914:32
alaskimriedem: but yes, I'm +2.14:32
mriedemthere are still UnexpectedVMStateErrors here http://logs.openstack.org/06/160506/5/check/check-tempest-dsvm-cells/09366dc/logs/screen-n-cell-region.txt.gz?level=TRACE14:32
*** aysyd has quit IRC14:32
mriedemlots of errors here: http://logs.openstack.org/06/160506/5/check/check-tempest-dsvm-cells/09366dc/logs/screen-n-api.txt.gz?level=TRACE14:32
*** Nakato has quit IRC14:33
*** Nakato has joined #openstack-nova14:34
*** ociuhandu has joined #openstack-nova14:35
alaskimriedem: yeah, we recently noticed that failure at the cells meeting yesterday.  For the negative tests that was fixed at some point and regressed so I need to dig in there14:35
alaskiI'm not sure on the other failures yet14:36
mriedemok14:36
*** aysyd has joined #openstack-nova14:36
mriedemif we could get that job passing, i say we make it voting so we don't have to untangle so much14:36
alaskiagreed14:36
*** thedodd has joined #openstack-nova14:36
mriedemi see the ceph job is recently regressed to14:37
mriedem*too14:37
alaskiwe've been chipping at the cells job, but haven't quite crossed the line yet14:37
*** tonytan4ever has joined #openstack-nova14:38
*** cbader has joined #openstack-nova14:40
*** Nikolay_St has joined #openstack-nova14:40
*** exploreshaifali has quit IRC14:42
bauwserdimsum__: mriedem: sorry folks, my pidgin client suffers from a no voice today14:44
bauwseralaski: I made a mistake on the 2nd patch where mriedem gave -1, we should no longer use ComputeNode.get_by_service_id14:46
bauwseroops14:46
*** amotoki has joined #openstack-nova14:46
openstackgerritAndrew Laski proposed openstack/nova: Add support for multiple database engines  https://review.openstack.org/15926614:46
openstackgerritAndrew Laski proposed openstack/nova: Use the proper database engine for nova-manage  https://review.openstack.org/16183314:46
*** shaohe_feng1 has joined #openstack-nova14:46
alaskibauwser: ok.  I haven't looked at that one yet14:46
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: Deprecate V1.1, add basic stuff for microversions  https://review.openstack.org/15256914:47
superdanbauwser: where is your bug for that service stuff?14:47
shaohe_feng1alex_xu:  hi14:47
openstackgerritAndrew Laski proposed openstack/nova: Objects: use setattr rather than dict syntax in remotable  https://review.openstack.org/16397414:48
openstackgerritAndrew Laski proposed openstack/nova: Add get_api_session to db api  https://review.openstack.org/16186614:48
openstackgerritAndrew Laski proposed openstack/nova: Split NovaPersistentObject mixin  https://review.openstack.org/16360514:48
bauwserbauwser: sorry which one ?14:48
bauwserargh14:48
*** alaski is now known as lascii14:48
*** vmtrooper has joined #openstack-nova14:48
shaohe_feng1hi all,14:48
* bauwser is becoming schizopheric14:48
*** thedodd has quit IRC14:48
bauwsersuperdan: sorry, which bug do you mention ?14:48
bauwsersuperdan: I have many todos in parallel :)14:48
*** Longgeek has quit IRC14:49
bauwsersuperdan: you mean the bp/detach-service stuff ?14:49
lasciisuperdan: I'm drawing a blank on how VERSION_ALIASES is used, is this correct here https://review.openstack.org/#/c/160507/12/nova/scheduler/rpcapi.py ?14:49
superdanbauwser: no I mean 143120114:49
superdanbauwser: your WIP patch claims to close that bug, but it should be partial-bug right?14:49
shaohe_feng1these 3 patches about V2.1  API policy are ready for a long time.14:50
shaohe_feng1https://review.openstack.org/#/c/149931/14:50
shaohe_feng1https://review.openstack.org/#/c/150280/14:50
shaohe_feng1https://review.openstack.org/#/c/150328/14:50
superdanlascii: we shouldn't set that alias until right before release14:50
shaohe_feng1any core can help review them?14:50
lasciisuperdan: ok, so the fact that it's already set is a problem?14:50
lasciisuperdan: well, incorrect at least14:51
superdanlascii: yeah, not necessarily a problem, but not correct14:51
bauwsersuperdan: nope, I checked and the error is fixed14:51
openstackgerritDan Smith proposed openstack/nova: Break out the child version calculation logic from obj_make_compatible()  https://review.openstack.org/16420614:52
bauwsersuperdan: I mean the recursive calls14:52
*** thedodd has joined #openstack-nova14:53
*** ildikov_ has quit IRC14:53
*** vmtrooper has quit IRC14:53
*** subscope has quit IRC14:53
superdanbauwser: oh you had another patch for the other half that already merged, right?14:53
superdanbauwser: but in this one, you still need to fix the version using my patch above, right?14:53
superdanbecause you're passing back too new of a compute_node, right?14:54
alex_xushaohe_feng1: thanks14:55
*** popw has quit IRC14:57
bauwsersuperdan: exactly14:59
bauwsersuperdan: I left a comment for it14:59
bauwsersuperdan: that's the only reason of WIP14:59
*** thangp has quit IRC14:59
superdanokay, I'm confused14:59
bauwsersuperdan: we should just move that helper either in the base class or elsewhere14:59
*** sdake has joined #openstack-nova15:00
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: WIP: assertJsonEqual for Timofey  https://review.openstack.org/16421015:00
bauwsersuperdan: re: the bug, I had 2 patches15:00
superdanOH, I was looking at an old PS15:00
superdanman, I thought I was crazy15:00
bauwsersuperdan: one has merged, the other is WIP due to the helper method I added15:00
bauwsersuperdan: oh ok15:00
superdanbauwser:  https://review.openstack.org/16420615:00
superdanbauwser: want me to rebase yours on that, or do you want to?15:00
bauwsersuperdan: that's a nice XMas gift15:00
bauwsersuperdan: feel free to do so, I just discovered a last outstanding issue with bp/detach-service which makes the completion of it very difficult before FF15:01
superdanokay, I will15:01
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for floating_ip_dns  https://review.openstack.org/15071015:02
openstackgerritShaoHe Feng proposed openstack/nova: enforce domain:update/delete policy for floating_ip_dns v2.1 REST API layer.  https://review.openstack.org/16023715:02
*** mriedem has quit IRC15:04
*** gokrokve has joined #openstack-nova15:04
*** pixelbeat has quit IRC15:05
* leakypipes fires up some Cult - She Sells Sanctuary15:05
leakypipesdigging in for a long day of reviews.15:06
openstackgerritDan Smith proposed openstack/nova: Fix ComputeNode backport for Service.obj_make_compatible  https://review.openstack.org/16386715:06
superdanbauwser: ^15:06
*** thedodd has quit IRC15:06
leakypipessuperdan: easy objects win: https://review.openstack.org/#/c/149322/15:07
bauwsersuperdan: ty15:07
*** pixelb has joined #openstack-nova15:08
superdanjohnthetubaguy: so that patch (from leakypipes) is an example of something against the blueprint, but which isn't a feature nor a bug, IMHO, but that we really don't need to block quite yet15:09
superdanjohnthetubaguy: what do you think?15:09
leakypipessuperdan: it's targeted at kilo-objects blueoprint.15:09
leakypipessuperdan: ah, sorry, yes, you just said that :)15:09
superdanleakypipes: I know, this morning johnthetubaguy was asking if he could mark that blueprint as implemented and stop approving patches against it, which is why I'm using this as an example15:09
superdanyeah :)15:10
leakypipessorry for the noise..15:10
leakypipessuperdan: reviewing your child version object patches now...15:10
bauwsersuperdan: leakypipes: I will have the same paperwork problem, because I need to nullify service_id in ComputeNode15:10
*** Marga_ has quit IRC15:10
leakypipesbauwser: right. I don't think we should be holding up things like this for paperwork problems.15:10
bauwserif I'm not able to remove the service_id field in the RT, it will defer the problem till Mmmm15:11
*** erlon has quit IRC15:11
bauwserbecause old 'Kilo' nodes will still have this field in it15:11
bauwserand Meuh ones won't15:11
bauwserI mean Lemming ones15:11
leakypipeslol15:12
superdanbauwser: is this something that just got missed in the detach-service blueprint?15:12
figleafbauwser: can I help with any of the detach stuff?15:12
*** nellysmitt has quit IRC15:12
*** mtanino has joined #openstack-nova15:13
*** jgrimm has quit IRC15:13
bauwsersuperdan: just to be clear, all the blueprint helped to use the host field instead of service_id and provide backwards compat15:13
*** jgrimm has joined #openstack-nova15:14
bauwsersuperdan: so atm, Juno computes are sending service_id only and Kilo ones are sending both service_id and host15:14
bauwsersuperdan: ideally, Kilo ones should only send host, not service_id15:14
superdandoes it really matter?15:14
leakypipessuperdan: +2 from me on both those obj_make_compat patches.15:14
bauwsersuperdan: that's due to https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L41715:15
bauwsersuperdan: not really, all the target objectives have been reached15:15
superdanleakypipes: thanks15:15
leakypipessuperdan: for you? any time.15:15
superdanleakypipes: <315:15
bauwsersuperdan: but it would defer the removal of the backwards compat by North instead of Meuh15:15
superdannorth?15:16
bauwserNxxx15:16
superdanoh, heh, not sure why you say that15:16
bauwserI don't have yet a super play of words15:16
johnthetubaguysuperdan: so I am honestly very torn with this, my personal preference says we should never really stop those kinds of patches… but technically it violates FPF, but its basically unenforceable, so I am mostly ignoring those details till FF, at which point, I think its ttx's call about what can merge, but it feels like a very similar level of risk as unit test fixups15:16
superdanhow does something we do in kilo matter to N?15:16
alex_xuadvertse the policy patch which ready to review and merge, on the top of etherpad https://etherpad.openstack.org/p/apipolicycheck15:17
bauwsersuperdan: I was maybe unclear, I will rephrase15:17
superdanjohnthetubaguy: I guess the question is whether FPF covers everything without a bug attached, or not15:17
bauwsersuperdan: once RT will stop writing service_id, it will need 2 cycles more to kill the compat code15:17
superdanjohnthetubaguy: because the kilo-objects blueprint is almost all "cleanups"15:17
superdanbauwser: why? can't we just ignore it if kilo nodes send it, but also send host?15:18
*** browne has joined #openstack-nova15:18
bauwsersuperdan: oic15:18
bauwsersuperdan: yeah, we can just say "eh, no matters"15:19
*** nkrinner has quit IRC15:19
superdanjohnthetubaguy: I can see us not merging any of these things after FF because of the potential for regressions (or really k3 would be more appropriate, IMHO)15:19
bauwsersuperdan: the last real important stuff is https://review.openstack.org/15531915:19
superdanjohnthetubaguy: anyway, we probably need to figure out what the word on that is going to be :)15:19
superdanbauwser: aye15:20
bauwsersuperdan: so indeed you're right, we can only assume that as host is provided since Kilo and we support N+1 compat, we can still remove the compat code by Meuh (Mxxx)15:20
superdanbauwser: is that ready? why hasn't leakypipes +W'd?15:20
superdanbauwser: right15:20
bauwsersuperdan: my bad, I only have a rookie level on rolling upgrades15:21
leakypipesbauwser: reviewing that now.15:21
bauwserleakypipes: your call15:21
superdanbauwser: it's all good :)15:21
johnthetubaguysuperdan: k3 = FF I think thats when we have to stop, but I am going with FPF doesn't stop clean up patches being proposed, but i am not sure thats what the "law" says, depends how you read it15:21
superdanjohnthetubaguy: oh, I thought k3 was a little later15:21
openstackgerritSean Dague proposed openstack/nova: remove unneeded teardown code  https://review.openstack.org/16421615:21
superdanjohnthetubaguy: okay, so do you want to get a ruling, or shall we use your call as the ruling? :)15:21
johnthetubaguysuperdan: not sure, honestly seems more effort than its worth, lets just worry about k3/FF at this point, FPF has happened in the sense that we don't have brand new feature code being proposed now, so I think we are good15:24
superdanjohnthetubaguy: okay, sounds good15:24
superdanleakypipes: +W15:25
* leakypipes goes to propose some brand new feature code... just to make things interesting. :)15:25
superdanleakypipes: don't be a hater.15:25
leakypipeslol15:25
superdan:)15:26
figleafleakypipes: care to review https://review.openstack.org/#/c/160507 again?15:26
leakypipesfigleaf: already on my list, yep.15:26
dimsum__figleaf: nice nick :)15:26
figleafleakypipes: thx15:26
figleafdimsum__: yours isn't too bad either :)15:27
*** thangp has joined #openstack-nova15:27
* bauwser wonders when someone will complain about finding nicks for a specific person15:28
*** tsekiyama has joined #openstack-nova15:28
openstackgerritRadoslav Gerganov proposed openstack/nova: VMware: Replace get_dynamic_property with get_object_property  https://review.openstack.org/16422015:28
*** erlon has joined #openstack-nova15:29
leakypipesbauwser: excellent work. +Wd.15:29
openstackgerritJay Pipes proposed openstack/nova: Fix PciDeviceDBApiTestCase with referential constraint checking  https://review.openstack.org/15667315:30
bauwserleakypipes: so I'm happy to say we can consider bp/detach-service as implemented for Kilo15:30
bauwserleakypipes: that will still require some further work for Liberty (remove service_id from RT and nullify it in ComputeNode) and Mxxx (remove compat' code) but that's fine, I'll open a new spec for it15:31
johnthetubaguybauwser: shall I mark it as partially complete for kilo now?15:32
bauwserjohnthetubaguy: your call15:32
johnthetubaguybauwser: is it complete for kilo?15:32
bauwserjohnthetubaguy: it's like the objects BP, we can't do all things by one release, due to compat15:32
leakypipesbauwser: yay! :)15:32
johnthetubaguybauwser: right, thats all good, so the kilo bit of work is complete, thats all we need to do15:32
leakypipesjohnthetubaguy: mark it complete. yeah. bauwser will open another one for the compat cleanup.15:33
bauwserjohnthetubaguy: yeah, what was targeted is now implemented, but as I said, there are further work for the future15:33
*** david-lyle_afk is now known as david-lyle15:33
bauwserjohnthetubaguy: at least, wait Jenkins to merge the code15:33
bauwserjohnthetubaguy: ie.https://review.openstack.org/#/c/155319/1415:33
johnthetubaguybauwser: yup, just added a comment to that effect15:33
bauwserjohnthetubaguy: ^ that's the last of the series15:33
*** otter768 has joined #openstack-nova15:33
bauwserjohnthetubaguy: awesome, ty15:34
johnthetubaguybauwser: thank you!15:34
bauwserjohnthetubaguy: btw. that one was not 'partially-implementing' in the commit msg, but rather 'implementing'15:34
*** mriedem has joined #openstack-nova15:34
johnthetubaguybauwser: not sure that actually works, but lets see15:35
*** rmoe has quit IRC15:35
*** zzzeek has joined #openstack-nova15:35
bauwserjohnthetubaguy: last question, as Liberty spec repo is open, shall I open a spec for compat code removal ?15:36
superdanUgh, you never want to see this for a one-line change: - Failed: 155015:36
johnthetubaguybauwser: can do, but not sure that needs a spec15:37
bauwserjohnthetubaguy: meaning that I'll open a new BP of course for Liberty, but shall I open a spec too ?15:37
*** adelinatuvenie has joined #openstack-nova15:37
bauwserjohnthetubaguy: yeah, that's basically removing fields and code branches15:38
bauwserjohnthetubaguy: that's very techy15:38
johnthetubaguybauwser: yeah, don't think it needs a spec though15:38
*** otter768 has quit IRC15:38
bauwserjohnthetubaguy: yeah, I thought about it, hence the DB migration landed by Kilo, in order to make it wouldn't require a spec15:39
*** thedodd has joined #openstack-nova15:39
johnthetubaguybauwser: maybe I am miss understand what you mean15:41
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for security_group_default_rule_destroy  https://review.openstack.org/16025715:41
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for security_group_default_rule_create  https://review.openstack.org/15071815:41
bauwserjohnthetubaguy: the whole idea of the BP is to replace a field by another one which wouldn't suffer from an explicit DB relationship15:42
*** jcoufal_ has quit IRC15:42
bauwserjohnthetubaguy: so I did that, and the last point was to make the old field nullable in DB - and remove that relationship15:42
johnthetubaguybauwser: oh, I thought you meant something difference, thats worth a spec15:42
*** dboik_ has joined #openstack-nova15:43
*** dboik has quit IRC15:43
bauwserjohnthetubaguy: nope, I mean I know that DB migration require a spec, that's it :)15:43
johnthetubaguybauwser: gotcha, I thought you meant like the RPC API compat code all over the place, ignore me15:43
*** mdbooth has quit IRC15:45
*** exploreshaifali has joined #openstack-nova15:46
openstackgerritjichenjc proposed openstack/nova: Add @wrap_exception() for 3 compute functions  https://review.openstack.org/15352315:46
*** Nikolay_St has quit IRC15:47
*** thedodd has quit IRC15:49
*** mdbooth has joined #openstack-nova15:50
*** armax has joined #openstack-nova15:52
*** unicell1 has joined #openstack-nova15:52
*** rmoe has joined #openstack-nova15:52
*** unicell has quit IRC15:53
*** hemna has joined #openstack-nova15:53
*** marun has joined #openstack-nova15:54
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_associate  https://review.openstack.org/16123415:54
openstackgerritShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_set_host  https://review.openstack.org/16162515:54
openstackgerritShaoHe Feng proposed openstack/nova: move the Netowrk V2 related api test from V21 to V2 test  https://review.openstack.org/16256415:54
mriedemndipanoff: should a DriverVolumeBlockDevice object always have connection_info set when attaching a volume after boot?15:54
ndipanoffmriedem, yes - it comes from cinder15:55
openstackgerritjichenjc proposed openstack/nova-specs: Delete version specified code suggestion  https://review.openstack.org/16422915:55
mriedemndipanoff: looks like attach stores it in the bdm object via the @update_db decorator15:55
mriedemok15:55
mriedemwe have a race with detach_volume where bdm.connection_info is None15:55
mriedemit's been around for a long time i think15:55
*** amotoki has quit IRC15:56
openstackgerritSean Dague proposed openstack/nova: remove unneeded teardown related code  https://review.openstack.org/16421615:56
openstackgerritSean Dague proposed openstack/nova: Add shadow table empty verification  https://review.openstack.org/16417815:56
ndipanoffmriedem, I saw a bug for that recently15:56
mriedemhttp://logs.openstack.org/93/156693/7/check/check-tempest-dsvm-postgres-full/d3b26e8/logs/screen-n-cpu.txt.gz?level=TRACE#_2015-03-12_16_38_17_56715:56
ndipanofflet me dig a bit15:56
ndipanoffor for something similar15:56
*** thedodd has joined #openstack-nova15:57
mriedemndipanoff: https://bugs.launchpad.net/nova/+bug/1431899 - i know i've seen this before and had POC changes up to try and recreate with more info15:57
openstackLaunchpad bug 1431899 in OpenStack Compute (nova) "TestEncryptedCinderVolumes fails with 'NoneType can't be decoded'" [Undecided,New]15:57
mriedemjust couldn't find the older bugs15:57
*** toan-tran has quit IRC15:59
*** Sukhdev has joined #openstack-nova15:59
ndipanoffmriedem, similar to https://bugs.launchpad.net/nova/+bug/1327218 ?15:59
openstackLaunchpad bug 1327218 in OpenStack Compute (nova) "Volume detach failure because of invalid bdm.connection_info" [High,Fix released]15:59
*** amotoki has joined #openstack-nova16:00
sdaguemdbooth: https://review.openstack.org/#/c/164178/ fixed, I did a bad merge and didn't realize that teardown was removed (I was removing it myself in the follow on patch)16:00
mriedemndipanoff: yeah16:00
ndipanoffmriedem, yeah... I don't know... we need a lock per method16:01
mdboothsdague: Yeah, guessed as much.16:01
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Verify all quotas before updating the db  https://review.openstack.org/16366816:01
mriedemndipanoff: i'll reopen markmc's old bug and dupe against that16:01
ndipanoffor per volume operation16:01
ndipanoffyes16:01
mriedemthen get a logstash query open16:01
ndipanoffthat would be a good place to start16:01
ndipanoffI'll look into fixing it16:01
ndipanoffbut no promises16:01
ndipanoff:)16:02
openstackgerritjichenjc proposed openstack/nova: Delete version specified code suggestion  https://review.openstack.org/16423416:03
mriedemndipanoff: get some sleep!16:04
mriedemit's the weekend16:04
mriedemor go out i guess16:04
*** sdake has quit IRC16:04
ndipanoffmriedem, sleep16:05
ndipanoffI'll take that option16:05
*** krykowski has quit IRC16:05
openstackgerritAndrew Laski proposed openstack/nova: Fix how service objects are looked up for Cells  https://review.openstack.org/16050616:08
lasciimriedem: bauwser still testing locally, but I think that update should eliminate the 500s and some traces16:09
shaohe_feng1hi  cores,  this is db policy api is ready:  https://review.openstack.org/#/c/161622/16:09
bauwserlascii: coolio16:09
lasciibauwser: I had previously fixed this in cells_api but since that's bypassed now...16:10
*** amotoki has quit IRC16:10
bauwserlascii: what's the change ?16:10
bauwserlascii: I can just git review -m it of course16:10
lasciibauwser: try/except in https://review.openstack.org/#/c/160506/6/nova/objects/service.py16:10
lasciiand an expected_exception wrapper on an rpcapi method16:11
*** browne has quit IRC16:11
bauwserlascii: minor nit, but shouldn't you add a unittest for this ?16:11
andreykurilinhi everyone! I'm testing microversioning stuff with my patch https://review.openstack.org/#/c/152569/ and found strange behavior of API side. As Feodor Tersin mentioned in comments, microversions work only for service_type == "computev21"16:12
lasciibauwser: yes, just seeing if it works atm16:12
bauwserlascii: yeah understood16:12
andreykurilinhow it works now: http://paste.openstack.org/show/192127/16:13
andreykurilinleackypipes:^16:14
openstackgerritJohn Garbutt proposed openstack/nova: Improve post_live_migrate error handling  https://review.openstack.org/12988116:15
*** rwsu-afk is now known as rwsu16:15
bauwserlascii: so you basically mimicated the exception to be handled correctly ?16:15
andreykurilinIs such logic correct?16:15
andreykurilinsdague: hi16:16
lasciibauwser: right.  not finding a host via cells routing would be the same as not finding it in a non cells setup, so we just need to translate the exception16:17
andreykurilinjogo: hi16:17
sdagueandreykurilin: yes, we probably need to tweak the service end point for those tests16:18
openstackgerritAndrew Laski proposed openstack/nova: Fix how service objects are looked up for Cells  https://review.openstack.org/16050616:19
lasciibauwser: now with a test16:19
leakypipessdague: there should be no new "service_type" for microversions... should just continue to be "compute", no?16:19
sdagueleakypipes: if devstack sets up the service catalog correctly16:20
sdaguehowever, right now, the compute entry is the v2 endpoint still16:20
sdagueI think there is a patch to flip that16:20
bauwserlascii: awesome ty16:21
*** amotoki has joined #openstack-nova16:22
*** jogo is now known as flashgordon16:22
*** tjones1 has joined #openstack-nova16:22
*** sdake has joined #openstack-nova16:23
bauwserlascii: something is still unclear with that change, does that mean that any exception raised on a child cell is returned as as CellRoutingInconsistency exception or is it only for some additional cases ?16:24
bauwserlascii: to rephrase, what are the cases where that exception is raised ? typically when states are incorrect?16:24
andreykurilinsdague: why additional endpoint is needed?16:25
bauwserlascii: nm, I'm reading the code, gotcha16:25
mriedemshouldn't auth_password for the bdm be scrubbed from the logs here?16:26
mriedemhttp://logs.openstack.org/93/156693/7/check/check-tempest-dsvm-postgres-full/d3b26e8/logs/screen-n-cpu.txt.gz#_2015-03-12_16_44_54_87616:26
*** amotoki has quit IRC16:27
*** sahid has quit IRC16:27
openstackgerritPaul Murray proposed openstack/nova: Use compute_node consistently in ResourceTracker  https://review.openstack.org/15976516:29
openstackgerritPaul Murray proposed openstack/nova: Cleanups for pci stats in preparation for RT using ComputeNode  https://review.openstack.org/16184316:29
openstackgerritPaul Murray proposed openstack/nova: Convert RT compute_node to be a ComputeNode object  https://review.openstack.org/16094216:29
openstackgerritPaul Murray proposed openstack/nova: Move ComputeNode creation at init stage in ResourceTracker  https://review.openstack.org/14890416:29
*** sbfox has joined #openstack-nova16:30
*** sbfox has quit IRC16:31
*** sbfox has joined #openstack-nova16:32
*** Longgeek has joined #openstack-nova16:34
*** dulek has quit IRC16:34
*** dboik_ has quit IRC16:36
*** lpetrut has quit IRC16:37
*** dboik has joined #openstack-nova16:37
*** vmtrooper has joined #openstack-nova16:37
openstackgerritAndrey Kurilin proposed openstack/python-novaclient: Deprecate V1.1, add basic stuff for microversions  https://review.openstack.org/15256916:37
openstackgerritDan Smith proposed openstack/nova: Remove usage of remotable context parameter in agent, aggregate  https://review.openstack.org/16424316:39
openstackgerritDan Smith proposed openstack/nova: Remove usage of remotable context parameter in bandwidth, block_device  https://review.openstack.org/16424416:39
openstackgerritDan Smith proposed openstack/nova: Remove usage of remotable context parameter in ec2 object  https://review.openstack.org/16424516:39
openstackgerritDan Smith proposed openstack/nova: Remove usage of remotable context parameter in fixed_ip, flavor, floating_ip  https://review.openstack.org/16424616:39
openstackgerritDan Smith proposed openstack/nova: Remove usage of remotable context parameter in instance* objects  https://review.openstack.org/16424716:39
openstackgerritDan Smith proposed openstack/nova: Remove usage of remotable context parameter in compute_node, keypair  https://review.openstack.org/16424816:39
openstackgerritDan Smith proposed openstack/nova: Remove usage of remotable context parameter in migration, network  https://review.openstack.org/16424916:39
bauwserfigleaf: sorry but I had to leave -1 for your no-op methods16:39
openstackgerritDan Smith proposed openstack/nova: Remove usage of remotable context parameter in pci_device, quotas  https://review.openstack.org/16425016:39
openstackgerritDan Smith proposed openstack/nova: Remove usage of remotable context parameter in security_group*  https://review.openstack.org/16425116:39
openstackgerritDan Smith proposed openstack/nova: Remove usage of remotable context parameter in service, tag, vif  https://review.openstack.org/16425216:39
openstackgerritDan Smith proposed openstack/nova: Actually stop passing context to remotable methods  https://review.openstack.org/16425316:39
*** pkoniszewski has joined #openstack-nova16:39
bauwserfigleaf: erm, was obfuscated by a long chain16:40
figleafbauwser: I was specifically asked to separate them out16:40
bauwserfigleaf: as I said, could you pleasy very quickly flip the logic of your series and do the methods before calling thme ?16:40
bauwserfigleaf: yeah this is good, but you should first provide the methods, and call them afterwards16:41
*** melwitt has joined #openstack-nova16:41
*** kaufer has quit IRC16:41
bauwserfigleaf: we're 3 working days before FF, that sounds extremely risky16:41
bauwserfigleaf: and CI will probably be drained by the last 2 days16:42
*** vmtrooper has quit IRC16:42
bauwserfigleaf: hence my ping, as I said, I'm ready to cast you my vote once you do that16:42
figleafbauwser: ok, give me a few minutes to get that worked out and tested16:42
bauwserfigleaf: sure16:42
bauwserlascii: see above ^16:43
bauwserlascii: I would appreciate if you could give again your +2 once the flip is done16:43
*** ttx has quit IRC16:43
*** ttx has joined #openstack-nova16:43
*** Marga_ has joined #openstack-nova16:46
*** pkoniszewski has quit IRC16:46
openstackgerritMatthew Booth proposed openstack/nova: Fix PciDeviceDBApiTestCase with referential constraint checking  https://review.openstack.org/15667316:47
bauwserfigleaf: reviewing your HostManager change btw.16:48
figleaf!106816:48
openstackfigleaf: Error: "1068" is not a valid command.16:48
figleafugh16:48
*** iamjarvo has joined #openstack-nova16:48
figleaftoo many freakin' windows open...16:49
*** matrohon has quit IRC16:49
bauwser:)16:49
*** mestery has quit IRC16:50
*** mpaolino has joined #openstack-nova16:50
*** mestery has joined #openstack-nova16:51
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Stop spamming logs when creating context  https://review.openstack.org/16426116:54
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Stop spamming logs when creating context  https://review.openstack.org/16426116:55
*** Longgeek has quit IRC16:56
*** harlowja has joined #openstack-nova16:57
*** kaufer has joined #openstack-nova17:01
lasciibauwser: sure, I'll review it once it's pushed17:02
*** sahid has joined #openstack-nova17:02
sdaguedimsum__: so I'm +A on this - https://review.openstack.org/#/c/164261 however, the warning itself is honestly kind of useless. What is a log consumer going to do about that? So probably a better follow on would be a way in testing that could cause a fatal exception17:03
*** jlanoux has quit IRC17:03
sdagueso that we know we don't ever do that by accident in the code17:04
openstackgerritTimofey Durakov proposed openstack/nova: Fixed archivation of deleted records  https://review.openstack.org/16426317:04
dimsum__sdague: yep, agreed17:04
*** mpovolny has joined #openstack-nova17:06
*** browne has joined #openstack-nova17:07
*** mpavone has quit IRC17:07
*** iamjarvo has quit IRC17:08
superdansdague: mriedem: https://github.com/openstack/nova/blob/master/nova/tests/unit/api/ec2/test_ec2utils.py#L2917:08
superdanany idea how that is working?17:08
tdurakovsdague: Hi Sean. I send patch for review: https://bugs.launchpad.net/nova/+bug/143157117:08
openstackLaunchpad bug 1431571 in OpenStack Compute (nova) "archive_deleted_rows_for_table relies on reflection to access the "default" for soft-delete columns, but this is not a server default" [Critical,In progress] - Assigned to Timofey Durakov (tdurakov)17:08
superdanit's a nodb test, no mocks for the db methods, but it's creating an EC2 object17:08
sdaguesuperdan: it only works because you didn't review my fix from yesterday17:09
mriedemsuperdan: that's similar to what i was seeing yesterday17:09
mriedemright17:09
superdanWAT17:09
tdurakovsdague: you are in reviewers17:09
sdaguesuperdan: https://review.openstack.org/#/c/163970/17:09
superdanzomg17:09
sdagueI did ask people a few times to review that one yesterday :)17:10
sdaguetdurakov: we already fixed that via a revert (landed) and have new test cases up in https://review.openstack.org/#/c/164178/17:10
superdansdague: yes and all I did yesterday was goof off, right? :)17:10
sdague:)17:11
*** mpaolino has quit IRC17:11
sdaguenope, but anyway, the reason why it works is because of a bug in that fixture. That patch closes that bug, and makes a bunch of tests require the db again to pass.17:11
mriedemsdague: ok i didn't realize you were going to switch things back to requiring the db17:11
sdaguemriedem: that's kind of what you have to do17:12
mriedemsdague: so that just enforces that those have to be db tests until fixed?17:12
*** sbfox has quit IRC17:12
tdurakovsdague: It wont help17:12
sdaguethere are folks that are scrubbing out the db need in tests17:12
sdaguetdurakov: yes, it will17:12
tdurakovsdague: tests a correct17:12
sdagueno, the tests are wrong17:12
superdansdague: mriedem: some of those must have just been done with no actual inspection17:12
mriedemthey weren't17:13
superdansdague: mriedem: like, I made it a NoDB test and it passed, so it must not need db17:13
mriedemyeah17:13
tdurakovthe problm was in insert from select statement17:13
sdaguetdurakov: no, that's a different problem17:13
mriedemsuperdan: i had pointed out in one of the bugs why it wouldn't work17:13
*** Nic has joined #openstack-nova17:13
sdaguetdurakov: there is another bug17:13
mriedemanyway +W17:13
mriedemi'm trying to dig out from this detach_volume gate turd17:13
tdurakovsdague: have you seen my patch?17:13
sdaguetdurakov: https://bugs.launchpad.net/nova/+bug/1183523 is I think what you are trying to fix17:14
openstackLaunchpad bug 1183523 in OpenStack Compute (nova) "db-archiving fails to clear some deleted rows from instances table" [Medium,Confirmed]17:14
sdaguebut there is a deeper issue of the archive inspection being wrong17:14
sdaguewhich is the corruption issue17:14
*** iamjarvo has joined #openstack-nova17:14
*** annashen has joined #openstack-nova17:15
tdurakovsdague: the problem is deeper, I found it when experiment with random PYTHONHASHSEEDS17:15
openstackgerritDan Smith proposed openstack/nova: Remove context from remotable call signature  https://review.openstack.org/16426817:15
*** patrickeast has joined #openstack-nova17:16
*** mpaolino has joined #openstack-nova17:16
sdaguetdurakov: ok, so, regardless, I think your patch has to be rebased, because I'm pretty sure it will be in merge conflict with existing code17:17
*** ildikov has joined #openstack-nova17:17
tdurakovsdague: no17:17
tdurakovjust rebase to master17:17
tdurakovbefore send for review17:18
sdagueyeh so - deleted_column.default.arg is definitively wrong17:18
sdaguethat's actually the bug17:19
tdurakovsdague: why?17:19
sdaguebecause of the email thread17:19
superdannot because of the email thread :)17:19
sdaguebecause I'm not going to reexplain the email thread in irc :)17:19
openstackgerritQin Zhao proposed openstack/nova: Make resize api of compute manager to send flavor object  https://review.openstack.org/16186017:19
superdanoooh, that :P17:19
*** markus_z has quit IRC17:20
*** oro_ has joined #openstack-nova17:21
*** oro has joined #openstack-nova17:21
*** sdake__ has joined #openstack-nova17:24
tdurakovsdague: I get deleted column from table that was loaded from metadata,not db17:24
lxslileakypipes: hi could you glance over https://review.openstack.org/#/c/136054/ when you have a min please? thanks17:26
leakypipeslxsli: already on my list (about 9 down from the top)17:26
tdurakovsdague: could you check it?17:26
sdaguetdurakov: ok, then this needs some more inline commentary about why that's safe in this case, because the last code was assumed to be. I'd also like to see additional tests for this.17:26
lxslileakypipes: awesome, thanks :)17:26
sdagueit does seem to pass my tests that the other code failed17:27
sdagueit should sit on top of - https://review.openstack.org/#/c/16417817:27
sdagueso it has to pass those modified tests17:27
*** sdake has quit IRC17:28
tdurakovsdague: thanks for patience^)17:28
*** eharney has quit IRC17:30
*** erlon has quit IRC17:31
*** jistr has quit IRC17:31
sdaguetdurakov: ok, so final comment left, there are things I'd like enhanced on that, so that we don't end up here again17:31
sdaguebut I do agree, that code is functionally correct now17:31
*** achanda has joined #openstack-nova17:33
*** otter768 has joined #openstack-nova17:34
*** bkopilov has quit IRC17:34
*** bkopilov has joined #openstack-nova17:35
openstackgerritTimofey Durakov proposed openstack/nova: Fixed archivation of deleted records  https://review.openstack.org/16426317:36
*** otter768 has quit IRC17:39
superdantdurakov: can you s/archivation/archiving/ ?17:39
superdantdurakov: "archivation" isn't actually a word, although it is something I would say :)17:40
*** adelinatuvenie has quit IRC17:40
*** Marga_ has quit IRC17:40
tdurakovsuperdan: ok, I'll fix  commit message17:41
superdanthanks17:41
*** Marga_ has joined #openstack-nova17:41
tdurakovsuperdan: although it is something I would say - what?)17:41
superdantdurakov: I'm not sure how to explain it, we'd need to find some english major probably17:42
*** johnthetubaguy is now known as zz_johnthetubagu17:42
superdantdurakov: it's not a word, but it's based on a real word, with a suffix17:42
*** eglynn has quit IRC17:42
figleaftdurakov: "It's a mistake to say that, but I'd probably make the same type of mistake"17:42
*** eharney has joined #openstack-nova17:42
tdurakovsdague: seen your comment, could you give me details of extra tests you want?17:43
superdantdurakov: yeah, what figleaf said :)17:43
superdanwell,17:43
superdannot realy17:43
*** BobBall is now known as BobBall_AWOL17:43
superdanfigleaf: I know it's wrong, but I would sometimes say the wrong word to be funny17:43
*** bkopilov has quit IRC17:43
superdanfigleaf: so not a mistake17:43
superdananyway, I'm overcomplicating the fix :)17:44
figleafsuperdan: heh17:44
*** bkopilov has joined #openstack-nova17:44
figleafsuperdan: I didn't know how else to explain self-deprecation17:44
melwittsdague: I noticed in novaclient tox -epep8 doesn't run on stuff under tests/functional. do you know how it works in nova, to not run functional tests by default yet run pep8 on the functional tests?17:44
superdanfigleaf: well, I was stuck trying to figure out what the language manipulation was called when you do something like "robust + ify = robustify"17:44
*** derekh has quit IRC17:45
superdanverbification?17:45
sdaguetdurakov: we should bulk populate more tables besides the instance_type one that gets default rows17:45
sdaguethen run archive and make sure all those rows stay17:45
sdaguebecause this is now going to assume all the model definitions are correct, which they may not be17:45
leakypipessdague: did you have a patch up that addressed the whole NoDBTestCase messy stuff? I think you had mentioned you wanted to do that yesterday instead of revert the NoDBTestCase thing from Mike_D_wk. is that right?17:46
*** ybathia has joined #openstack-nova17:46
sdagueleakypipes: yes, see https://review.openstack.org/#/c/163970/17:46
superdansdague: lol17:46
figleafsuperdan: I've heard of verbing a noun, but verbing an adjective?17:46
superdansdague: you need a better publicist17:46
superdanfigleaf: well, right17:46
*** Marga_ has quit IRC17:46
leakypipessdague: ty sir.17:47
sdaguesuperdan: yeh, seriously, I've been asked about the same patch how many times today :)17:47
superdansdague: oh that reminds me17:47
superdansdague: didn't you have a patch to fix the nodbtest stuff?17:47
* sdague glares17:47
superdanheh17:47
tdurakovsdague: ok, I'll add more entities to check, you also wrote, that you want explanation, why this works, comment in gerrit will be OK for that?17:48
*** angdraug has joined #openstack-nova17:48
*** sahid has quit IRC17:49
sdaguetdurakov: honestly, I think we should put code comments in for it17:49
sdaguebecause I can see someone deciding it's better to use the real db again some time in the future17:50
sdagueand not realizing that actually causes db corruption17:50
tdurakovunderstand)17:50
*** bkopilov has quit IRC17:50
melwittsdague: nevermind my earlier question. flake8 is running on novaclient/tests/functional17:51
*** bkopilov has joined #openstack-nova17:51
sdaguemelwitt: yeh, I thought so :)17:51
sdaguesorry, I just hadn't gotten to your question in my stack yet17:51
*** annashen has quit IRC17:51
*** rushiagr_away is now known as rushiagr17:51
*** Sukhdev has quit IRC17:52
*** lpetrut has joined #openstack-nova17:52
melwittsdague: I figured, just wanted to avoid you wasting time answering when you got to it :)17:53
*** Longgeek has joined #openstack-nova17:53
*** lucasagomes is now known as lucas-dinner17:54
*** gokrokve has quit IRC17:54
*** dprince has quit IRC17:56
*** omnibus7 is now known as davidlenwell17:57
*** bkopilov has quit IRC17:58
*** romainh has left #openstack-nova17:58
*** bkopilov has joined #openstack-nova17:59
*** alexpilotti has joined #openstack-nova18:00
*** gokrokve has joined #openstack-nova18:01
*** alexpilotti has quit IRC18:01
*** alexpilotti has joined #openstack-nova18:02
mriedemsuperdan: are you good with this? https://review.openstack.org/#/c/163978/18:07
superdanmriedem: does it work? I dunno where instance is coming from there, so I dunno if it has the proper context or not18:08
superdanpresume it does though if lascii is +2 so, yeah18:08
mriedemsuperdan: the error is gone from screen-c-child in the logs18:09
superdanwell okay then :)18:09
lasciisuperdan: it should be the same context on instance in the child cell18:09
lasciias in the child cell18:09
superdanokay18:10
lasciioh, this is from_api not at_top.  other way around then18:10
lasciiso whatever context was set when the instance was instantiated18:10
superdanwell, right, that's why I was asking, since the context gets bundled weirdly with those cells calls18:11
superdanI don't remember how the deserialization bit works in cells with regards to re-endowing the context18:11
lasciiyeah, let me double check that18:12
*** mpaolino has quit IRC18:12
*** bwensley has joined #openstack-nova18:13
openstackgerritEd Leafe proposed openstack/nova: Implement instance update logic in Scheduler  https://review.openstack.org/16051118:20
openstackgerritEd Leafe proposed openstack/nova: Add the instance update calls from Compute  https://review.openstack.org/16051318:20
openstackgerritEd Leafe proposed openstack/nova: Modify filters to get instance info from HostState  https://review.openstack.org/16051218:20
openstackgerritEd Leafe proposed openstack/nova: Add the RPC calls for instance updates.  https://review.openstack.org/16050718:20
figleafbauwser: lascii: leakypipes: ^^18:20
*** fandi has joined #openstack-nova18:20
*** fandi has quit IRC18:21
*** sbfox has joined #openstack-nova18:21
*** Longgeek has quit IRC18:22
*** bkopilov has quit IRC18:25
openstackgerritKent Wang proposed openstack/nova: Adds Not Null constraint to KeyPair name  https://review.openstack.org/16323018:25
*** bkopilov has joined #openstack-nova18:25
*** vmtrooper has joined #openstack-nova18:26
openstackgerritChris Friesen proposed openstack/nova: Fix "down" nova-compute service spuriously marked as "up"  https://review.openstack.org/16306018:28
bauwserfigleaf: starting week-end officially, but will try to look again this evening18:29
figleafbauwser: Weekend??? What a slacker!18:29
bauwserfigleaf: I made some comments on all the series, did you get them ?18:29
figleaf:)18:29
*** Marga_ has joined #openstack-nova18:29
bauwserfigleaf: eh, week-end == skiing for me18:30
*** vmtrooper has quit IRC18:31
openstackgerritJoe Gordon proposed openstack/nova: Stop installing everything to run pep8  https://review.openstack.org/16402018:31
bauwserfigleaf: I htink you had problems with nested mocking, because you had to update more than me18:31
openstackgerritDan Smith proposed openstack/nova: Fix ComputeNode backport for Service.obj_make_compatible  https://review.openstack.org/16386718:31
openstackgerritDan Smith proposed openstack/nova: Break out the child version calculation logic from obj_make_compatible()  https://review.openstack.org/16420618:31
figleafbauwser: going through the comments now...18:31
*** bkopilov has quit IRC18:32
*** bkopilov has joined #openstack-nova18:32
*** eharney has quit IRC18:32
superdanonly 387 things in the check queue18:34
*** Sukhdev has joined #openstack-nova18:35
*** Mike_D_laptop has joined #openstack-nova18:36
lasciisuperdan: well that was harder than it should have been to track down, but cells is using the NovaObjectSerializer to rehydrate the object with the context passed to the rpc method18:37
bauwsersuperdan: erm, TGIF would mean Thanks Gosh, It's Feature Freeze ?18:37
superdanlascii: right, but is that context the same as the one embedded in the message?18:38
superdanbauwser: yeah :)18:39
superdanlascii: basically, I don't remember why the context is re-encapsulated in the cells message18:39
superdanlascii: and if it's because the actual cells call is made with admin context or some such, that would then be, like bad and stuff :)18:40
superdanbut if it's the same, then that's cool18:40
superdanof course, if it's not the same, there are probably other problems18:40
superdanalthough they could be latent and undiscovered18:40
bauwserlascii: correct me if I'm wrong, but oslo.messaging requires context as the first arg ?18:40
lasciisuperdan: it's not admin-ized, but it is converted to json and back18:40
superdanlascii: the one in the message you mean?18:40
lasciisuperdan: yes18:41
bauwserlascii: I mean, you can't make a RPC method signature where no context is passed threu18:41
bauwserthru18:41
superdanlascii: right, but that's not the one that the instance will have been created from right?18:41
*** apuimedo has quit IRC18:41
lasciimessage_dict['ctxt'] = context.RequestContext.from_dict(ctxt)18:41
superdanlascii: okay I don't understand why that is done I guess18:41
lasciisuperdan: I don't either atm18:41
superdanokay, then all I was saying is: I hope it's not done because sometimes those two contexts differ :)18:42
lasciicells doesn't modify the context anywhere that I'm aware of18:42
*** shaohe_feng1 has quit IRC18:42
lasciisuperdan: gotcha18:42
*** shaohe_feng1 has joined #openstack-nova18:43
lasciisuperdan: other than being elevated, why would a context change during a request?18:44
*** ijw has joined #openstack-nova18:45
*** lpetrut has quit IRC18:46
superdanlascii: it wouldn't but I also don't know why we're making a copy of or storing the context separately18:47
*** bkeyouma has joined #openstack-nova18:48
superdanlascii: the only reason I can think would be if we always use an admin context when making the rpc call, embedding the user context in the message18:48
superdanlascii: if that were the case, then the instances are actually coming out on the other side with admin contexts in them18:48
bkeyoumaHi there, I have been looking into openstack for the past few weeks and have failed to find clear instructions on how to write a plugin for the nova compute module18:48
bkeyoumaI was wondering if anyone has had experience writing one18:48
superdanhopefully that's not what is happening, but I also don't know why we're doing that extra message['ctxt'] thing otherwise18:48
superdanthat's all :)18:48
lasciisuperdan: just found the other side "_dict['ctxt'] = _dict['ctxt'].to_dict()"18:49
*** andreykurilin_ has joined #openstack-nova18:49
lasciinothing fancy, and no explanation18:49
superdanlascii: yeah, I don'18:49
superdandon't get it at all18:49
bkeyoumaAnyone know how to write a plugin that works on top of Nova?18:50
*** eglynn has joined #openstack-nova18:51
*** oro_ has quit IRC18:51
*** oro has quit IRC18:52
*** annashen has joined #openstack-nova18:52
*** kiwik-chenrui has quit IRC18:53
*** kiwik-chenrui has joined #openstack-nova18:54
*** ndipanoff has quit IRC18:55
*** apuimedo has joined #openstack-nova18:55
*** pixelb has quit IRC18:56
*** liusheng has quit IRC18:56
*** annashen has quit IRC18:56
*** liusheng has joined #openstack-nova18:57
dimsum__bkeyouma: i'd recommend starting from the fake driver - http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/fake.py18:57
lasciisuperdan: looking at the timestamps on when this was added vs when olso messaging code was added all I can figure is it's because cells messaging was done before oslo messaging18:58
dimsum__bkeyouma: you have to flip compute_driver  and connection_type in nova.conf to start with18:59
lasciibauwser: missed your question earlier, I'm not sure if oslo messaging requires context be first.  I wouldn't be surprised if it did18:59
superdanlascii: well, so was all the other rpc stuff we had and we didn't specially encode the context19:00
superdanlascii: but anyway, I'm sure it's fine :)19:00
lasciisuperdan: yeah, I think it is as well19:00
lasciiultimately only comstud knows, as well as all the other secrets of the universe19:01
*** dprince has joined #openstack-nova19:01
bkeyoumadimsum__, thanks I will take a look at that. Is there any tutorials or documentations you know of?19:02
*** dkliban is now known as dkliban_afk19:07
superdanlascii: yar19:07
*** dkliban_afk is now known as dkliban_brb19:08
openstackgerritJennifer Mulsow proposed openstack/nova: Edit ServerGroup inval frmt msg to be more verbose  https://review.openstack.org/16430819:08
*** thedodd has quit IRC19:12
*** Nikolay_St has joined #openstack-nova19:12
*** eglynn has quit IRC19:14
*** zul has quit IRC19:19
openstackgerritJosh Gachnang proposed openstack/nova: Adjust resource tracker for new Ironic states  https://review.openstack.org/16431319:21
*** annashen has joined #openstack-nova19:21
openstackgerritJosh Gachnang proposed openstack/nova: Add support for cleaning in Ironic driver  https://review.openstack.org/16147419:22
*** hemna has quit IRC19:32
*** dkliban_brb is now known as dkliban19:34
*** otter768 has joined #openstack-nova19:35
openstackgerritJennifer Mulsow proposed openstack/nova: Edit ServerGroup inval frmt msg to be more verbose  https://review.openstack.org/16430819:36
openstackgerritJennifer Mulsow proposed openstack/nova: Edit ServerGroup inval frmt msg to be more verbose  https://review.openstack.org/16430819:37
*** otter768 has quit IRC19:40
openstackgerritJosh Gachnang proposed openstack/nova: Adjust resource tracker for new Ironic states  https://review.openstack.org/16431319:40
openstackgerritHans Lindgren proposed openstack/nova: Remove and deprecate unused conductor service calls  https://review.openstack.org/13366419:40
*** iamjarvo has quit IRC19:40
openstackgerritHans Lindgren proposed openstack/nova: Refactor some service tests and make them not require db  https://review.openstack.org/13366519:40
openstackgerritHans Lindgren proposed openstack/nova: Convert service and servicegroup to objects  https://review.openstack.org/13366319:40
openstackgerritHans Lindgren proposed openstack/nova: Add a fixture for the NovaObject indirection API  https://review.openstack.org/16414619:40
*** lpetrut has joined #openstack-nova19:41
openstackgerritmelanie witt proposed openstack/python-novaclient: Ensure the use of volume endpoint in volumes apis  https://review.openstack.org/16432119:43
*** bkopilov has quit IRC19:45
*** bkopilov has joined #openstack-nova19:48
sdagueanyone up for landing these tests to prevent the regression - https://review.openstack.org/#/c/164178 ?19:49
*** Longgeek has joined #openstack-nova19:50
*** tjones1 has quit IRC19:51
*** hemna has joined #openstack-nova19:52
*** thedodd has joined #openstack-nova19:53
*** lucas-dinner has quit IRC19:54
lasciisdague: got it19:56
*** rushiagr is now known as rushiagr_away19:57
sdaguelascii: thanks19:58
*** bkopilov has quit IRC20:02
*** iamjarvo has joined #openstack-nova20:04
*** tjones1 has joined #openstack-nova20:04
*** bkopilov has joined #openstack-nova20:04
*** achanda has quit IRC20:06
openstackgerritMatt Riedemann proposed openstack/nova: Refresh bdm.connection_info if not set when detaching volume  https://review.openstack.org/16433020:08
leakypipesmriedem: easy: https://review.openstack.org/#/c/164206/20:08
mriedemi hope i haven't wasted my whole day on this ^20:08
mriedemspooky20:08
leakypipesmriedem: I'll review the above BDM patch.20:08
mriedem'easy' and 'objects' stuff shouldn't be tied together :)20:08
leakypipesmriedem: just moves code :)20:08
*** yamahata has joined #openstack-nova20:09
*** achanda has joined #openstack-nova20:11
*** vmtrooper has joined #openstack-nova20:15
*** bwensley has quit IRC20:16
*** Mike_D_laptop has quit IRC20:16
*** Longgeek has quit IRC20:18
*** iamjarvo has quit IRC20:19
*** vmtrooper has quit IRC20:20
mriedemsuperdan: question inline of course https://review.openstack.org/#/c/164206/20:20
superdanmriedem: the quoted line is the "more explicit" bit that caused the tests to need tweaking20:21
superdanis that what you're asking?20:21
mriedemmore precise, yeah20:21
*** sbfox has quit IRC20:22
*** tjones1 has left #openstack-nova20:23
mriedemthat was the only thing i noticed as different from the pull out of the code20:24
*** achanda has quit IRC20:25
*** pixelb has joined #openstack-nova20:25
superdanyeah20:27
superdanwithout it, the caller deletes the child from the primitive when all the versions are  current20:27
superdanwhich is, like, not what I wanted :)20:27
*** henrique_ has quit IRC20:28
mriedemapproved20:29
mriedemsuperdan: so i was complaining to garyk yesterday morning about all of the ugly plug/unplug vif stuff in the libvirt driver and why we don't just let neutron handle all that, it occurs to me today (which i knew, but didn't piece together), that we do the same for volumes,20:30
mriedemand how every time someone wants to support a new type of network plugin or volume driver they have to register something in nova that talks to it so libvirt works20:31
*** jdurgin has quit IRC20:31
mriedemi'm assuming those are just architectural things that will never change?20:32
superdanmriedem: it seems much less disgusting for volumes, but yeah20:32
superdanI think that the cinder bits will change with whatever the heck "brick" is :)20:32
mriedemlike glance_store20:33
mriedemexcept nova doesn't have the same low-level detail for each glance backend that it does for every cinder/neutron thing we support20:34
mriedemso i never think about glance20:34
*** oro_ has joined #openstack-nova20:34
*** oro has joined #openstack-nova20:34
mriedemexcept of course the libvirt image code...20:34
*** Sukhdev has quit IRC20:35
*** alexpilotti has quit IRC20:37
*** thangp has quit IRC20:37
openstackgerritJosh Gachnang proposed openstack/nova: Adjust resource tracker for new Ironic states  https://review.openstack.org/16431320:37
*** eharney has joined #openstack-nova20:37
*** pixelb has quit IRC20:38
*** kaufer has quit IRC20:39
*** ociuhandu has quit IRC20:39
*** sdake__ has quit IRC20:40
*** annashen has quit IRC20:42
*** irenab_ has joined #openstack-nova20:45
*** exploreshaifali has quit IRC20:46
bauwserlascii: I'm almost sure, oslo.messaging does need a context, see https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/rpc/client.py#L340-L39320:47
*** irenab has quit IRC20:47
*** irenab_ is now known as irenab20:47
bauwserlascii: so even if your RPC method doesn't have it, you need to cast or call using a ctxt20:47
lasciibauwser: the RPC methods all have it, but cells code duplicates the context in the message payload for some reason20:48
*** annashen has joined #openstack-nova20:49
bauwserlascii: yey, saw your point, did you git blame it ?20:49
lasciiyes.  it goes back to the original cells commit20:50
*** kaufer has joined #openstack-nova20:50
bauwserlascii: mmm, sounds like it was just a copy20:51
mriedemsuperdan: ha https://github.com/openstack/nova/commit/588a57f13edd753614d2bcb289cbea5f0a7992c720:51
bauwserlascii: because it needed to serialize/unserialize it20:51
mriedemsuperdan: tell taylor that she broke nova rebase for me internally L)20:51
mriedem:)20:51
superdanmriedem: will-do :P20:52
bauwserlascii: so, copying it before primitiving it sounds ok20:52
*** oro has quit IRC20:53
*** oro_ has quit IRC20:54
*** exploreshaifali has joined #openstack-nova20:56
*** exploreshaifali has quit IRC20:57
*** achanda has joined #openstack-nova20:57
*** melwitt has quit IRC20:58
*** apuimedo has quit IRC20:59
*** rfolco has quit IRC20:59
*** melwitt has joined #openstack-nova21:00
*** harlowja has quit IRC21:00
*** melwitt has quit IRC21:00
*** apuimedo has joined #openstack-nova21:00
*** apuimedo has quit IRC21:00
*** apuimedo has joined #openstack-nova21:01
lasciibauwser: yeah, should be completely fine.  just not sure why it's done :)21:01
flashgordonsuperdan: so figured out what causes the quota sync issues21:02
flashgordonor at least one thing that does21:02
flashgordonrestarting nova-compute21:02
flashgordonwhile things are happening21:02
*** dave-mccowan has quit IRC21:02
*** irenab has quit IRC21:03
flashgordon(and doing the hard kill that doesn't wait for all the things to cleanup)21:03
bauwserlascii: by reading the code, seems like it's because comstud wanted to make sure it doesn't touch the context21:03
dimsum__superdan: 2 reviews, very cool21:03
bauwserlascii: as he's jsonifiying it before calling the RPC service21:03
dimsum__flashgordon: /me listening21:03
superdandimsum__: eh?21:03
dimsum__superdan: https://review.openstack.org/#/q/owner:%22Taylor+Smith+%253Ctaylor%2540taylorcole.net%253E%22,n,z21:04
bauwserlascii: well, to be clear, he does take a JSON primitive and rehydrate the context from it21:04
superdanflashgordon: hmm, that would mess up claims maybe, but I'm surprised about quotas21:04
superdandimsum__: ah :)21:04
flashgordonsuperdan: trying again with clean stops21:04
*** raildo has quit IRC21:05
flashgordonand seeing if that works or not21:05
flashgordonrebooting conductor and API didn't break anything for me21:05
dimsum__flashgordon: do people do that in the field? hard kills21:05
bauwserlascii: probably because he's serializing all the messages into JSON21:05
flashgordondimsum__: maybe21:05
flashgordondimsum__: also there may be other ways to reproduce this21:06
flashgordondimsum__: just don't know them yet21:06
*** harlowja has joined #openstack-nova21:06
flashgordonand doing a standard stop and wait for cleanup causes failures too21:06
lasciibauwser: sure, but the context comes through on the other side without pulling it into the message body explicitly21:06
*** melwitt has joined #openstack-nova21:07
flashgordondimsum__ superdan: also I spent 5 minutes yesterday and put together a POC to reset quotas http://paste.ubuntu.com/10588043/21:07
flashgordonwhich should satisfy https://review.openstack.org/#/c/161782/21:07
flashgordonI think its worth adding to Kilo as a bug fix21:07
flashgordonsince is nova-manage only21:07
flashgordonand very self contained21:08
bauwserlascii: it does21:08
bauwserlascii: it does put the context in the messaging, unless I'm wrong21:08
bauwsermessage sorry21:08
*** apuimedo has quit IRC21:10
bauwserlascii: https://github.com/openstack/nova/blob/master/nova/cells/rpc_driver.py#L155-L15621:10
bauwserlascii: so it serializes both content and context into a JSON dict which is unprimitived in from_message() on the other side21:11
lasciibauwser: yeah, but why is context duplicated in message there?21:11
bauwserlascii: so as probably the context has been transformed into a primitive, it needs to rehydrate it21:11
lasciihmm, maybe it's just so that context didn't need to be passed around to all of these methods21:12
lasciias none of them take a context param21:12
flashgordonlascii: got some quota related questions for you as an operator if you have a moment21:13
*** marun has quit IRC21:14
bauwserlascii: because he's just throwing it ? :)21:14
*** iamjarvo has joined #openstack-nova21:14
lasciiflashgordon: sure, I can try to answer21:14
*** diegows has quit IRC21:14
bauwserlascii: I mean in process_message()21:14
flashgordonlascii: you ever see quota out of sync issues?21:14
lasciiflashgordon: yes, but they don't come up often.  not sure if that's lack of hearing about it though21:15
bauwserlascii: yeah, didn't see your last point, I think so too21:15
flashgordonwhat do you do when the do come up?21:15
flashgordonlascii: do you manually go into the DB and fix etc?21:16
flashgordonlascii: any ideas on your end on what causes them?21:16
lasciiflashgordon: we try not to manually adjust, but will if necessary.  or we'll raise them.  :(21:18
lasciiwe also set until_refresh and max_age in config to help out21:18
lasciiso they get fixed periodically21:18
*** IanGovett has quit IRC21:18
*** IanGovett has joined #openstack-nova21:19
lasciiI've considered that those should default on, but they're basically an admission of an issue21:19
lasciiflashgordon: no idea what causes them though.  typically when I hear about them they've been out of sync for a while so it's hard to track down21:19
flashgordonahh21:19
flashgordonwhy not turn those on by default?21:21
flashgordonwe do have a problem21:21
flashgordonlets be honest about it21:21
flashgordonlascii: another option is to improve the config option help messages21:21
lasciithe other reason not to do it is that they cause increased load on quota calculations periodically21:21
flashgordonthey are really terse and don't explain why you would want to set them etc21:21
lasciibut it hasn't been an issue in practice for us21:21
flashgordonlascii: can you submit a patch adding expanding the help message on those two?21:22
*** annashen has quit IRC21:22
*** annashen has joined #openstack-nova21:22
lasciiflashgordon: sure21:22
*** andreykurilin_ has quit IRC21:23
flashgordonlascii: thankS!21:23
*** IanGovett has quit IRC21:23
flashgordonlascii: I ask because this turns out to a be a big pain for a lot of operators21:23
flashgordon(feedback sdague passed on from the ops mid cycle)21:23
*** andreykurilin_ has joined #openstack-nova21:23
lasciiinteresting.  I feel like we had more quota issues in the past, but I haven't heard about them for quite some time21:25
flashgordonso I can produce them consistently by rebooting n-cpu21:26
flashgordonduring things21:26
flashgordonbut not running max_age or until_refresh21:26
openstackgerritAndrew Laski proposed openstack/nova: Objects: use setattr rather than dict syntax in remotable  https://review.openstack.org/16397421:26
openstackgerritAndrew Laski proposed openstack/nova: Add CellMapping object  https://review.openstack.org/16186721:26
openstackgerritAndrew Laski proposed openstack/nova: Add get_api_session to db api  https://review.openstack.org/16186621:26
openstackgerritAndrew Laski proposed openstack/nova: Split NovaPersistentObject mixin  https://review.openstack.org/16360521:26
flashgordonwhat values do you recommend for those? I can try again with those values set21:26
*** achanda has quit IRC21:27
lasciiuntil_refresh = 10, and max_age = 86400 are what we have.  but until_refresh is more relevant for you in testing I think21:28
lasciiand max_age just means the quota will be updated the next time quotas are affected for a project/user, not each period21:28
*** mjturek1 has quit IRC21:30
flashgordonkk I'll try until_refresh = 5 or something low next21:31
*** cbader has quit IRC21:31
*** achanda has joined #openstack-nova21:33
lasciias long as you're not within x quota updates of hitting a limit it'll fix things, but won't help at the edges21:34
*** jgrimm_ has joined #openstack-nova21:34
*** timello_ has joined #openstack-nova21:35
*** lascii is now known as alaski21:35
alaskiweekend :)21:35
*** maurosr has quit IRC21:35
*** timello has quit IRC21:36
*** ekhugen has quit IRC21:36
*** ekhugen has joined #openstack-nova21:36
*** jgrimm- has joined #openstack-nova21:36
flashgordonhmm right it at least means quotas will self correct ish21:36
*** otter768 has joined #openstack-nova21:36
*** jgrimm has quit IRC21:36
*** maurosr has joined #openstack-nova21:36
*** timello has joined #openstack-nova21:37
*** iamjarvo has quit IRC21:39
*** annashen has quit IRC21:39
*** neelashah has quit IRC21:39
*** iamjarvo has joined #openstack-nova21:39
*** jgrimm_ has quit IRC21:39
*** timello_ has quit IRC21:39
*** ijw has quit IRC21:40
*** otter768 has quit IRC21:41
*** annashen has joined #openstack-nova21:41
*** andreykurilin_ has quit IRC21:41
*** andreykurilin_ has joined #openstack-nova21:42
flashgordonthanks alaski o/21:42
*** nelsnelson has quit IRC21:43
*** rushiagr_away is now known as rushiagr21:44
*** marun has joined #openstack-nova21:44
*** dboik has quit IRC21:46
*** dprince has quit IRC21:46
*** Mike_D_laptop has joined #openstack-nova21:46
*** iamjarvo has quit IRC21:46
mriedembooya, flight to vancouver is booked21:48
dimsum__mriedem: when are you reaching there?21:48
dimsum__i just started the process21:48
mriedemsunday21:48
mriedemleaving saturday21:48
*** dave-mccowan has joined #openstack-nova21:48
*** sdake has joined #openstack-nova21:48
dimsum__y, am trying that as well21:48
bauwsergosh, flights increased a lot in 2 months21:48
bauwserthanks euro...21:49
anishhey, at least you're not paying in roubles21:49
dimsum__bauwser: how many hops will you have?21:49
bauwseronly 1 because I'm living only close to the 2nd biggest french area...21:50
bauwseraround 16h21:50
bauwserflying Northbound21:50
dimsum__ah cool21:50
bauwsergosh, I had terrible experience when I went back from midcycle21:51
bauwserI arrived to Zurich (around 500km from home) and then had to flight thru Brussels (north) before arriving to Lyon21:51
bauwserjust because my original transatlantic flight had 3 hours delay21:51
mriedembauwser: and your fkey migration got merged!21:52
bauwsermriedem: \o/21:52
bauwser2 BPs in a row for Kilo, I'm about to open a bottle of champaign21:52
mriedem11pm there huh?21:53
mriedemmight as well21:53
bauwseryay21:53
bauwserthat remembers me I have to check again flight prices21:54
bauwserbecause it was just horrible when I looked on Monday21:54
bauwserand btw. tip again : don't take Swiss or Lufthansa when flying21:54
bauwserbecause they're now having fee for booking seats21:54
flashgordonsuperdan: so it looks like the quota issue happens during deletes not boots21:55
*** annashen has quit IRC21:56
flashgordonhmm ... maybe its the combination of the two21:58
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Stop spamming logs when creating context  https://review.openstack.org/16426122:00
*** annashen has joined #openstack-nova22:00
*** rwsu has quit IRC22:00
dimsum__flashgordon: can you please +2/+W ^^^ it was in the check/gate but i had missed one pep8 failure22:00
*** lpetrut has quit IRC22:01
flashgordondimsum__: done22:02
*** Longgeek has joined #openstack-nova22:03
*** vmtrooper has joined #openstack-nova22:04
*** harlowja has quit IRC22:04
*** jecarey has quit IRC22:04
*** Mike_D_laptop has quit IRC22:05
*** gokrokve has quit IRC22:05
*** gokrokve has joined #openstack-nova22:05
*** harlowja has joined #openstack-nova22:06
*** gokrokve has quit IRC22:06
*** harlowja has quit IRC22:06
*** gokrokve has joined #openstack-nova22:06
*** harlowja has joined #openstack-nova22:06
flashgordonso its terminates22:07
*** vmtrooper has quit IRC22:08
*** bkeyouma has quit IRC22:12
*** nelsnelson has joined #openstack-nova22:13
*** irenab has joined #openstack-nova22:15
*** dkliban is now known as dkliban_afk22:15
*** melwitt has quit IRC22:15
*** melwitt has joined #openstack-nova22:16
openstackgerritEd Leafe proposed openstack/nova: Implement instance update logic in Scheduler  https://review.openstack.org/16051122:17
openstackgerritEd Leafe proposed openstack/nova: Add the instance update calls from Compute  https://review.openstack.org/16051322:17
openstackgerritEd Leafe proposed openstack/nova: Modify filters to get instance info from HostState  https://review.openstack.org/16051222:17
openstackgerritEd Leafe proposed openstack/nova: Add the RPC calls for instance updates.  https://review.openstack.org/16050722:17
figleafbauwser: before you get drunk on champagne, wanna check out the changes ^^22:18
*** moshele has joined #openstack-nova22:18
*** moshele has quit IRC22:19
*** melwitt has quit IRC22:19
figleafbauwser: or maybe a drink or two might help http://xkcd.com/323/22:19
*** melwitt has joined #openstack-nova22:19
*** Longgeek has quit IRC22:25
*** tonytan4ever has quit IRC22:25
*** mtanino has quit IRC22:27
*** melwitt has quit IRC22:28
*** figleaf is now known as edleafe22:28
bauwseredleafe: well, if I would review now, it should rather look like http://xkcd.com/776/22:31
edleafebauwser: :)22:32
* bauwser heading off to bed22:32
bauwsergosh, I'm awfully disappointed by flight prices22:32
*** kaufer has quit IRC22:32
bauwsershould think about buying a canoe22:32
*** rwsu has joined #openstack-nova22:33
*** bauwser is now known as bauzas22:34
*** sdake__ has joined #openstack-nova22:38
flashgordonand found the bug https://bugs.launchpad.net/nova/+bug/129641422:38
openstackLaunchpad bug 1296414 in OpenStack Compute (nova) "quotas not updated when periodic tasks or startup finish deletes" [High,In progress] - Assigned to Rajesh Tailor (rajesh-tailor)22:38
flashgordonwe don't update quotas during reboot cleanups22:38
flashgordondimsum__:looks like you touched that bug in the past22:39
*** sdake has quit IRC22:41
flashgordonsdague superdan: quota bug fix, or at least fixes one case https://review.openstack.org/#/c/12234722:43
*** thedodd has quit IRC22:43
mriedemflashgordon: yeah, that's been around awhile22:44
mriedemi've been on it but it was going back and forth a lot so i lost focus22:44
*** tsekiyam_ has joined #openstack-nova22:52
*** hemna has quit IRC22:53
superdanhow about this22:55
superdanNO QUOTAS EVAR22:55
*** tsekiyama has quit IRC22:56
*** markvoelker has quit IRC22:56
*** tsekiyam_ has quit IRC22:56
*** IanGovett has joined #openstack-nova22:58
*** apuimedo has joined #openstack-nova23:03
*** browne has quit IRC23:03
*** nelsnelson has quit IRC23:05
*** IanGovett has quit IRC23:10
*** aysyd has quit IRC23:13
*** sdake__ has quit IRC23:15
flashgordonsuperdan: so actually that was my answer23:17
flashgordonexcept that by that I mean don't do the separate quota logic23:17
flashgordonto see usage23:17
flashgordonjust query the db for instances23:18
flashgordonand compute on the fly each time23:18
flashgordonshouldn't be a lot of extra work for a SQL DB23:18
*** annashen has quit IRC23:18
*** annashen has joined #openstack-nova23:20
mtreinishflashgordon: nah I think superdan meant kill quotas and make people use the honor system :)23:21
flashgordonmtreinish: hehe yeah that is what I assumed he meant23:21
*** david-lyle is now known as david-lyle_afk23:29
*** annashen has quit IRC23:29
*** patrickeast has quit IRC23:32
*** rwsu has quit IRC23:35
*** otter768 has joined #openstack-nova23:37
*** tjones1 has joined #openstack-nova23:37
*** rwsu has joined #openstack-nova23:37
*** tjones1 has left #openstack-nova23:38
*** otter768 has quit IRC23:42
*** melwitt has joined #openstack-nova23:49
*** dimsum__ has quit IRC23:52
*** vmtrooper has joined #openstack-nova23:53
*** dave-mccowan has quit IRC23:54
*** dims_ has joined #openstack-nova23:55
*** markvoelker has joined #openstack-nova23:57
*** dims_ has quit IRC23:57
*** dims_ has joined #openstack-nova23:57
*** vmtrooper has quit IRC23:57
*** thomasem has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!