*** annegentle has quit IRC | 00:02 | |
*** markvoelker has quit IRC | 00:03 | |
*** achanda has quit IRC | 00:03 | |
*** iamjarvo has joined #openstack-nova | 00:04 | |
openstackgerrit | Kent Wang proposed openstack/nova: Adds Not Null constraint to KeyPair name https://review.openstack.org/163230 | 00:04 |
---|---|---|
*** iamjarvo has quit IRC | 00:06 | |
*** markvoelker has joined #openstack-nova | 00:08 | |
*** Marga_ has quit IRC | 00:15 | |
*** vmtrooper has joined #openstack-nova | 00:17 | |
*** Longgeek has joined #openstack-nova | 00:18 | |
*** angdraug has quit IRC | 00:18 | |
*** claudiub has quit IRC | 00:20 | |
*** vmtrooper has quit IRC | 00:22 | |
*** pixelbeat has quit IRC | 00:27 | |
*** Marga_ has joined #openstack-nova | 00:27 | |
*** ybathia has quit IRC | 00:27 | |
*** dims has joined #openstack-nova | 00:32 | |
*** Longgeek has quit IRC | 00:32 | |
*** dave-mccowan has quit IRC | 00:33 | |
*** marun has quit IRC | 00:42 | |
openstackgerrit | Joe Julian proposed openstack/nova: log meaningful error message on download exception https://review.openstack.org/164039 | 00:42 |
*** jaypipes has quit IRC | 00:45 | |
*** dave-mccowan has joined #openstack-nova | 00:50 | |
*** mwagner_lap has quit IRC | 00:53 | |
openstackgerrit | yunhong-jiang proposed openstack/nova: Use VirtCPUModel in compute resource tracker. https://review.openstack.org/148139 | 00:54 |
*** liusheng has quit IRC | 00:56 | |
*** annegentle has joined #openstack-nova | 00:58 | |
*** asettle is now known as asettle-mtg | 01:00 | |
*** ijw has joined #openstack-nova | 01:03 | |
*** annegentle has quit IRC | 01:03 | |
*** ijw has quit IRC | 01:05 | |
*** ijw has joined #openstack-nova | 01:05 | |
*** baoli has joined #openstack-nova | 01:07 | |
*** promulo__ has joined #openstack-nova | 01:09 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Verify all quotas before updating the db https://review.openstack.org/163668 | 01:09 |
*** promulo has quit IRC | 01:12 | |
*** rwsu is now known as rwsu-afk | 01:13 | |
*** annashen has quit IRC | 01:19 | |
*** apuimedo has quit IRC | 01:20 | |
*** dsanders has quit IRC | 01:21 | |
*** I has joined #openstack-nova | 01:25 | |
*** I is now known as Guest59897 | 01:25 | |
*** otter768 has joined #openstack-nova | 01:27 | |
openstackgerrit | yuntongjin proposed openstack/nova: Move policy enforcement into REST API layer for v2.1 api volume_attachment https://review.openstack.org/159376 | 01:29 |
*** otter768 has quit IRC | 01:32 | |
*** dave-mccowan has quit IRC | 01:33 | |
*** yamahata has quit IRC | 01:33 | |
*** rmoe has quit IRC | 01:34 | |
*** annashen has joined #openstack-nova | 01:39 | |
*** amotoki has joined #openstack-nova | 01:39 | |
*** park has joined #openstack-nova | 01:41 | |
*** baoli has quit IRC | 01:42 | |
*** baoli has joined #openstack-nova | 01:43 | |
openstackgerrit | Josh Gachnang proposed openstack/nova: Add support for cleaning in Ironic driver https://review.openstack.org/161474 | 01:43 |
*** amotoki has quit IRC | 01:44 | |
alex_xu | gmann: good morning, can you reach Ken'ichi, need some help from him :) | 01:44 |
*** popw has joined #openstack-nova | 01:45 | |
*** gokrokve has joined #openstack-nova | 01:45 | |
gmann | alex_xu: good morning. actually he is not in yet. | 01:46 |
gmann | alex_xu: ll tell him once he comes. | 01:46 |
alex_xu | gmann: ok, got it, waiting for him, thanks :) | 01:46 |
*** gokrokve_ has quit IRC | 01:49 | |
*** gokrokve has quit IRC | 01:50 | |
*** sdake has joined #openstack-nova | 01:50 | |
*** rmoe has joined #openstack-nova | 01:51 | |
*** tsekiyama has joined #openstack-nova | 01:52 | |
*** sdake__ has joined #openstack-nova | 01:52 | |
*** Marga_ has quit IRC | 01:53 | |
*** sdake has quit IRC | 01:56 | |
*** annegentle has joined #openstack-nova | 01:59 | |
*** patrickeast has quit IRC | 02:02 | |
*** Marga_ has joined #openstack-nova | 02:03 | |
*** annegentle has quit IRC | 02:04 | |
*** sbfox has joined #openstack-nova | 02:04 | |
*** vmtrooper has joined #openstack-nova | 02:06 | |
*** harlowja is now known as harlowja_away | 02:07 | |
*** asselin has quit IRC | 02:09 | |
*** david8hu has quit IRC | 02:10 | |
*** david8hu has joined #openstack-nova | 02:10 | |
*** asselin has joined #openstack-nova | 02:10 | |
*** vmtrooper has quit IRC | 02:11 | |
*** Madkiss has quit IRC | 02:11 | |
*** Madkiss has joined #openstack-nova | 02:12 | |
*** Madkiss has quit IRC | 02:12 | |
*** Madkiss has joined #openstack-nova | 02:12 | |
*** asettle-mtg has quit IRC | 02:13 | |
dims | cyeoh: alex_xu: In the nova meeting today, this microversion support in python-novaclient came up https://review.openstack.org/#/c/152569/ (http://eavesdrop.openstack.org/meetings/nova/2015/nova.2015-03-12-21.00.log.html). Please take a look if you get a chance. there was a question about service type (v2 vs v21) i think | 02:14 |
dims | thanks! | 02:14 |
*** dims has quit IRC | 02:14 | |
alex_xu | dims, thanks, will take a look it asap | 02:15 |
*** marun has joined #openstack-nova | 02:16 | |
*** Longgeek has joined #openstack-nova | 02:18 | |
*** unicell has quit IRC | 02:19 | |
*** annegentle has joined #openstack-nova | 02:19 | |
*** andreykurilin has quit IRC | 02:22 | |
*** andreykurilin has joined #openstack-nova | 02:22 | |
*** marun has quit IRC | 02:22 | |
*** ijw has quit IRC | 02:22 | |
*** ozamiatin has quit IRC | 02:23 | |
*** kudryashova has quit IRC | 02:23 | |
*** kudryashova has joined #openstack-nova | 02:23 | |
*** ozamiatin has joined #openstack-nova | 02:23 | |
*** annegentle has quit IRC | 02:25 | |
*** tsekiyama has quit IRC | 02:26 | |
*** annegentle has joined #openstack-nova | 02:26 | |
*** erkules_ has joined #openstack-nova | 02:26 | |
openstackgerrit | YangLei proposed openstack/nova: Use the right instance object https://review.openstack.org/163745 | 02:27 |
*** tsekiyama has joined #openstack-nova | 02:27 | |
*** ijw has joined #openstack-nova | 02:28 | |
*** erkules has quit IRC | 02:29 | |
*** ijw has quit IRC | 02:29 | |
*** ijw has joined #openstack-nova | 02:30 | |
*** baoli has quit IRC | 02:32 | |
*** baoli has joined #openstack-nova | 02:32 | |
openstackgerrit | ShaoHe Feng proposed openstack/nova: remove the redundant policy check for SecurityGroupsOutputController https://review.openstack.org/159369 | 02:33 |
*** sbfox has quit IRC | 02:33 | |
*** dims has joined #openstack-nova | 02:34 | |
*** Longgeek has quit IRC | 02:35 | |
*** tsekiyama has quit IRC | 02:36 | |
*** haomaiwang has joined #openstack-nova | 02:38 | |
*** kaisers1 has joined #openstack-nova | 02:38 | |
*** dims has quit IRC | 02:39 | |
*** kaisers has quit IRC | 02:40 | |
*** devlaps has quit IRC | 02:43 | |
*** achanda has joined #openstack-nova | 02:44 | |
*** annegentle has quit IRC | 02:46 | |
*** sdake__ has quit IRC | 02:49 | |
*** baoli has quit IRC | 02:54 | |
*** amotoki has joined #openstack-nova | 02:55 | |
*** dsanders has joined #openstack-nova | 02:57 | |
*** royce has joined #openstack-nova | 02:59 | |
*** amotoki has quit IRC | 03:00 | |
*** annashen has quit IRC | 03:05 | |
*** annashen has joined #openstack-nova | 03:07 | |
openstackgerrit | Eli Qiao proposed openstack/nova: Handle exception when attaching interface failed https://review.openstack.org/109178 | 03:07 |
*** sdake has joined #openstack-nova | 03:08 | |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_count_reserved_ips https://review.openstack.org/161622 | 03:13 |
*** annashen has quit IRC | 03:18 | |
*** jaypipes has joined #openstack-nova | 03:18 | |
*** sdake__ has joined #openstack-nova | 03:19 | |
*** nelsnelson has joined #openstack-nova | 03:19 | |
*** annashen has joined #openstack-nova | 03:19 | |
*** sbfox has joined #openstack-nova | 03:21 | |
*** sdake has quit IRC | 03:22 | |
*** gyee has quit IRC | 03:23 | |
*** royce has quit IRC | 03:24 | |
*** shyama has joined #openstack-nova | 03:27 | |
*** otter768 has joined #openstack-nova | 03:28 | |
*** xylan has joined #openstack-nova | 03:28 | |
*** annashen has quit IRC | 03:30 | |
*** Longgeek has joined #openstack-nova | 03:31 | |
*** otter768 has quit IRC | 03:33 | |
openstackgerrit | Lingxian Kong proposed openstack/nova: Raise exception when using invalid az for vm creation https://review.openstack.org/163842 | 03:34 |
*** ijw has quit IRC | 03:36 | |
*** diegows has quit IRC | 03:38 | |
*** zzzeek has quit IRC | 03:40 | |
*** annashen has joined #openstack-nova | 03:40 | |
*** Longgeek has quit IRC | 03:41 | |
*** asettle has joined #openstack-nova | 03:42 | |
*** annashen has quit IRC | 03:43 | |
*** annashen has joined #openstack-nova | 03:44 | |
*** shyama has quit IRC | 03:46 | |
*** shyama has joined #openstack-nova | 03:46 | |
*** annashen has quit IRC | 03:47 | |
*** tsekiyama has joined #openstack-nova | 03:49 | |
*** annashen has joined #openstack-nova | 03:49 | |
*** ijw has joined #openstack-nova | 03:51 | |
*** Longgeek has joined #openstack-nova | 03:52 | |
*** gokrokve has joined #openstack-nova | 03:53 | |
*** ijw has quit IRC | 03:53 | |
*** tsekiyama has quit IRC | 03:53 | |
*** ijw has joined #openstack-nova | 03:53 | |
openstackgerrit | Joe Gordon proposed openstack/nova: Stop installing everything to run pep8 https://review.openstack.org/164020 | 03:55 |
*** vmtrooper has joined #openstack-nova | 03:55 | |
*** nelsnelson has quit IRC | 03:57 | |
*** annashen has quit IRC | 03:59 | |
*** rushiagr_away is now known as rushiagr | 03:59 | |
*** vmtrooper has quit IRC | 03:59 | |
*** annashen has joined #openstack-nova | 04:04 | |
*** annashen has quit IRC | 04:06 | |
*** liusheng has joined #openstack-nova | 04:06 | |
*** gokrokve has quit IRC | 04:09 | |
*** sdake__ has quit IRC | 04:09 | |
*** amotoki has joined #openstack-nova | 04:11 | |
*** annashen has joined #openstack-nova | 04:11 | |
*** amotoki has quit IRC | 04:15 | |
*** Marga_ has quit IRC | 04:16 | |
*** deepthi has joined #openstack-nova | 04:17 | |
*** dsanders has quit IRC | 04:20 | |
*** annashen has quit IRC | 04:23 | |
*** unicell has joined #openstack-nova | 04:23 | |
*** dboik_ has quit IRC | 04:34 | |
*** Marga_ has joined #openstack-nova | 04:37 | |
*** annashen has joined #openstack-nova | 04:39 | |
openstackgerrit | Joe Gordon proposed openstack/nova: Stop installing everything to run pep8 https://review.openstack.org/164020 | 04:43 |
*** mtanino has quit IRC | 04:46 | |
*** Longgeek has quit IRC | 04:47 | |
*** sbfox has quit IRC | 04:49 | |
*** annashen has quit IRC | 04:54 | |
*** annashen has joined #openstack-nova | 04:56 | |
*** ijw has quit IRC | 05:05 | |
*** coolsvap|afk is now known as coolsvap | 05:14 | |
*** exploreshaifali has joined #openstack-nova | 05:14 | |
*** swamireddy is now known as swamireddy_sick_ | 05:16 | |
*** vigneshvar has joined #openstack-nova | 05:24 | |
*** asettle has quit IRC | 05:26 | |
*** sbfox has joined #openstack-nova | 05:28 | |
*** otter768 has joined #openstack-nova | 05:29 | |
*** otter768 has quit IRC | 05:34 | |
*** annashen has quit IRC | 05:37 | |
*** exploreshaifali has quit IRC | 05:38 | |
*** annashen has joined #openstack-nova | 05:40 | |
*** Nikolay_St has quit IRC | 05:41 | |
*** vmtrooper has joined #openstack-nova | 05:43 | |
*** annashen has quit IRC | 05:44 | |
*** exploreshaifali has joined #openstack-nova | 05:47 | |
*** Longgeek has joined #openstack-nova | 05:48 | |
*** vmtrooper has quit IRC | 05:48 | |
*** sbfox has quit IRC | 05:48 | |
*** annashen has joined #openstack-nova | 05:53 | |
*** unicell has quit IRC | 05:53 | |
*** lpetrut has joined #openstack-nova | 05:54 | |
*** unicell has joined #openstack-nova | 05:54 | |
*** veena has joined #openstack-nova | 05:55 | |
*** exploreshaifali has quit IRC | 05:55 | |
*** sbfox has joined #openstack-nova | 05:58 | |
*** eliqiao has joined #openstack-nova | 06:05 | |
*** ankit_ag has joined #openstack-nova | 06:10 | |
*** achanda has quit IRC | 06:10 | |
*** markvoelker has quit IRC | 06:11 | |
*** annashen has quit IRC | 06:11 | |
*** markvoelker has joined #openstack-nova | 06:12 | |
*** achanda has joined #openstack-nova | 06:13 | |
*** markvoelker has quit IRC | 06:16 | |
*** Sukhdev has joined #openstack-nova | 06:18 | |
*** vigneshvar has quit IRC | 06:19 | |
*** Longgeek has quit IRC | 06:21 | |
*** amotoki has joined #openstack-nova | 06:23 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex https://review.openstack.org/162030 | 06:23 |
*** armax has quit IRC | 06:25 | |
openstackgerrit | Chris Friesen proposed openstack/nova: Fix up server group policy validation https://review.openstack.org/162746 | 06:25 |
*** achanda has quit IRC | 06:28 | |
*** oro_ has joined #openstack-nova | 06:29 | |
*** oro has joined #openstack-nova | 06:29 | |
*** royce has joined #openstack-nova | 06:33 | |
*** achanda has joined #openstack-nova | 06:34 | |
*** achanda has quit IRC | 06:38 | |
*** markvoelker has joined #openstack-nova | 06:42 | |
*** Sukhdev has quit IRC | 06:43 | |
openstackgerrit | Chris Friesen proposed openstack/nova: Fix "down" nova-compute service spuriously marked as "up" https://review.openstack.org/163060 | 06:44 |
*** rushiagr is now known as rushiagr_away | 06:45 | |
*** markvoelker has quit IRC | 06:47 | |
*** mrda is now known as mrda-weekend | 06:49 | |
*** jcoufal has joined #openstack-nova | 06:51 | |
gmann | lifeless: does testscenario (testscenarios.WithScenarios) runs with nose? | 06:52 |
*** coolsvap is now known as coolsvap|afk | 06:54 | |
*** browne has quit IRC | 06:57 | |
*** romainh has joined #openstack-nova | 06:58 | |
*** afazekas has joined #openstack-nova | 07:04 | |
veena | Hi, I cloned stable/icehouse and running tests using "tox -e py27" and stuck at "from oslo.serialization import jsonutils Unimplemented block at ../../relaxng.c:3825" for around 30 minutes. What does this imply? Is it hung? Am I missing anything? | 07:04 |
*** pkoniszewski has joined #openstack-nova | 07:07 | |
*** bkopilov has quit IRC | 07:08 | |
*** coolsvap has joined #openstack-nova | 07:09 | |
*** romainh has left #openstack-nova | 07:09 | |
*** Longgeek has joined #openstack-nova | 07:18 | |
*** dims has joined #openstack-nova | 07:23 | |
*** sbfox has quit IRC | 07:24 | |
*** dims has quit IRC | 07:27 | |
*** bkopilov has joined #openstack-nova | 07:28 | |
*** otter768 has joined #openstack-nova | 07:30 | |
*** sahid has joined #openstack-nova | 07:30 | |
*** jamielennox has quit IRC | 07:31 | |
*** oro_ has quit IRC | 07:32 | |
*** bkopilov has quit IRC | 07:32 | |
*** oro has quit IRC | 07:32 | |
*** vmtrooper has joined #openstack-nova | 07:32 | |
*** jamielennox has joined #openstack-nova | 07:34 | |
*** ijw has joined #openstack-nova | 07:34 | |
*** otter768 has quit IRC | 07:35 | |
*** ijw has quit IRC | 07:35 | |
*** ijw has joined #openstack-nova | 07:36 | |
*** vmtrooper has quit IRC | 07:37 | |
*** ijw has quit IRC | 07:38 | |
*** ijw has joined #openstack-nova | 07:39 | |
*** jamielennox has quit IRC | 07:39 | |
*** mpavone has joined #openstack-nova | 07:39 | |
*** Nikolay_St has joined #openstack-nova | 07:40 | |
*** Longgeek has quit IRC | 07:41 | |
*** Longgeek has joined #openstack-nova | 07:41 | |
*** markvoelker has joined #openstack-nova | 07:43 | |
*** lpetrut has quit IRC | 07:43 | |
*** TobiasE has joined #openstack-nova | 07:44 | |
*** apuimedo has joined #openstack-nova | 07:47 | |
openstackgerrit | Stephen Ahn proposed openstack/nova: libvirt: Rollback status when cold migrate failed https://review.openstack.org/144261 | 07:48 |
*** markvoelker has quit IRC | 07:48 | |
*** exploreshaifali has joined #openstack-nova | 07:48 | |
Anticimex | where has https://blueprints.launchpad.net/nova/+spec/support-keystone-v3-api gone? | 07:50 |
Anticimex | how does one use keystone v3 ~everywhere today, but map this to nova if nova is stuck on v2 still? | 07:50 |
xylan | hi, guys, I fired a bug in the launchpad, 'resize failed because of instance's invalid availability zone property', it's very easy to understand and reproduce. | 07:53 |
xylan | the patch is here: https://review.openstack.org/163842 | 07:53 |
xylan | very appreciated that you can help to review and welcome any comments. | 07:53 |
*** jamielennox|away has joined #openstack-nova | 07:55 | |
*** jamielennox|away is now known as jamielennox | 07:55 | |
*** coolsvap has quit IRC | 07:59 | |
*** markus_z has joined #openstack-nova | 08:00 | |
*** xylan has quit IRC | 08:02 | |
*** xylan has joined #openstack-nova | 08:02 | |
*** dulek has joined #openstack-nova | 08:09 | |
*** veena has quit IRC | 08:11 | |
*** jistr has joined #openstack-nova | 08:12 | |
*** matrohon has joined #openstack-nova | 08:21 | |
*** openstackgerrit has quit IRC | 08:21 | |
*** openstackgerrit has joined #openstack-nova | 08:21 | |
openstackgerrit | Hans Lindgren proposed openstack/nova: Replace conductor get_ec2_ids() with new Instance.ec2_ids attribute https://review.openstack.org/158066 | 08:24 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Add EC2Ids object and link to Instance object as optional attribute https://review.openstack.org/149746 | 08:24 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Remove unused metadata conductor parameter https://review.openstack.org/149747 | 08:24 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Remove and deprecate conductor get_ec2_ids() https://review.openstack.org/149749 | 08:24 |
*** adelinatuvenie has joined #openstack-nova | 08:28 | |
*** jlanoux has joined #openstack-nova | 08:38 | |
*** lpetrut has joined #openstack-nova | 08:39 | |
*** obondarev_ has quit IRC | 08:42 | |
*** obondarev has joined #openstack-nova | 08:42 | |
*** markvoelker has joined #openstack-nova | 08:44 | |
*** jistr has quit IRC | 08:46 | |
*** vivekd has joined #openstack-nova | 08:48 | |
*** markvoelker has quit IRC | 08:48 | |
*** park has quit IRC | 08:52 | |
*** lpetrut has quit IRC | 08:53 | |
*** andreykurilin_ has joined #openstack-nova | 08:53 | |
*** veena has joined #openstack-nova | 08:57 | |
*** amotoki has quit IRC | 08:57 | |
*** erkules_ is now known as erkules | 08:57 | |
openstackgerrit | Alexis Lee proposed openstack/nova: Move InstanceClaimTestCase.test_claim_and_audit https://review.openstack.org/136054 | 08:57 |
*** erkules has quit IRC | 08:57 | |
*** erkules has joined #openstack-nova | 08:57 | |
openstackgerrit | Alexis Lee proposed openstack/nova: Update some ResizeClaimTestCase tests https://review.openstack.org/138686 | 08:57 |
openstackgerrit | Alexis Lee proposed openstack/nova: Use migration object in resource_tracker https://review.openstack.org/79324 | 08:57 |
*** jistr has joined #openstack-nova | 09:04 | |
frickler | veena: The tox test runs for 30 minutes on a fast server, depending on your machine, it may also take much longer, did you try to wait for an hour and see whether it then finishes | 09:04 |
frickler | veena: the messages about namespace deprecation are to be expected | 09:05 |
*** pask81 has joined #openstack-nova | 09:07 | |
bauzas | veena: make sure you install all the required libs before running tox here http://docs.openstack.org/developer/nova/devref/development.environment.html | 09:09 |
bauzas | veena: but in general, we don't run all the tests locally, only the ones that are changed | 09:10 |
openstackgerrit | Rajesh Tailor proposed openstack/nova: Allow force-delete irrespective of VM task_state https://review.openstack.org/163798 | 09:12 |
*** ndipanov has joined #openstack-nova | 09:12 | |
*** abhishekkk has joined #openstack-nova | 09:12 | |
veena | bauzas: Okay, thank you | 09:14 |
openstackgerrit | garyk proposed openstack/nova: Compute: no longer need to pass flavor to the spawn method https://review.openstack.org/162652 | 09:16 |
*** Longgeek has quit IRC | 09:16 | |
frickler | veena: what distro are you using? relaxng.c belongs to libxml2, I'm seeing a similar message on my local Gentoo box, but not on Ubuntu | 09:17 |
veena | frickler: am using Ubuntu 14.04 | 09:18 |
openstackgerrit | garyk proposed openstack/nova: libvirt: remove unnecessary flavor parameter https://review.openstack.org/162946 | 09:19 |
*** romainh has joined #openstack-nova | 09:19 | |
*** mhorban has quit IRC | 09:20 | |
*** amotoki has joined #openstack-nova | 09:20 | |
*** lpetrut has joined #openstack-nova | 09:20 | |
*** vmtrooper has joined #openstack-nova | 09:21 | |
*** bnemec has quit IRC | 09:24 | |
*** bnemec has joined #openstack-nova | 09:25 | |
*** vmtrooper has quit IRC | 09:26 | |
*** zz_johnthetubagu is now known as johnthetubaguy | 09:29 | |
*** otter768 has joined #openstack-nova | 09:31 | |
*** andreykurilin_ has quit IRC | 09:31 | |
*** andreykurilin_ has joined #openstack-nova | 09:32 | |
*** vivekd has quit IRC | 09:34 | |
*** otter768 has quit IRC | 09:35 | |
openstackgerrit | jichenjc proposed openstack/nova: Fix wrong log when reschedule is disabled https://review.openstack.org/164124 | 09:38 |
*** lpetrut has quit IRC | 09:42 | |
*** dims has joined #openstack-nova | 09:42 | |
*** lpetrut has joined #openstack-nova | 09:42 | |
*** lpetrut has quit IRC | 09:43 | |
*** markvoelker has joined #openstack-nova | 09:45 | |
*** dims has quit IRC | 09:47 | |
*** vigneshvar has joined #openstack-nova | 09:47 | |
*** bkopilov has joined #openstack-nova | 09:49 | |
*** markvoelker has quit IRC | 09:49 | |
sahid | ndipanov: hi, can you have a look at this https://review.openstack.org/#/c/159106/ | 09:49 |
sahid | it is something we probably want to see merged | 09:50 |
ndipanov | sahid, looking | 09:51 |
*** eglynn has joined #openstack-nova | 09:54 | |
*** dims has joined #openstack-nova | 09:54 | |
*** bkopilov has quit IRC | 09:55 | |
*** royce has quit IRC | 09:56 | |
*** lpetrut has joined #openstack-nova | 09:56 | |
*** eglynn-officeafk has joined #openstack-nova | 09:57 | |
veena | frickler: Could you get over that? | 09:57 |
*** derekh has joined #openstack-nova | 09:57 | |
veena | frickler: am still stuck in that. But will wait for an hr as you suggested. | 09:58 |
*** TobiasE has quit IRC | 10:02 | |
openstackgerrit | shihanzhang proposed openstack/nova: Fix AggregateCoreFilter return incorrect value https://review.openstack.org/164128 | 10:03 |
*** TobiasE has joined #openstack-nova | 10:04 | |
*** moshele has joined #openstack-nova | 10:05 | |
*** sluo_wfh has quit IRC | 10:08 | |
*** igordcard_ has joined #openstack-nova | 10:13 | |
*** moshele has quit IRC | 10:15 | |
*** nellysmitt has joined #openstack-nova | 10:17 | |
*** Longgeek has joined #openstack-nova | 10:17 | |
*** vigneshvar has quit IRC | 10:19 | |
*** lucasagomes has joined #openstack-nova | 10:21 | |
*** lpetrut has quit IRC | 10:21 | |
frickler | veena: Looks like tox might indeed be getting stuck somehow on 14.04, I would suggest using 12.04 when working with Icehouse | 10:25 |
*** Longgeek has quit IRC | 10:32 | |
openstackgerrit | jichenjc proposed openstack/nova: Code clean up db.instance_get_all_by_host() https://review.openstack.org/164132 | 10:37 |
*** kolesovdv has joined #openstack-nova | 10:39 | |
*** andreykurilin_ has quit IRC | 10:39 | |
*** vigneshvar has joined #openstack-nova | 10:40 | |
openstackgerrit | garyk proposed openstack/nova: Neutron: configure requested amount of fixed_ips https://review.openstack.org/163864 | 10:41 |
*** aix has joined #openstack-nova | 10:44 | |
openstackgerrit | Amandeep proposed openstack/nova: Server details include ID as well as Name https://review.openstack.org/164136 | 10:44 |
*** ildikov_ has quit IRC | 10:45 | |
*** markvoelker has joined #openstack-nova | 10:46 | |
openstackgerrit | Sean Dague proposed openstack/nova: refactor policy fixtures to allow use of real policy https://review.openstack.org/161710 | 10:47 |
openstackgerrit | Sean Dague proposed openstack/nova: implement user negative testing for flavor manage https://review.openstack.org/160423 | 10:47 |
veena | frickler: It worked for me :) Thanks | 10:48 |
*** markvoelker has quit IRC | 10:50 | |
*** lpetrut has joined #openstack-nova | 10:50 | |
*** jamielennox has quit IRC | 10:55 | |
*** pixelbeat has joined #openstack-nova | 10:56 | |
*** harlowja_away has quit IRC | 10:59 | |
*** dulek_ has joined #openstack-nova | 11:00 | |
*** erlon has joined #openstack-nova | 11:01 | |
*** jamielennox|away has joined #openstack-nova | 11:02 | |
*** jamielennox|away is now known as jamielennox | 11:02 | |
*** dulek has quit IRC | 11:03 | |
*** exploreshaifali has quit IRC | 11:03 | |
*** mpaolino has joined #openstack-nova | 11:06 | |
openstackgerrit | Sean Dague proposed openstack/nova: Revert "Removed useless method _get_default_deleted_value." https://review.openstack.org/164140 | 11:06 |
openstackgerrit | Sean Dague proposed openstack/nova: Revert "Removed useless method _get_default_deleted_value." https://review.openstack.org/164140 | 11:08 |
openstackgerrit | jichenjc proposed openstack/nova: use block_dev.get_bdm_swap_list in compute api https://review.openstack.org/164141 | 11:09 |
*** vmtrooper has joined #openstack-nova | 11:10 | |
openstackgerrit | jichenjc proposed openstack/nova: Code clean up db.instance_get_all_by_host() https://review.openstack.org/164132 | 11:12 |
*** aysyd has joined #openstack-nova | 11:13 | |
sdague | ndipanov / johnthetubaguy - you guys up for a fast revert of a corrupt your data bug - https://review.openstack.org/#/c/164140/ ? | 11:13 |
*** jamielennox has quit IRC | 11:14 | |
*** vmtrooper has quit IRC | 11:15 | |
johnthetubaguy | sdague: makes sense, I can't remember the rule, can we just fast approve these? | 11:15 |
sdague | well it's been out there long enough that I don't have an issue with waiting for 2 +2s | 11:16 |
sdague | but I figured if both of you looked, that would be good | 11:16 |
johnthetubaguy | sdague: good point, just checked that | 11:16 |
sdague | I'll try to build some tests later today | 11:16 |
johnthetubaguy | sdague: I can't remember what we said about deprecating shadow tables now… I kinda remember it came up | 11:16 |
ndipanov | what the... | 11:17 |
sdague | yeh, I think it did, but regardless, this was a change that assumed a certain integrity in our data, which did not exist | 11:17 |
johnthetubaguy | sdague: yep | 11:17 |
openstackgerrit | Amandeep proposed openstack/nova: Server details include ID as well as Name https://review.openstack.org/164136 | 11:18 |
*** aysyd has quit IRC | 11:20 | |
ndipanov | oh wow | 11:20 |
*** lpetrut has quit IRC | 11:21 | |
lifeless | gmann: I don't know. Nose ooes some risky things unittest API wise. | 11:22 |
lifeless | gmann: WithScenarios is probably ok, though its preferred to use discovery layer multiplication which I rather suspect won't play nice with nose | 11:23 |
lifeless | gmann: IMBW | 11:23 |
ndipanov | sdague, shadow tables crap neads to die | 11:23 |
sdague | ndipanov: so... no real complaint here on that | 11:23 |
*** pask81 has quit IRC | 11:23 | |
sdague | but that's a bigger fix | 11:24 |
*** jamielennox|away has joined #openstack-nova | 11:24 | |
*** jamielennox|away is now known as jamielennox | 11:24 | |
ndipanov | sdague, yeah - just saying | 11:24 |
sdague | I'm going to try to get these tests to actually test things correctly as well | 11:24 |
ndipanov | on a bright side I think no one is using it at all | 11:25 |
ndipanov | for good reasons | 11:25 |
openstackgerrit | Pawel Koniszewski proposed openstack/nova: Add ability to pause instance during live migration https://review.openstack.org/163836 | 11:25 |
*** krykowski has joined #openstack-nova | 11:26 | |
openstackgerrit | Mike Durnosvistov proposed openstack/nova: libvirt: Resize down an instance booted from a volume https://review.openstack.org/152964 | 11:27 |
openstackgerrit | Mike Durnosvistov proposed openstack/nova: libvirt: don't allow to resize down the default ephemeral disk https://review.openstack.org/158646 | 11:27 |
*** otter768 has joined #openstack-nova | 11:32 | |
*** dave-mccowan has joined #openstack-nova | 11:32 | |
*** bauzas is now known as bauwser | 11:32 | |
*** otter768 has quit IRC | 11:36 | |
*** haomaiwang has quit IRC | 11:37 | |
*** eliqiao has quit IRC | 11:37 | |
*** baoli has joined #openstack-nova | 11:41 | |
veena | There are no test cases related to nova/virt/libvirt/driver.py in nova icehouse release, There is no test_driver.py file in nova/tests/virt/libvirt. Are they ignored or implemented in some other files? | 11:41 |
*** ildikov_ has joined #openstack-nova | 11:43 | |
*** baoli has quit IRC | 11:44 | |
sdague | git grep libvirt in nova/tests | 11:44 |
sdague | there were a bunch of them | 11:44 |
*** baoli has joined #openstack-nova | 11:44 | |
*** exploreshaifali has joined #openstack-nova | 11:45 | |
bauwser | veena: seriously ? mmm, and why not nova.tests.virt.libvirt.test_driver ? :) | 11:45 |
*** jcoufal_ has joined #openstack-nova | 11:45 | |
bauwser | veena: keep in mind that tests.unit has just been provided on last release | 11:46 |
*** markvoelker has joined #openstack-nova | 11:46 | |
*** deepthi has quit IRC | 11:47 | |
bauwser | veena: oh right | 11:47 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Remove and deprecate unused conductor service calls https://review.openstack.org/133664 | 11:48 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Refactor some service tests and make them not require db https://review.openstack.org/133665 | 11:48 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Convert service and servicegroup to objects https://review.openstack.org/133663 | 11:48 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Add a fixture for the NovaObject indirection API https://review.openstack.org/164146 | 11:48 |
*** jcoufal has quit IRC | 11:49 | |
*** vigneshvar has quit IRC | 11:51 | |
veena | bauwser: not tests/unit. | 11:51 |
veena | bauwser: nova.tests.virt.drivers.test_driver.py would have been there | 11:51 |
*** markvoelker has quit IRC | 11:51 | |
veena | bauwser: Are those functions in driver.py tested in some other file? Why are they being ignored? | 11:52 |
*** dulek___ has joined #openstack-nova | 11:53 | |
*** bkopilov has joined #openstack-nova | 11:53 | |
*** IanGovett has joined #openstack-nova | 11:55 | |
sdague | johnthetubaguy / ndipanov ok, I think I've got a safety check test, but it needs some cleaning up, and I have an errand to run. So should have it posted in a couple of errors. | 11:55 |
sdague | hours | 11:55 |
johnthetubaguy | awesome | 11:55 |
bauwser | veena: do a git blame nova/tests/unit/virt/libvirt/test_driver.py on the master branch and you'll see old paths | 11:56 |
ndipanov | sdague, cool | 11:56 |
*** dulek_ has quit IRC | 11:56 | |
veena | bauwser: I did a git clone of stable/icehouse. In stable/juno it is there. But not in icehouse | 11:57 |
*** mwagner_lap has joined #openstack-nova | 11:57 | |
*** diegows has joined #openstack-nova | 11:57 | |
bauwser | veena: eh, just clone the repo, you'll have the stable branches within | 11:57 |
bauwser | veena: ie. git clone https://github.com/openstack/nova, period. | 11:58 |
bauwser | veena: and then git checkout <stable/branch> | 11:58 |
*** samueldmq has joined #openstack-nova | 11:59 | |
*** mpaolino has quit IRC | 12:00 | |
johnthetubaguy | dansmith: it would be good to catch up about the objects blueprint, seems like we are having patches after the feature proposal freeze, but otherwise we have all the big stuff merged now? Maybe it should be marked as implemented? | 12:00 |
veena | bauwser: Doing that now. will update you | 12:01 |
*** lpetrut has joined #openstack-nova | 12:02 | |
bauwser | sdague: have you seen my comment on the scheduler log bug ? | 12:02 |
bauwser | sdague: https://bugs.launchpad.net/nova/+bug/1431291 #2 | 12:03 |
openstack | Launchpad bug 1431291 in OpenStack Compute (nova) "Scheduler Failures are no longer logged with enough detail for a site admin to do problem determination" [High,Confirmed] - Assigned to Sylvain Bauza (sylvain-bauza) | 12:03 |
bauwser | sdague: I was basically saying that instance_uuids were no longer part of the request_spec and we should rather find other way to provide a request ID | 12:03 |
bauwser | sdague: so I was proposing to use the reservation_id field | 12:04 |
*** aysyd has joined #openstack-nova | 12:04 | |
*** ndipanov is now known as ndipanoff | 12:04 | |
*** igordcard_ has quit IRC | 12:05 | |
*** markvoelker has joined #openstack-nova | 12:07 | |
veena | bauwser: Followed the steps Error - fatal: cannot stat path 'nova/tests/unit/virt/libvirt/test_driver.py': No such file or directory | 12:07 |
*** eliqiao has joined #openstack-nova | 12:08 | |
openstackgerrit | Radoslav Gerganov proposed openstack/nova-specs: VMware: Native HTML5 consoles for VMware https://review.openstack.org/127283 | 12:08 |
*** rajesht has joined #openstack-nova | 12:09 | |
*** lucasagomes is now known as lucas-hungry | 12:09 | |
*** irenab has quit IRC | 12:10 | |
*** irenab has joined #openstack-nova | 12:11 | |
*** lpetrut has quit IRC | 12:13 | |
*** Longgeek has joined #openstack-nova | 12:15 | |
*** eliqiao has quit IRC | 12:16 | |
bauwser | veena: you didn't read what I said, do a git blame on the master branch | 12:17 |
bauwser | veena: not on the icehouse stable branch | 12:17 |
*** vladikr has joined #openstack-nova | 12:18 | |
*** bkopilov has quit IRC | 12:20 | |
*** exploreshaifali has quit IRC | 12:23 | |
*** TobiasE has quit IRC | 12:23 | |
*** Marga_ has quit IRC | 12:24 | |
*** edleafe is now known as figleaf | 12:25 | |
*** raildo has joined #openstack-nova | 12:28 | |
*** rajesht has quit IRC | 12:29 | |
*** adelinatuvenie has quit IRC | 12:29 | |
*** lpetrut has joined #openstack-nova | 12:30 | |
*** Longgeek has quit IRC | 12:31 | |
*** ferest has joined #openstack-nova | 12:32 | |
*** rajesht has joined #openstack-nova | 12:34 | |
figleaf | alaski: jaypipes-afk: new revision pushed for https://review.openstack.org/#/c/160507/ to address your concerns | 12:34 |
rajesht | dansmith: please review "Allow force-delete irrespective of VM task_state" | 12:35 |
rajesht | dansmith: https://review.openstack.org/#/c/163798/ | 12:35 |
openstackgerrit | Mike Durnosvistov proposed openstack/nova: Using Instance object instead of db call https://review.openstack.org/149322 | 12:35 |
*** lpetrut has quit IRC | 12:35 | |
*** rajesht has quit IRC | 12:37 | |
*** dprince has joined #openstack-nova | 12:42 | |
figleaf | PaulMurray: the PciDevTracker bug fix merged, so your compute node init patch needs rebasing. | 12:47 |
openstackgerrit | Michal Rostecki proposed openstack/nova: Adding security groups to existing ports https://review.openstack.org/163780 | 12:48 |
*** kaufer has joined #openstack-nova | 12:49 | |
*** toan-tran has joined #openstack-nova | 12:51 | |
sahid | jaypipes: hello, are you going to work on this or can i try to rebase and address comments ? | 12:55 |
sahid | https://review.openstack.org/#/c/152689/ | 12:55 |
*** mriedem_away is now known as mriedem | 12:58 | |
*** vmtrooper has joined #openstack-nova | 12:59 | |
*** veena has quit IRC | 13:00 | |
*** dulek has joined #openstack-nova | 13:01 | |
*** b3nt_pin is now known as seagulls | 13:01 | |
*** dulek___ has quit IRC | 13:02 | |
openstackgerrit | sahid proposed openstack/nova: compute: introduce binary constants https://review.openstack.org/157363 | 13:03 |
openstackgerrit | sahid proposed openstack/nova: db: clean tests to verify enable service option https://review.openstack.org/164168 | 13:03 |
*** lucas-hungry is now known as lucasagomes | 13:03 | |
*** ildikov_ has quit IRC | 13:04 | |
*** dkliban_afk is now known as dkliban | 13:04 | |
*** dulek has quit IRC | 13:04 | |
*** vmtrooper has quit IRC | 13:04 | |
*** dulek_ has joined #openstack-nova | 13:04 | |
*** Nikolay_St has quit IRC | 13:05 | |
*** READ10 has joined #openstack-nova | 13:06 | |
*** eharney has joined #openstack-nova | 13:06 | |
openstackgerrit | wuhao proposed openstack/nova: Add previous page links for Nova GET servers API https://review.openstack.org/164169 | 13:06 |
*** xyang1 has joined #openstack-nova | 13:06 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Remove FK on service_id and make service_id nullable https://review.openstack.org/155319 | 13:06 |
*** ildikov_ has joined #openstack-nova | 13:08 | |
*** ijw has quit IRC | 13:09 | |
*** exploreshaifali has joined #openstack-nova | 13:10 | |
*** kolesovdv has quit IRC | 13:13 | |
sdague | bauwser: request id is not useful | 13:14 |
sdague | that's not a persistent thing | 13:14 |
bauwser | sdague: erm agreed | 13:14 |
*** neelashah has joined #openstack-nova | 13:14 | |
bauwser | sdague: you're right, I was checking it | 13:14 |
bauwser | sdague: I'm just wondering what is persisted so that a nova show could present it | 13:15 |
sdague | anyway, I'm writing the test case for the data corruption now, then I'll look about what kind of scheduler reporting is an option. | 13:15 |
*** vigneshvar has joined #openstack-nova | 13:15 | |
bauwser | sdague: as I said, there is only the first instance object which is provided in the request_spec dict | 13:15 |
*** rfolco has joined #openstack-nova | 13:15 | |
*** markvoelker has quit IRC | 13:16 | |
bauwser | sdague: and that's also something I'm working on for the RequestSpec object BP | 13:16 |
*** lpetrut has joined #openstack-nova | 13:16 | |
sdague | honestly, first instance might be good enough in most cases | 13:17 |
*** markvoelker has joined #openstack-nova | 13:17 | |
sdague | but, I need to go do this other thing first | 13:17 |
bauwser | sdague: then that's something I can add it | 13:19 |
*** park has joined #openstack-nova | 13:19 | |
*** neelashah has quit IRC | 13:21 | |
*** dboik has joined #openstack-nova | 13:21 | |
*** Marga_ has joined #openstack-nova | 13:23 | |
*** mpaolino has joined #openstack-nova | 13:24 | |
jaypipes | sahid: I will work on that this weekend. | 13:25 |
bauwser | week*end* | 13:25 |
*** neelashah has joined #openstack-nova | 13:27 | |
*** popw1 has joined #openstack-nova | 13:29 | |
dansmith | johnthetubaguy: which patches are merging that you think are freeze-worthy? | 13:29 |
dansmith | johnthetubaguy: there are cleanups I still need to merge before kilo in order to get ready for o.vo, and I cleared those with folks yesterday on the meeting | 13:30 |
openstackgerrit | Abhishek Kekane proposed openstack/nova: Allow force-delete irrespective of VM task_state https://review.openstack.org/163798 | 13:30 |
sahid | jaypipes: ack | 13:30 |
johnthetubaguy | dansmith: OK, those sound fine, just wondering what the blueprint tracking should look like | 13:31 |
*** mpaolino has quit IRC | 13:31 | |
dansmith | johnthetubaguy: if you want to mark it as implemented and let me still merge a few more cleanups against it, then that's cool, but since it was an umbrella BP, marking it "implemented" seems like just an arbitrary thing we can do whenever you want :) | 13:32 |
*** mpovolny has joined #openstack-nova | 13:32 | |
dansmith | i.e. it doesn't represent a thing that is either done or not | 13:32 |
*** popw has quit IRC | 13:32 | |
*** dulek has joined #openstack-nova | 13:32 | |
*** otter768 has joined #openstack-nova | 13:33 | |
*** dulek_ has quit IRC | 13:33 | |
johnthetubaguy | dansmith: OK, I will check with ttx on tuesday, technically he has to review any exceptions, but I am fine with that | 13:37 |
johnthetubaguy | fine with leaving it open, that is | 13:37 |
*** otter768 has quit IRC | 13:37 | |
dansmith | johnthetubaguy: exceptions to being left open in LP you mean? | 13:37 |
dansmith | johnthetubaguy: these cleanups aren't an exception, they're "almost bugs" :) | 13:37 |
dansmith | johnthetubaguy: anyway, I need to get them proposed and then we can discuss their bugness or not | 13:38 |
johnthetubaguy | dansmith: ah, closing it off and treating it as an important-ish bug might work better then | 13:39 |
dansmith | johnthetubaguy: okay, I'll let you mind the process loopholes :) | 13:39 |
johnthetubaguy | lol | 13:40 |
dansmith | johnthetubaguy: so on this https://review.openstack.org/#/c/163798/2 | 13:40 |
dansmith | johnthetubaguy: allowing force_delete to bypass the task_state just means that a user can hammer the API because the delete isn't completing fast enough | 13:40 |
*** setuid has quit IRC | 13:40 | |
dansmith | johnthetubaguy: I'm surprised you're okay with that premise | 13:40 |
johnthetubaguy | dansmith: yeah, I was just rethinking that idea… but I couldn't come up with a better idea yet | 13:41 |
dansmith | johnthetubaguy: well, admins can reset-state to clear it and let it try again | 13:41 |
dansmith | johnthetubaguy: I would like it to not be something that needs support intervention, | 13:42 |
dansmith | but I also know that given the opportunity to hit the button more, I'd do it | 13:42 |
*** dave-mccowan has quit IRC | 13:42 | |
*** setuid has joined #openstack-nova | 13:43 | |
dansmith | johnthetubaguy: we could have a configurable retry limit where if updated_at is more than 120 seconds old and task_state is deleting, then let them go again | 13:43 |
*** thomasem has joined #openstack-nova | 13:43 | |
johnthetubaguy | dansmith: yeah, for such and edge case, I can see that being the best bet... | 13:43 |
*** abhishekkk has quit IRC | 13:43 | |
johnthetubaguy | dansmith: sounds like too much effort, but I see your point | 13:43 |
bauwser | johnthetubaguy: you said tuesday about exceptions ? | 13:44 |
openstackgerrit | sahid proposed openstack/nova: compute: make test rpcapi more flexible https://review.openstack.org/164177 | 13:44 |
bauwser | johnthetubaguy: I had a question yesterday about tues vs. thurs for FF, but I don't remember what's it | 13:44 |
mriedem | dansmith: johnthetubaguy: keep in mind that https://review.openstack.org/#/c/163515/ should keep us out of this state of not being able to delete error'ed instances a bit | 13:44 |
dansmith | johnthetubaguy: it just seems like a weird exception to make, why not let me retry a stop() command if I think it has been ignored? | 13:44 |
mriedem | if we are getting stuck instances, we probably aren't reverting task state in the proper places on failure | 13:44 |
*** _gryf is now known as _gryf|afk | 13:44 | |
dansmith | mriedem: yes, the example in the commit message is for the message being lost because rabbit gets shot in the head, | 13:45 |
dansmith | which this wouldn't cover right?\ | 13:45 |
* dansmith checks rpcapi | 13:45 | |
*** thomasem has quit IRC | 13:45 | |
mriedem | oh, well, then all bets are off i guess :) | 13:46 |
*** thomasem has joined #openstack-nova | 13:46 | |
openstackgerrit | Sean Dague proposed openstack/nova: Add shadow table empty verification https://review.openstack.org/164178 | 13:46 |
sdague | so that's the test case for the corruption issue that zzzeek posted about | 13:46 |
PaulMurray | figleaf, thanks - already did rebase on it, so all good - pushing changes shortly | 13:46 |
figleaf | PaulMurray: ack | 13:46 |
dansmith | mriedem: yeah, it's a cast | 13:47 |
johnthetubaguy | dansmith: I was assuming non-persistent queues so the message got lost with the rabbit reboot, and never made it to compute, but totally agreed its too aggressive | 13:48 |
*** mikehn_ has quit IRC | 13:48 | |
dansmith | johnthetubaguy: right, I think that's the assumption in the patch | 13:48 |
johnthetubaguy | dansmith: I think we run persistent to avoid that, actually | 13:49 |
*** mikehn has joined #openstack-nova | 13:49 | |
johnthetubaguy | although I get confused about what that really means now… | 13:50 |
*** dboik has quit IRC | 13:50 | |
dansmith | johnthetubaguy: so actually, I'm not sure that patch is doing what it thinks it is | 13:50 |
dansmith | johnthetubaguy: because it's setting task_state=None on the decorator, which I think equates to "must be None" | 13:50 |
*** dboik has joined #openstack-nova | 13:50 | |
*** park has quit IRC | 13:51 | |
dansmith | oh, no it does, I was reading the decorator wrong the other day | 13:51 |
johnthetubaguy | dansmith: yeah, I had to re-read that too, (None,) is the other way | 13:52 |
dansmith | well, I had misread the bit at the top, which converted task_state to a set if it wasn't | 13:53 |
dansmith | and I thought =None would become =(None,), but it won't | 13:53 |
johnthetubaguy | bauwser: the deadline is Thursday, but things that look very unlikely tend to get kicked out on the Tuesday, as with all deadlines we have really. | 13:53 |
*** ferest has quit IRC | 13:53 | |
*** obutenko_ has joined #openstack-nova | 13:54 | |
sdague | mriedem: you want to review the fix for your issue from yesterday - https://review.openstack.org/#/c/163970/ ? | 13:55 |
mriedem | at some point | 13:55 |
mriedem | several plates spinning atm | 13:55 |
sdague | ok | 13:55 |
*** dave-mccowan has joined #openstack-nova | 13:56 | |
alex_xu | johnthetubaguy: emmm.....I think we can decide to defer db layer policy patches to L, still have about 30 patches. we can't merge them in one week. | 13:58 |
johnthetubaguy | alex_xu: ah, understood, how do you want to handle that, if you WIP or abandon them, we can avoid the -2 faf? | 13:58 |
alex_xu | johnthetubaguy: yes, I can WIP them, and tell the team set WIP them | 13:59 |
*** dansmith is now known as superdan | 13:59 | |
*** thangp has joined #openstack-nova | 13:59 | |
openstackgerrit | Michal Rostecki proposed openstack/nova: Adding security groups to existing ports https://review.openstack.org/163780 | 14:00 |
sahid | jaypipes, superdan if you can add this into your queue, nothing hurry just a clean https://review.openstack.org/#/c/157363/ | 14:00 |
alex_xu | johnthetubaguy: v2.1 related policy patches just left 5 patches, still have chance finish them. | 14:00 |
johnthetubaguy | alex_xu: cool, lets focus on those, I guess they are in the etherpad already? https://etherpad.openstack.org/p/kilo-nova-priorities-tracking | 14:00 |
alex_xu | johnthetubaguy: no, I can update in that etherpad | 14:01 |
*** apuimedo has quit IRC | 14:01 | |
superdan | sahid: my queueth overfloweth :/ | 14:01 |
sahid | superdan: ask you manager to give you budget for more memory :) | 14:02 |
superdan | heh | 14:02 |
superdan | sahid: you know, we could make the constants be "service names" instead of "binaries" | 14:02 |
*** ankit_ag has quit IRC | 14:03 | |
johnthetubaguy | alex_xu: shall we merge this one? then mark the BP as partially complete? https://review.openstack.org/#/c/160269/ | 14:03 |
superdan | sahid: mdbooth had comments on that verbiage, I wonder if it would be more clear if we intentionally had the discrepancy so people know what "binary" we're talking about | 14:03 |
*** jecarey has joined #openstack-nova | 14:03 | |
mdbooth | superdan: Nah, I rowed back on that. | 14:04 |
sahid | superdan: hum... i tried to keep the same convention with use for the query | 14:04 |
superdan | mdbooth: I'm talking about sahid's patch | 14:04 |
mdbooth | superdan: Yeah, that's where I started on that particular review trail. Didn't I row back on that patch? | 14:04 |
mdbooth | Certainly intended to. | 14:04 |
superdan | oh, I didn't realize you started from his patch | 14:05 |
superdan | okay | 14:05 |
mdbooth | The 'binary' moniker is from 2010 | 14:05 |
mdbooth | So it's confusing, but not worth changing. | 14:05 |
superdan | right, but he's adding constants which are really "service names" so even though changing the db layer would be heavy, we _could_ call the list of constants something else if it would make it clearer | 14:05 |
*** Nikolay_St has joined #openstack-nova | 14:05 | |
*** apuimedo has joined #openstack-nova | 14:06 | |
*** r-daneel has joined #openstack-nova | 14:06 | |
mdbooth | superdan: Yeah, once I saw it came from the db, I decided that consistency was the best option | 14:06 |
superdan | okay | 14:06 |
mdbooth | Nothing worse than a thing with multiple names in different places | 14:06 |
superdan | flavor and instance_type? :) | 14:06 |
alex_xu | johnthetubaguy: it's ok merge it. | 14:06 |
*** mpovolny has quit IRC | 14:06 | |
mdbooth | superdan: for eg | 14:06 |
superdan | and then danpb using "flavour" in all his specs :) | 14:06 |
*** dims has quit IRC | 14:06 | |
johnthetubaguy | alex_xu: I will abandon the other ones that are "obvious" | 14:06 |
*** jaypipes is now known as leakypipes | 14:07 | |
sahid | :) | 14:07 |
*** dims has joined #openstack-nova | 14:07 | |
*** shyama has quit IRC | 14:07 | |
alex_xu | johnthetubaguy: ok | 14:07 |
bauwser | superdan: quick question, do I need to bump an Object version if I change a field to be nullable ? | 14:09 |
alex_xu | johnthetubaguy: I updated the v2.1 patches in etherpad under " API v2.1 / microversions" section https://etherpad.openstack.org/p/kilo-nova-priorities-tracking | 14:09 |
superdan | bauwser: yeah | 14:09 |
superdan | bauwser: I'm going to start working on that patch for you as soon as I get coffee | 14:09 |
bauwser | superdan: erm, why ? I would think it would be needed if I would change a field to be non-nullable - because previous clients could not provide it - but changing a field to be nullable just means that we leave the clients do or not | 14:10 |
bauwser | superdan: old ones will still provide it | 14:11 |
johnthetubaguy | alex_xu: ah, so the only ones we want before kilo for that blueprint (https://blueprints.launchpad.net/nova/+spec/v3-api-policy) are the ones on the etherpad, just to check? | 14:11 |
openstackgerrit | John Garbutt proposed openstack/python-novaclient: Adds support for x509 certificates as keypairs https://review.openstack.org/136458 | 14:12 |
*** pkoniszewski has quit IRC | 14:12 | |
alex_xu | m/ | 14:12 |
superdan | bauwser: because if we try to pass a newer one with field=None to an older client, it needs to know to kick it back for backporting | 14:13 |
superdan | bauwser: and then you have to figure out how to replace the value :) | 14:13 |
sdague | alex_xu: honestly, the db layer policy patches are pretty easy | 14:14 |
sdague | why don't you think we can actually get them up and merged | 14:14 |
bauwser | superdan: mmm I see | 14:15 |
sdague | I'd rather get that bit finished than only be half finished in kilo. | 14:15 |
*** dboik has quit IRC | 14:15 | |
*** Longgeek has joined #openstack-nova | 14:15 | |
*** Ananci has joined #openstack-nova | 14:16 | |
*** nelsnelson has joined #openstack-nova | 14:16 | |
*** amotoki has quit IRC | 14:16 | |
*** nelsnelson has quit IRC | 14:16 | |
bauwser | superdan: well, I was knowing that no new clients would have called the old ones by not providing a field, but that's understandable | 14:16 |
*** dboik has joined #openstack-nova | 14:16 | |
bauwser | superdan: here, the thing is that old Juno computes will provide a service_id field while new Kilo won't | 14:16 |
bauwser | superdan: so that's why there will be no call from a new to an old | 14:16 |
alex_xu | sdague: there are a lot of patches https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/v3-api-policy,n,z | 14:17 |
bauwser | superdan: but that's fine | 14:17 |
bauwser | superdan: I'll provide the backport anyway | 14:17 |
superdan | bauwser: yeah, but you shouldn't just cut the rules because you know that, IMHO.. gets too confusing down the road | 14:17 |
alex_xu | sdague: if we think we have confidence merge them, I will continue update them | 14:17 |
bauwser | superdan: agreed, that's my point - I understand the rules, I'm not a freaky bad teacher doing heroin | 14:17 |
* alex_xu network is super slow, may drop the line anytime | 14:18 | |
superdan | bauwser: uh, what? :) | 14:18 |
*** afazekas has quit IRC | 14:18 | |
*** vigneshvar has quit IRC | 14:18 | |
bauwser | superdan: eh, not heroin, metamphetamine | 14:18 |
bauwser | superdan: sorry, just been binge watching Better Call Saul | 14:19 |
superdan | huh, I've never heard of that | 14:19 |
sdague | alex_xu: I'd say lets try to get them in | 14:20 |
bauwser | Breaking Bad then ? | 14:20 |
*** dboik has quit IRC | 14:21 | |
alex_xu | sdague: ok, glad to hear that :) | 14:21 |
sdague | alex_xu: instead of -1ing patches for that, I'd ask you to fix the patches in question | 14:21 |
*** bkopilov has joined #openstack-nova | 14:21 | |
superdan | bauwser: but the teacher didn't _do_ the meth, just cooked it... | 14:21 |
*** nelsnelson has joined #openstack-nova | 14:21 | |
bauwser | call me Jesse and you would be Walter... | 14:21 |
*** dboik has joined #openstack-nova | 14:21 | |
alex_xu | sdague: ok, will fix them soon | 14:21 |
superdan | man, this took a weird turn.. :P | 14:21 |
bauwser | :) | 14:21 |
*** dims is now known as dimsum__ | 14:21 | |
alex_xu | johnthetubaguy: ^^ change the plan, continue update db layer patches | 14:22 |
dimsum__ | bauwser: i binge watched Breaking Bad. Better Call Saul seems ok so far | 14:23 |
johnthetubaguy | alex_xu: OK, it would be good to get it all done if we can, I mean still work raising the most important fixes first | 14:23 |
*** Nikolay_St has quit IRC | 14:23 | |
alex_xu | johnthetubaguy: ok, got it | 14:23 |
sdague | it looks like the cells v2 stuff is basically just stacked on https://review.openstack.org/#/c/159266/ needing a config tweak? | 14:25 |
*** popw has joined #openstack-nova | 14:25 | |
mriedem | sdague: would be nice to get the cells job passing | 14:27 |
mriedem | i have one patch up to fix one thing | 14:27 |
mriedem | alaski: bauwser: was this still a thing being reviewed? http://logs.openstack.org/78/163978/1/check/check-tempest-dsvm-cells/f6d2cd2/logs/screen-n-api.txt.gz?level=TRACE#_2015-03-12_21_55_13_417 | 14:27 |
*** popw1 has quit IRC | 14:27 | |
mriedem | i think that's a large majority of the remaining failures i'm seeing | 14:27 |
sdague | mriedem: patch url? | 14:28 |
alaski | sdague: yep, going to be addressing that shortly | 14:28 |
mriedem | https://review.openstack.org/#/c/157185/ ? | 14:28 |
mriedem | yeah that's the one sdague ^ | 14:28 |
alaski | mriedem: yes, those two should fix it | 14:29 |
mriedem | alaski: are you +2 on https://review.openstack.org/#/c/157185/ ? | 14:29 |
mriedem | well, let me just check jenkins | 14:29 |
mriedem | still busted http://logs.openstack.org/85/157185/7/check/check-tempest-dsvm-cells/8acbe4d/logs/screen-n-api.txt.gz?level=TRACE#_2015-03-11_12_18_37_775 | 14:30 |
sdague | mriedem: so that doesn't change any tempest test failures | 14:31 |
sdague | it's 11 fails before that and 11 after | 14:31 |
alaski | mriedem: there are two patches | 14:31 |
mriedem | ha | 14:31 |
mriedem | oops | 14:31 |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for service_get_by_host* https://review.openstack.org/150349 | 14:32 |
alaski | mriedem: but yes, I'm +2. | 14:32 |
mriedem | there are still UnexpectedVMStateErrors here http://logs.openstack.org/06/160506/5/check/check-tempest-dsvm-cells/09366dc/logs/screen-n-cell-region.txt.gz?level=TRACE | 14:32 |
*** aysyd has quit IRC | 14:32 | |
mriedem | lots of errors here: http://logs.openstack.org/06/160506/5/check/check-tempest-dsvm-cells/09366dc/logs/screen-n-api.txt.gz?level=TRACE | 14:32 |
*** Nakato has quit IRC | 14:33 | |
*** Nakato has joined #openstack-nova | 14:34 | |
*** ociuhandu has joined #openstack-nova | 14:35 | |
alaski | mriedem: yeah, we recently noticed that failure at the cells meeting yesterday. For the negative tests that was fixed at some point and regressed so I need to dig in there | 14:35 |
alaski | I'm not sure on the other failures yet | 14:36 |
mriedem | ok | 14:36 |
*** aysyd has joined #openstack-nova | 14:36 | |
mriedem | if we could get that job passing, i say we make it voting so we don't have to untangle so much | 14:36 |
alaski | agreed | 14:36 |
*** thedodd has joined #openstack-nova | 14:36 | |
mriedem | i see the ceph job is recently regressed to | 14:37 |
mriedem | *too | 14:37 |
alaski | we've been chipping at the cells job, but haven't quite crossed the line yet | 14:37 |
*** tonytan4ever has joined #openstack-nova | 14:38 | |
*** cbader has joined #openstack-nova | 14:40 | |
*** Nikolay_St has joined #openstack-nova | 14:40 | |
*** exploreshaifali has quit IRC | 14:42 | |
bauwser | dimsum__: mriedem: sorry folks, my pidgin client suffers from a no voice today | 14:44 |
bauwser | alaski: I made a mistake on the 2nd patch where mriedem gave -1, we should no longer use ComputeNode.get_by_service_id | 14:46 |
bauwser | oops | 14:46 |
*** amotoki has joined #openstack-nova | 14:46 | |
openstackgerrit | Andrew Laski proposed openstack/nova: Add support for multiple database engines https://review.openstack.org/159266 | 14:46 |
openstackgerrit | Andrew Laski proposed openstack/nova: Use the proper database engine for nova-manage https://review.openstack.org/161833 | 14:46 |
*** shaohe_feng1 has joined #openstack-nova | 14:46 | |
alaski | bauwser: ok. I haven't looked at that one yet | 14:46 |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Deprecate V1.1, add basic stuff for microversions https://review.openstack.org/152569 | 14:47 |
superdan | bauwser: where is your bug for that service stuff? | 14:47 |
shaohe_feng1 | alex_xu: hi | 14:47 |
openstackgerrit | Andrew Laski proposed openstack/nova: Objects: use setattr rather than dict syntax in remotable https://review.openstack.org/163974 | 14:48 |
openstackgerrit | Andrew Laski proposed openstack/nova: Add get_api_session to db api https://review.openstack.org/161866 | 14:48 |
openstackgerrit | Andrew Laski proposed openstack/nova: Split NovaPersistentObject mixin https://review.openstack.org/163605 | 14:48 |
bauwser | bauwser: sorry which one ? | 14:48 |
bauwser | argh | 14:48 |
*** alaski is now known as lascii | 14:48 | |
*** vmtrooper has joined #openstack-nova | 14:48 | |
shaohe_feng1 | hi all, | 14:48 |
* bauwser is becoming schizopheric | 14:48 | |
*** thedodd has quit IRC | 14:48 | |
bauwser | superdan: sorry, which bug do you mention ? | 14:48 |
bauwser | superdan: I have many todos in parallel :) | 14:48 |
*** Longgeek has quit IRC | 14:49 | |
bauwser | superdan: you mean the bp/detach-service stuff ? | 14:49 |
lascii | superdan: I'm drawing a blank on how VERSION_ALIASES is used, is this correct here https://review.openstack.org/#/c/160507/12/nova/scheduler/rpcapi.py ? | 14:49 |
superdan | bauwser: no I mean 1431201 | 14:49 |
superdan | bauwser: your WIP patch claims to close that bug, but it should be partial-bug right? | 14:49 |
shaohe_feng1 | these 3 patches about V2.1 API policy are ready for a long time. | 14:50 |
shaohe_feng1 | https://review.openstack.org/#/c/149931/ | 14:50 |
shaohe_feng1 | https://review.openstack.org/#/c/150280/ | 14:50 |
shaohe_feng1 | https://review.openstack.org/#/c/150328/ | 14:50 |
superdan | lascii: we shouldn't set that alias until right before release | 14:50 |
shaohe_feng1 | any core can help review them? | 14:50 |
lascii | superdan: ok, so the fact that it's already set is a problem? | 14:50 |
lascii | superdan: well, incorrect at least | 14:51 |
superdan | lascii: yeah, not necessarily a problem, but not correct | 14:51 |
bauwser | superdan: nope, I checked and the error is fixed | 14:51 |
openstackgerrit | Dan Smith proposed openstack/nova: Break out the child version calculation logic from obj_make_compatible() https://review.openstack.org/164206 | 14:52 |
bauwser | superdan: I mean the recursive calls | 14:52 |
*** thedodd has joined #openstack-nova | 14:53 | |
*** ildikov_ has quit IRC | 14:53 | |
*** vmtrooper has quit IRC | 14:53 | |
*** subscope has quit IRC | 14:53 | |
superdan | bauwser: oh you had another patch for the other half that already merged, right? | 14:53 |
superdan | bauwser: but in this one, you still need to fix the version using my patch above, right? | 14:53 |
superdan | because you're passing back too new of a compute_node, right? | 14:54 |
alex_xu | shaohe_feng1: thanks | 14:55 |
*** popw has quit IRC | 14:57 | |
bauwser | superdan: exactly | 14:59 |
bauwser | superdan: I left a comment for it | 14:59 |
bauwser | superdan: that's the only reason of WIP | 14:59 |
*** thangp has quit IRC | 14:59 | |
superdan | okay, I'm confused | 14:59 |
bauwser | superdan: we should just move that helper either in the base class or elsewhere | 14:59 |
*** sdake has joined #openstack-nova | 15:00 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: WIP: assertJsonEqual for Timofey https://review.openstack.org/164210 | 15:00 |
bauwser | superdan: re: the bug, I had 2 patches | 15:00 |
superdan | OH, I was looking at an old PS | 15:00 |
superdan | man, I thought I was crazy | 15:00 |
bauwser | superdan: one has merged, the other is WIP due to the helper method I added | 15:00 |
bauwser | superdan: oh ok | 15:00 |
superdan | bauwser: https://review.openstack.org/164206 | 15:00 |
superdan | bauwser: want me to rebase yours on that, or do you want to? | 15:00 |
bauwser | superdan: that's a nice XMas gift | 15:00 |
bauwser | superdan: feel free to do so, I just discovered a last outstanding issue with bp/detach-service which makes the completion of it very difficult before FF | 15:01 |
superdan | okay, I will | 15:01 |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for floating_ip_dns https://review.openstack.org/150710 | 15:02 |
openstackgerrit | ShaoHe Feng proposed openstack/nova: enforce domain:update/delete policy for floating_ip_dns v2.1 REST API layer. https://review.openstack.org/160237 | 15:02 |
*** mriedem has quit IRC | 15:04 | |
*** gokrokve has joined #openstack-nova | 15:04 | |
*** pixelbeat has quit IRC | 15:05 | |
* leakypipes fires up some Cult - She Sells Sanctuary | 15:05 | |
leakypipes | digging in for a long day of reviews. | 15:06 |
openstackgerrit | Dan Smith proposed openstack/nova: Fix ComputeNode backport for Service.obj_make_compatible https://review.openstack.org/163867 | 15:06 |
superdan | bauwser: ^ | 15:06 |
*** thedodd has quit IRC | 15:06 | |
leakypipes | superdan: easy objects win: https://review.openstack.org/#/c/149322/ | 15:07 |
bauwser | superdan: ty | 15:07 |
*** pixelb has joined #openstack-nova | 15:08 | |
superdan | johnthetubaguy: so that patch (from leakypipes) is an example of something against the blueprint, but which isn't a feature nor a bug, IMHO, but that we really don't need to block quite yet | 15:09 |
superdan | johnthetubaguy: what do you think? | 15:09 |
leakypipes | superdan: it's targeted at kilo-objects blueoprint. | 15:09 |
leakypipes | superdan: ah, sorry, yes, you just said that :) | 15:09 |
superdan | leakypipes: I know, this morning johnthetubaguy was asking if he could mark that blueprint as implemented and stop approving patches against it, which is why I'm using this as an example | 15:09 |
superdan | yeah :) | 15:10 |
leakypipes | sorry for the noise.. | 15:10 |
leakypipes | superdan: reviewing your child version object patches now... | 15:10 |
bauwser | superdan: leakypipes: I will have the same paperwork problem, because I need to nullify service_id in ComputeNode | 15:10 |
*** Marga_ has quit IRC | 15:10 | |
leakypipes | bauwser: right. I don't think we should be holding up things like this for paperwork problems. | 15:10 |
bauwser | if I'm not able to remove the service_id field in the RT, it will defer the problem till Mmmm | 15:11 |
*** erlon has quit IRC | 15:11 | |
bauwser | because old 'Kilo' nodes will still have this field in it | 15:11 |
bauwser | and Meuh ones won't | 15:11 |
bauwser | I mean Lemming ones | 15:11 |
leakypipes | lol | 15:12 |
superdan | bauwser: is this something that just got missed in the detach-service blueprint? | 15:12 |
figleaf | bauwser: can I help with any of the detach stuff? | 15:12 |
*** nellysmitt has quit IRC | 15:12 | |
*** mtanino has joined #openstack-nova | 15:13 | |
*** jgrimm has quit IRC | 15:13 | |
bauwser | superdan: just to be clear, all the blueprint helped to use the host field instead of service_id and provide backwards compat | 15:13 |
*** jgrimm has joined #openstack-nova | 15:14 | |
bauwser | superdan: so atm, Juno computes are sending service_id only and Kilo ones are sending both service_id and host | 15:14 |
bauwser | superdan: ideally, Kilo ones should only send host, not service_id | 15:14 |
superdan | does it really matter? | 15:14 |
leakypipes | superdan: +2 from me on both those obj_make_compat patches. | 15:14 |
bauwser | superdan: that's due to https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L417 | 15:15 |
bauwser | superdan: not really, all the target objectives have been reached | 15:15 |
superdan | leakypipes: thanks | 15:15 |
leakypipes | superdan: for you? any time. | 15:15 |
superdan | leakypipes: <3 | 15:15 |
bauwser | superdan: but it would defer the removal of the backwards compat by North instead of Meuh | 15:15 |
superdan | north? | 15:16 |
bauwser | Nxxx | 15:16 |
superdan | oh, heh, not sure why you say that | 15:16 |
bauwser | I don't have yet a super play of words | 15:16 |
johnthetubaguy | superdan: so I am honestly very torn with this, my personal preference says we should never really stop those kinds of patches… but technically it violates FPF, but its basically unenforceable, so I am mostly ignoring those details till FF, at which point, I think its ttx's call about what can merge, but it feels like a very similar level of risk as unit test fixups | 15:16 |
superdan | how does something we do in kilo matter to N? | 15:16 |
alex_xu | advertse the policy patch which ready to review and merge, on the top of etherpad https://etherpad.openstack.org/p/apipolicycheck | 15:17 |
bauwser | superdan: I was maybe unclear, I will rephrase | 15:17 |
superdan | johnthetubaguy: I guess the question is whether FPF covers everything without a bug attached, or not | 15:17 |
bauwser | superdan: once RT will stop writing service_id, it will need 2 cycles more to kill the compat code | 15:17 |
superdan | johnthetubaguy: because the kilo-objects blueprint is almost all "cleanups" | 15:17 |
superdan | bauwser: why? can't we just ignore it if kilo nodes send it, but also send host? | 15:18 |
*** browne has joined #openstack-nova | 15:18 | |
bauwser | superdan: oic | 15:18 |
bauwser | superdan: yeah, we can just say "eh, no matters" | 15:19 |
*** nkrinner has quit IRC | 15:19 | |
superdan | johnthetubaguy: I can see us not merging any of these things after FF because of the potential for regressions (or really k3 would be more appropriate, IMHO) | 15:19 |
bauwser | superdan: the last real important stuff is https://review.openstack.org/155319 | 15:19 |
superdan | johnthetubaguy: anyway, we probably need to figure out what the word on that is going to be :) | 15:19 |
superdan | bauwser: aye | 15:20 |
bauwser | superdan: so indeed you're right, we can only assume that as host is provided since Kilo and we support N+1 compat, we can still remove the compat code by Meuh (Mxxx) | 15:20 |
superdan | bauwser: is that ready? why hasn't leakypipes +W'd? | 15:20 |
superdan | bauwser: right | 15:20 |
bauwser | superdan: my bad, I only have a rookie level on rolling upgrades | 15:21 |
leakypipes | bauwser: reviewing that now. | 15:21 |
bauwser | leakypipes: your call | 15:21 |
superdan | bauwser: it's all good :) | 15:21 |
johnthetubaguy | superdan: k3 = FF I think thats when we have to stop, but I am going with FPF doesn't stop clean up patches being proposed, but i am not sure thats what the "law" says, depends how you read it | 15:21 |
superdan | johnthetubaguy: oh, I thought k3 was a little later | 15:21 |
openstackgerrit | Sean Dague proposed openstack/nova: remove unneeded teardown code https://review.openstack.org/164216 | 15:21 |
superdan | johnthetubaguy: okay, so do you want to get a ruling, or shall we use your call as the ruling? :) | 15:21 |
johnthetubaguy | superdan: not sure, honestly seems more effort than its worth, lets just worry about k3/FF at this point, FPF has happened in the sense that we don't have brand new feature code being proposed now, so I think we are good | 15:24 |
superdan | johnthetubaguy: okay, sounds good | 15:24 |
superdan | leakypipes: +W | 15:25 |
* leakypipes goes to propose some brand new feature code... just to make things interesting. :) | 15:25 | |
superdan | leakypipes: don't be a hater. | 15:25 |
leakypipes | lol | 15:25 |
superdan | :) | 15:26 |
figleaf | leakypipes: care to review https://review.openstack.org/#/c/160507 again? | 15:26 |
leakypipes | figleaf: already on my list, yep. | 15:26 |
dimsum__ | figleaf: nice nick :) | 15:26 |
figleaf | leakypipes: thx | 15:26 |
figleaf | dimsum__: yours isn't too bad either :) | 15:27 |
*** thangp has joined #openstack-nova | 15:27 | |
* bauwser wonders when someone will complain about finding nicks for a specific person | 15:28 | |
*** tsekiyama has joined #openstack-nova | 15:28 | |
openstackgerrit | Radoslav Gerganov proposed openstack/nova: VMware: Replace get_dynamic_property with get_object_property https://review.openstack.org/164220 | 15:28 |
*** erlon has joined #openstack-nova | 15:29 | |
leakypipes | bauwser: excellent work. +Wd. | 15:29 |
openstackgerrit | Jay Pipes proposed openstack/nova: Fix PciDeviceDBApiTestCase with referential constraint checking https://review.openstack.org/156673 | 15:30 |
bauwser | leakypipes: so I'm happy to say we can consider bp/detach-service as implemented for Kilo | 15:30 |
bauwser | leakypipes: that will still require some further work for Liberty (remove service_id from RT and nullify it in ComputeNode) and Mxxx (remove compat' code) but that's fine, I'll open a new spec for it | 15:31 |
johnthetubaguy | bauwser: shall I mark it as partially complete for kilo now? | 15:32 |
bauwser | johnthetubaguy: your call | 15:32 |
johnthetubaguy | bauwser: is it complete for kilo? | 15:32 |
bauwser | johnthetubaguy: it's like the objects BP, we can't do all things by one release, due to compat | 15:32 |
leakypipes | bauwser: yay! :) | 15:32 |
johnthetubaguy | bauwser: right, thats all good, so the kilo bit of work is complete, thats all we need to do | 15:32 |
leakypipes | johnthetubaguy: mark it complete. yeah. bauwser will open another one for the compat cleanup. | 15:33 |
bauwser | johnthetubaguy: yeah, what was targeted is now implemented, but as I said, there are further work for the future | 15:33 |
*** david-lyle_afk is now known as david-lyle | 15:33 | |
bauwser | johnthetubaguy: at least, wait Jenkins to merge the code | 15:33 |
bauwser | johnthetubaguy: ie.https://review.openstack.org/#/c/155319/14 | 15:33 |
johnthetubaguy | bauwser: yup, just added a comment to that effect | 15:33 |
bauwser | johnthetubaguy: ^ that's the last of the series | 15:33 |
*** otter768 has joined #openstack-nova | 15:33 | |
bauwser | johnthetubaguy: awesome, ty | 15:34 |
johnthetubaguy | bauwser: thank you! | 15:34 |
bauwser | johnthetubaguy: btw. that one was not 'partially-implementing' in the commit msg, but rather 'implementing' | 15:34 |
*** mriedem has joined #openstack-nova | 15:34 | |
johnthetubaguy | bauwser: not sure that actually works, but lets see | 15:35 |
*** rmoe has quit IRC | 15:35 | |
*** zzzeek has joined #openstack-nova | 15:35 | |
bauwser | johnthetubaguy: last question, as Liberty spec repo is open, shall I open a spec for compat code removal ? | 15:36 |
superdan | Ugh, you never want to see this for a one-line change: - Failed: 1550 | 15:36 |
johnthetubaguy | bauwser: can do, but not sure that needs a spec | 15:37 |
bauwser | johnthetubaguy: meaning that I'll open a new BP of course for Liberty, but shall I open a spec too ? | 15:37 |
*** adelinatuvenie has joined #openstack-nova | 15:37 | |
bauwser | johnthetubaguy: yeah, that's basically removing fields and code branches | 15:38 |
bauwser | johnthetubaguy: that's very techy | 15:38 |
johnthetubaguy | bauwser: yeah, don't think it needs a spec though | 15:38 |
*** otter768 has quit IRC | 15:38 | |
bauwser | johnthetubaguy: yeah, I thought about it, hence the DB migration landed by Kilo, in order to make it wouldn't require a spec | 15:39 |
*** thedodd has joined #openstack-nova | 15:39 | |
johnthetubaguy | bauwser: maybe I am miss understand what you mean | 15:41 |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for security_group_default_rule_destroy https://review.openstack.org/160257 | 15:41 |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for security_group_default_rule_create https://review.openstack.org/150718 | 15:41 |
bauwser | johnthetubaguy: the whole idea of the BP is to replace a field by another one which wouldn't suffer from an explicit DB relationship | 15:42 |
*** jcoufal_ has quit IRC | 15:42 | |
bauwser | johnthetubaguy: so I did that, and the last point was to make the old field nullable in DB - and remove that relationship | 15:42 |
johnthetubaguy | bauwser: oh, I thought you meant something difference, thats worth a spec | 15:42 |
*** dboik_ has joined #openstack-nova | 15:43 | |
*** dboik has quit IRC | 15:43 | |
bauwser | johnthetubaguy: nope, I mean I know that DB migration require a spec, that's it :) | 15:43 |
johnthetubaguy | bauwser: gotcha, I thought you meant like the RPC API compat code all over the place, ignore me | 15:43 |
*** mdbooth has quit IRC | 15:45 | |
*** exploreshaifali has joined #openstack-nova | 15:46 | |
openstackgerrit | jichenjc proposed openstack/nova: Add @wrap_exception() for 3 compute functions https://review.openstack.org/153523 | 15:46 |
*** Nikolay_St has quit IRC | 15:47 | |
*** thedodd has quit IRC | 15:49 | |
*** mdbooth has joined #openstack-nova | 15:50 | |
*** armax has joined #openstack-nova | 15:52 | |
*** unicell1 has joined #openstack-nova | 15:52 | |
*** rmoe has joined #openstack-nova | 15:52 | |
*** unicell has quit IRC | 15:53 | |
*** hemna has joined #openstack-nova | 15:53 | |
*** marun has joined #openstack-nova | 15:54 | |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_associate https://review.openstack.org/161234 | 15:54 |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_set_host https://review.openstack.org/161625 | 15:54 |
openstackgerrit | ShaoHe Feng proposed openstack/nova: move the Netowrk V2 related api test from V21 to V2 test https://review.openstack.org/162564 | 15:54 |
mriedem | ndipanoff: should a DriverVolumeBlockDevice object always have connection_info set when attaching a volume after boot? | 15:54 |
ndipanoff | mriedem, yes - it comes from cinder | 15:55 |
openstackgerrit | jichenjc proposed openstack/nova-specs: Delete version specified code suggestion https://review.openstack.org/164229 | 15:55 |
mriedem | ndipanoff: looks like attach stores it in the bdm object via the @update_db decorator | 15:55 |
mriedem | ok | 15:55 |
mriedem | we have a race with detach_volume where bdm.connection_info is None | 15:55 |
mriedem | it's been around for a long time i think | 15:55 |
*** amotoki has quit IRC | 15:56 | |
openstackgerrit | Sean Dague proposed openstack/nova: remove unneeded teardown related code https://review.openstack.org/164216 | 15:56 |
openstackgerrit | Sean Dague proposed openstack/nova: Add shadow table empty verification https://review.openstack.org/164178 | 15:56 |
ndipanoff | mriedem, I saw a bug for that recently | 15:56 |
mriedem | http://logs.openstack.org/93/156693/7/check/check-tempest-dsvm-postgres-full/d3b26e8/logs/screen-n-cpu.txt.gz?level=TRACE#_2015-03-12_16_38_17_567 | 15:56 |
ndipanoff | let me dig a bit | 15:56 |
ndipanoff | or for something similar | 15:56 |
*** thedodd has joined #openstack-nova | 15:57 | |
mriedem | ndipanoff: https://bugs.launchpad.net/nova/+bug/1431899 - i know i've seen this before and had POC changes up to try and recreate with more info | 15:57 |
openstack | Launchpad bug 1431899 in OpenStack Compute (nova) "TestEncryptedCinderVolumes fails with 'NoneType can't be decoded'" [Undecided,New] | 15:57 |
mriedem | just couldn't find the older bugs | 15:57 |
*** toan-tran has quit IRC | 15:59 | |
*** Sukhdev has joined #openstack-nova | 15:59 | |
ndipanoff | mriedem, similar to https://bugs.launchpad.net/nova/+bug/1327218 ? | 15:59 |
openstack | Launchpad bug 1327218 in OpenStack Compute (nova) "Volume detach failure because of invalid bdm.connection_info" [High,Fix released] | 15:59 |
*** amotoki has joined #openstack-nova | 16:00 | |
sdague | mdbooth: https://review.openstack.org/#/c/164178/ fixed, I did a bad merge and didn't realize that teardown was removed (I was removing it myself in the follow on patch) | 16:00 |
mriedem | ndipanoff: yeah | 16:00 |
ndipanoff | mriedem, yeah... I don't know... we need a lock per method | 16:01 |
mdbooth | sdague: Yeah, guessed as much. | 16:01 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Verify all quotas before updating the db https://review.openstack.org/163668 | 16:01 |
mriedem | ndipanoff: i'll reopen markmc's old bug and dupe against that | 16:01 |
ndipanoff | or per volume operation | 16:01 |
ndipanoff | yes | 16:01 |
mriedem | then get a logstash query open | 16:01 |
ndipanoff | that would be a good place to start | 16:01 |
ndipanoff | I'll look into fixing it | 16:01 |
ndipanoff | but no promises | 16:01 |
ndipanoff | :) | 16:02 |
openstackgerrit | jichenjc proposed openstack/nova: Delete version specified code suggestion https://review.openstack.org/164234 | 16:03 |
mriedem | ndipanoff: get some sleep! | 16:04 |
mriedem | it's the weekend | 16:04 |
mriedem | or go out i guess | 16:04 |
*** sdake has quit IRC | 16:04 | |
ndipanoff | mriedem, sleep | 16:05 |
ndipanoff | I'll take that option | 16:05 |
*** krykowski has quit IRC | 16:05 | |
openstackgerrit | Andrew Laski proposed openstack/nova: Fix how service objects are looked up for Cells https://review.openstack.org/160506 | 16:08 |
lascii | mriedem: bauwser still testing locally, but I think that update should eliminate the 500s and some traces | 16:09 |
shaohe_feng1 | hi cores, this is db policy api is ready: https://review.openstack.org/#/c/161622/ | 16:09 |
bauwser | lascii: coolio | 16:09 |
lascii | bauwser: I had previously fixed this in cells_api but since that's bypassed now... | 16:10 |
*** amotoki has quit IRC | 16:10 | |
bauwser | lascii: what's the change ? | 16:10 |
bauwser | lascii: I can just git review -m it of course | 16:10 |
lascii | bauwser: try/except in https://review.openstack.org/#/c/160506/6/nova/objects/service.py | 16:10 |
lascii | and an expected_exception wrapper on an rpcapi method | 16:11 |
*** browne has quit IRC | 16:11 | |
bauwser | lascii: minor nit, but shouldn't you add a unittest for this ? | 16:11 |
andreykurilin | hi everyone! I'm testing microversioning stuff with my patch https://review.openstack.org/#/c/152569/ and found strange behavior of API side. As Feodor Tersin mentioned in comments, microversions work only for service_type == "computev21" | 16:12 |
lascii | bauwser: yes, just seeing if it works atm | 16:12 |
bauwser | lascii: yeah understood | 16:12 |
andreykurilin | how it works now: http://paste.openstack.org/show/192127/ | 16:13 |
andreykurilin | leackypipes:^ | 16:14 |
openstackgerrit | John Garbutt proposed openstack/nova: Improve post_live_migrate error handling https://review.openstack.org/129881 | 16:15 |
*** rwsu-afk is now known as rwsu | 16:15 | |
bauwser | lascii: so you basically mimicated the exception to be handled correctly ? | 16:15 |
andreykurilin | Is such logic correct? | 16:15 |
andreykurilin | sdague: hi | 16:16 |
lascii | bauwser: right. not finding a host via cells routing would be the same as not finding it in a non cells setup, so we just need to translate the exception | 16:17 |
andreykurilin | jogo: hi | 16:17 |
sdague | andreykurilin: yes, we probably need to tweak the service end point for those tests | 16:18 |
openstackgerrit | Andrew Laski proposed openstack/nova: Fix how service objects are looked up for Cells https://review.openstack.org/160506 | 16:19 |
lascii | bauwser: now with a test | 16:19 |
leakypipes | sdague: there should be no new "service_type" for microversions... should just continue to be "compute", no? | 16:19 |
sdague | leakypipes: if devstack sets up the service catalog correctly | 16:20 |
sdague | however, right now, the compute entry is the v2 endpoint still | 16:20 |
sdague | I think there is a patch to flip that | 16:20 |
bauwser | lascii: awesome ty | 16:21 |
*** amotoki has joined #openstack-nova | 16:22 | |
*** jogo is now known as flashgordon | 16:22 | |
*** tjones1 has joined #openstack-nova | 16:22 | |
*** sdake has joined #openstack-nova | 16:23 | |
bauwser | lascii: something is still unclear with that change, does that mean that any exception raised on a child cell is returned as as CellRoutingInconsistency exception or is it only for some additional cases ? | 16:24 |
bauwser | lascii: to rephrase, what are the cases where that exception is raised ? typically when states are incorrect? | 16:24 |
andreykurilin | sdague: why additional endpoint is needed? | 16:25 |
bauwser | lascii: nm, I'm reading the code, gotcha | 16:25 |
mriedem | shouldn't auth_password for the bdm be scrubbed from the logs here? | 16:26 |
mriedem | http://logs.openstack.org/93/156693/7/check/check-tempest-dsvm-postgres-full/d3b26e8/logs/screen-n-cpu.txt.gz#_2015-03-12_16_44_54_876 | 16:26 |
*** amotoki has quit IRC | 16:27 | |
*** sahid has quit IRC | 16:27 | |
openstackgerrit | Paul Murray proposed openstack/nova: Use compute_node consistently in ResourceTracker https://review.openstack.org/159765 | 16:29 |
openstackgerrit | Paul Murray proposed openstack/nova: Cleanups for pci stats in preparation for RT using ComputeNode https://review.openstack.org/161843 | 16:29 |
openstackgerrit | Paul Murray proposed openstack/nova: Convert RT compute_node to be a ComputeNode object https://review.openstack.org/160942 | 16:29 |
openstackgerrit | Paul Murray proposed openstack/nova: Move ComputeNode creation at init stage in ResourceTracker https://review.openstack.org/148904 | 16:29 |
*** sbfox has joined #openstack-nova | 16:30 | |
*** sbfox has quit IRC | 16:31 | |
*** sbfox has joined #openstack-nova | 16:32 | |
*** Longgeek has joined #openstack-nova | 16:34 | |
*** dulek has quit IRC | 16:34 | |
*** dboik_ has quit IRC | 16:36 | |
*** lpetrut has quit IRC | 16:37 | |
*** dboik has joined #openstack-nova | 16:37 | |
*** vmtrooper has joined #openstack-nova | 16:37 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Deprecate V1.1, add basic stuff for microversions https://review.openstack.org/152569 | 16:37 |
openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in agent, aggregate https://review.openstack.org/164243 | 16:39 |
openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in bandwidth, block_device https://review.openstack.org/164244 | 16:39 |
openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in ec2 object https://review.openstack.org/164245 | 16:39 |
openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in fixed_ip, flavor, floating_ip https://review.openstack.org/164246 | 16:39 |
openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in instance* objects https://review.openstack.org/164247 | 16:39 |
openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in compute_node, keypair https://review.openstack.org/164248 | 16:39 |
openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in migration, network https://review.openstack.org/164249 | 16:39 |
bauwser | figleaf: sorry but I had to leave -1 for your no-op methods | 16:39 |
openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in pci_device, quotas https://review.openstack.org/164250 | 16:39 |
openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in security_group* https://review.openstack.org/164251 | 16:39 |
openstackgerrit | Dan Smith proposed openstack/nova: Remove usage of remotable context parameter in service, tag, vif https://review.openstack.org/164252 | 16:39 |
openstackgerrit | Dan Smith proposed openstack/nova: Actually stop passing context to remotable methods https://review.openstack.org/164253 | 16:39 |
*** pkoniszewski has joined #openstack-nova | 16:39 | |
bauwser | figleaf: erm, was obfuscated by a long chain | 16:40 |
figleaf | bauwser: I was specifically asked to separate them out | 16:40 |
bauwser | figleaf: as I said, could you pleasy very quickly flip the logic of your series and do the methods before calling thme ? | 16:40 |
bauwser | figleaf: yeah this is good, but you should first provide the methods, and call them afterwards | 16:41 |
*** melwitt has joined #openstack-nova | 16:41 | |
*** kaufer has quit IRC | 16:41 | |
bauwser | figleaf: we're 3 working days before FF, that sounds extremely risky | 16:41 |
bauwser | figleaf: and CI will probably be drained by the last 2 days | 16:42 |
*** vmtrooper has quit IRC | 16:42 | |
bauwser | figleaf: hence my ping, as I said, I'm ready to cast you my vote once you do that | 16:42 |
figleaf | bauwser: ok, give me a few minutes to get that worked out and tested | 16:42 |
bauwser | figleaf: sure | 16:42 |
bauwser | lascii: see above ^ | 16:43 |
bauwser | lascii: I would appreciate if you could give again your +2 once the flip is done | 16:43 |
*** ttx has quit IRC | 16:43 | |
*** ttx has joined #openstack-nova | 16:43 | |
*** Marga_ has joined #openstack-nova | 16:46 | |
*** pkoniszewski has quit IRC | 16:46 | |
openstackgerrit | Matthew Booth proposed openstack/nova: Fix PciDeviceDBApiTestCase with referential constraint checking https://review.openstack.org/156673 | 16:47 |
bauwser | figleaf: reviewing your HostManager change btw. | 16:48 |
figleaf | !1068 | 16:48 |
openstack | figleaf: Error: "1068" is not a valid command. | 16:48 |
figleaf | ugh | 16:48 |
*** iamjarvo has joined #openstack-nova | 16:48 | |
figleaf | too many freakin' windows open... | 16:49 |
*** matrohon has quit IRC | 16:49 | |
bauwser | :) | 16:49 |
*** mestery has quit IRC | 16:50 | |
*** mpaolino has joined #openstack-nova | 16:50 | |
*** mestery has joined #openstack-nova | 16:51 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Stop spamming logs when creating context https://review.openstack.org/164261 | 16:54 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Stop spamming logs when creating context https://review.openstack.org/164261 | 16:55 |
*** Longgeek has quit IRC | 16:56 | |
*** harlowja has joined #openstack-nova | 16:57 | |
*** kaufer has joined #openstack-nova | 17:01 | |
lascii | bauwser: sure, I'll review it once it's pushed | 17:02 |
*** sahid has joined #openstack-nova | 17:02 | |
sdague | dimsum__: so I'm +A on this - https://review.openstack.org/#/c/164261 however, the warning itself is honestly kind of useless. What is a log consumer going to do about that? So probably a better follow on would be a way in testing that could cause a fatal exception | 17:03 |
*** jlanoux has quit IRC | 17:03 | |
sdague | so that we know we don't ever do that by accident in the code | 17:04 |
openstackgerrit | Timofey Durakov proposed openstack/nova: Fixed archivation of deleted records https://review.openstack.org/164263 | 17:04 |
dimsum__ | sdague: yep, agreed | 17:04 |
*** mpovolny has joined #openstack-nova | 17:06 | |
*** browne has joined #openstack-nova | 17:07 | |
*** mpavone has quit IRC | 17:07 | |
*** iamjarvo has quit IRC | 17:08 | |
superdan | sdague: mriedem: https://github.com/openstack/nova/blob/master/nova/tests/unit/api/ec2/test_ec2utils.py#L29 | 17:08 |
superdan | any idea how that is working? | 17:08 |
tdurakov | sdague: Hi Sean. I send patch for review: https://bugs.launchpad.net/nova/+bug/1431571 | 17:08 |
openstack | Launchpad bug 1431571 in OpenStack Compute (nova) "archive_deleted_rows_for_table relies on reflection to access the "default" for soft-delete columns, but this is not a server default" [Critical,In progress] - Assigned to Timofey Durakov (tdurakov) | 17:08 |
superdan | it's a nodb test, no mocks for the db methods, but it's creating an EC2 object | 17:08 |
sdague | superdan: it only works because you didn't review my fix from yesterday | 17:09 |
mriedem | superdan: that's similar to what i was seeing yesterday | 17:09 |
mriedem | right | 17:09 |
superdan | WAT | 17:09 |
tdurakov | sdague: you are in reviewers | 17:09 |
sdague | superdan: https://review.openstack.org/#/c/163970/ | 17:09 |
superdan | zomg | 17:09 |
sdague | I did ask people a few times to review that one yesterday :) | 17:10 |
sdague | tdurakov: we already fixed that via a revert (landed) and have new test cases up in https://review.openstack.org/#/c/164178/ | 17:10 |
superdan | sdague: yes and all I did yesterday was goof off, right? :) | 17:10 |
sdague | :) | 17:11 |
*** mpaolino has quit IRC | 17:11 | |
sdague | nope, but anyway, the reason why it works is because of a bug in that fixture. That patch closes that bug, and makes a bunch of tests require the db again to pass. | 17:11 |
mriedem | sdague: ok i didn't realize you were going to switch things back to requiring the db | 17:11 |
sdague | mriedem: that's kind of what you have to do | 17:12 |
mriedem | sdague: so that just enforces that those have to be db tests until fixed? | 17:12 |
*** sbfox has quit IRC | 17:12 | |
tdurakov | sdague: It wont help | 17:12 |
sdague | there are folks that are scrubbing out the db need in tests | 17:12 |
sdague | tdurakov: yes, it will | 17:12 |
tdurakov | sdague: tests a correct | 17:12 |
sdague | no, the tests are wrong | 17:12 |
superdan | sdague: mriedem: some of those must have just been done with no actual inspection | 17:12 |
mriedem | they weren't | 17:13 |
superdan | sdague: mriedem: like, I made it a NoDB test and it passed, so it must not need db | 17:13 |
mriedem | yeah | 17:13 |
tdurakov | the problm was in insert from select statement | 17:13 |
sdague | tdurakov: no, that's a different problem | 17:13 |
mriedem | superdan: i had pointed out in one of the bugs why it wouldn't work | 17:13 |
*** Nic has joined #openstack-nova | 17:13 | |
sdague | tdurakov: there is another bug | 17:13 |
mriedem | anyway +W | 17:13 |
mriedem | i'm trying to dig out from this detach_volume gate turd | 17:13 |
tdurakov | sdague: have you seen my patch? | 17:13 |
sdague | tdurakov: https://bugs.launchpad.net/nova/+bug/1183523 is I think what you are trying to fix | 17:14 |
openstack | Launchpad bug 1183523 in OpenStack Compute (nova) "db-archiving fails to clear some deleted rows from instances table" [Medium,Confirmed] | 17:14 |
sdague | but there is a deeper issue of the archive inspection being wrong | 17:14 |
sdague | which is the corruption issue | 17:14 |
*** iamjarvo has joined #openstack-nova | 17:14 | |
*** annashen has joined #openstack-nova | 17:15 | |
tdurakov | sdague: the problem is deeper, I found it when experiment with random PYTHONHASHSEEDS | 17:15 |
openstackgerrit | Dan Smith proposed openstack/nova: Remove context from remotable call signature https://review.openstack.org/164268 | 17:15 |
*** patrickeast has joined #openstack-nova | 17:16 | |
*** mpaolino has joined #openstack-nova | 17:16 | |
sdague | tdurakov: ok, so, regardless, I think your patch has to be rebased, because I'm pretty sure it will be in merge conflict with existing code | 17:17 |
*** ildikov has joined #openstack-nova | 17:17 | |
tdurakov | sdague: no | 17:17 |
tdurakov | just rebase to master | 17:17 |
tdurakov | before send for review | 17:18 |
sdague | yeh so - deleted_column.default.arg is definitively wrong | 17:18 |
sdague | that's actually the bug | 17:19 |
tdurakov | sdague: why? | 17:19 |
sdague | because of the email thread | 17:19 |
superdan | not because of the email thread :) | 17:19 |
sdague | because I'm not going to reexplain the email thread in irc :) | 17:19 |
openstackgerrit | Qin Zhao proposed openstack/nova: Make resize api of compute manager to send flavor object https://review.openstack.org/161860 | 17:19 |
superdan | oooh, that :P | 17:19 |
*** markus_z has quit IRC | 17:20 | |
*** oro_ has joined #openstack-nova | 17:21 | |
*** oro has joined #openstack-nova | 17:21 | |
*** sdake__ has joined #openstack-nova | 17:24 | |
tdurakov | sdague: I get deleted column from table that was loaded from metadata,not db | 17:24 |
lxsli | leakypipes: hi could you glance over https://review.openstack.org/#/c/136054/ when you have a min please? thanks | 17:26 |
leakypipes | lxsli: already on my list (about 9 down from the top) | 17:26 |
tdurakov | sdague: could you check it? | 17:26 |
sdague | tdurakov: ok, then this needs some more inline commentary about why that's safe in this case, because the last code was assumed to be. I'd also like to see additional tests for this. | 17:26 |
lxsli | leakypipes: awesome, thanks :) | 17:26 |
sdague | it does seem to pass my tests that the other code failed | 17:27 |
sdague | it should sit on top of - https://review.openstack.org/#/c/164178 | 17:27 |
sdague | so it has to pass those modified tests | 17:27 |
*** sdake has quit IRC | 17:28 | |
tdurakov | sdague: thanks for patience^) | 17:28 |
*** eharney has quit IRC | 17:30 | |
*** erlon has quit IRC | 17:31 | |
*** jistr has quit IRC | 17:31 | |
sdague | tdurakov: ok, so final comment left, there are things I'd like enhanced on that, so that we don't end up here again | 17:31 |
sdague | but I do agree, that code is functionally correct now | 17:31 |
*** achanda has joined #openstack-nova | 17:33 | |
*** otter768 has joined #openstack-nova | 17:34 | |
*** bkopilov has quit IRC | 17:34 | |
*** bkopilov has joined #openstack-nova | 17:35 | |
openstackgerrit | Timofey Durakov proposed openstack/nova: Fixed archivation of deleted records https://review.openstack.org/164263 | 17:36 |
*** otter768 has quit IRC | 17:39 | |
superdan | tdurakov: can you s/archivation/archiving/ ? | 17:39 |
superdan | tdurakov: "archivation" isn't actually a word, although it is something I would say :) | 17:40 |
*** adelinatuvenie has quit IRC | 17:40 | |
*** Marga_ has quit IRC | 17:40 | |
tdurakov | superdan: ok, I'll fix commit message | 17:41 |
superdan | thanks | 17:41 |
*** Marga_ has joined #openstack-nova | 17:41 | |
tdurakov | superdan: although it is something I would say - what?) | 17:41 |
superdan | tdurakov: I'm not sure how to explain it, we'd need to find some english major probably | 17:42 |
*** johnthetubaguy is now known as zz_johnthetubagu | 17:42 | |
superdan | tdurakov: it's not a word, but it's based on a real word, with a suffix | 17:42 |
*** eglynn has quit IRC | 17:42 | |
figleaf | tdurakov: "It's a mistake to say that, but I'd probably make the same type of mistake" | 17:42 |
*** eharney has joined #openstack-nova | 17:42 | |
tdurakov | sdague: seen your comment, could you give me details of extra tests you want? | 17:43 |
superdan | tdurakov: yeah, what figleaf said :) | 17:43 |
superdan | well, | 17:43 |
superdan | not realy | 17:43 |
*** BobBall is now known as BobBall_AWOL | 17:43 | |
superdan | figleaf: I know it's wrong, but I would sometimes say the wrong word to be funny | 17:43 |
*** bkopilov has quit IRC | 17:43 | |
superdan | figleaf: so not a mistake | 17:43 |
superdan | anyway, I'm overcomplicating the fix :) | 17:44 |
figleaf | superdan: heh | 17:44 |
*** bkopilov has joined #openstack-nova | 17:44 | |
figleaf | superdan: I didn't know how else to explain self-deprecation | 17:44 |
melwitt | sdague: I noticed in novaclient tox -epep8 doesn't run on stuff under tests/functional. do you know how it works in nova, to not run functional tests by default yet run pep8 on the functional tests? | 17:44 |
superdan | figleaf: well, I was stuck trying to figure out what the language manipulation was called when you do something like "robust + ify = robustify" | 17:44 |
*** derekh has quit IRC | 17:45 | |
superdan | verbification? | 17:45 |
sdague | tdurakov: we should bulk populate more tables besides the instance_type one that gets default rows | 17:45 |
sdague | then run archive and make sure all those rows stay | 17:45 |
sdague | because this is now going to assume all the model definitions are correct, which they may not be | 17:45 |
leakypipes | sdague: did you have a patch up that addressed the whole NoDBTestCase messy stuff? I think you had mentioned you wanted to do that yesterday instead of revert the NoDBTestCase thing from Mike_D_wk. is that right? | 17:46 |
*** ybathia has joined #openstack-nova | 17:46 | |
sdague | leakypipes: yes, see https://review.openstack.org/#/c/163970/ | 17:46 |
superdan | sdague: lol | 17:46 |
figleaf | superdan: I've heard of verbing a noun, but verbing an adjective? | 17:46 |
superdan | sdague: you need a better publicist | 17:46 |
superdan | figleaf: well, right | 17:46 |
*** Marga_ has quit IRC | 17:46 | |
leakypipes | sdague: ty sir. | 17:47 |
sdague | superdan: yeh, seriously, I've been asked about the same patch how many times today :) | 17:47 |
superdan | sdague: oh that reminds me | 17:47 |
superdan | sdague: didn't you have a patch to fix the nodbtest stuff? | 17:47 |
* sdague glares | 17:47 | |
superdan | heh | 17:47 |
tdurakov | sdague: ok, I'll add more entities to check, you also wrote, that you want explanation, why this works, comment in gerrit will be OK for that? | 17:48 |
*** angdraug has joined #openstack-nova | 17:48 | |
*** sahid has quit IRC | 17:49 | |
sdague | tdurakov: honestly, I think we should put code comments in for it | 17:49 |
sdague | because I can see someone deciding it's better to use the real db again some time in the future | 17:50 |
sdague | and not realizing that actually causes db corruption | 17:50 |
tdurakov | understand) | 17:50 |
*** bkopilov has quit IRC | 17:50 | |
melwitt | sdague: nevermind my earlier question. flake8 is running on novaclient/tests/functional | 17:51 |
*** bkopilov has joined #openstack-nova | 17:51 | |
sdague | melwitt: yeh, I thought so :) | 17:51 |
sdague | sorry, I just hadn't gotten to your question in my stack yet | 17:51 |
*** annashen has quit IRC | 17:51 | |
*** rushiagr_away is now known as rushiagr | 17:51 | |
*** Sukhdev has quit IRC | 17:52 | |
*** lpetrut has joined #openstack-nova | 17:52 | |
melwitt | sdague: I figured, just wanted to avoid you wasting time answering when you got to it :) | 17:53 |
*** Longgeek has joined #openstack-nova | 17:53 | |
*** lucasagomes is now known as lucas-dinner | 17:54 | |
*** gokrokve has quit IRC | 17:54 | |
*** dprince has quit IRC | 17:56 | |
*** omnibus7 is now known as davidlenwell | 17:57 | |
*** bkopilov has quit IRC | 17:58 | |
*** romainh has left #openstack-nova | 17:58 | |
*** bkopilov has joined #openstack-nova | 17:59 | |
*** alexpilotti has joined #openstack-nova | 18:00 | |
*** gokrokve has joined #openstack-nova | 18:01 | |
*** alexpilotti has quit IRC | 18:01 | |
*** alexpilotti has joined #openstack-nova | 18:02 | |
mriedem | superdan: are you good with this? https://review.openstack.org/#/c/163978/ | 18:07 |
superdan | mriedem: does it work? I dunno where instance is coming from there, so I dunno if it has the proper context or not | 18:08 |
superdan | presume it does though if lascii is +2 so, yeah | 18:08 |
mriedem | superdan: the error is gone from screen-c-child in the logs | 18:09 |
superdan | well okay then :) | 18:09 |
lascii | superdan: it should be the same context on instance in the child cell | 18:09 |
lascii | as in the child cell | 18:09 |
superdan | okay | 18:10 |
lascii | oh, this is from_api not at_top. other way around then | 18:10 |
lascii | so whatever context was set when the instance was instantiated | 18:10 |
superdan | well, right, that's why I was asking, since the context gets bundled weirdly with those cells calls | 18:11 |
superdan | I don't remember how the deserialization bit works in cells with regards to re-endowing the context | 18:11 |
lascii | yeah, let me double check that | 18:12 |
*** mpaolino has quit IRC | 18:12 | |
*** bwensley has joined #openstack-nova | 18:13 | |
openstackgerrit | Ed Leafe proposed openstack/nova: Implement instance update logic in Scheduler https://review.openstack.org/160511 | 18:20 |
openstackgerrit | Ed Leafe proposed openstack/nova: Add the instance update calls from Compute https://review.openstack.org/160513 | 18:20 |
openstackgerrit | Ed Leafe proposed openstack/nova: Modify filters to get instance info from HostState https://review.openstack.org/160512 | 18:20 |
openstackgerrit | Ed Leafe proposed openstack/nova: Add the RPC calls for instance updates. https://review.openstack.org/160507 | 18:20 |
figleaf | bauwser: lascii: leakypipes: ^^ | 18:20 |
*** fandi has joined #openstack-nova | 18:20 | |
*** fandi has quit IRC | 18:21 | |
*** sbfox has joined #openstack-nova | 18:21 | |
*** Longgeek has quit IRC | 18:22 | |
*** bkopilov has quit IRC | 18:25 | |
openstackgerrit | Kent Wang proposed openstack/nova: Adds Not Null constraint to KeyPair name https://review.openstack.org/163230 | 18:25 |
*** bkopilov has joined #openstack-nova | 18:25 | |
*** vmtrooper has joined #openstack-nova | 18:26 | |
openstackgerrit | Chris Friesen proposed openstack/nova: Fix "down" nova-compute service spuriously marked as "up" https://review.openstack.org/163060 | 18:28 |
bauwser | figleaf: starting week-end officially, but will try to look again this evening | 18:29 |
figleaf | bauwser: Weekend??? What a slacker! | 18:29 |
bauwser | figleaf: I made some comments on all the series, did you get them ? | 18:29 |
figleaf | :) | 18:29 |
*** Marga_ has joined #openstack-nova | 18:29 | |
bauwser | figleaf: eh, week-end == skiing for me | 18:30 |
*** vmtrooper has quit IRC | 18:31 | |
openstackgerrit | Joe Gordon proposed openstack/nova: Stop installing everything to run pep8 https://review.openstack.org/164020 | 18:31 |
bauwser | figleaf: I htink you had problems with nested mocking, because you had to update more than me | 18:31 |
openstackgerrit | Dan Smith proposed openstack/nova: Fix ComputeNode backport for Service.obj_make_compatible https://review.openstack.org/163867 | 18:31 |
openstackgerrit | Dan Smith proposed openstack/nova: Break out the child version calculation logic from obj_make_compatible() https://review.openstack.org/164206 | 18:31 |
figleaf | bauwser: going through the comments now... | 18:31 |
*** bkopilov has quit IRC | 18:32 | |
*** bkopilov has joined #openstack-nova | 18:32 | |
*** eharney has quit IRC | 18:32 | |
superdan | only 387 things in the check queue | 18:34 |
*** Sukhdev has joined #openstack-nova | 18:35 | |
*** Mike_D_laptop has joined #openstack-nova | 18:36 | |
lascii | superdan: well that was harder than it should have been to track down, but cells is using the NovaObjectSerializer to rehydrate the object with the context passed to the rpc method | 18:37 |
bauwser | superdan: erm, TGIF would mean Thanks Gosh, It's Feature Freeze ? | 18:37 |
superdan | lascii: right, but is that context the same as the one embedded in the message? | 18:38 |
superdan | bauwser: yeah :) | 18:39 |
superdan | lascii: basically, I don't remember why the context is re-encapsulated in the cells message | 18:39 |
superdan | lascii: and if it's because the actual cells call is made with admin context or some such, that would then be, like bad and stuff :) | 18:40 |
superdan | but if it's the same, then that's cool | 18:40 |
superdan | of course, if it's not the same, there are probably other problems | 18:40 |
superdan | although they could be latent and undiscovered | 18:40 |
bauwser | lascii: correct me if I'm wrong, but oslo.messaging requires context as the first arg ? | 18:40 |
lascii | superdan: it's not admin-ized, but it is converted to json and back | 18:40 |
superdan | lascii: the one in the message you mean? | 18:40 |
lascii | superdan: yes | 18:41 |
bauwser | lascii: I mean, you can't make a RPC method signature where no context is passed threu | 18:41 |
bauwser | thru | 18:41 |
superdan | lascii: right, but that's not the one that the instance will have been created from right? | 18:41 |
*** apuimedo has quit IRC | 18:41 | |
lascii | message_dict['ctxt'] = context.RequestContext.from_dict(ctxt) | 18:41 |
superdan | lascii: okay I don't understand why that is done I guess | 18:41 |
lascii | superdan: I don't either atm | 18:41 |
superdan | okay, then all I was saying is: I hope it's not done because sometimes those two contexts differ :) | 18:42 |
lascii | cells doesn't modify the context anywhere that I'm aware of | 18:42 |
*** shaohe_feng1 has quit IRC | 18:42 | |
lascii | superdan: gotcha | 18:42 |
*** shaohe_feng1 has joined #openstack-nova | 18:43 | |
lascii | superdan: other than being elevated, why would a context change during a request? | 18:44 |
*** ijw has joined #openstack-nova | 18:45 | |
*** lpetrut has quit IRC | 18:46 | |
superdan | lascii: it wouldn't but I also don't know why we're making a copy of or storing the context separately | 18:47 |
*** bkeyouma has joined #openstack-nova | 18:48 | |
superdan | lascii: the only reason I can think would be if we always use an admin context when making the rpc call, embedding the user context in the message | 18:48 |
superdan | lascii: if that were the case, then the instances are actually coming out on the other side with admin contexts in them | 18:48 |
bkeyouma | Hi there, I have been looking into openstack for the past few weeks and have failed to find clear instructions on how to write a plugin for the nova compute module | 18:48 |
bkeyouma | I was wondering if anyone has had experience writing one | 18:48 |
superdan | hopefully that's not what is happening, but I also don't know why we're doing that extra message['ctxt'] thing otherwise | 18:48 |
superdan | that's all :) | 18:48 |
lascii | superdan: just found the other side "_dict['ctxt'] = _dict['ctxt'].to_dict()" | 18:49 |
*** andreykurilin_ has joined #openstack-nova | 18:49 | |
lascii | nothing fancy, and no explanation | 18:49 |
superdan | lascii: yeah, I don' | 18:49 |
superdan | don't get it at all | 18:49 |
bkeyouma | Anyone know how to write a plugin that works on top of Nova? | 18:50 |
*** eglynn has joined #openstack-nova | 18:51 | |
*** oro_ has quit IRC | 18:51 | |
*** oro has quit IRC | 18:52 | |
*** annashen has joined #openstack-nova | 18:52 | |
*** kiwik-chenrui has quit IRC | 18:53 | |
*** kiwik-chenrui has joined #openstack-nova | 18:54 | |
*** ndipanoff has quit IRC | 18:55 | |
*** apuimedo has joined #openstack-nova | 18:55 | |
*** pixelb has quit IRC | 18:56 | |
*** liusheng has quit IRC | 18:56 | |
*** annashen has quit IRC | 18:56 | |
*** liusheng has joined #openstack-nova | 18:57 | |
dimsum__ | bkeyouma: i'd recommend starting from the fake driver - http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/fake.py | 18:57 |
lascii | superdan: looking at the timestamps on when this was added vs when olso messaging code was added all I can figure is it's because cells messaging was done before oslo messaging | 18:58 |
dimsum__ | bkeyouma: you have to flip compute_driver and connection_type in nova.conf to start with | 18:59 |
lascii | bauwser: missed your question earlier, I'm not sure if oslo messaging requires context be first. I wouldn't be surprised if it did | 18:59 |
superdan | lascii: well, so was all the other rpc stuff we had and we didn't specially encode the context | 19:00 |
superdan | lascii: but anyway, I'm sure it's fine :) | 19:00 |
lascii | superdan: yeah, I think it is as well | 19:00 |
lascii | ultimately only comstud knows, as well as all the other secrets of the universe | 19:01 |
*** dprince has joined #openstack-nova | 19:01 | |
bkeyouma | dimsum__, thanks I will take a look at that. Is there any tutorials or documentations you know of? | 19:02 |
*** dkliban is now known as dkliban_afk | 19:07 | |
superdan | lascii: yar | 19:07 |
*** dkliban_afk is now known as dkliban_brb | 19:08 | |
openstackgerrit | Jennifer Mulsow proposed openstack/nova: Edit ServerGroup inval frmt msg to be more verbose https://review.openstack.org/164308 | 19:08 |
*** thedodd has quit IRC | 19:12 | |
*** Nikolay_St has joined #openstack-nova | 19:12 | |
*** eglynn has quit IRC | 19:14 | |
*** zul has quit IRC | 19:19 | |
openstackgerrit | Josh Gachnang proposed openstack/nova: Adjust resource tracker for new Ironic states https://review.openstack.org/164313 | 19:21 |
*** annashen has joined #openstack-nova | 19:21 | |
openstackgerrit | Josh Gachnang proposed openstack/nova: Add support for cleaning in Ironic driver https://review.openstack.org/161474 | 19:22 |
*** hemna has quit IRC | 19:32 | |
*** dkliban_brb is now known as dkliban | 19:34 | |
*** otter768 has joined #openstack-nova | 19:35 | |
openstackgerrit | Jennifer Mulsow proposed openstack/nova: Edit ServerGroup inval frmt msg to be more verbose https://review.openstack.org/164308 | 19:36 |
openstackgerrit | Jennifer Mulsow proposed openstack/nova: Edit ServerGroup inval frmt msg to be more verbose https://review.openstack.org/164308 | 19:37 |
*** otter768 has quit IRC | 19:40 | |
openstackgerrit | Josh Gachnang proposed openstack/nova: Adjust resource tracker for new Ironic states https://review.openstack.org/164313 | 19:40 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Remove and deprecate unused conductor service calls https://review.openstack.org/133664 | 19:40 |
*** iamjarvo has quit IRC | 19:40 | |
openstackgerrit | Hans Lindgren proposed openstack/nova: Refactor some service tests and make them not require db https://review.openstack.org/133665 | 19:40 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Convert service and servicegroup to objects https://review.openstack.org/133663 | 19:40 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Add a fixture for the NovaObject indirection API https://review.openstack.org/164146 | 19:40 |
*** lpetrut has joined #openstack-nova | 19:41 | |
openstackgerrit | melanie witt proposed openstack/python-novaclient: Ensure the use of volume endpoint in volumes apis https://review.openstack.org/164321 | 19:43 |
*** bkopilov has quit IRC | 19:45 | |
*** bkopilov has joined #openstack-nova | 19:48 | |
sdague | anyone up for landing these tests to prevent the regression - https://review.openstack.org/#/c/164178 ? | 19:49 |
*** Longgeek has joined #openstack-nova | 19:50 | |
*** tjones1 has quit IRC | 19:51 | |
*** hemna has joined #openstack-nova | 19:52 | |
*** thedodd has joined #openstack-nova | 19:53 | |
*** lucas-dinner has quit IRC | 19:54 | |
lascii | sdague: got it | 19:56 |
*** rushiagr is now known as rushiagr_away | 19:57 | |
sdague | lascii: thanks | 19:58 |
*** bkopilov has quit IRC | 20:02 | |
*** iamjarvo has joined #openstack-nova | 20:04 | |
*** tjones1 has joined #openstack-nova | 20:04 | |
*** bkopilov has joined #openstack-nova | 20:04 | |
*** achanda has quit IRC | 20:06 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Refresh bdm.connection_info if not set when detaching volume https://review.openstack.org/164330 | 20:08 |
leakypipes | mriedem: easy: https://review.openstack.org/#/c/164206/ | 20:08 |
mriedem | i hope i haven't wasted my whole day on this ^ | 20:08 |
mriedem | spooky | 20:08 |
leakypipes | mriedem: I'll review the above BDM patch. | 20:08 |
mriedem | 'easy' and 'objects' stuff shouldn't be tied together :) | 20:08 |
leakypipes | mriedem: just moves code :) | 20:08 |
*** yamahata has joined #openstack-nova | 20:09 | |
*** achanda has joined #openstack-nova | 20:11 | |
*** vmtrooper has joined #openstack-nova | 20:15 | |
*** bwensley has quit IRC | 20:16 | |
*** Mike_D_laptop has quit IRC | 20:16 | |
*** Longgeek has quit IRC | 20:18 | |
*** iamjarvo has quit IRC | 20:19 | |
*** vmtrooper has quit IRC | 20:20 | |
mriedem | superdan: question inline of course https://review.openstack.org/#/c/164206/ | 20:20 |
superdan | mriedem: the quoted line is the "more explicit" bit that caused the tests to need tweaking | 20:21 |
superdan | is that what you're asking? | 20:21 |
mriedem | more precise, yeah | 20:21 |
*** sbfox has quit IRC | 20:22 | |
*** tjones1 has left #openstack-nova | 20:23 | |
mriedem | that was the only thing i noticed as different from the pull out of the code | 20:24 |
*** achanda has quit IRC | 20:25 | |
*** pixelb has joined #openstack-nova | 20:25 | |
superdan | yeah | 20:27 |
superdan | without it, the caller deletes the child from the primitive when all the versions are current | 20:27 |
superdan | which is, like, not what I wanted :) | 20:27 |
*** henrique_ has quit IRC | 20:28 | |
mriedem | approved | 20:29 |
mriedem | superdan: so i was complaining to garyk yesterday morning about all of the ugly plug/unplug vif stuff in the libvirt driver and why we don't just let neutron handle all that, it occurs to me today (which i knew, but didn't piece together), that we do the same for volumes, | 20:30 |
mriedem | and how every time someone wants to support a new type of network plugin or volume driver they have to register something in nova that talks to it so libvirt works | 20:31 |
*** jdurgin has quit IRC | 20:31 | |
mriedem | i'm assuming those are just architectural things that will never change? | 20:32 |
superdan | mriedem: it seems much less disgusting for volumes, but yeah | 20:32 |
superdan | I think that the cinder bits will change with whatever the heck "brick" is :) | 20:32 |
mriedem | like glance_store | 20:33 |
mriedem | except nova doesn't have the same low-level detail for each glance backend that it does for every cinder/neutron thing we support | 20:34 |
mriedem | so i never think about glance | 20:34 |
*** oro_ has joined #openstack-nova | 20:34 | |
*** oro has joined #openstack-nova | 20:34 | |
mriedem | except of course the libvirt image code... | 20:34 |
*** Sukhdev has quit IRC | 20:35 | |
*** alexpilotti has quit IRC | 20:37 | |
*** thangp has quit IRC | 20:37 | |
openstackgerrit | Josh Gachnang proposed openstack/nova: Adjust resource tracker for new Ironic states https://review.openstack.org/164313 | 20:37 |
*** eharney has joined #openstack-nova | 20:37 | |
*** pixelb has quit IRC | 20:38 | |
*** kaufer has quit IRC | 20:39 | |
*** ociuhandu has quit IRC | 20:39 | |
*** sdake__ has quit IRC | 20:40 | |
*** annashen has quit IRC | 20:42 | |
*** irenab_ has joined #openstack-nova | 20:45 | |
*** exploreshaifali has quit IRC | 20:46 | |
bauwser | lascii: I'm almost sure, oslo.messaging does need a context, see https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/rpc/client.py#L340-L393 | 20:47 |
*** irenab has quit IRC | 20:47 | |
*** irenab_ is now known as irenab | 20:47 | |
bauwser | lascii: so even if your RPC method doesn't have it, you need to cast or call using a ctxt | 20:47 |
lascii | bauwser: the RPC methods all have it, but cells code duplicates the context in the message payload for some reason | 20:48 |
*** annashen has joined #openstack-nova | 20:49 | |
bauwser | lascii: yey, saw your point, did you git blame it ? | 20:49 |
lascii | yes. it goes back to the original cells commit | 20:50 |
*** kaufer has joined #openstack-nova | 20:50 | |
bauwser | lascii: mmm, sounds like it was just a copy | 20:51 |
mriedem | superdan: ha https://github.com/openstack/nova/commit/588a57f13edd753614d2bcb289cbea5f0a7992c7 | 20:51 |
bauwser | lascii: because it needed to serialize/unserialize it | 20:51 |
mriedem | superdan: tell taylor that she broke nova rebase for me internally L) | 20:51 |
mriedem | :) | 20:51 |
superdan | mriedem: will-do :P | 20:52 |
bauwser | lascii: so, copying it before primitiving it sounds ok | 20:52 |
*** oro has quit IRC | 20:53 | |
*** oro_ has quit IRC | 20:54 | |
*** exploreshaifali has joined #openstack-nova | 20:56 | |
*** exploreshaifali has quit IRC | 20:57 | |
*** achanda has joined #openstack-nova | 20:57 | |
*** melwitt has quit IRC | 20:58 | |
*** apuimedo has quit IRC | 20:59 | |
*** rfolco has quit IRC | 20:59 | |
*** melwitt has joined #openstack-nova | 21:00 | |
*** harlowja has quit IRC | 21:00 | |
*** melwitt has quit IRC | 21:00 | |
*** apuimedo has joined #openstack-nova | 21:00 | |
*** apuimedo has quit IRC | 21:00 | |
*** apuimedo has joined #openstack-nova | 21:01 | |
lascii | bauwser: yeah, should be completely fine. just not sure why it's done :) | 21:01 |
flashgordon | superdan: so figured out what causes the quota sync issues | 21:02 |
flashgordon | or at least one thing that does | 21:02 |
flashgordon | restarting nova-compute | 21:02 |
flashgordon | while things are happening | 21:02 |
*** dave-mccowan has quit IRC | 21:02 | |
*** irenab has quit IRC | 21:03 | |
flashgordon | (and doing the hard kill that doesn't wait for all the things to cleanup) | 21:03 |
bauwser | lascii: by reading the code, seems like it's because comstud wanted to make sure it doesn't touch the context | 21:03 |
dimsum__ | superdan: 2 reviews, very cool | 21:03 |
bauwser | lascii: as he's jsonifiying it before calling the RPC service | 21:03 |
dimsum__ | flashgordon: /me listening | 21:03 |
superdan | dimsum__: eh? | 21:03 |
dimsum__ | superdan: https://review.openstack.org/#/q/owner:%22Taylor+Smith+%253Ctaylor%2540taylorcole.net%253E%22,n,z | 21:04 |
bauwser | lascii: well, to be clear, he does take a JSON primitive and rehydrate the context from it | 21:04 |
superdan | flashgordon: hmm, that would mess up claims maybe, but I'm surprised about quotas | 21:04 |
superdan | dimsum__: ah :) | 21:04 |
flashgordon | superdan: trying again with clean stops | 21:04 |
*** raildo has quit IRC | 21:05 | |
flashgordon | and seeing if that works or not | 21:05 |
flashgordon | rebooting conductor and API didn't break anything for me | 21:05 |
dimsum__ | flashgordon: do people do that in the field? hard kills | 21:05 |
bauwser | lascii: probably because he's serializing all the messages into JSON | 21:05 |
flashgordon | dimsum__: maybe | 21:05 |
flashgordon | dimsum__: also there may be other ways to reproduce this | 21:06 |
flashgordon | dimsum__: just don't know them yet | 21:06 |
*** harlowja has joined #openstack-nova | 21:06 | |
flashgordon | and doing a standard stop and wait for cleanup causes failures too | 21:06 |
lascii | bauwser: sure, but the context comes through on the other side without pulling it into the message body explicitly | 21:06 |
*** melwitt has joined #openstack-nova | 21:07 | |
flashgordon | dimsum__ superdan: also I spent 5 minutes yesterday and put together a POC to reset quotas http://paste.ubuntu.com/10588043/ | 21:07 |
flashgordon | which should satisfy https://review.openstack.org/#/c/161782/ | 21:07 |
flashgordon | I think its worth adding to Kilo as a bug fix | 21:07 |
flashgordon | since is nova-manage only | 21:07 |
flashgordon | and very self contained | 21:08 |
bauwser | lascii: it does | 21:08 |
bauwser | lascii: it does put the context in the messaging, unless I'm wrong | 21:08 |
bauwser | message sorry | 21:08 |
*** apuimedo has quit IRC | 21:10 | |
bauwser | lascii: https://github.com/openstack/nova/blob/master/nova/cells/rpc_driver.py#L155-L156 | 21:10 |
bauwser | lascii: so it serializes both content and context into a JSON dict which is unprimitived in from_message() on the other side | 21:11 |
lascii | bauwser: yeah, but why is context duplicated in message there? | 21:11 |
bauwser | lascii: so as probably the context has been transformed into a primitive, it needs to rehydrate it | 21:11 |
lascii | hmm, maybe it's just so that context didn't need to be passed around to all of these methods | 21:12 |
lascii | as none of them take a context param | 21:12 |
flashgordon | lascii: got some quota related questions for you as an operator if you have a moment | 21:13 |
*** marun has quit IRC | 21:14 | |
bauwser | lascii: because he's just throwing it ? :) | 21:14 |
*** iamjarvo has joined #openstack-nova | 21:14 | |
lascii | flashgordon: sure, I can try to answer | 21:14 |
*** diegows has quit IRC | 21:14 | |
bauwser | lascii: I mean in process_message() | 21:14 |
flashgordon | lascii: you ever see quota out of sync issues? | 21:14 |
lascii | flashgordon: yes, but they don't come up often. not sure if that's lack of hearing about it though | 21:15 |
bauwser | lascii: yeah, didn't see your last point, I think so too | 21:15 |
flashgordon | what do you do when the do come up? | 21:15 |
flashgordon | lascii: do you manually go into the DB and fix etc? | 21:16 |
flashgordon | lascii: any ideas on your end on what causes them? | 21:16 |
lascii | flashgordon: we try not to manually adjust, but will if necessary. or we'll raise them. :( | 21:18 |
lascii | we also set until_refresh and max_age in config to help out | 21:18 |
lascii | so they get fixed periodically | 21:18 |
*** IanGovett has quit IRC | 21:18 | |
*** IanGovett has joined #openstack-nova | 21:19 | |
lascii | I've considered that those should default on, but they're basically an admission of an issue | 21:19 |
lascii | flashgordon: no idea what causes them though. typically when I hear about them they've been out of sync for a while so it's hard to track down | 21:19 |
flashgordon | ahh | 21:19 |
flashgordon | why not turn those on by default? | 21:21 |
flashgordon | we do have a problem | 21:21 |
flashgordon | lets be honest about it | 21:21 |
flashgordon | lascii: another option is to improve the config option help messages | 21:21 |
lascii | the other reason not to do it is that they cause increased load on quota calculations periodically | 21:21 |
flashgordon | they are really terse and don't explain why you would want to set them etc | 21:21 |
lascii | but it hasn't been an issue in practice for us | 21:21 |
flashgordon | lascii: can you submit a patch adding expanding the help message on those two? | 21:22 |
*** annashen has quit IRC | 21:22 | |
*** annashen has joined #openstack-nova | 21:22 | |
lascii | flashgordon: sure | 21:22 |
*** andreykurilin_ has quit IRC | 21:23 | |
flashgordon | lascii: thankS! | 21:23 |
*** IanGovett has quit IRC | 21:23 | |
flashgordon | lascii: I ask because this turns out to a be a big pain for a lot of operators | 21:23 |
flashgordon | (feedback sdague passed on from the ops mid cycle) | 21:23 |
*** andreykurilin_ has joined #openstack-nova | 21:23 | |
lascii | interesting. I feel like we had more quota issues in the past, but I haven't heard about them for quite some time | 21:25 |
flashgordon | so I can produce them consistently by rebooting n-cpu | 21:26 |
flashgordon | during things | 21:26 |
flashgordon | but not running max_age or until_refresh | 21:26 |
openstackgerrit | Andrew Laski proposed openstack/nova: Objects: use setattr rather than dict syntax in remotable https://review.openstack.org/163974 | 21:26 |
openstackgerrit | Andrew Laski proposed openstack/nova: Add CellMapping object https://review.openstack.org/161867 | 21:26 |
openstackgerrit | Andrew Laski proposed openstack/nova: Add get_api_session to db api https://review.openstack.org/161866 | 21:26 |
openstackgerrit | Andrew Laski proposed openstack/nova: Split NovaPersistentObject mixin https://review.openstack.org/163605 | 21:26 |
flashgordon | what values do you recommend for those? I can try again with those values set | 21:26 |
*** achanda has quit IRC | 21:27 | |
lascii | until_refresh = 10, and max_age = 86400 are what we have. but until_refresh is more relevant for you in testing I think | 21:28 |
lascii | and max_age just means the quota will be updated the next time quotas are affected for a project/user, not each period | 21:28 |
*** mjturek1 has quit IRC | 21:30 | |
flashgordon | kk I'll try until_refresh = 5 or something low next | 21:31 |
*** cbader has quit IRC | 21:31 | |
*** achanda has joined #openstack-nova | 21:33 | |
lascii | as long as you're not within x quota updates of hitting a limit it'll fix things, but won't help at the edges | 21:34 |
*** jgrimm_ has joined #openstack-nova | 21:34 | |
*** timello_ has joined #openstack-nova | 21:35 | |
*** lascii is now known as alaski | 21:35 | |
alaski | weekend :) | 21:35 |
*** maurosr has quit IRC | 21:35 | |
*** timello has quit IRC | 21:36 | |
*** ekhugen has quit IRC | 21:36 | |
*** ekhugen has joined #openstack-nova | 21:36 | |
*** jgrimm- has joined #openstack-nova | 21:36 | |
flashgordon | hmm right it at least means quotas will self correct ish | 21:36 |
*** otter768 has joined #openstack-nova | 21:36 | |
*** jgrimm has quit IRC | 21:36 | |
*** maurosr has joined #openstack-nova | 21:36 | |
*** timello has joined #openstack-nova | 21:37 | |
*** iamjarvo has quit IRC | 21:39 | |
*** annashen has quit IRC | 21:39 | |
*** neelashah has quit IRC | 21:39 | |
*** iamjarvo has joined #openstack-nova | 21:39 | |
*** jgrimm_ has quit IRC | 21:39 | |
*** timello_ has quit IRC | 21:39 | |
*** ijw has quit IRC | 21:40 | |
*** otter768 has quit IRC | 21:41 | |
*** annashen has joined #openstack-nova | 21:41 | |
*** andreykurilin_ has quit IRC | 21:41 | |
*** andreykurilin_ has joined #openstack-nova | 21:42 | |
flashgordon | thanks alaski o/ | 21:42 |
*** nelsnelson has quit IRC | 21:43 | |
*** rushiagr_away is now known as rushiagr | 21:44 | |
*** marun has joined #openstack-nova | 21:44 | |
*** dboik has quit IRC | 21:46 | |
*** dprince has quit IRC | 21:46 | |
*** Mike_D_laptop has joined #openstack-nova | 21:46 | |
*** iamjarvo has quit IRC | 21:46 | |
mriedem | booya, flight to vancouver is booked | 21:48 |
dimsum__ | mriedem: when are you reaching there? | 21:48 |
dimsum__ | i just started the process | 21:48 |
mriedem | sunday | 21:48 |
mriedem | leaving saturday | 21:48 |
*** dave-mccowan has joined #openstack-nova | 21:48 | |
*** sdake has joined #openstack-nova | 21:48 | |
dimsum__ | y, am trying that as well | 21:48 |
bauwser | gosh, flights increased a lot in 2 months | 21:48 |
bauwser | thanks euro... | 21:49 |
anish | hey, at least you're not paying in roubles | 21:49 |
dimsum__ | bauwser: how many hops will you have? | 21:49 |
bauwser | only 1 because I'm living only close to the 2nd biggest french area... | 21:50 |
bauwser | around 16h | 21:50 |
bauwser | flying Northbound | 21:50 |
dimsum__ | ah cool | 21:50 |
bauwser | gosh, I had terrible experience when I went back from midcycle | 21:51 |
bauwser | I arrived to Zurich (around 500km from home) and then had to flight thru Brussels (north) before arriving to Lyon | 21:51 |
bauwser | just because my original transatlantic flight had 3 hours delay | 21:51 |
mriedem | bauwser: and your fkey migration got merged! | 21:52 |
bauwser | mriedem: \o/ | 21:52 |
bauwser | 2 BPs in a row for Kilo, I'm about to open a bottle of champaign | 21:52 |
mriedem | 11pm there huh? | 21:53 |
mriedem | might as well | 21:53 |
bauwser | yay | 21:53 |
bauwser | that remembers me I have to check again flight prices | 21:54 |
bauwser | because it was just horrible when I looked on Monday | 21:54 |
bauwser | and btw. tip again : don't take Swiss or Lufthansa when flying | 21:54 |
bauwser | because they're now having fee for booking seats | 21:54 |
flashgordon | superdan: so it looks like the quota issue happens during deletes not boots | 21:55 |
*** annashen has quit IRC | 21:56 | |
flashgordon | hmm ... maybe its the combination of the two | 21:58 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Stop spamming logs when creating context https://review.openstack.org/164261 | 22:00 |
*** annashen has joined #openstack-nova | 22:00 | |
*** rwsu has quit IRC | 22:00 | |
dimsum__ | flashgordon: can you please +2/+W ^^^ it was in the check/gate but i had missed one pep8 failure | 22:00 |
*** lpetrut has quit IRC | 22:01 | |
flashgordon | dimsum__: done | 22:02 |
*** Longgeek has joined #openstack-nova | 22:03 | |
*** vmtrooper has joined #openstack-nova | 22:04 | |
*** harlowja has quit IRC | 22:04 | |
*** jecarey has quit IRC | 22:04 | |
*** Mike_D_laptop has quit IRC | 22:05 | |
*** gokrokve has quit IRC | 22:05 | |
*** gokrokve has joined #openstack-nova | 22:05 | |
*** harlowja has joined #openstack-nova | 22:06 | |
*** gokrokve has quit IRC | 22:06 | |
*** harlowja has quit IRC | 22:06 | |
*** gokrokve has joined #openstack-nova | 22:06 | |
*** harlowja has joined #openstack-nova | 22:06 | |
flashgordon | so its terminates | 22:07 |
*** vmtrooper has quit IRC | 22:08 | |
*** bkeyouma has quit IRC | 22:12 | |
*** nelsnelson has joined #openstack-nova | 22:13 | |
*** irenab has joined #openstack-nova | 22:15 | |
*** dkliban is now known as dkliban_afk | 22:15 | |
*** melwitt has quit IRC | 22:15 | |
*** melwitt has joined #openstack-nova | 22:16 | |
openstackgerrit | Ed Leafe proposed openstack/nova: Implement instance update logic in Scheduler https://review.openstack.org/160511 | 22:17 |
openstackgerrit | Ed Leafe proposed openstack/nova: Add the instance update calls from Compute https://review.openstack.org/160513 | 22:17 |
openstackgerrit | Ed Leafe proposed openstack/nova: Modify filters to get instance info from HostState https://review.openstack.org/160512 | 22:17 |
openstackgerrit | Ed Leafe proposed openstack/nova: Add the RPC calls for instance updates. https://review.openstack.org/160507 | 22:17 |
figleaf | bauwser: before you get drunk on champagne, wanna check out the changes ^^ | 22:18 |
*** moshele has joined #openstack-nova | 22:18 | |
*** moshele has quit IRC | 22:19 | |
*** melwitt has quit IRC | 22:19 | |
figleaf | bauwser: or maybe a drink or two might help http://xkcd.com/323/ | 22:19 |
*** melwitt has joined #openstack-nova | 22:19 | |
*** Longgeek has quit IRC | 22:25 | |
*** tonytan4ever has quit IRC | 22:25 | |
*** mtanino has quit IRC | 22:27 | |
*** melwitt has quit IRC | 22:28 | |
*** figleaf is now known as edleafe | 22:28 | |
bauwser | edleafe: well, if I would review now, it should rather look like http://xkcd.com/776/ | 22:31 |
edleafe | bauwser: :) | 22:32 |
* bauwser heading off to bed | 22:32 | |
bauwser | gosh, I'm awfully disappointed by flight prices | 22:32 |
*** kaufer has quit IRC | 22:32 | |
bauwser | should think about buying a canoe | 22:32 |
*** rwsu has joined #openstack-nova | 22:33 | |
*** bauwser is now known as bauzas | 22:34 | |
*** sdake__ has joined #openstack-nova | 22:38 | |
flashgordon | and found the bug https://bugs.launchpad.net/nova/+bug/1296414 | 22:38 |
openstack | Launchpad bug 1296414 in OpenStack Compute (nova) "quotas not updated when periodic tasks or startup finish deletes" [High,In progress] - Assigned to Rajesh Tailor (rajesh-tailor) | 22:38 |
flashgordon | we don't update quotas during reboot cleanups | 22:38 |
flashgordon | dimsum__:looks like you touched that bug in the past | 22:39 |
*** sdake has quit IRC | 22:41 | |
flashgordon | sdague superdan: quota bug fix, or at least fixes one case https://review.openstack.org/#/c/122347 | 22:43 |
*** thedodd has quit IRC | 22:43 | |
mriedem | flashgordon: yeah, that's been around awhile | 22:44 |
mriedem | i've been on it but it was going back and forth a lot so i lost focus | 22:44 |
*** tsekiyam_ has joined #openstack-nova | 22:52 | |
*** hemna has quit IRC | 22:53 | |
superdan | how about this | 22:55 |
superdan | NO QUOTAS EVAR | 22:55 |
*** tsekiyama has quit IRC | 22:56 | |
*** markvoelker has quit IRC | 22:56 | |
*** tsekiyam_ has quit IRC | 22:56 | |
*** IanGovett has joined #openstack-nova | 22:58 | |
*** apuimedo has joined #openstack-nova | 23:03 | |
*** browne has quit IRC | 23:03 | |
*** nelsnelson has quit IRC | 23:05 | |
*** IanGovett has quit IRC | 23:10 | |
*** aysyd has quit IRC | 23:13 | |
*** sdake__ has quit IRC | 23:15 | |
flashgordon | superdan: so actually that was my answer | 23:17 |
flashgordon | except that by that I mean don't do the separate quota logic | 23:17 |
flashgordon | to see usage | 23:17 |
flashgordon | just query the db for instances | 23:18 |
flashgordon | and compute on the fly each time | 23:18 |
flashgordon | shouldn't be a lot of extra work for a SQL DB | 23:18 |
*** annashen has quit IRC | 23:18 | |
*** annashen has joined #openstack-nova | 23:20 | |
mtreinish | flashgordon: nah I think superdan meant kill quotas and make people use the honor system :) | 23:21 |
flashgordon | mtreinish: hehe yeah that is what I assumed he meant | 23:21 |
*** david-lyle is now known as david-lyle_afk | 23:29 | |
*** annashen has quit IRC | 23:29 | |
*** patrickeast has quit IRC | 23:32 | |
*** rwsu has quit IRC | 23:35 | |
*** otter768 has joined #openstack-nova | 23:37 | |
*** tjones1 has joined #openstack-nova | 23:37 | |
*** rwsu has joined #openstack-nova | 23:37 | |
*** tjones1 has left #openstack-nova | 23:38 | |
*** otter768 has quit IRC | 23:42 | |
*** melwitt has joined #openstack-nova | 23:49 | |
*** dimsum__ has quit IRC | 23:52 | |
*** vmtrooper has joined #openstack-nova | 23:53 | |
*** dave-mccowan has quit IRC | 23:54 | |
*** dims_ has joined #openstack-nova | 23:55 | |
*** markvoelker has joined #openstack-nova | 23:57 | |
*** dims_ has quit IRC | 23:57 | |
*** dims_ has joined #openstack-nova | 23:57 | |
*** vmtrooper has quit IRC | 23:57 | |
*** thomasem has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!