Wednesday, 2015-04-15

*** dboik has joined #openstack-nova00:00
*** promulo__ has joined #openstack-nova00:01
*** tjones1 has quit IRC00:01
*** mriedem has quit IRC00:01
*** Marga_ has quit IRC00:02
*** dboik has quit IRC00:02
*** ijw has quit IRC00:03
*** claudiub has quit IRC00:04
*** promulo_ has quit IRC00:05
*** otter768 has joined #openstack-nova00:12
openstackgerritChris Friesen proposed openstack/nova: Fix binding:host_id for neutron on evacuate  https://review.openstack.org/17361500:14
*** IanGovett has quit IRC00:14
*** dave-mccowan has quit IRC00:16
*** otter768 has quit IRC00:17
mriedem1handle_lifecycle_event bites me again00:17
*** baoli has joined #openstack-nova00:18
mriedem1libvirt graceful shutdown will stop instances, which triggers the event to nova to stop the instance (call stop api) which changes the vm_state to stopped. on libvirt restart, the instances are started by libvirt again but sync_instance_power_states sees the instance is supposed to be stopped (according to the nova db), so it stops the running instance00:18
mriedem1gah00:18
mriedem1sdague: ^00:18
mriedem1dansmith: have you heard of a problem like that?00:23
dansmithhah00:23
*** r-daneel has quit IRC00:24
dansmithyou can configure a vm in libvirt to either start or not on startup00:24
dansmithI would think that we should be telling libvirt to do nothing with it and let us either start it (or not) on init_host()00:24
*** sbfox has quit IRC00:25
*** salv-orlando has joined #openstack-nova00:25
mriedem1this is in /etc/sysconfig/libvirt-guests right?00:25
mriedem1ON_SHUTDOWN=shutdown00:26
mriedem1with a timeout00:26
dansmithno00:26
mriedem1ok, was reading this https://access.redhat.com/documentation/en-US/Red_Hat_Enterprise_Linux/6/html/Virtualization_Administration_Guide/sub-sect-Shutting_down_rebooting_and_force_shutdown_of_a_guest_virtual_machine-Manipulating_the_libvirt_guests_configuration_settings.html00:28
mriedem1ON_SHUTDOWN doc basically says be careful with this (because you could eff up nova's power state syncing for sure bro!)00:28
dansmiththere is an onboot= oncrash=, etc settings in libvirt00:28
*** jwcroppe has joined #openstack-nova00:28
mriedem1oh00:28
dansmithI thought we had a way to set what we wanted that to be.. looking00:29
*** browne has quit IRC00:29
dansmithmriedem1: https://libvirt.org/formatdomain.html#elementsEvents00:29
dansmithI also though there was controls in there to change what we do on libvirtd start00:29
dansmiththere also used to be something like /etc/libvirt/autostart I think00:30
*** heyongli_ has joined #openstack-nova00:30
dansmithwhich may be what I'm thinking of00:30
dansmithvirsh autostart00:31
dansmithyeah, "virsh autostart foo" leaves me with /etc/libvirt/qemu/autostart/foo.xml00:32
*** heyongli_ has quit IRC00:32
dansmithwhich is a link to /etc/libvirt/qemu/foo.xml00:32
*** salv-orlando has quit IRC00:32
*** neelashah has joined #openstack-nova00:32
dansmithso unless nova is running the equivalent of that command, I'd not think the instances would be restarting00:33
dansmithmriedem1: ^00:33
mriedem1dansmith: unless the operator is configuring something outside nova for this?00:33
dansmithor that, of course00:33
mriedem1i assume that's what's happening here but trying to get specific recreate steps00:33
*** nelsnelson has quit IRC00:33
dansmithgotta run to dinner00:33
*** dims_ has joined #openstack-nova00:35
openstackgerritChris Friesen proposed openstack/nova: Fix binding:host_id for neutron on evacuate  https://review.openstack.org/17361500:35
*** dims has quit IRC00:36
*** nelsnelson has joined #openstack-nova00:36
*** nelsnelson has quit IRC00:39
*** emagana has quit IRC00:40
*** emagana has joined #openstack-nova00:41
*** IanGovett has joined #openstack-nova00:42
*** jogo has quit IRC00:42
*** neelashah has quit IRC00:45
*** Marga_ has joined #openstack-nova00:47
*** emagana has quit IRC00:48
*** IanGovett has quit IRC00:49
*** annashen has joined #openstack-nova00:49
mriedem1guh, apparently handle_lifecycle_event was added in grizzly and resume_guests_state_on_host_boot was added back in like essex?00:50
*** kmartin has quit IRC00:51
mriedem1hell diablo even https://github.com/openstack/nova/commit/ba4946d0d3c73e5d9f67f42203d103bf9856345800:51
*** Marga_ has quit IRC00:52
*** pixelb has joined #openstack-nova00:53
*** Marga_ has joined #openstack-nova00:53
*** annashen has quit IRC00:55
*** sbfox has joined #openstack-nova00:55
*** promulo_ has joined #openstack-nova00:59
*** slong has joined #openstack-nova01:00
*** yuntongjin has joined #openstack-nova01:01
*** shaohe_feng has joined #openstack-nova01:02
*** heyongli_ has joined #openstack-nova01:03
*** shaohe_feng1 has joined #openstack-nova01:03
*** promulo__ has quit IRC01:03
*** Marga_ has quit IRC01:03
*** slong_ has joined #openstack-nova01:03
heyongli_baoli: ping01:05
*** slong has quit IRC01:05
*** tjones1 has joined #openstack-nova01:06
*** shaohe_feng has quit IRC01:07
*** shaohe_feng1 has quit IRC01:07
*** shaohe_feng has joined #openstack-nova01:08
*** eliqiao has joined #openstack-nova01:09
*** yuntongjin has quit IRC01:09
*** achanda has quit IRC01:10
*** jogo has joined #openstack-nova01:10
*** yuntongjin has joined #openstack-nova01:10
*** sbfox has quit IRC01:12
*** marun has quit IRC01:13
*** pixelb has quit IRC01:13
*** sdake_ has joined #openstack-nova01:17
*** sdake has quit IRC01:21
*** dboik_ has joined #openstack-nova01:21
baoliheyongli_: Hi01:26
heyongli_hi, baoli01:27
openstackgerritzhangjl proposed openstack/nova: Check if destination_type in block_device_mapping_v2  https://review.openstack.org/17335701:28
openstackgerritGhanshyam Mann proposed openstack/nova: Merge V2 and V2.1 cloudpipe functional tests  https://review.openstack.org/16748101:28
alex_xucfriesen: mriedem1 just FYI, for the evaucate case, there already patch from sdague https://review.openstack.org/#/c/169827/01:29
*** slong_ has quit IRC01:31
*** MVenesio has quit IRC01:31
mriedem1alex_xu: i like cfriesen's patch a lot more, it's much cleaner if it works01:31
*** jwcroppe has quit IRC01:32
alex_xumriedem1: This one https://review.openstack.org/#/c/173615/ ?  will take look at it01:33
*** dsanders has quit IRC01:34
*** Sukhdev has quit IRC01:34
*** setuid has quit IRC01:36
*** popw has joined #openstack-nova01:36
alex_xumriedem1: just quick look at it, I'm not sure it is right, For nova-network case, there also need some cleanup on the source host(for unshelve, reschedule case). And those cleanup and host only for one instance01:37
*** vilobhmm1 has quit IRC01:37
alex_xumriedem1: mriedem1 setup_networks_on_host is for normal generic network setup, not just for one instance01:38
alex_xumriedem1: anyway let me dig into more later01:38
openstackgerritGhanshyam Mann proposed openstack/nova: Merge remote consoles tests between v2 and v2.1  https://review.openstack.org/17363901:43
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: [WIP] Store context in local store after spawn_n  https://review.openstack.org/17311201:47
*** erkules has quit IRC01:48
*** erkules_ has joined #openstack-nova01:48
mriedem1alex_xu: ok, i didn't know it was broken for nova-network too01:50
mriedem1i duplicated cfriesen's bug against the original one though01:51
*** sdake has joined #openstack-nova01:52
*** yamahata has quit IRC01:53
*** baoli has quit IRC01:53
alex_xumriedem1: ok01:54
*** baoli has joined #openstack-nova01:54
*** baoli has quit IRC01:54
*** VW_ has joined #openstack-nova01:54
*** park_heijlong has joined #openstack-nova01:55
*** sdake_ has quit IRC01:56
*** kaisers has joined #openstack-nova01:58
*** kaisers1 has quit IRC01:59
openstackgerritGhanshyam Mann proposed openstack/nova: Merge server rescue tests between v2 and v2.1  https://review.openstack.org/17365102:09
*** achanda has joined #openstack-nova02:10
openstackgerritLan Qi Song proposed openstack/nova: Vmware:Fix how VolumeOps is getting host information  https://review.openstack.org/13518202:13
*** otter768 has joined #openstack-nova02:13
*** changbl has joined #openstack-nova02:14
*** setuid has joined #openstack-nova02:15
*** unicell has quit IRC02:16
*** achanda has quit IRC02:17
*** harlowja is now known as harlowja_away02:17
*** otter768 has quit IRC02:18
*** VW_ has quit IRC02:18
*** dims_ has quit IRC02:21
*** tjones1 has quit IRC02:22
*** tjones1 has joined #openstack-nova02:22
*** VW_ has joined #openstack-nova02:23
*** vilobhmm1 has joined #openstack-nova02:28
*** yamahata has joined #openstack-nova02:28
*** jecarey has joined #openstack-nova02:28
*** salv-orlando has joined #openstack-nova02:28
openstackgerritShaoHe Feng proposed openstack/nova: Move unlock_override policy enforcement into V2.1 REST API layer  https://review.openstack.org/16216802:29
*** browne has joined #openstack-nova02:32
*** patrickeast has quit IRC02:40
*** Nic1 has quit IRC02:41
*** salv-orlando has quit IRC02:41
*** flwang has quit IRC02:48
openstackgerritMatt Riedemann proposed openstack/nova: Remove power_state.BUILDING  https://review.openstack.org/17365802:48
*** xylan has joined #openstack-nova02:51
*** Nic has joined #openstack-nova02:55
*** Nic has quit IRC02:55
*** tjones1 has quit IRC02:59
*** flwang has joined #openstack-nova03:01
*** mriedem has joined #openstack-nova03:02
*** tjones1 has joined #openstack-nova03:03
*** mriedem1 has quit IRC03:04
*** VW_ has quit IRC03:04
*** otter768 has joined #openstack-nova03:05
*** dsanders has joined #openstack-nova03:08
*** mriedem has quit IRC03:08
*** tjones1 has quit IRC03:12
*** achanda has joined #openstack-nova03:13
*** jwcroppe has joined #openstack-nova03:14
*** tjones1 has joined #openstack-nova03:15
*** tjones1 has left #openstack-nova03:15
*** Sukhdev has joined #openstack-nova03:17
*** achanda has quit IRC03:17
openstackgerritAlex Xu proposed openstack/nova: Remove instance group member when delete instance  https://review.openstack.org/17366403:17
*** Longgeek has joined #openstack-nova03:18
*** sbfox has joined #openstack-nova03:24
*** aswadr has joined #openstack-nova03:25
openstackgerritRui Chen proposed openstack/nova: Fix empty instance nw_info cache  https://review.openstack.org/14603603:25
*** tojuvone has joined #openstack-nova03:33
*** dsanders has quit IRC03:34
*** tjones1 has joined #openstack-nova03:34
*** tiagogomes has quit IRC03:37
*** tiagogomes has joined #openstack-nova03:37
*** eliqiao has quit IRC03:41
*** eliqiao1 has joined #openstack-nova03:41
*** Longgeek has quit IRC03:41
*** eliqiao has joined #openstack-nova03:43
*** eliqiao1 has quit IRC03:45
*** VW_ has joined #openstack-nova03:47
*** achanda has joined #openstack-nova03:49
*** tjones1 has quit IRC03:52
*** tjones1 has joined #openstack-nova03:53
*** aswadr has quit IRC03:54
*** amotoki_ has joined #openstack-nova03:54
openstackgerritShaoHe Feng proposed openstack/nova: remove the redundant policy check for SecurityGroupsOutputController  https://review.openstack.org/15936903:55
openstackgerritKen'ichi Ohmichi proposed openstack/python-novaclient: WIP: Fix version-list failure  https://review.openstack.org/17367003:55
*** heyongli_ has quit IRC03:55
*** oro has joined #openstack-nova03:57
*** otter768 has quit IRC04:01
*** oro has quit IRC04:04
*** sgordon has quit IRC04:04
*** dsanders has joined #openstack-nova04:07
*** krtaylor has quit IRC04:07
*** tjones1 has quit IRC04:07
*** tjones1 has joined #openstack-nova04:09
*** sgordon has joined #openstack-nova04:10
*** krtaylor has joined #openstack-nova04:10
*** sudipto has joined #openstack-nova04:10
*** sdake has quit IRC04:11
*** tjones1 has quit IRC04:13
openstackgerritGhanshyam Mann proposed openstack/nova: Merge security groups tests between v2 and v2.1  https://review.openstack.org/17367104:18
*** annashen has joined #openstack-nova04:21
*** dsanders has quit IRC04:22
*** amotoki_ has quit IRC04:24
openstackgerritLianhao Lu proposed openstack/nova: Refactor the bandwidth_usage object's remotable method  https://review.openstack.org/17321304:25
*** annashen has quit IRC04:26
*** salv-orlando has joined #openstack-nova04:29
*** ankit_ag has joined #openstack-nova04:29
*** VW_ has quit IRC04:34
*** sbfox has quit IRC04:34
*** rajesht has joined #openstack-nova04:35
*** shyama has joined #openstack-nova04:36
*** rushiagr_away is now known as rushiagr04:36
*** salv-orlando has quit IRC04:36
*** Longgeek has joined #openstack-nova04:37
*** rushiagr is now known as rushiagr_away04:38
*** rushiagr_away is now known as rushiagr04:38
*** sbfox has joined #openstack-nova04:38
*** dave-mccowan has joined #openstack-nova04:39
*** Longgeek has quit IRC04:44
openstackgerritChris Friesen proposed openstack/nova: Fix binding:host_id for neutron on evacuate  https://review.openstack.org/17361504:44
*** sudipto has quit IRC04:47
*** dsanders has joined #openstack-nova04:49
*** achanda has quit IRC04:50
*** achanda has joined #openstack-nova04:50
*** xyang1 has quit IRC04:52
*** dsanders has quit IRC04:57
*** jwcroppe has quit IRC05:01
*** unicell has joined #openstack-nova05:01
*** mrodden has quit IRC05:12
*** apuimedo has joined #openstack-nova05:12
*** ajayaa has joined #openstack-nova05:14
*** heyongli_ has joined #openstack-nova05:16
*** Sukhdev has quit IRC05:17
*** heyongli_1 has joined #openstack-nova05:19
*** ritesh has quit IRC05:20
*** heyongli_ has quit IRC05:21
*** cfriesen has quit IRC05:21
*** nkrinner has joined #openstack-nova05:23
*** ociuhandu has quit IRC05:29
*** yuntongjin has quit IRC05:34
*** lan has quit IRC05:35
*** lan has joined #openstack-nova05:35
openstackgerritRui Chen proposed openstack/nova: Fix empty instance nw_info cache  https://review.openstack.org/14603605:37
openstackgerritRui Chen proposed openstack/nova: Clean up network_api.get_instance_nw_info  https://review.openstack.org/17368005:37
*** ociuhandu has joined #openstack-nova05:38
*** ankit8188 has joined #openstack-nova05:38
*** ankit8188 has quit IRC05:38
*** Nikolay_St has quit IRC05:44
*** dsanders has joined #openstack-nova05:48
*** Longgeek has joined #openstack-nova05:48
*** dulek has joined #openstack-nova05:49
openstackgerritZhenzan Zhou proposed openstack/nova: Bypass ironic server not available issue  https://review.openstack.org/17368105:50
*** salv-orlando has joined #openstack-nova05:50
*** bkopilov has quit IRC05:53
*** mrodden has joined #openstack-nova05:55
*** ociuhandu has quit IRC05:56
*** bkopilov has joined #openstack-nova05:59
*** salv-orlando has quit IRC06:00
*** otter768 has joined #openstack-nova06:02
*** unicell has quit IRC06:02
*** isd has joined #openstack-nova06:03
*** TobiasE has joined #openstack-nova06:03
*** TobiasE has quit IRC06:05
*** garyk has joined #openstack-nova06:06
*** tjones1 has joined #openstack-nova06:06
*** otter768 has quit IRC06:07
*** ajayaa has quit IRC06:07
*** browne has quit IRC06:09
*** hdd has joined #openstack-nova06:09
*** sudipto has joined #openstack-nova06:11
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex  https://review.openstack.org/17194306:18
*** alex_xu has quit IRC06:18
*** ajayaa has joined #openstack-nova06:24
*** bkopilov has quit IRC06:24
*** tjones1 has left #openstack-nova06:26
*** armax has quit IRC06:28
*** jcoufal has joined #openstack-nova06:29
*** alex_xu has joined #openstack-nova06:30
*** sahid has joined #openstack-nova06:32
openstackgerritGhanshyam Mann proposed openstack/nova: Merge V2 and V2.1 hypervisor functional tests  https://review.openstack.org/16708206:35
*** RuiChen has joined #openstack-nova06:42
*** irenab has joined #openstack-nova06:44
*** unicell has joined #openstack-nova06:45
*** RuiChen has quit IRC06:46
*** achanda has quit IRC06:48
*** vilobhmm1 has quit IRC06:49
*** bkopilov has joined #openstack-nova06:50
*** Mike_D_laptop has joined #openstack-nova06:51
*** rfolco has quit IRC06:55
*** deepthi has joined #openstack-nova06:55
*** bkopilov has quit IRC06:56
*** isd has quit IRC06:58
*** RuiChen has joined #openstack-nova06:59
openstackgerritShaoHe Feng proposed openstack/nova: remove the redundant policy check for SecurityGroupsOutputController  https://review.openstack.org/15936907:03
openstackgerritKen'ichi Ohmichi proposed openstack/python-novaclient: Don't use SessionClient for version-list  https://review.openstack.org/17367007:03
*** jeblair has quit IRC07:05
*** sbfox has quit IRC07:07
*** jeblair has joined #openstack-nova07:07
*** salv-orlando has joined #openstack-nova07:08
*** rwsu has quit IRC07:09
*** bkopilov has joined #openstack-nova07:11
*** doron_afk has joined #openstack-nova07:11
*** markus_z has joined #openstack-nova07:12
*** jichen has joined #openstack-nova07:12
openstackgerritGhanshyam Mann proposed openstack/nova: Merge console & console_output tests between v2 and v2.1  https://review.openstack.org/17144007:12
*** moshele has joined #openstack-nova07:19
openstackgerritSudipta Biswas proposed openstack/nova: Allow discrete blocks of online pCPUs for pinning  https://review.openstack.org/17318707:22
sudiptobauzas, Hi, made some changes to the review from last night. Didn't have to write a new function, since there's already a _host.get_online_cpus() function present in the latest Kilo code...07:23
openstackgerritShaoHe Feng proposed openstack/nova: Move unlock_override policy enforcement into V2.1 REST API layer  https://review.openstack.org/16216807:23
*** jistr has joined #openstack-nova07:24
*** annashen has joined #openstack-nova07:24
openstackgerritGhanshyam Mann proposed openstack/nova: Share multiple create server tests between v2 and v2.1  https://review.openstack.org/17280107:25
gilliardGood $time_of_day!07:27
openstackgerritSergey Nikitin proposed openstack/nova: Fixed incorrect dhcp_server value during nova-network creation  https://review.openstack.org/17336207:28
openstackgerritSudipta Biswas proposed openstack/nova: Allow discrete blocks of online pCPUs for pinning  https://review.openstack.org/17318707:29
*** annashen has quit IRC07:29
openstackgerritKen'ichi Ohmichi proposed openstack/python-novaclient: Add min/max microversions to version-list cmd  https://review.openstack.org/17371107:30
*** ankit_ag has quit IRC07:30
*** RuiChen has quit IRC07:31
*** eglynn has quit IRC07:33
*** ankit_ag has joined #openstack-nova07:33
*** eglynn has joined #openstack-nova07:33
*** rfolco has joined #openstack-nova07:39
*** dsanders has quit IRC07:41
*** romainh has joined #openstack-nova07:41
*** c0m0 has joined #openstack-nova07:42
*** jlanoux has joined #openstack-nova07:42
*** bkopilov has quit IRC07:45
*** Nikolay_St has joined #openstack-nova07:45
*** belmoreira has joined #openstack-nova07:47
*** eglynn has quit IRC07:47
*** bkopilov has joined #openstack-nova07:49
*** rushiagr is now known as rushiagr_away07:49
*** naggappan has joined #openstack-nova07:49
*** bkopilov has quit IRC07:54
*** bkopilov has joined #openstack-nova07:54
ankit_agsahid: hi07:59
*** dsanders has joined #openstack-nova08:01
*** rushiagr_away is now known as rushiagr08:01
*** tjones1 has joined #openstack-nova08:02
*** otter768 has joined #openstack-nova08:02
*** tjones1 has quit IRC08:04
*** tjones1 has joined #openstack-nova08:05
*** eglynn has joined #openstack-nova08:05
sahidhello ankit_ag08:06
*** otter768 has quit IRC08:07
ankit_agsahid: I want to discuss about your comment on https://review.openstack.org/#/c/17329608:09
*** dave-mccowan has quit IRC08:09
*** bkopilov has quit IRC08:10
ankit_agsahid: if delete is defined, in that case we do not need to explicitly check for the condition "changes-since"08:10
ankit_agand thats the existing behaviour08:11
ankit_agsahid:  "changes-since" condition is to set 'deleted'=False if 'deleted' is not passed in to filters, so if delete is defined then we do not need to explicitly set that flag again.08:13
*** mpavone has joined #openstack-nova08:14
*** zzz_pczesno is now known as pczesno08:14
*** shyama has quit IRC08:15
*** eglynn has quit IRC08:16
sahidankit_ag: the comment says "No 'changes-since', so we only want non-deleted servers" that makes me think in all cases if changes-since is not defined we want deleted=False08:17
*** bkopilov has joined #openstack-nova08:17
*** lucasagomes has joined #openstack-nova08:17
sahidwe are breakin whether deleted is defined and equal to True and changes-since not defined08:18
*** ujjain has joined #openstack-nova08:20
*** dsanders has quit IRC08:20
sahidankit_ag: hum let me double check...08:21
ankit_agsahid: yes sure, because by looking at the master code, it is clear that change-since needs to check only if deleted is not defined in filters08:23
*** yamahata has quit IRC08:25
*** a5t3r1x has joined #openstack-nova08:25
a5t3r1xhello:-)08:26
a5t3r1xquick question.08:26
a5t3r1xit is possible to use eth1:0 as the flat_interface?08:26
*** ndipanov has joined #openstack-nova08:27
*** eglynn has joined #openstack-nova08:27
sahidankit_ag: replied08:28
*** inhumanitas has quit IRC08:29
ankit_agsahid: yes, that makes sense. Thank you !08:29
*** ociuhandu has joined #openstack-nova08:31
*** bkopilov has quit IRC08:39
*** heyongli_1 has quit IRC08:43
*** pixelb has joined #openstack-nova08:44
*** shaohe_feng has quit IRC08:45
*** bkopilov has joined #openstack-nova08:45
openstackgerritSergey Nikitin proposed openstack/nova: Changed backporting of embedded Network object when backporting a FixedIP  https://review.openstack.org/17372308:47
*** doron_afk is now known as doron_mtg08:49
*** shaohe_feng has joined #openstack-nova08:49
*** park_heijlong has quit IRC08:50
*** bkopilov has quit IRC08:51
*** bkopilov has joined #openstack-nova08:52
*** shaohe_feng has quit IRC08:55
*** krtaylor has quit IRC08:57
*** bkopilov has quit IRC08:57
*** pask81 has joined #openstack-nova08:59
*** pask81 has quit IRC08:59
openstackgerritEli Qiao proposed openstack/nova: Libvirt: pre check cpuset when do LM  https://review.openstack.org/17372909:02
*** warewang has joined #openstack-nova09:02
*** Kevin_Zheng has joined #openstack-nova09:03
*** shyama has joined #openstack-nova09:03
*** pask81 has joined #openstack-nova09:03
*** krtaylor has joined #openstack-nova09:04
*** sudipto has quit IRC09:05
*** Marga_ has joined #openstack-nova09:06
openstackgerritEli Qiao proposed openstack/nova: Libvirt: pre check cpuset when do LM  https://review.openstack.org/17372909:08
*** ipj has joined #openstack-nova09:08
ipjhey guys09:08
ipjI'm having serious problems with instance resizing09:08
ipjthe command "nova resize" etc is working09:08
ipjand I get no errors09:08
ipjbut the status of the VM does not change... simply, the resize takes no effect09:08
ipjanyone can help me?09:09
*** sdake has joined #openstack-nova09:10
*** jamie_h has joined #openstack-nova09:12
*** eliqiao has quit IRC09:13
kashyapipj: You might get more responses on #openstack for such questions, this channel is mostly for upstream Nova development09:15
ipjok kashyap, thanks09:15
*** pask81 has quit IRC09:15
openstackgerritSergey Nikitin proposed openstack/nova: Changed backporting of embedded Network object when backporting a FixedIP  https://review.openstack.org/17372309:16
*** sudipto has joined #openstack-nova09:21
*** pask81 has joined #openstack-nova09:22
*** derekh has joined #openstack-nova09:25
*** Marga_ has quit IRC09:28
*** pask81 has quit IRC09:28
*** Marga_ has joined #openstack-nova09:29
*** abhishekk has joined #openstack-nova09:29
*** TobiasE has joined #openstack-nova09:31
openstackgerritTracy Jones proposed openstack/nova: Cleanup of compute api reboot method  https://review.openstack.org/12742709:31
*** pask81 has joined #openstack-nova09:31
*** gszasz has joined #openstack-nova09:36
*** gszasz_ has joined #openstack-nova09:37
*** garyk has quit IRC09:39
*** tjones1 has quit IRC09:39
*** garyk has joined #openstack-nova09:40
*** tjones1 has joined #openstack-nova09:41
*** gszasz has quit IRC09:41
*** ZZelle has quit IRC09:44
ipjkashyap, I dunno if you are curious: the VM resizing is working from a small flavor to a bigger one, but not in the other direction09:45
kashyapipj: Yeah, I remember testing that a long time ago,09:46
*** tjones1 has quit IRC09:46
kashyapand IIRC, it wasn't considered a priority09:47
ipjkashyap, may this be a problem related to LVM?09:47
kashyapAt one point (later 2013) Nova used to return bogus success for a resize operation, but it was fixed in later releases -- https://bugzilla.redhat.com/show_bug.cgi?id=104551509:48
openstackbugzilla.redhat.com bug 1045515 in openstack-nova "Re-size of an ACTIVE Nova instance returns success (albeit, bogus)" [Unspecified,Closed: currentrelease] - Assigned to ndipanov09:48
moshelehi can nova cores review https://review.openstack.org/#/c/168317/ and https://review.openstack.org/#/c/168680/ ?09:48
kashyapipj: Hmm, I don't test a whole lot with LVM, so I can't say it's that for sure.09:49
*** liusheng has quit IRC09:51
*** jamielennox is now known as jamielennox|away09:52
*** gszasz has joined #openstack-nova09:56
*** gszasz has quit IRC09:57
*** jhesketh has quit IRC09:57
*** gszasz_ has quit IRC09:58
rajeshtipj: IMO resize down is not supported09:59
rajeshtipj: https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L622509:59
*** jhesketh has joined #openstack-nova10:00
*** amotoki has joined #openstack-nova10:00
*** gszasz has joined #openstack-nova10:00
*** Longgeek has quit IRC10:02
*** Longgeek_ has joined #openstack-nova10:02
kashyapInstead of throwing up hands with reason "Unable to resize disk down", it should throw a little more reasonable error: "Invalid operation: resize disk down" or something like that. "unable" implies there's some error on the user's part.10:03
*** otter768 has joined #openstack-nova10:03
*** otter768 has quit IRC10:08
ipjrajesht, thanks10:09
ipjimho, this should be notified to the user in some fashion10:09
ipjI could never understand that it isn't supported10:09
Mike_D_laptoprajesht: Hi! Why you think so?10:09
Mike_D_laptoprajesht: Ohh :)I forgot... never mind. It's possible for instance which booted from volume...10:11
*** irenab has quit IRC10:12
rajeshtMike_D_laptop: np :)10:13
*** sudipto has quit IRC10:16
*** doron_mtg has quit IRC10:21
*** dheeraj-gupta-4 has joined #openstack-nova10:22
*** moshele has quit IRC10:22
*** achanda has joined #openstack-nova10:22
*** dguitarbite has joined #openstack-nova10:24
*** moshele has joined #openstack-nova10:25
*** annashen has joined #openstack-nova10:26
*** jcoufal has quit IRC10:27
*** lpetrut has joined #openstack-nova10:27
*** achanda has quit IRC10:27
*** jcoufal has joined #openstack-nova10:27
*** IanGovett has joined #openstack-nova10:28
*** sudipto has joined #openstack-nova10:28
*** annashen has quit IRC10:31
*** romainh has quit IRC10:33
*** ociuhandu has quit IRC10:34
*** claudiub has joined #openstack-nova10:34
*** amotoki_ has joined #openstack-nova10:40
*** amotoki has quit IRC10:43
*** sdake has quit IRC10:46
*** romainh has joined #openstack-nova10:48
*** pask81 has quit IRC10:48
*** zhenguo has quit IRC10:48
*** asselin_ has quit IRC10:49
*** popw has quit IRC10:52
*** ujjain has quit IRC10:59
*** Kevin_Zheng has quit IRC11:02
*** warewang has quit IRC11:02
*** deepthi has quit IRC11:02
*** Marga_ has quit IRC11:02
*** amotoki has joined #openstack-nova11:02
ankit_agalex_xu: hi11:04
*** amotoki_ has quit IRC11:05
*** irenab has joined #openstack-nova11:06
*** bkopilov has joined #openstack-nova11:07
*** zz_johnthetubagu is now known as johnthetubaguy11:07
*** dims has joined #openstack-nova11:08
*** irenab has quit IRC11:09
*** romainh has left #openstack-nova11:09
*** ferest has joined #openstack-nova11:10
*** ferest has quit IRC11:11
*** ferest has joined #openstack-nova11:11
*** romainh has joined #openstack-nova11:12
*** ferest has quit IRC11:13
*** gszasz has quit IRC11:16
*** popw has joined #openstack-nova11:20
openstackgerritMh Raies proposed openstack/nova: Enable tenant/user specific instance filtering  https://review.openstack.org/13902511:21
*** gszasz has joined #openstack-nova11:21
*** mwagner_lap has quit IRC11:21
*** doron_mtg has joined #openstack-nova11:21
*** Longgeek has joined #openstack-nova11:29
*** otter768 has joined #openstack-nova11:31
*** Longgeek_ has quit IRC11:31
bauzasjohnthetubaguy: around ?11:33
johnthetubaguybauzas: I am11:33
johnthetubaguybauzas: although I am running to lunch in a sec, can I help?11:34
bauzasjohnthetubaguy: I saw your comments on https://review.openstack.org/#/c/141486/11:34
johnthetubaguyah, yes11:34
bauzasjohnthetubaguy: just wanted to discuss with you for it, because I'm working on the scaling out scheduler11:34
bauzasjohnthetubaguy: see https://etherpad.openstack.org/p/liberty-nova-summit-ideas L6711:34
johnthetubaguyah, OK, cools11:34
bauzasjohnthetubaguy: I'm thinking about having a shared-state HostState11:35
bauzasjohnthetubaguy: like Google Omega11:35
bauzasjohnthetubaguy: but go to lunch, and we'll discussing later on11:35
johnthetubaguybauzas: so I am mostly agreed with omega, from when I remember reading that last11:36
*** ipj has quit IRC11:36
johnthetubaguybauzas: its partly why I don't like the two level scheduler, unless its a clean partition11:36
bauzasjohnthetubaguy: I also thought about Kafka, so maybe an hangout could be cool - unfortunately, we're close to RC2 so you would probably be just overworking now11:36
*** ociuhandu has joined #openstack-nova11:37
johnthetubaguybauzas: more pressed for time with internal release stuff at the moment, but we should catch up on that, let me go get something to eat, and get back to you11:37
bauzasjohnthetubaguy: by remembering the most papers I saw, I think a divide-and-conquer scheduler (ie. a sharding one) is less better than a shared-state one11:37
johnthetubaguybauzas: its not in the way I sharded it though11:38
johnthetubaguybauzas: I was presenting a partitioned shared state system, not a two level system11:38
bauzasjohnthetubaguy: we have the chance to have a read-only HostState for the scheduler11:38
bauzasjohnthetubaguy: oh like Omega then ?11:39
johnthetubaguybauzas: thats unrelated, while useful, will talk more later11:39
johnthetubaguybauzas: yeah, its quite similar actually11:39
bauzasjohnthetubaguy: okay, I'll write out a spec11:39
bauzasjohnthetubaguy: just for opening discussion11:39
johnthetubaguybauzas: yes, the basic idea I have is two things11:39
bauzasjohnthetubaguy: because at the moment, it's just braindump11:39
bauzasjohnthetubaguy: I saw : Kafka for providing states, and partitioned shared-state for many scheds ?11:40
johnthetubaguybauzas: if you can split your infrastructure into groups based on the incomming request (we do that with groups of flavors, onmetal vs ssd vs spinny disk, etc)11:40
johnthetubaguythats not two level, its sharded11:40
johnthetubaguythe other bit yeah, is efficient updating of the shared state11:41
johnthetubaguykafaka is a good messaging system that does what we need for that, I think11:41
bauzasagreed, we have the same direction11:41
johnthetubaguyOK cools11:41
johnthetubaguytalk more later11:41
bauzasokay, let me draft out some manifesto spec11:41
johnthetubaguybauzas: thanks, sounds good11:42
*** doron_mtg is now known as doron_afk11:48
*** aix has quit IRC11:50
*** beagles has joined #openstack-nova11:52
*** tojuvone has quit IRC11:52
*** otter768 has quit IRC11:56
*** jecarey has quit IRC11:58
*** doron has joined #openstack-nova12:01
*** doron_afk has quit IRC12:02
sudiptobauzas, johnthetubaguy  Can openstack currently perform resize of VMs without rebooting it for KVM?12:04
*** raildo has joined #openstack-nova12:06
*** dprince has joined #openstack-nova12:08
*** irenab has joined #openstack-nova12:08
*** mwagner_lap has joined #openstack-nova12:09
*** MVenesio has joined #openstack-nova12:13
*** irenab has quit IRC12:13
johnthetubaguysudipto: no driver can do that today, AFAIK, there are a few ideas that keep being raised though12:14
johnthetubaguysudipto: scale up isn't considered very cloudy, so its not something thats been priorities up to this point12:15
*** irenab has joined #openstack-nova12:16
*** irenab has quit IRC12:17
openstackgerritgaryk proposed openstack/nova: Resource tracker: unable to restart nova compute  https://review.openstack.org/17379412:18
*** aysyd has joined #openstack-nova12:18
*** irenab has joined #openstack-nova12:18
bauzasjohnthetubaguy: sudipto: yeah agreed and that sounds very driver specific12:19
bauzaseven guest specific12:19
*** irenab has quit IRC12:20
*** irenab has joined #openstack-nova12:20
sudiptojohnthetubaguy, Hmm, ok. That answers my question.  Libvirt doesn't have the support AFAIK...but you say that it's not a cloud use case coz?12:21
sudiptotrying to understand :)12:21
johnthetubaguysudipto: its just not a high priority cloud use case, because with cattle VMs you just start a new bigger VM, or ideally, more smaller VMs, its "pet" VMs that would need to be resized with zero downtime, and we are not really optimising for those12:22
sudiptojohnthetubaguy, Okk...12:23
johnthetubaguysudipto: having said that, I keep seeing blueprints for this crop us, so it may get somewhere soon12:25
*** amotoki has quit IRC12:25
johnthetubaguyas bauzas mentioned, there are lots issues making it work in general, but a lot of the "hotplug" work should be possible, even if some number of users need to reboot to see the extra capacity thats added, at least they could then choose when to reboot12:26
johnthetubaguy(but I have my xenapi head on talking about that, not sure about libvirt)12:26
sudiptojohnthetubaguy, Yeah makes sense...12:26
*** amotoki has joined #openstack-nova12:27
bauzasjohnthetubaguy: the main problem I see with this approach is that an image can be cloud-ready or not, and thus can't support resizing12:27
bauzasjohnthetubaguy: I mean live resizing12:28
*** aix has joined #openstack-nova12:28
johnthetubaguybauzas: think more about hotplugging RAM and CPU, rather than resizing a disk12:28
sudiptobauzas, yeah12:28
sudiptobauzas, I was talking about RAM and CPU12:28
bauzasjohnthetubaguy: I remember my lovely operator days where I had to play with Windows guest images on OpenStack12:28
johnthetubaguyright, thats very doable, just we don't do it12:29
*** zhenguo has joined #openstack-nova12:29
sudiptojohnthetubaguy, assuming the driver should also support it which i think it currently doesn't. Atleast for Libvirt.12:29
johnthetubaguyright, the code is not there, but its possible to add it12:30
sudiptojohnthetubaguy, Thanks! That helps me understand it!12:30
sudiptobauzas, Thanks to you too!12:30
johnthetubaguyno problem12:30
*** amotoki has quit IRC12:31
*** dheeraj-gupta-4 has left #openstack-nova12:32
*** eharney has joined #openstack-nova12:34
*** dkliban_afk is now known as dkliban12:35
*** irenab has quit IRC12:35
rajeshtdansmith: you around ?12:35
*** irenab has joined #openstack-nova12:36
*** vladikr has joined #openstack-nova12:39
*** ZZelle has joined #openstack-nova12:39
*** baoli has joined #openstack-nova12:42
*** jaypipes has quit IRC12:42
*** otter768 has joined #openstack-nova12:43
rajeshtdims: you around ?12:43
openstackgerritgaryk proposed openstack/nova: VMware: enable a resize of instance with no root disk  https://review.openstack.org/17380212:44
*** irenab has quit IRC12:45
*** otter768 has quit IRC12:46
*** smccully has joined #openstack-nova12:46
*** irenab has joined #openstack-nova12:46
*** rasoto_ has joined #openstack-nova12:47
*** irenab has quit IRC12:47
*** annegentle has joined #openstack-nova12:50
openstackgerritsahid proposed openstack/nova: compute: make test rpcapi more flexible  https://review.openstack.org/16417712:51
*** naggappan has quit IRC12:51
bauzasalaski: quick update on the idempotent tests, it seems it's probably not due to the race condition we mentioned12:52
rajeshtjohnthetubaguy: you around ?12:52
johnthetubaguyrajesht: kind of yes12:52
*** baoli_ has joined #openstack-nova12:54
*** garyk has quit IRC12:54
bauzasalaski: because the Tempest assertion is failing before we enter the instance.save() cell condition for _from_api12:54
johnthetubaguyrajesht: can I help?12:55
rajeshtjohnthetubaguy: there is an issue after adding V4 RPC api, if instance deleted during resize, we are not able to restart the n-cpu12:55
rajeshtjohnthetubaguy: pl check the bug https://bugs.launchpad.net/nova/+bug/144430012:55
openstackLaunchpad bug 1444300 in OpenStack Compute (nova) "nova-compute service doesn't restart if resize operation fails" [Undecided,New] - Assigned to Rajesh Tailor (rajesh-tailor)12:55
rajeshtthe decorators around the ComputeManager methods don't get parameters as kwargs, that why they failed with KeyError12:56
rajeshtjohnthetubaguy: correct me If I'm wrong12:56
*** jaypipes has joined #openstack-nova12:56
*** baoli has quit IRC12:56
*** rasoto_ has left #openstack-nova12:56
johnthetubaguyrajesht: I don't know, sounds like a bug I just saw: https://review.openstack.org/#/c/173794/12:57
*** claudiub has quit IRC12:57
rajeshtjohnthetubaguy: let me check, If this patch fixes this issue12:58
*** busterswt has joined #openstack-nova13:01
*** sald has joined #openstack-nova13:05
*** jecarey has joined #openstack-nova13:06
*** neelashah has joined #openstack-nova13:06
*** sudipto has quit IRC13:07
*** dboik_ has quit IRC13:08
*** adalbas has quit IRC13:12
openstackgerritsahid proposed openstack/nova: servicegroup: remove get_all method never used as public  https://review.openstack.org/16887613:12
*** dims has quit IRC13:13
*** burt has joined #openstack-nova13:14
*** irenab has joined #openstack-nova13:14
*** dims has joined #openstack-nova13:15
rajeshtjohnthetubaguy: with https://review.openstack.org/#/c/173794/ patch, I'm able to start the n-cpu service13:15
rajeshtjohnthetubaguy: but the problem still remains which I have mentioned in https://bugs.launchpad.net/nova/+bug/1444300 LP bug13:16
openstackLaunchpad bug 1444300 in OpenStack Compute (nova) "nova-compute service doesn't restart if resize operation fails" [Undecided,New] - Assigned to Rajesh Tailor (rajesh-tailor)13:16
rajeshtjohnthetubaguy: The issue which I have reported is because of newly added RPC V4.0 API, where methods gets parameter in kwargs from rpcapi13:17
rajeshtjohnthetubaguy: but don't pass these kwargs as args to RPC 3.x API,13:18
*** thomasem has joined #openstack-nova13:18
rajeshtjohnthetubaguy: methods of ComputeManager class (RPC 3.x) expects objects as kwargs, but gets as args from RPC 4.0 _ComputeV4Proxy class.13:19
johnthetubaguyrajesht: hmm, interesting, we had something related for live-migrate, dansmith might be able to help take a look at that13:19
*** thomasem has quit IRC13:19
rajeshtIMO, the same will fail for each method defined in 4.0 because the decorators around 3.x expects kwargs13:19
alaskibauzas: where did you see that?13:20
bauzasalaski: local debugging13:20
johnthetubaguyrajesht: a lot of the decorators use a util method to fix that, but not all of them13:20
alaskibauzas: did it fail with a different error?13:20
johnthetubaguyrajesht: I can't dig into that right now, I am in the middle of another bug I am afraid, sorry to not be more help right this second13:21
bauzasalaski: sec, reproducing the behaviour13:21
rajeshtjohnthetubaguy: np, thanks for your time13:21
bauzasalaski: just to be clear, instance.save() is called when terminating here https://github.com/openstack/tempest/blob/master/tempest/thirdparty/boto/test_ec2_instance_run.py#L12613:22
dimsrajesht: pong13:22
rajeshtdims: hi13:22
bauzasalaski: I left a pdb trace within _handle_cell_update_from_api and it got executed only when it was terminating13:23
*** MVenesio has quit IRC13:23
rajeshtdims: could you please take a look at this LP bug https://bugs.launchpad.net/nova/+bug/144430013:23
openstackLaunchpad bug 1444300 in OpenStack Compute (nova) "nova-compute service doesn't restart if resize operation fails" [Undecided,New] - Assigned to Rajesh Tailor (rajesh-tailor)13:23
rajeshtdims: IMO it is because of newly added RPC V4.013:23
*** david-lyle has quit IRC13:24
alaskibauzas: okay.  I may need to trace this locally then to see what's going on13:24
rajeshtdims: I was discussing with johnthetubaguy related to this only.13:24
bauzasalaski: I just checked13:25
*** dboik has joined #openstack-nova13:25
bauzasalaski: so https://github.com/openstack/tempest/blob/master/tempest/thirdparty/boto/test_ec2_instance_run.py#L10113:25
bauzasalaski: later calls https://github.com/openstack/nova/blob/master/nova/api/ec2/cloud.py#L1405-L141813:26
*** thomasem has joined #openstack-nova13:26
bauzasalaski: but compute_api.create() is actually calling the main API13:26
bauzasalaski: because the cells API returns the super method13:26
bauzasalaski: https://github.com/openstack/nova/blob/master/nova/compute/cells_api.py#L19913:27
*** VW_ has joined #openstack-nova13:27
*** mriedem has joined #openstack-nova13:27
*** cbader has joined #openstack-nova13:27
*** irenab has quit IRC13:27
*** irenab has joined #openstack-nova13:29
bauzasalaski: and https://github.com/openstack/nova/blob/master/nova/compute/api.py#L919 calls .update() instrad13:29
bauzasinstead even13:29
*** annashen has joined #openstack-nova13:29
alex_xuankit_ag: hi13:29
alaskibauzas: it eventually calls save in create_db_entry...13:30
bauzasalaski: but as it's done on the main compute.api, it's not having a cell_name right ?13:30
*** r-daneel has joined #openstack-nova13:31
alaskioh, it calls create()13:31
alaskibauzas: right, it does not13:31
ankit_agalex_xu: hi, I was looking for your help in https://review.openstack.org/#/c/171523/13:31
bauzasalaski: so https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L770 returns False even if it's called somewhere13:32
alex_xuankit_ag: ok, reading your reply13:32
alaskibauzas: yeah.  but it's calling create() and doesn't need to be synced at this point13:33
bauzasalaski: agreed13:33
*** garyk has joined #openstack-nova13:33
bauzasalaski: and then .update()13:33
*** annashen has quit IRC13:33
ankit_agshould we make these changes or it is fine to not allow an user to delete an instance by name when it is in soft_deleted state13:33
dansmithrajesht: johnthetubaguy: although that seems similar, I don't think it is. That looks like the delete deletes the instance files under the resize, which we shouldn't let it do13:34
alaskibauzas: and then the ec2 api looks up the instance and adds system_metadata for the client token13:34
*** ipj has joined #openstack-nova13:34
*** ipj has quit IRC13:35
johnthetubaguydansmith: ah, gotcha, didn't look too closely, but I guess we always want to allow delete13:35
rajeshtdansmith: IMO we need to use safe_utils.getcallargs in errors_out_migration decorator ?13:35
dansmithjohnthetubaguy: I guess, but seems like resize/migrate would be a good time to *not* allow it13:35
ankit_agbecause for me it is an issue, whether we document it in the api documentation, because for all the remaining cases we are allowing user to delete instance by name and id, so why not in case of soft_deleted instances.13:35
bauzasalaski: yeah https://github.com/openstack/nova/blob/master/nova/api/ec2/cloud.py#L142313:35
dansmithrajesht: that may be collateral damage, yeah13:36
johnthetubaguydansmith: thats certainly easier13:36
bauzasalaski: within there, we have an instance.save()13:36
johnthetubaguydansmith: I mean we see folks delete stuff half way through building, and that can create some mess, but still you want it, in some way13:36
dansmithjohnthetubaguy: it just seems like if we're in the middle of the copy, the easiest thing to do is wait for it to finish and then do the delete..13:37
dansmithjohnthetubaguy: rajesht: is this a regression or just a thing you found/13:37
ankit_agalex_xu: I am looking for ypur opinion about the delete api functionality13:37
johnthetubaguydansmith: yeah13:37
*** jwcroppe has joined #openstack-nova13:38
rajeshtdansmith: yes13:38
*** jwcroppe has quit IRC13:38
dansmithjohnthetubaguy: obviously I'd like to be able to signal the thread, stop the copy immediately, etc, but that likely requires another rpc call to the other side to tell it to clean up, etc13:38
bauzasalaski: but unless I'm wrong, the created instance doesn't still has a cell_name field13:38
alex_xuankit_ag: I'm ok fix the first problem in the separated patch, but I'm still thinking about the second one13:38
bauzasalaski: so it doesn't still sync13:39
johnthetubaguydansmith: agreed13:39
*** jwcroppe has joined #openstack-nova13:39
bauzasalaski: I can trace it, sec13:39
alaskibauzas: that may be true, unless it has synced up from the cell at that point13:39
*** ozialien has joined #openstack-nova13:39
alaskibauzas: but either way, it should save the system_metadata properly13:39
alaskibauzas: in the api db13:39
*** neelashah has quit IRC13:40
ankit_agalex_xu: By looking at the souce code, second issue looks like it is by design there13:40
*** neelashah has joined #openstack-nova13:40
ankit_agso I have filed a doumentation issue for the same13:40
*** garyk has quit IRC13:41
*** ferest has joined #openstack-nova13:41
alex_xuankit_ag: what the behavior if status=deleted without deleted=true?13:42
bauzasalaski: sec, running again the tests13:42
ankit_agalex_xu: For the first issue I have submitted separate patch to handle 'deletedd' filter . But for 'soft_deleted' I need to handle in the same patch13:42
alex_xuankit_ag: yes13:42
alex_xuankit_ag: and how about we make https://review.openstack.org/#/c/171523/ depend on this fix https://review.openstack.org/#/c/173296/?13:43
bauzasalaski: confirmed, instance.cell_name is None13:43
*** ferest has quit IRC13:43
alaskibauzas: okay.  but does it save the system_metada properly?13:43
alaskibauzas: and does that get overwritten at some point later?13:44
*** neelashah has quit IRC13:44
bauzasalaski: just to be clear, I'm following the path for instance.save()13:45
ankit_agalex_xu:  https://review.openstack.org/#/c/171523/ is not dependent https://review.openstack.org/#/c/173296/, because that only handles deleted filter and not 'soft_deleted'13:45
bauzasalaski: so, as cell_name is None in https://github.com/openstack/nova/blob/master/nova/api/ec2/cloud.py#L143513:45
alex_xuankit_ag: ok, I see now13:46
*** hdd has quit IRC13:46
*** irenab has quit IRC13:46
alex_xuankit_ag: I checked the code, the status=deleted works without deleted=true. If this is right, I think we can use stauts=soft-deleted without soft_delted=true also13:47
*** triggerz has joined #openstack-nova13:47
*** mtanino has joined #openstack-nova13:48
triggerzwhat is done when a vm is in the "spawning" state?13:48
*** markvoelker has joined #openstack-nova13:48
ankit_agalex_xu: yes, thats correct. But on master status=soft_deleted does not work without deleted=true13:49
*** READ10 has joined #openstack-nova13:49
alex_xuankit_ag: I prefer to fix that13:49
bauzasalaski: so, yeah, confirmed, at any moment when saving, we're syncing13:49
*** hdd has joined #openstack-nova13:50
alex_xuankit_ag: but looks like that can be fix in separated patch also13:51
alex_xuankit_ag: a fix https://review.openstack.org/#/c/171523/ can depend on13:51
ankit_agalex_xu: in sqlalchemy.api 'deleted' filter is applied on top of the 'soft_deleted' filter whlie fetching instance list13:52
*** eliqiao has joined #openstack-nova13:52
ndipanovpczesno, hey13:52
ndipanovu there?13:52
alex_xuankit_ag: status=delete work with this way https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L18413:53
*** dkliban has left #openstack-nova13:53
alex_xuankit_ag: does status=soft-delete can work with that way also?13:53
mtaninoHi nova core team, Can I get a target of this bug? https://bugs.launchpad.net/nova/+bug/137716113:54
openstackLaunchpad bug 1377161 in OpenStack Compute (nova) "If volume-attach API is failed, Block Device Mapping record will remain" [Low,In progress] - Assigned to Mitsuhiro Tanino (mitsuhiro-tanino)13:54
ankit_agalex_xu: I'll check this and will come back to you. Thank you !13:54
*** neelashah has joined #openstack-nova13:54
*** Nikolay_St has quit IRC13:54
alex_xuankit_ag: you are welcome, free to ping me if you still find some trouble with this way13:55
ankit_agalex_xu: status='deleted' is only allowed for admin user13:56
ankit_agbut we need soft_deleted instances in case of delete api for normal user as well13:56
eliqiaoankit_ag: alex_xu: I am not sure that will works, I remember that I have a patch to fix that, https://review.openstack.org/#/c/118641/113:58
ankit_agalex_xu: and if we do not add that admin context check, then normal user will be able to list all the soft deleted instances with this change13:58
*** artom has joined #openstack-nova13:59
eliqiaothat admin check is explict, so I think soft-deleted instance can only be seen by admin , it is by designed.13:59
*** matrohon has joined #openstack-nova14:00
*** rushil has joined #openstack-nova14:01
ankit_ageliqiao: yup, so in my patch, we are not allowing normal user to see soft_deleted instances, but he should be able to delete that instance14:01
eliqiaoankit_ag: there is a configure option in nova config file, it is a time slot, after sometime, the soft-deleted instances will be hard deleted by nova automaticly.14:02
bauzasalaski: I think I got the idea14:02
bauzasalaski: for the third instance being booted with the same token than the first one, it should enter that https://github.com/openstack/nova/blob/master/nova/api/ec2/cloud.py#L1367-L137414:03
ankit_ageliqiao: you are right, but what if you want to delete that instance immidiatly14:04
*** doron is now known as doron_afk14:04
ankit_agcurrently it is allowed to call delete by instance-id, but by name it gives not found error14:04
*** Nikolay_St has joined #openstack-nova14:04
*** nkrinner has quit IRC14:06
*** eliqiao1 has joined #openstack-nova14:07
eliqiao1ankit_ag: do you mean, it(soft-deleted) can be delete by uuid, but not by name?14:07
ankit_ageliqiao: yes, thats correct14:07
*** ujjain has joined #openstack-nova14:08
eliqiao1ankit_ag: if that so , I think we need fix something.14:08
bauzasalaski: got it14:08
ankit_ageliqiao: so I have submitted a patch in novaclient, for which we need to make these change in nova as well14:08
*** eliqiao has quit IRC14:08
eliqiao1ankit_ag: cool, do you have a bug reported against it?14:09
ankit_ageliqiao: yes, let me get that for you14:09
eliqiao1ankit_ag: thanks :)14:10
*** zz_jgrimm is now known as jgrimm14:11
ankit_ageliqiao: https://bugs.launchpad.net/nova/+bug/143684914:11
openstackLaunchpad bug 1436849 in OpenStack Compute (nova) "Inconsistent delete API in case of soft-delete" [Low,In progress] - Assigned to Ankit Agrawal (ankitagrawal)14:11
alaskibauzas: what did it end up being?14:11
ankit_ageliqiao, alex_xu: I request your opinion on this issue14:11
bauzasalaski: self.compute_api.get_all_system_metadata returns zero results14:12
ankit_agThank you for your time and help :)14:12
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Fix proxying finish_resize and resize_instance in _ComputeV4Proxy  https://review.openstack.org/17389714:12
dimsrajesht: see if this will help? ^^^14:12
*** markvoelker_ has joined #openstack-nova14:13
ndipanovdansmith, https://review.openstack.org/#/c/173394/14:13
ndipanovit would be really good if we could slam this in so that I can propose it for RC214:13
bauzasalaski: it should return one instance14:13
ndipanovdansmith, and I have a feeling you will get what it is about very quickly ;)14:14
alaskibauzas: right.  did the system_metadata not get saved for some reason?14:14
*** abhishekk has quit IRC14:14
bauzasalaski: that's what I'm diggin14:14
bauzasalaski: doesn't look to be overrided by the cells_api so that's just checking the API DB14:15
eliqiao1ankit_ag: yw, I will post some comments on the bug if I found something useful.14:15
dansmithndipanov: we just merged a thing to remove that None from the else clause, right bauzas ?14:15
alaskibauzas: yeah, it's a bit confusing to me at this point14:15
dansmithor was that a different thing?14:15
ndipanovdansmith, yes14:15
ndipanovI did that and broke it14:15
ndipanovgit blame it on me :)14:15
bauzasdansmith: mmm ?14:15
bauzasdansmith: missing context14:15
dansmithbauzas: ndipanov's patch above14:15
bauzasdansmith: yeah, that reminds me something, but I have to check14:16
*** markvoelker has quit IRC14:16
*** ozialien has quit IRC14:17
ndipanovdansmith, bauzas https://review.openstack.org/#/c/169245/14:17
bauzasyeah that one14:17
*** tonytan4ever has joined #openstack-nova14:17
ndipanovhmmm I didn't actually remove the none there...14:18
ndipanovah right14:18
ndipanovbecause we didn't even use it14:18
dansmithno, that's not the one I was thinking of14:18
mtaninodims: Hi, Can I get a target of this bug? I found your name on the bug. https://bugs.launchpad.net/nova/+bug/137716114:19
openstackLaunchpad bug 1377161 in OpenStack Compute (nova) "If volume-attach API is failed, Block Device Mapping record will remain" [Low,In progress] - Assigned to Mitsuhiro Tanino (mitsuhiro-tanino)14:19
ndipanovbecause we stashed it on the filter14:19
*** ozialien has joined #openstack-nova14:19
ndipanovdansmith, anyway - there is an explanation why that None is needed in my comment14:19
*** achanda has joined #openstack-nova14:20
dimsmtanino: there was a change in nova that got abandoned.14:20
bauzasdansmith: oh you meant the sched client thing ?14:20
dansmithI dunno, I'm doing too many things at once right now14:21
dimsmtanino: ah there's another one https://review.openstack.org/#/c/166695/14:21
bauzasyeah, we merged a lot of PCI changes recently... :/14:21
BobBallmriedem: Citrix CI is back working and commenting (clearly not voting); see https://review.openstack.org/#/c/168876/ (still currently the wrong format, sorry)14:21
*** irenab has joined #openstack-nova14:22
dimsmtanino: what would you like the "Importance" field to be?14:22
dimsmtanino: can you please add some notes in the bug report so we can flip it?14:22
mriedemBobBall: ok, are you asking that voting be turned back on?14:22
mtaninodims: sure. The final patch is https://review.openstack.org/#/c/166695/14:22
*** cfriesen has joined #openstack-nova14:23
*** achanda has quit IRC14:24
ankit_ageliqiao: That will be really helpful. Thank you14:24
mtaninodims: I think the importance is medium because this bug causes unintentional volume detach.14:24
BobBallmriedem: If you're happy to enable it, sure - but we won't use it yet.  I want to leave it running for a day or so to check the pass rate and make sure there isn't another race lurking somewhere that'd cause more frustration.14:24
mriedemBobBall: ok, that was my thinking14:25
dimsmtanino: done14:25
mriedemBobBall: when you're comfortable with it please ping me or johnthetubaguy or mikal14:25
BobBallWill do.14:25
openstackgerritPetrut Lucian proposed openstack/nova: Hyper-V: Nova serial console access support  https://review.openstack.org/14500414:25
mtaninodims: Thank you :) Is it possible to get merge this during Kilo or need to wait liberty1?14:25
*** ozialien has quit IRC14:26
dimsmtanino: one of the cores will figure that out (i am not a core). it's probably late for Kilo if you ask me14:26
mtaninodims: I see. Thanks.14:27
sdaguealaski / johnthetubaguy - so the gate back up is in part caused by 180 nodes stuck in deleting state in RAX. Any chance we could get someone to look at it14:27
mtaninodims: you are in the nova bug team?14:27
dimsmtanino: see guidance from the team - http://markmail.org/message/ct45huk4cty6p2mx14:27
bauzasndipanov: dansmith: looking at your comment on https://review.openstack.org/#/c/173394/1/nova/scheduler/host_manager.py,cm14:28
johnthetubaguysdague: we should be able to get someone to look, what region are you seeing that?14:28
bauzasndipanov: dansmith: so you say that it never nullify the pci_requests field ?14:28
sdaguejohnthetubaguy: see #openstack-infra, mordred is pinging you there with details14:28
mtaninodims: Thank you for the link.14:28
*** Marga_ has joined #openstack-nova14:28
bauzasndipanov: because of https://github.com/openstack/nova/blob/feef80c1f88cc28f8625b19ebf43b190fae0ca08/nova/pci/request.py#L193 ?14:28
openstackgerritAndrew Laski proposed openstack/nova: Store context in local store after spawn_n  https://review.openstack.org/17129914:29
*** browne has joined #openstack-nova14:29
*** popw has quit IRC14:30
alaskisdague: looks like johnthetubaguy has it, but I can help push if necessary14:31
*** armax has joined #openstack-nova14:31
*** ankit_ag has quit IRC14:32
*** dboik_ has joined #openstack-nova14:32
*** rushiagr is now known as rushiagr_away14:33
*** achanda has joined #openstack-nova14:34
*** emagana has joined #openstack-nova14:36
*** dboik has quit IRC14:36
*** markvoelker has joined #openstack-nova14:36
*** markvoel_ has joined #openstack-nova14:38
*** russellb has quit IRC14:38
ndipanovyes14:38
ndipanovbauzas,14:38
ndipanovthat will always set an object on the instance14:38
ndipanovnow the ObjectList14:38
ndipanovhas __len__ defined14:39
*** hdd has quit IRC14:39
ndipanovmeaning insance.pci_requests would be False14:39
ndipanovin a boolean context14:39
ndipanovbut since we use the completely broken14:40
ndipanovno no no let me rephrase that14:40
ndipanovCOMPLETELY EFFIN BROKEN14:40
ndipanovobj_to_primitive14:40
*** markvoelker_ has quit IRC14:40
bauzasndipanov: I think I understood you, it transforms it into a list of dicts ?14:40
ndipanovit get's converted to {"instance_uuid": UUD} dict14:40
bauzasndipanov: orly?14:40
ndipanovoyeah14:41
*** markvoel_ has quit IRC14:41
ndipanovwhich is Truthy14:41
ndipanovit's just a mess14:41
*** russellb has joined #openstack-nova14:42
*** markvoelker has quit IRC14:42
bauzasndipanov: obj_to_primitive calls the objects primitives too14:42
bauzasndipanov: so that means that something is wrong in there14:42
openstackgerritTimofey Durakov proposed openstack/nova: Fixed nova-network dhcp-hostsfile update during live-migration  https://review.openstack.org/17391314:43
bauzasndipanov: it just flattens the nested objects into dicts with key and flatten value14:43
bauzasndipanov: the main problem I see with that is that obj_to_prim() != db_primitive14:44
*** achanda has quit IRC14:45
*** otter768 has joined #openstack-nova14:46
ndipanovbauzas, well that could be one way to define it14:47
ndipanovbauzas, for InstancePciRequests it would be {'instance_uuid': my_uuid, 'requests': []}14:48
ndipanovwhich is very wrong in the context of an instance list14:48
ndipanover14:48
ndipanovobject list14:48
*** sald has quit IRC14:48
*** dboik_ has quit IRC14:48
bauzasndipanov: well, that's because the model is broken14:48
ndipanovanyway14:49
bauzasndipanov: InstancePCIRequests is considered as one object, not a list14:49
ndipanovacutally yes14:49
*** dboik has joined #openstack-nova14:49
ndipanovwill correct myself14:49
bauzasndipanov: if it was a list of requests, it would be primitived into a list14:49
*** igordcard has quit IRC14:49
ndipanovlol that's another bug14:49
bauzasI mean an ObjectList becomes a list of dicts14:50
ndipanovif it happens to be a ObjectList14:50
ndipanovyes14:50
ndipanovbut if you just have a list of objects (which is a field)14:50
ndipanovthen it would just stay objects14:50
*** igordcard has joined #openstack-nova14:50
bauzasyou mean a nested objectlist as a field ?14:50
*** otter768 has quit IRC14:51
ndipanovbauzas, ListOfObjectsField but on a class that is not a subclass of ObjectList14:52
bauzasndipanov: IMHO https://github.com/openstack/nova/blob/master/nova/objects/instance_pci_requests.py14:52
bauzasndipanov: is wrong14:52
ndipanovwhy is it wrong?14:52
bauzasndipanov: oh no no14:52
bauzasmy bad14:52
ndipanovthen NUMA is wrong since we do the same thing for cells14:52
*** hdd has joined #openstack-nova14:52
bauzasndipanov: no no, the model is good14:53
bauzasndipanov: I missed the nested object as a fieldf14:53
ndipanovso if you put it on an object that is not a list14:53
ndipanovit will happily pass objects from obj_to_pirmitive14:53
*** annegentle has quit IRC14:54
ndipanovso you will have  [<InstancePCiRequest at xxx>] for example14:54
ndipanovnow pass that to the serializer over RPC14:54
bauzasndipanov: mmm14:54
ndipanovit will work because it will find objects and seralize them with their versions and maybe drop stuff14:54
ndipanovwhen it tries to do compat14:55
bauzasndipanov: base.obj_to_primitive() on a InstancePCIRequests object will generate14:55
ndipanova dict with a uuid and a list of OBJECT instances14:55
bauzas{'uuid': 'bla', 'requests': [{'count': 1, 'spec': 'foo'...}']}14:56
ndipanovnope14:56
bauzashttps://github.com/openstack/nova/blob/master/nova/objects/base.py#L901-L90614:57
ndipanovyeah bauzas  I know where it is - it's not how it works14:57
ndipanovpull it up and try it14:57
bauzasndipanov: checking locally14:57
ndipanovit will recursively call itself with a list14:58
ndipanovwhich hits the last branch AKA get's returned as is14:58
*** kmartin has joined #openstack-nova14:58
ndipanovand you can't change that as you break all the codez14:58
ndipanovthat scheduler code actually expects it to work like that14:58
*** rwsu has joined #openstack-nova15:00
ndipanovanyway dansmith https://review.openstack.org/#/c/173394/ I'd much appreciate15:01
dansmithndipanov: when I can15:01
ndipanovdansmith, but like 2015 right? :)15:01
*** jkraj has joined #openstack-nova15:02
ndipanovanyway - back to the other PCI disaster15:02
bauzasndipanov: damn15:03
ndipanovbauzas, nice eh?15:04
ndipanovso when I said - rip it out and burn it FIRST before anything else in the scheduler15:05
ndipanovI was not kidding15:05
bauzasndipanov: yeah, that's not an instance of ObjectListBase, that's just a list...15:05
openstackgerritChris Friesen proposed openstack/nova: libvirt: check qemu version for NUMA & hugepage support  https://review.openstack.org/17078015:05
*** xyang1 has joined #openstack-nova15:05
*** TobiasE has quit IRC15:07
mriedemhuzzah15:07
mriedemcompute manager cleanup_host shuts down the instance events handling15:07
*** thedodd has joined #openstack-nova15:07
mriedemwe need to do the same for virt driver lifecycle events15:07
mriedemeasy peasy15:07
*** belmoreira has quit IRC15:08
*** shyama has quit IRC15:10
*** ijw has joined #openstack-nova15:10
*** shyama has joined #openstack-nova15:11
*** rushiagr_away is now known as rushiagr15:11
*** markvoelker has joined #openstack-nova15:12
*** c0m0 has quit IRC15:13
openstackgerritChris Friesen proposed openstack/nova: libvirt: check qemu version for NUMA & hugepage support  https://review.openstack.org/17078015:13
*** doron_afk is now known as doron15:14
openstackgerritPetrut Lucian proposed openstack/nova: Hyper-V: Nova serial console access support  https://review.openstack.org/14500415:16
*** markvoelker has quit IRC15:16
*** dsanders has joined #openstack-nova15:17
*** sbfox has joined #openstack-nova15:18
*** c0m0 has joined #openstack-nova15:19
openstackgerritPetrut Lucian proposed openstack/nova: Hyper-V: Nova serial console access support  https://review.openstack.org/14500415:20
*** Nikolay_St has quit IRC15:20
*** hdd has quit IRC15:20
*** doron is now known as doron_afk15:20
*** yingjun has joined #openstack-nova15:20
*** yingjun has quit IRC15:22
*** sbfox has quit IRC15:24
*** sbfox has joined #openstack-nova15:25
mriedemcfriesen: are you still waiting on an answer on the pkvm stuff in https://review.openstack.org/#/c/170780/ ?15:25
mriedemfor _has_numa_support?15:25
*** ozialien has joined #openstack-nova15:26
*** VW_ has quit IRC15:26
mriedemcfriesen: if so, i'd maybe leave the arch checks for ppc64 out and risk assume it doesn't work15:26
*** jcoufal_ has joined #openstack-nova15:26
mriedemcfriesen: you know it doesn't work with zkvm and you need the version constraint check on qemu15:26
mriedema separate pkvm patch could come later that adds ppc64 to supported_archs if pkvm does support those15:26
mriedemjgrimm: krtaylor: ^15:26
jgrimmmriedem, agreed15:27
*** jamie_h has quit IRC15:28
*** tonytan4ever has quit IRC15:29
*** jcoufal has quit IRC15:29
*** Marga_ has quit IRC15:30
*** Marga_ has joined #openstack-nova15:30
*** doron_afk has quit IRC15:31
*** tonytan4ever has joined #openstack-nova15:32
*** russellb has quit IRC15:32
*** ajayaa has quit IRC15:34
*** browne has quit IRC15:34
*** sdake has joined #openstack-nova15:35
*** VW_ has joined #openstack-nova15:35
*** thomasem has quit IRC15:35
*** russellb has joined #openstack-nova15:36
*** dboik_ has joined #openstack-nova15:37
openstackgerritPetrut Lucian proposed openstack/nova: Hyper-V: Implement nova rescue  https://review.openstack.org/12715915:38
*** thomasem has joined #openstack-nova15:38
cfriesenmriedem: jgrimm: okay, will respin.15:38
*** Sukhdev has joined #openstack-nova15:38
*** thomasem has quit IRC15:39
mriedemndipanov: just read this https://bugzilla.redhat.com/show_bug.cgi?id=912284 - maybe we should update the config option help for that?15:39
openstackbugzilla.redhat.com bug 912284 in openstack-nova "with resume_guests_state_on_host_boot=True rebooting host leaves VM's in Error state" [High,Closed: errata] - Assigned to beagles15:39
*** sdake_ has joined #openstack-nova15:39
*** thomasem has joined #openstack-nova15:39
mriedemndipanov: i.e. something along the lines of it's racy and might not work, so don't assume things will be happy if, for example, you're taking your compute host down for maintenance15:39
ndipanovmriedem, hmm15:40
*** dboik has quit IRC15:40
ndipanovmriedem, I am trying to think of a case when that option is useful actually15:41
openstackgerritChris Friesen proposed openstack/nova: libvirt: check qemu version for NUMA & hugepage support  https://review.openstack.org/17078015:41
*** matrohon has quit IRC15:42
mriedemndipanov: looking at the libvirt driver and how it's handled, it appears it will only reboot the guest if it's down and the nova db thinks it's power state is running15:42
*** sdake has quit IRC15:42
mriedemndipanov: but the option was added in diablo and races with the lifecycyle event handling added in grizzly15:42
ndipanovmriedem, though this was a long time ago so things might have changed15:42
mriedemndipanov: yeah - i'm pulling some info together for a bug report. i see some things on ask.o.o about this option being set to True and it not really working15:43
mriedemso the config option help doesn't really make it clear that it's not a cure all15:43
ndipanovalso we added some code to try to detect transition states and try to remedy that15:43
ndipanovand I bet this was not tested with it as well15:43
cfriesenmriedem: does it actually race?  I thought the resume guest code ran really early at compute startup15:44
mriedemcfriesen: the race is on shutdown15:44
mriedemlibvirt stops the guests which sends the stopped event to the compute manager which tries to call the stop api on the instance15:44
mriedemwhile the compute service is doing down15:44
mriedemso the instance vm_state/task_state can be wonky wrt the power_state on the hypervisor15:44
cfriesenmriedem: ah, okay.  maybe we should stop nova-compute prior to stopping the guests15:45
*** lpetrut has quit IRC15:45
*** amotoki has joined #openstack-nova15:45
mriedemand you can hit cases where we actually do update the db power state before shutdown so nova thinks the instance is stopped, but when libvirt comes back up and restarts the guests, it sends the started event which nova gets and b/c the nova db thinks the instance should be stopped, it shuts it down15:45
mriedemcfriesen: stopping the guests is handled asynchronously by libvirt15:46
mriedemi'm going to push a change to stop handling lifecycle events from the driver when we're compute service is doing down, like we do with the neutron events listener15:46
cfriesenmriedem: okay, so shutdown nova-compute before telling libvirt to shutdown?15:46
mriedemcfriesen: well, if you do just an os reboot15:46
mriedemthat's not up to you really i guess, unless you are controlling the lifecycle processing of your services on the os15:47
cfriesenmriedem: don't we still have a race if libvirt gets the shutdown signal before nova-compute does?15:48
mriedemanyway, someone was freaking out on me because CONF.resume_guests_state_on_host_boot=True wasn't making their caviar dreams come true15:48
mriedemcfriesen: yeah, possibly15:48
cfriesenmriedem: I work on dedicated stuff...we always control the lifecycle. :)15:48
*** dboik_ has quit IRC15:48
mriedemit probably ultimately comes down to, if you're doing maintenance, plan for it and migrate the instances,15:49
*** dboik has joined #openstack-nova15:49
mriedemif shit crashes, you have to recover by resettting state and then start the instance, something like that15:49
cfriesenmriedem: we had fun trying to get DOR working reasonably15:49
cfriesenwho's in charge of the Intel PCI CI?  It seems to be failing.15:51
mriedembaoli_: ^?15:51
*** garyk has joined #openstack-nova15:51
baoli_mriedem: Hi15:52
ndipanovPaulMurray, there?15:52
ndipanovI found a very interesting issue backporting your patch to stable15:53
openstackgerritChris Friesen proposed openstack/nova: libvirt: check qemu version for NUMA & hugepage support  https://review.openstack.org/17078015:53
cfriesenmriedem: ^ commit message updated with arch info15:53
*** annegentle has joined #openstack-nova15:54
cfriesenbaoli: Intel PCI CI seems to be failing with hardly any logs15:54
cfriesenbaoli_: http://198.175.100.33/170780/6/15:55
PaulMurrayndipanov, hi15:55
PaulMurrayndipanov, whats the issue?15:56
ndipanovhey so... I'm hitting this: http://logs.openstack.org/26/173226/3/check/gate-tempest-dsvm-large-ops/f136941/logs/screen-n-cond.txt.gz?level=INFO15:56
ndipanovand am wondering how xome wi didn't hit that with kilo15:56
*** jwcroppe has quit IRC15:56
PaulMurrayits this: 10000000000015:56
PaulMurraythat number is too big for a db int filed15:57
*** jwcroppe has joined #openstack-nova15:57
PaulMurrayyour wondering how I spotted that :)15:57
ndipanovyeah I know what it is15:57
PaulMurrayoh, ok :(15:57
ndipanovbut what I don't get is how come original patch wasnt hitting this15:57
PaulMurrayI fixed the big number -is it in the same patch?15:58
baoli_cfriesen: you can contact yonglihe_ for that, I think15:58
ndipanovPaulMurray, you did?!15:59
ndipanovshow me :)15:59
PaulMurraytyring to find the patch15:59
*** sdake has joined #openstack-nova15:59
ndipanovPaulMurray, awesome!!15:59
PaulMurraythe number never gets saved before because it is over-ridden by the calculations15:59
PaulMurrayso I changed it to be a sensible number - its disk size and is supposed to be in GB but the test has it in bytes16:00
*** vilobhmm1 has joined #openstack-nova16:00
PaulMurraylooking - hold on16:00
*** unicell1 has joined #openstack-nova16:00
ndipanovPaulMurray, right - I got that16:00
ndipanovand am wondering if that's what we actually want to be doing here as well16:01
ndipanovi.e. create the record with no values and then re-do them16:01
*** Marga_ has quit IRC16:01
*** unicell has quit IRC16:01
PaulMurraythey need a value because the db fields are NOT NULL16:01
*** jwcroppe has quit IRC16:01
ndipanovugh16:01
ndipanovyes16:02
ndipanovlooking at it16:02
*** vilobhmm11 has joined #openstack-nova16:02
PaulMurraywe looked at doing the calculation before saving first time, but it was no different from not doing the patch16:02
ndipanovPaulMurray, exactly16:02
*** sdake_ has quit IRC16:03
*** derekh has quit IRC16:03
*** emagana has quit IRC16:03
bauzasalaski: quick q, still investigating the EC2 problem, do you know when the instance.cell_name is provided ?16:03
*** jistr has quit IRC16:03
*** jistr has joined #openstack-nova16:04
*** vilobhmm1 has quit IRC16:04
*** FL1SK has quit IRC16:04
ndipanovPaulMurray, that's actually kind of bad16:05
*** jlanoux has quit IRC16:05
ndipanovPaulMurray, but if you can dig up the patch that'd be great16:06
mriedemcfriesen: on the qemu version check change, i'm more or less +2, left some comments on how the tests gross me out though - we really need some decoupling in there and move that low-level host.has_min_version testing to test_host.py, but that could be a separate cleanup16:06
dansmithbauzas: so are you good with ndipanov's patch? I'm just starting to look at it...16:07
PaulMurrayndipanov, we had quite a bit of debate about it - don't like it myself, but thats life16:08
bauzasdansmith: you mean the juno backport of PaulMurray ?16:09
bauzasdansmith: yeah16:09
bauzasdansmith: except that the large-ops job is saying no16:09
dansmithbauzas: no the consume_from_instance one16:09
bauzasdansmith: oh16:09
bauzasdansmith: sorry, many stuff on my mind16:09
*** jistr has quit IRC16:09
dansmithbauzas: I missed the discussion between you guys, and thus I don't really understand the problem16:09
* bauzas still has to write a spec16:09
bauzasdansmith: oh16:09
*** emagana has joined #openstack-nova16:10
bauzasdansmith: well, the problem is that base.obj_to_prim() is buggy because a list is not an ObjectListBase :)16:10
*** _gryf is now known as _gryf|afk16:10
ndipanovPaulMurray, well I guess nova compute failing like that is actually pretty bad since there is no easy way for users to remedy it16:10
openstackgerritjichenjc proposed openstack/nova: Catch SnapshotNotFound exception at os-volumes  https://review.openstack.org/17396516:10
bauzasdansmith: so it doesn't primitive it16:10
bauzasdansmith: so yeah, basically, we need that hack IMHO16:10
ndipanovbut not sure what the solution would be other than set all the used ones to 0...16:11
*** jwcroppe has joined #openstack-nova16:11
ndipanov*_used that is16:11
ndipanovdansmith, see my comment inline on the patch16:11
dansmithndipanov: yeah, I've read it16:11
cfriesenmriedem: thanks...I agree that the unit tests are kind of gross.  I basically did the minimum to get things working.16:11
dansmithndipanov: obj_to_primitive is not buggy, it's just that we use it when we shouldn't, yes?16:12
dansmithI mean, it does what it's supposed to do16:12
dansmithwe just keep using it to hack around code that hasn't been converted yet because it's ugly and hard16:12
ndipanovdansmith, well it should have never ever been used on anything that goes over rpc16:12
bauzasdansmith: the real problem is that we primitive the first instance in order to get an instance_props field for the req_spec16:12
*** markvoelker has joined #openstack-nova16:13
*** rushil has quit IRC16:13
ndipanovand req_spec is one of these16:13
mriedemcfriesen: yeah, i understand16:13
bauzasdansmith: instead, we should just trust RPC serialization and go ahead with passing an obj in the spec16:13
*** eliqiao1 has quit IRC16:13
*** tiagogomes has left #openstack-nova16:13
bauzasdansmith: ndipanov: btw. https://review.openstack.org/#/c/173316/16:13
*** dosaboy has quit IRC16:13
ndipanovplus it is pretty buggy - see what happens when an object has a ListOfObjects field and is not an instance of ListBase16:13
bauzasdansmith: ndipanov: ^ RequestSpec object spec again...16:14
*** unicell1 has quit IRC16:14
*** markus_z has quit IRC16:14
*** dosaboy has joined #openstack-nova16:14
ndipanovbauzas, added myself16:14
dansmithndipanov: so, on line 265, if we just changed it to this:16:14
dansmithndipanov: pci_requests = instance.get(pci_requests) or None16:14
bauzasndipanov: cool16:14
dansmithwouldn't that do what we want?16:15
*** jistr has joined #openstack-nova16:15
ndipanovdansmith, no16:15
bauzasndipanov: no16:15
bauzasoop16:15
bauzasdansmith: no16:15
bauzasdansmith: the problem is that this is an object16:15
bauzasnot an empty list or dict16:15
cfriesenProcedural question...I posted a couple of specs at https://review.openstack.org/#/c/168982/ and https://review.openstack.org/#/c/169026/ but have gotten very little feedback.  Is that a sign or is it just early days yet?16:16
dansmithbauzas: you mean we actually have an instance dict with a real object inside it?16:16
bauzascfriesen: eh, wait a couple more :)16:16
*** irenab has quit IRC16:16
bauzasdansmith: exactly16:16
dansmithah, okay16:16
ndipanovdansmith, no16:16
ndipanovwe have an instance dict16:16
*** annegentle has quit IRC16:16
ndipanovthat has a pci_requests field16:16
ndipanovthat is an object16:16
ndipanover16:16
ndipanova dict16:16
ndipanovsuch as16:17
bauzasndipanov: yeah, that's what I said16:17
dansmithhuh?16:17
openstackgerritjichenjc proposed openstack/nova: Catch SnapshotNotFound exception at os-volumes  https://review.openstack.org/17396516:17
bauzas>>> objects.base.obj_to_primitive(pci_mult)16:17
bauzas{'instance_uuid': '48dc327e-4597-4767-8eaf-61e640455799', 'requests': [InstancePCIRequest(alias_name=<?>,count=1,is_new=<?>,request_id=<?>,spec=<?>)]}16:17
dansmithyou two just said different htings16:17
ndipanovthat ^^16:17
ndipanovthat is obj_to_primitive16:17
bauzasso, I was unclear16:17
*** irenab has joined #openstack-nova16:17
*** jistr has quit IRC16:17
bauzasprimitiving InstancePCIRequests makes this16:18
ndipanovand to make matter worse16:18
ndipanovthere is a lot of code that actually relies on this16:18
dansmithokay, what bauzas showed is what I was asking, but ndipanov you said dict of dict16:18
*** arnaud___ has joined #openstack-nova16:18
ndipanovwell this is inside the instance_ref dict16:18
mriedemrussellb: vishy: garyk: pixelb: nova stable cores, can you take a look at this squashed backport? there are several bugs lined up around this racy code going back to at least icehouse: https://review.openstack.org/#/c/163378/16:18
*** dboik_ has joined #openstack-nova16:18
dansmithndipanov: right, that's what I said16:18
mriedemand i have a change on master for kvm that depends on these to backport16:18
ndipanovso it's {... 'pci_requests': that}16:18
dansmithndipanov: it's an instance dict with a non-primitive (real object) element16:19
dansmithwe think it's dicts all the way down, but it's not16:19
bauzasdansmith: that's not the instance dict16:19
ndipanovright16:19
mriedemrussellb: vishy: garyk: pixelb: this is the kvm change i plan on backporting https://review.openstack.org/#/c/172775/16:19
bauzasdansmith: instance['pci_requests'] is that16:19
ndipanovsame happens for any Object that has a ListOfObjectss field16:19
*** markvoelker has quit IRC16:19
dansmithbauzas: yeah16:19
dansmithndipanov: and we're not fixing obj_to_primitive() because why?16:19
*** lpetrut has joined #openstack-nova16:19
alaskibauzas: instance.cell_name is set in instance_update_at_top.16:20
bauzasalaski: then I'm lost :)16:20
ndipanovdansmith, because it changes what goes over RPC16:20
*** dave-mccowan has joined #openstack-nova16:20
ndipanovif we fix it16:20
*** browne has joined #openstack-nova16:20
bauzasalaski: that's around 3 hours I'm following the path, and my eyes are blinking :D16:20
ndipanovfix it without changing scheduler code16:21
dansmithndipanov: so, if I may take a detour:16:21
dansmithndipanov: all this stuff has been broken like a hundred times in the last month16:21
ndipanovyes16:21
ndipanovapprox16:21
dansmithndipanov: why should we continue to fix any of it until we have some functional tests to show that it works?16:21
bauzasdansmith: I think we can safely assume this as a slow price, and fix the obj_to_primitive() stuff on a later patch, because then it could make some side-effect16:21
dansmithI mean really, we're just playing whack-a-mole and it's ridiculous16:21
*** dboik has quit IRC16:22
bauzasdansmith: eh, come playing with cells job16:22
ndipanovdansmith, well because there's companies that pay people outrages salaries to work on this shit16:22
dansmithbauzas: the cells job at least has tests to show when it's working and not16:22
bauzas:)16:22
ndipanovand then we tell them to go screw themselves16:22
ndipanovso I say we take the middle road16:22
bauzasdansmith: just an expression of my frustration to not quickly fix those bugs :)16:22
ndipanovand try to make it not completely broken16:22
ndipanovwhile we agree that it's bad16:22
bauzasagreed16:22
*** emagana has quit IRC16:22
ndipanovand also add tests16:22
bauzaswe need to move carefully with PCI16:23
PaulMurrayndipanov, found it !16:23
ndipanovPaulMurray, \o/16:23
alaskibauzas: okay, I'll work on reproducing locally and see what's going on16:23
dansmithbut this stuff is >1cycle old and it still has so little testing that it's breaking this often16:23
PaulMurrayndipanov, my fix for that big number went away in a rebase because sean landed https://review.openstack.org/#/c/165376/16:23
dansmithso when do we do that?16:23
*** mpavone has quit IRC16:23
ndipanovdansmith, well as I pointed out on one of the reviews that fixes the breakage16:24
bauzasalaski: still continuing to work on, basically looking at the DB API why it doesn't find the same metadata instance16:24
ndipanovof PCI16:24
ndipanovit was actually broken by16:24
ndipanovobject fuckery (as I put it)16:24
PaulMurrayndipanov, the number comes from nova/virt/fake.py #L113 before his change16:24
ndipanovso... the answer is - like my relationship status on FB16:24
bauzasndipanov: I also helped to break the PCI stuff16:24
ndipanov"it's complicated"16:24
alaskibauzas: okay.  that's my big question.  instance.system_metadata = something; instance.save() should work regardles of cell_name being set16:24
bauzasalaski: you got it16:25
PaulMurrayndipanov, my fix just changed the definition to be in GB16:25
*** dave-mccowan has quit IRC16:25
dansmithndipanov: bauzas: breaking it is understandable, but continuing to patch it without tests is not, IMHO16:25
bauzasdansmith: hence my lookaheads to the PCI CI16:25
*** dave-mccowan has joined #openstack-nova16:25
* bauzas wonders if it's grammatically correct16:25
*** welldannit has quit IRC16:25
ndipanovpci + numa is really from February16:26
dansmithbauzas: the problem is, PCI CI is complicated, but I don't think we need full environments to test some of this level of stupid brokenness16:26
ndipanovso it's not really been there for >1 cycle16:26
bauzasdansmith: agreed, it could be identified with mockups16:26
dansmiththere should be reasonable functional tests in our tree to protect against *this* level of broken16:26
bauzasdansmith: high debt IMHO16:27
bauzasdansmith: but sounds like it could be identified as a prio ?16:27
dansmithI surely hope so16:27
bauzasor part of an existing prio, like CI16:28
dansmithon this specific patch, there are no tests that actually verify the change, right? just a change to make it continue to work16:28
dansmithright ndipanov ?16:28
*** ociuhandu has quit IRC16:28
mriedemrussellb: pixelb: garyk: vishy: adam_g: stable/juno is also race failing w/o this patch: https://review.openstack.org/#/c/170295/16:28
ndipanovdansmith, let me check16:29
*** jecarey has quit IRC16:29
*** rajesht has quit IRC16:29
mriedemcan someone just throw me on nova-stable-maint please? :P16:29
mriedemdansmith: ^16:29
ndipanovdansmith, that is correct yes16:29
ndipanovunit tests could have caught this actually16:30
bauzasmriedem: oh man, lots of pain with the cells job related to the Tempest test you're mentioning16:30
*** sudipto has joined #openstack-nova16:30
garykmriedem: done16:31
mriedembauzas: cells shouldn't be running on stable/juno16:31
mriedemgaryk: thanks16:31
bauzasmriedem: yeah but cells were impacted by that Tempest change too16:31
bauzasanyway16:32
*** emagana has joined #openstack-nova16:32
*** annashen has joined #openstack-nova16:32
*** Mike_D_laptop has quit IRC16:32
*** dave-mccowan has quit IRC16:32
*** dave-mccowan has joined #openstack-nova16:33
openstackgerritSudipta Biswas proposed openstack/nova: Allow discrete blocks of online pCPUs for pinning  https://review.openstack.org/17318716:33
*** shaohe_feng has joined #openstack-nova16:33
ndipanovPaulMurray, not sure hwo this patch fixes it16:34
*** Mike_D_laptop has joined #openstack-nova16:36
*** annashen has quit IRC16:37
*** annashen has joined #openstack-nova16:37
sudiptomriedem, can ask for a review: https://review.openstack.org/173187 ?16:38
*** EmilienM is now known as EmilienM|afk16:38
PaulMurrayndipanov, sorry, lost track of converstaion - do you mean you are not sure how sean's patch fixes it?16:39
*** Mike_D_laptop has quit IRC16:40
openstackgerritjichenjc proposed openstack/nova: Catch OverQuota in volume create function  https://review.openstack.org/17398516:40
*** c0m0 has quit IRC16:40
ndipanovyeah16:41
ndipanovPaulMurray, ^16:41
*** Marga_ has joined #openstack-nova16:42
*** arnaud___ has quit IRC16:42
*** arnaud___ has joined #openstack-nova16:43
*** unicell has joined #openstack-nova16:43
*** shyama has quit IRC16:43
*** markvoelker has joined #openstack-nova16:44
PaulMurrayndipanov, nova/virt/fake.py has the driver used in the tests. The resource tracker gets resource values from it in update_available_resources()16:45
PaulMurrayndipanov, sean's patch changes the fake so that initially the values are different - so the big number doesn't occur any more16:45
ndipanovPaulMurray, ah so the big number wasn't hardcoded16:46
*** unicell has quit IRC16:46
*** unicell1 has joined #openstack-nova16:46
ndipanovthis patch makes the tracking actually happen from instances right16:46
*** romainh has left #openstack-nova16:46
ndipanovPaulMurray, never mind I'm blind16:47
ndipanovI need to stop working16:47
ndipanovthanks a lot for this!16:47
PaulMurrayndipanov, before his patch it was hard coded - sean's change makes the fake give values based on instances - yes, your right16:47
*** arnaud___ has quit IRC16:47
*** otter768 has joined #openstack-nova16:47
PaulMurrayndipanov, np - glad to help16:47
cfriesensudipto: is it ever valid to have online_pcpus be empty?16:47
sudiptocfriesen, Good question. I don't know if the system would be functional in that case? (Just wondering)16:48
ndipanovPaulMurray, I'd still prefer to set those to 0 TBH but that's another topic16:48
*** zzzeek has joined #openstack-nova16:48
PaulMurrayndipanov, yes, I agree its not ideal16:49
cfriesensudipto: also, if available_ids is more than online_pcpus that would seem like a functional bug.  The operator has told nova to use certain cpus and then offlined one or more of them.16:49
bauzasalaski: so, now I haven't changed anything and now the problem is not reproduced...16:49
bauzasalaski: I can't no longer get a failure16:49
bauzasalaski: so, that's racy16:50
*** markvoelker has quit IRC16:50
sudiptocfriesen, You mean the validity of the bug itself?16:50
alaskibauzas: yeah.  it went away in Jenkins for a while too16:51
sudiptocfriesen, like available ids is [2, 3, 4] and online_pcpus is [2, 3] coz 4 got offline?16:52
*** otter768 has quit IRC16:52
*** Mike_D_laptop has joined #openstack-nova16:52
sudiptocfriesen, and at that time if nova-compute is restarted, total_pcpus count would be 2. and the older code would kick in (the code which was there before this review) - and throw an invalid error.16:53
cfriesensudipto: whoops...misread it.  what does "available_ids <= online_pcpus" actually do for two lists?16:53
*** irenab has quit IRC16:54
sudiptocfriesen, these are sets - and hence we use the <= to determine if available_ids is a subset equal to the online_pcpus set16:54
cfriesensudipto: for the existing code should we be checking against online_pcpus instead of total_pcpus?16:57
*** raildo has quit IRC16:58
sudiptocfriesen, yeah that's what motivated me to file this bug, but then every host is not meant to support NUMA topology - and hence i had to retain the old behavior as well.16:58
cfriesensudipto: or is self._conn.getInfo()[2] only reporting online cpus?   Also, isn't online/offline separate from NUMA?17:00
*** ozialien has quit IRC17:00
sudiptocfriesen,  self._conn.getInfo()[2] is only returning a number - for the total number of pcpus.17:00
cfriesensudipto: assuming it maps to https://libvirt.org/html/libvirt-libvirt-host.html#virNodeInfo then it's actually reporting the number of "active" CPUs.17:01
sudiptocfriesen, right, it's reporting the "number" of active CPUs - but let's say your pcpu numbers which are online are discrete in nature. For example : [5, 55, 89]17:02
cfriesensudipto: so my concern about total vs online is already dealt with.17:02
*** unicell1 has quit IRC17:02
cfriesensudipto: yes, still need to deal with discontiguous CPUs17:02
*** unicell has joined #openstack-nova17:02
sudiptocfriesen, and let's say you specify vcpus as: 5, 55, 89 in nova.conf, but the pcpus older number would return 3 and it nova-compute would refuse to start...17:03
sudiptocfriesen, yeah17:03
cfriesensudipto: maybe change the commit message to "17:04
cfriesenIf the IDs form a subset17:04
cfriesenof the total available pcpus on the host, pinning is allowed.17:04
cfriesensudipto: bah, stupid paste....I meant "If the IDs form a subste of the online pCPUs on the host..."17:04
sudiptocfriesen, change this line to the one you suggested: " if the17:05
sudiptocpuset ID exceeds the total number of online pcpus.17:05
sudipto"?17:05
*** raildo has joined #openstack-nova17:06
cfriesensudipto: the current line has "...form a subset of the total available pCPUs...", I'm suggesting that you be explicit that you are checking against "online" pCPUs.  (instead of "available")17:07
*** tonytan4ever has quit IRC17:07
sudiptocfriesen, ah yeah - makes sense. Let me change that right away.17:08
*** dboik_ has quit IRC17:08
*** dboik has joined #openstack-nova17:08
*** amotoki has quit IRC17:10
sudiptocfriesen, check now?17:10
sudiptobauzas, I wrote the UTs you asked for.17:11
sudiptohttps://review.openstack.org/#/c/173187/17:11
*** eglynn has quit IRC17:13
*** adalbas has joined #openstack-nova17:13
*** ndipanov has quit IRC17:15
*** sudipto has quit IRC17:16
*** apuimedo has quit IRC17:17
*** deepakcs has joined #openstack-nova17:19
*** lucasagomes has quit IRC17:20
deepakcsHi all, can someone take a look at https://review.openstack.org/168805 and provide reviews pls17:21
deepakcsdansmith, ^17:21
*** jichen has quit IRC17:22
*** aix has quit IRC17:22
*** asselin has joined #openstack-nova17:23
dansmithdeepakcs: you haven't replied to my comments17:24
*** ijw has quit IRC17:25
*** bkopilov has quit IRC17:26
*** ijw has joined #openstack-nova17:26
*** ijw has quit IRC17:27
*** ijw has joined #openstack-nova17:28
*** sudipto has joined #openstack-nova17:29
*** bkopilov has joined #openstack-nova17:30
sudiptobauzas, Not sure if i got disconnected in between, i just wanted to mention to you that I have added the UTs per your comment for the review https://review.openstack.org/#/c/173187/17:32
*** hdd has joined #openstack-nova17:32
*** sahid has quit IRC17:32
*** ajayaa has joined #openstack-nova17:32
deepakcsdansmith, sorry, i didn't get notification for that :)17:34
dansmithdeepakcs: the string freeze concerns are now moot of course17:34
deepakcsdansmith, https://review.openstack.org/#/c/168805/5/nova/virt/libvirt/driver.py (what excatly u refer to by remove whitespace ?)17:34
dansmithdeepakcs: but it's always nice to see if you have comments before begging for reviews in here :)17:34
deepakcsdansmith, yes, i was sure i didn't since somehow the notification didn't come / maybe i missed it. my bad17:35
dansmithdeepakcs: the leading whitespace between the # and the first character.. that's just crazy17:35
*** achanda has joined #openstack-nova17:35
*** tonytan4ever has joined #openstack-nova17:36
deepakcsdansmith, ok, i thought that space was needed, if not, will remove it in next patch17:36
deepakcsdansmith, thanks for ur review, will send next patch soon17:36
*** harlowja_away is now known as harlowja17:36
*** sbfox has quit IRC17:36
*** deepakcs has quit IRC17:37
*** Nic has joined #openstack-nova17:37
*** Sukhdev has quit IRC17:38
*** sudipto has quit IRC17:39
*** bkopilov has quit IRC17:39
*** bkopilov has joined #openstack-nova17:39
*** cbits has joined #openstack-nova17:43
*** bkopilov has quit IRC17:44
*** moshele has quit IRC17:45
*** sbfox has joined #openstack-nova17:46
*** signed8bit has joined #openstack-nova17:47
*** markvoelker has joined #openstack-nova17:47
*** johnthetubaguy is now known as zz_johnthetubagu17:48
*** gszasz has quit IRC17:48
*** marun has joined #openstack-nova17:49
*** Marga_ has quit IRC17:49
*** Marga_ has joined #openstack-nova17:49
*** erlon has joined #openstack-nova17:50
*** jecarey has joined #openstack-nova17:50
*** Longgeek has quit IRC17:51
*** adalbas has quit IRC17:51
*** markvoelker has quit IRC17:52
*** Mike_D_laptop has quit IRC17:52
*** mpaolino has joined #openstack-nova17:52
*** shaohe_feng1 has joined #openstack-nova17:54
*** jecarey has quit IRC17:55
cfriesendeepakcs: I think the suggestion is to remove the multiple spaces, leaving just a single space.17:57
*** annashen has quit IRC17:57
*** shaohe_feng has quit IRC17:57
cfriesenwhoops, he's gone17:57
*** sbfox has quit IRC17:57
*** rfolco has quit IRC17:57
*** andreykurilin has joined #openstack-nova17:58
*** openstackstatus has quit IRC17:58
*** openstackstatus has joined #openstack-nova18:00
*** ChanServ sets mode: +v openstackstatus18:00
*** apuimedo has joined #openstack-nova18:00
*** FL1SK has joined #openstack-nova18:02
*** ozialien has joined #openstack-nova18:02
*** annashen has joined #openstack-nova18:02
*** sbfox has joined #openstack-nova18:03
*** ijw has quit IRC18:03
*** cbits has quit IRC18:03
*** patrickeast has joined #openstack-nova18:03
-openstackstatus- NOTICE: Gerrit has stopped emitting events so Zuul is not alerted to changes. We will restart Gerrit shortly to correct the problem.18:03
*** ChanServ changes topic to "Gerrit has stopped emitting events so Zuul is not alerted to changes. We will restart Gerrit shortly to correct the problem."18:03
*** ijw has joined #openstack-nova18:03
*** signed8bit is now known as signed8bit_ZZZzz18:04
*** annegentle has joined #openstack-nova18:04
*** ijw has quit IRC18:04
*** ijw has joined #openstack-nova18:05
*** signed8bit_ZZZzz is now known as signed8bit18:05
*** mpaolino has quit IRC18:09
*** MVenesio has joined #openstack-nova18:13
mriedemi can't live without gerrit18:13
*** dosaboy has quit IRC18:13
*** rfolco has joined #openstack-nova18:14
*** dosaboy has joined #openstack-nova18:14
*** Marga_ has quit IRC18:15
*** apuimedo has quit IRC18:16
*** VW_ has quit IRC18:18
*** dosaboy has quit IRC18:20
*** dosaboy has joined #openstack-nova18:21
*** EmilienM|afk is now known as EmilienM18:22
*** dosaboy has quit IRC18:22
*** dosaboy has joined #openstack-nova18:24
*** dosaboy has quit IRC18:24
*** dosaboy has joined #openstack-nova18:24
*** rajesht has joined #openstack-nova18:26
*** tonytan4ever has quit IRC18:26
*** ChanServ changes topic to "This channel is for Nova development. For support of Nova deployments, please use #openstack. -=- master is open for Lemming development"18:26
-openstackstatus- NOTICE: Gerrit has been restarted. New patches, approvals, and rechecks between 17:30 and 18:20 UTC may have been missed by Zuul and will need rechecks or new approvals added.18:26
*** signed8bit is now known as signed8bit_ZZZzz18:28
*** Nikolay_St has joined #openstack-nova18:30
openstackgerritMichael Bayer proposed openstack/nova: Add an index to virtual_interfaces.uuid  https://review.openstack.org/15424318:32
*** annegentle has quit IRC18:35
*** annegentle has joined #openstack-nova18:35
openstackgerritMichael Bayer proposed openstack/nova: Add an index to virtual_interfaces.uuid  https://review.openstack.org/17401818:35
*** eharney has quit IRC18:36
*** andreykurilin has quit IRC18:36
openstackgerritMichael Bayer proposed openstack/nova: Add an index to virtual_interfaces.uuid  https://review.openstack.org/17401818:37
*** andreykurilin has joined #openstack-nova18:40
*** rajesht has quit IRC18:40
*** matrohon has joined #openstack-nova18:42
*** tonytan4ever has joined #openstack-nova18:43
*** jcoufal_ has quit IRC18:45
*** rushil has joined #openstack-nova18:46
*** Marga_ has joined #openstack-nova18:46
*** otter768 has joined #openstack-nova18:48
*** sbfox has quit IRC18:49
*** Nic1 has joined #openstack-nova18:51
*** Marga_ has quit IRC18:51
*** Nic has quit IRC18:51
*** andreykurilin has quit IRC18:52
*** otter768 has quit IRC18:53
*** hdd has quit IRC18:53
*** matrohon has quit IRC18:54
*** baoli_ has quit IRC18:56
*** ijw has quit IRC18:57
*** VW_ has joined #openstack-nova19:00
*** pixelb has quit IRC19:01
*** samueldmq has joined #openstack-nova19:02
openstackgerritMichael Bayer proposed openstack/nova: Add an index to virtual_interfaces.uuid  https://review.openstack.org/15424319:03
samueldmqhi, how long approximately nova unit tests take to run ?19:04
*** annashen has quit IRC19:04
*** eharney has joined #openstack-nova19:04
*** jichen has joined #openstack-nova19:06
*** matrohon has joined #openstack-nova19:07
*** ijw has joined #openstack-nova19:08
dansmithsamueldmq: depends entirely on your machine19:09
dansmithi.e. could be 5 minutes and could be 3019:09
*** ijw has quit IRC19:13
*** stevemar has joined #openstack-nova19:17
*** jaypipes has quit IRC19:18
*** gszasz has joined #openstack-nova19:20
*** jaypipes has joined #openstack-nova19:21
*** jwcroppe has quit IRC19:21
*** jwcroppe has joined #openstack-nova19:22
*** dboik_ has joined #openstack-nova19:25
*** jwcroppe has quit IRC19:26
*** Nikolay_St has quit IRC19:27
*** ijw has joined #openstack-nova19:28
*** dboik has quit IRC19:29
*** Nikolay_St has joined #openstack-nova19:29
*** oro has joined #openstack-nova19:30
*** david-lyle has joined #openstack-nova19:30
*** ijw_ has joined #openstack-nova19:30
*** VW_ has quit IRC19:30
*** armax has quit IRC19:31
samueldmqdansmith, yeah I know, but for example, for you, how long it takes ?19:32
dansmithsamueldmq: it takes like 300s for me right now, IIRC19:32
*** ijw has quit IRC19:32
samueldmqdansmith, k, I am asking because I get curious after reading a post from sdague at https://dague.net/19:33
samueldmqdansmith, 'testr discovery takes 20 - 30s on the Nova source tree'19:33
sdaguesamueldmq: I'm at about 2 minutes on my box19:33
*** ijw has joined #openstack-nova19:33
sdaguemaybe 319:33
* dansmith does a run19:33
samueldmqdansmith, k thx19:33
samueldmqsdague, hi - I was wondering how useful/appreciated a tool like https://folding.stanford.edu/ would be for openstack19:34
*** VW_ has joined #openstack-nova19:34
sdaguesamueldmq: in what context?19:34
samueldmqsdague, basically people register and their unit tests run distributed on all the registered machines19:34
sdaguesamueldmq: we already have a giant CI pipeline19:35
samueldmqsdague, unit tests which are already run in parallel19:35
sdaguehttp://status.openstack.org/zuul/19:35
samueldmqsdague, yeah but people run tests locally some times before submitting to jenkins, right?19:35
*** Hosam has joined #openstack-nova19:35
sdaguesamueldmq: sure19:35
sdaguedo you expect they would get faster than 5 minute turn around from that?19:36
*** oro has quit IRC19:36
samueldmqsdague, and that should be fun: "be part of the infra, yes, yourself"19:36
dansmithyeah, I'm at 3.5 minutes on my quadcore box19:36
samueldmqsdague, yes I do think19:36
samueldmqsdague, registered ppl would have the .tox env up to date19:36
*** ijw_ has quit IRC19:36
samueldmqsdague, each computer would get a list of tests to run, and return the results19:37
sdaguesamueldmq: it seems like a lot of effort, for not a ton of gain. But feel free to try :)19:37
samueldmqsdague, yeah, actually I am not convinced it's worth it19:37
samueldmqsdague, but I am sure it would bring fun :p19:37
samueldmqsdague, maybe a poc, I will mull it a bit more19:37
*** signed8bit_ZZZzz is now known as signed8bit19:38
samueldmqsdague, thanks!19:38
*** signed8bit is now known as signed8bit_ZZZzz19:39
*** ijw has quit IRC19:39
dansmiththat 3.5 minutes is with one test taking 120s and two taking 60s19:39
dansmithyikes19:39
*** oro has joined #openstack-nova19:40
sdagueoh, you must have the dbs configured correctly19:40
samueldmqdansmith, one single test taking 120s, did I misread?19:40
dansmithnova.tests.unit.compute.test_compute_mgr.ComputeManagerUnitTestCase.test_swap_volume_volume_api_usage19:41
dansmithtakes 120s ^19:41
dansmithsdague: eh?19:41
samueldmqoO19:41
dansmithsdague: *correctly* ?19:41
sdagueoh, I assumed it was the mysql tests19:41
dansmiththat's a unit unit test, shouldn't be using db19:41
dansmithno19:41
sdaguethey take real time19:41
dansmiththe first db test is 14s19:41
dansmiths/first/longest/19:41
sdagueright, but there are the oportunistic migration tests with real databases19:41
sdaguethose take longer iirc19:42
dansmithyeah, not those19:42
dansmithright19:42
mriedemtest_compute_mgr.ComputeManagerUnitTestCase is NoDBTestCase is the point19:42
mriedemshouldn't take 2 minutes19:42
sdaguebut yeh, nova.tests.unit.compute.test_compute_mgr.ComputeManagerUnitTestCase.test_swap_volume_volume_api_usage seems wrong19:42
mriedemdid someone throw a sleep in :)19:42
sdaguebut, I'm stepping out for a few19:42
samueldmqmriedem, ++ haha19:42
dansmiththe error paths are taking 60s each19:47
*** alex_xu has quit IRC19:48
*** alex_xu has joined #openstack-nova19:49
*** markvoelker has joined #openstack-nova19:50
dansmithah, I bet I got it19:50
*** ozialien has quit IRC19:50
*** ijw has joined #openstack-nova19:50
*** kmartin has quit IRC19:51
*** jwcroppe has joined #openstack-nova19:51
dansmithhmm, maybe not19:51
*** rushil has quit IRC19:52
*** jwcroppe has quit IRC19:53
*** bkopilov has joined #openstack-nova19:54
*** markvoelker has quit IRC19:55
* mriedem runs it locally too19:57
mriedemthe test is scary to look at19:57
dansmithmriedem: I've almost got it licked19:57
*** ajayaa has quit IRC19:58
mriedemhmm, rpc timeout?19:58
mriedemignored rpc timeout?19:58
mriedemtwo of them19:58
*** jichen has quit IRC19:58
dansmithyeah19:59
mriedemnice19:59
dansmithpatch in a sec :)19:59
mriedemback in the day we talked about mocking out conductor from within test_compute_mgr to blow up if you got to conductor from those tests19:59
*** jichen has joined #openstack-nova19:59
dimsdansmith: that V4Proxy, one more bug showed up - https://review.openstack.org/#/c/173897/ possible fix19:59
openstackgerritMatt Riedemann proposed openstack/nova: compute: stop handling virt lifecycle events in cleanup_host()  https://review.openstack.org/17406920:00
dansmithman, I suck20:00
dansmithon the upside, this test used to take 120s and now takes 0.15s :)20:00
*** smccully has quit IRC20:01
dimshaha20:01
*** oro has quit IRC20:01
mriedemdims: ah, the decorator could probably also be fixed20:01
mriedemin how it normalizes the args/kwargs into a dict20:02
mriedemi had to do that in @reverts_task_state20:02
*** Marga_ has joined #openstack-nova20:02
openstackgerritDan Smith proposed openstack/nova: Fix test_swap_volume_api_usage()  https://review.openstack.org/17407320:03
dansmithmerge that sumbitch ^ !20:03
*** nkrinner has joined #openstack-nova20:03
mriedemdims: left a comment20:04
*** annashen has joined #openstack-nova20:04
*** rushiagr is now known as rushiagr_away20:06
*** jwcroppe has joined #openstack-nova20:07
*** annashen has quit IRC20:08
*** jwcroppe has quit IRC20:08
*** annashen has joined #openstack-nova20:08
*** jecarey has joined #openstack-nova20:08
*** sbfox has joined #openstack-nova20:08
dansmithwell, that saved like 15 seconds off my runtime20:09
*** ayoung has joined #openstack-nova20:12
*** dave-mccowan has quit IRC20:12
ayoungDid we really leave the network specification off the common cli params?20:12
ayoung$ openstack server create   --flavor m1.medium   --image "fedora-21-atomic" --key-name ayoung-pubkey  ayoung-test  --security-group default20:12
ayoungERROR: openstack Multiple possible networks found, use a Network ID to be more specific. (HTTP 400) (Request-ID: req-f16e86d0-877b-4d73-947e-712422040873)20:12
ayoungand yet...no reference to network id in the --help string?20:12
ayoungdims, you ever done this?20:13
*** dave-mccowan has joined #openstack-nova20:13
dimsayoung: never used the openstack command to boot if that's what you are asking :)20:14
ayoungis that what --nic are for?20:14
samueldmqdansmith, nice, 0.15 s :)20:14
ayoungdims, yes that is what I am asking, but only cuz I see you and know you and don't want to address an empty room20:14
openstackgerritDan Smith proposed openstack/nova: Fix test_attach_interface_failure()  https://review.openstack.org/17408020:15
openstackgerritDan Smith proposed openstack/nova: Fix test_set_admin_password_bad_state()  https://review.openstack.org/17408120:15
dansmithsamueldmq: two more ^^20:15
dimsayoung: ack, looking one sec20:15
dansmithfor a total of 240s of time back20:15
ayoungdims, think I got it20:15
ayoungopenstack server create   --flavor m1.medium   --image "fedora-21-atomic" --key-name ayoung-pubkey  ayoung-test  --security-group default  --nic net-id=63258623-1fd5-497c-b62d-e0651e03bdca20:15
ayoungthat created something anyway20:16
samueldmqdansmith, nice, I'll take a look, thanks :)20:16
dimsayoung: haha :)20:16
*** rushil has joined #openstack-nova20:16
*** jecarey has quit IRC20:17
*** jecarey has joined #openstack-nova20:18
dimsayoung: looking through, you can specify net-id or port-id20:20
ayoungdims, so I was doing this by trial and erro.  I started by running openstack server create, and filling in the params, just like the N00Bi3 I am20:21
ayoungand the error message didn't say nothing about ports20:21
ayounglooking at the help string,  I can see20:22
dimsayoung: am still trying to figure out how to get "-h" to spit out the help for --nic20:22
ayoung --nic <nic-config-string>20:22
ayoung                        Specify NIC configuration (optional extension)20:22
ayoungopenstack help server create20:22
ayoungI was able to guess the format for that param from the old nova cli20:23
ayoung nova boot --flavor m1.tiny --image cirros-0.3.3-x86_64 --nic net-id=DEMO_NET_ID \20:24
ayoung  --security-group default --key-name demo-key demo-instance120:24
*** rushiagr_away is now known as rushiagr20:24
dimsright20:25
*** kmartin has joined #openstack-nova20:25
*** dboik_ has quit IRC20:26
*** dboik has joined #openstack-nova20:26
mriedemdansmith: +2 on those but someone will probably just add another test later that reintroduces the problem20:27
mriedemi'd still like to just mock out self.compute.conductor_api globally in test_compute_mgr to blow up if not mocked specifically for a test case20:27
dansmithyeah, I'm not sure hans' use_local=True is the right thing to do there etiher20:27
dansmithright, I think I'd prefer that20:28
dansmithhave you ever tried to see what might fail?20:28
*** hdd has joined #openstack-nova20:28
dansmithreplacing it with a big magicmock would let you easily override one call that you want to do a thing20:28
dansmithi.e. maybe it doesn't need to blow up20:28
mriedemself.compute.conductor_api = mock.Mock(side_effect=test.TestingException('f u'))?20:28
*** dboik has quit IRC20:28
mriedemi'd have to test it quick20:29
*** VW_ has quit IRC20:29
dansmithI guess that works since it's private20:29
*** dboik has joined #openstack-nova20:29
*** baoli has joined #openstack-nova20:30
mriedemdansmith: http://paste.openstack.org/show/204037/20:32
mriedemthat works on that swap volume test20:32
mriedemit takes .153 seocnds20:32
*** Nic1 has quit IRC20:32
mriedemrunning the full class20:33
dansmithit will there because it throws away any exception that it hits there20:33
dansmithyeah20:33
dansmithI still think making it blow up is probably not necessary20:33
dimsayoung: https://review.openstack.org/17409120:33
*** VW_ has joined #openstack-nova20:33
*** Mike_D_laptop has joined #openstack-nova20:33
mriedemdansmith: all other tests pass in the test class20:33
dansmithif you expect something back, then getting back the resulting MagicMock from any call should make you explode20:33
ayoungdims, has anyone told you today that you are awesome?20:33
ayoungNo?20:33
ayoungThen let me be the first.20:33
dansmithmriedem: can you try without making it explode?20:34
dansmithmriedem: actually, that's probably wrong20:34
ayoungdims, http://paste.fedoraproject.org/211444/91300841/20:34
dansmithmriedem: that will only explode if you call the conductor_api as a callable20:35
ayoung:)20:35
dansmithmriedem: so I think you're doing what I was asking :)20:35
dansmithmriedem: if you want to make it explode, you should do something like this:20:35
mriedemdansmith: runs the same as just a mock w/o the side_effect20:35
dansmithright20:35
dansmithit needs to be something like:20:35
dansmithm = mock.MagicMock()20:36
mriedemshit, you could just make it None20:36
mriedemif you wanted it to explode :)20:36
mriedemm.callable = False20:36
dansmithself.conductor_api = m.__getattr__.return_value.side_effect = Foo20:36
mriedemactually20:36
mriedemself.compute.conductor_api = mock.NonCallableMock()20:36
mriedembam20:36
dansmiththe reason I'm asking is because presumably we could want to actually check that one of those methods is called20:37
mriedemyeah, idk, i think i'm moving on :)20:37
dansmithmriedem: NonCallableMock doesn't make it explode20:38
mriedemyeah, i know20:38
mriedemnow20:38
dansmithhah20:38
*** tonytan4ever has quit IRC20:38
mriedemi have crazy donut sugar energy and running ADHD20:38
dansmithlol20:38
samueldmqdansmith, well, that saved ~100 s for me20:39
dansmithsamueldmq: then you have a slow computer :)20:39
dansmithsamueldmq: but glad to hear it :)20:39
samueldmqdansmith, actually I am on a quad-core 20gb ram workstation :p20:41
dansmiththen you're doing something very wrong20:41
samueldmqdansmith, don't know why it's taking so long20:41
dansmithmy 195s runs are coming from a 16GB quad i720:41
*** stevemar has quit IRC20:41
dansmithsamueldmq: try nuking .testrepository20:42
*** vladikr has quit IRC20:42
mriedemwas going to say that20:42
samueldmqdansmith, hmm, so .. I cloned nova code, then tox -e py2720:42
dansmithit shits its own bed now and then and will cause single-threaded runs20:42
mriedemi was having slow unit test runs before and a big .testrepository was something someone pointed out20:42
mriedembut i don't think it helped me20:42
samueldmqdansmith, ran it again and get 362 s  ... got your patches and then 288 s20:42
dansmithsamueldmq: it takes a couple runs to get the optimal ordering, yeah20:42
dansmithsamueldmq: is yours quad with HT?20:43
dansmithsamueldmq: intel or AMD?20:43
samueldmqdansmith, let me check20:43
dansmithmine is quad i7 with HT, so eight threads20:43
dansmiththe closer to 240s that those patches save, the more linear your workload is being run20:44
dansmithso 100s would make sense for only four threads I guess20:44
*** gyee has joined #openstack-nova20:44
*** gyee has quit IRC20:44
dansmithacross eight, it's not much gain for me20:44
samueldmqdansmith, yeah, intel .. quad-core Intel(R) Xeon(R) CPU E3-1225 v3 @ 3.20GHz20:45
*** jichen has quit IRC20:45
samueldmqdansmith, maybe I need more runs to get the optimal ordering ?20:45
mriedemdansmith: btw, what do you think about this? https://review.openstack.org/#/c/174069/20:45
mriedempretty simple20:45
dansmithsamueldmq: should only take a few20:45
dansmithsamueldmq: that is only four threads20:46
dansmithsamueldmq: and based on core2 I think20:46
samueldmqdansmith, k ... I will re-run to see what happens :)20:46
samueldmqdansmith, note that I am not a nova guy .. I am just curious about this20:46
dansmithso definitely going to be slower20:46
samueldmqdansmith, I am mostly on keystone side20:47
dansmithsamueldmq: I have a machine with two of those procs in it (so 8 cores) and it runs only slightly faster than my i7 quad w/HT20:47
*** belmoreira has joined #openstack-nova20:47
samueldmqdansmith, hmm, so why ?20:47
samueldmqdansmith, shared memory is the bottleneck?20:47
*** jecarey has quit IRC20:47
dansmithsamueldmq: no, it's an older proc20:48
*** baoli has quit IRC20:48
*** oro has joined #openstack-nova20:49
*** baoli has joined #openstack-nova20:49
*** otter768 has joined #openstack-nova20:49
*** thedodd has quit IRC20:49
samueldmqdansmith, btw, what is missing for nova side to support keystone v3?20:50
samueldmqdansmith, someone to work on it ?20:50
dansmithsamueldmq: I dunno, I'm not to the right person to ask20:50
dansmithI think jogo might know more20:50
*** dboik_ has joined #openstack-nova20:51
samueldmqjogo, you around ? ^20:51
mriedemdid we release kilo rc1 as kilo 2015.1? no rc2? why is there a stable/kilo now?20:52
mriedemor just not doing proposed branches anymore?20:52
mriedemdhellmann: ^?20:52
*** otter768 has quit IRC20:54
*** dboik has quit IRC20:55
dhellmannmriedem: we've had to rename proposed/kilo to stable/kilo to make some of the tools work properly. We have not yet released RC2, though. ttx will be describing this in more detail on the ML tomorrow20:56
*** gszasz has quit IRC20:56
*** rushil has quit IRC20:57
mriedemlike requirements sync20:58
*** Mike_D_laptop has quit IRC21:00
*** raildo has quit IRC21:00
*** gyee has joined #openstack-nova21:00
*** aysyd has quit IRC21:05
*** Marga_ has quit IRC21:05
samueldmqdansmith, jogo, gotta go now, will be back later to ask about keystone v3 support :)21:07
*** ZZelle has quit IRC21:07
*** mwagner_lap has quit IRC21:08
*** jecarey has joined #openstack-nova21:08
*** matrohon has quit IRC21:09
*** jwcroppe has joined #openstack-nova21:10
*** Marga_ has joined #openstack-nova21:10
*** jwcroppe has quit IRC21:10
*** dprince has quit IRC21:12
*** Sukhdev has joined #openstack-nova21:13
*** apuimedo has joined #openstack-nova21:15
*** rfolco has quit IRC21:15
*** jkraj has quit IRC21:16
jogosamueldmq: AFAIk nothing is missing for nova keystone v3 support21:16
morganfainbergjogo, we need a way to run devstack w/o v2 enabled21:16
morganfainbergjogo, and a way to turn off v2 checks in tempest... then we will see *what* breaks. I expect every service to have minor errors21:17
morganfainbergjogo, on the short list to hit as soon as we're past release21:17
morganfainbergjogo, but nova shouldn't care v2 or v3 at this point afaik21:17
morganfainbergsamueldmq, ^ cc21:18
*** Marga_ has quit IRC21:19
*** Marga_ has joined #openstack-nova21:19
jogomorganfainberg: good idea, will we make devstack gate default to keystone v3 before the summit?21:22
morganfainbergjogo, default? maaaaybe21:23
morganfainbergavailable: likely21:23
jogothat is a good start21:23
*** Vek has quit IRC21:24
*** rushiagr is now known as rushiagr_away21:24
samueldmqmorganfainberg, jogo nice, makes sense21:24
jogosamueldmq: so if you find any issues please file bugs!21:25
*** andreykurilin has joined #openstack-nova21:25
jogosamueldmq: AFAIK the big thing is nova doesn't use domain scoped tokens21:25
jogoso if your token is domain scoped things should just error21:25
*** dboik_ has quit IRC21:25
*** dboik has joined #openstack-nova21:26
samueldmqjogo, ++21:26
morganfainbergjogo, you get a weird error in nova about not being in the project21:26
morganfainbergbut yes it does21:26
*** dave-mcc_ has joined #openstack-nova21:28
samueldmqjogo, I will sync up with morganfainberg the plan to get the devstack running and then see the errors21:28
samueldmqjogo, nova is a good starting point21:28
*** nkrinner has quit IRC21:28
samueldmqI think most of the things that will break are due to code that is hard-coded for v221:29
samueldmqmorganfainberg, ^right?21:29
*** lpetrut has quit IRC21:29
morganfainbergsamueldmq, yes21:30
*** dave-mccowan has quit IRC21:30
samueldmqnice, need to go now, talk to you later21:31
samueldmqmorganfainberg, jogo thanks21:31
*** busterswt has quit IRC21:32
*** achanda has quit IRC21:34
*** tjones1 has joined #openstack-nova21:34
*** jwcroppe has joined #openstack-nova21:36
*** achanda has joined #openstack-nova21:37
*** achanda has quit IRC21:37
cfriesenbauzas: you on?21:38
*** achanda has joined #openstack-nova21:38
bauzascfriesen: still up yeah21:38
cfriesenbauzas: running into an issue with _filter_pools_for_numa_cells...noticed that you touched it somewhat recently.  you know anything about that or who I should pester21:39
*** armax has joined #openstack-nova21:40
cfriesenbauzas: or at least you touched the pci/stats.py file. :)21:41
bauzascfriesen: oh yeah, because of an issue I had21:41
cfriesenbauzas: okay, looks like author of code is Przemyslaw Czesnowicz21:42
bauzascfriesen: what's the problem, if I can help ?21:42
cfriesenbauzas: well, it's calling utils.pci_device_prop_match(), but it appears that the pci_dev specifies the numa node as a string, but the specs specifies numa node as an int21:43
cfriesenbauzas: so they don't compare properly21:43
*** tjones1 has quit IRC21:44
bauzascfriesen: I pass21:46
*** dims_ has joined #openstack-nova21:46
cfriesenbauzas: :)21:46
*** jamielennox|away is now known as jamielennox21:46
bauzascfriesen: ndipanov could help but he's offline21:46
*** andreykurilin has quit IRC21:46
bauzascfriesen: I don't know the IRC nick of Przemyslaw21:47
*** annegentle has quit IRC21:47
*** tjones1 has joined #openstack-nova21:48
*** tjones1 has left #openstack-nova21:48
*** dims has quit IRC21:48
*** mwagner_lap has joined #openstack-nova21:48
cfriesenbauzas: will keep digging.  wondering if it has anything to do with the change you made...it used to do a jsonutils.loads(stats) but you changed it to call to_dict()21:50
bauzasfor the stats ?21:50
cfriesenbauzas: __init__() for PciDeviceStats writes self.pools21:51
*** jecarey has quit IRC21:51
bauzascfriesen: yeah, because I objectified some bits in the API21:51
cfriesenbauzas: so we're seeing pci_dev: {'count': 2, u'numa_node': u'0', 'vendor_id': u'8086', u'physical_network': u'group0-data0', 'product_id': u'10ed'}21:51
*** annegentle has joined #openstack-nova21:52
*** dboik_ has joined #openstack-nova21:52
cfriesenbauzas: wondering if all those values should actually be ints and not unicode21:52
bauzascfriesen: what says the object ?21:53
*** vilobhmm11 has quit IRC21:53
*** tjones2 has joined #openstack-nova21:53
*** markvoelker has joined #openstack-nova21:53
*** tjones2 has left #openstack-nova21:54
*** sbfox has quit IRC21:54
*** VW_ has quit IRC21:55
*** irenab has joined #openstack-nova21:55
cfriesenbauzas: ah, okay.  PciDevicePool shows product/vendor as strings.  where's the numa node coming from?21:55
*** pixelb has joined #openstack-nova21:56
*** dboik has quit IRC21:56
bauzascfriesen: just to explain why I modified this, that's because the compute api proxy was changed to get the compute_nodes using the object method21:57
*** dboik_ has quit IRC21:57
bauzasso the nested pci_device_pool key was no longer a raw pci_stats but rather something objectified21:57
*** markvoelker has quit IRC21:58
bauzasin order to not change more than what was needed, I had to primitive that/these pci objects into something which was the opposite of from_pci_stats21:58
flwanggaryk: ping21:58
bauzascfriesen: hence the addition of to_dict()21:59
flwanggaryk: adam_g: could you pls review https://review.openstack.org/#/c/168759/ ?21:59
*** sbfox has joined #openstack-nova22:01
cfriesenbauzas: okay. will keep digging22:02
*** annegentle has quit IRC22:03
*** patrickeast has quit IRC22:04
*** artom has quit IRC22:05
*** tjones1 has joined #openstack-nova22:07
*** neelashah has quit IRC22:08
*** MVenesio has quit IRC22:09
*** hdd has quit IRC22:10
*** tjones1 has quit IRC22:12
openstackgerritBelmiro Moreira proposed openstack/nova: No disable reason defined for new services  https://review.openstack.org/13664522:14
*** yamahata has joined #openstack-nova22:14
*** ijw has quit IRC22:18
*** belmoreira has quit IRC22:18
*** ijw has joined #openstack-nova22:20
*** VW_ has joined #openstack-nova22:20
*** annegentle has joined #openstack-nova22:20
*** patrickeast has joined #openstack-nova22:21
*** VW__ has joined #openstack-nova22:22
*** VW_ has quit IRC22:22
*** burt has quit IRC22:24
*** annegentle has quit IRC22:24
*** dboik has joined #openstack-nova22:26
*** dboik_ has joined #openstack-nova22:27
*** tjones1 has joined #openstack-nova22:28
*** ijw has quit IRC22:30
*** annashen has quit IRC22:30
*** dboik has quit IRC22:31
*** annashen has joined #openstack-nova22:31
*** tjones1 has quit IRC22:33
*** annegentle has joined #openstack-nova22:36
*** jecarey has joined #openstack-nova22:36
*** mriedem has quit IRC22:38
*** tjones1 has joined #openstack-nova22:39
*** annegentle has quit IRC22:41
*** VW__ has quit IRC22:41
*** jecarey has quit IRC22:41
*** tjones1 has quit IRC22:46
*** tjones1 has joined #openstack-nova22:46
*** jwcroppe has quit IRC22:48
*** achanda has quit IRC22:48
*** patrickeast has quit IRC22:48
*** otter768 has joined #openstack-nova22:50
openstackgerritTracy Jones proposed openstack/nova: Cleanup of compute api reboot method  https://review.openstack.org/12742722:50
*** Marga_ has quit IRC22:51
*** markvoelker_ has joined #openstack-nova22:53
*** otter768 has quit IRC22:54
openstackgerritTracy Jones proposed openstack/nova: Cleanup of compute api reboot method  https://review.openstack.org/12742722:56
*** baoli has quit IRC22:57
*** achanda has joined #openstack-nova22:58
*** baoli has joined #openstack-nova22:58
*** apuimedo has quit IRC22:59
*** oro has quit IRC22:59
openstackgerritTracy Jones proposed openstack/nova: Cleanup of compute api reboot method  https://review.openstack.org/12742723:00
*** erlon has quit IRC23:01
*** zzzeek has quit IRC23:01
*** baoli has quit IRC23:03
*** Marga_ has joined #openstack-nova23:03
*** erkules_ is now known as erkules23:03
*** hemna is now known as hemnafk23:05
openstackgerritAlex Xu proposed openstack/nova: Update rpc version aliases for kilo  https://review.openstack.org/17414823:06
*** jaypipes has quit IRC23:08
*** Sukhdev has quit IRC23:12
*** Marga_ has quit IRC23:13
*** tjones1 has left #openstack-nova23:15
*** otter768 has joined #openstack-nova23:16
*** patrickeast has joined #openstack-nova23:16
*** irenab has quit IRC23:17
*** asettle has quit IRC23:19
*** Hosam has quit IRC23:19
*** Vek has joined #openstack-nova23:20
*** annashen has quit IRC23:21
*** jaypipes has joined #openstack-nova23:21
*** Marga_ has joined #openstack-nova23:23
openstackgerritAlex Xu proposed openstack/nova: Add rpc client side version control for conductor task API  https://review.openstack.org/17415223:24
*** tjones1 has joined #openstack-nova23:28
*** jwcroppe has joined #openstack-nova23:30
*** Madkiss has quit IRC23:31
*** Madkiss_ has joined #openstack-nova23:31
*** Madkiss_ is now known as Madkiss23:31
*** armax_ has joined #openstack-nova23:32
*** tjones1 has quit IRC23:33
*** promulo__ has joined #openstack-nova23:33
*** tjones1 has joined #openstack-nova23:33
*** mestery_ has joined #openstack-nova23:33
*** tteggel_ has joined #openstack-nova23:34
*** kmartin_ has joined #openstack-nova23:34
*** aloga_ has joined #openstack-nova23:35
*** francois has joined #openstack-nova23:35
*** frickler_ has joined #openstack-nova23:35
*** HenryG_ has joined #openstack-nova23:35
*** triggerz_ has joined #openstack-nova23:35
*** salv-orl_ has joined #openstack-nova23:36
*** luv has quit IRC23:38
*** mdbooth has quit IRC23:38
*** aloga has quit IRC23:38
*** kmartin has quit IRC23:38
*** bkopilov has quit IRC23:38
*** HenryG has quit IRC23:38
*** triggerz has quit IRC23:38
*** luv_ has joined #openstack-nova23:38
*** mdbooth_ has joined #openstack-nova23:38
*** luv_ is now known as luv23:38
*** bkopilov has joined #openstack-nova23:38
*** lan_ has joined #openstack-nova23:38
*** cburgess_ has joined #openstack-nova23:38
*** mdbooth_ is now known as mdbooth23:38
*** markvoelker has joined #openstack-nova23:39
*** rpodolyaka has quit IRC23:39
*** jesusaurus has quit IRC23:39
*** francois1 has quit IRC23:39
*** armax has quit IRC23:39
*** salv-orlando has quit IRC23:39
*** lan has quit IRC23:39
*** promulo_ has quit IRC23:39
*** heyongli has quit IRC23:39
*** frickler has quit IRC23:39
*** mestery has quit IRC23:39
*** tteggel has quit IRC23:39
*** cburgess has quit IRC23:39
*** heyongli has joined #openstack-nova23:39
*** rpodolyaka has joined #openstack-nova23:39
*** heyongli has quit IRC23:39
*** heyongli has joined #openstack-nova23:39
*** armax_ is now known as armax23:39
*** markvoelker_ has quit IRC23:40
*** jesusaurus has joined #openstack-nova23:40
*** markvoelker has quit IRC23:40
*** markvoelker has joined #openstack-nova23:40
*** markvoelker_ has joined #openstack-nova23:41
*** emagana has quit IRC23:43
*** tjones1 has left #openstack-nova23:43
*** markvoelker has quit IRC23:45
*** tjones1 has joined #openstack-nova23:50
*** oro has joined #openstack-nova23:53
*** Marga_ has quit IRC23:54
*** tjones1 has quit IRC23:57
*** dboik_ has quit IRC23:59
*** wolsen_ is now known as wolsen23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!