jhesketh | Yep | 00:00 |
---|---|---|
*** browne has quit IRC | 00:00 | |
*** mtanino has quit IRC | 00:00 | |
*** markvoelker has joined #openstack-nova | 00:01 | |
*** browne has joined #openstack-nova | 00:01 | |
*** tsekiyam_ has quit IRC | 00:01 | |
*** redbeard has quit IRC | 00:04 | |
openstackgerrit | Joe Gordon proposed openstack/nova: Removing dummy mac address in the dhcp conf during shelving https://review.openstack.org/85249 | 00:05 |
jogo | clarkb: ^ cleaned up the unit tests for that patch lets see if it helps at all | 00:06 |
*** otter768 has joined #openstack-nova | 00:06 | |
clarkb | jogo: ya I am not sure if that will make a difference | 00:06 |
clarkb | jogo: the issue is when unshelving the mac addr isn't added to dnsmasq | 00:07 |
*** zzzeek has quit IRC | 00:08 | |
jogo | not sure either | 00:09 |
*** otter768 has quit IRC | 00:11 | |
*** Marga_ has quit IRC | 00:11 | |
jogo | but figured it was worth a try | 00:13 |
*** Marga_ has joined #openstack-nova | 00:13 | |
*** davideagnello has quit IRC | 00:14 | |
*** signed8bit_ZZZzz is now known as signed8b_ | 00:19 | |
*** signed8b_ is now known as signed8bit_ZZZzz | 00:19 | |
*** VW_ has joined #openstack-nova | 00:21 | |
*** marun has quit IRC | 00:26 | |
*** ijw has quit IRC | 00:29 | |
*** oro has quit IRC | 00:31 | |
*** Marga_ has quit IRC | 00:31 | |
*** yingjun has joined #openstack-nova | 00:32 | |
jhesketh | dansmith: Looks like your patch fixes the migrate_flavor command... however once migrated it just marks the system_metadata as deleted | 00:33 |
jhesketh | should https://review.openstack.org/#/c/174480/7/nova/db/sqlalchemy/migrate_repo/versions/291_enforce_flavors_migrated.py include a check that system_metadata.deleted = 0? | 00:33 |
dansmith | jhesketh: there are other things in sysmeta than the flavor | 00:34 |
dansmith | jhesketh: it should delete the rows related to flavor things, | 00:34 |
dansmith | jhesketh: and leave the rest | 00:34 |
jhesketh | dansmith: right, but I think we still need to select deleted = 0. I have 1506 instances that need migrating. I've done 40 of them | 00:36 |
jhesketh | if Ido | 00:36 |
jhesketh | http://paste.openstack.org/show/205155/ | 00:36 |
jhesketh | the migrate_flavor_data just updates deleted on the instance_type_id rows which are still selected by your migration afaik | 00:37 |
dansmith | jhesketh: oh, I see | 00:38 |
* dansmith looks at something | 00:38 | |
dansmith | okay, we're soft deleting those rows | 00:39 |
jhesketh | right, yes | 00:39 |
dansmith | I think it needs to be instance_system_metadata.deleted != null | 00:39 |
dansmith | and not just == 0 | 00:39 |
jhesketh | not on my dataset | 00:39 |
jhesketh | in fact, show create table says its a non-null field | 00:40 |
dansmith | really? | 00:40 |
jhesketh | eh, no, sorry, it's default NULL | 00:40 |
dansmith | I was going to say, I thought that was part of the base model | 00:40 |
jhesketh | yeah sorry | 00:41 |
*** vilobhmm1 has quit IRC | 00:41 | |
jhesketh | dansmith: http://paste.openstack.org/show/205157/ | 00:41 |
jhesketh | (I took out the uuid's and just showed two rows of interest) | 00:41 |
openstackgerrit | Dan Smith proposed openstack/nova: Wedge DB migrations if flavor migrations are not complete https://review.openstack.org/174480 | 00:42 |
jhesketh | dansmith: selecting deleted = null returns no rows | 00:42 |
dansmith | jhesketh: yeah, it should be deleted=id in most cases I think | 00:42 |
dansmith | jhesketh: so try that ^ ? | 00:42 |
dansmith | not sure about the deleted=0, that's strange | 00:42 |
dansmith | oh, are you saying deleted=0 are the not deleted ones? | 00:43 |
jhesketh | dansmith: right | 00:43 |
dansmith | hrm | 00:43 |
jhesketh | well I'm assuming they aren't deleted | 00:43 |
jhesketh | I have no null values for deleted in that table | 00:43 |
*** sdake has joined #openstack-nova | 00:44 | |
dansmith | huh, delete defaults to zero in the model | 00:44 |
dansmith | I could have sword they were supposed to be default to NULL | 00:44 |
dansmith | above, did you mean the table definition defaults to NULL? | 00:44 |
jhesketh | yes | 00:44 |
dansmith | yuck | 00:45 |
jhesketh | `deleted` int(11) DEFAULT NULL, | 00:45 |
dansmith | I wonder if that changed when this stuff moved out to oslo | 00:45 |
dansmith | I think that means that older nova people could have NULL there | 00:45 |
dansmith | or zero if the rows are newer | 00:45 |
*** annashen has joined #openstack-nova | 00:45 | |
jhesketh | could be older nova's have 0 in there and newer ones are null | 00:46 |
jhesketh | this dataset is, admittedly, old | 00:46 |
dansmith | the current oslo model mixin says zero | 00:46 |
jhesketh | ah | 00:48 |
jhesketh | so maybe we need to do an ugly OR | 00:48 |
jhesketh | or perhaps another migration to bring it into line (make everything NULL or 0's as it should be) | 00:48 |
dansmith | I dunno, I'm futzing with it, just a sec | 00:49 |
*** promulo__ has joined #openstack-nova | 00:49 | |
*** sdake has quit IRC | 00:50 | |
jhesketh | cool | 00:50 |
dansmith | something is weird because if I put !=0 in my query, I get no rows, even for not-deleted things | 00:50 |
dansmith | oh duh | 00:50 |
* dansmith really needs dinner | 00:50 | |
dansmith | so deleted=id is what signals the deletedness, regardless of the default | 00:51 |
dansmith | jhesketh: I think it's this: | 00:52 |
openstackgerrit | Dan Smith proposed openstack/nova: Wedge DB migrations if flavor migrations are not complete https://review.openstack.org/174480 | 00:52 |
*** igordcard has quit IRC | 00:52 | |
dansmith | actually, | 00:53 |
dansmith | that should probably be the case for the instances deleted check too | 00:53 |
*** promulo_ has quit IRC | 00:54 | |
openstackgerrit | Dan Smith proposed openstack/nova: Wedge DB migrations if flavor migrations are not complete https://review.openstack.org/174480 | 00:54 |
*** doude has quit IRC | 00:55 | |
dansmith | jhesketh: if that looks right to you, tomorrow I'll write some extra unit tests here to make sure that it properly ignores deleted sysmeta rows and deleted instances | 00:55 |
*** mtanino has joined #openstack-nova | 00:58 | |
*** annashen has quit IRC | 01:01 | |
jhesketh | dansmith: that looks right to me.. but why in earlier patches were you checking instances.deleted != null. Wouldn't that have selected all of the deleted instances? | 01:04 |
dansmith | yeah | 01:04 |
dansmith | I don't know what I was thinking | 01:05 |
dansmith | but it passed tests because the sqla model is defaulting them to 0, which is not null | 01:05 |
jhesketh | ah right | 01:05 |
dansmith | I mean to do == NULL of course, but that wouldn't have worked because apparently we're defaulting them to 0 in software :/ | 01:05 |
*** annashen has joined #openstack-nova | 01:06 | |
dansmith | I'll try to chase that down, because our schema should, like, match our models and stuff :/ | 01:06 |
*** annashen has quit IRC | 01:06 | |
jhesketh | yeah, if oslo.db uses 0 or the id to denote a deleted row then maybe all the deleted fields should be non-null | 01:07 |
*** dboik has joined #openstack-nova | 01:15 | |
dansmith | well, I'm pretty sure that in the past nova defaulted them to NULL | 01:16 |
*** tjones2 has quit IRC | 01:16 | |
dansmith | which means there could be data sets out there that need more than just a schema change I think | 01:17 |
*** dboik has quit IRC | 01:19 | |
*** yuntong1 has quit IRC | 01:21 | |
*** wuhg has joined #openstack-nova | 01:21 | |
*** otter768 has joined #openstack-nova | 01:22 | |
*** VW_ has quit IRC | 01:22 | |
*** achanda has quit IRC | 01:22 | |
*** yuntong has joined #openstack-nova | 01:23 | |
*** marun has joined #openstack-nova | 01:26 | |
jhesketh | right, I meant data and schema fixed | 01:29 |
*** sdake has joined #openstack-nova | 01:31 | |
*** kaisers has quit IRC | 01:31 | |
*** yuntong has quit IRC | 01:31 | |
*** Kevin_Zheng has joined #openstack-nova | 01:32 | |
*** kaisers has joined #openstack-nova | 01:32 | |
*** markvoelker has quit IRC | 01:33 | |
*** yuntong has joined #openstack-nova | 01:34 | |
*** erkules_ has joined #openstack-nova | 01:37 | |
*** Administrator_ has joined #openstack-nova | 01:37 | |
*** erkules has quit IRC | 01:40 | |
*** Kevin_Zheng has quit IRC | 01:41 | |
*** Administrator_ has quit IRC | 01:41 | |
*** popw has joined #openstack-nova | 01:41 | |
*** haigang has joined #openstack-nova | 01:41 | |
*** VW_ has joined #openstack-nova | 01:43 | |
*** IanGovett has quit IRC | 01:44 | |
openstackgerrit | Joshua Hesketh proposed openstack/nova: Add support for forcing migrate_flavor_data https://review.openstack.org/176574 | 01:45 |
*** Longgeek has joined #openstack-nova | 01:46 | |
*** Marga_ has joined #openstack-nova | 01:49 | |
*** otter768 has quit IRC | 01:51 | |
*** browne has quit IRC | 01:52 | |
*** Longgeek has quit IRC | 01:56 | |
*** ijw has joined #openstack-nova | 01:56 | |
*** Longgeek has joined #openstack-nova | 01:56 | |
*** david-lyle has quit IRC | 01:59 | |
*** davideagnello has joined #openstack-nova | 02:02 | |
*** ijw has quit IRC | 02:02 | |
*** davideagnello has quit IRC | 02:07 | |
*** annashen has joined #openstack-nova | 02:07 | |
*** baoli has joined #openstack-nova | 02:09 | |
*** annashen has quit IRC | 02:12 | |
*** haigang has quit IRC | 02:12 | |
*** harlowja is now known as harlowja_away | 02:12 | |
*** annegentle has joined #openstack-nova | 02:14 | |
*** VW_ has quit IRC | 02:14 | |
*** patrickeast has quit IRC | 02:18 | |
openstackgerrit | Vincent Hou proposed openstack/nova: Correct the order of the parameters to call swap_volume https://review.openstack.org/174307 | 02:19 |
*** annegentle has quit IRC | 02:19 | |
*** browne has joined #openstack-nova | 02:22 | |
*** markvoelker has joined #openstack-nova | 02:22 | |
*** marun has quit IRC | 02:23 | |
*** dave-mccowan has quit IRC | 02:24 | |
*** dave-mccowan has joined #openstack-nova | 02:25 | |
*** VW_ has joined #openstack-nova | 02:26 | |
*** rfolco has quit IRC | 02:28 | |
*** dikonoor has joined #openstack-nova | 02:30 | |
*** yingjun has quit IRC | 02:31 | |
*** park_heijlong has joined #openstack-nova | 02:33 | |
*** unicell1 has quit IRC | 02:38 | |
*** yingjun has joined #openstack-nova | 02:39 | |
*** haigang has joined #openstack-nova | 02:39 | |
*** yingjun has quit IRC | 02:51 | |
*** achanda has joined #openstack-nova | 02:53 | |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Disassociate before delete network in os-tenant-networks delete method https://review.openstack.org/164563 | 02:59 |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_associate https://review.openstack.org/161234 | 02:59 |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_create_safe https://review.openstack.org/161626 | 02:59 |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Pass project_id when create networks by os-tenant-networks https://review.openstack.org/164549 | 02:59 |
*** achanda has quit IRC | 02:59 | |
*** VW_ has quit IRC | 03:08 | |
*** VW_ has joined #openstack-nova | 03:08 | |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Disassociate before deleting network in os-tenant-networks delete method https://review.openstack.org/164563 | 03:08 |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_create_safe https://review.openstack.org/161626 | 03:08 |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Pass project_id when create networks by os-tenant-networks https://review.openstack.org/164549 | 03:08 |
*** vilobhmm1 has joined #openstack-nova | 03:10 | |
*** lan_ is now known as lan | 03:10 | |
*** mmedvede has quit IRC | 03:10 | |
*** signed8bit_ZZZzz is now known as signed8b_ | 03:13 | |
*** signed8b_ is now known as signed8bit_ZZZzz | 03:14 | |
*** mmedvede has joined #openstack-nova | 03:18 | |
*** VW_ has quit IRC | 03:22 | |
*** VW_ has joined #openstack-nova | 03:25 | |
*** annashen has joined #openstack-nova | 03:30 | |
*** VW_ has quit IRC | 03:31 | |
*** yingjun has joined #openstack-nova | 03:45 | |
*** Marga_ has quit IRC | 03:50 | |
*** Marga_ has joined #openstack-nova | 03:50 | |
*** otter768 has joined #openstack-nova | 03:52 | |
*** oomichi has joined #openstack-nova | 03:52 | |
*** oomichi has quit IRC | 03:52 | |
*** yingjun has quit IRC | 03:53 | |
*** yingjun has joined #openstack-nova | 03:53 | |
*** otter768 has quit IRC | 03:57 | |
*** yingjun has quit IRC | 03:58 | |
*** annashen has quit IRC | 04:04 | |
*** TobiasE has quit IRC | 04:04 | |
*** baoli has quit IRC | 04:05 | |
*** wverdugo500 has quit IRC | 04:05 | |
*** davideagnello has joined #openstack-nova | 04:07 | |
*** krtaylor has quit IRC | 04:08 | |
*** thomasem has quit IRC | 04:10 | |
*** krtaylor has joined #openstack-nova | 04:11 | |
*** xuhanp has joined #openstack-nova | 04:12 | |
*** xuhanp_ has joined #openstack-nova | 04:12 | |
*** rajesht has joined #openstack-nova | 04:12 | |
*** thomasem has joined #openstack-nova | 04:14 | |
*** wverdugo500 has joined #openstack-nova | 04:14 | |
*** Sukhdev has joined #openstack-nova | 04:17 | |
*** unicell has joined #openstack-nova | 04:25 | |
*** deepthi has joined #openstack-nova | 04:30 | |
*** coolsvap|afk is now known as coolsvap | 04:31 | |
*** coolsvap is now known as coolsvap|afk | 04:32 | |
*** annashen has joined #openstack-nova | 04:35 | |
*** sdake has quit IRC | 04:41 | |
*** fawadkhaliq has joined #openstack-nova | 04:45 | |
*** sdake has joined #openstack-nova | 04:46 | |
*** yingjun has joined #openstack-nova | 04:47 | |
*** annashen has quit IRC | 04:48 | |
*** sdake_ has joined #openstack-nova | 04:49 | |
*** sdake has quit IRC | 04:50 | |
*** whenry has quit IRC | 04:58 | |
*** david-lyle has joined #openstack-nova | 04:59 | |
*** mtanino has quit IRC | 05:01 | |
*** pradipta has joined #openstack-nova | 05:04 | |
*** sdake has joined #openstack-nova | 05:05 | |
*** mmedvede has quit IRC | 05:08 | |
*** tojuvone has joined #openstack-nova | 05:10 | |
*** sdake_ has quit IRC | 05:10 | |
*** jcoufal has joined #openstack-nova | 05:12 | |
*** nkrinner has joined #openstack-nova | 05:12 | |
*** whenry has joined #openstack-nova | 05:13 | |
*** unicell1 has joined #openstack-nova | 05:14 | |
*** vilobhmm1 has quit IRC | 05:15 | |
*** jcoufal has quit IRC | 05:15 | |
*** unicell has quit IRC | 05:16 | |
*** vilobhmm1 has joined #openstack-nova | 05:17 | |
*** wverdugo500 has quit IRC | 05:17 | |
*** krtaylor has quit IRC | 05:19 | |
*** vilobhmm11 has joined #openstack-nova | 05:19 | |
*** fawadk has joined #openstack-nova | 05:19 | |
*** garyk has joined #openstack-nova | 05:19 | |
*** thomasem has quit IRC | 05:19 | |
*** annashen has joined #openstack-nova | 05:20 | |
*** markvoelker_ has joined #openstack-nova | 05:21 | |
*** markvoelker has quit IRC | 05:21 | |
*** mmedvede has joined #openstack-nova | 05:21 | |
*** rwsu has quit IRC | 05:21 | |
*** vilobhmm1 has quit IRC | 05:22 | |
*** fawadkhaliq has quit IRC | 05:22 | |
*** xylan has joined #openstack-nova | 05:23 | |
*** med_ has quit IRC | 05:24 | |
*** jcoufal has joined #openstack-nova | 05:25 | |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_get_all_* https://review.openstack.org/160202 | 05:26 |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_create/update https://review.openstack.org/160203 | 05:26 |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_destroy_all_* https://review.openstack.org/160201 | 05:26 |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_usage_update https://review.openstack.org/160215 | 05:26 |
*** davideagnello has quit IRC | 05:30 | |
*** ajayaa has joined #openstack-nova | 05:31 | |
*** armax has quit IRC | 05:32 | |
*** thomasem has joined #openstack-nova | 05:32 | |
*** achanda has joined #openstack-nova | 05:33 | |
*** krtaylor has joined #openstack-nova | 05:33 | |
*** sks has joined #openstack-nova | 05:35 | |
*** med_ has joined #openstack-nova | 05:36 | |
*** med_ has quit IRC | 05:36 | |
*** med_ has joined #openstack-nova | 05:36 | |
*** wverdugo500 has joined #openstack-nova | 05:38 | |
*** josecastroleon has joined #openstack-nova | 05:38 | |
sks | [stack@images]$ nova console-log fedora-20.x86_64.qcow2 | 05:39 |
sks | ERROR (CommandError): No server with a name or ID of 'fedora-20.x86_64.qcow2' exists. | 05:39 |
sks | [stack@images]$ | 05:39 |
sks | any idea what could be the issue? | 05:40 |
dikonoor | alex_xu : Hi alex_xu ..This is about https://bugs.launchpad.net/nova/+bug/1447084 . I guess the final decision made is to elevate the context just before the db api call | 05:40 |
openstack | Launchpad bug 1447084 in OpenStack Compute (nova) "view hypervisor details should be controlled by policy.json" [High,Confirmed] - Assigned to Divya K Konoor (dikonoor) | 05:40 |
alex_xu | dikonoor: yes, as my understand it is | 05:41 |
dikonoor | alex_xu : also , based on the discussion mriedem and bauzas had later in the evening , the change has to go into master and then backported | 05:41 |
alex_xu | dikonoor: yes | 05:41 |
*** Hosam has joined #openstack-nova | 05:42 | |
alex_xu | dikonoor: so we stop to merge this patch https://review.openstack.org/160089 , it will continue after that fix merged | 05:42 |
openstackgerrit | Joshua Hesketh proposed openstack/nova: Add support for forcing migrate_flavor_data https://review.openstack.org/176574 | 05:42 |
dikonoor | alex_xu : ok..let me make the changes then..I see that https://review.openstack.org/#/c/175739/ and https://review.openstack.org/#/c/176461/ are failing because of same set of errors: http://logs.openstack.org/61/176461/1/check/check-tempest-dsvm-postgres-full/2577299/logs/devstacklog.txt.gz | 05:42 |
*** whenry has quit IRC | 05:43 | |
dikonoor | alex_xu : "ImportError: No module named pathlib" .They don;t seem related to the changes proposed. | 05:43 |
dikonoor | dikonoor: I added a recheck comment on both but I am not sure if that's the next step | 05:44 |
alex_xu | dikonoor: looks like unrelated error, just recheck the patchset | 05:44 |
alex_xu | dikonoor: yea, recheck was right | 05:44 |
*** Longgeek has quit IRC | 05:44 | |
dikonoor | alex_xu : ok , then I will wait..Thanks | 05:44 |
alex_xu | dikonoor: np, thanks for the fix too | 05:45 |
openstackgerrit | garyk proposed openstack/nova: VMware: add in folder support on VC https://review.openstack.org/165060 | 05:45 |
*** dave-mccowan has quit IRC | 05:46 | |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_class_create/update https://review.openstack.org/160206 | 05:46 |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_class_get_all_by_name https://review.openstack.org/160205 | 05:46 |
openstackgerrit | Alex Xu proposed openstack/nova: Cleanup quota_class unittest with appropriate request context https://review.openstack.org/150351 | 05:46 |
*** mmedvede has quit IRC | 05:46 | |
*** xyang1 has quit IRC | 05:48 | |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_class_create/update https://review.openstack.org/160206 | 05:49 |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_class_get_all_by_name https://review.openstack.org/160205 | 05:49 |
openstackgerrit | Alex Xu proposed openstack/nova: Cleanup quota_class unittest with appropriate request context https://review.openstack.org/150351 | 05:49 |
*** isd has quit IRC | 05:50 | |
*** lpetrut has joined #openstack-nova | 05:50 | |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_get_all_* https://review.openstack.org/160202 | 05:52 |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_create/update https://review.openstack.org/160203 | 05:52 |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_destroy_all_* https://review.openstack.org/160201 | 05:52 |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_usage_update https://review.openstack.org/160215 | 05:52 |
*** otter768 has joined #openstack-nova | 05:53 | |
*** kiran-r has joined #openstack-nova | 05:53 | |
*** haomaiwang has quit IRC | 05:55 | |
*** Longgeek has joined #openstack-nova | 05:57 | |
*** otter768 has quit IRC | 05:57 | |
openstackgerrit | garyk proposed openstack/nova: VMware: improve instance names on VC https://review.openstack.org/166608 | 05:59 |
*** emagana has joined #openstack-nova | 05:59 | |
*** yingjun_ has joined #openstack-nova | 05:59 | |
*** Maike has joined #openstack-nova | 06:01 | |
*** yingjun has quit IRC | 06:04 | |
*** mmedvede has joined #openstack-nova | 06:04 | |
*** pkoniszewski has joined #openstack-nova | 06:04 | |
*** ankit_ag has joined #openstack-nova | 06:08 | |
*** afazekas_ has joined #openstack-nova | 06:11 | |
openstackgerrit | Chris Friesen proposed openstack/nova: libvirt: check qemu version for NUMA & hugepage support https://review.openstack.org/170780 | 06:11 |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for floating_ip_dns https://review.openstack.org/150710 | 06:12 |
winston-d | win 3 | 06:14 |
*** Longgeek has quit IRC | 06:16 | |
openstackgerrit | Chris Friesen proposed openstack/nova: unify libvirt driver checks for qemu https://review.openstack.org/175542 | 06:16 |
*** Sukhdev has quit IRC | 06:17 | |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_class_create/update https://review.openstack.org/160206 | 06:20 |
openstackgerrit | Alex Xu proposed openstack/nova: Cleanup quota_class unittest with appropriate request context https://review.openstack.org/150351 | 06:20 |
*** cfriesen has quit IRC | 06:22 | |
openstackgerrit | Vilobh Meshram proposed openstack/nova-specs: Replace service groups with the tooz groups https://review.openstack.org/138607 | 06:22 |
*** lpetrut has quit IRC | 06:23 | |
*** ildikov has quit IRC | 06:25 | |
*** Longgeek has joined #openstack-nova | 06:26 | |
*** fawadkhaliq has joined #openstack-nova | 06:26 | |
vilobhmm11 | johnthetubaguy: Can you please have a look at https://review.openstack.org/138607 I have summarised your concerns and have answered the question that you had posted… | 06:26 |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for keypair https://review.openstack.org/176231 | 06:27 |
*** fawadk has quit IRC | 06:29 | |
*** Marga_ has quit IRC | 06:31 | |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_disassociate https://review.openstack.org/161624 | 06:39 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex https://review.openstack.org/171943 | 06:40 |
*** Longgeek_ has joined #openstack-nova | 06:43 | |
*** Longgeek has quit IRC | 06:46 | |
*** annashen has quit IRC | 06:46 | |
*** xuhanp has quit IRC | 06:47 | |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_set_host https://review.openstack.org/161625 | 06:48 |
*** sileht has quit IRC | 06:48 | |
openstackgerrit | Trung Trinh proposed openstack/nova: Fix bug in function get_instance_availability_zone https://review.openstack.org/149952 | 06:48 |
*** xuhanp_ has quit IRC | 06:49 | |
*** sahid has joined #openstack-nova | 06:49 | |
*** erkules_ is now known as erkules | 06:50 | |
*** erkules has joined #openstack-nova | 06:50 | |
*** eglynn-pto has quit IRC | 06:52 | |
*** eglynn-pto has joined #openstack-nova | 06:52 | |
*** haomaiwang has joined #openstack-nova | 06:54 | |
*** vilobhmm11 has quit IRC | 06:54 | |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for fixed_ip_associate_* https://review.openstack.org/150687 | 06:55 |
*** divya_ has joined #openstack-nova | 06:57 | |
*** mpaolino has joined #openstack-nova | 06:57 | |
*** eglynn-pto has quit IRC | 06:57 | |
*** dikonoor has quit IRC | 06:59 | |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for floating_ips_bulk https://review.openstack.org/150704 | 07:00 |
*** welldannit has quit IRC | 07:03 | |
*** Maike has quit IRC | 07:06 | |
*** achanda has quit IRC | 07:07 | |
*** pkoniszewski has quit IRC | 07:07 | |
*** jcoufal_ has joined #openstack-nova | 07:07 | |
*** pkoniszewski has joined #openstack-nova | 07:07 | |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for security_group_default_rule_destroy https://review.openstack.org/160257 | 07:07 |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for security_group_default_rule_create https://review.openstack.org/150718 | 07:07 |
*** Longgeek_ has quit IRC | 07:09 | |
*** sileht has joined #openstack-nova | 07:10 | |
*** Longgeek has joined #openstack-nova | 07:11 | |
*** jcoufal has quit IRC | 07:11 | |
*** pkoniszewski has quit IRC | 07:12 | |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_get_all_* https://review.openstack.org/160202 | 07:12 |
*** rushiagr_away is now known as rushiagr | 07:12 | |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_create/update https://review.openstack.org/160203 | 07:12 |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_destroy_all_* https://review.openstack.org/160201 | 07:12 |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_usage_update https://review.openstack.org/160215 | 07:12 |
*** jyuso has joined #openstack-nova | 07:13 | |
*** oro has joined #openstack-nova | 07:13 | |
*** ildikov has joined #openstack-nova | 07:14 | |
*** gzhai1 has quit IRC | 07:15 | |
*** jcoufal_ has quit IRC | 07:15 | |
*** heyongli has quit IRC | 07:15 | |
*** atuvenie has joined #openstack-nova | 07:15 | |
*** alex_xu has quit IRC | 07:15 | |
*** jcoufal has joined #openstack-nova | 07:15 | |
*** alex_xu_ has joined #openstack-nova | 07:15 | |
*** jyuso1 has quit IRC | 07:15 | |
*** gzhai1 has joined #openstack-nova | 07:16 | |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for network_get_all_by_host https://review.openstack.org/161629 | 07:17 |
*** lpetrut has joined #openstack-nova | 07:17 | |
*** heyongli has joined #openstack-nova | 07:17 | |
*** davideagnello has joined #openstack-nova | 07:18 | |
*** jichen has joined #openstack-nova | 07:19 | |
divya_ | alex_xu : for the changes that we discussed for https://bugs.launchpad.net/nova/+bug/1447084 , I am trying to figure out where unite test case changes can be made. I guess https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/contrib/test_hypervisors.py uses the fake policy file at http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/fake_policy.py#L252 which expects and admin role | 07:20 |
openstack | Launchpad bug 1447084 in OpenStack Compute (nova) "view hypervisor details should be controlled by policy.json" [High,Confirmed] - Assigned to Divya K Konoor (dikonoor) | 07:20 |
*** xuhanp has joined #openstack-nova | 07:23 | |
*** xuhanp_ has joined #openstack-nova | 07:23 | |
*** davideagnello has quit IRC | 07:23 | |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_class_create/update https://review.openstack.org/160206 | 07:25 |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for quota_class_get_all_by_name https://review.openstack.org/160205 | 07:25 |
openstackgerrit | Alex Xu proposed openstack/nova: Cleanup quota_class unittest with appropriate request context https://review.openstack.org/150351 | 07:25 |
*** bkopilov has quit IRC | 07:26 | |
*** browne has quit IRC | 07:27 | |
*** xuhanp has quit IRC | 07:28 | |
*** xuhanp_ has quit IRC | 07:28 | |
openstackgerrit | ShaoHe Feng proposed openstack/nova: Remove db layer hard-code permission checks for fixed_ip_get_* https://review.openstack.org/160103 | 07:31 |
openstackgerrit | Eli Qiao proposed openstack/nova: API: remove admin require from certificate_* from db layer https://review.openstack.org/176648 | 07:32 |
*** xuhanp_ has joined #openstack-nova | 07:33 | |
*** xuhanp has joined #openstack-nova | 07:33 | |
*** jistr has joined #openstack-nova | 07:38 | |
*** apuimedo_ has joined #openstack-nova | 07:38 | |
*** popw has quit IRC | 07:38 | |
openstackgerrit | sahid proposed openstack/nova: Correct the legacy serialization of NUMATopology https://review.openstack.org/152689 | 07:39 |
openstackgerrit | Divya K Konoor proposed openstack/nova: view hypervisor details rest api should be allowed for non-admins https://review.openstack.org/176651 | 07:40 |
*** jlanoux has joined #openstack-nova | 07:40 | |
*** jcoufal has quit IRC | 07:40 | |
*** jcoufal has joined #openstack-nova | 07:41 | |
*** bkopilov has joined #openstack-nova | 07:44 | |
*** popw has joined #openstack-nova | 07:44 | |
*** jcoufal has quit IRC | 07:45 | |
*** sudipto has joined #openstack-nova | 07:48 | |
*** coolsvap|afk is now known as coolsvap | 07:52 | |
*** coolsvap is now known as coolsvap|afk | 07:53 | |
*** Maike has joined #openstack-nova | 07:53 | |
*** otter768 has joined #openstack-nova | 07:54 | |
*** jcoufal has joined #openstack-nova | 07:54 | |
*** matrohon has joined #openstack-nova | 07:55 | |
*** divya_ has quit IRC | 07:58 | |
*** otter768 has quit IRC | 07:58 | |
*** sudipto has quit IRC | 07:59 | |
*** eglynn-pto has joined #openstack-nova | 08:05 | |
*** zz_johnthetubagu is now known as johnthetubaguy | 08:08 | |
*** jyuso has quit IRC | 08:10 | |
*** eliqiao1 has joined #openstack-nova | 08:14 | |
*** eliqiao1 has left #openstack-nova | 08:15 | |
*** eglynn-pto has quit IRC | 08:16 | |
*** yingjun_ has quit IRC | 08:16 | |
*** lucasagomes has joined #openstack-nova | 08:17 | |
*** yassine_ has joined #openstack-nova | 08:19 | |
*** Nikolay_St has joined #openstack-nova | 08:19 | |
*** romainh has joined #openstack-nova | 08:19 | |
*** yassine_ has quit IRC | 08:19 | |
*** bkopilov has quit IRC | 08:19 | |
johnthetubaguy | mikal: thanks the the mails, I will take a look at those reviews, its mostly a case of checking the blueprint and getting that approved first | 08:21 |
*** yassine_ has joined #openstack-nova | 08:21 | |
*** yingjun has joined #openstack-nova | 08:23 | |
*** eglynn-pto has joined #openstack-nova | 08:26 | |
*** andreykurilin__ has joined #openstack-nova | 08:27 | |
*** Longgeek has quit IRC | 08:31 | |
*** Longgeek has joined #openstack-nova | 08:31 | |
*** dikonoor has joined #openstack-nova | 08:32 | |
*** zhangtralon has joined #openstack-nova | 08:34 | |
*** doude has joined #openstack-nova | 08:34 | |
*** redbeard has joined #openstack-nova | 08:37 | |
*** eglynn-pto is now known as eglynn | 08:38 | |
openstackgerrit | zhangtralon proposed openstack/nova: filter_class_names is never passed https://review.openstack.org/143285 | 08:41 |
*** doude has quit IRC | 08:42 | |
*** dave-mcnally has joined #openstack-nova | 08:42 | |
dave-mcnally | hey folks I have a small fix up for a bug in rebuild that I'd appreciate some reviews on: https://review.openstack.org/#/c/172951/ | 08:43 |
*** tdurakov has joined #openstack-nova | 08:48 | |
tdurakov | Hi | 08:49 |
tdurakov | who could give some details about https://bugs.launchpad.net/nova/+bug/1398999 and the way, how it was fixed? | 08:50 |
openstack | Launchpad bug 1398999 in OpenStack Compute (nova) "Block migrate with attached volumes copies volumes to themselves" [Undecided,Confirmed] - Assigned to Chris St. Pierre (stpierre) | 08:50 |
*** alexpilotti has joined #openstack-nova | 08:52 | |
tdurakov | why current implementation doesn't allow block-migration at all if volume is attached? | 08:53 |
*** jwang has joined #openstack-nova | 08:54 | |
*** jwang_ has quit IRC | 08:57 | |
tdurakov | sdague, dansmith, could you help me with this? There is bug in launchpad, connected with previous: https://bugs.launchpad.net/nova/+bug/1276639 | 08:57 |
openstack | Launchpad bug 1276639 in OpenStack Compute (nova) "block live migration does not work when a volume is attached" [Medium,In progress] - Assigned to Timofey Durakov (tdurakov) | 08:57 |
*** fawadkhaliq has quit IRC | 08:58 | |
openstackgerrit | Divya K Konoor proposed openstack/nova: view hypervisor details rest api should be allowed for non-admins https://review.openstack.org/176651 | 08:58 |
*** jwang_ has joined #openstack-nova | 08:59 | |
*** jwang has quit IRC | 09:01 | |
*** haomaiwang has quit IRC | 09:05 | |
*** ildikov has quit IRC | 09:06 | |
*** davideagnello has joined #openstack-nova | 09:08 | |
*** jcoufal_ has joined #openstack-nova | 09:10 | |
*** davideagnello has quit IRC | 09:12 | |
*** jcoufal has quit IRC | 09:13 | |
*** ndipanov has joined #openstack-nova | 09:18 | |
*** kaisers has quit IRC | 09:20 | |
*** ildikov has joined #openstack-nova | 09:21 | |
*** kaisers has joined #openstack-nova | 09:23 | |
*** zhangtralon has quit IRC | 09:24 | |
*** exploreshaifali has joined #openstack-nova | 09:27 | |
johnthetubaguy | bauzas: wondering if we could do with a blueprint for this patch I spotted: https://review.openstack.org/#/c/158245 | 09:30 |
ndipanov | johnthetubaguy, well it's really only refactoring, and the BP could be general objects work | 09:31 |
*** haigang has quit IRC | 09:31 | |
*** xgsa has joined #openstack-nova | 09:32 | |
*** yingjun has quit IRC | 09:33 | |
*** aix has joined #openstack-nova | 09:35 | |
*** park_heijlong has quit IRC | 09:36 | |
*** moshele has joined #openstack-nova | 09:36 | |
*** pask81 has joined #openstack-nova | 09:40 | |
*** derekh has joined #openstack-nova | 09:41 | |
johnthetubaguy | ndipanov: yeah, its more to raise it up the review priority, and track it, its required | 09:42 |
*** mmedvede has quit IRC | 09:43 | |
ndipanov | johnthetubaguy, I think bauzas is on PTO today, but I'll talk to him | 09:43 |
ndipanov | he has a BP up that may make that work moot | 09:43 |
ndipanov | PTO = day off | 09:44 |
*** andreykurilin__ has quit IRC | 09:44 | |
bauzas | johnthetubaguy : yeah on PTO | 09:44 |
bauzas | Well I need further thoughts about the patch, I would say its a nice workaround until we merge ReqSpec | 09:46 |
openstackgerrit | dave-mcnally proposed openstack/nova: rebuild_instance doesn't detach cinder volumes correctly https://review.openstack.org/172951 | 09:46 |
*** annashen has joined #openstack-nova | 09:47 | |
bauzas | I'm planning to work on the Bp by next week | 09:47 |
bauzas | but hard to give more context using my Android phone :/ | 09:48 |
*** sudipto has joined #openstack-nova | 09:49 | |
bauzas | johnthetubaguy: ^ | 09:50 |
*** josecastroleon has quit IRC | 09:51 | |
*** annashen has quit IRC | 09:51 | |
*** moshele has quit IRC | 09:51 | |
*** otter768 has joined #openstack-nova | 09:54 | |
*** jcoufal_ is now known as jcoufal | 09:55 | |
*** fawadkhaliq has joined #openstack-nova | 09:57 | |
*** Longgeek has quit IRC | 09:57 | |
*** Longgeek has joined #openstack-nova | 09:59 | |
*** doude has joined #openstack-nova | 09:59 | |
*** otter768 has quit IRC | 09:59 | |
*** mmedvede has joined #openstack-nova | 10:00 | |
johnthetubaguy | bauzas: have a good holiday! | 10:05 |
*** fawadkhaliq has quit IRC | 10:08 | |
sudipto | johnthetubaguy, Can i ask for a couple of reviews? | 10:10 |
*** doude has quit IRC | 10:11 | |
*** IanGovett has joined #openstack-nova | 10:13 | |
*** yingjun has joined #openstack-nova | 10:13 | |
*** ildikov has quit IRC | 10:13 | |
*** afazekas_ has quit IRC | 10:14 | |
*** amotoki_ has joined #openstack-nova | 10:15 | |
sudipto | johnthetubaguy, one is here: https://review.openstack.org/#/c/173187/ and the other is https://review.openstack.org/#/c/175357/ (this is very minor one) | 10:17 |
*** yingjun has quit IRC | 10:19 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova: Removed unused variables, methods and classes https://review.openstack.org/164666 | 10:21 |
*** inhumanitas has left #openstack-nova | 10:21 | |
*** mpaolino has quit IRC | 10:26 | |
*** zul has quit IRC | 10:27 | |
*** zul has joined #openstack-nova | 10:28 | |
*** fawadkhaliq has joined #openstack-nova | 10:29 | |
*** ildikov has joined #openstack-nova | 10:29 | |
sudipto | sahid, hoping for a merge on the patches! | 10:29 |
*** inhumanitas has joined #openstack-nova | 10:31 | |
*** afazekas has joined #openstack-nova | 10:32 | |
*** exploreshaifali has quit IRC | 10:32 | |
sahid | :) | 10:34 |
*** haomaiwa_ has joined #openstack-nova | 10:38 | |
*** zul has quit IRC | 10:38 | |
*** zul has joined #openstack-nova | 10:39 | |
johnthetubaguy | sudipto: so, bit confused about one bit in the first patch | 10:39 |
*** rushiagr is now known as rushiagr_away | 10:40 | |
johnthetubaguy | sudipto: https://review.openstack.org/#/c/173187/21/nova/virt/libvirt/driver.py,cm L4489 in the new side, don't those need to be sorted first? | 10:40 |
*** kim__ has joined #openstack-nova | 10:40 | |
sudipto | johnthetubaguy, umm, i didn't think so. Let me write a dummy code. | 10:41 |
sudipto | sets don't have to be sorted to be compared right? | 10:41 |
sahid | sets are always sorted | 10:41 |
johnthetubaguy | sudipto: oh, it wasn't clear to me that they are both sets, I thought they were lists | 10:41 |
sudipto | johnthetubaguy, ah - they are sets... | 10:42 |
sahid | johnthetubaguy: made the same mistake in my first review | 10:42 |
johnthetubaguy | sudipto: L4496 really sends you off thinking about sorting | 10:43 |
*** xgsa has quit IRC | 10:44 | |
kim__ | I am working on a nova project and i m very new to openstack. I would like to know can nova pass information to Ironic? | 10:44 |
johnthetubaguy | kim__: nova makes REST API calls to Ironic, see the ironic nova virt driver for details: https://github.com/openstack/nova/tree/master/nova/virt/ironic | 10:45 |
sudipto | johnthetubaguy, sahid I don't see sets being sorted by default. But yeah if you are doing set operations on them, i don't think need to be sorted before doing so. | 10:45 |
sahid | sudipto: >>> set([3, 2, 1]) | 10:47 |
sahid | set([1, 2, 3]) | 10:47 |
sudipto | sahid, woah! I see different. Wonder why. | 10:47 |
sudipto | a = set([9, 5]) | 10:48 |
sudipto | print a | 10:48 |
sahid | it's easy to find duplicate when a list is sorted | 10:48 |
ndipanov | sahid, fwiw - internally sets are hashes so - they are not sorted really - they might be by your repr | 10:48 |
ndipanov | not that it matters | 10:48 |
sahid | ndipanov: oh really | 10:48 |
ndipanov | well yeah... | 10:48 |
sudipto | sahid, yeah for me, it seems like they aren't set([9, 5]) this is the o/p | 10:48 |
*** pkoniszewski has joined #openstack-nova | 10:48 | |
sahid | hum...some operation can be heavy without to keep that list sorted | 10:49 |
ndipanov | sahid, ? | 10:50 |
*** pask81 has quit IRC | 10:52 | |
sahid | ndipanov: hum yes.. you probably aez right forget about me :) | 10:52 |
ndipanov | http://svn.python.org/view/python/trunk/Objects/setobject.c | 10:53 |
ndipanov | pretty straightforward open addressing hash table | 10:53 |
ndipanov | I mean | 10:53 |
*** xgsa has joined #openstack-nova | 10:53 | |
ndipanov | battle tested of course | 10:53 |
sahid | ndipanov: yes actually it makes sens that is why we cannot have two same element, the key will be the same | 10:54 |
ndipanov | right | 10:55 |
sudipto | sahid, if you see alex_xu_ 's comment there - he is suggesting we should not throw an exception - something that i had in the first patch sets...your thoughts? | 10:55 |
sudipto | ndipanov, If i may get your thoughts too on https://review.openstack.org/#/c/175357/ ... | 10:56 |
sudipto | johnthetubaguy, thanks! | 10:56 |
*** davideagnello has joined #openstack-nova | 10:56 | |
*** zul has quit IRC | 10:57 | |
*** zul has joined #openstack-nova | 10:57 | |
ndipanov | sudipto, my thoughts are that it seems approved :) | 10:58 |
ndipanov | hope it helps | 10:58 |
sudipto | ndipanov, ok thanks! :) | 10:58 |
*** atuvenie has quit IRC | 10:59 | |
johnthetubaguy | I figure we can loosen it in a follow up patch, but probably best to fix the bug first | 11:01 |
*** davideagnello has quit IRC | 11:01 | |
sudipto | johnthetubaguy, yeah - just that - i feel we have to re-look at what we want to support. | 11:04 |
sudipto | johnthetubaguy, to me it appears that even in the previous scenario (that didn't have this patch set code) - you'd not be able to specify or allow offline cpuset numbers in some cases. | 11:04 |
*** kim__ has quit IRC | 11:04 | |
*** Maike has quit IRC | 11:04 | |
sudipto | johnthetubaguy, this is my argument on the patch: while I agree that the operator may specify some cpusets that might not be online - and later expect them to be online - in which case, the below check too doesn't suffice that need. Let's say the operator specifies 1-4 as the cpuset to use. (and my code above is not present). Let's say there are only 2 active cpus, so total_pcpus will be 2. In such a case, you wouldn't allow the compute to start | 11:05 |
sudipto | as per the old behavior. Hence, it needs a complete re-look at how we would want to support this scenario that goes beyond this patch IMHO. | 11:05 |
openstackgerrit | sahid proposed openstack/nova: libvirt: introduces a new Guest object https://review.openstack.org/174313 | 11:10 |
*** subscope has quit IRC | 11:21 | |
*** aix has quit IRC | 11:22 | |
*** xuhanp has quit IRC | 11:24 | |
*** xuhanp_ has quit IRC | 11:24 | |
*** david-lyle has quit IRC | 11:29 | |
*** eglynn is now known as eglynn-lunch | 11:30 | |
*** pask81 has joined #openstack-nova | 11:32 | |
*** divya_ has joined #openstack-nova | 11:37 | |
*** alex_xu_ has quit IRC | 11:38 | |
*** atuvenie has joined #openstack-nova | 11:39 | |
*** dikonoor has quit IRC | 11:40 | |
*** alex_xu has joined #openstack-nova | 11:41 | |
*** tojuvone has quit IRC | 11:41 | |
*** divya__ has joined #openstack-nova | 11:41 | |
*** subscope has joined #openstack-nova | 11:42 | |
*** Maike has joined #openstack-nova | 11:43 | |
*** josecastroleon has joined #openstack-nova | 11:43 | |
*** divya_ has quit IRC | 11:43 | |
*** pask81 has quit IRC | 11:49 | |
*** dave-mccowan has joined #openstack-nova | 11:53 | |
*** pask81 has joined #openstack-nova | 11:53 | |
openstackgerrit | Timofey Durakov proposed openstack/nova: Fixed nova-network dhcp-hostsfile update during live-migration https://review.openstack.org/173913 | 11:54 |
*** rahuk_ has joined #openstack-nova | 11:54 | |
*** samueldmq has joined #openstack-nova | 11:55 | |
*** otter768 has joined #openstack-nova | 11:55 | |
rahuk_ | hey guys has anyone ever try to run xenserver (6.2) as a vm/instance on openstack (juno) ? is it possible ? | 11:56 |
*** pixelb has joined #openstack-nova | 11:57 | |
*** ociuhandu has joined #openstack-nova | 11:59 | |
tdurakov | dansmith, Hi, could you review my patch again https://review.openstack.org/#/c/173913/ | 11:59 |
*** aix has joined #openstack-nova | 12:00 | |
*** otter768 has quit IRC | 12:00 | |
*** aix has quit IRC | 12:00 | |
*** aix has joined #openstack-nova | 12:00 | |
*** david-lyle has joined #openstack-nova | 12:05 | |
*** raildo has joined #openstack-nova | 12:05 | |
*** VW_ has joined #openstack-nova | 12:06 | |
*** sudipto has quit IRC | 12:09 | |
*** VW_ has quit IRC | 12:11 | |
*** VW_ has joined #openstack-nova | 12:11 | |
*** zhenguo has quit IRC | 12:12 | |
*** jgrimm is now known as zz_jgrimm | 12:15 | |
wanghao | hi guys, could you review my patch https://review.openstack.org/#/c/171984/? | 12:16 |
*** whenry has joined #openstack-nova | 12:17 | |
*** VW_ has quit IRC | 12:17 | |
*** deepthi has quit IRC | 12:18 | |
*** pask811 has joined #openstack-nova | 12:20 | |
*** dprince has joined #openstack-nova | 12:23 | |
*** pask81 has quit IRC | 12:23 | |
*** divya__ has quit IRC | 12:27 | |
*** josecastroleon has quit IRC | 12:28 | |
*** rahuk_ has quit IRC | 12:30 | |
*** david-lyle has quit IRC | 12:31 | |
*** joefides_ has quit IRC | 12:33 | |
*** kaisers has quit IRC | 12:33 | |
*** dikonoor has joined #openstack-nova | 12:33 | |
rajesht | alaski: you around ? | 12:34 |
*** eglynn-lunch is now known as eglynn | 12:35 | |
*** vladikr has joined #openstack-nova | 12:37 | |
*** kaisers has joined #openstack-nova | 12:37 | |
*** signed8bit_ZZZzz has quit IRC | 12:39 | |
*** ajayaa has quit IRC | 12:39 | |
*** mpaolino has joined #openstack-nova | 12:40 | |
BobBall | rahuk_: Yes, it is possible - if you're running Xen underneath you can have a nested XenServer instance. | 12:41 |
*** davideagnello has joined #openstack-nova | 12:45 | |
*** xyang1 has joined #openstack-nova | 12:45 | |
*** amotoki_ has quit IRC | 12:46 | |
*** Longgeek has quit IRC | 12:47 | |
*** erlon has joined #openstack-nova | 12:47 | |
*** apmelton_away is now known as apmelton | 12:48 | |
*** Longgeek has joined #openstack-nova | 12:48 | |
*** pradipta has quit IRC | 12:49 | |
*** davideagnello has quit IRC | 12:50 | |
openstackgerrit | sahid proposed openstack/nova: Correct the legacy serialization of NUMATopology https://review.openstack.org/152689 | 12:54 |
*** Longgeek_ has joined #openstack-nova | 12:55 | |
*** Longgeek has quit IRC | 12:56 | |
*** mjturek1 has joined #openstack-nova | 12:57 | |
openstackgerrit | dave-mcnally proposed openstack/nova: rebuild_instance doesn't detach cinder volumes correctly https://review.openstack.org/172951 | 12:58 |
*** rushil has joined #openstack-nova | 13:00 | |
*** ferest has joined #openstack-nova | 13:01 | |
alaski | rajesht: yep | 13:01 |
*** neelashah has joined #openstack-nova | 13:01 | |
*** apmelton is now known as apmelton_away | 13:03 | |
*** ferest has quit IRC | 13:04 | |
*** joefides has joined #openstack-nova | 13:05 | |
*** alexschm has joined #openstack-nova | 13:05 | |
johnthetubaguy | dansmith: I am wondering if we should back port all these flavor migration issues joshua H is finding? | 13:06 |
*** apuimedo_ has quit IRC | 13:06 | |
*** baoli has joined #openstack-nova | 13:06 | |
*** baoli_ has joined #openstack-nova | 13:07 | |
*** busterswt has joined #openstack-nova | 13:07 | |
*** baoli__ has joined #openstack-nova | 13:08 | |
*** sdake_ has joined #openstack-nova | 13:10 | |
*** baoli has quit IRC | 13:11 | |
alexschm | I'm looking for reviewers on https://review.openstack.org/#/c/168961/ | 13:11 |
alexschm | it's nearly a month old and did not get a lot of attention, does anybody care to have a look? | 13:11 |
*** baoli_ has quit IRC | 13:12 | |
*** josecastroleon has joined #openstack-nova | 13:13 | |
*** jecarey has joined #openstack-nova | 13:13 | |
*** sdake has quit IRC | 13:14 | |
*** Marga_ has joined #openstack-nova | 13:14 | |
*** ivasev has joined #openstack-nova | 13:16 | |
*** thomasem has quit IRC | 13:16 | |
*** mriedem_away has quit IRC | 13:21 | |
*** pask811 has quit IRC | 13:22 | |
*** annegentle has joined #openstack-nova | 13:22 | |
*** pask81 has joined #openstack-nova | 13:23 | |
*** sks has quit IRC | 13:25 | |
*** claudiub has joined #openstack-nova | 13:26 | |
*** pask81 has quit IRC | 13:27 | |
*** rfolco has joined #openstack-nova | 13:28 | |
*** thomasem has joined #openstack-nova | 13:29 | |
*** mpaolino has quit IRC | 13:29 | |
*** mjturek1 has quit IRC | 13:30 | |
*** aswadr has joined #openstack-nova | 13:30 | |
*** kiran-r has quit IRC | 13:32 | |
dansmith | johnthetubaguy: backport, definitely, we have to | 13:32 |
dansmith | johnthetubaguy: did you mean backport for rc2? | 13:32 |
*** fawadkhaliq has quit IRC | 13:33 | |
*** fawadkhaliq has joined #openstack-nova | 13:36 | |
*** kiran-r has joined #openstack-nova | 13:36 | |
*** mjturek1 has joined #openstack-nova | 13:37 | |
*** dboik has joined #openstack-nova | 13:39 | |
*** wuhg has quit IRC | 13:39 | |
*** burt has joined #openstack-nova | 13:42 | |
dansmith | johnthetubaguy: I think there are only two issues though | 13:43 |
johnthetubaguy | dansmith: I was thinking for RC2, but we shipped that now, could be in RC3 if we end up needing one | 13:44 |
johnthetubaguy | dansmith: glad there are only the two issues, but realised we didn't have bugs to track those patches | 13:45 |
dansmith | johnthetubaguy: well, I figure that people running stable/kilo have until we cut the rc for lemming to do this, so, it's not super time critical I don't think | 13:45 |
dansmith | the only pressing thing is getting it to work so we can drop the stuff in master | 13:45 |
dansmith | johnthetubaguy: we have a bug for the really important one: | 13:45 |
dansmith | 1447132 | 13:46 |
dansmith | johnthetubaguy: here's the backport, for whenever: https://review.openstack.org/176741 | 13:46 |
*** mriedem has joined #openstack-nova | 13:47 | |
johnthetubaguy | dansmith: ah, I see now, its tagged for backport not RC, but thats fine | 13:47 |
mriedem | flwang: i'm around now if you still are | 13:47 |
dansmith | johnthetubaguy: if we do another rc, we should put this in there, but not justify it with it | 13:47 |
dansmith | so should I tag and say that on the bug? | 13:47 |
johnthetubaguy | dansmith: +1 that | 13:48 |
johnthetubaguy | dansmith: +1 both actually | 13:48 |
johnthetubaguy | thanks | 13:48 |
*** vladikr has quit IRC | 13:48 | |
dansmith | okay | 13:48 |
dansmith | johnthetubaguy: I suppose I should feel bad about this not being perfect, | 13:49 |
dansmith | but it was our first time doing such a thing, and it was flavors, so it was like worst case scenario | 13:49 |
johnthetubaguy | dansmith: I am just glad we have started doing it, thats a great step forward | 13:49 |
dansmith | yeah | 13:50 |
*** Marga_ has quit IRC | 13:52 | |
anteaya | 6 | 13:53 |
mriedem | 5? | 13:56 |
*** otter768 has joined #openstack-nova | 13:56 | |
*** sdake_ has quit IRC | 13:58 | |
*** rdo has quit IRC | 13:58 | |
dikonoor | alex_xu : On your comments in https://review.openstack.org/#/c/176651/ on adding test cases , I am not sure if this file considers the rules from a real or fake policy.json file >> https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/contrib/test_hypervisors.py | 14:00 |
*** kaisers has quit IRC | 14:00 | |
*** rdo has joined #openstack-nova | 14:00 | |
*** otter768 has quit IRC | 14:01 | |
dikonoor | alex_xu: do you know if it checks for the policy.json rules.. I see a fake_policy file and policy_fixtures file under the tests but I am not sure if it's getting used here | 14:01 |
*** READ10 has joined #openstack-nova | 14:01 | |
*** kaisers has joined #openstack-nova | 14:02 | |
*** vladikr has joined #openstack-nova | 14:02 | |
*** signed8bit has joined #openstack-nova | 14:02 | |
mriedem | dikonoor: it uses the fake policy http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/fake_policy.py?id=2015.1.0rc2 | 14:03 |
mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/test.py?id=2015.1.0rc2#n249 | 14:03 |
*** ganso_ has joined #openstack-nova | 14:03 | |
mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/unit/policy_fixture.py?id=2015.1.0rc2#n61 | 14:04 |
mriedem | dikonoor: why are you only elevating the context in show for v2 api? | 14:04 |
alex_xu | dikonoor: yea it use fake policy | 14:04 |
mriedem | shouldn't it be on all calls to host_api.service_get_by_compute_host? | 14:04 |
*** VW_ has joined #openstack-nova | 14:04 | |
alex_xu | dikonoor: and you can follow this way https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/contrib/test_agents.py#L401 to fake a policy can accept normal user request | 14:05 |
alex_xu | dikonoor: then you can assert the non-admin context was elevated | 14:05 |
mriedem | johnthetubaguy: this was marked for kilo-rc-potential but i'm not sure it should be? https://review.openstack.org/#/c/160266/ | 14:06 |
dikonoor | mriedem : thanks for pointing me to test.py. I wasn't sure how it all fit in . alex_xu : Let me check that file..Thanks | 14:06 |
alex_xu | mriedem: it because other method have another call which have hard-code permission checks before for example:https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/contrib/hypervisors.py#L86 | 14:07 |
johnthetubaguy | mriedem: yeah, I think its because its a crazy meta bug on lots of project, and some other project wanted it in their RC | 14:07 |
alex_xu | mriedem: so in that bug, only the show method was break | 14:07 |
BobBall | asselin: ping | 14:07 |
alex_xu | dikonoor: np | 14:08 |
*** eharney has joined #openstack-nova | 14:08 | |
*** ajayaa has joined #openstack-nova | 14:08 | |
johnthetubaguy | BobBall: I replied on the ML to anthony about a Xen+libvirt issue and volumes | 14:09 |
BobBall | thanks johnthetubaguy - I saw it and forwarded to Anthony. Will let you know when we have a follow up. | 14:09 |
dikonoor | alex_xu : so I can override a rule in the fake_policy in this manner to " " or some other role | 14:09 |
mriedem | alex_xu: i don't understand the reference to https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/contrib/hypervisors.py#L86 | 14:09 |
alex_xu | dikonoor: no, if you change the fake_policy, I guess you will break some other unittest | 14:10 |
*** doude has joined #openstack-nova | 14:11 | |
dikonoor | alex_xu : I don't have to change the fake_policy but I should be able to override a specific rule | 14:11 |
mriedem | dikonoor: yes you can do that, sec, trying to find an example | 14:11 |
dikonoor | mriedem : on your question on - why are you only elevating the context in show for v2 api? , ideally it should be fixed for all.. but I wasn't sure if someone else was taking care of that.. | 14:12 |
alex_xu | mriedem: the problem is self.host_api.service_get_by_compute_host was added in the code. And it have hard-code permission checks, then the show only can be called by admin user | 14:12 |
mriedem | dikonoor: https://github.com/openstack/nova/blob/master/nova/tests/unit/network/test_api.py#L74 | 14:12 |
mriedem | alex_xu: yes i understand that | 14:13 |
mriedem | but dikonoor's patch is only fixing the 'show' method in the api extension | 14:13 |
*** cfriesen has joined #openstack-nova | 14:13 | |
alex_xu | mriedem: but for other method, like index, there is call to compute_nodes = self.host_api.compute_node_get_all(context) it include hard-code permission checks before also | 14:13 |
mriedem | not the other operations where host_api.service_get_by_compute_host is called | 14:13 |
*** signed8b_ has joined #openstack-nova | 14:13 | |
mriedem | alex_xu: you mean in the db api? | 14:13 |
mriedem | ah | 14:14 |
mriedem | @require_admin_context | 14:14 |
mriedem | def compute_node_get_all(context): | 14:14 |
alex_xu | mriedem: so the self.host_api.service_get_by_compute_host was added after that compute node db call, so index behavior isn't changed | 14:14 |
alex_xu | mriedem: yes | 14:14 |
mriedem | ok, makes sense | 14:14 |
mriedem | man i hate reviewing these changes :) | 14:14 |
alex_xu | :) | 14:14 |
alex_xu | dikonoor: | 14:15 |
dikonoor | mriedem : I am quite confused with how the other flows work in this respect and I would want to make small changes at a time | 14:15 |
alex_xu | dikonoor: that is way I suggest you can try this way https://github.com/openstack/nova/blob/master/nova/tests/unit/api/openstack/compute/contrib/test_agents.py#L401 | 14:15 |
*** lpetrut has quit IRC | 14:15 | |
*** nkrinner has quit IRC | 14:16 | |
*** signed8bit has quit IRC | 14:16 | |
*** doude has quit IRC | 14:17 | |
dikonoor | alex_xu : ok ..I will try adding something like this.. one for v2 and one for v2.1 .. | 14:17 |
*** doude has joined #openstack-nova | 14:17 | |
dikonoor | alex_xu: mriedem :Thanks | 14:17 |
alex_xu | dikonoor: np | 14:17 |
*** browne has joined #openstack-nova | 14:18 | |
*** johnthetubaguy is now known as zz_johnthetubagu | 14:20 | |
mriedem | dikonoor: alex_xu: i went through the other api opertations that call host_api.service_get_by_compute_host and the uptime method looks like it's also regresse | 14:20 |
mriedem | *regressed | 14:20 |
*** zz_johnthetubagu is now known as johnthetubaguy | 14:21 | |
mriedem | oh nvm, service_get_by_compute_host is called from host_api._assert_host_exists | 14:21 |
*** haomaiw__ has joined #openstack-nova | 14:22 | |
*** haomaiwa_ has quit IRC | 14:22 | |
openstackgerrit | Adelina Tuvenie proposed openstack/nova: Adds Hyper-V vNic hot-plug implementation https://review.openstack.org/138255 | 14:23 |
openstackgerrit | Adelina Tuvenie proposed openstack/nova: Adds Hyper-V OVS ViF driver https://review.openstack.org/140045 | 14:23 |
*** rwsu has joined #openstack-nova | 14:24 | |
alex_xu | mriedem: yea :) | 14:28 |
*** mtanino has joined #openstack-nova | 14:28 | |
*** rdo has quit IRC | 14:29 | |
mtanino | Hi, does anyone give me comments for this patch? This is a bug fix for medium bug. https://review.openstack.org/#/c/175067/ | 14:30 |
*** haomaiw__ has quit IRC | 14:32 | |
*** haomaiwa_ has joined #openstack-nova | 14:32 | |
*** Marga_ has joined #openstack-nova | 14:34 | |
*** achanda has joined #openstack-nova | 14:34 | |
*** jistr is now known as jistr|mtg | 14:35 | |
*** BadCub_Hiding is now known as BadCub | 14:36 | |
*** Marga_ has quit IRC | 14:36 | |
*** artom has joined #openstack-nova | 14:36 | |
*** Marga_ has joined #openstack-nova | 14:37 | |
*** haomaiwa_ has quit IRC | 14:38 | |
*** haomaiwang has joined #openstack-nova | 14:39 | |
openstackgerrit | Andrew Laski proposed openstack/nova: Remove downgrade support from the cellsv2 api db https://review.openstack.org/175551 | 14:40 |
*** thangp has joined #openstack-nova | 14:41 | |
openstackgerrit | sahid proposed openstack/nova: Correct the legacy serialization of NUMATopology https://review.openstack.org/152689 | 14:41 |
*** emagana has quit IRC | 14:41 | |
sahid | vladikr: +1 on functional tests you have added for numa ! you made my day :) | 14:42 |
*** rdo has joined #openstack-nova | 14:42 | |
sahid | http://logs.openstack.org/89/152689/14/check/gate-nova-tox-functional/7b2859f/testr_results.html.gz | 14:42 |
*** emagana has joined #openstack-nova | 14:42 | |
openstackgerrit | Sean Dague proposed openstack/nova: sync oslo: service child process normal SIGTERM exit https://review.openstack.org/176777 | 14:42 |
vladikr | sahid, I was hoping to :) | 14:42 |
sdague | dansmith: ok, ^^^ is the oslo sync | 14:42 |
sahid | ahah | 14:43 |
dansmith | sdague: and what are your intentions for kilo? | 14:43 |
sdague | we should backport to kilo | 14:43 |
dansmith | backport not rc3, yes? | 14:43 |
sdague | that's what we did for keystone and cinder | 14:44 |
dansmith | sdague: also, the wait_interval bit was proposed for nova at one point.. did that go in? | 14:44 |
*** achanda has quit IRC | 14:44 | |
sdague | I don't know | 14:44 |
dansmith | sdague: to be clear, you mean a normal backport to stable/kilo, and not make this force an rc3, yes? | 14:45 |
sdague | I think that's probably fine, our CI won't be reliable until we have this, but other people are probably kill -9ing things in init scripts | 14:45 |
dansmith | cool, I was going to say, -1 on this being rc3 :) | 14:46 |
dansmith | sdague: so, question... if this is really a problem with an inbound wsgi connection or something, | 14:46 |
sdague | dansmith: I don't know | 14:46 |
dansmith | sdague: can I keep SIGTERMing it until everything is clean and then have it exit | 14:46 |
*** emagana has quit IRC | 14:46 | |
sdague | dansmith: sure, so we could change the test infrastructure to go into a hard loop and term term term term | 14:47 |
sdague | however, the current approach did expose a real issue | 14:47 |
dansmith | sdague: no, I mean for workaround until the backport | 14:47 |
dansmith | like something to put into the release notes about known issues | 14:47 |
*** nelsnelson has joined #openstack-nova | 14:48 | |
dansmith | mriedem: needs +W ^ | 14:48 |
mriedem | looking | 14:48 |
dansmith | mriedem: I put an explanation of what we found in -qa | 14:48 |
mriedem | i guess this is pulling in other changes | 14:48 |
mriedem | since hte last sync | 14:48 |
sdague | ok, so... I guess the question is do you oppose landing this on the stable/kilo branch now? or this triggering an rc3? or are the 2 too coupled to ask that question. | 14:49 |
dansmith | one other change | 14:49 |
*** ankit_ag has quit IRC | 14:49 | |
sdague | mriedem: it's actually pulling in the aggregate of a revert - revert + fix | 14:49 |
*** beagles has quit IRC | 14:49 | |
*** haomaiwang has quit IRC | 14:49 | |
sdague | because that's how this code rolled this release | 14:49 |
dansmith | sdague: I don't oppose anything, I just thought we couldn't land anything else into stable/kilo until the release is done | 14:49 |
sdague | johnthetubaguy: ? | 14:49 |
dansmith | sdague: given that I can't +2 things there right now | 14:50 |
*** haomaiwang has joined #openstack-nova | 14:50 | |
*** nithyag_ has quit IRC | 14:50 | |
dansmith | couldn't land, unless we want it for an rc3 that is | 14:50 |
mriedem | which is https://review.openstack.org/#/c/175851/ | 14:50 |
mriedem | revert revert revert, nice | 14:50 |
sdague | let me ask ttx what he wants to do | 14:50 |
openstackgerrit | sahid proposed openstack/nova: Correct the legacy serialization of NUMATopology https://review.openstack.org/152689 | 14:51 |
dansmith | sdague: so all I meant was, if there will be a delay between kilo-final and people getting this fix, it would be nice if we could say that term term term is a workaround | 14:51 |
sdague | dansmith: sure | 14:51 |
dansmith | but not critical of course | 14:51 |
*** ildikov has quit IRC | 14:51 | |
mriedem | +W | 14:52 |
dansmith | mriedem: thanks | 14:52 |
tdurakov | dansmith, Hi, could you review https://review.openstack.org/#/c/173913/ again? | 14:53 |
dansmith | tdurakov: yeah, I'll get to it | 14:54 |
*** signed8b_ is now known as signed8bit_ZZZzz | 14:54 | |
tdurakov | dansmith: thanks! | 14:54 |
*** alexpilotti has quit IRC | 14:55 | |
tdurakov | there are some bug in launchpad about buggy live block migration with attached volume, should we mark them as Invalid? | 14:56 |
tdurakov | one for example: https://bugs.launchpad.net/nova/+bug/1303690 | 14:57 |
openstack | Launchpad bug 1303690 in OpenStack Compute (nova) "nova live-migration slow when using volumes" [Medium,Confirmed] | 14:57 |
*** signed8bit_ZZZzz is now known as signed8b_ | 14:57 | |
*** josecastroleon has quit IRC | 14:57 | |
tdurakov | sdague, what do you think? | 14:57 |
*** thangp has quit IRC | 14:58 | |
*** thomasem has quit IRC | 14:59 | |
*** ajayaa has quit IRC | 14:59 | |
*** Guest93081 is now known as beagles | 15:01 | |
*** ildikov has joined #openstack-nova | 15:01 | |
gilliard | tdurakov: should be invalid, since https://review.openstack.org/#/c/139085/ | 15:03 |
*** whenry has quit IRC | 15:03 | |
tdurakov | gilliard, ok | 15:04 |
*** marun has joined #openstack-nova | 15:04 | |
gilliard | tdurakov: I see you've backported that to stable/juno | 15:04 |
tdurakov | yep | 15:05 |
*** zzzeek has joined #openstack-nova | 15:05 | |
gilliard | Makes sense. IDK if 'invalid' or 'fixed' is more appropriate though, actually? | 15:06 |
tdurakov | as for me Invalid is more appropriate, we doesn't actually fix it, we close this functionality at all) | 15:07 |
*** baoli__ has quit IRC | 15:07 | |
*** lpetrut has joined #openstack-nova | 15:08 | |
gilliard | "we doesn't actually fix it" <-- true :) | 15:09 |
*** baoli has joined #openstack-nova | 15:09 | |
dansmith | tdurakov: spelling nit, then I'm good | 15:09 |
openstackgerrit | Timofey Durakov proposed openstack/nova: Fixed nova-network dhcp-hostsfile update during live-migration https://review.openstack.org/173913 | 15:10 |
johnthetubaguy | sdague: sorry, still getting dragged into meetings, as I escape them | 15:10 |
johnthetubaguy | sdague: whats up? | 15:10 |
dansmith | johnthetubaguy: question about merging things to stable/kilo now.. | 15:10 |
dansmith | johnthetubaguy: I think the answer is, we have to wait until final release, unless we're pushing something for rcN, right? | 15:11 |
dansmith | johnthetubaguy: (that was sdague's ping) | 15:11 |
sdague | ttx is processing rc efforts, once he gets a breath, lets get him in the conversation | 15:11 |
tdurakov | dansmith: done) | 15:11 |
johnthetubaguy | dansmith: +1 I think | 15:11 |
johnthetubaguy | dansmith: but yeah, ttx will be able to answer fully | 15:11 |
sdague | I'm also working on test work around code in parallel, so we can decide | 15:11 |
dansmith | cool | 15:12 |
dansmith | tdurakov: thanks | 15:12 |
*** ajayaa has joined #openstack-nova | 15:12 | |
*** Marga_ has quit IRC | 15:13 | |
johnthetubaguy | dansmith: sdague: FWIW I saw -2 on patches before we decided they go into an RC | 15:13 |
mriedem | dansmith: i'd agree that we can't merge things to stable/kilo unless we want them in an rc....although the 2015.1 release tag could be based on the rc2 tag | 15:13 |
*** Marga_ has joined #openstack-nova | 15:13 | |
dansmith | I'm going based on the fact that I don't have +2 privs on stable/kilo right now :) | 15:14 |
*** unicell has joined #openstack-nova | 15:14 | |
dansmith | assume that means ttx wants us hands off that branch :) | 15:14 |
sdague | hmmm.... the work around here is going to be more invasive than I thought | 15:14 |
sdague | we rm the pid file once we send the kill in devstack | 15:14 |
dansmith | sdague: I don't think we need to care about the workaround in grenade, | 15:14 |
dansmith | I just wanted to know if we could offer some help to ops that might hit this | 15:14 |
sdague | dansmith: yeh, sure, that's a "keep killing" | 15:15 |
dansmith | yeah | 15:15 |
dansmith | we just don't know if that actually works yet right?? | 15:15 |
dansmith | s/?$/ | 15:15 |
*** unicell1 has quit IRC | 15:15 | |
*** jlanoux has quit IRC | 15:16 | |
sdague | yeh, I'm trying to figure out how we'd validate that | 15:16 |
dansmith | I was just going to test it locally | 15:17 |
sdague | ok | 15:17 |
*** nelsnelson has quit IRC | 15:18 | |
openstackgerrit | dave-mcnally proposed openstack/nova: Add conf option to prevent snapshotting of volume backed instances https://review.openstack.org/176805 | 15:18 |
*** Marga_ has quit IRC | 15:18 | |
*** dboik has quit IRC | 15:18 | |
*** whenry has joined #openstack-nova | 15:19 | |
*** Nikolay_St has quit IRC | 15:20 | |
dansmith | I was delayed because my devstack was giving me shit | 15:20 |
*** claudiub has quit IRC | 15:20 | |
sdague | heh | 15:23 |
*** tonytan4ever has joined #openstack-nova | 15:24 | |
*** johnthetubaguy has left #openstack-nova | 15:24 | |
*** Nikolay_St has joined #openstack-nova | 15:24 | |
*** johnthetubaguy has joined #openstack-nova | 15:24 | |
*** apmelton_away is now known as apmelton | 15:24 | |
openstackgerrit | Claudiu Belu proposed openstack/nova: Fixes X509 keypair creation failure https://review.openstack.org/176817 | 15:25 |
dansmith | gah | 15:25 |
*** claudiub has joined #openstack-nova | 15:25 | |
dansmith | friggin cinder and loopdev | 15:25 |
dansmith | sdague: help: Unable to add physical volume '/dev/loop0' to volume group 'stack-volumes-default'. | 15:26 |
dansmith | clean.sh isn't getting me clean | 15:26 |
*** IanGovett has quit IRC | 15:26 | |
sdague | anything still left for mounted devices after a ./clean.sh? | 15:26 |
dansmith | I booted this fresh this morning so I don't think so, but let me try again | 15:27 |
*** dboik has joined #openstack-nova | 15:29 | |
dansmith | sdague: nothing mounted, loop0 is empty | 15:29 |
*** david-lyle has joined #openstack-nova | 15:29 | |
dansmith | figure I'll nuke /opt/stack | 15:29 |
*** armax has joined #openstack-nova | 15:30 | |
*** thangp has joined #openstack-nova | 15:30 | |
*** matrohon has quit IRC | 15:35 | |
*** derekh has quit IRC | 15:36 | |
*** oro has quit IRC | 15:36 | |
*** sandywalsh has quit IRC | 15:37 | |
*** popw has quit IRC | 15:37 | |
*** sandywalsh has joined #openstack-nova | 15:38 | |
*** Mike_D_laptop has joined #openstack-nova | 15:38 | |
dansmith | gah | 15:38 |
sdague | dansmith: ok, so this is going to trigger rc3 | 15:39 |
dansmith | sdague: what is? | 15:39 |
sdague | the patch | 15:39 |
dansmith | why? | 15:39 |
sdague | because it's the only way we can get it on the stable/kilo branch | 15:40 |
dansmith | I'm confused | 15:40 |
dansmith | we can just wait on the backport, right? | 15:40 |
sdague | if it's ok that neutron master is blocked until then | 15:40 |
*** davideagnello has joined #openstack-nova | 15:41 | |
dansmith | oh, I didn't think anything was blocking all the time, I thought it was just spotty? | 15:41 |
dansmith | and, I choose not to answer that question :) | 15:41 |
*** Nikolay_St has quit IRC | 15:41 | |
sdague | so, this started with trying to fix - https://review.openstack.org/#/c/176723/ | 15:42 |
dansmith | I think my problem is lib/cinder breaking my lvm.conf | 15:43 |
dansmith | sdague: okay, I don't have the context on that rename | 15:44 |
dansmith | but regardless, I thought this was only a sometimes-things-don't-exit thing | 15:45 |
sdague | dansmith: sometimes became a lot | 15:45 |
dansmith | hmm | 15:45 |
dansmith | feels like something else is going on | 15:45 |
sdague | it could be | 15:45 |
*** bkopilov has joined #openstack-nova | 15:46 | |
cfriesen | sdague: any plans to update https://review.openstack.org/#/c/169827/ ? | 15:47 |
*** fawadkhaliq has quit IRC | 15:47 | |
sdague | cfriesen: honestly, I was trying to rescue a patch out of the tracker, feel free to take if over | 15:47 |
sdague | I'm not likely to get back to it for a couple weeks | 15:47 |
cfriesen | sdague: okay, may do that depending on time constraints | 15:48 |
sdague | cfriesen: ok, great | 15:48 |
*** signed8b_ has quit IRC | 15:49 | |
*** nelsnelson has joined #openstack-nova | 15:49 | |
*** angdraug has joined #openstack-nova | 15:50 | |
*** atuvenie has quit IRC | 15:51 | |
*** tsekiyama has joined #openstack-nova | 15:52 | |
openstackgerrit | Victor Stinner proposed openstack/nova-specs: Add "Port Nova to Python 3" spec https://review.openstack.org/176868 | 15:53 |
*** dboik has quit IRC | 15:56 | |
*** alexschm has quit IRC | 15:56 | |
*** david-lyle has quit IRC | 15:56 | |
*** thomasem has joined #openstack-nova | 15:56 | |
*** claudiub has quit IRC | 15:57 | |
*** otter768 has joined #openstack-nova | 15:57 | |
*** amotoki_ has joined #openstack-nova | 15:59 | |
*** dboik has joined #openstack-nova | 16:00 | |
*** otter768 has quit IRC | 16:02 | |
*** sahid has quit IRC | 16:04 | |
*** VW_ has quit IRC | 16:04 | |
*** hemnafk is now known as hemna | 16:07 | |
*** emagana has joined #openstack-nova | 16:08 | |
*** tjones1 has joined #openstack-nova | 16:08 | |
*** rajesht has quit IRC | 16:10 | |
*** VW_ has joined #openstack-nova | 16:10 | |
*** VW_ has quit IRC | 16:11 | |
*** pkoniszewski has quit IRC | 16:11 | |
*** VW_ has joined #openstack-nova | 16:11 | |
*** emagana has quit IRC | 16:13 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/nova: Ironic: Parse and validate Node's properties https://review.openstack.org/176890 | 16:14 |
*** exploreshaifali has joined #openstack-nova | 16:14 | |
openstackgerrit | Roman Podoliaka proposed openstack/nova: Fix rebuild of an instance with a volume attached https://review.openstack.org/176891 | 16:15 |
openstackgerrit | Roman Podoliaka proposed openstack/nova: rebuild: make sure server is shut down before volumes are detached https://review.openstack.org/176892 | 16:15 |
*** emagana has joined #openstack-nova | 16:16 | |
*** aix has quit IRC | 16:17 | |
*** jistr|mtg is now known as jistr | 16:18 | |
*** unicell has quit IRC | 16:20 | |
*** ivasev has quit IRC | 16:20 | |
*** vilobhmm1 has joined #openstack-nova | 16:25 | |
*** kiran-r has quit IRC | 16:28 | |
*** vilobhmm1 has quit IRC | 16:29 | |
*** dikonoor has quit IRC | 16:29 | |
*** patrickeast has joined #openstack-nova | 16:31 | |
*** mwagner_lap has quit IRC | 16:31 | |
*** Nikolay_St has joined #openstack-nova | 16:32 | |
*** zz_jgrimm is now known as jgrimm | 16:36 | |
sc68cal | sdague: jaypipes: If you get a chance, could you take a look at https://review.openstack.org/#/c/168701/ ? It's the last patch before we can merge the dual stack testing change (https://review.openstack.org/#/c/160856/) | 16:38 |
jaypipes | sc68cal: will do! | 16:39 |
*** jcoufal has quit IRC | 16:41 | |
*** yassine_ has quit IRC | 16:42 | |
*** jistr has quit IRC | 16:43 | |
*** signed8bit has joined #openstack-nova | 16:44 | |
*** unicell has joined #openstack-nova | 16:46 | |
*** penick has joined #openstack-nova | 16:47 | |
*** unicell has quit IRC | 16:48 | |
*** unicell has joined #openstack-nova | 16:49 | |
*** signed8bit has quit IRC | 16:49 | |
*** oro has joined #openstack-nova | 16:49 | |
*** dboik has quit IRC | 16:51 | |
*** signed8bit has joined #openstack-nova | 16:51 | |
*** mpaolino has joined #openstack-nova | 16:52 | |
*** unicell has quit IRC | 16:54 | |
*** unicell has joined #openstack-nova | 16:54 | |
*** Nikolay_St has quit IRC | 16:55 | |
*** vilobhmm11 has joined #openstack-nova | 16:57 | |
*** dboik has joined #openstack-nova | 16:57 | |
*** vilobhmm12 has joined #openstack-nova | 16:58 | |
*** fawadkhaliq has joined #openstack-nova | 16:59 | |
*** vilobhmm11 has quit IRC | 17:01 | |
*** johnthetubaguy is now known as zz_johnthetubagu | 17:01 | |
*** rushil has quit IRC | 17:02 | |
*** cbader has quit IRC | 17:03 | |
*** cbader has joined #openstack-nova | 17:03 | |
*** rushil has joined #openstack-nova | 17:04 | |
*** alexpilotti has joined #openstack-nova | 17:05 | |
*** ildikov has quit IRC | 17:05 | |
*** lucasagomes has quit IRC | 17:05 | |
*** jichen has quit IRC | 17:06 | |
*** rushiagr_away is now known as rushiagr | 17:07 | |
*** Longgeek_ has quit IRC | 17:07 | |
*** ivasev has joined #openstack-nova | 17:07 | |
*** Nikolay_St has joined #openstack-nova | 17:08 | |
*** neelashah has quit IRC | 17:08 | |
mriedem | dansmith: trying to re-wrap my head around flwang's patch here https://review.openstack.org/#/c/164494/ - we need an rpcapi version bump to know that volume-backed backup won't work on a juno compute, but i'm at a loss for where we fail that case | 17:10 |
mriedem | in a previous patch set (6) he was actually passing is_volume_backed kwarg to the rpc api | 17:10 |
dansmith | mriedem: if we send this message as 4.x juno will refuse to accept it | 17:11 |
dansmith | so that part is automatic | 17:11 |
dansmith | and 4.1 will cause kilo to refuse it | 17:11 |
dansmith | because kilo understands only 4.0 | 17:11 |
dansmith | what he's doing here though breaks compatibility | 17:12 |
dansmith | I'll comment | 17:12 |
*** romainh has left #openstack-nova | 17:13 | |
*** harlowja_away is now known as harlowja | 17:13 | |
*** tonytan4ever has quit IRC | 17:13 | |
*** pmyers has joined #openstack-nova | 17:14 | |
*** pmyers has left #openstack-nova | 17:16 | |
*** alexpilotti has quit IRC | 17:16 | |
*** Nikolay_St has quit IRC | 17:18 | |
*** Hosam has quit IRC | 17:19 | |
*** browne has quit IRC | 17:20 | |
*** achanda has joined #openstack-nova | 17:21 | |
*** Nikolay_St has joined #openstack-nova | 17:22 | |
*** neelashah has joined #openstack-nova | 17:22 | |
*** Maike has quit IRC | 17:23 | |
vilobhmm12 | johnthetubaguy : ping if you are still around | 17:23 |
*** ndipanov has quit IRC | 17:23 | |
*** neelashah1 has joined #openstack-nova | 17:23 | |
dansmith | vilobhmm12: he's not | 17:23 |
dansmith | not until around the meeting time, AIUI | 17:24 |
vilobhmm12 | ok | 17:24 |
vilobhmm12 | thanks for letting me know | 17:24 |
mriedem | dansmith: your comment made sense, the only thing i'm wondering about was how to explicitly fail if you can't send 4.1 and is_volume_backed==True? | 17:25 |
dansmith | mriedem: raise something | 17:25 |
mriedem | ok, that's too simple. :) i didn't see any other ops doing this in there already so figured it was something else | 17:26 |
*** neelashah has quit IRC | 17:27 | |
dansmith | well, usually we're just converting the call into the thing that is compatible | 17:27 |
dansmith | but here we don't have any such thing | 17:27 |
dansmith | so we need to signal to the upper layers that it can't do this | 17:27 |
*** jwcroppe has joined #openstack-nova | 17:28 | |
dansmith | which is basically, some exception, where it will do the same thing it does now if it's unsupported | 17:28 |
dansmith | and once the pin is lifted, then it'll just start working | 17:28 |
*** sdake has joined #openstack-nova | 17:28 | |
*** doude has quit IRC | 17:28 | |
*** doude has joined #openstack-nova | 17:29 | |
mriedem | ok, this is a fun little patch | 17:29 |
*** alanf-mc has joined #openstack-nova | 17:30 | |
openstackgerrit | Chris Friesen proposed openstack/nova: fix network setup on evacuate https://review.openstack.org/169827 | 17:31 |
*** signed8bit has quit IRC | 17:31 | |
*** kiran-r has joined #openstack-nova | 17:34 | |
*** signed8bit has joined #openstack-nova | 17:34 | |
*** marun has quit IRC | 17:34 | |
*** claudiub has joined #openstack-nova | 17:35 | |
*** tonytan4ever has joined #openstack-nova | 17:35 | |
*** patrickeast_ has joined #openstack-nova | 17:36 | |
*** patrickeast has quit IRC | 17:37 | |
*** patrickeast_ is now known as patrickeast | 17:37 | |
*** dprince has quit IRC | 17:38 | |
*** dboik has quit IRC | 17:38 | |
*** dboik has joined #openstack-nova | 17:39 | |
openstackgerrit | Jim Rollenhagen proposed openstack/nova: Objects: Fix instance.system_metadata tracking https://review.openstack.org/176920 | 17:39 |
jroll | dansmith: ^ how (in)valid is this test case? | 17:40 |
dansmith | VERY INVALID | 17:41 |
jroll | (it should fail, to be clear, I think I've found a bug here) | 17:41 |
jroll | heh | 17:41 |
* dansmith actually looks at it | 17:41 | |
dansmith | jroll: that says "fix it" but it just adds a test | 17:41 |
*** ZZelle_ has joined #openstack-nova | 17:41 | |
jroll | dansmith: right, it's incomplete | 17:41 |
dansmith | it should be tracked now | 17:41 |
* jroll WIPs | 17:41 | |
jroll | so, for background, I've had cases where this isn't taking: https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L2491 | 17:42 |
*** isd1 has joined #openstack-nova | 17:42 | |
dansmith | jroll: hmm, not sure why that would be | 17:42 |
dansmith | jroll: regardless, the test shouldn't need to create rows in the db | 17:43 |
jroll | dansmith: right, I'm not either, reading the code. but I finally wrote a failing test case, which is why I wanted to poke you and see if you see immediate problems with it | 17:43 |
dansmith | that fails? | 17:43 |
jroll | yes | 17:43 |
jroll | I created rows in the db, because it was otherwise failing with orphaned instances errors | 17:44 |
jroll | mocking obj_load_attr may handle that though | 17:44 |
dansmith | are you trying to simulate the case where it's set when it's not loaded? | 17:44 |
dansmith | because that's what you're doing and why you're getting that lazy load | 17:44 |
*** sileht has quit IRC | 17:44 | |
openstackgerrit | Tracy Jones proposed openstack/nova: Cleanup of compute api reboot method https://review.openstack.org/127427 | 17:45 |
*** lpetrut has quit IRC | 17:45 | |
tjones1 | dansmith: ^^ blush… that's what i get for doing too many things at the same time. | 17:45 |
dansmith | tjones1: yeah :-( | 17:45 |
jroll | dansmith: I'm thinking so, but honestly unsure | 17:45 |
*** annegent_ has joined #openstack-nova | 17:46 | |
tjones1 | sorry about that | 17:46 |
dansmith | jroll: so, what you have there is too invasive to be legit I think, unless you're poking some really obscure thing | 17:46 |
*** thomasem has quit IRC | 17:46 | |
dansmith | jroll: if you add this to the instance object creation: | 17:46 |
dansmith | inst = instance.Instance(context=self.context, system_metadata={}) | 17:47 |
*** eglynn has quit IRC | 17:47 | |
dansmith | jroll: then you shouldn't need to inst.create() it, nor the mocks for lazy load, etc | 17:47 |
dansmith | jroll: the actual code in the manager you're pointing to there should never arrive at a place where system_metadata is unset, I think | 17:47 |
dansmith | jroll: if it is, then *that* is probably what needs fixing | 17:47 |
jroll | dansmith: ok, I'll play with it | 17:48 |
dansmith | cool | 17:48 |
*** jwcroppe has quit IRC | 17:48 | |
jroll | dansmith: I also just realized I'm not actually changing the value, I meant to have baz in there somewhere | 17:48 |
*** jwcroppe has joined #openstack-nova | 17:48 | |
dansmith | heh | 17:49 |
*** annegentle has quit IRC | 17:50 | |
jroll | dansmith: so if system_metadata isn't set in that manager code, why would that be a problem, wouldn't it just load it at that point? | 17:52 |
dansmith | jroll: it should yeah | 17:52 |
jroll | yeah, don't see why that would cause this | 17:53 |
*** dprince has joined #openstack-nova | 17:53 | |
*** lennyb has joined #openstack-nova | 17:55 | |
jroll | fwiw, doing the sm = inst.system_metadata; sm['network_allocated'] = 'False'; inst.system_metadata = sm; dance seems to have fixed this in my environment, though it's hard to tell since it's on reschedule | 17:55 |
*** sileht has joined #openstack-nova | 17:55 | |
openstackgerrit | Chris Friesen proposed openstack/nova: fix network setup on evacuate https://review.openstack.org/169827 | 17:56 |
openstackgerrit | Andrew Laski proposed openstack/nova: Cells: Limit instances pulled in _heal_instances https://review.openstack.org/176925 | 17:56 |
dansmith | jroll: well, that'd be a classic example of missing noticing that it's changed, of course | 17:56 |
jroll | dansmith: right, it's really odd | 17:56 |
dansmith | jroll: any chance the thing is already False, we set it to False, so the save() doesn't do anything because nothing is changed, and the thing that fails is actually because we didn't do other things in save? | 17:57 |
dansmith | meaning the workaround you do above will always make us save, even if the value was already False | 17:57 |
dansmith | maybe log the value first to see if we're really changing it? | 17:57 |
jroll | dansmith: well, the thing failing is because it's True, and in the same thread and whatnot | 17:57 |
jroll | I have some logs, sec | 17:58 |
*** otter768 has joined #openstack-nova | 17:58 | |
*** jwcroppe has quit IRC | 17:59 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/176844 | 18:00 |
*** ildikov has joined #openstack-nova | 18:00 | |
*** aswadr has quit IRC | 18:01 | |
jroll | dansmith: https://gist.github.com/jimrollenhagen/67b06f73c698cc07dd93 | 18:01 |
dansmith | jroll: oh you mean the save is yanking it back to true? | 18:02 |
jroll | dansmith: yes | 18:02 |
dansmith | okay, this is different I tink | 18:02 |
*** ijw has joined #openstack-nova | 18:02 | |
*** otter768 has quit IRC | 18:03 | |
*** claudiub has quit IRC | 18:03 | |
jroll | dansmith: and just to be clear, this code is 20 days behind master and running in cells | 18:04 |
dansmith | oh cells | 18:04 |
*** browne has joined #openstack-nova | 18:04 | |
jroll | x.x | 18:04 |
*** kiran-r has quit IRC | 18:04 | |
*** jwcroppe has joined #openstack-nova | 18:05 | |
*** rajesht has joined #openstack-nova | 18:06 | |
jroll | dansmith: this is within the same request/thread/etc, so I'm hoping cells doesn't matter... but there's cells code in save() so you never know | 18:07 |
*** tjones1 has quit IRC | 18:07 | |
dansmith | jroll: well, this kinda seems like a race to update the DB, and that you're getting True back because that's what is in the database | 18:07 |
*** david-lyle has joined #openstack-nova | 18:07 | |
dansmith | jroll: have you tried adding logging to see if it's actually saving the system_metadata in that call? | 18:07 |
dansmith | like, you were concerned that maybe it's not noticing the change, but have you tried like running obj_what_changed() right before the save call? | 18:08 |
*** tjones1 has joined #openstack-nova | 18:08 | |
dansmith | also maybe alaski has some ideas if it happens to be cells-related | 18:08 |
alaski | I don't think it is, I looked at it a bit yesterdya | 18:08 |
dansmith | okay | 18:08 |
alaski | I'm also interested in what some logging would find | 18:08 |
jroll | dansmith: I think those logs are the best I've got right now | 18:09 |
dansmith | jroll: well, I don't think they tell us much | 18:09 |
dansmith | jroll: can you repro with more? | 18:09 |
jroll | and I don't know why what we're seeing there would be a db race or whatever | 18:09 |
dansmith | well, | 18:09 |
jroll | I guess I don't understand why calling save() would change the contents of sysmeta | 18:10 |
dansmith | the instance refreshes itself during the save | 18:10 |
jroll | mmmm | 18:10 |
jroll | right. | 18:10 |
jroll | fun | 18:10 |
alaski | yeah, it seems like the object sysmeta is set to true and the db is false, but the db doesn't get updated | 18:10 |
jroll | but those *should* be talking to the same db, alaski correct me if I'm wrong there with our env | 18:10 |
dansmith | opposite I think | 18:10 |
jroll | yeah, opposite | 18:11 |
dansmith | sure | 18:11 |
*** rajesht has quit IRC | 18:11 | |
alaski | right, opposite | 18:11 |
*** melwitt has joined #openstack-nova | 18:11 | |
dansmith | but if something else changes it between when you changed it and it returns.. | 18:11 |
alaski | jroll: yeah, same db | 18:11 |
dansmith | because we do sync the metadata in a separate transaction, because $reasons | 18:11 |
jroll | right | 18:11 |
jroll | are there any periodic tasks that update sysmeta? | 18:12 |
dansmith | probably :) | 18:12 |
jroll | goody | 18:12 |
jroll | dansmith: I'll drop some extra logging and whatnot in there, might be this afternoon before I really get into it | 18:13 |
jroll | thanks for the help | 18:13 |
dansmith | okay | 18:13 |
dansmith | any chance we can just pretend this isn't happening? :) | 18:14 |
jroll | heh, dunno, seems people get upset when their instances don't have networking :) | 18:14 |
dansmith | to quote mriedem, "let them eat cake" | 18:15 |
*** gyee has joined #openstack-nova | 18:15 | |
*** dboik_ has joined #openstack-nova | 18:15 | |
jroll | :P | 18:15 |
mriedem | heh | 18:15 |
mriedem | i said that at least twice yesterday | 18:15 |
mriedem | and still have my head | 18:15 |
mriedem | on the plus side for me, | 18:16 |
mriedem | a guy internally has been bugging me for a week about why his compute node won't register with his controller, | 18:16 |
mriedem | got on the controller and the disk was full, rpc was going insane in neutron eating up the logs, db connection was lost, the whole shebang | 18:17 |
alaski | hmm, I'm sort of suprised our periodic tasks don't use a lock | 18:17 |
mriedem | alaski: sync_instance_power_state does | 18:17 |
mriedem | well.....the periodic task does, the lifecycle event stuff does not | 18:17 |
jroll | alaski: sooo about this clustered compute thing..... | 18:17 |
*** derekh has joined #openstack-nova | 18:17 | |
* jroll hides | 18:17 | |
alaski | jroll: yeah, I was about to get to that :) | 18:18 |
jroll | I'm curious if we can drop a compute and still reproduce this | 18:18 |
*** dboik has quit IRC | 18:18 | |
alaski | mriedem: cool. just found that. none of the others seem to | 18:18 |
*** redbeard has quit IRC | 18:19 | |
*** mpaolino has quit IRC | 18:23 | |
*** morganfainberg is now known as grebniafnagrom | 18:24 | |
*** grebniafnagrom is now known as morganfainberg | 18:24 | |
*** yassine_ has joined #openstack-nova | 18:24 | |
*** yassine_ has quit IRC | 18:25 | |
*** alexpilotti has joined #openstack-nova | 18:27 | |
*** exploreshaifali has quit IRC | 18:28 | |
*** MVenesio has joined #openstack-nova | 18:28 | |
*** gyee has quit IRC | 18:30 | |
*** VW_ has quit IRC | 18:35 | |
*** ArxCruz_ has joined #openstack-nova | 18:35 | |
*** ArxCruz_ has quit IRC | 18:36 | |
*** VW_ has joined #openstack-nova | 18:38 | |
*** VW__ has joined #openstack-nova | 18:39 | |
*** nikhil_k is now known as nikhil_k-bbiab | 18:40 | |
*** VW_ has quit IRC | 18:42 | |
*** lennyb has quit IRC | 18:45 | |
*** lennyb has joined #openstack-nova | 18:46 | |
*** alexpilotti_ has joined #openstack-nova | 18:46 | |
wasmum | running centos 7 following the juno docs, line by line. getting a vif_binding_fail and no host found. Anyone else seen that following those docs? | 18:47 |
wasmum | *vif_type_binding | 18:47 |
dansmith | wasmum: please see topic | 18:48 |
wasmum | sorry wrong room, thanks dansmith | 18:48 |
*** ZZelle has quit IRC | 18:48 | |
*** ZZelle has joined #openstack-nova | 18:49 | |
*** alexpilotti has quit IRC | 18:49 | |
*** derekh has quit IRC | 18:49 | |
*** alexpilotti_ is now known as alexpilotti | 18:49 | |
mikehn | hey guys, how can i avoid "mysql server has gone away" errors? i tweaked all the timeout settings and stuff but they continue to happen, just like with keystone and glance etc | 18:52 |
*** jwcroppe has quit IRC | 18:54 | |
*** doude has quit IRC | 18:55 | |
*** doude has joined #openstack-nova | 18:55 | |
*** amotoki_ has quit IRC | 18:57 | |
*** jwcroppe_ has joined #openstack-nova | 18:58 | |
mriedem | mikehn: see topic, | 18:58 |
*** angdraug has quit IRC | 18:58 | |
mriedem | also, a google search and ask.openstack.org search on that error shows several hits to dig into | 18:58 |
mikehn | mriedem: well nova-api gives the errors too :) | 18:59 |
mikehn | oh well | 18:59 |
openstackgerrit | Andrew Laski proposed openstack/nova: Cells: Limit instances pulled in _heal_instances https://review.openstack.org/176925 | 18:59 |
mikehn | dev | 18:59 |
mikehn | true | 18:59 |
mikehn | google and ask dont give me the solution, only the max packet size and timeout | 18:59 |
*** derekh has joined #openstack-nova | 19:00 | |
*** mwagner_lap has joined #openstack-nova | 19:03 | |
*** kaisers has quit IRC | 19:05 | |
*** ivasev has quit IRC | 19:06 | |
*** kaisers has joined #openstack-nova | 19:06 | |
*** sdake_ has joined #openstack-nova | 19:09 | |
*** patrickeast has quit IRC | 19:10 | |
*** sdake has quit IRC | 19:12 | |
*** jichen has joined #openstack-nova | 19:14 | |
*** rushiagr is now known as rushiagr_away | 19:14 | |
*** ivasev has joined #openstack-nova | 19:15 | |
*** marun has joined #openstack-nova | 19:15 | |
*** VW__ has quit IRC | 19:15 | |
*** nelsnelson has quit IRC | 19:17 | |
*** tjones1 has quit IRC | 19:17 | |
*** browne has quit IRC | 19:18 | |
*** tjones1 has joined #openstack-nova | 19:19 | |
*** browne has joined #openstack-nova | 19:19 | |
*** nikhil_k-bbiab is now known as nikhil_k | 19:20 | |
openstackgerrit | Chris Friesen proposed openstack/nova: unify libvirt driver checks for qemu https://review.openstack.org/175542 | 19:30 |
*** penick has quit IRC | 19:32 | |
*** liusheng has quit IRC | 19:34 | |
*** penick has joined #openstack-nova | 19:37 | |
*** ociuhandu has quit IRC | 19:38 | |
*** annegent_ has quit IRC | 19:40 | |
*** annegentle has joined #openstack-nova | 19:41 | |
*** ildikov has quit IRC | 19:41 | |
*** lpetrut has joined #openstack-nova | 19:41 | |
openstackgerrit | Dan Smith proposed openstack/nova: Add some testing for flavor migrations with deleted things https://review.openstack.org/176955 | 19:41 |
*** yuntong has quit IRC | 19:41 | |
*** jecarey has quit IRC | 19:42 | |
*** yuntong has joined #openstack-nova | 19:42 | |
*** smccully has quit IRC | 19:45 | |
*** smccully has joined #openstack-nova | 19:45 | |
*** Nikolay_St has quit IRC | 19:46 | |
*** pixelb has quit IRC | 19:50 | |
*** Nikolay_St has joined #openstack-nova | 19:52 | |
cfriesen | looks like I'm going to the summit...is there a cutoff for merged submissions after which the ATC pass is only good for the next summit? | 19:55 |
*** MVenesio has quit IRC | 19:55 | |
*** yuntong has quit IRC | 19:56 | |
*** yuntong has joined #openstack-nova | 19:56 | |
*** amotoki_ has joined #openstack-nova | 19:57 | |
*** ajayaa has quit IRC | 19:58 | |
*** annashen has joined #openstack-nova | 19:58 | |
*** mtanino has quit IRC | 19:58 | |
*** otter768 has joined #openstack-nova | 19:59 | |
*** patrickeast has joined #openstack-nova | 19:59 | |
*** Sukhdev has joined #openstack-nova | 19:59 | |
dansmith | cfriesen: if you haven't used your ATC pass yet, it's too late | 20:02 |
dansmith | as I understand it | 20:02 |
dansmith | for vancouver, that is | 20:02 |
*** angdraug has joined #openstack-nova | 20:02 | |
*** Nikolay_St has quit IRC | 20:03 | |
cfriesen | I never actually got one...was just wondering when the cutoff date for merged patches was to qualify for ATC. | 20:03 |
dansmith | I would expect it was just before the cutoff for using the ATC pass | 20:03 |
*** Nikolay_St has joined #openstack-nova | 20:03 | |
dansmith | as if they issued you one now, it wouldn't matter because it's not a valid discount anymore | 20:04 |
dansmith | so my point is, if you don't have one, you won't get one until next cycle | 20:04 |
*** otter768 has quit IRC | 20:04 | |
mriedem | cfriesen: http://stackalytics.com/?metric=commits&user_id=cbf123&release=kilo | 20:04 |
mriedem | yeah a bit late | 20:04 |
mriedem | cfriesen: you will have one for liberty though | 20:04 |
*** annashen has quit IRC | 20:04 | |
mriedem | http://stackalytics.com/?metric=commits&user_id=cbf123&release=liberty | 20:04 |
mriedem | so...see you in tokyo! | 20:05 |
cfriesen | hopefully | 20:05 |
dansmith | well, | 20:05 |
dansmith | he could still come | 20:05 |
dansmith | he'd just have to pay :) | 20:05 |
mriedem | true | 20:05 |
cfriesen | I'm coming to vancouver...just got approval | 20:05 |
mriedem | or concoct some elaborate 80s style movie scheme to get in | 20:05 |
mriedem | with antics to ensue | 20:05 |
*** annashen has joined #openstack-nova | 20:06 | |
* cfriesen creates fake badge and sneaks in | 20:06 | |
melwitt | cfriesen here's some info, if you still are curious about cutoff date https://ask.openstack.org/en/question/45531/atc-pass-for-the-openstack-summit/ | 20:06 |
mriedem | i'm thinking more along the lines of weekend at barneys | 20:07 |
mriedem | *bernies | 20:07 |
cfriesen | melwitt: I saw that...it doesn't actually give the cutoff date for kilo, just the start date. | 20:07 |
melwitt | cfriesen: oh, well it says "the last batch of invites is sent right after the Feature Freeze" | 20:07 |
melwitt | which I think was around march 19 or so | 20:08 |
dansmith | and all the emails said "no exceptions at all" | 20:08 |
dansmith | so I dunno if that's a hard line or not | 20:08 |
cfriesen | okay, thanks all. full price it is. | 20:09 |
*** annashen has quit IRC | 20:12 | |
*** hanzhang has quit IRC | 20:12 | |
*** mtanino has joined #openstack-nova | 20:12 | |
*** hanzhang has joined #openstack-nova | 20:13 | |
*** Nikolay_St has quit IRC | 20:13 | |
*** Mike_D_laptop has quit IRC | 20:13 | |
*** Nikolay_St has joined #openstack-nova | 20:14 | |
*** fawadkhaliq has quit IRC | 20:14 | |
openstackgerrit | Dan Smith proposed openstack/nova: Wedge DB migrations if flavor migrations are not complete https://review.openstack.org/174480 | 20:17 |
openstackgerrit | Andrew Laski proposed openstack/nova-specs: WIP RequestSpec object split instance_properties https://review.openstack.org/176967 | 20:18 |
openstackgerrit | Andrew Laski proposed openstack/nova-specs: RequestSpec object split instance_properties https://review.openstack.org/176967 | 20:19 |
openstackgerrit | Andrew Laski proposed openstack/nova-specs: RequestSpec object split instance_properties https://review.openstack.org/176083 | 20:20 |
*** marun has quit IRC | 20:21 | |
*** igordcard has joined #openstack-nova | 20:26 | |
*** overlayer has joined #openstack-nova | 20:26 | |
*** jecarey has joined #openstack-nova | 20:26 | |
*** overlayer has quit IRC | 20:27 | |
*** matrohon has joined #openstack-nova | 20:28 | |
*** andreykurilin__ has joined #openstack-nova | 20:28 | |
zigo | dansmith: jaypipes: I noticed that the generated nova.conf.sample is wrong, with the keystone_authtoken missing half of the directives. I first noticed the issue in Cinder, and as a consequence, jgriffith wrote a patch to stop using tools/config/generate_sample.sh and to use oslo-config-generator directly, which fixed the issue. | 20:29 |
zigo | So, both nova & cinder have the issue... | 20:29 |
dansmith | zigo: okay, is there a question coming? :) | 20:31 |
zigo | dansmith: Hum.... Can you fix it? :) | 20:32 |
zigo | :D | 20:32 |
mriedem | zigo: link to jgriffith's cinder patch? | 20:32 |
dansmith | zigo: probably no better than you can | 20:32 |
dansmith | heh, my next question :) | 20:32 |
zigo | https://review.openstack.org/#/c/176857/ | 20:33 |
zigo | That's probably not so helpful, as nova is using a different set of libs, so the oslo-config-generator call must be different. | 20:33 |
dansmith | that was abandoned? | 20:33 |
*** fawadkhaliq has joined #openstack-nova | 20:34 | |
zigo | This one must be better: https://review.openstack.org/#/c/165431/ | 20:34 |
mriedem | "better" | 20:34 |
mriedem | it's not trivial | 20:34 |
dansmith | yeah, jeez | 20:35 |
mriedem | i think jogo is the oslo liasion so let's just make him fix it | 20:35 |
dansmith | +2 | 20:35 |
*** dboik_ has quit IRC | 20:36 | |
*** artom has quit IRC | 20:36 | |
*** Nikolay_St has quit IRC | 20:38 | |
zigo | I don't mind the way it's done, but the fact is, we can't leave nova.conf.sample with half of the keystone_authtoken directives removed (including tenant_name, password, URI and so on...). | 20:38 |
*** marun has joined #openstack-nova | 20:39 | |
*** achanda has quit IRC | 20:41 | |
*** neelashah1 has quit IRC | 20:41 | |
*** tonytan4ever has quit IRC | 20:42 | |
*** annashen has joined #openstack-nova | 20:42 | |
*** signed8bit has quit IRC | 20:43 | |
*** jgrimm is now known as zz_jgrimm | 20:43 | |
*** Nikolay_St has joined #openstack-nova | 20:43 | |
*** gtt116 has quit IRC | 20:44 | |
*** gtt116 has joined #openstack-nova | 20:44 | |
*** raildo has quit IRC | 20:45 | |
*** tonytan4ever has joined #openstack-nova | 20:46 | |
*** n0ano has joined #openstack-nova | 20:51 | |
jgriffith | mriedem: Had to make an adjustment: https://review.openstack.org/#/c/176930/ | 20:51 |
*** derekh has quit IRC | 20:51 | |
*** samueldmq has quit IRC | 20:51 | |
mriedem | jgriffith: that's much nicer short-term :) | 20:51 |
jgriffith | mriedem: yeah | 20:52 |
*** aruban has joined #openstack-nova | 20:52 | |
mriedem | added nova to the bug | 20:52 |
*** aruban has quit IRC | 20:52 | |
jgriffith | mriedem: although honestly when I looked at what others are doing with the opts.py file I'm considering polishing slightly and keeping it long term :) | 20:52 |
*** aruban has joined #openstack-nova | 20:53 | |
openstackgerrit | Tracy Jones proposed openstack/nova: Cleanup of compute api reboot method https://review.openstack.org/127427 | 20:53 |
*** dboik has joined #openstack-nova | 20:55 | |
*** fawadkhaliq has quit IRC | 20:57 | |
*** ijw has quit IRC | 20:59 | |
mriedem | meeting time? | 21:01 |
bauzas | nova meeting now ? | 21:01 |
bauzas | (back from PTO today) | 21:01 |
*** unicell has quit IRC | 21:01 | |
*** unicell1 has joined #openstack-nova | 21:01 | |
bauzas | eh, zombie meeting ? | 21:03 |
openstackgerrit | Joel Coffman proposed openstack/nova: Remove comment inconsistent with code https://review.openstack.org/176984 | 21:05 |
*** zz_johnthetubagu is now known as johnthetubaguy | 21:05 | |
*** Nikolay_St has quit IRC | 21:05 | |
*** ivasev has quit IRC | 21:06 | |
*** Nikolay_St has joined #openstack-nova | 21:06 | |
*** aruban has quit IRC | 21:07 | |
*** lpetrut has quit IRC | 21:07 | |
*** tonytan4ever has quit IRC | 21:09 | |
*** signed8bit has joined #openstack-nova | 21:11 | |
*** baoli has quit IRC | 21:14 | |
*** annegentle has quit IRC | 21:15 | |
*** thangp has quit IRC | 21:15 | |
*** tonytan4ever has joined #openstack-nova | 21:16 | |
*** annegentle has joined #openstack-nova | 21:20 | |
zigo | dansmith: mriedem: jgriffith just pinged and gave me this as a new patch for Cinder: https://review.openstack.org/gitweb?p=openstack%2Fcinder.git;a=commitdiff;h=51a22591a44932463847ed3247899db32ac49444 maybe the same approach could be used to fix Nova? | 21:21 |
mriedem | zigo: yes, jgriffith already did that ^ | 21:22 |
zigo | :) | 21:22 |
mriedem | zigo: feel free to push the patch for nova that mimics that :) | 21:22 |
mriedem | nova meeting atm | 21:22 |
*** dboik has quit IRC | 21:22 | |
zigo | mriedem: I'm busy finishing the Debian packages for Kilo, I have no time to do "upstream work", sorry. | 21:22 |
*** apmelton is now known as apmelton_away | 21:26 | |
*** cbader has quit IRC | 21:26 | |
*** jichen has quit IRC | 21:26 | |
jgriffith | mriedem: I'm pushing it now assuming you guys are ok with it? | 21:27 |
mriedem | sure | 21:27 |
*** eharney has quit IRC | 21:28 | |
openstackgerrit | Dan Smith proposed openstack/nova: Wedge DB migrations if flavor migrations are not complete https://review.openstack.org/174480 | 21:29 |
jgriffith | mriedem: I *think* the same libs in Nova (as far as ones that take conf options) | 21:30 |
*** Nikolay_St has quit IRC | 21:32 | |
*** busterswt has quit IRC | 21:32 | |
openstackgerrit | John Griffith proposed openstack/nova: Add external genconfig calls https://review.openstack.org/176995 | 21:35 |
*** pixelb has joined #openstack-nova | 21:36 | |
openstackgerrit | John Griffith proposed openstack/nova: Add external genconfig calls https://review.openstack.org/176995 | 21:36 |
*** Nikolay_St has joined #openstack-nova | 21:38 | |
*** oro has quit IRC | 21:38 | |
*** achanda has joined #openstack-nova | 21:41 | |
*** thumpba_ has joined #openstack-nova | 21:43 | |
mikal | . | 21:44 |
*** annegentle has quit IRC | 21:44 | |
*** mpaolino has joined #openstack-nova | 21:45 | |
*** gyee has joined #openstack-nova | 21:48 | |
*** mpaolino has quit IRC | 21:49 | |
thumpba_ | im having an issue where vm's on the same compute cannot talk to each other | 21:49 |
thumpba_ | im running nova on each compute | 21:50 |
thumpba_ | not sure how to solve this. it started happening after the compute was rebooted | 21:50 |
*** derekh has joined #openstack-nova | 21:51 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/176844 | 21:51 |
*** dprince has quit IRC | 21:53 | |
*** matrohon has quit IRC | 21:55 | |
mriedem | another wonderful nova meeting | 21:59 |
*** burt has quit IRC | 21:59 | |
*** Sukhdev has quit IRC | 21:59 | |
*** Nikolay_St has quit IRC | 21:59 | |
bauzas | mriedem: I liked the topic titles :p | 22:00 |
*** otter768 has joined #openstack-nova | 22:00 | |
*** Nikolay_St has joined #openstack-nova | 22:00 | |
*** joefides has quit IRC | 22:00 | |
mriedem | as in 0 topic titles? | 22:01 |
mriedem | last time i tried doing those i screwed it up and everyone laughed me out of the room so i gave up | 22:01 |
mriedem | *sniff* | 22:01 |
*** Sukhdev has joined #openstack-nova | 22:01 | |
bauzas | yeah, no topics plus no actions == perfect meeting :) | 22:01 |
thumpba_ | im having an issue where vm's on the same compute cannot talk to each other | 22:01 |
*** johnthetubaguy is now known as zz_johnthetubagu | 22:01 | |
mriedem | thumpba_: see the topic of the channel please | 22:01 |
bauzas | thumpba_: see $subject | 22:01 |
thumpba_ | thanks | 22:02 |
*** thumpba_ has left #openstack-nova | 22:02 | |
bauzas | mriedem: you know #undo right ? :) | 22:02 |
*** rushil has quit IRC | 22:02 | |
*** Guest47750 has joined #openstack-nova | 22:03 | |
mriedem | no | 22:03 |
mriedem | only #startmeeting and #endmeeting | 22:03 |
mriedem | maybe #action | 22:03 |
mriedem | #slap | 22:03 |
*** keekz has quit IRC | 22:03 | |
mriedem | crap i have to run | 22:03 |
bauzas | :) | 22:03 |
*** keekz has joined #openstack-nova | 22:04 | |
*** derekh has quit IRC | 22:04 | |
*** mriedem is now known as mriedem_away | 22:04 | |
*** andreykurilin__ has quit IRC | 22:04 | |
*** otter768 has quit IRC | 22:05 | |
*** dboik has joined #openstack-nova | 22:06 | |
*** lennyb has quit IRC | 22:06 | |
*** dboik_ has joined #openstack-nova | 22:08 | |
*** unicell1 has quit IRC | 22:08 | |
*** unicell has joined #openstack-nova | 22:08 | |
*** openstackstatus has quit IRC | 22:09 | |
*** dboik has quit IRC | 22:10 | |
*** tjones1 has quit IRC | 22:17 | |
*** greghaynes has quit IRC | 22:18 | |
*** pixelb has quit IRC | 22:22 | |
*** browne has quit IRC | 22:25 | |
*** ijw has joined #openstack-nova | 22:26 | |
*** gtt116_ has joined #openstack-nova | 22:26 | |
*** Nikolay_St has quit IRC | 22:27 | |
*** isd1 has quit IRC | 22:27 | |
openstackgerrit | Feodor Tersin proposed openstack/nova: Convert NetworkDuplicated to HTTPBadRequest for v2.1 API https://review.openstack.org/177018 | 22:27 |
*** Nikolay_St has joined #openstack-nova | 22:28 | |
*** gtt116 has quit IRC | 22:29 | |
*** jwcroppe_ has quit IRC | 22:30 | |
*** browne has joined #openstack-nova | 22:33 | |
*** Hosam has joined #openstack-nova | 22:36 | |
*** alexpilotti has quit IRC | 22:36 | |
*** signed8b_ has joined #openstack-nova | 22:37 | |
*** signed8bit has quit IRC | 22:40 | |
*** Guest47750 has quit IRC | 22:44 | |
*** leseb has quit IRC | 22:45 | |
*** leseb has joined #openstack-nova | 22:45 | |
*** erlon has quit IRC | 22:51 | |
*** Nikolay_St has quit IRC | 22:52 | |
*** Nikolay_St has joined #openstack-nova | 22:53 | |
*** Hosam has quit IRC | 22:59 | |
*** ijw has quit IRC | 23:00 | |
*** annashen has quit IRC | 23:00 | |
*** annashen has joined #openstack-nova | 23:00 | |
*** penick has quit IRC | 23:01 | |
*** derekh has joined #openstack-nova | 23:02 | |
*** melwitt has quit IRC | 23:02 | |
*** annegentle has joined #openstack-nova | 23:03 | |
*** derekh has quit IRC | 23:04 | |
*** annashen has quit IRC | 23:05 | |
*** joefides has joined #openstack-nova | 23:05 | |
*** hemna is now known as hemnafk | 23:07 | |
*** signed8b_ has quit IRC | 23:07 | |
*** joefides_ has joined #openstack-nova | 23:08 | |
*** ijw has joined #openstack-nova | 23:11 | |
*** joefides has quit IRC | 23:11 | |
*** annegentle has quit IRC | 23:14 | |
*** ijw_ has joined #openstack-nova | 23:14 | |
*** sdake has joined #openstack-nova | 23:16 | |
*** ganso_ has quit IRC | 23:17 | |
*** ijw has quit IRC | 23:17 | |
*** sdake_ has quit IRC | 23:20 | |
*** isd1 has joined #openstack-nova | 23:20 | |
*** Nikolay_St has quit IRC | 23:20 | |
*** browne has quit IRC | 23:20 | |
*** Nikolay_St has joined #openstack-nova | 23:21 | |
*** apuimedo has quit IRC | 23:22 | |
*** angdraug has quit IRC | 23:24 | |
*** signed8bit has joined #openstack-nova | 23:27 | |
*** wuhg has joined #openstack-nova | 23:28 | |
*** ijw_ has quit IRC | 23:30 | |
jroll | dansmith: I have a present for you :D | 23:30 |
jroll | https://gist.github.com/pcsforeducation/9b79956a6057d16ed5dc | 23:31 |
jroll | this is single compute, too, no clustered compute shenanigans | 23:31 |
jroll | alaski: ^ if you're curious | 23:31 |
*** ijw has joined #openstack-nova | 23:34 | |
*** marun has quit IRC | 23:34 | |
*** zhenguo has joined #openstack-nova | 23:34 | |
*** baoli has joined #openstack-nova | 23:35 | |
*** baoli has quit IRC | 23:37 | |
*** baoli has joined #openstack-nova | 23:37 | |
*** Marga_ has joined #openstack-nova | 23:38 | |
dansmith | jroll: well, it's hard to tell exactly what's going on without seeing the diff, | 23:39 |
dansmith | but are you thinking that going into the save, system_metadata is not in the list? | 23:39 |
dansmith | the changed list, that is | 23:39 |
jroll | dansmith: exactly | 23:39 |
*** ZZelle_ has quit IRC | 23:40 | |
dansmith | jroll: and the log is between sysmeta = False and instance.save() | 23:41 |
dansmith | ? | 23:41 |
jroll | triple-checking | 23:41 |
*** vilobhmm12 has quit IRC | 23:42 | |
jroll | nope, I lied, grr | 23:42 |
jroll | I'm sorry | 23:42 |
* jroll fixes | 23:42 | |
*** vilobhmm1 has joined #openstack-nova | 23:42 | |
dansmith | okay | 23:43 |
dansmith | would be really helpful to see the diff | 23:43 |
jroll | yeah, it isn't a git repo on this server, but I'll do what I can there | 23:43 |
dansmith | does it have diff? :) | 23:44 |
jroll | heh | 23:44 |
jroll | I don't have a clean copy there | 23:45 |
dansmith | well, who's fault is that? :) | 23:45 |
jroll | but yeah, I'll get a diff and more logs, and file a bug if necessary | 23:45 |
jroll | shhh :) | 23:45 |
dansmith | fwiw, | 23:45 |
*** igordcard has quit IRC | 23:45 | |
dansmith | I think the next thing I would do, is log out inst.system_metadata and inst._orig_system_metadata | 23:45 |
dansmith | because that's the logic it uses to determine if the the thing is changed | 23:46 |
jroll | nod | 23:46 |
*** vilobhmm11 has joined #openstack-nova | 23:46 | |
dansmith | because maybe deallocate_for_instance is breaking something | 23:46 |
dansmith | or | 23:46 |
dansmith | setting it to False there too and doing a reset_changes or something crazy like that | 23:46 |
*** Nikolay_St has quit IRC | 23:46 | |
*** vilobhmm1 has quit IRC | 23:47 | |
jroll | yeah | 23:47 |
*** Nikolay_St has joined #openstack-nova | 23:47 | |
jroll | alright, thank you | 23:47 |
dansmith | we can pick it up tomorrow | 23:48 |
jroll | indeed | 23:48 |
dansmith | just need to figure out how to pin it on neutron, ironic, or you (in that order) :P | 23:48 |
jroll | heh | 23:48 |
*** sorrison has quit IRC | 23:53 | |
*** apuimedo has joined #openstack-nova | 23:53 | |
*** sorrison has joined #openstack-nova | 23:54 | |
*** ijw has quit IRC | 23:55 | |
*** sdake_ has joined #openstack-nova | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!