*** baoli has joined #openstack-nova | 00:20 | |
*** dims_ has quit IRC | 00:34 | |
*** salv-orlando has joined #openstack-nova | 00:43 | |
*** promulo_ has joined #openstack-nova | 00:45 | |
openstackgerrit | Eli Qiao proposed openstack/nova: Set power state to None when evaucate do failed due to recreate not supported https://review.openstack.org/173150 | 00:47 |
---|---|---|
*** promulo__ has quit IRC | 00:49 | |
*** salv-orlando has quit IRC | 00:50 | |
*** jaypipes has joined #openstack-nova | 00:56 | |
*** haigang has joined #openstack-nova | 00:56 | |
*** isd has quit IRC | 00:58 | |
*** zhenguo has joined #openstack-nova | 01:01 | |
*** achanda has joined #openstack-nova | 01:09 | |
*** jecarey has quit IRC | 01:14 | |
*** jecarey has joined #openstack-nova | 01:15 | |
*** sandywalsh has joined #openstack-nova | 01:15 | |
*** haigang has quit IRC | 01:18 | |
*** ttx has quit IRC | 01:18 | |
*** sandywalsh_ has quit IRC | 01:19 | |
*** wanghao has quit IRC | 01:20 | |
*** arnaud____ has quit IRC | 01:20 | |
*** ttx has joined #openstack-nova | 01:22 | |
*** wanghao has joined #openstack-nova | 01:23 | |
*** popw has joined #openstack-nova | 01:25 | |
openstackgerrit | Eli Qiao proposed openstack/nova: WIP: Add ConsoleAuthToken object and console_auth_token table https://review.openstack.org/177078 | 01:25 |
openstackgerrit | Eli Qiao proposed openstack/nova: WIP Allow running multiple consoleauth services https://review.openstack.org/177145 | 01:25 |
openstackgerrit | Eli Qiao proposed openstack/nova: WIP Conductor: Add console_auth_token apis https://review.openstack.org/177144 | 01:25 |
*** sdake has joined #openstack-nova | 01:32 | |
*** erkules_ has joined #openstack-nova | 01:32 | |
*** armax has joined #openstack-nova | 01:33 | |
*** erkules has quit IRC | 01:35 | |
*** jyuso1 has quit IRC | 01:36 | |
*** kaisers has quit IRC | 01:36 | |
*** kaisers1 has quit IRC | 01:36 | |
*** haigang has joined #openstack-nova | 01:38 | |
*** kaisers has joined #openstack-nova | 01:39 | |
*** kaisers1 has joined #openstack-nova | 01:39 | |
*** haigang has quit IRC | 01:40 | |
*** haigang has joined #openstack-nova | 01:41 | |
*** jyuso1 has joined #openstack-nova | 01:42 | |
*** sdake_ has joined #openstack-nova | 01:48 | |
*** igordcard has quit IRC | 01:49 | |
*** haigang has quit IRC | 01:49 | |
*** sdake has quit IRC | 01:51 | |
*** IanGovett has joined #openstack-nova | 01:52 | |
*** haigang has joined #openstack-nova | 01:53 | |
*** baoli has quit IRC | 01:57 | |
*** asettle is now known as asettle-afk | 02:02 | |
*** achanda has quit IRC | 02:02 | |
*** jlvillal has quit IRC | 02:08 | |
*** jlvillal has joined #openstack-nova | 02:09 | |
*** eliqiao has left #openstack-nova | 02:15 | |
*** armax has quit IRC | 02:24 | |
*** Longgeek has quit IRC | 02:28 | |
*** Longgeek has joined #openstack-nova | 02:33 | |
*** IanGovett has quit IRC | 02:34 | |
*** baoli has joined #openstack-nova | 02:35 | |
*** sdake_ has quit IRC | 02:35 | |
*** setuid has quit IRC | 02:36 | |
*** salv-orlando has joined #openstack-nova | 02:46 | |
*** sdake has joined #openstack-nova | 02:52 | |
*** wuhg has joined #openstack-nova | 02:52 | |
*** eliqiao has joined #openstack-nova | 02:53 | |
*** salv-orlando has quit IRC | 02:56 | |
*** haigang has quit IRC | 02:56 | |
*** haigang has joined #openstack-nova | 02:57 | |
*** VW_ has joined #openstack-nova | 02:58 | |
*** asettle-afk is now known as asettle | 02:59 | |
*** VW_ has quit IRC | 03:01 | |
*** VW_ has joined #openstack-nova | 03:01 | |
*** salv-orlando has joined #openstack-nova | 03:02 | |
*** salv-orlando has quit IRC | 03:04 | |
*** RuiChen has joined #openstack-nova | 03:07 | |
*** baoli has quit IRC | 03:08 | |
*** otter768 has quit IRC | 03:20 | |
*** armax has joined #openstack-nova | 03:21 | |
*** armax has quit IRC | 03:23 | |
*** vilobhmm1 has joined #openstack-nova | 03:23 | |
*** sdake_ has joined #openstack-nova | 03:28 | |
*** sdake has quit IRC | 03:32 | |
*** vilobhmm1 has quit IRC | 03:35 | |
*** setuid has joined #openstack-nova | 03:37 | |
*** vilobhmm1 has joined #openstack-nova | 03:42 | |
*** tjones1 has joined #openstack-nova | 03:45 | |
*** Nikolay_St has quit IRC | 03:47 | |
*** annashen has joined #openstack-nova | 03:48 | |
*** vilobhmm11 has joined #openstack-nova | 03:49 | |
*** vilobhmm1 has quit IRC | 03:51 | |
*** Nikolay_St has joined #openstack-nova | 03:51 | |
*** setuid has quit IRC | 03:55 | |
*** dave-mccowan has quit IRC | 03:56 | |
*** tjones1 has quit IRC | 03:57 | |
*** arif-ali has quit IRC | 03:58 | |
*** Nikolay_St has quit IRC | 04:06 | |
*** RuiChen has left #openstack-nova | 04:06 | |
*** RuiChen has joined #openstack-nova | 04:07 | |
*** exploreshaifali has joined #openstack-nova | 04:09 | |
*** annashen has quit IRC | 04:10 | |
*** vilobhmm11 has quit IRC | 04:10 | |
*** Longgeek has quit IRC | 04:17 | |
*** Longgeek has joined #openstack-nova | 04:18 | |
*** neelashah has joined #openstack-nova | 04:21 | |
*** neelashah has quit IRC | 04:22 | |
*** davideagnello has joined #openstack-nova | 04:24 | |
*** davideagnello has quit IRC | 04:28 | |
*** ijw has joined #openstack-nova | 04:38 | |
*** coolsvap|afk is now known as coolsvap | 04:47 | |
*** tojuvone has joined #openstack-nova | 04:56 | |
*** Nikolay_St has joined #openstack-nova | 04:57 | |
*** nkrinner has joined #openstack-nova | 05:02 | |
*** irenab has quit IRC | 05:06 | |
*** browne has joined #openstack-nova | 05:09 | |
*** setuid has joined #openstack-nova | 05:09 | |
*** exploreshaifali has quit IRC | 05:14 | |
*** cfriesen has quit IRC | 05:18 | |
*** _gryf|afk is now known as _gryf | 05:19 | |
*** otter768 has joined #openstack-nova | 05:21 | |
*** otter768 has quit IRC | 05:26 | |
*** annashen has joined #openstack-nova | 05:29 | |
*** subscope_ has joined #openstack-nova | 05:30 | |
*** subscope_ has quit IRC | 05:31 | |
*** wolsen_ is now known as wolsen | 05:33 | |
*** VW_ has quit IRC | 05:34 | |
*** VW_ has joined #openstack-nova | 05:35 | |
*** VW_ has quit IRC | 05:36 | |
*** VW_ has joined #openstack-nova | 05:37 | |
*** VW_ has quit IRC | 05:38 | |
*** VW_ has joined #openstack-nova | 05:39 | |
*** achanda has joined #openstack-nova | 05:39 | |
*** annashen has quit IRC | 05:42 | |
*** masayukig has quit IRC | 05:44 | |
*** bkopilov has quit IRC | 05:44 | |
*** masayukig has joined #openstack-nova | 05:46 | |
*** salv-orlando has joined #openstack-nova | 05:46 | |
*** annashen has joined #openstack-nova | 05:49 | |
*** annashen has quit IRC | 05:53 | |
*** salv-orlando has quit IRC | 05:54 | |
*** sdake_ has quit IRC | 05:56 | |
*** sdake has joined #openstack-nova | 05:56 | |
*** nkrinner has quit IRC | 05:57 | |
*** doron_afk has joined #openstack-nova | 06:00 | |
*** doron_afk has quit IRC | 06:00 | |
*** doron_afk has joined #openstack-nova | 06:00 | |
*** kiran-r has joined #openstack-nova | 06:03 | |
*** bkopilov has joined #openstack-nova | 06:03 | |
*** ildikov has joined #openstack-nova | 06:03 | |
*** morgabra has quit IRC | 06:04 | |
*** morgabra has joined #openstack-nova | 06:04 | |
*** kaisers1 has quit IRC | 06:06 | |
*** kaisers has quit IRC | 06:06 | |
*** Longgeek has quit IRC | 06:07 | |
*** moshele has joined #openstack-nova | 06:07 | |
*** moshele has joined #openstack-nova | 06:07 | |
*** Longgeek has joined #openstack-nova | 06:09 | |
*** VW_ has quit IRC | 06:10 | |
*** VW_ has joined #openstack-nova | 06:10 | |
*** VW_ has quit IRC | 06:10 | |
*** zul has joined #openstack-nova | 06:11 | |
*** vilobhmm1 has joined #openstack-nova | 06:15 | |
*** kaisers has joined #openstack-nova | 06:16 | |
*** lpetrut has joined #openstack-nova | 06:16 | |
*** haomaiwang has quit IRC | 06:16 | |
*** deepthi has joined #openstack-nova | 06:18 | |
*** haigang has quit IRC | 06:21 | |
*** masayukig has quit IRC | 06:21 | |
*** afazekas has joined #openstack-nova | 06:21 | |
*** masayukig has joined #openstack-nova | 06:23 | |
*** oro has joined #openstack-nova | 06:24 | |
*** wanghao has quit IRC | 06:24 | |
*** BadCub_Hiding has quit IRC | 06:24 | |
*** wanghao has joined #openstack-nova | 06:24 | |
*** liusheng has quit IRC | 06:24 | |
*** BadCub_Hiding has joined #openstack-nova | 06:25 | |
*** nkrinner has joined #openstack-nova | 06:25 | |
*** wanghao has quit IRC | 06:29 | |
*** Sukhdev has joined #openstack-nova | 06:29 | |
*** wanghao has joined #openstack-nova | 06:30 | |
*** Longgeek_ has joined #openstack-nova | 06:34 | |
*** Sukhdev has quit IRC | 06:34 | |
*** annashen has joined #openstack-nova | 06:35 | |
*** Longgeek has quit IRC | 06:37 | |
*** kaisers has quit IRC | 06:39 | |
*** zul has quit IRC | 06:40 | |
*** foexle has quit IRC | 06:40 | |
*** salv-orlando has joined #openstack-nova | 06:42 | |
*** salv-orlando has quit IRC | 06:44 | |
*** annashen has quit IRC | 06:45 | |
*** ttx has quit IRC | 06:47 | |
*** ttx has joined #openstack-nova | 06:47 | |
*** haomaiwa_ has joined #openstack-nova | 06:51 | |
*** haomaiw__ has joined #openstack-nova | 06:54 | |
*** haomaiwa_ has quit IRC | 06:54 | |
*** Bsony has joined #openstack-nova | 06:56 | |
*** rajesht has joined #openstack-nova | 06:56 | |
*** sdake has quit IRC | 06:58 | |
*** haomaiwa_ has joined #openstack-nova | 06:59 | |
*** ildikov has quit IRC | 07:01 | |
*** arnaud____ has joined #openstack-nova | 07:01 | |
*** haomaiw__ has quit IRC | 07:02 | |
*** vilobhmm1 has quit IRC | 07:04 | |
*** jcoufal has joined #openstack-nova | 07:06 | |
*** jcoufal is now known as 7JTAAIHSL | 07:06 | |
*** jcoufal has joined #openstack-nova | 07:06 | |
*** jcoufal has quit IRC | 07:06 | |
*** jcoufal has joined #openstack-nova | 07:06 | |
*** jcoufal has quit IRC | 07:06 | |
*** dsanders1 has quit IRC | 07:06 | |
*** abhishekk has joined #openstack-nova | 07:07 | |
*** kaisers has joined #openstack-nova | 07:08 | |
*** zhangtralon has joined #openstack-nova | 07:08 | |
*** mpaolino has joined #openstack-nova | 07:08 | |
*** sahid has joined #openstack-nova | 07:09 | |
*** arnaud____ has quit IRC | 07:11 | |
*** vokhrimenko has quit IRC | 07:15 | |
*** apmelton_away has quit IRC | 07:15 | |
*** apmelton has joined #openstack-nova | 07:16 | |
*** Nakato has quit IRC | 07:16 | |
*** Nakato has joined #openstack-nova | 07:16 | |
*** freyes has quit IRC | 07:16 | |
*** romainh has joined #openstack-nova | 07:18 | |
*** freyes has joined #openstack-nova | 07:18 | |
*** browne has quit IRC | 07:20 | |
*** otter768 has joined #openstack-nova | 07:22 | |
*** liusheng has joined #openstack-nova | 07:23 | |
*** dsanders has joined #openstack-nova | 07:25 | |
*** markvoelker has joined #openstack-nova | 07:26 | |
*** otter768 has quit IRC | 07:27 | |
*** Administrator_ has joined #openstack-nova | 07:28 | |
*** Kevin_Zheng has joined #openstack-nova | 07:28 | |
*** Administrator_ has quit IRC | 07:28 | |
*** jichen has joined #openstack-nova | 07:28 | |
*** oro has quit IRC | 07:30 | |
*** markvoelker has quit IRC | 07:30 | |
*** Murali has joined #openstack-nova | 07:31 | |
*** salv-orlando has joined #openstack-nova | 07:36 | |
gillliard | Thank God It's Monday! | 07:39 |
*** BobBall_ is now known as BobBall | 07:39 | |
*** gillliard is now known as gilliard | 07:39 | |
*** jlanoux has joined #openstack-nova | 07:40 | |
*** sdake has joined #openstack-nova | 07:42 | |
*** sdake has quit IRC | 07:42 | |
*** sdake has joined #openstack-nova | 07:42 | |
*** mpavone has joined #openstack-nova | 07:45 | |
*** Bsony has quit IRC | 07:46 | |
*** pask81 has joined #openstack-nova | 07:48 | |
*** kashyap has joined #openstack-nova | 07:48 | |
*** pask81 has quit IRC | 07:51 | |
*** romainh has quit IRC | 07:52 | |
*** Longgeek_ has quit IRC | 07:54 | |
*** jistr has joined #openstack-nova | 07:57 | |
*** freyes has quit IRC | 07:59 | |
*** zul has joined #openstack-nova | 08:00 | |
*** freyes has joined #openstack-nova | 08:01 | |
*** Longgeek has joined #openstack-nova | 08:03 | |
*** dulek has joined #openstack-nova | 08:04 | |
*** apuimedo_ has joined #openstack-nova | 08:05 | |
*** flashgordon has quit IRC | 08:06 | |
*** openstackstatus has joined #openstack-nova | 08:06 | |
*** ChanServ sets mode: +v openstackstatus | 08:06 | |
*** romainh has joined #openstack-nova | 08:07 | |
*** exploreshaifali has joined #openstack-nova | 08:07 | |
*** zul has quit IRC | 08:08 | |
-openstackstatus- NOTICE: Restarting gerrit because it stopped sending events (ETA 15 mins) | 08:10 | |
*** dsanders has quit IRC | 08:12 | |
*** pask81 has joined #openstack-nova | 08:12 | |
*** openstackgerrit has quit IRC | 08:13 | |
*** pask811 has joined #openstack-nova | 08:16 | |
*** achanda has quit IRC | 08:16 | |
*** openstackgerrit has joined #openstack-nova | 08:17 | |
*** pask81 has quit IRC | 08:17 | |
*** lucasagomes has joined #openstack-nova | 08:17 | |
*** freyes has quit IRC | 08:18 | |
openstackgerrit | sahid proposed openstack/nova: libvirt: add get_cpu_stats method to host https://review.openstack.org/177223 | 08:19 |
openstackgerrit | sahid proposed openstack/nova: libvirt: add get hardware info method to Host https://review.openstack.org/177222 | 08:19 |
openstackgerrit | sahid proposed openstack/nova: libvirt: add compare_cpu to Host https://review.openstack.org/177331 | 08:19 |
openstackgerrit | sahid proposed openstack/nova: libvirt: add list_devices to Host https://review.openstack.org/177330 | 08:19 |
*** derekh has joined #openstack-nova | 08:19 | |
openstackgerrit | sahid proposed openstack/nova: libvirt: add device_lookup_by_name to Host https://review.openstack.org/177329 | 08:19 |
openstackgerrit | sahid proposed openstack/nova: libvirt: add define_xml method to host https://review.openstack.org/174314 | 08:19 |
openstackgerrit | sahid proposed openstack/nova: libvirt: add note to do note call libvirt from the driver https://review.openstack.org/177332 | 08:19 |
*** freyes has joined #openstack-nova | 08:21 | |
*** dguitarbite has joined #openstack-nova | 08:25 | |
*** haypo has joined #openstack-nova | 08:26 | |
*** Mike_D_laptop has joined #openstack-nova | 08:26 | |
*** markvoelker has joined #openstack-nova | 08:27 | |
*** xgsa has joined #openstack-nova | 08:31 | |
*** markvoelker has quit IRC | 08:32 | |
*** freyes has quit IRC | 08:32 | |
*** freyes has joined #openstack-nova | 08:35 | |
*** deepthi has quit IRC | 08:37 | |
*** zul has joined #openstack-nova | 08:38 | |
*** ndipanov has joined #openstack-nova | 08:39 | |
*** zul has quit IRC | 08:41 | |
*** zul has joined #openstack-nova | 08:41 | |
*** Mike_D_laptop has quit IRC | 08:43 | |
*** oro has joined #openstack-nova | 08:44 | |
*** erkules_ is now known as erkules | 08:45 | |
sahid | ndipanov: morning, can i have you ack on this tiny think https://review.openstack.org/#/c/176236/ please | 08:45 |
*** erkules has quit IRC | 08:45 | |
*** erkules has joined #openstack-nova | 08:45 | |
RuiChen | sahid: https://review.openstack.org/#/c/177644/ , you means I need to add the Error type in help when the hypervisors don't support bandwithd=0? | 08:45 |
RuiChen | sahid: when bandwithd not 0, sorry | 08:46 |
sahid | RuiChen: no, no sorry i wanted to say that, your commit mesage needs to be updated since you are doing more than just update bps to mib | 08:46 |
sahid | mbps | 08:47 |
RuiChen | sahid: ok, I will add more details, thanks | 08:47 |
sahid | then please add the doc tag | 08:47 |
RuiChen | sahid: get it | 08:47 |
*** apuimedo_ has quit IRC | 08:49 | |
*** pixelb has joined #openstack-nova | 08:50 | |
*** sudipto has joined #openstack-nova | 08:50 | |
*** lpetrut has quit IRC | 08:51 | |
*** sdake_ has joined #openstack-nova | 08:51 | |
*** redbeard has joined #openstack-nova | 08:53 | |
*** sdake has quit IRC | 08:55 | |
bauzas | sahid: RuiChen: FYI, please don't give -1 for commit msgs | 08:55 |
bauzas | it's preferable to modify the commit msg directly using the Gerrit UI | 08:55 |
*** aix has joined #openstack-nova | 08:58 | |
*** yassine has joined #openstack-nova | 08:58 | |
*** apuimedo_ has joined #openstack-nova | 08:58 | |
*** achanda has joined #openstack-nova | 08:59 | |
*** yassine has quit IRC | 09:00 | |
*** yingjun has joined #openstack-nova | 09:00 | |
*** yassine has joined #openstack-nova | 09:01 | |
*** pask811 has quit IRC | 09:01 | |
*** arnaud____ has joined #openstack-nova | 09:01 | |
*** dikonoor has joined #openstack-nova | 09:05 | |
*** mpavone has quit IRC | 09:05 | |
*** flashgordon has joined #openstack-nova | 09:06 | |
dikonoor | johnthetubaguy : Hi ,Could you review https://review.openstack.org/#/c/176651/ | 09:07 |
openstackgerrit | Eli Qiao proposed openstack/nova-specs: Support console auth service HA https://review.openstack.org/177671 | 09:07 |
*** arnaud____ has quit IRC | 09:09 | |
*** ajayaa has joined #openstack-nova | 09:10 | |
openstackgerrit | Rui Chen proposed openstack/nova: Fix unit issue of CONF.libvirt.live_migration_bandwidth https://review.openstack.org/177644 | 09:11 |
*** sdake_ has quit IRC | 09:13 | |
*** lpetrut has joined #openstack-nova | 09:15 | |
*** sdake has joined #openstack-nova | 09:15 | |
eliqiao | hi RuiChen: seems https://review.openstack.org/177644 is dup with https://review.openstack.org/#/c/168258/1/nova/virt/libvirt/driver.py | 09:15 |
eliqiao | sahid: seems you reviewed my patch before https://review.openstack.org/#/c/168258/1/nova/virt/libvirt/driver.py | 09:16 |
ndipanov | bauzas, well that's for typos - if a commit message is wrong - IMHO it's -1 wrothy for sure | 09:16 |
bauzas | ndipanov: well, it's really better to modify directly the commit msg unless there are many people having +1'd the patch | 09:17 |
bauzas | ndipanov: or someone already +2'ing | 09:17 |
ndipanov | bauzas, that would clear all the votes anyway | 09:17 |
bauzas | ndipanov: because it's just a matter of clicking on 'modify" | 09:17 |
*** mpavone has joined #openstack-nova | 09:17 | |
bauzas | ndipanov: yeah, that's why I say "unless..." | 09:17 |
ndipanov | ah | 09:18 |
bauzas | ndipanov: but I think it's really cooler than just giving -1 for saying "eh dude, you forgot DocImpact" | 09:18 |
bauzas | or APIImpact or whatever | 09:18 |
ndipanov | yeah just adding docimpact is on the level of typo | 09:19 |
ndipanov | but sometimes DocImpact needs further explanation, and even though I can write it | 09:19 |
bauzas | so, each time, I'm seeing it, and if the "unless" is not there, I prefer to click on modify, do the update and click on +1 | 09:19 |
ndipanov | It would still be better to come from the orriginal author just so taht we are all clear | 09:19 |
bauzas | ndipanov: sure, I'm not saying you should not -1 a patch | 09:19 |
ndipanov | it's also a more natural flow of discussion | 09:20 |
bauzas | ndipanov: but we should just help the owner if we think it's really a nitpick | 09:20 |
ndipanov | yeah | 09:20 |
ndipanov | for typos - no excuse | 09:20 |
bauzas | again, I agree it's a tradeoff | 09:20 |
bauzas | - there is no rule - | 09:20 |
bauzas | and of course pinging the owner is the best one | 09:20 |
bauzas | but again, I really want to see the reviewers not just fencing the changes | 09:21 |
bauzas | just because it's a nitpick | 09:21 |
bauzas | ndipanov: and it's just a discussion, not a ML thread :-) | 09:21 |
RuiChen | eliqiao: sorry, I didn't see your patch, please link your patch to my bug https://launchpad.net/bugs/1448844, and add sahid and garyk's suggestion, | 09:22 |
openstack | Launchpad bug 1448844 in OpenStack Compute (nova) "Unit issue of CONF.libvirt.live_migration_bandwidth in option description" [Low,In progress] - Assigned to Rui Chen (kiwik-chenrui) | 09:22 |
RuiChen | eliqiao: I willing to abandon my patch and help to review yours. | 09:23 |
RuiChen | eliqiao: thank your reminding :) | 09:24 |
eliqiao | RuiChen: thanks Rui, I should notice and see your patch more early.. | 09:24 |
johnthetubaguy | ndipanov: bauzas: is this about this one: https://review.openstack.org/#/c/176651/ | 09:25 |
bauzas | johnthetubaguy: ? | 09:25 |
bauzas | johnthetubaguy: you mean the convo ? | 09:25 |
johnthetubaguy | bauzas: yeah, that was a typo in a commit message | 09:25 |
johnthetubaguy | bauzas: but its just a missing space, which doesn't make me loose too much sleep | 09:26 |
bauzas | johnthetubaguy: not this particular patch | 09:26 |
johnthetubaguy | ah, gotacha | 09:26 |
bauzas | johnthetubaguy: it was another one, and I don't exactly want to give it :) | 09:26 |
bauzas | johnthetubaguy: but it was like a missing DocImpact tag with a good change | 09:26 |
johnthetubaguy | the problem with a commit message is you can't go back and fix it, tricky one | 09:26 |
johnthetubaguy | bauzas: if the +2 was not such a rare event, we would just rev the patch, and everyone would be happy, but right now, its tricky... | 09:27 |
*** markvoelker has joined #openstack-nova | 09:27 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Libvirt: Make live_migration_bandwidth help msg more meaning https://review.openstack.org/168258 | 09:28 |
bauzas | johnthetubaguy: yeah the main sucking thing is that it regenerates a new PS | 09:28 |
bauzas | johnthetubaguy: so we're loosing votes | 09:28 |
bauzas | johnthetubaguy: as I said, it's a trade-off | 09:29 |
bauzas | johnthetubaguy: but my take is to say that as reviewer, I think it's good to sometimes put hands on the patch | 09:29 |
johnthetubaguy | right, thats what I was saying, we would make a better trade off if its easier to get your +2 back, just ping the folk and they will re-add it I suspect | 09:29 |
johnthetubaguy | its tricky though | 09:29 |
johnthetubaguy | as you say | 09:29 |
bauzas | johnthetubaguy: exactly, that's what I usually do | 09:29 |
bauzas | johnthetubaguy: identify the voters, and if good enough, change it and ping back | 09:30 |
*** alexpilotti has joined #openstack-nova | 09:30 | |
*** zul has quit IRC | 09:30 | |
bauzas | johnthetubaguy: at least for the ones you know | 09:30 |
bauzas | the ones == the reviewers | 09:30 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Libvirt: Make live_migration_bandwidth help msg more meaning https://review.openstack.org/168258 | 09:32 |
*** gszasz has joined #openstack-nova | 09:32 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Libvirt: Make live_migration_bandwidth help msg more meaning https://review.openstack.org/168258 | 09:32 |
*** yingjun has quit IRC | 09:32 | |
*** Longgeek has quit IRC | 09:33 | |
*** zul has joined #openstack-nova | 09:33 | |
dikonoor | johnthetubaguy:Thanks for reviewing https://review.openstack.org/#/c/176651/ and for your comments | 09:34 |
*** Longgeek has joined #openstack-nova | 09:34 | |
*** ociuhandu has joined #openstack-nova | 09:35 | |
*** sudipto has quit IRC | 09:35 | |
*** markvoelker has quit IRC | 09:36 | |
*** apuimedo has quit IRC | 09:39 | |
bauzas | dikonoor: johnthetubaguy: I'm surprised to see https://review.openstack.org/#/c/176651/4/nova/api/openstack/compute/contrib/hypervisors.py,cm | 09:40 |
bauzas | dikonoor: johnthetubaguy: I thought the plan was to remove the context-related checks ? | 09:40 |
bauzas | on the DB side | 09:40 |
bauzas | dikonoor: the patch is for the master branch | 09:40 |
dikonoor | bauzas : yes, that's right..Those changes will be made as part of another patch..Let me get that patch by eliqiao I guess.. | 09:41 |
bauzas | dikonoor: then, why are you proposing that ? | 09:41 |
johnthetubaguy | bauzas: it makes a clean backport for a regression at least, although yes, we can tidy up that fix afterwards, maybe thats overthinking it | 09:42 |
dikonoor | bauzas : http://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2015-04-22.log . | 09:42 |
dikonoor | bauzas : This patch has to be backported to kilo | 09:42 |
johnthetubaguy | dikonoor: we can just create a new patch for the backport if we have to though | 09:43 |
johnthetubaguy | (as I understand it) | 09:43 |
bauzas | dikonoor: I totally understand the backporting problem | 09:43 |
johnthetubaguy | its missed the RC now, which was the original aim | 09:43 |
*** foexle has joined #openstack-nova | 09:43 | |
bauzas | dikonoor: but I think that's something we can discuss with stable cores | 09:44 |
bauzas | dikonoor: at least mriedem gave us an insight | 09:44 |
*** apuimedo has joined #openstack-nova | 09:44 | |
*** lpetrut has quit IRC | 09:44 | |
dikonoor | johnthetubaguy : yes a new patch has to be created for backporting | 09:45 |
bauzas | dikonoor: in http://lists.openstack.org/pipermail/openstack-dev/2015-April/062376.html I was referring to only remove the context check for service_get_all_by_cn | 09:45 |
bauzas | dikonoor: then the backport would be that patch only | 09:45 |
bauzas | dikonoor: it would reduce the level of change and we should just make sure that all the API methods calling that DB method would be admin-only, like mriedem said | 09:46 |
bauzas | sounds doable | 09:46 |
bauzas | dikonoor: you got the idea ? ie. provide a master change for removing the context decorator to service_get_all_by_cn() and ensure that all associated API endpoints are admin-only | 09:48 |
bauzas | dikonoor: then backport only that change to Kilo | 09:48 |
bauzas | dikonoor: of course, if the endpoints are not admin-only, then provide a modified policy.json file in the same change | 09:48 |
bauzas | johnthetubaguy: do we notify the operators of all the policy.json changes we do implicitely ?. | 09:49 |
*** zhangtralon has quit IRC | 09:49 | |
bauzas | johnthetubaguy: sounds pretty sensitive | 09:49 |
bauzas | like in the relnotes ? | 09:49 |
eliqiao | bauzas: already has patch for removing admin check for service_get_all_by_cn https://review.openstack.org/#/c/160089/ | 09:50 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova: libvirt/utils.py: Cleanup create_cow_image function https://review.openstack.org/177574 | 09:50 |
bauzas | eliqiao: cool, will review it | 09:50 |
*** BobBall_ has joined #openstack-nova | 09:50 | |
bauzas | eliqiao: oh oh, I disagree with that one :) | 09:50 |
johnthetubaguy | bauzas: it should be in the release notes yes, its tricky | 09:50 |
eliqiao | bauzas: alex_xu marks it as wip.. | 09:50 |
*** flip214 has quit IRC | 09:51 | |
bauzas | johnthetubaguy: lemme blame the file and see if there are changes except new things | 09:51 |
bauzas | for Kilo I mean | 09:51 |
bauzas | eliqiao: yeah, that's what I see | 09:52 |
*** alexpilotti has quit IRC | 09:52 | |
*** deepthi has joined #openstack-nova | 09:54 | |
*** sudipto has joined #openstack-nova | 09:54 | |
*** BobBall has quit IRC | 09:54 | |
*** mpavone has quit IRC | 09:54 | |
*** IanGovett has joined #openstack-nova | 09:54 | |
*** achanda has quit IRC | 09:55 | |
bauzas | eliqiao: alex_xu: see my comment on https://review.openstack.org/#/c/160089/10 | 09:57 |
*** zhangtralon has joined #openstack-nova | 09:57 | |
bauzas | to be clear, there is absolutely zero reasons to provide the context checks on the API level | 09:58 |
bauzas | dikonoor: johnthetubaguy: ^ following that, I think that we can just ask https://review.openstack.org/#/c/160089/10 to only remove the db decorator and backport that change | 09:59 |
bauzas | dikonoor: johnthetubaguy: there is no need of an elevated context to use too... | 09:59 |
*** dguitarbite has quit IRC | 09:59 | |
bauzas | 3 extensions, all of them are admin-only... | 09:59 |
*** achanda has joined #openstack-nova | 10:00 | |
dikonoor | bauzas : if the context check in db layer is removed and backported to kilo , would that cause any regression anywhere else ? I am fine with https://review.openstack.org/#/c/160089/ removing the db decorator and backporting the changes..Both ways (with the elevated ctxt) and db decorator removed the permissions get picked up from policy.json | 10:01 |
*** mpavone has joined #openstack-nova | 10:01 | |
*** dguitarbite has joined #openstack-nova | 10:01 | |
eliqiao | bauzas: sure, but this patch is only for v2 api. I am agree with you that remove all db/api policy check is the right directory, but it's only for v2.1, we would use policy.json to control all policy checking.. | 10:02 |
*** arnaud____ has joined #openstack-nova | 10:03 | |
bauzas | eliqiao: https://review.openstack.org/#/c/160089/10 should only mention the DB API | 10:03 |
bauzas | eliqiao: so that would benefit both v2.0 and v2.1 | 10:04 |
eliqiao | bauzas: dikonoor: yeah , I get, we added context.elevated() 's only for backwards-complile for older v2 version. | 10:04 |
bauzas | eliqiao: as the RBAC rules are the same for v2.1 and v2.0 right ? | 10:04 |
*** lpetrut has joined #openstack-nova | 10:04 | |
bauzas | eliqiao: if not, that seems a major issue to me :/ | 10:05 |
eliqiao | bauzas: what's RBAC ? | 10:05 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Make objects serialize_args() handle datetimes in positional args https://review.openstack.org/174243 | 10:06 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Remove and deprecate conductor task_log methods https://review.openstack.org/174247 | 10:06 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Remove unused compute utils methods https://review.openstack.org/174246 | 10:06 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Make instance usage audit use the brand new TaskLog object https://review.openstack.org/174245 | 10:06 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Add a TaskLog object https://review.openstack.org/174244 | 10:06 |
bauzas | eliqiao: role-based access control == policy.json | 10:06 |
dikonoor | eliqiao : Role based access control = rbac | 10:06 |
RuiChen | johnthetubaguy: I move the logic into '_schedule' method in my patch, so I think the test cases that deleted by me didn't need anymore. https://review.openstack.org/#/c/147048/ | 10:06 |
*** alexpilotti has joined #openstack-nova | 10:07 | |
bauzas | eliqiao: so I checked, and unless I'm blind, v2.0 and v2.1 are enforcing the same rulesets | 10:07 |
bauzas | eliqiao: so, removing the DB decorator is covered by the same RBAC ruleset | 10:07 |
bauzas | eliqiao: ie. what applies to v2.0 applies also to v2.1 | 10:08 |
*** arnaud____ has quit IRC | 10:08 | |
*** lucasagomes has quit IRC | 10:09 | |
*** achanda has quit IRC | 10:11 | |
*** lucasagomes has joined #openstack-nova | 10:11 | |
eliqiao | bauzas: v2's rule is "compute_extension:hypervisors": "rule:admin_api", and v2.1 is "os_compute_api:os-hypervisors": "rule:admin_api", | 10:12 |
bauzas | ???? | 10:12 |
johnthetubaguy | RuiChen: I don't really understand why are they not needed, if you want to drop them, please do that in a separate patch, ideally | 10:12 |
bauzas | johnthetubaguy: +1 | 10:12 |
bauzas | RuiChen: I don't like having our coverage not being explicit | 10:13 |
bauzas | RuiChen: it's sometimes really hard to see the code coverage because most of our tests are not isolated - like the ones that are testing thru the DB | 10:13 |
bauzas | RuiChen: so I prefer leaving things explicitely covered, even if we're sure that another test is doing the implicit check | 10:14 |
*** dims has joined #openstack-nova | 10:14 | |
*** Longgeek has quit IRC | 10:14 | |
bauzas | eliqiao: alex_xu: do you have an idea why v2.1 and v2.0 have different rulessets ? | 10:14 |
bauzas | alex_xu: eliqiao: and most of that the more important, are you sure that operators know that ? | 10:15 |
eliqiao | bauzas: seems there is no operators using v2.1 yet? | 10:15 |
bauzas | alex_xu: eliqiao: well, technically I understand *why*, I just think it's error-proner | 10:16 |
bauzas | eliqiao: erm http://docs.openstack.org/ is marking v2.1 as CURRENT :) | 10:16 |
eliqiao | bauzas: that 's a good progress. cool. | 10:16 |
bauzas | that's just the CLI which doesn't support it yet AFAIK | 10:17 |
bauzas | johnthetubaguy: I wonder if we shouldn't warn operators that v2.1 have different rules in https://wiki.openstack.org/w/index.php?title=ReleaseNotes/Kilo#API | 10:18 |
bauzas | I was just thinking both versions were consuming the same rulesets but it seems I'm wrong | 10:18 |
bauzas | so, saying that you want to modify the evacuate endpoint, you have to do it on 2 lines | 10:19 |
RuiChen | johnthetubaguy: the test cases was deleted because I refactor some logic in filter_scheduler, I will split it out from patch/147048, avoid confusion | 10:22 |
*** apuimedo_ has quit IRC | 10:22 | |
*** sudipto has quit IRC | 10:22 | |
openstackgerrit | dave-mcnally proposed openstack/nova: Add policy to cover snapshotting of volume backed instances https://review.openstack.org/176805 | 10:23 |
*** apuimedo_ has joined #openstack-nova | 10:23 | |
*** lpetrut has quit IRC | 10:26 | |
*** Longgeek has joined #openstack-nova | 10:26 | |
johnthetubaguy | RuiChen: because you did the refactor, I want to see the old unit tests pass against the new code, as a minimum | 10:28 |
*** markvoelker has joined #openstack-nova | 10:28 | |
kashyap | mdbooth (or anyone): When you get a moment: So, I dug a little bit into the qcow2 overlay inheriting properties from its base, and put this up -- https://review.openstack.org/#/c/177574/ -- libvirt/utils.py: cleanup create_cow_image function | 10:28 |
alex_xu | bauzas: hi, just saw your message. sorry, I have to go now, will catch up you after few hours | 10:29 |
bauzas | alex_xu: idem here, have to jump out for lunch | 10:29 |
alex_xu | bauzas: enough lunch :) | 10:29 |
bauzas | alex_xu: so I understood why it's needed to have distinct v2.0 and v2.1 policy rulesets | 10:29 |
bauzas | alex_xu: I just wonder if we should yell that | 10:30 |
RuiChen | johnthetubaguy: you're right, I will update my patch, thanks :0 | 10:30 |
RuiChen | johnthetubaguy: :0 | 10:30 |
bauzas | alex_xu: ie. explicitely telling to operators that as it's new API endpoints, they have fine-grained control for that too | 10:30 |
*** haomaiwa_ has quit IRC | 10:31 | |
*** markvoelker has quit IRC | 10:33 | |
*** joefides_ has joined #openstack-nova | 10:35 | |
*** zhangtralon has quit IRC | 10:35 | |
*** gtt116 has quit IRC | 10:38 | |
*** joefides has quit IRC | 10:38 | |
*** gtt116 has joined #openstack-nova | 10:38 | |
*** sdake has quit IRC | 10:41 | |
*** doron_afk is now known as doron | 10:41 | |
*** zul has quit IRC | 10:41 | |
*** lpetrut has joined #openstack-nova | 10:42 | |
*** zhangtralon has joined #openstack-nova | 10:42 | |
*** sudipto has joined #openstack-nova | 10:43 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Remove orphaned tables - iscsi_targets, volumes https://review.openstack.org/166214 | 10:45 |
johnthetubaguy | superdan: getting confused by this bug, I would love you to take a look when you can please, possibly going to trigger RC3 https://review.openstack.org/#/c/177186 | 10:47 |
*** gcivitella has joined #openstack-nova | 10:47 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova-specs: Implement server instance tagging https://review.openstack.org/177112 | 10:49 |
*** ociuhandu has quit IRC | 10:50 | |
*** lxsli0 is now known as lxsli | 10:52 | |
*** ujjain- has quit IRC | 10:52 | |
*** ujjain- has joined #openstack-nova | 10:52 | |
*** sdake has joined #openstack-nova | 10:52 | |
gcivitella | Do someone knows if it is possible to get notifications about system usage data (https://wiki.openstack.org/wiki/SystemUsageData)? I'd like to give my customers the ability to receive an email in case of reboot, resize. etc | 10:53 |
sdague | johnthetubaguy: https://review.openstack.org/#/c/79741/3 - I thought cells job should be green now | 10:57 |
*** alexpilotti has quit IRC | 10:58 | |
openstackgerrit | John Garbutt proposed openstack/nova: Cells: Call compute api methods with instance objects https://review.openstack.org/79741 | 10:58 |
*** VW_ has joined #openstack-nova | 10:58 | |
johnthetubaguy | sdague: it should be… thats a bad sign for sure | 10:59 |
sdague | so, I just realized the test results are pretty old | 10:59 |
sdague | I'm running a recheck | 10:59 |
*** gszasz has quit IRC | 10:59 | |
*** gszasz has joined #openstack-nova | 10:59 | |
*** VW_ has quit IRC | 10:59 | |
johnthetubaguy | sdague: did a rebase as a belt and braces approach | 11:00 |
*** VW_ has joined #openstack-nova | 11:00 | |
johnthetubaguy | just seen your recheck, I guess that should have been equivalent, oops | 11:00 |
sdague | yeh, no worries | 11:02 |
sdague | the rebase doesn't hurt eitehr | 11:02 |
*** afazekas has quit IRC | 11:05 | |
*** josecastroleon has quit IRC | 11:06 | |
openstackgerrit | Rui Chen proposed openstack/nova: Fix scheduler issue when multiple-create failed https://review.openstack.org/147048 | 11:06 |
*** josecastroleon has joined #openstack-nova | 11:06 | |
openstackgerrit | Rui Chen proposed openstack/nova: Clean up network_api.get_instance_nw_info https://review.openstack.org/173680 | 11:07 |
openstackgerrit | Rui Chen proposed openstack/nova: Fix empty instance nw_info cache https://review.openstack.org/146036 | 11:07 |
openstackgerrit | Rui Chen proposed openstack/nova: Fix failure of stopping instances during init host https://review.openstack.org/167926 | 11:08 |
*** josecastroleon has quit IRC | 11:08 | |
*** irenab has joined #openstack-nova | 11:08 | |
*** sdake has quit IRC | 11:10 | |
*** dulek_ has joined #openstack-nova | 11:10 | |
*** dprince has joined #openstack-nova | 11:11 | |
*** dulek has quit IRC | 11:12 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Fix disconnect_volume issue when find_multipath_device returns None https://review.openstack.org/159626 | 11:12 |
*** Anticimex has quit IRC | 11:13 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Add documentation for nova-cells and nova-idmapshift commands https://review.openstack.org/166553 | 11:13 |
*** afazekas has joined #openstack-nova | 11:21 | |
*** zhangtralon has quit IRC | 11:21 | |
*** salv-orlando has quit IRC | 11:23 | |
*** otter768 has joined #openstack-nova | 11:24 | |
*** coolsvap is now known as coolsvap|afk | 11:27 | |
*** dulek___ has joined #openstack-nova | 11:29 | |
*** otter768 has quit IRC | 11:29 | |
*** markvoelker has joined #openstack-nova | 11:29 | |
*** dulek_ has quit IRC | 11:29 | |
*** mpaolino has quit IRC | 11:30 | |
*** zul has joined #openstack-nova | 11:32 | |
*** markvoelker has quit IRC | 11:33 | |
*** markvoelker has joined #openstack-nova | 11:38 | |
*** salv-orlando has joined #openstack-nova | 11:45 | |
*** liusheng has quit IRC | 11:46 | |
*** liusheng has joined #openstack-nova | 11:46 | |
*** alexpilotti has joined #openstack-nova | 11:47 | |
*** zhenguo has quit IRC | 11:47 | |
*** mwagner_lap has quit IRC | 11:48 | |
*** doron is now known as doron_afk | 11:50 | |
bauzas | sdague: johnthetubaguy: saw your question about the cells job | 11:50 |
*** deepthi has quit IRC | 11:51 | |
bauzas | sdague: johnthetubaguy: the cells job should be green, but we still have some race failures | 11:51 |
*** baoli has joined #openstack-nova | 11:51 | |
sdague | bauzas: ok, this was old test results I think | 11:51 |
bauzas | sdague: johnthetubaguy: alaski is working on fixing a race on the instance.save() | 11:51 |
sdague | bauzas: are those race failures fingerprinted ? | 11:52 |
bauzas | sdague: yup, sec | 11:52 |
bauzas | sdague: https://review.openstack.org/#/c/177356/ | 11:52 |
*** RuiChen has quit IRC | 11:52 | |
*** arnaud____ has joined #openstack-nova | 11:52 | |
*** RuiChen has joined #openstack-nova | 11:53 | |
bauzas | sdague: also http://lists.openstack.org/pipermail/openstack-dev/2015-April/062605.html | 11:53 |
*** afazekas has quit IRC | 11:54 | |
*** lucasagomes is now known as lucas-hungry | 11:56 | |
sdague | bauzas: by fingerprint, I mean did you submit Elastic Recheck signatures? | 11:56 |
*** matrohon has joined #openstack-nova | 11:56 | |
*** arnaud____ has quit IRC | 11:57 | |
*** dikonoor has quit IRC | 11:58 | |
*** sileht has quit IRC | 11:59 | |
bauzas | sdague: yeah, good thing | 11:59 |
bauzas | sdague: I'll look at them and discuss with mriedem and alaski | 12:00 |
bauzas | sdague: and will upload some e-r changes if so | 12:00 |
*** Longgeek has quit IRC | 12:00 | |
*** ociuhandu has joined #openstack-nova | 12:00 | |
*** ociuhandu has quit IRC | 12:00 | |
*** alexpilotti has quit IRC | 12:01 | |
*** exploreshaifali has quit IRC | 12:01 | |
sdague | ok, great | 12:02 |
*** lucas-hungry has quit IRC | 12:02 | |
*** Longgeek has joined #openstack-nova | 12:05 | |
*** openstackgerrit has quit IRC | 12:06 | |
*** openstackgerrit has joined #openstack-nova | 12:06 | |
*** afazekas has joined #openstack-nova | 12:07 | |
*** sileht has joined #openstack-nova | 12:09 | |
*** VW_ has quit IRC | 12:10 | |
*** VW_ has joined #openstack-nova | 12:11 | |
*** haomaiwang has joined #openstack-nova | 12:13 | |
*** lucas-hungry has joined #openstack-nova | 12:14 | |
*** htruta has joined #openstack-nova | 12:14 | |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova: libvirt/utils.py: Cleanup create_cow_image function https://review.openstack.org/177574 | 12:15 |
*** mpaolino has joined #openstack-nova | 12:18 | |
*** mpaolino has quit IRC | 12:18 | |
kashyap | Seems like Jenkins and other CI messages are mixed with human comments again in Gerrit? | 12:18 |
*** dprince has quit IRC | 12:19 | |
*** VW_ has quit IRC | 12:22 | |
*** VW_ has joined #openstack-nova | 12:22 | |
*** BobBall_ is now known as BobBall | 12:22 | |
*** VW__ has joined #openstack-nova | 12:24 | |
*** VW_ has quit IRC | 12:24 | |
*** popw has quit IRC | 12:26 | |
*** joefides_ has quit IRC | 12:30 | |
*** claudiub has joined #openstack-nova | 12:31 | |
alex_xu | bauzas: I repiled comment at https://review.openstack.org/#/c/160089/ | 12:35 |
*** raildo has joined #openstack-nova | 12:35 | |
*** rfolco has joined #openstack-nova | 12:35 | |
alex_xu | bauzas: btw, how can I saw your comment on the policy.json? | 12:35 |
*** dprince has joined #openstack-nova | 12:36 | |
*** josecastroleon has joined #openstack-nova | 12:36 | |
*** Longgeek has quit IRC | 12:36 | |
bauzas | alex_xu: ? | 12:36 |
bauzas | alex_xu: I don't understand your question | 12:36 |
bauzas | alex_xu: is that your question ? https://review.openstack.org/#/c/160089/10/etc/nova/policy.json,cm | 12:36 |
*** openstackgerrit has quit IRC | 12:37 | |
alex_xu | bauzas: yea, thanks | 12:37 |
bauzas | alex_xu: long story short, I compared the default policies and none of them are not admin-only | 12:37 |
*** openstackgerrit has joined #openstack-nova | 12:37 | |
bauzas | alex_xu: which means that the policy authorizer is making sure that all calls are admin - unless the operator explicitely changed that | 12:38 |
alex_xu | bauzas: there is chance operator set the policy rule to empty. | 12:38 |
bauzas | alex_xu: so we can safely consider that all API calls to service_get_by_cn are validated by the policy enforcer | 12:38 |
bauzas | alex_xu: yeah, that's why we need to remove the context check | 12:39 |
*** Longgeek has joined #openstack-nova | 12:39 | |
bauzas | alex_xu: if not, we will have this kind of bug : | 12:39 |
bauzas | https://bugzilla.redhat.com/show_bug.cgi?id=1164271 | 12:39 |
openstack | bugzilla.redhat.com bug 1164271 in openstack-nova "nova evacuate not allowed for non-admin even after policy change" [Medium,Assigned] - Assigned to sbauza | 12:39 |
bauzas | alex_xu: ^ | 12:39 |
alex_xu | bauzas: the problem is in the long term before, those api only can be accessed by admin | 12:40 |
alex_xu | bauzas: even the operator set the rule to empty | 12:40 |
alex_xu | bauzas: and those api still work as admin api | 12:40 |
bauzas | alex_xu: I don't get your point | 12:40 |
bauzas | alex_xu: there is absolutely *zero* reason to not leave the operator define his access policy if we leave him to do that using policy.json | 12:41 |
alex_xu | bauzas: the operator may be didn't want to make the api to be called by non-admin user. operator just make wrong configuration to set the policy to empty | 12:41 |
bauzas | alex_xu: then, that's a configuration issue | 12:41 |
bauzas | alex_xu: either we trust the operators, or we remove the policy possibility | 12:41 |
alex_xu | bauzas: emm....we can't assume user always doing the right thing | 12:42 |
bauzas | alex_xu: but having require_admin_context() explicitely checking for is_admin is a bad thing if the operator wants to have the end-users calling the API | 12:42 |
bauzas | alex_xu: why can't we assume PEBKAC ? | 12:42 |
alex_xu | bauzas: although it's wrong, but in long term before, it is nova API's behavior. | 12:42 |
alex_xu | bauzas: ok, let me explain. | 12:42 |
bauzas | alex_xu: is that a good reason for not fixing a bug ? | 12:42 |
bauzas | alex_xu: I thought we were in agreement in the -dev thread I opened | 12:43 |
alex_xu | bauzas: for example, before kilo, this api is policy configuable, at now, it isn't configurable, then it is a bug | 12:43 |
bauzas | alex_xu: but that whole discussion makes me wonder why we still leave the operator define his rules, if we don't follow them | 12:43 |
alex_xu | bauzas: but the reality is at the beginning the api isn't policy configurable | 12:43 |
bauzas | alex_xu: agreed, that's a long story bug | 12:44 |
alex_xu | bauzas: there is similiar thing. | 12:44 |
bauzas | alex_xu: the one who added the policy check on the DB side probably didn't make the best decision he hads | 12:44 |
bauzas | alex_xu: because it doesn't leave the API enforce that | 12:44 |
bauzas | alex_xu: honestly, I don't get your point, you want to remove the DB checks by replacing them elsewhere in the API | 12:45 |
alex_xu | bauzas: in the API validation, before we have json-schema, there are a lot of api without better validation. And we can't just provide strict validation for the api. The reason is same for this case. Although user use nova api with wrong way, but it already is API's behavior, we can't just break it. | 12:45 |
bauzas | alex_xu: saying that's because it's historical sounds not a good reason to me | 12:45 |
bauzas | alex_xu: that's why I checked that for the corresponding service_get_by_cn method and that's it | 12:46 |
alex_xu | bauzas: emm... that is the reason we have some bug in the api, and we can't fix them | 12:46 |
bauzas | alex_xu: I'm not covering all the other API calls to the DB | 12:46 |
*** jecarey has quit IRC | 12:46 | |
bauzas | alex_xu: but you have my opinion : we should just make sure that the default policy rules for the corresponding DB methods are admin-only so we can just remove that method | 12:47 |
alex_xu | bauzas: that is for v2.1 API, not the v2 | 12:47 |
bauzas | alex_xu: that's just what mriedem said explictely | 12:47 |
bauzas | aaaaaarrrrrh :) | 12:47 |
bauzas | why ? | 12:47 |
*** ajo has joined #openstack-nova | 12:48 | |
alex_xu | bauzas: emm....ok | 12:48 |
*** VW__ has quit IRC | 12:48 | |
bauzas | I mean, each API has its policy ruleset, I can understand | 12:48 |
*** dpaterson has joined #openstack-nova | 12:48 | |
bauzas | for both of the APIs, the 3 methods you added back the context check were just enforcing an admin level | 12:48 |
bauzas | there is no matter of v2.1 or v2.0 that's just identical | 12:49 |
bauzas | alex_xu: ^ | 12:50 |
alex_xu | bauzas: ok, you mean remove the context check for aggregate, host api also? | 12:51 |
alex_xu | and evacuate | 12:51 |
bauzas | alex_xu: I mean that only that change is necessary https://review.openstack.org/#/c/160089/10/nova/db/sqlalchemy/api.py,cm | 12:52 |
*** sileht has quit IRC | 12:52 | |
bauzas | alex_xu: the other files can be git checkout'd to HEAD | 12:52 |
alex_xu | bauzas: ok, got it | 12:52 |
bauzas | (well, your previous HEAD actually :D) | 12:52 |
openstackgerrit | Victor Stinner proposed openstack/nova-specs: Add "Port Nova to Python 3" spec https://review.openstack.org/176868 | 12:53 |
alex_xu | bauzas: but it will be different the nova spec said https://github.com/openstack/nova-specs/commit/995c676a3ee56af479b7f74960d468c050cc2fbc#diff-67150f76e50d28ac82be44133bd514f9R121 | 12:53 |
*** jungleboyj has quit IRC | 12:53 | |
openstackgerrit | Victor Stinner proposed openstack/nova-specs: "Adding Python 3.4 support to Nova" spec https://review.openstack.org/176868 | 12:53 |
*** thomasem has joined #openstack-nova | 12:54 | |
*** lucas-hungry is now known as lucasagomes | 12:54 | |
bauzas | alex_xu: do you want me to propose a change to the spec ? | 12:55 |
alex_xu | bauzas: no~ :) | 12:55 |
bauzas | alex_xu: I mean, that's doable | 12:55 |
bauzas | alex_xu: take alaski's example on an approved spec https://review.openstack.org/#/c/176083/ | 12:56 |
alex_xu | bauzas: for rest of policy and already merged patches you want to remove back-compatible change also? if yes, we should get agreement on the spec first I think... | 12:58 |
*** sudipto has quit IRC | 12:58 | |
*** dikonoor has joined #openstack-nova | 12:58 | |
*** Anticimex has joined #openstack-nova | 13:00 | |
bauzas | alex_xu: well, I honestly think it's the best path, yeah - but as said mriedem's guru, we first need to make sure that all APIs that are calling DB methods decorated by the context check are actually having a default policy rule set to admin | 13:01 |
*** zhenguo has joined #openstack-nova | 13:02 | |
alex_xu | bauzas: ok, would you like make a change to the spec? then let's get agreement on it. | 13:02 |
bauzas | alex_xu: sure thing | 13:03 |
bauzas | alex_xu: just adding it to my todo stack :) | 13:03 |
*** joefides has joined #openstack-nova | 13:03 | |
alex_xu | bauzas: thanks, before change direction let update spec first. | 13:04 |
haypo | ndipanov: hi. i updated my python 3 spec to have a more explicit title ;) in general, the new version of the spec is more explicit. https://review.openstack.org/#/c/176868/ | 13:05 |
*** ivasev has joined #openstack-nova | 13:05 | |
ndipanov | haypo, ah I see you added the bit about whitelisting tests that are know to pass | 13:06 |
ndipanov | nice | 13:06 |
haypo | ndipanov: i just rephrased what i wrote before, i already planned to use a whitelist ;) | 13:07 |
ndipanov | haypo, right | 13:07 |
ndipanov | yes I see | 13:08 |
haypo | ndipanov: thanks for your review | 13:08 |
ndipanov | I mean it's a no brainer imho | 13:08 |
*** ZZelle has joined #openstack-nova | 13:08 | |
*** subscope has quit IRC | 13:09 | |
*** alexpilotti has joined #openstack-nova | 13:10 | |
*** oro has quit IRC | 13:13 | |
bauzas | alex_xu: I'm really sorry that I missed your spec, I would have so much to tell :/ | 13:13 |
alex_xu | bauzas: it's fine, you are telling me now :) | 13:15 |
alex_xu | bauzas: hah, you +1 on https://review.openstack.org/#/c/138270/11 :) | 13:17 |
*** dims has quit IRC | 13:17 | |
*** dims has joined #openstack-nova | 13:18 | |
*** wverdugo500 has left #openstack-nova | 13:18 | |
bauzas | alex_xu: yeah I was probably NEC - not enough caffeinated | 13:18 |
bauzas | alex_xu: tbh, it was not explicetly explained that the hard-checks were checking the context, and not the policy | 13:19 |
bauzas | alex_xu: I just recently discovered that | 13:19 |
alex_xu | bauzas: yea, it's fine, all of our discussion is want to make thing right :) | 13:20 |
alex_xu | bauzas: let's correct the direction if we think we are wrong | 13:20 |
*** yamahata has quit IRC | 13:21 | |
*** openstackgerrit has quit IRC | 13:21 | |
*** openstackgerrit has joined #openstack-nova | 13:22 | |
*** neelashah has joined #openstack-nova | 13:24 | |
*** russellb has quit IRC | 13:24 | |
*** subscope has joined #openstack-nova | 13:24 | |
*** otter768 has joined #openstack-nova | 13:25 | |
*** vladikr has joined #openstack-nova | 13:25 | |
*** 7JTAAIHSL has quit IRC | 13:26 | |
*** eharney has quit IRC | 13:27 | |
*** andrearosa has quit IRC | 13:27 | |
bauzas | alex_xu: https://review.openstack.org/177764 | 13:27 |
*** russellb has joined #openstack-nova | 13:28 | |
alex_xu | bauzas: thanks | 13:28 |
*** mriedem has joined #openstack-nova | 13:29 | |
*** otter768 has quit IRC | 13:29 | |
mriedem | howdy | 13:30 |
gilliard | pip pip | 13:30 |
superdan | johnthetubaguy: oh jeez | 13:31 |
*** superdan is now known as dansmith | 13:31 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova-specs: Remove the use of require_admin_context in the API https://review.openstack.org/177764 | 13:31 |
johnthetubaguy | dansmith: yeah, I guess we do it a bit earlier next time… | 13:31 |
*** cfriesen has joined #openstack-nova | 13:31 | |
*** sileht has joined #openstack-nova | 13:32 | |
johnthetubaguy | dansmith: we have RC3 ready to go in the morning, if we can get that merged in master | 13:32 |
bauzas | mriedem: holà , was just referring you as a guru | 13:32 |
*** ajayaa has quit IRC | 13:32 | |
*** mestery_ is now known as mestery | 13:32 | |
mriedem | oh boy | 13:32 |
*** VW_ has joined #openstack-nova | 13:32 | |
*** VW_ has quit IRC | 13:32 | |
bauzas | :) | 13:33 |
*** VW_ has joined #openstack-nova | 13:33 | |
dims | hi bauzas, mriedem | 13:33 |
dikonoor | mriedem : hi | 13:33 |
bauzas | mriedem: all of the convo was about https://review.openstack.org/#/c/177764/ | 13:33 |
bauzas | dims: aloha | 13:33 |
bauzas | man, it's 3:30pm for me and I had zero time to work on my patches yet :( | 13:34 |
dansmith | johnthetubaguy: we can't really do it earlier | 13:34 |
* bauzas should seriously consider to train her daughter to write code | 13:34 | |
dims | bauzas: :) mahalo | 13:34 |
dikonoor | mriedem : dauzas : and https://review.openstack.org/#/c/176651/ and https://review.openstack.org/#/c/160089/ | 13:34 |
*** dboik has quit IRC | 13:34 | |
johnthetubaguy | dansmith: very true | 13:34 |
bauzas | dikonoor: I don't who that dauzas is at all :D | 13:35 |
*** eglynn has joined #openstack-nova | 13:35 | |
dikonoor | bauzas : oops..sorry..typos | 13:35 |
dims | lol | 13:35 |
dikonoor | bauzas : :) | 13:35 |
bauzas | well, sometimes when I get a cough, I could name myself like that :) | 13:35 |
*** doron_afk has quit IRC | 13:35 | |
*** doron_afk has joined #openstack-nova | 13:36 | |
*** ganso_ has joined #openstack-nova | 13:38 | |
mriedem | johnthetubaguy: dikonoor: bauzas: alex_xu: i'm +2 on https://review.openstack.org/#/c/176651/ now | 13:39 |
johnthetubaguy | mriedem: gotcha, as this is the fix we can backport | 13:41 |
*** arnaud____ has joined #openstack-nova | 13:41 | |
johnthetubaguy | bauzas: are you OK with the above idea? | 13:41 |
*** lucasagomes has quit IRC | 13:41 | |
*** artom has joined #openstack-nova | 13:42 | |
*** josecastroleon has quit IRC | 13:43 | |
*** lucasagomes has joined #openstack-nova | 13:43 | |
alex_xu | johnthetubaguy: mriedem, emm... bauzas is say no to that patch, we have a lot of discussion above. bauzas prefer this https://review.openstack.org/#/c/177764/ | 13:43 |
*** burt has joined #openstack-nova | 13:43 | |
mriedem | alex_xu: we're not going to backport https://review.openstack.org/#/c/177764/ to stable/kilo | 13:43 |
bauzas | sorry was around to fix my coffee machine | 13:44 |
bauzas | mriedem: the problem is that I thought on how correctly backporting to kilo what was necessary | 13:44 |
*** josecastroleon has joined #openstack-nova | 13:44 | |
alex_xu | mriedem: yea, right, I mean bauzas prefer to not add back-compatible change | 13:44 |
*** morganfainberg has quit IRC | 13:44 | |
*** jroll has quit IRC | 13:44 | |
*** jroll has joined #openstack-nova | 13:44 | |
bauzas | mriedem: so I went through the policy.json file to see if the engine was already enforcing the admin rules for the 3 API methods calling service_get_by_cn | 13:45 |
bauzas | mriedem: and the answer is... yes | 13:45 |
*** exploreshaifali has joined #openstack-nova | 13:45 | |
*** arnaud____ has quit IRC | 13:45 | |
bauzas | mriedem: so, we can just remove the DB decorator on service_get_by_cn(), it won't impact how the users are enforced | 13:45 |
mriedem | bauzas: so you want to propose that as the fix for bug 1447084 on master and backport that to stable/kilo, and have that done in the next 24 hours or so? | 13:46 |
openstack | bug 1447084 in OpenStack Compute (nova) "view hypervisor details should be controlled by policy.json" [High,In progress] https://launchpad.net/bugs/1447084 - Assigned to Divya K Konoor (dikonoor) | 13:46 |
bauzas | mriedem: long story short, https://review.openstack.org/#/c/160089/10/ only needs to remove the decorator so we can cherry-pick it | 13:46 |
openstackgerrit | Sergey Nikitin proposed openstack/nova-specs: Implement server instance tagging https://review.openstack.org/177112 | 13:47 |
*** morganfainberg has joined #openstack-nova | 13:47 | |
bauzas | mriedem: I'm proposing only https://review.openstack.org/#/c/160089/10/nova/db/sqlalchemy/api.py,cm to backport to Kilo | 13:47 |
-openstackstatus- NOTICE: gerrit has been restarted to clear a problem with its event stream. change events between 13:09 and 13:36 utc should be rechecked or have approval votes reapplied as needed to trigger jobs | 13:47 | |
*** Murali has quit IRC | 13:48 | |
bauzas | mriedem: no need to elevate a context, as we're sure that the API methods are fencing it by the policy enforcer | 13:48 |
mriedem | bauzas: and what about these backwards compat checks in the v2 api once the db api decorator is gone? https://review.openstack.org/#/c/160089/10/nova/api/openstack/compute/contrib/hosts.py | 13:48 |
dansmith | johnthetubaguy: I commented. Hans is usually on top of replies, so I'll monitor and make the change myself if he doesn't soon | 13:48 |
bauzas | mriedem: that's not user-facing, here is my take | 13:49 |
mriedem | bauzas: knowing that we probably won't come to agreement on removing all of those in the v2 API via your spec by the time kilo needs to release | 13:49 |
*** jecarey has joined #openstack-nova | 13:49 | |
bauzas | mriedem: agreed, my point is just about service_get_by_cn for backporting | 13:49 |
bauzas | mriedem: all the other context decorators need to be removed but we won't backport them to Kilo | 13:50 |
*** apuimedo_ has quit IRC | 13:50 | |
*** oro has joined #openstack-nova | 13:53 | |
mriedem | idk, i'd have to go back to stable/kilo and see what remove the db api decorator would mean to anything using it and make sure policy files are covering all of those apis - and it'll be an odd backport for stable reviewers to review since it will look like a security issue | 13:54 |
mriedem | the fix that dikonoor has up is much more targeted | 13:54 |
*** mkoderer has quit IRC | 13:55 | |
*** dboik has joined #openstack-nova | 13:55 | |
bauzas | mriedem: okay, then I guess that https://review.openstack.org/#/c/160089/ needs to be rebased on top of https://review.openstack.org/#/c/160089/ to remove that line, right ? | 13:55 |
bauzas | argh | 13:55 |
bauzas | ok, rewinding | 13:55 |
mriedem | to remove the context.elevated() line? | 13:55 |
*** vishy has quit IRC | 13:55 | |
bauzas | mriedem: https://review.openstack.org/#/c/160089/ depending on https://review.openstack.org/#/c/176651/ | 13:56 |
bauzas | mriedem: yup | 13:56 |
mriedem | sure, though it doesn't really matter. at that point we've already checked the policy against the context | 13:56 |
bauzas | mriedem: agreed, that's just debt | 13:57 |
*** subscope has quit IRC | 13:57 | |
*** mwagner_lap has joined #openstack-nova | 13:57 | |
bauzas | mriedem: but I want to make things clear that this is just a "pirouette" (will translate the word later) for a +1/-1 one-liner change | 13:57 |
bauzas | mriedem: just for backporting purpose | 13:58 |
*** vishy has joined #openstack-nova | 13:58 | |
*** mpaolino has joined #openstack-nova | 13:58 | |
*** eharney has joined #openstack-nova | 13:58 | |
*** mkoderer has joined #openstack-nova | 13:58 | |
bauzas | okay, pirouette == twist | 13:58 |
mriedem | i know what it is :) | 13:58 |
bauzas | well, that's a french word :) | 13:59 |
mriedem | i'm a black belt in ballet | 13:59 |
* alex_xu search dictionary... | 13:59 | |
bauzas | mriedem: https://www.youtube.com/watch?v=3gw0rRw8ipA | 13:59 |
mriedem | croissant is a french word too | 13:59 |
alex_xu | bauzas: mriedem , do you want me make https://review.openstack.org/#/c/160089/10 depend on https://review.openstack.org/#/c/176651/ now? | 14:00 |
mriedem | alex_xu: might as well wait to see how we settle on https://review.openstack.org/#/c/176651/ | 14:00 |
bauzas | alex_xu: well, I just think we add a new elevated() method which becomes useless by your change, so hence my depending-on point | 14:00 |
mriedem | bauzas: yeah https://review.openstack.org/#/c/176651/ is a hacky workaround just to backport, i agree with that | 14:00 |
bauzas | mriedem: okay, then +1 on it | 14:00 |
mriedem | the half baked nature of the blueprint makes things messy for fixing on stable, which sucks, but it is what it is | 14:01 |
*** tonytan4ever has joined #openstack-nova | 14:01 | |
mriedem | C'est la vie | 14:01 |
mriedem | ! | 14:01 |
alex_xu | mriedem: bauzas ok, got it | 14:01 |
mriedem | bauzas: i get points for that btw ^ | 14:01 |
* alex_xu search dictionary again | 14:02 | |
*** alexpilotti has quit IRC | 14:02 | |
bauzas | mriedem: lemme give you a bonus point | 14:02 |
bauzas | okay, cool, I can now go back to my duties ! | 14:03 |
*** thangp has joined #openstack-nova | 14:03 | |
bauzas | :p | 14:03 |
alex_xu | bauzas: thanks :) | 14:03 |
*** wznoinsk has joined #openstack-nova | 14:03 | |
bauzas | alex_xu: thanks for your patience, we'll discuss again on https://review.openstack.org/#/c/177764/ | 14:03 |
alex_xu | bauzas: np, yea~ | 14:04 |
*** toure has joined #openstack-nova | 14:04 | |
mriedem | ndipanov: added you to https://review.openstack.org/#/c/177084/ since it's bdm-related :) actually surprised the author didn't already add you since nearly the entire core team was already added to it. | 14:05 |
mriedem | jgriffith: with cinder multi-attach, can i attach a volume to instance A and then boot instance B from that same volume? | 14:06 |
ndipanov | mriedem, maybe the author knows something I don't :) | 14:06 |
*** exploreshaifali has quit IRC | 14:06 | |
*** pradipta has joined #openstack-nova | 14:07 | |
*** dkliban has joined #openstack-nova | 14:10 | |
openstackgerrit | Alex Xu proposed openstack/nova: Add version bump guideline in microversion devref https://review.openstack.org/177778 | 14:11 |
dikonoor | mriedem : Thanks for resolving the confusion around https://review.openstack.org/#/c/176651/ johnthetubaguy: Could you review the changes again ? bauzas : dauzas , thx for the +1 | 14:12 |
*** abhishekk has quit IRC | 14:13 | |
*** beagles is now known as beagles_brb | 14:13 | |
alex_xu | johnthetubaguy: I work out first version for when we bump microversion: https://review.openstack.org/#/c/177778 but it pretty preview. I will tuning the word and format tomorrow. | 14:13 |
*** subscope has joined #openstack-nova | 14:13 | |
* bauzas should definitely rename himself as Sylvain Dauza | 14:14 | |
*** rushil has joined #openstack-nova | 14:16 | |
*** mtanino has joined #openstack-nova | 14:17 | |
*** BadCub_Hiding is now known as BadCub | 14:19 | |
*** salv-orl_ has joined #openstack-nova | 14:22 | |
openstackgerrit | Dan Smith proposed openstack/nova: Add security group calls missing from latest compute rpc api version bump https://review.openstack.org/177186 | 14:23 |
*** salv-orlando has quit IRC | 14:23 | |
*** jungleboyj has joined #openstack-nova | 14:26 | |
jgriffith | mriedem: in theory you'll be able to do stuff like that | 14:30 |
jgriffith | mriedem: AIR there's a good deal of change still needed on the initiator side of things to make all of that work though | 14:31 |
dansmith | johnthetubaguy: ^ | 14:32 |
mriedem | jgriffith: so i was on the wrong track on that https://review.openstack.org/#/c/177084/ | 14:32 |
dansmith | johnthetubaguy: I can backport to stable/kilo if you're good with it | 14:32 |
mriedem | jgriffith: turns out it's not a volume bdm, it's snapshot/image/blank bdm's | 14:32 |
mriedem | where nova creates them on boot | 14:33 |
*** sudipto has joined #openstack-nova | 14:33 | |
mriedem | so nova is creating these things in cinder, we timeout waiting for the volume to be available, and the instance boot goes to error but the volume is orphaned | 14:33 |
*** achanda has joined #openstack-nova | 14:33 | |
mriedem | the generic use of 'volume' all over the code confused me | 14:33 |
johnthetubaguy | dansmith: that would be awesome, thank you | 14:33 |
*** ajayaa has joined #openstack-nova | 14:33 | |
mriedem | since the gory details are down in the virt layer, not where this change is being made | 14:34 |
dansmith | johnthetubaguy: https://review.openstack.org/177791 | 14:35 |
*** Longgeek has quit IRC | 14:35 | |
*** Longgeek has joined #openstack-nova | 14:36 | |
jgriffith | mriedem: ohh... I've been asking this person for clarification on that bug. Maybe the patch will help me :) | 14:36 |
* jgriffith is looking | 14:36 | |
mriedem | jgriffith: i think i have enough comments in there now to understand it | 14:36 |
mriedem | jgriffith: but it doesn't fix the bug anyway | 14:36 |
*** tjones1 has joined #openstack-nova | 14:37 | |
johnthetubaguy | dansmith: awesome, thank you | 14:38 |
jgriffith | mriedem: yeah, that's not useful that I can see | 14:38 |
*** browne has joined #openstack-nova | 14:38 | |
*** tsekiyama has joined #openstack-nova | 14:38 | |
*** Kevin_Zheng has quit IRC | 14:40 | |
*** dave-mccowan has joined #openstack-nova | 14:40 | |
*** mspreitz has joined #openstack-nova | 14:41 | |
*** foexle has quit IRC | 14:41 | |
*** achanda has quit IRC | 14:41 | |
jgriffith | mriedem: so I'm pretty opposed to introducing any concept of Nova auto-deleting a Cinder resource that a user tried to bring in to Nova FWIW | 14:43 |
mriedem | jgriffith: yeah, that was my original -1 | 14:44 |
mriedem | but in the case of these bdm types, nova is actually creating them | 14:44 |
mriedem | sec | 14:44 |
jgriffith | mriedem: ahh... didn't see that. Umm... but how do you "know" that | 14:44 |
jgriffith | mriedem: I mean, I know that code-path exists, but I don't see a way to detect it later | 14:44 |
mriedem | snapshot: http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/block_device.py#n318 | 14:44 |
johnthetubaguy | dansmith: I am thinking we just do RC3 containing only that patch, to limit the regression risk of stuffing anything else in there, does that work for you as well? | 14:44 |
mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/block_device.py#n340 | 14:44 |
mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/virt/block_device.py#n363 | 14:45 |
jgriffith | mriedem: yeah, I've never liked that method by the way :) It's never really worked reliably | 14:45 |
mriedem | jgriffith: so for those types nova creates the volume in cinder and the method being changed in the compute manager is the wait_func passed down here | 14:45 |
dansmith | johnthetubaguy: there was another thing recently that I was thinking should be in rc3 if we did it, let me look and think | 14:45 |
jgriffith | mriedem: anything larger than a Cirros image tends to time out | 14:45 |
mriedem | jgriffith: the wait function you mean? | 14:46 |
dansmith | johnthetubaguy: ah, this one: https://review.openstack.org/#/c/176741/ | 14:46 |
jgriffith | mriedem: That might be new since I last looked | 14:46 |
dansmith | johnthetubaguy: that's not runtime code, so regression concerns are small I think, but it's something people have to have before they can roll forward | 14:46 |
mriedem | jgriffith: i think _await_block_device_map_created in the compute manager has been around a long time | 14:47 |
jgriffith | mriedem: which would solve my big problem with it. We never make the usual 90 second default | 14:47 |
johnthetubaguy | dansmith: oh, thats a good point... | 14:47 |
*** nkrinner has quit IRC | 14:47 | |
jgriffith | mriedem: oh.. derp | 14:47 |
jgriffith | mriedem: so the problem is that 9/10 times thta volume_api.create is going to fail | 14:47 |
mriedem | jgriffith: so the default wait there is 3 minutes | 14:48 |
mriedem | loops 60 times with a 3 second wait in between loops | 14:48 |
mriedem | jgriffith: fail how? | 14:48 |
*** zz_jgrimm is now known as jgrimm | 14:48 | |
jgriffith | mriedem: anyway... but if you have an image/volume that's a couple gig and you are doing the qemu-convert/dd or even just a dd it can take longer | 14:48 |
jgriffith | if you don't have a "real" iSCSI network | 14:48 |
jgriffith | mriedem: lemme look at it and make sure it's the same use case that I'm talking about | 14:49 |
*** hemnafk is now known as hemna | 14:49 | |
jgriffith | mriedem: I could be leading you down the wrong path here :) | 14:49 |
claudiub | any ironic fellows around? | 14:49 |
jgriffith | mriedem: but regardless for the submitters patch to be "safe" IMO we'd need to have a marker that tells us Nova created the resource before allowing Nova to delete it | 14:50 |
*** ajayaa has quit IRC | 14:50 | |
mriedem | jgriffith: yeah, that's what i was worried about. right now this is very tightly coupled with assuming the virt layer bdm code is doing the create | 14:51 |
mriedem | which today it is, but someone could change that later and forget to update this and then oops data loss | 14:51 |
*** annegentle has joined #openstack-nova | 14:51 | |
jgriffith | mriedem: yep | 14:51 |
jgriffith | mriedem: very easily could happen I think | 14:51 |
mriedem | so my comment for that was, rather than the compute manager doing this, let the nova.virt.block_device code handle the volume delete on failure since that's the layer that's doing the volume create | 14:53 |
mriedem | leave the compute manager out of it | 14:53 |
jgriffith | mriedem: makes sense, and it's relatively EZ as it already has the knowledge | 14:53 |
jgriffith | mriedem: reading your comment now | 14:53 |
*** salv-orl_ has quit IRC | 14:54 | |
*** zul has quit IRC | 14:59 | |
*** marcusvrn_ has joined #openstack-nova | 14:59 | |
*** zul has joined #openstack-nova | 14:59 | |
*** zzzeek has joined #openstack-nova | 15:00 | |
*** tsekiyama has quit IRC | 15:00 | |
*** ociuhandu has joined #openstack-nova | 15:01 | |
*** beagles_brb is now known as beagles | 15:01 | |
*** gszasz has quit IRC | 15:04 | |
*** doron_afk is now known as doron | 15:04 | |
*** ajayaa has joined #openstack-nova | 15:06 | |
*** dsanders has joined #openstack-nova | 15:06 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova-specs: Implement server instance tagging https://review.openstack.org/177112 | 15:07 |
*** nelsnelson has joined #openstack-nova | 15:07 | |
*** dulek___ has quit IRC | 15:08 | |
*** davideagnello has joined #openstack-nova | 15:09 | |
*** aix has quit IRC | 15:09 | |
*** arnaud____ has joined #openstack-nova | 15:12 | |
*** annegentle has quit IRC | 15:12 | |
*** kbyrne has quit IRC | 15:12 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Virt: update shared storage base methods https://review.openstack.org/162457 | 15:13 |
*** davideagnello has quit IRC | 15:13 | |
mriedem | ^ pulled that out of the gate since the ceph job was failing on it | 15:14 |
kashyap | mriedem: Hi, a random Virt question. . .do you know of any strange storage cases where while creating a base qcow2 image (with `qemu_img`), you set a non-default cluster_size value (between 512K and 2MB)? | 15:14 |
mriedem | mtreinish: hmm, wtf, the ceph job is supposed to be voting... | 15:15 |
*** afazekas has quit IRC | 15:15 | |
mtreinish | mriedem: it is voting isn't it? | 15:15 |
mriedem | mtreinish: it was.... | 15:15 |
mriedem | kashyap: doesn't ring a bell | 15:15 |
mriedem | mtreinish: checking project-config | 15:16 |
*** kbyrne has joined #openstack-nova | 15:16 | |
*** salv-orlando has joined #openstack-nova | 15:16 | |
mtreinish | mriedem: look at status.o.o/zuul the nova patch at the top of the gate is run ceph voting | 15:16 |
*** arnaud____ has quit IRC | 15:16 | |
*** zhenguo has quit IRC | 15:17 | |
mriedem | mtreinish: ah, https://review.openstack.org/#/c/162457/2 - jenkins was 3/24 there, before we made the ceph job voting | 15:18 |
mtreinish | ah, ok | 15:18 |
*** dsanders has quit IRC | 15:19 | |
*** dguitarbite has quit IRC | 15:19 | |
mriedem | mtreinish: i can't find a fingerprint on that trace | 15:22 |
*** Nikolay_St has quit IRC | 15:22 | |
*** marun has joined #openstack-nova | 15:22 | |
mriedem | ah here we go | 15:23 |
*** dboik_ has joined #openstack-nova | 15:23 | |
*** irenab_ has joined #openstack-nova | 15:23 | |
mriedem | http://goo.gl/i5daj0 | 15:23 |
mriedem | started today | 15:23 |
mriedem | mtreinish: it only hit on 2 changes, gary's and alaski's: https://review.openstack.org/#/c/171299/ | 15:24 |
*** irenab has quit IRC | 15:24 | |
*** irenab_ is now known as irenab | 15:24 | |
*** artom_ has joined #openstack-nova | 15:25 | |
*** artom has quit IRC | 15:25 | |
*** otter768 has joined #openstack-nova | 15:26 | |
*** dboik has quit IRC | 15:26 | |
*** tojuvone has quit IRC | 15:26 | |
mdbooth | Nova requirements.txt contains: | 15:28 |
mdbooth | oslo.db>=1.7.0,<1.8.0 # Apache-2.0 | 15:28 |
mdbooth | Any idea why that <1.8.0 is in there? | 15:28 |
mriedem | mdbooth: stable branch caps on requirements | 15:28 |
mriedem | synced from global-requirements | 15:28 |
mdbooth | What do I need to do to use newer oslo.db? | 15:28 |
mriedem | those will be uncapped at some point in liberty | 15:28 |
mriedem | propose a change to global-requirements | 15:29 |
*** Marga_ has joined #openstack-nova | 15:29 | |
mdbooth | Thanks | 15:29 |
mdbooth | Incidentally, how do I see the version of oslo.db in git? | 15:29 |
mdbooth | My grep-fu is failing me | 15:29 |
*** Marga__ has joined #openstack-nova | 15:29 | |
*** obondarev_ is now known as obondarev | 15:30 | |
jroll | mdbooth: 'git tag' should show you all versions available | 15:30 |
kashyap | mriedem: Np. If you're curious, read the discussion here in this commit message -- https://review.openstack.org/#/c/177574/3//COMMIT_MSG | 15:30 |
*** otter768 has quit IRC | 15:30 | |
mtreinish | mriedem: they should already be uncapped | 15:31 |
kashyap | mdbooth: You might want to look too (since you commented :-) ) DanPB has a valid point there. | 15:31 |
*** penick has joined #openstack-nova | 15:31 | |
mtreinish | mriedem: http://git.openstack.org/cgit/openstack/requirements/tree/global-requirements.txt#n66 | 15:31 |
*** tjones1 has quit IRC | 15:32 | |
*** Marga_ has quit IRC | 15:33 | |
bauzas | johnthetubaguy: FYI, https://blueprints.launchpad.net/nova/+spec/check-destination-on-migrations | 15:33 |
bauzas | johnthetubaguy: we discussed about that a couple of days before | 15:34 |
openstackgerrit | Chris Friesen proposed openstack/nova: libvirt: check qemu version for NUMA & hugepage support https://review.openstack.org/170780 | 15:34 |
bauzas | johnthetubaguy: just a clarification, I'm planning to expose it at the API level (for the optionnality of checking the destination) so a spec would be needed | 15:35 |
johnthetubaguy | bauzas: yeah, API means needs a spec | 15:35 |
openstackgerrit | Dimitri Mazmanov proposed openstack/nova: Fix documentation for scheduling filters https://review.openstack.org/177824 | 15:35 |
bauzas | johnthetubaguy: do you agree with the optionality, or should I split my bp into 2, one for extending the Scheduler API (not requiring a spec) and one for exposing it at the API level ? | 15:35 |
*** nelsnelson has quit IRC | 15:35 | |
johnthetubaguy | bauzas: only needs one spec I think | 15:36 |
bauzas | johnthetubaguy: and one BP ? :) | 15:36 |
johnthetubaguy | bauzas: yep, its 1:1 | 15:36 |
bauzas | johnthetubaguy: yeah ok, that's what I thought | 15:36 |
*** dboik_ has quit IRC | 15:36 | |
bauzas | it's more convenient to make it optional | 15:36 |
johnthetubaguy | bauzas: its a use case thing, be clear why we don't check it when for the "admin" operations | 15:36 |
*** dboik has joined #openstack-nova | 15:37 | |
johnthetubaguy | bauzas: not sure what you mean by optional, but I look forward to reviewing the spec | 15:37 |
bauzas | johnthetubaguy: all the migration tasks are admin only, I think | 15:37 |
*** foexle has joined #openstack-nova | 15:37 | |
johnthetubaguy | bauzas: by default, and in concept, yet | 15:37 |
*** Marga__ has quit IRC | 15:37 | |
bauzas | you can't evacuate if you're an end-user | 15:37 |
johnthetubaguy | s/yet/yes/ | 15:37 |
johnthetubaguy | bauzas: thats up to policy, but in general, no | 15:38 |
bauzas | johnthetubaguy: ok, I'm not planning to modify that, just adding a new --check option to the CLI | 15:38 |
johnthetubaguy | bauzas: hmm, OK, I imagined a check destination call thats separate | 15:38 |
bauzas | johnthetubaguy: agreed, that's just the matter of all the loooong convo that I discussed with mriedem and alex_xu :) | 15:38 |
bauzas | johnthetubaguy: that would be a new Scheduler API call | 15:39 |
*** armax has joined #openstack-nova | 15:39 | |
bauzas | johnthetubaguy: but within the conductor methods for the migrations, it would be optional - given what's in the API | 15:39 |
bauzas | johnthetubaguy: if not, operators could complain we would add a call to the scheduler for something which was not done already | 15:39 |
bauzas | johnthetubaguy: but let's discuss on the spec | 15:40 |
johnthetubaguy | bauzas: I think its a separate API call, but yeah, lets discuss on the spec | 15:40 |
*** mpavone has quit IRC | 15:40 | |
bauzas | johnthetubaguy: ooooh I see your point | 15:40 |
bauzas | johnthetubaguy: I'll mention that as alternative, thanks for the idea | 15:41 |
johnthetubaguy | bauzas: but either could work I guess, needs thought | 15:41 |
johnthetubaguy | sounds good | 15:41 |
*** browne has quit IRC | 15:41 | |
*** angdraug has joined #openstack-nova | 15:42 | |
mdbooth | mtreinish: Interesting. Any idea what the schedule is for nova to pull in global requirements? | 15:42 |
*** flashgordon is now known as jogo | 15:42 | |
*** annashen has joined #openstack-nova | 15:42 | |
mriedem | jbernard: i can't figure out what's changed outside of those changes which might be breaking the ceph jobs | 15:43 |
mriedem | jbernard: it passed the check queue on https://review.openstack.org/#/c/171299/ though | 15:43 |
mriedem | and that doesn't have anything to do directly with shared storage | 15:43 |
mtreinish | mdbooth: https://review.openstack.org/#/c/176844/ | 15:43 |
*** dikonoor has quit IRC | 15:43 | |
jbernard | mriedem: does it break outside of those changes? | 15:44 |
mriedem | jbernard: nope | 15:44 |
mriedem | jbernard: http://goo.gl/i5daj0 | 15:44 |
*** annashen has quit IRC | 15:44 | |
*** jroll has quit IRC | 15:44 | |
*** dikonoor has joined #openstack-nova | 15:45 | |
*** jroll has joined #openstack-nova | 15:46 | |
*** sdake has joined #openstack-nova | 15:47 | |
*** josecastroleon has quit IRC | 15:48 | |
*** nelsnelson has joined #openstack-nova | 15:49 | |
openstackgerrit | Chris Friesen proposed openstack/nova: unify libvirt driver checks for qemu https://review.openstack.org/175542 | 15:50 |
jbernard | that's odd, ill try it out but I need a bit of time, im juggling a few things at the momemnt | 15:50 |
mdbooth | self.assertEqual(2, mock_safe_decode.call_count) | 15:50 |
* mdbooth asserts that this kind of test is wrong in almost all circumstances | 15:51 | |
cfriesen | mriedem: could you take a quick look at https://review.openstack.org/#/c/170780/ ? It's basically the same as wehn you did +2 earlier, just updated due to merge conflicts. | 15:51 |
*** bkopilov has quit IRC | 15:52 | |
*** jroll has quit IRC | 15:53 | |
*** jroll has joined #openstack-nova | 15:53 | |
*** salv-orlando has quit IRC | 15:53 | |
*** tjones1 has joined #openstack-nova | 15:54 | |
*** rpodolyaka1 has joined #openstack-nova | 15:56 | |
*** Sukhdev has joined #openstack-nova | 15:56 | |
*** browne has joined #openstack-nova | 15:58 | |
*** bkopilov has joined #openstack-nova | 15:58 | |
mriedem | cfriesen: yeah will look in a bit | 15:59 |
*** afazekas has joined #openstack-nova | 16:00 | |
*** penick has quit IRC | 16:01 | |
*** david-ly_ is now known as david-lyle | 16:01 | |
*** tsekiyama has joined #openstack-nova | 16:03 | |
*** nelsnelson has quit IRC | 16:03 | |
*** alexpilotti has joined #openstack-nova | 16:04 | |
*** nelsnelson has joined #openstack-nova | 16:04 | |
*** jlanoux has quit IRC | 16:05 | |
*** artom_ has quit IRC | 16:05 | |
*** salv-orlando has joined #openstack-nova | 16:09 | |
*** mpaolino has quit IRC | 16:09 | |
*** salv-orl_ has joined #openstack-nova | 16:10 | |
*** SpamapS has quit IRC | 16:12 | |
*** neelashah has quit IRC | 16:12 | |
*** salv-orlando has quit IRC | 16:13 | |
*** Sukhdev has quit IRC | 16:15 | |
*** jcoufal has joined #openstack-nova | 16:15 | |
*** unicell1 has quit IRC | 16:15 | |
openstackgerrit | dave-mcnally proposed openstack/nova: Add policy to cover snapshotting of volume backed instances https://review.openstack.org/176805 | 16:16 |
*** zul has quit IRC | 16:16 | |
cfriesen | mriedem: awesome, thanks | 16:17 |
*** dkliban has left #openstack-nova | 16:17 | |
openstackgerrit | John Garbutt proposed openstack/nova-specs: api: relax validation for unversioned requests https://review.openstack.org/173243 | 16:21 |
*** amotoki_ has joined #openstack-nova | 16:21 | |
*** jistr has quit IRC | 16:21 | |
*** amotoki_ is now known as amotoki | 16:21 | |
*** armax has quit IRC | 16:22 | |
*** armax has joined #openstack-nova | 16:23 | |
*** ociuhandu has quit IRC | 16:26 | |
*** neelashah has joined #openstack-nova | 16:27 | |
*** mpaolino has joined #openstack-nova | 16:27 | |
*** yassine has quit IRC | 16:28 | |
*** dboik_ has joined #openstack-nova | 16:30 | |
*** doron is now known as doron_afk | 16:31 | |
*** tonytan4ever has quit IRC | 16:34 | |
*** ociuhandu has joined #openstack-nova | 16:34 | |
*** dboik has quit IRC | 16:34 | |
*** doron_afk has quit IRC | 16:35 | |
*** afazekas has quit IRC | 16:35 | |
*** rajesht has quit IRC | 16:36 | |
*** afazekas has joined #openstack-nova | 16:36 | |
*** dsanders has joined #openstack-nova | 16:41 | |
*** dikonoor has quit IRC | 16:43 | |
lucasagomes | hi, if you have a time mind taking a look at this Ironic patch https://review.openstack.org/#/c/172930/ ? It's a fairly small patches (+20, -0 LOC) and help when troubleshooting Ironic (as per bug) | 16:43 |
lucasagomes | thank you | 16:43 |
openstackgerrit | sahid proposed openstack/nova: libvirt: add method to get cpu stats to host https://review.openstack.org/177223 | 16:45 |
openstackgerrit | sahid proposed openstack/nova: libvirt: add method to get hardware info to Host https://review.openstack.org/177222 | 16:45 |
openstackgerrit | sahid proposed openstack/nova: libvirt: add method to compare cpu to Host https://review.openstack.org/177331 | 16:45 |
openstackgerrit | sahid proposed openstack/nova: libvirt: add method to list pci devices to Host https://review.openstack.org/177330 | 16:45 |
openstackgerrit | sahid proposed openstack/nova: libvirt: add method to get device by name to Host https://review.openstack.org/177329 | 16:45 |
openstackgerrit | sahid proposed openstack/nova: libvirt: avoid call of listDefinedDomains when post live migration https://review.openstack.org/177328 | 16:45 |
openstackgerrit | sahid proposed openstack/nova: libvirt: add method to define instance to host https://review.openstack.org/174314 | 16:45 |
openstackgerrit | sahid proposed openstack/nova: libvirt: introduces a Guest to wrap arround virConnect https://review.openstack.org/174313 | 16:45 |
openstackgerrit | sahid proposed openstack/nova: libvirt: add note to do note call libvirt from the driver https://review.openstack.org/177332 | 16:45 |
openstackgerrit | sahid proposed openstack/nova: libvirt: introduces a Guest to wrap arround virConnect https://review.openstack.org/174313 | 16:48 |
openstackgerrit | sahid proposed openstack/nova: libvirt: add todo note to avoid call to libvirt from the driver https://review.openstack.org/177332 | 16:48 |
*** armax has quit IRC | 16:49 | |
*** derekh has quit IRC | 16:49 | |
*** Sukhdev has joined #openstack-nova | 16:51 | |
*** afazekas has quit IRC | 16:52 | |
*** unicell has joined #openstack-nova | 16:53 | |
*** unicell has quit IRC | 16:54 | |
*** unicell has joined #openstack-nova | 16:54 | |
*** unicell has quit IRC | 16:55 | |
*** unicell has joined #openstack-nova | 16:55 | |
*** sahid has quit IRC | 16:55 | |
*** promulo__ has joined #openstack-nova | 16:56 | |
*** promulo_ has quit IRC | 16:57 | |
*** romainh has left #openstack-nova | 16:57 | |
*** vilobhmm1 has joined #openstack-nova | 16:58 | |
*** vilobhmm1 has quit IRC | 16:58 | |
*** erlon has joined #openstack-nova | 16:58 | |
*** vilobhmm1 has joined #openstack-nova | 16:58 | |
*** afazekas has joined #openstack-nova | 17:00 | |
*** arnaud____ has joined #openstack-nova | 17:01 | |
*** foexle has quit IRC | 17:01 | |
*** pixelb has quit IRC | 17:01 | |
*** Nic has joined #openstack-nova | 17:02 | |
*** patrickeast has joined #openstack-nova | 17:02 | |
*** vilobhmm1 has quit IRC | 17:03 | |
*** alexpilotti has quit IRC | 17:03 | |
openstackgerrit | Andrew Laski proposed openstack/nova: Add a method to skip cells syncs on instance.save https://review.openstack.org/177356 | 17:05 |
*** ijw has quit IRC | 17:05 | |
*** davideagnello has joined #openstack-nova | 17:05 | |
*** arnaud____ has quit IRC | 17:05 | |
*** moshele has quit IRC | 17:05 | |
*** Nic has quit IRC | 17:06 | |
*** yamahata has joined #openstack-nova | 17:07 | |
dansmith | alaski: boy you got a lot of activity on that patch | 17:08 |
dansmith | almost like the subject was "free beer" | 17:08 |
alaski | heh. you're giving people ideas now | 17:09 |
*** wuhg has quit IRC | 17:09 | |
*** vilobhmm1 has joined #openstack-nova | 17:10 | |
dansmith | heh | 17:10 |
*** exploreshaifali has joined #openstack-nova | 17:10 | |
*** ociuhandu has quit IRC | 17:13 | |
*** ociuhandu has joined #openstack-nova | 17:14 | |
dansmith | alaski: what's the format of cell_name now? isn't it foo!bar!baz ? | 17:15 |
alaski | dansmith: foo!bar@compute | 17:15 |
*** lucasagomes is now known as lucas-dinner | 17:16 | |
dansmith | okay, so what was the plan with using that delimiter for the signal? seems potentially confusing | 17:16 |
dansmith | where you could use something like * and then just cell_name.remove('*') | 17:16 |
*** EmilienM is now known as EmilienM|afk | 17:17 | |
alaski | as crazy as it would be, someone could technically use * in a name | 17:17 |
*** neelashah has quit IRC | 17:17 | |
*** afazekas has quit IRC | 17:18 | |
alaski | but !! would be illegal from a routing standpoint | 17:18 |
dansmith | alaski: is there no char we could use that is banned? | 17:18 |
openstackgerrit | jichenjc proposed openstack/nova: Add log for volume status if it failed https://review.openstack.org/177887 | 17:19 |
*** kiran-r has quit IRC | 17:19 | |
*** alanf-mc has joined #openstack-nova | 17:19 | |
*** xyang1 has joined #openstack-nova | 17:19 | |
*** exploreshaifali has quit IRC | 17:20 | |
alaski | dansmith: doesn't look like it | 17:20 |
dansmith | boo, okay | 17:20 |
openstackgerrit | John Garbutt proposed openstack/nova-specs: Move qualified-uuids spec to liberty https://review.openstack.org/132623 | 17:20 |
*** achanda has joined #openstack-nova | 17:20 | |
alaski | dansmith: the component pieces are pulled from StrOpt config values. So if those have banned chars we could use them, I'll check | 17:23 |
*** ashishjain has joined #openstack-nova | 17:23 | |
*** penick has joined #openstack-nova | 17:23 | |
dansmith | alaski: okay | 17:23 |
dansmith | alaski: not a huge deal, I just wish we could use something else | 17:23 |
dansmith | alaski: left some comments in there, but otherwise I think that's how we should do this, IMHO | 17:23 |
dansmith | hacky, but limited scope/damage | 17:23 |
alaski | agreed. I would prefer a better signal | 17:24 |
*** mpaolino has quit IRC | 17:24 | |
*** salv-orlando has joined #openstack-nova | 17:26 | |
*** otter768 has joined #openstack-nova | 17:27 | |
*** salv-orl_ has quit IRC | 17:27 | |
alaski | we could limit the range of acceptable chars for that config option, but by default nothing is banned | 17:28 |
dansmith | yeah, but that could break someone that already runs cells and doesn't make good life decisions :) | 17:28 |
dansmith | i.e. starting a cell name with * | 17:28 |
alaski | yep | 17:29 |
*** mpaolino has joined #openstack-nova | 17:29 | |
*** marun has quit IRC | 17:30 | |
*** pradipta has quit IRC | 17:30 | |
*** otter768 has quit IRC | 17:31 | |
*** penick has quit IRC | 17:32 | |
*** sdake_ has joined #openstack-nova | 17:34 | |
*** sdake has quit IRC | 17:36 | |
*** armax has joined #openstack-nova | 17:36 | |
alaski | dansmith: the reason I went with cleaning the cell_name up top is that I started building up a lot of logic around the db.instance_update_and... call to preserve and restore the cell_name in order to disable the later sync. And then I had to clean it up at the end again anyways | 17:36 |
dansmith | oh, I meant to suggest that we make that a special case above | 17:37 |
dansmith | let me comment on that, | 17:37 |
*** marun has joined #openstack-nova | 17:37 | |
dansmith | but even still, it was just a suggestion to make it a little clearer, not critical | 17:37 |
alaski | yeah. I started out that way and it ended up being messy just around the actual db update, it was much cleaner elsewhere | 17:39 |
*** Nic has joined #openstack-nova | 17:39 | |
dansmith | alaski: I just commented again.. you did it there? | 17:40 |
dansmith | it feels wrong to modify the instance in save, for any purpose other than refreshing from the DB, which is also part of my hesitation | 17:40 |
dansmith | but if it's messier for some reason, then that's fine. I'd still rather keep it confined to cells-y things like this, so I won't complain too much :) | 17:41 |
alaski | dansmith: ah, your latest comment was something I missed. that would be much easier | 17:42 |
dansmith | okay :) | 17:42 |
*** jwcroppe has quit IRC | 17:43 | |
alaski | I had still been modifying the instance before, not the updates | 17:43 |
dansmith | ah | 17:43 |
*** jwcroppe has joined #openstack-nova | 17:43 | |
*** sdake has joined #openstack-nova | 17:45 | |
*** sudipto has quit IRC | 17:46 | |
*** amotoki has quit IRC | 17:47 | |
*** liusheng has quit IRC | 17:47 | |
*** jwcroppe has quit IRC | 17:47 | |
*** sdake_ has quit IRC | 17:48 | |
*** liusheng has joined #openstack-nova | 17:48 | |
*** marcusvrn_ has quit IRC | 17:49 | |
*** dprince has quit IRC | 17:50 | |
*** harlowja_away is now known as harlowja_ | 17:52 | |
*** neelashah has joined #openstack-nova | 17:52 | |
*** mpaolino has quit IRC | 17:52 | |
openstackgerrit | Dan Smith proposed openstack/nova-specs: Add admin-query-any-keypair.rst https://review.openstack.org/175579 | 17:57 |
*** jwcroppe has joined #openstack-nova | 17:57 | |
*** claudiub has quit IRC | 18:00 | |
*** alanf-mc has quit IRC | 18:01 | |
*** jogo has quit IRC | 18:03 | |
*** kiran-r has joined #openstack-nova | 18:04 | |
*** redbeard has quit IRC | 18:05 | |
*** ijw has joined #openstack-nova | 18:05 | |
*** EmilienM|afk is now known as EmilienM | 18:06 | |
*** artom has joined #openstack-nova | 18:09 | |
*** davideagnello has quit IRC | 18:10 | |
*** davideagnello has joined #openstack-nova | 18:12 | |
openstackgerrit | Miguel Lavalle proposed openstack/nova-specs: Integrate DNS resolution with Neutron using Nova hostname https://review.openstack.org/90150 | 18:12 |
*** yamahata has quit IRC | 18:14 | |
openstackgerrit | Petrut Lucian proposed openstack/nova: Add Hyper-V storage QoS support https://review.openstack.org/175479 | 18:16 |
*** dboik_ has quit IRC | 18:17 | |
*** dboik has joined #openstack-nova | 18:18 | |
*** josecastroleon has joined #openstack-nova | 18:18 | |
*** Sukhdev has quit IRC | 18:20 | |
*** ajayaa has quit IRC | 18:20 | |
*** jcoufal has quit IRC | 18:20 | |
*** bkopilov has quit IRC | 18:25 | |
*** VW_ has quit IRC | 18:26 | |
*** unicell has quit IRC | 18:26 | |
*** unicell1 has joined #openstack-nova | 18:26 | |
*** bkopilov has joined #openstack-nova | 18:26 | |
*** kiran-r has quit IRC | 18:29 | |
*** exploreshaifali has joined #openstack-nova | 18:30 | |
*** rajesht has joined #openstack-nova | 18:33 | |
*** signed8bit has joined #openstack-nova | 18:33 | |
*** VW_ has joined #openstack-nova | 18:33 | |
*** tonytan4ever has joined #openstack-nova | 18:33 | |
*** jwcroppe has quit IRC | 18:34 | |
*** jwcroppe has joined #openstack-nova | 18:35 | |
*** jwcroppe has quit IRC | 18:36 | |
*** jwcroppe has joined #openstack-nova | 18:36 | |
*** rajesht has quit IRC | 18:37 | |
*** angdraug has quit IRC | 18:45 | |
dansmith | alaski: on this: https://review.openstack.org/#/c/176083/2/specs/liberty/approved/request-spec-object.rst,cm | 18:47 |
dansmith | alaski: are those half dozen or so attributes the only ones from instance_properties that we really need whilst booting an instance ? | 18:47 |
*** josecastroleon has quit IRC | 18:48 | |
*** Longgeek has quit IRC | 18:48 | |
alaski | dansmith: those are the only ones that the scheduler needs. To fully create an instance will need more | 18:48 |
*** alanf-mc has joined #openstack-nova | 18:48 | |
*** unicell has joined #openstack-nova | 18:48 | |
*** unicell1 has quit IRC | 18:49 | |
*** IanGovett has quit IRC | 18:49 | |
*** arnaud____ has joined #openstack-nova | 18:49 | |
dansmith | alaski: what I mean is, are those the only ones for the value of which we need as part of the request? like, all the other hundred properties are implied values? | 18:50 |
alaski | I think it depends on whose perspective we're considering | 18:51 |
alaski | if you're thinking of the api, or a cell, then no | 18:51 |
*** danpb has joined #openstack-nova | 18:53 | |
*** arnaud____ has quit IRC | 18:53 | |
alaski | hostname, kernel_id, ramdisk_id, userdata, and a few other things are missing | 18:54 |
*** ajayaa has joined #openstack-nova | 18:54 | |
*** IanGovett has joined #openstack-nova | 18:55 | |
alaski | I'm still working out where to keep that for returning in the API. request_spec is only a subset of what we need | 18:55 |
*** alanf-mc has quit IRC | 18:55 | |
*** marun_ has joined #openstack-nova | 18:55 | |
*** tonytan4ever has quit IRC | 18:56 | |
*** arif-ali has joined #openstack-nova | 18:57 | |
*** Sukhdev has joined #openstack-nova | 18:58 | |
*** marun has quit IRC | 18:58 | |
*** jwcroppe has quit IRC | 18:58 | |
*** jwcroppe has joined #openstack-nova | 18:59 | |
*** baoli has quit IRC | 19:01 | |
johnthetubaguy | dansmith: alaski: are you free for a nova-drivers meeting now? | 19:02 |
dansmith | johnthetubaguy: yep | 19:02 |
*** ajayaa has quit IRC | 19:02 | |
dansmith | johnthetubaguy: you said it would be in here right? | 19:02 |
johnthetubaguy | not sure how many folks on the list are actually online right now, but anyways | 19:02 |
* danpb waves | 19:02 | |
johnthetubaguy | yeah, seemed as good a place as any | 19:02 |
johnthetubaguy | danpb: hi, good to see you :) | 19:02 |
dansmith | okay, thought maybe I was being poked to jump somewhere :) | 19:03 |
johnthetubaguy | so I was thinking lets start with this: https://etherpad.openstack.org/p/liberty-nova-summit-ideas | 19:03 |
alaski | I'm here, but also in a last minute VC | 19:03 |
johnthetubaguy | been looking at the sessions we should have, maybe lets scroll down the bottom and see what you think to my sketch? | 19:03 |
johnthetubaguy | alaski: ah, no worries | 19:03 |
dansmith | johnthetubaguy: do we need virt driver sessions? | 19:04 |
dansmith | I thought we didn't have them in paris | 19:04 |
johnthetubaguy | dansmith: we didn't, I put them in there to fill a whole, we can drop them | 19:04 |
*** davideagnello has quit IRC | 19:04 | |
dansmith | IMHO, they're usually not that useful | 19:04 |
alaski | +1 | 19:04 |
dansmith | also definitely don't want a "containers" one | 19:04 |
danpb | in prev summits they just ended up being a boring walk through of blueprints | 19:05 |
johnthetubaguy | yeah, deleted | 19:05 |
danpb | so don't think they really added much value | 19:05 |
dansmith | I would say we should start with the scheduler one | 19:05 |
*** ijw has quit IRC | 19:05 | |
*** lpetrut has quit IRC | 19:05 | |
*** moshele has joined #openstack-nova | 19:05 | |
danpb | yep, def need to make sure we move forwards in schedular stuff | 19:05 |
dansmith | in fact, | 19:05 |
dansmith | I think maybe first session on scheduler next steps, | 19:05 |
johnthetubaguy | I was wondering about leaving the early slot blank | 19:05 |
dansmith | and the second one on scheduler+cells==?PROFIT? | 19:06 |
*** davideagnello has joined #openstack-nova | 19:06 | |
johnthetubaguy | so we get a warm up one in there? | 19:06 |
johnthetubaguy | Oh, I do like that idea though | 19:06 |
dansmith | it'll be wednesday | 19:06 |
johnthetubaguy | true | 19:06 |
dansmith | I think we'll be chomping at the bit to talk at this point | 19:06 |
danpb | i think in paris we had some generic unconference sessions on each day | 19:06 |
alaski | yeah, scheduler and cells should probably be close together | 19:06 |
dansmith | because we'll have done the cross-project ones | 19:06 |
danpb | where people could propose random short topics | 19:06 |
dansmith | he had those in there | 19:06 |
dansmith | unconf ones, that is | 19:06 |
danpb | oh yeah, i see them now i scrolled more | 19:07 |
johnthetubaguy | danpb: I went for after lunch again | 19:07 |
johnthetubaguy | that seemed to work | 19:07 |
*** Nikolay_St has joined #openstack-nova | 19:07 | |
johnthetubaguy | (when I didn't get stuck in a pizza place) | 19:07 |
dansmith | johnthetubaguy: I actually meant a whole cells/scheduler one.. alaski do you think one for cellsv2 is enough? | 19:07 |
dansmith | I think we could talk about just the scheduling bit for at least an hour | 19:07 |
dansmith | and I don't want that to squeeze out other discussions we might need to have | 19:07 |
alaski | right. I would do one on scheduler/cells and one on everything else in cells | 19:08 |
dansmith | johnthetubaguy: okay, that looks good | 19:08 |
dansmith | johnthetubaguy: that timeboxes the scheduler bit, after the break, we have to move on | 19:08 |
johnthetubaguy | dansmith: alaski: I couldn't decide if they both needed two slots, I like the three together | 19:08 |
johnthetubaguy | top idea | 19:08 |
dansmith | the three like this seems good to me | 19:08 |
dansmith | how about we put resource tracker crapolium in the slot after that | 19:09 |
*** jog0 has joined #openstack-nova | 19:09 | |
dansmith | we need to talk about that too, IIRC | 19:09 |
alaski | the three look good to me too | 19:09 |
jog0 | sorry for showing up late, had some IRC proxy issues | 19:09 |
*** promulo_ has joined #openstack-nova | 19:09 | |
johnthetubaguy | jog0: no worries, we are looking at this: https://etherpad.openstack.org/p/liberty-nova-summit-ideas | 19:09 |
dansmith | jaypipes: bauzas do we need a session on unfscking the RT? | 19:09 |
johnthetubaguy | dansmith: so thats 4 on scheduling and cells, I guess that makes sense | 19:10 |
dansmith | separate from scheduler stuff? | 19:10 |
*** promulo__ has quit IRC | 19:10 | |
dansmith | johnthetubaguy: well, scheduler/RT is the biggest single pile of poo we have, no? :) | 19:10 |
johnthetubaguy | dansmith: that and quotas | 19:10 |
bauzas | hola | 19:10 |
dansmith | yeah, | 19:10 |
*** penick has joined #openstack-nova | 19:11 | |
*** dprince has joined #openstack-nova | 19:11 | |
* bauzas rewinding | 19:11 | |
johnthetubaguy | bauzas: https://etherpad.openstack.org/p/liberty-nova-summit-ideas | 19:11 |
dansmith | johnthetubaguy: feels like the API one might should be on the operatory day | 19:11 |
johnthetubaguy | dansmith: I flip flopped with that one, yeah | 19:11 |
danpb | if schedular is the biggest mess to discuss, should we reserve a slot on the last day too | 19:11 |
danpb | so if the topics on day 1 trigger more thoughts over the rest of the days, we have space to revisit them on last day | 19:12 |
dansmith | johnthetubaguy: we could swap the API one and the functional testing one | 19:12 |
dansmith | danpb: we have friday | 19:12 |
dansmith | which is unstructured | 19:12 |
johnthetubaguy | danpb: we have the final day meetup thing which should do that quite well I hope | 19:12 |
*** tonytan4ever has joined #openstack-nova | 19:12 | |
danpb | ok | 19:12 |
bauzas | well, we should maybe try to have one session before friday for the scheduler so we could discuss any left issue on Friday IMHO | 19:12 |
johnthetubaguy | dansmith: but I had two slots of API, maybe thats silly? | 19:12 |
dansmith | bauzas: we have three right now :) | 19:13 |
bauzas | dansmith: oh cool | 19:13 |
dansmith | johnthetubaguy: I think that's likely overkill | 19:13 |
dansmith | but maybe others disagree | 19:13 |
bauzas | yeah, I would like to discuss on how we could have a scalable scheduler | 19:13 |
johnthetubaguy | dansmith: thats probably fair, we have most stuff sorted now | 19:13 |
bauzas | and we should also discuss for cells V2 | 19:13 |
dansmith | bauzas: are you seeing the doc? | 19:13 |
dansmith | bauzas: we have those covered | 19:13 |
dansmith | bauzas: scroll to the bottom | 19:13 |
bauzas | erf | 19:14 |
* bauzas needs to awake | 19:14 | |
johnthetubaguy | dansmith: does that look better? | 19:14 |
johnthetubaguy | api wise | 19:14 |
bauzas | dansmith: oh right | 19:14 |
bauzas | johnthetubaguy: +1 on your planning | 19:15 |
dansmith | yeah | 19:15 |
jog0 | should we have cells v2 next steps before scheduler and cells? | 19:15 |
bauzas | agreed on API, I think the operators need to be there | 19:15 |
dansmith | johnthetubaguy: I don't think we need to necessarily | 19:15 |
dansmith | oops | 19:15 |
dansmith | jog0: ^ | 19:15 |
bauzas | because there are some things we should discuss with them | 19:15 |
bauzas | like having different policies between v2.0 and v2.1, how to have a client knowing that, etc. | 19:16 |
johnthetubaguy | I quite like doing scheduling first actually, its probably the biggest direction sticking point I guess | 19:16 |
dansmith | no | 19:16 |
jog0 | dansmith: well for scheduler and cells wil the discussions from cells v2 next steps have any impact on it? | 19:16 |
dansmith | like "when can we drop v2" :) | 19:16 |
dansmith | jog0: I think it's the other way around | 19:16 |
jog0 | dansmith: kk, just checking | 19:16 |
dansmith | jog0: scheduling might dictate some directions we have to follow | 19:16 |
dansmith | scheduling being the hard part | 19:17 |
dansmith | johnthetubaguy: so are we good with what is on there now such that we can fill some of the holes? | 19:17 |
johnthetubaguy | dansmith: its a random stab, but I like the tweaks | 19:17 |
johnthetubaguy | is it looking how people expected? | 19:17 |
*** alanf-mc has joined #openstack-nova | 19:17 | |
dansmith | yep | 19:17 |
johnthetubaguy | it feels similar to paris, which is no bad thing | 19:18 |
dansmith | one thing, | 19:18 |
dansmith | the nova-net discussion is only one session, and while I'm fine talking about it for zero sessions, | 19:18 |
jog0 | we have a lot of operator feedback requested comments what does that mean | 19:18 |
jog0 | johnthetubaguy: ^ | 19:18 |
dansmith | I do worry that it butts up against quittin' time | 19:18 |
dansmith | jog0: things we want to schedule such that they don't overlap the ops sessions in other rooms | 19:18 |
johnthetubaguy | dansmith: thats true, its the only slot where neutron doesn't have a slot | 19:18 |
dansmith | jog0: they have some stuff on weds, so our stuff is thurs to avoid conflicts | 19:19 |
dansmith | johnthetubaguy: okay, well, then that's fine | 19:19 |
dansmith | johnthetubaguy: maybe it's good to have a hard ending on it anwyay :) | 19:19 |
jog0 | dansmith: cool | 19:19 |
johnthetubaguy | dansmith: keeps people on their toes for something | 19:19 |
dansmith | maybe :) | 19:19 |
jog0 | so not sure where this would fit or if it makes sense at all: but what about a Kilo retrospective | 19:20 |
jog0 | what worked what didn't etc | 19:20 |
dansmith | I think that's part of the process one | 19:20 |
johnthetubaguy | jog0: I was thinking we do that a little bit in the process section? | 19:20 |
jog0 | works for me | 19:20 |
danpb | on the topic of APIs, is there any need to have a discussion about EC2 API, or are we comfortable with where that's going now ? | 19:20 |
dansmith | I think it's a done deal | 19:21 |
johnthetubaguy | danpb: I popped that into the API session | 19:21 |
*** jcoufal has joined #openstack-nova | 19:21 | |
johnthetubaguy | danpb: but yeah, I hope its rubber stamp stuff | 19:21 |
*** yamahata has joined #openstack-nova | 19:21 | |
danpb | ok | 19:21 |
* johnthetubaguy crosses fingers | 19:21 | |
*** whenry has quit IRC | 19:21 | |
bauzas | :) | 19:21 |
dansmith | yeah | 19:21 |
dansmith | and if not, we ask the dissenters to leave the room :P | 19:21 |
bauzas | lol | 19:21 |
johnthetubaguy | I put it as, when to delete the ec2 api code | 19:22 |
dansmith | so we have two slots? | 19:22 |
johnthetubaguy | yeah | 19:22 |
*** scottda has joined #openstack-nova | 19:22 | |
bauzas | sounds like the new release for the EC2 repo should help us | 19:22 |
johnthetubaguy | oh, I gave priorities two slots | 19:22 |
johnthetubaguy | I guess thats correct | 19:22 |
dansmith | do we need one on upgrade migrations/objects/etc or are we pretty good on those? | 19:22 |
jaypipes | johnthetubaguy: is the other one "when to get rid of API extensions"? | 19:22 |
dansmith | johnthetubaguy: if we need a slot for something I think we can bump that | 19:22 |
*** sdake_ has joined #openstack-nova | 19:22 | |
johnthetubaguy | jaypipes: yeah, thats in that API session too | 19:22 |
jaypipes | kk | 19:22 |
jaypipes | thx | 19:22 |
dansmith | jaypipes: in 2.1 extensions are gone right? | 19:22 |
dansmith | I mean effectively gone | 19:23 |
jog0 | johnthetubaguy: what about adding extra time for the process evolution? | 19:23 |
jaypipes | dansmith: no, not yet :( | 19:23 |
jog0 | johnthetubaguy: there is potentially a lot to hash out in that one | 19:23 |
dansmith | jaypipes: they're there mechanically, but they no longer swap in modular bits of the API | 19:23 |
*** jog0 is now known as jogo | 19:23 | |
johnthetubaguy | jaypipes: the policy is a bit tied to extensions in the current plan, thats a worry there, but yeah | 19:23 |
dansmith | jogo: those are adjacent so we can bleed as appropriate | 19:23 |
johnthetubaguy | jogo: yeah, I want to timebox that, there is a cross project on that, I am hoping | 19:24 |
jogo | ahh | 19:24 |
dansmith | jaypipes: that said, happy to have a "who do we hate? api extensions! what to we want? to kill them with fire!" sort of chant :) | 19:24 |
johnthetubaguy | jogo: I should check that though!! | 19:24 |
jaypipes | dansmith: heh :) | 19:24 |
johnthetubaguy | I can record some tuba stuff for that or something… actually might do that | 19:24 |
johnthetubaguy | anyways, extra slots | 19:25 |
dansmith | johnthetubaguy: tuba is kinda heavy for a chant... | 19:25 |
johnthetubaguy | dansmith: depends how load you shout I guess | 19:25 |
dansmith | hah | 19:25 |
dansmith | so, my question above about upgrades/objects/schema ? | 19:25 |
johnthetubaguy | oh yeah | 19:26 |
*** wverdugo500 has joined #openstack-nova | 19:26 | |
*** sdake has quit IRC | 19:26 | |
dansmith | I'm mostly asking because we failed to land online schema for kilo :/ | 19:26 |
jogo | johnthetubaguy: not sure if this needs a full session but python3? | 19:26 |
johnthetubaguy | dansmith: so johannes is working on Xen stuff now… I need to do something about the online migrations | 19:26 |
bauzas | dansmith: yeah | 19:26 |
dansmith | jogo: I don't think a py3 session is useful | 19:26 |
dansmith | johnthetubaguy: meaning, he's not working on it anymore? | 19:26 |
johnthetubaguy | jogo: I am actually getting fairly happy with the spec right now | 19:27 |
johnthetubaguy | dansmith: so he wants feedback on how to get us to understand it properly | 19:27 |
*** annegentle has joined #openstack-nova | 19:27 | |
bauzas | does the py3 stuff require a big session or could we try to disucss htat on Friday ? | 19:27 |
johnthetubaguy | I think we can get time for him to fix it up | 19:27 |
bauzas | because it sounds quite cool | 19:27 |
dansmith | johnthetubaguy: I wanted it to be in the tree so we can experiment with it | 19:27 |
bauzas | just something we should just agree on | 19:28 |
jogo | dansmith: works for me, was just trying to throw ideas out there | 19:28 |
johnthetubaguy | dansmith: that was my thinking too, honestly | 19:28 |
dansmith | bauzas: does the py3 stuff require any discussion? it's just a thing we need to do | 19:28 |
sdague | bauzas: the patch is up to get it to pass on unit tests, I don't think it's a discussion, it's just work | 19:28 |
*** otter768 has joined #openstack-nova | 19:28 | |
dansmith | johnthetubaguy: well, so, should we have a session or no? | 19:28 |
bauzas | dansmith: maybe just an approval or a blessing I gues | 19:28 |
bauzas | guess | 19:28 |
* bauzas has fat fingers | 19:28 | |
johnthetubaguy | dansmith: not sure a session will help, I should check to see if he is coming, I thought he was originally | 19:28 |
dansmith | okay | 19:28 |
bauzas | johnthetubaguy: he is coming | 19:28 |
johnthetubaguy | dansmith: lets pencil it in | 19:28 |
bauzas | johnthetubaguy: you mean victor ? | 19:29 |
dansmith | bauzas: no | 19:29 |
dansmith | johnthetubaguy: if it won't help, then perhaps we just skip it | 19:29 |
bauzas | oh, who else then ? | 19:29 |
dansmith | jerdfeldt | 19:29 |
*** armax has quit IRC | 19:29 | |
dansmith | we're talking about online schema | 19:29 |
*** ociuhandu has quit IRC | 19:29 | |
bauzas | dansmith: sounds like we mixed the py3 and online change discussions :/ | 19:29 |
bauzas | =>[] | 19:30 |
johnthetubaguy | dansmith: it might be good if we just sit down and get that merged, we can make it into a working session if we want that | 19:30 |
dansmith | bauzas: I think we're saying we don't need a py3 one | 19:30 |
johnthetubaguy | yeah | 19:30 |
dansmith | johnthetubaguy: okay | 19:30 |
bauzas | okay | 19:30 |
johnthetubaguy | what would we talk about in a py3 session? | 19:30 |
bauzas | johnthetubaguy: CI maybe ? but agreed, that's pretty straightforward | 19:30 |
bauzas | now that eventlet is ported to py3 | 19:31 |
johnthetubaguy | right, its not really a discussion | 19:31 |
dansmith | what about nova under apache? | 19:31 |
*** armax has joined #openstack-nova | 19:31 | |
bauzas | 'please use six, and make sure reviewers check that' | 19:31 |
dansmith | I'd like to hear what we need to do for that | 19:31 |
johnthetubaguy | dansmith: I lobbed that into API actually | 19:31 |
dansmith | okay | 19:31 |
danpb | what about level of support statement for python 3 | 19:31 |
bauzas | dansmith: then, why not Pecan ? :D | 19:31 |
sdague | so, it might be nice to have a discussion about bug handling, because we never seem to really get that under control, and maybe more heads in one room help sort that out some | 19:31 |
johnthetubaguy | dansmith: maybe we should pull it out | 19:31 |
danpb | i mean obviously we'll have CI for python 3 in the gate at some point | 19:31 |
dansmith | sdague: we have process | 19:31 |
* bauzas kidding, remember the icehouse convos | 19:32 | |
danpb | but do we want 3rd party CI to also be testing python 3 | 19:32 |
dansmith | johnthetubaguy: well, api is sounding kinda heavy now :) | 19:32 |
johnthetubaguy | danpb: there is a spec, basically working twoards equal py27 py35 support | 19:32 |
jogo | I think py3 would make a decent friday chat | 19:32 |
dansmith | johnthetubaguy: maybe we move some things out to weds that are more mechanical and don't need ops feedback? | 19:32 |
danpb | eg, so we validate vmware driver works with py3 before we call nova fully supported on py3 | 19:32 |
jogo | don't think it would be very long | 19:32 |
dansmith | johnthetubaguy: like apache | 19:32 |
johnthetubaguy | dansmith: yeah, maybe we have two sessions on that? | 19:32 |
bauzas | why not using the experimental pipeline for py3 ? | 19:32 |
*** wverdugo500 has left #openstack-nova | 19:32 | |
johnthetubaguy | dansmith: yeah, can make the second one a more ops focused thing | 19:32 |
dansmith | ffs, can we stop talking about py3? :D | 19:32 |
bauzas | :) | 19:33 |
johnthetubaguy | +1 | 19:33 |
dansmith | johnthetubaguy: yeah | 19:33 |
*** otter768 has quit IRC | 19:33 | |
sdague | yeh, I'm with dansmith, I think very little about py3 makes sense at this point. It's all mechanical for the next 3 months. And once it's running a bunch we can have policy discussions. Doing that before it's running will just mean a lot of theory talking. | 19:34 |
dansmith | yep, all well-understood things | 19:34 |
jogo | johnthetubaguy: will Vek be there? | 19:34 |
dansmith | johnthetubaguy: so, I know we have the DB one on thursday, but what about some more internally-focused DB things on weds, like the enginefacade stuff, refactoring our own internal API to be more consistent, etc | 19:34 |
dansmith | johnthetubaguy: and save the quotas, etc, for the opsy bit? | 19:34 |
*** sdake_ has quit IRC | 19:35 | |
johnthetubaguy | dansmith: ah, so roll that into online schemas? | 19:35 |
*** sdake has joined #openstack-nova | 19:35 | |
dansmith | johnthetubaguy: yeah, internal-focused DB stuff | 19:35 |
jogo | I think a lot of the quotas discussion has gone way off into the weeds | 19:36 |
jogo | so may take some time to reset | 19:36 |
dansmith | johnthetubaguy: so that looks pretty good to me right now | 19:36 |
dansmith | johnthetubaguy: the whole schedule I mean | 19:36 |
*** angdraug has joined #openstack-nova | 19:36 | |
johnthetubaguy | dansmith: sweet | 19:36 |
jogo | so I don't think having operators in the room for quotas is helpful | 19:37 |
*** Mike_D_laptop has joined #openstack-nova | 19:37 | |
johnthetubaguy | jogo: that might be true, but they would maybe turn up anyways | 19:37 |
dansmith | well, I think it could be from a rethinking the problem perspective | 19:37 |
bauzas | jogo: do you know if there is any planned cross-project session about quotas ? | 19:37 |
dansmith | more so than many of the other things | 19:37 |
dansmith | we can continue the discussion on friday too, without them there | 19:37 |
jogo | bauzas: I do not know, but a quota lib is not the answer IMHO | 19:37 |
jogo | dansmith: sure, its not a big deal | 19:37 |
johnthetubaguy | jogo: I need it to work before we create a lib | 19:38 |
bauzas | jogo: I said that because I remember some discussions at ATL | 19:38 |
jogo | johnthetubaguy: hehe yeah | 19:38 |
bauzas | jogo: so probably a new update would be done, but agreed there is much to do about that before just providing a lib | 19:38 |
jogo | a lib doesn't solve the issue of them not working | 19:38 |
sdague | jogo: ++ | 19:38 |
*** exploreshaifali has quit IRC | 19:39 | |
johnthetubaguy | dansmith: I am thinking we make quota a pure API request concept, so a failed build just means you need to delete it, etc, I think that fits with cells better | 19:39 |
dansmith | just teach people to share and make quotas cooperative, I say :P | 19:39 |
bauzas | jogo: correct, just wondering if it was a global effort, that's it :) | 19:39 |
dansmith | johnthetubaguy: hmm, maybe | 19:39 |
jogo | johnthetubaguy: yeah, so Vek has the history on all of this | 19:39 |
sdague | bauzas: it's not a global effort though, if you've looked at how the current code works | 19:39 |
jogo | johnthetubaguy: talk to him | 19:39 |
johnthetubaguy | jogo: yeah, thats on my TODO list | 19:39 |
sdague | it's kind of a low level construct | 19:39 |
johnthetubaguy | jogo: I need to make that happen | 19:39 |
jogo | bauzas: sure other projects cargo culted our quota logic ... which was a stupid on their part. | 19:40 |
*** marun_ is now known as marun | 19:40 | |
*** whenry has joined #openstack-nova | 19:40 | |
jogo | bauzas: but lets fix ourselves before getting bogged down in cross project politics | 19:40 |
dansmith | agreed | 19:40 |
bauzas | sdague: yeah, I know that's not consistent, my take is just to wonder if some other people like Cinder ones should just discuss on that too - just because they *also* have problems: ) | 19:40 |
johnthetubaguy | jogo: I know we have it patched to do some extra stuff we need that sounds like features people are requesting, but yeah | 19:40 |
jogo | johnthetubaguy: he posted a few comments in the ML and on reviews on this | 19:40 |
bauzas | jogo: fair enough :) | 19:40 |
bauzas | that just reminds me some other area... | 19:40 |
johnthetubaguy | jogo: I saw some of those, but clearly not all of those | 19:41 |
bauzas | :) | 19:41 |
dansmith | johnthetubaguy: so, are we good on this schedule for now? | 19:41 |
sdague | bauzas: it's not that it's not consistent, it's that the kind of things you need to account for are very project specific, and it's not clear there is a good way to do them in a global reusable way. Let's try to fix the narrow first to not be barfy :) | 19:41 |
johnthetubaguy | dansmith: sorry, yes, I guess we are | 19:41 |
*** exploreshaifali has joined #openstack-nova | 19:41 | |
johnthetubaguy | is everyone happy with this getting uploaded the the schedule site, I will create etherpads, etc | 19:41 |
dansmith | johnthetubaguy: np, just want to make sure we stay on task :) | 19:41 |
johnthetubaguy | dansmith: thats all good | 19:41 |
bauzas | sdague: good point, but I don't see really some bps or bugs about that, do you have a few of them ? | 19:41 |
jogo | what would be in the nova error handling bit? | 19:41 |
sdague | johnthetubaguy: so, I wouldn't lock it down until the cross projects sessions get selected, in case stuff you were hoping lands there does not | 19:42 |
sdague | bauzas: there are a *ton* of quota bugs :) | 19:42 |
johnthetubaguy | sdague: we can adjust it later, but yeah thats true | 19:42 |
sdague | johnthetubaguy: mostly, don't push to sched quite yet | 19:42 |
bauzas | sdague: eh https://bugs.launchpad.net/nova/+bugs?field.tag=quotas (20) | 19:42 |
*** gcivitella has quit IRC | 19:43 | |
johnthetubaguy | sdague: why not? I guess I don't want people making plans then changing them | 19:43 |
jogo | johnthetubaguy: ^ what is nova error handling? | 19:43 |
*** lpetrut has joined #openstack-nova | 19:43 | |
johnthetubaguy | jogo: its a decide what we are doing going forward, there was Ops feedback about self-service debugging | 19:44 |
*** edleafe- is now known as edleafe | 19:44 | |
jogo | johnthetubaguy: still don't know what that means | 19:44 |
johnthetubaguy | jogo: I want to write up the current state in devref at some point | 19:44 |
sdague | jogo: exposing more error information over the API, for instance | 19:44 |
dansmith | jogo: sucking less and exposing more useful info than NoValidHost for every failure, I imagine :) | 19:44 |
johnthetubaguy | jogo: basically decide how logging, notifications, instance faults and instance actions, would be used in an ideal world | 19:44 |
sdague | but doing so in a controlled way so that you can lock it down in the public cloud use case | 19:45 |
bauzas | jogo: sec, giving you one bug which can describe the problem | 19:45 |
jogo | johnthetubaguy: so this sounds like a clusterf**ck of a session waiting to happen THB | 19:45 |
johnthetubaguy | jogo: right now they each give you slightly different information, which is fun | 19:45 |
jogo | not saying the issue isn't there | 19:45 |
sdague | jogo: why? | 19:45 |
bauzas | jogo: https://bugs.launchpad.net/nova/+bug/1431291 | 19:45 |
openstack | Launchpad bug 1431291 in OpenStack Compute (nova) "Scheduler Failures are no longer logged with enough detail for a site admin to do problem determination" [High,In progress] - Assigned to Sylvain Bauza (sylvain-bauza) | 19:45 |
johnthetubaguy | jogo: so I am hoping I will present a plan there, whats the concern? | 19:45 |
johnthetubaguy | so this leads to another point | 19:45 |
danpb | jogo: not having a session isn't going to improve the problem we already face | 19:45 |
johnthetubaguy | we need session leaders for some of this | 19:45 |
jogo | but without a decent amount of preperation and work to make this a concerete discussion, I can see it getting stuck in theoretical land | 19:46 |
dansmith | johnthetubaguy: I say we punt on the session leader thing right now | 19:46 |
johnthetubaguy | dansmith: yep | 19:46 |
dansmith | johnthetubaguy: at least until we know which of these are staying, or which might be changing based on the cross-project outcome | 19:46 |
bauzas | jogo: there is a sdague's email quite good as a starting point | 19:46 |
johnthetubaguy | dansmith: except to say, I will ask for peoples to step up on Thursday I guess | 19:46 |
dansmith | johnthetubaguy: sure | 19:47 |
jogo | bauzas: link? | 19:47 |
johnthetubaguy | bauzas: can you send me a link, not sure I saw that one? | 19:47 |
johnthetubaguy | OK. so next bit... | 19:47 |
johnthetubaguy | priorities | 19:47 |
bauzas | johnthetubaguy: jogo: searching... | 19:47 |
jogo | danpb: having a session that is not run correctly will not help either | 19:47 |
johnthetubaguy | jogo: totally agreed BTW, thats going to need a plan, like the quota session | 19:48 |
danpb | jogo: guess it depends what we want to get out of it - general brainstorming sessions can be useful | 19:48 |
*** ashishjain has quit IRC | 19:48 | |
johnthetubaguy | danpb: well, needs some structure I guess, I will try at least get that | 19:48 |
jogo | johnthetubaguy: the error handling sounds like two things. 1) having general guidelines 2) getting bugs fixed in general | 19:48 |
danpb | if we go into it with the intention to make decisions though, and it just becomes a brainstorming session then obviously that'd be a failure of expectation | 19:48 |
jogo | danpb: I feel like we have already had those before on this somewhere | 19:48 |
bauzas | johnthetubaguy: jogo: well, reading back again the email, not really a bunch of stuff, more scheduler-related but that's a start anyway http://lists.openstack.org/pipermail/openstack-dev/2015-March/058801.html | 19:48 |
johnthetubaguy | jogo: we did logs, not the rest of it | 19:48 |
johnthetubaguy | jogo: but I may be missing something | 19:49 |
dansmith | johnthetubaguy: so, priorities, eh? | 19:49 |
johnthetubaguy | https://etherpad.openstack.org/p/liberty-nova-priorities | 19:49 |
johnthetubaguy | yeah | 19:49 |
johnthetubaguy | talking about have a structure to debate | 19:49 |
jogo | johnthetubaguy: anyway, as long as someone does the prep for that session and sets expectations sure | 19:49 |
* jogo looks at the priorites page | 19:50 | |
johnthetubaguy | jogo: I hope to do that, been doing monitoring stuff recently, so I have been seeing the hurt there | 19:50 |
johnthetubaguy | so does anyone fancy running the session | 19:50 |
*** arnaud____ has joined #openstack-nova | 19:50 | |
dansmith | johnthetubaguy: I fancy you running it | 19:50 |
johnthetubaguy | I know jogo did a great job, but I think its someone elses turn | 19:50 |
johnthetubaguy | so I kinda do fancy it | 19:50 |
dansmith | will you be fancy while you run it? | 19:50 |
johnthetubaguy | but I don't want to steal the job from people :) | 19:50 |
johnthetubaguy | lol | 19:50 |
* jogo gladly gives the task to johnthetubaguy | 19:51 | |
johnthetubaguy | my accent can be fancy | 19:51 |
dansmith | +1 | 19:51 |
dansmith | flavour | 19:51 |
dansmith | my accent ^ | 19:51 |
johnthetubaguy | in deed | 19:51 |
johnthetubaguy | OK, so thats my job | 19:51 |
johnthetubaguy | cools | 19:51 |
dansmith | nothing much to discuss about it ahead of time, right? | 19:51 |
johnthetubaguy | yeah | 19:51 |
johnthetubaguy | just wanted to raise that really | 19:51 |
johnthetubaguy | so, next thing | 19:51 |
jogo | a little surprised how few people adding things to the list | 19:51 |
dansmith | jogo: sssshh | 19:52 |
johnthetubaguy | :) | 19:52 |
johnthetubaguy | nova-coresec | 19:52 |
*** emagana has joined #openstack-nova | 19:52 | |
johnthetubaguy | that group has a lot of work, and its not really happing all the time | 19:52 |
openstackgerrit | John Griffith proposed openstack/nova: Add external genconfig calls https://review.openstack.org/177949 | 19:52 |
johnthetubaguy | I am thinking nova-drivers should be in that group, ideally, although we must keep it small ish | 19:53 |
johnthetubaguy | I should bring this up in the regular meeting really | 19:53 |
dansmith | so, I'm fine with that, | 19:53 |
dansmith | and also, | 19:53 |
johnthetubaguy | but I wanted to raise ideas there | 19:53 |
dansmith | I think that per-bug we can invite non-coresec people to see it, right? | 19:53 |
dansmith | so if we can delegate to someone that knows more about $thing then we can do that, yes? | 19:53 |
johnthetubaguy | dansmith: yep totally can | 19:53 |
dansmith | so let's do that, | 19:53 |
johnthetubaguy | dansmith: its more making sure that happens | 19:53 |
dansmith | make drivers responsible for those, or for finding people to comment on specific things | 19:53 |
johnthetubaguy | yeah, I like that idea | 19:54 |
dansmith | instead of just a group of folks that have to handle anything that comes up | 19:54 |
johnthetubaguy | I will try make that real when I get permissions to do that | 19:54 |
dansmith | alaski: or do you want to keep all the fun to yourself? | 19:54 |
alaski | just coming back to this meeting | 19:54 |
alaski | but heck no | 19:54 |
dansmith | *shocking* | 19:54 |
johnthetubaguy | hehe, well thats cool | 19:55 |
*** arnaud____ has quit IRC | 19:55 | |
johnthetubaguy | so I think we should set a data for another meeting at the summit | 19:55 |
*** jcoufal has quit IRC | 19:55 | |
johnthetubaguy | I mean the monday before liberty-1 might be about right I guess | 19:55 |
johnthetubaguy | also, we should look at expanding nova-drivers, ideas on an email thread I guess | 19:56 |
johnthetubaguy | any more for any more? | 19:56 |
dansmith | nope, and we're out of time | 19:56 |
johnthetubaguy | on nova-drivers stuff at least | 19:56 |
johnthetubaguy | perfect | 19:57 |
johnthetubaguy | thanks folks | 19:57 |
*** armax has quit IRC | 19:58 | |
jogo | johnthetubaguy: thank you | 19:58 |
johnthetubaguy | jogo: no problems, thanks for all helping out with this stuff | 19:58 |
jogo | dansmith johnthetubaguy: how do we pick session leaders? | 19:58 |
jogo | (not now of course) | 19:58 |
dansmith | take volunteers first, pick among dupes, and then approach folks for the holes? | 19:59 |
*** danpb has quit IRC | 19:59 | |
johnthetubaguy | +1 | 19:59 |
*** Mike_D_laptop has quit IRC | 19:59 | |
jogo | works for me, thanks in advance for sorting that out johnthetubaguy :) | 20:00 |
johnthetubaguy | :) | 20:01 |
*** jdurgin has quit IRC | 20:03 | |
*** thangp has quit IRC | 20:03 | |
*** marun has quit IRC | 20:03 | |
*** johnthetubaguy is now known as zz_johnthetubagu | 20:06 | |
alaski | not one mention of containers or nfv, how will we ever attract the masses? | 20:06 |
dansmith | heh | 20:06 |
bauzas | alaski: don't be shy about cells v2, you'll get more people than Bieber | 20:08 |
alaski | hopefully not, or at least a different demographic | 20:08 |
*** doude has quit IRC | 20:09 | |
*** doude has joined #openstack-nova | 20:09 | |
bauzas | :) | 20:09 |
jogo | alaski: you don't want the beliebers? | 20:09 |
alaski | I know i'm late, but the schedule looks good. although I think the evacuate and flavor ones might not get enough time | 20:09 |
bauzas | alaski: at least, the cells v2 effort got some fans on the last Paris meetup | 20:09 |
alaski | jogo: heh, I don't think I do. I say without really knowing what sort of people they are | 20:10 |
bauzas | for some unexpectable reason, people liked the idea to add new cells just like a click | 20:10 |
*** Nikolay_St has quit IRC | 20:14 | |
*** dprince has quit IRC | 20:16 | |
*** saikrishna has joined #openstack-nova | 20:17 | |
*** ericksonsantos has joined #openstack-nova | 20:18 | |
jogo | mriedem: http://logs.openstack.org/05/176805/4/check/check-tempest-dsvm-multinode-full/305a5f8/logs/screen-n-cpu.txt.gz#_2015-04-27_16_48_45_557 | 20:19 |
jogo | huh? | 20:19 |
*** Nikolay_St has joined #openstack-nova | 20:20 | |
jogo | Migration running for 30 secs, memory 0% remaining; (bytes processed=0, remaining=0, total=0) | 20:20 |
*** jdurgin has joined #openstack-nova | 20:21 | |
*** exploreshaifali has quit IRC | 20:22 | |
mriedem | jogo: idk, danpb added that monitor code | 20:22 |
mriedem | looks like it completed though? http://logs.openstack.org/05/176805/4/check/check-tempest-dsvm-multinode-full/305a5f8/logs/screen-n-cpu.txt.gz#_2015-04-27_16_48_59_446 | 20:22 |
jogo | the live migration itself failed | 20:22 |
jogo | mriedem: http://logs.openstack.org/05/176805/4/check/check-tempest-dsvm-multinode-full/305a5f8/logs/testr_results.html.gz | 20:22 |
jogo | cannot resize image ??? http://logs.openstack.org/05/176805/4/check/check-tempest-dsvm-multinode-full/305a5f8/logs/subnode-1/screen-n-cpu.txt.gz#_2015-04-27_16_45_43_121 | 20:23 |
jogo | clarkb: ping | 20:24 |
jogo | so multinode | 20:24 |
jogo | clarkb: 61 successful runs in 24 hours | 20:25 |
jogo | 6 failures | 20:25 |
jogo | with no duplicate reasons | 20:25 |
jogo | and several of those are valid failures | 20:25 |
dansmith | jogo: is that in check? | 20:25 |
jogo | dansmith: yes | 20:25 |
dansmith | cool | 20:25 |
dansmith | the last 24 hours are not very representative | 20:25 |
dansmith | but still, pretty good | 20:25 |
jogo | dansmith: well 61 successful runs | 20:25 |
jogo | not sure what the next step is here | 20:26 |
dansmith | turn it on and head to the bunker to watch? | 20:26 |
jogo | that works for me :) | 20:26 |
mriedem | we're making it voting now? | 20:26 |
dansmith | I didn't say now, | 20:26 |
dansmith | I just said that's the next step :) | 20:27 |
jogo | mriedem: no, we are discussing the next steps | 20:27 |
jogo | dansmith: I guess give look at the numbers again tomorrow | 20:27 |
jogo | and see how they look? | 20:27 |
dansmith | jogo: are you thinking let it gate as-is for a while and then move other things to run in multinode mode if it continues to be stable? | 20:27 |
jogo | and if still decent | 20:27 |
jogo | ohh interesting | 20:28 |
jogo | I was initially thinking work toards making it gating (vs non-voting check only) in nova | 20:28 |
*** Nikolay_St has quit IRC | 20:29 | |
jogo | but we can work on making other repos run this as non-voting with the hope of making it default elsewhere too | 20:29 |
dansmith | oh, by "other things" I meant replacing a current job with multinode | 20:29 |
jogo | ahh in that case yes | 20:29 |
dansmith | like, make the nova-net case handled by the multinode test and drop the normal nova-net job | 20:29 |
*** Nikolay_St has joined #openstack-nova | 20:30 | |
dansmith | jogo: sdague: related to this, I have a multinode-and-grenade question.. do you want it here or in -qa? | 20:30 |
jogo | dansmith: yes, make nova-net case handle by multinode test and drop | 20:32 |
jogo | in -qa | 20:32 |
*** lpetrut has quit IRC | 20:34 | |
*** luv has quit IRC | 20:34 | |
bauzas | mriedem: quick question, do you know how I could find any failure for the cells job ? | 20:35 |
bauzas | mriedem: I mean, find each time a failure is there | 20:35 |
bauzas | mriedem: using logstash maybe like checking the cells file ? | 20:35 |
alaski | bauzas: build_name:"check-tempest-dsvm-cells" AND message:"Worker Balance" AND build_status:"FAILURE" | 20:35 |
bauzas | alaski: ok, that's what I was trying to do | 20:36 |
alaski | shamelessly stolen from something mriedem sent me | 20:36 |
*** annegentle has quit IRC | 20:36 | |
bauzas | alaski: I just discussed with sdague this morning (ET) about the cells failures, and we were wondering how to provide e-r changes for these | 20:36 |
bauzas | alaski: so I was about reviewing those, and trying to see if there were more than the ones we knew | 20:37 |
*** mwagner_lap has quit IRC | 20:37 | |
alaski | gotcha. I'm not sure if there's an easy way to pull something like failing tests out of there | 20:38 |
*** Nic has quit IRC | 20:38 | |
openstackgerrit | John Griffith proposed openstack/nova: Add external genconfig calls https://review.openstack.org/177949 | 20:39 |
*** jungleboyj has quit IRC | 20:39 | |
*** isd has joined #openstack-nova | 20:40 | |
*** vladikr has quit IRC | 20:41 | |
*** luv has joined #openstack-nova | 20:41 | |
*** eharney has quit IRC | 20:44 | |
*** Marga_ has joined #openstack-nova | 20:47 | |
*** luv has quit IRC | 20:50 | |
openstackgerrit | Andrew Laski proposed openstack/nova: Add a method to skip cells syncs on instance.save https://review.openstack.org/177356 | 20:50 |
mriedem | bauzas: alaski: e-r ignores non-voting jobs | 20:51 |
mriedem | so e-r patches for things only in the cells job wouldn't do anything until it's voting | 20:51 |
bauzas | mriedem: oh ok | 20:51 |
mriedem | i opened a couple of bugs for cells job traces on friday | 20:51 |
mriedem | and linked those into the ML | 20:51 |
mriedem | under alaski's thread on keeping an eye on the job | 20:52 |
bauzas | mriedem: and I replied to them, but I wanted to see more on that | 20:52 |
*** luv has joined #openstack-nova | 20:52 | |
bauzas | I'm seriously wondering if all of that is just due to the race problem we have | 20:52 |
alaski | yeah. I'm not sure but I wanted to get https://review.openstack.org/177356 in shape and then I'll dig further | 20:53 |
*** yamahata has quit IRC | 20:55 | |
*** yamahata has joined #openstack-nova | 20:55 | |
mikal | . | 20:57 |
*** jdurgin has quit IRC | 20:57 | |
*** Sukhdev has quit IRC | 20:58 | |
*** ivasev has quit IRC | 20:59 | |
*** Marga_ has quit IRC | 20:59 | |
*** amotoki has joined #openstack-nova | 21:01 | |
*** Sukhdev has joined #openstack-nova | 21:01 | |
*** armax has joined #openstack-nova | 21:03 | |
*** marun has joined #openstack-nova | 21:05 | |
openstackgerrit | Gabor Takacs proposed openstack/nova: Refactor os-services endpoint https://review.openstack.org/177966 | 21:07 |
*** sdake_ has joined #openstack-nova | 21:07 | |
*** annegent_ has joined #openstack-nova | 21:07 | |
*** saikrishna has quit IRC | 21:07 | |
*** sdake has quit IRC | 21:11 | |
*** mspreitz has quit IRC | 21:12 | |
*** jdurgin has joined #openstack-nova | 21:12 | |
*** rfolco has quit IRC | 21:12 | |
*** jogo has quit IRC | 21:15 | |
*** sdake has joined #openstack-nova | 21:15 | |
*** redbeard has joined #openstack-nova | 21:16 | |
*** foexle has joined #openstack-nova | 21:18 | |
bauzas | alaski: agreed, I'm currently reviewing your change, but it needs more time than just something reviewed at 11pm | 21:19 |
*** sdake_ has quit IRC | 21:19 | |
*** tonytan4ever has quit IRC | 21:20 | |
alaski | bauzas: definitely. I just found a small bug in to as well while making the test better | 21:20 |
alaski | s/to/it/ | 21:20 |
*** artom has quit IRC | 21:22 | |
*** joefides has quit IRC | 21:23 | |
bauzas | alaski: okay, I'm done for a first pass, will just vote tomorrow morning | 21:25 |
*** tjones1 has quit IRC | 21:25 | |
bauzas | alaski: going off, see ya | 21:25 |
alaski | bauzas: bye | 21:25 |
bauzas | alaski: (not really finding issues with your patch, just a few comments) | 21:25 |
*** otter768 has joined #openstack-nova | 21:29 | |
*** lucas-dinner has quit IRC | 21:29 | |
*** Nic has joined #openstack-nova | 21:30 | |
*** dave-mccowan has quit IRC | 21:30 | |
*** dave-mccowan has joined #openstack-nova | 21:31 | |
*** otter768 has quit IRC | 21:34 | |
*** luv has quit IRC | 21:35 | |
*** ZZelle_ has joined #openstack-nova | 21:35 | |
*** luv has joined #openstack-nova | 21:36 | |
*** jungleboyj has joined #openstack-nova | 21:37 | |
*** jgrimm is now known as zz_jgrimm | 21:38 | |
*** arnaud____ has joined #openstack-nova | 21:39 | |
openstackgerrit | Chris Friesen proposed openstack/nova-specs: Allow specifying cpu model in flavor extra-specs or image metadata https://review.openstack.org/168982 | 21:39 |
*** mriedem has quit IRC | 21:43 | |
*** arnaud____ has quit IRC | 21:44 | |
*** moshele has quit IRC | 21:45 | |
*** sdake_ has joined #openstack-nova | 21:46 | |
*** Marga_ has joined #openstack-nova | 21:47 | |
*** dave-mccowan has quit IRC | 21:47 | |
*** dave-mccowan has joined #openstack-nova | 21:48 | |
*** sdake has quit IRC | 21:49 | |
*** neelashah has quit IRC | 21:49 | |
openstackgerrit | Josh Gachnang proposed openstack/nova: Reschedules sometimes do not allocate networks https://review.openstack.org/177470 | 21:50 |
*** armax has quit IRC | 21:50 | |
*** ijw has joined #openstack-nova | 21:51 | |
*** rushil has quit IRC | 21:53 | |
*** isd has quit IRC | 21:53 | |
*** jichen has quit IRC | 21:55 | |
*** marun has quit IRC | 21:55 | |
*** penick has quit IRC | 22:01 | |
*** Marga_ has quit IRC | 22:01 | |
*** mdbooth has quit IRC | 22:02 | |
*** haypo has quit IRC | 22:03 | |
*** VW_ has quit IRC | 22:05 | |
*** penick has joined #openstack-nova | 22:07 | |
*** mdbooth has joined #openstack-nova | 22:08 | |
*** burt has quit IRC | 22:09 | |
*** salv-orlando has quit IRC | 22:09 | |
*** haypo has joined #openstack-nova | 22:10 | |
*** dguitarbite has joined #openstack-nova | 22:15 | |
openstackgerrit | Andrew Laski proposed openstack/nova: Add a method to skip cells syncs on instance.save https://review.openstack.org/177356 | 22:15 |
*** ijw has quit IRC | 22:15 | |
*** vishy has quit IRC | 22:17 | |
*** cyeoh has quit IRC | 22:17 | |
*** vishy has joined #openstack-nova | 22:19 | |
*** cyeoh has joined #openstack-nova | 22:19 | |
*** dguitarbite has quit IRC | 22:21 | |
*** VW_ has joined #openstack-nova | 22:21 | |
openstackgerrit | Andrew Laski proposed openstack/nova-specs: RequestSpec object split instance_properties https://review.openstack.org/176083 | 22:22 |
*** marun has joined #openstack-nova | 22:23 | |
dansmith | alaski: comment on ^ .. I might be missing something | 22:24 |
*** mriedem has joined #openstack-nova | 22:25 | |
alaski | dansmith: draft comment...? | 22:25 |
dansmith | alaski: no... | 22:25 |
*** VW__ has joined #openstack-nova | 22:25 | |
dansmith | oh sorry | 22:25 |
dansmith | not ^ but ^^ :D | 22:25 |
alaski | oh | 22:25 |
dansmith | I started commenting before you pushed the second one | 22:25 |
alaski | dansmith: gotcha. good points, I'll update real quick | 22:26 |
dansmith | okay | 22:26 |
*** amotoki has quit IRC | 22:27 | |
dansmith | alaski: before you update, | 22:27 |
dansmith | alaski: I think you also need a test that the cells messaging bit actually skips the cells update | 22:27 |
*** VW_ has quit IRC | 22:28 | |
*** salv-orlando has joined #openstack-nova | 22:29 | |
alaski | agreed | 22:30 |
dansmith | otherwise, looks awesome | 22:30 |
*** VW__ has quit IRC | 22:30 | |
*** foexle has quit IRC | 22:32 | |
*** mriedem has quit IRC | 22:33 | |
*** mriedem has joined #openstack-nova | 22:34 | |
*** nelsnelson has quit IRC | 22:34 | |
*** isd has joined #openstack-nova | 22:34 | |
*** tjones1 has joined #openstack-nova | 22:35 | |
*** dboik_ has joined #openstack-nova | 22:36 | |
*** jecarey has quit IRC | 22:37 | |
*** ZZelle_ has quit IRC | 22:37 | |
*** mriedem has quit IRC | 22:38 | |
*** dboik has quit IRC | 22:39 | |
*** mriedem has joined #openstack-nova | 22:39 | |
*** jdurgin has quit IRC | 22:39 | |
*** jdurgin has joined #openstack-nova | 22:40 | |
*** dboik_ has quit IRC | 22:41 | |
*** marun has quit IRC | 22:41 | |
*** jog0 has joined #openstack-nova | 22:45 | |
*** annegent_ has quit IRC | 22:51 | |
*** luv has quit IRC | 22:52 | |
*** jog0 is now known as jogo | 22:52 | |
*** luv has joined #openstack-nova | 22:53 | |
*** mwagner_lap has joined #openstack-nova | 22:54 | |
*** sdake_ has quit IRC | 22:57 | |
openstackgerrit | Andrew Laski proposed openstack/nova: Add a method to skip cells syncs on instance.save https://review.openstack.org/177356 | 22:58 |
alaski | wow gerrit is slow today | 22:59 |
*** signed8bit is now known as signed8bit_ZZZzz | 23:01 | |
*** Sukhdev has quit IRC | 23:01 | |
*** armax has joined #openstack-nova | 23:07 | |
*** hemna is now known as hemnafk | 23:11 | |
*** jungleboyj has quit IRC | 23:12 | |
*** penick has quit IRC | 23:18 | |
*** zzzeek has quit IRC | 23:19 | |
*** zzzeek has joined #openstack-nova | 23:19 | |
*** redbeard has quit IRC | 23:21 | |
*** pixelb has joined #openstack-nova | 23:21 | |
*** oro has quit IRC | 23:23 | |
*** kaisers has quit IRC | 23:27 | |
*** ganso_ has quit IRC | 23:27 | |
*** arnaud____ has joined #openstack-nova | 23:28 | |
*** emagana has quit IRC | 23:28 | |
*** otter768 has joined #openstack-nova | 23:30 | |
*** Marga_ has joined #openstack-nova | 23:32 | |
*** arnaud____ has quit IRC | 23:32 | |
*** annegentle has joined #openstack-nova | 23:33 | |
*** otter768 has quit IRC | 23:35 | |
*** annegentle has quit IRC | 23:35 | |
*** kaisers has joined #openstack-nova | 23:36 | |
*** ijw has joined #openstack-nova | 23:40 | |
*** erlon has quit IRC | 23:41 | |
*** dims has quit IRC | 23:46 | |
*** armax has quit IRC | 23:49 | |
*** jwcroppe has quit IRC | 23:51 | |
*** Kevin_Zheng has joined #openstack-nova | 23:53 | |
*** armax has joined #openstack-nova | 23:56 | |
*** rushil has joined #openstack-nova | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!