Saturday, 2015-05-09

*** VW_ has quit IRC00:00
melwittmy instinct was to clone the newly returned thing from db, and send that to sync. but when he suggested that I thought maybe it doesn't matter. I'm not really sure00:00
*** VW_ has joined #openstack-nova00:00
superdanI actually think this is right now00:01
superdanI was thrown by the change in what you're sending,00:01
superdanbut because the other end will look at the changes list, they need to have the dirty one00:01
superdanbefore, they'd just save everything I guess00:01
*** otter768 has quit IRC00:01
superdangah, gerrit is hanging on me00:01
*** apuimedo has quit IRC00:02
superdandid you get my second point above?00:02
superdanoh jeez, thanks gerrit00:02
superdanmelwitt: left you 3 (!) comments here about this: https://review.openstack.org/#/c/176518/9/nova/objects/instance_info_cache.py,cm00:02
melwittthinking.. definitely before they would just save everything. I'm trying to think what's the difference between sending the dirty instance vs the new one with changed field list set to the same as the dirty instance00:03
superdanthe reason is,00:04
*** aix has joined #openstack-nova00:04
superdanif the other end is like "oh, this is an object, let me see what I should save ... NOTHING, sweet!" then that's bad00:04
*** baoli has joined #openstack-nova00:04
superdanbefore you were sending the raw dict,00:05
superdanbut if you didn't send the stale_instance, you'd send self, right?00:05
melwittyeah, that's where I was at before. but, it does also work if you clone the new one and set the changed_fields the same as they were00:05
superdansure, but you might as well do what you do here cause it's easier, right?00:05
melwittyeah, it seems like it doesn't matter. it boils down to whether it's somehow better to use the field values that the db returned to us for syncing00:07
superdanif we're setting the change list, I don't think it really does00:08
superdanbut00:08
superdanit's also less expensive because you didn't have to deepcopy the instance00:08
superdanbut does _from_db_object() reset changes?00:08
*** Marga_ has quit IRC00:08
superdanit doesn't00:08
melwittdepends on the class. in instance it does, in info_cache it doesn't00:09
*** VW_ has quit IRC00:09
superdanyeah00:09
superdanso I think you should play it safe,00:09
superdanand just do the clone00:09
superdanlike you have00:09
superdanand not listen to me on fridays00:09
superdanexcept about the comment :)00:09
*** VW_ has joined #openstack-nova00:09
superdanbecause if someone "fixed" that on this object, you'd suddenly stop sending cells updates00:10
superdannetworks would break00:10
superdanpeople would be mad, and blame you00:10
superdanetc, etc00:10
superdanso, I'm about to turn to a punkin'00:10
melwittheh, yeah00:10
superdanjust want to verify you got the other thing about the bare instance hydration00:10
melwittdid you not think the comment on L92 explains the stale_instance thing?00:11
melwittor should I move the comment?00:11
superdanyes it does, sorry00:11
superdanI think I would move it00:11
superdanor rename stale->original or something00:12
superdanit just didn't click for me00:12
superdanbut I'm also stupid, so I'm a bad example00:12
melwittyes, understood the db/api.py thing00:12
superdanokay sweet00:12
melwittthanks!00:13
*** VW_ has quit IRC00:13
superdanno problem, glad you're cleaning up this mess :)00:13
*** VW_ has joined #openstack-nova00:13
melwitt:)00:14
*** mtanino has quit IRC00:15
*** aix has quit IRC00:17
* melwitt runs00:19
*** vilobhmm1 has quit IRC00:20
*** VW_ has quit IRC00:21
*** VW_ has joined #openstack-nova00:21
*** rwsu has joined #openstack-nova00:22
*** VW_ has quit IRC00:27
*** smccully has quit IRC00:28
*** VW_ has joined #openstack-nova00:28
*** smccully has joined #openstack-nova00:28
*** VW_ has quit IRC00:29
*** VW_ has joined #openstack-nova00:30
*** promulo_ has joined #openstack-nova00:30
*** dimsum__ has joined #openstack-nova00:31
*** rwsu has quit IRC00:33
*** promulo__ has quit IRC00:34
*** VW_ has quit IRC00:35
*** VW_ has joined #openstack-nova00:35
*** Marga_ has joined #openstack-nova00:35
*** VW_ has quit IRC00:36
*** VW_ has joined #openstack-nova00:36
*** ijw has quit IRC00:36
*** VW_ has quit IRC00:37
*** VW_ has joined #openstack-nova00:38
*** VW_ has quit IRC00:39
*** VW_ has joined #openstack-nova00:39
*** VW_ has quit IRC00:41
*** VW_ has joined #openstack-nova00:42
*** dimsum__ has quit IRC00:42
*** busterswt has joined #openstack-nova00:43
*** busterswt has quit IRC00:44
*** VW__ has joined #openstack-nova00:46
*** VW_ has quit IRC00:49
*** VW__ has quit IRC00:50
*** DCWilliams_VA has joined #openstack-nova00:53
*** mestery has joined #openstack-nova00:57
*** DCWilliams_VA has quit IRC01:09
*** alanf-mc has quit IRC01:15
*** ZZelle has quit IRC01:19
*** dimsum__ has joined #openstack-nova01:23
*** dimsum__ has quit IRC01:27
*** ijw has joined #openstack-nova01:28
*** zzzeek has quit IRC01:28
*** ijw has quit IRC01:31
*** ijw has joined #openstack-nova01:31
*** ijw has quit IRC01:36
*** dimsum__ has joined #openstack-nova01:39
*** baoli has quit IRC01:41
*** tjones1 has left #openstack-nova01:42
*** browne1 has quit IRC01:44
*** IanGovett1 has quit IRC01:50
*** unicell has quit IRC01:51
*** otter768 has joined #openstack-nova01:58
*** otter768 has quit IRC02:03
*** achanda has quit IRC02:14
*** jecarey has joined #openstack-nova02:15
*** jecarey has quit IRC02:15
*** baoli has joined #openstack-nova02:15
*** yamahata has quit IRC02:19
*** baoli has quit IRC02:20
*** Marga_ has quit IRC02:57
*** unicell has joined #openstack-nova02:59
*** mmedvede_ has quit IRC03:03
*** dsanders has quit IRC03:13
*** achanda has joined #openstack-nova03:15
*** humble_ has joined #openstack-nova03:16
*** humble_ has left #openstack-nova03:17
*** achanda has quit IRC03:20
*** baoli has joined #openstack-nova03:21
*** achanda has joined #openstack-nova03:37
*** pixelbeat_ has joined #openstack-nova03:42
*** pixelbeat has quit IRC03:43
*** otter768 has joined #openstack-nova03:59
*** baoli has quit IRC04:03
*** otter768 has quit IRC04:04
*** dsanders has joined #openstack-nova04:12
*** vilobhmm1 has joined #openstack-nova04:21
*** browne has joined #openstack-nova04:21
*** arnaud____ has joined #openstack-nova04:24
*** vilobhmm11 has joined #openstack-nova04:30
*** vilobhmm1 has quit IRC04:33
*** dsanders has quit IRC04:53
*** arnaud____ has quit IRC04:58
*** sdake has joined #openstack-nova05:02
*** sdake_ has joined #openstack-nova05:06
*** sdake has quit IRC05:09
*** flwang has quit IRC05:13
*** jlvillal has quit IRC05:13
*** jlvillal has joined #openstack-nova05:13
*** vilobhmm11 has quit IRC05:14
*** flwang has joined #openstack-nova05:14
*** vilobhmm1 has joined #openstack-nova05:14
*** mmedvede has quit IRC05:25
*** ildikov has quit IRC05:41
*** ildikov has joined #openstack-nova05:41
*** mmedvede has joined #openstack-nova05:47
*** vishwana_ has joined #openstack-nova05:48
*** pixelbeat_ has quit IRC05:50
*** vishwanathj has quit IRC05:51
*** cfriesen has quit IRC05:53
*** Nikolay_St has quit IRC05:55
*** otter768 has joined #openstack-nova06:00
*** otter768 has quit IRC06:04
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex  https://review.openstack.org/17963806:20
*** vilobhmm1 has quit IRC06:27
*** Mike_D_laptop has joined #openstack-nova06:29
*** vilobhmm1 has joined #openstack-nova06:31
*** Longgeek has joined #openstack-nova06:50
*** vilobhmm11 has joined #openstack-nova06:56
*** vilobhmm1 has quit IRC06:59
*** Murali has joined #openstack-nova07:05
*** Murali_ has joined #openstack-nova07:07
*** Murali has quit IRC07:10
*** Murali_ is now known as Murali07:10
*** Murali has quit IRC07:15
*** sahid has joined #openstack-nova07:19
*** Murali has joined #openstack-nova07:19
*** subscope has joined #openstack-nova07:20
*** Murali_ has joined #openstack-nova07:27
*** Murali has quit IRC07:31
*** Murali_ is now known as Murali07:31
*** sahid has quit IRC07:35
*** mdbooth has quit IRC07:35
*** mdbooth has joined #openstack-nova07:40
*** oro has joined #openstack-nova07:43
*** browne has quit IRC07:46
*** oro has quit IRC07:50
*** openstackgerrit has quit IRC07:51
*** openstackgerrit has joined #openstack-nova07:51
openstackgerritjaveme proposed openstack/nova: [VMware] Using ShutdownGuest instead of PowerOffVM_Task, if vmtools was installed.  https://review.openstack.org/18162807:56
*** Murali has quit IRC07:56
*** otter768 has joined #openstack-nova08:00
*** Murali has joined #openstack-nova08:05
*** otter768 has quit IRC08:05
*** Murali has quit IRC08:10
*** dsanders has joined #openstack-nova08:26
*** lpetrut has joined #openstack-nova08:29
*** vilobhmm11 has quit IRC08:37
openstackgerritjaveme proposed openstack/nova: [VMware] Using ShutdownGuest instead of PowerOffVM_Task, if vmtools was installed.  https://review.openstack.org/18163408:38
*** jamielennox|away is now known as jamielennox08:39
*** achanda has quit IRC08:40
*** exploreshaifali has joined #openstack-nova08:43
*** achanda has joined #openstack-nova08:55
*** jichen has joined #openstack-nova09:02
*** subscope_ has joined #openstack-nova09:05
*** jswarren has quit IRC09:09
*** dsanders has quit IRC09:11
*** zhangtralon has joined #openstack-nova09:16
*** Murali has joined #openstack-nova09:17
*** zhangtralon has quit IRC09:18
*** rwmjones has quit IRC09:29
*** garyk has joined #openstack-nova09:34
*** Murali has quit IRC09:37
*** achanda has quit IRC09:39
*** kiran-r has joined #openstack-nova09:52
*** pixelbeat_ has joined #openstack-nova09:53
*** otter768 has joined #openstack-nova10:01
*** IanGovett has joined #openstack-nova10:02
*** Kennan2 has joined #openstack-nova10:03
*** Kennan has quit IRC10:04
*** nihilifer has quit IRC10:06
*** otter768 has quit IRC10:06
*** nihilifer has joined #openstack-nova10:09
*** pixelbeat_ has quit IRC10:10
*** rwmjones has joined #openstack-nova10:15
*** nihilifer has quit IRC10:18
*** nihilifer has joined #openstack-nova10:19
*** nihilifer has quit IRC10:28
*** nihilifer has joined #openstack-nova10:29
*** jichen has quit IRC10:35
*** nihilifer has quit IRC10:39
*** exploreshaifali has quit IRC11:01
*** pixelbeat_ has joined #openstack-nova11:04
*** lpetrut has quit IRC11:16
*** Mike_D_laptop has quit IRC11:23
*** kiranr has joined #openstack-nova11:24
*** kiran-r has quit IRC11:28
*** lpetrut has joined #openstack-nova11:34
*** jamielennox is now known as jamielennox|away11:36
*** alexpilotti has quit IRC11:41
*** oro has joined #openstack-nova11:47
*** pixelbeat_ has quit IRC11:47
*** otter768 has joined #openstack-nova12:02
*** otter768 has quit IRC12:07
*** oro has quit IRC12:11
*** nihilifer has joined #openstack-nova12:12
*** baoli has joined #openstack-nova12:15
*** IanGovett1 has joined #openstack-nova12:16
*** IanGovett has quit IRC12:18
*** subscope_ has quit IRC12:25
*** baoli has quit IRC12:26
*** VW_ has joined #openstack-nova12:34
*** VW_ has quit IRC12:39
*** subscope_ has joined #openstack-nova12:46
*** oro has joined #openstack-nova12:46
openstackgerritjaveme proposed openstack/nova: [VMware] Using ShutdownGuest instead of PowerOffVM_Task, if vmtools was installed.  https://review.openstack.org/18163412:51
*** subscope_ has quit IRC12:57
*** mmedvede_ has joined #openstack-nova12:59
*** baoli has joined #openstack-nova13:03
*** baoli has quit IRC13:05
*** _kiran_ has joined #openstack-nova13:15
*** kiranr has quit IRC13:18
*** belmoreira has joined #openstack-nova13:19
*** belmoreira has quit IRC13:19
*** IanGovett has joined #openstack-nova13:24
*** IanGovett1 has quit IRC13:26
*** baoli has joined #openstack-nova13:48
*** takedakn has joined #openstack-nova13:51
*** baoli has quit IRC13:54
*** alexpilotti has joined #openstack-nova13:55
*** wanghua has joined #openstack-nova13:55
*** pixelbeat_ has joined #openstack-nova13:57
*** _kiran_ has quit IRC13:57
*** takedakn has quit IRC13:59
*** pixelbeat_ has quit IRC14:03
*** otter768 has joined #openstack-nova14:03
*** otter768 has quit IRC14:08
*** nihilifer has quit IRC14:12
*** redbeard has joined #openstack-nova14:13
*** VW_ has joined #openstack-nova14:19
*** nihilifer has joined #openstack-nova14:29
*** browne has joined #openstack-nova14:32
*** baoli has joined #openstack-nova14:46
*** cfriesen has joined #openstack-nova14:47
*** Mike_D_laptop has joined #openstack-nova14:51
*** Raildo has joined #openstack-nova14:56
*** oro has quit IRC14:56
*** baoli has quit IRC14:59
*** humble_ has joined #openstack-nova15:00
*** VW_ has quit IRC15:02
*** VW_ has joined #openstack-nova15:03
*** wanghua has quit IRC15:04
*** sdake has joined #openstack-nova15:04
*** IanGovett has quit IRC15:06
*** sdake_ has quit IRC15:08
*** VW_ has quit IRC15:08
openstackgerritjaveme proposed openstack/nova: vm_state and power_state are inconsistent after creating a VM which is not power-on.  https://review.openstack.org/18166115:15
*** humble__ has joined #openstack-nova15:16
*** ZZelle has joined #openstack-nova15:16
*** dave-mccowan has quit IRC15:17
-openstackstatus- NOTICE: Gerrit will be offline from 1600-2000 UTC while it is upgraded to version 2.1015:17
*** humble_ has quit IRC15:20
*** kiran-r has joined #openstack-nova15:25
openstackgerritHua Wang proposed openstack/nova: Import CONF.host before use it  https://review.openstack.org/18166315:26
*** pixelbeat_ has joined #openstack-nova15:35
*** kiran-r has quit IRC15:36
*** pixelbeat_ has quit IRC15:41
*** humble__ has quit IRC15:42
*** tjones1 has joined #openstack-nova15:49
*** tjones1 has left #openstack-nova15:49
*** baoli has joined #openstack-nova15:52
*** exploreshaifali has joined #openstack-nova15:54
*** baoli has quit IRC15:56
*** baoli has joined #openstack-nova15:56
*** subscope has quit IRC15:57
*** garyk has quit IRC16:00
*** sdake_ has joined #openstack-nova16:01
-openstackstatus- NOTICE: Gerrit is offline from 16:00-20:00 UTC to upgrade to version 2.10.16:01
*** ChanServ changes topic to "Gerrit is offline from 16:00-20:00 UTC to upgrade to version 2.10."16:01
*** baoli has quit IRC16:03
*** otter768 has joined #openstack-nova16:04
*** subscope has joined #openstack-nova16:04
*** sdake has quit IRC16:05
*** otter768 has quit IRC16:08
*** Raildo has quit IRC16:11
*** baoli has joined #openstack-nova16:12
*** tonytan4ever has quit IRC16:13
*** tonytan4ever has joined #openstack-nova16:14
*** baoli has quit IRC16:14
*** nihilifer has quit IRC16:15
*** moshele has joined #openstack-nova16:19
*** moshele has quit IRC16:19
*** moshele has joined #openstack-nova16:20
*** armax has quit IRC16:20
*** ildikov has quit IRC16:24
*** dsanders has joined #openstack-nova16:25
*** dsanders has quit IRC16:28
*** dboik has quit IRC16:31
*** dboik has joined #openstack-nova16:32
*** ildikov has joined #openstack-nova16:38
*** moshele has quit IRC16:41
*** apuimedo_ has joined #openstack-nova16:43
*** armax has joined #openstack-nova16:48
*** armax has quit IRC16:58
*** otter768 has joined #openstack-nova17:14
*** sdake has joined #openstack-nova17:20
*** sdake_ has quit IRC17:23
*** dsanders has joined #openstack-nova17:31
*** iamjarvo has joined #openstack-nova17:40
*** iamjarvo has quit IRC17:40
*** iamjarvo has joined #openstack-nova17:41
*** iamjarvo has quit IRC17:41
openstackgerritjaveme proposed openstack/nova: Using ShutdownGuest instead of PowerOffVM_Task.  https://review.openstack.org/18163417:41
*** hanzhang has quit IRC17:42
*** liusheng has quit IRC17:43
*** iamjarvo has joined #openstack-nova17:46
*** oro has joined #openstack-nova17:48
*** ildikov has quit IRC17:51
*** hanzhang has joined #openstack-nova17:52
*** liusheng has joined #openstack-nova17:53
*** moshele has joined #openstack-nova17:54
*** dsanders has quit IRC17:57
openstackgerritMoshe Levi proposed openstack/nova: Move ebrctl to compute.filter.  https://review.openstack.org/18167017:58
openstackgerritMoshe Levi proposed openstack/nova: libvirt: mlnx_direct vif type removal  https://review.openstack.org/18167118:01
*** achanda has joined #openstack-nova18:05
openstackgerritMoshe Levi proposed openstack/nova: libvirt: mlnx_direct vif type removal  https://review.openstack.org/18167118:05
*** apuimedo_ has quit IRC18:06
*** ildikov has joined #openstack-nova18:06
*** moshele has quit IRC18:08
*** iamjarvo_ has joined #openstack-nova18:21
*** iamjarvo has quit IRC18:22
*** kiran-r has joined #openstack-nova18:24
*** otter768 has quit IRC18:28
*** dave-mccowan has joined #openstack-nova18:29
*** ChanServ changes topic to "This channel is for Nova development. For support of Nova deployments, please use #openstack. -=- master is open for Lemming development"18:31
-openstackstatus- NOTICE: Gerrit upgrade completed; please report problems in #openstack-infra18:31
*** superdan is now known as dansmith18:32
*** dave-mccowan has quit IRC18:32
*** Nikolay_St has joined #openstack-nova18:35
*** achanda has quit IRC18:36
*** iamjarvo_ has quit IRC18:36
*** iamjarvo has joined #openstack-nova18:39
*** iamjarvo has joined #openstack-nova18:40
*** openstackgerrit has quit IRC18:52
*** openstackgerrit has joined #openstack-nova18:52
*** Sukhdev has joined #openstack-nova18:53
*** VW_ has joined #openstack-nova18:56
*** kiran-r has quit IRC18:56
*** Mike_D_laptop has quit IRC19:01
*** VW_ has quit IRC19:13
*** VW_ has joined #openstack-nova19:24
*** VW_ has quit IRC19:29
*** luv has quit IRC19:32
*** iamjarvo has quit IRC19:34
openstackgerritjaveme proposed openstack/nova: Update to return the correct esx iqn.  https://review.openstack.org/16270019:49
*** luv has joined #openstack-nova19:55
*** Marga_ has joined #openstack-nova20:01
*** apuimedo_ has joined #openstack-nova20:03
*** iamjarvo has joined #openstack-nova20:10
*** moshele has joined #openstack-nova20:13
*** moshele has quit IRC20:13
openstackgerritjaveme proposed openstack/nova: To make vm_state consistent with power_state.  https://review.openstack.org/18166120:29
*** otter768 has joined #openstack-nova20:29
*** otter768 has quit IRC20:35
*** patrickeast has joined #openstack-nova20:40
*** vilobhmm1 has joined #openstack-nova20:42
*** subscope has quit IRC20:45
openstackgerritjaveme proposed openstack/nova: To make vm_state consistent with power_state.  https://review.openstack.org/18166120:46
*** iamjarvo has quit IRC20:48
*** Sukhdev has quit IRC20:53
*** mriedem has joined #openstack-nova20:56
*** browne has quit IRC21:00
*** oro has quit IRC21:05
*** exploreshaifali has quit IRC21:09
*** oro has joined #openstack-nova21:16
*** otter768 has joined #openstack-nova21:16
*** leakypipes has quit IRC21:21
*** vilobhmm11 has joined #openstack-nova21:25
*** vilobhmm1 has quit IRC21:26
*** otter768 has quit IRC21:28
*** apuimedo_ has quit IRC21:34
*** lpetrut has quit IRC22:00
*** vishwanathj has joined #openstack-nova22:01
*** vishwana_ has quit IRC22:03
*** pixelbeat_ has joined #openstack-nova22:05
*** Marga_ has quit IRC22:08
*** patrickeast has quit IRC22:10
*** tjones1 has joined #openstack-nova22:13
*** oro has quit IRC22:24
*** sdake has quit IRC22:27
*** tjones1 has quit IRC22:31
*** sdake has joined #openstack-nova22:31
*** Marga_ has joined #openstack-nova22:35
*** pixelbeat_ has quit IRC22:35
*** achanda has joined #openstack-nova22:54
*** vilobhmm11 has quit IRC22:57
*** salv-orlando has quit IRC22:58
*** Longgeek has quit IRC23:06
*** redbeard has quit IRC23:07
*** dboik has quit IRC23:09
*** rushiagr_away is now known as rushiagr23:18
*** oro has joined #openstack-nova23:20
*** otter768 has joined #openstack-nova23:28
*** rushiagr is now known as rushiagr_away23:28
*** Marga_ has quit IRC23:37
*** Marga_ has joined #openstack-nova23:50
*** salv-orlando has joined #openstack-nova23:59
*** otter768 has quit IRC23:59

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!