*** emagana has quit IRC | 00:01 | |
*** annegentle has quit IRC | 00:04 | |
*** ijw_ has joined #openstack-nova | 00:08 | |
*** annegentle has joined #openstack-nova | 00:09 | |
*** ZZelle_ has quit IRC | 00:10 | |
*** ijw has quit IRC | 00:11 | |
*** nelsnelson has quit IRC | 00:11 | |
*** markvoelker has joined #openstack-nova | 00:16 | |
*** tjones1 has joined #openstack-nova | 00:16 | |
*** alanf-mc has joined #openstack-nova | 00:19 | |
*** david-lyle has quit IRC | 00:20 | |
*** annegentle has quit IRC | 00:21 | |
*** Sukhdev has joined #openstack-nova | 00:22 | |
*** wwriverrat has quit IRC | 00:22 | |
*** sdake has quit IRC | 00:22 | |
*** davideagnello has quit IRC | 00:23 | |
*** markvoelker has quit IRC | 00:23 | |
*** markvoelker has joined #openstack-nova | 00:23 | |
*** salv-orlando has joined #openstack-nova | 00:25 | |
*** davideagnello has joined #openstack-nova | 00:25 | |
*** exploreshaifali has quit IRC | 00:26 | |
*** annegentle has joined #openstack-nova | 00:27 | |
*** mohitsharma has joined #openstack-nova | 00:29 | |
*** davideagnello has quit IRC | 00:29 | |
*** yingjun has joined #openstack-nova | 00:31 | |
*** davideagnello has joined #openstack-nova | 00:33 | |
*** ddutta has joined #openstack-nova | 00:34 | |
*** mohitsharma has quit IRC | 00:34 | |
*** annegentle has quit IRC | 00:36 | |
*** otter768 has joined #openstack-nova | 00:39 | |
*** otter768 has quit IRC | 00:44 | |
*** yamahata has quit IRC | 00:44 | |
*** nelsnelson has joined #openstack-nova | 00:46 | |
*** zhenguo has joined #openstack-nova | 00:46 | |
*** ddutta has quit IRC | 00:58 | |
*** salv-orlando has quit IRC | 01:03 | |
*** tobe has joined #openstack-nova | 01:09 | |
*** dims has quit IRC | 01:12 | |
*** tjones1 has left #openstack-nova | 01:12 | |
*** patrickeast has quit IRC | 01:14 | |
*** mohitsharma has joined #openstack-nova | 01:17 | |
*** dsanders has quit IRC | 01:18 | |
*** jamielennox|away is now known as jamielennox | 01:23 | |
*** garloff has joined #openstack-nova | 01:26 | |
*** mohitsharma has quit IRC | 01:26 | |
*** alanf-mc has quit IRC | 01:27 | |
*** annegentle has joined #openstack-nova | 01:27 | |
*** annegentle has quit IRC | 01:28 | |
*** garloff_ has quit IRC | 01:29 | |
*** david-lyle has joined #openstack-nova | 01:35 | |
*** thorst has quit IRC | 01:39 | |
*** ijw has joined #openstack-nova | 01:39 | |
*** popw has joined #openstack-nova | 01:42 | |
*** ijw_ has quit IRC | 01:42 | |
*** electrocucaracha has quit IRC | 01:44 | |
*** annegentle has joined #openstack-nova | 01:49 | |
*** kaufer has joined #openstack-nova | 01:50 | |
*** Sukhdev has quit IRC | 01:51 | |
*** jyuso has quit IRC | 01:51 | |
wanghao | andrearosa: hi~, I see the review in https://review.openstack.org/#/c/84048. Will update it today.:) | 01:52 |
---|---|---|
*** yamahata has joined #openstack-nova | 01:53 | |
*** kiran-r has joined #openstack-nova | 01:55 | |
*** dave-mccowan has joined #openstack-nova | 02:00 | |
*** bzhao has joined #openstack-nova | 02:02 | |
*** salv-orlando has joined #openstack-nova | 02:04 | |
*** zhangtralon has joined #openstack-nova | 02:04 | |
*** pixelb has quit IRC | 02:09 | |
*** salv-orlando has quit IRC | 02:09 | |
openstackgerrit | wanghao proposed openstack/nova-specs: Support force detach volume to nova https://review.openstack.org/84048 | 02:09 |
*** unicell has quit IRC | 02:11 | |
*** kiran-r has quit IRC | 02:17 | |
*** salv-orlando has joined #openstack-nova | 02:21 | |
*** yingjun has quit IRC | 02:21 | |
*** salv-orlando has quit IRC | 02:25 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: libvirt: simplify logic of checking PCI device's existence https://review.openstack.org/145400 | 02:29 |
*** kiran-r has joined #openstack-nova | 02:31 | |
*** yingjun has joined #openstack-nova | 02:31 | |
*** david-lyle has quit IRC | 02:33 | |
*** gyee has quit IRC | 02:36 | |
*** annegentle has quit IRC | 02:38 | |
*** ijw has quit IRC | 02:39 | |
*** otter768 has joined #openstack-nova | 02:40 | |
*** annegentle has joined #openstack-nova | 02:40 | |
*** claudiub has quit IRC | 02:41 | |
*** zhangtralon has quit IRC | 02:44 | |
*** dsanders has joined #openstack-nova | 02:44 | |
*** otter768 has quit IRC | 02:44 | |
*** yingjun has quit IRC | 02:46 | |
*** whenry has joined #openstack-nova | 02:47 | |
*** nic has quit IRC | 02:47 | |
*** gokrokve has joined #openstack-nova | 02:52 | |
*** nelsnelson has quit IRC | 02:53 | |
*** yingjun has joined #openstack-nova | 02:53 | |
*** nelsnelson has joined #openstack-nova | 02:54 | |
*** whenry has quit IRC | 02:56 | |
*** browne has quit IRC | 03:00 | |
*** dave-mccowan has quit IRC | 03:04 | |
*** bzhao has quit IRC | 03:04 | |
openstackgerrit | Sabari proposed openstack/nova: VMware: Fix base exceptions changed in oslo.vmware 0.13.0 https://review.openstack.org/185830 | 03:05 |
*** gokrokve has quit IRC | 03:06 | |
*** gokrokve has joined #openstack-nova | 03:07 | |
*** tobe has quit IRC | 03:08 | |
*** RuiChen has joined #openstack-nova | 03:10 | |
*** gokrokve has quit IRC | 03:11 | |
*** david-lyle has joined #openstack-nova | 03:11 | |
*** veena has joined #openstack-nova | 03:13 | |
*** kiran-r has quit IRC | 03:18 | |
*** norman has joined #openstack-nova | 03:18 | |
*** kaisers has quit IRC | 03:20 | |
*** salv-orlando has joined #openstack-nova | 03:21 | |
*** fawadkhaliq has joined #openstack-nova | 03:22 | |
*** tobe has joined #openstack-nova | 03:26 | |
*** VW has joined #openstack-nova | 03:26 | |
*** salv-orl_ has joined #openstack-nova | 03:28 | |
*** salv-orlando has quit IRC | 03:29 | |
*** browne has joined #openstack-nova | 03:30 | |
*** salv-orl_ has quit IRC | 03:32 | |
*** annegentle has quit IRC | 03:32 | |
*** changbl has joined #openstack-nova | 03:32 | |
*** triggerz has quit IRC | 03:34 | |
*** dave-mccowan has joined #openstack-nova | 03:36 | |
*** salv-orlando has joined #openstack-nova | 03:36 | |
*** annegentle has joined #openstack-nova | 03:37 | |
*** dsanders has quit IRC | 03:40 | |
*** salv-orlando has quit IRC | 03:41 | |
*** salv-orl_ has joined #openstack-nova | 03:43 | |
*** salv-orl_ has quit IRC | 03:43 | |
*** VW has quit IRC | 03:44 | |
*** VW has joined #openstack-nova | 03:45 | |
*** diga has joined #openstack-nova | 03:51 | |
*** emagana has joined #openstack-nova | 03:51 | |
*** yingjun has quit IRC | 03:52 | |
*** armax has quit IRC | 03:54 | |
*** Sukhdev has joined #openstack-nova | 03:58 | |
*** tobe has quit IRC | 03:58 | |
*** deepthi has joined #openstack-nova | 04:01 | |
*** achanda has joined #openstack-nova | 04:02 | |
*** krtaylor has joined #openstack-nova | 04:03 | |
*** dsanders has joined #openstack-nova | 04:06 | |
*** rajesht has joined #openstack-nova | 04:06 | |
*** rajesht has quit IRC | 04:08 | |
*** dave-mccowan has quit IRC | 04:09 | |
*** dbyte has joined #openstack-nova | 04:10 | |
*** abhishekk has joined #openstack-nova | 04:13 | |
*** links has joined #openstack-nova | 04:15 | |
openstackgerrit | Eric Brown proposed openstack/nova: VMware: use predefined constant for os_type https://review.openstack.org/185836 | 04:19 |
*** xyang1 has quit IRC | 04:20 | |
*** Nikolay_St has quit IRC | 04:23 | |
*** annegentle has quit IRC | 04:26 | |
*** markvoelker has quit IRC | 04:31 | |
*** nihilifer has quit IRC | 04:32 | |
*** unicell has joined #openstack-nova | 04:34 | |
*** tobe has joined #openstack-nova | 04:34 | |
*** zhangtralon has joined #openstack-nova | 04:35 | |
*** dsanders has quit IRC | 04:35 | |
*** amotoki_ has joined #openstack-nova | 04:35 | |
*** otter768 has joined #openstack-nova | 04:41 | |
*** zhangtralon has quit IRC | 04:42 | |
*** otter768 has quit IRC | 04:45 | |
openstackgerrit | Eric Brown proposed openstack/nova: VMware: replace hardcoded strings with constants https://review.openstack.org/185836 | 04:48 |
*** irenab has joined #openstack-nova | 04:50 | |
*** bkopilov is now known as bkopilov_wfh | 04:52 | |
*** mdbooth has quit IRC | 04:55 | |
*** pradipta has joined #openstack-nova | 04:55 | |
*** gokrokve has joined #openstack-nova | 04:56 | |
*** VW has quit IRC | 04:58 | |
*** mdbooth has joined #openstack-nova | 04:59 | |
*** kiran-r has joined #openstack-nova | 05:00 | |
*** matrohon has joined #openstack-nova | 05:01 | |
*** tobe has quit IRC | 05:04 | |
*** nkrinner has joined #openstack-nova | 05:05 | |
*** gokrokve has quit IRC | 05:14 | |
*** salv-orlando has joined #openstack-nova | 05:16 | |
*** sdake has joined #openstack-nova | 05:18 | |
*** leopoldj has joined #openstack-nova | 05:18 | |
*** achanda has quit IRC | 05:19 | |
*** whenry has joined #openstack-nova | 05:19 | |
*** salv-orlando has quit IRC | 05:21 | |
*** penick has quit IRC | 05:23 | |
*** belmoreira has joined #openstack-nova | 05:23 | |
*** penick has joined #openstack-nova | 05:24 | |
*** matrohon has quit IRC | 05:27 | |
openstackgerrit | Alex Xu proposed openstack/nova-specs: Correct resource name for consolidate console API https://review.openstack.org/185844 | 05:27 |
*** whenry has quit IRC | 05:33 | |
*** Sukhdev has quit IRC | 05:34 | |
*** fawadk has joined #openstack-nova | 05:37 | |
*** fawadk has quit IRC | 05:37 | |
*** fawadk has joined #openstack-nova | 05:37 | |
*** fawadk is now known as fawadkhaliq_ | 05:37 | |
*** deepthi has quit IRC | 05:38 | |
*** fawadkhaliq has quit IRC | 05:39 | |
*** sdake has quit IRC | 05:40 | |
*** salv-orlando has joined #openstack-nova | 05:44 | |
*** IanGovett has joined #openstack-nova | 05:44 | |
*** salv-orl_ has joined #openstack-nova | 05:47 | |
*** salv-orlando has quit IRC | 05:48 | |
*** whenry has joined #openstack-nova | 05:50 | |
*** tobe has joined #openstack-nova | 05:50 | |
*** achanda has joined #openstack-nova | 05:52 | |
*** bfic has joined #openstack-nova | 05:54 | |
*** whenry has quit IRC | 05:54 | |
*** salv-or__ has joined #openstack-nova | 05:55 | |
*** salv-orl_ has quit IRC | 05:55 | |
*** salv-orl_ has joined #openstack-nova | 05:57 | |
*** achanda_ has joined #openstack-nova | 05:58 | |
*** achanda has quit IRC | 05:59 | |
*** salv-or__ has quit IRC | 06:00 | |
*** IanGovett has quit IRC | 06:00 | |
*** emagana has quit IRC | 06:00 | |
*** emagana has joined #openstack-nova | 06:01 | |
*** kaisers has joined #openstack-nova | 06:01 | |
*** salv-orlando has joined #openstack-nova | 06:01 | |
openstackgerrit | Qin Zhao proposed openstack/nova: Refactor show_port() in neutron api https://review.openstack.org/135020 | 06:02 |
*** salv-orl_ has quit IRC | 06:02 | |
*** kaisers has quit IRC | 06:02 | |
*** fawadkhaliq has joined #openstack-nova | 06:03 | |
*** flashgordon is now known as jogo | 06:04 | |
*** garyk has joined #openstack-nova | 06:04 | |
*** emagana has quit IRC | 06:05 | |
*** fawadkhaliq_ has quit IRC | 06:05 | |
*** garyk has quit IRC | 06:06 | |
*** salv-orlando has quit IRC | 06:06 | |
*** fawadk has joined #openstack-nova | 06:06 | |
*** kaisers has joined #openstack-nova | 06:06 | |
*** garyk has joined #openstack-nova | 06:06 | |
*** salv-orlando has joined #openstack-nova | 06:06 | |
*** yingjun has joined #openstack-nova | 06:07 | |
*** garyk has quit IRC | 06:07 | |
*** fawadkhaliq has quit IRC | 06:08 | |
*** unicell has quit IRC | 06:09 | |
*** unicell has joined #openstack-nova | 06:09 | |
*** unicell1 has joined #openstack-nova | 06:14 | |
*** achanda_ has quit IRC | 06:15 | |
*** unicell has quit IRC | 06:16 | |
*** tobe has quit IRC | 06:20 | |
*** dsanders has joined #openstack-nova | 06:21 | |
*** salv-orlando has quit IRC | 06:21 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex https://review.openstack.org/179638 | 06:22 |
*** ankit_ag has joined #openstack-nova | 06:22 | |
*** garyk has joined #openstack-nova | 06:23 | |
garyk | hi, are there any cores around. if so then please look at https://review.openstack.org/#/c/185830/ - this will unblock the gate | 06:23 |
*** sahid has joined #openstack-nova | 06:27 | |
*** salv-orl_ has joined #openstack-nova | 06:28 | |
*** cfriesen has quit IRC | 06:29 | |
*** kaisers has quit IRC | 06:30 | |
*** salv-orlando has joined #openstack-nova | 06:31 | |
*** salv-or__ has joined #openstack-nova | 06:33 | |
*** salv-orl_ has quit IRC | 06:33 | |
openstackgerrit | Carlos Gonçalves proposed openstack/python-novaclient: Support forcing service down https://review.openstack.org/185849 | 06:33 |
*** yingjun has quit IRC | 06:33 | |
*** rotbeard has joined #openstack-nova | 06:34 | |
*** salv-orlando has quit IRC | 06:35 | |
*** salv-or__ has quit IRC | 06:37 | |
*** tobe has joined #openstack-nova | 06:38 | |
*** ZZelle_ has joined #openstack-nova | 06:39 | |
*** rajesht has joined #openstack-nova | 06:39 | |
*** yingjun has joined #openstack-nova | 06:40 | |
*** oomichi has joined #openstack-nova | 06:41 | |
*** otter768 has joined #openstack-nova | 06:42 | |
*** kaufer has quit IRC | 06:46 | |
*** otter768 has quit IRC | 06:46 | |
*** deepthi has joined #openstack-nova | 06:47 | |
*** moshele has joined #openstack-nova | 06:48 | |
*** salv-orlando has joined #openstack-nova | 06:49 | |
*** Murali has joined #openstack-nova | 06:50 | |
*** yingjun has quit IRC | 06:51 | |
*** yingjun has joined #openstack-nova | 06:51 | |
*** fawadkhaliq has joined #openstack-nova | 06:51 | |
*** User17 has quit IRC | 06:52 | |
*** pece has joined #openstack-nova | 06:53 | |
*** salv-orl_ has joined #openstack-nova | 06:53 | |
*** oomichi has quit IRC | 06:53 | |
*** salv-orlando has quit IRC | 06:53 | |
*** fawadk has quit IRC | 06:54 | |
*** lpetrut has joined #openstack-nova | 06:55 | |
*** yingjun has quit IRC | 06:56 | |
*** yingjun has joined #openstack-nova | 06:57 | |
*** salv-orl_ has quit IRC | 06:58 | |
*** salv-orlando has joined #openstack-nova | 06:58 | |
*** mpaolino has joined #openstack-nova | 06:59 | |
gilliard | Good Morning all! | 06:59 |
*** salv-orl_ has joined #openstack-nova | 07:00 | |
*** achanda has joined #openstack-nova | 07:02 | |
*** salv-orlando has quit IRC | 07:03 | |
*** mpaolino has quit IRC | 07:04 | |
*** claudiub has joined #openstack-nova | 07:04 | |
*** salv-orl_ has quit IRC | 07:05 | |
*** dbyte has quit IRC | 07:06 | |
*** dbyte has joined #openstack-nova | 07:07 | |
*** dbyte has quit IRC | 07:07 | |
*** dbite has quit IRC | 07:07 | |
*** dguitarbite has quit IRC | 07:07 | |
*** dguitarbite has joined #openstack-nova | 07:07 | |
*** abhishekk has quit IRC | 07:07 | |
*** romainh has joined #openstack-nova | 07:09 | |
openstackgerrit | Qin Zhao proposed openstack/nova: Update sqlalchemy-migrate to 0.9.6 https://review.openstack.org/170050 | 07:10 |
*** mpavone has joined #openstack-nova | 07:11 | |
*** Administrator__ has joined #openstack-nova | 07:13 | |
*** dsanders has quit IRC | 07:14 | |
*** Administrator_ has quit IRC | 07:16 | |
*** IanGovett has joined #openstack-nova | 07:17 | |
*** markvoelker has joined #openstack-nova | 07:17 | |
*** radek__ has joined #openstack-nova | 07:18 | |
*** bkopilov_wfh has quit IRC | 07:20 | |
*** dulek has joined #openstack-nova | 07:20 | |
*** salv-orlando has joined #openstack-nova | 07:23 | |
*** matrohon has joined #openstack-nova | 07:24 | |
*** emagana has joined #openstack-nova | 07:25 | |
*** bkopilov has joined #openstack-nova | 07:25 | |
*** annegentle has joined #openstack-nova | 07:27 | |
*** salv-orlando has quit IRC | 07:27 | |
*** salv-orlando has joined #openstack-nova | 07:27 | |
*** dsanders has joined #openstack-nova | 07:28 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Rewrite nova.tests.network.test_manager.AllocateTestCase https://review.openstack.org/185860 | 07:29 |
*** emagana has quit IRC | 07:30 | |
*** pbrooko has joined #openstack-nova | 07:31 | |
*** salv-orlando has quit IRC | 07:31 | |
*** annegentle has quit IRC | 07:32 | |
*** salv-orlando has joined #openstack-nova | 07:32 | |
*** pbrooko has quit IRC | 07:32 | |
*** markus_z has joined #openstack-nova | 07:32 | |
*** alex_klimov has joined #openstack-nova | 07:34 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Rewrite nova.tests.network.test_manager.AllocateTestCase https://review.openstack.org/185860 | 07:34 |
*** salv-orl_ has joined #openstack-nova | 07:35 | |
*** salv-orlando has quit IRC | 07:36 | |
* bauzas suffers terrible headache - thanks jetlag | 07:36 | |
*** achanda has quit IRC | 07:36 | |
* gilliard recommends some nice cheese | 07:36 | |
bauzas | gilliard: a beer would be more welcome | 07:37 |
gilliard | bit early for beer? | 07:37 |
*** tobe has quit IRC | 07:37 | |
*** achanda has joined #openstack-nova | 07:38 | |
lxsli | garyk: do you happen to know what the correct bug # for that patch is please? | 07:38 |
bauzas | gilliard: depending on the TZ, nope | 07:38 |
lxsli | Also, morning | 07:38 |
*** dims has joined #openstack-nova | 07:38 | |
*** tobe has joined #openstack-nova | 07:38 | |
gilliard | garyk lxsli: https://bugs.launchpad.net/nova/+bug/1459021 | 07:39 |
openstack | Launchpad bug 1459021 in oslo.vmware "nova vmware unit tests failing with oslo.vmware 0.13.0" [Undecided,In progress] - Assigned to Matt Riedemann (mriedem) | 07:39 |
garyk | lxsli: there is a patch which fixes nova | 07:39 |
gilliard | ^^ that patch has the wrong bug # in the commit :( | 07:40 |
garyk | https://review.openstack.org/#/c/185830/ | 07:40 |
garyk | gilliard: not sure why you -1'ed - i think that is a better fix than the revert of the oslo.vmware | 07:40 |
openstackgerrit | Matthew Gilliard proposed openstack/nova: VMware: Fix base exceptions changed in oslo.vmware 0.13.0 https://review.openstack.org/185830 | 07:41 |
garyk | gilliard: is that due to the commit message? | 07:41 |
*** pbrooko has joined #openstack-nova | 07:41 | |
gilliard | yes. updated. | 07:41 |
garyk | gilliard: thanks! | 07:41 |
*** veena has quit IRC | 07:41 | |
garyk | gilliard: i feel that this is better than reverting the oslo patch | 07:42 |
gilliard | it's a bit of a core-drought at this time of day though :( | 07:42 |
*** jlanoux has joined #openstack-nova | 07:42 | |
lxsli | johnthetubaguy: should be online soon, maybe ndipanov ? | 07:42 |
*** dims has quit IRC | 07:44 | |
*** toan-tran has joined #openstack-nova | 07:46 | |
*** toan-tran has left #openstack-nova | 07:46 | |
*** achanda has quit IRC | 07:47 | |
*** fawadkhaliq has quit IRC | 07:50 | |
*** jistr has joined #openstack-nova | 07:52 | |
*** Nikolay_St has joined #openstack-nova | 07:53 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Rewrite nova.tests.network.test_manager.AllocateTestCase https://review.openstack.org/185860 | 07:59 |
*** yingjun has quit IRC | 07:59 | |
*** achanda has joined #openstack-nova | 08:00 | |
*** emagana has joined #openstack-nova | 08:04 | |
*** dsanders has quit IRC | 08:09 | |
*** emagana has quit IRC | 08:09 | |
*** xgsa has joined #openstack-nova | 08:10 | |
openstackgerrit | Yongli He proposed openstack/nova-specs: test cases for third party CI https://review.openstack.org/141270 | 08:11 |
*** matrohon has quit IRC | 08:14 | |
*** yassine_ has joined #openstack-nova | 08:15 | |
*** whenry has joined #openstack-nova | 08:20 | |
*** apuimedo|away has joined #openstack-nova | 08:22 | |
*** lucasagomes has joined #openstack-nova | 08:23 | |
*** ildikov has joined #openstack-nova | 08:23 | |
*** whenry has quit IRC | 08:25 | |
openstackgerrit | Maxim Nestratov proposed openstack/nova: libvirt: rename parallels driver to virtuozzo https://review.openstack.org/184311 | 08:26 |
*** ZZelle has quit IRC | 08:27 | |
*** ZZelle has joined #openstack-nova | 08:27 | |
andrearosa | wanghao: are u around? ref "add force detach to nova" | 08:28 |
*** pixelb has joined #openstack-nova | 08:29 | |
wanghao | Yes | 08:30 |
*** danpb has joined #openstack-nova | 08:31 | |
*** mpavone has quit IRC | 08:31 | |
andrearosa | wanghao: thanks for adding me as co-author of the spec. Are you ok if I edit the spec? or do you prefer to edit it and I'll add my comments? or both :) | 08:31 |
wanghao | Of course, you can edit this spec. | 08:32 |
*** ashishjain has joined #openstack-nova | 08:33 | |
andrearosa | wanghao: thanks | 08:33 |
ashishjain | Hello | 08:33 |
wanghao | andrearosa: :) | 08:33 |
ashishjain | while deploying a nova server using nova-docker driver metadata as seen by nova api is different from as seen by docker view | 08:33 |
ashishjain | Any reason for this difference? | 08:33 |
ashishjain | Is it possible to sync this up? | 08:34 |
*** heyongli has joined #openstack-nova | 08:34 | |
*** ndipanov has joined #openstack-nova | 08:36 | |
*** mpavone has joined #openstack-nova | 08:37 | |
wanghao | andrearosa: BTW, if you commit new code patch for this feature, please let me know it. Thanks. | 08:37 |
*** markus_z has quit IRC | 08:38 | |
andrearosa | wanghao: yes. I hope I'll be able to put a WIP next week, At the moment the cindeclient doesn't expose a way to call the cinder force_detach. I talked to cinder guys yesterday and they are going to put a patch as soon as possible | 08:39 |
*** haypo has joined #openstack-nova | 08:40 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Rewrite nova.tests.network.test_manager.AllocateTestCase https://review.openstack.org/185860 | 08:40 |
*** beagles has quit IRC | 08:42 | |
wanghao | andrearosa: That's good to hear that. | 08:42 |
*** tobe has quit IRC | 08:42 | |
ashishjain | Guys another question | 08:42 |
*** mariusv has quit IRC | 08:42 | |
*** otter768 has joined #openstack-nova | 08:43 | |
ashishjain | When I run "nova list" using admin I am unable to see the nova servers deployed by say a user "demo" | 08:43 |
*** Guest4835 has joined #openstack-nova | 08:43 | |
*** tobe has joined #openstack-nova | 08:43 | |
ashishjain | however when I log-in to horizon console as admin same ispossible | 08:43 |
*** yingjun has joined #openstack-nova | 08:43 | |
openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Adds VolumeOps unit tests https://review.openstack.org/139797 | 08:43 |
openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: removes test_hypervapi tests https://review.openstack.org/139798 | 08:43 |
openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Adds HyperVDriver unit tests https://review.openstack.org/148980 | 08:43 |
ashishjain | Can I use nova commands to get the list of all nova-servers running | 08:43 |
ashishjain | irrespective of tenant which it belongs to | 08:44 |
*** lpetrut has quit IRC | 08:46 | |
gilliard | you would need to be an admin user. "nova list --all" would work in that case, IIRC | 08:46 |
gilliard | (assuming by "servers" you mean "instances"?) | 08:46 |
gilliard | * --all-tenants | 08:47 |
ashishjain | aah able to make it work "nova list --all-tenants | 08:47 |
*** mariusv has joined #openstack-nova | 08:47 | |
*** otter768 has quit IRC | 08:47 | |
ashishjain | gilliard: thanks , I just used the same command | 08:47 |
gilliard | :) | 08:47 |
ashishjain | btw is there an restful api which does the same stuff | 08:47 |
gilliard | everything in the CLI uses the restful api to communicate with nova. | 08:48 |
*** mariusv has quit IRC | 08:48 | |
gilliard | "nova --debug list --all-tenants" will show you the details | 08:48 |
*** mariusv has joined #openstack-nova | 08:49 | |
ashishjain | gilliard: thanks a lot. This debug option gives all the details including the rest call | 08:50 |
*** markus_z has joined #openstack-nova | 08:51 | |
mikal | ndipanov: you around? | 08:52 |
ashishjain | gilliard: Do you know someone who can help here with nova-docker | 08:52 |
gilliard | ashishjain: Not my thing, sorry | 08:53 |
ashishjain | gilliard: no problems, thanks for your help. | 08:53 |
*** mariusv has quit IRC | 08:54 | |
gilliard | mikal: while you're waiting for ndipanov, this is blocking the gate: https://review.openstack.org/#/c/185830/ ;) | 08:56 |
mikal | gilliard: /me looks | 08:57 |
ndipanov | yo | 08:58 |
*** achanda has quit IRC | 08:58 | |
ndipanov | mikal, what up | 08:58 |
mikal | ndipanov: can you help me with a bug? | 08:58 |
gilliard | thanks mikal - sorry to jump at you like that | 08:58 |
ndipanov | I can try | 08:58 |
mikal | ndipanov: I noticed https://bugs.launchpad.net/nova/+bug/1457527 while at the summit and I started digging | 08:58 |
openstack | Launchpad bug 1457527 in OpenStack Compute (nova) "Image-cache deleting active swap backing images" [Critical,In progress] - Assigned to Michael Still (mikalstill) | 08:58 |
*** emagana has joined #openstack-nova | 08:59 | |
* ndipanov reads | 08:59 | |
mikal | ndipanov: however, I've gotten sick since coming back home after the summit and have been basically asleep for the last two days | 08:59 |
mikal | ndipanov: the root cause of the problem seems to be that swap disks don't get saved to the db bdms by the libvirt driver | 08:59 |
mikal | ndipanov: I am still unclear on if that's by design, or is a bug | 08:59 |
ndipanov | right | 08:59 |
ndipanov | I have a patch for that | 08:59 |
mikal | ndipanov: so the cache cleanup code declares all swap files to be unused | 09:00 |
*** lifeless has quit IRC | 09:00 | |
mikal | ndipanov: which causes instance corruption for instances using swap in kilo | 09:00 |
*** lifeless_ has joined #openstack-nova | 09:00 | |
ndipanov | https://review.openstack.org/#/c/83516/ | 09:00 |
* ndipanov note: typing with a baby in arms harder than typing without one | 09:01 | |
bauzas | lol | 09:01 |
mikal | ndipanov: I don't feel coherant enough to review that right now, but it doesn't seem bonkers to me | 09:02 |
ndipanov | mikal but imagecache code should still look at instance.swap_mb | 09:02 |
ndipanov | for old instances | 09:02 |
mikal | ndipanov: can you please do the thing where it gets associated with that bug? | 09:02 |
mikal | ndipanov: ok | 09:02 |
ndipanov | yes | 09:02 |
*** exploreshaifali has joined #openstack-nova | 09:02 | |
mikal | ndipanov: I think we need to do a backport of this for kilo | 09:02 |
ndipanov | will add that | 09:02 |
mikal | ndipanov: thanks, sorry I sat on this one without talking to you for so long | 09:03 |
ndipanov | np | 09:03 |
*** emagana has quit IRC | 09:03 | |
ndipanov | will look into this a bit more | 09:04 |
ndipanov | I think more work would be needed on top of this iiuc | 09:04 |
mikal | ndipanov: ok cool. I will bravely go back to bed then. | 09:04 |
*** mpavone has quit IRC | 09:04 | |
*** chaochin has joined #openstack-nova | 09:04 | |
ndipanov | mikal, brave on | 09:05 |
openstackgerrit | wanghao proposed openstack/nova-specs: Support force detach volume to nova https://review.openstack.org/84048 | 09:08 |
chaochin | garyk: Hi gary, about bug https://bugs.launchpad.net/nova/+bug/1459021, does nova ci job always load the latest code of oslo.vmware code? | 09:09 |
openstack | Launchpad bug 1459021 in OpenStack Compute (nova) "nova vmware unit tests failing with oslo.vmware 0.13.0" [Critical,In progress] - Assigned to Matthew Gilliard (matthew-gilliard-u) | 09:09 |
garyk | chaochin: yes. it should use the latest and greatest | 09:10 |
garyk | chaochin: last patch it voted on was https://review.openstack.org/#/c/175243/ | 09:11 |
chaochin | garyk: So if anyone merge wrong code in oslo.vmware, it might has possibility to break nova ci, correct? | 09:12 |
*** amotoki_ has quit IRC | 09:14 | |
*** belmoreira has quit IRC | 09:15 | |
garyk | chaochin: not sure i understand. | 09:16 |
*** ekarlso has quit IRC | 09:16 | |
garyk | chaochin: in the case of nova it just breaks the unit tests - the patch https://review.openstack.org/185830 should address this | 09:17 |
garyk | i just hope that cores can take a look at this... | 09:17 |
openstackgerrit | Sergey Nikitin proposed openstack/nova-specs: Implement server instance tagging https://review.openstack.org/177112 | 09:18 |
chaochin | garyk: yes, that patch can fix the problem. | 09:18 |
garyk | chaochin: i am not sure why the CI is not working now. Will check soon | 09:18 |
*** rushiagr_away is now known as rushiagr | 09:18 | |
*** rotbeard has quit IRC | 09:19 | |
chaochin | garyk: I see there is no oslo.vmware in requirement.txt. Should we limit oslo.vmware version <= XXX for nova? If we make a new version of oslo.vmware, we need to make a code change in requirement.txt, so that unit test can detect whether or not the new version of oslo.vmware is compatible with current nova code. | 09:22 |
chaochin | garyk: Is that a right way? | 09:22 |
*** ekarlso has joined #openstack-nova | 09:22 | |
garyk | chaochin: that was moved to test_requirements | 09:23 |
garyk | chaochin: matt and joe wanted it this way | 09:23 |
*** amotoki_ has joined #openstack-nova | 09:23 | |
garyk | originally i was not convinced but their argument was that is was driver specific | 09:23 |
*** yingjun has quit IRC | 09:24 | |
chaochin | garyk: ok. in test_requirements oslo.vmware>=0.11.1, so it always load latest version. If latest version of oslo.vmware is incompatible with current driver code, I feel it will break ut. Not sure if it is necessary to add <= | 09:28 |
chaochin | garyk: just some personal comments | 09:28 |
garyk | chaochin: if you look in the test requirements file then you will see ironic etc. so its good | 09:28 |
garyk | yeah, we always want the latest. no reason to cap it at the moment | 09:29 |
chaochin | garyk:ok | 09:29 |
*** lpetrut has joined #openstack-nova | 09:33 | |
*** diga has quit IRC | 09:33 | |
*** diga has joined #openstack-nova | 09:35 | |
*** dosaboy_ has quit IRC | 09:36 | |
*** dosaboy has joined #openstack-nova | 09:36 | |
*** derekh has joined #openstack-nova | 09:37 | |
*** amotoki_ has quit IRC | 09:39 | |
*** kaisers has joined #openstack-nova | 09:39 | |
*** mpavone has joined #openstack-nova | 09:42 | |
johnthetubaguy | garyk: can we get the CI to vote on this patch? https://review.openstack.org/#/c/185830 | 09:43 |
*** moshele has quit IRC | 09:46 | |
dave-mcnally | I have a change here looking for a second core to approve if anyone has a second: https://review.openstack.org/#/c/176805/ | 09:46 |
garyk | johnthetubaguy: yes. i am trying to see what the issue is there - seems like glance did not start. working on | 09:48 |
claudiub | hello. I would require a little bit of assistance. I'm currently trying to do a db migration and add a new element to an Enum column. Do you know any proper ways to do so? | 09:48 |
johnthetubaguy | garyk: eek, OK, thanks for digging | 09:48 |
garyk | johnthetubaguy: we may sadly have to wait for the guys in palo alto to wake up for this one. humble apoligies to all | 09:49 |
johnthetubaguy | claudiub: whats the actually real type for that column in the DB | 09:50 |
*** veena has joined #openstack-nova | 09:50 | |
johnthetubaguy | garyk: hey, no worries, it happens, usually at the worst possible moments | 09:50 |
*** eliqiao has quit IRC | 09:50 | |
claudiub | johnthetubaguy: Enum of strings: https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L736 | 09:51 |
johnthetubaguy | claudiub: right, not sure you need a DB migration then, assuming you just add an extra type? | 09:51 |
claudiub | johnthetubaguy: yeah, I want to add an extra type. | 09:52 |
johnthetubaguy | claudiub: I could be wrong, there might be some constraint that needs updating, but I am unsure of the details, not attempted that mysel | 09:52 |
openstackgerrit | sahid proposed openstack/nova: libvirt: Enchance libvirt to set admin root password https://review.openstack.org/185910 | 09:52 |
*** emagana has joined #openstack-nova | 09:53 | |
claudiub | johnthetubaguy: well, I would assume it needs a db migration, otherwise it would result in errors, trying to store that extra type. | 09:53 |
*** eliqiao has joined #openstack-nova | 09:53 | |
openstackgerrit | sahid proposed openstack/nova: libvirt: enchance libvirt to set admin root password https://review.openstack.org/185910 | 09:53 |
johnthetubaguy | claudiub: maybe, I would just look for an example where we have changed that in the past | 09:54 |
johnthetubaguy | claudiub: sorry, I have to run away and deal with some emergency internal fires | 09:54 |
claudiub | johnthetubaguy: no worries, good luck. :) | 09:55 |
*** ashishjain_ has joined #openstack-nova | 09:57 | |
*** emagana has quit IRC | 09:57 | |
*** ashishjain has quit IRC | 09:59 | |
sahid | danpb: whaoo, thanks ! | 09:59 |
*** pbrooko has quit IRC | 09:59 | |
*** ashishjain has joined #openstack-nova | 10:00 | |
*** ashishjain_ has quit IRC | 10:02 | |
*** eliqiao1 has joined #openstack-nova | 10:07 | |
*** rushiagr has quit IRC | 10:08 | |
*** eliqiao has quit IRC | 10:08 | |
*** dims has joined #openstack-nova | 10:09 | |
*** achanda has joined #openstack-nova | 10:09 | |
*** moshele has joined #openstack-nova | 10:17 | |
*** pbrooko has joined #openstack-nova | 10:20 | |
dims | garyk: my only objection would be that the unit tests behave differently with the 2 different oslo.vmware versions...i.e, the newer unit tests would fail with the older oslo.vmware | 10:24 |
openstackgerrit | sahid proposed openstack/nova: libvirt: enchance libvirt to set admin password https://review.openstack.org/185910 | 10:28 |
openstackgerrit | sahid proposed openstack/nova: libvirt: add os_admin_user to use with set admin password https://review.openstack.org/185921 | 10:28 |
*** pbrooko has quit IRC | 10:32 | |
*** veena has quit IRC | 10:37 | |
*** exploreshaifali has quit IRC | 10:43 | |
*** otter768 has joined #openstack-nova | 10:44 | |
*** emagana has joined #openstack-nova | 10:47 | |
*** pbrooko has joined #openstack-nova | 10:47 | |
*** pbrooko has quit IRC | 10:48 | |
*** emagana has quit IRC | 10:48 | |
*** otter768 has quit IRC | 10:48 | |
*** emagana has joined #openstack-nova | 10:48 | |
*** pradipta has quit IRC | 10:49 | |
*** pbrooko has joined #openstack-nova | 10:52 | |
*** emagana has quit IRC | 10:53 | |
*** romainh has quit IRC | 10:56 | |
*** romainh1 has joined #openstack-nova | 10:56 | |
*** dulek_ has joined #openstack-nova | 10:57 | |
*** romainh1 has quit IRC | 10:58 | |
*** romainh has joined #openstack-nova | 10:58 | |
*** dulek has quit IRC | 10:59 | |
*** rushiagr_away has joined #openstack-nova | 11:00 | |
*** ildikov has quit IRC | 11:01 | |
*** deepthi has quit IRC | 11:04 | |
garyk | dims: i hear you. | 11:06 |
dims | :) | 11:07 |
garyk | dims: it is not clear what our direction is - do we drop the current requirements or move with the patch by sabari. problem on our side is that we do not have CI running on this - there is some glance issue (unrelated) | 11:13 |
*** ildikov has joined #openstack-nova | 11:16 | |
*** matrohon has joined #openstack-nova | 11:17 | |
dims | garyk: ack, i'd wait on mriedem_away's input | 11:17 |
garyk | dims: ok | 11:17 |
garyk | dims: i think that the lesson here is to try and see how we can test something like this prior to publishing - it can happen with all oslo libraries (and we have seen it happen with external ones too) | 11:18 |
*** dguitarbite has quit IRC | 11:18 | |
openstackgerrit | Mh Raies proposed openstack/nova: Enable tenant/user specific instance filtering https://review.openstack.org/139025 | 11:19 |
*** romainh has quit IRC | 11:20 | |
*** achanda has quit IRC | 11:20 | |
*** dguitarbite has joined #openstack-nova | 11:21 | |
*** achanda has joined #openstack-nova | 11:25 | |
*** openstack has joined #openstack-nova | 11:38 | |
*** jdurgin has joined #openstack-nova | 11:38 | |
*** apuimedo|away has joined #openstack-nova | 11:38 | |
*** thorst has joined #openstack-nova | 11:39 | |
*** baffle_ has joined #openstack-nova | 11:40 | |
*** lucasagomes is now known as lucas-hungry | 11:41 | |
*** romainh has joined #openstack-nova | 11:41 | |
openstackgerrit | Nikola Dipanov proposed openstack/nova: libvirt: make default_device_names DRY-er https://review.openstack.org/180636 | 11:42 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: virt: add get_device_name_for_instance to the base driver class https://review.openstack.org/180637 | 11:42 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: libvirt: implement get_device_name_for_instance https://review.openstack.org/180638 | 11:42 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: virt: Move building the block_device_info dict into a method https://review.openstack.org/180635 | 11:42 |
*** emagana has joined #openstack-nova | 11:43 | |
*** gszasz has joined #openstack-nova | 11:43 | |
garyk | gilliard: agree. but not sure how can go about verifying stuff like this. in this specific case only the unit tests are broken the rest is a ok | 11:44 |
gilliard | garyk: I'm not sure either. In my previous jobs we've pinned everything and had some tooling to alert us to new deps being available, but always need to manually test that the code will work with them. | 11:46 |
*** aix has joined #openstack-nova | 11:47 | |
gilliard | ^^ That would be a pretty time-consuming job in Nova. More so than dealing with broken gates? I don't know. | 11:47 |
gilliard | At least it concentrates the work rather than stopping the whole machine. | 11:47 |
*** emagana has quit IRC | 11:48 | |
ndipanov | well that's the whole point of CI right - to catch stuff like this | 11:48 |
ndipanov | as for aggressively pinning dependencies - I am not sure about that | 11:49 |
ndipanov | if we have a dep on something - it's assumed that we are happy not only with the code itself but with the upstream too | 11:50 |
ndipanov | so vetting every single release might be an overkill | 11:50 |
gilliard | It would really be arduous, I know. | 11:51 |
gilliard | It does seem to me to be automatable, though. | 11:51 |
ndipanov | well isn't automated testing just that | 11:51 |
*** tobe has joined #openstack-nova | 11:52 | |
*** dprince has joined #openstack-nova | 11:52 | |
openstackgerrit | Ritesh proposed openstack/nova: Bug : when running nova image-create with --poll we continues to report even when instance is desroyed https://review.openstack.org/185942 | 11:52 |
ndipanov | I mean seems like a good deal to me - we get to follow upstream releases of our deps for the price of breaking changes halting our merging for a day | 11:52 |
gilliard | I mean - we could automate the aggressive pinning and upgrading of dependencies. | 11:52 |
ndipanov | gilliard, what does that get us that we don't already have? | 11:52 |
gilliard | a gate which only fails if the code being tested doesn't work. | 11:53 |
ndipanov | gilliard, well that's not what the gate is supposed to do is it | 11:53 |
ndipanov | I mean | 11:53 |
ndipanov | there are tradeoffs | 11:53 |
ndipanov | but I think we are doing the right thing here | 11:53 |
ndipanov | given the number and diversity of libs we depend on | 11:54 |
gilliard | That's the key thing. My previous life was all on the JVM where you can be pretty concise about your dependencies. | 11:54 |
gilliard | Nova is on a different scale. | 11:54 |
ndipanov | you mean Python is | 11:54 |
ndipanov | :) | 11:54 |
*** tobe has quit IRC | 11:56 | |
*** tobe has joined #openstack-nova | 11:57 | |
*** dulek___ has quit IRC | 11:58 | |
*** dulek___ has joined #openstack-nova | 11:58 | |
gilliard | We effectively pin dependencies here by having a curated repo with only one version of everything. I guess that's how most operators do it. | 11:58 |
ndipanov | gilliard, right - so for stable we should surely pin them | 12:00 |
ndipanov | for master - I think this is a good setup personally | 12:01 |
*** baoli has joined #openstack-nova | 12:01 | |
*** markvoelker has quit IRC | 12:04 | |
*** markvoelker has joined #openstack-nova | 12:04 | |
*** ashishjain has quit IRC | 12:05 | |
*** dulek_ has joined #openstack-nova | 12:06 | |
danpb | ndipanov: can you check this numa docs patch i did https://review.openstack.org/#/c/178773/ | 12:07 |
*** ildikov has quit IRC | 12:07 | |
*** bkopilov is now known as bkopilov_wfh | 12:08 | |
*** dulek___ has quit IRC | 12:09 | |
danpb | garyk: does vmware have or need any kind of cap on the maximum duration of live migration operations ? | 12:10 |
danpb | BobBall: same Q about XenServer & migration ... | 12:10 |
garyk | danpb: sadly at the moment the driver does not support this via the nova api's | 12:11 |
garyk | the implementation is broken :( | 12:11 |
danpb | in this libvirt review it was suggested that the 'live_migration_completion_timeout' config param be put in nova/virt/driver.py instead of libvirt/driver.py https://review.openstack.org/#/c/162254/4/nova/virt/libvirt/driver.py | 12:11 |
danpb | but i'm really loathe todo that unless other drivers positively affirm that such a config parameter is actually going to be usable for them | 12:11 |
danpb | as all this live migration tuning stuff ends up getting rather hypervisor driver specific imho | 12:12 |
garyk | danpb: i agree with you | 12:13 |
danpb | if you could comment on that review from vmware's pov that'd be helpful | 12:13 |
garyk | danpb: sure, will do | 12:13 |
*** aysyanne has joined #openstack-nova | 12:14 | |
*** amotoki_ has joined #openstack-nova | 12:19 | |
*** achanda has quit IRC | 12:20 | |
*** ildikov has joined #openstack-nova | 12:21 | |
*** raildo has joined #openstack-nova | 12:27 | |
*** ashishjain has joined #openstack-nova | 12:27 | |
*** mwagner_lap has joined #openstack-nova | 12:31 | |
*** dims has quit IRC | 12:31 | |
*** mwagner_lap is now known as mwagner | 12:31 | |
*** dims has joined #openstack-nova | 12:32 | |
*** dulek_ has quit IRC | 12:32 | |
*** emagana has joined #openstack-nova | 12:37 | |
*** eharney has quit IRC | 12:40 | |
*** lucas-hungry is now known as lucasagomes | 12:41 | |
*** emagana has quit IRC | 12:41 | |
*** annegentle has joined #openstack-nova | 12:41 | |
openstackgerrit | Bartosz Fic proposed openstack/nova: Rollback on destination host after deleting vm during live migration https://review.openstack.org/185958 | 12:42 |
*** matrohon has quit IRC | 12:44 | |
*** otter768 has joined #openstack-nova | 12:44 | |
*** kaisers has quit IRC | 12:45 | |
*** otter768 has quit IRC | 12:49 | |
*** josecastroleon has joined #openstack-nova | 12:49 | |
*** dguitarbite has quit IRC | 12:51 | |
openstackgerrit | Claudiu Belu proposed openstack/nova: Adds live resize task states and instance action https://review.openstack.org/184585 | 12:52 |
openstackgerrit | Claudiu Belu proposed openstack/nova: Adds instance live resize nova-api microversion https://review.openstack.org/184584 | 12:53 |
openstackgerrit | Claudiu Belu proposed openstack/nova: db: Adds live-resize to Migration model migration_type https://review.openstack.org/185961 | 12:53 |
openstackgerrit | Claudiu Belu proposed openstack/nova: objects: Adds live-resize to Migration object migration_type https://review.openstack.org/185962 | 12:53 |
*** ashishjain has quit IRC | 12:53 | |
*** ekarlso has quit IRC | 12:53 | |
*** ekarlso has joined #openstack-nova | 12:53 | |
openstackgerrit | Bartosz Fic proposed openstack/nova: Rollback on dest host after deleting vm during live migration https://review.openstack.org/185958 | 12:54 |
*** xyang1 has joined #openstack-nova | 12:56 | |
*** bfic has left #openstack-nova | 12:57 | |
*** dulek has joined #openstack-nova | 12:58 | |
*** abhishekk has joined #openstack-nova | 12:58 | |
*** fawadkhaliq has joined #openstack-nova | 13:00 | |
*** jecarey has joined #openstack-nova | 13:01 | |
openstackgerrit | Zhang Ni proposed openstack/nova-specs: improve nova attach volume api to support disk-bus The purpose of this spec is to add disk-bus paramter to nova attach volume api. https://review.openstack.org/185973 | 13:04 |
dims | garyk: anyway to tickle the CI for https://review.openstack.org/#/c/185830/? | 13:04 |
*** dboik has joined #openstack-nova | 13:05 | |
*** cknight has joined #openstack-nova | 13:06 | |
*** annegentle has quit IRC | 13:06 | |
*** kaufer has joined #openstack-nova | 13:06 | |
*** kaufer has quit IRC | 13:07 | |
garyk | dims: sadly we need to wait for ryan/sabari - it is a glance issue | 13:07 |
openstackgerrit | Zhang Ni proposed openstack/nova-specs: Improve nova attach volume api to support disk-bus https://review.openstack.org/185973 | 13:08 |
dims | garyk: how do we do this better next time? | 13:09 |
dims | we'll need oslo.vmware trunk run against glance and nova ? | 13:09 |
dims | in the NSX CI? | 13:09 |
garyk | dims: i do not think that it is specific to oslo.vmware it is the same issue for all libraries | 13:09 |
*** lpetrut has quit IRC | 13:10 | |
garyk | is it possible to change a tag name? | 13:10 |
garyk | if so we could create a version say oslo.vmware.proposed, we could then see if that works locally and if so then rename to 0.x | 13:11 |
dims | don't want to mess up pypi though | 13:12 |
garyk | ok | 13:15 |
*** abhishekk has quit IRC | 13:15 | |
garyk | i am terribly sorry for the mess. had it been last week you guys could have tarred and feathered us… | 13:17 |
*** salv-orl_ has quit IRC | 13:17 | |
*** mriedem_away is now known as mriedem | 13:17 | |
*** VW has joined #openstack-nova | 13:17 | |
garyk | i would suggest approving the patch by sabari to unblock the gate and we get the CI sorted in parallel | 13:18 |
mriedem | what's going on? | 13:19 |
mriedem | garyk: dims: so nova is the only user in the planet of oslo.vmware? | 13:20 |
danpb | am i right in thinking that nova.utils.instance_sys_meta is essentially useless now we can assume Instance objects everywhere | 13:20 |
garyk | mriedem: no, glance, cinder,… | 13:21 |
garyk | cinder ci is passing | 13:21 |
danpb | it seems like we could replace utils.instance_sys_meta(instance) with just instance.system_metadata everywhere | 13:21 |
danpb | unless there's a dark corner still using a dict instead of Instance object ?? | 13:21 |
*** kaufer has joined #openstack-nova | 13:21 | |
garyk | danpb: my guess would be that there are some tests that may need tweaking | 13:22 |
mriedem | garyk: glance is failing on the same VimFaultException stuff? | 13:22 |
garyk | mriedem: no. | 13:22 |
garyk | in the nova CI glance is not starting. hence we do not have a vote on this patch | 13:23 |
garyk | mriedem: that is some glance issue that we need to resolve | 13:23 |
garyk | but it is unrelated | 13:23 |
*** lpetrut has joined #openstack-nova | 13:23 | |
mriedem | garyk: how can you say that the 0.13.0 release of oslo.vmware isn't backwards incompatible? | 13:24 |
mriedem | it makes a thing that didn't fail before now fail bya change to the behaviour of the API | 13:24 |
garyk | mriedem: there is no change in the API | 13:24 |
garyk | the fact that nova was catching an exception that is different to the one returned is not a break in the API. | 13:24 |
mriedem | how so? | 13:25 |
mriedem | oslo.vmware used to return a VMwareDriverException | 13:25 |
garyk | did you look at the patch posted by sabari? | 13:25 |
mriedem | so clients would handle that | 13:25 |
garyk | mriedem: but clients did not handle that in the past | 13:25 |
mriedem | umm | 13:25 |
mriedem | apparently nova was | 13:25 |
*** matrohon has joined #openstack-nova | 13:25 | |
garyk | it was just to handle a specific case where one was trying to get some additional information about the root cause | 13:26 |
garyk | kind of trying to make debugging a little easier - but that would not have even helped if a later VC version was used | 13:27 |
mriedem | but...https://review.openstack.org/#/c/185830/2/nova/virt/vmwareapi/vm_util.py | 13:27 |
mriedem | that's still changing the runtime code to handle a different type of exception from the library | 13:28 |
mriedem | i don't see how that's not backwards incompatible | 13:28 |
*** busterswt has joined #openstack-nova | 13:28 | |
mriedem | any other client using oslo.vmware would have to make a similar change | 13:28 |
*** annegentle has joined #openstack-nova | 13:28 | |
mriedem | if they were catching VMwareDriverException | 13:28 |
garyk | mriedem: can you pleease show me where in the nova api we are actually catching that exception? | 13:29 |
mriedem | garyk: i'm not literally talking about nova "API" | 13:29 |
garyk | that exception was only being caught to see if there was a problem with the geust os being run | 13:29 |
mriedem | i'm talking about a contract with the library | 13:29 |
garyk | guest | 13:29 |
*** vladikr has joined #openstack-nova | 13:29 | |
*** eharney has joined #openstack-nova | 13:30 | |
mriedem | so i decided that i didn't like returning FooError from sqlahcmey-migrate when everyone was used to FooError, and i started raising BarError | 13:30 |
mriedem | that's a break in the contract of how the library behaves | 13:30 |
mriedem | w/o a deprecation cycle | 13:30 |
mriedem | *say i decided | 13:30 |
*** annegentle has quit IRC | 13:30 | |
*** oomichi has joined #openstack-nova | 13:31 | |
garyk | i disagree in this specific case. this code in nova was just to add information to try and help identify the error. | 13:31 |
*** emagana has joined #openstack-nova | 13:31 | |
garyk | it is not breaking any API | 13:31 |
*** sdake_ has joined #openstack-nova | 13:31 | |
mriedem | _wait_for_task was returning VMwareDriverException, now it returns VimFaultException | 13:31 |
mriedem | that's a contractual break imo | 13:32 |
mriedem | i'm not saying, 'this breaks the nova compute API for spawning instances' | 13:32 |
mriedem | you're taking my usage of 'API' too literally | 13:32 |
garyk | in the oslo api's this should have been VimFaultException | 13:33 |
mriedem | 'should have been' | 13:33 |
garyk | i think that it was a bug and the fact that nova used it was incorrect | 13:33 |
*** annegentle has joined #openstack-nova | 13:33 | |
mriedem | nova used what the library was providing | 13:33 |
garyk | that is a mistake in hindsight | 13:33 |
gilliard | mriedem: is your suggestion to roll back this specific change to oslo.vmware?? | 13:33 |
mriedem | http://specs.openstack.org/openstack/api-wg/guidelines/evaluating_api_changes.html#guidance | 13:33 |
mriedem | "A change such that a request which was successful before now results in an error response (unless the success reported previously was hiding an existing error condition)." | 13:33 |
mriedem | gilliard: yes | 13:34 |
gilliard | mriedem: and release a new version of it. | 13:34 |
lxsli | +1 | 13:34 |
mriedem | gilliard: https://review.openstack.org/#/c/185748/ and https://review.openstack.org/#/c/185744/ | 13:34 |
mriedem | revert the backwards incompatible change, release oslo.vmware 0.13.1 | 13:34 |
mriedem | block 0.13.0 in g-r | 13:34 |
mriedem | then have a deprecation cycle and redo the change the right way | 13:34 |
mriedem | rather than just dropping a thing and changing a 'should have been' this different error into something else, because we felt like it | 13:35 |
garyk | guys, have you read the code in vm_util? | 13:35 |
garyk | https://review.openstack.org/#/c/185830/2/nova/virt/vmwareapi/vm_util.py,cm | 13:35 |
garyk | the only thing that this does is log a warning | 13:35 |
*** emagana has quit IRC | 13:35 | |
mriedem | garyk: it doesn't matter | 13:35 |
garyk | now is that breaking an API? | 13:35 |
garyk | mriedem: it does | 13:35 |
garyk | the problem is the tests raising the wrong execption | 13:36 |
garyk | that is the problem | 13:36 |
mriedem | the tests were not raising the wrong exception before the oslo.vmware change | 13:36 |
mriedem | the tests were stubbing out oslo.vmware | 13:36 |
mriedem | and raising what it was before 0.13.0 | 13:36 |
garyk | not the fake tests | 13:36 |
lxsli | garyk: you're assuming we're the only consumer of oslo.vmware | 13:36 |
mriedem | https://review.openstack.org/#/c/185830/2/nova/tests/unit/virt/vmwareapi/fake.py | 13:36 |
lxsli | the impact on Nova is immaterial. What's important is that oslo.vmware released a backwards-incompatible version | 13:37 |
mriedem | honestly with the terrible state of the vmware driver tests i don't know which are mocks and which are stubbed and what fakes are being used and how far down into oslo.vmware we are stubbing things out when we shouldn't be | 13:37 |
garyk | mriedem: that is a bit of an exageration. when last did you try and write a test in the libvirt driver? | 13:37 |
mriedem | last week? | 13:37 |
garyk | :) | 13:37 |
garyk | use 'terrible' is not something which is characteristic of the driver especially when you were the one advocating the rewirte in the past cycle | 13:38 |
garyk | but lest move on. | 13:38 |
mriedem | let's say libvirt-python decided to return newLibvirtError instead of libvirtError, that'd be a backwards incompatible change from a library | 13:38 |
*** zz_jgrimm is now known as jgrimm | 13:38 | |
garyk | yes, there were cases when the exeptions there were changed. i can try and dig them up if you wish. i did not see you making a fuss then | 13:39 |
danpb | mriedem: yeah, we'd never do that | 13:41 |
danpb | but we do reserve the right to change the error codes we use for some certain scenarios | 13:41 |
*** links has quit IRC | 13:41 | |
danpb | which in theory can cause breakage if an app was looking for a specific error code | 13:41 |
mriedem | danpb: would you have a deprecation / warning cycle for that? | 13:42 |
danpb | nope | 13:42 |
danpb | generally this happens when we switch from the general VIR_ERR_INTERNAL_ERROR to a new error constant VIR_ERR_SOME_SPECIFIC_PROBLEM | 13:42 |
danpb | so apps generally like this | 13:42 |
mriedem | b/c it's more specific, i get that | 13:42 |
garyk | mriedem: i think that this could happen with any library | 13:42 |
mriedem | i agree that any library could break it's users, yes | 13:43 |
garyk | i have spun up a devstack installation with this latest oslo.vmware and it works. | 13:43 |
mriedem | until you hit the code path that the unit test is hitting | 13:43 |
garyk | the fact that we have a issue in our CI should not block this. that is my opinion | 13:43 |
mriedem | and then it doesn't work | 13:43 |
garyk | the problem with the CI at the moment is that the glance does not start | 13:44 |
*** apuimedo|away is now known as apuimedo | 13:44 | |
mriedem | which ci? | 13:44 |
garyk | nova CI for the vmware driver | 13:45 |
garyk | so we cannot get a vote on https://review.openstack.org/#/c/185830/ | 13:45 |
openstackgerrit | Radoslav Gerganov proposed openstack/nova: Consolidate the APIs for getting consoles https://review.openstack.org/148509 | 13:47 |
*** sdake has joined #openstack-nova | 13:47 | |
*** dave-mccowan has joined #openstack-nova | 13:48 | |
*** burt has joined #openstack-nova | 13:48 | |
*** _gryf|afk is now known as _gryf | 13:50 | |
*** sdake_ has quit IRC | 13:51 | |
gilliard | If j-random-library releases and breaks our CI, we work around it and move on. Honest Q: Why is olso.vmware get special in this regard? | 13:51 |
*** annegentle has quit IRC | 13:52 | |
*** annegentle has joined #openstack-nova | 13:53 | |
*** rook has joined #openstack-nova | 13:53 | |
garyk | mriedem: one way we could address this in the future is to have our oslo ci running to try and prevent issues like this. | 13:53 |
garyk | it may take a lot of work on our side | 13:53 |
openstackgerrit | Brent Eagles proposed openstack/nova-specs: VIF plug script support for Nova https://review.openstack.org/162468 | 13:54 |
*** amotoki_ has quit IRC | 13:54 | |
mriedem | gilliard: we have also black listed versions of libraries for backwards incompatible changes in the past | 13:55 |
mriedem | including oslo libraries | 13:55 |
mriedem | garyk: what's 'our ci'? vmware ci on oslo.vmware changes? | 13:55 |
mriedem | it's not going to hit that edge case as you pointed out anyway | 13:56 |
rgerganov | garyk: I think the oslo.vmware CI should use the patch under review instead of the pypi version when running tempest | 13:56 |
*** garloff_ has joined #openstack-nova | 13:56 | |
*** cbits has joined #openstack-nova | 13:56 | |
mriedem | oslo.vmware ci is not even testing the changes under review? | 13:56 |
*** cbits has left #openstack-nova | 13:57 | |
rgerganov | mriedem: let me check this | 13:57 |
garyk | mriedem: not sure i understand your last comment | 13:57 |
BobBall | danpb: None needed I think; we will abort the live migration if it's taking 'too long' but because it's an iterative process I'm not sure if there is a fixed upper limit | 13:57 |
rgerganov | mriedem: ok, it does test the patch under review but obviously it doesn't run Nova unit tests :) | 13:58 |
mriedem | rgerganov: no, and i wouldn't expect it to, it's a tempest run | 13:58 |
BobBall | danpb: Why are you thinking of adding a fixed upper limit? | 13:58 |
rgerganov | mriedem: right, sorry for the confusion | 13:58 |
mriedem | rgerganov: it was a review fail | 13:58 |
*** pradipta has joined #openstack-nova | 13:59 | |
*** garloff has quit IRC | 14:00 | |
danpb | BobBall: in libvirt / kvm we don't automatically abort migration that's taking too long | 14:00 |
danpb | BobBall: it is upto the app like nova to decide when/whether to abort it | 14:00 |
BobBall | Ah ok - what sort of limit are you thinking of? | 14:00 |
BobBall | or something based on flavor? | 14:00 |
danpb | so what i've proposed for libvirt/driver.py was a live_migration_completion_timeout= opt in nova.conf's [libvirt] group | 14:01 |
danpb | but some people thought it should be in the [default] group for other virt drivers to use | 14:01 |
BobBall | Let me just quickly check | 14:01 |
danpb | but i'm not convinced it will be generally used | 14:01 |
*** radek__ has quit IRC | 14:01 | |
*** radek__ has joined #openstack-nova | 14:02 | |
danpb | BobBall: this was the suggestion https://review.openstack.org/#/c/162254/4/nova/virt/libvirt/driver.py | 14:03 |
danpb | if you have comments from XenServer POV please add them | 14:03 |
BobBall | Will do. | 14:03 |
garyk | mdbooth: around | 14:03 |
openstackgerrit | Brent Eagles proposed openstack/nova-specs: VIF plug script support for Nova https://review.openstack.org/162468 | 14:04 |
mdbooth | garyk: I am | 14:04 |
lpetrut | Hi guys. I have a small question related to the way the nova compute manager handles lifecycle events | 14:05 |
garyk | mdbooth: wanted your two cents on the following https://review.openstack.org/#/c/185830/ - as you added the code that is breaking :) | 14:05 |
dims | holy cow, you guys have been busy :) garyk, mriedem, is there consensus? | 14:05 |
*** oomichi_ has joined #openstack-nova | 14:05 | |
*** ferest has joined #openstack-nova | 14:06 | |
dims | garyk: haha :) | 14:06 |
mdbooth | garyk: Impossible! ;) | 14:06 |
lpetrut | Shouldn't it ignore events when the instance has a pending task? | 14:06 |
mriedem | lpetrut: it does | 14:06 |
garyk | dims: i think that we are between a rock and a hard place. | 14:06 |
mriedem | if instance.task_state != None | 14:06 |
mriedem | lpetrut: see _sync_instance_power_state | 14:06 |
openstackgerrit | Brent Eagles proposed openstack/nova-specs: VIF plug script support for Nova https://review.openstack.org/162468 | 14:06 |
dims | johnthetubaguy: i got a volunteer for switching on the nova-docker job on nova reviews - https://review.openstack.org/#/c/185992/ | 14:07 |
garyk | dims: mriedem: the question is is there a contract broken. i think not and mriedem disagrees (which is legit) | 14:07 |
garyk | i have asked mdbooth what he thinks as he wrote that code | 14:07 |
dims | garyk: from a practical point of view, if we can fix the nova tests to work with both old and new oslo.vmware library, i'd be happy. but others may not agree | 14:08 |
*** ferest has quit IRC | 14:08 | |
mdbooth | What's the relationship between VMwareDriverException and VimFaultException? | 14:08 |
garyk | dims that can certainly work | 14:08 |
*** tonytan4ever has joined #openstack-nova | 14:09 | |
*** oomichi has quit IRC | 14:09 | |
dims | mdbooth: different hierarchy from what i recall | 14:09 |
mdbooth | IIRC, this is basically passing on an exception raised by vsphere | 14:09 |
lpetrut | mriedem: you're right. now that's odd. Basically, I'm trying to add an event listener to the Hyper-V driver as used by the Libvirt Driver. The issue is that when an instance is destroyed, the instance is stopped. The event listener emits the power off event, calls the stop API and then I get this: http://paste.openstack.org/show/240003/ | 14:09 |
lpetrut | I get this UnexpectedDeletingTaskStateError | 14:10 |
mdbooth | garyk: I seemed to be quite clear when I wrote it that the exception raised was a VMwareDriverException | 14:10 |
garyk | mdbooth: yes, that is correct - we are now passing the Vim exception instead of using the VMwareDriverException | 14:10 |
mdbooth | It's possible I was wrong about that | 14:11 |
garyk | in Nova we could check for both and that will resolve the issue | 14:11 |
garyk | mdbooth: we have all learnt a lot over the last few years. | 14:11 |
mdbooth | TBH, it *is* a vim exception | 14:11 |
mdbooth | So if the library has changed to make it a vim exception, then that seems like a good idea | 14:12 |
garyk | mdbooth: thanks | 14:12 |
lxsli | the question isn't whether it's a good idea | 14:12 |
garyk | mriedem: ^^ | 14:12 |
*** READ10 has joined #openstack-nova | 14:12 | |
mdbooth | It's not as if we don't control the users of oslo.vmware | 14:12 |
mriedem | mdbooth: do you? | 14:12 |
lxsli | it's whether it should have gone through a deprecation cycle before making an incompatible change to a client-facing exception | 14:12 |
garyk | mriedem: we can extend the exception hadnling to handle both exception if you wnat | 14:12 |
mdbooth | mriedem: I agree with you that it indicates a change in behaviour of the oslo.vmware library | 14:13 |
mriedem | can VimFaultException extend VMwareDriverException in the library? | 14:13 |
mdbooth | I'm not sure I'm bothered about that, though | 14:13 |
mdbooth | But I'll leave that discussion to others :) | 14:13 |
*** vladikr has quit IRC | 14:14 | |
garyk | mriedem: what about we have vm_util do: | 14:14 |
*** popw has quit IRC | 14:14 | |
gilliard | mriedem: That would be a good idea. | 14:14 |
garyk | except (vexc.VimFaultException, vexc.VMwareDriverException) | 14:14 |
*** vladikr has joined #openstack-nova | 14:14 | |
garyk | then we can depreacte that in L | 14:15 |
*** tobe has quit IRC | 14:15 | |
mriedem | lpetrut: you'd need debug logging on to see what all of the vm/task/power states are when _sync_instance_power_state runs | 14:15 |
garyk | does that work for you? | 14:15 |
mriedem | lpetrut: that code is racy so i wouldn't be surprised if you're hitting something - the stack trace at least doesn't blow anything up, but it's ugly | 14:15 |
mriedem | garyk: can VimFaultException extend VMwareDriverException in the library? | 14:15 |
*** oomichi has joined #openstack-nova | 14:16 | |
mriedem | garyk: nova handling both is only marginally better than what's the solution proposed now | 14:16 |
garyk | mriedem: it would require a change. i would actually have it the other way around | 14:16 |
lpetrut | mriedem: got it, thanks! | 14:16 |
mriedem | garyk: i know you would, but the other way around doesn't fix the compat issue | 14:16 |
mriedem | honestly at this point i'm not sure how much i care | 14:17 |
garyk | in pracical terms the only issue is a message being logged | 14:17 |
*** annegentle has quit IRC | 14:17 | |
mriedem | garyk: again, in this one little nova case | 14:17 |
kashyap | Is this reasonably up2date? - https://wiki.openstack.org/wiki/BlockDeviceConfig | 14:17 |
mriedem | there is a bigger picture | 14:17 |
*** leopoldj has quit IRC | 14:17 | |
garyk | in an ideal world there is a bigger picture, but in our little openstack world this is the only case | 14:18 |
mriedem | kashyap: no idea, looks like it was written in havana so probably now, i'd ask ndipanov | 14:18 |
*** oomichi_ has quit IRC | 14:18 | |
mriedem | kashyap: stuff like that should live in the devref so it can be updated with the code | 14:18 |
mriedem | *probably not | 14:18 |
kashyap | mriedem: No worries, I'll refer code or unit tests to see the exact behavior. | 14:18 |
kashyap | And, yes - I think more and more such docs are being submitted as part of devref. Maybe should be submitted there too. | 14:19 |
mriedem | kashyap: we should actually probably have big warnings at the tops of those old design wikis (before spec reviews) saying 'this may be way out of date by now, check the code' | 14:19 |
*** artom has joined #openstack-nova | 14:20 | |
kashyap | Yep | 14:23 |
ndipanov | kashyap, resonably - I think so | 14:24 |
ndipanov | but could be improved for sure | 14:24 |
*** kiran-r has quit IRC | 14:25 | |
*** kiran-r has joined #openstack-nova | 14:25 | |
*** ashishjain has joined #openstack-nova | 14:25 | |
mriedem | kashyap: i added a note at the top of the page | 14:27 |
kashyap | ndipanov: Which doc doesn't couldn't use more love :-) . mriedem: Thanks! | 14:27 |
kashyap | s/doesn't couldn't/couldn't/ | 14:27 |
*** moshele_ has joined #openstack-nova | 14:29 | |
*** moshele has quit IRC | 14:29 | |
openstackgerrit | Alex Xu proposed openstack/nova-specs: Correct resource name for consolidate console API https://review.openstack.org/185844 | 14:29 |
*** bnemec has quit IRC | 14:30 | |
*** thangp has joined #openstack-nova | 14:30 | |
*** claudiub has quit IRC | 14:31 | |
*** kiran-r has quit IRC | 14:32 | |
*** annegentle has joined #openstack-nova | 14:32 | |
*** ashishjain has quit IRC | 14:32 | |
*** mestery has quit IRC | 14:33 | |
*** mtanino has joined #openstack-nova | 14:33 | |
*** mestery has joined #openstack-nova | 14:34 | |
*** bnemec has joined #openstack-nova | 14:35 | |
*** dims has quit IRC | 14:35 | |
*** nelsnelson has quit IRC | 14:38 | |
*** achanda has joined #openstack-nova | 14:40 | |
*** emagana has joined #openstack-nova | 14:40 | |
*** dulek has quit IRC | 14:41 | |
bauzas | danpb: around ? while working on providing a to_dict, I'm seeing some bugs with your patch | 14:41 |
*** eharney has quit IRC | 14:42 | |
bauzas | danpb: do you prefer me giving you reviews, or me providing a new patchset ? | 14:42 |
bauzas | danpb: eg. https://review.openstack.org/#/c/76234/35/nova/objects/image_meta.py,cm L413 needs to be changed to getattr(self, name) | 14:43 |
danpb | since the rest of my series is merged i'm fine if you wnat to just upload the new patch | 14:43 |
danpb | i can easily pull it back down to my workspace now | 14:43 |
bauzas | danpb: okay | 14:43 |
danpb | perhaps put comments inline in the current patch though to show what you're changing | 14:43 |
bauzas | danpb: ackl | 14:44 |
*** salv-orlando has joined #openstack-nova | 14:45 | |
*** cfriesen has joined #openstack-nova | 14:45 | |
*** otter768 has joined #openstack-nova | 14:45 | |
*** electrocucaracha has joined #openstack-nova | 14:46 | |
alex_xu | jogo: hi, are you around? Just want to ask whether you mean the propose of custom cpu feature and cpu model is too complex? sorry, I didn't catch up at summit, the discussion is too fast for me. Thanks for if you can give me short explain! | 14:46 |
*** otter768 has quit IRC | 14:50 | |
*** hemnafk is now known as hemna | 14:50 | |
*** patrickeast has joined #openstack-nova | 14:51 | |
*** achanda has quit IRC | 14:52 | |
*** nelsnelson has joined #openstack-nova | 14:53 | |
*** Kennan has quit IRC | 14:55 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Rewrite nova.tests.network.test_manager.AllocateTestCase https://review.openstack.org/185860 | 14:55 |
*** amotoki_ has joined #openstack-nova | 14:55 | |
*** dims_ has joined #openstack-nova | 14:55 | |
*** Kennan has joined #openstack-nova | 14:56 | |
kashyap | How do I find what is the swap drive size allowed for a given instance type/flavor? | 14:58 |
mriedem | kashyap: http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/flavors.py#n82 ? | 14:58 |
mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/objects/flavor.py#n41 | 14:59 |
mriedem | instance.flavor.swap | 14:59 |
*** gokrokve has joined #openstack-nova | 14:59 | |
kashyap | Hmm, I invoked an instance this way: | 14:59 |
kashyap | $ nova boot --flavor 2 --block-device source=image,id=4955be94-9af4-44f2-8803-8eb362796037,dest=volume,size=2,shutdown=PRESERVE,bootindex=0 vm1 --swap 512 | 14:59 |
*** amotoki_ has quit IRC | 15:00 | |
*** claudiub has joined #openstack-nova | 15:00 | |
kashyap | And, I get the exception thrown by this part of the code from compute/api.py: | 15:00 |
kashyap | 1276 if swap_size > instance_type['swap']: | 15:00 |
kashyap | 1277 raise exception.InvalidBDMSwapSize() | 15:00 |
mriedem | so, swap_size is 512, what's the swap value for flavor 2? | 15:00 |
*** salv-orlando has quit IRC | 15:00 | |
*** Hosam has joined #openstack-nova | 15:01 | |
kashyap | Trying to look up, I haven't done any tests before with "--swap" | 15:01 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: libvirt: make default_device_names DRY-er https://review.openstack.org/180636 | 15:01 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: virt: add get_device_name_for_instance to the base driver class https://review.openstack.org/180637 | 15:01 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: libvirt: implement get_device_name_for_instance https://review.openstack.org/180638 | 15:01 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: virt: Move building the block_device_info dict into a method https://review.openstack.org/180635 | 15:01 |
*** armax has joined #openstack-nova | 15:01 | |
openstackgerrit | garyk proposed openstack/nova: VMware: Fix base exceptions changed in oslo.vmware 0.13.0 https://review.openstack.org/185830 | 15:02 |
garyk | mriedem: ^ | 15:02 |
kashyap | Hmm, I don't see any "Swap" value when I invoke `nova flavor-list`, w/ Nova from current git. | 15:03 |
*** tsekiyama has joined #openstack-nova | 15:04 | |
bauzas | danpb: left a few comments on https://review.openstack.org/#/c/76234/35, will see if I have time to work on delivering a new patchset | 15:04 |
* kashyap updates flavor properties. | 15:04 | |
mriedem | kashyap: nova flavor-show 2 ? | 15:04 |
kashyap | mriedem: Already did that - nothing is enumerated there. | 15:05 |
mriedem | kashyap: v2 api doesn't show swap in the view builder | 15:05 |
mriedem | v2.1 api does | 15:05 |
kashyap | Yeah, so I read from an old bug comment. | 15:06 |
mriedem | is the bug marked won't fix? | 15:06 |
mriedem | since we probably aren't going to change the v2 api for that | 15:06 |
openstackgerrit | Mikhail Feoktistov proposed openstack/nova: libvirt: virtuozzo instance resize support https://review.openstack.org/182257 | 15:06 |
*** apuimedo has quit IRC | 15:06 | |
*** dprince has quit IRC | 15:07 | |
kashyap | mriedem: Yeah - https://bugs.launchpad.net/nova/+bug/1354546 | 15:07 |
openstack | Launchpad bug 1354546 in OpenStack Compute (nova) "nova flavor-list does not show swap value" [Undecided,Invalid] - Assigned to Takashi Sogabe (sogabe) | 15:07 |
mriedem | kashyap: thanks, added some notes in there | 15:09 |
openstackgerrit | garyk proposed openstack/nova: VMware: Fix base exceptions changed in oslo.vmware 0.13.0 https://review.openstack.org/185830 | 15:09 |
garyk | mriedem: take two ^ | 15:10 |
*** ddaskal has joined #openstack-nova | 15:10 | |
mriedem | kashyap: from reading the novaclient code, if you specify --swap with a bdm it sets the guest_format in the bdm dict to 'swap' and sets the volume_size to the --swap value | 15:11 |
kashyap | mriedem: Oh, that's not helpful, is it? | 15:12 |
mriedem | well, it adds a swap bdm | 15:12 |
mriedem | so i think you end up with 2 bdms? | 15:13 |
*** rajesht has quit IRC | 15:14 | |
* kashyap is still testing | 15:14 | |
*** pbrooko has quit IRC | 15:14 | |
*** tobe has joined #openstack-nova | 15:15 | |
ndipanov | mriedem, related https://review.openstack.org/#/c/83516/ | 15:19 |
*** dulek_home has joined #openstack-nova | 15:20 | |
*** tobe has quit IRC | 15:20 | |
*** sahid has quit IRC | 15:21 | |
kashyap | ndipanov: Do you know if the CLI I posted above is valid? | 15:22 |
kashyap | Specifying "--block-device" and "--swap" together w/ one of the default flavors, this is testing from current Nova git. | 15:23 |
*** claudiub has quit IRC | 15:23 | |
openstackgerrit | Mikhail Feoktistov proposed openstack/nova: libvirt: virtuozzo instance resize support https://review.openstack.org/182257 | 15:24 |
mriedem | kashyap: yeah according to the novaclient code it's valid | 15:24 |
*** nelsnelson has quit IRC | 15:24 | |
ndipanov | kashyap, I think so but you need to check the swap value in flavor | 15:25 |
mriedem | like i said, it creates a 2nd bdm dict for the swap device | 15:25 |
ndipanov | mriedem, it doesn't now | 15:25 |
kashyap | Even a simple boot with "swap" disk doesn't work either? - nova boot --config-drive false --flavor 1234 --swap 512 --key_name oskey1 --image cirros-0.3.3-x86_64-disk cirrvm1 | 15:25 |
ndipanov | not without the patch I just linked | 15:25 |
mriedem | ndipanov: oh | 15:25 |
*** dprince has joined #openstack-nova | 15:25 | |
mriedem | well, novaclient sends the thing - it's entirely different if nova works with that or not :) | 15:25 |
mriedem | from the amazon docs it sounds like you use swap volumes with smaller flavors | 15:25 |
*** wwriverrat has joined #openstack-nova | 15:26 | |
*** Murali has quit IRC | 15:26 | |
ndipanov | ah no if it sends it then it will be there | 15:26 |
ndipanov | sorry you are right | 15:26 |
ndipanov | mriedem, ^ | 15:26 |
* kashyap creates a flavor with swap: `nova flavor-create flav-with-swap 1234 512 10 1 --swap 512 --is-public true` and boots an instance with it. | 15:26 | |
kashyap | ndipanov: mriedem: Why I'm trying this, noticed this bug and thought I'd see if I can reproduce it at all - https://bugs.launchpad.net/nova/+bug/1457527 | 15:27 |
openstack | Launchpad bug 1457527 in OpenStack Compute (nova) "Image-cache deleting active swap backing images" [Critical,In progress] - Assigned to Michael Still (mikalstill) | 15:27 |
*** gokrokve has quit IRC | 15:27 | |
ndipanov | ah y es mikal mentioned that one earlier it's on my list of things to look into today | 15:27 |
*** gokrokve has joined #openstack-nova | 15:28 | |
*** tsekiyama has quit IRC | 15:28 | |
kashyap | Yep, my latter test works: | 15:28 |
kashyap | $ sudo virsh domblklist 3 | 15:28 |
kashyap | Target Source | 15:28 |
kashyap | ------------------------------------------------ | 15:28 |
kashyap | vda /home/kashyapc/src/cloud/data/nova/instances/92e6e003-a3da-4c2f-8c18-752706d8ef49/disk | 15:28 |
kashyap | vdb /home/kashyapc/src/cloud/data/nova/instances/92e6e003-a3da-4c2f-8c18-752706d8ef49/disk.swap | 15:28 |
ndipanov | kashyap, yeah - flavor swap will limit you on the size | 15:28 |
ndipanov | that's a feature | 15:28 |
*** tsekiyama1 has joined #openstack-nova | 15:28 | |
kashyap | ndipanov: Oh, okay. I was only curious, as it involves backing chains and I usually test them at libvirt/QEMU layer from git. | 15:29 |
*** romainh has left #openstack-nova | 15:30 | |
kashyap | ndipanov: Noted, thanks for furthering my education :-) | 15:30 |
kashyap | mriedem: Thanks for the hint to look at the client code, learnt a few things from the unit tests there. | 15:31 |
*** marun has joined #openstack-nova | 15:31 | |
*** eharney has joined #openstack-nova | 15:32 | |
*** gokrokve has quit IRC | 15:32 | |
*** claudiub has joined #openstack-nova | 15:37 | |
ndipanov | kashyap, I will look at that bug now | 15:38 |
ndipanov | and also link the other patch I mentioned there as well | 15:38 |
kashyap | ndipanov: Sure. | 15:39 |
*** VW has quit IRC | 15:39 | |
*** browne has quit IRC | 15:39 | |
kashyap | ndipanov: Maybe I'm being dense, but I don't see an intuitive way to find what's the swap size associated w/ a flavor? (It's not enumerated when you do a 'flavor-show') | 15:39 |
ndipanov | kashyap, but iiuc the problem is not there when you pass --swap but when it's only given by flavor | 15:39 |
ndipanov | kashyap, select id, swap_mb from instance_type; | 15:40 |
*** VW has joined #openstack-nova | 15:40 | |
*** pbrooko has joined #openstack-nova | 15:40 | |
*** Nikolay_St has quit IRC | 15:42 | |
*** tsekiyam has joined #openstack-nova | 15:42 | |
*** gokrokve has joined #openstack-nova | 15:42 | |
*** tsekiyama1 has left #openstack-nova | 15:43 | |
*** Guest4835 is now known as beagles | 15:44 | |
*** penick has quit IRC | 15:45 | |
*** nelsnelson has joined #openstack-nova | 15:46 | |
*** annegentle has quit IRC | 15:47 | |
*** jwcroppe has quit IRC | 15:48 | |
*** jwcroppe has joined #openstack-nova | 15:48 | |
kashyap | ndipanov: This did it: select id, swap from instance_types; | 15:50 |
openstackgerrit | Alexis Lee proposed openstack/nova-specs: Purge soft deleted rows https://review.openstack.org/184637 | 15:50 |
kashyap | (It was 0 for all instances, by default. Hence it is not shown apparently.) | 15:50 |
ndipanov | kashyap, yeah potato potato | 15:50 |
*** Sukhdev has joined #openstack-nova | 15:50 | |
kashyap | :-) | 15:50 |
kashyap | So, I can't dynamically provide a swap size as opposed to the flavor swap feature? | 15:51 |
*** lpetrut has quit IRC | 15:52 | |
*** lpetrut has joined #openstack-nova | 15:52 | |
*** lifeless_ is now known as lifeless | 15:53 | |
ndipanov | kashyap, you can but not larger than what's there | 15:54 |
*** barra204 has quit IRC | 15:54 | |
ndipanov | which actually makes it kinda useless... :/ | 15:54 |
kashyap | Hmm, /me didn't wanted to say that out loud | 15:55 |
*** amotoki_ has joined #openstack-nova | 15:56 | |
*** pbrooko_ has joined #openstack-nova | 15:58 | |
*** alanf-mc has joined #openstack-nova | 15:59 | |
*** jwcroppe has quit IRC | 15:59 | |
*** baoli has quit IRC | 16:00 | |
*** emagana has quit IRC | 16:00 | |
*** pbrooko has quit IRC | 16:00 | |
*** yamahata has quit IRC | 16:00 | |
*** ildikov has quit IRC | 16:01 | |
*** yamahata has joined #openstack-nova | 16:01 | |
*** amotoki_ has quit IRC | 16:01 | |
*** baoli_ has joined #openstack-nova | 16:02 | |
*** emagana has joined #openstack-nova | 16:02 | |
*** matrohon has quit IRC | 16:02 | |
*** oomichi has quit IRC | 16:06 | |
*** jistr has quit IRC | 16:07 | |
*** alanf-mc_ has joined #openstack-nova | 16:09 | |
*** mpavone has quit IRC | 16:10 | |
*** jlanoux has quit IRC | 16:10 | |
*** alanf-mc_ has quit IRC | 16:11 | |
*** alanf-mc has quit IRC | 16:11 | |
*** alanf-mc has joined #openstack-nova | 16:12 | |
*** unicell1 has quit IRC | 16:12 | |
*** dsanders has joined #openstack-nova | 16:13 | |
*** jogo has quit IRC | 16:13 | |
*** alex_klimov has quit IRC | 16:15 | |
*** jogo has joined #openstack-nova | 16:17 | |
*** achanda has joined #openstack-nova | 16:17 | |
*** browne has joined #openstack-nova | 16:17 | |
openstackgerrit | Brent Eagles proposed openstack/nova: WIP: Add support for VIF plugin script to Nova https://review.openstack.org/162470 | 16:18 |
*** gokrokve has quit IRC | 16:19 | |
*** moshele_ has quit IRC | 16:19 | |
*** gokrokve has joined #openstack-nova | 16:19 | |
openstackgerrit | Petrut Lucian proposed openstack/nova: Hyper-V: Implement nova rescue https://review.openstack.org/127159 | 16:20 |
*** derekh_ has joined #openstack-nova | 16:21 | |
*** gokrokve has quit IRC | 16:21 | |
beagles | dansmith: can you take a look at https://review.openstack.org/#/c/167287/ when you get a sec to see if I'm on the right track, what I'm missing, etc? If your swamped, can you recommend someone else I can ping? | 16:22 |
*** vilobhmm has joined #openstack-nova | 16:22 | |
mriedem | beagles: he's out until tomorrow | 16:22 |
mriedem | vacation | 16:22 |
*** lpetrut has quit IRC | 16:23 | |
* beagles facepalm ... | 16:23 | |
beagles | okay | 16:23 |
mriedem | way2go! | 16:23 |
beagles | I'll retreat into my own little world :) | 16:23 |
*** destiny has quit IRC | 16:24 | |
*** claudiub has quit IRC | 16:24 | |
*** pkoniszewski has joined #openstack-nova | 16:25 | |
*** derekh has quit IRC | 16:25 | |
*** pboldin has joined #openstack-nova | 16:28 | |
*** tjones1 has joined #openstack-nova | 16:28 | |
*** pboldin has left #openstack-nova | 16:29 | |
*** ankit_ag has quit IRC | 16:29 | |
*** fawadkhaliq has quit IRC | 16:30 | |
*** haypo has quit IRC | 16:31 | |
*** pbrooko_ has quit IRC | 16:31 | |
garyk | johnthetubaguy: mriedem: https://review.openstack.org/#/c/185830/ has VMware CI +1 | 16:31 |
garyk | Can we get this approved to unblock the gate if possible. | 16:31 |
mriedem | putting out other fires atm | 16:32 |
garyk | ack | 16:32 |
garyk | ndipanov: danpb: any chance you guys can please look at https://review.openstack.org/#/c/185830/ | 16:32 |
garyk | this will unblock the gate | 16:32 |
openstackgerrit | Brent Eagles proposed openstack/nova: WIP: Add support for VIF plugin script to Nova https://review.openstack.org/162470 | 16:35 |
danpb | garyk: i +2d on the basis that vmware ci passed | 16:35 |
garyk | danpb: thanks | 16:36 |
ndipanov | garyk, I kind of agree with mriedem - why are we not fixing oslo.vmware? | 16:36 |
garyk | ndipanov: the problem is not oslo.vmware it is nova | 16:36 |
ndipanov | how so? | 16:36 |
garyk | we were raisning the wrong exception | 16:37 |
ndipanov | in tests? | 16:37 |
garyk | in nova we were catching the wrong exception - due to misunderstanding, noyt good enough docs, | 16:37 |
johnthetubaguy | garyk: hey, I think its looking close now, just worried a bit about adding an extra comment and some more testing | 16:37 |
garyk | the only purpose of that code in nova was to log a warning for the admin | 16:37 |
mriedem | oslo.vmware raised A, nova caught A. oslo.vmware changed A to B, nova was catching A, kaboom | 16:37 |
mriedem | so their solution now is catch A and B | 16:38 |
garyk | mriedem: it is not kaboom | 16:38 |
mriedem | for older and latest versions of oslo.vmware | 16:38 |
ndipanov | yeah let me stay out of this - I really agree with mriedem though - oslo.vmware should not have done this | 16:38 |
mriedem | garyk: i'm not sure what your definition of kaboom is then | 16:38 |
garyk | that is making a mountain out or an antjill - we are going in a loop now | 16:38 |
ndipanov | they should revert the change and do a release | 16:38 |
mriedem | i blame ndipanov for being late to the party | 16:38 |
mriedem | ndipanov: that's what i had originally proposed but -1s all over | 16:38 |
mriedem | https://review.openstack.org/#/c/185744/ | 16:38 |
mriedem | https://review.openstack.org/#/c/185748/ | 16:39 |
ndipanov | and we should only block that version in the requirements | 16:39 |
mriedem | anyway, reviewing the nova workaorund now | 16:39 |
mriedem | ndipanov: yeah, see ^ :) | 16:39 |
ndipanov | yeah I'm 100% with you on this | 16:39 |
dims_ | mriedem: hey, come back to #oslo and work on the kazoo stuff :) | 16:39 |
ndipanov | you can't do that, and if you do and break ppl you should fix it | 16:39 |
garyk | i disagree. | 16:40 |
ndipanov | but whatever | 16:40 |
ndipanov | garyk, how so | 16:40 |
mriedem | dims_: yes i also need lunch at some point here | 16:40 |
dims_ | mriedem: haha :) | 16:40 |
ndipanov | you can't change a publicly visible exception in a non major update | 16:40 |
ndipanov | period | 16:40 |
garyk | the reasons are explained in the -1 | 16:41 |
garyk | guys the only change is a warning being logged. seriously | 16:41 |
johnthetubaguy | ndipanov: mriedem: so my take is we merge the support for both exceptions, while we have the debate about reverting the API break in oslo.vmware, so the debate is less heated, but I duno, maybe thats the wrong way around | 16:41 |
garyk | even matt who wrote it said that it is wrong | 16:41 |
ndipanov | yeah not really important I guess | 16:41 |
ndipanov | merge the fix in Nova | 16:41 |
mriedem | garyk: but you understand that's not a very solid argument right? | 16:41 |
ndipanov | but don't try to argue how it's "better" - it's not | 16:42 |
garyk | mriedem: i think that at times you need to be pragmatic and see things as they are | 16:42 |
mriedem | just because i only killed one puppy and not 20 doesn't make it less wrong | 16:42 |
ndipanov | better is not breaking publicly visible contracts in minor revisions of a library | 16:42 |
garyk | we should not break api's | 16:42 |
ndipanov | absolutely not | 16:42 |
garyk | is this an api? not 100% sure. | 16:42 |
mriedem | garyk: this is not a REST API | 16:42 |
danpb | the thing is that with exceptions, if you take that argument to its conclusion | 16:42 |
ndipanov | the fact that it happens all the time is a different story | 16:42 |
mriedem | API does not necessarily mean REST API | 16:42 |
danpb | you can't ever change anything about any exception you raise | 16:42 |
*** unicell has joined #openstack-nova | 16:42 | |
ndipanov | EVA! | 16:42 |
mriedem | garyk: a contract with a library is also an API | 16:43 |
danpb | i think that's untenable as a position in general even if the modules aims to provide API compat | 16:43 |
mriedem | which you shouldn't break w/o major version updates per semver | 16:43 |
danpb | its unfortunate Nova broke when a new exception became possible to be thrown | 16:43 |
garyk | mriedem: so why does nova break every few months with the ec2 boto library | 16:43 |
danpb | but i don't think it is entirely unreasonable for oslo.vmware to have done that | 16:43 |
mriedem | b/c boto sucks and we're trying to move ec2 out of tree | 16:43 |
garyk | i am sure that a few guys at amazon may disagree... | 16:44 |
danpb | if nova wanted to be more robust it could have catch a more general exception rather than the specific exception subclass that particular version of oslo happened to be raising | 16:44 |
garyk | danpb: agree | 16:44 |
danpb | so just fix the exception catching in nova and move on | 16:44 |
johnthetubaguy | dims_: do we define what the oslo API is already? | 16:44 |
dhellmann | johnthetubaguy: we do normally include exceptions in the API definition | 16:45 |
garyk | danpb: that is what has been done | 16:45 |
danpb | garyk: yep, and i agre with that | 16:46 |
mriedem | garyk: i'm still -1 on the deprecation todo in the code, it doesn't make sense to me | 16:46 |
*** otter768 has joined #openstack-nova | 16:46 | |
johnthetubaguy | mriedem: if we bump the min supported version of the lib, we could drop the extra bit I guess right? | 16:46 |
garyk | i'll look at the comments and address | 16:46 |
mriedem | johnthetubaguy: http://git.openstack.org/cgit/openstack/oslo.vmware/tree/oslo_vmware/exceptions.py#n126 | 16:47 |
johnthetubaguy | mriedem: its was assuming its not raised on that code patch any more | 16:48 |
*** dulek has joined #openstack-nova | 16:48 | |
mriedem | while the library still defines a VMwareDriverException type, it makes 0 sense to me for nova to be saying 'we're going to deprecate the usage of this thing that we have 0 control over' | 16:48 |
*** ssurana has joined #openstack-nova | 16:48 | |
johnthetubaguy | garyk: maybe the real think here is just to do the log message for all exceptions? | 16:48 |
*** annegentle has joined #openstack-nova | 16:48 | |
*** nic has joined #openstack-nova | 16:48 | |
*** timsim has joined #openstack-nova | 16:48 | |
garyk | mriedem: the exception handling in nova is incorrect. the VIM exception is what is raised by the VC and this should be treated. Not a exception the other exception. but we are going in circles. | 16:48 |
garyk | johnthetubaguy: i am fine with that | 16:49 |
johnthetubaguy | mriedem: agreed they broke the API though, even if its kinda only a soft squishy bit | 16:49 |
*** lpetrut has joined #openstack-nova | 16:50 | |
johnthetubaguy | honestly, I would have expected exception inheritence to have been added to isolate users from such changes, or not bother making the change, but I am not sure what the general oslo policy is there | 16:50 |
mriedem | garyk: then the deprecation is not 'M', it's whenever nova requires oslo.vmware>=0.13.0 | 16:50 |
dhellmann | johnthetubaguy, garyk : we are supposed to avoid breaks like this | 16:50 |
*** yamahata has quit IRC | 16:51 | |
johnthetubaguy | dhellmann: right, thats what I thought was true too, see: https://review.openstack.org/#/c/185744/ | 16:51 |
dhellmann | johnthetubaguy: I just voted +2 on that | 16:51 |
johnthetubaguy | oh wait, i see you commented there, thanks | 16:51 |
johnthetubaguy | cool | 16:51 |
*** otter768 has quit IRC | 16:51 | |
garyk | dhellmann: i would agree if the calling code was catching the correct exception | 16:51 |
johnthetubaguy | dhellmann: I guess we then exclude the bad version in global deps, I guess someone mentioned that already? | 16:52 |
dhellmann | garyk: it makes no difference, we've changed the behavior in a way that broke something. We need to find a way to fix that behavior without breaking existing callers. | 16:52 |
vilobhmm | johnthetubaguy : hey john….as discussed in the Nova unconference session at the Summit …I have updated the doc impact section with the summary of the migration plan and release plan with new Tooz drivers….can you have a look at the spec https://review.openstack.org/#/c/138607/ | 16:52 |
*** alanf-mc has quit IRC | 16:52 | |
mriedem | dhellmann: also https://review.openstack.org/#/c/185748/ | 16:52 |
dims_ | dhellmann: agree in principle. wanted to see if there was a way forward given the team feels that it's the right way forward | 16:52 |
vilobhmm | johnthetubaguy : ^^ | 16:52 |
garyk | dhellmann: you guys can override the -1 for the requirements | 16:52 |
ndipanov | danpb, fwiw - the only more specific thing than VMwareDriverException is Exception | 16:52 |
ndipanov | so really nova could not have done anything else afaict | 16:52 |
ndipanov | (other than catch Exception - bad) | 16:53 |
dims_ | dhellmann: i'd have leaned towards the immediate revert if the runtime was affected | 16:53 |
ndipanov | and it broke | 16:53 |
ndipanov | but whatevs | 16:53 |
dims_ | ndipanov: remember this code was in nova and then we are trying to fix it slowly | 16:53 |
johnthetubaguy | ndipanov: so I guess the new exception could have just inherited from the less specific one right, and we are done? | 16:53 |
*** alanf-mc has joined #openstack-nova | 16:53 | |
*** annegentle has quit IRC | 16:53 | |
johnthetubaguy | dims_: it should have been incubator then? | 16:53 |
*** emagana has quit IRC | 16:53 | |
dims_ | let's not open up that can of worms :) | 16:53 |
dhellmann | garyk: do you have a patch up to oslo.vmware to fix the class hierarchy for those exceptions or something, or are we going with the revert? | 16:54 |
mriedem | johnthetubaguy: i proposed that earlier but by definition they are supposed to inherit the other way around, i.e. VMwareDriverException extends from VimFaultException i guess | 16:54 |
ndipanov | yeah like I said - whatever - in this case it's prolly fine as we are not reverting a cleaner change | 16:54 |
ndipanov | but don't go and argue how it's right | 16:54 |
johnthetubaguy | mriedem: gotcha, missed that bit, sorry | 16:54 |
ndipanov | cause it ain't! | 16:54 |
dims_ | dhellmann: there's a patch to fix nova tests | 16:54 |
ndipanov | :) | 16:54 |
dims_ | that works with both old and new oslo.vmware versions | 16:54 |
dhellmann | dims_: ok, does cinder have a similar issue? | 16:54 |
mriedem | dhellmann: this is the nova change https://review.openstack.org/#/c/185830/ | 16:54 |
*** electrocucaracha has quit IRC | 16:54 | |
openstackgerrit | Thang Pham proposed openstack/nova: VMware: Add support for swap disk https://review.openstack.org/142174 | 16:55 |
dhellmann | mriedem: ok, whether or not that is right will depend some on how we fix things in oslo.vmware | 16:56 |
*** amotoki_ has joined #openstack-nova | 16:57 | |
garyk | i am heading home will be back online in about 45 minutes | 16:57 |
dims_ | dhellmann: haven't heard any issue from cinder | 16:57 |
garyk | dims_: there are no issues with cinder/glance | 16:57 |
dhellmann | dims_, garyk : ok, good | 16:58 |
garyk | only problem is the code in nova that logs a warning (which is not really that useful either) | 16:58 |
*** claudiub has joined #openstack-nova | 16:58 | |
garyk | the exception is still raised. | 16:58 |
garyk | kind of you try to boot a vm and nova gets into an error state | 16:58 |
garyk | the admin may have a warning in addition to the exception | 16:58 |
garyk | the fact that the fake unit test driver behaves differently is the bug... | 16:59 |
dims_ | garyk: either way we should have been more careful next time | 16:59 |
garyk | dims_: agree. but that is the same with all libraries. | 16:59 |
dhellmann | we may also want to move that fake into the library where we can keep it up to date with the API | 16:59 |
dims_ | in addition to NSX CI, we have to run unit tests in all the projects before release. lesson learnt | 16:59 |
garyk | dims_: when you make a library change do you test all of the porjcets units tests - no. | 16:59 |
garyk | dims_: agree - lesson learnt. not sure how to check this | 17:00 |
dims_ | dhellmann: y we cleaned up suds stuff, have to get fake stuff as well | 17:00 |
dhellmann | yep | 17:00 |
dhellmann | dims_, garyk : so, short term, what's the plan? revert the change and re-release oslo.vmware or block it in requirements and release a fixed version? | 17:01 |
dhellmann | or some other combination? | 17:01 |
*** amotoki_ has quit IRC | 17:01 | |
dims_ | dhellmann: there's a block in requirements https://review.openstack.org/#/c/185744/ but vacillating between that and https://review.openstack.org/#/c/185830/ | 17:03 |
*** hemna is now known as hemnafk | 17:03 | |
*** garyk has quit IRC | 17:04 | |
*** tobe has joined #openstack-nova | 17:04 | |
dims_ | dhellmann: one of us have to break the logjam | 17:04 |
*** gszasz has quit IRC | 17:05 | |
dhellmann | dims_: I vote for blocking this release for now, and then working with the nova team more closely on a fix when we're under less pressure | 17:05 |
*** danpb has quit IRC | 17:05 | |
johnthetubaguy | dhellmann: that sounds good, I don't mind landing the patch in Nova if thats quicker, but I prefer the blocking of the version for now, if thats easy enough | 17:06 |
johnthetubaguy | + dims_: ^ | 17:06 |
dhellmann | dims_: I approved the requirements block in https://review.openstack.org/#/c/185748/1 | 17:06 |
*** jwcroppe has joined #openstack-nova | 17:06 | |
dims_ | dhellmann: let's get that requirements block in that will unblock nova folks | 17:06 |
dims_ | we don't need to make a release or revert yet | 17:07 |
dhellmann | dims_: right, if there's a simple fix we can apply that and release 0.14 | 17:07 |
*** dboik has quit IRC | 17:07 | |
dims_ | johnthetubaguy: https://review.openstack.org/#/c/185830/ or https://review.openstack.org/#/c/185748/ should unblock you | 17:07 |
dims_ | dhellmann: we'll still need the g-r block of the "bad" version | 17:08 |
johnthetubaguy | dims_: sweet | 17:08 |
dims_ | so let's find someone to do that | 17:08 |
dhellmann | dims_: right, I approved the g-r block | 17:09 |
dhellmann | dims_: that's https://review.openstack.org/#/c/185748/ | 17:09 |
*** tobe has quit IRC | 17:09 | |
*** ijw has joined #openstack-nova | 17:09 | |
dims_ | thanks dhellmann | 17:09 |
*** rajesht has joined #openstack-nova | 17:10 | |
*** annegentle has joined #openstack-nova | 17:10 | |
dims_ | johnthetubaguy: do you want to wait for the ci job to propose the update or i can add a review | 17:10 |
mriedem | dims_: wait | 17:11 |
mriedem | it's not like we haven't waited long enough anyway | 17:11 |
dims_ | ack | 17:12 |
mriedem | meanwhile | 17:12 |
dhellmann | if we do that update by hand we can approve it and it should merge right after the g-r change | 17:12 |
*** dboik has joined #openstack-nova | 17:12 | |
johnthetubaguy | dims_: I was just going to say, mriedem has a good handle on this stuff, I will defer to him (including the fact I am about to sign off for the day) | 17:12 |
*** vilobhmm has quit IRC | 17:12 | |
*** ociuhandu has joined #openstack-nova | 17:12 | |
dims_ | dhellmann: was going to add a Depends-On | 17:12 |
*** pkoniszewski has quit IRC | 17:12 | |
dhellmann | dims_: right | 17:12 |
mriedem | dims_: we'd have to recheck anyway until the g-r change is merged | 17:12 |
mriedem | oh | 17:12 |
*** baoli_ has quit IRC | 17:12 | |
mriedem | that | 17:12 |
mriedem | go for it | 17:12 |
dhellmann | yeah, we can piggy-back right on that change | 17:12 |
johnthetubaguy | ah, depends-on, thats cool | 17:12 |
johnthetubaguy | I keep forgetting we have that | 17:13 |
*** annegentle has quit IRC | 17:13 | |
* mriedem goes back to the oslo channel to babysit tooz | 17:13 | |
*** vilobhmm has joined #openstack-nova | 17:13 | |
*** markus_z has quit IRC | 17:14 | |
*** sdake_ has joined #openstack-nova | 17:14 | |
*** rajesht has quit IRC | 17:14 | |
jogo | mriedem: you seem to be doing a lot of babysitting these days :) | 17:14 |
*** alanf-mc has quit IRC | 17:14 | |
mriedem | jogo: welcome | 17:15 |
mriedem | to hell | 17:15 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Block oslo.vmware 0.13.0 due to a backwards incompatible change https://review.openstack.org/186087 | 17:15 |
*** ijw has quit IRC | 17:15 | |
*** vilobhmm has quit IRC | 17:16 | |
*** alanf-mc has joined #openstack-nova | 17:16 | |
*** jfding has quit IRC | 17:16 | |
jogo | haha | 17:16 |
*** dboik has quit IRC | 17:16 | |
*** ijw has joined #openstack-nova | 17:16 | |
*** gokrokve has joined #openstack-nova | 17:17 | |
*** sdake has quit IRC | 17:17 | |
*** zzzeek has joined #openstack-nova | 17:18 | |
*** alanf-mc has quit IRC | 17:18 | |
*** alanf-mc has joined #openstack-nova | 17:20 | |
*** fawadkhaliq has joined #openstack-nova | 17:22 | |
*** krtaylor has quit IRC | 17:22 | |
dims_ | mriedem: jogo has seen the light :) | 17:23 |
*** lucasagomes is now known as lucas-dinner | 17:23 | |
*** yamahata has joined #openstack-nova | 17:23 | |
jogo | dims_: and the light isn't coming from hell | 17:24 |
dims_ | haha | 17:25 |
melwitt | some people are hitting a VersionConflict error installing novaclient because pbr required version ranges aren't meshing between novaclient and oslo libs https://bugs.launchpad.net/python-novaclient/+bug/1457100 | 17:26 |
openstack | Launchpad bug 1457100 in python-novaclient "pbr version conflict" [Undecided,Confirmed] | 17:26 |
*** baoli has joined #openstack-nova | 17:26 | |
melwitt | is there anything we usually do to stay in sync with pbr version requires? | 17:26 |
*** fawadkhaliq has quit IRC | 17:27 | |
dhellmann | melwitt: do you have a full traceback for that error? we've fixed a couple of other places by changing the way entry points are loaded | 17:28 |
melwitt | dhellmann: BobBall made a paste http://paste.openstack.org/show/239540/ | 17:28 |
dhellmann | melwitt: the global requirements syncs have happened, but we haven't released the related oslo libs yet. We have 2 other requirements-related issues in play right now, so it's probably best to wait on more releases if we can. | 17:28 |
* dhellmann notices the scrollbar on that bug report | 17:29 | |
dims_ | melwitt: dhellmann: they also probably have older oslo.config in their environment | 17:29 |
dims_ | melwitt: please bless https://review.openstack.org/#/c/186087/ so the nova unit tests can unblock quickly after the g-r and this review merges | 17:30 |
*** emagana has joined #openstack-nova | 17:31 | |
*** VW has quit IRC | 17:31 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Block oslo.vmware 0.13.0 due to a backwards incompatible change https://review.openstack.org/186087 | 17:32 |
mriedem | dims_: i added the bug reference | 17:32 |
dims_ | mriedem: ack thanks | 17:32 |
melwitt | mriedem: it's good to go now? | 17:32 |
*** kfox1111 has joined #openstack-nova | 17:33 | |
kfox1111 | Is there a way to boot a new instance already paused? | 17:33 |
mriedem | melwitt: yeah | 17:33 |
mriedem | melwitt: we're just expediting the g-r sync for this one | 17:33 |
mriedem | hence the depends-on tag | 17:33 |
*** busterswt has quit IRC | 17:34 | |
*** aix has quit IRC | 17:35 | |
*** vilobhmm has joined #openstack-nova | 17:35 | |
*** isd has joined #openstack-nova | 17:37 | |
*** vilobhmm has quit IRC | 17:38 | |
*** hemnafk is now known as hemna | 17:39 | |
*** ijw_ has joined #openstack-nova | 17:41 | |
dhellmann | melwitt: I'm working on a novaclient patch to fix up the requirements issue you're having, give me a few minutes | 17:43 |
*** sudipto has joined #openstack-nova | 17:44 | |
*** ijw has quit IRC | 17:44 | |
*** yassine_ has quit IRC | 17:44 | |
*** garyk has joined #openstack-nova | 17:45 | |
garyk | dhellmann: i have just arrived home | 17:45 |
melwitt | dhellmann: cool, though I don't yet understand why it won't install pbr==0.11.0 to fit both requirements | 17:45 |
garyk | not sure what the conclusion is. i would prefer making changes to nova | 17:46 |
dhellmann | melwitt: pip doesn't have a good requirements resolver yet | 17:46 |
*** ildikov has joined #openstack-nova | 17:46 | |
garyk | i think that is the healthier path to take | 17:46 |
garyk | dims_: dhellmann: what do you guys suggest? | 17:46 |
mriedem | melwitt: lifeless is working on the be all end all requirements resolver | 17:46 |
mriedem | and will put us all out of a job | 17:47 |
dhellmann | garyk: we have a patch in the queue to block 0.13 from g-r, and then we're going to regroup the oslo.vmware team to find a way to make the desired change there without breaking nova | 17:47 |
dims_ | garyk: g-r block is in progress. we should put out another release of oslo.vmware which does not immediately break nova upon release and we need to figure out what that should have (a revert or something else) | 17:47 |
*** vilobhmm has joined #openstack-nova | 17:48 | |
*** vilobhmm has quit IRC | 17:48 | |
*** vilobhmm has joined #openstack-nova | 17:49 | |
garyk | two options: | 17:49 |
garyk | 1. approve the requirement change | 17:49 |
*** dboik has joined #openstack-nova | 17:49 | |
garyk | 2. approve the nova change | 17:49 |
melwitt | mriedem: oh, oops. I didn't realize this problem was that | 17:49 |
mriedem | garyk: the requirements change is approved | 17:50 |
*** emagana has quit IRC | 17:50 | |
mriedem | https://review.openstack.org/#/c/185748/ | 17:50 |
garyk | due to the fact that everyone says that we are breaking the API's lets go for #1, then fix nova to catch another exception and then update the lib | 17:50 |
*** Sukhdev has quit IRC | 17:50 | |
mriedem | dims has a preemptive g-r sync to nova here https://review.openstack.org/#/c/186087/ | 17:50 |
mriedem | that will unblock nova | 17:50 |
dhellmann | garyk, dims_, mriedem : I started an etherpad with notes for the issue: https://etherpad.openstack.org/p/oslo-vmware-13 | 17:52 |
*** vilobhmm has quit IRC | 17:53 | |
dims_ | garyk: dhellmann: mriedem: added some options | 17:55 |
*** sdake has joined #openstack-nova | 17:55 | |
*** Hosam has quit IRC | 17:55 | |
*** electrocucaracha has joined #openstack-nova | 17:56 | |
garyk | i added comments too. i will start to work on the nova side of thinsg if that is ok | 17:56 |
*** isd has quit IRC | 17:56 | |
mriedem | i'm distracted with fixing stable/juno and kilo atm | 17:57 |
dims_ | garyk: fine with me. you may end up blocking haypo's python34 work | 17:57 |
dims_ | since the nova change may take a while to land. i was hoping to get a 0.14.0 quickly | 17:57 |
dims_ | or a 0.13.1 | 17:58 |
*** isd has joined #openstack-nova | 17:58 | |
*** isd has quit IRC | 17:58 | |
*** sdake_ has quit IRC | 17:58 | |
garyk | dims_: if that is the case let me sync with vipin and rado tomorrow morning and we can get a fix in oslo.vmware. lets sync up tomorrow and we'll have something | 18:00 |
*** pradipta has quit IRC | 18:00 | |
*** rushiagr_away is now known as rushiagr | 18:00 | |
dims_ | garyk: perfect. thanks | 18:00 |
*** isd has joined #openstack-nova | 18:01 | |
*** IanGovett has quit IRC | 18:01 | |
*** isd has quit IRC | 18:01 | |
*** isd has joined #openstack-nova | 18:02 | |
*** dims_ has quit IRC | 18:02 | |
*** isd has quit IRC | 18:02 | |
*** achanda_ has joined #openstack-nova | 18:03 | |
*** dims_ has joined #openstack-nova | 18:03 | |
*** dulek_home has quit IRC | 18:03 | |
*** penick has joined #openstack-nova | 18:05 | |
*** isd has joined #openstack-nova | 18:05 | |
*** achanda has quit IRC | 18:05 | |
*** isd has quit IRC | 18:05 | |
*** alanf-mc has quit IRC | 18:06 | |
*** ijw has joined #openstack-nova | 18:07 | |
*** alanf-mc has joined #openstack-nova | 18:07 | |
nic | Am I reading the code right, and resize-revert is completely unimplemented for RBD/Ceph instances? | 18:08 |
*** isd has joined #openstack-nova | 18:08 | |
*** isd has quit IRC | 18:08 | |
nic | Spinning up a test cluster to try it is a significant time-sink, so if there's a quicker answer here, you have my attention | 18:08 |
*** Sukhdev has joined #openstack-nova | 18:08 | |
nic | i.e., resize-revert puts RBD-backed instances in an ERROR state currently? | 18:09 |
mriedem | jbernard: ^ | 18:10 |
mriedem | i'm pretty sure the ceph job is running resize tests | 18:10 |
*** ijw_ has quit IRC | 18:11 | |
mriedem | nic: which release? | 18:11 |
nic | I'm looking at master currently | 18:11 |
openstackgerrit | Doug Hellmann proposed openstack/python-novaclient: Do not check requirements when loading entry points https://review.openstack.org/186111 | 18:11 |
nic | also, I'm talking about the libvirt driver w/ Ceph and KVM | 18:11 |
dhellmann | melwitt: ^^ | 18:11 |
mriedem | nic: http://logs.openstack.org/59/127159/27/check/check-tempest-dsvm-full-ceph/7de8b17/console.html#_2015-05-27_16_53_47_736 | 18:11 |
mriedem | nic: http://logs.openstack.org/59/127159/27/check/check-tempest-dsvm-full-ceph/7de8b17/console.html#_2015-05-27_16_55_43_937 | 18:12 |
*** Nikolay_St has joined #openstack-nova | 18:12 | |
mriedem | it's working in our test job on master | 18:12 |
*** VW has joined #openstack-nova | 18:12 | |
nic | I see no code to support rolling back a resize, though | 18:12 |
nic | I tried it against stable/icehouse and it blew up in my face | 18:13 |
mriedem | nic: ceph probably wasn't working until maybe juno, more like kilo | 18:13 |
mriedem | the ceph job wasn't passing until kilo | 18:13 |
melwitt | dhellmann: thanks! | 18:13 |
*** Sukhdev has quit IRC | 18:13 | |
nic | OK, I'll stand up a test cluster and put this to the burden of proof | 18:13 |
nic | Thanks | 18:14 |
mriedem | nic: the compute manager resize revert method is here http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/manager.py#n3352 | 18:14 |
dhellmann | melwitt: it's not pretty, and note the suggestions for an alternative approach | 18:14 |
nic | I used RBD snapshots for it in our Grizzly; it works like a dream and is really fast | 18:14 |
*** krtaylor has joined #openstack-nova | 18:16 | |
*** annashen has joined #openstack-nova | 18:17 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/186116 | 18:17 |
cfriesen | anyone have any thoughts on bug 1458122? Is this something that would need a spec? | 18:17 |
openstack | bug 1458122 in OpenStack Compute (nova) "nova shouldn't error if we can't schedule all of max_count instances at boot time" [Undecided,New] https://launchpad.net/bugs/1458122 | 18:17 |
cfriesen | if everyone is fine with the current behaviour I'll drop it, but I don't think the current behaviour makes sense given the expected semantics of "min count" | 18:18 |
nic | I've always taken those arguments to be mutually exclusive, and a touch poorly-named | 18:20 |
cfriesen | nic: they're not mutually exclusive though | 18:20 |
nic | Giving the end-user something other than exactly what they asked for and claiming it's OK is a great way to generate support tickets for us | 18:21 |
cfriesen | nic: if the user says "I want at least 4 and at most 6" instances, and we can give them 5... | 18:21 |
*** dboik has quit IRC | 18:22 | |
nic | But that's not what those args mean | 18:22 |
*** kmartin has quit IRC | 18:22 | |
*** vilobhmm has joined #openstack-nova | 18:23 | |
cfriesen | nic: min_count "The minimum number of servers to launch when the service provider enables multiple server launch." | 18:24 |
cfriesen | nic: max_count: "The maximum number of servers to launch when the service provider enables multiple server launch. " | 18:24 |
*** ankit_ag has joined #openstack-nova | 18:25 | |
cfriesen | nic: and actually, the API explicitly supports setting both min/max in one request | 18:26 |
cfriesen | http://developer.openstack.org/api-ref-compute-v2.1.html#os-agents-v2.1 | 18:26 |
cfriesen | whoops, wrong hash | 18:26 |
cfriesen | http://developer.openstack.org/api-ref-compute-v2.1.html#os-multiple-create-v2.1 | 18:26 |
*** vilobhmm1 has joined #openstack-nova | 18:27 | |
*** vishwanathj has joined #openstack-nova | 18:27 | |
*** isd has joined #openstack-nova | 18:27 | |
*** isd has quit IRC | 18:28 | |
*** apmelton is now known as apmelton_away | 18:29 | |
*** ankit_ag has quit IRC | 18:30 | |
*** vilobhmm has quit IRC | 18:30 | |
*** dboik_ has joined #openstack-nova | 18:30 | |
openstackgerrit | Nikola Dipanov proposed openstack/nova: Add the swap and ephemeral BDMs if needed https://review.openstack.org/83516 | 18:32 |
jogo | dims_: re oslo.vmware I was pointing out we don't do a great job in Openstack (me included) of using semvers 1.0.0 clause | 18:32 |
*** moshele_ has joined #openstack-nova | 18:32 | |
jogo | dims_: and being the API should be considered stable why not a 1.0.0 release? | 18:33 |
*** dulek has quit IRC | 18:33 | |
*** isd has joined #openstack-nova | 18:34 | |
*** sudipto has quit IRC | 18:34 | |
*** kmartin has joined #openstack-nova | 18:34 | |
dims_ | jogo: ah, fair point. several other libraries got promoted at the kilo boundary, we were not sure about oslo.vmware yet at that point to make the jump | 18:35 |
jogo | dims_: responding to the post, I didn't mean to belittle the effort the oslo.vmware team put in | 18:35 |
*** rotbeard has joined #openstack-nova | 18:35 | |
dims_ | jogo: context, policy and vmware are stuck < 1 | 18:35 |
*** ijw_ has joined #openstack-nova | 18:37 | |
jogo | dims_: any responded on the ML. Thanks again | 18:38 |
dims_ | will definitely push them to go 1.x before liberty jogo! | 18:38 |
jogo | dims_: thanks! | 18:39 |
*** ijw has quit IRC | 18:40 | |
openstackgerrit | Jay Pipes proposed openstack/nova-specs: Add generic scheduling/placement API https://review.openstack.org/183837 | 18:41 |
*** isd has quit IRC | 18:41 | |
*** amotoki_ has joined #openstack-nova | 18:46 | |
*** achanda_ has quit IRC | 18:47 | |
*** otter768 has joined #openstack-nova | 18:47 | |
*** sdake_ has joined #openstack-nova | 18:47 | |
*** sudipto has joined #openstack-nova | 18:47 | |
*** vilobhmm has joined #openstack-nova | 18:47 | |
*** electrocucaracha has quit IRC | 18:48 | |
*** vilobhmm1 has quit IRC | 18:48 | |
*** Sukhdev has joined #openstack-nova | 18:49 | |
*** VW has quit IRC | 18:49 | |
sabari | dims_ mriedem garyk I abandoned https://review.openstack.org/#/c/185830/ as I just saw that we already blocked oslo.vmware 0.13.0 in nova. | 18:49 |
dims_ | sabari: thanks | 18:50 |
dims_ | sabari: please add your ideas/thoughts here - https://etherpad.openstack.org/p/oslo-vmware-13 | 18:50 |
dims_ | how best to proceed next | 18:50 |
*** amotoki_ has quit IRC | 18:51 | |
*** sdake has quit IRC | 18:51 | |
sabari | dims_ sure, I initially thought we could bump up min version in nova to use the latest oslo.vmware and also fix the tests. | 18:51 |
sabari | I will add my thoughts on the etherpad. | 18:51 |
*** cknight has left #openstack-nova | 18:51 | |
dims_ | sabari: y, we need a deprecation period at least | 18:51 |
*** otter768 has quit IRC | 18:52 | |
sabari | dims_: but we are not deprecating any exception in oslo.vmware. chk out my last comments in https://review.openstack.org/#/c/185830/ | 18:52 |
*** dave-mccowan has quit IRC | 18:52 | |
*** tobe has joined #openstack-nova | 18:53 | |
*** gokrokve has quit IRC | 18:53 | |
*** gokrokve has joined #openstack-nova | 18:56 | |
*** Hosam has joined #openstack-nova | 18:56 | |
*** dboik_ has quit IRC | 18:57 | |
*** dboik has joined #openstack-nova | 18:57 | |
jbernard | mriedem: it is, ill take a look | 18:58 |
*** tobe has quit IRC | 18:58 | |
mriedem | jbernard: yeah the ceph job passes the resize confirm/revert tests, i think it was an issue with someone testing on < kilo nova code | 18:58 |
jbernard | mriedem: yeah, that could be the case | 18:59 |
mriedem | i'm pretty sure the ceph / shared storage stuff in nova is probably just busted < juno | 18:59 |
jbernard | mriedem: it should work in kilo, if not then i have a bug | 18:59 |
jbernard | mriedem: im certain it is :) | 18:59 |
mriedem | we backported your shared storage fix to juno so that should be ok | 18:59 |
mriedem | but wedon't test it | 18:59 |
mriedem | oh i'm sure red hat tests it | 18:59 |
*** isd has joined #openstack-nova | 19:00 | |
*** alex_klimov has joined #openstack-nova | 19:00 | |
*** achanda has joined #openstack-nova | 19:00 | |
jbernard | nic: let me know how your tests go | 19:01 |
nic | I just resized an instance from m1.nano (24576k root disk) to m1.small (20GB root disk). It claims it worked, but Ceph reports no change in the size of the volume | 19:01 |
jbernard | nic: kilo? | 19:01 |
nic | master | 19:01 |
*** fawadkhaliq has joined #openstack-nova | 19:01 | |
*** rushiagr is now known as rushiagr_away | 19:01 | |
nic | Freshly pulled as of an hour ago (give or take) | 19:01 |
jbernard | nic: crap | 19:02 |
*** isd has quit IRC | 19:02 | |
jbernard | nic: alright, ill take a look; thanks for the info | 19:02 |
jbernard | nic: might be good to file a bug | 19:02 |
nic | I made this work relatively well against grizzly, and can forward-port the code if need be | 19:02 |
jbernard | nic: things should be distintly better in kilo, so i need to find out what's going on there | 19:03 |
nic | It's not particularly complicated: make a snapshot, resize the volume, and either pivot or rollback depending on user confirm/cancel | 19:03 |
*** penick has quit IRC | 19:04 | |
*** ijw_ has quit IRC | 19:05 | |
*** fawadkhaliq has quit IRC | 19:06 | |
*** sdake has joined #openstack-nova | 19:06 | |
nic | @jbernard: as you wish: https://bugs.launchpad.net/nova/+bug/1459399 | 19:08 |
openstack | Launchpad bug 1459399 in OpenStack Compute (nova) "Nova + Ceph: resize-instance doesn't resize anything, lies about it" [Undecided,New] | 19:08 |
*** eharney has quit IRC | 19:08 | |
jbernard | nic: thank you | 19:08 |
*** vishwanathj has quit IRC | 19:09 | |
*** dave-mccowan has joined #openstack-nova | 19:10 | |
*** sdake_ has quit IRC | 19:10 | |
*** VW has joined #openstack-nova | 19:12 | |
*** fawadkhaliq has joined #openstack-nova | 19:14 | |
*** annashen has quit IRC | 19:14 | |
*** eharney has joined #openstack-nova | 19:15 | |
*** kmartin has quit IRC | 19:20 | |
*** sudipto has quit IRC | 19:21 | |
*** electrocucaracha has joined #openstack-nova | 19:28 | |
*** rgerganov has quit IRC | 19:31 | |
*** electrocucaracha has quit IRC | 19:31 | |
*** fawadkhaliq has quit IRC | 19:33 | |
*** moshele_ has quit IRC | 19:34 | |
*** jgriffith has quit IRC | 19:36 | |
*** jgriffith has joined #openstack-nova | 19:36 | |
*** fungi has joined #openstack-nova | 19:38 | |
*** fungi has left #openstack-nova | 19:38 | |
*** haypo has joined #openstack-nova | 19:40 | |
*** Mike_D_laptop has joined #openstack-nova | 19:41 | |
*** thorst has left #openstack-nova | 19:45 | |
*** jgrimm is now known as zz_jgrimm | 19:49 | |
*** ociuhandu has quit IRC | 19:55 | |
*** gokrokve has quit IRC | 19:55 | |
*** mestery_ has joined #openstack-nova | 20:00 | |
*** kmartin has joined #openstack-nova | 20:00 | |
*** matrohon has joined #openstack-nova | 20:03 | |
*** mestery has quit IRC | 20:03 | |
bauzas | alaski_vanc: mmm, you there for the cells meeting tonight ? | 20:03 |
bauzas | unless vanc means "Very Awaiting Next Cycle" ? | 20:04 |
* bauzas shouldn't try joking in English during evenings | 20:05 | |
*** tonytan4ever has quit IRC | 20:05 | |
melwitt | bauzas: I think last meeting we said we were skipping the next two meetings, so last week and this week | 20:07 |
*** sdake_ has joined #openstack-nova | 20:07 | |
bauzas | melwitt: ooooooh | 20:07 |
bauzas | melwitt: right | 20:07 |
*** electrocucaracha has joined #openstack-nova | 20:08 | |
*** sdake has quit IRC | 20:11 | |
*** tonytan4ever has joined #openstack-nova | 20:11 | |
*** achanda has quit IRC | 20:14 | |
*** READ10 has quit IRC | 20:15 | |
*** annashen has joined #openstack-nova | 20:15 | |
*** IanGovett has joined #openstack-nova | 20:16 | |
*** slagle_ is now known as slagle | 20:20 | |
*** VW has quit IRC | 20:21 | |
*** matrohon has quit IRC | 20:24 | |
*** inara has quit IRC | 20:32 | |
*** inara has joined #openstack-nova | 20:34 | |
*** VW has joined #openstack-nova | 20:34 | |
*** amotoki_ has joined #openstack-nova | 20:34 | |
*** barra204 has joined #openstack-nova | 20:35 | |
*** annegentle has joined #openstack-nova | 20:37 | |
*** claudiub has quit IRC | 20:38 | |
*** amotoki_ has quit IRC | 20:39 | |
*** vladikr has quit IRC | 20:39 | |
*** IanGovett has quit IRC | 20:41 | |
*** electrocucaracha has quit IRC | 20:41 | |
*** tobe has joined #openstack-nova | 20:42 | |
*** adreznec has joined #openstack-nova | 20:45 | |
*** tobe has quit IRC | 20:46 | |
*** annashen has quit IRC | 20:47 | |
*** nkrinner has quit IRC | 20:48 | |
bauzas | mriedem: saw https://review.openstack.org/#/c/184968/ wedged by the oslo.vmware issue, I rechecked it since the partial bug was merged | 20:48 |
openstackgerrit | Eric Brown proposed openstack/nova: Use oslo_config choices support https://review.openstack.org/158573 | 20:48 |
bauzas | mriedem: IIUC, we can now recheck since https://review.openstack.org/#/c/186087/ merged ? | 20:48 |
openstackgerrit | Eric Brown proposed openstack/nova: VMware: replace hardcoded strings with constants https://review.openstack.org/185836 | 20:48 |
*** Sukhdev has quit IRC | 20:49 | |
bauzas | mriedem: at least your comment on bug 1459021 is explicit but I would like to make sure | 20:49 |
openstack | bug 1459021 in OpenStack Compute (nova) "nova vmware unit tests failing with oslo.vmware 0.13.0" [Critical,In progress] https://launchpad.net/bugs/1459021 - Assigned to Matt Riedemann (mriedem) | 20:49 |
*** barra204 has quit IRC | 20:50 | |
mriedem | bauzas: yeah, recheck | 20:51 |
bauzas | cool | 20:53 |
*** baoli has quit IRC | 20:56 | |
bauzas | mriedem: while you're here, question | 20:57 |
mriedem | i'm not here | 20:57 |
bauzas | mriedem: lol | 20:58 |
bauzas | mriedem: your nick is not registered, you're a fake then | 20:58 |
bauzas | mriedem: about https://review.openstack.org/#/c/118010/4/nova/conductor/manager.py,cm I'm torn since I'm working on RequestSpec | 20:58 |
bauzas | mriedem: I thought we agreed on the summit that we should avoid any change related to what we provide to the scheduler until we get resource-object and request-spec BPs implemented, do you confirm ? | 20:59 |
mriedem | jwcroppe: https://review.openstack.org/#/c/118010/ is still a -2 | 20:59 |
mriedem | b/c the dependent change has a -2 from me | 21:00 |
mriedem | bauzas: i wasn't in the scheduler session | 21:00 |
mriedem | bauzas: those have -2 anyway for now | 21:00 |
mriedem | going to require a blueprint for the new filter | 21:00 |
mriedem | and probably a spec | 21:00 |
mriedem | where those more in the know about wtf goes on in scheduler land can advise | 21:00 |
bauzas | mriedem: okay, will wait jaypipes coming back from his dream location | 21:00 |
mriedem | ha | 21:00 |
mriedem | jaypipes needs to get out of my dreams and into my car | 21:01 |
bauzas | mriedem: I'll put a note on that | 21:01 |
*** ociuhandu has joined #openstack-nova | 21:01 | |
*** electrocucaracha has joined #openstack-nova | 21:01 | |
bauzas | those -2s are procedural | 21:01 |
mriedem | bauzas: yes | 21:01 |
mriedem | i'm the king of procedural -2, don't you know? | 21:01 |
mriedem | bauzas: btw, fyi https://www.youtube.com/watch?v=zNgcYGgtf8M in case you didn't know | 21:02 |
mriedem | melwitt: dansmith: ^ you too! | 21:02 |
*** ociuhandu has quit IRC | 21:02 | |
bauzas | mriedem: :) | 21:02 |
*** ildikov has quit IRC | 21:03 | |
mriedem | now just imagine jay is the one dancing around | 21:03 |
bauzas | man... | 21:03 |
mriedem | let me have this | 21:03 |
mriedem | it's been a long day | 21:03 |
*** ociuhandu has joined #openstack-nova | 21:04 | |
*** sdake has joined #openstack-nova | 21:04 | |
bauzas | mriedem: I'm still jetlagged, that evening doesn't count for me | 21:04 |
*** alanf-mc_ has joined #openstack-nova | 21:05 | |
mriedem | i'm not sure why there is an animated duck with a boombox in this video | 21:05 |
mriedem | but i mean, why not, right? | 21:05 |
bauzas | :) | 21:07 |
melwitt | lol | 21:07 |
*** alanf-mc has quit IRC | 21:08 | |
*** sdake_ has quit IRC | 21:08 | |
*** artom has quit IRC | 21:10 | |
*** alanf-mc_ has quit IRC | 21:10 | |
*** artom has joined #openstack-nova | 21:10 | |
*** mestery_ is now known as mestery | 21:12 | |
*** Mike_D_laptop has quit IRC | 21:12 | |
*** alanf-mc has joined #openstack-nova | 21:12 | |
*** bkopilov_wfh has quit IRC | 21:13 | |
*** lsmola_ has quit IRC | 21:13 | |
openstackgerrit | David Bingham proposed openstack/nova: Allow cleanup completion when serial ports already released https://review.openstack.org/179978 | 21:16 |
*** mwagner has quit IRC | 21:16 | |
jwcroppe | mriedem, bauzas: Re: https://review.openstack.org/#/c/118010/ - fully agree we can create a blueprint. A spec seems a little heavyweight though to put back something that was there already (Icehouse) and a simple scheduler filter? | 21:18 |
mriedem | jwcroppe: i told him to at least put the bp in the nova meeting agenda to see if a spec is needed | 21:19 |
mriedem | i'm not sure what was there already in icehouse thoug | 21:19 |
mriedem | *though | 21:19 |
mriedem | the requested network stuff? | 21:19 |
jwcroppe | mriedem: yes, the requested network identifier was there - was removed since nothing was using it (in treee) | 21:19 |
mriedem | right | 21:20 |
*** alanf-mc_ has joined #openstack-nova | 21:20 | |
mriedem | so there isn't a point in adding it back until something is using it | 21:20 |
mriedem | hence the new filter and bp | 21:20 |
jwcroppe | Agree, hence the blueprint and filter | 21:20 |
jwcroppe | You just type faster :) | 21:20 |
*** alanf-mc has quit IRC | 21:20 | |
*** ildikov has joined #openstack-nova | 21:21 | |
jwcroppe | So I'm all for Stephen creating a blueprint (I'm happy to do it too, I'll check w/ him) and then try to get it through. Spec just seems like a lot of overhead for a trivial thing... but it could be done if that's the consensus | 21:22 |
mriedem | well, given what bauzas brings up above, it might not be trivial, idk | 21:22 |
mriedem | we have like a million scheduler filters, i think a design doc, even if smallish, is probably worth a spec to lay out the use case | 21:23 |
*** bkopilov has joined #openstack-nova | 21:23 | |
*** lucas-dinner has quit IRC | 21:23 | |
mriedem | and ops people can comment on spec reviewsw | 21:23 |
jwcroppe | mriedem: Yeah, all fair points... I'll see what Stephen says in the reviews. Is he already signed up for one of the meetings? | 21:28 |
*** dave-mccowan has quit IRC | 21:28 | |
mriedem | i haven't seen a meeting agenda update | 21:28 |
mriedem | or his reply on the patch | 21:28 |
*** dave-mccowan has joined #openstack-nova | 21:29 | |
jwcroppe | ok... hopefully this shouldn't be too problematic overall; I'd like to hear bauzas's thoughts on if he has a better option for getting the network ID into the request spec as well | 21:30 |
*** bkopilov has quit IRC | 21:31 | |
*** dave-mccowan has quit IRC | 21:34 | |
*** pece has quit IRC | 21:34 | |
*** rbradfor has joined #openstack-nova | 21:34 | |
*** lucas-dinner has joined #openstack-nova | 21:36 | |
*** nihilifer has joined #openstack-nova | 21:38 | |
*** thangp has quit IRC | 21:43 | |
*** rbradfor has left #openstack-nova | 21:43 | |
*** annashen has joined #openstack-nova | 21:48 | |
*** bkopilov has joined #openstack-nova | 21:49 | |
*** nic has quit IRC | 21:49 | |
*** burt has quit IRC | 21:49 | |
*** dboik has quit IRC | 21:49 | |
*** mriedem has quit IRC | 21:51 | |
*** penick has joined #openstack-nova | 21:51 | |
*** annashen has quit IRC | 21:53 | |
*** kaufer has quit IRC | 21:55 | |
*** mjturek1 has quit IRC | 21:55 | |
*** electrocucaracha has quit IRC | 21:56 | |
*** VW has quit IRC | 21:56 | |
*** VW has joined #openstack-nova | 21:57 | |
*** mwagner has joined #openstack-nova | 21:58 | |
*** jwcroppe has quit IRC | 21:58 | |
*** VW has quit IRC | 21:59 | |
*** VW has joined #openstack-nova | 21:59 | |
*** jwcroppe has joined #openstack-nova | 21:59 | |
*** electrocucaracha has joined #openstack-nova | 22:00 | |
*** gokrokve has joined #openstack-nova | 22:02 | |
*** radek__ has quit IRC | 22:02 | |
*** mriedem has joined #openstack-nova | 22:03 | |
*** VW has quit IRC | 22:04 | |
*** annashen has joined #openstack-nova | 22:04 | |
*** Sukhdev has joined #openstack-nova | 22:04 | |
*** amotoki_ has joined #openstack-nova | 22:05 | |
*** VW has joined #openstack-nova | 22:06 | |
*** VW has quit IRC | 22:06 | |
*** VW has joined #openstack-nova | 22:07 | |
cfriesen | someone tell me if I'm sniffing glue here...if instance storage is not shared, then _is_instance_storage_shared() will say that we're on shared storage if it can't contact the other compute node. If called from _destroy_evacuated_instances() that could cause it to leave instance disks lying around, which then could cause the instance_on_disk() call in a subsequent evac call to think that the instance is on shared storage. | 22:07 |
cfriesen | I'm wondering if it might make sense to have an "shared_storage_id" value in nova.conf which could be "None" for nova-compute with local storage. That would let us short-circuit the _is_instance_storage_shared() for the local storage case, making it more robust. | 22:09 |
*** amotoki_ has quit IRC | 22:10 | |
*** VW_ has joined #openstack-nova | 22:11 | |
*** VW has quit IRC | 22:11 | |
*** rotbeard has quit IRC | 22:11 | |
*** lpetrut has quit IRC | 22:19 | |
*** annegentle has quit IRC | 22:20 | |
*** annegentle has joined #openstack-nova | 22:24 | |
*** ijw has joined #openstack-nova | 22:26 | |
tjones1 | i asked this on #openstack but no answer. does nova have the ability to dump a stack trace if i do a kill -i SIGUSR1 <pid>? It kind of looks like it should but i am not seeing the stack dump . any ideas? | 22:29 |
tjones1 | by nova i mean nova-compute | 22:30 |
*** ndipanov has quit IRC | 22:30 | |
*** tobe has joined #openstack-nova | 22:30 | |
*** ijw_ has joined #openstack-nova | 22:31 | |
anteaya | tonyb: care to join us in -infra? | 22:32 |
*** nelsnelson has quit IRC | 22:32 | |
mriedem | tjones1: you might read this http://docs.openstack.org/developer/nova/devref/gmr.html | 22:32 |
mriedem | not sure if it helps though | 22:33 |
tjones1 | im looking at https://wiki.openstack.org/wiki/GuruMeditationReport | 22:33 |
*** kmartin_ has joined #openstack-nova | 22:34 | |
tjones1 | which would be awesome | 22:34 |
*** fawadkhaliq has joined #openstack-nova | 22:34 | |
*** artom_ has joined #openstack-nova | 22:34 | |
*** kmartin has quit IRC | 22:34 | |
cfriesen | tjones1: I think you want "kill -USR1 <pid>", and the report goes to stderr, wherever that is for nova | 22:34 |
*** artom has quit IRC | 22:34 | |
*** patrickeast_ has joined #openstack-nova | 22:34 | |
tjones1 | ah - let me try i did -i SIGUSR1 | 22:34 |
*** ijw has quit IRC | 22:34 | |
*** tobe has quit IRC | 22:35 | |
*** patrickeast has quit IRC | 22:36 | |
*** patrickeast_ is now known as patrickeast | 22:36 | |
tjones1 | i think stderr goes nowhere… | 22:37 |
*** fawadkhaliq has quit IRC | 22:38 | |
*** salv-orlando has joined #openstack-nova | 22:41 | |
*** VW_ has quit IRC | 22:41 | |
*** derekh_ has quit IRC | 22:42 | |
*** aysyanne has quit IRC | 22:43 | |
*** annashen has quit IRC | 22:43 | |
*** annegentle has quit IRC | 22:46 | |
*** otter768 has joined #openstack-nova | 22:49 | |
*** annashen has joined #openstack-nova | 22:50 | |
*** krtaylor has quit IRC | 22:50 | |
*** electrocucaracha has quit IRC | 22:51 | |
*** ddaskal has quit IRC | 22:51 | |
*** electrocucaracha has joined #openstack-nova | 22:51 | |
*** otter768 has quit IRC | 22:54 | |
openstackgerrit | Stephen Pierce proposed openstack/nova: per-aggregate filter to select hosts based on requested networks https://review.openstack.org/185204 | 23:00 |
*** haypo has quit IRC | 23:01 | |
*** jecarey has quit IRC | 23:01 | |
*** ijw_ has quit IRC | 23:02 | |
tjones1 | mriedem: cfriesen: thanks for the info. once i redirect stderr somewhere i get info. I just have to restart the process to redirect unfortuately | 23:03 |
*** electroc_ has joined #openstack-nova | 23:03 | |
*** mriedem has quit IRC | 23:04 | |
*** gokrokve has quit IRC | 23:04 | |
*** ijw has joined #openstack-nova | 23:05 | |
*** electrocucaracha has quit IRC | 23:06 | |
*** wuhg has joined #openstack-nova | 23:07 | |
*** tjones1 has quit IRC | 23:09 | |
*** tonytan4ever has quit IRC | 23:10 | |
*** electroc_ has quit IRC | 23:10 | |
*** annashen has quit IRC | 23:12 | |
*** electrocucaracha has joined #openstack-nova | 23:12 | |
*** annashen has joined #openstack-nova | 23:13 | |
*** electrocucaracha has quit IRC | 23:14 | |
*** salv-orlando has quit IRC | 23:14 | |
*** electrocucaracha has joined #openstack-nova | 23:15 | |
*** sdake_ has joined #openstack-nova | 23:16 | |
*** annashen has quit IRC | 23:17 | |
*** electrocucaracha has quit IRC | 23:17 | |
*** tjones1 has joined #openstack-nova | 23:17 | |
*** sdake has quit IRC | 23:19 | |
*** annashen has joined #openstack-nova | 23:21 | |
*** ZZelle_ has quit IRC | 23:22 | |
*** ijw_ has joined #openstack-nova | 23:22 | |
*** Hosam has quit IRC | 23:23 | |
*** electrocucaracha has joined #openstack-nova | 23:24 | |
*** electrocucaracha has quit IRC | 23:25 | |
*** ijw has quit IRC | 23:26 | |
*** electrocucaracha has joined #openstack-nova | 23:26 | |
*** annashen has quit IRC | 23:29 | |
*** annashen has joined #openstack-nova | 23:30 | |
*** tobe has joined #openstack-nova | 23:31 | |
*** annashen has quit IRC | 23:35 | |
*** tobe has quit IRC | 23:36 | |
*** nelsnelson has joined #openstack-nova | 23:36 | |
*** dims_ has quit IRC | 23:38 | |
*** fawadkhaliq has joined #openstack-nova | 23:38 | |
*** lucas-dinner has quit IRC | 23:39 | |
*** krtaylor has joined #openstack-nova | 23:39 | |
*** dims_ has joined #openstack-nova | 23:40 | |
*** tjones1 has left #openstack-nova | 23:49 | |
*** ddutta has joined #openstack-nova | 23:50 | |
*** lsmola has joined #openstack-nova | 23:51 | |
*** amotoki_ has joined #openstack-nova | 23:51 | |
*** nelsnelson has quit IRC | 23:52 | |
*** penick has quit IRC | 23:53 | |
*** amotoki_ has quit IRC | 23:56 | |
*** ddutta has quit IRC | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!