*** barra204 has quit IRC | 00:03 | |
*** ssurana1 has joined #openstack-nova | 00:04 | |
*** tpatil has quit IRC | 00:04 | |
*** ssurana has quit IRC | 00:04 | |
*** tjones1 has quit IRC | 00:05 | |
vilobhmm | dansmith : ping | 00:06 |
---|---|---|
dansmith | vilobhmm: just about to leave for the day, but what's up? | 00:06 |
vilobhmm | nothing urgent…talk to you tommorow… | 00:07 |
dansmith | okay, thanks | 00:07 |
vilobhmm | dansmith : ^^ | 00:07 |
*** mdrabe has joined #openstack-nova | 00:08 | |
*** MentalRay has joined #openstack-nova | 00:09 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/200708 | 00:13 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient: Updated from global requirements https://review.openstack.org/201838 | 00:14 |
*** mtanino has quit IRC | 00:19 | |
*** tsekiyam_ has joined #openstack-nova | 00:21 | |
gmann | sdague: sure that will be nice to add. | 00:22 |
*** mdrabe has quit IRC | 00:22 | |
gmann | sdague: apart from bottom, top and changed version testing for microversion as discussed in summit, i was thinking will it be good if we run all func tests against particular microversion to verify nothing is changed than the expected API/s | 00:24 |
*** david-lyle has quit IRC | 00:25 | |
gmann | sdague: we can run same tests using testscenario as done for v2 and v2.1. your thought? | 00:25 |
*** tsekiyama has quit IRC | 00:25 | |
*** tsekiyam_ has quit IRC | 00:26 | |
*** diogogmt has joined #openstack-nova | 00:27 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/200708 | 00:28 |
*** Kennan2 is now known as Kennan | 00:29 | |
*** achanda has quit IRC | 00:29 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient: Updated from global requirements https://review.openstack.org/201838 | 00:29 |
*** MentalRay has quit IRC | 00:30 | |
*** MentalRay has joined #openstack-nova | 00:32 | |
mtreinish | oomichi: heh, did you actually find the pdf output useful? :) | 00:33 |
*** signed8b_ has joined #openstack-nova | 00:33 | |
mtreinish | the sphinx generated latex doesn't do such a hot job... | 00:33 |
*** mnestratov|2 has quit IRC | 00:34 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge server list multi status tests between v2 and v2.1 https://review.openstack.org/201387 | 00:35 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/200708 | 00:35 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge flavor all_extensions tests between v2 and v2.1 https://review.openstack.org/201430 | 00:35 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge "versions" tests between v2 and v2.1 https://review.openstack.org/201439 | 00:35 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient: Updated from global requirements https://review.openstack.org/201838 | 00:36 |
*** thorst has joined #openstack-nova | 00:38 | |
oomichi | mtreinish: yeah, I did download Nova.pdf from devstack and can read it. that is useful, but there are some storange formats. | 00:40 |
oomichi | mtreinish: maybe we need to fix them, but they should be out of scope from your patch as the first step | 00:40 |
*** signed8b_ is now known as signed8bit_ZZZzz | 00:40 | |
mtreinish | oomichi: well they really should be fixed in sphinx, because that's where the bugs are. It's just generating sloppy latex | 00:41 |
mtreinish | but after looking at the sphinx bug tracker they've got quite the back log | 00:41 |
*** hemna is now known as hemnafk | 00:41 | |
*** signed8bit_ZZZzz has quit IRC | 00:41 | |
mtreinish | especially on latex bugs | 00:42 |
mtreinish | https://github.com/sphinx-doc/sphinx/issues | 00:42 |
*** kcaj has quit IRC | 00:43 | |
oomichi | mtreinish: oops, nice info. ok, we can just wait for fixing them without any our works ;) | 00:43 |
*** bitblt has quit IRC | 00:44 | |
*** kcaj has joined #openstack-nova | 00:45 | |
*** baoli has joined #openstack-nova | 00:45 | |
*** dims__ has quit IRC | 00:54 | |
*** browne has quit IRC | 00:58 | |
*** deepthi has joined #openstack-nova | 00:58 | |
*** nic has quit IRC | 01:06 | |
*** asettle has joined #openstack-nova | 01:09 | |
*** casusbel_ has joined #openstack-nova | 01:12 | |
*** casusbelli has quit IRC | 01:15 | |
*** ssurana1 has quit IRC | 01:17 | |
*** ssurana has joined #openstack-nova | 01:17 | |
*** vilobhmm has quit IRC | 01:20 | |
*** lyanchih has joined #openstack-nova | 01:21 | |
*** ssurana has quit IRC | 01:21 | |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for provider_fw_rule_* https://review.openstack.org/200381 | 01:21 |
openstackgerrit | Alex Xu proposed openstack/nova: Remove db layer hard-code permission checks for archive_deleted_rows* https://review.openstack.org/200380 | 01:21 |
*** jwang_ has quit IRC | 01:21 | |
*** changbl has joined #openstack-nova | 01:24 | |
openstackgerrit | ZhaoBo proposed openstack/nova: Fixed raise SecurityGroupCannotBeApplied as network port_security off https://review.openstack.org/188260 | 01:25 |
alex_xu | melwitt: hi, just fyi, the microversion client discussion happened last night in this channel, you can find out from the log | 01:26 |
*** bradjones has quit IRC | 01:26 | |
*** dims_ has joined #openstack-nova | 01:28 | |
*** bradjones has joined #openstack-nova | 01:30 | |
*** bradjones has quit IRC | 01:30 | |
*** bradjones has joined #openstack-nova | 01:30 | |
*** kjelly has joined #openstack-nova | 01:30 | |
*** signed8b_ has joined #openstack-nova | 01:30 | |
*** signed8b_ is now known as signed8bit_ZZZzz | 01:31 | |
*** deepthi has quit IRC | 01:32 | |
*** signed8bit_ZZZzz has quit IRC | 01:33 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/200708 | 01:35 |
*** dprince has quit IRC | 01:36 | |
*** shyu has joined #openstack-nova | 01:36 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient: Updated from global requirements https://review.openstack.org/201838 | 01:37 |
*** unicell has quit IRC | 01:39 | |
*** ishita has quit IRC | 01:40 | |
*** thorst has quit IRC | 01:41 | |
*** tpeoples_away is now known as tpeoples | 01:41 | |
*** liusheng has quit IRC | 01:41 | |
*** asettle has quit IRC | 01:46 | |
*** liusheng has joined #openstack-nova | 01:47 | |
*** otter768 has joined #openstack-nova | 01:51 | |
*** boris-42 has quit IRC | 01:52 | |
*** signed8bit has joined #openstack-nova | 01:53 | |
*** markvoelker has quit IRC | 01:54 | |
*** signed8bit is now known as signed8bit_ZZZzz | 01:54 | |
*** otter768 has quit IRC | 01:55 | |
*** signed8bit_ZZZzz has quit IRC | 01:56 | |
*** markvoelker has joined #openstack-nova | 02:00 | |
*** signed8b_ has joined #openstack-nova | 02:01 | |
*** Kennan2 has joined #openstack-nova | 02:02 | |
*** signed8b_ is now known as signed8bit_ZZZzz | 02:02 | |
*** sharkJing has quit IRC | 02:03 | |
*** Kennan has quit IRC | 02:03 | |
*** signed8bit_ZZZzz has quit IRC | 02:04 | |
*** sharkJing has joined #openstack-nova | 02:04 | |
*** tjones1 has joined #openstack-nova | 02:07 | |
*** zhenguo has joined #openstack-nova | 02:09 | |
*** patrickeast_ has quit IRC | 02:10 | |
*** coolsvap|away has quit IRC | 02:10 | |
*** unicell has joined #openstack-nova | 02:10 | |
*** yamahata has quit IRC | 02:10 | |
*** coolsvap|away has joined #openstack-nova | 02:12 | |
*** david-lyle has joined #openstack-nova | 02:12 | |
*** dims_ has quit IRC | 02:17 | |
*** markvoelker has quit IRC | 02:18 | |
*** dave-mccowan has quit IRC | 02:18 | |
*** eliqiao1 has left #openstack-nova | 02:19 | |
*** mutoulbj has joined #openstack-nova | 02:22 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge virtual interface tests between v2 and v2.1 https://review.openstack.org/197811 | 02:25 |
*** unicell1 has joined #openstack-nova | 02:28 | |
david-lyle | kfox1111: horizon makes a call directly to neutron because the nova db has stale values | 02:29 |
*** unicell has quit IRC | 02:29 | |
*** pixelbeat_ has quit IRC | 02:33 | |
*** david-lyle has quit IRC | 02:35 | |
*** unicell1 has quit IRC | 02:35 | |
*** unicell has joined #openstack-nova | 02:36 | |
*** MentalRay has quit IRC | 02:37 | |
*** annashen has joined #openstack-nova | 02:39 | |
*** asettle has joined #openstack-nova | 02:43 | |
*** coolsvap has quit IRC | 02:45 | |
*** annashen has quit IRC | 02:48 | |
*** baoli has quit IRC | 02:49 | |
*** hakimo has joined #openstack-nova | 02:52 | |
*** baoli has joined #openstack-nova | 02:52 | |
*** patrickeast has joined #openstack-nova | 02:53 | |
*** hakimo_ has quit IRC | 02:54 | |
*** annashen has joined #openstack-nova | 02:58 | |
*** jecarey has joined #openstack-nova | 03:01 | |
*** tjones1 has quit IRC | 03:03 | |
*** signed8b_ has joined #openstack-nova | 03:04 | |
*** haomaiwang has quit IRC | 03:09 | |
*** haomaiwa_ has joined #openstack-nova | 03:09 | |
*** achanda has joined #openstack-nova | 03:10 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Merge block_device_mapping boot tests between v2 and v2.1 https://review.openstack.org/201401 | 03:13 |
*** dims_ has joined #openstack-nova | 03:19 | |
*** dims_ has quit IRC | 03:23 | |
*** markvoelker has joined #openstack-nova | 03:35 | |
*** y_sawai has joined #openstack-nova | 03:36 | |
*** y_sawai has quit IRC | 03:38 | |
*** david-lyle has joined #openstack-nova | 03:38 | |
*** markvoelker_ has joined #openstack-nova | 03:38 | |
*** markvoelker has quit IRC | 03:40 | |
*** RuiChen has joined #openstack-nova | 03:40 | |
*** otter768 has joined #openstack-nova | 03:52 | |
*** achanda has quit IRC | 03:56 | |
*** otter768 has quit IRC | 03:56 | |
*** diogogmt has quit IRC | 03:56 | |
*** achanda has joined #openstack-nova | 03:57 | |
*** kumar has joined #openstack-nova | 04:00 | |
*** signed8__ has joined #openstack-nova | 04:03 | |
*** markvoelker has joined #openstack-nova | 04:04 | |
*** signed8b_ has quit IRC | 04:04 | |
*** markvoelker_ has quit IRC | 04:07 | |
*** markvoelker_ has joined #openstack-nova | 04:08 | |
*** dannywilson has joined #openstack-nova | 04:08 | |
*** dannywilson has joined #openstack-nova | 04:09 | |
*** markvoelker has quit IRC | 04:09 | |
*** asettle has quit IRC | 04:16 | |
*** signed8bit has joined #openstack-nova | 04:17 | |
*** wanghao has quit IRC | 04:17 | |
*** achanda has quit IRC | 04:18 | |
*** signed8__ has quit IRC | 04:20 | |
*** coolsvap|away is now known as coolsvap | 04:20 | |
*** signed8bit has quit IRC | 04:21 | |
*** deepthi has joined #openstack-nova | 04:22 | |
*** dannywilson has joined #openstack-nova | 04:24 | |
*** fifieldt has joined #openstack-nova | 04:28 | |
*** jecarey has quit IRC | 04:29 | |
*** annashen has quit IRC | 04:29 | |
*** shyama has joined #openstack-nova | 04:32 | |
*** Administrator_ has joined #openstack-nova | 04:32 | |
*** FL1SK has quit IRC | 04:34 | |
*** danieru has quit IRC | 04:35 | |
*** Kevin_Zheng has quit IRC | 04:35 | |
*** Kevin_Zheng_ is now known as Kevin_Zheng | 04:35 | |
*** danieru has joined #openstack-nova | 04:36 | |
*** sharkJing has quit IRC | 04:36 | |
*** sharkJing has joined #openstack-nova | 04:36 | |
*** pradipta has joined #openstack-nova | 04:37 | |
*** baoli has quit IRC | 04:39 | |
*** oomichi has quit IRC | 04:40 | |
*** baoli_ has joined #openstack-nova | 04:41 | |
openstackgerrit | Sergey Vilgelm proposed openstack/nova: Switch to the oslo_utils.fileutils https://review.openstack.org/199575 | 04:41 |
*** boris-42 has joined #openstack-nova | 04:43 | |
*** baoli_ has quit IRC | 04:44 | |
*** shane-wang has joined #openstack-nova | 04:45 | |
*** shane-wang has left #openstack-nova | 04:45 | |
*** shane-wang has joined #openstack-nova | 04:45 | |
*** shane-wang has left #openstack-nova | 04:46 | |
*** asettle has joined #openstack-nova | 04:50 | |
*** patrickeast has quit IRC | 04:51 | |
*** slong has quit IRC | 04:54 | |
*** slong has joined #openstack-nova | 04:54 | |
*** otter768 has joined #openstack-nova | 05:04 | |
openstackgerrit | lyanchih proposed openstack/nova: Creating instance fail when inject ssh key in cells mode https://review.openstack.org/197514 | 05:06 |
*** markvoelker has joined #openstack-nova | 05:06 | |
*** markvoelker_ has quit IRC | 05:06 | |
*** achanda has joined #openstack-nova | 05:07 | |
*** markvoelker_ has joined #openstack-nova | 05:08 | |
*** markvoelker has quit IRC | 05:11 | |
*** tjones1 has joined #openstack-nova | 05:12 | |
*** exploreshaifali has joined #openstack-nova | 05:13 | |
*** exploreshaifali has quit IRC | 05:14 | |
*** annashen has joined #openstack-nova | 05:14 | |
openstackgerrit | Sergey Vilgelm proposed openstack/nova: Switch to the oslo_utils.fileutils https://review.openstack.org/199575 | 05:16 |
*** xyang1 has quit IRC | 05:20 | |
*** sudipto has joined #openstack-nova | 05:24 | |
*** irenab has joined #openstack-nova | 05:24 | |
*** vilobhmm has joined #openstack-nova | 05:26 | |
*** lyanchih has quit IRC | 05:26 | |
*** vilobhmm1 has joined #openstack-nova | 05:27 | |
*** moshele has joined #openstack-nova | 05:28 | |
*** Longgeek has joined #openstack-nova | 05:28 | |
*** vilobhmm has quit IRC | 05:30 | |
*** slong_ has joined #openstack-nova | 05:30 | |
*** mutoulbj_ has joined #openstack-nova | 05:31 | |
*** slong has quit IRC | 05:31 | |
*** tjones1 has quit IRC | 05:32 | |
*** deepthi has quit IRC | 05:33 | |
*** ByPasS has joined #openstack-nova | 05:33 | |
*** mutoulb__ has joined #openstack-nova | 05:34 | |
*** mutoulbj has quit IRC | 05:34 | |
*** browne has joined #openstack-nova | 05:34 | |
*** sudipto has quit IRC | 05:35 | |
*** pradipta has quit IRC | 05:37 | |
*** mutoulbj_ has quit IRC | 05:37 | |
*** Sukhdev has joined #openstack-nova | 05:38 | |
*** kiran-r has joined #openstack-nova | 05:39 | |
*** jyuso1 has quit IRC | 05:43 | |
*** sharkJing has quit IRC | 05:46 | |
*** annashen has quit IRC | 05:48 | |
*** deepthi has joined #openstack-nova | 05:50 | |
*** sudipto has joined #openstack-nova | 05:51 | |
*** kumar has quit IRC | 05:52 | |
*** Nikolay_St has quit IRC | 05:53 | |
*** dboik has joined #openstack-nova | 05:53 | |
*** Murali has joined #openstack-nova | 05:53 | |
*** fawadkhaliq has joined #openstack-nova | 05:54 | |
*** oro_ has joined #openstack-nova | 05:55 | |
*** oro has joined #openstack-nova | 05:55 | |
*** norman has joined #openstack-nova | 05:56 | |
norman | Hi All, can I live-migrate a volume backend instance with a config drive in Kilo? | 05:57 |
*** lyanchih has joined #openstack-nova | 05:57 | |
norman | when I do it in nova client , I can't | 05:57 |
*** dboik has quit IRC | 05:57 | |
*** ankit has joined #openstack-nova | 05:59 | |
*** otter768 has quit IRC | 05:59 | |
*** itzikb_ has joined #openstack-nova | 06:01 | |
*** shyu has quit IRC | 06:01 | |
*** adreznec has quit IRC | 06:01 | |
*** shyu has joined #openstack-nova | 06:02 | |
*** sudipto has quit IRC | 06:03 | |
*** adreznec has joined #openstack-nova | 06:03 | |
*** rajesht has joined #openstack-nova | 06:06 | |
*** vilobhmm1 has quit IRC | 06:06 | |
*** annashen has joined #openstack-nova | 06:10 | |
*** oro has quit IRC | 06:12 | |
*** oro_ has quit IRC | 06:13 | |
*** oro has joined #openstack-nova | 06:14 | |
*** shyu has quit IRC | 06:14 | |
*** browne has quit IRC | 06:14 | |
*** shyu has joined #openstack-nova | 06:16 | |
*** belmoreira has joined #openstack-nova | 06:21 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex https://review.openstack.org/197213 | 06:21 |
*** tobe has joined #openstack-nova | 06:28 | |
*** oro_ has joined #openstack-nova | 06:30 | |
*** afazekas has joined #openstack-nova | 06:30 | |
*** sahid has joined #openstack-nova | 06:32 | |
*** fawadkhaliq has quit IRC | 06:33 | |
*** FL1SK has joined #openstack-nova | 06:35 | |
*** nkrinner_afk is now known as nkrinner | 06:35 | |
*** cfriesen has quit IRC | 06:36 | |
*** wanghao has joined #openstack-nova | 06:44 | |
*** jichen has joined #openstack-nova | 06:45 | |
*** annashen has quit IRC | 06:46 | |
*** Nikolay_St has joined #openstack-nova | 06:47 | |
openstackgerrit | ZhaoBo proposed openstack/nova: Fixed raise SecurityGroupCannotBeApplied as network port_security off https://review.openstack.org/188260 | 06:49 |
*** lpetrut has joined #openstack-nova | 06:51 | |
*** ildikov has quit IRC | 06:53 | |
*** fawadkhaliq has joined #openstack-nova | 06:54 | |
*** lpetrut1 has joined #openstack-nova | 06:54 | |
*** vilobhmm has joined #openstack-nova | 06:55 | |
*** fawadk has joined #openstack-nova | 06:55 | |
*** lpetrut has quit IRC | 06:58 | |
*** rdopiera has joined #openstack-nova | 06:58 | |
*** fawadkhaliq has quit IRC | 06:58 | |
*** jyuso1 has joined #openstack-nova | 06:58 | |
*** asettle has quit IRC | 06:59 | |
*** markus_z has joined #openstack-nova | 06:59 | |
*** fawadkhaliq has joined #openstack-nova | 06:59 | |
*** fawadk has quit IRC | 07:00 | |
openstackgerrit | Abhishek Kekane proposed openstack/nova: Execute _poll_shelved_instances only if shelved_offload_time is > 0 https://review.openstack.org/201436 | 07:00 |
openstackgerrit | heijlong proposed openstack/nova: Add uuid into SecurityGroup database model https://review.openstack.org/199928 | 07:04 |
*** dannywilson has quit IRC | 07:05 | |
*** lpetrut1 has quit IRC | 07:05 | |
*** jichen has quit IRC | 07:07 | |
*** josecastroleon has quit IRC | 07:07 | |
*** rook has quit IRC | 07:07 | |
*** jichen has joined #openstack-nova | 07:07 | |
*** mutoulb__ has quit IRC | 07:10 | |
*** alex_klimov has joined #openstack-nova | 07:10 | |
*** mutoulbj has joined #openstack-nova | 07:11 | |
*** deepthi has quit IRC | 07:12 | |
*** annashen has joined #openstack-nova | 07:15 | |
*** markus_z has quit IRC | 07:17 | |
*** eglynn has joined #openstack-nova | 07:20 | |
*** dims_ has joined #openstack-nova | 07:20 | |
*** jichen_ has joined #openstack-nova | 07:22 | |
*** jichen has quit IRC | 07:22 | |
*** jichen_ is now known as jichen | 07:22 | |
*** Longgeek has quit IRC | 07:23 | |
*** zigo has quit IRC | 07:24 | |
*** pixelbeat_ has joined #openstack-nova | 07:24 | |
*** zigo has joined #openstack-nova | 07:25 | |
*** dims_ has quit IRC | 07:26 | |
*** annashen has quit IRC | 07:26 | |
*** rook has joined #openstack-nova | 07:27 | |
*** vilobhmm has quit IRC | 07:28 | |
*** q3k has quit IRC | 07:29 | |
*** Jeffrey4l has quit IRC | 07:31 | |
*** aix has joined #openstack-nova | 07:31 | |
openstackgerrit | lyanchih proposed openstack/nova: Creating instance fail when inject ssh key in cells mode https://review.openstack.org/197514 | 07:36 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/200708 | 07:36 |
*** Sukhdev has quit IRC | 07:37 | |
*** Jeffrey4l has joined #openstack-nova | 07:40 | |
*** jlanoux has joined #openstack-nova | 07:40 | |
*** romainh has joined #openstack-nova | 07:43 | |
*** shyu has quit IRC | 07:45 | |
*** shyu has joined #openstack-nova | 07:45 | |
*** ildikov has joined #openstack-nova | 07:47 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: libvirt:Rsync remote FS driver was added https://review.openstack.org/146887 | 07:49 |
openstackgerrit | wuhao proposed openstack/nova: shared block device will be deleted when live migration failed https://review.openstack.org/171310 | 07:49 |
*** eglynn has quit IRC | 07:49 | |
*** rotbeard has joined #openstack-nova | 07:50 | |
*** sharkJing has joined #openstack-nova | 07:52 | |
*** jichen has quit IRC | 07:52 | |
*** lpetrut has joined #openstack-nova | 07:52 | |
*** lyanchih has quit IRC | 07:53 | |
*** jichen has joined #openstack-nova | 07:55 | |
*** ankit_ag has joined #openstack-nova | 07:55 | |
*** shuquan has joined #openstack-nova | 07:56 | |
*** lpetrut has quit IRC | 07:57 | |
*** sharkJing has quit IRC | 07:58 | |
*** ankit has quit IRC | 07:58 | |
*** lyanchih has joined #openstack-nova | 07:59 | |
*** sharkJing has joined #openstack-nova | 07:59 | |
*** park_ has joined #openstack-nova | 08:00 | |
*** Longgeek has joined #openstack-nova | 08:00 | |
*** achanda has quit IRC | 08:02 | |
openstackgerrit | heijlong proposed openstack/nova: Add uuid into SecurityGroup object https://review.openstack.org/201970 | 08:02 |
*** ZZelle has quit IRC | 08:03 | |
openstackgerrit | wuhao proposed openstack/nova: shared block device will be deleted when live migration failed https://review.openstack.org/171310 | 08:04 |
*** sharkJing has quit IRC | 08:04 | |
*** leseb has quit IRC | 08:04 | |
*** fawadkhaliq has quit IRC | 08:05 | |
*** leseb has joined #openstack-nova | 08:07 | |
*** lpetrut has joined #openstack-nova | 08:09 | |
*** ccard has quit IRC | 08:11 | |
*** norman has quit IRC | 08:12 | |
*** jistr has joined #openstack-nova | 08:12 | |
*** boris-42 has quit IRC | 08:12 | |
*** ociuhandu has joined #openstack-nova | 08:16 | |
*** lucasagomes has joined #openstack-nova | 08:16 | |
*** PpPyg has joined #openstack-nova | 08:21 | |
*** sudipto has joined #openstack-nova | 08:21 | |
*** leseb_ has quit IRC | 08:21 | |
*** markvoelker_ has quit IRC | 08:21 | |
*** fawadkhaliq has joined #openstack-nova | 08:22 | |
*** romainh has quit IRC | 08:22 | |
*** shuquan has quit IRC | 08:22 | |
*** ndipanov has joined #openstack-nova | 08:24 | |
*** lpetrut1 has joined #openstack-nova | 08:24 | |
*** lpetrut has quit IRC | 08:24 | |
openstackgerrit | Eli Qiao proposed openstack/nova: Libvirt: Show real vCpuCompareResult instead of a url link https://review.openstack.org/165671 | 08:28 |
*** romainh has joined #openstack-nova | 08:29 | |
*** jdandrea has quit IRC | 08:32 | |
*** q3k has joined #openstack-nova | 08:32 | |
*** hanzhang has quit IRC | 08:33 | |
*** jichen_ has joined #openstack-nova | 08:35 | |
*** derekh has joined #openstack-nova | 08:35 | |
*** jichen has quit IRC | 08:36 | |
*** jichen_ is now known as jichen | 08:36 | |
*** markvoelker has joined #openstack-nova | 08:36 | |
mdbooth | So yesterday, after a delay of only 7 months, I finally got merged a patch which fixed a race on one of the most critical paths in Nova | 08:36 |
mdbooth | When things started failing, because they were racing, the fix was to revert the patch which was pointing it out | 08:37 |
mdbooth | Shoot the messenger :) | 08:37 |
*** yassine_ has joined #openstack-nova | 08:37 | |
ndipanov | ahahaha | 08:37 |
mdbooth | That's the Nova way | 08:37 |
mdbooth | Kwalitee | 08:37 |
ndipanov | what was the revert | 08:37 |
mdbooth | https://review.openstack.org/#/c/201771/ | 08:37 |
johnthetubaguy | kfox1111: sorry, I can't find the context for your comment in the scrollback, probably best to send me an email | 08:37 |
ndipanov | mdbooth, do you have the link to the revert? | 08:38 |
mdbooth | Here's a documented failure: https://bugs.launchpad.net/nova/+bug/1474550 | 08:38 |
openstack | Launchpad bug 1474550 in OpenStack Compute (nova) "network allocation randomly failing with InstanceUpdateConflict after compare and swap was merged" [High,Fix committed] - Assigned to Matt Riedemann (mriedem) | 08:38 |
mdbooth | ndipanov: Above review is the revert | 08:38 |
mdbooth | Interestingly, the revert took only a few hours to be approved, all of which I was asleep for | 08:38 |
* mdbooth fucks off back to downstream land | 08:39 | |
johnthetubaguy | we need someone to help sort out the bug queue, its a total mess | 08:39 |
johnthetubaguy | well, thats a bit unfair, but we have no idea what gremlins are in there | 08:39 |
ndipanov | reverts should not be taken personally | 08:40 |
mdbooth | ndipanov: Yeah, I know | 08:40 |
mdbooth | I sorta don't disagree, either | 08:40 |
mdbooth | However, it would be nice if somebody had looked harder at what was racing | 08:41 |
mdbooth | Rather than just taking out the code which detected the race | 08:41 |
*** Jeffrey4l has quit IRC | 08:41 | |
mdbooth | That's just absurdly fast, considering it took 7 months to get in | 08:41 |
johnthetubaguy | mdbooth: if it blocks the gate, people jump really really quickly | 08:42 |
ndipanov | and that's imho wrong as I've ranted several times before.... it gives bugs unreasonable boost in priority | 08:42 |
gmann | johnthetubaguy: Updated specs for v2.1 bug. Please have look- https://review.openstack.org/#/c/198622/ and this too- https://review.openstack.org/#/c/198184/ | 08:42 |
johnthetubaguy | ndipanov: gate bugs block everyone though, so its good to get people unblocked right? | 08:43 |
ndipanov | yes but that's "tragedy of the commons" approach | 08:43 |
kashyap | johnthetubaguy: markus_z (not around yet) is doing a bunch of nice bug cleanup work. See his email thread on the list. | 08:43 |
johnthetubaguy | ndipanov: I don't get that | 08:43 |
ndipanov | I imagine moving a bunch of stuff out of the integrated tempest | 08:43 |
*** yuntong has joined #openstack-nova | 08:44 | |
johnthetubaguy | kashyap: he is yeah, going to meet with him about becoming the bug czar, and chat through some ideas | 08:44 |
ndipanov | since it's just too wide of a net | 08:44 |
ndipanov | would help it | 08:44 |
kashyap | johnthetubaguy: Nice. | 08:45 |
*** lyanchih has quit IRC | 08:45 | |
*** ociuhandu has quit IRC | 08:45 | |
*** markvoelker has quit IRC | 08:45 | |
johnthetubaguy | ndipanov: would that not just mean more bugs we don't find? I mean there is trade off between the integrated gate and the nova check queue, agreed with that | 08:45 |
*** lyanchih has joined #openstack-nova | 08:46 | |
ndipanov | johnthetubaguy, well it's far from a simple problem | 08:46 |
ndipanov | :) | 08:46 |
johnthetubaguy | ndipanov: totally agreed | 08:46 |
ndipanov | but the thing is that fixing a race in tempest means just that | 08:47 |
ndipanov | we heavily optimize for the tempest path to be bug-free | 08:47 |
*** tpeoples has quit IRC | 08:47 | |
ndipanov | and I am not sure how that correlates to users having a bug free experience | 08:47 |
ndipanov | it obviously does of course | 08:48 |
*** hanzhang has joined #openstack-nova | 08:49 | |
johnthetubaguy | thats mostly why I want a push to make sure the CI covers what people care about | 08:49 |
openstackgerrit | garyk proposed openstack/nova: libvirt: improve logging in the driver.py code https://review.openstack.org/200123 | 08:49 |
ndipanov | johnthetubaguy, that's not an easy problem for sure | 08:50 |
johnthetubaguy | it does seems to catch real things that would be otherwise hard to pin down | 08:50 |
ndipanov | johnthetubaguy, but we don't know how many real things a more focused test suite that does not block the world would catch | 08:51 |
ndipanov | (maybe we don't want to know :)) | 08:51 |
*** markvoelker has joined #openstack-nova | 08:51 | |
ndipanov | but if matt's patch uncovers that a bug he claims is there happens more often than we thought and our reaction is to pull it out (rightfully so) - maybe that's the kind of thing we should allow people to do | 08:53 |
ndipanov | anyway just thinking out loud | 08:53 |
johnthetubaguy | sorry, just lost internet there, stupid BT | 08:54 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: Allow for migration object to be passed to _move_claim https://review.openstack.org/199679 | 08:54 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: rt: generalize claim code to be useful for other move actions https://review.openstack.org/197138 | 08:54 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: rt: move filtering of mygration by type lower in the call stack https://review.openstack.org/199678 | 08:54 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: compute: Make rebuild_instance RPC take an optional migration https://review.openstack.org/200485 | 08:54 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: Define migration states and transitions and use when changing status https://review.openstack.org/197669 | 08:54 |
openstackgerrit | Nikola Dipanov proposed openstack/nova: Introduce a simple state machine module https://review.openstack.org/197668 | 08:54 |
*** Jeffrey4l has joined #openstack-nova | 08:55 | |
johnthetubaguy | ndipanov: I think putting it back so it just logs the error, and track that in ER is the right way | 08:55 |
johnthetubaguy | well, not the right way, a way that could work with our tooling, I think | 08:55 |
johnthetubaguy | mriedem_away: sdague: curious if we have someone working on an ER replacement for this revert? https://review.openstack.org/#/c/201771/ | 08:56 |
*** markvoelker has quit IRC | 08:56 | |
* mdbooth is currently looking at the circumstances of the reported failure | 08:57 | |
ndipanov | johnthetubaguy, that would be a good step forward | 08:57 |
ndipanov | need to go afk for a bit | 08:58 |
ndipanov | mdbooth, I'd suggest to re-propose with logging instead of failing | 08:58 |
johnthetubaguy | FWIW I would love to see us spend some time to convert instance save to compare and swap, with retry, that would be an awesome thing to get in | 08:58 |
*** lucasagomes is now known as lucas-afk | 08:58 | |
mdbooth | johnthetubaguy: My initial version had retry, but I took it out for simplicity | 08:59 |
mdbooth | However, even with retry you have to fail eventually | 08:59 |
johnthetubaguy | mdbooth: yeah, true | 08:59 |
*** markus_z has joined #openstack-nova | 09:00 | |
johnthetubaguy | mdbooth: I wonder if the retry would work in a similar way to the deadlock decorator, I guess its not that simple in this case | 09:00 |
mdbooth | I'm trying to work out the circumstances which would have resulted in this exception being raise | 09:00 |
mdbooth | d | 09:00 |
johnthetubaguy | mdbooth: that would be awesome | 09:00 |
mdbooth | Because it suggests that we conflicted, then unconflicted rapidly | 09:00 |
mdbooth | Or something else subtle is going on | 09:01 |
johnthetubaguy | mdbooth: oh, like API racing nova-compute periodic task, or something like that? | 09:01 |
mdbooth | I'm trying to correlate n-api with n-cpu | 09:01 |
mdbooth | I assume that's a sane thing to do? | 09:02 |
johnthetubaguy | the logs should be all on the same box, so that should work I guess | 09:02 |
*** derekh has quit IRC | 09:02 | |
johnthetubaguy | but its a good place to look | 09:02 |
johnthetubaguy | I mean the nova-conductor does the final db write, but the compute should tell you why, I guess | 09:02 |
haypo | /win 11 | 09:03 |
mdbooth | johnthetubaguy: I don't see an error in n-cond, which I was expecting | 09:04 |
johnthetubaguy | gmann: you might want to add those spec reviews to the nova meeting agenda, they are technically exception requests, but they are valid ones | 09:04 |
johnthetubaguy | mdbooth: oh, only an error in API? | 09:04 |
mdbooth | No, only in n-cpu | 09:05 |
johnthetubaguy | mdbooth: oh, freaky | 09:05 |
mdbooth | http://logs.openstack.org/85/197185/10/gate/gate-tempest-dsvm-cells/7ef1949/logs/screen-n-cpu.txt.gz | 09:05 |
mdbooth | At 16:39:06.862 | 09:05 |
gmann | johnthetubaguy: sure, Thanks | 09:05 |
mdbooth | The rpc call to conductor is in the stack trace | 09:05 |
mdbooth | The returned error has _Remote appended to it, which I'm not familiar with but assume is a standard wrapper | 09:06 |
*** markvoelker has joined #openstack-nova | 09:06 | |
haypo | hi. my python3 patches https://review.openstack.org/#/c/197748/ & https://review.openstack.org/#/c/197982/ have been approved last thursday but then failed to be merged because of the mock 1.1 storm and simple conflict issues (on the whitelist of py3 tests tox.ini). can someone please reapprove them? | 09:07 |
mdbooth | I don't see anything in the conductor logs... | 09:08 |
openstackgerrit | sahid proposed openstack/nova: libvirt: make unit tests concise by setup guest object https://review.openstack.org/190963 | 09:09 |
openstackgerrit | sahid proposed openstack/nova: libvirt: introduce method to wait for block device job https://review.openstack.org/190214 | 09:09 |
openstackgerrit | sahid proposed openstack/nova: libvirt: make host return guest information https://review.openstack.org/191046 | 09:09 |
openstackgerrit | sahid proposed openstack/nova: libvirt: make host return power state of guest https://review.openstack.org/191047 | 09:09 |
sahid | sdague: hello, if you have a moment to see this https://review.openstack.org/#/c/176242/ i replied to you, thanks | 09:10 |
johnthetubaguy | mdbooth: yeah, those conductor logs look very empty | 09:10 |
johnthetubaguy | mdbooth: :S | 09:10 |
*** markvoelker has quit IRC | 09:10 | |
gmann | johnthetubaguy: under which section in meeting agenda - https://wiki.openstack.org/wiki/Meetings/Nova | 09:11 |
gmann | johnthetubaguy: it present in https://etherpad.openstack.org/p/liberty-nova-priorities-tracking | 09:14 |
gmann | johnthetubaguy: should i explicitly mention in agenda too? | 09:14 |
johnthetubaguy | mdbooth: oh, this is in cells mode... I wonder if we have two conductors and are missing it | 09:15 |
*** yamahata has joined #openstack-nova | 09:15 | |
mdbooth | Do we have the possibility of anything else making db modifications? | 09:16 |
johnthetubaguy | gmann: explicitly mention it is best, maybe in the open discussion, just add a bullet referencing your spec reviews, and that they are a bug fix that requires a spec | 09:16 |
gmann | johnthetubaguy: ok | 09:16 |
*** gszasz has joined #openstack-nova | 09:16 | |
johnthetubaguy | mdbooth: with cells the nova-cells process makes DB changes too | 09:17 |
johnthetubaguy | mdbooth: you basically run the api.py twice | 09:17 |
mdbooth | Would it make changes to an instance's vm_state? | 09:17 |
mdbooth | Or do anything else to an instance? | 09:17 |
*** ZZelle has joined #openstack-nova | 09:18 | |
johnthetubaguy | mdbooth: it would create the instance in the child DB, and there is a bit of state syncing, I can't think of anything specific to this case though | 09:18 |
*** yamahata has quit IRC | 09:20 | |
*** markvoelker has joined #openstack-nova | 09:20 | |
*** kiran-r has quit IRC | 09:21 | |
*** aarefiev has quit IRC | 09:22 | |
*** ccard has joined #openstack-nova | 09:23 | |
johnthetubaguy | mdbooth: so that might be the change that triggered things, maybe its just causing issues with cells jobs more than others | 09:23 |
mdbooth | http://logs.openstack.org/85/197185/10/gate/gate-tempest-dsvm-cells/7ef1949/logs/screen-n-cell-region.txt.gz | 09:23 |
mdbooth | Look at 16:39:08.358 | 09:24 |
mdbooth | There's a cells failure | 09:24 |
mdbooth | This is just over a second *after* the n-cpu error | 09:24 |
mdbooth | However, something there is clearly touching the instance object | 09:25 |
*** markvoelker has quit IRC | 09:25 | |
mdbooth | I can't immediately see what the entry to that stack trace is, though | 09:25 |
mdbooth | It starts at _process_locally, which isn't immediately revealing | 09:25 |
* mdbooth isn't at all familiar with cells | 09:26 | |
mdbooth | johnthetubaguy: Is this running on a different box? | 09:26 |
mdbooth | n-cell-region | 09:27 |
johnthetubaguy | there are all on the same box in the gate | 09:27 |
johnthetubaguy | here is process_locally, in case that helps, its a bit of a maze: https://github.com/openstack/nova/blob/master/nova/cells/messaging.py#L191 | 09:28 |
johnthetubaguy | it feels unrelated though | 09:28 |
*** akscram has left #openstack-nova | 09:28 | |
johnthetubaguy | there are two databases in the cells setup | 09:29 |
johnthetubaguy | the region talks to one, the child cell cells, conductor and nova compute talk to the other | 09:29 |
*** humble_ has quit IRC | 09:29 | |
johnthetubaguy | mdbooth: it feels like we need to add more logging to find the cause of that race | 09:30 |
mdbooth | What if the region db was the same as the child db | 09:31 |
*** doude has quit IRC | 09:31 | |
*** andreykurilin__ has joined #openstack-nova | 09:31 | |
johnthetubaguy | mdbooth: thats not possible in cells, AFAIK | 09:34 |
mdbooth | What would call instance_update_at_top()? | 09:34 |
johnthetubaguy | instance.save() | 09:35 |
*** markvoelker has joined #openstack-nova | 09:35 | |
mdbooth | And that would definitely write to the 'region' db, not the same one n-cpu is writing to | 09:35 |
mdbooth | indirectly | 09:35 |
johnthetubaguy | there is a reason we are trying to kill cells v1, its horrid | 09:35 |
johnthetubaguy | mdbooth: I think so | 09:35 |
*** dguitarbite has quit IRC | 09:36 | |
mdbooth | So, here's the thing | 09:36 |
johnthetubaguy | for context: https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L872 | 09:36 |
mdbooth | I added a patch which is probably, but not definitely, going to expose a long-standing bug in cells | 09:36 |
mdbooth | But it was reverted | 09:36 |
mdbooth | We're making our own lives difficult, here | 09:37 |
johnthetubaguy | so it blocked people landing code, so it got reverted, while folks work on an alternative | 09:37 |
johnthetubaguy | no I don't know who if anyone, is doing the last bit of the above statement | 09:38 |
johnthetubaguy | s/no/now/ | 09:38 |
johnthetubaguy | usually folks are quite good on following up on a revert, particularly one like that | 09:39 |
mdbooth | My expectation: the race condition will be allowed to remain, because nobody will bother to find and fix the bug | 09:39 |
* mdbooth has low expectations | 09:39 | |
johnthetubaguy | yeah, agreed thats bad, and shouldn't happen | 09:40 |
*** markvoelker has quit IRC | 09:40 | |
mdbooth | I wonder if it's some race triggered by a notification | 09:40 |
mdbooth | This is supposition at this point | 09:40 |
johnthetubaguy | if we can convert it to a non-fatal race detection, that would be cool | 09:40 |
johnthetubaguy | a notification? | 09:40 |
mdbooth | So, the instance update starts, it sends a notification | 09:41 |
mdbooth | event | 09:41 |
mdbooth | Something | 09:41 |
mdbooth | Something responding to that triggers a write to the instance | 09:41 |
mdbooth | And it races with the instance update which originally triggered it | 09:41 |
johnthetubaguy | oh, that sounds like the neutron call back, at least a little bit | 09:42 |
johnthetubaguy | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3354 | 09:43 |
johnthetubaguy | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6156 | 09:44 |
mdbooth | So, the _Remote exception suffix seems to be specific to cells | 09:44 |
johnthetubaguy | its possible the extra cells rpc calls means the race is more likely? | 09:44 |
johnthetubaguy | mdbooth: that just an RPC call, I assumed | 09:44 |
mdbooth | That's what I thought, but grep says no | 09:45 |
mdbooth | It's in cells/messaging | 09:45 |
johnthetubaguy | hmm, so thats interesting... | 09:45 |
johnthetubaguy | I had assumed update_instance_at_top was a cast, maybe its a call | 09:46 |
*** deepthi has joined #openstack-nova | 09:48 | |
*** dguitarbite has joined #openstack-nova | 09:48 | |
mdbooth | It's a cast | 09:49 |
*** markvoelker has joined #openstack-nova | 09:49 | |
johnthetubaguy | yeah, its just changed to send an object, but yeah, its a cast, so it can't trigger the exception really | 09:49 |
johnthetubaguy | it feels to me like a race in the neutron event processing of the call coming in from neutron vs recording the DB state after our call to neutron | 09:51 |
johnthetubaguy | although I can't put my finger on it :( | 09:52 |
*** doude has joined #openstack-nova | 09:53 | |
johnthetubaguy | thats rubbish, that code is not logging anything it should | 09:53 |
*** tobe has quit IRC | 09:54 | |
*** markvoelker has quit IRC | 09:54 | |
*** RA_ has joined #openstack-nova | 09:54 | |
*** andrearosa has quit IRC | 09:55 | |
*** RA_ has quit IRC | 09:55 | |
*** Kennan has joined #openstack-nova | 10:03 | |
*** Kennan2 has quit IRC | 10:03 | |
*** dims_ has joined #openstack-nova | 10:03 | |
*** park_ has quit IRC | 10:04 | |
*** markvoelker has joined #openstack-nova | 10:04 | |
*** dims_ has quit IRC | 10:05 | |
sdague | sahid: deprecated_for_removal is what I was thinking | 10:05 |
sdague | sahid: http://docs.openstack.org/developer/oslo.config/opts.html | 10:06 |
sdague | that lets you do some automated detection of deprecation | 10:06 |
*** mutoulbj has quit IRC | 10:07 | |
*** markvoelker has quit IRC | 10:08 | |
*** romainh has quit IRC | 10:10 | |
johnthetubaguy | haypo: got a question on the rebase, looks like you are removing tests in: https://review.openstack.org/#/c/197748/7 was that intentional? | 10:14 |
johnthetubaguy | haypo: in the previous revision it seems like you were only adding tests | 10:14 |
openstackgerrit | Sean Dague proposed openstack/nova: Cannot rebuild a instance booted from volume https://review.openstack.org/201458 | 10:17 |
*** tobe has joined #openstack-nova | 10:17 | |
*** IanGovett has joined #openstack-nova | 10:17 | |
*** markvoelker has joined #openstack-nova | 10:19 | |
*** shyu has quit IRC | 10:20 | |
*** shyu has joined #openstack-nova | 10:21 | |
andreykurilin__ | sdague, johnthetubaguy: hi! Can you review patches with requirements updates in novaclient? https://review.openstack.org/#/c/201838/4 I propose get it in and then rebase https://review.openstack.org/#/c/173834/4 on it. | 10:23 |
*** markvoelker has quit IRC | 10:23 | |
*** ajayaa has joined #openstack-nova | 10:23 | |
sdague | andreykurilin__: approved | 10:24 |
sdague | andreykurilin__: so if you want to rebase, I'll fast approve the other one | 10:26 |
sdague | though it is still failing tests | 10:26 |
andreykurilin__ | sdague: one moment | 10:26 |
sdague | andreykurilin__: any idea what's up with that endpoint not found error? keystone and nova seem to be working fine from my quick glance. | 10:28 |
andreykurilin__ | I don't know, but will try to find out | 10:29 |
andreykurilin__ | sdague: ^ | 10:29 |
sdague | andreykurilin__: thanks | 10:31 |
*** markvoelker has joined #openstack-nova | 10:33 | |
openstackgerrit | Andreas Scheuring proposed openstack/nova: Add macvtap as new virtual interface (vif) type to Nova's libvirt driver https://review.openstack.org/182283 | 10:34 |
*** rgerganov has joined #openstack-nova | 10:34 | |
*** markvoelker has quit IRC | 10:38 | |
*** kmartin has quit IRC | 10:40 | |
*** jamielennox is now known as jamielennox|away | 10:41 | |
*** coolsvap is now known as coolsvap|away | 10:41 | |
sahid | sdague: ack | 10:45 |
*** markvoelker has joined #openstack-nova | 10:48 | |
*** tobe has quit IRC | 10:48 | |
*** markvoelker has quit IRC | 10:54 | |
*** mutoulbj has joined #openstack-nova | 10:54 | |
mdbooth | Oh, that's unexpected | 10:59 |
mdbooth | status: 200 | 10:59 |
mdbooth | ... | 10:59 |
mdbooth | Body: ... status: ERROR | 10:59 |
mdbooth | I guess the http status is reserved for transport errors? | 10:59 |
*** jichen has quit IRC | 11:01 | |
*** markvoelker has joined #openstack-nova | 11:02 | |
sdague | mdbooth: what was the request? | 11:03 |
mdbooth | http://logs.openstack.org/85/197185/10/gate/gate-tempest-dsvm-cells/7ef1949/logs/testr_results.html.gz | 11:03 |
sdague | typically we set status to not 200, but there might be calls where errors happen in a really weird way | 11:04 |
mdbooth | I wonder if that's a missing part of this puzzle | 11:04 |
mdbooth | The 'really weird way' | 11:04 |
sdague | oh, no that's the GET | 11:05 |
sdague | that's effectively the status call | 11:05 |
sdague | so, yes, in these cases 200 because "yes, you can get status" and "error" is the status | 11:05 |
*** afazekas has quit IRC | 11:05 | |
mdbooth | Ah... ok | 11:05 |
mdbooth | Just misreading that, then, thanks | 11:06 |
sdague | 2015-07-14 16:39:08,670 8785 INFO [tempest_lib.common.rest_client] Request (DeleteServersTestJSON:test_delete_server_while_in_building_state): 200 GET http://127.0.0.1:8774/v2/ee1fa65c56da464bbf5586e53f76b3c0/servers/f143b952-9edd-4971-86fe-227d61294a76 0.120s | 11:06 |
*** lyanchih has quit IRC | 11:06 | |
sdague | that's the request that's getting made | 11:06 |
mdbooth | Ok, that's just doing a metadata dump | 11:06 |
mdbooth | And the status is of the instance is ERROR | 11:06 |
mdbooth | There was no error in the call | 11:06 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: libvirt:Rsync remote FS driver was added https://review.openstack.org/146887 | 11:06 |
mdbooth | Got it | 11:07 |
sdague | yep | 11:07 |
mdbooth | Thanks | 11:07 |
*** markvoelker has quit IRC | 11:07 | |
mdbooth | That means I'm still looking for the elusive initial call | 11:07 |
andreykurilin__ | sdague: I don't know the root of issue, but it looks like tests can't access to global environment. `user = os.environ['OS_USERNAME']` ==> KeyError: 'OS_USERNAME'. Should we backport your and Monty's patches to get credentials from file? | 11:08 |
*** asselin has quit IRC | 11:09 | |
*** ociuhandu has joined #openstack-nova | 11:10 | |
sdague | mdbooth: typically just start searching all the nova logs for the uuid of the instance | 11:10 |
sdague | http://logs.openstack.org/85/197185/10/gate/gate-tempest-dsvm-cells/7ef1949/logs/screen-n-cell-region.txt.gz#_2015-07-14_16_39_08_358 is my guess of where the relevant explode is here | 11:11 |
mdbooth | sdague: That's too late | 11:11 |
sdague | andreykurilin__: oh, this is stable/kilo? | 11:11 |
mdbooth | It happens almost 2 seconds before that | 11:11 |
andreykurilin__ | yes:( | 11:11 |
andreykurilin__ | I miss this | 11:11 |
sdague | mdbooth: no it doesn't, the GET call that finds the error happens 300ms after that event | 11:12 |
openstackgerrit | John Garbutt proposed openstack/nova: docs: add the scheduler evolution plans https://review.openstack.org/192260 | 11:13 |
mdbooth | There's another error in n-cpu which is before that | 11:13 |
sdague | anyway, it's somewhere down that path | 11:13 |
mdbooth | sdague: Although I'm going to take your advice on grepping for the instance uuid | 11:14 |
* mdbooth downloads all the logs | 11:14 | |
sdague | andreykurilin__: yeh so backporting those changes is probably the right plan | 11:14 |
andreykurilin__ | sdague: I suppose that we need to merge 3 changes(your and Monty's patches + update requirements) in one. | 11:15 |
*** markvoelker has joined #openstack-nova | 11:17 | |
andreykurilin__ | sdague: hm.. it looks like your change + update requirements will be enough | 11:17 |
*** baoli has joined #openstack-nova | 11:17 | |
*** mnestratov has joined #openstack-nova | 11:19 | |
johnthetubaguy | haypo: can I catch up about the python 3.4 work, we have the blueprint deadlines communing up, and I am just wanting to give you a heads up about those | 11:20 |
*** markvoelker has quit IRC | 11:21 | |
johnthetubaguy | dansmith: just checking about the robustly evacuate spec, as its not a priority spec, is that all up for review now? | 11:22 |
*** mpaolino has joined #openstack-nova | 11:22 | |
*** fawadkhaliq has quit IRC | 11:23 | |
*** markvoelker has joined #openstack-nova | 11:24 | |
mdbooth | In the context of gate-tempest-dsvm-cells, can anybody tell me what is the relationship between n-cell-child, n-cell-region, and n-api? | 11:25 |
*** MentalRay has joined #openstack-nova | 11:26 | |
mdbooth | I'm most in the dark about n-cell-child, tbh | 11:26 |
johnthetubaguy | alaski: can we mark this blueprint complete now? https://blueprints.launchpad.net/nova/+spec/cells-host-mapping | 11:26 |
mdbooth | I thought n-cell-region would talk to n-api | 11:26 |
mdbooth | What's listening on port 8774? | 11:26 |
johnthetubaguy | it kinda does, they share the same database | 11:26 |
johnthetubaguy | n-api | 11:26 |
mdbooth | How does n-cell-child receive messages? | 11:27 |
mdbooth | Exclusively from n-cell-region? | 11:27 |
*** openstack has joined #openstack-nova | 11:37 | |
*** alex_xu_ has quit IRC | 11:37 | |
*** alex_xu_ has joined #openstack-nova | 11:37 | |
*** ndipanov has joined #openstack-nova | 11:38 | |
*** ujjain has joined #openstack-nova | 11:38 | |
*** ujjain has quit IRC | 11:38 | |
*** ujjain has joined #openstack-nova | 11:38 | |
*** lucas-afk has joined #openstack-nova | 11:38 | |
haypo | johnthetubaguy: https://review.openstack.org/#/c/197748/7/tox.ini -- i didn't removed any test, they are just moved below. they were not sorted correctly ;-) | 11:38 |
sdague | mdbooth: I'm pretty sure it's all over rabbit | 11:38 |
*** openstackstatus has joined #openstack-nova | 11:38 | |
*** ChanServ sets mode: +v openstackstatus | 11:38 | |
mdbooth | sdague: Do you know where the service is configured? | 11:38 |
mdbooth | I can't find the entry point | 11:39 |
*** markvoelker has joined #openstack-nova | 11:39 | |
johnthetubaguy | haypo: ah, gotcah | 11:39 |
sdague | http://docs.openstack.org/kilo/config-reference/content/section_compute-cells.html - best I've got there, I don't know much of the cells internals, just the high level stuff | 11:39 |
haypo | johnthetubaguy: what is the blueprint deadline? | 11:40 |
mdbooth | Thanks | 11:40 |
johnthetubaguy | mdbooth: what entry point are you wanting to find? | 11:40 |
mdbooth | Warning | 11:40 |
mdbooth | Cell functionality is currently considered experimental | 11:40 |
johnthetubaguy | mdbooth: its probably the cellsm | 11:40 |
johnthetubaguy | I mean cells/manager.py | 11:40 |
johnthetubaguy | haypo: I posted on the ML, let me get the link | 11:41 |
mdbooth | screen-n-cell-child.txt.gz:2015-07-14 16:39:06.641 DEBUG nova.compute.api [req-b288f57a-c499-4bbf-a5ba-da5048201e8d tempest-DeleteServersTestJSON-193542712 tempest-DeleteServersTestJSON-409686918] [instance: f143b952-9edd-4971-86fe-227d61294a76] Going to try to terminate instance delete /opt/stack/new/nova/nova/compute/api.py:1830 | 11:41 |
*** erlon has joined #openstack-nova | 11:41 | |
mdbooth | So that's cell-child deleting an instance | 11:41 |
*** ociuhandu_ has joined #openstack-nova | 11:41 | |
*** ociuhandu has quit IRC | 11:41 | |
*** ociuhandu_ is now known as ociuhandu | 11:41 | |
mdbooth | What told it to do that, and what db is it deleting it in? | 11:41 |
haypo | johnthetubaguy: oh, i see [openstack-dev] [nova] Reminder: July 16 is non-priority feature proposal freeze | 11:41 |
johnthetubaguy | mdbooth: its the delete call in compate/api.py that gets routed down to the run compute api method on the cells manager, I think | 11:42 |
johnthetubaguy | haypo: yeah, thats the one, python3.4 is not a priority item, so I am thinking we move to to NeedsCodeReview tomorrow to cover the work we have done for liberty | 11:42 |
haypo | johnthetubaguy: python3 has its section at https://etherpad.openstack.org/p/liberty-nova-priorities-tracking | 11:43 |
haypo | johnthetubaguy: ah, it's in the "Sub team "Ready for Review" lists" section | 11:43 |
*** markvoelker has quit IRC | 11:44 | |
johnthetubaguy | haypo: yeah, the priorities are defined here: http://specs.openstack.org/openstack/nova-specs/priorities/liberty-priorities.html | 11:45 |
johnthetubaguy | (as agreed when that patch gets added to the specs repo after the summit) | 11:45 |
*** fawadkhaliq has quit IRC | 11:45 | |
*** Jeffrey4l_ has quit IRC | 11:46 | |
haypo | johnthetubaguy: no problem. i do my best to port as much code to python 3, and i understand that they are more important stuff | 11:46 |
haypo | johnthetubaguy: at least, the gate became voting. we cannot go backward ;) | 11:47 |
johnthetubaguy | haypo: yeah, thats good stuff | 11:47 |
*** dims_ has joined #openstack-nova | 11:47 | |
johnthetubaguy | haypo: we should be able to open up as soon as we open for M, I hope we can do this in a "smoother" way in the future with runways, but we are just not there yet | 11:48 |
haypo | johnthetubaguy: i'm proposing a talk "status of openstack port to python3" for tokyo ;) | 11:48 |
haypo | johnthetubaguy: it took a little bit longer than i expect to reach the milestone "voting py34 gate" | 11:48 |
haypo | johnthetubaguy: with a voting gate, it becomes safer and simpler to work on python 3 | 11:48 |
haypo | by the way, i would be nice to drop mysql-python and switch to pymysql, as done in other projects: https://review.openstack.org/#/c/184387/ | 11:49 |
johnthetubaguy | haypo: so that change is not tracked anywhere, we need to get that priority raised up, I had assumed we did that already :S | 11:52 |
*** MentalRay_ has joined #openstack-nova | 11:53 | |
*** pradipta has joined #openstack-nova | 11:53 | |
johnthetubaguy | sdague: does this look OK to you now? https://review.openstack.org/#/c/184387/3 | 11:53 |
*** markvoelker has joined #openstack-nova | 11:54 | |
*** Alexei_987 has quit IRC | 11:54 | |
*** MentalRay has quit IRC | 11:54 | |
openstackgerrit | Ritesh proposed openstack/python-novaclient: Fix to set value for name using nova list --fields option https://review.openstack.org/202062 | 11:54 |
*** jichen has joined #openstack-nova | 11:54 | |
*** exploreshaifali has joined #openstack-nova | 11:55 | |
*** jichen has quit IRC | 11:56 | |
*** Alexei_987 has joined #openstack-nova | 11:56 | |
dims_ | sdague: johnthetubaguy: a couple of oslo reviews have been waiting for a bit, please take a look when you get a chance (oslo.service - https://review.openstack.org/#/c/192900/ and oslo.reports - https://review.openstack.org/#/c/195558/) | 11:56 |
johnthetubaguy | dims_: can you add those to the blueprint, that should get them more attention, I would hope: https://blueprints.launchpad.net/nova/+spec/liberty-olso-sync | 11:57 |
dims_ | ack thanks johnthetubaguy | 11:57 |
*** jichen has joined #openstack-nova | 11:57 | |
*** markvoelker has quit IRC | 11:58 | |
*** dguitarbite has quit IRC | 12:00 | |
* johnthetubaguy runs away for some food | 12:03 | |
*** Jeffrey4l_ has joined #openstack-nova | 12:04 | |
*** romainh has joined #openstack-nova | 12:05 | |
*** jichen_ has joined #openstack-nova | 12:05 | |
*** jichen has quit IRC | 12:06 | |
*** jichen_ is now known as jichen | 12:06 | |
sdague | dims_: so..... because this breaks all the time, has oslo.service been tested for service shutdown? | 12:07 |
sdague | with multiple workers | 12:07 |
sdague | reports I'm good with | 12:08 |
*** markvoelker has joined #openstack-nova | 12:08 | |
dims_ | sdague: yes, both neutron and nova has been tested | 12:11 |
dims_ | sdague: that was the primary directive :) | 12:12 |
sdague | dims_: for service shutdown? | 12:12 |
sdague | because that blows up in grenade a lot, in very subtle ways | 12:12 |
*** markvoelker has quit IRC | 12:13 | |
sdague | dims_: do me a favor, and stack a random devstack change on top of that. We've got this updown test in there which I'd like to see run a few times to feel better about this change. | 12:13 |
dims_ | sdague: ack, good feedback will do | 12:14 |
sdague | if we get 3 good runs out of that, I'll +2 | 12:14 |
dims_ | sdague: awesome! :) | 12:14 |
*** tobe has joined #openstack-nova | 12:15 | |
*** tobe has quit IRC | 12:18 | |
*** tobe has joined #openstack-nova | 12:19 | |
*** jichen has quit IRC | 12:20 | |
*** jichen has joined #openstack-nova | 12:20 | |
openstackgerrit | Radoslav Gerganov proposed openstack/nova: VMware: Use virtual disk size instead of image size https://review.openstack.org/168013 | 12:21 |
*** markvoelker has joined #openstack-nova | 12:23 | |
*** tobe has quit IRC | 12:24 | |
*** andrearosa has joined #openstack-nova | 12:25 | |
*** jecarey has joined #openstack-nova | 12:25 | |
*** raildo has joined #openstack-nova | 12:26 | |
*** liusheng has quit IRC | 12:26 | |
*** _gryf has quit IRC | 12:27 | |
*** garyk has joined #openstack-nova | 12:27 | |
*** markvoelker has quit IRC | 12:28 | |
alex_xu_ | dansmith: would you like take a look at https://review.openstack.org/199971 | 12:31 |
*** sudipto_ has quit IRC | 12:32 | |
*** dprince has joined #openstack-nova | 12:34 | |
*** edmondsw has joined #openstack-nova | 12:35 | |
*** markvoelker has joined #openstack-nova | 12:37 | |
markus_z | If someone wants an easy review: https://review.openstack.org/#/c/188058/ | 12:37 |
*** deepthi has quit IRC | 12:39 | |
garyk | markus_z: can you give us a hard one :) | 12:39 |
*** aysyd has joined #openstack-nova | 12:39 | |
markus_z | garyk: maybe in the next cycle ;) | 12:40 |
openstackgerrit | sahid proposed openstack/nova: libvirt: enhance method to return pointer_model from image prop https://review.openstack.org/174854 | 12:40 |
openstackgerrit | sahid proposed openstack/nova: libvirt: deprecate use_usb_tablet in favor of pointer_model https://review.openstack.org/176242 | 12:40 |
*** dims_ has quit IRC | 12:41 | |
*** bnemec has joined #openstack-nova | 12:41 | |
*** whenry__ has quit IRC | 12:41 | |
*** markvoelker has quit IRC | 12:42 | |
*** Alexei_987 has quit IRC | 12:43 | |
*** afazekas has joined #openstack-nova | 12:44 | |
*** exploreshaifali has quit IRC | 12:45 | |
*** Alexei_987 has joined #openstack-nova | 12:46 | |
*** signed8bit has joined #openstack-nova | 12:48 | |
garyk | markus_z: i gave some overly pedantic comments. let me know if they are ok. | 12:49 |
*** hanzhang has quit IRC | 12:49 | |
garyk | i think that an UpgradeImpact is necessary in the commit message. | 12:49 |
openstackgerrit | sahid proposed openstack/nova: libvirt: add cpu schedular priority config https://review.openstack.org/197567 | 12:50 |
openstackgerrit | sahid proposed openstack/nova: libvirt: rework membacking config to support future features https://review.openstack.org/197566 | 12:50 |
openstackgerrit | sahid proposed openstack/nova: virt: add contraint to handle realtime policy https://review.openstack.org/197568 | 12:50 |
*** hanzhang has joined #openstack-nova | 12:50 | |
openstackgerrit | sahid proposed openstack/nova: libvirt: add realtime support https://review.openstack.org/197569 | 12:50 |
markus_z | garyk: Even if the impact of the upgrade is not visible to guests? | 12:51 |
*** markvoelker has joined #openstack-nova | 12:52 | |
markus_z | garyk: oh, wait, I think I understand it now what you say. | 12:52 |
*** deepthi has joined #openstack-nova | 12:52 | |
garyk | yup my point is that today my instances behave in one way and after this patch they will behave in another | 12:53 |
garyk | so we need whoever is going to read the release notes (yup there is such a thing) to at least have a heads up that something may change | 12:53 |
garyk | greenfield installations are cool | 12:53 |
*** ferest has joined #openstack-nova | 12:54 | |
garyk | markus_z: i think that it would also be good if you can get danpb or sahid to chime in | 12:54 |
garyk | now on a more serious note, when does the october fest start? | 12:55 |
markus_z | garyk: Yes, good point, I did miss the upgrade thought completely. | 12:55 |
*** eharney has joined #openstack-nova | 12:55 | |
markus_z | garyk: Mid of September, logically :) | 12:56 |
*** markvoelker has quit IRC | 12:56 | |
*** mdrabe has joined #openstack-nova | 12:57 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Raise exception when API does't support microversions https://review.openstack.org/188816 | 12:58 |
*** yassine_ has quit IRC | 12:59 | |
*** jaypipes has joined #openstack-nova | 12:59 | |
*** vladikr has joined #openstack-nova | 13:00 | |
*** markvoelker has joined #openstack-nova | 13:01 | |
*** shuquan has joined #openstack-nova | 13:05 | |
*** dims_ has joined #openstack-nova | 13:06 | |
*** yassine_ has joined #openstack-nova | 13:08 | |
*** markvoelker has quit IRC | 13:09 | |
*** markvoelker has joined #openstack-nova | 13:09 | |
*** signed8bit is now known as signed8bit_ZZZzz | 13:10 | |
*** rlrossit has joined #openstack-nova | 13:10 | |
*** markvoelker_ has joined #openstack-nova | 13:10 | |
*** kiran-r has joined #openstack-nova | 13:10 | |
*** signed8bit_ZZZzz has quit IRC | 13:10 | |
*** thangp has joined #openstack-nova | 13:11 | |
sahid | hum so the spec freeze was June 25 and we have about 15working days to implement the spec? | 13:12 |
alaski | johnthetubaguy: yes, https://blueprints.launchpad.net/nova/+spec/cells-host-mapping is complete now | 13:12 |
johnthetubaguy | alaski: cool, thanks, just updated the blueprint to mark it as implemented | 13:13 |
johnthetubaguy | that was the scripts will pick it up when we try to release liberty-2 | 13:13 |
*** markvoelker has quit IRC | 13:14 | |
openstackgerrit | John Garbutt proposed openstack/nova-specs: Pass Down the Instance Name to Ironic Driver https://review.openstack.org/189850 | 13:14 |
alaski | mdbooth: cell-child receives messages from cell-region and compute, the main purpose for cell-region and cell-child is to proxy messages from api->compute or replicate db updates from a cell to the global db | 13:14 |
alaski | mdbooth: but the InstanceUpdateConflict was happening on non cells jobs as well, though I don't know with what frequency | 13:15 |
*** krtaylor has joined #openstack-nova | 13:16 | |
*** ijuwang has joined #openstack-nova | 13:17 | |
*** READ10 has joined #openstack-nova | 13:17 | |
*** ivasev has joined #openstack-nova | 13:18 | |
*** shuquan has quit IRC | 13:18 | |
*** kiran-r has quit IRC | 13:18 | |
*** lucas-afk is now known as lucasagomes | 13:20 | |
*** READ10 has quit IRC | 13:20 | |
*** baoli has quit IRC | 13:20 | |
*** shuquan has joined #openstack-nova | 13:21 | |
*** ivasev has quit IRC | 13:22 | |
*** ferest has quit IRC | 13:23 | |
*** shuquan has quit IRC | 13:26 | |
*** READ10 has joined #openstack-nova | 13:26 | |
*** shuquan has joined #openstack-nova | 13:27 | |
mriedem_away | alaski: mdbooth: johnthetubaguy: it actually happened in mostly non-cells jobs http://goo.gl/2wfzoV | 13:27 |
mriedem_away | since it was in the integrated gate and was a race that had nothing to do with cells from what i can tell | 13:27 |
mriedem_away | the point is, we have checks for UnexpectedTaskStateError and UnexpectedVMStateError in delete paths in the code and InstanceUpdateConflict wasn't being handled like those, | 13:28 |
mriedem_away | so if instance update compare and swap is re-proposed it needs to take the same error handling into account | 13:28 |
*** ivasev has joined #openstack-nova | 13:29 | |
alaski | +1 | 13:30 |
*** derekh has joined #openstack-nova | 13:30 | |
*** eglynn has joined #openstack-nova | 13:31 | |
*** samuel-dmq has quit IRC | 13:31 | |
*** samueldmq has joined #openstack-nova | 13:32 | |
*** zzzeek has joined #openstack-nova | 13:32 | |
mdbooth | mriedem_away: I don't see handling for UnexpectedVMStateError | 13:33 |
*** lyanchih has joined #openstack-nova | 13:34 | |
*** mriedem_away is now known as mriedem | 13:34 | |
*** dguitarbite has joined #openstack-nova | 13:34 | |
*** dguitarbite is now known as Guest4286 | 13:34 | |
mdbooth | UnexpectedTaskStateError is handled in a few places | 13:34 |
*** Guest4286 has quit IRC | 13:35 | |
mriedem | yeah, i'm more familiar with the latter | 13:35 |
*** dbite has joined #openstack-nova | 13:35 | |
*** chuckcarmack has joined #openstack-nova | 13:35 | |
*** dbite has quit IRC | 13:35 | |
*** oro_ has joined #openstack-nova | 13:35 | |
*** diogogmt has joined #openstack-nova | 13:36 | |
*** jdandrea has joined #openstack-nova | 13:37 | |
*** browne has joined #openstack-nova | 13:38 | |
*** Piet has quit IRC | 13:38 | |
*** signed8bit has joined #openstack-nova | 13:41 | |
*** kylek3h has joined #openstack-nova | 13:41 | |
*** agireud has joined #openstack-nova | 13:42 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Undo tox -e docs pip install sphinx workaround https://review.openstack.org/202113 | 13:42 |
*** jecarey has quit IRC | 13:43 | |
*** gyee has joined #openstack-nova | 13:43 | |
*** signed8b_ has joined #openstack-nova | 13:43 | |
*** signed8bit has quit IRC | 13:45 | |
*** jichen has quit IRC | 13:47 | |
*** garyk has quit IRC | 13:47 | |
*** jichen has joined #openstack-nova | 13:47 | |
*** jistr is now known as jistr|mtg | 13:49 | |
*** exploreshaifali has joined #openstack-nova | 13:49 | |
*** rdopiera has quit IRC | 13:51 | |
*** ankit_ag has quit IRC | 13:52 | |
*** burt has joined #openstack-nova | 13:53 | |
dansmith | alex_xu_: done | 13:54 |
*** LukeHinds has joined #openstack-nova | 13:57 | |
haypo | dims_, johnthetubaguy: i added https://review.openstack.org/#/c/197601/ "Replace parse_strtime() with parse_isotime()" to https://blueprints.launchpad.net/nova/+spec/liberty-olso-sync -- it's a patch to prepare nova to replace the strtime() function with the isoformat() method. currently a lot of warnings a logged | 13:58 |
dims_ | haypo: thanks | 13:59 |
*** pmcfadden has joined #openstack-nova | 13:59 | |
*** Piet has joined #openstack-nova | 14:00 | |
openstackgerrit | Dan Smith proposed openstack/nova: Revert "Remove useless db call instance_get_all_hung_in_rebooting" https://review.openstack.org/202124 | 14:01 |
dansmith | alex_xu_: ^ | 14:01 |
alex_xu_ | dansmith: thanks | 14:02 |
alex_xu_ | dansmith: when we should bump to 2.0 for object, when we drop the back-compatible? | 14:02 |
dansmith | alex_xu_: I wanted to do it for kilo, but the patches didn't get reviewed | 14:02 |
*** otter768 has joined #openstack-nova | 14:03 | |
dansmith | not sure I will have time to resurrect them for lemming, but I plan to try | 14:03 |
*** dboik has joined #openstack-nova | 14:03 | |
*** gszasz has quit IRC | 14:04 | |
*** diogogmt has quit IRC | 14:04 | |
*** rlrossit has left #openstack-nova | 14:04 | |
*** gszasz has joined #openstack-nova | 14:04 | |
lyanchih | guys please help to review this patch. https://review.openstack.org/#/c/201019/ | 14:04 |
alex_xu_ | dansmith: why we needn't bump major version when we remove method in rpc? like this https://github.com/openstack/nova/blob/master/nova/conductor/rpcapi.py#L167 | 14:04 |
dansmith | alex_xu_: let me look | 14:05 |
dansmith | alex_xu_: that is client side | 14:06 |
*** annegentle has joined #openstack-nova | 14:06 | |
dansmith | alex_xu_: which is just preventing new uses of the thing, but it's still in manager, which means older clients can still use the method | 14:07 |
dansmith | alex_xu_: since objects unify the client/server side for simplicity, you can't remove the client half | 14:07 |
*** ctrath has joined #openstack-nova | 14:07 | |
*** otter768 has quit IRC | 14:07 | |
alex_xu_ | dansmith: ah, I see now, thanks | 14:07 |
*** tonytan4ever has joined #openstack-nova | 14:10 | |
openstackgerrit | Belmiro Moreira proposed openstack/nova: Creates flavor* tables in API database https://review.openstack.org/201606 | 14:11 |
alex_xu_ | dansmith: sorry, let me ask more question. Before user upgrade to Liberty, his all code already upgrade to K, and in K we removed all usage of get_by_host_and_not_type already. so I still have a little confuse on why we can't remove in L. | 14:12 |
dansmith | alex_xu_: not everyone deploys from stable | 14:12 |
raildo | hi guys, I'm working to provide nested quotas here in nova, with this feature, a parent project will be able to set the quotas for their subprojects | 14:14 |
raildo | but during the implementation, we found a project_id check here: https://github.com/openstack/nova/blob/8fd7b44d1ae4fd919dfdab4aab358a3137708ff4/nova/api/openstack/wsgi.py#L805-L812 | 14:14 |
raildo | that prohibit make some action a project which isn't the project in the context. | 14:14 |
raildo | Do you know a way to don't make this check only for the quota update? | 14:14 |
*** doron has joined #openstack-nova | 14:15 | |
alex_xu_ | dansmith: ok, I see now, thanks | 14:16 |
*** jecarey has joined #openstack-nova | 14:17 | |
*** cfriesen has joined #openstack-nova | 14:18 | |
*** yamahata has joined #openstack-nova | 14:18 | |
*** doron_ has joined #openstack-nova | 14:18 | |
*** doron has quit IRC | 14:19 | |
*** mtanino has joined #openstack-nova | 14:20 | |
haypo | win 11 | 14:20 |
*** rlrossit has joined #openstack-nova | 14:24 | |
*** shuquan has quit IRC | 14:26 | |
ndipanov | so dansmith regarding this: https://review.openstack.org/#/c/201280/5 | 14:26 |
ndipanov | we have to merge the stable fix first :( | 14:26 |
dansmith | why? | 14:27 |
ndipanov | dansmith, is there a way for our CI to run a related stable kilo fix | 14:27 |
mriedem | ndipanov: nope | 14:27 |
ndipanov | so kilo code does not know about 1.2 | 14:27 |
openstackgerrit | lyanchih proposed openstack/nova: Creating instance fail when inject ssh key in cells mode https://review.openstack.org/197514 | 14:27 |
mriedem | i don't think depends-on works that way with grenade | 14:27 |
dansmith | mriedem: me either | 14:27 |
ndipanov | well it should | 14:27 |
*** xyang2 has joined #openstack-nova | 14:27 | |
mriedem | heh | 14:27 |
mriedem | well | 14:27 |
dansmith | ndipanov: they take patches | 14:27 |
mriedem | yeah, that | 14:28 |
ndipanov | lol | 14:28 |
mriedem | plus, this is probably very rare | 14:28 |
ndipanov | anywhoo | 14:28 |
dansmith | it's actually something we never want to happen, of course | 14:28 |
ndipanov | I'm pretty sure that that's what's happening | 14:28 |
dansmith | so supporting this would be rather counterproductive | 14:28 |
ndipanov | so what do you propose | 14:28 |
ndipanov | ? | 14:28 |
dansmith | I don't understand | 14:28 |
*** markvoelker has joined #openstack-nova | 14:28 | |
dansmith | we're not sending back 1.2, right? | 14:28 |
ndipanov | we are | 14:28 |
ndipanov | and deserializer drops it | 14:28 |
ndipanov | to 1.1 | 14:29 |
dansmith | that's not how that works | 14:29 |
*** tpeoples has joined #openstack-nova | 14:29 | |
ndipanov | it is | 14:29 |
dansmith | if the deserializer fails on the version, it bounces it | 14:29 |
dansmith | it can't just drop the version because it doesn't know how | 14:29 |
ndipanov | let me check again | 14:29 |
*** shuquan_ has joined #openstack-nova | 14:30 | |
*** markvoel_ has joined #openstack-nova | 14:31 | |
*** markvoelker has quit IRC | 14:31 | |
dansmith | aside from that, if we get the instance version that specifies 1.2 and we send 1.2 because of the updated relationship mapping, I see that kilo will fail because it doesn't know about 1.2 | 14:31 |
openstackgerrit | lyanchih proposed openstack/nova: NUMATopologyFilter raise exception and not continue filter next node https://review.openstack.org/200630 | 14:31 |
dansmith | because that's the goal, right? to get instance 1.19, pcidevicelist 1.2 and pcidevice 1.3 back to a kilo node, right? | 14:32 |
*** markvoelker_ has quit IRC | 14:32 | |
dansmith | and pcidevicelist 1.2 doesn't exist in kilo right now | 14:32 |
rlrossit | if that's what's really going on then that error message was very.... lacking | 14:32 |
*** shuquan_ has quit IRC | 14:32 | |
n0ano | mriedem, the CI team knows about the outage and is working on the issue, hopefully it'll be solved soon | 14:32 |
mriedem | n0ano: ok - how long did they know about it? :) | 14:33 |
dansmith | n0ano: it's been gone for >30 days :/ | 14:33 |
*** jistr|mtg is now known as jistr | 14:33 | |
*** markvoel_ has quit IRC | 14:33 | |
ndipanov | dansmith, right so it should get downgraded to 1.1 | 14:33 |
n0ano | not sure, I just got a report back this morning, I also indicated that they should notify at least the dev mailing list when something like this happens in the future | 14:33 |
ndipanov | not dropped | 14:33 |
dansmith | ndipanov: by asking conductor to do that | 14:34 |
ndipanov | yes | 14:34 |
dansmith | ndipanov: right, so that's why the fact that it seems completely missing on the client side is confusing | 14:34 |
*** deepthi has quit IRC | 14:34 | |
ndipanov | right | 14:34 |
n0ano | 30 days!! OK, now I have a bigger problem to deal with, that is just unacceptable | 14:35 |
haypo | https://review.openstack.org/#/c/197748/ merge failed because of "gate-tempest-dsvm-nova-v21-full: UNSTABLE". the link to the job logs is a dead link (File Not Found). is someone aware of the issue? | 14:35 |
*** Jeffrey4l_ has quit IRC | 14:36 | |
*** garyk has joined #openstack-nova | 14:37 | |
*** doron_ has left #openstack-nova | 14:37 | |
openstackgerrit | lyanchih proposed openstack/nova: Creating instance fail when inject ssh key in cells mode https://review.openstack.org/197514 | 14:39 |
haypo | for "gate-tempest-dsvm-nova-v21-full: UNSTABLE": we told me on #openstack-infra that some gates were renamed, a simple recheck (reverify) is enough | 14:40 |
*** signed8b_ is now known as signed8bit_ZZZzz | 14:42 | |
*** signed8bit_ZZZzz is now known as signed8b_ | 14:42 | |
*** ssurana has joined #openstack-nova | 14:43 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: libvirt: use log file and serial console at the same time https://review.openstack.org/188058 | 14:45 |
*** mutoulbj has quit IRC | 14:45 | |
openstackgerrit | Markus Zoeller (markus_z) proposed openstack/nova: libvirt: use log file and serial console at the same time https://review.openstack.org/188058 | 14:47 |
*** mutoulbj has joined #openstack-nova | 14:47 | |
*** Murali has quit IRC | 14:47 | |
*** jasondotstar has joined #openstack-nova | 14:49 | |
*** Jeffrey4l_ has joined #openstack-nova | 14:49 | |
*** gyee has quit IRC | 14:50 | |
*** tsekiyama has joined #openstack-nova | 14:50 | |
sdague | haypo: yes, that's correct | 14:51 |
sdague | a big job rename merged and the fully implication of rebuilding jobs was not anticipated, let to a brief outage | 14:51 |
*** markvoelker has joined #openstack-nova | 14:53 | |
haypo | sdague: no problem. it's just an advice if someone else get the same issue | 14:53 |
*** gyee has joined #openstack-nova | 14:54 | |
*** markvoelker_ has joined #openstack-nova | 14:54 | |
*** markvoelker has quit IRC | 14:58 | |
mdbooth | sdague: I posted a script to merge sort log files, btw. In retrospect I guess you already have a solution to this problem, but there it is. | 14:59 |
ndipanov | dansmith, just for my info | 14:59 |
sdague | mdbooth: honestly, I typically use browser tabs, because there is a lot of content in those logs and doing side by side is sometimes helpful | 15:00 |
mdbooth | I was getting lost in the ordering. Don't have a solution yet, so it remains to be seen if it's helpful :) | 15:01 |
ndipanov | why do we save a list of known versions in _obj_classes - so as to be able to register different versions? we don't ever use that in nova right? | 15:01 |
ndipanov | dansmith, ^ | 15:01 |
dansmith | ndipanov: we will when we bump the object versions to 2.0.. my prototype patches for that did | 15:01 |
dansmith | just like most of the time we only have one version implementation for the rpc apis, | 15:01 |
dansmith | except when we're spanning a major bump | 15:01 |
ndipanov | right | 15:02 |
jdandrea | Question about the "image" portion of /{tenant_id}/servers/detail - it's a dict when content exists, and "" when there's no content. http://paste.openstack.org/show/377789/ | 15:02 |
*** yamahata has quit IRC | 15:02 | |
garyk | alaski: any chance you can look at https://review.openstack.org/193889. i have tested this extensively | 15:02 |
*** yamahata has joined #openstack-nova | 15:02 | |
*** mdrabe has quit IRC | 15:03 | |
alaski | garyk: yes. sorry, I thought I had gotten to it | 15:03 |
garyk | thanks | 15:04 |
cfriesen | ndipanov: hopefully a quick question for you...in _numa_fit_instance_cell() we check "len(instance_cell.cpuset) > len(host_cell.cpuset)". What happens in the case where we have hugepages but floating CPUs? It seems like that check would not take cpu_allocation_ratio into account | 15:04 |
*** rdopiera has joined #openstack-nova | 15:04 | |
garyk | markus_z: thanks! | 15:05 |
markus_z | garyk: thank you! | 15:05 |
*** coreywright has quit IRC | 15:06 | |
*** diogogmt has joined #openstack-nova | 15:07 | |
*** sudipto has joined #openstack-nova | 15:09 | |
ndipanov | cfriesen, would have to check | 15:10 |
ndipanov | I remember this came up | 15:10 |
ndipanov | floating CPUs + hugepages | 15:10 |
ndipanov | but can't remember what the resolution was | 15:10 |
ndipanov | cfriesen, sadly can't do it now - ping me an email and I'll look into it later | 15:11 |
johnthetubaguy | dansmith: should I add a blueprint to bump all the object versions at the end of of liberty-3, so we don't forget? | 15:11 |
cfriesen | ndipanov: I'm running into issues with our modified version, but it's possible we messed it up. :) Haven't tested it on vanilla stable/kilo yet. No worries, will follow up. | 15:11 |
dansmith | johnthetubaguy: you can if you want.. it's a thing I'd like to do, but it's going to require some real work, so I also don't know that I want to be committed to it.. but you can put it in and we could always defer I guess :) | 15:12 |
*** yamahata has quit IRC | 15:12 | |
*** yamahata has joined #openstack-nova | 15:12 | |
johnthetubaguy | dansmith: that makes sense, I wonder if melwitt_ would fancy taking a look at that? | 15:12 |
mdbooth | zzzeek: ping | 15:13 |
dansmith | johnthetubaguy: at the implementation you mean? | 15:13 |
johnthetubaguy | yeah | 15:13 |
*** lsmola has quit IRC | 15:13 | |
*** markus_z has quit IRC | 15:13 | |
dansmith | dunno, maybe | 15:13 |
dansmith | I really want to do it, I just worry about time the way things are going | 15:14 |
dansmith | I guess if we do it near the end of L-3 and I know it's coming I should be able to plan for it | 15:14 |
dansmith | last time it was a little rushed | 15:14 |
dansmith | johnthetubaguy: but anyway, I guess file it and we'll either work it out or defer | 15:15 |
johnthetubaguy | yeah, similar thoughts | 15:15 |
openstackgerrit | garyk proposed openstack/nova: VMware: clean up exceptions https://review.openstack.org/202151 | 15:15 |
johnthetubaguy | just given how close we are getting with some stuff, it feels like we might be able to drop a lot of code | 15:15 |
*** itzikb_ has quit IRC | 15:16 | |
dansmith | johnthetubaguy: it's not much code really, it's just methods we don't use anymore, which really don't cost us much at all | 15:16 |
dansmith | johnthetubaguy: but it's something | 15:17 |
johnthetubaguy | dansmith: yeah, true | 15:17 |
dansmith | regular rpc calls cost us more | 15:17 |
dansmith | but still worth doing of course | 15:17 |
johnthetubaguy | yeah | 15:17 |
openstackgerrit | garyk proposed openstack/nova: VMware: clean up exceptions https://review.openstack.org/202151 | 15:17 |
*** kmartin has joined #openstack-nova | 15:17 | |
dansmith | I should find and unabandon my POC patches for that before they get too old and lost | 15:17 |
*** mlavalle has joined #openstack-nova | 15:18 | |
johnthetubaguy | dansmith: I was just thinking, its good to get back into a pattern of doing it every release, so its "easy" | 15:18 |
johnthetubaguy | actually, thats probably quite a good use of the word trivial | 15:18 |
dansmith | well | 15:18 |
dansmith | every time we do that, we have the inflation around release time | 15:18 |
dansmith | which I don't like if it's not necessary | 15:18 |
johnthetubaguy | thats a good point | 15:19 |
johnthetubaguy | its far from zero risk | 15:19 |
dansmith | if it's just dropping a couple methods that aren't used, it's hardly worth all the code to support both sides | 15:19 |
dansmith | and it makes backports confusing | 15:19 |
johnthetubaguy | true | 15:19 |
dansmith | but, bumping more frequently than every 40+ changes, definitely agree ;) | 15:19 |
*** coreywright has joined #openstack-nova | 15:19 | |
johnthetubaguy | :) | 15:19 |
*** mdrabe has joined #openstack-nova | 15:19 | |
*** ddaskal has joined #openstack-nova | 15:19 | |
openstackgerrit | Dan Smith proposed openstack/nova: Base NovaObject on VersionedObject https://review.openstack.org/201655 | 15:19 |
openstackgerrit | Jordan Pittier proposed openstack/nova: libvirt:when deleting snapshot use qemu-img to blockRebase if domain is stopped https://review.openstack.org/192736 | 15:20 |
johnthetubaguy | dansmith: added it: https://blueprints.launchpad.net/nova/+spec/liberty-bump-object-and-rpcapi-versions | 15:20 |
mdbooth | mriedem: Do you have any indication of what proportion of jobs were failing due to the instance compare and swap patch? | 15:20 |
dansmith | johnthetubaguy: okay we just bumped rpc in K, not sure we've changed enough to do it again | 15:21 |
* dansmith looks | 15:21 | |
johnthetubaguy | dansmith: true, hopefully not I guess | 15:21 |
dansmith | only two minor things | 15:21 |
dansmith | anyway | 15:21 |
ndipanov | dansmith, very strange that that test passed the check | 15:21 |
*** wwriverrat has quit IRC | 15:21 | |
dansmith | we can punt on that part if it looks unnecessary in L3 | 15:21 |
ndipanov | let me see if something snuck in in between to fail it | 15:21 |
mlavalle | johnthetubaguy: hi, I want to talk about https://review.openstack.org/#/c/90150/ and the message you sent about non priority features freeze | 15:22 |
dansmith | ndipanov: it failed check | 15:22 |
dansmith | ndipanov: it passed check on an earlier PS, but not on the latest | 15:22 |
*** dannywilson has joined #openstack-nova | 15:22 | |
mdbooth | mriedem: I'm wondering if it was all of them, basically | 15:22 |
mdbooth | Was anything passing the gate? | 15:23 |
ndipanov | I see | 15:23 |
johnthetubaguy | mlavalle: hi | 15:23 |
*** zhenguo has quit IRC | 15:23 | |
*** aix has quit IRC | 15:23 | |
mlavalle | johnthetubaguy: we talked about this in Vancouver, during the nova net / neutron sessions. do you remember? | 15:24 |
*** dannywilson has quit IRC | 15:24 | |
*** moshele has quit IRC | 15:24 | |
*** dannywilson has joined #openstack-nova | 15:24 | |
johnthetubaguy | mlavalle: I do, but the blueprint (and spec?) has now missed the deadline for liberty | 15:24 |
*** agireud has quit IRC | 15:24 | |
mlavalle | johnthetubaguy: I am willing to implement the nova side. It is not that difficult. The Neutron side is well on its way. I only need review on the nova side | 15:25 |
johnthetubaguy | mlavalle: so this is the process we follow on the Nova side, we needed the blueprint approving before the blueprint on June 25th, this covers more of the details: https://wiki.openstack.org/wiki/Nova/Liberty_Release_Schedule | 15:27 |
thomasem | Would anyone have some time today to review: https://review.openstack.org/#/c/187012/ | 15:27 |
johnthetubaguy | mlavalle: the best way forward at this point, is probably to submit a small spec for review as a backlog nova-spec | 15:28 |
*** jichen has quit IRC | 15:29 | |
openstackgerrit | Nikola Dipanov proposed openstack/nova: Fix the incorrect PciDeviceList version number https://review.openstack.org/201280 | 15:29 |
mlavalle | johnthetubaguy: Does this https://review.openstack.org/#/c/90150/ serve the purpose? Or do I need to work on another template / process? | 15:30 |
*** vladikr has quit IRC | 15:30 | |
johnthetubaguy | mlavalle: it needs to now move to the specs/backlog directory, I need to go through all the current specs in review and add that in, not got around to that so far | 15:31 |
*** vladikr has joined #openstack-nova | 15:32 | |
mlavalle | johnthetubaguy: do you want me to move it to that directory? | 15:32 |
mdbooth | dansmith: Did you happen to notice if instance compare and swap broke everything, or just some things? | 15:32 |
mriedem | mdbooth: it didn't break everything | 15:32 |
dansmith | mdbooth: I don't think it was everything | 15:32 |
*** Tedster has joined #openstack-nova | 15:32 | |
*** ajayaa has quit IRC | 15:32 | |
mdbooth | Cool, thanks | 15:32 |
mriedem | mdbooth: the logstash query is in the bug report and on the e-r page | 15:33 |
mdbooth | mriedem: Yeah, thanks for that. I've already been using it. | 15:33 |
mriedem | http://goo.gl/HTYV0D | 15:33 |
mriedem | 224 hits | 15:34 |
mriedem | so not a gate blocker, but enough to be annoying | 15:34 |
mriedem | especially when there is a deleted server test in tempest which really tickles the UnexpectedTaskStateError type paths | 15:34 |
mriedem | which weren't handled with the new InstanceUpdateConflict | 15:34 |
mdbooth | In that case, I suspect that my 'unlikely' race is sufficiently likely to be actually hit | 15:35 |
mdbooth | It turns out, we really do update instances a lot | 15:35 |
mdbooth | I should perhaps wrap it in a retry | 15:36 |
mdbooth | On the flip side, it probably means that it's preventing a lot of races | 15:37 |
johnthetubaguy | mlavalle: yes please, that would be great, I added a comment on the review | 15:38 |
mlavalle | johnthetubaguy: thanks | 15:38 |
*** hemnafk is now known as hemna | 15:39 | |
*** ig0r__ has quit IRC | 15:39 | |
*** ig0r_ has joined #openstack-nova | 15:40 | |
mdbooth | Specifically, I think we're getting: 1. read instance in instance_update. 2. delete instance in another context. 3. atomic compare and swap fails (correctly) 4. We can't see why because of bloody mysql read view, so raise the generic error | 15:41 |
johnthetubaguy | mdbooth: I am curious, what is pointing towards the delete? | 15:47 |
mdbooth | johnthetubaguy: This one is much clearer than the cells example: | 15:47 |
mdbooth | http://logs.openstack.org/05/160205/13/check/check-tempest-dsvm-full/43837d6/logs/screen-n-cpu.txt.gz?level=ERROR | 15:47 |
mdbooth | The delete is done by n-api | 15:47 |
mdbooth | The update by n-cpu | 15:48 |
*** belmoreira has quit IRC | 15:48 | |
openstackgerrit | Sudipta Biswas proposed openstack/nova: Allow NUMA based reporting for Monitors https://review.openstack.org/198972 | 15:48 |
johnthetubaguy | mdbooth: ah, cool | 15:49 |
johnthetubaguy | mdbooth: I wonder if its worth a nova functional test, to help deal with that specific race? | 15:49 |
johnthetubaguy | (in the hope it helps fix the general case) | 15:50 |
mdbooth | The race is already being handled | 15:50 |
*** andrearosa has quit IRC | 15:50 | |
mdbooth | And this is the functional test, I guess | 15:51 |
johnthetubaguy | mdbooth: I was thinking a specific functional test for this, here: https://github.com/openstack/nova/tree/master/nova/tests/functional/db | 15:51 |
johnthetubaguy | so open two sessions, and reproduce how the read view hides the problem, or something like that | 15:52 |
mdbooth | You mean move the tempest test into functional? | 15:52 |
johnthetubaguy | sorry, I was being unclear, I was meaning nova functional test | 15:52 |
*** wwriverrat has joined #openstack-nova | 15:54 | |
*** kiran-r has joined #openstack-nova | 15:54 | |
mdbooth | johnthetubaguy: I had a bunch of patches to allow us to run tests against MySQL at one point | 15:54 |
mdbooth | they were killed :( | 15:54 |
mdbooth | By a regression in oslo.db this time | 15:55 |
*** patrickeast has joined #openstack-nova | 15:56 | |
*** armax has joined #openstack-nova | 15:56 | |
*** kiran-r has quit IRC | 15:56 | |
johnthetubaguy | mdbooth: the functional tests are doing that now, its worth trying to extend those I think, hopefully that makes it easier | 15:57 |
mdbooth | This patch fixes a race, and in doing so raises a new exception in a subclass of that race. Previously we didn't notice the race at all, and just corrupted the db. | 15:57 |
johnthetubaguy | mdbooth: agreed | 15:57 |
mdbooth | So I think it's a good patch. | 15:57 |
*** scheuran has joined #openstack-nova | 15:57 | |
mdbooth | If I have to write a new functional test to get it back in, it'll be another 7 months. | 15:57 |
johnthetubaguy | I am not trying to say that | 15:58 |
johnthetubaguy | just saying, that might be a handy way to prove you fixed the race, if its not, thats fine | 15:58 |
*** alex_klimov has quit IRC | 15:58 | |
mdbooth | Ideally yes, but I've tried hard in other cases to add tests cases for race conditions | 15:58 |
*** jaypipes has quit IRC | 15:58 | |
mdbooth | Turns out it's pretty hard | 15:59 |
mdbooth | It's harder in this case, where you have the interaction with a MySQL read view, which we can't even use in these tests | 15:59 |
mdbooth | I'd have to simulate both the race and the read view | 16:00 |
*** annashen has joined #openstack-nova | 16:00 | |
*** logan2 has quit IRC | 16:00 | |
johnthetubaguy | yeah, I guess thats what I was thinking, open two sessions to a mysql DB, maybe turn off auto commit, and reproduce the race, not tried doing that though | 16:00 |
*** diogogmt has quit IRC | 16:01 | |
*** diogogmt_ has joined #openstack-nova | 16:01 | |
johnthetubaguy | but anyways, its not a requirement, just an idea that might help, it might well be a dumb idea, not tried to do that myself | 16:01 |
mdbooth | What I can do is add InstanceConflict to the db retry wrapper | 16:01 |
*** agireud has joined #openstack-nova | 16:01 | |
*** salv-orl_ has joined #openstack-nova | 16:01 | |
mdbooth | And add a test that it's retried in that case | 16:01 |
*** amotoki has joined #openstack-nova | 16:02 | |
johnthetubaguy | mdbooth: yeah, that might be enough actually | 16:02 |
johnthetubaguy | well, seems worth a try | 16:02 |
*** Sukhdev has joined #openstack-nova | 16:03 | |
*** otter768 has joined #openstack-nova | 16:03 | |
johnthetubaguy | sahid: do you have all the code up for review for this one now? https://blueprints.launchpad.net/nova/+spec/libvirt-set-admin-password | 16:04 |
rlrossit | dansmith: I'm allowed one stupid question per day right? | 16:04 |
dansmith | rlrossit: yep | 16:04 |
*** unicell has quit IRC | 16:05 | |
*** salv-orlando has quit IRC | 16:05 | |
*** earlephilhower_ has joined #openstack-nova | 16:05 | |
rlrossit | dansmith: here it comes.... how in the world do you get obj_attr_is_set() to be true? (https://github.com/openstack/nova/blob/master/nova/objects/base.py#L512) I can set the actual attribute just fine, but it's not getting put in the backing _obj_* attribute on the object | 16:06 |
*** rajesht has quit IRC | 16:06 | |
scheuran | garyk: thanks for your comments on https://review.openstack.org/#/c/182283 Just a minor thing. you asked why I'm using doulbe underscores in my variables. The answer is I was following the pattern mock_<method-name> where the method was named _execute | 16:06 |
*** earlephilhower has quit IRC | 16:06 | |
scheuran | garyk: I mean I could change that easily | 16:06 |
dansmith | rlrossit: if the field is in the object fields, and your object is registered, then it gets an @property for the name you chose, which actually sets _obj_$field when you set it | 16:07 |
dims_ | mdbooth: what did we break in oslo.db? | 16:07 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: libvirt: enable virtio-net multiqueue https://review.openstack.org/128829 | 16:07 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: objects: add hw_vif_multiqueue_enabled image property https://review.openstack.org/202168 | 16:07 |
*** shihanzhang has joined #openstack-nova | 16:07 | |
rlrossit | dansmith: wait it has to be registered? what if I'm just whipping this object up in a test? | 16:07 |
dansmith | rlrossit: use register_if(False) | 16:08 |
sahid | johnthetubaguy: yes | 16:08 |
dansmith | rlrossit: the registration step is what builds all the objecty stuff | 16:08 |
mdbooth | dims_: Was a while back. I was using a db fixture in a patch series to use MySQL | 16:08 |
mdbooth | from oslo.db | 16:08 |
*** otter768 has quit IRC | 16:08 | |
dims_ | k just making sure, this is not something new, i remember that *old* issue :) | 16:08 |
johnthetubaguy | sahid: awesome, are you OK to update the state to NeedsCodeReview please? | 16:08 |
mdbooth | Don't remember the detail now, but you decided to break the fixture | 16:08 |
mdbooth | or possibly remove | 16:08 |
mdbooth | Anyway, it killed my patch series | 16:09 |
*** sudipto has quit IRC | 16:09 | |
sahid | johnthetubaguy: done | 16:09 |
*** kiran-r has joined #openstack-nova | 16:09 | |
rlrossit | dansmith: so register_if(False) handles all of the register stuff without actually putting it in the registry (so it doesn't get picked up in the other tests)? | 16:09 |
johnthetubaguy | sahid: thank you! | 16:09 |
* mdbooth was running unit tests against MySQL in addition to sqlite for a while | 16:09 | |
dansmith | rlrossit: yeah | 16:10 |
*** gszasz has quit IRC | 16:10 | |
*** hanzhang has quit IRC | 16:10 | |
dims_ | mdbooth: we can somewhat guarantee unit tests, functional tests and dsvm/tempest tests are good with newer releases. reviews in progress - we cannot | 16:10 |
johnthetubaguy | sahid: its just so folks know its all up for review, and so it doesn't get unapproved tomorrow | 16:10 |
dims_ | just drawing a line | 16:10 |
dims_ | i know we'll disagree on that | 16:10 |
mdbooth | Meh, a regression is a regression :) | 16:10 |
*** jlanoux has quit IRC | 16:11 | |
sahid | johnthetubaguy: i see yes, got it | 16:11 |
mriedem | garyk: i see that tempest.api.compute.volumes.test_attach_volume.AttachVolumeTestJSON.test_attach_detach_volume is skipped in nsx CI - is there a reason why? | 16:12 |
*** unicell has joined #openstack-nova | 16:13 | |
rlrossit | dansmith: yesssss thanks! | 16:13 |
*** lpetrut1 has quit IRC | 16:13 | |
mriedem | garyk: and tempest.api.compute.admin.test_servers.ServersAdminTestJSON.test_get_server_diagnostics_by_admin | 16:14 |
johnthetubaguy | sahid: boils down to wanting as many complete blueprints as possible in liberty-2, and focusing on priorities in liberty-3 | 16:14 |
dansmith | rlrossit: no problem :) | 16:14 |
dansmith | rlrossit: not really a dumb question, by the way.. it's non obvious | 16:14 |
*** signed8b_ is now known as signed8bit_ZZZzz | 16:14 | |
garyk | mriedem: the diagnosts is excluded as in v1 the tempest is built around the livirt results | 16:14 |
*** ildikov has quit IRC | 16:14 | |
mriedem | garyk: but not v2.1 | 16:14 |
garyk | the tempest community did not allow us to add support for different drivers | 16:15 |
*** unicell has quit IRC | 16:15 | |
garyk | the common support was for v2 for diagnostics | 16:15 |
mriedem | we should change that | 16:15 |
garyk | correct - we need to go back and see that | 16:15 |
mriedem | since v2 diags is crap | 16:15 |
garyk | for the volumes i need to check | 16:15 |
*** krtaylor has quit IRC | 16:15 | |
rlrossit | dansmith: I saw that register_if(False) elsewhere and I took a peek at the register_if() function and had no idea what was going on. It was way to Python-y for me | 16:15 |
garyk | out of interst why is this on your radar? | 16:15 |
*** ishita has joined #openstack-nova | 16:15 | |
cfriesen | Is anyone else seeing problems with unit tests in nova.tests.unit.cmd.test_idmapshift for the stable/kilo branch? I get this: http://paste.openstack.org/show/377934/ | 16:17 |
cfriesen | wondering if it's a requirements issue | 16:17 |
*** ishita has quit IRC | 16:18 | |
mriedem | garyk: i was checking nsx ci results on https://review.openstack.org/#/c/197192/ | 16:18 |
mriedem | and looking to see what tests the nsx ci is skipping | 16:18 |
*** tpatil has joined #openstack-nova | 16:18 | |
*** asselin has joined #openstack-nova | 16:18 | |
mriedem | cfriesen: it's a mock thing in stable/kilo which should already be fixed | 16:18 |
mriedem | cfriesen: rebase | 16:18 |
*** rotbeard has quit IRC | 16:19 | |
*** lpetrut has joined #openstack-nova | 16:19 | |
*** gyee has quit IRC | 16:19 | |
*** thangp has quit IRC | 16:20 | |
*** lucasagomes has quit IRC | 16:20 | |
*** Anticime1 has quit IRC | 16:20 | |
*** bradjones has quit IRC | 16:20 | |
*** ZZelle has quit IRC | 16:20 | |
*** stefanb has quit IRC | 16:20 | |
*** mrda-away has quit IRC | 16:20 | |
*** Anticimex has joined #openstack-nova | 16:20 | |
*** bradjones has joined #openstack-nova | 16:20 | |
*** bradjones has quit IRC | 16:20 | |
*** bradjones has joined #openstack-nova | 16:20 | |
*** thangp has joined #openstack-nova | 16:20 | |
*** mrda-away has joined #openstack-nova | 16:20 | |
*** lucasagomes has joined #openstack-nova | 16:20 | |
*** ZZelle has joined #openstack-nova | 16:20 | |
*** stefanb has joined #openstack-nova | 16:20 | |
openstackgerrit | Andreas Scheuring proposed openstack/nova: Add macvtap as new virtual interface (vif) type to Nova's libvirt driver https://review.openstack.org/182283 | 16:23 |
*** ddaskal has quit IRC | 16:24 | |
*** afazekas has quit IRC | 16:27 | |
*** krtaylor has joined #openstack-nova | 16:28 | |
*** rdopiera has quit IRC | 16:28 | |
*** mjturek1 has quit IRC | 16:29 | |
*** mlavalle has quit IRC | 16:29 | |
*** ivasev has quit IRC | 16:30 | |
*** romainh has left #openstack-nova | 16:31 | |
*** scheuran has quit IRC | 16:32 | |
cfriesen | mriedem: would you happen to know which commit fixed it? I don't see anything obvious. | 16:32 |
mriedem | well, i'd check git history on test-requirements.txt in nova on stable/kilo | 16:33 |
mriedem | bingo https://github.com/openstack/nova/commit/330c6f8deed60c14e4b2435745e84d3ac38387bf | 16:34 |
*** sahid has quit IRC | 16:34 | |
*** scheuran has joined #openstack-nova | 16:34 | |
mriedem | ndipanov: just found something interesting in tempest | 16:35 |
*** scheuran has quit IRC | 16:35 | |
cfriesen | mriedem: I was looking at that commit, but I didn't see anything related to six or mock | 16:35 |
*** ijw has joined #openstack-nova | 16:35 | |
mriedem | cfriesen: +mock<1.1.0,>=1.0 | 16:35 |
cfriesen | mriedem: whoops...didn't scroll down far enough. :) | 16:36 |
mriedem | ndipanov: there is a scenario test in tempest that does attach/detach + ssh of a volume, and it was using a hard-coded device name in tempest.conf | 16:36 |
mriedem | http://git.openstack.org/cgit/openstack/tempest/tree/tempest/scenario/test_stamp_pattern.py#n105 | 16:36 |
mriedem | the test has been skipped since like the 80s becaues the device name isn't honored with libvirt :) | 16:37 |
mriedem | ndipanov: were you going to get that ML thread started on that change? | 16:37 |
lyanchih | Hi, I try to using utils.synchronized to avoid race condition, but I saw two lock for ’acquired by’ appear together in log instead of “acquired by…release by…acquired by….realease by”. It is normal | 16:37 |
mriedem | lyanchih: are they file system locks? | 16:38 |
*** vilobhmm has joined #openstack-nova | 16:38 | |
ndipanov | mriedem, I did just now | 16:38 |
ndipanov | like 15 minutes ago | 16:38 |
mriedem | ok | 16:39 |
lyanchih | I was using nova.utils.synchronized. Is it file system lock? | 16:39 |
ndipanov | mriedem, all those tests should be changed to ask for the device name before sshing | 16:39 |
mriedem | yup | 16:39 |
mriedem | was just talking to mtreinish about that | 16:39 |
ndipanov | I'd be happy to do that | 16:39 |
*** pixelbeat_ has quit IRC | 16:39 | |
ndipanov | not today tho | 16:39 |
mriedem | i could check it out too | 16:40 |
*** markvoelker_ has quit IRC | 16:40 | |
*** annashen has quit IRC | 16:42 | |
*** markvoelker has joined #openstack-nova | 16:42 | |
*** sudipto has joined #openstack-nova | 16:42 | |
*** ssurana has quit IRC | 16:42 | |
lyanchih | I’m checking oslo_concurrency…. It looks like it should been lock. Therefore I felt confused | 16:43 |
*** lpetrut has quit IRC | 16:44 | |
*** ajayaa has joined #openstack-nova | 16:44 | |
mriedem | lyanchih: i believe you have to use kwargs to tell it what kind of lock it is | 16:44 |
mriedem | by default it's an in-process lock | 16:44 |
*** ndipanov has quit IRC | 16:45 | |
*** PaulMurray is now known as ptm_away | 16:45 | |
*** yassine_ has quit IRC | 16:45 | |
*** annashen has joined #openstack-nova | 16:46 | |
lyanchih | mriedem: I will try other type of lock, thank you. | 16:47 |
*** mjturek1 has joined #openstack-nova | 16:47 | |
*** nic has joined #openstack-nova | 16:48 | |
*** melwitt_ is now known as melwitt | 16:49 | |
*** unicell has joined #openstack-nova | 16:49 | |
*** vilobhmm has quit IRC | 16:49 | |
*** jistr has quit IRC | 16:50 | |
lyanchih | mriedem: Oh!! I add external argument then it WORK!! thx. I originally thought request of nova api will be same process. | 16:50 |
*** amotoki has quit IRC | 16:50 | |
*** ssurana has joined #openstack-nova | 16:51 | |
openstackgerrit | Earle F. Philhower, III proposed openstack/nova: Add os_brick-based VolumeDriver for HGST connector https://review.openstack.org/194412 | 16:52 |
*** ijw has quit IRC | 16:54 | |
*** haypo has left #openstack-nova | 16:55 | |
*** ijw has joined #openstack-nova | 16:55 | |
mriedem | lyanchih: there can be multiple api worker processes | 16:56 |
mriedem | by default it's ncpu i think | 16:56 |
mriedem | $ncpu workers | 16:56 |
*** ssurana has quit IRC | 16:57 | |
*** Nikolay_St has quit IRC | 16:57 | |
*** yamahata has quit IRC | 16:57 | |
*** yamahata has joined #openstack-nova | 16:58 | |
*** patrickeast has quit IRC | 16:59 | |
*** mutoulbj has quit IRC | 16:59 | |
*** derekh has quit IRC | 17:01 | |
*** kiran-r has quit IRC | 17:02 | |
*** lucasagomes has quit IRC | 17:03 | |
*** hemna is now known as hemnafk | 17:04 | |
*** eglynn has quit IRC | 17:04 | |
*** oro_ has quit IRC | 17:05 | |
*** oro has quit IRC | 17:05 | |
openstackgerrit | Ming Yang proposed openstack/nova: Case-insensitive filters https://review.openstack.org/201725 | 17:07 |
openstackgerrit | Ming Yang proposed openstack/nova: Refactor get_filtered_hosts in filter host manager https://review.openstack.org/192878 | 17:07 |
*** yamahata has quit IRC | 17:09 | |
*** artom has joined #openstack-nova | 17:10 | |
*** exploreshaifali has quit IRC | 17:10 | |
*** logan2 has joined #openstack-nova | 17:10 | |
*** moshele has joined #openstack-nova | 17:14 | |
*** Marc_F has quit IRC | 17:14 | |
*** browne has quit IRC | 17:16 | |
*** patrickeast has joined #openstack-nova | 17:18 | |
*** Marc_F has joined #openstack-nova | 17:20 | |
*** agireud has quit IRC | 17:22 | |
mriedem | mtreinish: does tempest know if it's talking to v2 or v2.1 nova api? | 17:22 |
mtreinish | mriedem: nope right now it's jsut an endpoint | 17:22 |
dansmith | dims_: do we need to do something to o.vo for pbr/tox/something changes? | 17:22 |
mtreinish | adding microversion support is a todo | 17:22 |
*** moshele has quit IRC | 17:22 | |
mtreinish | there is an ironic patch up for it somewhere, which I've been meaning to review | 17:23 |
mriedem | hrm | 17:23 |
mtreinish | it kinda fell through the cracks | 17:23 |
*** nic has quit IRC | 17:23 | |
mriedem | mtreinish: well, i'm looking at nova.conf in the check-tempest-dsvm-nova-v21-full job and check-tempest-dsvm-full jobs and osapi_v3.enabled = True in both | 17:23 |
*** whenry has joined #openstack-nova | 17:23 | |
mriedem | so i'm wondering why we even have a v2.1 specific job if both are talking to nova v2.1 already since it's backwards compatible | 17:24 |
mtreinish | mriedem: https://review.openstack.org/#/c/166386/ | 17:24 |
mtreinish | mriedem: those jobs are weird they play games with the endpoint config to point tempest at 2.0 or 2.1 | 17:24 |
mriedem | so i guess i need to check the tempest logs to see which api endpoint is actually getting hte request | 17:25 |
mriedem | ah ok, in the v21 full job x-openstack-nova-api-version: 2.1 is in there | 17:26 |
mriedem | in the non-v21 job it's not | 17:26 |
*** mjturek1 has quit IRC | 17:28 | |
melwitt | mriedem: yeah, I think we always run nova with 2.0 and 2.1 enabled at the same time and then devstack sets up catalog endpoints as "compute | 17:28 |
melwitt | " and "computev21" | 17:28 |
*** achanda has joined #openstack-nova | 17:29 | |
*** tonytan4ever has quit IRC | 17:30 | |
mriedem | weird, osapiv3_enabled is False by default in nova even though the v2.1 API is listed as CURRENT and the v2 api is listed as SUPPORTED | 17:31 |
melwitt | hmm | 17:32 |
*** mgarza_ has joined #openstack-nova | 17:32 | |
*** yamahata has joined #openstack-nova | 17:33 | |
*** jaypipes has joined #openstack-nova | 17:35 | |
mtreinish | mriedem: fwiw, I told gmann_ and oomichi that we should switch the default for gate jobs to use the 2.1 endpoint and make the 2.0 a special separate job | 17:36 |
*** lyanchih has quit IRC | 17:36 | |
melwitt | mriedem: I assumed it was defaulting to true because devstack installs have it running but I see now that devstack sets it to True in lib/nova | 17:36 |
mtreinish | I'm not sure what happened about that though | 17:36 |
mriedem | yeah idk, the more i look the more confused i get | 17:37 |
*** tpeoples has quit IRC | 17:37 | |
*** hemnafk is now known as hemna | 17:38 | |
*** mtanino has quit IRC | 17:39 | |
*** achanda has quit IRC | 17:39 | |
*** ssurana has joined #openstack-nova | 17:39 | |
openstackgerrit | Dan Smith proposed openstack/nova: Move to using ovo's remotable decorators https://review.openstack.org/202209 | 17:40 |
annashen | can nova have no availability zones? | 17:40 |
*** agireud has joined #openstack-nova | 17:43 | |
*** shyu has quit IRC | 17:43 | |
*** pradipta has quit IRC | 17:43 | |
*** shyu has joined #openstack-nova | 17:43 | |
*** ajayaa has quit IRC | 17:44 | |
*** bauzas has quit IRC | 17:46 | |
*** lpetrut has joined #openstack-nova | 17:48 | |
*** Alexei_987 has left #openstack-nova | 17:48 | |
*** achanda has joined #openstack-nova | 17:48 | |
*** tpeoples has joined #openstack-nova | 17:50 | |
*** bauzas has joined #openstack-nova | 17:50 | |
*** salv-orl_ has quit IRC | 17:50 | |
*** mtanino has joined #openstack-nova | 17:52 | |
*** shyu has quit IRC | 17:53 | |
*** shyu has joined #openstack-nova | 17:54 | |
*** gyee has joined #openstack-nova | 17:57 | |
*** vilobhmm has joined #openstack-nova | 17:58 | |
*** mutoulbj has joined #openstack-nova | 17:59 | |
*** agireud has quit IRC | 18:01 | |
*** Nikolay_St has joined #openstack-nova | 18:02 | |
*** browne has joined #openstack-nova | 18:02 | |
*** rajesht has joined #openstack-nova | 18:02 | |
*** ivasev_ has joined #openstack-nova | 18:02 | |
*** Kennan has quit IRC | 18:02 | |
*** Sukhdev has quit IRC | 18:03 | |
*** Kennan has joined #openstack-nova | 18:03 | |
*** shyama has quit IRC | 18:03 | |
*** signed8bit_ZZZzz is now known as signed8b_ | 18:04 | |
*** signed8b_ is now known as signed8bit_ZZZzz | 18:04 | |
*** otter768 has joined #openstack-nova | 18:04 | |
openstackgerrit | Dan Smith proposed openstack/nova: Move to using ovo's remotable decorators https://review.openstack.org/202209 | 18:04 |
*** thangp has quit IRC | 18:04 | |
*** nkrinner is now known as nkrinner_afk | 18:05 | |
*** annegentle has quit IRC | 18:06 | |
*** rajesht has quit IRC | 18:06 | |
*** Nikolay_St has quit IRC | 18:07 | |
*** mutoulbj has quit IRC | 18:07 | |
*** slagle_ is now known as slagle | 18:08 | |
*** otter768 has quit IRC | 18:09 | |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: objects: add hw_vif_multiqueue_enabled image property https://review.openstack.org/202168 | 18:12 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: libvirt: enable virtio-net multiqueue https://review.openstack.org/128829 | 18:12 |
*** pmcfadden has quit IRC | 18:12 | |
*** iamjarvo has joined #openstack-nova | 18:14 | |
*** thangp has joined #openstack-nova | 18:15 | |
*** ociuhandu has quit IRC | 18:17 | |
*** pmcfadden has joined #openstack-nova | 18:18 | |
*** boris-42 has joined #openstack-nova | 18:23 | |
*** tonytan4ever has joined #openstack-nova | 18:25 | |
*** vishwanathj has joined #openstack-nova | 18:25 | |
*** belmoreira has joined #openstack-nova | 18:28 | |
*** otter768 has joined #openstack-nova | 18:29 | |
*** lpetrut has quit IRC | 18:30 | |
*** tjones1 has joined #openstack-nova | 18:30 | |
*** annashen has quit IRC | 18:30 | |
*** shyu has quit IRC | 18:34 | |
*** shyu has joined #openstack-nova | 18:35 | |
*** annegentle has joined #openstack-nova | 18:35 | |
*** gryf_ has joined #openstack-nova | 18:41 | |
*** belmoreira has quit IRC | 18:41 | |
*** shyu has quit IRC | 18:41 | |
*** annashen has joined #openstack-nova | 18:42 | |
*** agireud has joined #openstack-nova | 18:43 | |
*** achanda has quit IRC | 18:43 | |
*** shyu has joined #openstack-nova | 18:44 | |
anish | can I get a core reviewer to look at this very small bug fix ? It's been waiting for a month now https://review.openstack.org/#/c/193414/ | 18:44 |
*** exploreshaifali has joined #openstack-nova | 18:46 | |
*** agireud has quit IRC | 18:48 | |
*** shyu has quit IRC | 18:49 | |
melwitt | dansmith: it looks like this compute manager code is making a wrong assumption that instance_type is an object here. there's no conversion to object if not object in manager and in rpcapi I see it can send a primitive until 5.0 https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L3557-L3558 | 18:49 |
mriedem | anish: i'm confused, the help text explicitly says "Supported transports are" | 18:50 |
mriedem | and then a list of things | 18:50 |
*** shyu has joined #openstack-nova | 18:50 | |
*** mordred has joined #openstack-nova | 18:51 | |
mriedem | anish: what else would someone set iscsi_iface to? | 18:51 |
anish | mriedem: yes, there's an explicit explanation for iface != transport in the docs | 18:51 |
mordred | anybody know who I should follow up with if I have questions with metadata-service-network-info ? | 18:51 |
anish | mriedem: for iscsi_tcp & iser transport names are the same as iface names, for everything else they are not | 18:51 |
anish | open-iscsi is a bit confusing about this | 18:51 |
*** redbeard has joined #openstack-nova | 18:52 | |
dansmith | mriedem: yeah, we should be converting it to an object early in the method if it's not already | 18:52 |
dansmith | like we do for flavor elsewhere and did for instance with the decorator | 18:52 |
mordred | specifically, the description in the spec mentions the usecase where a primary interface would have dhcp and a private interface woudl have static ip... | 18:52 |
mriedem | dansmith: ? | 18:52 |
mordred | but there is no example of an interface communicating intent to be configured via dhcp in the sample response json | 18:52 |
dansmith | mriedem: sorry, meant for melwitt | 18:52 |
melwitt | mriedem: you and I are now the same person too, along with mtreinish | 18:53 |
dansmith | too many m* nicks active in here | 18:53 |
* mordred aplogizes for joining the channel | 18:53 | |
anish | mriedem: I added explanation regarding this in the documentation and the code as well http://docs.openstack.org/kilo/config-reference/content/iscsi-iface-config.html | 18:53 |
mordred | JoshNang: that's you, right? | 18:54 |
melwitt | dansmith: okay, making sure I'm not crazy. I was reviewing a change to dot notation on an instance_type and the first thing I look for is "can we assume it's an object" | 18:54 |
dansmith | yeah' | 18:54 |
mriedem | anish: still, is there a case where someone would set the iscsi_iface option to a value that is not one of "be2iscsi, bnx2i, cxgb3i, cxgb4i, qla4xxx and ocs" | 18:55 |
mriedem | ? | 18:55 |
mriedem | if so, please give the example | 18:55 |
mriedem | the docs don't make sense to me either | 18:55 |
anish | mriedem: maybe this explains it a bit better ? https://review.openstack.org/#/c/153743/8/nova/virt/libvirt/volume.py | 18:56 |
mriedem | anish: or is that something like bnx2i.hwaddress? | 18:56 |
*** jecarey has quit IRC | 18:56 | |
mriedem | bnx2i.<hwaddress>? | 18:56 |
anish | mriedem: yes | 18:56 |
mriedem | ah, ok | 18:56 |
mriedem | yeah i remember that change, i approved it | 18:56 |
anish | but for default or iser, you do not need to make this iface config | 18:56 |
anish | so it accepts iface name == transport name | 18:57 |
anish | as these are automatically generated (or even not required) | 18:57 |
anish | for all others, they are generated as transport_name.hwaddress | 18:57 |
anish | the whole thing together is the iscsi_iface | 18:57 |
anish | which you must provide as a parameter | 18:57 |
anish | just the transport name is not enough | 18:57 |
anish | as all the others are bound to actualy hardware | 18:57 |
*** flwang has quit IRC | 18:58 | |
*** markvoelker has quit IRC | 18:58 | |
*** ZZelle_ has joined #openstack-nova | 18:58 | |
mriedem | anish: i added a comment in the change | 19:00 |
anish | I saw, just about to reply | 19:00 |
mriedem | anish: let me know if you want to update the config option help text in this change or a later one | 19:00 |
mriedem | i think we need to be more clear about the actual form of that option's value | 19:00 |
anish | I'll do that right now | 19:00 |
mriedem | and probably an example like bnx2i.00:05:b5:d2:a0:c2 | 19:00 |
anish | best to do it one shot | 19:00 |
mriedem | ok, | 19:00 |
mriedem | i'm +2 either way | 19:00 |
anish | do examples belong in help text or documentation ? | 19:01 |
gryf_ | hi, can I bring core reviewer attention to https://review.openstack.org/#/c/197063/ and https://review.openstack.org/#/c/184086/ ? | 19:01 |
mriedem | anish: this is the first place people are going to look for using this option | 19:01 |
anish | gotcha | 19:01 |
mriedem | anish: so i think our config option help needs to be top notch to start | 19:01 |
*** shyu has quit IRC | 19:01 | |
mriedem | mordred: would you agree? ^ | 19:01 |
gryf_ | first patch is about utilization of forced_down flag in service group drivers, second is exposing changing that flag state by the api… | 19:02 |
mordred | mriedem: I definitely agree that config option help needs to be top notch | 19:03 |
*** hemna is now known as hemnafood | 19:03 | |
*** shyu has joined #openstack-nova | 19:04 | |
anish | mriedem: realted note, is there a way to get this backported to current release as well ? | 19:04 |
mriedem | anish: it was only changed in master | 19:05 |
JoshNang | mordred: yup that's me | 19:05 |
mriedem | so no backport needed | 19:05 |
anish | oh good ! | 19:05 |
*** sudipto has quit IRC | 19:05 | |
mordred | JoshNang: yay! | 19:06 |
*** annashen has quit IRC | 19:06 | |
mordred | JoshNang: so - a) thanks for teh work - we're using it already :) | 19:06 |
JoshNang | mordred: np! \o/ we are too | 19:06 |
mordred | JoshNang: I'm about to add support to glean for consuming the vlan structures ... but while I was reading the spec I noticed there was no example output for an interface using dhcp | 19:07 |
JoshNang | mordred: ahh dang. i need to write some actual docs for it. let me see if i can find you an example | 19:07 |
mordred | JoshNang: cool! | 19:07 |
*** Longgeek has quit IRC | 19:08 | |
mordred | JoshNang: fwiw - we have a set of test config-drives we're testing against here: http://git.openstack.org/cgit/openstack-infra/glean/tree/glean/tests/fixtures | 19:08 |
mordred | JoshNang: with our current understanding of the pending liberty structure (minus vlans) here: http://git.openstack.org/cgit/openstack-infra/glean/tree/glean/tests/fixtures/liberty/mnt/config/openstack/latest/network_info.json | 19:08 |
*** mutoulbj has joined #openstack-nova | 19:08 | |
annegentle | anish: mriedem: config ref tables on http://docs.openstack.org/kilo/config-reference are created from that help='super awesome helpfulness' | 19:09 |
mriedem | annegentle: yup | 19:09 |
annegentle | anish: mriedem: but they aren't scraped automatically | 19:09 |
*** imandhan has joined #openstack-nova | 19:09 | |
annegentle | and we don't publish config-ref til release | 19:09 |
JoshNang | mordred: nice! that example looks correct | 19:09 |
annegentle | anyway | 19:09 |
mordred | JoshNang: woot! | 19:09 |
*** thangp has quit IRC | 19:09 | |
mriedem | annegentle: yeah, i know. i was basically asking a rhetorical question about the value of good config option help | 19:10 |
annegentle | mriedem: heh :) | 19:10 |
*** fifieldt_ has joined #openstack-nova | 19:10 | |
*** thangp has joined #openstack-nova | 19:10 | |
*** mgarza_ has quit IRC | 19:11 | |
*** tongli has joined #openstack-nova | 19:11 | |
*** mgarza has joined #openstack-nova | 19:11 | |
*** achanda has joined #openstack-nova | 19:11 | |
JoshNang | mordred: so this is what a dhcp network would look like (with ipv6 right below): https://github.com/openstack/nova/blob/master/nova/tests/unit/network/test_network_info.py#L941-L946 | 19:11 |
mordred | JoshNang: sweet! | 19:12 |
mordred | JoshNang: thanks!! that's exactly what I needed | 19:12 |
JoshNang | mordred: \o/ | 19:12 |
imandhan | I'm new to openstack and am trying to setup the devstack env. When I create a nova instance, it shows as active but I'm not able to ssh or ping it. Can anyone help me with this? | 19:12 |
*** scheuran has joined #openstack-nova | 19:13 | |
*** fifieldt has quit IRC | 19:13 | |
*** belmoreira has joined #openstack-nova | 19:13 | |
*** hakimo has quit IRC | 19:13 | |
*** ashestakov has joined #openstack-nova | 19:14 | |
*** johnma has joined #openstack-nova | 19:14 | |
*** mutoulbj has quit IRC | 19:14 | |
ashestakov | hello | 19:14 |
*** hakimo has joined #openstack-nova | 19:14 | |
ashestakov | review pls https://review.openstack.org/#/c/202215/ | 19:14 |
mriedem | ashestakov: that isn't even the right project | 19:16 |
openstackgerrit | Anish Bhatt proposed openstack/nova: libvirt : remove broken olso_config choices option https://review.openstack.org/193414 | 19:17 |
anish | mriedem: see if that's better | 19:17 |
*** shyu has quit IRC | 19:17 | |
*** shyu has joined #openstack-nova | 19:17 | |
ashestakov | mriedem: sorry, where i can ask for review changes in puppet? | 19:17 |
mriedem | ashestakov: i don't know | 19:18 |
mriedem | but https://review.openstack.org/#/admin/groups/134,members | 19:18 |
openstackgerrit | Anish Bhatt proposed openstack/nova: libvirt : remove broken olso_config choices option https://review.openstack.org/193414 | 19:18 |
ashestakov | thanks | 19:18 |
mriedem | ashestakov: the readme for that project points me here https://wiki.openstack.org/wiki/Puppet#Developer_documentation | 19:19 |
mriedem | ashestakov: https://wiki.openstack.org/wiki/Puppet#IRC | 19:19 |
mriedem | that'll be $5 please | 19:19 |
ashestakov | :) | 19:19 |
openstackgerrit | Belmiro Moreira proposed openstack/nova: Creates flavor* tables in API database https://review.openstack.org/201606 | 19:21 |
*** ashestakov has left #openstack-nova | 19:21 | |
*** imandhan has quit IRC | 19:22 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtISERVolumeDriver into it's own module https://review.openstack.org/197311 | 19:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move volume/remotefs/quobyte modules under volume subdir https://review.openstack.org/193223 | 19:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtNETVolumeDriver into it's own module https://review.openstack.org/197341 | 19:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtNFSVolumeDriver into it's own module https://review.openstack.org/196859 | 19:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move the LibvirtScalityVolumeDriver into it's own module https://review.openstack.org/193249 | 19:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move lvm/dmcrypt/rbd_utils modules under storage subdir https://review.openstack.org/193195 | 19:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtAOEVolumeDriver into it's own module https://review.openstack.org/196276 | 19:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move the LibvirtQuobyteVolumeDriver into the quobyte module https://review.openstack.org/193236 | 19:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtFibreChannelVolumeDriver into it's own module https://review.openstack.org/193278 | 19:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtGlusterfsVolumeDriver into it's own module https://review.openstack.org/193380 | 19:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move fibre channel specific utilities into fc module https://review.openstack.org/193317 | 19:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move the LibvirtGPFSVolumeDriver into it's own module https://review.openstack.org/193240 | 19:24 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtSMBFSVolumeDriver into it's own module https://review.openstack.org/196380 | 19:24 |
anish | mriedem: wouldn't some of that get handled by os-brick ? | 19:24 |
*** gyee has quit IRC | 19:25 | |
mriedem | anish: sort of | 19:25 |
bauzas | evening nova | 19:25 |
*** newbie_2 has joined #openstack-nova | 19:25 | |
mriedem | right now i don't want to rebase on top of the os-brick change | 19:25 |
openstackgerrit | Qiu Yu proposed openstack/nova: libvirt: Force iSCSI disconnect after timeout https://review.openstack.org/167815 | 19:25 |
anish | mriedem: heh, I'm doing the same changes in os-brick | 19:26 |
anish | mriedem: so the only issue with the way you want is that open-iscsi does not care what you call your iface file | 19:26 |
*** ijw has quit IRC | 19:26 | |
anish | that's just the default format if you use the utilities provided to make the files | 19:27 |
anish | but you can generate them manually and call them whatever you like | 19:27 |
anish | I can say "preferred format is .." | 19:27 |
mriedem | anish: so iscsi_iface can just be "squishy_squat" and no one cares? | 19:29 |
mriedem | maybe say default format is | 19:30 |
mriedem | <transport_name>.<hwaddress> | 19:30 |
*** gyee has joined #openstack-nova | 19:34 | |
*** scheuran has quit IRC | 19:35 | |
anish | mriedem: yep, squishy_sqaut is fine. | 19:36 |
*** jecarey has joined #openstack-nova | 19:37 | |
openstackgerrit | Anish Bhatt proposed openstack/nova: libvirt : remove broken olso_config choices option https://review.openstack.org/193414 | 19:38 |
anish | doneski | 19:38 |
*** belmoreira has quit IRC | 19:43 | |
*** markvoelker has joined #openstack-nova | 19:43 | |
*** ctrath has quit IRC | 19:44 | |
*** markvoelker has quit IRC | 19:45 | |
*** markvoelker has joined #openstack-nova | 19:46 | |
*** tjones1 has quit IRC | 19:48 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/200708 | 19:48 |
*** dave-mccowan has joined #openstack-nova | 19:48 | |
mriedem | hemnafood: really only about 2 small things left in here and then i'm thinking it's pretty solid https://review.openstack.org/#/c/175569/ | 19:48 |
mriedem | anish: one typo | 19:49 |
mriedem | then +2 | 19:49 |
*** mgarza has quit IRC | 19:50 | |
*** mgarza has joined #openstack-nova | 19:50 | |
*** ijw has joined #openstack-nova | 19:51 | |
*** nkrinner_afk is now known as nkrinner | 19:51 | |
anish | mriedem: SO CLOSE | 19:51 |
*** y_sawai has joined #openstack-nova | 19:51 | |
*** salv-orlando has joined #openstack-nova | 19:51 | |
openstackgerrit | Anish Bhatt proposed openstack/nova: libvirt : remove broken olso_config choices option https://review.openstack.org/193414 | 19:52 |
anish | I wonder if there's a way to hookup pep to a dictionary | 19:52 |
*** annegentle has quit IRC | 19:53 | |
*** annegentle has joined #openstack-nova | 19:53 | |
*** hemnafood is now known as hemna | 19:54 | |
*** dave-mccowan has quit IRC | 19:55 | |
hemna | mriedem, ok I'll check them out. thanks for the help and the review | 19:56 |
*** salv-orlando has quit IRC | 19:57 | |
*** dave-mccowan has joined #openstack-nova | 19:58 | |
*** lpetrut has joined #openstack-nova | 19:58 | |
*** mgarza has quit IRC | 20:01 | |
*** mgarza has joined #openstack-nova | 20:02 | |
*** tjones1 has joined #openstack-nova | 20:05 | |
mriedem | easy fix for other nova cores around https://review.openstack.org/#/c/193414/ | 20:07 |
*** Longgeek has joined #openstack-nova | 20:08 | |
*** cpschult has joined #openstack-nova | 20:09 | |
*** mgarza has quit IRC | 20:10 | |
*** mgarza has joined #openstack-nova | 20:10 | |
*** mutoulbj has joined #openstack-nova | 20:12 | |
*** ctrath has joined #openstack-nova | 20:13 | |
*** Longgeek has quit IRC | 20:13 | |
*** redbeard has quit IRC | 20:14 | |
*** annegentle has quit IRC | 20:18 | |
*** pmcfadden has quit IRC | 20:19 | |
*** lpetrut has quit IRC | 20:20 | |
*** READ10 has quit IRC | 20:22 | |
*** y_sawai has quit IRC | 20:24 | |
*** tonytan4ever has quit IRC | 20:25 | |
*** y_sawai has joined #openstack-nova | 20:25 | |
*** dave-mccowan has quit IRC | 20:26 | |
*** iamjarvo has quit IRC | 20:26 | |
*** dave-mccowan has joined #openstack-nova | 20:28 | |
*** ijw has quit IRC | 20:28 | |
*** mutoulbj has quit IRC | 20:28 | |
*** ijw has joined #openstack-nova | 20:29 | |
bauzas | alaski: sounds like I missed the Cells meeting, right ? :) | 20:29 |
alaski | bauzas: yes. but you didn't miss much | 20:30 |
bauzas | alaski: no worries, will look at the logs | 20:30 |
*** thangp has quit IRC | 20:30 | |
bauzas | alaski: I'm actually reading my backlog, and something popped up | 20:30 |
bauzas | alaski: https://review.openstack.org/#/c/145528/26/nova/objects/request_spec.py,cm | 20:30 |
*** tjones1 has left #openstack-nova | 20:30 | |
bauzas | alaski: sounds like you're unhappy with using the objects in the from_dict() method :) | 20:31 |
alaski | bauzas: well, it's a few things | 20:31 |
bauzas | alaski: any chance to discuss that now ? | 20:31 |
alaski | I'm more unhappy with the db lookup | 20:31 |
alaski | bauzas: sure | 20:31 |
bauzas | alaski: yeah understood your point | 20:31 |
bauzas | that and the need of a Computenode object instead of a tuple | 20:32 |
*** htruta_ has quit IRC | 20:32 | |
alaski | yes. that mainly makes it harder to setup for testing | 20:32 |
*** htruta has joined #openstack-nova | 20:32 | |
alaski | but it's also a lot to use when most of it is unnecessary there | 20:33 |
bauzas | alaski: well, to give you a quick explanation of why my torteous mind came to CN objects | 20:33 |
bauzas | alaski: it was mainly because I felt it wrong to have such unclear tuples for that | 20:34 |
bauzas | alaski: just because we check a Compute node right? | 20:34 |
*** tonytan4ever has joined #openstack-nova | 20:34 | |
*** newbie_2 has quit IRC | 20:34 | |
bauzas | alaski: tbh, the scheduler is returning a tuple of HostState fields | 20:34 |
bauzas | alaski: that becomes the destination | 20:34 |
openstackgerrit | melanie witt proposed openstack/nova: Convert instance_type to object in prep_resize https://review.openstack.org/202271 | 20:35 |
bauzas | alaski: but here, I think it should be considered as a Computenode (and honestly, HostState should be just dumped in favor of ComputeNode) | 20:35 |
alaski | yeah, I get the desire to use objects there | 20:35 |
bauzas | alaski: so, I'm probably thinking 2 or 3 steps far from now | 20:36 |
alaski | I would prefer another object to store the tuple, if we want an object | 20:36 |
*** annegentle has joined #openstack-nova | 20:36 | |
alaski | ComputeNode doesn't even have nodename in it, so I don't think that will work for Retry anyways, right? | 20:36 |
bauzas | alaski: and until the scheduler returns a list of ComputeNodes, we could possibly use another object | 20:36 |
bauzas | alaski: it has - it's very badly named hypervisor_hostname | 20:36 |
*** jasondotstar has quit IRC | 20:37 | |
alaski | oh | 20:37 |
bauzas | alaski: so, I'm pretty okay with using a new object, but I'm just a little concerned by the possible duplication we could have | 20:37 |
*** newbie_2 has joined #openstack-nova | 20:38 | |
bauzas | alaski: in particular if/when we do the move I mentioned - returning list of CN objects instead of tuples | 20:38 |
alaski | we could pull out hypervisor_hostname and host info from ComputeNode, and then store the new object in there | 20:38 |
alaski | what I'm realizing is that ComputeNode has a payload of information that's relevant to the scheduler, but not much else. what we need is something that's a reference to that | 20:39 |
bauzas | alaski: wouldn't the new object (call it Destination or Attempt) just a subset of ComputeNode then ? | 20:39 |
alaski | then pass around the reference, and the scheduler can associate it with the ComputeNode | 20:39 |
*** krtaylor has quit IRC | 20:40 | |
*** vladikr has quit IRC | 20:40 | |
*** nkrinner is now known as nkrinner_afk | 20:40 | |
bauzas | meh, you possibly lost me :) | 20:40 |
alaski | it would have a subset of info, but I think it's useful as a reference | 20:40 |
alaski | bauzas: essentially let's not pass around computenode when all we need is (host, node) | 20:41 |
bauzas | alaski: that I understand | 20:41 |
alaski | and then when (host, node) is passed into the scheduler it can look up the computenode | 20:41 |
alaski | if (host, node) is in an object, that's fine | 20:41 |
* bauzas thinking about when the retry logic is done/called | 20:42 | |
alaski | bauzas: specifically for the request spec stuff, move the objects.ComputeNode.get_by_host_and_nodename into the scheduler, and let Retry.hosts be a lightweight field | 20:43 |
bauzas | alaski: yeah, I see your point | 20:43 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/200708 | 20:44 |
alaski | though it could be objects.ComputeNode.get_by_hostnodeobj() and use a hostnodeobj in Retry | 20:44 |
*** y_sawai has quit IRC | 20:45 | |
alaski | although I also have concerns about the object explosion here :) | 20:45 |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/nova: Switch to using os-brick https://review.openstack.org/175569 | 20:46 |
*** Nikolay_St has joined #openstack-nova | 20:46 | |
*** jasondotstar has joined #openstack-nova | 20:46 | |
bauzas | alaski: yeah, again I see your points, I appreciate that and I think it's doable, I'm just thinking of any implication :) | 20:47 |
*** dboik has quit IRC | 20:47 | |
bauzas | alaski: ie. a free tuple is certainly not the best option for that information, but having a new object just for that sounds quite heavy to me | 20:48 |
*** mgarza has quit IRC | 20:48 | |
bauzas | alaski: since we can't really easily deprecate objects :-( | 20:48 |
*** mgarza has joined #openstack-nova | 20:49 | |
alaski | bauzas: yeah. I would favor starting light and building up where appropriate once we start using the objects | 20:49 |
dansmith | say wha? | 20:49 |
dansmith | we can deprecate objects whenever we want | 20:49 |
*** leseb_ has joined #openstack-nova | 20:49 | |
melwitt | bauzas, alaski: so is the conclusion that we'll use a tuple? | 20:50 |
dansmith | the difficulty just comes from how pervasively a thing is used, which is pretty much the case regardless | 20:50 |
melwitt | or are you saying make a new object that is only host and node | 20:51 |
bauzas | melwitt: that's indeed the question | 20:51 |
alaski | melwitt: bauzas that would be my preference for now( the tuple), and then once we're using the object in the scheduler if it makes sense to bulk it up into an object we could | 20:51 |
melwitt | okay. sorry wasn't totally following | 20:51 |
bauzas | dansmith: well, deprecating an object needs to make sure that nobody is calling it, right? | 20:51 |
bauzas | dansmith: I missed the migration path for a whole object, not a field | 20:52 |
dansmith | if it has methods | 20:52 |
bauzas | dansmith: you mean remotable methods ? | 20:52 |
dansmith | yeah | 20:52 |
*** agireud has joined #openstack-nova | 20:52 | |
bauzas | well, good point | 20:52 |
dansmith | I didn't read the whole conversation, | 20:52 |
dansmith | but if you're talking about communicating any amount of data between two things on different machines or code levels, | 20:52 |
*** krtaylor has joined #openstack-nova | 20:52 | |
dansmith | then having a version is worthwhile, IMHO | 20:53 |
dansmith | saying "just return a tuple because it's simple" only works until you have to add something :) | 20:53 |
bauzas | dansmith: melwitt: the convo is about https://review.openstack.org/#/c/145528/26/nova/objects/request_spec.py,cm | 20:53 |
alaski | dansmith: yeah. this is about a tuple as a field vs another object | 20:53 |
*** dboik has joined #openstack-nova | 20:53 | |
bauzas | dansmith: melwitt: here we have some unversioned information passed over the wire to the scheduler | 20:53 |
dansmith | alaski: and specifically the result of a placement request, presumably? | 20:54 |
alaski | dansmith: yes, the list of hosts that have been tried, for the retry filter | 20:54 |
dansmith | yeah | 20:54 |
bauzas | dansmith: correct, that's a list of HostState | 20:54 |
bauzas | dansmith: which is barely identical to ComputeNodes but not the same object | 20:55 |
*** tjones1 has joined #openstack-nova | 20:55 | |
bauzas | so creating a new object for that would mean that we would have the ComputeNode object, the HostState vanilla object and that new object | 20:55 |
alaski | I'm not against an object there, but I think ComputeNode is the wrong one | 20:55 |
bauzas | alaski: sure | 20:56 |
dansmith | it has a lot of stuff in it that is probably not related to the placement decision | 20:56 |
openstackgerrit | Mike Dorman proposed openstack/nova: Add console allowed origins setting https://review.openstack.org/201677 | 20:56 |
dansmith | so if that's the concern, then yeah | 20:57 |
bauzas | fair guys :) | 20:57 |
bauzas | okay, lemme create a new Destination object :) | 20:57 |
melwitt | I started going through the review again earlier today and I think the concern is the db lookup that has to occur because of using ComputeNode object, right? | 20:58 |
* bauzas is giving a call to anyone better than him about naming | 20:58 | |
bauzas | melwitt: yup | 20:58 |
bauzas | melwitt: mostly that | 20:58 |
bauzas | anyway, some cores just made me happy by merging something that broke my series :p | 20:59 |
*** ildikov has joined #openstack-nova | 21:00 | |
melwitt | bauzas: and I guess we've already considered the option of creating a ComputeNode mostly empty object? is that problematic, that is, will it potentially be accessible to someone who doesn't know most of it is empty | 21:01 |
*** mgarza has quit IRC | 21:01 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Add support of latest version in CLI https://review.openstack.org/184281 | 21:01 |
*** dave-mccowan has quit IRC | 21:01 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Set "latest" as default compute api version https://review.openstack.org/184658 | 21:01 |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Add "get_current" method to VersionManager https://review.openstack.org/202296 | 21:01 |
*** mgarza has joined #openstack-nova | 21:02 | |
bauzas | melwitt: fair point, but I was identifying that as non-blocker | 21:02 |
bauzas | melwitt: anyway, the outcome of that is that I'll do another object :) | 21:02 |
*** thorst has quit IRC | 21:03 | |
*** Piet has quit IRC | 21:04 | |
melwitt | bauzas: okay. I was just thinking we could use it as a versioned way to carry those things without going to the db if it's not all filled in and isn't going to be saved or other attrs accessed by someone | 21:04 |
*** unicell has quit IRC | 21:06 | |
*** dims_ has quit IRC | 21:07 | |
*** dprince has quit IRC | 21:07 | |
*** jasondotstar has quit IRC | 21:09 | |
*** gyee has quit IRC | 21:09 | |
mriedem | dansmith: do i sense a future megatuple?! | 21:11 |
*** tongli has quit IRC | 21:11 | |
dansmith | mriedem: ripe for robustification | 21:11 |
alaski | melwitt: in the short term I don't think it's problematic. but in doing that it's an indication that we're not using the right object. perhaps we could use a new one, or maybe computenode is right and some stuff should split off of that into something new | 21:12 |
mriedem | son of megatuple | 21:12 |
dansmith | melwitt: it's not problematic | 21:12 |
*** mgarza has quit IRC | 21:13 | |
*** mgarza_ has joined #openstack-nova | 21:13 | |
dansmith | maybe we should try to come up with some measure for whether computenode is right | 21:13 |
dansmith | like, is there anything that would be in the Destination object that's not in ComputeNode? | 21:13 |
dansmith | or any difference? | 21:13 |
dansmith | or would it just be a subset of computenode? | 21:13 |
dansmith | because if the latter, maybe we should just use a sparse computenode until we come up with a reason not to | 21:14 |
*** tjones1 has left #openstack-nova | 21:14 | |
dansmith | there is a ton of silly stuff in computenode that we don't need as the result of that decision | 21:14 |
melwitt | I guess I'm currently thinking... what are right objects in general? if most of the fields are nullable and ones we don't need, it becomes blurry to me | 21:14 |
dansmith | but... maybe not worth making another object | 21:14 |
dansmith | they needn't be nullable | 21:14 |
bauzas | dansmith: oh oh, that's exactly my point above | 21:14 |
*** fawadkhaliq has joined #openstack-nova | 21:15 | |
dansmith | melwitt: memory_mb is not a nullable field of computenode, but that just means it can't be None.. Any of them can be "unset" | 21:15 |
bauzas | dansmith: I mean, if we consider Destination being possibly diverging from ComputeNode, then yeah | 21:15 |
*** whenry has quit IRC | 21:15 | |
melwitt | dansmith: ah, okay | 21:15 |
dansmith | melwitt: and we can make them lazy-loadable so that if something wants to see the memory_mb on the computenode that it asked for, it can just read it and lazy-load its value in | 21:15 |
bauzas | dansmith: but if all the Destination fields stay as subset of CN, then we could possibly get rid of it | 21:16 |
dansmith | bauzas: well, I'd argue for not creating a new thing until we need it, I think, instead of creating a thing we plan to drop if it never diverges | 21:16 |
dansmith | I'm saying all this without knowing... _is_ there anything we expect to differ from computenode, or just a subset as far as we know at this point? | 21:16 |
bauzas | oh btw. someone (I didn't remember who) asked for something in that channel and here it comes https://twitter.com/sylvainbauza/status/620586311435571201 | 21:17 |
alaski | dansmith: at this point just a subset, host and node | 21:17 |
melwitt | I was thinking ComputeNode doesn't seem semantically bad in that, we're using RequestSpec to schedule to a compute node. with that host and node. if there's something semantically bad about it that I missed, then I wouldn't want to use it either | 21:17 |
bauzas | mmmmm | 21:17 |
dansmith | melwitt: yeah | 21:18 |
mriedem | hemna: i think we have to use iser_use_multipath for existing deployments | 21:18 |
mriedem | hemna: that's my last -1 on that change | 21:18 |
hemna | mriedem, does that exist ? | 21:19 |
mriedem | hemna: yeah | 21:19 |
hemna | ah ok, crap, sorry I missed that. | 21:19 |
bauzas | dansmith: melwitt: alaski: mmm, stuck review then ? | 21:20 |
melwitt | bauzas: that's a nice photo :) | 21:20 |
dansmith | I dunno, I was leaning to a new object, but now I'm kinda feeling like reuse-until-a-reason-not-to | 21:20 |
bauzas | dansmith: that's my original thoughts when I wrote that | 21:20 |
bauzas | dansmith: I felt torn between creating a new object, using a free tuple field or reusing the CN object | 21:21 |
bauzas | dansmith: I preferred the latter for the consistency of that | 21:21 |
*** dave-mccowan has joined #openstack-nova | 21:21 | |
melwitt | I'm not strongly stuck on ComputeNode but if it is semantically representing the pieces we want, I don't see why not to use it. to me the chance of divergence is related to whether or not ComputeNode represents the meaning in the scheduling | 21:21 |
bauzas | alaski: what if me keeping the CN object but removing the db call N? | 21:21 |
melwitt | I don't think we need to do a db lookup though | 21:22 |
bauzas | alaski: since it was most of your concern | 21:22 |
dansmith | what db call? | 21:22 |
bauzas | melwitt: jinxed | 21:22 |
alaski | bauzas: that would be much better | 21:22 |
melwitt | bauzas: heh, you won by a lot, I was still typing and decided to just keep going | 21:22 |
*** flwang1 has joined #openstack-nova | 21:22 | |
alaski | I'm not stuck on ComputeNode, but I will keep going on my patch to see if it becomes problematic or not | 21:23 |
melwitt | if we're bending meaning by using ComputeNode then I don't want to use it and would favor a new object | 21:23 |
melwitt | but it seems to fit as far as I know | 21:24 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/200708 | 21:24 |
alaski | bauzas: are there plans for computenode to change based on the other scheduling work that's happening? | 21:25 |
*** lpetrut has joined #openstack-nova | 21:25 | |
*** rlrossit has left #openstack-nova | 21:26 | |
*** xyang2 has quit IRC | 21:26 | |
bauzas | alaski: mmm, considering your question | 21:26 |
*** dboik_ has joined #openstack-nova | 21:26 | |
melwitt | dansmith: db call in Retry.from_dict in the review https://review.openstack.org/#/c/145528/26/nova/objects/request_spec.py,cm | 21:26 |
*** mutoulbj has joined #openstack-nova | 21:27 | |
bauzas | alaski: I don't think we need to amend the object for any stuff we need - unless jaypipes figures out any big issue when writing the resource-usage BP | 21:27 |
dansmith | melwitt: ah, to fill it out instead of just making it sparse with the info we have? | 21:27 |
dansmith | yeah, that's nuts :) | 21:28 |
*** karimb has joined #openstack-nova | 21:28 | |
melwitt | heh | 21:28 |
*** garyk has quit IRC | 21:29 | |
*** karimb has quit IRC | 21:29 | |
*** dboik has quit IRC | 21:30 | |
*** Sukhdev has joined #openstack-nova | 21:30 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move the LibvirtQuobyteVolumeDriver into the quobyte module https://review.openstack.org/193236 | 21:31 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtISERVolumeDriver into it's own module https://review.openstack.org/197311 | 21:31 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtNETVolumeDriver into it's own module https://review.openstack.org/197341 | 21:31 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtNFSVolumeDriver into it's own module https://review.openstack.org/196859 | 21:31 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move the LibvirtScalityVolumeDriver into it's own module https://review.openstack.org/193249 | 21:31 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtGlusterfsVolumeDriver into it's own module https://review.openstack.org/193380 | 21:31 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtFibreChannelVolumeDriver into it's own module https://review.openstack.org/193278 | 21:31 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move fibre channel specific utilities into fc module https://review.openstack.org/193317 | 21:31 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move the LibvirtGPFSVolumeDriver into it's own module https://review.openstack.org/193240 | 21:31 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtSMBFSVolumeDriver into it's own module https://review.openstack.org/196380 | 21:31 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtAOEVolumeDriver into it's own module https://review.openstack.org/196276 | 21:31 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtISCSIVolumeDriver into it's own module https://review.openstack.org/202301 | 21:31 |
melwitt | whhoooaa | 21:31 |
*** dboik_ has quit IRC | 21:31 | |
openstackgerrit | Walter A. Boring IV (hemna) proposed openstack/nova: Switch to using os-brick https://review.openstack.org/175569 | 21:31 |
*** LukeHinds has quit IRC | 21:32 | |
*** karimb has joined #openstack-nova | 21:32 | |
mriedem | ^ +2 on now | 21:33 |
mriedem | if another core can get on it sometime | 21:33 |
mriedem | +193, -2281 | 21:33 |
*** Piet has joined #openstack-nova | 21:33 | |
mriedem | weird | 21:33 |
bauzas | oh, btw. I know that can be silly, but you guys okay with that kind of big change https://review.openstack.org/#/c/197912/5 ? | 21:35 |
bauzas | or should I begin to split it into like 10 different changes ? :) | 21:35 |
melwitt | yeah, I was just being silly seeing all those changes at the same time | 21:36 |
*** salv-orlando has joined #openstack-nova | 21:36 | |
*** pixelbeat_ has joined #openstack-nova | 21:37 | |
bauzas | melwitt: fair point, the change is very limited, but it's pretty hairy so I think it could be good to split anyway | 21:37 |
*** mriedem is now known as mriedem_away | 21:38 | |
melwitt | bauzas: I agree | 21:38 |
*** dave-mccowan has quit IRC | 21:39 | |
*** garyk has joined #openstack-nova | 21:40 | |
*** mutoulbj has quit IRC | 21:41 | |
hemna | mriedem_away, :)! | 21:41 |
*** vilobhmm has quit IRC | 21:42 | |
*** vilobhmm has joined #openstack-nova | 21:42 | |
*** bnemec has quit IRC | 21:43 | |
*** mgarza_ has quit IRC | 21:43 | |
*** annegentle has quit IRC | 21:44 | |
*** mgarza has joined #openstack-nova | 21:44 | |
*** annegentle has joined #openstack-nova | 21:44 | |
*** jamielennox|away is now known as jamielennox | 21:49 | |
*** annegentle has quit IRC | 21:49 | |
openstackgerrit | Anish Bhatt proposed openstack/nova: libvirt : remove broken olso_config choices option https://review.openstack.org/193414 | 21:50 |
*** mjturek1 has joined #openstack-nova | 21:51 | |
*** lpetrut has quit IRC | 21:55 | |
*** cpschult has quit IRC | 21:55 | |
*** fawadkhaliq has quit IRC | 21:55 | |
*** earlephilhower_ has quit IRC | 21:56 | |
*** jaypipes has quit IRC | 21:57 | |
*** Longgeek has joined #openstack-nova | 21:57 | |
*** browne has quit IRC | 22:00 | |
*** patrickeast has quit IRC | 22:03 | |
*** krtaylor has quit IRC | 22:03 | |
*** earlephilhower has joined #openstack-nova | 22:03 | |
*** edmondsw has quit IRC | 22:05 | |
*** achanda has quit IRC | 22:06 | |
*** achanda has joined #openstack-nova | 22:06 | |
*** signed8bit has joined #openstack-nova | 22:06 | |
*** mdrabe has quit IRC | 22:07 | |
*** hakimo has quit IRC | 22:07 | |
*** hakimo has joined #openstack-nova | 22:08 | |
*** tonytan4ever has quit IRC | 22:09 | |
*** mjturek1 has quit IRC | 22:09 | |
*** signed8bit_ZZZzz has quit IRC | 22:10 | |
*** mgarza has quit IRC | 22:11 | |
*** mgarza has joined #openstack-nova | 22:12 | |
*** agireud has quit IRC | 22:15 | |
*** patrickeast has joined #openstack-nova | 22:15 | |
*** exploreshaifali has quit IRC | 22:15 | |
*** oro_ has joined #openstack-nova | 22:15 | |
*** oro has joined #openstack-nova | 22:16 | |
*** krtaylor has joined #openstack-nova | 22:16 | |
*** Longgeek has quit IRC | 22:16 | |
openstackgerrit | Earle F. Philhower, III proposed openstack/nova: Add os_brick-based VolumeDriver for HGST connector https://review.openstack.org/194412 | 22:17 |
*** tjones1 has joined #openstack-nova | 22:17 | |
*** zul has quit IRC | 22:17 | |
*** ijw has quit IRC | 22:18 | |
*** ctrath has quit IRC | 22:21 | |
*** ctrath has joined #openstack-nova | 22:21 | |
*** EmilienM is now known as EmilienM|off | 22:22 | |
*** doude has quit IRC | 22:23 | |
*** karimb has quit IRC | 22:25 | |
*** doude has joined #openstack-nova | 22:26 | |
*** tonytan4ever has joined #openstack-nova | 22:26 | |
*** patrickeast has quit IRC | 22:27 | |
*** igordcard_ has quit IRC | 22:30 | |
tonyb | edleafe: ping? | 22:30 |
*** aysyd has quit IRC | 22:31 | |
*** patrickeast has joined #openstack-nova | 22:32 | |
*** annashen has joined #openstack-nova | 22:34 | |
*** annashen has quit IRC | 22:35 | |
*** johnma has quit IRC | 22:35 | |
*** tpeoples has quit IRC | 22:36 | |
*** signed8bit is now known as signed8bit_ZZZzz | 22:37 | |
*** EmilienM|off is now known as EmilienM | 22:37 | |
*** ijw has joined #openstack-nova | 22:37 | |
*** annashen has joined #openstack-nova | 22:38 | |
*** rdo_ has quit IRC | 22:39 | |
*** kylek3h has quit IRC | 22:40 | |
*** ijw_ has joined #openstack-nova | 22:41 | |
*** rdo has joined #openstack-nova | 22:41 | |
*** mutoulbj has joined #openstack-nova | 22:41 | |
*** ijuwang has quit IRC | 22:42 | |
*** ijw has quit IRC | 22:42 | |
*** yamahata has quit IRC | 22:42 | |
*** pixelbeat_ has quit IRC | 22:44 | |
*** oro has quit IRC | 22:45 | |
*** oro_ has quit IRC | 22:45 | |
*** dims_ has joined #openstack-nova | 22:51 | |
*** mutoulbj has quit IRC | 22:51 | |
*** xyang1 has joined #openstack-nova | 22:52 | |
*** ctrath has quit IRC | 22:55 | |
*** browne has joined #openstack-nova | 22:57 | |
*** mestery_ has joined #openstack-nova | 23:00 | |
*** vilobhmm has quit IRC | 23:02 | |
*** achanda_ has joined #openstack-nova | 23:02 | |
*** achanda has quit IRC | 23:02 | |
*** vilobhmm has joined #openstack-nova | 23:02 | |
*** EmilienM is now known as EmilienM|off | 23:03 | |
*** mestery has quit IRC | 23:03 | |
*** ivasev_ has quit IRC | 23:04 | |
*** ijw_ has quit IRC | 23:04 | |
*** mgarza has quit IRC | 23:04 | |
*** ijw has joined #openstack-nova | 23:04 | |
*** vilobhmm2 has joined #openstack-nova | 23:04 | |
*** diogogmt_ has quit IRC | 23:05 | |
*** jasondotstar has joined #openstack-nova | 23:07 | |
*** vilobhmm has quit IRC | 23:07 | |
*** tjones1 has quit IRC | 23:07 | |
*** devlaps has joined #openstack-nova | 23:08 | |
*** devlaps has quit IRC | 23:08 | |
*** jasondotstar has quit IRC | 23:10 | |
*** annegentle has joined #openstack-nova | 23:10 | |
*** zzzeek has quit IRC | 23:13 | |
*** annegentle has quit IRC | 23:15 | |
*** MentalRay__ has joined #openstack-nova | 23:19 | |
*** MentalRay__ has quit IRC | 23:20 | |
*** MentalRay_ has quit IRC | 23:20 | |
*** ZZelle_ has quit IRC | 23:24 | |
*** annegentle has joined #openstack-nova | 23:26 | |
*** zhenguo has joined #openstack-nova | 23:27 | |
*** Sukhdev has quit IRC | 23:30 | |
*** tonytan4ever has quit IRC | 23:31 | |
*** ijw_ has joined #openstack-nova | 23:37 | |
*** dave-mccowan has joined #openstack-nova | 23:37 | |
gmann_ | mtreinish: mriedem_away : on both job Tempest use v2 endpoint (compute as registered by devstack) and for v2.1 job we just redirect /v2 to v2.1 API wrapper by overriding nova api-paste.ini | 23:38 |
*** ijw__ has joined #openstack-nova | 23:39 | |
mtreinish | gmann_: yeah that's the weird part | 23:39 |
mtreinish | the overriding the paste file | 23:39 |
gmann_ | mtreinish: hummm | 23:39 |
*** tonytan4ever has joined #openstack-nova | 23:39 | |
mtreinish | you should have both enabled and just tell tempest which endpoint to use | 23:40 |
*** doude has quit IRC | 23:40 | |
*** doude has joined #openstack-nova | 23:40 | |
*** doude has quit IRC | 23:40 | |
*** doude has joined #openstack-nova | 23:40 | |
mtreinish | but mriedem_away sent: http://lists.openstack.org/pipermail/openstack-dev/2015-July/069624.html so you should probably reply there | 23:40 |
*** oomichi has joined #openstack-nova | 23:40 | |
*** ijw has quit IRC | 23:40 | |
*** thorst has joined #openstack-nova | 23:41 | |
*** ijw_ has quit IRC | 23:42 | |
*** ijw has joined #openstack-nova | 23:42 | |
gmann_ | mtreinish: but endpoint in Tempest is being set internally right | 23:42 |
mtreinish | gmann_: no you just give it the catalog entry name in the config file | 23:43 |
mtreinish | v21 and v2 are 2 different registered endpoints in the catalog right? | 23:43 |
gmann_ | mtreinish: ahh right. | 23:43 |
mtreinish | gmann_: http://git.openstack.org/cgit/openstack/tempest/tree/tempest/config.py#n261 | 23:44 |
gmann_ | mtreinish: yes, with compute and computev21 | 23:45 |
gmann_ | mtreinish: yea | 23:45 |
mtreinish | gmann_: but mriedem_away was more concerned with the fact that nova by default has v2.1 turned off | 23:45 |
mtreinish | this was a side issue :) | 23:45 |
*** ijw__ has quit IRC | 23:46 | |
gmann_ | mtreinish:is it? | 23:46 |
gmann_ | gmann | 23:46 |
*** dave-mccowan has quit IRC | 23:46 | |
*** hemna is now known as hemnafk | 23:47 | |
*** IanGovett has quit IRC | 23:48 | |
mtreinish | gmann_: http://git.openstack.org/cgit/openstack/nova/tree/nova/api/openstack/__init__.py#n44 | 23:49 |
mtreinish | devstack explicitly sets that to true: http://git.openstack.org/cgit/openstack-dev/devstack/tree/lib/nova#n493 | 23:49 |
*** mutoulbj has joined #openstack-nova | 23:51 | |
*** thorst has quit IRC | 23:52 | |
openstackgerrit | Jim Rollenhagen proposed openstack/nova-specs: Ironic: Multiple compute host support https://review.openstack.org/194453 | 23:55 |
gmann_ | mtreinish: right :), that surprise for me too. we might have missed to change its value to True while making v21 as current. | 23:55 |
jroll | dansmith: ^ updated. going to try to get initial code done before next week hits | 23:55 |
jroll | where's that pipes character | 23:56 |
gmann_ | mtreinish: back to making v21 default in gate | 23:57 |
*** johnma has joined #openstack-nova | 23:58 | |
gmann_ | mtreinish: one way is just override the default catalog in tempest to v21 one and change it to compute for v2 | 23:58 |
*** annashen has quit IRC | 23:58 | |
*** Sukhdev has joined #openstack-nova | 23:59 | |
gmann_ | mtreinish: or we change default in tempest itself so that all existing jobs will talk to v21 and lets have specific job for v2 | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!