*** vilobhmm has quit IRC | 00:00 | |
*** ssurana1 has joined #openstack-nova | 00:02 | |
*** pkoniszewski has quit IRC | 00:02 | |
*** tjones has quit IRC | 00:03 | |
*** tjones has joined #openstack-nova | 00:04 | |
*** lucas__ has joined #openstack-nova | 00:04 | |
tjones | so speaking of config options. i noticed when i run tox -egenconfig it does not generate all of the config variables. Is there a way to make it do so? | 00:04 |
---|---|---|
*** davideagnello has quit IRC | 00:05 | |
*** pkoniszewski has joined #openstack-nova | 00:05 | |
mriedem | tjones: i thought there was a bug for that but not sure where it's all landed | 00:06 |
mriedem | or if there was an outstanding change, dims might know | 00:06 |
tjones | for example - verbose is not there or debug, and others :-( | 00:06 |
tjones | dims: do you know?? | 00:06 |
*** lucas__ has quit IRC | 00:08 | |
dims | tjones: which specific config option? (from which python module? | 00:08 |
mriedem | dims: verbose/debug | 00:09 |
tjones | well what i want are all of them | 00:09 |
mriedem | those come from oslo.log right? | 00:09 |
mriedem | tjones: so new world order is the nova options come from http://git.openstack.org/cgit/openstack/nova/tree/setup.cfg#n28 | 00:09 |
mriedem | but i'm not sure how options from oslo / keystone libs are pulled in | 00:09 |
mriedem | should come from here http://git.openstack.org/cgit/openstack/nova/tree/etc/nova/nova-config-generator.conf#n13 | 00:10 |
mriedem | which should pull these in http://git.openstack.org/cgit/openstack/oslo.log/tree/oslo_log/_options.py | 00:11 |
tjones | ah oslo.log is there. oh crap - im on kilo right now. im sure it's totally different… | 00:11 |
*** jasondotstar has quit IRC | 00:11 | |
*** ijw has quit IRC | 00:12 | |
mriedem | gah! | 00:12 |
dims | tjones: ok | 00:15 |
*** achanda has quit IRC | 00:15 | |
tjones | dims: ok?? | 00:16 |
dims | tjones: kilo, i haven't touched :) the oslo-config-generator is only in master | 00:16 |
*** jasondotstar has joined #openstack-nova | 00:17 | |
tjones | am i right in thinking that in kilo when you do that, all config options should be in the sample? if so something broke in kilo. ill take a look and see if i can figure it out. | 00:17 |
dims | tjones: y, please do, i can look tomorrow if you are still stuck | 00:18 |
tjones | i'll give it a try. i may ping you tomorrow if i get stuck ;-) | 00:19 |
*** xek_ has joined #openstack-nova | 00:19 | |
*** xek has quit IRC | 00:20 | |
*** isq_ has joined #openstack-nova | 00:20 | |
*** isq has quit IRC | 00:20 | |
*** Piet has quit IRC | 00:21 | |
mriedem | tjones: i seem to remember this being a known issue in kilo where the external oslo lib options weren't pulled into nova's sample config | 00:22 |
tjones | im just not sure what else is missing - just oslo stuff? | 00:23 |
*** david-lyle has quit IRC | 00:24 | |
*** ujjain has quit IRC | 00:24 | |
*** mdrabe has joined #openstack-nova | 00:24 | |
mriedem | and probably keystonemiddleware | 00:26 |
mriedem | anything that's not an option in nova itself, listed in here http://git.openstack.org/cgit/openstack/nova/tree/etc/nova/nova-config-generator.conf#n13 | 00:26 |
*** ujjain has joined #openstack-nova | 00:26 | |
*** ujjain has quit IRC | 00:26 | |
*** ujjain has joined #openstack-nova | 00:26 | |
tjones | ah ok thanks | 00:28 |
*** veena has quit IRC | 00:29 | |
*** tonytan4ever has joined #openstack-nova | 00:30 | |
*** tsekiyam_ has joined #openstack-nova | 00:32 | |
openstackgerrit | Meghal Gosalia proposed openstack/nova-specs: Quota Management for Dynamic Quota Resources https://review.openstack.org/206160 | 00:32 |
*** xyang1 has quit IRC | 00:33 | |
openstackgerrit | Meghal Gosalia proposed openstack/nova-specs: Quota Management for Dynamic Quota Resources https://review.openstack.org/206160 | 00:33 |
*** mdrabe has quit IRC | 00:34 | |
*** changbl has joined #openstack-nova | 00:34 | |
*** mtanino has quit IRC | 00:34 | |
*** gzhai has quit IRC | 00:34 | |
openstackgerrit | Meghal Gosalia proposed openstack/nova-specs: Quota Management for Dynamic Quota Resources https://review.openstack.org/206160 | 00:34 |
*** tsekiyama has quit IRC | 00:35 | |
*** tsekiyam_ has quit IRC | 00:36 | |
*** shyu has joined #openstack-nova | 00:37 | |
*** otter768 has joined #openstack-nova | 00:37 | |
*** mwagner_lap has joined #openstack-nova | 00:40 | |
*** leeantho has quit IRC | 00:41 | |
*** pkoniszewski has quit IRC | 00:43 | |
*** browne_ has joined #openstack-nova | 00:45 | |
*** xek_ has quit IRC | 00:46 | |
*** xek_ has joined #openstack-nova | 00:47 | |
*** browne_ has quit IRC | 00:47 | |
*** tonytan4ever has quit IRC | 00:48 | |
*** pkoniszewski has joined #openstack-nova | 00:50 | |
*** MentalRay_ has joined #openstack-nova | 00:50 | |
*** zhenguo has joined #openstack-nova | 00:57 | |
*** nic has quit IRC | 00:59 | |
*** hshiina has joined #openstack-nova | 01:02 | |
*** sajeesh has joined #openstack-nova | 01:03 | |
*** thorst has joined #openstack-nova | 01:03 | |
*** wanghua has joined #openstack-nova | 01:04 | |
sajeesh | ping melwitt | 01:04 |
*** wanghua has quit IRC | 01:05 | |
*** wanghua has joined #openstack-nova | 01:05 | |
*** angdraug has quit IRC | 01:05 | |
*** lucas____ has joined #openstack-nova | 01:05 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtISCSIVolumeDriver into it's own module https://review.openstack.org/202301 | 01:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtISERVolumeDriver into it's own module https://review.openstack.org/197311 | 01:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move volume/remotefs/quobyte modules under volume subdir https://review.openstack.org/193223 | 01:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtNFSVolumeDriver into it's own module https://review.openstack.org/196859 | 01:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtNETVolumeDriver into it's own module https://review.openstack.org/197341 | 01:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move the LibvirtScalityVolumeDriver into it's own module https://review.openstack.org/193249 | 01:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtAOEVolumeDriver into it's own module https://review.openstack.org/196276 | 01:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move the LibvirtQuobyteVolumeDriver into the quobyte module https://review.openstack.org/193236 | 01:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: convert SMBFS vol driver to LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202779 | 01:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: convert NFS volume driver to LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202778 | 01:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtFibreChannelVolumeDriver into it's own module https://review.openstack.org/193278 | 01:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtGlusterfsVolumeDriver into it's own module https://review.openstack.org/193380 | 01:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Introduce LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202777 | 01:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: convert Scality vol driver to LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202783 | 01:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: convert Quobyte driver to LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202782 | 01:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move the LibvirtGPFSVolumeDriver into it's own module https://review.openstack.org/193240 | 01:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: convert GPFS volume driver to LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202781 | 01:06 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: move LibvirtSMBFSVolumeDriver into it's own module https://review.openstack.org/196380 | 01:06 |
mriedem | rebasing that *sucked* | 01:06 |
*** tjones has quit IRC | 01:06 | |
*** browne has quit IRC | 01:08 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 01:08 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add instance action events for live migration https://review.openstack.org/195372 | 01:09 |
*** Jhelf has left #openstack-nova | 01:09 | |
*** lucas____ has quit IRC | 01:10 | |
*** jasondotstar has quit IRC | 01:12 | |
*** thorst has quit IRC | 01:14 | |
*** meghal has quit IRC | 01:14 | |
*** humble_ has joined #openstack-nova | 01:14 | |
*** armax has joined #openstack-nova | 01:15 | |
*** ssurana has joined #openstack-nova | 01:16 | |
*** ssurana1 has quit IRC | 01:16 | |
*** jasondotstar has joined #openstack-nova | 01:17 | |
*** wanghua has quit IRC | 01:17 | |
*** r-daneel has quit IRC | 01:19 | |
*** salv-orlando has joined #openstack-nova | 01:20 | |
openstackgerrit | Ian Cordasco proposed openstack/python-novaclient: Use keystoneclient's TCPKeepAliveAdapter https://review.openstack.org/204745 | 01:20 |
*** jasondotstar has quit IRC | 01:22 | |
*** shuquan has joined #openstack-nova | 01:23 | |
*** salv-orlando has quit IRC | 01:25 | |
*** patrickeast has quit IRC | 01:25 | |
*** annashen has joined #openstack-nova | 01:26 | |
*** mriedem has quit IRC | 01:26 | |
*** shuquan has quit IRC | 01:29 | |
*** shuquan_ has joined #openstack-nova | 01:29 | |
*** annashen has quit IRC | 01:31 | |
*** ssurana has quit IRC | 01:32 | |
*** lucas____ has joined #openstack-nova | 01:33 | |
*** shuquan has joined #openstack-nova | 01:35 | |
*** shuquan_ has quit IRC | 01:36 | |
*** lucas____ has quit IRC | 01:37 | |
*** shuquan_ has joined #openstack-nova | 01:54 | |
*** shuquan has quit IRC | 01:55 | |
*** shuquan_ is now known as shuquan | 01:55 | |
*** annashen has joined #openstack-nova | 01:55 | |
*** annashen has quit IRC | 02:00 | |
*** annashen has joined #openstack-nova | 02:10 | |
*** annashen has quit IRC | 02:12 | |
*** pixelbeat_ has joined #openstack-nova | 02:12 | |
*** dboik has joined #openstack-nova | 02:18 | |
*** david-lyle has joined #openstack-nova | 02:19 | |
*** unicell has quit IRC | 02:21 | |
*** haomaiwang has quit IRC | 02:21 | |
*** haomaiwa_ has joined #openstack-nova | 02:22 | |
*** david-lyle has quit IRC | 02:23 | |
*** tpeoples has joined #openstack-nova | 02:25 | |
*** Piet has joined #openstack-nova | 02:26 | |
*** annashen has joined #openstack-nova | 02:27 | |
*** dboik has quit IRC | 02:27 | |
*** dboik has joined #openstack-nova | 02:27 | |
*** jwcroppe has quit IRC | 02:27 | |
*** jwcroppe has joined #openstack-nova | 02:28 | |
*** annashen has quit IRC | 02:32 | |
*** jwcroppe has quit IRC | 02:32 | |
*** lucas__ has joined #openstack-nova | 02:34 | |
*** baoli has joined #openstack-nova | 02:35 | |
*** haomaiwa_ has quit IRC | 02:36 | |
*** haomaiwang has joined #openstack-nova | 02:36 | |
*** achanda has joined #openstack-nova | 02:37 | |
*** lucas__ has quit IRC | 02:39 | |
*** boris-42 has quit IRC | 02:40 | |
*** browne has joined #openstack-nova | 02:40 | |
*** armax has quit IRC | 02:41 | |
*** oomichi has joined #openstack-nova | 02:51 | |
*** hakimo has joined #openstack-nova | 02:51 | |
*** hakimo_ has quit IRC | 02:53 | |
oomichi | alex_xu: hi, morning | 02:55 |
alex_xu | oomichi: hi, o ha yo | 02:56 |
oomichi | alex_xu: o ha yo ;) | 02:56 |
oomichi | alex_xu: about https://review.openstack.org/#/c/167905/7/nova/compute/api.py | 02:57 |
oomichi | alex_xu: do you mean we need to remove instance.info_cache.delete() call on that ? | 02:57 |
alex_xu | oomichi: yea, I confused on destroy instance will do the same thing | 02:58 |
alex_xu | oomichi: but let me check the replied comment. | 02:58 |
oomichi | alex_xu: ok, thanks in advance :) | 02:59 |
alex_xu | oomichi: np | 02:59 |
oomichi | alex_xu: one more thing. can you check https://review.openstack.org/#/c/192043/ also again ? | 02:59 |
*** shuquan_ has joined #openstack-nova | 03:00 | |
alex_xu | oomichi: yea, sure, will check that also. | 03:00 |
*** shuquan has quit IRC | 03:00 | |
*** shuquan_ is now known as shuquan | 03:00 | |
oomichi | alex_xu: thanks again | 03:00 |
alex_xu | oomichi: np again | 03:00 |
eliqiao | alex_xu: hi, can you please recheck https://review.openstack.org/#/c/165671/10/nova/virt/libvirt/driver.py , I replied your comment. | 03:02 |
alex_xu | eliqiao: yea, will check also | 03:02 |
* alex_xu have a lot of debt | 03:03 | |
*** MentalRay_ has quit IRC | 03:03 | |
eliqiao | alex_xu: thanks in advance | 03:03 |
alex_xu | eliqiao: np, will reach it before the end of day! | 03:03 |
eliqiao | alex_xu: take it easy...:) | 03:04 |
*** tjones has joined #openstack-nova | 03:04 | |
*** sajeesh has quit IRC | 03:06 | |
*** dboik has quit IRC | 03:08 | |
*** dboik has joined #openstack-nova | 03:09 | |
*** annashen has joined #openstack-nova | 03:10 | |
*** pixelbeat_ has quit IRC | 03:10 | |
*** deepthi has joined #openstack-nova | 03:11 | |
*** mragupat has joined #openstack-nova | 03:12 | |
alex_xu | eliqiao: :) | 03:12 |
*** mragupat_ has joined #openstack-nova | 03:13 | |
*** dboik has quit IRC | 03:14 | |
*** haomaiwang has quit IRC | 03:14 | |
*** mragupat has quit IRC | 03:16 | |
*** baoli has quit IRC | 03:20 | |
*** whenry has quit IRC | 03:21 | |
*** yamahata has joined #openstack-nova | 03:21 | |
*** coolsvap|away is now known as coolsvap | 03:26 | |
*** annashen_ has joined #openstack-nova | 03:32 | |
*** tjones has quit IRC | 03:33 | |
*** david-lyle has joined #openstack-nova | 03:34 | |
*** armax has joined #openstack-nova | 03:35 | |
*** annashen has quit IRC | 03:35 | |
*** whenry has joined #openstack-nova | 03:37 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Show 'locked' information in server details https://review.openstack.org/202391 | 03:42 |
*** fawadkhaliq has joined #openstack-nova | 03:42 | |
*** otter768 has quit IRC | 03:43 | |
*** shuquan has quit IRC | 03:43 | |
*** cpschult has joined #openstack-nova | 03:44 | |
*** ishant has joined #openstack-nova | 03:48 | |
*** shuquan has joined #openstack-nova | 03:49 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/206827 | 03:49 |
*** achanda has quit IRC | 03:55 | |
*** annashen has joined #openstack-nova | 03:58 | |
*** jhesketh has quit IRC | 04:01 | |
*** hshiina has quit IRC | 04:02 | |
*** jhesketh has joined #openstack-nova | 04:02 | |
*** shuquan has quit IRC | 04:03 | |
*** annashen has quit IRC | 04:03 | |
openstackgerrit | Mike Dorman proposed openstack/nova: Add console allowed origins setting https://review.openstack.org/201677 | 04:06 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 04:06 |
*** annashen_ has quit IRC | 04:07 | |
*** dboik has joined #openstack-nova | 04:09 | |
*** mragupat_ has quit IRC | 04:09 | |
*** vishwanathj has joined #openstack-nova | 04:10 | |
*** dboik has quit IRC | 04:14 | |
*** jwcroppe has joined #openstack-nova | 04:14 | |
*** cpschult has quit IRC | 04:16 | |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: Adding user_id handling to keypair index, show and create api calls https://review.openstack.org/70485 | 04:28 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/206827 | 04:30 |
*** shuquan has joined #openstack-nova | 04:31 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs: Fixing lock information spec for latest updates https://review.openstack.org/206864 | 04:33 |
*** lucas__ has joined #openstack-nova | 04:38 | |
*** ftersin has joined #openstack-nova | 04:39 | |
*** armax has quit IRC | 04:42 | |
*** lucas__ has quit IRC | 04:42 | |
*** hshiina has joined #openstack-nova | 04:42 | |
*** shuquan has quit IRC | 04:45 | |
*** vilobhmm has joined #openstack-nova | 04:49 | |
*** unicell has joined #openstack-nova | 04:49 | |
*** annashen has joined #openstack-nova | 04:49 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Add JSON-Home document methods https://review.openstack.org/189551 | 04:50 |
*** rushiagr_away is now known as rushiagr | 04:50 | |
*** davideagnello has joined #openstack-nova | 04:51 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Add register method for JSON-Home data- index/create https://review.openstack.org/204889 | 04:51 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Add template_parameter_relation JSON-Home methods https://review.openstack.org/205374 | 04:51 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Support for registering JSON-Home data- show/delete/update https://review.openstack.org/205001 | 04:51 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Add resource_template_with_parent JSON-Home methods https://review.openstack.org/205392 | 04:52 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Register JSON-Home data for resources with parent https://review.openstack.org/205905 | 04:52 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Register JSON-Home data for resources with inherits https://review.openstack.org/205944 | 04:52 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Register JSON-Home data for resources actions https://review.openstack.org/206360 | 04:52 |
*** shaohe_robot has quit IRC | 04:54 | |
*** garyk has joined #openstack-nova | 04:54 | |
*** zzz_pczesno has joined #openstack-nova | 04:54 | |
*** shaohe_robot has joined #openstack-nova | 04:55 | |
*** pczesno has quit IRC | 04:56 | |
*** annashen_ has joined #openstack-nova | 04:59 | |
*** annashen_ has quit IRC | 05:03 | |
*** tpeoples has quit IRC | 05:07 | |
*** xgsa has joined #openstack-nova | 05:09 | |
*** annashen has quit IRC | 05:10 | |
*** davideagnello has quit IRC | 05:12 | |
*** rotbeard has joined #openstack-nova | 05:14 | |
*** annashen has joined #openstack-nova | 05:16 | |
*** jwcroppe has quit IRC | 05:25 | |
*** ajayaa has quit IRC | 05:25 | |
*** jwcroppe has joined #openstack-nova | 05:25 | |
*** achanda has joined #openstack-nova | 05:26 | |
alex_xu | eliqiao: it's done, I think you are right. | 05:28 |
eliqiao | alex_xu: cool, thanks for your supporting and reviewing.. | 05:29 |
alex_xu | eliqiao: np | 05:29 |
*** jwcroppe has quit IRC | 05:30 | |
*** deepakcs has joined #openstack-nova | 05:31 | |
*** lpetrut has joined #openstack-nova | 05:31 | |
*** kumar has joined #openstack-nova | 05:36 | |
openstackgerrit | Vilobh Meshram proposed openstack/nova-specs: Quota Management for Dynamic Quota Resources https://review.openstack.org/206160 | 05:37 |
*** chhavi has joined #openstack-nova | 05:38 | |
*** shz has quit IRC | 05:38 | |
*** liusheng has quit IRC | 05:38 | |
*** liusheng has joined #openstack-nova | 05:39 | |
*** lucas__ has joined #openstack-nova | 05:40 | |
*** otter768 has joined #openstack-nova | 05:44 | |
*** lucas__ has quit IRC | 05:44 | |
*** jwcroppe has joined #openstack-nova | 05:45 | |
*** Nikolay_St has quit IRC | 05:47 | |
*** otter768 has quit IRC | 05:48 | |
*** rajesht has joined #openstack-nova | 05:51 | |
*** Murali has joined #openstack-nova | 05:58 | |
*** scheuran has joined #openstack-nova | 05:59 | |
*** annashen_ has joined #openstack-nova | 06:00 | |
*** annashen has quit IRC | 06:00 | |
*** lpetrut has quit IRC | 06:00 | |
*** park_heijlong_ has joined #openstack-nova | 06:02 | |
*** lpetrut has joined #openstack-nova | 06:04 | |
*** annashen_ has quit IRC | 06:04 | |
*** kiran-r has joined #openstack-nova | 06:05 | |
*** rushiagr is now known as rushiagr_away | 06:07 | |
*** afazekas has joined #openstack-nova | 06:09 | |
*** liusheng has quit IRC | 06:12 | |
*** ajayaa has joined #openstack-nova | 06:13 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/206827 | 06:13 |
*** liusheng has joined #openstack-nova | 06:15 | |
*** ftersin has quit IRC | 06:16 | |
*** rushiagr_away is now known as rushiagr | 06:16 | |
*** nkrinner has joined #openstack-nova | 06:18 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex https://review.openstack.org/197213 | 06:20 |
*** josecastroleon has joined #openstack-nova | 06:22 | |
*** whenry has quit IRC | 06:25 | |
*** whenry has joined #openstack-nova | 06:27 | |
*** shz has joined #openstack-nova | 06:28 | |
*** moshele has joined #openstack-nova | 06:29 | |
*** wanghao has joined #openstack-nova | 06:30 | |
*** zhenguo has quit IRC | 06:32 | |
*** armax has joined #openstack-nova | 06:33 | |
*** rushiagr is now known as rushiagr_away | 06:34 | |
*** abhishekk has joined #openstack-nova | 06:34 | |
*** Marga_ has quit IRC | 06:36 | |
*** Nikolay_St has joined #openstack-nova | 06:37 | |
*** zhenguo has joined #openstack-nova | 06:40 | |
*** Marga_ has joined #openstack-nova | 06:40 | |
*** lucas__ has joined #openstack-nova | 06:42 | |
*** lpetrut has quit IRC | 06:45 | |
*** lucas__ has quit IRC | 06:46 | |
*** kfox1111_ has quit IRC | 06:47 | |
*** sahid has joined #openstack-nova | 06:47 | |
openstackgerrit | Yongli He proposed openstack/nova: resource tracker style pci resource management https://review.openstack.org/131321 | 06:47 |
garyk | ndipanov: you around? quick question - do you remember the nova boot command to spin up a bdm for a ephemeral disk | 06:47 |
*** browne has quit IRC | 06:49 | |
*** gzhai has joined #openstack-nova | 06:50 | |
*** gszasz has joined #openstack-nova | 06:53 | |
*** shuquan has joined #openstack-nova | 06:53 | |
*** achanda has quit IRC | 06:54 | |
*** alex_klimov has joined #openstack-nova | 06:56 | |
*** karimb has joined #openstack-nova | 06:57 | |
*** achanda has joined #openstack-nova | 06:57 | |
*** markus_z has joined #openstack-nova | 06:58 | |
*** vilobhmm has quit IRC | 06:59 | |
*** tongli_ has quit IRC | 07:00 | |
*** annashen has joined #openstack-nova | 07:01 | |
*** mpavone has joined #openstack-nova | 07:03 | |
*** yamahata has quit IRC | 07:05 | |
*** annashen has quit IRC | 07:05 | |
*** sorrison has quit IRC | 07:07 | |
garyk | anyone here know off hand the block device params to pass when doing a nova boot | 07:10 |
*** cfriesen_ has quit IRC | 07:10 | |
*** rushiagr_away is now known as rushiagr | 07:10 | |
*** salv-orlando has joined #openstack-nova | 07:12 | |
*** davideagnello has joined #openstack-nova | 07:13 | |
*** openstack-glance has joined #openstack-nova | 07:14 | |
*** adam_g has quit IRC | 07:14 | |
*** davideagnello has quit IRC | 07:17 | |
garyk | mdbooth: around? | 07:20 |
*** rushiagr is now known as rushiagr_away | 07:20 | |
*** jwcroppe has quit IRC | 07:22 | |
*** karimb has quit IRC | 07:22 | |
*** karimb has joined #openstack-nova | 07:23 | |
*** openstack-glance is now known as kodoku | 07:23 | |
*** kodoku is now known as kodoku_ | 07:23 | |
*** armax has quit IRC | 07:25 | |
*** shuquan has quit IRC | 07:27 | |
*** achanda has quit IRC | 07:27 | |
*** kmARC has joined #openstack-nova | 07:28 | |
markus_z | bauzas: FYI https://bugs.launchpad.net/nova/+bug/1479181 | 07:29 |
openstack | Launchpad bug 1479181 in OpenStack Compute (nova) "Cells: Build instance doesn't work with kilo api, juno compute " [Critical,New] | 07:29 |
*** Jeffrey4l has joined #openstack-nova | 07:31 | |
*** kumar has quit IRC | 07:31 | |
*** shuquan has joined #openstack-nova | 07:33 | |
*** rdopiera has joined #openstack-nova | 07:34 | |
*** markus_z has quit IRC | 07:34 | |
*** rdopiera_ has joined #openstack-nova | 07:35 | |
*** romainh has joined #openstack-nova | 07:36 | |
*** rdopiera_ has quit IRC | 07:36 | |
*** rdopiera has quit IRC | 07:36 | |
*** rdopiera has joined #openstack-nova | 07:36 | |
*** shuquan_ has joined #openstack-nova | 07:37 | |
*** shuquan has quit IRC | 07:38 | |
*** shuquan_ is now known as shuquan | 07:38 | |
*** jlanoux has joined #openstack-nova | 07:38 | |
*** y_sawai has joined #openstack-nova | 07:42 | |
*** lucas__ has joined #openstack-nova | 07:43 | |
*** otter768 has joined #openstack-nova | 07:44 | |
*** lpetrut has joined #openstack-nova | 07:46 | |
*** lucas__ has quit IRC | 07:48 | |
*** otter768 has quit IRC | 07:49 | |
*** y_sawai has quit IRC | 07:49 | |
*** markus_z has joined #openstack-nova | 07:51 | |
*** jwcroppe has joined #openstack-nova | 07:51 | |
*** bfic has joined #openstack-nova | 07:51 | |
kashyap | garyk: Heya, are you looking for this? -- http://docs.openstack.org/openstack-ops/content/attach_block_storage.html | 07:54 |
garyk | kashyap: i tried to use that but was unable to spin up an ephemeral disk. get all kinds of errors that are cryptic from nova api. | 07:57 |
*** y_sawai has joined #openstack-nova | 07:58 | |
kashyap | garyk: From my history on a DevStack machine, I see one of these CLIs working correctly: nova boot --flavor 1 --block_device_mapping vda=${SNAPSHOT_ID}:snap::0 --key_name oskey volume_backed | 07:58 |
kashyap | Where SNAPSHOT_ID=$(cinder snapshot-list | awk '/bootable_snapshot/ {print $2}') | 07:58 |
garyk | kashyap: ok, thanks | 07:59 |
garyk | i was trying nova boot --image cirros-0.3.2-i386-disk --flavor eli --ephemeral size=1 X | 07:59 |
garyk | and this is what i got - ERROR (BadRequest): Block Device Mapping is Invalid: Boot sequence for the instance and image/block device mapping combination is not valid. (HTTP 400) | 07:59 |
kashyap | IIRC, I was testing: "Create bootable volume, boot a nova instance from it" | 08:00 |
kashyap | garyk: I'll test yours once my new DevStack instance is built | 08:00 |
openstackgerrit | Alex Xu proposed openstack/nova: Skip additionalProperties checks when LegacyV2CompatibleWrapper enabled https://review.openstack.org/193858 | 08:01 |
openstackgerrit | Alex Xu proposed openstack/nova: Fix the wrong file name for legacy v2 compatible wrapper functional test https://review.openstack.org/206326 | 08:01 |
openstackgerrit | Alex Xu proposed openstack/nova: Add scenario for API sample tests with legacy v2 compatible wrapper https://review.openstack.org/203485 | 08:01 |
*** annashen has joined #openstack-nova | 08:01 | |
*** danpb has joined #openstack-nova | 08:01 | |
*** annashen_ has joined #openstack-nova | 08:02 | |
*** y_sawai has quit IRC | 08:02 | |
*** matrohon has joined #openstack-nova | 08:03 | |
*** annashen has quit IRC | 08:05 | |
openstackgerrit | Giridhar Jayavelu proposed openstack/nova: Create vif with net_io resource allocation https://review.openstack.org/196171 | 08:05 |
*** annashen_ has quit IRC | 08:06 | |
garyk | kashyap: ok, thanks | 08:08 |
*** lucas__ has joined #openstack-nova | 08:08 | |
*** jistr has joined #openstack-nova | 08:08 | |
openstackgerrit | Giridhar Jayavelu proposed openstack/nova: VMware: create vif with net_io resource allocation https://review.openstack.org/196171 | 08:11 |
*** lucas__ has quit IRC | 08:12 | |
*** shuquan_ has joined #openstack-nova | 08:13 | |
*** ndipanov has quit IRC | 08:14 | |
openstackgerrit | sahid proposed openstack/nova: libvirt: add os_admin_user to use with set admin password https://review.openstack.org/185921 | 08:14 |
openstackgerrit | sahid proposed openstack/nova: libvirt: enhance libvirt to set admin password https://review.openstack.org/185910 | 08:14 |
openstackgerrit | sahid proposed openstack/nova: libvirt: rework quiesce to not share "sensitive" informations https://review.openstack.org/196620 | 08:14 |
*** ndipanov has joined #openstack-nova | 08:14 | |
*** shuquan has quit IRC | 08:15 | |
*** shuquan_ is now known as shuquan | 08:15 | |
openstackgerrit | Alex Xu proposed openstack/nova: Skip additionalProperties checks when LegacyV2CompatibleWrapper enabled https://review.openstack.org/193858 | 08:15 |
openstackgerrit | Alex Xu proposed openstack/nova: Fix the wrong file name for legacy v2 compatible wrapper functional test https://review.openstack.org/206326 | 08:15 |
openstackgerrit | Alex Xu proposed openstack/nova: Add scenario for API sample tests with legacy v2 compatible wrapper https://review.openstack.org/203485 | 08:15 |
*** lucasagomes has joined #openstack-nova | 08:17 | |
*** karimb has quit IRC | 08:17 | |
*** dguitarbite has joined #openstack-nova | 08:18 | |
deepakcs | garyk: the nova flavor limits the max size of swap and ephemeral disks, not sure if 1GB is valid for flavor eli ? | 08:18 |
garyk | deepakcs: my understand in that with block devices we can create multiple ephemeral disks as long as the sum does not exceed that configured in the flavor. | 08:20 |
garyk | maybe that has not been implemented yet. | 08:20 |
deepakcs | garyk: i don't see flavor eli in my local devstack setup, but all flavor's in my setup shows '0' against ephemeral column in `nova flavor-list` | 08:20 |
*** mpaolino has joined #openstack-nova | 08:20 | |
kashyap | It's a custom flavor, probably. | 08:21 |
kashyap | Yeah, default swap size is '0' | 08:21 |
deepakcs | garyk: what is the ephermeral value for ur flavor in flavour-list ? | 08:21 |
garyk | deepakcs: it is 2 | 08:22 |
deepakcs | garyk: then --size=2 should work, try that | 08:22 |
garyk | deepakcs: yes, size = 2 and size =0 work. | 08:22 |
deepakcs | garyk: ah ok :) thats strange | 08:22 |
garyk | i just wanted to see if size =1 works | 08:22 |
openstackgerrit | Alex Xu proposed openstack/nova: Return v2 version info with v2 legacy compatible wrapper https://review.openstack.org/206930 | 08:22 |
deepakcs | garyk: ideally <=2 should work for size, iiuc | 08:23 |
garyk | deepakcs: that was my understanding too. i need to debug. | 08:25 |
garyk | serenity now | 08:25 |
deepakcs | garyk: ok , interesting , i would like to know if u figure the root cuase :) | 08:25 |
*** jasondotstar has joined #openstack-nova | 08:25 | |
garyk | sure, will notfiy you as soon as i find something | 08:25 |
*** bharath has joined #openstack-nova | 08:26 | |
*** neiljerr` has joined #openstack-nova | 08:26 | |
deepakcs | garyk: i haven't found enuf helpful doc on --ephemeral, is it documented anywhere.. the user-guide just tells how to use it, doesn't detail out the constraints/flavor relations | 08:26 |
bharath | Hi, may I know why are we creating a linux bridge every time when we launch an instance? I am using libvirt for nova and ovs as neutron plugin | 08:29 |
bharath | we are creating per vif every time, referring this code https://github.com/openstack/nova/blob/6b4146e944611685b593deabaa1d83d410e90318/nova/virt/libvirt/vif.py#L445 | 08:30 |
garyk | deepakcs: one of the many things that we need to try and improve | 08:31 |
kashyap | garyk: W/ current Git master, invoking this - nova boot --image cirros-0.3.3-x86_64-disk --flavor 2 --ephemeral size=2 vm1 | 08:32 |
kashyap | throws: "ERROR (ClientException): The server has either erred or is incapable of performing the requested operation" | 08:32 |
abhishekk | ndipanov: hi, https://review.openstack.org/#/c/192986/ | 08:33 |
* kashyap first checks if it's his environment. . . | 08:33 | |
ndipanov | abhishekk, looking | 08:35 |
ndipanov | you have a merfe conflict | 08:35 |
*** jwcroppe has quit IRC | 08:35 | |
abhishekk | ndipanov: yes I am pushing a patch for that | 08:35 |
abhishekk | just want to make sure should I remove assert statement in instancejobtracker.py? | 08:35 |
ndipanov | abhishekk, yeah - I mean we don't normally have them in code | 08:36 |
abhishekk | ndipanov: ok then I will push the patch, thank you | 08:37 |
bauzas | markus_z: heya | 08:39 |
bauzas | markus_z: okay, you want to discuss about what ? | 08:39 |
bauzas | markus_z: if it's a critical or not ? | 08:40 |
openstackgerrit | sahid proposed openstack/nova: libvirt: enhance method to return pointer_model from image prop https://review.openstack.org/174854 | 08:41 |
openstackgerrit | sahid proposed openstack/nova: libvirt: deprecate use_usb_tablet in favor of pointer_model https://review.openstack.org/176242 | 08:41 |
*** pixelbeat_ has joined #openstack-nova | 08:41 | |
bauzas | markus_z: yeah, it's a critical one hitting the cells job | 08:42 |
*** exploreshaifali has joined #openstack-nova | 08:42 | |
*** markus_z has quit IRC | 08:43 | |
*** yassine has joined #openstack-nova | 08:43 | |
*** markus_z has joined #openstack-nova | 08:43 | |
chhavi | With the latest nova I am getting the "ImportError: No module named storage" | 08:45 |
openstackgerrit | sahid proposed openstack/nova: libvirt: make host return guest information https://review.openstack.org/191046 | 08:45 |
openstackgerrit | sahid proposed openstack/nova: libvirt: make host return power state of guest https://review.openstack.org/191047 | 08:45 |
chhavi | storage folders seems to be removed from the nova ? | 08:46 |
bauzas | markus_z: oh, sec | 08:46 |
bauzas | markus_z: I thought the related bug was related to CI, but it seems it doesn't | 08:47 |
bauzas | markus_z: I'm saying that because most of the cells job runs are -1 now | 08:47 |
bauzas | checking | 08:47 |
kashyap | garyk: Hmm, strange, w/ current Nova Git, I can't even seem to boot instances -- n-api.log says it can't find an attribute 'id' -- http://paste.openstack.org/show/406178/ | 08:48 |
openstackgerrit | Alexis Lee proposed openstack/nova: Adds resource classes https://review.openstack.org/128999 | 08:48 |
openstackgerrit | Alexis Lee proposed openstack/nova: Add object models for comparing resource amounts https://review.openstack.org/128992 | 08:48 |
* kashyap starts over with a new DevStack run. | 08:49 | |
alex_xu | oomichi: re: https://review.openstack.org/#/c/192043 this make the api have different behavior between nova network and neutron backend | 08:50 |
alex_xu | oomichi: I'm not sure this what we want | 08:51 |
gmann | sdague: johnthetubaguy : I updated lock info spec as per yesterday discussion- https://review.openstack.org/#/c/206864/ | 08:51 |
deepakcs | kashyap: i am hitting the same error too (2015-07-29 08:49:05.915 TRACE nova.virt.libvirt.driver ClientException: The server has either erred or is incapable of performing the requested operation. (HTTP 500) (Request-ID: req-83be6665-2ed6-4662-b900-67d387edad9e) | 08:52 |
deepakcs | kashyap: as part of nova sending update _snapshot_status to Cinder | 08:53 |
kashyap | deepakcs: I'm trying to reproduce that issue | 08:53 |
*** ZZelle has quit IRC | 08:53 | |
danpb | l | 08:53 |
deepakcs | kashyap: I was able to create a nova VM successfully tho' | 08:53 |
danpb | ll~N | 08:53 |
*** ZZelle has joined #openstack-nova | 08:53 | |
danpb | hmm, that's not my mutt terminal window ! | 08:54 |
bauzas | okay, the CI was pretty in a bad shape yesterday night it seems... | 08:54 |
*** haypo has joined #openstack-nova | 08:54 | |
*** ip0353 has joined #openstack-nova | 08:55 | |
johnthetubaguy | gmann: cool, thanks for the update | 08:56 |
johnthetubaguy | gmann: I am curious though, what happens if its locked by a user, and an admin lists the instance, do they see locked? I guess thats OK | 08:57 |
garyk | kashyap: maybe pull them all… | 08:57 |
kashyap | garyk: :-) | 08:57 |
* kashyap just waiting for the darn `make stack` to finish. . . | 08:57 | |
oomichi | alex_xu: do you mean nova needs to allow integer or other values as name/description for Neutron? | 08:58 |
bauzas | ouch ! http://logstash.openstack.org/#eyJzZWFyY2giOiJtZXNzYWdlOlwiRVJST1I6IHRoZSBtYWluIHNldHVwIHNjcmlwdCBydW4gYnkgdGhpcyBqb2IgZmFpbGVkIC0gZXhpdCBjb2RlOiAxMzdcIiBhbmQgdGFnczpcImNvbnNvbGVcIiIsImZpZWxkcyI6W10sIm9mZnNldCI6MCwidGltZWZyYW1lIjoiODY0MDAiLCJncmFwaG1vZGUiOiJjb3VudCIsInRpbWUiOnsidXNlcl9pbnRlcnZhbCI6MH0sInN0YW1wIjoxNDM4MTYwMjc4NTM4fQ== | 08:58 |
*** ftersin has joined #openstack-nova | 08:58 | |
garyk | kashyap: there are too many moving parts :). on the bright side there is the rugby world cup soon.... | 08:59 |
alex_xu | oomichi: I mean nova-network didn't allow None or not specific any value for name/description. That patch enable not specific any value for neutron | 08:59 |
*** doude has joined #openstack-nova | 09:00 | |
kashyap | garyk: Joys of cloud | 09:00 |
alex_xu | oomichi: so for consistent API behavior, we shouldn't allow not specific any value for name/descript with neutron, does make sense? | 09:02 |
openstackgerrit | Abhishek Kekane proposed openstack/nova: libvirt: Kill rsync/scp processes before deleting instance https://review.openstack.org/192986 | 09:02 |
*** Jeffrey4l has quit IRC | 09:02 | |
*** jwcroppe has joined #openstack-nova | 09:02 | |
*** markus_z has quit IRC | 09:02 | |
*** annashen has joined #openstack-nova | 09:02 | |
sahid | hum this patch is i ready since Apr unfortunatly no core noticed it, ndipanov can you look at it please https://review.openstack.org/#/c/176360/ | 09:03 |
sahid | oomichi: ^ | 09:03 |
johnthetubaguy | alex_xu: oomichi: we need to talk about networking APIs at some point, in the long term we need a single (interoperable) network API, so you can't tell if its nova-network or neutron underneath, although it might be that certain API calls are not supported, depending on the driver or tech chosen | 09:03 |
openstackgerrit | Daniel Berrange proposed openstack/nova: Don't check flavor disk attributes when booting from volume https://review.openstack.org/204635 | 09:03 |
openstackgerrit | Daniel Berrange proposed openstack/nova: compute: improve exceptions related to disk size checks https://review.openstack.org/206565 | 09:03 |
oomichi | alex_xu: does that say nova should validate parameters on the same manner between nova-network and neutron, right? | 09:04 |
*** coolsvap is now known as coolsvap|away | 09:04 | |
alex_xu | oomichi: yes | 09:04 |
johnthetubaguy | sahid: I think it would be good to have a libvirt sub group to help push important bug fixes, in here, thats what other drivers are doing to try and make sure cores give attention to the appropriate patches, its not working yet, but thats the current push quite a few folks are signed up for: etherpad.openstack.org/p/liberty-nova-priorities-tracking | 09:05 |
alex_xu | oomichi: same as johnthetubaguy as said | 09:05 |
oomichi | alex_xu: ideally we should do that, but actually some environments run on Neutron/nova-network. so it seems difficult to enfoce the validation manner to nova-network | 09:05 |
*** shyama has joined #openstack-nova | 09:06 | |
johnthetubaguy | oomichi: alex_xu: its possible there are differences, but it should be a discoverable capabilities difference, ideally | 09:06 |
johnthetubaguy | oomichi: you mean some environments run both? | 09:06 |
bauzas | correct me if I'm wrong but isn't there any ugly if branches for knowing whether if it's Neutron or n-net ? :) | 09:06 |
oomichi | johnthetubaguy: no to some environments run both | 09:06 |
chhavi | We were using the linuxscsi.echo_scsi_command in the nova, I cannot see this in the latest code, | 09:06 |
chhavi | is there any other way to use this method | 09:07 |
johnthetubaguy | bauzas: well it should be hidden behind the network_api, ideally, but there are some. We need a consistent API experience, I know we are not doing that today :( | 09:07 |
*** annashen has quit IRC | 09:07 | |
openstackgerrit | Zhenguo Niu proposed openstack/nova: [Ironic]Not count available resources of deployed ironic node https://review.openstack.org/204088 | 09:07 |
bauzas | johnthetubaguy: that's my point | 09:07 |
oomichi | johnthetubaguy: neutron allows to create security group without name, that is different from nova's one | 09:07 |
bauzas | johnthetubaguy: before moving further, we should have a good internal API for network being abstract | 09:07 |
johnthetubaguy | oomichi: agreed, we need to enforce adding a name if you use the nova api though, to be consistent | 09:08 |
oomichi | johnthetubaguy: I'm not sure we can enforce the feature is disabled at this time | 09:08 |
johnthetubaguy | oomichi: once that security group add uuids, it should make that easier I thought | 09:08 |
johnthetubaguy | oomichi: sorry, getting confused, do you mean turn off security groups API when using neutron? | 09:09 |
alex_xu | oomichi: I think it's fine, with current code, if you without name, the nova return 500, it means nobody use nova security-group api like that | 09:09 |
johnthetubaguy | alex_xu: it should be 400, but yes, it seems valid to reject requests without a name when using the Nova API | 09:10 |
alex_xu | oomichi: but it's worth to check the old code, whether we return 500 all the time, all the 500 is some kind of regression | 09:10 |
*** liusheng has quit IRC | 09:10 | |
shyama | johnthetubaguy: nova/storage folder is missing in master. have the files moved? | 09:10 |
*** liusheng has joined #openstack-nova | 09:11 | |
alex_xu | johnthetubaguy: yea | 09:11 |
oomichi | alex_xu: now nova returns 400 in this case because of https://review.openstack.org/#/c/189541/ | 09:11 |
*** BobBall_AWOL is now known as BobBall | 09:11 | |
johnthetubaguy | shyama: I don't remember us having a nova/storage folder, if I am honest, what does github show for the older branches, does that answer your question at all? | 09:11 |
oomichi | alex_xu: yeah, anyway your point is right. | 09:12 |
*** coolsvap|away is now known as coolsvap | 09:12 | |
kashyap | garyk: Sigh, I had a random Nova patch series in local.conf w/ variables NOVA_REPO & NOVA_BRANCH. Re-testing w/o that. | 09:12 |
shyama | this one https://github.com/openstack/nova/blob/master/nova/storage/linuxscsi.py gives a 404 | 09:12 |
sahid | johnthetubaguy: hum I see, it's good idea to highlight patches reads yes :) | 09:12 |
sahid | just thinking it seems difficult to keep this up to date, no | 09:12 |
oomichi | alex_xu: on current code, creating security group without name returns 400 always. | 09:12 |
danpb | shyama: it was deleted yesterday | 09:13 |
shyama | it is documented here http://docs.openstack.org/developer/nova/api/nova.storage.linuxscsi.html. How do i find when it was removed | 09:13 |
shyama | danpb: ok which is the commit? | 09:13 |
openstackgerrit | Petrut Lucian proposed openstack/nova: HyperV: Add IOUtils class for asynchronous IO operations https://review.openstack.org/184035 | 09:13 |
chhavi | danpb: Is it moved somewhere else, | 09:14 |
johnthetubaguy | sahid: it is, but the idea is core or patch owner can strike out (or delete) stuff when the patch is merged, and the subteam can check back to keep the list full, hopefully its minimal overhead | 09:14 |
danpb | commit e6cdd1693ba843e1c8dcccbde3af20f62eb0b5a2 | 09:14 |
danpb | Author: Walter A. Boring IV <walter.boring@hp.com> | 09:14 |
danpb | Date: Mon Apr 20 13:42:44 2015 -0700 | 09:14 |
danpb | Switch to using os-brick | 09:14 |
danpb | is what deleted it | 09:14 |
openstackgerrit | Petrut Lucian proposed openstack/nova: HyperV: Add IOQueue class used for named pipe IO operations https://review.openstack.org/184036 | 09:15 |
alex_xu | oomichi: that's good news...at least the problem become easy | 09:15 |
johnthetubaguy | sahid: it feels way better than cores having to look through all patches and guessing what is important for each subteam, and then missing out the really important stuff, at least it seems worth a try (this is what we started doing after the summit, and gets advertised in every nova-meeting, but I am trying to advertise it more places so more people notice it) | 09:15 |
sahid | johnthetubaguy: understand you want to make core looking at more than one area by this way ? | 09:17 |
lxsli | johnthetubaguy: sahid: imho yes, it is a hassle - but it's way better than having important patches miss reviews | 09:17 |
*** dikonoor has joined #openstack-nova | 09:17 | |
sahid | i mean by this one, a core not too much related to libvirt can review it or something like that, right? | 09:17 |
*** gszasz has quit IRC | 09:18 | |
chhavi | linuxscsi.echo_scsi_command(scanpath, '- - -') | 09:18 |
*** eliqiao has quit IRC | 09:18 | |
*** kodoku_ has quit IRC | 09:18 | |
garyk | kashyap: deepakcs: i have found the issue - just need ndipanov to try and provide some clarrity here - basically the line https://github.com/openstack/nova/blame/master/nova/compute/api.py#L1222 is the culprit | 09:18 |
johnthetubaguy | sahid: not really, the idea is to give focus to what is reviewed, most cores should already be looking at many areas of the code, and generally they do | 09:18 |
*** markus_z has joined #openstack-nova | 09:19 | |
sahid | ack | 09:19 |
johnthetubaguy | sahid: one idea, is that eventually the sub team recommending a patch *could* be trusted as a +2, so you only need one more core review, but it will take time to build up that level of trust, but that shouldn't stop us trying | 09:19 |
ndipanov | garyk, what up with it? | 09:20 |
*** eliqiao has joined #openstack-nova | 09:20 | |
kashyap | garyk: Hmm. (Aside: I didn't know GitHub provides a convenient `git blame` style web interface.) | 09:20 |
*** arunman has joined #openstack-nova | 09:20 | |
sahid | johnthetubaguy: sure yes | 09:20 |
kashyap | garyk: Speaking of docs, ndipanov recently wrote some block device related documentation. Not sure if you came across. | 09:20 |
ndipanov | kashyap, not merged yet sadly | 09:21 |
kashyap | ndipanov: Due to the recent Gate issues? Or general sluggishness? | 09:21 |
ndipanov | but through my own fault - haven't addressed the comments | 09:21 |
*** alexpilotti has joined #openstack-nova | 09:21 | |
garyk | kashyap: i am not sure where he put them. he is mia at the moment… | 09:22 |
kashyap | garyk: MIA? He's right here, talking :-) | 09:22 |
garyk | ndipanov: ah. you around | 09:22 |
johnthetubaguy | sahid: I missed an important point, the idea is not just for core reviews, the idea is that all reviewers start looking for reviews in that etherpad, ideally. | 09:22 |
ndipanov | yes | 09:23 |
ndipanov | why wouldn't I be | 09:23 |
garyk | ndipanov: i have an issue with bdms - want to boot a instance with an eph disk | 09:23 |
kashyap | garyk: https://review.openstack.org/#/c/192651/ | 09:23 |
ndipanov | ok | 09:23 |
garyk | ndipanov: nova boot --image cirros-0.3.2-i386-disk --flavor eli --ephemeral size=1 X | 09:23 |
garyk | ERROR (BadRequest): Block Device Mapping is Invalid: Boot sequence for the instance and image/block device mapping combination is not valid. (HTTP 400) (Request-ID: req-230ebb8e-0aa6-435c-8b2f-45843ad7e1cb) | 09:23 |
garyk | the flavor has eph disk size 2 - so this is legit | 09:24 |
garyk | the code that breaks this is - https://github.com/openstack/nova/blame/master/nova/compute/api.py#L1222 | 09:24 |
ndipanov | what's the actual cli line you used? | 09:24 |
garyk | nova boot --image cirros-0.3.2-i386-disk  --flavor eli --ephemeral size=1 X | 09:24 |
ndipanov | hmmm | 09:24 |
ndipanov | that should not blow up | 09:24 |
garyk | when i delete the line above from the git blame it works | 09:25 |
ndipanov | obviously | 09:25 |
garyk | why is the boot index of interst here at all? | 09:25 |
ndipanov | hmmm | 09:25 |
ndipanov | well it shouldn't be | 09:26 |
ndipanov | unless you have bdms in the image | 09:26 |
garyk | the boot_indexes is [] | 09:26 |
garyk | no | 09:26 |
ndipanov | ORLY? | 09:26 |
ndipanov | garyk, is this devstack or? | 09:27 |
garyk | yes | 09:27 |
garyk | devstack with the vmware driver - but it does not even get to the driver. so you cannot blame vmware :) | 09:27 |
ndipanov | and python-novaclent is also recent | 09:28 |
garyk | sec | 09:28 |
garyk | 2.23 | 09:28 |
openstackgerrit | Petrut Lucian proposed openstack/nova: HyperV: Add IOQueue class used for named pipe IO operations https://review.openstack.org/184036 | 09:28 |
garyk | ndipanov: should be kosher for stable/kilo | 09:28 |
ndipanov | ah so you are running stable/kilo? | 09:29 |
*** madhaviy has joined #openstack-nova | 09:29 | |
-openstackstatus- NOTICE: Currently our CI system is broken, jobs are not getting processed at all. | 09:29 | |
garyk | i am running stable/kilo. ack | 09:29 |
*** ChanServ changes topic to "Currently our CI system is broken, jobs are not getting processed at all." | 09:29 | |
garyk | if you want i can run on trunk. but it will be the same. | 09:29 |
ndipanov | pls try master | 09:29 |
oomichi | grayk: I can run it on master devstack | 09:30 |
oomichi | grayk: $ nova flavor-create eph10 100 512 0 1 --ephemeral 10 | 09:30 |
oomichi | grayk: $ nova boot --image cirros-0.3.4-x86_64-uec --flavor eph10 --ephemeral size=1 X | 09:30 |
oomichi | grayk: that was succeeded | 09:30 |
garyk | ok, will do. | 09:30 |
madhaviy | Hi there, I have query in /nova/compute/manager/_shutdown_instance#L2246 ,during shutdown volume detach is done directly without check_detach, is there any reason behind | 09:33 |
johnthetubaguy | madhaviy: I guess the detach happens after the instance is shutdown? I suspect it was assumed it was always possible at that point, but I am not 100% sure thats why its done that way | 09:36 |
*** humble_ has quit IRC | 09:36 | |
johnthetubaguy | madhaviy: if we couldn't do the detach at that point, I am not 100% sure when we would do the detach, not sure if there is a clean up loop for that, for example | 09:37 |
*** romainh has left #openstack-nova | 09:37 | |
*** shuquan has quit IRC | 09:37 | |
kashyap | oomichi: ndipanov: Hmm, w/ Nova Git master, I could consistently reproduce this AttributeError "id" -- http://paste.openstack.org/show/406182/ | 09:38 |
kashyap | Wonder what am I missing there. | 09:38 |
*** romainh has joined #openstack-nova | 09:39 | |
madhaviy | johnthetubaguy: _shutdown_instance its called during deploy failure also, if volume is not attached completely, say its in creating/attaching state still, then I feel detach directly may not work | 09:40 |
johnthetubaguy | madhaviy: yes, thats true, it should be more defensive, I assumed we just ignored the error response for "already detached", but I didn't check that | 09:41 |
openstackgerrit | Petrut Lucian proposed openstack/nova: HyperV: Add named pipe handler https://review.openstack.org/184037 | 09:44 |
ndipanov | kashyap, that seems to be a glance client issue | 09:45 |
*** otter768 has joined #openstack-nova | 09:45 | |
ndipanov | it may be too old or smth (or an actual bug in it) | 09:46 |
openstackgerrit | Petrut Lucian proposed openstack/nova: HyperV: Add serial console proxy https://review.openstack.org/184038 | 09:46 |
*** markus_z has quit IRC | 09:46 | |
openstackgerrit | Petrut Lucian proposed openstack/nova: HyperV: Add serial console handler class https://review.openstack.org/184039 | 09:46 |
kashyap | ndipanov: This is Glance from Git master. It can't be newer than this. | 09:46 |
kashyap | I'll file a bug | 09:46 |
openstackgerrit | Petrut Lucian proposed openstack/nova: HyperV: Add SerialConsoleOps class https://review.openstack.org/184040 | 09:46 |
ndipanov | glancelient | 09:46 |
*** mdbooth has quit IRC | 09:46 | |
ndipanov | not Glance | 09:46 |
ndipanov | but yes it might as well be a bug | 09:47 |
kashyap | ndipanov: Err, jumped the gun too soon. | 09:47 |
*** mdbooth has joined #openstack-nova | 09:47 | |
*** alex_xu has quit IRC | 09:48 | |
* kashyap tries with the unified `openstack` CLI | 09:48 | |
garyk | oomichi: ndipanov: i have some glance issues - so still try to check :( | 09:48 |
*** alex_xu has joined #openstack-nova | 09:49 | |
*** otter768 has quit IRC | 09:50 | |
*** coolsvap is now known as coolsvap|away | 09:50 | |
madhaviy | johnthetubaguy: so do you think adding check_detach() before detach will have more proper checks. | 09:53 |
*** eliqiao1 has joined #openstack-nova | 09:54 | |
johnthetubaguy | madhaviy: unsure, it feels like overkill, is there a specific problem you are seeing? | 09:54 |
*** doude has quit IRC | 09:55 | |
kashyap | ndipanov: Hmm, that's the version I was using btw -- 0.19.0. PyPI mirror says 0.17.2 is the current version. /me downgrades and tests. | 09:56 |
openstackgerrit | John Garbutt proposed openstack/nova: docs: add a placeholder link to mentoring docs https://review.openstack.org/200053 | 09:56 |
*** eliqiao has quit IRC | 09:56 | |
openstackgerrit | John Garbutt proposed openstack/nova: docs: split up upgrade and upgrade futures https://review.openstack.org/201529 | 09:56 |
madhaviy | johnthetubaguy: I saw an exception throw, I will get stack trace an dmay be raise a bug? | 09:57 |
kashyap | garyk: What version of python-glanceclient are you using? | 09:57 |
*** jasondotstar has quit IRC | 09:57 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/nova: Ironic: Better handle InstanceNotFound on destroy() https://review.openstack.org/204995 | 09:57 |
*** shyama has quit IRC | 09:58 | |
*** coolsvap|away is now known as coolsvap | 09:58 | |
openstackgerrit | John Garbutt proposed openstack/nova: Add a summary of the architecture evolution work https://review.openstack.org/200001 | 09:58 |
openstackgerrit | John Garbutt proposed openstack/nova: docs: add the scheduler evolution plans https://review.openstack.org/192260 | 09:59 |
*** yassine has quit IRC | 09:59 | |
openstackgerrit | John Garbutt proposed openstack/nova: devref: update the nova architecture doc https://review.openstack.org/177374 | 09:59 |
*** madhaviy_ has joined #openstack-nova | 10:00 | |
*** jwcroppe has quit IRC | 10:00 | |
*** madhaviy_ has quit IRC | 10:00 | |
*** alex_klimov has quit IRC | 10:00 | |
*** gzhai has quit IRC | 10:00 | |
*** zzz_pczesno has quit IRC | 10:00 | |
*** garyk has quit IRC | 10:00 | |
*** ijuwang has quit IRC | 10:00 | |
*** Kennan has quit IRC | 10:00 | |
*** jwang has quit IRC | 10:00 | |
*** melwitt has quit IRC | 10:00 | |
*** mjturek1 has quit IRC | 10:00 | |
*** mitz has quit IRC | 10:00 | |
*** jogo has quit IRC | 10:00 | |
*** sc68cal has quit IRC | 10:00 | |
*** mitz has joined #openstack-nova | 10:00 | |
*** park_heijlong_ has quit IRC | 10:00 | |
*** melwitt has joined #openstack-nova | 10:00 | |
*** garyk has joined #openstack-nova | 10:00 | |
*** jwang has joined #openstack-nova | 10:01 | |
*** alex_klimov has joined #openstack-nova | 10:01 | |
*** Kennan has joined #openstack-nova | 10:01 | |
*** ijuwang has joined #openstack-nova | 10:01 | |
*** abhishekkk has joined #openstack-nova | 10:01 | |
*** madhaviy_ has joined #openstack-nova | 10:01 | |
*** mjturek1 has joined #openstack-nova | 10:01 | |
*** madhaviy has quit IRC | 10:01 | |
*** gszasz has joined #openstack-nova | 10:01 | |
*** kmARC has quit IRC | 10:01 | |
*** annashen has joined #openstack-nova | 10:02 | |
*** sc68cal has joined #openstack-nova | 10:02 | |
*** kiran-r has quit IRC | 10:03 | |
garyk | kashyap: glance (11.0.0.0b2, /opt/stack/glance) | 10:04 |
garyk | glance-store (0.7.1) | 10:04 |
garyk | python-glanceclient (0.19.0) | 10:04 |
*** annashen_ has joined #openstack-nova | 10:04 | |
garyk | kashyap: ERROR: Could not bind to 0.0.0.0:9191 after trying for 30 seconds | 10:04 |
garyk | reboot | 10:04 |
*** madhaviy has joined #openstack-nova | 10:04 | |
kashyap | garyk: Likewise here (about the versions). They seem buggy to me. | 10:04 |
*** sahid_ has joined #openstack-nova | 10:05 | |
*** clduser_ has joined #openstack-nova | 10:05 | |
*** sahid_ has quit IRC | 10:05 | |
*** rushiagr_away has quit IRC | 10:05 | |
*** jmccrory has quit IRC | 10:05 | |
*** sahid has quit IRC | 10:05 | |
*** abhishekk has quit IRC | 10:05 | |
*** clduser has quit IRC | 10:05 | |
*** ildikov has quit IRC | 10:05 | |
*** Piet has quit IRC | 10:05 | |
*** kaisers has quit IRC | 10:05 | |
*** pczesno has joined #openstack-nova | 10:05 | |
*** pczesno has quit IRC | 10:05 | |
*** pczesno has joined #openstack-nova | 10:05 | |
*** ildikov has joined #openstack-nova | 10:05 | |
*** madhaviy_ has quit IRC | 10:05 | |
*** sahid_ has joined #openstack-nova | 10:05 | |
*** sahid_ is now known as sahid | 10:06 | |
*** jogo has joined #openstack-nova | 10:06 | |
*** annashen has quit IRC | 10:06 | |
*** kaisers has joined #openstack-nova | 10:06 | |
*** jmccrory has joined #openstack-nova | 10:07 | |
*** rdo has quit IRC | 10:08 | |
*** annashen_ has quit IRC | 10:08 | |
*** jasondotstar has joined #openstack-nova | 10:09 | |
arunman | sdeague: Hi | 10:10 |
*** rdo has joined #openstack-nova | 10:10 | |
arunman | sdeague: I need some clarification on this bug-1478546, that you changed to 'Invalid' | 10:11 |
*** kiran-r has joined #openstack-nova | 10:12 | |
arunman | sdeague: I meant, this https://bugs.launchpad.net/bugs/1478546 got marked as invalid, asking for a BP | 10:13 |
openstack | Launchpad bug 1478546 in OpenStack Compute (nova) "nova GMR doesn't provide option to specify log_dir path" [Undecided,Invalid] - Assigned to Arun Mani (arun-mani) | 10:13 |
*** zhenguo has quit IRC | 10:13 | |
arunman | I'm not really sure if this requires to be fixed by submitting a BP | 10:14 |
danpb | arunman: the response there is saying that this is a feature request, rather than a bug report, so you need to use our feature process to submit the suggestion instead | 10:14 |
lxsli | arunman: you want sdague and he's US-based so probably still asleep | 10:15 |
*** josecastroleon has quit IRC | 10:15 | |
openstackgerrit | Petrut Lucian proposed openstack/nova: HyperV: Nova serial console access support https://review.openstack.org/145004 | 10:15 |
arunman | danpb: jus wondering how this can be considered as a feature | 10:15 |
lxsli | you want to add an extra option | 10:16 |
*** kmARC has joined #openstack-nova | 10:16 | |
*** doude has joined #openstack-nova | 10:18 | |
arunman | lxsli: Alrite, if BP is the only way of getting this fixed... I'll push it that way | 10:18 |
openstackgerrit | Andrea Rosa proposed openstack/nova: Raise nova exception for missing/empty machine-id https://review.openstack.org/202640 | 10:19 |
danpb | nb, it does not need to have a spec though - merely a blueprint is sufficient imho | 10:19 |
*** romainh has quit IRC | 10:20 | |
lxsli | +1 | 10:23 |
openstackgerrit | Matthew Booth proposed openstack/nova: Implement compare-and-swap for instance update https://review.openstack.org/202593 | 10:23 |
lxsli | bauzas: good morning! | 10:23 |
bauzas | lxsli: good noon ! | 10:23 |
lxsli | bauzas: I can't find any persist-request-spec patches apart from the spec; has alaski pushed anything yet? | 10:23 |
bauzas | lxsli: none I've heard of | 10:24 |
bauzas | lxsli: he was testing locally | 10:24 |
lxsli | bauzas: that explains that then :) | 10:24 |
bauzas | lxsli: well, you can begin working on that without needing to get the persisted Spec | 10:24 |
bauzas | lxsli: but you would still need my top level patch | 10:25 |
lxsli | bauzas: yep I'll see what I can do | 10:25 |
lxsli | bauzas: did you see I asked a couple of qs on https://review.openstack.org/#/c/179224/16/specs/liberty/approved/check-destination-on-migrations.rst ? | 10:25 |
bauzas | lxsli: remember what I've said during the midcycle, that's the main problem with delegating that one | 10:25 |
lxsli | bauzas: yep rebases will be plentiful | 10:26 |
bauzas | lxsli: mmm, I don't get your first point | 10:26 |
bauzas | lxsli: why a list ? | 10:27 |
bauzas | lxsli: here the user gives a destination | 10:27 |
lxsli | bauzas: a user might want to allow some choice though; they can't do that right now through livemigr but maybe later | 10:27 |
bauzas | lxsli: then it should amend the ReqSpec object later | 10:27 |
bauzas | lxsli: for the moment, the API allows to provide *one* destination | 10:28 |
ndipanov | danpb, https://review.openstack.org/#/c/192986/ <- dat security fix | 10:28 |
lxsli | bauzas: it just seems like a trivial extension with high potential | 10:28 |
bauzas | lxsli: not really, seems rather confusing | 10:28 |
lxsli | bauzas: not sure how it can be confusing but ok | 10:29 |
bauzas | lxsli: here, we amend the Spec based on what's given by the user | 10:29 |
ndipanov | sdague, can we land this maybe https://review.openstack.org/#/c/206249/3 ? | 10:29 |
bauzas | lxsli: since the user is only allowed to provide one destination, then we should provide one item | 10:29 |
openstackgerrit | Andrea Rosa proposed openstack/nova: Raise nova exception for missing/empty machine-id https://review.openstack.org/202640 | 10:29 |
ndipanov | don't want to just +A it but seems to me the naming is fine | 10:29 |
lxsli | what if the user were allowed to provide more than one? | 10:30 |
bauzas | lxsli: re: the --force stuff, it's for keeping the exact existing behaviour | 10:30 |
*** shyama has joined #openstack-nova | 10:31 | |
bauzas | lxsli: if migrate-live or evacuate JSON bodies would accept more than a string, then we would update the Spec object to accept a ComputeNodeList for requested_destination | 10:31 |
*** xgsa has quit IRC | 10:33 | |
lxsli | bauzas: ok, let's do it like this for now | 10:34 |
lxsli | bauzas: I can write my accept-multiple-force-hosts spec later :) | 10:34 |
openstackgerrit | Marian Horban proposed openstack/nova: libvirt:Rsync remote FS driver was added https://review.openstack.org/146887 | 10:35 |
bauzas | lxsli: honestly, I'd rather be -1 to that | 10:35 |
bauzas | lxsli: because we have aggregates | 10:35 |
lxsli | bauzas: what about my 2nd q? | 10:35 |
sdague | ndipanov: ok, sure. It still seems like a bad name to me. | 10:35 |
sdague | but if no one else agrees... | 10:35 |
bauzas | lxsli: the --force option is just an alleviated way to act in urgency | 10:36 |
lxsli | oh hey, thanks ndipanov + sdague :) | 10:36 |
ndipanov | well what else can we call it? positive_but_zero's_cool_too? | 10:36 |
ndipanov | :) | 10:36 |
ndipanov | unsigned really has different connotations... | 10:37 |
bauzas | lxsli: I answered to that by saying (12:30:53) bauzas: lxsli: re: the --force stuff, it's for keeping the exact existing behaviour | 10:38 |
bauzas | lxsli: which means I don't want to change that by calling the scheduler | 10:38 |
*** shyu has quit IRC | 10:38 | |
*** aix has quit IRC | 10:38 | |
lxsli | bauzas: ok, I can accept an argument for not changing too much at once | 10:39 |
*** exploreshaifali_ has joined #openstack-nova | 10:39 | |
lxsli | bauzas: do you agree we'll have to change this when/if we shift source-of-truth to scheduler? | 10:40 |
*** exploreshaifali has quit IRC | 10:43 | |
bauzas | lxsli: say what ? | 10:43 |
bauzas | source-of-truth of what ? | 10:43 |
openstackgerrit | Andrea Rosa proposed openstack/nova: Raise nova exception for missing/empty machine-id https://review.openstack.org/202640 | 10:44 |
lxsli | sorry, that was argumentative | 10:44 |
*** dikonoor has quit IRC | 10:44 | |
lxsli | aiui we'd like the scheduler to be able to cache hoststate | 10:44 |
bauzas | lxsli: now we invert the logic by calling the scheduler anyway when an host is given by the user | 10:44 |
bauzas | lxsli: unless the user explicitely makes use of the force flag | 10:44 |
*** arunman has left #openstack-nova | 10:44 | |
lxsli | if instances can be forced behind the scheduler's back, the hoststate can never be fully accurate | 10:44 |
bauzas | lxsli: going out to lunch | 10:45 |
bauzas | lxsli: but that's life | 10:45 |
lxsli | ok chat later | 10:45 |
bauzas | lxsli: if an user breaks the rules by forcing to a dest, then fer sur, it will raise some problems | 10:45 |
bauzas | but the host states are given by RT | 10:45 |
bauzas | so, please don't overthink | 10:46 |
danpb | ndipanov: what about it ? | 10:46 |
lxsli | call me crazy, I like to think ahead :) | 10:47 |
ndipanov | danpb, can you +2 it pls if you don't find something horribly wrong | 10:48 |
ndipanov | we really should land that fix soon | 10:48 |
kashyap | garyk: Okay, I filed it, since I was able to reproduce it twice at-least, asked the Glance folks if it legitmate, let's see what they say -- https://bugs.launchpad.net/glance/+bug/1479296 | 10:48 |
openstack | Launchpad bug 1479296 in Glance "On Nova instance boot, 'glanceclient/openstack/common/apiclient/base.py' throws: "AttributeError: id"" [Undecided,New] | 10:48 |
chhavi | danpb: As u mentioned that nova/storage/linuxscsi.py is completely been removed by os-brick | 10:49 |
*** lennyb_ has quit IRC | 10:49 | |
danpb | ndipanov: ah ok | 10:49 |
chhavi | danpb: Now what is the preferred way to make the linuxscsi commands | 10:49 |
*** xgsa has joined #openstack-nova | 10:49 | |
danpb | chhavi: don't make scsi commands in nova - do it in os-brick | 10:49 |
garyk | kashyap: thanks | 10:50 |
chhavi | danpb: Earlier we were making echo_scsi_command() in the nova drivers. Now do we need to make use of the API exposed by os-brick | 10:51 |
danpb | chhavi: what exactly are you trying todo | 10:52 |
dims | danpb: sdague: ndipanov: other nova cores who are awake :) - updated "Currently reviewable" bug list in https://etherpad.openstack.org/p/liberty-nova-priorities-tracking - we merged one in that list since yesterday | 10:52 |
*** markus_z has joined #openstack-nova | 10:53 | |
garyk | ndipanov: can you please look at https://review.openstack.org/#/c/188789 | 10:54 |
chhavi | danpb: I am looking for an alternative for linuxscsi.echo_scsi_command() | 10:55 |
garyk | johnthetubaguy: i addressed your comment on the vnic patch - https://review.openstack.org/147126 | 10:55 |
*** coolsvap is now known as coolsvap|away | 10:55 | |
garyk | still working on the metadata | 10:55 |
danpb | chhavi: but for what purpose ? | 10:56 |
chhavi | We have been using it to scan the path to identify a scsi device | 10:57 |
dims | thanks danpb! | 10:58 |
danpb | chhavi: using it from where though ? what source file / code in nova ? | 10:59 |
*** shaohe_robot has quit IRC | 11:00 | |
*** mpaolino has quit IRC | 11:00 | |
ndipanov | garyk, yeah it's on my (very long) list of things to look at :/ | 11:01 |
*** shaohe_robot has joined #openstack-nova | 11:01 | |
garyk | ndipanov: how about moving it to the top of the list :) | 11:02 |
*** yassine has joined #openstack-nova | 11:04 | |
*** annashen has joined #openstack-nova | 11:04 | |
*** yassine has quit IRC | 11:04 | |
*** yassine has joined #openstack-nova | 11:04 | |
*** annashen has quit IRC | 11:09 | |
johnthetubaguy | garyk: sweet, I think I going to get some lunch right now, but will try revisit those after lunch | 11:12 |
danpb | ndipanov: johnthetubaguy sdague could one of you see if you think this single patch can be +A'd - this one patch is holding up 3 different people's patch series https://review.openstack.org/#/c/188789/15 | 11:12 |
garyk | bon apetite | 11:13 |
johnthetubaguy | danpb: its on my list, I did a first read the other day, (mostly due to it blocking those dependent patches) | 11:13 |
danpb | both myelf & jaypipes think the patch is ok, but since we've now both been involved in writing it, it doesn't feel right for us to +A it ourselves | 11:13 |
*** romainh has joined #openstack-nova | 11:14 | |
johnthetubaguy | danpb: ah, totally, let me take another look | 11:14 |
johnthetubaguy | danpb: got out of date with that bit of the code after having to focus on specs, so having more ramp up time in there than I had hoped, it looked good, just hadn't totally convinced myself yet | 11:14 |
johnthetubaguy | danpb: ah, this was the bit I wasn't sure about: https://review.openstack.org/#/c/188789/15/nova/compute/resource_tracker.py,cm | 11:15 |
johnthetubaguy | danpb: I was wondering if we should copy the pattern on L246 on 667? | 11:16 |
danpb | sorry, i gave you the link to the old patch version | 11:16 |
danpb | that's fixed in patchset 18 | 11:16 |
johnthetubaguy | danpb: ah, damm it, I keep doing that, looking at the old one | 11:17 |
danpb | yeah i often make that mistake as i have 100's of firefox tabs open with reviews | 11:18 |
garyk | oomichi: ndipanov deepakcs kashyap: on latest master the — ephemeral size=1 works. i think that the issue is the nova client. | 11:18 |
oomichi | garyk: that is a good news :) | 11:20 |
garyk | oomichi: yes, thank you. | 11:20 |
sdague | danpb: seems fine to me. That being said, zuul is down, so nothing is going to flow for a bit | 11:21 |
ftersin | garyk: check your novaclient for https://github.com/openstack/python-novaclient/commit/8679eedb8352630012202c12a9c9acf8757802a5 | 11:22 |
*** jasondot_ has joined #openstack-nova | 11:23 | |
garyk | ftersin: thanks! | 11:23 |
*** baoli has joined #openstack-nova | 11:24 | |
*** deepthi has quit IRC | 11:24 | |
openstackgerrit | Gábor Takács proposed openstack/nova: Refactor os-services unit tests https://review.openstack.org/180869 | 11:25 |
*** jasondotstar has quit IRC | 11:25 | |
openstackgerrit | Pranali Deore proposed openstack/nova: Validate quota class_name https://review.openstack.org/192115 | 11:27 |
deepakcs | garyk: thanks for following up | 11:27 |
*** baoli has quit IRC | 11:31 | |
*** belmoreira has joined #openstack-nova | 11:31 | |
*** lucasagomes is now known as lucas-hungry | 11:33 | |
openstackgerrit | Daniel Berrange proposed openstack/nova: Introduce VNC Security Proxy Framework https://review.openstack.org/115483 | 11:33 |
openstackgerrit | Daniel Berrange proposed openstack/nova: Add VeNCrypt (TLS/x509) Security Proxy Driver https://review.openstack.org/115484 | 11:33 |
*** mwagner_lap has quit IRC | 11:35 | |
*** oomichi has quit IRC | 11:36 | |
*** rushiagr_away has joined #openstack-nova | 11:37 | |
*** madhaviy has quit IRC | 11:38 | |
*** sahid has quit IRC | 11:38 | |
*** madhaviy has joined #openstack-nova | 11:38 | |
openstackgerrit | Shiina, Hironori proposed openstack/nova-specs: Fix spec: Inject NMI to an instance https://review.openstack.org/207004 | 11:39 |
openstackgerrit | Daniel Berrange proposed openstack/nova-specs: Blueprint for Websockify security proxy framework https://review.openstack.org/207006 | 11:40 |
*** shyama has quit IRC | 11:46 | |
*** otter768 has joined #openstack-nova | 11:46 | |
*** cpschult has joined #openstack-nova | 11:47 | |
*** jwcroppe has joined #openstack-nova | 11:47 | |
*** kodoku_ has joined #openstack-nova | 11:47 | |
*** thorst has joined #openstack-nova | 11:47 | |
*** jwcroppe has quit IRC | 11:48 | |
*** fawadkhaliq has quit IRC | 11:48 | |
*** otter768 has quit IRC | 11:51 | |
*** veena has joined #openstack-nova | 11:51 | |
*** coolsvap|away is now known as coolsvap | 11:51 | |
openstackgerrit | Shiina, Hironori proposed openstack/nova: Add a Nova API to inject an NMI https://review.openstack.org/202617 | 11:52 |
*** cpschult has quit IRC | 11:53 | |
*** shaohe_robot1 has joined #openstack-nova | 11:54 | |
*** josecastroleon has joined #openstack-nova | 11:55 | |
*** fawadkhaliq has joined #openstack-nova | 11:55 | |
*** shaohe_robot has quit IRC | 11:57 | |
*** annashen has joined #openstack-nova | 12:02 | |
*** annashen_ has joined #openstack-nova | 12:05 | |
*** aix has joined #openstack-nova | 12:07 | |
*** annashen has quit IRC | 12:07 | |
*** exploreshaifali_ has quit IRC | 12:07 | |
*** annashen_ has quit IRC | 12:10 | |
*** erlon has joined #openstack-nova | 12:16 | |
*** shaohe_robot has joined #openstack-nova | 12:16 | |
*** ByPasS has joined #openstack-nova | 12:16 | |
*** marcusvrn has joined #openstack-nova | 12:16 | |
*** shaohe_robot1 has quit IRC | 12:17 | |
*** coolsvap is now known as coolsvap|away | 12:17 | |
lyanchih | Hi, guys. please help to review our patch https://review.openstack.org/#/c/202436/ | 12:17 |
*** kiran-r has quit IRC | 12:18 | |
*** vladikr has joined #openstack-nova | 12:18 | |
*** kodoku_ has quit IRC | 12:19 | |
*** salv-orl_ has joined #openstack-nova | 12:22 | |
openstackgerrit | Nikolas Hermanns proposed openstack/nova: libvirt: Add post_connection_terminated https://review.openstack.org/172341 | 12:22 |
*** oomichi has joined #openstack-nova | 12:23 | |
*** xek_ is now known as xek | 12:23 | |
*** salv-orlando has quit IRC | 12:25 | |
oomichi | alex_xu: can you take a look at https://review.openstack.org/#/c/192043/10 again? | 12:25 |
oomichi | alex_xu: it seems difficult to make validation behavior completely same between nova-network and neutron at this time. | 12:25 |
*** salv-orlando has joined #openstack-nova | 12:26 | |
alex_xu | oomichi: let me check | 12:26 |
*** salv-orl_ has quit IRC | 12:26 | |
*** edmondsw has joined #openstack-nova | 12:27 | |
*** salv-orl_ has joined #openstack-nova | 12:27 | |
*** madhaviy has quit IRC | 12:28 | |
*** salv-orlando has quit IRC | 12:30 | |
alex_xu | oomichi: yea, that is sad, looks like we can't fix it now | 12:30 |
*** ajayaa has quit IRC | 12:30 | |
*** enikher has joined #openstack-nova | 12:31 | |
*** mjturek1 has quit IRC | 12:31 | |
alex_xu | oomichi: so for now, the fix should be no value specific return 400. The value is empty string have different behavior | 12:32 |
alex_xu | oomichi: does make sense? | 12:32 |
*** kylek3h has joined #openstack-nova | 12:33 | |
*** deepakcs has quit IRC | 12:33 | |
scheuran | danpb, could you please verify, if your -1 on https://review.openstack.org/#/c/182283 is still valid? | 12:34 |
*** salv-orlando has joined #openstack-nova | 12:35 | |
scheuran | danpb, I answered in the review to your comment | 12:35 |
*** ishant has quit IRC | 12:36 | |
oomichi | alex_xu: the idea is for making the validation behavior the same as possible, right? | 12:36 |
alex_xu | oomichi: yea | 12:37 |
oomichi | alex_xu: that seems reasonable, and I'd like to consider more | 12:37 |
*** aysyd has joined #openstack-nova | 12:38 | |
alex_xu | oomichi: I can image the json-schema of security-group will be hard-work :( | 12:38 |
*** salv-orl_ has quit IRC | 12:38 | |
*** mpaolino has joined #openstack-nova | 12:38 | |
*** lucas-hungry is now known as lucasagomes | 12:38 | |
oomichi | alex_xu: yeah, completely right. and that was the consensus between us in kilo :-( | 12:39 |
*** mpavone has quit IRC | 12:39 | |
oomichi | alex_xu: but I forgot it and tried to do it.. | 12:39 |
alex_xu | oomichi: :) | 12:39 |
openstackgerrit | Tiago Mello proposed openstack/nova: Handle unsupported Spice feature for PowerKVM https://review.openstack.org/203809 | 12:43 |
*** mdrabe has joined #openstack-nova | 12:44 | |
*** salv-orl_ has joined #openstack-nova | 12:44 | |
*** mjturek1 has joined #openstack-nova | 12:46 | |
*** salv-orlando has quit IRC | 12:47 | |
*** VW_ has joined #openstack-nova | 12:47 | |
*** mpavone has joined #openstack-nova | 12:47 | |
*** salv-orl_ has quit IRC | 12:47 | |
*** coolsvap|away is now known as coolsvap | 12:48 | |
*** salv-orlando has joined #openstack-nova | 12:48 | |
*** ChanServ changes topic to "This channel is for Nova development. For support of Nova deployments, please use #openstack. -=- master is open for Lemming development" | 12:50 | |
-openstackstatus- NOTICE: zuul's disks were at capacity. Space has been freed up and jobs are being re-queued. | 12:50 | |
openstackgerrit | Roman Podoliaka proposed openstack/nova: rebuild: make sure server is shut down before volumes are detached https://review.openstack.org/176892 | 12:52 |
openstackgerrit | Shiina, Hironori proposed openstack/nova-specs: Fix spec: Inject NMI to an instance https://review.openstack.org/207004 | 12:52 |
*** VW_ has quit IRC | 12:52 | |
*** baoli has joined #openstack-nova | 12:52 | |
*** VW_ has joined #openstack-nova | 12:53 | |
*** shyama has joined #openstack-nova | 12:53 | |
openstackgerrit | Shiina, Hironori proposed openstack/nova: Add a Nova API to inject an NMI https://review.openstack.org/202617 | 12:54 |
*** rfolco has joined #openstack-nova | 12:54 | |
*** dims has quit IRC | 12:57 | |
*** VW_ has quit IRC | 12:57 | |
*** chuckcarmack has joined #openstack-nova | 12:57 | |
*** rlrossit has joined #openstack-nova | 12:57 | |
*** salv-orl_ has joined #openstack-nova | 12:57 | |
*** annegentle has joined #openstack-nova | 12:57 | |
*** dims has joined #openstack-nova | 12:57 | |
*** mriedem has joined #openstack-nova | 12:57 | |
*** veena has quit IRC | 12:58 | |
*** salv-orlando has quit IRC | 13:00 | |
*** salv-or__ has joined #openstack-nova | 13:00 | |
*** scheuran has quit IRC | 13:02 | |
*** scheuran has joined #openstack-nova | 13:02 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova-specs: Fix bodies on consolidate-console-api https://review.openstack.org/207029 | 13:03 |
*** salv-orl_ has quit IRC | 13:04 | |
*** annashen has joined #openstack-nova | 13:06 | |
*** eglynn has joined #openstack-nova | 13:07 | |
*** oomichi has quit IRC | 13:08 | |
rlrossit | dansmith: am I going crazy or are there no screen logs in this? http://logs.openstack.org/04/198904/6/check/gate-grenade-dsvm-partial-ncpu/afddd41/logs/ | 13:08 |
*** salv-or__ has quit IRC | 13:09 | |
*** annashen has quit IRC | 13:10 | |
mriedem | rlrossit: see the old and new subdirs | 13:10 |
*** salv-orlando has joined #openstack-nova | 13:11 | |
mriedem | rlrossit: there are no screen logs because devstack blew up on the kilo side during setup http://logs.openstack.org/04/198904/6/check/gate-grenade-dsvm-partial-ncpu/afddd41/logs/old/devstacklog.txt.gz#_2015-07-29_01_28_04_557 | 13:11 |
mriedem | recheck that one | 13:11 |
rlrossit | fdshqiuonewcosiueorfasdvfnloeqorive | 13:11 |
rlrossit | ugh | 13:11 |
*** phschwartz has quit IRC | 13:11 | |
rlrossit | is it friday yet? | 13:11 |
mriedem | actually hold on | 13:11 |
mriedem | https://review.openstack.org/#/c/206676/ | 13:12 |
mriedem | kilo will be blocked until https://review.openstack.org/#/q/I180de9d4f1f4ae385682ce40a3a695eb3acc4c43,n,z are merged | 13:12 |
*** phschwartz has joined #openstack-nova | 13:12 | |
rlrossit | mriedem: so don't recheck? | 13:12 |
mriedem | no | 13:12 |
mriedem | not yet | 13:12 |
*** dboik has joined #openstack-nova | 13:12 | |
*** dave-mccowan has joined #openstack-nova | 13:13 | |
rlrossit | yeah I saw both changes in that chain didn't work | 13:13 |
*** coolsvap is now known as coolsvap|away | 13:14 | |
*** salv-orl_ has joined #openstack-nova | 13:14 | |
mnestratov | mriedem: hi! could you please check if your -1 is still valid https://review.openstack.org/#/c/184153/ | 13:16 |
*** sahid has joined #openstack-nova | 13:17 | |
*** salv-orlando has quit IRC | 13:17 | |
Murali | Hi | 13:17 |
*** salv-orlando has joined #openstack-nova | 13:18 | |
mriedem | mnestratov: done | 13:18 |
Murali | Could any body help me. I am using the "{tenant_id}​/servers/​{server_id}​/action" REST API to reboot the instance | 13:18 |
*** rfolco has quit IRC | 13:18 | |
*** rlrossit has left #openstack-nova | 13:19 | |
Murali | I am getting the 404 Not Found for existing instance | 13:19 |
mnestratov | mriedem: thanks | 13:19 |
*** lucas__ has joined #openstack-nova | 13:19 | |
Murali | here is " curl -s -X POST -H "X-Auth-Token:a0872bc3deef4c258530df4b923e2454" -H "Content-Type: application/json" @reboot.json http://192.168.7.73:8774/v2/db688ec0a0d844e781203329c4aa1f47/servers/77efd837-bad6-4717-93d1-63b552af64e0/reboot" | 13:20 |
mriedem | Murali: see the channel topic, | 13:21 |
mriedem | this isn't a support channel | 13:21 |
*** salv-orl_ has quit IRC | 13:21 | |
Murali | mriedem:sorry if interrupt any meeting | 13:22 |
openstackgerrit | garyk proposed openstack/nova: Metadata: support proxying loadbalancers https://review.openstack.org/147539 | 13:22 |
openstackgerrit | garyk proposed openstack/nova: Neutron: add in API method for updating VNIC index https://review.openstack.org/147126 | 13:22 |
garyk | johnthetubaguy: ^ following your comments | 13:22 |
*** tpeoples has joined #openstack-nova | 13:22 | |
*** eharney has joined #openstack-nova | 13:23 | |
*** jswarren has joined #openstack-nova | 13:23 | |
*** VW_ has joined #openstack-nova | 13:23 | |
-openstackstatus- NOTICE: zuul jobs after about 07:00 UTC may need a 'recheck' to enter the queue. Look if your change is in http://status.openstack.org/zuul/ and recheck if not. | 13:26 | |
*** sahid has quit IRC | 13:28 | |
*** sahid has joined #openstack-nova | 13:28 | |
openstackgerrit | Alexis Lee proposed openstack/nova: Prevent (un)pinning unknown CPUs https://review.openstack.org/207040 | 13:28 |
*** sahid has quit IRC | 13:28 | |
*** sahid has joined #openstack-nova | 13:29 | |
haypo | dims, johnthetubaguy : hi. i have a patch to reduce the technical debt of nova, https://review.openstack.org/#/c/197601/ - it prepares nova to kill the deprecation warnings on strtime() (i get a ton of such warnings when running nova tests) | 13:29 |
*** tpeoples has quit IRC | 13:29 | |
haypo | (i added it to https://blueprints.launchpad.net/nova/+spec/liberty-olso-sync) | 13:29 |
*** rfolco has joined #openstack-nova | 13:31 | |
*** jecarey has joined #openstack-nova | 13:32 | |
lxsli | bauzas: ndipanov makes a very good point on 128992. I don't think it applies to can_provide, but it does to consume. Does it sound sensible to you for consume to return the claimed resources? | 13:32 |
lxsli | I'd check with jaypipes but he's not even in channel | 13:32 |
bauzas | lxsli: I need some time before replying | 13:33 |
lxsli | OK | 13:33 |
bauzas | lxsli: because it needs me to consider all of that | 13:33 |
bauzas | lxsli: that really depends on who the caller is | 13:34 |
lxsli | bauzas: well, once self.topology is updated and the original discarded, the information is lost | 13:34 |
*** annegentle has quit IRC | 13:36 | |
*** rlrossit has joined #openstack-nova | 13:37 | |
*** raildo has joined #openstack-nova | 13:38 | |
*** lucas__ has quit IRC | 13:38 | |
*** READ10 has joined #openstack-nova | 13:39 | |
*** lucas__ has joined #openstack-nova | 13:39 | |
*** abhishekkk has quit IRC | 13:39 | |
*** ctrath has joined #openstack-nova | 13:42 | |
*** nelsnelson has joined #openstack-nova | 13:42 | |
lxsli | bauzas: another q sorry. How are we protected from concurrent calls to #consume? | 13:43 |
*** Nikolay_St has quit IRC | 13:43 | |
*** jwcroppe has joined #openstack-nova | 13:43 | |
*** cpschult has joined #openstack-nova | 13:43 | |
*** Nikolay_St has joined #openstack-nova | 13:43 | |
*** jordanP has joined #openstack-nova | 13:43 | |
*** romainh has left #openstack-nova | 13:44 | |
*** markvoelker has joined #openstack-nova | 13:44 | |
*** otter768 has joined #openstack-nova | 13:47 | |
markus_z | mikal: I'd like to inform you about bug 1479181. Would you see it as "critical" too? | 13:48 |
openstack | bug 1479181 in OpenStack Compute (nova) "Cells: Build instance doesn't work with kilo api, juno compute " [Critical,New] https://launchpad.net/bugs/1479181 | 13:48 |
*** jasondotstar has joined #openstack-nova | 13:48 | |
*** bfic has quit IRC | 13:51 | |
*** otter768 has quit IRC | 13:52 | |
*** salv-orlando has quit IRC | 13:52 | |
*** jasondot_ has quit IRC | 13:52 | |
*** fawadkhaliq has quit IRC | 13:53 | |
openstackgerrit | Tiago Mello proposed openstack/nova: libvirt: Handle unsupported Spice feature for PowerKVM https://review.openstack.org/203809 | 13:53 |
alaski | markus_z: I don't think it meets the criteria for critical since it affects a (relatively small) subset of deployments | 13:54 |
*** LukeHinds has joined #openstack-nova | 13:54 | |
*** bfic has joined #openstack-nova | 13:55 | |
alaski | but it seems that we need to document the fact that cells doesn't guarantee compatibility during upgrades | 13:56 |
*** tpeoples has joined #openstack-nova | 13:56 | |
*** fawadkhaliq has joined #openstack-nova | 13:56 | |
moshele | danp: can you review https://review.openstack.org/#/c/187052/ and https://review.openstack.org/#/c/199488/ ? | 13:57 |
markus_z | alaski: I see, thanks for the feedback, I was unsure about this. | 13:57 |
*** yamahata has joined #openstack-nova | 13:57 | |
moshele | danpb: can you review https://review.openstack.org/#/c/187052/ and https://review.openstack.org/#/c/199488/ ? | 13:57 |
*** mwagner_lap has joined #openstack-nova | 13:58 | |
*** ferest has joined #openstack-nova | 13:58 | |
*** ctrath has quit IRC | 13:58 | |
*** bfic has quit IRC | 13:58 | |
*** ferest has quit IRC | 13:59 | |
dansmith | alaski: agree on !critical and the docs | 13:59 |
*** mragupat has joined #openstack-nova | 13:59 | |
garyk | ftersin: please see my comment - context was added due to the fact that the virt driver method did not have it … | 13:59 |
markus_z | alaski: Where did we document such things in the past? | 13:59 |
*** mragupat has quit IRC | 13:59 | |
*** thangp has joined #openstack-nova | 13:59 | |
alaski | markus_z: well, we haven't always. but the devref would be the right place for it | 14:00 |
*** fawadkhaliq has quit IRC | 14:00 | |
*** mragupat has joined #openstack-nova | 14:00 | |
*** fawadkhaliq has joined #openstack-nova | 14:01 | |
*** tonytan4ever has joined #openstack-nova | 14:01 | |
mriedem | it's 9am and i'm already depressed | 14:01 |
mriedem | calgone take me away | 14:01 |
mriedem | sorry, calgon | 14:02 |
*** ctrath has joined #openstack-nova | 14:03 | |
markus_z | alaski: just to double-check: We assume with cells that all nodes are on the same release-level? | 14:03 |
*** annashen has joined #openstack-nova | 14:03 | |
lxsli | bauzas: answering ndipanov now, figured it out | 14:03 |
alaski | markus_z: yes, all nova-cells nodes should be the same | 14:04 |
*** markvoelker has quit IRC | 14:04 | |
*** anthonyper has quit IRC | 14:04 | |
*** lpetrut has quit IRC | 14:04 | |
bauzas | lxsli: sorry had no time to look thru yety | 14:04 |
alaski | markus_z: it wasn't until recently that we had objects being used throughout cells which is a pre-req for the smooth upgrade path. but adding objects is what has broken things | 14:05 |
mriedem | markus_z: cells doesn't yet support rolling upgrades | 14:05 |
lxsli | bauzas: np just letting you know, I don't think it's a problem after all | 14:05 |
markus_z | alaski: dansmith: So, this would mean the bug is "medium" at most and we should clarify this assumption as you said. | 14:05 |
*** q3k has quit IRC | 14:05 | |
markus_z | mriedem: OK, I wasn't aware of that. | 14:05 |
bauzas | alaski: markus_z: missed the convo, so considering juno support as non supported ? | 14:05 |
*** EmilienM has quit IRC | 14:05 | |
dansmith | markus_z: and cells is experimental | 14:06 |
*** haypo has quit IRC | 14:06 | |
*** lpetrut has joined #openstack-nova | 14:06 | |
mriedem | dropped it to low severity | 14:06 |
*** haypo has joined #openstack-nova | 14:06 | |
alaski | markus_z: yes | 14:06 |
*** haypo has quit IRC | 14:06 | |
*** haypo has joined #openstack-nova | 14:06 | |
mriedem | could probably just mark as invalid | 14:06 |
dansmith | if we're not going to fix it, then probably | 14:06 |
mriedem | done | 14:06 |
*** rdopiera has quit IRC | 14:07 | |
*** annashen_ has joined #openstack-nova | 14:07 | |
markus_z | mriedem: Would keep it as low with the need to document that. Otherwise others will fall into this too. | 14:07 |
bauzas | markus_z: if not supported, then Invalid | 14:07 |
*** y_sawai has joined #openstack-nova | 14:07 | |
mriedem | i agree that documenting it would be good, | 14:07 |
mriedem | i'm not totally sure where | 14:07 |
markus_z | dansmith: "Cells" is still on my "research-list", I didn't know that. | 14:07 |
bauzas | mriedem: devref sounds the better place | 14:08 |
*** annashen has quit IRC | 14:08 | |
dansmith | markus_z: we don't do a great job of communicating it, but it does barf a warning in to the logs on startup | 14:08 |
mriedem | we barf that it's experimental | 14:08 |
mriedem | we could also barf that n-1 isn't supported | 14:08 |
mriedem | or just devref | 14:08 |
*** burt has joined #openstack-nova | 14:08 | |
*** garyk has quit IRC | 14:09 | |
alaski | I would vote for devref | 14:09 |
mriedem | and/or here http://docs.openstack.org/openstack-ops/content/scaling.html#cells_regions | 14:09 |
*** EmilienM has joined #openstack-nova | 14:09 | |
alaski | experimental implies that any guarantees are out the window imo | 14:09 |
markus_z | alaski: agreed | 14:10 |
*** anthonyper has joined #openstack-nova | 14:10 | |
*** MentalRay_ has joined #openstack-nova | 14:10 | |
mriedem | for devref i wouldn't lump this in with the cells v2 manifesto probably, | 14:10 |
mriedem | so that leaves upgrades http://docs.openstack.org/developer/nova/upgrade.html | 14:10 |
mriedem | could add a blurb there i guess? | 14:10 |
markus_z | mriedem: There it is :) "Overhead: Considered experimental." | 14:10 |
bauzas | a warn in logs sounds good too | 14:11 |
bauzas | since when people are reading docs ? | 14:11 |
mriedem | since when do people read logs? | 14:11 |
ftersin | garyk: thanks for the explanation | 14:11 |
*** annashen_ has quit IRC | 14:11 | |
*** jmccrory has quit IRC | 14:11 | |
bauzas | mriedem: as an operator, I was reading more logs than docs :) | 14:11 |
bauzas | anyway | 14:12 |
*** browne has joined #openstack-nova | 14:12 | |
mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/cells/manager.py#n82 | 14:12 |
mriedem | that's the warning in the logs today | 14:12 |
*** jmccrory has joined #openstack-nova | 14:13 | |
mriedem | i'd be in favor of adding there that rolling upgrades aren't supported (yet) | 14:13 |
*** q3k has joined #openstack-nova | 14:13 | |
bauzas | +1 | 14:13 |
alaski | sure, I'd +2 that | 14:13 |
mriedem | alright, will do | 14:13 |
markus_z | OK, the devref guide mentions the experimental state too. | 14:14 |
markus_z | Maybe it could contain a section what our strategy with experimental things is and what the implications are. | 14:14 |
*** annegentle has joined #openstack-nova | 14:14 | |
markus_z | Cells won't be the last feature with this status, I guess | 14:14 |
mriedem | it means use at your own risk | 14:15 |
mnestratov | dansmith: hello, I fixed obj_make_compatible in https://review.openstack.org/#/c/184311/, please take a look when you have time | 14:15 |
mriedem | we log warnings when using experimental things in most cases, or should be | 14:15 |
dansmith | mnestratov: thanks, it's on my list for this morning | 14:15 |
dansmith | mnestratov: sorry this has been complicated for just adding a new constant :/ | 14:15 |
mnestratov | dansmith: that's ok. It was helpful. I figured out how object versioning works | 14:16 |
markus_z | mriedem: Yeah, sorry that I created a sensation. I'm aware of this now. | 14:17 |
dansmith | just +2d, if someone else wants to hit that ^ | 14:17 |
mriedem | dansmith: unless it's a bong i'm not interested | 14:17 |
mriedem | markus_z: no, it's good to ask this kind of thing, and mention that we should document it | 14:18 |
mriedem | fresh perspsective and all | 14:18 |
johnthetubaguy | haypo: sounds cool, will try to read that next week I think, worried about the freeze this week | 14:18 |
* johnthetubaguy is mostly attending midcycles (in a virtual sense) today | 14:19 | |
_gryf | bauzas, hi, regarding https://review.openstack.org/#/c/197063 - I've included the reason why it doesn't matter for zk driver if we force a service down or not | 14:21 |
_gryf | bauzas, is it ok? | 14:21 |
*** whenry has quit IRC | 14:21 | |
*** markvoelker_ has joined #openstack-nova | 14:21 | |
*** Murali has quit IRC | 14:22 | |
kashyap | Darn, it's a duplicate of what mriedem already filed - https://bugs.launchpad.net/python-glanceclient/+bug/1479296 | 14:23 |
openstack | Launchpad bug 1476770 in OpenStack-Gate "duplicate for #1479296 _translate_from_glance fails with "AttributeError: id" in grenade" [Undecided,In progress] - Assigned to Matt Riedemann (mriedem) | 14:23 |
bauzas | _gryf: then no | 14:23 |
_gryf | bauzas, no? | 14:23 |
bauzas | _gryf: I don't want to have an ABC having different behaviours based on the plugin | 14:23 |
kashyap | Note to self: Check for existing bugs before filing! Anyhow, seems like there's a fix for this. | 14:24 |
bauzas | _gryf: I mean, the user doesn't know which SG backend is run | 14:24 |
*** whenry has joined #openstack-nova | 14:24 | |
_gryf | bauzas, I see your point | 14:24 |
bauzas | _gryf: so if calling the REST API, he wants to have the host fenced anyway | 14:24 |
mnestratov | sdague: could you please consider reissuing your +A on https://review.openstack.org/#/c/184311/ ? | 14:24 |
_gryf | bauzas, but still it doesn;t matter | 14:24 |
bauzas | _gryf: why ? | 14:25 |
_gryf | bauzas, currently with the shape of zk driver it's not even possible :/ | 14:25 |
bauzas | _gryf: if I force that host to be down, I want it down | 14:25 |
mriedem | mnestratov: small issue in https://review.openstack.org/#/c/184311/ | 14:25 |
bauzas | _gryf: I don't care which driver is running | 14:25 |
*** mtanino has joined #openstack-nova | 14:25 | |
bauzas | _gryf: if you leave ZK unchanged, it would mean that calling forced_down would still see the service up if the driver is ZK, right? | 14:26 |
*** r-daneel has joined #openstack-nova | 14:26 | |
_gryf | bauzas, I thought that what is plugins about - they share the same interface, but they do thing differently, am i right? | 14:26 |
_gryf | bauzas, yes and no | 14:26 |
_gryf | bauzas, yes - if it's really up | 14:27 |
_gryf | bauzas, and yes - if you query in some of the narrow window of time | 14:27 |
*** liusheng has quit IRC | 14:27 | |
bauzas | _gryf: so, why are you trusting ZK and not using it ? and then, why are you needing a BP for providing a way to use a 3rd-party engine ? | 14:27 |
*** ctrath has quit IRC | 14:28 | |
bauzas | _gryf: either we consider the 3rd-party engine as the source of truth, or we consider that we don't need that as a source of truth because ZK is self-sufficient | 14:28 |
bauzas | _gryf: but here, you make a very different semantics based on which driver is | 14:29 |
_gryf | bauzas, if there would be driver similar to zk (like corosync) i would trust the heartbeat. Otherwise we must do other things like that | 14:29 |
bauzas | _gryf: on one hand, you consider to defer the control to an external tool, but on the other hand you don't actually do that | 14:29 |
bauzas | for the audience, we're discussing abotu https://review.openstack.org/#/c/197063/11//COMMIT_MSG,cm | 14:30 |
*** baoli has quit IRC | 14:31 | |
_gryf | bauzas, from consistency pointo of view - you are right | 14:32 |
*** baoli has joined #openstack-nova | 14:32 | |
*** mpaolino has quit IRC | 14:32 | |
*** lpetrut has quit IRC | 14:32 | |
_gryf | bauzas, from functoinal - IMHO it's a bit strange to not trust tools like that (which was especially crafted for the job) | 14:33 |
bauzas | _gryf: I wouldn't matter about consistency if that wasn't exposed as a WSGI resource | 14:33 |
bauzas | _gryf: again, if we trust ZK, why are we needing all of that ? | 14:33 |
openstackgerrit | Vladik Romanovsky proposed openstack/nova: Adding user_id handling to keypair index, show and create api calls https://review.openstack.org/70485 | 14:34 |
bauzas | _gryf: we could just say that deployers would support ZK or implement their own drivers out-of-tree | 14:34 |
bauzas | so that the upstream Nova project would propose one single heartbeat mechanism, but any downstream vendor could provide his own | 14:34 |
bauzas | we wouldn't require to have an external hook for any 3rd-party engine | 14:35 |
_gryf | bauzas, well. we could say that, yes. specifically this functionality was needed to imporve performance of the db driver (which is most popular among the sg drivers) | 14:35 |
bauzas | _gryf: I don't want to open that can of worms, I'm just explaining that the BP was as a whole based on the idea that we allow the SG logic to be transferred to a 3rd party tool | 14:36 |
*** lpetrut has joined #openstack-nova | 14:36 | |
bauzas | if that 3rd-party tool is no-op for a specific set of drivers, that doesn't make sense IMHO | 14:36 |
*** coolsvap|away is now known as coolsvap | 14:37 | |
bauzas | and that could lead to confusion for operators wanting to deploy their own Pacemaker | 14:37 |
bauzas | _gryf: imagine the scenario | 14:37 |
bauzas | _gryf: I'm an operator using ZK because I like its reactivity but I also have some specific wordloads (like HPC batches) that I want to monitor using Nagios | 14:38 |
*** markvoelker_ has quit IRC | 14:38 | |
bauzas | _gryf: and I'm writing some Nagios plugins for checking the batch manager | 14:38 |
bauzas | batch managers even | 14:38 |
bauzas | _gryf: if I'm seeing that a batch manager is not performing correctly, then I'd mark the host down and reconfigure my cloud | 14:39 |
*** markvoelker has joined #openstack-nova | 14:39 | |
_gryf | bauzas, oh. ok. I see your point now. | 14:39 |
*** ajayaa has joined #openstack-nova | 14:39 | |
*** ctrath has joined #openstack-nova | 14:39 | |
_gryf | bauzas, I'll include the changes in the base class than. Is it ok, or should I change in every each driver? | 14:40 |
bauzas | _gryf: the base class is the perfect class for that IMO | 14:40 |
openstackgerrit | Maxim Nestratov proposed openstack/nova: libvirt: rename parallels driver to virtuozzo https://review.openstack.org/184311 | 14:40 |
_gryf | bauzas, cool. thanks for your time :) | 14:41 |
mnestratov | mriedem: fixed | 14:41 |
bauzas | _gryf: np | 14:41 |
edleafe | jroll: around? | 14:41 |
*** yamahata has quit IRC | 14:41 | |
mriedem | mnestratov: not quite, you have a pep8 error | 14:42 |
*** madhaviy has joined #openstack-nova | 14:43 | |
*** mpaolino has joined #openstack-nova | 14:44 | |
*** kodoku has joined #openstack-nova | 14:45 | |
*** markvoelker has quit IRC | 14:47 | |
*** markvoelker has joined #openstack-nova | 14:47 | |
*** ZZelle has quit IRC | 14:48 | |
*** cfriesen_ has joined #openstack-nova | 14:49 | |
* bauzas whispers https://sbauza.wordpress.com/2014/04/05/hook-for-tox-compliancy-before-a-git-review/ | 14:49 | |
jroll | edleafe: kinda :) | 14:51 |
bauzas | (amended with https://review.openstack.org/#/c/205575/) | 14:51 |
danpb | bauzas: does that hoook invoke it on each individual commit, or only the final release ? | 14:52 |
danpb | s/release/result/ | 14:52 |
openstackgerrit | Matt Riedemann proposed openstack/nova: cells: document upgrade limitations/assumptions https://review.openstack.org/207076 | 14:52 |
mriedem | alaski: markus_z: bauzas: ^ | 14:52 |
jroll | edleafe: I'm actually stepping away for a bit but I should be back in 30 or so | 14:52 |
bauzas | danpb: the hook is pre-review, so only the latest patch, hence the full pep8 coverage | 14:52 |
bauzas | danpb: before submitting, I'd rather call git rebase -x with your tox modification to see the output | 14:53 |
danpb | even running full pep8 check is not sufficient | 14:53 |
danpb | because you could have a flaw in an early patch which is fixed in a later patch | 14:54 |
danpb | and that'll fail jenkins | 14:54 |
bauzas | danpb: yeah, and -x unfortunately needs interactive | 14:54 |
edleafe | jroll: ok. ping me when you can | 14:55 |
bauzas | danpb: but that's doable to run a diff pep8 on each change | 14:55 |
bauzas | within the hook script | 14:55 |
*** eglynn_ has joined #openstack-nova | 14:57 | |
*** jwcroppe has quit IRC | 14:58 | |
*** eglynn has quit IRC | 14:58 | |
*** belmoreira has quit IRC | 14:59 | |
*** jasondotstar has quit IRC | 14:59 | |
*** tsekiyama has joined #openstack-nova | 14:59 | |
*** jistr has quit IRC | 15:00 | |
*** gszasz has quit IRC | 15:00 | |
*** kodoku has quit IRC | 15:01 | |
*** ByPasS has quit IRC | 15:01 | |
*** haomaiwang has joined #openstack-nova | 15:01 | |
*** mragupat has quit IRC | 15:01 | |
*** rex_lee has quit IRC | 15:02 | |
*** dougwig has quit IRC | 15:02 | |
*** mestery has joined #openstack-nova | 15:02 | |
*** jistr has joined #openstack-nova | 15:02 | |
*** ByPasS has joined #openstack-nova | 15:02 | |
*** haomaiwang has quit IRC | 15:03 | |
*** haomaiwang has joined #openstack-nova | 15:03 | |
*** alex_klimov has quit IRC | 15:04 | |
*** nkrinner has quit IRC | 15:05 | |
*** annashen has joined #openstack-nova | 15:07 | |
openstackgerrit | Dan Smith proposed openstack/nova: Prepare for unicode enums from Oslo https://review.openstack.org/207087 | 15:08 |
*** mpaolino has quit IRC | 15:11 | |
*** annashen has quit IRC | 15:13 | |
*** chhavi has quit IRC | 15:14 | |
*** alex_klimov has joined #openstack-nova | 15:14 | |
*** josecastroleon has quit IRC | 15:15 | |
*** davideagnello has joined #openstack-nova | 15:16 | |
*** davideagnello has quit IRC | 15:20 | |
openstackgerrit | Shiina, Hironori proposed openstack/python-novaclient: Add support for injecting an NMI https://review.openstack.org/207092 | 15:21 |
*** tsekiyama has quit IRC | 15:23 | |
*** ddaskal has joined #openstack-nova | 15:23 | |
bauzas | markus_z: will be off for the bug triage day but enjoy it | 15:24 |
mriedem | danpb: could use your review on this https://review.openstack.org/#/c/200280/ | 15:25 |
markus_z | bauzas: ah, too bad :( Thanks for the heads up | 15:25 |
mriedem | danpb: since that impacts imagemeta and eventually the bdm objet | 15:25 |
mriedem | *object | 15:25 |
*** rajesht has quit IRC | 15:25 | |
*** tsekiyama has joined #openstack-nova | 15:25 | |
mriedem | mnestratov: looks like the VZ CI has a patch merge conflict here http://openstack-3rd-party-ci-logs.odin.net/80/200280/6/check/dsvm-tempest-cinder/19d0e95/logs/devstacklog.txt.gz | 15:27 |
mriedem | in os-brick | 15:27 |
bauzas | danpb: FYI http://paste.openstack.org/show/406261/ made the deal for checking pep8 iteratively | 15:28 |
*** ijw has joined #openstack-nova | 15:29 | |
*** lucas__ has quit IRC | 15:30 | |
mnestratov | mriedem: thanks | 15:31 |
*** baoli has quit IRC | 15:31 | |
*** lucas__ has joined #openstack-nova | 15:32 | |
mnestratov | mriedem: i'll see | 15:32 |
openstackgerrit | Matt Riedemann proposed openstack/nova: cells: document upgrade limitations/assumptions https://review.openstack.org/207076 | 15:32 |
*** alexpilotti has quit IRC | 15:34 | |
openstackgerrit | Andreas Scheuring proposed openstack/nova: libvirt: Add macvtap as virtual interface (vif) type to Nova's libvirt driver https://review.openstack.org/182283 | 15:35 |
*** lucas__ has quit IRC | 15:37 | |
*** hshiina has quit IRC | 15:38 | |
bauzas | dims: can I ask you a question about oslo.config opts ? | 15:38 |
dims | bauzas: shoot | 15:39 |
bauzas | dims: coolness, ty | 15:39 |
bauzas | dims: (morning btw.) | 15:39 |
*** baoli has joined #openstack-nova | 15:39 | |
*** gabriel-bezerra has quit IRC | 15:39 | |
bauzas | dims: so, given http://specs.openstack.org/openstack/nova-specs/specs/liberty/approved/allocation-ratio-to-resource-tracker.html I need to provide 2 new flags within the compute manager | 15:39 |
bauzas | dims: they're currently provided by the scheduler component, but since I need to have upgrades, I'll provide 2 new opts | 15:40 |
*** diogogmt has joined #openstack-nova | 15:40 | |
bauzas | dims: and keep the current ones (deprecated) | 15:40 |
dims | right | 15:40 |
bauzas | dims: my question is, can I have the same name for those 2 opts (ie. ram_allocation_ratio) but have them in a separate group ? | 15:41 |
bauzas | like compute? | 15:41 |
dims | bauzas: yes | 15:41 |
bauzas | I would prevent any bad naming like 'compute_ram_alloc_ratio' | 15:41 |
bauzas | dims: sweet ! | 15:41 |
*** lucas____ has joined #openstack-nova | 15:41 | |
dims | bauzas: search for DeprecatedOpt | 15:41 |
*** vishwanathj has quit IRC | 15:41 | |
bauzas | dims: for the moment, until my series is implemented, I can't deprecate the sched opts | 15:42 |
bauzas | dims: because they're yet in use | 15:42 |
*** dannywilson has joined #openstack-nova | 15:42 | |
bauzas | dims: or should we consider to deprecate those even still used by Nova ? | 15:42 |
dims | bauzas: typically you add the DeprecatedOpt in one release, leave it there till you can take it out | 15:42 |
bauzas | dims: the question is rather, when do we provide a DeprecatedOpt ? | 15:42 |
dims | bauzas: see example http://docs.openstack.org/developer/oslo.config/opts.html | 15:43 |
dims | there's some in the nova code too | 15:43 |
bauzas | yeah I know | 15:43 |
bauzas | my wondering is rather about *when* deprecating those | 15:43 |
bauzas | ie. here | 15:43 |
dims | you register the new option/group and specify which it deprecates | 15:43 |
*** lpetrut has quit IRC | 15:43 | |
bauzas | I'm gonna add those 2 new opts | 15:43 |
*** artom has joined #openstack-nova | 15:43 | |
*** lpetrut has joined #openstack-nova | 15:43 | |
dims | yes | 15:44 |
bauzas | provide them as fields for ComputeNode, send them to the DB, get them from the DB and use them in the Scheduler before they're actually in use | 15:44 |
jroll | edleafe: free when you are | 15:44 |
bauzas | in the meantime, those 2 old sched opts will still be in use | 15:44 |
dims | yes | 15:44 |
openstackgerrit | Sean Dague proposed openstack/nova: tweak graphviz formatting for readability https://review.openstack.org/207103 | 15:45 |
bauzas | and will be kept until we're sure that all computes (ie. N-2) provide those 2 opts | 15:45 |
*** artom has quit IRC | 15:45 | |
dims | yes | 15:45 |
bauzas | dims: so, can I deprecate immediately those 2 opts even if the new opts are not yet provided to the scheduler ? | 15:45 |
*** artom has joined #openstack-nova | 15:45 | |
dims | yes, bauzas | 15:45 |
openstackgerrit | Maxim Nestratov proposed openstack/nova: libvirt: rename parallels driver to virtuozzo https://review.openstack.org/184311 | 15:45 |
bauzas | dims: ack | 15:45 |
bauzas | dims: coolness for your help | 15:45 |
*** lucas____ has quit IRC | 15:46 | |
dims | bauzas: once you register the new option/group with the DeprecatedOpt, both the old and the new style configs will work | 15:46 |
bauzas | dims: bauzas.get_beer()++ | 15:46 |
mnestratov | mriedem: fixed yesterday. asked CI to recheck | 15:46 |
dims | bauzas: :) thanks | 15:46 |
*** Sukhdev_ has joined #openstack-nova | 15:47 | |
bauzas | dims: okay, I should probably consider that again | 15:47 |
*** ftersin has quit IRC | 15:47 | |
*** otter768 has joined #openstack-nova | 15:48 | |
bauzas | dims: http://docs.openstack.org/developer/oslo.config/opts.html#oslo_config.cfg.DeprecatedOpt is pretty well written | 15:48 |
dims | bauzas: thanks :) kudos go to dhellmann and markmc i believe | 15:48 |
*** ijw has quit IRC | 15:50 | |
edleafe | jroll: I'm working on an update to your patch we discussed yesterday | 15:51 |
*** alex_klimov has quit IRC | 15:51 | |
edleafe | jroll: I'm adding a check to see if the hypervisor_type is 'ironic', and if so, skip calling get_by_host() for that host | 15:52 |
edleafe | jroll: that won't break existing sites using the instance affinity filters, and will keep ironic from blowing up | 15:52 |
edleafe | jroll: without adding a new CONF setting | 15:52 |
jroll | edleafe: the scheduler caring about the compute driver doesn't seem like the best abstraction, and really this is a "hundreds of instances per host" thing, not an ironic thing | 15:52 |
*** otter768 has quit IRC | 15:52 | |
jroll | (also, I believe hypervisor_type is 'baremetal' but not sure) | 15:53 |
edleafe | jroll: it | 15:53 |
edleafe | jroll: it's ironic (I checked :) | 15:53 |
mriedem | you're both wrong | 15:53 |
mriedem | it's both http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/hv_type.py | 15:53 |
*** patrickeast has joined #openstack-nova | 15:53 | |
edleafe | jroll: the abstraction ugliness comes from the design decision to treat bare metal resources similar to virt resources | 15:54 |
edleafe | jroll: but that ship sailed long ago | 15:54 |
*** karimb has joined #openstack-nova | 15:54 | |
*** fawadkhaliq has quit IRC | 15:54 | |
*** garyk has joined #openstack-nova | 15:54 | |
*** chhavi has joined #openstack-nova | 15:54 | |
edleafe | jroll: I have a few more tests to clean up, but I'll push it as soon as I finish | 15:56 |
*** matrohon has quit IRC | 15:58 | |
*** doude has quit IRC | 15:59 | |
*** rotbeard has quit IRC | 15:59 | |
*** chhavi has quit IRC | 16:00 | |
*** haomaiwang has quit IRC | 16:01 | |
jroll | edleafe: sure, I mean if other nova folks are okay with this method, I'm okay with ti | 16:01 |
*** lpetrut has quit IRC | 16:01 | |
*** gabriel-bezerra has joined #openstack-nova | 16:01 | |
*** jlanoux has quit IRC | 16:01 | |
*** baoli has quit IRC | 16:01 | |
jroll | edleafe: however, I think we'll see this with containers too | 16:01 |
*** lpetrut has joined #openstack-nova | 16:01 | |
edleafe | jroll: I think that's a good thing. | 16:01 |
edleafe | jroll: it will force a re-thinking of the underlying abstraction | 16:02 |
jroll | edleafe: hitting this bug with other virt drivers later is a good thing? | 16:02 |
jroll | ah | 16:02 |
*** haomaiwang has joined #openstack-nova | 16:02 | |
jroll | well | 16:02 |
jroll | it's not about the abstraction | 16:02 |
*** jnc8651 has quit IRC | 16:02 | |
jroll | it's about, this code can't handle hosts with hundreds of instances | 16:02 |
jroll | so if I had a kvm compute node with a terabyte of ram, I bet I could break it | 16:02 |
*** baoli_ has joined #openstack-nova | 16:03 | |
*** lucasagomes is now known as lucas-afk | 16:03 | |
jroll | it being this code | 16:03 |
alaski | fwiw we turned that off in our cloud for now because it was causing an issue in once cell, and we haven't dug into the root cause yet | 16:03 |
alaski | s/once/one/ | 16:03 |
jroll | alaski: we only turned it off in the ironic cell, right? | 16:03 |
dansmith | jroll: you mean a TB of RAM and still scheduled m1.tiny instances to it :) | 16:03 |
alaski | jroll: it's off everywhere I believe | 16:03 |
jroll | dansmith: well, yeah :) | 16:03 |
edleafe | alaski: but even if you turn off tracking, it will query the instances per host on each request | 16:03 |
jroll | alaski: oh, different configs for ironic cells ftl :( | 16:04 |
*** lucas____ has joined #openstack-nova | 16:04 | |
jroll | you're right though | 16:04 |
*** annashen has joined #openstack-nova | 16:04 | |
edleafe | alaski: tracking only removes the need to query per request | 16:04 |
alaski | edleafe: which seems to be fine for us. I'm not sure if our problem was related to number of instances per host. but it was one of about 20 issues so we just disabled and moved on to the next. we need to get back to it | 16:05 |
*** y_sawai_ has joined #openstack-nova | 16:05 | |
jroll | alaski: to clarify, the tracking code still runs, that config just turns off the initial "load everything at startup" | 16:05 |
jroll | which loads instances for all hosts, which was likely the thing | 16:05 |
edleafe | alaski: ok, let me know what you find when you do | 16:05 |
edleafe | jroll: no, that's not correct | 16:05 |
*** vilobhmm has joined #openstack-nova | 16:05 | |
alaski | yeah. that was causing the scheduler to get "stuck" doing something | 16:05 |
edleafe | jroll: the tracking code won't run | 16:06 |
*** moshele has quit IRC | 16:06 | |
edleafe | jroll: the code for querying was removed from the filters and added to the host manager | 16:06 |
edleafe | jroll: the problem is that it happens even if you don't use those filters | 16:06 |
edleafe | jroll: the HM has no insight into which filters are being used | 16:06 |
jroll | edleafe: setting the config for the scheduler causes the initial load to not happen, setting it for the compute makes tracking not happen at all, as I understand it | 16:07 |
*** jistr has quit IRC | 16:08 | |
jroll | edleafe: and what alaski is talking about only has it turned off for the scheduler, it's still on for computes | 16:08 |
edleafe | jroll: there is only one setting | 16:08 |
*** y_sawai has quit IRC | 16:08 | |
openstackgerrit | xing-yang proposed openstack/nova: Add os-brick based LibvirtVolumeDriver for ScaleIO https://review.openstack.org/194454 | 16:08 |
edleafe | jroll: compute uses the setting from the scheduler | 16:08 |
*** annashen_ has joined #openstack-nova | 16:08 | |
jroll | edleafe: not if the compute has a different config file | 16:08 |
edleafe | 262 CONF.import_opt('scheduler_tracks_instance_changes', | 16:09 |
*** annashen has quit IRC | 16:09 | |
edleafe | 263 'nova.scheduler.host_manager') | 16:09 |
jroll | edleafe: I know it's the same config | 16:09 |
alaski | right, we just turned it off on the schedulers | 16:09 |
edleafe | jroll: ^ from nova/compute/manager.py | 16:09 |
jroll | we have different config files on the scheduler and the compute hosts | 16:09 |
jroll | the compute hosts' config file does not have this disabled. | 16:09 |
jroll | import_opt doesn't query the scheduler for the setting | 16:10 |
openstackgerrit | Adelina Tuvenie proposed openstack/nova: Fixes Hyper-V boot from volume fails when using ephemeral disk https://review.openstack.org/207113 | 16:10 |
edleafe | jroll: why wouldn't you update the compute nodes? | 16:11 |
mriedem | rlrossit: you should be good to recheck your stuff now | 16:11 |
*** thangp has quit IRC | 16:11 | |
*** meghal has joined #openstack-nova | 16:11 | |
jroll | edleafe: me personally? because I don't operate the rest of our cloud, only the ironic bits (where we did disable it on compute hosts) | 16:11 |
alaski | edleafe: I turned if off on the scheduler because that's where the problem was. it wasn't the messages it was something in the schedulers processing of them causing an issue | 16:11 |
*** jaypipes has joined #openstack-nova | 16:12 | |
edleafe | alaski: ok; please let me know what you find out | 16:12 |
jroll | alaski: fwiw, if that's only disabled on the scheduler, it just disables the load-every-instance-at-startup (which I'm not surprised caused problems) | 16:12 |
*** coolsvap is now known as coolsvap|away | 16:12 | |
openstackgerrit | Dan Smith proposed openstack/nova: Prepare for unicode enums from Oslo https://review.openstack.org/207087 | 16:12 |
alaski | edleafe: will do | 16:12 |
*** nic has joined #openstack-nova | 16:13 | |
*** scottda has quit IRC | 16:13 | |
*** briancurtin has quit IRC | 16:13 | |
*** zhiyan has quit IRC | 16:13 | |
*** ameade has quit IRC | 16:13 | |
*** xyang has quit IRC | 16:13 | |
*** wanghao has quit IRC | 16:13 | |
*** LukeHinds has quit IRC | 16:13 | |
*** serverascode has quit IRC | 16:13 | |
*** annashen_ has quit IRC | 16:13 | |
*** Piet has joined #openstack-nova | 16:13 | |
alaski | jroll: yeah, that was the troublemaker. there was some unevenness in the loading, like it would process a bunch of hosts with 2-10 instances and then get to one that it said had 200 instances or something and basically just stop | 16:14 |
alaski | definitely needs investigation | 16:14 |
jroll | heh | 16:14 |
jroll | yeah, we were OOM'ing because E_TOO_MANY_INSTANCES | 16:14 |
rlrossit | mriedem: thanks for letting me know because I looked like 10 minutes ago and was going to give up on it until after lunch | 16:15 |
*** lucas____ has quit IRC | 16:15 | |
edleafe | alaski: the batch size for the startup run is 10 hosts. I wanted to make that configurable, but the old 'no more CONF!' arguments won out | 16:15 |
mriedem | rlrossit: do you know how to monitor a change through the queue in zuul? | 16:15 |
rlrossit | mriedem: nope | 16:15 |
mriedem | http://status.openstack.org/zuul/ | 16:15 |
mriedem | plug in the change number from the url | 16:15 |
*** lucas__ has joined #openstack-nova | 16:15 | |
*** thangp has joined #openstack-nova | 16:16 | |
rlrossit | wait what do you mean by monitor? | 16:16 |
mriedem | e.g. 206674 for https://review.openstack.org/#/c/206674/ | 16:16 |
mriedem | you can see the changes placement in the queue and the progress of the jobs on that change | 16:16 |
mriedem | if you're waiting for a thing to merge | 16:16 |
rlrossit | oh yeah I do that. but I don't actively stare at it | 16:16 |
mriedem | me neither, but i check in on it as i run through tabs | 16:17 |
rlrossit | I thought you were saying you could like have zuul tell you when something happened | 16:17 |
mriedem | i have zuul send me text messages when my code merges | 16:17 |
mriedem | and tweets to my twitter account | 16:17 |
alaski | edleafe: if that's causing an issue it would be worth adding a conf, or changing the default, or optimizing. but that seems like a reasonable default for now | 16:17 |
rlrossit | I mean... I wouldn't hate that... | 16:17 |
*** leeantho has joined #openstack-nova | 16:17 | |
*** lpetrut has quit IRC | 16:17 | |
*** chhavi has joined #openstack-nova | 16:17 | |
*** kmARC has quit IRC | 16:17 | |
mriedem | '@zuul says you have merged change 123 way2go LOL!' | 16:17 |
rlrossit | other than the fact that I wouldn't be able to get the text within these steel walls | 16:17 |
*** unicell has quit IRC | 16:17 | |
*** xyang1 has joined #openstack-nova | 16:18 | |
rlrossit | the prison bars on my office block a lot of cell reception | 16:18 |
mriedem | sorry, i should have had a hash tag in that tweet | 16:18 |
*** david-lyle has quit IRC | 16:18 | |
alaski | there's also https://github.com/kk7ds/openstack-gerrit-dashboard | 16:19 |
mriedem | yeah, that's also running | 16:19 |
mriedem | but these aren't always my changes that i'm watching | 16:19 |
mriedem | i use status.o.o/zuul for those | 16:19 |
*** lsmola has quit IRC | 16:20 | |
mriedem | ahh | 16:20 |
mriedem | "./dash.py -o cbehrens" | 16:20 |
mriedem | RIP! | 16:20 |
alaski | heh | 16:20 |
dansmith | heh | 16:20 |
alaski | he also lives on in multiple TODOs in the codebase | 16:20 |
mriedem | TODO(comstud): this f'ing sucks, i hate it, let's fix it someday | 16:21 |
mriedem | all over the quotas code :) | 16:21 |
mriedem | ooo | 16:22 |
mriedem | i'm going to push a patch to dash | 16:22 |
mriedem | -O is new to me | 16:22 |
*** ip0353 has quit IRC | 16:22 | |
mriedem | so i can watch my changes with -o and a specific other change with -c, but have to use -O OR | 16:22 |
*** belmoreira has joined #openstack-nova | 16:22 | |
dansmith | yeah I use: python dash.py -u danms -p openstack/nova,openstack/oslo.versionedobjects -r 10 -s -O OR -o danms | 16:23 |
mriedem | dansmith: is it just OR and AND? | 16:23 |
mriedem | i was going to update the doc since i had to check the code | 16:23 |
dansmith | I don't remember | 16:24 |
dansmith | what else do you want? XOR? :P | 16:24 |
mriedem | sure | 16:24 |
dansmith | heh | 16:24 |
mriedem | https://review.openstack.org/Documentation/user-search.html#_boolean_operators | 16:24 |
dansmith | -o danms -O NAND -p ... | 16:24 |
mriedem | -OR | 16:24 |
dansmith | I find it totally amusing that the sample outputs are from ~30k reviews | 16:25 |
*** Marga_ has quit IRC | 16:26 | |
*** afazekas has quit IRC | 16:27 | |
*** browne has quit IRC | 16:27 | |
*** Marga_ has joined #openstack-nova | 16:28 | |
*** dougwig has joined #openstack-nova | 16:29 | |
*** yassine has quit IRC | 16:29 | |
*** markus_z has quit IRC | 16:29 | |
*** exploreshaifali has joined #openstack-nova | 16:33 | |
*** tonytan4ever has quit IRC | 16:34 | |
*** ajayaa has quit IRC | 16:37 | |
*** tpeoples has quit IRC | 16:38 | |
*** coolsvap|away is now known as coolsvap | 16:39 | |
*** jordanP has quit IRC | 16:39 | |
*** rdopiera has joined #openstack-nova | 16:41 | |
*** sahid has quit IRC | 16:41 | |
*** serverascode has joined #openstack-nova | 16:41 | |
*** david-lyle has joined #openstack-nova | 16:42 | |
*** enikher has quit IRC | 16:43 | |
*** ameade has joined #openstack-nova | 16:43 | |
*** alexpilotti has joined #openstack-nova | 16:45 | |
*** zhiyan has joined #openstack-nova | 16:46 | |
*** Marga_ has quit IRC | 16:47 | |
*** baoli_ has quit IRC | 16:48 | |
*** MentalRay_ has quit IRC | 16:48 | |
*** baoli_ has joined #openstack-nova | 16:49 | |
*** tpeoples has joined #openstack-nova | 16:49 | |
*** Nikolay_St has quit IRC | 16:50 | |
*** unicell has joined #openstack-nova | 16:50 | |
*** BobBall is now known as BobBall_AWOL | 16:54 | |
openstackgerrit | Ed Leafe proposed openstack/nova: Remove unneeded and painful call for ironic https://review.openstack.org/206736 | 16:54 |
edleafe | jroll: ^^ | 16:55 |
* jroll will look | 16:55 | |
*** briancurtin has joined #openstack-nova | 16:57 | |
openstackgerrit | Nicolas Simonds proposed openstack/nova: libvirt: make snapshot use RBD snapshot/clone when available https://review.openstack.org/205282 | 16:57 |
*** lpetrut has joined #openstack-nova | 16:58 | |
*** coolsvap is now known as coolsvap|away | 16:58 | |
*** coolsvap|away is now known as coolsvap | 16:58 | |
openstackgerrit | Chuck Carmack proposed openstack/nova: Fix DeprecationWarning when using BaseException.message https://review.openstack.org/207127 | 16:58 |
*** davideagnello has joined #openstack-nova | 17:00 | |
jaypipes | nic: note that my review user ID is jaypipes@gmail.com. jpipes@mirantis.com is something I used for testing external CI systems... | 17:00 |
jaypipes | nic: re: https://review.openstack.org/#/c/205282/ :) | 17:00 |
*** LukeHinds has joined #openstack-nova | 17:00 | |
*** haomaiwang has quit IRC | 17:01 | |
openstackgerrit | Nicolas Simonds proposed openstack/nova-specs: RBD instance snapshots https://review.openstack.org/188244 | 17:01 |
nic | I didn't add you, seb did | 17:01 |
nic | FIXED FOR GREAT JUSTICE | 17:02 |
*** haomaiwang has joined #openstack-nova | 17:02 | |
ndipanov | bauzas, https://review.openstack.org/#/c/203078/ | 17:02 |
nic | jaypipes: although I guess I should start the whining about getting that spec squeezed in for the L release. | 17:03 |
nic | Folks are saying something akin to "Ceph is unusable right now" with respect to the current state-of-the-art | 17:03 |
*** kumar has joined #openstack-nova | 17:04 | |
nic | Where should I go to whine the most effectively, and at what volume? | 17:04 |
bauzas | ndipanov: in cells meeting, but lemme look | 17:04 |
bauzas | ndipanov: oh that, see my commit msg | 17:05 |
*** rex_lee has joined #openstack-nova | 17:05 | |
bauzas | ndipanov: I wanted to make the BP implemented by the last patch, but I'm quite okay with you, we need to remove the build_req_spec() method etc. | 17:05 |
*** tjones has joined #openstack-nova | 17:06 | |
ndipanov | there some other issues - go through the series and see individual comments | 17:06 |
*** scottda has joined #openstack-nova | 17:06 | |
ndipanov | imho this is not done until the build_request_spec dies in a fire | 17:06 |
scheuran | mriedem, could you please have another look on the macvtap-vif patchset some time your afternoon? I was removing the vlan device name logic. https://review.openstack.org/#/c/182283/ | 17:08 |
*** Marga_ has joined #openstack-nova | 17:08 | |
scheuran | mriedem, it still has to walk through the gate, so no hurry | 17:08 |
scheuran | mriedem, thanks! | 17:08 |
*** annashen has joined #openstack-nova | 17:09 | |
bauzas | ndipanov: ack, will look thru | 17:09 |
*** wanghao has joined #openstack-nova | 17:10 | |
*** scheuran has quit IRC | 17:10 | |
*** mjturek1 has quit IRC | 17:11 | |
*** mpavone has quit IRC | 17:11 | |
*** danpb has quit IRC | 17:12 | |
*** annashen has quit IRC | 17:13 | |
*** salv-orlando has joined #openstack-nova | 17:14 | |
*** alexpilotti has quit IRC | 17:14 | |
jaypipes | nic: johnthetubaguy and mriedem would be my best advice. | 17:18 |
*** annashen has joined #openstack-nova | 17:19 | |
*** kumar has quit IRC | 17:19 | |
*** xyang has joined #openstack-nova | 17:19 | |
*** dboik has quit IRC | 17:19 | |
*** karimb has quit IRC | 17:19 | |
*** browne has joined #openstack-nova | 17:19 | |
ndipanov | jaypipes, lxsli I don't think you fully understood my comment here https://review.openstack.org/#/c/128992/ | 17:19 |
*** salv-orlando has quit IRC | 17:20 | |
*** moshele has joined #openstack-nova | 17:20 | |
mriedem | nic: the correct volume is always 11 | 17:20 |
jaypipes | ndipanov: no, I fully udnerstand your comment. I am saying that checking for capacity is not the same activity as assigning a particular NUMA node toplogy/pinning to an instance | 17:21 |
*** madhaviy has quit IRC | 17:21 | |
ndipanov | jaypipes, fair enough | 17:21 |
mriedem | nic: so we're at feature freeze for liberty tomorrow | 17:21 |
nic | I'm looking over the agenda for the meeting tomorrow, and I have no idea where to try and slot my stuff in. | 17:21 |
mriedem | nic: so given the spec isn't even approved, and the deadline for spec approval was long ago, i don't see this making liberty | 17:21 |
*** rajesht has joined #openstack-nova | 17:21 | |
mriedem | nic: open discussion | 17:22 |
ndipanov | don't we want an interface to that side of reosurces as well | 17:22 |
ndipanov | jaypipes, ^ | 17:22 |
*** salv-orlando has joined #openstack-nova | 17:22 | |
*** patrickeast has quit IRC | 17:23 | |
*** alexpilotti has joined #openstack-nova | 17:23 | |
bauzas | ndipanov: heya, just read your comments | 17:24 |
*** lpetrut has quit IRC | 17:24 | |
bauzas | ndipanov: nothing really complaining about, just one sentence that I'm going thru without really understanding :D | 17:24 |
bauzas | ndipanov: "I wanted to comment on the previous patch - but it would be nice to have some kind of abstraction here (like a special descriptor that will delegate back to the one object has if the type is right and do the conversion otherwis) instead of all of these awkwardly named methods that special case single fields." | 17:24 |
bauzas | ndipanov: in https://review.openstack.org/#/c/187197/24 | 17:24 |
bauzas | ndipanov: could you try bauzas's translator ? :) | 17:25 |
tjones | Im in rebase hell here if anyone has time for a review - https://review.openstack.org/#/c/127427/ | 17:26 |
openstackgerrit | Vilobh Meshram proposed openstack/nova-specs: Quota Management for Dynamic Quota Resources https://review.openstack.org/206160 | 17:26 |
*** rajesht has quit IRC | 17:26 | |
ndipanov | bauzas, well all object fields work like properties which are actually python descriptors | 17:27 |
ndipanov | instead of that inline mess with arbitrarily named methods | 17:27 |
ndipanov | maybe we could come up with a descriptor that does the conversion if needed - otherwise delegates to the standard object's field machinery | 17:27 |
*** achanda has joined #openstack-nova | 17:27 | |
ndipanov | that's just a thought | 17:27 |
ndipanov | not really necessary to do it that way | 17:28 |
*** lpetrut has joined #openstack-nova | 17:28 | |
bauzas | ndipanov: mmm, I think I see your point | 17:28 |
ndipanov | but right now it's just a bunch of weird methods that are not even uniformly named | 17:28 |
bauzas | ndipanov: yeah, naming is not one of my best skills | 17:28 |
*** mjturek1 has joined #openstack-nova | 17:29 | |
ndipanov | bauzas, also once the bp is done we can drop all forward porting methods | 17:29 |
ndipanov | primitive -> spec_obj | 17:29 |
ndipanov | please do it | 17:29 |
ndipanov | no reason to keep that code around | 17:30 |
bauzas | yeah I know | 17:30 |
*** tjones1 has joined #openstack-nova | 17:30 | |
ndipanov | if it's there people will use it | 17:30 |
ndipanov | in like 3 days | 17:30 |
ndipanov | trust me :D | 17:30 |
*** aix has quit IRC | 17:30 | |
bauzas | ndipanov: I was thinking of the compat decorator, it was pretty acceptable to keep it re: out-of-tree | 17:30 |
bauzas | ndipanov: since those guys would probably be like chicken with cut head | 17:31 |
ctrath | mriedem: I'm looking at this: https://bugs.launchpad.net/os-brick/+bug/1479355 … Where should constants be defined? | 17:31 |
openstack | Launchpad bug 1479355 in os-brick "Define constants for connector factory protocol" [Undecided,Confirmed] - Assigned to Cale Rath (ctrath) | 17:31 |
bauzas | once they see that their filters don't work now | 17:31 |
ndipanov | bauzas, absolutely not | 17:31 |
bauzas | ndipanov: I know | 17:31 |
*** tonytan4ever has joined #openstack-nova | 17:31 | |
mriedem | ctrath: i believe rlrossit was already looking at that | 17:31 |
ndipanov | we have enough "stable" apis as is that we can't break | 17:31 |
bauzas | ndipanov: I know it's bad to keep something for out-of-tree need | 17:31 |
*** lpetrut has quit IRC | 17:31 | |
mriedem | rlrossit: right? ^ if so, assign it to yourself | 17:31 |
ctrath | mriedem: ok.. It was not assigned | 17:31 |
bauzas | ndipanov: but I'm a gentleman :) | 17:32 |
ndipanov | bauzas, filter interface is not one of them. Kill it | 17:32 |
*** Marga_ has quit IRC | 17:32 | |
bauzas | ndipanov: lol | 17:32 |
bauzas | ndipanov: fair enough | 17:32 |
*** Marga_ has joined #openstack-nova | 17:32 | |
*** tjones1 has quit IRC | 17:32 | |
*** shaohe_robot has quit IRC | 17:32 | |
bauzas | ndipanov: alaski would just probably be that worried :D | 17:32 |
bauzas | ndipanov: I mean RAX | 17:33 |
bauzas | ndipanov: but let's move on | 17:33 |
*** shaohe_robot has joined #openstack-nova | 17:33 | |
*** tjones1 has joined #openstack-nova | 17:33 | |
alaski | what are we talking about killing? I need to read back | 17:33 |
*** tjones1 has quit IRC | 17:33 | |
*** lpetrut has joined #openstack-nova | 17:34 | |
bauzas | alaski: no worries, just explaining that RAX is a chicken | 17:35 |
* bauzas thanks scrollback | 17:35 | |
alaski | "resistant to some change" | 17:35 |
bauzas | alaski: no, was speaking of the filters API passing the old legacy filter_props dict | 17:35 |
bauzas | alaski: since I'm changing our in-tree filters to accept a ReqSpec object now, it means that out-of-tree filters will be broken | 17:36 |
bauzas | oh, that reminds me I should tag UpgradeImpact ! | 17:36 |
*** armax has joined #openstack-nova | 17:36 | |
ndipanov | they would be broken anyway unless they add that line | 17:37 |
alaski | that's fine. it's not an api we guarantee to be stable | 17:37 |
bauzas | alaski: so I was using the metaphor of a chicken which has the head cut | 17:37 |
ndipanov | exactly | 17:37 |
bauzas | yep | 17:37 |
ndipanov | we have enough "stable" APIs | 17:37 |
alaski | I would like us to get there, because I do think out of tree filters should be supported. but we're not there yet | 17:37 |
bauzas | no, that whole convo was based on keeping a compat decorator I provided | 17:37 |
ndipanov | please don't | 17:37 |
ndipanov | I mean | 17:38 |
bauzas | yeah yeah | 17:38 |
bauzas | that's fine, will do | 17:38 |
*** patrickeast has joined #openstack-nova | 17:38 | |
bauzas | and when removing the to_legacy_dict(), it will be anyway impossible to look back | 17:38 |
alaski | we just had to adapt to https://review.openstack.org/#/c/188485/, it wasn't a big deal | 17:39 |
*** jaypipes has quit IRC | 17:40 | |
bauzas | alaski: yeah, and using the Spec object shouldn't be a big deal too | 17:40 |
bauzas | alaski: you should just review the existing changes where I'm doing that change | 17:41 |
ndipanov | bauzas, why would we remove to_legacy_dict? | 17:41 |
ndipanov | we can't until we move the compute completely to spec object | 17:41 |
ndipanov | and then wait another RPC version cycle | 17:41 |
johnthetubaguy | nic: +1 to what mriedem said, although bug fixes are welcome, but it sounded like it was more than that I guess. | 17:41 |
bauzas | ndipanov: oh yeah | 17:41 |
ndipanov | what we can and should remove ASAP is forward porting | 17:41 |
*** annashen has quit IRC | 17:42 | |
ndipanov | legacy will stay with us for some time... | 17:42 |
bauzas | you mean the from_primitives() ? | 17:42 |
bauzas | gotcha | 17:42 |
bauzas | okay, I misunderstood your thoughts | 17:42 |
bauzas | any good opportunity for me to pause and properly document the backport methods and maybe think of an abstraction | 17:43 |
*** r-daneel has quit IRC | 17:44 | |
alaski | bauzas: I think all we'll really need to change to deal with reqspec object is to stop using dict style attribute accesses | 17:44 |
bauzas | alaski: not exactly since we remove the instance_props subdict but yeah you got the idea | 17:44 |
ctrath | rlrossit: ping | 17:44 |
alaski | bauzas: right, still an easy adaption | 17:45 |
*** ByPasS has quit IRC | 17:45 | |
alaski | phew, apparently that is a word | 17:46 |
*** annashen has joined #openstack-nova | 17:46 | |
*** dannywilson has quit IRC | 17:46 | |
bauzas | alaski: don't overrule me with my frenglish | 17:46 |
*** Sukhdev_ has quit IRC | 17:47 | |
nic | johnthetubaguy: if feature freeze is tomorrow, and you have a completed feature, he fact that the cover sheet isn't on the TPS report shouldn't torpedo the whole thing, IMO | 17:48 |
*** ByPasS has joined #openstack-nova | 17:48 | |
nic | But the process is the process for a reason, and I don't want to claim special snowflake status on my forst attempt | 17:48 |
*** otter768 has joined #openstack-nova | 17:49 | |
sdague | johnthetubaguy: gmann's spec update is here - https://review.openstack.org/#/c/206864 | 17:50 |
*** Marga_ has quit IRC | 17:51 | |
johnthetubaguy | nic: its not process for the sake of process, there is a good reason behind it (much of it described here: https://wiki.openstack.org/wiki/Nova/Liberty_Release_Schedule), we have given two weeks for all the advertised (i.e. approved) blueprint patches to be up for review, so we can try and work through all of those and maximise the number of completed blueprints (currently have 50 or so in that situation I think), while been honest to | 17:52 |
johnthetubaguy | everyone else about the fact we just don't have the bandwidth to review that | 17:52 |
*** Marga_ has joined #openstack-nova | 17:52 | |
johnthetubaguy | nic: have you got a link to your blueprint, etc, I couldn't find that in the scrollback for some reason | 17:52 |
johnthetubaguy | sdague: I have been having internet troubles, seems gerrit didn't submit my vote :( | 17:53 |
sdague | johnthetubaguy: ok | 17:53 |
johnthetubaguy | sdague: I had a minor worry, but I still like the overall approach | 17:53 |
nic | johnthetubaguy: https://review.openstack.org/188244 and https://blueprints.launchpad.net/nova/+spec/rbd-instance-snapshots | 17:53 |
*** moshele has quit IRC | 17:53 | |
johnthetubaguy | sdague: does my comment make sense? | 17:53 |
sdague | johnthetubaguy: what is the minor worry? | 17:53 |
*** otter768 has quit IRC | 17:54 | |
rlrossit | ctrath: what's up? | 17:54 |
*** jasondotstar has joined #openstack-nova | 17:54 | |
*** lucas-afk is now known as lucasagomes | 17:55 | |
johnthetubaguy | sdague: oh, I added that comment, I should really run, I have my dinner going cold at this point | 17:55 |
rlrossit | ctrath: yeah I'm working on https://bugs.launchpad.net/os-brick/+bug/1479355 not sure why it didn't get updated when I didn't push up a patch for it | 17:55 |
openstack | Launchpad bug 1479355 in os-brick "Define constants for connector factory protocol" [Undecided,Confirmed] - Assigned to Cale Rath (ctrath) | 17:55 |
johnthetubaguy | sdague: I am just worried about when locked: false doesn't apply | 17:55 |
ctrath | rlrossit.. Ok | 17:56 |
mriedem | ctrath: https://review.openstack.org/#/c/207090/ | 17:56 |
sdague | johnthetubaguy: locked: false means there is no lock, I think that's pretty clear | 17:56 |
johnthetubaguy | nic: this does appear to have missed all the deadlines we have in place, its unfair to give this one an exception at this point, given the amount of blueprints that did make all the deadlines (currently around 90 or so). Most of those are about to get deferred tomorrow as well, not that that helps anyone, but the point here is to focus on the agreed project priorities | 17:57 |
ctrath | rlrossit: I removed myself from the bug, but I can't find your name to assign it to you | 17:57 |
johnthetubaguy | sdague: sorry, I mean the other way around locked: true, but its the admin listing it, and its not actually locked for them, as its an owner lock | 17:57 |
mriedem | ctrath: neither can i, might be some weirdness with how the os-brick project is setup in launchpad | 17:57 |
johnthetubaguy | sdague: I don't think its a big deal | 17:57 |
rlrossit | I got it ctrath | 17:57 |
sdague | johnthetubaguy: sure, and when we have a lock resource, that can be distinguished | 17:57 |
ctrath | ok, thanks | 17:58 |
*** lucas__ has quit IRC | 17:58 | |
sdague | right now the admin can break all the locks anyway | 17:58 |
rlrossit | mriedem: why didn't it post the change and set it to in progress when I put the patch up? | 17:58 |
nic | johnthetubaguy: I was under no illusion that I was working on anything considered a project priority, that's why I didn't make much noise about this at the mid-cycle. But some folks that have seen this work have said that it would be really good to land, so I'm giving it the old college try | 17:58 |
mriedem | rlrossit: because ^ | 17:58 |
johnthetubaguy | sdague: yeah, I think it just means, "there is a lock", not that "its locked for you" | 17:58 |
sdague | there are more semantics here that are pretty hacky | 17:58 |
*** xyang1 has quit IRC | 17:58 | |
sdague | johnthetubaguy: yes, I agree, this means there is a lock | 17:58 |
rlrossit | oh missed that one | 17:58 |
johnthetubaguy | nic: thats cool, it looks super useful, but so are the other ones we are already focused on reviewing already, its more a general fairness thing to all the others that have been deferred, I wish we had way more review capacity, but we don't right now, but we are working on it :( | 17:59 |
johnthetubaguy | sdague: I was just thinking its worth a note, but I am all for the change, let me add that. | 18:00 |
sdague | ok | 18:00 |
sdague | yeh, the implementation is pretty clear already on that. kenichi blocked that on the spec. | 18:00 |
sdague | not being landed | 18:00 |
*** haomaiwang has quit IRC | 18:01 | |
mriedem | nic: i'm going to writeup something to the ML on this topic, we discussed it a bit at the midcycle but i don't exactly remember how it landed, so will regurgitate it there | 18:01 |
sdague | so I actually think all the ducks are in a row here, just needs +2's and not mutual deadlock | 18:01 |
nic | mriedem: which topic? | 18:01 |
mriedem | nic: freezes | 18:02 |
*** shyama has quit IRC | 18:02 | |
nic | Ah. reading comprehension is not my strong suit | 18:02 |
*** haomaiwang has joined #openstack-nova | 18:02 | |
*** browne has quit IRC | 18:02 | |
mriedem | nic: that's ok, you're american | 18:03 |
*** pixelbeat_ has quit IRC | 18:03 | |
*** browne has joined #openstack-nova | 18:04 | |
*** lucas__ has joined #openstack-nova | 18:05 | |
*** annashen_ has joined #openstack-nova | 18:05 | |
*** adam_g has joined #openstack-nova | 18:07 | |
*** adam_g has quit IRC | 18:07 | |
*** adam_g has joined #openstack-nova | 18:07 | |
*** lucas__ has quit IRC | 18:09 | |
*** lucas__ has joined #openstack-nova | 18:10 | |
*** annashen_ has quit IRC | 18:10 | |
*** jwcroppe has joined #openstack-nova | 18:11 | |
*** lpetrut has quit IRC | 18:12 | |
*** ByPasS has quit IRC | 18:13 | |
*** dannywilson has joined #openstack-nova | 18:18 | |
melwitt | mriedem: if someone forgets to cherry-pick -x for a backport, would it work to just change the commit message manually or does it have to be redone with -x? https://review.openstack.org/#/c/199569/ | 18:18 |
*** coolsvap is now known as coolsvap|brb | 18:18 | |
mnestratov | mriedem: last pep8 issue addressed https://review.openstack.org/#/c/184311/ | 18:18 |
*** ByPasS has joined #openstack-nova | 18:19 | |
mriedem | melwitt: oooooo | 18:20 |
mriedem | i bring hellfire down on those that don't cherry-pick -x | 18:20 |
mriedem | melwitt: it doesn't matter too much, the change id matching is the big thing | 18:20 |
dansmith | eh? | 18:20 |
mriedem | it would be nice to see the (cherry picked from commit) thing in there though | 18:20 |
dansmith | does it affect that? I don't think so | 18:20 |
dansmith | I thought it just does the (from commit $foo) | 18:21 |
mriedem | cherry-pick -x adds the cherry pickedfrom commit hash line | 18:21 |
mriedem | yeah | 18:21 |
mriedem | the hellfire comment was a joke | 18:21 |
*** annashen has quit IRC | 18:21 | |
dansmith | oh you mean the change-id matching is the important step to get right | 18:21 |
dansmith | not the important thing about using -x | 18:21 |
mriedem | yes | 18:22 |
dansmith | then, yes | 18:22 |
* dansmith brings down hellfire on those that speak ambiguously | 18:22 | |
mriedem | hey | 18:22 |
mriedem | hellfire block! | 18:22 |
mriedem | (saving throw jokes) | 18:22 |
*** jasondotstar has quit IRC | 18:23 | |
melwitt | I was thinking if I could add the "from commit" message in there instead of asking the person to redo the entire cherry-pick, and tell them use -x next time please | 18:23 |
mriedem | melwitt: naw, that will reset the votes and if you do that, you might as well just redo with cherry-pick -x | 18:23 |
mriedem | not sure it would matter either way | 18:24 |
*** annashen has joined #openstack-nova | 18:24 | |
*** dims_ has joined #openstack-nova | 18:24 | |
mriedem | sounds like an unimportant bug but i guess over time it kills things with ceilometer? | 18:24 |
melwitt | mriedem: yeah, guess that's true. I was trying to avoid saying "redo this thing because there isn't a footnote in the commit message" but they're a similar amount of work assuming no conflicts | 18:25 |
*** dboik has joined #openstack-nova | 18:25 | |
melwitt | mriedem: yeah cfriesen_ said ceilometer will keep creeping up the memory because of this | 18:26 |
*** annegentle has quit IRC | 18:26 | |
*** annegentle has joined #openstack-nova | 18:26 | |
openstackgerrit | Lucas Alvares Gomes proposed openstack/nova: Ironic: Better handle InstanceNotFound on destroy() https://review.openstack.org/204995 | 18:26 |
*** pixelbeat_ has joined #openstack-nova | 18:27 | |
*** dims has quit IRC | 18:28 | |
*** lucasagomes is now known as lucas-dinner | 18:28 | |
*** josecastroleon has joined #openstack-nova | 18:28 | |
*** MentalRay_ has joined #openstack-nova | 18:30 | |
*** openstackgerrit has quit IRC | 18:31 | |
*** openstackgerrit has joined #openstack-nova | 18:32 | |
*** armax has quit IRC | 18:32 | |
*** pixelbeat_ has quit IRC | 18:33 | |
*** jaypipes has joined #openstack-nova | 18:34 | |
*** dannywilson has quit IRC | 18:34 | |
*** dannywilson has joined #openstack-nova | 18:34 | |
*** ByPasS has quit IRC | 18:34 | |
*** chhavi has quit IRC | 18:35 | |
dansmith | sdague: can I run your multinode-grenade thing against a patch easily? | 18:35 |
*** thorst has quit IRC | 18:36 | |
*** ByPasS has joined #openstack-nova | 18:36 | |
*** ByPasS has quit IRC | 18:40 | |
*** salv-orlando has quit IRC | 18:40 | |
*** annashen has quit IRC | 18:42 | |
*** vishwanathj has joined #openstack-nova | 18:42 | |
*** ByPasS has joined #openstack-nova | 18:43 | |
*** jwcroppe has quit IRC | 18:43 | |
*** jwcroppe has joined #openstack-nova | 18:44 | |
mnestratov | dansmith: I resubmitted https://review.openstack.org/#/c/184311/ to address mriedem's comments, thus erased your +2 | 18:44 |
dansmith | mnestratov: I refuse to review that until mriedem +2s it | 18:44 |
dansmith | mnestratov: he likes to -1 my +2s too much | 18:44 |
dansmith | mnestratov: so let me know when his majesty has blessed it and I'll re-+2 :) | 18:45 |
mnestratov | dansmith: :) | 18:45 |
*** y_sawai has joined #openstack-nova | 18:45 | |
*** fawadkhaliq has joined #openstack-nova | 18:45 | |
mnestratov | mriedem: your majesty, please | 18:46 |
*** vishwanathj has quit IRC | 18:46 | |
mriedem | we are reviewing it now | 18:47 |
mriedem | there | 18:47 |
*** y_sawai_ has quit IRC | 18:48 | |
*** jwcroppe has quit IRC | 18:48 | |
sdague | dansmith: ... well, its in experimental on devstack-gate | 18:49 |
* dansmith -1s | 18:49 | |
sdague | so you'd have to Depends-On that d-g change, then upload another d-g change and run check experimental | 18:49 |
dansmith | sdague: heh | 18:49 |
dansmith | nevermind then :) | 18:49 |
sdague | or a grenade change | 18:49 |
sdague | or convince mordred he should land the code :) | 18:50 |
sdague | and we can make it easier | 18:50 |
* dansmith scoffs in mordred's general direction | 18:50 | |
*** thorst has joined #openstack-nova | 18:51 | |
*** shaohe_robot1 has joined #openstack-nova | 18:55 | |
*** Sukhdev_ has joined #openstack-nova | 18:55 | |
*** fawadk has joined #openstack-nova | 18:55 | |
*** fawadkhaliq has quit IRC | 18:56 | |
*** shaohe_robot has quit IRC | 18:57 | |
mnestratov | any chances to look at https://review.openstack.org/#/c/186858/ today? It is +2-ed by danpb | 18:57 |
*** josecastroleon has quit IRC | 18:58 | |
*** haomaiwang has quit IRC | 19:01 | |
*** haomaiwa_ has joined #openstack-nova | 19:01 | |
*** salv-orlando has joined #openstack-nova | 19:01 | |
*** krtaylor has quit IRC | 19:04 | |
*** lucas__ has quit IRC | 19:07 | |
mriedem | mnestratov: which does covers the case that 'disk' is in the mapping dict? | 19:08 |
mnestratov | mriedem: yes | 19:08 |
mriedem | sorry, which test covers | 19:08 |
mriedem | the changed test and the one above it are very similar and use some stubs, so it's hard to read how those 2 paths are differnet | 19:09 |
*** coolsvap|brb is now known as coolsvap|away | 19:10 | |
*** Piet has quit IRC | 19:10 | |
mnestratov | test_get_guest_config_parallels_ct | 19:12 |
mnestratov | ct == exe | 19:12 |
*** ZZelle has joined #openstack-nova | 19:13 | |
*** IanGovett has joined #openstack-nova | 19:13 | |
*** jamiec has joined #openstack-nova | 19:13 | |
mnestratov | above test is for hvm, below for exe | 19:13 |
*** haypo has left #openstack-nova | 19:13 | |
mriedem | so this is probably just one of those cases where i have to memorize the internals of how blockinfo.get_disk_info works to know how this is actually tested | 19:14 |
mriedem | i guess i was looking for an assertion that the filesystem disk wasn't added in one of these cases | 19:14 |
*** meghal has quit IRC | 19:16 | |
*** fawadkhaliq has joined #openstack-nova | 19:16 | |
*** artom has quit IRC | 19:16 | |
*** krtaylor has joined #openstack-nova | 19:17 | |
*** VW__ has joined #openstack-nova | 19:18 | |
*** artom has joined #openstack-nova | 19:18 | |
*** jasondotstar has joined #openstack-nova | 19:18 | |
*** lpetrut has joined #openstack-nova | 19:18 | |
*** jamiec has quit IRC | 19:19 | |
*** IanGovett has quit IRC | 19:19 | |
*** fawadk has quit IRC | 19:19 | |
*** tjones has quit IRC | 19:21 | |
*** VW_ has quit IRC | 19:22 | |
mnestratov | mriedem: thanks for review. I'll add assertion | 19:22 |
mriedem | mnestratov: added some comments | 19:22 |
*** READ10 has quit IRC | 19:22 | |
*** VW__ has quit IRC | 19:22 | |
mriedem | mnestratov: basically i don't think you should be updating the existing test, | 19:22 |
*** lucas__ has joined #openstack-nova | 19:22 | |
mriedem | you should have a test that covers the case that 'disk' is in the mapping, and one where 'disk' isn't in the mapping and vm_mode is EXE | 19:22 |
mriedem | and make the proper assertion that the filesystem device isn't added if 'disk' isn't in the mapping | 19:23 |
*** fawadk has joined #openstack-nova | 19:24 | |
mriedem | one day i hope i'll make enough money that i can add a comment in an executive blog post that says, "Empowering, enabling and energizing our enterprise customers is fundamental to who we've been, who we are and who we will be as a company." | 19:25 |
dansmith | mnestratov: I agree with his majesty | 19:25 |
mnestratov | mriedem: ok. just tried to change fewer lines of code | 19:26 |
*** fawadkhaliq has quit IRC | 19:26 | |
dansmith | mnestratov: changing few lines of production code is good. Fewer lines of test code, usually not :D | 19:26 |
mnestratov | dansmith: :) me too | 19:26 |
mnestratov | dansmith: I see | 19:27 |
*** dims_ has quit IRC | 19:27 | |
*** davideagnello has quit IRC | 19:27 | |
*** dims has joined #openstack-nova | 19:27 | |
*** VW_ has joined #openstack-nova | 19:29 | |
dims | mriedem: nice goal! :) | 19:30 |
mriedem | dims: or, i'll just repeat that everywhere | 19:31 |
mriedem | like a slogan | 19:31 |
mriedem | eventually it will be true and i'll be unstoppable | 19:31 |
dims | mriedem: print a sticker! :) | 19:31 |
dims | like the cirros default password :) | 19:31 |
*** lucas__ has quit IRC | 19:32 | |
*** lucas__ has joined #openstack-nova | 19:33 | |
*** vishwanathj has joined #openstack-nova | 19:35 | |
*** salv-orlando has quit IRC | 19:35 | |
*** ByPasS has quit IRC | 19:35 | |
*** ByPasS has joined #openstack-nova | 19:35 | |
dansmith | dims: by the way, I have a todo item to get taylor an oslo sticker in tokyo | 19:36 |
dansmith | I rudely procured only one for myself in rochester | 19:36 |
dims | haha. will do | 19:36 |
openstackgerrit | Dan Smith proposed openstack/nova: Prepare for unicode enums from Oslo https://review.openstack.org/207087 | 19:36 |
*** rlrossit has left #openstack-nova | 19:41 | |
*** annashen has joined #openstack-nova | 19:42 | |
*** tjones has joined #openstack-nova | 19:42 | |
dims | dansmith: mriedem: 15 fresh items in the quick hit list - https://etherpad.openstack.org/p/liberty-nova-priorities-tracking | 19:44 |
dims | jaypipes: ^^ | 19:45 |
mriedem | i wouldn't consider https://review.openstack.org/#/c/202616/ quick hit | 19:45 |
dims | mriedem: please add notes :) that one was added by ndipanov | 19:46 |
*** achanda has quit IRC | 19:46 | |
mriedem | that's a no no | 19:46 |
*** krtaylor has quit IRC | 19:46 | |
dims | mriedem: because? | 19:47 |
*** ByPasS has quit IRC | 19:47 | |
*** belmoreira has quit IRC | 19:47 | |
mriedem | you're not supposed to add your own changes to that list right? | 19:48 |
mriedem | line 133 | 19:48 |
*** Nikolay_St has joined #openstack-nova | 19:48 | |
dims | ah. right. i thought there was a technical concern :) | 19:48 |
mriedem | well, also that, it's a relatively complicated change | 19:48 |
mriedem | at least the first part was | 19:48 |
*** HenryG has quit IRC | 19:49 | |
mriedem | nagyz_: so i see you're on a summit presentation about adding performance testing to tempest or something - i assume that's all out of tree? | 19:49 |
mriedem | is it in public github at least? | 19:49 |
*** otter768 has joined #openstack-nova | 19:50 | |
dims | mriedem: add your name to your color? | 19:50 |
*** salv-orlando has joined #openstack-nova | 19:51 | |
*** HenryG has joined #openstack-nova | 19:52 | |
*** ByPasS has joined #openstack-nova | 19:52 | |
openstackgerrit | Earle F. Philhower, III proposed openstack/nova: Add os_brick-based VolumeDriver for HGST connector https://review.openstack.org/194412 | 19:53 |
*** otter768 has quit IRC | 19:54 | |
*** meghal has joined #openstack-nova | 19:55 | |
bauzas | dims: sorry, I'm not angry but why did you changed the current reviews ? | 19:55 |
bauzas | dims: tbc, I'm fine, just wondering why | 19:55 |
bauzas | I mean the review requests | 19:55 |
*** vishwanathj has quit IRC | 19:57 | |
dansmith | mriedem: I get what you mean about it being complicated, | 19:57 |
dansmith | mriedem: but it's really just making good on that comment I think | 19:57 |
dansmith | mriedem: there is a lot of complexity around it, but we agreed we'd do this thing, so... | 19:58 |
*** krtaylor has joined #openstack-nova | 19:59 | |
mriedem | dansmith: you first | 19:59 |
*** meghal has quit IRC | 19:59 | |
dansmith | mriedem: hmm, I've seen this trap before | 19:59 |
dansmith | mriedem: but, I just did :) | 19:59 |
*** meghal has joined #openstack-nova | 20:00 | |
openstackgerrit | Earle F. Philhower, III proposed openstack/nova: Add os_brick-based VolumeDriver for HGST connector https://review.openstack.org/194412 | 20:00 |
mriedem | damn | 20:00 |
*** haomaiwa_ has quit IRC | 20:01 | |
mriedem | earlephilhower: i'm in the middle of hte last one | 20:01 |
*** meghal has quit IRC | 20:01 | |
*** lpetrut has quit IRC | 20:01 | |
*** meghal has joined #openstack-nova | 20:01 | |
earlephilhower | mriedem: Howdy...didn't want to wait with cutoff <24hrs away. | 20:01 |
jaypipes | dansmith: +W'd that PciDeviceList patch. | 20:01 |
*** edmondsw has quit IRC | 20:01 | |
dansmith | jaypipes: thanks homey | 20:01 |
mriedem | earlephilhower: yeah, that's ok, i'll still -1 :) | 20:01 |
*** rlrossit has joined #openstack-nova | 20:02 | |
*** haomaiwa_ has joined #openstack-nova | 20:02 | |
*** fawadk has quit IRC | 20:02 | |
*** thangp has quit IRC | 20:02 | |
earlephilhower | mriedem: OK, no sweat. I just pulled off your AOE splitoff so I'm kinda not sure what the prob is... | 20:03 |
jaypipes | dansmith: no problem ma brutha. | 20:03 |
mriedem | earlephilhower: oh you'll see | 20:04 |
mriedem | you'll see | 20:04 |
* earlephilhower imagines diabolical laughter... | 20:04 | |
mriedem | that's implied | 20:05 |
mriedem | muwahhahahaa | 20:05 |
*** VW_ has quit IRC | 20:05 | |
*** VW_ has joined #openstack-nova | 20:06 | |
*** annashen_ has joined #openstack-nova | 20:06 | |
*** busterswt has joined #openstack-nova | 20:06 | |
mriedem | earlephilhower: comments posted | 20:07 |
mriedem | earlephilhower: this is kind of the biggy :) hgst=nova.virt.libvirt.volume.hgst.LibvirtQuobyteVolumeDriver | 20:07 |
*** ByPasS has quit IRC | 20:09 | |
*** ByPasS has joined #openstack-nova | 20:09 | |
openstackgerrit | Dan Smith proposed openstack/nova: Add version counter to Service object https://review.openstack.org/201733 | 20:10 |
*** vishwanathj has joined #openstack-nova | 20:10 | |
*** annashen_ has quit IRC | 20:11 | |
dims | "After reboot 285 times,can not nova reboot again"... | 20:11 |
dansmith | awesome | 20:11 |
dims | https://bugs.launchpad.net/nova/+bug/1478450 | 20:11 |
openstack | Launchpad bug 1478450 in OpenStack Compute (nova) "can not nova reboot vm" [Undecided,New] | 20:11 |
* earlephilhower applies head to desk | 20:12 | |
*** baoli_ has quit IRC | 20:12 | |
earlephilhower | firkastirkadirka | 20:12 |
dims | lol | 20:13 |
dims | nova | 20:13 |
dims | anyone remember nova/openstack/common/deadlock_monitor.py? | 20:15 |
earlephilhower | mriedem: So my CI's backlogged on the change, but I want to get it in so I ./run_tests.sh nova...test_hgst. All good, commit! Only thing is test is manually instantiating the right kind of object. D'oh. | 20:15 |
mriedem | earlephilhower: yeah, i guess we don't have a test that makes sure that all available volume drivers are registered properly, but we probably don't need one either | 20:16 |
*** meghal has quit IRC | 20:16 | |
*** openstackgerrit has quit IRC | 20:16 | |
*** meghal has joined #openstack-nova | 20:16 | |
*** vladikr has quit IRC | 20:16 | |
*** openstackgerrit has joined #openstack-nova | 20:17 | |
openstackgerrit | xing-yang proposed openstack/nova: Add os-brick based LibvirtVolumeDriver for ScaleIO https://review.openstack.org/194454 | 20:17 |
*** annegentle has quit IRC | 20:17 | |
openstackgerrit | Earle F. Philhower, III proposed openstack/nova: Add os_brick-based VolumeDriver for HGST connector https://review.openstack.org/194412 | 20:18 |
*** jasondotstar has quit IRC | 20:19 | |
*** vishwanathj has quit IRC | 20:20 | |
openstackgerrit | xing-yang proposed openstack/nova: Add os-brick based LibvirtVolumeDriver for ScaleIO https://review.openstack.org/194454 | 20:22 |
*** achanda has joined #openstack-nova | 20:25 | |
*** xyang1 has joined #openstack-nova | 20:26 | |
*** meghal has quit IRC | 20:27 | |
*** lucas__ has quit IRC | 20:28 | |
xyang | mriedem: hi, can you please review the Scaleio patch again? https://review.openstack.org/#/c/194454/ | 20:29 |
*** xyang1 has quit IRC | 20:29 | |
rlrossit | dansmith: got the most recent run done: http://logs.openstack.org/30/198730/16/check/gate-grenade-dsvm-partial-ncpu/4277d2a/logs/, and I found something suspicious... | 20:29 |
mriedem | yeah, in a bit | 20:29 |
xyang | mriedem: thanks! | 20:30 |
rlrossit | dansmith: "Got IncompatibleObjectVersion, object name Instance at version 1.21 while processing InstanceList at version 1.16" | 20:30 |
*** y_sawai has quit IRC | 20:30 | |
rlrossit | InstanceList 1.16 should have Instance 1.19, and InstanceList 1.19 (the latest version which we are trying to convert) is at Instance 1.21 | 20:31 |
rlrossit | not sure if it's always said that and I'm suddenly not stupid and realizing it | 20:31 |
*** lucas__ has joined #openstack-nova | 20:31 | |
*** jasondotstar has joined #openstack-nova | 20:32 | |
*** kaisers has quit IRC | 20:34 | |
*** achanda has quit IRC | 20:34 | |
*** achanda has joined #openstack-nova | 20:35 | |
*** lucas__ has quit IRC | 20:35 | |
*** tjones1 has joined #openstack-nova | 20:35 | |
*** tjones2 has joined #openstack-nova | 20:36 | |
*** salv-orlando has quit IRC | 20:36 | |
*** armax has joined #openstack-nova | 20:39 | |
*** armax has quit IRC | 20:39 | |
*** tjones1 has quit IRC | 20:40 | |
dansmith | rlrossit: right so that means we're not actually converting Instance when we convert InstanceList, right? | 20:40 |
*** achanda has quit IRC | 20:41 | |
*** davideagnello has joined #openstack-nova | 20:41 | |
rlrossit | dansmith: uhhh... sure? | 20:44 |
rlrossit | dansmith: but it should be *trying* to convert Instance right? | 20:44 |
dansmith | well, presumably, but I'm not seeing any debug in your obj_make_compatible() to tell us that it's actually running | 20:45 |
dansmith | so I wonder if it's something stupid and punting on the whole thing | 20:46 |
*** salv-orlando has joined #openstack-nova | 20:46 | |
*** VW_ has quit IRC | 20:47 | |
rlrossit | dansmith: wait... who's supposed to be running obj_make_compatible()? conductor, right? | 20:47 |
*** VW_ has joined #openstack-nova | 20:47 | |
dansmith | yeah | 20:47 |
*** lucas__ has joined #openstack-nova | 20:48 | |
rlrossit | oh wait I'm dumb I was looking at ObjectListBase and saying it wasn't trying to convert Instance... so do I need to add logging to NovaObjects obj_make_compatible() now too? | 20:48 |
*** tjones has quit IRC | 20:49 | |
dansmith | we know it's running L618 at least | 20:49 |
rlrossit | yeah but that's only for lists | 20:50 |
rlrossit | we can't see what's going on when it's trying to convert Instance | 20:50 |
rlrossit | which if you think about it, should be out of my new stuff's hands | 20:50 |
dansmith | right, but the list is what recurses | 20:50 |
*** edmondsw has joined #openstack-nova | 20:50 | |
rlrossit | hrm | 20:50 |
dansmith | so on L644, I'd want to know what child version we calculated for Instance | 20:50 |
dansmith | (and ideally some indication that we went through the else on line 625 | 20:51 |
*** tonytan4ever has quit IRC | 20:51 | |
*** lucas__ has quit IRC | 20:51 | |
dansmith | and then something saying "I'm calling obj_to_primitive(instance, target_version=$foo)" on L646 | 20:51 |
*** lucas__ has joined #openstack-nova | 20:51 | |
dansmith | and then dump the output of that to see that we actually converted it | 20:51 |
mriedem | xyang: a few comments inline https://review.openstack.org/#/c/194454/ | 20:51 |
*** VW_ has quit IRC | 20:51 | |
dansmith | either, we're not converting it, or we're converting it to the wrong version, or we are doing both things and somehow not passing back the updated stack to the client | 20:52 |
xyang | mriedem: let me check, thanks | 20:52 |
rlrossit | uhhh | 20:52 |
rlrossit | I think I found the problem | 20:52 |
rlrossit | L646 | 20:52 |
dansmith | what about it? | 20:53 |
rlrossit | I should be doing self.objects[index] = self.objects[index].obj_make_compatible()? | 20:53 |
dansmith | no | 20:53 |
dansmith | obj_make_compatible() operates on primitive in-place | 20:53 |
dansmith | so primitives[index] should be changed after that call | 20:53 |
rlrossit | gotcha | 20:53 |
dansmith | which is what you should print | 20:53 |
dansmith | but, | 20:53 |
*** dustins has joined #openstack-nova | 20:54 | |
dansmith | if we're ever copying that dict and returning the original and not the copy or something, then that would be same kind of result | 20:54 |
dansmith | I don't think we're doing that, but answering the above 3-possibility question would tell us which thing to chase I thin | 20:54 |
dansmith | rlrossit: I assume you didn't get this running locally, eh? | 20:55 |
*** Sukhdev_ has quit IRC | 20:55 | |
*** ByPasS has quit IRC | 20:55 | |
*** lucas__ has quit IRC | 20:55 | |
rlrossit | no because I couldn't figure out the zuul magic of getting my kilo change in old, and my liberty change in new | 20:56 |
*** ByPasS has joined #openstack-nova | 20:56 | |
rlrossit | this is a dependency nightmare | 20:56 |
*** rmcall has joined #openstack-nova | 20:56 | |
rlrossit | unless I can tell grenade to not do anything | 20:56 |
*** dustins has left #openstack-nova | 20:56 | |
xyang | mriedem: sure, working on more tests. So is the merge deadline by end of day tomorrow? | 20:56 |
rlrossit | for cloning | 20:56 |
dansmith | rlrossit: it's easy | 20:56 |
rlrossit | "easy" | 20:56 |
dansmith | rlrossit: grenade has configs for that | 20:56 |
*** dustins has joined #openstack-nova | 20:56 | |
rlrossit | grenade has too many configs | 20:56 |
dansmith | rlrossit: you don't have to do "the zuul thing" you just have to tell grenade what you want | 20:57 |
dansmith | mriedem: can't you help him? | 20:57 |
mriedem | help rlrossit run grenade partial n-cpu locally? | 20:57 |
dansmith | rlrossit: you can do this with just devstack too I think | 20:57 |
dansmith | mriedem: yeah | 20:57 |
*** lucas__ has joined #openstack-nova | 20:57 | |
mriedem | dansmith: i've never tried | 20:57 |
*** angdraug has joined #openstack-nova | 20:58 | |
mriedem | xyang: yeah i think so | 20:58 |
*** meghal has joined #openstack-nova | 20:58 | |
dansmith | okay, well, I guess I'll just do it | 20:58 |
*** meghal has quit IRC | 20:58 | |
xyang | mriedem: ok, thanks | 20:58 |
*** tonytan4ever has joined #openstack-nova | 20:59 | |
*** Nikolay_St has quit IRC | 21:00 | |
*** haomaiwa_ has quit IRC | 21:01 | |
*** lucas__ has quit IRC | 21:01 | |
openstackgerrit | Earle F. Philhower, III proposed openstack/nova: Add os_brick-based VolumeDriver for HGST connector https://review.openstack.org/194412 | 21:02 |
*** 6JTABPDW5 has joined #openstack-nova | 21:02 | |
*** nagyz_ has quit IRC | 21:02 | |
*** nagyz_ has joined #openstack-nova | 21:03 | |
openstackgerrit | Earle F. Philhower, III proposed openstack/nova: Add os_brick-based VolumeDriver for HGST connector https://review.openstack.org/194412 | 21:04 |
xyang | mriedem: hemna says if I don't add path in filters, I'll need it in rootwrap.conf exe_dirs. do you prefer the path to be added there or keep it in compute.filters? | 21:05 |
*** VW_ has joined #openstack-nova | 21:05 | |
*** rdopiera has quit IRC | 21:08 | |
*** dustins has quit IRC | 21:09 | |
mriedem | sec | 21:10 |
mriedem | https://github.com/openstack/nova/blob/master/etc/nova/rootwrap.conf#L13 | 21:10 |
mriedem | ah | 21:10 |
mriedem | i don't really want it there no | 21:11 |
mriedem | xyang: is this not in cinder somewhere? not seeing it in https://github.com/openstack/cinder/blob/master/etc/cinder/rootwrap.d/volume.filters | 21:11 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] default_schedule_zone should be list https://review.openstack.org/207221 | 21:11 |
mriedem | xyang: the scaleio product doesn't create a link to /usr/bin or something for that executable? | 21:11 |
mriedem | that seems less than ideal | 21:12 |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Change List objects to use obj_relationships https://review.openstack.org/198730 | 21:12 |
*** ByPasS has quit IRC | 21:13 | |
xyang | I think I'll remove it from compute.filters | 21:13 |
xyang | mriedem: we'll figure out to get a link created | 21:14 |
*** aysyd has quit IRC | 21:14 | |
earlephilhower | mriedem: Sorry bout the mixup earlier, new shim version online. Mock's pretty neat, much cleaner for the test. | 21:14 |
mriedem | earlephilhower: welcome to the wonderful world of mock | 21:15 |
*** ekarlso has quit IRC | 21:16 | |
mriedem | xyang: well, this is a product that people have right? | 21:17 |
mriedem | so probably not good to merge this in openstack if it won't work | 21:17 |
mriedem | w/ older versions of that product | 21:17 |
*** ByPasS has joined #openstack-nova | 21:18 | |
xyang | mriedem: it works with what I have in compute.filters | 21:18 |
*** meghal has joined #openstack-nova | 21:18 | |
mriedem | xyang: does it work if you just have drv_cfg? | 21:18 |
xyang | mriedem: if we remove the path, we need to document to add that in rootwrap.conf | 21:19 |
xyang | mriedem: in the long term, we need to make sure the link is created automatically | 21:19 |
mriedem | xyang: yeah, how does this work then? https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/emc/scaleio.py#L989 | 21:20 |
mriedem | i don't see anything in cinder's rootwrap filter | 21:20 |
xyang | mriedem: let me check on our CI setup. This is probably missed | 21:21 |
mriedem | it's probably hacked into the ci setup to make it work :( | 21:21 |
*** tjones2 has quit IRC | 21:21 | |
mriedem | rather than having the filter in volume.filters | 21:21 |
*** angdraug has quit IRC | 21:24 | |
*** tjones has joined #openstack-nova | 21:24 | |
xyang | mriedem: there are so many moving pieces to get this one in. This one seems to be missed:( | 21:24 |
*** tjones1 has joined #openstack-nova | 21:25 | |
mriedem | busted! :) | 21:25 |
* mriedem opens cinder bug | 21:25 | |
xyang | mriedem: I'll a open a bug to get the cinder side fixed soon | 21:25 |
mriedem | xyang: already doing that now | 21:26 |
xyang | Oh, already? :) | 21:26 |
mriedem | you bet | 21:26 |
*** tjones2 has joined #openstack-nova | 21:26 | |
*** tjones1 has quit IRC | 21:26 | |
*** tjones has quit IRC | 21:29 | |
mriedem | earlephilhower: congrats | 21:33 |
*** achanda has joined #openstack-nova | 21:34 | |
earlephilhower | mriedem: Thanks! I've also got an internal project that's supposed to close today, too. Losing what little hair I've left. | 21:34 |
*** nic has quit IRC | 21:36 | |
*** eglynn_ has quit IRC | 21:38 | |
*** achanda has quit IRC | 21:39 | |
*** annashen has quit IRC | 21:39 | |
*** eglynn_ has joined #openstack-nova | 21:39 | |
*** tjones2 has left #openstack-nova | 21:40 | |
*** angdraug has joined #openstack-nova | 21:40 | |
*** rmcall has quit IRC | 21:41 | |
*** jasondotstar has quit IRC | 21:41 | |
dansmith | rlrossit: guess what | 21:42 |
dansmith | rlrossit: http://pastebin.com/MVXsFbyB | 21:43 |
dansmith | makes it real easy to poke the problem | 21:43 |
*** exploreshaifali has quit IRC | 21:43 | |
*** annashen has joined #openstack-nova | 21:43 | |
*** ekarlso has joined #openstack-nova | 21:43 | |
hemna | heh | 21:45 |
dansmith | rlrossit: it's asking instance for version 1.21 | 21:46 |
dansmith | rlrossit: so something in your obj_relationships code is not picking the right child_target_version | 21:46 |
*** dboik has quit IRC | 21:46 | |
*** tjones has joined #openstack-nova | 21:48 | |
mriedem | test_ryan_is_lazy | 21:48 |
mriedem | ha | 21:48 |
dansmith | rlrossit: you're missing a single break statement after L643 | 21:50 |
dansmith | rlrossit: which is a return in o.vo | 21:50 |
*** otter768 has joined #openstack-nova | 21:51 | |
dansmith | rlrossit: and it's also exactly what mriedem said he was waiting for .. that copied code to be the source of endless pain | 21:51 |
mriedem | omfg | 21:51 |
*** ByPasS has quit IRC | 21:51 | |
mriedem | so, | 21:51 |
mriedem | can i just get a t-shirt made that says, 'i told you so!' in big print? | 21:51 |
* dansmith drops the mic and walks out | 21:52 | |
dansmith | mriedem: you may | 21:52 |
mriedem | well, i don't want to pay for that | 21:52 |
mriedem | i'd like rlrossit to have it made | 21:52 |
mriedem | like that cupcake | 21:52 |
dansmith | probably reasonable at this point | 21:52 |
dansmith | I want another cupcake for the realization that a <10 line unit test could poke the bug | 21:53 |
*** ByPasS has joined #openstack-nova | 21:53 | |
dansmith | it's also worth noting that edleafe suggested a break there purely for efficiency like eleventy billion patchsets ago | 21:53 |
mriedem | i have a feeling that ryan has left the building | 21:54 |
dansmith | may be for the best | 21:54 |
mriedem | i'm soon to follow | 21:54 |
dansmith | the amazon man comes in a few minutes and then I'm otherwise entertained for hours | 21:55 |
mriedem | you mean the ups guy? | 21:55 |
dansmith | yeah | 21:55 |
*** otter768 has quit IRC | 21:55 | |
openstackgerrit | Danny Wilson proposed openstack/nova: libvirt: add discard support for attached volumes https://review.openstack.org/205726 | 21:55 |
mriedem | you know he doesn't work directly for amazon right? | 21:55 |
mriedem | :) | 21:55 |
dansmith | pretty sure they'll rename themselves to "amazon delivery branch" pretty soon | 21:55 |
mriedem | they should | 21:55 |
mriedem | but, | 21:55 |
mriedem | drones will replace them | 21:55 |
dansmith | surely will if they don't make smart strategic renames sooner than later, yeah | 21:56 |
*** cpschult has quit IRC | 21:56 | |
rlrossit | mriedem: dansmith: it's a good thing I chose to not turn off my laptop, and instead play video games with it sitting in the corner | 21:57 |
dansmith | heh | 21:58 |
*** thorst has quit IRC | 21:58 | |
*** READ10 has joined #openstack-nova | 21:59 | |
*** burt has quit IRC | 21:59 | |
*** dboik has joined #openstack-nova | 21:59 | |
*** meghal has quit IRC | 22:00 | |
*** 6JTABPDW5 has quit IRC | 22:01 | |
rlrossit | dansmith: so do I want the break in just the elif or do I need on in the if too? o.vo has it in both | 22:01 |
dansmith | rlrossit: I think you want it only in the == case | 22:01 |
*** meghal has joined #openstack-nova | 22:01 | |
*** meghal has quit IRC | 22:01 | |
*** markvoelker has quit IRC | 22:02 | |
*** meghal has joined #openstack-nova | 22:02 | |
rlrossit | yep it's cranking in my head now, I get it | 22:02 |
*** 16WAAEHWP has joined #openstack-nova | 22:02 | |
dansmith | rlrossit: I dunno, I'd say write tests | 22:02 |
dansmith | prove we don't need it (or do) | 22:02 |
*** Kennan2 has joined #openstack-nova | 22:02 | |
rlrossit | dansmith: but volleyball is in 30 minutes... I don't have time to right tests (right now) | 22:02 |
dansmith | yep | 22:02 |
dansmith | knowing the fix and not fixing it all night is the sweet pleasure you get | 22:03 |
openstackgerrit | sajeesh cs proposed openstack/nova: Nested Quota Driver: Create column allocated in Quota table https://review.openstack.org/151327 | 22:03 |
*** erlon has quit IRC | 22:03 | |
dansmith | i.e. that tomorrow will be productive and less head-slamming :) | 22:03 |
*** Kennan has quit IRC | 22:03 | |
openstackgerrit | Ruby Loo proposed openstack/nova: Instance destroyed if ironic node in CLEANWAIT https://review.openstack.org/207236 | 22:03 |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Change List objects to use obj_relationships https://review.openstack.org/198730 | 22:04 |
*** meghal has quit IRC | 22:04 | |
rlrossit | dansmith: does this mean I need to ship you another cupcake? | 22:04 |
*** READ10 has quit IRC | 22:04 | |
*** mriedem has quit IRC | 22:04 | |
dansmith | rlrossit: I'm certainly not waiting until the next time I'm in rochester, but we can negotiate alternate payment and delivery arrangements later | 22:05 |
dansmith | the first cupcake was pretty good... not sure I'd be happy with the mess I'd receive via UPS | 22:05 |
*** apmelton has quit IRC | 22:06 | |
*** annashen_ has joined #openstack-nova | 22:07 | |
rlrossit | dansmith: it's up and you can stare at zuul if you want, I'm personally sick of looking at it so I'm out. I'll probably check later tonight so I can sleep easy | 22:07 |
dansmith | yep, all good | 22:07 |
*** rlrossit has left #openstack-nova | 22:07 | |
*** apmelton has joined #openstack-nova | 22:08 | |
*** achanda has joined #openstack-nova | 22:11 | |
*** annashen_ has quit IRC | 22:12 | |
*** busterswt has quit IRC | 22:12 | |
*** d34dh0r53 has quit IRC | 22:13 | |
*** ctrath has quit IRC | 22:13 | |
*** VW__ has joined #openstack-nova | 22:13 | |
*** d34dh0r53 has joined #openstack-nova | 22:13 | |
*** LukeHinds has quit IRC | 22:14 | |
*** chuckcarmack has left #openstack-nova | 22:15 | |
*** d34dh0r53 has quit IRC | 22:15 | |
*** lucas-dinner has quit IRC | 22:15 | |
*** d34dh0r53 has joined #openstack-nova | 22:16 | |
*** VW_ has quit IRC | 22:17 | |
*** VW__ has quit IRC | 22:18 | |
*** Sukhdev_ has joined #openstack-nova | 22:19 | |
*** apmelton has quit IRC | 22:22 | |
*** d34dh0r53 has quit IRC | 22:23 | |
*** mjturek1 has quit IRC | 22:23 | |
*** READ10 has joined #openstack-nova | 22:23 | |
*** d34dh0r53 has joined #openstack-nova | 22:23 | |
*** dboik has quit IRC | 22:25 | |
*** apmelton has joined #openstack-nova | 22:25 | |
*** d34dh0r53 has quit IRC | 22:27 | |
*** d34dh0r53 has joined #openstack-nova | 22:27 | |
*** jasondotstar has joined #openstack-nova | 22:28 | |
edleafe | jroll: still around? | 22:28 |
*** armax has joined #openstack-nova | 22:29 | |
jroll | edleafe: yep | 22:29 |
jroll | I'm always around >:) | 22:29 |
edleafe | jroll: are your sites using the ironic_host_manager? Could we simply override the bad behavior there? | 22:30 |
jroll | edleafe: yeah, they are, I think it's a requirement for ironic | 22:31 |
jroll | that's a great point you have there :) | 22:31 |
edleafe | jroll: wasn't sure if it was required or just advisable :) | 22:31 |
edleafe | jroll: ok, lemme push something different | 22:32 |
*** d34dh0r53 has quit IRC | 22:32 | |
*** d34dh0r53 has joined #openstack-nova | 22:33 | |
jroll | edleafe: yeah, it's required because IronicHostState | 22:33 |
*** ByPasS has quit IRC | 22:35 | |
*** armax has quit IRC | 22:36 | |
openstackgerrit | Fei Long Wang proposed openstack/nova-specs: Add spec for volume backed backup https://review.openstack.org/190919 | 22:37 |
*** ByPasS has joined #openstack-nova | 22:37 | |
*** mwagner_lap has quit IRC | 22:38 | |
*** ijuwang has quit IRC | 22:40 | |
*** ByPasS has quit IRC | 22:43 | |
*** jaypipes has quit IRC | 22:43 | |
*** ByPasS has joined #openstack-nova | 22:43 | |
*** thorst has joined #openstack-nova | 22:45 | |
*** raildo has quit IRC | 22:49 | |
*** samueldmq has quit IRC | 22:49 | |
*** ericksonsantos has quit IRC | 22:50 | |
*** htruta has quit IRC | 22:50 | |
*** ByPasS has quit IRC | 22:50 | |
*** tpeoples has quit IRC | 22:51 | |
*** ByPasS has joined #openstack-nova | 22:52 | |
*** vishwanathj has joined #openstack-nova | 22:53 | |
*** penick has joined #openstack-nova | 22:56 | |
*** markvoelker_ has joined #openstack-nova | 22:57 | |
*** eglynn_ has quit IRC | 22:58 | |
*** ByPasS has quit IRC | 22:59 | |
*** 16WAAEHWP has quit IRC | 23:01 | |
openstackgerrit | Ed Leafe proposed openstack/nova: Fix IronicHostManager to skip get_by_host() call. https://review.openstack.org/206736 | 23:01 |
*** haomaiwang has joined #openstack-nova | 23:02 | |
edleafe | jroll: ^ | 23:02 |
* jroll looks | 23:03 | |
*** ByPasS has joined #openstack-nova | 23:04 | |
*** jecarey has quit IRC | 23:04 | |
*** alexpilotti has quit IRC | 23:05 | |
*** ddaskal has quit IRC | 23:06 | |
*** moshele has joined #openstack-nova | 23:06 | |
*** ZZelle has quit IRC | 23:07 | |
*** tonytan4ever has quit IRC | 23:12 | |
*** gzhai has joined #openstack-nova | 23:13 | |
*** gzhai has quit IRC | 23:14 | |
*** gzhai has joined #openstack-nova | 23:15 | |
*** diogogmt has quit IRC | 23:17 | |
gzhai | sdague: I changed according to you comments. Could you pls. take a look at https://review.openstack.org/#/c/203573/ ? | 23:18 |
*** thorst has quit IRC | 23:19 | |
*** vishwanathj has quit IRC | 23:20 | |
*** slong has joined #openstack-nova | 23:22 | |
*** tpeoples has joined #openstack-nova | 23:22 | |
openstackgerrit | Fei Long Wang proposed openstack/nova: Fix nova backup for volume-backed instance https://review.openstack.org/164494 | 23:23 |
*** moshele has quit IRC | 23:24 | |
*** annegentle has joined #openstack-nova | 23:28 | |
*** annashen has quit IRC | 23:28 | |
*** oomichi has joined #openstack-nova | 23:31 | |
*** zhenguo has joined #openstack-nova | 23:31 | |
*** ByPasS has quit IRC | 23:32 | |
*** jasondotstar has quit IRC | 23:33 | |
*** meghal has joined #openstack-nova | 23:34 | |
*** ByPasS has joined #openstack-nova | 23:34 | |
*** mwagner_lap has joined #openstack-nova | 23:37 | |
*** obondarev has quit IRC | 23:38 | |
*** obondarev has joined #openstack-nova | 23:39 | |
*** jamielennox is now known as jamielennox|away | 23:39 | |
*** penick has quit IRC | 23:39 | |
openstackgerrit | Tracy Jones proposed openstack/nova: Cleanup of compute api reboot method https://review.openstack.org/127427 | 23:41 |
*** tpeoples has quit IRC | 23:42 | |
*** jasondotstar has joined #openstack-nova | 23:45 | |
*** andrewbogott has left #openstack-nova | 23:46 | |
*** armax has joined #openstack-nova | 23:47 | |
*** rmcall has joined #openstack-nova | 23:47 | |
*** otter768 has joined #openstack-nova | 23:51 | |
*** Kennan2 is now known as Kennan | 23:53 | |
*** otter768 has quit IRC | 23:56 | |
melwitt | dansmith: what are the guidelines for creating an object from a primitive? when to use objects.<class>.obj_from_primitive vs objects.<class>(context, **primitive) | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!