*** ritesh has joined #openstack-nova | 00:00 | |
alex_xu | dansmith: hi, may I update this patch https://review.openstack.org/#/c/209240/ if I found something today? | 00:01 |
---|---|---|
openstackgerrit | Shiina, Hironori proposed openstack/nova: Add a Nova API to inject an NMI https://review.openstack.org/202617 | 00:02 |
*** achanda_ has quit IRC | 00:03 | |
*** salv-orlando has quit IRC | 00:03 | |
*** achanda has quit IRC | 00:05 | |
*** diogogmt has quit IRC | 00:07 | |
*** skylerberg has quit IRC | 00:11 | |
*** armax has joined #openstack-nova | 00:11 | |
*** mriedem1 has joined #openstack-nova | 00:15 | |
*** ijw_ has joined #openstack-nova | 00:16 | |
*** mriedem has quit IRC | 00:17 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs: Spec for "tenant_id" "user_id" filter implies "all_tenant" https://review.openstack.org/198184 | 00:18 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs: Spec for "tenant_id" "user_id" filter implies "all_tenant" https://review.openstack.org/198184 | 00:18 |
*** ijw has quit IRC | 00:19 | |
ritesh | Has anyone tried booting an instance with a nic each on 2 subnets on 1 network ? I see that only one interface is up in the instance... | 00:19 |
ritesh | ^^ HELP HELP! | 00:19 |
*** skylerberg has joined #openstack-nova | 00:20 | |
*** tsekiyam_ has joined #openstack-nova | 00:21 | |
dansmith | alex_xu: I guess | 00:22 |
openstackgerrit | Ghanshyam Mann proposed openstack/nova-specs: Spec to add vif 'net-id' in virtual interfaces API https://review.openstack.org/198622 | 00:23 |
*** mtanino has quit IRC | 00:24 | |
*** otter768 has joined #openstack-nova | 00:25 | |
*** tsekiyama has quit IRC | 00:25 | |
*** tsekiyam_ has quit IRC | 00:26 | |
*** markvoelker has quit IRC | 00:27 | |
*** markvoelker has joined #openstack-nova | 00:28 | |
*** ssurana has joined #openstack-nova | 00:28 | |
*** tjones has joined #openstack-nova | 00:29 | |
*** otter768 has quit IRC | 00:29 | |
*** iamjarvo has joined #openstack-nova | 00:33 | |
alex_xu | dansmith: ok, let me give one more try :) | 00:34 |
*** iamjarvo has quit IRC | 00:37 | |
*** asselin_ has left #openstack-nova | 00:41 | |
openstackgerrit | Shiina, Hironori proposed openstack/nova-specs: Fix spec: Inject NMI to an instance https://review.openstack.org/207004 | 00:42 |
*** tjones has quit IRC | 00:46 | |
openstackgerrit | Zhenguo Niu proposed openstack/nova: [Ironic]Not count available resources of deployed ironic node https://review.openstack.org/204088 | 00:49 |
*** dims_ has quit IRC | 00:53 | |
*** liusheng has joined #openstack-nova | 00:55 | |
*** ijw_ has quit IRC | 00:58 | |
*** ijw has joined #openstack-nova | 00:59 | |
*** praneshp has quit IRC | 01:00 | |
*** tjones has joined #openstack-nova | 01:00 | |
*** leeantho has quit IRC | 01:01 | |
*** ijw_ has joined #openstack-nova | 01:03 | |
*** atuvenie has quit IRC | 01:05 | |
openstackgerrit | Vilobh Meshram proposed openstack/nova-specs: Quota by Flavor, Quota by AZ, Quota by X https://review.openstack.org/206160 | 01:05 |
*** ijw has quit IRC | 01:06 | |
*** xyang has quit IRC | 01:08 | |
*** dave-mccowan has joined #openstack-nova | 01:09 | |
*** dims_ has joined #openstack-nova | 01:09 | |
*** dims__ has joined #openstack-nova | 01:15 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs: Add project id information in os-server-group API https://review.openstack.org/209917 | 01:16 |
*** dims__ has quit IRC | 01:16 | |
*** thorst has joined #openstack-nova | 01:16 | |
*** thorst has quit IRC | 01:17 | |
*** dims_ has quit IRC | 01:17 | |
*** dims_ has joined #openstack-nova | 01:18 | |
*** tongli has joined #openstack-nova | 01:18 | |
*** bnemec has quit IRC | 01:19 | |
*** ssurana has quit IRC | 01:19 | |
*** jyuso1 has quit IRC | 01:21 | |
*** angdraug has quit IRC | 01:23 | |
*** tpeoples has joined #openstack-nova | 01:25 | |
*** lyanchih has joined #openstack-nova | 01:26 | |
*** bnemec has joined #openstack-nova | 01:27 | |
*** meghal has quit IRC | 01:32 | |
*** pixelbeat has quit IRC | 01:33 | |
*** kylek3h has quit IRC | 01:39 | |
*** tjones has quit IRC | 01:41 | |
*** dims__ has joined #openstack-nova | 01:42 | |
*** dims_ has quit IRC | 01:44 | |
*** mriedem1 has quit IRC | 01:44 | |
*** tpeoples has quit IRC | 01:50 | |
*** shuquan has joined #openstack-nova | 01:51 | |
*** vilobhmm has quit IRC | 01:51 | |
*** ijw_ has quit IRC | 01:52 | |
*** Sukhdev has quit IRC | 01:53 | |
*** dims_ has joined #openstack-nova | 01:54 | |
*** unicell has quit IRC | 01:56 | |
*** dims__ has quit IRC | 01:56 | |
*** zul has joined #openstack-nova | 02:11 | |
openstackgerrit | Shiina, Hironori proposed openstack/nova: Add a compute RPC API to inject an NMI https://review.openstack.org/202605 | 02:15 |
*** tongli has quit IRC | 02:16 | |
openstackgerrit | Shiina, Hironori proposed openstack/nova: Add a Nova API to inject an NMI https://review.openstack.org/202617 | 02:18 |
*** baoli has joined #openstack-nova | 02:22 | |
*** baoli has quit IRC | 02:22 | |
*** achanda has joined #openstack-nova | 02:24 | |
*** baoli has joined #openstack-nova | 02:24 | |
*** otter768 has joined #openstack-nova | 02:25 | |
*** baoli has quit IRC | 02:29 | |
*** markvoelker has quit IRC | 02:30 | |
*** otter768 has quit IRC | 02:30 | |
*** shuquan has quit IRC | 02:34 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: CONF.allow_resize_to_same_host should check only once in controller https://review.openstack.org/186236 | 02:41 |
*** dave-mccowan has quit IRC | 02:42 | |
openstackgerrit | Jay Pipes proposed openstack/nova: pci: Use fields.Enum type for PCI device status https://review.openstack.org/210180 | 02:43 |
openstackgerrit | Jay Pipes proposed openstack/nova: pci: Use fields.Enum type for PCI device type https://review.openstack.org/210181 | 02:43 |
openstackgerrit | Jay Pipes proposed openstack/nova: pci: Move whitelist filtering inside PCI tracker https://review.openstack.org/210182 | 02:43 |
openstackgerrit | Jay Pipes proposed openstack/nova: pci: Remove get_pci_devices_filter() method https://review.openstack.org/210183 | 02:43 |
*** wanghua has joined #openstack-nova | 02:43 | |
*** rushiagr_away is now known as rushiagr | 02:45 | |
*** dave-mccowan has joined #openstack-nova | 02:46 | |
*** Murali has joined #openstack-nova | 02:51 | |
*** hakimo_ has joined #openstack-nova | 02:52 | |
*** hakimo has quit IRC | 02:55 | |
*** rushiagr is now known as rushiagr_away | 03:02 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Use Version Independent Identity Plugins for Neutron handshake https://review.openstack.org/209599 | 03:06 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 03:08 |
*** Murali has quit IRC | 03:10 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Use Version Independent Identity Plugins for Neutron handshake https://review.openstack.org/209599 | 03:10 |
openstackgerrit | Alex Xu proposed openstack/nova: Remove tie between system_metadata and extra.flavor https://review.openstack.org/209240 | 03:12 |
*** baoli has joined #openstack-nova | 03:12 | |
*** baoli has quit IRC | 03:12 | |
*** shuquan has joined #openstack-nova | 03:13 | |
*** sakaYK has joined #openstack-nova | 03:14 | |
openstackgerrit | Shiina, Hironori proposed openstack/python-novaclient: Add support for injecting an NMI https://review.openstack.org/207092 | 03:21 |
*** salv-orlando has joined #openstack-nova | 03:24 | |
*** markvoelker has joined #openstack-nova | 03:30 | |
*** shuquan_ has joined #openstack-nova | 03:31 | |
*** shuquan has quit IRC | 03:32 | |
*** shuquan_ is now known as shuquan | 03:32 | |
*** salv-orlando has quit IRC | 03:33 | |
*** Guest57802 is now known as jgriffith | 03:34 | |
*** markvoelker has quit IRC | 03:35 | |
*** tjones has joined #openstack-nova | 03:37 | |
*** zzzeek has quit IRC | 03:38 | |
*** shyu has joined #openstack-nova | 03:39 | |
*** diogogmt has joined #openstack-nova | 03:40 | |
*** shuquan has quit IRC | 03:44 | |
*** vilobhmm has joined #openstack-nova | 03:45 | |
*** apuimedo has quit IRC | 03:46 | |
*** humble_ has joined #openstack-nova | 03:47 | |
*** vivekd has joined #openstack-nova | 03:48 | |
*** wanghua has quit IRC | 03:49 | |
*** boris-42 has quit IRC | 03:50 | |
*** skylerberg has quit IRC | 03:50 | |
*** humble__ has joined #openstack-nova | 03:51 | |
*** humble_ has quit IRC | 03:55 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs: Add project id information in os-server-group API https://review.openstack.org/209917 | 03:56 |
*** achanda has quit IRC | 03:56 | |
*** shuquan has joined #openstack-nova | 03:57 | |
*** shuquan has quit IRC | 04:02 | |
*** dims_ has quit IRC | 04:04 | |
*** hshiina has joined #openstack-nova | 04:05 | |
*** shuquan has joined #openstack-nova | 04:05 | |
*** rajesht has joined #openstack-nova | 04:08 | |
*** rajesht has quit IRC | 04:09 | |
*** rajesht has joined #openstack-nova | 04:10 | |
*** shuquan has quit IRC | 04:10 | |
*** shuquan_ has joined #openstack-nova | 04:10 | |
*** gyee has quit IRC | 04:13 | |
*** baoli has joined #openstack-nova | 04:13 | |
*** lyanchih has quit IRC | 04:14 | |
*** baoli has quit IRC | 04:18 | |
*** sudipto has joined #openstack-nova | 04:21 | |
*** otter768 has joined #openstack-nova | 04:26 | |
*** yushiro has joined #openstack-nova | 04:28 | |
*** ildikov has quit IRC | 04:29 | |
*** otter768 has quit IRC | 04:31 | |
*** Sukhdev_ has joined #openstack-nova | 04:34 | |
*** salv-orlando has joined #openstack-nova | 04:34 | |
*** kiran-r has joined #openstack-nova | 04:34 | |
*** tjones has quit IRC | 04:34 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs: Add project id information in os-server-group API https://review.openstack.org/209917 | 04:35 |
yushiro | sdague, ping | 04:37 |
*** jswarren has quit IRC | 04:38 | |
*** jdandrea has quit IRC | 04:39 | |
*** dave-mccowan has quit IRC | 04:39 | |
*** salv-orlando has quit IRC | 04:39 | |
*** xyang2 has quit IRC | 04:40 | |
*** sakaYK has quit IRC | 04:41 | |
*** sakaYK has joined #openstack-nova | 04:41 | |
*** deepakcs has joined #openstack-nova | 04:41 | |
*** dave-mccowan has joined #openstack-nova | 04:42 | |
*** Nikolay_St has joined #openstack-nova | 04:42 | |
*** vilobhmm has quit IRC | 04:44 | |
*** vilobhmm has joined #openstack-nova | 04:44 | |
*** tjones has joined #openstack-nova | 04:47 | |
*** tjones has quit IRC | 04:48 | |
*** unicell has joined #openstack-nova | 04:49 | |
*** diogogmt has quit IRC | 05:00 | |
*** ishant has joined #openstack-nova | 05:03 | |
*** lyanchih has joined #openstack-nova | 05:04 | |
*** _kiran_ has joined #openstack-nova | 05:06 | |
*** kiran-r has quit IRC | 05:07 | |
openstackgerrit | Johnson koil raj proposed openstack/nova: Provide an option to set disk.EnableUUID in vmx https://review.openstack.org/205269 | 05:10 |
*** haomaiwang has quit IRC | 05:11 | |
*** haomaiwa_ has joined #openstack-nova | 05:11 | |
*** flwang1 has quit IRC | 05:11 | |
*** ildikov has joined #openstack-nova | 05:12 | |
openstackgerrit | Zachary Sais proposed openstack/nova: Move existing V2 to legacy_v2 https://review.openstack.org/193725 | 05:14 |
*** unicell has quit IRC | 05:15 | |
*** _kiran_ has quit IRC | 05:16 | |
*** unicell has joined #openstack-nova | 05:19 | |
*** dave-mcc_ has joined #openstack-nova | 05:21 | |
*** moshele has joined #openstack-nova | 05:22 | |
*** baoli has joined #openstack-nova | 05:22 | |
*** dave-mccowan has quit IRC | 05:23 | |
deepakcs | johnthetubaguy: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/volume-snapshot-improvements,n,z (splitted the patch as per your and danpb's suggestion) | 05:24 |
deepakcs | dansmith: danpb ^^ | 05:24 |
*** achanda has joined #openstack-nova | 05:25 | |
*** vilobhmm has quit IRC | 05:25 | |
*** baoli has quit IRC | 05:27 | |
*** shihanzhang has quit IRC | 05:29 | |
*** shihanzhang has joined #openstack-nova | 05:29 | |
*** echoingumesh has joined #openstack-nova | 05:31 | |
*** cfriesen has quit IRC | 05:31 | |
*** markvoelker has joined #openstack-nova | 05:31 | |
*** echoingu_ has joined #openstack-nova | 05:34 | |
*** markvoelker has quit IRC | 05:36 | |
*** echoingumesh has quit IRC | 05:37 | |
*** shuquan_ has quit IRC | 05:39 | |
*** lyanchih has quit IRC | 05:39 | |
*** shuquan has joined #openstack-nova | 05:39 | |
*** salv-orlando has joined #openstack-nova | 05:40 | |
*** sakaYK has quit IRC | 05:41 | |
*** shuquan has quit IRC | 05:42 | |
*** shuquan has joined #openstack-nova | 05:43 | |
*** Nikolay_St has quit IRC | 05:46 | |
*** salv-orlando has quit IRC | 05:46 | |
*** belmoreira has quit IRC | 05:47 | |
*** Murali has joined #openstack-nova | 05:48 | |
*** praneshp has joined #openstack-nova | 05:49 | |
openstackgerrit | Alex Xu proposed openstack/nova: Remove tie between system_metadata and extra.flavor https://review.openstack.org/209240 | 05:52 |
*** josecastroleon has joined #openstack-nova | 05:54 | |
openstackgerrit | Zoltan Arnold Nagy proposed openstack/nova: libvirt: add encrypted rbd volume support https://review.openstack.org/206576 | 05:55 |
*** lyanchih has joined #openstack-nova | 05:56 | |
*** jwitko has quit IRC | 05:58 | |
*** ankit_ag has joined #openstack-nova | 06:02 | |
*** setuid has quit IRC | 06:02 | |
*** jwitko has joined #openstack-nova | 06:02 | |
*** melwitt has quit IRC | 06:04 | |
*** zul has quit IRC | 06:06 | |
*** ftersin has joined #openstack-nova | 06:07 | |
*** praneshp has quit IRC | 06:09 | |
*** setuid has joined #openstack-nova | 06:09 | |
*** alex_klimov has joined #openstack-nova | 06:09 | |
*** ttrumm has joined #openstack-nova | 06:10 | |
openstackgerrit | junxu proposed openstack/nova-specs: Allow force stop server in nova rest api https://review.openstack.org/195418 | 06:11 |
openstackgerrit | garyk proposed openstack/nova: Compute: replace incorrect instance object with dict https://review.openstack.org/209583 | 06:15 |
*** ftersin_ has joined #openstack-nova | 06:17 | |
*** moshele has quit IRC | 06:18 | |
*** ftersin has quit IRC | 06:19 | |
*** sakaYK has joined #openstack-nova | 06:22 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex https://review.openstack.org/209780 | 06:22 |
*** otter768 has joined #openstack-nova | 06:27 | |
*** otter768 has quit IRC | 06:32 | |
*** alex_klimov has quit IRC | 06:33 | |
*** Sukhdev_ has quit IRC | 06:34 | |
*** sahid has joined #openstack-nova | 06:34 | |
*** alex_klimov has joined #openstack-nova | 06:34 | |
*** Nikolay_St has joined #openstack-nova | 06:38 | |
*** rdopiera has joined #openstack-nova | 06:38 | |
*** belmoreira has joined #openstack-nova | 06:38 | |
*** humble__ has quit IRC | 06:40 | |
*** humble__ has joined #openstack-nova | 06:41 | |
*** lyanchih has quit IRC | 06:44 | |
*** sahid has quit IRC | 06:46 | |
*** jyuso1 has joined #openstack-nova | 06:46 | |
*** salv-orlando has joined #openstack-nova | 06:51 | |
*** Vikas has joined #openstack-nova | 06:51 | |
Vikas | Hi Folks..one small query | 06:52 |
*** sahid has joined #openstack-nova | 06:52 | |
Vikas | what does "cleaned" instance variable in a VM instance class represents.https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L106 | 06:53 |
*** sahid has quit IRC | 06:53 | |
Vikas | does it mean if hypervisor resources have been freed? | 06:54 |
*** jwitko has quit IRC | 06:54 | |
*** sahid has joined #openstack-nova | 06:54 | |
*** shuquan has quit IRC | 06:55 | |
*** vilobhmm has joined #openstack-nova | 06:55 | |
*** shuquan has joined #openstack-nova | 06:55 | |
*** jwitko has joined #openstack-nova | 06:56 | |
*** salv-orlando has quit IRC | 06:56 | |
*** shuquan has quit IRC | 06:57 | |
*** sahid has quit IRC | 06:58 | |
*** setuid has quit IRC | 06:59 | |
*** sahid has joined #openstack-nova | 07:01 | |
*** lyanchih has joined #openstack-nova | 07:01 | |
*** dave-mcc_ has quit IRC | 07:01 | |
*** vilobhmm has quit IRC | 07:01 | |
*** dave-mccowan has joined #openstack-nova | 07:02 | |
*** winston-d_zZZ is now known as winston-d | 07:04 | |
*** romainh has joined #openstack-nova | 07:06 | |
*** yushiro has quit IRC | 07:10 | |
*** shuquan has joined #openstack-nova | 07:11 | |
humble__ | #openstack-fuel | 07:12 |
*** Marga_ has joined #openstack-nova | 07:13 | |
*** salv-orlando has joined #openstack-nova | 07:13 | |
*** achanda has quit IRC | 07:15 | |
*** shuquan has quit IRC | 07:15 | |
*** romainh has left #openstack-nova | 07:16 | |
*** humble_ has joined #openstack-nova | 07:17 | |
*** shuquan has joined #openstack-nova | 07:17 | |
*** kiran-r has joined #openstack-nova | 07:17 | |
*** yamahata has quit IRC | 07:17 | |
*** ttrumm_ has joined #openstack-nova | 07:19 | |
*** lyanchih has quit IRC | 07:20 | |
*** ttrumm has quit IRC | 07:20 | |
*** tojuvone has joined #openstack-nova | 07:23 | |
*** Marga_ has quit IRC | 07:23 | |
*** Marga_ has joined #openstack-nova | 07:24 | |
*** sahid has quit IRC | 07:26 | |
*** sahid has joined #openstack-nova | 07:26 | |
*** setuid has joined #openstack-nova | 07:27 | |
*** abhishekk has joined #openstack-nova | 07:28 | |
*** markvoelker has joined #openstack-nova | 07:32 | |
*** baoli has joined #openstack-nova | 07:34 | |
*** markvoelker has quit IRC | 07:37 | |
*** baoli has quit IRC | 07:39 | |
openstackgerrit | Ankit Agrawal proposed openstack/nova: Detach volume after deleting instance with no host https://review.openstack.org/194063 | 07:39 |
*** shuquan has quit IRC | 07:43 | |
*** browne has quit IRC | 07:44 | |
*** vivekd has quit IRC | 07:47 | |
*** shuquan has joined #openstack-nova | 07:50 | |
*** jlanoux has joined #openstack-nova | 07:51 | |
openstackgerrit | ZhuChunzhan proposed openstack/python-novaclient: Correct the files's description "overrwriter" The parameter of method create files's description contains incorrect word Modify "overrwrite" to "overwrite". Fixes Bug1482081 https://review.openstack.org/210235 | 07:51 |
*** chhavi has joined #openstack-nova | 07:51 | |
*** ssurana has joined #openstack-nova | 07:51 | |
openstackgerrit | Eduard Biceri-Matei proposed openstack/nova: libvirt: New driver for volumes backed by local file. https://review.openstack.org/134134 | 07:51 |
*** wanghua has joined #openstack-nova | 07:52 | |
*** alexschm has joined #openstack-nova | 07:52 | |
*** jcoufal has joined #openstack-nova | 07:52 | |
*** shuquan_ has joined #openstack-nova | 07:54 | |
*** humble__ has quit IRC | 07:54 | |
*** shuquan has quit IRC | 07:55 | |
*** shuquan_ is now known as shuquan | 07:55 | |
*** venkatesh has joined #openstack-nova | 08:00 | |
*** liusheng has quit IRC | 08:00 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add instance action events for live migration https://review.openstack.org/195372 | 08:04 |
*** jistr has joined #openstack-nova | 08:06 | |
*** alexpilotti has joined #openstack-nova | 08:07 | |
*** ttrumm_ has quit IRC | 08:14 | |
*** yassine_ has joined #openstack-nova | 08:15 | |
*** afazekas_ has joined #openstack-nova | 08:17 | |
*** sudipto has quit IRC | 08:22 | |
*** scheuran has joined #openstack-nova | 08:22 | |
*** sudipto has joined #openstack-nova | 08:22 | |
*** shuquan has quit IRC | 08:24 | |
*** ttrumm_ has joined #openstack-nova | 08:25 | |
*** atuvenie has joined #openstack-nova | 08:25 | |
*** shuquan has joined #openstack-nova | 08:25 | |
*** danpb has joined #openstack-nova | 08:26 | |
*** otter768 has joined #openstack-nova | 08:28 | |
*** shuquan has quit IRC | 08:28 | |
*** atuvenie has quit IRC | 08:29 | |
*** shuquan has joined #openstack-nova | 08:30 | |
*** ssurana has quit IRC | 08:32 | |
ankit_ag | ftersin_: hi .. | 08:33 |
*** otter768 has quit IRC | 08:33 | |
ftersin_ | hi there | 08:33 |
ankit_ag | ftersin_: want to discuss about review https://review.openstack.org/#/c/194063/ if you have some time | 08:34 |
ftersin_ | sure | 08:34 |
johnthetubaguy | deepakcs: that split looks better, sorry if it was not clear, but that is now hit by the feature exception freeze at this point, although that is one we debated quite a lot, its clearly important, there maybe a slim chance of bringing that back if we think its good now | 08:34 |
ankit_ag | you first concern is _delete destroys the instance with empty host locally | 08:34 |
deepakcs | johnthetubaguy: thanks for the update.. so you mean there will be one more round of discussions on that ? | 08:35 |
ankit_ag | now instance will be deleted localy from local_delete | 08:35 |
deepakcs | johnthetubaguy: also my bp is not really a feature, si it ? its more of improving existing feature :) | 08:35 |
ankit_ag | and the code which I have removed is duplicate of _local_delete | 08:35 |
ankit_ag | so there is no need to keep that in _delete method. | 08:36 |
*** gszasz has joined #openstack-nova | 08:36 | |
ankit_ag | 2. L1583: instance is refreshed and gets non empty host | 08:36 |
ankit_ag | It is handled in _local_delete now in my patch | 08:36 |
ankit_ag | 3. L1593: is_local_delete is evaluated as False | 08:37 |
ankit_ag | it is evaluted similar to the master code in my patch as well | 08:37 |
johnthetubaguy | deepakcs: possibly, I would love to get some reviews from cinder folks on there I guess, to make sure its what they expected, I am curious about if danpb if OK to take a quick look at that, and see how close we are now? | 08:37 |
ankit_ag | 4. L1614: delete operation is redirected to compute node | 08:37 |
ftersin_ | ankit_ag: you numer lines by master or your code? | 08:37 |
ankit_ag | these lines are from your comments on PS3 | 08:38 |
deepakcs | johnthetubaguy: sure from Cinder eharney can look ( He is in cinder mid-cycle meetup right now) and danpb had given a +1 to the objects patch (before u gave -2 :) ) | 08:38 |
ftersin_ | ankit_ag: give me a minute... | 08:39 |
ankit_ag | those are from master code | 08:39 |
ankit_ag | yes sure | 08:39 |
deepakcs | (The other patch in the series had +1 from others in the past) | 08:39 |
ftersin_ | ankit_ag: the difference is that in your patch is_local_delete is evaluated with empty host, but master code evaluates it after instance refresh, so its host is not empty | 08:40 |
*** ttrumm has joined #openstack-nova | 08:41 | |
ftersin_ | ankit_ag: when destroy is failed with the error, master code may redirect destroy to a compute node | 08:42 |
ftersin_ | ankit_ag: but your patch cannot | 08:42 |
ankit_ag | ftersin_: With my patch _local_delete will only be called if instance host is not set, so there is no need to redirect to compute node | 08:44 |
*** vivekd has joined #openstack-nova | 08:44 | |
ankit_ag | ftersin_: and if host is up and running is will redirect to compute node and terminate the instance | 08:44 |
*** markus_z has joined #openstack-nova | 08:44 | |
ankit_ag | ftersin_: in case when control is redirected to the compute node, it cleansup everything properly | 08:45 |
*** ttrumm_ has quit IRC | 08:45 | |
ankit_ag | ftersin_: The issue was only in case of deleting the instance locallu | 08:45 |
ankit_ag | locally | 08:45 |
johnthetubaguy | deepakcs: its a procedural -2, not a code review one, just to be clear | 08:46 |
ftersin_ | ankit_ag: but the reason of reverting your original patch is that when _delete starts, the instance has empty host | 08:46 |
johnthetubaguy | deepakcs: I probably missed the previous +1s, my bad | 08:46 |
ankit_ag | ftersin_: I have ran this pacth several times on jenkins successfully | 08:46 |
ftersin_ | ankit_ag: but it becomes not empty during execution | 08:46 |
ftersin_ | ankit_ag: so when you evaluates is_local_delete host field is empty | 08:47 |
ftersin_ | ankit_ag: but when you go to destroy the instance, host is no longer empty | 08:48 |
ankit_ag | ftersin_: Can you please help me to find a single case where this patch fails in actual scenario | 08:48 |
*** Vikas has quit IRC | 08:49 | |
ankit_ag | ftersin_: Even host is not empty it is cleaning up everything while destoying the instance | 08:49 |
deepakcs | johnthetubaguy: yes i know u said in the comment, no issues :) | 08:49 |
ankit_ag | ftersin_: I have verified host, network, volume, info_cache everything is cleaned up properly with this patch | 08:50 |
ftersin_ | ankit_ag: the scenario should be described in 998117 | 08:50 |
*** shuquan has quit IRC | 08:50 | |
ftersin_ | ankit_ag: i understand that now all your tests passes, but your patch deletes instance locally when it has not empty host, which was desided as an error by 998117 | 08:53 |
*** neelabh has joined #openstack-nova | 08:53 | |
*** shuquan has joined #openstack-nova | 08:53 | |
ftersin_ | ankit_ag: master code cathes the renewal of host and redirects the flow to compute node | 08:54 |
ankit_ag | ftersin_: What if compute service is down with master code | 08:54 |
ftersin_ | ankit_ag: it checks it when it evaluates is_local_delete | 08:55 |
ankit_ag | and based on that it decides to delete instance locally or to redirect to compute manager | 08:56 |
neelabh | Hey Guys, I want to use open-stack "nova-api" to make similar application in flask, So I do should I start.... | 08:56 |
ankit_ag | ftersin_: If we talk about the bug 998117 this is the code which has caused the issues I am trying to fix | 08:57 |
openstack | bug 998117 in OpenStack Compute (nova) "compute api delete race condition" [Undecided,Fix released] https://launchpad.net/bugs/998117 - Assigned to Mark Washenberger (markwash) | 08:57 |
ankit_ag | ftersin_: so we can not keep those changes | 08:58 |
*** shuquan has quit IRC | 08:58 | |
*** shuquan_ has joined #openstack-nova | 08:58 | |
ftersin_ | ankit_ag: that bug says that locally deleting of instance when it accures host value is an error | 08:59 |
*** vivekd has quit IRC | 09:00 | |
ftersin_ | ankit_ag: and to fix this error the exception was introduced and raised | 09:00 |
ankit_ag | ftersin_: OK let me check that host point and will come back to you | 09:00 |
ankit_ag | ftersin_: Thank you | 09:01 |
ftersin_ | ankit_ag: and this exception handler redirects deleting to compute node | 09:01 |
*** vivekd has joined #openstack-nova | 09:02 | |
*** vivekd_ has joined #openstack-nova | 09:02 | |
johnthetubaguy | neelabh: I would read the API docs: http://developer.openstack.org/ but Nova is only going to let you start VMs, I don't think its what you are looking for, but this is more a conversation for #openstack as they have folks on there to help with usage questions, this is a development focused channel | 09:02 |
ftersin_ | ankit_ag: so i think if now there is no objections to locally delete an instance in such conditions, it's better to remove the excetion at all, instead of re-run instance.destroy | 09:05 |
*** vivekd has quit IRC | 09:06 | |
*** vivekd_ is now known as vivekd | 09:06 | |
*** lucasagomes has joined #openstack-nova | 09:06 | |
ankit_ag | ftersin_: There is still that exception is raised in race condition due to which my original patch got reverted. After analysing the every possible race conditions I came to the conclusion to add that exception back | 09:07 |
*** shuquan_ has quit IRC | 09:10 | |
ftersin_ | ankit_ag: what do you mean? did you already think to remove that exception at all, but decided to leave it? | 09:10 |
ftersin_ | ankit_ag: i mean that the exception is raised to catch certain condition to do rediredt | 09:11 |
ankit_ag | ftersin_: Yes in my original patch I had removed that exception which was causing issues in race condition | 09:12 |
ftersin_ | ankit_ag: if you do not do redirection in this condition, you do not need this exception at all | 09:12 |
ftersin_ | ankit_ag: could you please give me a link? | 09:12 |
ankit_ag | ftersin_: sure, give me a min please | 09:13 |
ankit_ag | ftersin_: https://review.openstack.org/#/c/145738/ | 09:14 |
*** humble__ has joined #openstack-nova | 09:16 | |
ftersin_ | ankit_ag: in which patchset you tryed to remove ObjectActionError exception? | 09:16 |
*** vivekd_ has joined #openstack-nova | 09:17 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs: Add project id information in os-server-group API https://review.openstack.org/209917 | 09:17 |
ftersin_ | ankit_ag: probably we talk about different exceptions? I talk about ObjectActionError | 09:17 |
ftersin_ | ankit_ag: sorry, not about it... | 09:18 |
*** schwicke has quit IRC | 09:18 | |
ankit_ag | ftersin_: we are talking about ObjectActionError ? | 09:18 |
ftersin_ | ankit_ag: ConstraintNotMet | 09:19 |
*** wanghua has quit IRC | 09:19 | |
ankit_ag | ftersin_: Yes ObjectActionError exception is caught in case of ConstraintNotMet exception is raised | 09:20 |
ftersin_ | ankit_ag: it was introduced to catch the race to redirect to compute node | 09:20 |
*** vivekd has quit IRC | 09:21 | |
*** vivekd_ is now known as vivekd | 09:21 | |
ftersin_ | ankit_ag: so if you do not redirect there in the race condition, why we should keep this exception? | 09:21 |
ankit_ag | ftersin_: in master code ConstraintNotMet is moved down the flow of instance.destroy and raised ObjectActionError from there | 09:21 |
ankit_ag | ftersin_: If you see my original patch https://review.openstack.org/#/c/145738/, I had removed this exception but it caused race condition and got reverted | 09:23 |
ftersin_ | ankit_ag: but what the value of this exception? why instance object and db level catch this condition and raise the exception? | 09:23 |
ftersin_ | ankit_ag: in you previous patch you removed handling of this exception, right? or i miss something? | 09:24 |
ankit_ag | ftersin_: yes in my previos patch I had removed that | 09:26 |
ftersin_ | ankit_ag: as i understand, this exception is raised specially to catch them in _delete to redirect deletion to compute node | 09:26 |
ankit_ag | ftersin_: The exception was caught to handle the condition raised from https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L1693 while destoying the instance | 09:28 |
*** humble_ has quit IRC | 09:28 | |
ankit_ag | ftersin_: This is when instance is not found while callinf instance.destroy | 09:29 |
ankit_ag | ftersin_: so after catching that exception its the _delete api task to decide how can we cleanup the environment. | 09:30 |
ftersin_ | ankit_ag: not really. The instance is not found with a condition. The condition is host=None | 09:30 |
ftersin_ | ankit_ag: Why this condition is added? | 09:31 |
openstackgerrit | Tomi Juvonen proposed openstack/nova-specs: Get valid server state https://review.openstack.org/192246 | 09:31 |
ftersin_ | ankit_ag: It is added to catch the race condition when compute node just set host field, but api node does not know about it | 09:32 |
*** markvoelker has joined #openstack-nova | 09:33 | |
ankit_ag | ftersin_: Or may be the case host has been deleted by another thread | 09:34 |
ftersin_ | ankit_ag: Why this race condition is important, why code catches it? The only handling of it - is redirection to compute node | 09:34 |
neelabh | I am trying to create the nova client "nova=client.Client(2, 'admin', '1234', 'admin', 'http://10.0.2.15:5000')" But getting error =>novaclient.exceptions.ClientException: Unknown Error (HTTP 300) | 09:35 |
ftersin_ | ankit_ag: i digged the history and found that it was added to catch the same race | 09:35 |
ftersin_ | ankit_ag: see https://review.openstack.org/#/c/7345/ | 09:36 |
*** markvoelker has quit IRC | 09:37 | |
ankit_ag | ftersin_: OK I'll test my patch against this race and will come back to you | 09:38 |
ankit_ag | ftersin_: Thanks again for your time and help | 09:38 |
ftersin_ | ankit_ag: what if you tests will not find an error? | 09:39 |
ftersin_ | ankit_ag: your | 09:39 |
*** shuquan has joined #openstack-nova | 09:39 | |
*** vivekd has quit IRC | 09:40 | |
*** vivekd has joined #openstack-nova | 09:41 | |
ankit_ag | ftersin_: Then I think there should be no issues in merging the pacth as it is :) | 09:42 |
*** IanGovett has joined #openstack-nova | 09:45 | |
ftersin_ | ankit_ag: But since we do not know what was a reason of 998117, we can not perform an approppriate test, so we can not be sure that 998117 will not return | 09:45 |
*** vivekd_ has joined #openstack-nova | 09:46 | |
*** humble__ has quit IRC | 09:47 | |
*** vivekd has quit IRC | 09:48 | |
ankit_ag | ftersin_: If there would have been any race with this patch then IMO jenking would have been failed atleast once on this patch | 09:48 |
*** vivekd_ is now known as vivekd | 09:48 | |
ankit_ag | ftersin_: I have tried running jenkins successfully a number of time before submitting this patch | 09:48 |
*** vivekd_ has joined #openstack-nova | 09:49 | |
*** alexschm has quit IRC | 09:50 | |
ftersin_ | ankit_ag: on the other hand, if we're sure that 998117 will not return with you patch which doesn't redirect to compute node, why do we need constraint arg in db.instance_destroy which is intended to redirect destruction to compute node? | 09:51 |
*** vivekd__ has joined #openstack-nova | 09:53 | |
*** vivekd has quit IRC | 09:53 | |
*** vivekd__ is now known as vivekd | 09:53 | |
neelabh | aarefiev: Hi | 09:54 |
*** dims_ has joined #openstack-nova | 09:54 | |
ankit_ag | ftersin_: we'll need to catch that exception to give another change to destroy instance. In a case when instance is deleted by another thread or api while the main thread is in db.instance_destroy call. | 09:54 |
*** sakaYK has quit IRC | 09:54 | |
ankit_ag | ftersin_: If that happens we'll need to set database and to clean bdm and network info | 09:55 |
*** echoingu_ has quit IRC | 09:56 | |
*** echoingumesh has joined #openstack-nova | 09:57 | |
*** vivekd_ has quit IRC | 09:57 | |
*** apuimedo has joined #openstack-nova | 09:57 | |
ftersin_ | ankit_ag: but instance.refresh() fails if the instance is deleted, does not? | 09:59 |
*** ttrumm has quit IRC | 09:59 | |
*** marzif has joined #openstack-nova | 09:59 | |
ankit_ag | ftersin_: No, instance.refresh() fails if we have deleted instance info_cache | 10:00 |
ankit_ag | but not the instance | 10:00 |
mdbooth | I saw some discussion yesterday about segfaults in the gate running unit tests | 10:00 |
mdbooth | Looks like one of my patches just hit that, so I'm wondering if anybody has a status | 10:00 |
*** echoingumesh has quit IRC | 10:01 | |
mdbooth | Shortcutting Jenkins on first failure would be really useful. I'm sure this has come up before. Does anybody know why we don't do it? | 10:04 |
*** alexschm has joined #openstack-nova | 10:04 | |
johnthetubaguy | mdbooth: I think mriedem opened a bug for that, it should be in the nova-meeting log, if that helps | 10:05 |
*** p01s0n has joined #openstack-nova | 10:05 | |
johnthetubaguy | mdbooth: I think its to avoid it taking several rounds to spot you fail the last test, and its a valid failure, but I can't say I have debated that with infra myself | 10:06 |
ftersin_ | ankit_ag: it calls db.instance_get_by_uuid which calls db._build_instance_get which calls model_query with no read_deleted=True. So i think db.instance_get_by_uuid raises InstanceNotFound for a deleted instance | 10:06 |
*** shuquan has quit IRC | 10:06 | |
p01s0n | is there any way to have different allocation ratio for each availability zones .First AZ with default ram/cpu allocation and another with high over provisioning or no over provisioning | 10:07 |
mdbooth | johnthetubaguy: Thanks | 10:07 |
*** kmARC_ has joined #openstack-nova | 10:08 | |
*** kmARC has joined #openstack-nova | 10:08 | |
mdbooth | It's https://bugs.launchpad.net/nova/+bug/1482230 | 10:09 |
openstack | Launchpad bug 1482230 in OpenStack Compute (nova) "LibvirtConnTestCase.test_clean_shutdown_first_time segfaults" [High,In progress] - Assigned to Matt Riedemann (mriedem) | 10:09 |
*** mpaolino has joined #openstack-nova | 10:10 | |
ankit_ag | ftersin_: For that case InstanceNotFound exception is handled by _delete method https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1635 | 10:11 |
*** mestery_ has joined #openstack-nova | 10:11 | |
mdbooth | ftersin_: Hey, regarding the image checks thing, I'm going to move some code around anyway, despite what I said yesterday | 10:12 |
mdbooth | Reason is, even to reliably know that you don't need to do the tests, you need to know the type of the root device | 10:12 |
mdbooth | And given the byzantine possibilities, it seems silly to work that out twice | 10:13 |
mdbooth | Haven't yet decided whether to do the min_disk test, but if it falls out of the code move relatively easily then I'll do it | 10:14 |
mdbooth | Because it's much nicer to the user | 10:14 |
*** Vek has quit IRC | 10:14 | |
*** mestery has quit IRC | 10:15 | |
*** masayukig has quit IRC | 10:15 | |
*** dansmith has quit IRC | 10:15 | |
ftersin_ | ankit_ag: ok, but why to call instance.refresh() if it raises this error? | 10:16 |
*** loquacities has quit IRC | 10:16 | |
*** apuimedo has quit IRC | 10:17 | |
*** apuimedo has joined #openstack-nova | 10:17 | |
*** dansmith has joined #openstack-nova | 10:17 | |
*** dansmith is now known as Guest45541 | 10:17 | |
*** masayukig has joined #openstack-nova | 10:18 | |
*** nikhil_k has quit IRC | 10:18 | |
ankit_ag | ftersin_: That is not always true, sometimes we need to call instance.refresh to destroy the instance successfully | 10:18 |
*** dosaboy has quit IRC | 10:18 | |
*** nikhil_k has joined #openstack-nova | 10:18 | |
*** dosaboy has joined #openstack-nova | 10:19 | |
*** jistr has quit IRC | 10:20 | |
*** bradjones has quit IRC | 10:20 | |
*** ttrumm has joined #openstack-nova | 10:20 | |
*** beagles has quit IRC | 10:20 | |
*** jistr has joined #openstack-nova | 10:20 | |
ftersin_ | jmdbooth: hi, i agree that user experience is awful now.with that pended test | 10:21 |
*** jeblair has quit IRC | 10:21 | |
*** pixelbeat has joined #openstack-nova | 10:21 | |
*** loquacities has joined #openstack-nova | 10:22 | |
*** jeblair has joined #openstack-nova | 10:22 | |
ftersin_ | jmdbooth: but it's also good to check not only root bdm parameter, but also other bdms, since thay can also request volumes from images | 10:24 |
ftersin_ | mdbooth: sorry, missed in your nick ^^^^^ | 10:25 |
mdbooth | ftersin_: I would have to work out what that means | 10:25 |
*** shyu has quit IRC | 10:27 | |
mdbooth | ftersin_: To have that make sense, you'd have to reduce over all bdms with image metadata and take the max of any non-disk requirements you're going to test | 10:27 |
mdbooth | I'm not going there today :) | 10:28 |
mdbooth | I think robustly checking the root disk is a reasonable goal | 10:28 |
mdbooth | This is a can of works | 10:28 |
*** zhenguo has quit IRC | 10:28 | |
mdbooth | s/works/worms/ | 10:28 |
*** otter768 has joined #openstack-nova | 10:29 | |
mdbooth | Yeah, testing image metadata other than for the boot disk would be a change of behaviour | 10:29 |
mdbooth | I've been burned by that already, so I'd be inclined to do it very carefully. Probably run it past operators first to see if anybody is actually doing that, and if it would break them. | 10:30 |
*** bradjones_ has joined #openstack-nova | 10:30 | |
*** mjturek1 has quit IRC | 10:30 | |
*** bradjones_ is now known as bradjones | 10:30 | |
*** mpaolino has quit IRC | 10:31 | |
*** mpaolino has joined #openstack-nova | 10:31 | |
*** tsbot_ has quit IRC | 10:33 | |
*** b3nt_pin_ has joined #openstack-nova | 10:34 | |
*** ttrumm_ has joined #openstack-nova | 10:34 | |
*** otter768 has quit IRC | 10:34 | |
*** baoli has joined #openstack-nova | 10:35 | |
*** ttrumm has quit IRC | 10:36 | |
ftersin_ | mdbooth: compute.api's _validate_bdm is the best place for me to test that | 10:37 |
mdbooth | I looked there. It hasn't finished messing with it at that point | 10:37 |
mdbooth | After _check_and_transform_bdm looks the most robust | 10:38 |
mdbooth | And no resources have been allocated up to that point in the function | 10:38 |
*** josecastroleon has quit IRC | 10:38 | |
mdbooth | So failing later should make no material difference | 10:38 |
ftersin_ | mdbooth: _validate_bdm gets all parts of the bdm, incliding image | 10:39 |
mdbooth | Are you sure? | 10:39 |
*** vivekd_ has joined #openstack-nova | 10:39 | |
*** baoli has quit IRC | 10:39 | |
mdbooth | Looks to me like that doesn't happen until _check_and_transform | 10:39 |
mdbooth | See image_defined_bdms | 10:39 |
mdbooth | Also, after _check_and_transform they have been converted to object format | 10:40 |
mdbooth | So you don't have to worry about legacy format | 10:40 |
*** vivekd__ has joined #openstack-nova | 10:43 | |
ftersin_ | mdbooth: it's called from _provision_instances, this is the last stage of preparation work on api node | 10:44 |
mdbooth | ftersin_: I think we're looking at different code | 10:44 |
ftersin_ | mdbooth: all bdm are converted there, user defined and image definde bdms are merged | 10:44 |
*** bradjones has quit IRC | 10:45 | |
*** vivekd has quit IRC | 10:45 | |
*** chhavi has quit IRC | 10:45 | |
*** kiran-r has quit IRC | 10:45 | |
*** alex_klimov has quit IRC | 10:45 | |
*** shihanzhang has quit IRC | 10:45 | |
*** ishant has quit IRC | 10:45 | |
*** hshiina has quit IRC | 10:45 | |
*** harlowja has quit IRC | 10:45 | |
*** mtreinish has quit IRC | 10:45 | |
*** krtaylor has quit IRC | 10:45 | |
*** openstackgerrit has quit IRC | 10:45 | |
*** HenryG has quit IRC | 10:45 | |
*** tobasco has quit IRC | 10:45 | |
*** _gryf has quit IRC | 10:45 | |
*** ccesario has quit IRC | 10:45 | |
*** sdague has quit IRC | 10:45 | |
*** aignatov has quit IRC | 10:45 | |
*** _cerberus_ has quit IRC | 10:45 | |
*** leseb has quit IRC | 10:45 | |
*** danieru has quit IRC | 10:45 | |
*** raginbajin has quit IRC | 10:45 | |
*** dhellmann has quit IRC | 10:45 | |
*** s1rp_ has quit IRC | 10:45 | |
*** thomasem has quit IRC | 10:45 | |
*** vivekd__ is now known as vivekd | 10:45 | |
gmann | alex_xu: hi | 10:45 |
mdbooth | ftersin_: You definitely want to do the check before _provision_instances | 10:45 |
ftersin_ | mdbooth: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1248 | 10:45 |
*** alexschm has quit IRC | 10:46 | |
gmann | alex_xu: I would not be able to join today meeting due to some personal work. I added bug spec in agenda just to ask review on that. | 10:46 |
*** tsbot_ has joined #openstack-nova | 10:46 | |
*** ttrumm_ has quit IRC | 10:46 | |
gmann | alex_xu: sorry for not attending meeting. | 10:47 |
mdbooth | ftersin_: Eesh, that's a mess | 10:47 |
*** vivekd_ has quit IRC | 10:47 | |
mdbooth | That's wrong. I'm not putting checks there :) | 10:47 |
mdbooth | We can fix the existing code another time. | 10:47 |
mdbooth | Perhaps that's what you were referring to? | 10:48 |
*** rotbeard has joined #openstack-nova | 10:48 | |
*** mjturek1 has joined #openstack-nova | 10:49 | |
*** bradjones has joined #openstack-nova | 10:49 | |
*** chhavi has joined #openstack-nova | 10:49 | |
*** kiran-r has joined #openstack-nova | 10:49 | |
*** alex_klimov has joined #openstack-nova | 10:49 | |
*** shihanzhang has joined #openstack-nova | 10:49 | |
*** ishant has joined #openstack-nova | 10:49 | |
*** hshiina has joined #openstack-nova | 10:49 | |
*** harlowja has joined #openstack-nova | 10:49 | |
*** mtreinish has joined #openstack-nova | 10:49 | |
*** krtaylor has joined #openstack-nova | 10:49 | |
*** openstackgerrit has joined #openstack-nova | 10:49 | |
*** HenryG has joined #openstack-nova | 10:49 | |
*** tobasco has joined #openstack-nova | 10:49 | |
*** ccesario has joined #openstack-nova | 10:49 | |
*** _gryf has joined #openstack-nova | 10:49 | |
*** sdague has joined #openstack-nova | 10:49 | |
*** aignatov has joined #openstack-nova | 10:49 | |
*** _cerberus_ has joined #openstack-nova | 10:49 | |
*** leseb has joined #openstack-nova | 10:49 | |
*** danieru has joined #openstack-nova | 10:49 | |
*** raginbajin has joined #openstack-nova | 10:49 | |
*** dhellmann has joined #openstack-nova | 10:49 | |
*** s1rp_ has joined #openstack-nova | 10:49 | |
*** thomasem has joined #openstack-nova | 10:49 | |
*** bradjones has quit IRC | 10:49 | |
*** mjturek1 has quit IRC | 10:49 | |
*** mjturek1 has joined #openstack-nova | 10:49 | |
*** bradjones has joined #openstack-nova | 10:49 | |
*** bradjones has quit IRC | 10:49 | |
*** bradjones has joined #openstack-nova | 10:49 | |
openstackgerrit | Marian Horban proposed openstack/nova: Added processing /compute URL https://review.openstack.org/195303 | 10:49 |
ftersin_ | ankit_ag: sorry for the pause. Sometimes - when exactly? I know the only reason - it is ConstraintNotMet exception. instance.refresh was added to _delete to honour this exception exactly. | 10:50 |
openstackgerrit | Marian Horban proposed openstack/nova: Added processing /compute URL https://review.openstack.org/195303 | 10:51 |
ftersin_ | mdbooth: as i remember ndipanov wanted to move _validate_bdm outside of create_db_entry_for_new_instance | 10:53 |
ftersin_ | mdbooth: the reason it stays there is races in attachment checks | 10:54 |
*** armax has quit IRC | 10:54 | |
mdbooth | I was just looking at those | 10:54 |
ftersin_ | mdbooth: but of course, it contains a lot of static checks, which can be performed early | 10:55 |
mdbooth | So we actually pass instance to check_attach | 10:55 |
mdbooth | That's unfortunate, because it seems all it needs to check is an availability zone | 10:55 |
*** armax has joined #openstack-nova | 10:55 | |
mdbooth | ftersin_: Do you know what races? | 10:56 |
mdbooth | The volume can obviously be claimed by something else before it gets to the compute host | 10:57 |
*** echoingumesh has joined #openstack-nova | 10:57 | |
*** mpaolino has quit IRC | 10:58 | |
*** alexschm has joined #openstack-nova | 10:58 | |
ftersin_ | mdbooth: https://review.openstack.org/#/c/95394/ | 10:58 |
*** Piet has quit IRC | 10:58 | |
*** kmARC has quit IRC | 11:00 | |
nagyz_ | danpb, around? | 11:00 |
*** dan has quit IRC | 11:00 | |
*** kylek3h has joined #openstack-nova | 11:00 | |
*** sahid has quit IRC | 11:00 | |
mdbooth | ftersin_: That's exactly the feedback I was looking for, thanks. | 11:01 |
*** kmARC_ has quit IRC | 11:01 | |
*** sahid has joined #openstack-nova | 11:01 | |
*** echoingumesh has quit IRC | 11:02 | |
*** dan has joined #openstack-nova | 11:03 | |
ftersin_ | mdbooth: see there my suggestion on PS3 and ndipanov's response on PS5 | 11:03 |
mdbooth | Yeah, read that | 11:03 |
*** xottabich has joined #openstack-nova | 11:04 | |
*** vivekd has quit IRC | 11:04 | |
*** kylek3h has quit IRC | 11:05 | |
*** kylek3h has joined #openstack-nova | 11:05 | |
*** kmARC_ has joined #openstack-nova | 11:05 | |
danpb | nagyz_: ? | 11:05 |
*** kmARC has joined #openstack-nova | 11:05 | |
nagyz_ | danpb, can we discuss the rbd encryption patch from https://review.openstack.org/#/c/206576/ ? | 11:08 |
*** kylek3h has quit IRC | 11:08 | |
*** jaypipes is now known as leakypipes | 11:11 | |
*** tojuvone has quit IRC | 11:12 | |
danpb | nagyz_: i saw your comments, but i still consider this a feature | 11:12 |
danpb | the original crypt code was design for drivers which have a device exposed in the filesystem | 11:13 |
danpb | so supporting anything else is a feature enhancement for which we should review the design options | 11:13 |
nagyz_ | which none of them had except iSCSI | 11:13 |
nagyz_ | as it was (is?) broken for FC as well | 11:13 |
danpb | as your change is switching rbd to use the host driver, instead of the direct qemu connection, which is a significant enough change to warrant review | 11:14 |
nagyz_ | no, it's not switching it | 11:14 |
nagyz_ | at least not for the current use cases | 11:14 |
nagyz_ | the switch only occures if someone is using encryption; else it just falls back for the current implementation | 11:14 |
danpb | that's still a significant change in architecture | 11:15 |
danpb | because there are now 2 completely different RBD code paths in play | 11:15 |
danpb | that's not something we're going to do as a bug fix | 11:15 |
*** lucasagomes is now known as lucas-hungry | 11:15 | |
nagyz_ | then we just have to agree to disagree | 11:15 |
ftersin_ | ankit_ag: i have to go out now. i'll think over your arguments. now i think i was not clear in my concern explanation. i'll think over all again and write something in your review | 11:16 |
nagyz_ | so you'd rather ship something that's completely broken in L than have an 8 line fix included? | 11:16 |
nagyz_ | in M everything is moving to os-brick anyway | 11:16 |
nagyz_ | so basically the nova part will be gone | 11:16 |
danpb | os-brick can't magically solve this | 11:16 |
danpb | because the RBD client is in QEMU | 11:16 |
danpb | os-brick can't alter that fact | 11:16 |
ankit_ag | ftersin_: sorry I was not on my desk. | 11:17 |
ankit_ag | ftersin_: I will also looks into the scenario of ConstraintNotMet exception and will check what may be the possible issue. | 11:18 |
ankit_ag | ftersin_: Thank you | 11:18 |
*** kmARC has quit IRC | 11:18 | |
nagyz_ | danpb, IIRC you were here when we were discussing this numerous times before the spec freeze and you haven't objected to it back then. I'd really like to get this into L instead of rolling it into our own tree | 11:19 |
*** kylek3h has joined #openstack-nova | 11:19 | |
*** kmARC_ has quit IRC | 11:20 | |
danpb | nagyz_: discussing problems is not the same as agreeing to implement them in a particular release | 11:21 |
*** smatzek has joined #openstack-nova | 11:22 | |
nagyz_ | I specifically asked here if it could be considered a bug fix thus not need a spec and the consensus seemed to be a yes :( | 11:22 |
danpb | and in the discussions my focus was on ensuring we have suitable error reporting in the case where encryption is not supported | 11:22 |
danpb | so that we dont silently ignore the request | 11:22 |
nagyz_ | the only thing that encryption works today AFAIK is iSCSI (maybe FC) | 11:23 |
nagyz_ | *with | 11:23 |
*** baoli has joined #openstack-nova | 11:24 | |
*** baoli has quit IRC | 11:24 | |
*** baoli has joined #openstack-nova | 11:26 | |
*** baoli has quit IRC | 11:26 | |
openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: don't open connection in driver constructor https://review.openstack.org/210334 | 11:26 |
*** baoli has joined #openstack-nova | 11:27 | |
*** yassine_ has quit IRC | 11:28 | |
*** b3nt_pin_ is now known as b3nt_pin | 11:28 | |
*** b3nt_pin is now known as Guest3973 | 11:29 | |
leakypipes | danpb: morning Dan. I have a refactor/cleanup series for PCI stuff here: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:pci-cleanup,n,z. Would love some reviews if you have a chance. thx in advance :) | 11:30 |
danpb | leakypipes: is it intended for Lemming ? | 11:31 |
leakypipes | danpb: yeah. no bp or bug though... it's cleanup stuff. should I submit a bug for it? | 11:32 |
danpb | lemme see what the codes like :-) | 11:33 |
leakypipes | danpb: I'm trying to clean this stuff up to make the resource-objects work (which is priority scheduler stuff) easier to consume and review. | 11:33 |
leakypipes | danpb: of course, no worries :) | 11:33 |
leakypipes | thx for even looking! | 11:33 |
danpb | right, so if its related to the schedular priority, i don't think cleanups need bugs | 11:33 |
* danpb hopes that https://review.openstack.org/#/c/210334/ will fix the gate crashiness | 11:34 | |
*** markvoelker has joined #openstack-nova | 11:34 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Support keystone /v3 API url in [neutron]admin_auth_url https://review.openstack.org/209599 | 11:34 |
*** rdopiera has quit IRC | 11:35 | |
*** haomaiwa_ has quit IRC | 11:37 | |
*** haomaiwa_ has joined #openstack-nova | 11:38 | |
*** markvoelker has quit IRC | 11:39 | |
*** chhavi has quit IRC | 11:39 | |
*** thorst has joined #openstack-nova | 11:40 | |
*** jcoufal has quit IRC | 11:40 | |
*** santosh has joined #openstack-nova | 11:41 | |
santosh | Hi All | 11:41 |
santosh | I am facing following problem while restarting nova network at RHEL openstack 6.0 setup | 11:41 |
*** p01s0n has quit IRC | 11:42 | |
santosh | Anyone using RHEL openstack? | 11:43 |
*** josecastroleon has joined #openstack-nova | 11:44 | |
leakypipes | santosh: pls see /topic :) | 11:45 |
*** eliqiao1 has joined #openstack-nova | 11:46 | |
leakypipes | danpb: reviewed 210334. | 11:47 |
eliqiao1 | hi johnthetubaguy | 11:47 |
johnthetubaguy | eliqiao1: hello | 11:47 |
*** ttrumm has joined #openstack-nova | 11:47 | |
eliqiao1 | johnthetubaguy: nice, you are here, alex_xu is not blocking by a heavy rain on his way home, so he can not help to host the nova-api meeting | 11:48 |
*** dprince has joined #openstack-nova | 11:49 | |
*** sudipto_ has joined #openstack-nova | 11:49 | |
eliqiao1 | johnthetubaguy: he's ask if you or sdague can help to host it ? or would you like to cancel it ? | 11:49 |
johnthetubaguy | eliqiao1: I can start it off, lets see who is around I guess | 11:49 |
sdague | yeh, I'm around. Need more coffee though. | 11:50 |
eliqiao1 | johnthetubaguy: okay , cool, thank you | 11:50 |
*** sudipto has quit IRC | 11:51 | |
sdague | danpb: thanks for digging in on that gate break, looks good | 11:51 |
*** chhavi has joined #openstack-nova | 11:51 | |
danpb | sdague: NB, i've no idea if this will fix it, but its worth a punt | 11:52 |
danpb | if this fails, then i guess we should just try reverting the multiqueue patch entirely to confirm it as the cause | 11:52 |
*** sudipto__ has joined #openstack-nova | 11:54 | |
*** ttrumm has quit IRC | 11:54 | |
*** Guest3973 is now known as beagles | 11:56 | |
*** sudipto_ has quit IRC | 11:56 | |
*** santosh has quit IRC | 11:58 | |
*** echoingumesh has joined #openstack-nova | 11:58 | |
mdbooth | ftersin_ ndipanov: Why don't we check_attach a snapshot? | 12:00 |
leakypipes | danpb: guh, looks like a search/replace goof in the unit tests for that patch. thanks for the catch. will push a new rev shortly. | 12:03 |
*** ttrumm has joined #openstack-nova | 12:04 | |
mdbooth | danpb: I know you -2d mriedem's patch, but I'm pretty sure that mock is a no-op anyway, right? | 12:07 |
*** echoingumesh has quit IRC | 12:07 | |
mdbooth | That just creates a context manager, and then throws it away, surely | 12:07 |
mdbooth | Without ever doing anything with it | 12:07 |
mdbooth | So it should probably come out anyway, because it's confusing | 12:08 |
*** raildo has joined #openstack-nova | 12:08 | |
mdbooth | For reference: https://review.openstack.org/#/c/210036/1/nova/tests/unit/virt/libvirt/test_driver.py,cm | 12:08 |
danpb | mdbooth: yep, but my patch kills that and more | 12:08 |
mdbooth | Ah, ok | 12:09 |
danpb | i just reverted all the changes to that test suite | 12:09 |
danpb | instead of just that 1 line | 12:09 |
*** MVenesio has joined #openstack-nova | 12:09 | |
*** ishant has quit IRC | 12:10 | |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: api: add soft-affinity policies for server groups https://review.openstack.org/147520 | 12:10 |
openstackgerrit | Ildiko Vancsa proposed openstack/nova: Add functional tests to soft affinity capabilities https://review.openstack.org/147521 | 12:10 |
*** ttrumm_ has joined #openstack-nova | 12:12 | |
*** Vek has joined #openstack-nova | 12:13 | |
openstackgerrit | Roman Bogorodskiy proposed openstack/nova: Skip SO_REUSEADDR tests on BSD https://review.openstack.org/191522 | 12:13 |
*** dave-mccowan has quit IRC | 12:13 | |
*** ttrumm has quit IRC | 12:15 | |
*** deepakcs has quit IRC | 12:15 | |
*** jcoufal has joined #openstack-nova | 12:18 | |
mdbooth | danpb: Have you noticed the pep8 failure in the libvirt patch, btw? | 12:19 |
*** GeraldK has joined #openstack-nova | 12:19 | |
mdbooth | ./nova/tests/unit/virt/libvirt/test_vif.py:32:1: H306 imports not in alphabetical order (nova.virt.libvirt.vif, nova.virt.libvirt.host) | 12:20 |
danpb | oh dog damn it | 12:20 |
*** tojuvone has joined #openstack-nova | 12:21 | |
openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: don't open connection in driver constructor https://review.openstack.org/210334 | 12:22 |
*** lxsli is now known as lexloofah | 12:22 | |
openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: don't open connection in driver constructor https://review.openstack.org/210334 | 12:23 |
*** lucas-hungry is now known as lucasagomes | 12:24 | |
dims_ | nova cores, updated quick hit bugs list - https://etherpad.openstack.org/p/liberty-nova-priorities-tracking | 12:28 |
dims_ | leakypipes: sdague: danpb: ^^^ | 12:29 |
*** moshele has joined #openstack-nova | 12:29 | |
*** scheuran has quit IRC | 12:29 | |
*** markvoelker has joined #openstack-nova | 12:29 | |
*** otter768 has joined #openstack-nova | 12:30 | |
*** yassine_ has joined #openstack-nova | 12:31 | |
openstackgerrit | Dmitry Tantsur proposed openstack/nova: Use ironicclient native retries https://review.openstack.org/210369 | 12:31 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Add api samples impact to microversion devref https://review.openstack.org/210370 | 12:31 |
*** dims_ has quit IRC | 12:33 | |
*** dims_ has joined #openstack-nova | 12:34 | |
*** otter768 has quit IRC | 12:35 | |
*** afazekas_ has quit IRC | 12:36 | |
*** tongli has joined #openstack-nova | 12:38 | |
*** rdopiera has joined #openstack-nova | 12:38 | |
*** rdopiera has quit IRC | 12:39 | |
*** rdopiera has joined #openstack-nova | 12:39 | |
*** bapalm has joined #openstack-nova | 12:39 | |
openstackgerrit | Hans Lindgren proposed openstack/nova: Remove/deprecate unused parts of the compute node object https://review.openstack.org/186757 | 12:41 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Make ComputeNode.service_id nullable to match db schema https://review.openstack.org/169284 | 12:41 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Avoid querying for Service in resource tracker https://review.openstack.org/169288 | 12:43 |
*** rdopiera has quit IRC | 12:46 | |
*** aysyd has joined #openstack-nova | 12:46 | |
openstackgerrit | Dmitry Tantsur proposed openstack/nova: Ironic: Use ironicclient native retries in ClientWrapper https://review.openstack.org/210369 | 12:47 |
*** rdopiera has joined #openstack-nova | 12:48 | |
*** chuckcarmack has joined #openstack-nova | 12:51 | |
*** claudiub has joined #openstack-nova | 12:53 | |
*** hshiina has quit IRC | 12:54 | |
*** rfolco has joined #openstack-nova | 12:58 | |
*** zzzeek has joined #openstack-nova | 12:59 | |
*** tojuvone has quit IRC | 12:59 | |
*** claudiub has quit IRC | 13:01 | |
*** ctrath has joined #openstack-nova | 13:02 | |
sdague | johnthetubaguy: so can you explain that last bit just for context | 13:02 |
sdague | <johnthetubaguy> so the history there is, when downloading and uploading, its nice not to have a loadbalancer in the way | 13:02 |
sdague | <johnthetubaguy> at least, thats why I care about it | 13:02 |
sdague | because, the only large data flow through nova would be the image proxy, right? | 13:03 |
sdague | which we're kind of telling people not to use | 13:03 |
johnthetubaguy | well, how do you avoid using it? | 13:03 |
*** rushil has joined #openstack-nova | 13:03 | |
johnthetubaguy | when you have swift as your backend | 13:04 |
johnthetubaguy | I could be missing something | 13:04 |
*** kiran-r has quit IRC | 13:04 | |
*** dustins has joined #openstack-nova | 13:05 | |
*** echoingumesh has joined #openstack-nova | 13:05 | |
*** rlrossit has joined #openstack-nova | 13:05 | |
openstackgerrit | Hans Lindgren proposed openstack/nova: Add a VolumeUsage object https://review.openstack.org/180442 | 13:08 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Replace conductor proxying calls with the new VolumeUsage object https://review.openstack.org/180443 | 13:08 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Remove and deprecate unused conductor method vol_usage_update() https://review.openstack.org/180444 | 13:08 |
*** ctrath has quit IRC | 13:09 | |
sdague | johnthetubaguy: ok, so maybe I'm missing a bit of the flow | 13:09 |
*** eliqiao1 has quit IRC | 13:09 | |
sdague | because if we create a server, POST /v2/{tenant_id}/servers ... not a lot of data anywhere there | 13:10 |
johnthetubaguy | sdague: its the upload and download to swift, that still goes through glance (i wish it didn't, but thats another conversation) | 13:10 |
sdague | nova ends up making calls to glance | 13:10 |
johnthetubaguy | yeah | 13:10 |
johnthetubaguy | sends the disk image to/from glance | 13:10 |
sdague | but that's glance's SC entry | 13:10 |
sdague | not nova's | 13:10 |
*** echoingumesh has quit IRC | 13:10 | |
sdague | GET glance/v2/.... | 13:10 |
*** logan2 has quit IRC | 13:11 | |
sdague | from nova | 13:11 |
johnthetubaguy | its more POST glance/v1 <chunked upload of image> | 13:11 |
sdague | sure | 13:11 |
sdague | but, the important thing is that the sharding you care about is in glance | 13:11 |
sdague | not in nova | 13:11 |
johnthetubaguy | (so that v1 shouldn't be exposed to end users, and should only be exposed to nova) | 13:12 |
johnthetubaguy | well, what we have right now is a list of servers to randomly pick from | 13:12 |
johnthetubaguy | to distribute the load between glance API boxes | 13:12 |
johnthetubaguy | if its down, it just tries the next one | 13:12 |
sdague | right, which is about glance's service catalog entries | 13:12 |
*** logan2 has joined #openstack-nova | 13:12 | |
johnthetubaguy | yeah, thats true | 13:12 |
sdague | which I'm not currently concerned about | 13:13 |
johnthetubaguy | OK | 13:13 |
sdague | I'm concerned about Nova's service catalog entries that users and other services call | 13:13 |
sdague | which currently require {tenant_id} in them | 13:13 |
sdague | for I believe no value | 13:13 |
johnthetubaguy | yes | 13:13 |
*** ankit_ag has quit IRC | 13:14 | |
sdague | that's the thing I think we should make go away in M & N | 13:14 |
openstackgerrit | Joel Coffman proposed openstack/nova: libvirt: Disconnect dm-crypt on instance suspend/stop https://review.openstack.org/141485 | 13:14 |
openstackgerrit | Joel Coffman proposed openstack/nova: libvirt: Add unit tests for methods https://review.openstack.org/198880 | 13:14 |
johnthetubaguy | now the one (poor) argument I heard was you can have a proxy infront of the API validate the token matches the tenant in the URL, but thats a layer violation in my book | 13:14 |
johnthetubaguy | yeah, I was fixating on the dropping our config that hard codes the glance URLs | 13:14 |
sdague | oh, right, that's a different thing | 13:15 |
*** busterswt has joined #openstack-nova | 13:15 | |
sdague | oh, so that's why it's still there? you do poor man's sharding by pushing out variants to compute nodes? | 13:15 |
sdague | or would {tenant_id} in the glance SC entries be fine for you | 13:16 |
johnthetubaguy | ah, the URL doesn't matter | 13:17 |
johnthetubaguy | its just the list of hosts I was fixating on | 13:17 |
*** jswarren has joined #openstack-nova | 13:19 | |
johnthetubaguy | sdague: so totally don't mean to run away mid conversation, but I totally need to go get some lunch from somewhere, back in a little bit | 13:19 |
sdague | yep | 13:19 |
sdague | well, I'll write all the details down | 13:19 |
*** jdandrea has joined #openstack-nova | 13:21 | |
*** dustins has quit IRC | 13:21 | |
*** mriedem has joined #openstack-nova | 13:21 | |
*** tjones has joined #openstack-nova | 13:22 | |
* leakypipes now running into this libvirt shutdown bug that danpb was working | 13:25 | |
*** kylek3h_ has joined #openstack-nova | 13:25 | |
*** browne has joined #openstack-nova | 13:25 | |
leakypipes | it's hosed up a few test runs now... | 13:25 |
danpb | leakypipes: yeah its hosed all my patches | 13:26 |
*** kylek3h has quit IRC | 13:27 | |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Fix test_relationships() for subobject versions https://review.openstack.org/198904 | 13:27 |
*** cfriesen has joined #openstack-nova | 13:28 | |
*** edleafe is now known as figleaf | 13:30 | |
*** rajesht has quit IRC | 13:30 | |
*** browne has quit IRC | 13:31 | |
mriedem | sudipto__: are you around? | 13:32 |
*** ijuwang has joined #openstack-nova | 13:32 | |
*** leakypipes has quit IRC | 13:32 | |
*** ctrath has joined #openstack-nova | 13:33 | |
alex_xu | johnthetubaguy: sdague sorry for missing api meeting. One thing I want to ask, so we probably need merged each microversion support on order like server side merged, right? should we send out email to reminder people can write microversion client support now. I'm afraid some contributor already forget that after waiting for such long time. | 13:34 |
*** lyanchih has joined #openstack-nova | 13:34 | |
sdague | alex_xu: sure | 13:35 |
sdague | ok, well as soon as the nova job completes, danpb's patch should get into the gate | 13:35 |
sdague | sorry, the neutron job, which passed, is just uploading logs now | 13:36 |
alex_xu | sdague: ok, thanks, let me send a reminder | 13:36 |
*** pixelbeat has quit IRC | 13:36 | |
andreykurilin | sdague, alex_xu: hi! should we update spec due to changes of implementation? | 13:36 |
*** VW_ has joined #openstack-nova | 13:37 | |
danpb | sdague: looks like it passed the check queue, so fingers crossed for the gate queue now | 13:37 |
*** claudiub has joined #openstack-nova | 13:37 | |
alex_xu | andreykurilin: it will be better, can help people understand how those works, and how they add microversion support. | 13:37 |
sdague | danpb: yep | 13:37 |
sdague | andreykurilin: yeh, changes that were made should come back as a spec patch now to just keep it all reflecting reality | 13:38 |
*** abhishekk has quit IRC | 13:38 | |
andreykurilin | alex_xu, sdague: ok, I'll change spec | 13:38 |
alex_xu | andreykurilin: thanks | 13:38 |
*** ftersin_ has quit IRC | 13:39 | |
*** jaypipes has joined #openstack-nova | 13:39 | |
*** mestery_ is now known as mestery | 13:40 | |
*** jaypipes is now known as leakypipes | 13:41 | |
*** dustins has joined #openstack-nova | 13:42 | |
*** hshiina has joined #openstack-nova | 13:44 | |
*** tongli has quit IRC | 13:45 | |
*** mwagner_lap has joined #openstack-nova | 13:47 | |
mdbooth | What's the difference between the check and gate queues? Assume it's related to what they do with git. | 13:47 |
mriedem | mdbooth: in the check queue changes are tested in isolation against HEAD, in the gate queue i believe multiple changes are all tested together | 13:48 |
mriedem | which is why sometimes when one thing gets in ahead of you it can break your stuff in the gate queue but not check queue | 13:48 |
mriedem | sdague and mtreinish can explain it better | 13:49 |
*** mnestratov has joined #openstack-nova | 13:49 | |
mdbooth | Right, so check literally runs against the commit you submitted, but gate runs against your commit merged to head? | 13:49 |
sdague | mdbooth: no | 13:49 |
sdague | check runs against HEAD | 13:49 |
*** edmondsw has joined #openstack-nova | 13:49 | |
sdague | gate runs speculatively against everything in front of it in the gate | 13:50 |
mdbooth | i.e. your patch rebased on to head? | 13:50 |
sdague | the top of GATE is against HEAD | 13:50 |
sdague | yes | 13:50 |
*** venkatesh has quit IRC | 13:50 | |
sdague | https://dague.net/2013/02/21/the-openstack-gate/ | 13:51 |
sdague | some pictures | 13:51 |
mdbooth | sdague: Thanks | 13:51 |
*** jwitko has quit IRC | 13:52 | |
*** ndipanov has quit IRC | 13:53 | |
*** tongli has joined #openstack-nova | 13:57 | |
*** garyk has quit IRC | 13:57 | |
*** tjones has quit IRC | 13:58 | |
*** Marga_ has quit IRC | 13:59 | |
*** jianghua_ has joined #openstack-nova | 14:00 | |
*** Marga_ has joined #openstack-nova | 14:01 | |
*** ftersin has joined #openstack-nova | 14:02 | |
*** eglynn has joined #openstack-nova | 14:03 | |
mriedem | it's interesting that a third party ci system would be running with a different version of oslo.versionedobjects than what jenkins runs do https://review.openstack.org/#/c/210445/ | 14:03 |
mriedem | unless they are using a pypi mirror that didn't have ovo 0.0 | 14:03 |
mriedem | *0.6.0 | 14:03 |
*** tjones has joined #openstack-nova | 14:03 | |
*** ndipanov has joined #openstack-nova | 14:04 | |
sudipto__ | mriedem, hi | 14:06 |
*** echoingumesh has joined #openstack-nova | 14:06 | |
dims_ | mriedem: y, fishy | 14:07 |
mriedem | dims_: fishy but it did catch that gap in the minimum required version of ovo | 14:08 |
mriedem | sudipto__: nevermind, i sorted it out ^ | 14:08 |
dims_ | mriedem: right | 14:08 |
dims_ | if you remember in mid-cycle we thought there was nothing left for keystone v3...found one - https://review.openstack.org/#/c/209599/ | 14:09 |
*** diogogmt has joined #openstack-nova | 14:10 | |
*** lpetrut has joined #openstack-nova | 14:10 | |
*** jianghua_ has quit IRC | 14:10 | |
*** echoingumesh has quit IRC | 14:11 | |
*** alexschm has quit IRC | 14:11 | |
*** diogogmt has quit IRC | 14:11 | |
*** ttrumm_ has quit IRC | 14:11 | |
openstackgerrit | Cale Rath proposed openstack/nova: Make generate_password more secure https://review.openstack.org/210092 | 14:12 |
sudipto__ | mriedem, got it... | 14:12 |
*** diogogmt has joined #openstack-nova | 14:13 | |
*** READ10 has joined #openstack-nova | 14:15 | |
*** lucas___ has joined #openstack-nova | 14:15 | |
openstackgerrit | Chuck Carmack proposed openstack/nova: Fix DeprecationWarning when using BaseException.message https://review.openstack.org/207560 | 14:18 |
cfriesen | alaski: you around? | 14:18 |
alaski | cfriesen: yep | 14:19 |
*** baoli has quit IRC | 14:20 | |
cfriesen | I just reported bug 1482416, was wondering if you might have any suggestions on where to look. | 14:20 |
openstack | bug 1482416 in OpenStack Compute (nova) "bug blocks DB migration that changes column type" [Undecided,New] https://launchpad.net/bugs/1482416 | 14:20 |
*** baoli has joined #openstack-nova | 14:20 | |
*** lpetrut has quit IRC | 14:21 | |
*** alaski is now known as lascii | 14:21 | |
lascii | nothing really jumps out at me. it's very strange that the constraint would be an issue here since it doesn't affect the column you want to change | 14:22 |
openstackgerrit | Alexis Lee proposed openstack/nova: Make generate_password more secure https://review.openstack.org/210092 | 14:24 |
cfriesen | lascii: huh..yeah, that's a good point. even weirder than I thought. :) | 14:26 |
lascii | cfriesen: I don't think that alter command will work directly with sqlite, so you may want to see what sqlalchemy-migrate is doing under the hood there. it may be creating a new table and losing the constraint that way | 14:27 |
*** diogogmt has quit IRC | 14:28 | |
lascii | cfriesen: you may want to ping zzzeek on this | 14:28 |
*** ferest has joined #openstack-nova | 14:29 | |
*** edmund has joined #openstack-nova | 14:29 | |
openstackgerrit | Alexis Lee proposed openstack/nova: Walk through the API, Conductor and Compute code https://review.openstack.org/210467 | 14:30 |
openstackgerrit | Jordan Pittier proposed openstack/nova: ScalityVolume:fix how remote FS mount is detected https://review.openstack.org/210468 | 14:30 |
*** otter768 has joined #openstack-nova | 14:31 | |
*** garyk has joined #openstack-nova | 14:33 | |
*** diogogmt has joined #openstack-nova | 14:33 | |
*** dane-fichter has joined #openstack-nova | 14:34 | |
*** otter768 has quit IRC | 14:35 | |
*** dboik_ has joined #openstack-nova | 14:36 | |
*** garyk1 has joined #openstack-nova | 14:37 | |
*** garyk has quit IRC | 14:37 | |
*** ferest has quit IRC | 14:38 | |
*** Guest55 has joined #openstack-nova | 14:39 | |
*** jgriffith is now known as Guest81486 | 14:39 | |
*** Guest55 is now known as jgriffith | 14:40 | |
*** nelsnelson has joined #openstack-nova | 14:41 | |
openstackgerrit | Sudipta Biswas proposed openstack/nova: cleanup NovaObjectDictCompat from numa object https://review.openstack.org/210480 | 14:41 |
*** hshiina has quit IRC | 14:46 | |
*** hshiina has joined #openstack-nova | 14:46 | |
*** ferest has joined #openstack-nova | 14:46 | |
mriedem | did someone actually give superdan the day off? | 14:47 |
Guest45541 | heh | 14:47 |
*** Guest45541 is now known as superdan | 14:47 | |
mriedem | i knew you were hiding | 14:47 |
*** superdan is now known as Guest20222 | 14:48 | |
*** xyang has joined #openstack-nova | 14:48 | |
*** moshele has quit IRC | 14:49 | |
*** gszasz has quit IRC | 14:50 | |
*** ttrumm has joined #openstack-nova | 14:50 | |
*** edmund1 has joined #openstack-nova | 14:50 | |
*** edmund1 has quit IRC | 14:50 | |
*** sulo has quit IRC | 14:50 | |
*** patrickeast has joined #openstack-nova | 14:51 | |
*** edmund1 has joined #openstack-nova | 14:51 | |
*** GeraldK has quit IRC | 14:51 | |
*** ferest has quit IRC | 14:51 | |
*** xottabich has quit IRC | 14:51 | |
*** Piet has joined #openstack-nova | 14:52 | |
*** edmund has quit IRC | 14:52 | |
*** dims_ is now known as dimsum__ | 14:53 | |
*** dave-mccowan has joined #openstack-nova | 14:56 | |
*** moshele has joined #openstack-nova | 14:57 | |
*** moshele has quit IRC | 14:57 | |
*** Nikolay_St has quit IRC | 14:57 | |
*** nagyz_ is now known as nagyz | 14:58 | |
*** tonytan4ever has joined #openstack-nova | 14:59 | |
*** ildikov has quit IRC | 14:59 | |
*** lpetrut has joined #openstack-nova | 14:59 | |
*** sulo has joined #openstack-nova | 14:59 | |
*** yamahata has joined #openstack-nova | 15:00 | |
*** kevinbenton has quit IRC | 15:02 | |
*** ijw has joined #openstack-nova | 15:02 | |
openstackgerrit | Ed Leafe proposed openstack/nova: Move existing V2 to legacy_v2 https://review.openstack.org/193725 | 15:02 |
*** kevinbenton has joined #openstack-nova | 15:03 | |
*** pixelb has joined #openstack-nova | 15:03 | |
*** ferest has joined #openstack-nova | 15:03 | |
*** dave-mcc_ has joined #openstack-nova | 15:03 | |
openstackgerrit | Sudipta Biswas proposed openstack/nova: cleanup NovaObjectDictCompat from network object https://review.openstack.org/210490 | 15:04 |
*** sahid has quit IRC | 15:05 | |
markus_z | If one want's to look at a small review => https://review.openstack.org/#/c/209187/ | 15:05 |
*** dave-mc__ has joined #openstack-nova | 15:06 | |
*** sahid has joined #openstack-nova | 15:06 | |
*** dave-mccowan has quit IRC | 15:07 | |
*** echoingumesh has joined #openstack-nova | 15:07 | |
*** browne has joined #openstack-nova | 15:07 | |
*** dave-mcc_ has quit IRC | 15:08 | |
johnthetubaguy | figleaf: I just took a look at this: https://review.openstack.org/#/c/193725/30 | 15:09 |
*** mtanino has joined #openstack-nova | 15:09 | |
rlrossit | leakypipes: Guest20222: https://review.openstack.org/#/c/198904/ needed a rebase but it's back up and raring to go | 15:09 |
*** ferest has quit IRC | 15:09 | |
*** ttrumm has quit IRC | 15:10 | |
figleaf | johnthetubaguy: that was quick! | 15:10 |
johnthetubaguy | figleaf: there are two things that looked a bit odd to me | 15:10 |
*** nelsnelson has quit IRC | 15:10 | |
Guest20222 | whisky tango foxtrot | 15:10 |
*** dave-mccowan has joined #openstack-nova | 15:11 | |
johnthetubaguy | figleaf: literally just got out a meeting | 15:11 |
*** Guest20222 is now known as dansmith | 15:11 | |
figleaf | johnthetubaguy: literally just got off a candidate interview :) | 15:11 |
*** shyama has quit IRC | 15:11 | |
rlrossit | no need for that type of language dansmith | 15:11 |
figleaf | gs | 15:11 |
rlrossit | there are children present | 15:11 |
*** echoingumesh has quit IRC | 15:12 | |
dansmith | rlrossit: leakypipes: I just hit that one, it's on its way | 15:12 |
*** dave-mcc_ has joined #openstack-nova | 15:12 | |
alex_xu | figleaf: what I can help for https://review.openstack.org/#/c/193725/? | 15:12 |
alex_xu | figleaf: I saw still have test failed, you get trouble for that? do you need me help on something? | 15:13 |
*** dave-mc__ has quit IRC | 15:13 | |
figleaf | alex_xu: the ps I just pushed should be working | 15:14 |
*** unicell1 has joined #openstack-nova | 15:14 | |
*** dave-mc__ has joined #openstack-nova | 15:14 | |
alex_xu | figleaf: cool, will catch up review it | 15:14 |
figleaf | alex_xu: the real problems are with the second in the series: https://review.openstack.org/#/c/210131/ | 15:14 |
*** tsekiyama has joined #openstack-nova | 15:14 | |
*** dave-mccowan has quit IRC | 15:15 | |
figleaf | johnthetubaguy: yeah, I don't know how those odd changes snuck in. I'll work on cleaning them up | 15:15 |
*** dave-mccowan has joined #openstack-nova | 15:16 | |
alex_xu | figleaf: oops, a lot of error | 15:16 |
*** unicell has quit IRC | 15:16 | |
figleaf | johnthetubaguy: looks like some git ugliness. Gimme a few to clean them up | 15:16 |
alex_xu | figleaf: if it is trouble, I can help on debug | 15:16 |
*** venkatesh has joined #openstack-nova | 15:16 | |
*** dave-mcc_ has quit IRC | 15:17 | |
dane-fichter | jcook: I like that comment alot, it does a great job of clarifying your patch's relationship to glanceclient. Definitely will give a +1 as soon as you upload a version in the mitaka folder | 15:17 |
*** dave-mcc_ has joined #openstack-nova | 15:17 | |
venkatesh | HI all, | 15:18 |
venkatesh | what is the current status of the work "Related to blueprint liberty-objects" | 15:18 |
alex_xu | johnthetubaguy: we have priority feature propose freeze at 17.Aug? | 15:19 |
*** dave-mc__ has quit IRC | 15:19 | |
venkatesh | i want to start work on it .. | 15:19 |
*** dave-m___ has joined #openstack-nova | 15:19 | |
johnthetubaguy | alex_xu: yeah, its down as 18th on my list, but thats the current plan | 15:19 |
figleaf | alex_xu: the second patch set in the series is close. There seems to be a problem in the wsgi mocks that I don't understand | 15:19 |
johnthetubaguy | alex_xu: that might be a bit too soon I guess | 15:19 |
alex_xu | figleaf: ok, let me try to debug that | 15:20 |
*** kurtmartin has joined #openstack-nova | 15:20 | |
alex_xu | johnthetubaguy: yea, I'm a little afraid remove extension a little slow now | 15:20 |
*** dave-mc__ has joined #openstack-nova | 15:20 | |
*** dave-mccowan has quit IRC | 15:21 | |
johnthetubaguy | alex_xu: yeah, I think we need to look at reducing the scope to the key bits | 15:21 |
johnthetubaguy | alex_xu: my priority is deprecating v2.0 I guess | 15:21 |
johnthetubaguy | and deprecating all the configs, etc | 15:21 |
alex_xu | johnthetubaguy: and freeze the extension API | 15:22 |
alex_xu | johnthetubaguy: or remove it | 15:22 |
*** dave-mcc_ has quit IRC | 15:22 | |
*** r-daneel has joined #openstack-nova | 15:22 | |
*** dave-mccowan has joined #openstack-nova | 15:22 | |
*** mdrabe has quit IRC | 15:22 | |
*** mdrabe has joined #openstack-nova | 15:23 | |
johnthetubaguy | alex_xu: yeah, we can't remove it, and its already frozen as I understand it, we could remove it in a microversion I guess, but the config stuff is more important, in some ways | 15:23 |
alex_xu | johnthetubaguy: ok, I see now | 15:23 |
mtreinish | dimsum__: is it really invalid on nova: https://bugs.launchpad.net/nova/+bug/1482609 the only reason os-testr stack traced was because of a broken subunit stream caused by a segfault | 15:23 |
openstack | Launchpad bug 1482609 in os-testr "Intermittent py27 failure - TypeError: unsupported operand type(s" [Medium,Fix released] - Assigned to Matthew Treinish (treinish) | 15:23 |
johnthetubaguy | alex_xu: next release we can look at dropping the ability to turn stuff off, thats the bit I think thats crazy important | 15:23 |
*** dave-m___ has quit IRC | 15:24 | |
johnthetubaguy | alex_xu: unless I am missing something, which I totally could be | 15:24 |
*** tjones has quit IRC | 15:24 | |
alex_xu | johnthetubaguy: you mean drop the plugin stuff? | 15:24 |
dimsum__ | mtreinish: there's another bug tracking test_clean_shutdown_failure | 15:24 |
johnthetubaguy | alex_xu: yeah, next release | 15:24 |
johnthetubaguy | alex_xu: once we have removed the config, after it was deprecated | 15:25 |
alex_xu | johnthetubaguy: yea, agree, that need a lot of work also, we can't done in this release | 15:25 |
*** dave-mc__ has quit IRC | 15:25 | |
mtreinish | dimsum__: ah ok | 15:25 |
johnthetubaguy | alex_xu: just want to make sure we get the super critical bits landed, I think sdague is looking at helping make a list of that | 15:25 |
*** patrickeast has quit IRC | 15:25 | |
alex_xu | johnthetubaguy: ok, got it | 15:25 |
johnthetubaguy | alex_xu: I hope you got out of the water OK, BTW | 15:26 |
*** dave-mcc_ has joined #openstack-nova | 15:26 | |
*** dave-mccowan has quit IRC | 15:27 | |
*** patrickeast has joined #openstack-nova | 15:27 | |
jcook | dane-fichter: thanks :) | 15:27 |
alex_xu | johnthetubaguy: yea, thanks :) just terrible traffic, stuck on the road two hours... | 15:27 |
*** VW_ has quit IRC | 15:27 | |
*** VW_ has joined #openstack-nova | 15:28 | |
*** ttrumm has joined #openstack-nova | 15:28 | |
dane-fichter | jcook: np. feel free to ask me for reviews on that whenever. | 15:28 |
*** dave-mccowan has joined #openstack-nova | 15:28 | |
jcook | dane-fichter: will do, thanks :) | 15:29 |
*** jcoufal has quit IRC | 15:29 | |
*** ttrumm has quit IRC | 15:29 | |
*** dave-mc__ has joined #openstack-nova | 15:30 | |
alex_xu | sdague: do you need me continue push https://review.openstack.org/202900 or waiting for your devref, I feel the time tight for now. | 15:30 |
*** Murali has quit IRC | 15:31 | |
*** dave-m___ has joined #openstack-nova | 15:31 | |
*** dave-mcc_ has quit IRC | 15:31 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Add functional tests to soft affinity capabilities https://review.openstack.org/147521 | 15:32 |
*** VW__ has joined #openstack-nova | 15:32 | |
*** browne has quit IRC | 15:32 | |
*** VW_ has quit IRC | 15:32 | |
alex_xu | sdague: let me know if you need me help on that. I have to go to bed now, otherwise the baby will wakeup after a hour again.... | 15:33 |
*** dave-mccowan has quit IRC | 15:33 | |
*** dave-mc__ has quit IRC | 15:34 | |
mriedem | comstud: https://www.youtube.com/watch?v=z0yYHNEy5Hs | 15:34 |
*** dave-mccowan has joined #openstack-nova | 15:35 | |
*** dave-m___ has quit IRC | 15:36 | |
*** rdopiera has quit IRC | 15:37 | |
ftersin | dansmith: hi. do you know what jaypipes meant in https://review.openstack.org/#/c/170031/4/nova/compute/manager.py | 15:38 |
ftersin | dansmith: why not to get image metadata from instance system metadata? | 15:38 |
*** logan2 has quit IRC | 15:38 | |
dansmith | just a sec | 15:38 |
*** mnestratov has quit IRC | 15:39 | |
*** dave-mcc_ has joined #openstack-nova | 15:39 | |
dansmith | danpb: we're not persisting the ImageMeta object anywhere yet, so we should still pull things from system_metadata if we just have the instance, right? | 15:39 |
danpb | yeah | 15:39 |
openstackgerrit | Daniel Berrange proposed openstack/nova: ironic: convert driver to use nova.objects.ImageMeta https://review.openstack.org/189362 | 15:40 |
openstackgerrit | Daniel Berrange proposed openstack/nova: objects: convert config drive to use ImageMeta object https://review.openstack.org/189323 | 15:40 |
openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: convert driver to use nova.objects.ImageMeta https://review.openstack.org/188119 | 15:40 |
openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: make instance compulsory in blockinfo APIs https://review.openstack.org/188118 | 15:40 |
openstackgerrit | Daniel Berrange proposed openstack/nova: hyperv: convert driver to use nova.objects.ImageMeta https://review.openstack.org/189302 | 15:40 |
openstackgerrit | Daniel Berrange proposed openstack/nova: objects: add virtual 'image_meta' property to Instance object https://review.openstack.org/190145 | 15:40 |
openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: convert to use instance.image_meta property https://review.openstack.org/190146 | 15:40 |
openstackgerrit | Daniel Berrange proposed openstack/nova: compute: convert manager to use nova.objects.ImageMeta https://review.openstack.org/189685 | 15:40 |
openstackgerrit | Daniel Berrange proposed openstack/nova: xenapi: convert driver to use nova.objects.ImageMeta https://review.openstack.org/188790 | 15:40 |
dansmith | and you have patches up to return an ImageMeta from that call or something, instead of a dict? | 15:40 |
dansmith | speak of the devil :) | 15:40 |
danpb | initially we use objects.ImageMeta.from_instance() or with that patchset just instance.image_meta | 15:40 |
*** dave-mc__ has joined #openstack-nova | 15:40 | |
dansmith | ah, 190145 | 15:41 |
danpb | the only place the data is persisted is in instance.system_metadata, or in glance / cinder itself | 15:41 |
dansmith | yeah | 15:41 |
*** logan2 has joined #openstack-nova | 15:41 | |
dansmith | ftersin: leakypipes: I replied | 15:41 |
leakypipes | dansmith: ty sir. | 15:42 |
leakypipes | superdan. | 15:42 |
*** dave-mccowan has quit IRC | 15:43 | |
ftersin | dansmith: thanks | 15:43 |
dansmith | grr, nickserv is having troubles today | 15:44 |
dansmith | keeps flipping me back | 15:44 |
*** dave-mcc_ has quit IRC | 15:44 | |
*** dave-mccowan has joined #openstack-nova | 15:44 | |
*** rfolco has quit IRC | 15:44 | |
*** dave-mc__ has quit IRC | 15:45 | |
*** dave-mcc_ has joined #openstack-nova | 15:46 | |
*** dave-mc__ has joined #openstack-nova | 15:47 | |
openstackgerrit | Ed Leafe proposed openstack/nova: Move existing V2 to legacy_v2 https://review.openstack.org/193725 | 15:47 |
*** dave-mccowan has quit IRC | 15:48 | |
*** dave-mccowan has joined #openstack-nova | 15:49 | |
mriedem | leakypipes: do you know if there is any reason why nova sends the service catalog in the header when making glance requests? | 15:49 |
mriedem | https://github.com/openstack/nova/blob/master/nova/image/glance.py#L112 | 15:49 |
leakypipes | mriedem: lol, no idea. | 15:49 |
mriedem | if you have a bunch of endpoints in your service catalog that shit blows up | 15:50 |
mriedem | 400 Header Line Too Long | 15:50 |
*** dave-mcc_ has quit IRC | 15:50 | |
figleaf | johnthetubaguy: pushed the fixes | 15:50 |
*** dave-mcc_ has joined #openstack-nova | 15:50 | |
*** belmoreira has quit IRC | 15:51 | |
mriedem | leakypipes: i'll push a change to remove that | 15:51 |
mriedem | since we use the auth_token middleware it's unused | 15:51 |
mtreinish | mriedem: I think the catalog gets returned from keystone on get token requests, but that's different | 15:51 |
johnthetubaguy | figleaf: cool, I am attempting to dig into those other test failures | 15:51 |
mriedem | morganfainberg_: ^ can you confirm? | 15:51 |
johnthetubaguy | figleaf: just having setup issues, but getting to the end of those now I hope | 15:51 |
leakypipes | mriedem: yes, please do. git blame isn't really showing the source of that. | 15:51 |
figleaf | johnthetubaguy: thx | 15:51 |
mriedem | leakypipes: it's uber hold | 15:51 |
mriedem | *old | 15:51 |
*** dave-mc__ has quit IRC | 15:52 | |
*** belmoreira has joined #openstack-nova | 15:52 | |
dansmith | if glance needs it for some reason, it'd get it from keystone when it auths the token anyway, right? | 15:52 |
*** belmoreira has quit IRC | 15:52 | |
leakypipes | mriedem: ichi setthi: https://github.com/openstack/nova/commit/5bb1803cfd82eceec09765fb3c41e9e571364a94 | 15:52 |
mriedem | dansmith: yeah | 15:52 |
mriedem | probably predated the keystone auth token middleware stuff | 15:52 |
*** dave-mc__ has joined #openstack-nova | 15:53 | |
*** Nikolay_St has joined #openstack-nova | 15:53 | |
leakypipes | mriedem: I was at AT&T working in Chef Hell. | 15:53 |
leakypipes | mriedem: I accept no responsibility :) | 15:53 |
mriedem | leakypipes: well | 15:53 |
mriedem | that's a funny coincidence | 15:53 |
mriedem | it's AT&T hitting this :) | 15:54 |
*** dave-mccowan has quit IRC | 15:54 | |
dansmith | karma is a bitch | 15:54 |
*** dansmith is now known as superdan | 15:54 | |
*** tjones has joined #openstack-nova | 15:54 | |
*** dave-mccowan has joined #openstack-nova | 15:54 | |
*** dave-mcc_ has quit IRC | 15:55 | |
leakypipes | lol | 15:55 |
*** echirivella has quit IRC | 15:56 | |
*** dave-mcc_ has joined #openstack-nova | 15:56 | |
*** sajeesh has joined #openstack-nova | 15:57 | |
*** dave-mc__ has quit IRC | 15:57 | |
*** dave-mccowan has quit IRC | 15:59 | |
johnthetubaguy | figleaf: going to rebase phase 2 on top of your latest phase 1, to see if that helps the test failures | 15:59 |
superdan | mriedem: what is the patch we're waiting on to fix the gate? | 15:59 |
johnthetubaguy | figleaf: I have the tests passing on your latest phase 1, which is a start | 16:00 |
mriedem | superdan: my efforts failed | 16:00 |
mriedem | superdan: so there isn't one | 16:00 |
superdan | I thought danpb had a patch | 16:00 |
superdan | also it appears to not be 100% fail.. I thought it was | 16:00 |
*** dave-mccowan has joined #openstack-nova | 16:01 | |
mriedem | yeah apparently not http://status.openstack.org/elastic-recheck/index.html | 16:01 |
mriedem | it's top though | 16:01 |
danpb | my patch merged about 40 mins ago | 16:02 |
openstackgerrit | Jay Pipes proposed openstack/nova: Allow compute monitors in different namespaces https://review.openstack.org/209499 | 16:02 |
mriedem | https://review.openstack.org/#/c/210334/ | 16:02 |
leakypipes | sudipto__, alex_xu: fix for the compute monitor namespace thing... | 16:02 |
mriedem | danpb: there is no reason to -2 my fix | 16:02 |
mriedem | it's still a fix | 16:02 |
danpb | have we seen any failures for builds which started /after/ | 16:02 |
danpb | mriedem: my fix included your fix too, as i simply reverted all the changes too that test file | 16:02 |
mriedem | danpb: https://review.openstack.org/#/c/210036 still cleans up a useless thing, it doesn't close the bug, so i can remove that if it's contentious | 16:02 |
danpb | the whole set of changes was bogus | 16:03 |
superdan | mriedem: I still don't understand why you think that's a useless mock | 16:03 |
*** dave-mc__ has joined #openstack-nova | 16:03 | |
mriedem | superdan: because as i understand it mock.patch.object is only useful as a decorator or context manager | 16:03 |
superdan | mriedem: I think that's not true | 16:04 |
*** dave-mcc_ has quit IRC | 16:04 | |
superdan | mriedem: but the thing being mocked needs to return true in order for the tests to behave properly, right? | 16:04 |
mriedem | the test cases were already decorated with the same thing | 16:04 |
mriedem | to pass the host.min_version check | 16:04 |
*** dave-mcc_ has joined #openstack-nova | 16:04 | |
superdan | ah, I missed that | 16:04 |
superdan | mriedem: seems to work fine as a regular patcher, fwiw | 16:06 |
*** dave-m___ has joined #openstack-nova | 16:06 | |
*** salv-orl_ has joined #openstack-nova | 16:06 | |
*** dave-mccowan has quit IRC | 16:06 | |
superdan | I just tested | 16:06 |
mriedem | danpb: so https://review.openstack.org/#/c/210334/ is a total revert of https://review.openstack.org/#/c/128829/ ? | 16:06 |
*** jlanoux has quit IRC | 16:07 | |
mriedem | no | 16:07 |
*** MarcF has quit IRC | 16:07 | |
*** dave-mccowan has joined #openstack-nova | 16:07 | |
danpb | mriedem: no, its a total revert of the test suite changes to test_driver.py | 16:08 |
*** dave-mc__ has quit IRC | 16:08 | |
danpb | along with fixing the brokeness in driver.py | 16:08 |
*** echoingumesh has joined #openstack-nova | 16:08 | |
*** salv-orlando has quit IRC | 16:08 | |
openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: set caps on maximum live migration time https://review.openstack.org/162254 | 16:08 |
openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: take account of disks in migration data size https://review.openstack.org/206632 | 16:08 |
openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: support management of downtime during migration https://review.openstack.org/162253 | 16:08 |
openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: add helper methods for getting guest devices/disks https://review.openstack.org/206631 | 16:08 |
openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: ensure LibvirtConfigGuestDisk parses readonly/shareable flags https://review.openstack.org/206630 | 16:08 |
*** dave-mcc_ has quit IRC | 16:09 | |
*** dave-mcc_ has joined #openstack-nova | 16:09 | |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Add hacking check for greenthread.spawn() and eventlet.spawn() https://review.openstack.org/195713 | 16:09 |
*** josecastroleon has quit IRC | 16:09 | |
rlrossit | mriedem: I think ^ stopped just being a trivial rebase because moving from eventlet to nova utils caused a unit test failure in hyperv stuff. | 16:10 |
*** gordc has joined #openstack-nova | 16:10 | |
*** tjones has quit IRC | 16:10 | |
mriedem | i knew adding eventlet.spawn() to that would make it more complicated | 16:10 |
gordc | hi folks, had a historical question. when glance/cinder split from nova, do you know how quickly the existing code in nova was removed? was there a cycle of deprecation or was it immediate? | 16:10 |
rlrossit | here's the failure if you care about that: https://jenkins04.openstack.org/job/gate-nova-python27/1697/console | 16:10 |
*** dave-m___ has quit IRC | 16:10 | |
*** dave-mc__ has joined #openstack-nova | 16:10 | |
superdan | mriedem: so if I change that mock from True to False, I get more test failures | 16:10 |
superdan | mriedem: so I think it does need to be mocked in setUp(), we just need to properly start() it to be correct | 16:11 |
mriedem | gordc: it's still a work in progress | 16:11 |
mriedem | superdan: gross | 16:11 |
*** patrickeast has quit IRC | 16:11 | |
mriedem | i'd prefer to just see the actual test cases that need it to mock it for their test cases, not all test cases | 16:11 |
*** meghal has joined #openstack-nova | 16:11 | |
mriedem | since that would fudge up negative tests too | 16:11 |
*** dave-m___ has joined #openstack-nova | 16:11 | |
superdan | mriedem: yep, happy to have that too, just saying I think removing it means we're dependent on what that thing actually returns, which is wrong | 16:12 |
gordc | mriedem: ... oh. so there's still cinder code in nova? | 16:12 |
*** patrickeast has joined #openstack-nova | 16:12 | |
*** dave-mccowan has quit IRC | 16:13 | |
*** echoingumesh has quit IRC | 16:13 | |
gordc | i guess the followup question when did the nova-version of cinder stopped being packaged | 16:13 |
*** dave-mccowan has joined #openstack-nova | 16:13 | |
mriedem | gordc: i remember nova-volume being in folsom | 16:13 |
mriedem | gone in grizzly https://github.com/openstack/nova/tree/grizzly-eol/bin | 16:13 |
*** alex_klimov has quit IRC | 16:13 | |
mriedem | gordc: the comment was a bit misleading on my part, | 16:14 |
*** dave-mcc_ has quit IRC | 16:14 | |
mriedem | the libvirt volume drivers are just now getting pulled out of nova per os-brick | 16:14 |
mriedem | they are duplicated into cinder originally, now that's all be lifted into os-brick and re-used in cinder and nova | 16:14 |
mriedem | and nova still have volume apis | 16:14 |
*** dave-mcc_ has joined #openstack-nova | 16:15 | |
mriedem | the actual nova-volume service stuff was gone in grizzly though | 16:15 |
gordc | ... yikes. ok. glance was released in essex? | 16:15 |
*** dave-mc__ has quit IRC | 16:15 | |
mriedem | the glance split was before i hit puberty i think, ask leakypipes :) | 16:15 |
leakypipes | gordc: cactus. | 16:15 |
mriedem | hi-o! | 16:15 |
leakypipes | maybe bexar | 16:15 |
gordc | daaaamnnnn...lol | 16:16 |
openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: check min required qemu/libvirt versions on s390/s390x https://review.openstack.org/183486 | 16:16 |
openstackgerrit | Emma Foley proposed openstack/nova: Added support for specifying units to hw:mem_page_size https://review.openstack.org/209564 | 16:16 |
figleaf | leakypipes: yeah, it was probably in bexar | 16:16 |
* leakypipes retreats with smoking jacket, billfold, and pipe into the drawing room | 16:16 | |
*** dave-mc__ has joined #openstack-nova | 16:16 | |
superdan | heh | 16:16 |
*** dave-m___ has quit IRC | 16:16 | |
*** ftersin has quit IRC | 16:16 | |
*** unicell1 has quit IRC | 16:17 | |
mriedem | imagine there is bear skin rugs, a fire, well oiled leather and mahogeny | 16:17 |
gordc | we're splitting off some code in ceilometer, and was wondering how long i had to keep original code around... seems like 'immediate removal' is not an optoin | 16:17 |
mriedem | gnocchi? | 16:17 |
gordc | leakypipes: thanks for history lesson | 16:17 |
*** dave-mccowan has quit IRC | 16:17 | |
*** dave-m___ has joined #openstack-nova | 16:18 | |
gordc | mriedem: aodh... we've move alarming code into it's own repo | 16:18 |
*** eglynn has quit IRC | 16:18 | |
gordc | gnocchi was all new so it was always separate | 16:18 |
*** venkatesh has quit IRC | 16:18 | |
*** burgerk has joined #openstack-nova | 16:18 | |
*** leeantho has joined #openstack-nova | 16:19 | |
*** patrickeast has quit IRC | 16:19 | |
*** dave-mcc_ has quit IRC | 16:19 | |
mriedem | well i'd say at least 6 month deprecation cycle | 16:19 |
*** dave-mccowan has joined #openstack-nova | 16:20 | |
*** armax has quit IRC | 16:20 | |
mriedem | N at earliest? | 16:20 |
*** nic has joined #openstack-nova | 16:20 | |
*** echoingumesh has joined #openstack-nova | 16:20 | |
*** echoingumesh has quit IRC | 16:20 | |
gordc | mriedem: yeah seems like that's what needs to be done here. | 16:20 |
openstackgerrit | Shiina, Hironori proposed openstack/nova: Add a compute RPC API to inject an NMI https://review.openstack.org/202605 | 16:20 |
*** dave-mc__ has quit IRC | 16:20 | |
gordc | mriedem: we've already stopped development this cycle so we'll aim for M* removal. | 16:21 |
mriedem | gordc: but when did the deprecation warning go into release notes and code? | 16:21 |
mriedem | K or L? | 16:21 |
* gordc needs to make sure packagers make both ceilo-alarms and aodh | 16:21 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Don't pass the service catalog when making glance requests https://review.openstack.org/210515 | 16:22 |
mriedem | leakypipes: superdan: ^ should be trivial | 16:22 |
*** dave-m___ has quit IRC | 16:22 | |
*** patrickeast has joined #openstack-nova | 16:23 | |
gordc | it was decided at summit... or pre-summit. we definitely want it gone as soon as it can | 16:23 |
*** dave-mcc_ has joined #openstack-nova | 16:23 | |
*** dave-mccowan has quit IRC | 16:24 | |
*** ijuwang has quit IRC | 16:25 | |
*** xyang1 has joined #openstack-nova | 16:26 | |
*** ssurana has joined #openstack-nova | 16:27 | |
*** sahid has quit IRC | 16:27 | |
*** patrickeast has quit IRC | 16:28 | |
*** jistr has quit IRC | 16:28 | |
*** ericksonfgds is now known as ericksonsantos | 16:28 | |
*** dave-mccowan has joined #openstack-nova | 16:29 | |
openstackgerrit | Carlos Gonçalves proposed openstack/python-novaclient: Support forcing service down https://review.openstack.org/185849 | 16:30 |
*** xyang1 has quit IRC | 16:30 | |
*** agireud has joined #openstack-nova | 16:30 | |
johnthetubaguy | figleaf: this change is doing my head in, the tests are super confusing... | 16:30 |
*** dave-mcc_ has quit IRC | 16:30 | |
johnthetubaguy | figleaf: I really think we would be better of moving all the code, then moving all the tests | 16:31 |
johnthetubaguy | figleaf: change set wise | 16:31 |
*** bapalm has quit IRC | 16:31 | |
*** dave-mcc_ has joined #openstack-nova | 16:31 | |
*** otter768 has joined #openstack-nova | 16:32 | |
*** lucas___ has quit IRC | 16:32 | |
figleaf | johnthetubaguy: you mean start all over again? | 16:33 |
smatzek | danpb: should disk_format be a field on ImageMeta? There are several places in the drivers that are using it. Some go to system metadata directly even though image_meta is local, some are in snapshot and are using meta from glance, those are OK. A a few places are like https://github.com/openstack/nova/blob/master/nova/virt/libvirt/blockinfo.py#L426, and I don't know how that will work once image_meta is an object. | 16:34 |
*** dave-mccowan has quit IRC | 16:34 | |
*** lucas___ has joined #openstack-nova | 16:35 | |
johnthetubaguy | figleaf: yeah, it sounds bad like that | 16:35 |
johnthetubaguy | figleaf: lets see how this goes | 16:35 |
*** dave-mccowan has joined #openstack-nova | 16:35 | |
*** gordc has left #openstack-nova | 16:35 | |
johnthetubaguy | figleaf: currently doing a manual rebase of all the test files, so its kinda being re-done in some ways | 16:36 |
*** otter768 has quit IRC | 16:36 | |
*** dave-mcc_ has quit IRC | 16:37 | |
*** dave-mc__ has joined #openstack-nova | 16:37 | |
danpb | smatzek: err, it is already a field in ImageMeta | 16:37 |
figleaf | johnthetubaguy: yeah, since the test files reference the moved api files, they always have to change | 16:37 |
figleaf | gs | 16:37 |
figleaf | doh! | 16:37 |
danpb | smatzek: this series converts all existing code to use ImageMeta object https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:virtimageprops-19,n,z | 16:38 |
*** patrickeast has joined #openstack-nova | 16:39 | |
*** dave-mcc_ has joined #openstack-nova | 16:39 | |
*** lucas___ has quit IRC | 16:39 | |
*** dave-mccowan has quit IRC | 16:40 | |
*** unicell has joined #openstack-nova | 16:40 | |
*** dave-mc__ has quit IRC | 16:41 | |
*** ildikov has joined #openstack-nova | 16:42 | |
smatzek | danpb: smatzek face-palms. Thank for pointing out the obvious. I was so focused on the fields in ImageMetaProps I completely missed the ImageMeta fields. | 16:43 |
*** jgriffith has quit IRC | 16:44 | |
*** rotbeard has quit IRC | 16:44 | |
*** marzif has quit IRC | 16:45 | |
*** kiran has joined #openstack-nova | 16:45 | |
*** dave-mccowan has joined #openstack-nova | 16:45 | |
*** xyang2 has joined #openstack-nova | 16:45 | |
dimsum__ | mriedem: was there a bug opened for that segmentation fault in test_clean_shutdown_failure? | 16:47 |
*** iamjarvo has joined #openstack-nova | 16:47 | |
leakypipes | mriedem: done | 16:47 |
*** dave-mcc_ has quit IRC | 16:47 | |
danpb | dimsum__: https://bugs.launchpad.net/nova/+bug/1482230 | 16:47 |
openstack | Launchpad bug 1482230 in OpenStack Compute (nova) "LibvirtConnTestCase.test_clean_shutdown_first_time segfaults" [High,Fix committed] - Assigned to Daniel Berrange (berrange) | 16:47 |
*** meghal has quit IRC | 16:48 | |
openstackgerrit | Carlos Gonçalves proposed openstack/python-novaclient: Support forcing service down https://review.openstack.org/185849 | 16:48 |
*** tojuvone has joined #openstack-nova | 16:49 | |
dimsum__ | thanks danpb | 16:49 |
danpb | fingers crossed it is fixed now | 16:49 |
superdan | leakypipes: is it worth getting a sign-off from another glance person? | 16:50 |
*** dave-mcc_ has joined #openstack-nova | 16:50 | |
leakypipes | danpb: I've rebased onto that patch for 3 different branches locally and have not run into the bug again yet (about 5 test runs) | 16:50 |
dimsum__ | :) | 16:50 |
superdan | I mean if it passes tests, then it's probably good, but we do use v1 and something else could lurk | 16:50 |
leakypipes | superdan: sorry, for what? | 16:50 |
superdan | leakypipes: the glance service catalog thing | 16:50 |
*** claudiub has quit IRC | 16:50 | |
leakypipes | superdan: no, I don't think so. It's really the keystone folks that are the correct SMEs there. | 16:51 |
superdan | okay | 16:51 |
*** kiran-r has joined #openstack-nova | 16:51 | |
*** dave-mccowan has quit IRC | 16:51 | |
*** dave-mccowan has joined #openstack-nova | 16:51 | |
*** tonytan4ever has quit IRC | 16:52 | |
openstackgerrit | Ed Leafe proposed openstack/nova: Move existing V2 to legacy_v2 https://review.openstack.org/193725 | 16:52 |
openstackgerrit | Ed Leafe proposed openstack/nova: Move the v3 files into the main directories https://review.openstack.org/210131 | 16:52 |
figleaf | johnthetubaguy: alex_xu: ^ pushed a rebased version of step 2 | 16:52 |
*** penick has joined #openstack-nova | 16:53 | |
*** rfolco has joined #openstack-nova | 16:53 | |
*** dave-mc__ has joined #openstack-nova | 16:54 | |
*** dave-mcc_ has quit IRC | 16:54 | |
kiran | Hi Every one, I'm from Cisco Nexus 1000v team. I have a question on the 'vhost-user' VIF driver. Today the 'plug' api 'plug_vhostuser()' in 'vif.py' supports OVS plug. We need to extend it to Nexus1000v plug. I want to check if there is some work to extend vhost-user interface to other than OVS plug. | 16:55 |
johnthetubaguy | figleaf: I have just finished that myself, hence the note above, never mind | 16:55 |
*** claudiub has joined #openstack-nova | 16:55 | |
johnthetubaguy | I think i screwed it up though, so I will try the other one | 16:56 |
*** dave-mccowan has quit IRC | 16:56 | |
*** MentalRay has joined #openstack-nova | 16:57 | |
*** dave-mccowan has joined #openstack-nova | 16:57 | |
*** penick has quit IRC | 16:57 | |
*** iamjarvo has quit IRC | 16:57 | |
*** lucasagomes is now known as lucas-beer | 16:58 | |
*** dave-mcc_ has joined #openstack-nova | 16:58 | |
*** dave-mc__ has quit IRC | 16:59 | |
*** lucas___ has joined #openstack-nova | 16:59 | |
*** meghal has joined #openstack-nova | 16:59 | |
*** MentalRay has quit IRC | 17:00 | |
*** meghal has quit IRC | 17:00 | |
*** dprince has quit IRC | 17:01 | |
*** dave-mccowan has quit IRC | 17:02 | |
openstackgerrit | Zhongcheng Lao proposed openstack/nova: Skip detach when volume is no longer in-use https://review.openstack.org/210534 | 17:02 |
*** salv-orlando has joined #openstack-nova | 17:02 | |
*** MentalRay has joined #openstack-nova | 17:03 | |
*** lucas___ has quit IRC | 17:03 | |
*** dave-mccowan has joined #openstack-nova | 17:04 | |
*** MentalRay has quit IRC | 17:04 | |
*** lucas___ has joined #openstack-nova | 17:05 | |
*** dave-mcc_ has quit IRC | 17:06 | |
*** salv-orl_ has quit IRC | 17:06 | |
*** kiran-r has quit IRC | 17:07 | |
johnthetubaguy | figleaf: looking at that first patch, its this bit that confuses me: nova/tests/functional/test_access_ips.py | 17:07 |
johnthetubaguy | figleaf: why did you move those? | 17:07 |
*** dave-mcc_ has joined #openstack-nova | 17:08 | |
*** exploreshaifali has joined #openstack-nova | 17:09 | |
*** dannywilson has joined #openstack-nova | 17:09 | |
*** browne has joined #openstack-nova | 17:10 | |
figleaf | johnthetubaguy: because you asked me to? :) See your comment on PS 24 from Aug 5 09:38 | 17:11 |
*** dave-mccowan has quit IRC | 17:11 | |
johnthetubaguy | figleaf: that was not about nova/tests/functional/v3/test_networks.py that was about nova/tests/unit/api/openstack/compute/contrib/test_access_ips.py right? | 17:12 |
johnthetubaguy | the v3 ones are v3, the contrib ones are v2 | 17:13 |
johnthetubaguy | anyways, I think its getting closer now here | 17:13 |
*** danpb has quit IRC | 17:13 | |
*** dave-mccowan has joined #openstack-nova | 17:13 | |
figleaf | johnthetubaguy: ah - wrong 'test_access_ips' :( | 17:14 |
*** kiran has left #openstack-nova | 17:14 | |
*** dave-mcc_ has quit IRC | 17:14 | |
johnthetubaguy | figleaf: those ones in the functional directory really really need to be in a sub directory, maybe api_v21 or something like that | 17:15 |
figleaf | johnthetubaguy: it moved from nova/tests/functional/v3 to nova/tests/functional. Probably should have been in phase 2 | 17:15 |
johnthetubaguy | yeah, should have been phase2, and into a sub directory, but lets level that for right this second, just finishing off the tests | 17:15 |
*** dave-mcc_ has joined #openstack-nova | 17:16 | |
*** vilobhmm has joined #openstack-nova | 17:16 | |
*** dave-mc__ has joined #openstack-nova | 17:18 | |
*** dave-mccowan has quit IRC | 17:18 | |
*** apuimedo has quit IRC | 17:20 | |
*** meghal has joined #openstack-nova | 17:21 | |
*** dave-mcc_ has quit IRC | 17:21 | |
*** apuimedo has joined #openstack-nova | 17:22 | |
*** VW__ has quit IRC | 17:22 | |
*** tjones has joined #openstack-nova | 17:23 | |
*** VW_ has joined #openstack-nova | 17:23 | |
*** VW_ has quit IRC | 17:23 | |
*** VW_ has joined #openstack-nova | 17:24 | |
*** nic1 has joined #openstack-nova | 17:24 | |
johnthetubaguy | figleaf: seeing the same failures we had before, once I fixed up the rebase | 17:25 |
*** dave-mccowan has joined #openstack-nova | 17:25 | |
johnthetubaguy | figleaf: I think we need to go back and tidy up that first change, there is stuff thats moved to odd locations, let me add comments | 17:25 |
*** nic has quit IRC | 17:26 | |
johnthetubaguy | figleaf: I am thinking we should go back to patchset 24, were life was simpler? | 17:27 |
*** praneshp has joined #openstack-nova | 17:27 | |
*** dave-mcc_ has joined #openstack-nova | 17:27 | |
*** markus_z has quit IRC | 17:27 | |
*** dave-mc__ has quit IRC | 17:28 | |
johnthetubaguy | figleaf: I wonder if we should do this in a feature branch, so we get the single commit merge back in, that might be easier | 17:28 |
*** VW__ has joined #openstack-nova | 17:28 | |
*** VW_ has quit IRC | 17:28 | |
*** thorst has quit IRC | 17:28 | |
johnthetubaguy | figleaf: sorry, I am exhausted now, and not making progress, I am probably going to call it a day in a little bit | 17:29 |
*** ijw has quit IRC | 17:29 | |
figleaf | johnthetubaguy: understood. I'm stressed a bit too - closing on a house later this afternoon :) | 17:29 |
*** dave-mccowan has quit IRC | 17:30 | |
*** meghal has quit IRC | 17:31 | |
_gryf | superdan, hi :) | 17:31 |
*** dave-mcc_ has quit IRC | 17:31 | |
*** hshiina has quit IRC | 17:31 | |
*** meghal has joined #openstack-nova | 17:31 | |
*** shyama has joined #openstack-nova | 17:32 | |
superdan | _gryf: hola | 17:32 |
*** dave-mccowan has joined #openstack-nova | 17:32 | |
*** meghal has quit IRC | 17:32 | |
*** meghal has joined #openstack-nova | 17:32 | |
*** ndipanov has quit IRC | 17:32 | |
_gryf | superdan, about the patch https://review.openstack.org/#/c/209766/ . Is there still nothing we can do about that mr jenkins failure? | 17:32 |
*** VW__ has quit IRC | 17:32 | |
*** ftersin has joined #openstack-nova | 17:33 | |
superdan | _gryf: I think the patch we think will fix it just landed | 17:33 |
superdan | _gryf: so, try a recheck | 17:33 |
superdan | if it passes, it'll go in | 17:33 |
*** READ10 has quit IRC | 17:33 | |
_gryf | superdan, cool. I'm on it | 17:33 |
*** dave-mcc_ has joined #openstack-nova | 17:33 | |
*** bertys_ has joined #openstack-nova | 17:34 | |
leakypipes | superdan: https://review.openstack.org/#/c/146887/ if you have a chance. had a +2 from danpb before a rebase, but danpb is gone now. | 17:35 |
superdan | okay in a sec | 17:36 |
*** dave-mccowan has quit IRC | 17:36 | |
*** dave-mccowan has joined #openstack-nova | 17:38 | |
*** dave-mcc_ has quit IRC | 17:39 | |
*** dave-mcc_ has joined #openstack-nova | 17:43 | |
*** achanda has joined #openstack-nova | 17:44 | |
*** dave-mccowan has quit IRC | 17:45 | |
*** bertys_ has quit IRC | 17:46 | |
*** dave-mccowan has joined #openstack-nova | 17:46 | |
*** dave-mcc_ has quit IRC | 17:47 | |
sdague | johnthetubaguy: ok, here's kind of a new standing agenda for the API meeting - https://wiki.openstack.org/wiki/Meetings/NovaAPI#Agenda | 17:48 |
cfriesen | zzzeek: you around? | 17:48 |
zzzeek | cfriesen: hey | 17:50 |
*** dave-mcc_ has joined #openstack-nova | 17:51 | |
*** thorst has joined #openstack-nova | 17:51 | |
*** ijuwang has joined #openstack-nova | 17:52 | |
*** ijw has joined #openstack-nova | 17:52 | |
*** dave-mccowan has quit IRC | 17:53 | |
*** burgerk has quit IRC | 17:55 | |
cfriesen | zzzeek: I recently reported bug 1482416 and alaski suggested I ping you. | 17:55 |
openstack | bug 1482416 in OpenStack Compute (nova) "bug blocks DB migration that changes column type" [Undecided,New] https://launchpad.net/bugs/1482416 | 17:55 |
*** hshiina has joined #openstack-nova | 17:55 | |
*** VW_ has joined #openstack-nova | 17:55 | |
*** lucas___ has quit IRC | 17:56 | |
*** dave-mccowan has joined #openstack-nova | 17:56 | |
cfriesen | zzzeed: it seems to be due to the fact that sqlite doesn't support altering columns, but it's colliding with constraints on other columns and I don't know enough about what's going on under the hood | 17:57 |
*** iamjarvo has joined #openstack-nova | 17:57 | |
*** dave-mc__ has joined #openstack-nova | 17:58 | |
*** dave-mcc_ has quit IRC | 17:59 | |
zzzeek | im goign to guess this is the same code that iterates through tables in test teardown and emits DROP CONSTRAINT for all the foreign keys ? | 18:01 |
zzzeek | oh | 18:01 |
*** dave-mccowan has quit IRC | 18:01 | |
zzzeek | cfriesen: nova doesnt support changes in column types anymore | 18:02 |
zzzeek | cfriesen: that wont work with non-scripted online schema migrations | 18:02 |
*** dave-mccowan has joined #openstack-nova | 18:02 | |
harlowja | is there a scheduling subchannel ? | 18:05 |
harlowja | and/or gantt channel? | 18:05 |
*** ssurana has quit IRC | 18:05 | |
*** hshiina has quit IRC | 18:05 | |
*** dave-mc__ has quit IRC | 18:05 | |
*** dannywilson has quit IRC | 18:05 | |
harlowja | and/or other place? | 18:05 |
*** dannywilson has joined #openstack-nova | 18:06 | |
*** salv-orlando has quit IRC | 18:07 | |
*** dave-mcc_ has joined #openstack-nova | 18:07 | |
*** dave-mccowan has quit IRC | 18:09 | |
mriedem | figleaf: ^ | 18:09 |
cfriesen | zzzeek: we supported it before, so what changed? (And what's the issue, since it seems to work at runtime with a "real" DB.) | 18:09 |
*** rushil has quit IRC | 18:10 | |
*** jdandrea has left #openstack-nova | 18:10 | |
mriedem | cfriesen: it's part of the larger effort to have no downtime upgrades, so the schema changes are additive until there is one big constraction that you opt into when ready | 18:10 |
mriedem | from what i understand anyway | 18:10 |
cfriesen | zzzeed: also, what's the "correct" way to handle something like this? | 18:10 |
*** dave-mccowan has joined #openstack-nova | 18:11 | |
mriedem | cfriesen: see https://review.openstack.org/#/c/197349/ | 18:11 |
cfriesen | mriedem: okay, will take a look | 18:11 |
*** kmARC has joined #openstack-nova | 18:11 | |
zzzeek | cfriesen: im not a nova dev. take a look at http://docs.openstack.org/developer/nova/devref/upgrade.html | 18:12 |
zzzeek | cfriesen: as far as “whats the issue”, noted on the bug report. nova should not be testing migrations against sqlite | 18:12 |
*** kmARC_ has joined #openstack-nova | 18:12 | |
*** dave-mc__ has joined #openstack-nova | 18:12 | |
cfriesen | zzzeek: are the nova devs aware of this? :) | 18:13 |
*** dave-mcc_ has quit IRC | 18:13 | |
zzzeek | cfriesen: probably | 18:13 |
cfriesen | mriedem: I see. And changing a column type counts as a subtractive change. | 18:14 |
*** armax has joined #openstack-nova | 18:14 | |
mriedem | cfriesen: well, sqlite doesn't support alter | 18:14 |
mriedem | so in sqlite land you have to drop and add | 18:14 |
*** kurtmartin has quit IRC | 18:14 | |
*** dave-mcc_ has joined #openstack-nova | 18:15 | |
cfriesen | mriedem: okay, makes sense. thanks. | 18:15 |
mriedem | e.g. https://github.com/stackforge/sqlalchemy-migrate/commit/ae64d828df9debe61283ca7aa436bdbf0b49d0e7 | 18:15 |
*** dave-mccowan has quit IRC | 18:15 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Copy cli arguments in api_versions.wraps decorator https://review.openstack.org/210563 | 18:16 |
*** ijw_ has joined #openstack-nova | 18:16 | |
*** dave-mccowan has joined #openstack-nova | 18:16 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova: Changed backporting of embedded Network object when backporting a FixedIP https://review.openstack.org/173723 | 18:17 |
*** dave-mc__ has quit IRC | 18:17 | |
openstackgerrit | Vilobh Meshram proposed openstack/nova-specs: Quota by Flavor, Quota by AZ, Quota by X https://review.openstack.org/206160 | 18:18 |
*** shyama has quit IRC | 18:18 | |
mriedem | cfriesen: notes in https://bugs.launchpad.net/nova/+bug/1482416/comments/4 | 18:18 |
openstack | Launchpad bug 1482416 in OpenStack Compute (nova) "bug blocks DB migration that changes column type" [Undecided,New] | 18:18 |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Set vif and allocated when associating fixed ip https://review.openstack.org/197135 | 18:19 |
*** ijw has quit IRC | 18:19 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova: Changed backporting of embedded Network object when backporting a FixedIP https://review.openstack.org/173723 | 18:19 |
*** rlrossit has left #openstack-nova | 18:19 | |
*** dave-mcc_ has quit IRC | 18:20 | |
*** dave-mccowan has quit IRC | 18:21 | |
*** josecastroleon has joined #openstack-nova | 18:21 | |
cfriesen | mriedem: zzzeek: thanks guys. mriedem: are you aware of any plans to drop migration testing on sqlite? or do we just live with the limitations? | 18:21 |
*** sudipto__ has quit IRC | 18:21 | |
mriedem | eliqiao: are you going to rebase this at some point? https://review.openstack.org/#/c/156112/ | 18:22 |
mriedem | cfriesen: i'm not aware of plans to stop using sqlite in db migration testing | 18:22 |
*** lpetrut has quit IRC | 18:22 | |
*** dave-mccowan has joined #openstack-nova | 18:24 | |
*** patrickeast has quit IRC | 18:24 | |
*** ssurana has joined #openstack-nova | 18:25 | |
*** xyang2 has quit IRC | 18:26 | |
*** bapalm has joined #openstack-nova | 18:26 | |
*** imcsk8 has joined #openstack-nova | 18:27 | |
imcsk8 | hello, is the nova v3 api still experimental? | 18:28 |
mriedem | imcsk8: v3 is v2.1 and no | 18:28 |
mriedem | it's CURRENT | 18:28 |
*** dave-mcc_ has joined #openstack-nova | 18:29 | |
mriedem | http://docs.openstack.org/developer/nova/index.html#compute-api-references | 18:29 |
mriedem | imcsk8: maybe helpful https://www.openstack.org/summit/vancouver-2015/summit-videos/presentation/introduction-of-a-new-nova-rest-api-why-we-need-to-use-nova-v2-1-api | 18:30 |
* mriedem thinks maybe we should link that summit video into the docs | 18:30 | |
imcsk8 | mriedem: thanks | 18:31 |
*** dave-mc__ has joined #openstack-nova | 18:31 | |
*** dave-mccowan has quit IRC | 18:32 | |
*** otter768 has joined #openstack-nova | 18:33 | |
*** xyang2 has joined #openstack-nova | 18:33 | |
*** dave-mcc_ has quit IRC | 18:33 | |
*** melwitt has joined #openstack-nova | 18:33 | |
*** xyang2 has quit IRC | 18:34 | |
figleaf | harlowja: no, no separate scheduling channel. Dis is da place | 18:34 |
harlowja | figleaf ok, i just started https://review.openstack.org/#/c/210549/ which thought those folks might be interested in | 18:35 |
harlowja | (imho something long overdue, and i *think* gantt folks and others want to get there to...) | 18:35 |
*** meghal has quit IRC | 18:36 | |
*** dave-mccowan has joined #openstack-nova | 18:36 | |
figleaf | harlowja: be sure to add it to the scheduler for Monday's meeting at 1400UTC | 18:36 |
harlowja | k, i'll try :-P | 18:36 |
harlowja | or will just use spec/ML for this stuff, ha | 18:36 |
*** dave-mcc_ has joined #openstack-nova | 18:37 | |
figleaf | harlowja: fwiw, I think that you might need a bit more detail. We all want a scheduler-for-all-the-things, but how to achieve that is where it gets contentious | 18:37 |
*** otter768 has quit IRC | 18:37 | |
*** bapalm has quit IRC | 18:38 | |
harlowja | figleaf of course, its a WIP after all ;) | 18:38 |
harlowja | and thats why we have this cross-project stuff in the first place, and a TC body and blah blah | 18:38 |
*** dave-mc__ has quit IRC | 18:38 | |
figleaf | harlowja: heh | 18:38 |
harlowja | if we can't get past the 'contentious' part, we are all screwed | 18:38 |
harlowja | *imho* | 18:38 |
figleaf | harlowja: I just meant that actual designs get more eyeballs than generic "we need to be better" stuff | 18:39 |
*** lyanchih has quit IRC | 18:39 | |
*** dave-mc__ has joined #openstack-nova | 18:39 | |
chhavi | johnthetubaguy: We are looking at the proposed shared volume feature. We'd like to implement it for our PowerVM driver as well, but if there is anything more general that we can do to help in the M release, can you let me know? | 18:39 |
figleaf | harlowja: of course, there will be dozens of people ready to tell you why your ideas can never work, but that seems to be typical around here | 18:39 |
harlowja | figleaf understood, imho its a balance because, actual designs to early create locally optimally project decisions, which is how we got in this situation in the first place | 18:40 |
harlowja | :-P | 18:40 |
*** dave-mccowan has quit IRC | 18:40 | |
figleaf | harlowja: only if they have a single project in mind. | 18:40 |
mriedem | lascii: http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/15/210515/1/7541//logs/screen-n-cpu.txt.gz | 18:40 |
mriedem | bw_usage[field] = db_bw_usage['uuid'] | 18:40 |
mriedem | TypeError: 'NoneType' object has no attribute '__getitem__' | 18:41 |
figleaf | harlowja: if they are designed to be project-agnostic, much less so | 18:41 |
*** yassine_ has quit IRC | 18:41 | |
mriedem | lascii: that's from https://review.openstack.org/#/c/189397/ but that's a long time ago | 18:41 |
mriedem | hrm oslo.versionedobjects==0.7.0 | 18:41 |
*** dave-mccowan has joined #openstack-nova | 18:41 | |
harlowja | figleaf agreed, its a multi-dimensonal strike force kind of effort required here, haha | 18:41 |
mriedem | 0.7.0 released on 8/3 | 18:42 |
*** dave-mcc_ has quit IRC | 18:42 | |
harlowja | u take the left flank, lol | 18:42 |
*** ftersin has quit IRC | 18:42 | |
*** xyang2 has joined #openstack-nova | 18:43 | |
*** dave-mcc_ has joined #openstack-nova | 18:43 | |
figleaf | harlowja: https://www.youtube.com/watch?v=Nrh5YOQHvFw | 18:43 |
mriedem | BobBall: are you around? | 18:43 |
*** dave-mc__ has quit IRC | 18:43 | |
harlowja | figleaf nice :) | 18:44 |
harlowja | pew pew pew | 18:44 |
harlowja | lol | 18:44 |
*** xyang2 has quit IRC | 18:44 | |
*** dave-mc__ has joined #openstack-nova | 18:44 | |
dimsum__ | "I don't listen to hip-hop"! | 18:45 |
*** dave-m___ has joined #openstack-nova | 18:46 | |
lascii | mriedem: is that a xenserver run? | 18:46 |
mriedem | yeah | 18:46 |
*** dave-mccowan has quit IRC | 18:46 | |
openstackgerrit | Jay Pipes proposed openstack/nova: pci: Move whitelist filtering inside PCI tracker https://review.openstack.org/210182 | 18:47 |
openstackgerrit | Jay Pipes proposed openstack/nova: pci: Remove get_pci_devices_filter() method https://review.openstack.org/210183 | 18:47 |
openstackgerrit | Jay Pipes proposed openstack/nova: pci: Use fields.Enum type for PCI device status https://review.openstack.org/210180 | 18:47 |
openstackgerrit | Jay Pipes proposed openstack/nova: pci: Use fields.Enum type for PCI device type https://review.openstack.org/210181 | 18:47 |
lascii | that needs another, related, fix. but I thought it had merged a while ago | 18:47 |
*** meghal has joined #openstack-nova | 18:47 | |
*** dave-mccowan has joined #openstack-nova | 18:47 | |
*** dave-mcc_ has quit IRC | 18:47 | |
mriedem | https://bugs.launchpad.net/nova/+bug/1482738 | 18:47 |
openstack | Launchpad bug 1482738 in OpenStack Compute (nova) "_poll_bandwidth_usage task fails to create bw usage object with TypeError" [Undecided,New] | 18:47 |
mriedem | i guess since it's a periodic task no one would notice | 18:47 |
lascii | yeah, and only on xen | 18:47 |
mriedem | that task only works for xen | 18:48 |
mriedem | ? | 18:48 |
*** bapalm has joined #openstack-nova | 18:48 | |
*** bapalm has quit IRC | 18:48 | |
lascii | possibly others now, but xen is the only driver I know of that implements the method it relies on | 18:48 |
mriedem | Interval to pull network bandwidth usage info. Not ' 'supported on all hypervisors. Set to -1 to disable. ' 'Setting this to 0 will run at the default rate. | 18:49 |
mriedem | yeah, i guess the help says that | 18:49 |
*** dave-mc__ has quit IRC | 18:49 | |
*** dave-mcc_ has joined #openstack-nova | 18:49 | |
lascii | oh, the other fix didn't merge yet | 18:49 |
lascii | https://review.openstack.org/#/c/172524/ | 18:50 |
*** chhavi has quit IRC | 18:50 | |
lascii | missed that it was still open | 18:50 |
mriedem | rechecked :) | 18:50 |
mriedem | c'mon lascii! | 18:50 |
*** dave-m___ has quit IRC | 18:50 | |
lascii | I know, my shame is visible to all now | 18:51 |
melwitt | I was about to ask if that review is needed to stop this bug. I'm too slow | 18:51 |
openstackgerrit | Jay Pipes proposed openstack/nova: Refactor unit test for InstanceGroup objects https://review.openstack.org/197228 | 18:51 |
*** dave-mccowan has quit IRC | 18:51 | |
*** josecastroleon has quit IRC | 18:51 | |
*** dave-mccowan has joined #openstack-nova | 18:52 | |
mriedem | lascii: is there potentially any goofy thing with the xenserver driver and how it uploads images to glance via some plugin that it requires the x-service-catalog entry in the glance api request header? | 18:53 |
*** rfolco has quit IRC | 18:53 | |
mriedem | please say no, please say no, please say no | 18:53 |
*** agireud_ has joined #openstack-nova | 18:53 | |
lascii | mriedem: ye... no | 18:54 |
mriedem | Failure: ['XENAPI_PLUGIN_FAILURE', 'upload_vhd', 'PluginError', 'Got Permanent Error response [404] while uploading image [a19c924d-50f7-4649-a78b-ad80543ba8d9] to glance host [192.168.33.1:9292]'] | 18:54 |
*** dave-mcc_ has quit IRC | 18:54 | |
mriedem | http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/15/210515/1/7541//logs/screen-n-cpu.txt.gz | 18:54 |
*** dave-mcc_ has joined #openstack-nova | 18:54 | |
*** ttrumm has joined #openstack-nova | 18:54 | |
*** kmARC has quit IRC | 18:55 | |
*** kmARC_ has quit IRC | 18:55 | |
*** agireud has quit IRC | 18:55 | |
*** agireud_ is now known as agireud | 18:55 | |
lascii | mriedem: the interesting logs for that are going to be on the dom0, not the compute logs | 18:56 |
*** dboik_ has quit IRC | 18:57 | |
*** dave-mccowan has quit IRC | 18:57 | |
mriedem | do those get published for xenserver ci runs? | 18:57 |
mriedem | not seeing anything | 18:58 |
*** jecarey has joined #openstack-nova | 18:58 | |
mriedem | ooo http://dd6b71949550285df7dc-dda4e480e005aaa13ec303551d2d8155.r49.cf1.rackcdn.com/15/210515/1/7541//logs/var/log/index.html | 18:58 |
*** dave-mccowan has joined #openstack-nova | 18:59 | |
*** neelabh has quit IRC | 18:59 | |
*** yamahata has quit IRC | 18:59 | |
*** dave-mcc_ has quit IRC | 19:00 | |
lascii | hmm, not finding the plugin logs. though I can never remember which log they're in | 19:01 |
*** Piet has quit IRC | 19:02 | |
lascii | Aug 07 17:30:40 localhost glance: ERROR Unexpected response while doing a HEAD call to image 7bc054ef-a379-4259-8369-e9a82d47d1ed , url = http://192.168.33.1:9292/v1/images/7bc054ef-a379-4259-8369-e9a82d47d1ed , Response Status: 404 | 19:02 |
*** dave-mcc_ has joined #openstack-nova | 19:02 | |
*** Piet has joined #openstack-nova | 19:02 | |
*** xyang2 has joined #openstack-nova | 19:03 | |
*** xyang2 has quit IRC | 19:04 | |
*** tjones has quit IRC | 19:05 | |
*** dave-mccowan has quit IRC | 19:05 | |
*** tjones has joined #openstack-nova | 19:07 | |
*** burgerk has joined #openstack-nova | 19:09 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: docs: add link to liberty summit session on v2.1 API https://review.openstack.org/210587 | 19:09 |
mriedem | lascii: ok, i just wanted to make sure that glance wasn't expecting x-service-catalog per https://review.openstack.org/#/c/210515/ | 19:09 |
mriedem | *xenapi | 19:09 |
mriedem | since it was added for some xen thing back in the day, and there are related xenapi unit tests | 19:09 |
*** dave-mccowan has joined #openstack-nova | 19:10 | |
*** jecarey has quit IRC | 19:11 | |
*** smatzek has quit IRC | 19:11 | |
*** davideagnello has joined #openstack-nova | 19:12 | |
*** ttrumm has quit IRC | 19:13 | |
*** dave-mcc_ has quit IRC | 19:13 | |
*** busterswt has quit IRC | 19:13 | |
lascii | mriedem: gotcha. that was never really a xen thing, it was for our noauth glance setup | 19:13 |
lascii | xen just passed it through | 19:14 |
*** jecarey has joined #openstack-nova | 19:15 | |
*** davideag_ has quit IRC | 19:15 | |
lascii | and as far as I can tell it's not something we use. I can't find any code for it | 19:15 |
mriedem | ok, cool | 19:16 |
*** dave-mcc_ has joined #openstack-nova | 19:16 | |
mriedem | i know you rax boyz and your crazy glance adventures | 19:16 |
lascii | yep, it mostly consists of glance drinking too much and making a mess for the rest of us to clean up | 19:16 |
mriedem | like this http://logs.openstack.org/00/209200/11/check/gate-neutron-lbaasv1-dsvm-api/e205cb7/logs/screen-g-api.txt.gz#_2015-08-07_18_47_55_313 | 19:18 |
*** dave-mccowan has quit IRC | 19:18 | |
*** burgerk has quit IRC | 19:18 | |
mriedem | http://goo.gl/C459X6 | 19:18 |
*** dave-mccowan has joined #openstack-nova | 19:19 | |
*** echoingumesh has joined #openstack-nova | 19:19 | |
*** dave-mcc_ has quit IRC | 19:20 | |
mriedem | mtreinish: figured it out | 19:20 |
mriedem | https://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/healthcheck/disable_by_file.py#L49 | 19:20 |
mriedem | http://git.openstack.org/cgit/openstack/glance/tree/etc/glance-api-paste.ini#n56 | 19:20 |
mriedem | /etc/glance/healthcheck_disable doesn't exist | 19:21 |
mriedem | http://logs.openstack.org/00/209200/11/check/gate-neutron-lbaasv1-dsvm-api/e205cb7/logs/etc/glance/ | 19:21 |
mriedem | blam | 19:21 |
mtreinish | ah, ok that would do it | 19:22 |
*** dave-mcc_ has joined #openstack-nova | 19:22 | |
*** xyang2 has joined #openstack-nova | 19:22 | |
*** xyang2 has quit IRC | 19:24 | |
*** agireud has quit IRC | 19:24 | |
*** dave-mccowan has quit IRC | 19:24 | |
*** agireud has joined #openstack-nova | 19:27 | |
*** tongli has quit IRC | 19:28 | |
*** yamahata has joined #openstack-nova | 19:28 | |
*** dave-mccowan has joined #openstack-nova | 19:30 | |
*** dave-mcc_ has quit IRC | 19:32 | |
*** claudiub has quit IRC | 19:33 | |
*** dave-mcc_ has joined #openstack-nova | 19:33 | |
*** meghal has quit IRC | 19:33 | |
*** exploreshaifali has quit IRC | 19:34 | |
*** alexpilotti has quit IRC | 19:35 | |
*** dave-mccowan has quit IRC | 19:36 | |
*** tjones has quit IRC | 19:36 | |
*** ildikov has quit IRC | 19:37 | |
*** claudiub has joined #openstack-nova | 19:38 | |
*** dave-mccowan has joined #openstack-nova | 19:39 | |
*** boris-42 has joined #openstack-nova | 19:40 | |
*** dave-mcc_ has quit IRC | 19:41 | |
*** MVenesio has quit IRC | 19:45 | |
*** andrewbogott has left #openstack-nova | 19:46 | |
*** dannywilson has quit IRC | 19:47 | |
*** dave-mcc_ has joined #openstack-nova | 19:47 | |
melwitt | lascii: I was just looking at https://review.openstack.org/#/c/207587/ and was wondering, if the instance doesn't exist in the child cell, how does instance_destroy_at_top get called by that child? I thought it would error out before it could call destroy_at_top | 19:48 |
*** dave-mccowan has quit IRC | 19:50 | |
*** dave-mccowan has joined #openstack-nova | 19:51 | |
lascii | melwitt: let me dig that up. That's what I would have expected as well since this case isn't really accounted for, but it was getting called somewhere | 19:52 |
*** dave-mc__ has joined #openstack-nova | 19:52 | |
*** dave-mcc_ has quit IRC | 19:52 | |
*** echoingumesh has quit IRC | 19:53 | |
*** dave-mcc_ has joined #openstack-nova | 19:54 | |
*** dane-fichter has quit IRC | 19:54 | |
*** echoingumesh has joined #openstack-nova | 19:54 | |
melwitt | lascii: and getting called without "id" set, I also didn't yet find how that's possible since I thought the instance is looked up in the db at the top first, then passed down to the child and back up. I didn't find the Instance construction with just the uuid | 19:54 |
lascii | melwitt: there's still some spots where objects are getting converted to uuids to be passed around in cells | 19:55 |
*** salv-orlando has joined #openstack-nova | 19:55 | |
*** dave-mccowan has quit IRC | 19:55 | |
*** xyang1 has joined #openstack-nova | 19:55 | |
*** dave-mccowan has joined #openstack-nova | 19:55 | |
*** dave-mc__ has quit IRC | 19:57 | |
*** ildikov has joined #openstack-nova | 19:57 | |
melwitt | lascii: I think maybe I see it, in cells/messaging.py L687 | 19:57 |
*** iamjarvo has quit IRC | 19:57 | |
lascii | melwitt: close, 832 | 19:58 |
*** VW_ has quit IRC | 19:58 | |
lascii | called from http://git.openstack.org/cgit/openstack/nova/tree/nova/cells/messaging.py#n868 | 19:58 |
*** echoingumesh has quit IRC | 19:58 | |
*** dave-mcc_ has quit IRC | 19:58 | |
melwitt | lascii: ah, okay. there we go | 19:58 |
*** VW_ has joined #openstack-nova | 19:58 | |
lascii | I could try reusing instance there, but I'm not sure what state it's in after the failed refresh | 19:59 |
lascii | maybe I should copy it first, in case | 19:59 |
*** dave-mcc_ has joined #openstack-nova | 20:00 | |
*** dave-mcc_ has quit IRC | 20:00 | |
*** salv-orlando has quit IRC | 20:01 | |
*** dave-mccowan has quit IRC | 20:01 | |
*** VW_ has quit IRC | 20:03 | |
melwitt | lascii: hm, yeah maybe. I was just trying to wrap my brain around what was going on. it would seem like we could reuse it, a copy, considering we must have looked it up at the top in the first place | 20:03 |
melwitt | I'm not against looking it up again | 20:07 |
*** achanda has quit IRC | 20:08 | |
*** salv-orlando has joined #openstack-nova | 20:09 | |
*** echoingumesh has joined #openstack-nova | 20:12 | |
*** meghal has joined #openstack-nova | 20:12 | |
lascii | melwitt: okay. looking it up again keeps the fix in one place. otherwise I think there's 3 places that would need to be updated. not a big deal, but the current fix is a bit more future proof | 20:14 |
*** Guest81486 is now known as jgriffith | 20:16 | |
*** meghal has quit IRC | 20:17 | |
melwitt | lascii: yeah, I think that makes sense | 20:20 |
*** albertom has joined #openstack-nova | 20:23 | |
openstackgerrit | Shiina, Hironori proposed openstack/nova: Add a Nova API to inject an NMI https://review.openstack.org/202617 | 20:23 |
*** xyang has quit IRC | 20:28 | |
*** lucas-beer has quit IRC | 20:29 | |
*** otter768 has joined #openstack-nova | 20:33 | |
*** zul has joined #openstack-nova | 20:36 | |
*** ijw has joined #openstack-nova | 20:36 | |
*** tojuvone has quit IRC | 20:36 | |
*** otter768 has quit IRC | 20:38 | |
*** ijw_ has quit IRC | 20:40 | |
*** dustins has quit IRC | 20:41 | |
*** rushil has joined #openstack-nova | 20:43 | |
*** agireud has quit IRC | 20:50 | |
leakypipes | lascii, melwitt: would love reviews/feedback from you guys on this patch series, if you have any free time :) https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:pci-cleanup,n,z | 20:55 |
*** logan2 has quit IRC | 20:56 | |
*** raildo has quit IRC | 20:57 | |
melwitt | leakypipes: sure, will take a look | 20:58 |
*** agireud has joined #openstack-nova | 20:58 | |
*** chuckcarmack has left #openstack-nova | 20:59 | |
openstackgerrit | Hans Lindgren proposed openstack/nova: Remove/deprecate unused parts of the compute node object https://review.openstack.org/186757 | 20:59 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Make ComputeNode.service_id nullable to match db schema https://review.openstack.org/169284 | 20:59 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Avoid querying for Service in resource tracker https://review.openstack.org/169288 | 21:00 |
*** salv-orlando has quit IRC | 21:00 | |
leakypipes | melwitt: cheers | 21:00 |
lascii | leakypipes: it's at the front of the queue for monday. company is arriving so I need to bail here | 21:00 |
leakypipes | lascii: no worries, thanks Andrew! :) enjoy company | 21:01 |
*** htruta has quit IRC | 21:02 | |
*** lascii is now known as alaski | 21:02 | |
alaski | leakypipes: thanks | 21:02 |
*** meghal has joined #openstack-nova | 21:07 | |
*** agireud has quit IRC | 21:08 | |
*** achanda has joined #openstack-nova | 21:10 | |
*** lpetrut has joined #openstack-nova | 21:10 | |
*** aysyd has quit IRC | 21:12 | |
*** ijw_ has joined #openstack-nova | 21:14 | |
*** Piet has quit IRC | 21:14 | |
mriedem | leakypipes: i added rlrossit | 21:16 |
mriedem | he'll be happy to review objects patches | 21:16 |
*** ijw has quit IRC | 21:16 | |
leakypipes | thx! | 21:17 |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Copy cli arguments in api_versions.wraps decorator https://review.openstack.org/210563 | 21:18 |
*** meghal has quit IRC | 21:20 | |
*** mvensky has joined #openstack-nova | 21:22 | |
*** mriedem has quit IRC | 21:24 | |
*** markvoelker has quit IRC | 21:28 | |
*** Piet has joined #openstack-nova | 21:30 | |
*** baoli has quit IRC | 21:31 | |
*** meghal has joined #openstack-nova | 21:33 | |
*** meghal has quit IRC | 21:34 | |
*** meghal has joined #openstack-nova | 21:34 | |
*** logan2 has joined #openstack-nova | 21:39 | |
*** VW_ has joined #openstack-nova | 21:40 | |
*** ctrath has quit IRC | 21:44 | |
*** patrickeast has joined #openstack-nova | 21:48 | |
*** VW__ has joined #openstack-nova | 21:50 | |
*** tjones has joined #openstack-nova | 21:50 | |
*** salv-orlando has joined #openstack-nova | 21:52 | |
*** VW_ has quit IRC | 21:53 | |
openstackgerrit | Hans Lindgren proposed openstack/nova: Remove/deprecate conductor instance_update() https://review.openstack.org/189155 | 21:54 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Make compute manager instance updates use objects https://review.openstack.org/189154 | 21:54 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Consolidate _set_instance_error_state() methods https://review.openstack.org/210614 | 21:54 |
*** VW__ has quit IRC | 21:54 | |
*** mriedem has joined #openstack-nova | 21:54 | |
mvensky | any hints are where to start with nova source; any good docs/references | 21:57 |
mvensky | ? | 21:57 |
melwitt | mvensky: http://docs.openstack.org/developer/nova/ | 21:59 |
*** salv-orlando has quit IRC | 22:02 | |
mvensky | thanks melwitt | 22:04 |
*** mdrabe has quit IRC | 22:07 | |
*** thorst has quit IRC | 22:08 | |
*** tjones has quit IRC | 22:13 | |
*** lpetrut1 has joined #openstack-nova | 22:15 | |
*** lpetrut has quit IRC | 22:18 | |
*** dims_ has joined #openstack-nova | 22:18 | |
*** nikhil_k has quit IRC | 22:19 | |
*** nikhil_k has joined #openstack-nova | 22:20 | |
*** tjones has joined #openstack-nova | 22:21 | |
*** sulo has quit IRC | 22:21 | |
*** edmondsw has quit IRC | 22:21 | |
*** dimsum__ has quit IRC | 22:22 | |
*** sulo has joined #openstack-nova | 22:23 | |
*** rushil has quit IRC | 22:24 | |
cfriesen | I'm running "nova stop" as a regular user but nova-api is seeing the command come in with an admin context. Anyone have any ideas what might cause that? (This is with a modified kilo/stable, so it's entirely possible we screwed something up.) | 22:25 |
cfriesen | The "nova start" command is seen as having the expected context. | 22:26 |
*** Piet has quit IRC | 22:26 | |
zzzeek | OK, I am totally at a loss for how https://review.openstack.org/#/c/192760/14 is passing tests on the gate, the same tests that run there fail as expected for me at http://paste.openstack.org/show/412236/, because the code is wrong | 22:26 |
*** figleaf is now known as edleafe | 22:26 | |
zzzeek | maybe oslo.db versions are different | 22:26 |
*** markvoelker has joined #openstack-nova | 22:28 | |
*** tsekiyama has quit IRC | 22:30 | |
*** r-daneel has quit IRC | 22:31 | |
*** mtanino has quit IRC | 22:31 | |
*** tsekiyama has joined #openstack-nova | 22:33 | |
*** claudiub has quit IRC | 22:33 | |
*** markvoelker has quit IRC | 22:33 | |
*** otter768 has joined #openstack-nova | 22:34 | |
*** davideagnello has quit IRC | 22:37 | |
*** davideagnello has joined #openstack-nova | 22:37 | |
*** tjones has quit IRC | 22:39 | |
*** otter768 has quit IRC | 22:39 | |
*** edmund1 has quit IRC | 22:39 | |
mvensky | I'm relatively new to python and wanted to use openstack/nova to get deeper into the language; I've downloaded the source; any hints on where to start in the code to start understanding it; or architectual docs that will help guide me along? | 22:42 |
* zzzeek suggests, get a drink first | 22:43 | |
mvensky | done thank, next | 22:43 |
zzzeek | that’s all I know about nova source :) | 22:43 |
*** salv-orlando has joined #openstack-nova | 22:44 | |
mvensky | oh good, I thought it was going to be difficult | 22:44 |
*** leeantho has quit IRC | 22:45 | |
*** Nikolay_St has quit IRC | 22:45 | |
zzzeek | mvensky: if you want to study source code to learn more about python, id suggest reading armin ronacher’s code. like the source to jinja2 | 22:47 |
zzzeek | mvensky: plenty of deep things there | 22:48 |
zzzeek | mvensky: and he writes the cleanest most sophisticated code of like anyone | 22:48 |
*** nic1 has quit IRC | 22:49 | |
*** zul has quit IRC | 22:49 | |
*** mwagner_lap has quit IRC | 22:49 | |
*** bradjones has quit IRC | 22:49 | |
*** changbl has quit IRC | 22:49 | |
*** mtanino has joined #openstack-nova | 22:49 | |
mvensky | zzzeek: what about looking at "main" for nova and trying to see how the system "boots" or is that just way too deep? | 22:49 |
zzzeek | mvensky: i cannot follow that code, and just tried again a couple of weeks ago and gave up again, and I wrote SQLAlchemy | 22:51 |
*** mwagner_lap has joined #openstack-nova | 22:51 | |
openstackgerrit | Alberto Murillo proposed openstack/nova: Create additional hosts file for dnsmasq before using it. https://review.openstack.org/210627 | 22:52 |
mvensky | welp, that gives me some pause; I think I'll try armin's code | 22:52 |
*** zul has joined #openstack-nova | 22:54 | |
*** meghal has quit IRC | 22:54 | |
*** bradjones has joined #openstack-nova | 22:55 | |
*** bradjones has quit IRC | 22:55 | |
*** bradjones has joined #openstack-nova | 22:55 | |
*** changbl has joined #openstack-nova | 22:56 | |
*** claudiub has joined #openstack-nova | 22:56 | |
zzzeek | mvensky: i think nova’s startup syssttem is just very very spread out among different libraries | 22:56 |
zzzeek | mvensky: it just does one little thing here , one little thing there, and there’s a lot going on w/ eventlet and such | 22:56 |
*** patrickeast has quit IRC | 22:57 | |
*** salv-orl_ has joined #openstack-nova | 22:57 | |
*** salv-orlando has quit IRC | 22:59 | |
*** jdurgin has quit IRC | 23:05 | |
openstackgerrit | Pengtao Huang proposed openstack/nova: change the volue "vol" to "bdm" https://review.openstack.org/208211 | 23:07 |
*** otter768 has joined #openstack-nova | 23:11 | |
*** zzzeek has quit IRC | 23:12 | |
*** logan2 has quit IRC | 23:15 | |
*** meghal has joined #openstack-nova | 23:16 | |
*** salv-orl_ has quit IRC | 23:17 | |
*** salv-orlando has joined #openstack-nova | 23:19 | |
*** mwagner_lap has quit IRC | 23:22 | |
*** kevinbenton has quit IRC | 23:25 | |
*** kevinbenton has joined #openstack-nova | 23:27 | |
*** salv-orlando has quit IRC | 23:28 | |
*** salv-orlando has joined #openstack-nova | 23:28 | |
*** ijw has joined #openstack-nova | 23:28 | |
*** ijw_ has quit IRC | 23:30 | |
alex_xu | sdague: nice agenda, it also helpful clear what worktiem we track now. learn a lot, thanks | 23:30 |
openstackgerrit | Nicolas Simonds proposed openstack/nova: EC2 API: make describe_instances() respect filters https://review.openstack.org/210637 | 23:34 |
*** Piet has joined #openstack-nova | 23:49 | |
*** tsekiyam_ has joined #openstack-nova | 23:54 | |
*** mtanino has quit IRC | 23:56 | |
*** tsekiyama has quit IRC | 23:57 | |
*** mvensky has quit IRC | 23:57 | |
*** tsekiyam_ has quit IRC | 23:58 | |
*** salv-orlando has quit IRC | 23:59 | |
*** markvoelker has joined #openstack-nova | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!