| *** thumpba has quit IRC | 00:03 | |
| *** 92AABUE7H has joined #openstack-nova | 00:08 | |
| *** tjones has quit IRC | 00:08 | |
| *** 6A4AABQAG has quit IRC | 00:10 | |
| *** Marga_ has joined #openstack-nova | 00:11 | |
| *** armax has quit IRC | 00:14 | |
| *** Marga_ has quit IRC | 00:16 | |
| *** kbyrne has quit IRC | 00:17 | |
| *** shoutm has quit IRC | 00:17 | |
| *** thumpba has joined #openstack-nova | 00:20 | |
| *** kbyrne has joined #openstack-nova | 00:20 | |
| *** shoutm has joined #openstack-nova | 00:20 | |
| *** ericksonsantos has quit IRC | 00:27 | |
| *** ericksonsantos has joined #openstack-nova | 00:31 | |
| *** thedodd has quit IRC | 00:32 | |
| *** thumpba has quit IRC | 00:38 | |
| *** shoutm has quit IRC | 00:44 | |
| *** tjones has joined #openstack-nova | 00:59 | |
| *** mjturek1 has joined #openstack-nova | 01:01 | |
| *** shoutm has joined #openstack-nova | 01:02 | |
| *** zhenguo has joined #openstack-nova | 01:04 | |
| *** moshele has quit IRC | 01:06 | |
| *** shyu has joined #openstack-nova | 01:08 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/210681 | 01:09 |
|---|---|---|
| *** haigang has joined #openstack-nova | 01:09 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient: Updated from global requirements https://review.openstack.org/210927 | 01:10 |
| *** penick has joined #openstack-nova | 01:11 | |
| *** Marga_ has joined #openstack-nova | 01:12 | |
| *** shoutm has quit IRC | 01:16 | |
| *** Marga_ has quit IRC | 01:17 | |
| *** shoutm has joined #openstack-nova | 01:19 | |
| *** penick has quit IRC | 01:21 | |
| openstackgerrit | lyanchih proposed openstack/nova: libvirt - Unrescue will not remove rescue disk when image_type=rbd https://review.openstack.org/205766 | 01:23 |
| *** haigang has quit IRC | 01:26 | |
| *** shoutm has quit IRC | 01:28 | |
| *** tjones has quit IRC | 01:30 | |
| *** shoutm has joined #openstack-nova | 01:30 | |
| *** mriedem1 has quit IRC | 01:32 | |
| *** jogo has quit IRC | 01:35 | |
| *** jogo has joined #openstack-nova | 01:35 | |
| *** bnemec has quit IRC | 01:38 | |
| *** markvoelker has joined #openstack-nova | 01:39 | |
| *** markvoelker has quit IRC | 01:44 | |
| *** mjturek1 has quit IRC | 01:55 | |
| *** alex_xu has joined #openstack-nova | 01:56 | |
| openstackgerrit | Jay Pipes proposed openstack/nova: ObjectListBase support append and __delitem__ https://review.openstack.org/210947 | 02:00 |
| openstackgerrit | Jay Pipes proposed openstack/nova: pci: Use PciDeviceList for PciDevTracker.pci_devs https://review.openstack.org/210948 | 02:00 |
| *** jogo has quit IRC | 02:06 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Allow resize root_gb to 0 for volume-backed instances https://review.openstack.org/207794 | 02:07 |
| *** alejandrito has joined #openstack-nova | 02:08 | |
| *** thumpba has joined #openstack-nova | 02:08 | |
| *** jyuso1 has joined #openstack-nova | 02:09 | |
| *** baoli has quit IRC | 02:12 | |
| *** Marga_ has joined #openstack-nova | 02:13 | |
| *** baoli has joined #openstack-nova | 02:15 | |
| *** thumpba has quit IRC | 02:15 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 02:17 |
| *** Marga_ has quit IRC | 02:17 | |
| *** jogo has joined #openstack-nova | 02:18 | |
| *** jogo has quit IRC | 02:18 | |
| *** jogo has joined #openstack-nova | 02:18 | |
| *** cfriesen has joined #openstack-nova | 02:23 | |
| *** shuquan has joined #openstack-nova | 02:24 | |
| *** cfriesen has quit IRC | 02:27 | |
| *** cfriesen_ has joined #openstack-nova | 02:27 | |
| *** diogogmt has quit IRC | 02:30 | |
| *** shuquan has quit IRC | 02:30 | |
| *** alejandrito has quit IRC | 02:37 | |
| *** otter768 has quit IRC | 02:40 | |
| *** diogogmt has joined #openstack-nova | 02:42 | |
| *** jdurgin has joined #openstack-nova | 02:44 | |
| *** patrickeast has joined #openstack-nova | 02:45 | |
| *** agireud has joined #openstack-nova | 02:45 | |
| alex_xu | gmann: hi, good morning | 02:48 |
| *** armax has joined #openstack-nova | 02:50 | |
| *** hakimo has joined #openstack-nova | 02:52 | |
| *** shuquan has joined #openstack-nova | 02:54 | |
| *** patrickeast has quit IRC | 02:54 | |
| *** shuquan has quit IRC | 02:55 | |
| *** hakimo_ has quit IRC | 02:55 | |
| openstackgerrit | yalei wang proposed openstack/nova: Support unaddressed port https://review.openstack.org/202882 | 02:57 |
| *** shuquan has joined #openstack-nova | 02:58 | |
| *** baoli has quit IRC | 03:01 | |
| *** annashen has joined #openstack-nova | 03:05 | |
| *** thumpba has joined #openstack-nova | 03:12 | |
| *** Marga_ has joined #openstack-nova | 03:14 | |
| *** venkatesh has joined #openstack-nova | 03:14 | |
| *** thumpba has quit IRC | 03:17 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: change the value "all_mappings" to "block_device_mapping" https://review.openstack.org/208511 | 03:17 |
| *** Marga_ has quit IRC | 03:18 | |
| *** meghal has joined #openstack-nova | 03:19 | |
| *** unicell1 has joined #openstack-nova | 03:19 | |
| lifeless | mikal: sdague: johnthetubaguy: https://review.openstack.org/#/c/205931/ <- this would be good to get in please | 03:19 |
| lifeless | its the next bit of lock-down insulation from requirements changes | 03:20 |
| lifeless | Nakato: ^ begging for you here :) | 03:20 |
| *** unicell has quit IRC | 03:21 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add instance action events for live migration https://review.openstack.org/195372 | 03:25 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 03:33 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Allow resize root_gb to 0 for volume-backed instances https://review.openstack.org/207794 | 03:38 |
| openstackgerrit | Zhenyu Zheng proposed openstack/python-novaclient: Allow display project-id for server groups https://review.openstack.org/209011 | 03:40 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: network_request_obj: Clean up outdated code https://review.openstack.org/201425 | 03:40 |
| *** markvoelker has joined #openstack-nova | 03:40 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: CONF.allow_resize_to_same_host should check only once in controller https://review.openstack.org/186236 | 03:41 |
| *** markvoelker has quit IRC | 03:45 | |
| *** shuquan has quit IRC | 03:50 | |
| *** shz has quit IRC | 03:50 | |
| *** shuquan has joined #openstack-nova | 03:51 | |
| *** kiwik has quit IRC | 03:53 | |
| *** shuquan has quit IRC | 03:53 | |
| *** RuiChen has joined #openstack-nova | 03:56 | |
| openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add secgroup param checks for Neutron https://review.openstack.org/192043 | 03:57 |
| *** yamahata has joined #openstack-nova | 03:59 | |
| *** meghal has quit IRC | 03:59 | |
| *** shuquan has joined #openstack-nova | 04:00 | |
| *** shuquan has quit IRC | 04:00 | |
| *** shuquan has joined #openstack-nova | 04:04 | |
| *** shuquan has quit IRC | 04:06 | |
| *** shuquan has joined #openstack-nova | 04:07 | |
| *** Marga_ has joined #openstack-nova | 04:15 | |
| *** armax has quit IRC | 04:15 | |
| *** shuquan has quit IRC | 04:17 | |
| *** shuquan has joined #openstack-nova | 04:18 | |
| *** Marga_ has quit IRC | 04:19 | |
| *** unicell has joined #openstack-nova | 04:21 | |
| *** unicell1 has quit IRC | 04:21 | |
| *** annashen has quit IRC | 04:25 | |
| *** agireud has quit IRC | 04:27 | |
| *** agireud has joined #openstack-nova | 04:31 | |
| *** yamahata has quit IRC | 04:31 | |
| *** oomichi has joined #openstack-nova | 04:32 | |
| *** shuquan has quit IRC | 04:35 | |
| *** vishwanathj has quit IRC | 04:36 | |
| *** otter768 has joined #openstack-nova | 04:41 | |
| *** otter768 has quit IRC | 04:45 | |
| *** shyama has joined #openstack-nova | 04:49 | |
| *** achanda has joined #openstack-nova | 04:53 | |
| *** penick has joined #openstack-nova | 05:04 | |
| *** irenab has quit IRC | 05:10 | |
| *** deepakcs has joined #openstack-nova | 05:12 | |
| *** thumpba has joined #openstack-nova | 05:14 | |
| *** slong has quit IRC | 05:14 | |
| *** annashen has joined #openstack-nova | 05:15 | |
| *** slong has joined #openstack-nova | 05:15 | |
| *** Marga_ has joined #openstack-nova | 05:15 | |
| *** shuquan has joined #openstack-nova | 05:16 | |
| *** penick has quit IRC | 05:18 | |
| *** thumpba has quit IRC | 05:18 | |
| *** chhavi has joined #openstack-nova | 05:19 | |
| *** Marga_ has quit IRC | 05:20 | |
| openstackgerrit | Feodor Tersin proposed openstack/nova: Remove obsolete race handling in Instance.destroy https://review.openstack.org/210972 | 05:23 |
| *** Sukhdev has joined #openstack-nova | 05:24 | |
| *** meghal has joined #openstack-nova | 05:29 | |
| *** agireud has quit IRC | 05:29 | |
| *** venkatesh has quit IRC | 05:35 | |
| *** annashen has quit IRC | 05:38 | |
| *** annashen has joined #openstack-nova | 05:39 | |
| *** salv-orlando has joined #openstack-nova | 05:41 | |
| *** markvoelker has joined #openstack-nova | 05:41 | |
| *** sudipto has joined #openstack-nova | 05:43 | |
| *** markvoelker has quit IRC | 05:46 | |
| *** irenab has joined #openstack-nova | 05:47 | |
| *** salv-orlando has quit IRC | 05:48 | |
| *** venkatesh has joined #openstack-nova | 05:50 | |
| *** slong_ has joined #openstack-nova | 05:50 | |
| *** slong has quit IRC | 05:51 | |
| *** hanzhang has joined #openstack-nova | 05:57 | |
| *** salv-orlando has joined #openstack-nova | 06:01 | |
| *** Nikolay_St has joined #openstack-nova | 06:02 | |
| *** venkatesh has quit IRC | 06:02 | |
| *** shuquan has quit IRC | 06:02 | |
| *** jyuso1 has quit IRC | 06:02 | |
| *** shuquan has joined #openstack-nova | 06:06 | |
| *** josecastroleon has joined #openstack-nova | 06:07 | |
| *** ttrumm has joined #openstack-nova | 06:07 | |
| *** Murali_ has joined #openstack-nova | 06:10 | |
| *** meghal has quit IRC | 06:11 | |
| *** ankit_ag has joined #openstack-nova | 06:13 | |
| *** thumpba has joined #openstack-nova | 06:15 | |
| *** jdurgin has quit IRC | 06:16 | |
| *** venkatesh has joined #openstack-nova | 06:16 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Allow resize root_gb to 0 for volume-backed instances https://review.openstack.org/207794 | 06:16 |
| *** Marga_ has joined #openstack-nova | 06:16 | |
| *** tojuvone has joined #openstack-nova | 06:18 | |
| *** thumpba has quit IRC | 06:19 | |
| *** Marga_ has quit IRC | 06:21 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex https://review.openstack.org/209780 | 06:22 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 06:23 |
| *** afazekas_ has joined #openstack-nova | 06:24 | |
| *** apuimedo has quit IRC | 06:24 | |
| *** scheuran has joined #openstack-nova | 06:29 | |
| *** sahid has joined #openstack-nova | 06:30 | |
| *** ildikov has quit IRC | 06:30 | |
| *** moshele has joined #openstack-nova | 06:31 | |
| *** rubasov has joined #openstack-nova | 06:33 | |
| *** annashen has quit IRC | 06:38 | |
| openstackgerrit | Feodor Tersin proposed openstack/nova: Remove obsolete race handling in Instance.destroy https://review.openstack.org/210972 | 06:40 |
| *** ishant has joined #openstack-nova | 06:42 | |
| *** otter768 has joined #openstack-nova | 06:42 | |
| *** jkraj has joined #openstack-nova | 06:43 | |
| *** otter768 has quit IRC | 06:47 | |
| *** rdopiera has joined #openstack-nova | 06:50 | |
| *** Sree has joined #openstack-nova | 06:51 | |
| *** markus_z has joined #openstack-nova | 06:52 | |
| *** jyuso1 has joined #openstack-nova | 06:57 | |
| *** venkatesh has quit IRC | 06:59 | |
| *** Sree__ has joined #openstack-nova | 07:00 | |
| *** hakimo has quit IRC | 07:02 | |
| *** belmoreira has joined #openstack-nova | 07:02 | |
| *** Sree__ has quit IRC | 07:02 | |
| *** Sree__ has joined #openstack-nova | 07:03 | |
| *** hakimo has joined #openstack-nova | 07:03 | |
| *** kiran-r has joined #openstack-nova | 07:03 | |
| *** ildikov has joined #openstack-nova | 07:03 | |
| *** Sree has quit IRC | 07:04 | |
| *** Sree__ has quit IRC | 07:07 | |
| *** cfriesen_ has quit IRC | 07:08 | |
| *** xgsa has quit IRC | 07:09 | |
| *** shuquan has quit IRC | 07:10 | |
| *** xgsa has joined #openstack-nova | 07:11 | |
| *** venkatesh has joined #openstack-nova | 07:11 | |
| *** shuquan has joined #openstack-nova | 07:11 | |
| *** thumpba has joined #openstack-nova | 07:15 | |
| *** achanda has quit IRC | 07:16 | |
| *** Marga_ has joined #openstack-nova | 07:17 | |
| openstackgerrit | Arata Notsu proposed openstack/nova: More specific error message for OverQuota on BDM https://review.openstack.org/209897 | 07:17 |
| *** achanda has joined #openstack-nova | 07:18 | |
| *** thumpba has quit IRC | 07:20 | |
| *** Marga_ has quit IRC | 07:21 | |
| *** shuquan has quit IRC | 07:23 | |
| *** Sukhdev has quit IRC | 07:23 | |
| *** Marga_ has joined #openstack-nova | 07:25 | |
| *** shuquan has joined #openstack-nova | 07:26 | |
| *** shoutm has quit IRC | 07:27 | |
| *** achanda has quit IRC | 07:28 | |
| *** shoutm has joined #openstack-nova | 07:30 | |
| *** achanda has joined #openstack-nova | 07:31 | |
| *** abhishekk has joined #openstack-nova | 07:34 | |
| *** slong_ has quit IRC | 07:34 | |
| *** Marga_ has quit IRC | 07:35 | |
| *** apuimedo has joined #openstack-nova | 07:36 | |
| *** Marga_ has joined #openstack-nova | 07:36 | |
| openstackgerrit | Rajesh Tailor proposed openstack/nova: Remove unnecessary ValueError exception https://review.openstack.org/190525 | 07:38 |
| *** markvoelker has joined #openstack-nova | 07:42 | |
| *** shuquan has quit IRC | 07:43 | |
| *** Sree has joined #openstack-nova | 07:45 | |
| *** jlanoux has joined #openstack-nova | 07:46 | |
| *** markvoelker has quit IRC | 07:46 | |
| *** scheuran has quit IRC | 07:46 | |
| *** achanda has quit IRC | 07:46 | |
| *** mnestratov has joined #openstack-nova | 07:47 | |
| *** kmARC has joined #openstack-nova | 07:47 | |
| *** kmARC_ has joined #openstack-nova | 07:48 | |
| *** shuquan has joined #openstack-nova | 07:48 | |
| *** wanghua has joined #openstack-nova | 07:50 | |
| *** jlanoux has quit IRC | 07:50 | |
| *** ishant has quit IRC | 07:50 | |
| *** salv-orlando has quit IRC | 07:54 | |
| *** jlanoux has joined #openstack-nova | 07:56 | |
| *** chhavi has quit IRC | 07:56 | |
| *** jcoufal has joined #openstack-nova | 08:00 | |
| *** kiwik-chenrui has joined #openstack-nova | 08:03 | |
| *** romainh has joined #openstack-nova | 08:05 | |
| *** shuquan has quit IRC | 08:06 | |
| *** yassine has joined #openstack-nova | 08:06 | |
| *** romainh has left #openstack-nova | 08:06 | |
| *** RuiChen has quit IRC | 08:07 | |
| *** ndipanov has joined #openstack-nova | 08:08 | |
| *** kmARC has quit IRC | 08:08 | |
| *** kmARC_ has quit IRC | 08:09 | |
| openstackgerrit | Feodor Tersin proposed openstack/nova: Remove obsolete race handling in Instance.destroy https://review.openstack.org/210972 | 08:10 |
| openstackgerrit | geml proposed openstack/nova: fix bug: Delete "vm that has snapshot" spend more time We are now using ceph as nova backend in version juno/stable. In the following scene, deleting instance will take more time than icehouse. https://review.openstack.org/211027 | 08:10 |
| *** shuquan has joined #openstack-nova | 08:12 | |
| *** jistr has joined #openstack-nova | 08:12 | |
| *** MarcF has joined #openstack-nova | 08:23 | |
| *** scheuran has joined #openstack-nova | 08:24 | |
| MarcF | #join #openstack-glance | 08:24 |
| *** shuquan has quit IRC | 08:24 | |
| *** jcoufal has quit IRC | 08:25 | |
| *** shuquan has joined #openstack-nova | 08:26 | |
| *** matrohon has joined #openstack-nova | 08:26 | |
| *** claudiub has joined #openstack-nova | 08:27 | |
| *** shuquan has quit IRC | 08:27 | |
| *** Sree has quit IRC | 08:28 | |
| *** Sree has joined #openstack-nova | 08:28 | |
| *** alexschm has joined #openstack-nova | 08:30 | |
| *** xgsa1 has joined #openstack-nova | 08:32 | |
| *** xgsa has quit IRC | 08:32 | |
| openstackgerrit | Alex Xu proposed openstack/nova: DO NOT MERGE: Remove extension white/black list option from v2.1 API https://review.openstack.org/211040 | 08:33 |
| *** shoutm has quit IRC | 08:34 | |
| *** danpb has joined #openstack-nova | 08:36 | |
| *** jingsong has joined #openstack-nova | 08:38 | |
| *** annashen has joined #openstack-nova | 08:39 | |
| openstackgerrit | James Page proposed openstack/nova: Add canonicalization for non-x86 architectures https://review.openstack.org/211041 | 08:40 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add instance action events for live migration https://review.openstack.org/195372 | 08:40 |
| *** haigang has joined #openstack-nova | 08:40 | |
| *** shihanzhang has joined #openstack-nova | 08:41 | |
| openstackgerrit | James Page proposed openstack/nova: Add canonicalization for non-x86 architectures https://review.openstack.org/211041 | 08:42 |
| *** otter768 has joined #openstack-nova | 08:43 | |
| *** annashen has quit IRC | 08:43 | |
| openstackgerrit | Emma Foley proposed openstack/nova: Added support for specifying units to hw:mem_page_size https://review.openstack.org/209564 | 08:44 |
| *** hanzhang has quit IRC | 08:44 | |
| *** otter768 has quit IRC | 08:47 | |
| *** humble_ has joined #openstack-nova | 08:51 | |
| *** wanghua has quit IRC | 08:54 | |
| openstackgerrit | Feodor Tersin proposed openstack/nova: ImageMeta: Improve support of nullable fields https://review.openstack.org/211048 | 08:56 |
| johnthetubaguy | sdague: nice update to the API meeting agenda, thank you! | 09:00 |
| *** afazekas_ is now known as afazekas | 09:04 | |
| *** shoutm has joined #openstack-nova | 09:09 | |
| *** mkoderer has quit IRC | 09:14 | |
| *** ankit_ag has quit IRC | 09:15 | |
| *** ankit has joined #openstack-nova | 09:15 | |
| *** marzif_ has quit IRC | 09:16 | |
| *** mkoderer has joined #openstack-nova | 09:17 | |
| *** thumpba has joined #openstack-nova | 09:17 | |
| *** belmoreira has quit IRC | 09:18 | |
| *** belmoreira has joined #openstack-nova | 09:19 | |
| *** mdbooth has quit IRC | 09:20 | |
| *** mdbooth has joined #openstack-nova | 09:21 | |
| *** dheeraj-gupta-4 has joined #openstack-nova | 09:21 | |
| *** dheeraj-gupta-4 has left #openstack-nova | 09:22 | |
| *** thumpba has quit IRC | 09:22 | |
| *** alexpilotti has joined #openstack-nova | 09:25 | |
| *** jyuso1 has quit IRC | 09:27 | |
| *** jyuso1 has joined #openstack-nova | 09:28 | |
| *** _kiran_ has joined #openstack-nova | 09:28 | |
| *** salv-orlando has joined #openstack-nova | 09:29 | |
| *** kiran-r has quit IRC | 09:31 | |
| *** eliqiao has joined #openstack-nova | 09:33 | |
| openstackgerrit | John Garbutt proposed openstack/nova: libvirt: convert GPFS volume driver to LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202781 | 09:34 |
| *** marzif_ has joined #openstack-nova | 09:36 | |
| *** rajesht has joined #openstack-nova | 09:42 | |
| *** markvoelker has joined #openstack-nova | 09:43 | |
| *** Sree__ has joined #openstack-nova | 09:44 | |
| *** Sree__ has quit IRC | 09:44 | |
| *** Sree__ has joined #openstack-nova | 09:45 | |
| *** Sree has quit IRC | 09:47 | |
| *** markvoelker has quit IRC | 09:49 | |
| *** eliqiao has left #openstack-nova | 09:54 | |
| *** eliqiao has joined #openstack-nova | 09:54 | |
| *** venkatesh has quit IRC | 09:55 | |
| *** salv-orlando has quit IRC | 09:58 | |
| *** shoutm has quit IRC | 09:58 | |
| *** dheeraj-gupta-4 has joined #openstack-nova | 09:58 | |
| *** salv-orlando has joined #openstack-nova | 09:58 | |
| *** dheeraj-gupta-4 has left #openstack-nova | 09:58 | |
| *** Sree has joined #openstack-nova | 09:58 | |
| *** jcoufal has joined #openstack-nova | 10:01 | |
| *** Sree__ has quit IRC | 10:02 | |
| sdague | johnthetubaguy: no prob | 10:06 |
| openstackgerrit | Rui Chen proposed openstack/nova: Fix incorrect result of host-describe https://review.openstack.org/211083 | 10:09 |
| deepakcs | johnthetubaguy: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/volume-snapshot-improvements,n,z (2nd patch was refactord to be split into 2 as you and danpb suggested) | 10:10 |
| deepakcs | johnthetubaguy: I hope you folks will consider it :) | 10:10 |
| johnthetubaguy | deepakcs: its missed the deadlines I am afraid, see comments on the other patches | 10:10 |
| johnthetubaguy | deepakcs: friday was the last day to approve any exceptions, so we can focus on bug fixes and priorities going forward | 10:11 |
| *** alex_klimov has joined #openstack-nova | 10:11 | |
| johnthetubaguy | deepakcs: this is the list of priorities: http://specs.openstack.org/openstack/nova-specs/priorities/liberty-priorities.html | 10:11 |
| deepakcs | johnthetubaguy: :( I had split the patch on Fri itself, so i was hopeful. | 10:12 |
| *** xgsa1 has quit IRC | 10:15 | |
| *** chhavi has joined #openstack-nova | 10:16 | |
| johnthetubaguy | deepakcs: I need to work out the cinder impact of this missing liberty, if its a big impact, we can try do something, but right now, we really need to focus on the backlog of bug fixes that need reviewing | 10:16 |
| openstackgerrit | Arata Notsu proposed openstack/nova: More specific error message for OverQuota on BDM https://review.openstack.org/209897 | 10:16 |
| sdague | johnthetubaguy: ok, so no one has yet expressed a preference between mon or tues for the API meeting. So what's your preference. | 10:17 |
| johnthetubaguy | sdague: slight preference for tuesday, I am behind on the ML right now, I should respond there really | 10:17 |
| *** venkatesh has joined #openstack-nova | 10:18 | |
| deepakcs | johnthetubaguy: we have another bp in Cinder to track cinder volume format (https://review.openstack.org/#/c/165393/) which can only start after Nova is able to return the volume format (which is part of this bp which we just non-prioritised) | 10:18 |
| sdague | ok, how about you do that, then I'll respond from there | 10:18 |
| *** jingsong has quit IRC | 10:19 | |
| *** lucasagomes has joined #openstack-nova | 10:19 | |
| *** venkatesh has quit IRC | 10:20 | |
| *** gszasz has joined #openstack-nova | 10:21 | |
| *** venkatesh has joined #openstack-nova | 10:22 | |
| haigang | hi there~~ I got a problem with metadata service | 10:23 |
| haigang | recently, I adjust my topo, using neutron provider network, remove network node | 10:23 |
| haigang | only controller and compute node. when boot a instance, vm's request http://169.254.169.254 will failed | 10:24 |
| haigang | I set the neutron dhcp agent's option enable_isolated_metadata to True, and vm got 500 err. | 10:25 |
| haigang | by capturing packet, I found that the problem is because of vm's request without http header x-instance-id, how to handle this problem~~ | 10:25 |
| *** IanGovett has joined #openstack-nova | 10:28 | |
| *** salv-orl_ has joined #openstack-nova | 10:28 | |
| *** venkatesh is now known as venkat_p | 10:28 | |
| *** lexloofah is now known as lxsli | 10:30 | |
| *** salv-orlando has quit IRC | 10:30 | |
| *** venkat_p has quit IRC | 10:31 | |
| *** venkat_p has joined #openstack-nova | 10:31 | |
| *** venkat_p has quit IRC | 10:32 | |
| *** venkat_p has joined #openstack-nova | 10:33 | |
| *** Sree has quit IRC | 10:35 | |
| openstackgerrit | John Garbutt proposed openstack/nova: Compute: use instance object for refresh_instance_security_rules https://review.openstack.org/187537 | 10:39 |
| *** annashen has joined #openstack-nova | 10:40 | |
| openstackgerrit | John Garbutt proposed openstack/nova: Compute: use instance object for refresh_instance_security_rules https://review.openstack.org/187537 | 10:40 |
| *** josecastroleon has quit IRC | 10:41 | |
| *** otter768 has joined #openstack-nova | 10:44 | |
| *** lucasagomes has quit IRC | 10:44 | |
| *** annashen has quit IRC | 10:45 | |
| *** scheuran has quit IRC | 10:47 | |
| *** otter768 has quit IRC | 10:48 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/nova: Ironic: Use ironicclient native retries for Conflict in ClientWrapper https://review.openstack.org/210369 | 10:50 |
| openstackgerrit | Dmitry Tantsur proposed openstack/nova: Ironic: Use ironicclient native for connection errors https://review.openstack.org/211097 | 10:50 |
| *** baoli has joined #openstack-nova | 10:51 | |
| openstackgerrit | Sergey Nikitin proposed openstack/nova-specs: Implement server instance tagging https://review.openstack.org/211099 | 10:51 |
| *** kiran-r has joined #openstack-nova | 10:51 | |
| *** jaypipes has joined #openstack-nova | 10:53 | |
| *** baoli_ has joined #openstack-nova | 10:54 | |
| *** _kiran_ has quit IRC | 10:55 | |
| openstackgerrit | Ramakrishnan G proposed openstack/nova-specs: Add support for booting bare metals from Cinder volume https://review.openstack.org/211101 | 10:55 |
| *** mwagner_lap has quit IRC | 10:57 | |
| *** baoli has quit IRC | 10:57 | |
| *** venkat_p has quit IRC | 10:57 | |
| johnthetubaguy | alex_xu: just looking at this BP, I guess we don't have all the code up for review yet? https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/api-relax-validation,n,z | 10:58 |
| alex_xu | johnthetubaguy: we have all code up for review now | 10:59 |
| *** lucasagomes has joined #openstack-nova | 10:59 | |
| alex_xu | johnthetubaguy: https://review.openstack.org/#/c/206930/ this is last one | 10:59 |
| johnthetubaguy | alex_xu: where is the big that drops the v2.1 headers? | 10:59 |
| alex_xu | johnthetubaguy: it already merged https://review.openstack.org/193857 | 11:00 |
| johnthetubaguy | alex_xu: awesome | 11:01 |
| alex_xu | johnthetubaguy: :) | 11:01 |
| alex_xu | johnthetubaguy: thanks for the review | 11:01 |
| johnthetubaguy | alex_xu: no problem, big thank you for coding this all up and making it real | 11:01 |
| alex_xu | johnthetubaguy: np | 11:01 |
| alex_xu | edleafe: johnthetubaguy sdague , for remove v3, how about we seperate as 1. move legacy v2 code, 2. move v2.1 code, 3. move unittest, 4. move api sample tests | 11:02 |
| openstackgerrit | Roman Podoliaka proposed openstack/nova: vmware: use hostnames instead of IPs to differ computes https://review.openstack.org/211105 | 11:03 |
| alex_xu | Then I hope the work and review will be easy for now. | 11:04 |
| sdague | alex_xu: sure, at this point I think any way that you think we can get there is important. I know edleafe was having challenges getting a solid patch | 11:04 |
| johnthetubaguy | alex_xu: edleafe: that is my preferred approach too, having reviewed the current efforts, its possibly the unit tests could move at the same time, but I am keep to keep it simple | 11:04 |
| johnthetubaguy | sdague: +1 | 11:04 |
| sdague | alex_xu: you want to take a stab at the moves? | 11:04 |
| sdague | I'm just affraid we're going to run out of time on this one | 11:04 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add instance action events for live migration https://review.openstack.org/195372 | 11:04 |
| alex_xu | stab means help? | 11:04 |
| johnthetubaguy | alex_xu: I guess its late with you now, I am tempted to take a look at the API moves, based on some older patches, etc | 11:05 |
| alex_xu | I want to help edleafe on this, I hope in two week, we can make move v2 and v2.1 code ready in two weeks | 11:05 |
| *** scheuran has joined #openstack-nova | 11:05 | |
| alex_xu | johnthetubaguy: it's fine, let me try to work late recently | 11:06 |
| johnthetubaguy | alex_xu: I think we need to merge that early this week really | 11:07 |
| *** pas-ha has joined #openstack-nova | 11:07 | |
| *** lucasagomes has quit IRC | 11:07 | |
| alex_xu | johnthetubaguy: ok, no prob, let's try | 11:07 |
| johnthetubaguy | alex_xu: cool, ping me when there are things to review | 11:08 |
| alex_xu | johnthetubaguy: ok | 11:08 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: CONF.allow_resize_to_same_host should check only once in controller https://review.openstack.org/186236 | 11:08 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: network_request_obj: Clean up outdated code https://review.openstack.org/201425 | 11:08 |
| pas-ha | hi all, have a (may be stupid) question - does nova support introspection of hypervizor driver and reporting which actions are supported for given instance? | 11:08 |
| *** venkat_p has joined #openstack-nova | 11:08 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 11:08 |
| johnthetubaguy | alex_xu: I know ed has a patch up for the v2->legacy_v2 move, if you look at patchest 24, I think its close to what we want, give or take some minor grumbles | 11:09 |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova: Allow resize root_gb to 0 for volume-backed instances https://review.openstack.org/207794 | 11:09 |
| johnthetubaguy | might not be the correct number | 11:09 |
| alex_xu | sdague: for removing extension, how about we just remove something visible for user in L. Like remove black/white extension list with some tunning of tests, like this https://review.openstack.org/211040 | 11:09 |
| pas-ha | use-case - BM Ironic node that does not support pause/suspend/migrate etc but they are still shown in Horizon as available VM actions | 11:09 |
| alex_xu | johnthetubaguy: ok, got it | 11:09 |
| * johnthetubaguy runs away to get some lunch | 11:09 | |
| johnthetubaguy | alex_xu: I think we need to deprecate the option, so we can remove it in M, sadly | 11:10 |
| alex_xu | johnthetubaguy: why we can't remove it directly? | 11:10 |
| *** salv-o___ has joined #openstack-nova | 11:11 | |
| *** fawadkhaliq has joined #openstack-nova | 11:11 | |
| *** salv-orl_ has quit IRC | 11:11 | |
| alex_xu | johnthetubaguy: if we only can deprecate, looks like most of remove extension work will move to M | 11:11 |
| *** josecastroleon has joined #openstack-nova | 11:11 | |
| johnthetubaguy | alex_xu: correct | 11:12 |
| alex_xu | johnthetubaguy: ok | 11:12 |
| johnthetubaguy | alex_xu: deprecating that ASAP is super important, I think we should also drop /extensions in a new API microversion | 11:12 |
| johnthetubaguy | alex_xu: not sure we can do anything else, given our upgrade rules | 11:12 |
| *** Marga_ has quit IRC | 11:12 | |
| alex_xu | johnthetubaguy: I remove we said we keep /extensions always return True in summit, we didn't say will drop it. | 11:13 |
| alex_xu | s/remove/remember/.... | 11:14 |
| alex_xu | but drop it looks ok to me | 11:14 |
| *** chhavi has quit IRC | 11:14 | |
| *** Marga_ has joined #openstack-nova | 11:16 | |
| johnthetubaguy | alex_xu: I think it would be cleaner to drop it for v2.1, if you are on a newer micro verison, still need it there for older versions and v2 compat, I think it sends a clearer signal | 11:17 |
| *** venkat_p has quit IRC | 11:19 | |
| openstackgerrit | Emma Foley proposed openstack/nova: Added support for specifying units to hw:mem_page_size https://review.openstack.org/209564 | 11:21 |
| *** xgsa has joined #openstack-nova | 11:24 | |
| *** markvoelker has joined #openstack-nova | 11:29 | |
| *** marcusvrn has joined #openstack-nova | 11:29 | |
| *** shoutm has joined #openstack-nova | 11:30 | |
| *** liusheng has joined #openstack-nova | 11:30 | |
| *** venkat_p has joined #openstack-nova | 11:30 | |
| *** Marga_ has quit IRC | 11:31 | |
| haigang | hi, how to handle metadata service request without neutron-ns-metadata-proxy | 11:31 |
| haigang | I remove network node, VM ssh public key inject doesn't work | 11:32 |
| *** exploreshaifali has joined #openstack-nova | 11:32 | |
| *** mili_ has joined #openstack-nova | 11:32 | |
| mili_ | Hi guys | 11:32 |
| *** kiran-r has quit IRC | 11:32 | |
| *** haigang has quit IRC | 11:33 | |
| *** exploreshaifali has quit IRC | 11:34 | |
| *** markus_z has quit IRC | 11:34 | |
| *** Marga_ has joined #openstack-nova | 11:34 | |
| *** markvoelker has quit IRC | 11:34 | |
| *** haigang has joined #openstack-nova | 11:35 | |
| *** exploreshaifali has joined #openstack-nova | 11:36 | |
| mili_ | https://ask.openstack.org/en/question/67273/nova-compute-cant-connect-to-nova-controller/?answer=79920#post-id-79920 | 11:36 |
| mili_ | Please have a look | 11:36 |
| mili_ | https://ask.openstack.org/en/question/67273/nova-compute-cant-connect-to-nova-controller/?answer=79920#post-id-79920 | 11:36 |
| *** exploreshaifali has quit IRC | 11:37 | |
| *** jcoufal_ has joined #openstack-nova | 11:37 | |
| *** sudipto has quit IRC | 11:37 | |
| sdague | johnthetubaguy: https://review.openstack.org/#/c/181393/10/specs/service-catalog.rst,cm - "Removing Project Template" see how that works for you as a plan | 11:39 |
| *** jwcroppe has quit IRC | 11:39 | |
| *** jwcroppe has joined #openstack-nova | 11:40 | |
| *** haigang has quit IRC | 11:40 | |
| *** thorst has joined #openstack-nova | 11:40 | |
| *** jcoufal has quit IRC | 11:41 | |
| *** haigang has joined #openstack-nova | 11:42 | |
| *** romainh has joined #openstack-nova | 11:44 | |
| *** jwcroppe has quit IRC | 11:44 | |
| *** marzif_ has quit IRC | 11:45 | |
| *** marzif_ has joined #openstack-nova | 11:45 | |
| haigang | hi, I see an explanation "f you are not using the quantum/neutron namespace proxy + metadata agent, then nova-api does an instance-id lookup based on the source IP address of the http request." | 11:47 |
| *** mili_ has quit IRC | 11:47 | |
| haigang | I wonder how to let nova-api know there's no neutron namespace proxy? | 11:47 |
| haigang | is there any option in nova.conf? | 11:48 |
| *** markus_z has joined #openstack-nova | 11:48 | |
| openstackgerrit | Emma Foley proposed openstack/nova: Added support for specifying units to hw:mem_page_size https://review.openstack.org/209564 | 11:49 |
| *** scheuran has quit IRC | 11:51 | |
| *** Sree has joined #openstack-nova | 11:57 | |
| *** VW_ has joined #openstack-nova | 12:01 | |
| *** dave-mccowan has joined #openstack-nova | 12:01 | |
| *** mjturek1 has joined #openstack-nova | 12:02 | |
| openstackgerrit | lyanchih proposed openstack/nova: libvirt: serial console ports count upper limit needs to be checked https://review.openstack.org/207373 | 12:02 |
| *** baoli_ has quit IRC | 12:03 | |
| *** lyanchih has joined #openstack-nova | 12:03 | |
| *** htruta has joined #openstack-nova | 12:04 | |
| *** jordanP has joined #openstack-nova | 12:05 | |
| jordanP | sahid, ping ? | 12:05 |
| *** scheuran has joined #openstack-nova | 12:07 | |
| openstackgerrit | Zhai, Edwin proposed openstack/nova: Fix notify_decorator errors https://review.openstack.org/203573 | 12:07 |
| *** markvoelker has joined #openstack-nova | 12:08 | |
| sahid | jordanP: yes ? | 12:08 |
| jordanP | I am adding some new code to Nova and I have to use "guest._domain.isActive()" | 12:08 |
| jordanP | sahid: is there a way not to call this private "_domain" property ? | 12:09 |
| danpb | jordanP: you should never access guest._domain, except from inside the Guest class impl | 12:09 |
| jordanP | danpb, that's what I thought | 12:09 |
| sahid | jordanP: yes you must add new method in guest object | 12:09 |
| danpb | if you need to access from outside, then you should add a new formal method to the Guest class | 12:09 |
| danpb | eg create guest.is_active() | 12:09 |
| jordanP | so I have this guest object, how can I access its state ? | 12:09 |
| jordanP | sahid, aren't you working on that ? | 12:10 |
| danpb | which contains return self._domain.isActive() | 12:10 |
| sahid | jordanP: looking if i have a patch in review about that | 12:10 |
| jordanP | I have been struggling on my own patch, and having to add this "wrapper" feels like it's going to delay the work I am interested in... | 12:10 |
| *** raildo has joined #openstack-nova | 12:11 | |
| *** yassine has quit IRC | 12:11 | |
| sahid | jordanP: you just have to impl this methif in Guest object and clean libvirt/driver.py to use it | 12:11 |
| sahid | it seems to be used one time only | 12:11 |
| jordanP | "just", yeah.... | 12:11 |
| sahid | :) | 12:11 |
| *** rfolco has joined #openstack-nova | 12:12 | |
| *** yassine has joined #openstack-nova | 12:12 | |
| jordanP | ok, will do that. I hope danpb you could review this one soon (c) ... :) | 12:12 |
| *** humble_ has quit IRC | 12:14 | |
| *** humble_ has joined #openstack-nova | 12:14 | |
| jordanP | sahid, what do you think of isActive being a property of the Guest instead of a method ? | 12:17 |
| sahid | jordanP: why yo uwant to do that? | 12:17 |
| jordanP | I don't know :), isActive sounds like a property | 12:18 |
| jordanP | but yeah, okay, better keep it simple | 12:18 |
| sahid | i guess we should to follow what is done by libvirt | 12:18 |
| sahid | let using a method :) | 12:18 |
| jordanP | right | 12:18 |
| *** chhavi has joined #openstack-nova | 12:19 | |
| *** kylek3h has quit IRC | 12:20 | |
| *** annegentle has joined #openstack-nova | 12:20 | |
| *** aysyd has joined #openstack-nova | 12:23 | |
| *** busterswt has joined #openstack-nova | 12:23 | |
| *** erlon has joined #openstack-nova | 12:24 | |
| *** shyu has quit IRC | 12:25 | |
| *** salv-o___ has quit IRC | 12:26 | |
| *** chhavi has quit IRC | 12:26 | |
| *** shyu has joined #openstack-nova | 12:26 | |
| *** salv-orlando has joined #openstack-nova | 12:26 | |
| sahid | danpb: on https://review.openstack.org/#/c/209564/7/nova/virt/hardware.py,cm | 12:27 |
| openstackgerrit | jichenjc proposed openstack/nova: Refactor test cases for live-migrate error case https://review.openstack.org/179048 | 12:27 |
| openstackgerrit | jichenjc proposed openstack/nova: Handle MessageTimeout to MigrationPreCheckError https://review.openstack.org/168635 | 12:27 |
| sahid | i do not see the reason why we need math.ceil? | 12:27 |
| danpb | sahid: iiuc casting from float to int just truncates eg 7.9 becomes 7 | 12:28 |
| danpb | though to be honest it is actually probably not needed in our usage scenario | 12:28 |
| danpb | because huge page sizes will always be a multiple of 1024 | 12:28 |
| openstackgerrit | jichenjc proposed openstack/nova: Only set access_ip_* when instance goes ACTIVE https://review.openstack.org/129333 | 12:28 |
| sahid | yes we should use multiple of 2 | 12:28 |
| danpb | so we shouldn't actually ever get a fraction | 12:29 |
| sahid | yes | 12:29 |
| danpb | so we could drop the math.ceil call and just do int(.... / 1024) | 12:29 |
| sahid | i guess too | 12:29 |
| *** shuquan has joined #openstack-nova | 12:29 | |
| *** oomichi has quit IRC | 12:31 | |
| *** moshele has quit IRC | 12:32 | |
| *** lucasagomes has joined #openstack-nova | 12:33 | |
| *** bapalm has joined #openstack-nova | 12:36 | |
| *** shuquan has quit IRC | 12:36 | |
| *** abhishekk has quit IRC | 12:36 | |
| *** edmondsw has joined #openstack-nova | 12:38 | |
| *** VW_ has quit IRC | 12:39 | |
| *** VW_ has joined #openstack-nova | 12:40 | |
| *** annashen has joined #openstack-nova | 12:41 | |
| *** ttrumm has quit IRC | 12:41 | |
| *** ttrumm has joined #openstack-nova | 12:42 | |
| *** ttrumm has quit IRC | 12:42 | |
| *** VW__ has joined #openstack-nova | 12:43 | |
| *** lyanchih has quit IRC | 12:43 | |
| *** annegentle has quit IRC | 12:44 | |
| *** annegentle has joined #openstack-nova | 12:44 | |
| *** otter768 has joined #openstack-nova | 12:44 | |
| *** mwagner_lap has joined #openstack-nova | 12:45 | |
| *** annashen has quit IRC | 12:45 | |
| *** baoli has joined #openstack-nova | 12:46 | |
| *** VW_ has quit IRC | 12:46 | |
| *** dane-fichter has joined #openstack-nova | 12:47 | |
| *** otter768 has quit IRC | 12:49 | |
| *** jamie_h has joined #openstack-nova | 12:52 | |
| *** kylek3h has joined #openstack-nova | 12:54 | |
| dane-fichter | Could use some feedback on https://review.openstack.org/#/c/203784/ . | 12:56 |
| *** VW__ has quit IRC | 12:57 | |
| dane-fichter | Will review for reviews | 12:57 |
| *** VW_ has joined #openstack-nova | 12:57 | |
| *** tongli has joined #openstack-nova | 12:58 | |
| johnthetubaguy | sdague: looking at the service catalog stuff, why do we want to include the version in the service catalog, is that to save an extra round trip for the API users, maybe I am missreading a bit of the spec? | 12:58 |
| johnthetubaguy | dane-fichter: can you set the priority on your bug please, that should help with the review triage | 12:58 |
| *** humble_ has quit IRC | 12:58 | |
| *** bapalm_ has joined #openstack-nova | 12:58 | |
| *** humble_ has joined #openstack-nova | 12:59 | |
| dane-fichter | johnthetubaguy: Will do. I imagine it's pretty low priority | 12:59 |
| *** rushil has joined #openstack-nova | 13:00 | |
| *** Marga_ has quit IRC | 13:00 | |
| *** rlrossit has joined #openstack-nova | 13:01 | |
| sdague | johnthetubaguy: no, it's actually the opposite | 13:01 |
| sdague | today most implementations use the versioned endpoint | 13:01 |
| *** deepakcs has quit IRC | 13:01 | |
| sdague | we want to get rid of that | 13:02 |
| johnthetubaguy | dane-fichter: given its a small bug fix, its maybe worth adding to the list of trivial patches, and helping out by reviewing the others on there, if possible https://etherpad.openstack.org/p/liberty-nova-priorities-tracking | 13:02 |
| johnthetubaguy | sdague: yeah, I was thinking we should get rid of it too | 13:02 |
| *** bapalm has quit IRC | 13:02 | |
| *** VW_ has quit IRC | 13:02 | |
| johnthetubaguy | sdague: will add a comment on the bit that confused me, it might just be me | 13:02 |
| sdague | yes, that's explicitly stated earlier in the document | 13:02 |
| *** Kennan has quit IRC | 13:03 | |
| *** dustins has joined #openstack-nova | 13:03 | |
| *** park__ has quit IRC | 13:03 | |
| *** jcoufal_ has quit IRC | 13:04 | |
| *** chaochin has quit IRC | 13:04 | |
| johnthetubaguy | sdague: yeah, adding comments now, I think I agree with the approach that this is pointing towards | 13:04 |
| *** venkat_p has quit IRC | 13:04 | |
| openstackgerrit | Joel Coffman proposed openstack/nova: libvirt: Add unit tests for methods https://review.openstack.org/198880 | 13:05 |
| *** xek_ has joined #openstack-nova | 13:06 | |
| *** claudiub has quit IRC | 13:06 | |
| openstackgerrit | Joel Coffman proposed openstack/nova: libvirt: Add unit tests for methods https://review.openstack.org/198880 | 13:06 |
| dane-fichter | johnthetubaguy: Added to trivial bug list. Thanks. | 13:06 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: ironic: convert driver to use nova.objects.ImageMeta https://review.openstack.org/189362 | 13:07 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: objects: convert config drive to use ImageMeta object https://review.openstack.org/189323 | 13:07 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: convert driver to use nova.objects.ImageMeta https://review.openstack.org/188119 | 13:07 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: make instance compulsory in blockinfo APIs https://review.openstack.org/188118 | 13:07 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: hyperv: convert driver to use nova.objects.ImageMeta https://review.openstack.org/189302 | 13:07 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: objects: add virtual 'image_meta' property to Instance object https://review.openstack.org/190145 | 13:07 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: libvirt: convert to use instance.image_meta property https://review.openstack.org/190146 | 13:07 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: compute: convert manager to use nova.objects.ImageMeta https://review.openstack.org/189685 | 13:07 |
| openstackgerrit | Daniel Berrange proposed openstack/nova: xenapi: convert driver to use nova.objects.ImageMeta https://review.openstack.org/188790 | 13:07 |
| johnthetubaguy | dane-fichter: awesome, thanks | 13:07 |
| *** moshele has joined #openstack-nova | 13:08 | |
| *** haigang has quit IRC | 13:09 | |
| *** markus_z has quit IRC | 13:09 | |
| *** jcoufal has joined #openstack-nova | 13:10 | |
| *** xek_ has quit IRC | 13:11 | |
| *** apuimedo has quit IRC | 13:11 | |
| *** chuckcarmack has joined #openstack-nova | 13:12 | |
| *** markus_z has joined #openstack-nova | 13:13 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Switch from deprecated timeutils.isotime https://review.openstack.org/211146 | 13:15 |
| *** park__ has joined #openstack-nova | 13:16 | |
| *** chaochin has joined #openstack-nova | 13:16 | |
| *** scheuran has quit IRC | 13:16 | |
| *** scheuran has joined #openstack-nova | 13:18 | |
| *** jichen has joined #openstack-nova | 13:18 | |
| *** thumpba has joined #openstack-nova | 13:19 | |
| *** Kennan has joined #openstack-nova | 13:20 | |
| *** jecarey has quit IRC | 13:20 | |
| *** Marga_ has joined #openstack-nova | 13:20 | |
| *** ankit has quit IRC | 13:21 | |
| *** zhenguo has quit IRC | 13:23 | |
| *** mriedem has joined #openstack-nova | 13:24 | |
| *** xek has quit IRC | 13:24 | |
| *** jwcroppe has joined #openstack-nova | 13:24 | |
| openstackgerrit | Jordan Pittier proposed openstack/nova: libvirt:update live_migration_monitor to use Guest https://review.openstack.org/211152 | 13:24 |
| *** arjan_work has joined #openstack-nova | 13:25 | |
| *** xek has joined #openstack-nova | 13:25 | |
| *** xek has quit IRC | 13:26 | |
| *** xek has joined #openstack-nova | 13:26 | |
| jordanP | sahid, ^^ This doesn't look really good. I add to add an extra argument to _live_migration_monitor whilst I wanted to replace the "dom" argument by a "Guest" argument | 13:26 |
| jordanP | *I had to | 13:26 |
| jordanP | sahid, but it seems I still need to dom argument because of the line "info = host.DomainJobInfo.for_domain(dom)" | 13:27 |
| *** jwcroppe_ has joined #openstack-nova | 13:27 | |
| sahid | jordanP: hum i do not think it's something we want | 13:27 |
| *** jwcropp__ has joined #openstack-nova | 13:28 | |
| sahid | if you want to use guest as extra arg it's to remove 'dom' | 13:28 |
| sahid | actually you should to replace it | 13:28 |
| *** salv-orl_ has joined #openstack-nova | 13:28 | |
| jordanP | sahid, right, I understand. But how could I replace the call to host.DomainJobInfo.for_domain ? | 13:28 |
| sahid | but i'm not asking you to do all of that work, you can simply add method is_active() in Guest object | 13:28 |
| jordanP | sahid, great :) | 13:29 |
| *** ctrath has joined #openstack-nova | 13:29 | |
| *** zzzeek has joined #openstack-nova | 13:29 | |
| sahid | then line 5611 you can use it | 13:29 |
| sahid | let me add a comment | 13:29 |
| *** jwcroppe has quit IRC | 13:29 | |
| *** xgsa has quit IRC | 13:30 | |
| *** xgsa has joined #openstack-nova | 13:30 | |
| *** shyu has quit IRC | 13:30 | |
| *** haigang has joined #openstack-nova | 13:31 | |
| *** jwcroppe_ has quit IRC | 13:31 | |
| *** salv-orlando has quit IRC | 13:31 | |
| *** diogogmt has quit IRC | 13:33 | |
| *** changbl has quit IRC | 13:34 | |
| *** shuquan has joined #openstack-nova | 13:35 | |
| *** marzif_ has quit IRC | 13:36 | |
| *** lyanchih has joined #openstack-nova | 13:36 | |
| *** chhavi has joined #openstack-nova | 13:36 | |
| *** marzif_ has joined #openstack-nova | 13:36 | |
| *** humble_ has quit IRC | 13:37 | |
| *** xgsa has quit IRC | 13:37 | |
| *** diogogmt has joined #openstack-nova | 13:38 | |
| *** humble_ has joined #openstack-nova | 13:39 | |
| *** VW_ has joined #openstack-nova | 13:39 | |
| *** ferest has joined #openstack-nova | 13:43 | |
| *** shoutm has quit IRC | 13:44 | |
| *** ferest has quit IRC | 13:46 | |
| *** haigang has quit IRC | 13:47 | |
| *** irenab has quit IRC | 13:50 | |
| *** ivasev has joined #openstack-nova | 13:50 | |
| *** thangp has joined #openstack-nova | 13:51 | |
| *** annegentle has quit IRC | 13:52 | |
| *** ijw has joined #openstack-nova | 13:53 | |
| *** arif-ali has quit IRC | 13:53 | |
| *** moshele has quit IRC | 13:54 | |
| *** alexpilotti has quit IRC | 13:55 | |
| jordanP | sahid, line 5611 I can't use guest.is_active() | 13:55 |
| jordanP | guest is not defined.... | 13:55 |
| jordanP | (if I don"t add an extra argument) | 13:56 |
| jordanP | euhh wait a min | 13:56 |
| jordanP | yeah, not it's not defined | 13:56 |
| edleafe | johnthetubaguy: on Friday you suggested doing the v3 cleanup in a feature branch. I've never done that with nova/gerrit - what is involved? | 13:57 |
| chhavi | johnthetubaguy: Hi, I'm interesting in seeing if I could help with the multi-attach-volume blueprint that looks like it will occur in the Mitaka release. I work on the PowerVM driver, and can drive the implementation there. But I'm curious if there are any other things I could potentially help out with? | 13:57 |
| sahid | jordanP: looking | 13:57 |
| openstackgerrit | Matthew Booth proposed openstack/nova: Don't check flavor disk size when booting from volume https://review.openstack.org/204635 | 13:57 |
| openstackgerrit | Chuck Carmack proposed openstack/nova: Fix DeprecationWarning when using BaseException.message https://review.openstack.org/207560 | 13:57 |
| openstackgerrit | Emma Foley proposed openstack/nova: Added support for specifying units to hw:mem_page_size https://review.openstack.org/209564 | 13:58 |
| *** markus_z has quit IRC | 13:58 | |
| johnthetubaguy | edleafe: I think we have to request one, its a bit too heavy weight now, I think alex_xu had some good suggestions about phasing the work | 13:58 |
| *** salv-orl_ has quit IRC | 13:59 | |
| edleafe | johnthetubaguy: yeah, those were pretty much the steps alex_xu and I had discussed at the outset | 13:59 |
| *** xgsa has joined #openstack-nova | 13:59 | |
| alex_xu | edleafe: yea, I think it's a little hard move tests code with api code together, let us separate them | 13:59 |
| edleafe | johnthetubaguy: so just go with a patch series instead? | 13:59 |
| alex_xu | edleafe: hope we can make the patch and review easy | 14:00 |
| *** READ10 has joined #openstack-nova | 14:00 | |
| *** jdandrea has joined #openstack-nova | 14:00 | |
| alex_xu | edleafe: currently I'm trying to base on PS25 https://review.openstack.org/#/c/193725/32 work out patch for move v2 code | 14:00 |
| sahid | jordanP: so if you don't want to update signature of all the live_migration things... | 14:01 |
| edleafe | alex_xu: ok, I was going to start working on that, but should I wait until you post something? | 14:01 |
| sahid | just add the TODO and guest initialization as line 5497 | 14:02 |
| *** annegentle has joined #openstack-nova | 14:02 | |
| jordanP | sahid, I'll just add the is_active on guest object and leave it to someone else to do the rest ? :p | 14:02 |
| sahid | methond _live_migration_operation | 14:02 |
| sahid | jordanP: yes i'm working on this so it should be ok i guess | 14:02 |
| jordanP | ok thanls | 14:02 |
| johnthetubaguy | edleafe: I think the best approach is what we said on friday, lets get a patch set up, get it reviewed, then we can see if we want to try squash it or not, incase thats useful | 14:03 |
| johnthetubaguy | oops | 14:03 |
| johnthetubaguy | patch series up | 14:03 |
| *** artom has joined #openstack-nova | 14:03 | |
| alex_xu | edleafe: yea, waiting for me post the newest version. let see if that's better | 14:04 |
| *** boris-42 has joined #openstack-nova | 14:04 | |
| edleafe | johnthetubaguy: ok - this time we'll take smaller bites | 14:04 |
| edleafe | alex_xu: ok, I'll wait | 14:04 |
| dhellmann | johnthetubaguy: when you have a few minutes, can you ack this stable client release request? https://review.openstack.org/#/c/209629/ | 14:05 |
| mhorban | sdague: hello! Question about wiki page https://wiki.openstack.org/wiki/URLs . We have mapping openstack ulrs to services there. But there is nothing about such services as nova/metadata and nova/ec2-api. I need to choose right names for these services and edit wiki page. | 14:05 |
| *** Murali_ has quit IRC | 14:05 | |
| *** xgsa has quit IRC | 14:06 | |
| *** josecastroleon has quit IRC | 14:06 | |
| openstackgerrit | Jordan Pittier proposed openstack/nova: libvirt:update live_migration_monitor to use Guest https://review.openstack.org/211152 | 14:07 |
| *** park_ has joined #openstack-nova | 14:07 | |
| openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Change docstring of api_versions.discover_version https://review.openstack.org/211177 | 14:07 |
| *** mili has joined #openstack-nova | 14:07 | |
| mili | Nova Experts | 14:07 |
| mili | https://ask.openstack.org/en/question/67273/nova-compute-cant-connect-to-nova-controller/?answer=79920#post-id-79920 | 14:07 |
| *** Sree has quit IRC | 14:08 | |
| *** Sree has joined #openstack-nova | 14:08 | |
| *** Kennan2 has joined #openstack-nova | 14:09 | |
| *** Kennan has quit IRC | 14:09 | |
| mili | Guys im having an issue with compute node in Kilo release | 14:10 |
| mili | anyone here that can help | 14:10 |
| mili | ? | 14:10 |
| *** arif-ali has joined #openstack-nova | 14:10 | |
| mili | its couple of bugs that are leading to this | 14:10 |
| *** Murali_ has joined #openstack-nova | 14:10 | |
| *** park__ has quit IRC | 14:11 | |
| *** chaochin has quit IRC | 14:11 | |
| *** xgsa has joined #openstack-nova | 14:12 | |
| *** chaochin has joined #openstack-nova | 14:12 | |
| *** Sree has quit IRC | 14:13 | |
| jroll | mili: see the topic | 14:14 |
| andreykurilin | sdague: hi! Can you look at small improvement for novaclient.api_versions_wraps decorator? https://review.openstack.org/#/c/210563/ ? | 14:14 |
| *** diogogmt has quit IRC | 14:14 | |
| mili | jroll: im sorry, i know its team discusion but im not getting an answer on this anywhere | 14:15 |
| johnthetubaguy | dhellmann: I am being dumb, I can't find a good way to diff what is going into this release | 14:15 |
| lxsli | what do I need to upgrade to understand a requirements.txt including ";python_version=='2.7'" please? Tried pip and setuptools already | 14:15 |
| johnthetubaguy | dhellmann: do you know a good way to get that done? | 14:15 |
| johnthetubaguy | dhellmann: oh wait, I see the hashes now | 14:16 |
| *** xgsa has quit IRC | 14:16 | |
| *** tojuvone has quit IRC | 14:16 | |
| *** Sree has joined #openstack-nova | 14:17 | |
| *** liusheng has quit IRC | 14:18 | |
| *** unicell1 has joined #openstack-nova | 14:18 | |
| johnthetubaguy | mriedem: I think this make sense, just wanted to give you a heads up on the new stable release for python-novaclient: https://review.openstack.org/#/c/209629 | 14:19 |
| *** r-daneel has joined #openstack-nova | 14:19 | |
| mriedem | johnthetubaguy: ok, let me check in detail - dealing with busted kilo atm so would be good to not break some more | 14:19 |
| *** unicell has quit IRC | 14:20 | |
| mriedem | +1 | 14:22 |
| johnthetubaguy | mriedem: cool thanks for checking that out | 14:22 |
| *** shuquan has quit IRC | 14:23 | |
| *** superdan is now known as dansmith | 14:23 | |
| dhellmann | johnthetubaguy: http://logs.openstack.org/29/209629/1/check/gate-releases-tox-list-changes/edde06a/ | 14:24 |
| sdague | mhorban: I'm not sure we can remap the urls on the ec2 services (the api and the metadata service which is modeled on theirs) | 14:24 |
| sdague | because it would break compat | 14:24 |
| sdague | but I don't know | 14:24 |
| *** Marga_ has quit IRC | 14:25 | |
| *** wverdugo500 has joined #openstack-nova | 14:25 | |
| *** Marga_ has joined #openstack-nova | 14:26 | |
| sdague | andreykurilin: can we get a few test cases to go along with - https://review.openstack.org/#/c/210563 ? | 14:26 |
| *** arjan_work has quit IRC | 14:27 | |
| *** josecastroleon has joined #openstack-nova | 14:29 | |
| *** Piet has quit IRC | 14:29 | |
| *** agireud has joined #openstack-nova | 14:29 | |
| andreykurilin | sdague: it's quite hard to check methods attributes, when it decorated(I don't know how to access to them), so I just can add tests to check that `cliutils.add_arg` is called by wraps decorator. Is it enough? | 14:29 |
| *** baoli has quit IRC | 14:29 | |
| *** afazekas has quit IRC | 14:31 | |
| *** baoli_ has joined #openstack-nova | 14:31 | |
| *** apuimedo has joined #openstack-nova | 14:31 | |
| *** sakaYK has joined #openstack-nova | 14:33 | |
| *** claudiub has joined #openstack-nova | 14:34 | |
| openstackgerrit | Andrey Kurilin proposed openstack/nova-specs: Update novaclient-api-microversions spec https://review.openstack.org/211206 | 14:38 |
| *** xgsa has joined #openstack-nova | 14:38 | |
| openstackgerrit | jichenjc proposed openstack/nova: Refactor test cases for live-migrate error case https://review.openstack.org/179048 | 14:40 |
| *** moshele has joined #openstack-nova | 14:40 | |
| *** jecarey has joined #openstack-nova | 14:41 | |
| *** annashen has joined #openstack-nova | 14:42 | |
| *** xyang1 has joined #openstack-nova | 14:42 | |
| *** cfriesen_ has joined #openstack-nova | 14:42 | |
| openstackgerrit | Andrey Kurilin proposed openstack/nova-specs: Update novaclient-api-microversions spec https://review.openstack.org/211206 | 14:43 |
| *** vilobhmm has joined #openstack-nova | 14:43 | |
| *** tpeoples has joined #openstack-nova | 14:44 | |
| *** exploreshaifali has joined #openstack-nova | 14:44 | |
| *** otter768 has joined #openstack-nova | 14:45 | |
| *** annashen has quit IRC | 14:46 | |
| *** fifieldt_ has quit IRC | 14:47 | |
| openstackgerrit | jichenjc proposed openstack/nova: Only set access_ip_* when instance goes ACTIVE https://review.openstack.org/129333 | 14:47 |
| *** mtanino has joined #openstack-nova | 14:48 | |
| sdague | andreykurilin: sure | 14:48 |
| jordanP | mriedem, do you have 2 min to explain a comment you left on https://review.openstack.org/#/c/192736/14/nova/virt/libvirt/driver.py,cm (libvirt:on snapshot delete, use qemu-img to blockRebase if VM is stopped) I don't understand what you said about save_and_reraise | 14:49 |
| mriedem | yeah | 14:49 |
| *** irenab has joined #openstack-nova | 14:49 | |
| *** otter768 has quit IRC | 14:50 | |
| jordanP | mriedem, should I add a save_and_reraise context L1897 with reraise=False and set reraise=True L1930 ? | 14:50 |
| *** scheuran has quit IRC | 14:51 | |
| *** Sree has quit IRC | 14:51 | |
| *** markus_z has joined #openstack-nova | 14:51 | |
| openstackgerrit | Balazs Gibizer proposed openstack/nova: Switch from deprecated timeutils.isotime https://review.openstack.org/211146 | 14:52 |
| openstackgerrit | Alexis Lee proposed openstack/nova: Make ObjectListBase a MutableSequence https://review.openstack.org/211215 | 14:52 |
| beagles | trying to get devstack rolling and nova-api chokes ... has the following in stack trace: serv.log.write("(%s) wsgi starting up on %s://%s%s/\n" % ( | 14:53 |
| beagles | AttributeError: 'KeywordArgumentAdapter' object has no attribute 'write' | 14:53 |
| beagles | " | 14:53 |
| beagles | thoughts anybody? | 14:53 |
| mriedem | jordanP: well, you put that exception block in the save_and_reraise_exception block which defaults to reraise, which is your L1930, | 14:54 |
| *** tonytan4ever has joined #openstack-nova | 14:54 | |
| mriedem | jordanP: but if you get to L1927 and that passes (the qemu-img call), then you set ctxt.reraise=False | 14:54 |
| jordanP | mriedem, got you. Thanks | 14:56 |
| mriedem | jordanP: added comments inline - i might have to think on it | 14:56 |
| mriedem | not sure how that will deal with the raised NovaException from within the block | 14:56 |
| *** dguitarbite has quit IRC | 14:56 | |
| jordanP | mriedem, "If another exception occurs, the saved exception is logged and the new exception is re-raised." | 14:57 |
| *** arjan_work has joined #openstack-nova | 14:57 | |
| jordanP | http://docs.openstack.org/developer/oslo.utils/api/excutils.html#oslo_utils.excutils.save_and_reraise_exception | 14:58 |
| mriedem | ok, that's what i was looking for | 14:58 |
| openstackgerrit | Roman Podoliaka proposed openstack/nova: Ensure test_models_sync() works with new Alembic releases https://review.openstack.org/211218 | 14:58 |
| jordanP | so it"s fine I guess | 14:58 |
| openstackgerrit | Alexis Lee proposed openstack/nova: Walk through the API, Conductor and Compute code https://review.openstack.org/210467 | 14:58 |
| lxsli | jaypipes: there it is | 14:59 |
| *** Sree has joined #openstack-nova | 14:59 | |
| *** dguitarbite has joined #openstack-nova | 14:59 | |
| *** Murali__ has joined #openstack-nova | 14:59 | |
| *** dave-mcc_ has joined #openstack-nova | 15:00 | |
| *** salv-orlando has joined #openstack-nova | 15:01 | |
| *** scheuran has joined #openstack-nova | 15:03 | |
| *** Murali_ has quit IRC | 15:03 | |
| *** Nikolay_St has quit IRC | 15:03 | |
| *** scheuran has quit IRC | 15:03 | |
| *** dave-mccowan has quit IRC | 15:04 | |
| *** scheuran has joined #openstack-nova | 15:04 | |
| *** fawadkhaliq has quit IRC | 15:06 | |
| *** dave-mccowan has joined #openstack-nova | 15:07 | |
| *** diogogmt has joined #openstack-nova | 15:07 | |
| *** Murali__ has quit IRC | 15:08 | |
| openstackgerrit | garyk proposed openstack/nova: VMware: expand support for Opaque networks https://review.openstack.org/165750 | 15:08 |
| *** garyk has joined #openstack-nova | 15:09 | |
| *** dave-mcc_ has quit IRC | 15:09 | |
| *** xgsa has quit IRC | 15:10 | |
| garyk | mriedem: i addressed the comments that you posted in the commit message - basically i opened a bp. i guess that effectively blocks this code landing in L as there is no chance this will be approved as the FFE's are no longer open. | 15:10 |
| *** thedodd has joined #openstack-nova | 15:10 | |
| openstackgerrit | jichenjc proposed openstack/nova: Avoid create / destory db info if volume attached https://review.openstack.org/163177 | 15:10 |
| *** chhavi has quit IRC | 15:11 | |
| openstackgerrit | Alexis Lee proposed openstack/nova: Adds resource classes https://review.openstack.org/128999 | 15:13 |
| openstackgerrit | Alexis Lee proposed openstack/nova: Add non-negative integer and float fields https://review.openstack.org/206249 | 15:13 |
| openstackgerrit | Alexis Lee proposed openstack/nova: Add object models for comparing resource amounts https://review.openstack.org/128992 | 15:13 |
| garyk | mriedem: i agree with you that the subteam does need to review more. | 15:13 |
| *** jamie_h has quit IRC | 15:14 | |
| *** hemnafk has quit IRC | 15:16 | |
| *** hemna_ has joined #openstack-nova | 15:17 | |
| *** armax has joined #openstack-nova | 15:17 | |
| *** diogogmt has quit IRC | 15:18 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Move existing V2 to legacy_v2 https://review.openstack.org/193725 | 15:19 |
| *** diogogmt has joined #openstack-nova | 15:19 | |
| *** pas-ha has quit IRC | 15:19 | |
| *** brad_ has joined #openstack-nova | 15:20 | |
| *** hemna_ has quit IRC | 15:21 | |
| *** dannywilson has joined #openstack-nova | 15:23 | |
| *** chhavi has joined #openstack-nova | 15:24 | |
| *** dannywilson has quit IRC | 15:24 | |
| *** chhavi has quit IRC | 15:24 | |
| *** chhavi has joined #openstack-nova | 15:24 | |
| *** dannywilson has joined #openstack-nova | 15:24 | |
| *** kiwik has joined #openstack-nova | 15:25 | |
| *** kiwik-chenrui has quit IRC | 15:26 | |
| *** hemna_ has joined #openstack-nova | 15:27 | |
| *** park_ has quit IRC | 15:27 | |
| *** shakamunyi has joined #openstack-nova | 15:27 | |
| *** josecastroleon has quit IRC | 15:28 | |
| *** park_ has joined #openstack-nova | 15:28 | |
| *** kiran-r has joined #openstack-nova | 15:29 | |
| *** thumpba has quit IRC | 15:30 | |
| *** rajesht has quit IRC | 15:31 | |
| *** xgsa has joined #openstack-nova | 15:31 | |
| *** arjan_work has quit IRC | 15:32 | |
| *** thumpba has joined #openstack-nova | 15:32 | |
| openstackgerrit | Alex Xu proposed openstack/nova: Move existing V2 to legacy_v2 https://review.openstack.org/193725 | 15:33 |
| *** kmartin_ is now known as kmartin | 15:33 | |
| alex_xu | edleafe: it's done ^ :) | 15:33 |
| alex_xu | edleafe: it passed in my local, would you like monitor on if that pass all the ci tests. Then we can ask johnthetubaguy and sdague give a review. | 15:33 |
| alex_xu | edleafe: and you can work on move v3 code, but wihout move any tests. And in tomorrow morning, I will monitor on move v3 code, and updated it if something wrong, then hope we can get move v3 code patch merged tomorrow | 15:35 |
| markus_z | mriedem: Would be great if you could find the time to give me feedback for https://review.openstack.org/#/c/209187/ | 15:35 |
| *** SourabhP has joined #openstack-nova | 15:35 | |
| sdague | alex_xu: we might need a compatibility shim for those symbols and the paste.ini for grenade to pass | 15:35 |
| sdague | but it will be good to get tests back on that | 15:35 |
| alex_xu | sdague: you mean add some tests in grenade? | 15:36 |
| johnthetubaguy | alex_xu: edleafe: whats the plan for CONF.osapi_compute_extension I see changes in the unit tests due to the class path changes? | 15:36 |
| *** thumpba has quit IRC | 15:37 | |
| sdague | alex_xu: no, I mean grenade will probably fail, but we'll see | 15:37 |
| alex_xu | sdague: ok... let see | 15:37 |
| alex_xu | johnthetubaguy: which unittest changed? | 15:37 |
| *** thumpba has joined #openstack-nova | 15:37 | |
| *** belmoreira has quit IRC | 15:38 | |
| alex_xu | johnthetubaguy: at least expect osapi_compute_extension compatible old class path | 15:38 |
| *** thumpba has quit IRC | 15:38 | |
| *** alexschm has quit IRC | 15:38 | |
| *** thumpba has joined #openstack-nova | 15:38 | |
| johnthetubaguy | alex_xu: its these ones: https://review.openstack.org/#/c/193725/34/nova/tests/functional/v3/test_access_ips.py,cm | 15:38 |
| *** changbl has joined #openstack-nova | 15:39 | |
| *** rotbeard has joined #openstack-nova | 15:40 | |
| *** tjones has joined #openstack-nova | 15:40 | |
| *** thumpba has quit IRC | 15:40 | |
| *** tjones has left #openstack-nova | 15:40 | |
| *** thumpba has joined #openstack-nova | 15:41 | |
| alex_xu | johnthetubaguy: emm...yes, we should keep the a reference, I missed that | 15:41 |
| johnthetubaguy | alex_xu: its more the config not working across upgrades that worries me | 15:41 |
| *** Sukhdev has joined #openstack-nova | 15:41 | |
| johnthetubaguy | alex_xu: don't we need some kinda of compatibility code so folks don't have their config broken by the code move? | 15:42 |
| alex_xu | johnthetubaguy: yes, we need | 15:42 |
| johnthetubaguy | alex_xu: is it in this patch? | 15:42 |
| johnthetubaguy | (I think it has to be) | 15:43 |
| *** exploreshaifali has quit IRC | 15:43 | |
| alex_xu | johnthetubaguy: no, just part of that, https://review.openstack.org/#/c/193725/34/nova/api/openstack/compute/contrib/__init__.py | 15:43 |
| alex_xu | johnthetubaguy: let me add those code | 15:43 |
| johnthetubaguy | alex_xu: cool, thank you | 15:44 |
| alex_xu | johnthetubaguy: np | 15:44 |
| *** thumpba has quit IRC | 15:44 | |
| *** thumpba has joined #openstack-nova | 15:45 | |
| edleafe | alex_xu: ok, I'll check it out (in between meetings!) | 15:45 |
| alex_xu | edleafe: thanks! | 15:46 |
| *** arjan_work has joined #openstack-nova | 15:46 | |
| *** tsbot_ has quit IRC | 15:47 | |
| *** tsekiyama has joined #openstack-nova | 15:47 | |
| *** ssurana has joined #openstack-nova | 15:48 | |
| rlrossit | dansmith: could you take a look at https://review.openstack.org/#/c/203831/ when you get a chance and let me know if how I did that was good/bad | 15:48 |
| *** vilobhmm has quit IRC | 15:48 | |
| dansmith | yep, just a sec | 15:48 |
| rlrossit | awesome. thanks! | 15:48 |
| *** vilobhmm has joined #openstack-nova | 15:48 | |
| *** dguitarbite has quit IRC | 15:49 | |
| *** vilobhmm has quit IRC | 15:49 | |
| *** jistr has quit IRC | 15:50 | |
| *** rushil has quit IRC | 15:53 | |
| *** sudipto has joined #openstack-nova | 15:55 | |
| *** yamahata has joined #openstack-nova | 15:57 | |
| *** jcoufal has quit IRC | 15:57 | |
| *** Sree has quit IRC | 15:59 | |
| *** meghal has joined #openstack-nova | 16:00 | |
| johnthetubaguy | claudiub: do you have a moment to catch up about the hyper-v section in here? https://etherpad.openstack.org/p/liberty-nova-priorities-tracking | 16:00 |
| claudiub | johnthetubaguy: sure. what's up? | 16:01 |
| johnthetubaguy | claudiub: for the trivial bug patches, I think its probably better to put it on the general list for those, as that gets more attention | 16:01 |
| johnthetubaguy | claudiub: I don't actually see any bugs in the list right now, do you have a list of bugs that we should really get fixed in liberty that we can add in here? | 16:02 |
| johnthetubaguy | claudiub: also, given non of those items got a feature freeze exception, I am guessing we can remove those blueprint patches now? | 16:03 |
| *** Nikolay_St has joined #openstack-nova | 16:03 | |
| claudiub | johnthetubaguy: yeah, I noticed that. I've put a trivial bug on that trivial bug list and it was picked up rather fast. As for the bug list, I'll take a quick look at all the commits wer have. | 16:03 |
| *** unicell1 has quit IRC | 16:03 | |
| claudiub | johnthetubaguy: Yeah, that's unfortunate that the -2 hammer dropped so fast. :D | 16:04 |
| johnthetubaguy | claudiub: that would be good, we have a bug push coming up on wednesday, its worth getting a good list | 16:04 |
| claudiub | johnthetubaguy: I'll refresh the list asap. ~30 I think should be done. | 16:04 |
| johnthetubaguy | claudiub: cool, thanks | 16:04 |
| *** jlanoux has quit IRC | 16:04 | |
| *** browne has joined #openstack-nova | 16:05 | |
| *** SourabhP has quit IRC | 16:06 | |
| *** alex_klimov has quit IRC | 16:06 | |
| *** amotoki has joined #openstack-nova | 16:08 | |
| *** leeantho has joined #openstack-nova | 16:09 | |
| openstackgerrit | Feodor Tersin proposed openstack/nova: Suppress not image properties for image metadata from volume https://review.openstack.org/204947 | 16:10 |
| *** exploreshaifali has joined #openstack-nova | 16:12 | |
| *** tojuvone has joined #openstack-nova | 16:13 | |
| *** kiran-r has quit IRC | 16:14 | |
| *** penick has joined #openstack-nova | 16:16 | |
| openstackgerrit | whitekid proposed openstack/nova: replace memcache.get to memcache.get_multi for better performance https://review.openstack.org/211250 | 16:16 |
| *** burgerk has joined #openstack-nova | 16:17 | |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Adds VolumeOps unit tests https://review.openstack.org/139797 | 16:20 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Adds MigrationOps unit tests https://review.openstack.org/139796 | 16:20 |
| openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Adds HyperVDriver unit tests https://review.openstack.org/148980 | 16:20 |
| *** scheuran has quit IRC | 16:20 | |
| *** garyk has quit IRC | 16:24 | |
| *** patrickeast has joined #openstack-nova | 16:25 | |
| openstackgerrit | Alexis Lee proposed openstack/nova: Make ObjectListBase a MutableSequence https://review.openstack.org/211215 | 16:26 |
| *** lucasagomes has quit IRC | 16:27 | |
| *** sahid has quit IRC | 16:28 | |
| edleafe | alex_xu: just ran the tests on your PS, and got the same results: all passed except docs | 16:28 |
| alex_xu | edleafe: oops, I didn't check the docs | 16:28 |
| *** burt has joined #openstack-nova | 16:28 | |
| jaypipes | lxsli: nice one. +2 from me. | 16:28 |
| jaypipes | dansmith: https://review.openstack.org/#/c/211215/ | 16:29 |
| lxsli | jaypipes: sweet, thanks :D | 16:29 |
| *** jkraj has quit IRC | 16:29 | |
| *** chhavi has quit IRC | 16:29 | |
| alex_xu | edleafe: the time is too late, if you have time, can you fix it and good point from johnthetubaguy at https://review.openstack.org/#/c/193725/34 , then tomrrow morning I will continue your works also | 16:30 |
| edleafe | alex_xu: ok. Get some rest!! | 16:30 |
| alex_xu | edleafe: thanks see you tomorrow | 16:31 |
| *** shyama has quit IRC | 16:31 | |
| *** jichen has quit IRC | 16:32 | |
| *** mdrabe has joined #openstack-nova | 16:33 | |
| *** nic has joined #openstack-nova | 16:33 | |
| jroll | edleafe: so sounds like nobody is opposed to that ironic host manager patch thing, I vote we get this in | 16:34 |
| *** fawadkhaliq has joined #openstack-nova | 16:34 | |
| dansmith | jaypipes: lxsli: so we originally specifically didn't allow for mutability on those | 16:34 |
| dansmith | let me finish this call and I'll explain | 16:34 |
| dansmith | and you can say "I don't care, I want it this way" | 16:34 |
| edleafe | jroll: yeah, so we just have to wait unti bauzas gets back from holiday | 16:34 |
| jaypipes | sure, no prob | 16:34 |
| jroll | edleafe: I tend to think between his comment there and the ML discussion, cores would be comfortable merging with that -1 there | 16:35 |
| jroll | but that's just me | 16:35 |
| *** penick has quit IRC | 16:35 | |
| * jroll links to ML thing in review | 16:35 | |
| lxsli | dansmith: I like immutable things and don't mind if lists stay immutable, I just wanted a better version of Jay's patch (and something to procrastinate with) | 16:35 |
| edleafe | jroll: agreed, but it's much simpler without the -1 | 16:35 |
| *** unicell has joined #openstack-nova | 16:36 | |
| *** mjturek1 has quit IRC | 16:37 | |
| claudiub | johnthetubaguy: done updating the list. most of them are trivial bug fixes actually. The biggest commits are the *Ops unit tests that I reaaally want to get rid of, as they replace the old mox unit tests with mock unit tests, which are painful to update each time we add a new feature. | 16:38 |
| *** lyanchih has quit IRC | 16:38 | |
| dansmith | jaypipes: lxsli: so the deal was: we wanted to avoid the list objects looking like they represented a set in the database. | 16:39 |
| dansmith | jaypipes: lxsli: specifically, we never want them to have a save() call, so that people thing they can add one to the list and call list.save() and have it be an INSERT in the DB | 16:39 |
| openstackgerrit | Roman Podoliaka proposed openstack/nova: Ensure test_models_sync() works with new Alembic releases https://review.openstack.org/211218 | 16:40 |
| dansmith | jaypipes: lxsli: mutability of the list goes in the same vein there, where you could build a similar assumption | 16:40 |
| dansmith | jaypipes: lxsli: that said, that was back when we didn't have any non-DB-backed objects, so maybe we need to either (a) modify the rule or (b) add another mixin to give us a place for a clear docstring about danger | 16:40 |
| jaypipes | dansmith: so what that means is that you inevitably get code that looks like this: | 16:41 |
| jaypipes | https://github.com/openstack/nova/blob/master/nova/pci/manager.py#L78-L85 | 16:41 |
| dannywilson | danpb: mriedem: johnthetubaguy: hi, just curious on what to do about https://review.openstack.org/#/c/205726/. There is support from the cinder side and danpb to get this merged into L and I am just wondering if there is any chance of that or anything I can do to make that happen. | 16:41 |
| *** rushil has joined #openstack-nova | 16:41 | |
| dansmith | jaypipes: yeah | 16:41 |
| dansmith | that does suck indeed | 16:42 |
| dansmith | jaypipes: so, in order to keep our semantics, what if we did something like this: | 16:42 |
| dansmith | @remotable_classmethod def save_all(context, list_of_things): | 16:42 |
| *** xyang1 has quit IRC | 16:42 | |
| dansmith | which would be a single-shot call to call save() a list of objects, but remotely instead of N calls ? | 16:43 |
| *** penick has joined #openstack-nova | 16:43 | |
| *** bapalm has joined #openstack-nova | 16:43 | |
| *** annashen has joined #openstack-nova | 16:43 | |
| dansmith | although I don't think the mutability handlers have anything to do with this specific issue necessarily | 16:43 |
| mriedem | dannywilson: what actually consumes this? conf.driver_discard = 'unmap' | 16:43 |
| *** marzif_ has quit IRC | 16:44 | |
| mriedem | libvirt i guess | 16:44 |
| *** marzif_ has joined #openstack-nova | 16:44 | |
| dannywilson | mriedem: correct, https://github.com/openstack/nova/blob/master/nova/virt/libvirt/config.py | 16:45 |
| *** ssurana has quit IRC | 16:46 | |
| *** penick has quit IRC | 16:46 | |
| *** otter768 has joined #openstack-nova | 16:46 | |
| *** rotbeard has quit IRC | 16:46 | |
| *** mdrabe has quit IRC | 16:46 | |
| *** mdrabe has joined #openstack-nova | 16:47 | |
| *** annashen has quit IRC | 16:47 | |
| *** yassine has quit IRC | 16:47 | |
| jgriffith | mriedem: ping | 16:47 |
| openstackgerrit | Arata Notsu proposed openstack/nova: More specific error messages on building BDM https://review.openstack.org/209897 | 16:47 |
| jgriffith | mriedem: oh... hehe.. I think you might already be discussing: https://review.openstack.org/#/c/205726/ | 16:48 |
| jaypipes | dansmith: I'd be cool with that. but that's quite a bit more work than what is proposed here. I think I will just move on and undo these last two patches in the PCI series. | 16:48 |
| dansmith | jaypipes: I haven't looked at yours, just lxsli | 16:48 |
| *** romainh has left #openstack-nova | 16:48 | |
| dansmith | jaypipes: can you link me? I can write you that thing | 16:48 |
| jgriffith | mriedem: FWIW, I view this as a bug | 16:48 |
| jaypipes | dansmith: https://github.com/openstack/nova/blob/master/nova/pci/manager.py#L78-L85 is refactored in the patch here: https://review.openstack.org/#/c/210948/ | 16:48 |
| jgriffith | mriedem: there are a number of app's like couch-db etc that rely on this, and the fact that we're silently just eating the command causes some issues | 16:49 |
| jgriffith | mriedem: I did have an issue with how it's implemented though :( | 16:49 |
| danpb | jgriffith: there's reall no sense in which this can be called a bug | 16:49 |
| openstackgerrit | whitekid proposed openstack/nova: tuning extended volume extensions https://review.openstack.org/211258 | 16:49 |
| jgriffith | danpb: you don't think so? | 16:49 |
| jgriffith | danpb: ok | 16:49 |
| danpb | jgriffith: but I do think we should accept this in nova for liberty none the less | 16:49 |
| danpb | because the cinder side is done and the libvirt bit is utterly trivial | 16:49 |
| mriedem | the commit message is sorely lacking detail | 16:50 |
| ndipanov | jaypipes, fwiw we have on order of 10s of those per compute host usually | 16:50 |
| dansmith | jaypipes: oh, I thought you were trying to refactor out the multiple calls | 16:50 |
| mriedem | when i see "add*support*" in a commit message, i assume feature | 16:50 |
| ndipanov | it would be good to kill those multiple calls of course but I woudn't call it critical | 16:50 |
| mriedem | that's why i asked if it were a blueprint | 16:50 |
| mriedem | or needed one | 16:50 |
| danpb | it should have been a spec-less blueprint really | 16:50 |
| jgriffith | danpb: yeah... I'm certainly not going to argue. I did have a concern about it being part of the connection info as opposed to provider fields but honestly I would just like to see it land (bug, feature or whatever) :) | 16:50 |
| jgriffith | danpb: I'm happy to write one up if that helps? | 16:51 |
| dansmith | jaypipes: https://review.openstack.org/#/c/210948/1/nova/pci/manager.py,cm | 16:51 |
| *** otter768 has quit IRC | 16:51 | |
| jgriffith | Oh... errr | 16:51 |
| jaypipes | ndipanov: I'm only trying to clean up the messy code. | 16:51 |
| jgriffith | has one, never mind | 16:51 |
| danpb | jgriffith: there's alreayd one actually i see https://blueprints.launchpad.net/nova/+spec/cinder-backend-report-discard | 16:51 |
| danpb | but to start with most important thing is to make sure the patch is actually mergable | 16:52 |
| jgriffith | danpb: yeah | 16:52 |
| danpb | currently its in conflict which kills any discussion of merging it really | 16:52 |
| jgriffith | danpb: fair | 16:52 |
| jgriffith | dannywilson: Can you rebase that? | 16:52 |
| dannywilson | I wanted to get views on it before rebase causes loss of +2, I will do so now | 16:52 |
| jgriffith | dannywilson: yeah, but people like me don't spend much time looking if it won't merge :( | 16:53 |
| dansmith | ndipanov: I can kill those separate from jaypipes' work | 16:53 |
| dannywilson | jgriffith: understood, thanks | 16:53 |
| danpb | dannywilson: we're at the point int he cycle where a merge conflict means we'll just totally ignore something | 16:53 |
| jaypipes | dansmith: I will push a new patch with the approach you outlined in that review. | 16:53 |
| mriedem | dannywilson: note the comments i just put in htere | 16:53 |
| mriedem | before you rebase | 16:53 |
| jgriffith | danpb: thanks for chatting about it and at least considering it | 16:53 |
| dannywilson | mriedem: will do | 16:54 |
| *** mjturek1 has joined #openstack-nova | 16:54 | |
| lxsli | dansmith: jaypipes: so we're not making our lists mutable? Shall I push a new patch that makes them Sequences instead of MutableSequences? | 16:54 |
| jgriffith | dannywilson: danpb Any thoughts regarding use of provider fields vs connector info? | 16:55 |
| dansmith | lxsli: I'd prefer we not, yeah.. what is the benefit of the Sequence linkage? | 16:55 |
| jaypipes | lxsli: well, I'm actually going to be undoing the thing that was going to depend on that patch :) so it's not as important to me now... | 16:55 |
| dannywilson | danpb: can you check mriedem comments? Do we need to do a version check at all? I think the older versions would ignore the unmap setting. | 16:55 |
| jgriffith | dannywilson: danpb or am I pushing my luck by bringing it up :) | 16:55 |
| jordanP | danpb, could you review https://review.openstack.org/#/c/211152/2 (libvirt:update live_migration_monitor to use Guest) that we discussed this morning ? Thanks | 16:55 |
| lxsli | dansmith: you get contains, reversed, index and count for free | 16:55 |
| dansmith | lxsli: not sure how that would be, but okay :) | 16:56 |
| lxsli | dansmith: I quite like a thing called a List to act like a List in as many ways as possible | 16:56 |
| dannywilson | jgriffith: my only concern would be it adds complexity but need to check out how it would look first | 16:56 |
| lxsli | it's just like comparable, you implement <=> and get everything else for free (well not in Python any more but ...) | 16:56 |
| *** alexpilotti_ has joined #openstack-nova | 16:57 | |
| jgriffith | dannywilson: it's a similar change but if it raises any concern for anybody I'm fine with what you have | 16:57 |
| *** ildikov has quit IRC | 16:57 | |
| danpb | dannywilson: you do need a version check | 16:58 |
| danpb | libvirt checks qemu and reports | 16:58 |
| danpb | virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", | 16:58 |
| danpb | _("discard is not supported by this QEMU binary")); | 16:58 |
| danpb | if missing | 16:58 |
| *** rdopiera has quit IRC | 16:58 | |
| *** sakaYK has quit IRC | 16:58 | |
| danpb | yo don't need to check libvirt version - old libvirt just ignores it - only need to check qemu version | 16:58 |
| dansmith | jaypipes: once you push that up, I'll stack a patch on top to reduce the calls to one | 16:58 |
| mriedem | dannywilson: the cinder spec says you have to set libvirt.hw_disk_discard = unmap in nova.conf to use this | 16:58 |
| dannywilson | danpb: ah, okay | 16:58 |
| mriedem | dannywilson: danpb: and there is already a version check in the libvirt driver for using hw_disk_discard | 16:58 |
| danpb | mriedem: that's wrong | 16:59 |
| mriedem | super | 16:59 |
| jaypipes | dansmith: ok dokey. | 16:59 |
| dansmith | jaypipes: on this: https://review.openstack.org/#/c/210180/3/nova/objects/pci_device.py,cm | 16:59 |
| mriedem | ok, well this is what i am trying to say about the commit message | 16:59 |
| danpb | mriedem: the libvirt.hw_disk_discard setting is for controling it on nova images | 16:59 |
| danpb | this is about nova volume | 16:59 |
| dansmith | jaypipes: you're supporting every possible status in the enum, right? | 16:59 |
| *** baoli_ has quit IRC | 16:59 | |
| *** amotoki has quit IRC | 16:59 | |
| danpb | i already had this fixed in earlier reviews | 16:59 |
| jaypipes | dansmith: AFAIK, yes: https://review.openstack.org/#/c/210180/3/nova/objects/fields.py | 17:00 |
| *** baoli has joined #openstack-nova | 17:00 | |
| dansmith | jaypipes: okay, don't hate me, but I left a comment | 17:00 |
| dannywilson | danpb: but to have the correct controller in place you need setting in nova.conf and add props to glance image as well | 17:00 |
| dansmith | but it makes your patch smaller | 17:00 |
| *** alexpilotti_ has quit IRC | 17:01 | |
| jaypipes | dansmith: doh, that wouldv'e been helpful... :) I spent an afternoon yesterday pushing verrsion increment after version increment... | 17:01 |
| *** fawadkhaliq has quit IRC | 17:01 | |
| dansmith | jaypipes: I feel no sympathy for you working on a sunday :D | 17:01 |
| dansmith | hopefully you'll learn | 17:01 |
| jaypipes | hehe | 17:02 |
| jaypipes | k, lemme rework these... | 17:02 |
| * dansmith goes to find a beer-by-mail service for jaypipes | 17:02 | |
| jaypipes | lol | 17:02 |
| lxsli | dansmith: btw would it be easier if I did this straight in o.vo instead of nova? Since there's no pressing need for it today | 17:04 |
| dansmith | lxsli: yes | 17:04 |
| lxsli | right you are | 17:04 |
| *** exploreshaifali has quit IRC | 17:04 | |
| dansmith | plus, o.vo commits are like badges on a military uniform | 17:05 |
| dansmith | the more you have, the cooler you are | 17:05 |
| dannywilson | danpb: mriedem: I was building off of https://review.openstack.org/#/c/70263/ and trying to re-use prior work | 17:05 |
| mriedem | so it sounds like this isn't as trivial as previously thought | 17:07 |
| dannywilson | mriedem: danpb: it sounds like I need better info in the blueprint, I will update the blueprint to make it clear what is needed to make this work | 17:07 |
| mriedem | and the commit message | 17:07 |
| mriedem | at this point i think this has to come up in the weekly nova meeting to see if it requires a specless blueprint and if that's even allowable to merge at tihs point in the release when we've dropped the -2 hammer on all other bp things | 17:07 |
| dannywilson | mriedem: agreed. It is a trivial commit but requires some extra steps to make the discard command actually work | 17:08 |
| *** SourabhP has joined #openstack-nova | 17:09 | |
| dannywilson | mriedem: extra doc work maybe? I will update things, thank you so much for your time | 17:09 |
| danpb | explanation in the commit message is probably most important at this stage | 17:09 |
| dannywilson | danpb: ok | 17:10 |
| *** gszasz has quit IRC | 17:10 | |
| *** jamielennox is now known as jamielennox|away | 17:11 | |
| lxsli | dansmith: jaypipes: https://review.openstack.org/#/c/211268/ | 17:13 |
| *** danpb has quit IRC | 17:14 | |
| *** achanda has joined #openstack-nova | 17:14 | |
| *** tjones has joined #openstack-nova | 17:14 | |
| lxsli | and with that, I fleeeeeee | 17:15 |
| *** bapalm has quit IRC | 17:16 | |
| *** salv-orlando has quit IRC | 17:16 | |
| *** bapalm has joined #openstack-nova | 17:16 | |
| *** matrohon has quit IRC | 17:17 | |
| *** moshele has quit IRC | 17:18 | |
| *** ssurana has joined #openstack-nova | 17:18 | |
| *** garyk has joined #openstack-nova | 17:18 | |
| *** wanghua has joined #openstack-nova | 17:20 | |
| *** bapalm has quit IRC | 17:21 | |
| *** humble_ has quit IRC | 17:22 | |
| johnthetubaguy | claudiub: I see lots more trivial bug patches in the hyper-v section, I thought you were going to add those into the larger list? | 17:23 |
| *** tjones has left #openstack-nova | 17:23 | |
| claudiub | johnthetubaguy: will add them | 17:24 |
| claudiub | johnthetubaguy: but what's your opinion, shoud I leave the items on both lists, or just on the larger list? | 17:24 |
| johnthetubaguy | claudiub: cool, there are a few I struck out, so I think they can get killed off now | 17:25 |
| johnthetubaguy | claudiub: personally, I would just have them on the larger list | 17:25 |
| johnthetubaguy | claudiub: if they had a few reviews from subteam folks, then maybe both, but thats sounds like too much paperwork to me | 17:25 |
| *** Nikolay_St has quit IRC | 17:26 | |
| claudiub | johnthetubaguy: true, will move them to the larger list. | 17:26 |
| *** dave-mccowan has quit IRC | 17:26 | |
| openstackgerrit | Nicolas Simonds proposed openstack/nova: libvirt: make snapshot use RBD snapshot/clone when available https://review.openstack.org/205282 | 17:28 |
| dansmith | jaypipes: can't you do self.pci_devs.objects.remove(dev) ? | 17:28 |
| openstackgerrit | Nicolas Simonds proposed openstack/nova: libvirt: Split out resize_image logic from create_image https://review.openstack.org/187857 | 17:28 |
| openstackgerrit | Jay Pipes proposed openstack/nova: pci: Use PciDeviceList for PciDevTracker.pci_devs https://review.openstack.org/210948 | 17:29 |
| openstackgerrit | Jay Pipes proposed openstack/nova: pci: Move whitelist filtering inside PCI tracker https://review.openstack.org/210182 | 17:29 |
| openstackgerrit | Jay Pipes proposed openstack/nova: pci: Remove get_pci_devices_filter() method https://review.openstack.org/210183 | 17:29 |
| openstackgerrit | Jay Pipes proposed openstack/nova: pci: Use fields.Enum type for PCI device status https://review.openstack.org/210180 | 17:29 |
| openstackgerrit | Jay Pipes proposed openstack/nova: pci: Use fields.Enum type for PCI device type https://review.openstack.org/210181 | 17:29 |
| jaypipes | dansmith: yeah... | 17:29 |
| *** rushil has quit IRC | 17:30 | |
| openstackgerrit | Jay Pipes proposed openstack/nova: pci: Use PciDeviceList for PciDevTracker.pci_devs https://review.openstack.org/210948 | 17:30 |
| *** ritesh has quit IRC | 17:30 | |
| jaypipes | dansmith: done. | 17:30 |
| dansmith | cool | 17:31 |
| claudiub | johnthetubaguy: anyways, thanks for the reviews / help. :) | 17:31 |
| *** rushil has joined #openstack-nova | 17:32 | |
| openstackgerrit | Nicolas Simonds proposed openstack/nova: libvirt: Fix/implement revert-resize for RBD-backed images https://review.openstack.org/187395 | 17:32 |
| johnthetubaguy | claudiub: thank you for filling up the list, I hope this really starts to get some traction now | 17:33 |
| *** marzif_ has quit IRC | 17:36 | |
| *** marzif_ has joined #openstack-nova | 17:36 | |
| johnthetubaguy | claudiub: if you get chance, I had a question on this one, wasn't sure how the change is tested, I can't find how its tested: https://review.openstack.org/#/c/194070/3 | 17:38 |
| * johnthetubaguy is running off for the day now | 17:38 | |
| *** baoli has quit IRC | 17:39 | |
| *** markus_z has quit IRC | 17:39 | |
| *** READ10 has quit IRC | 17:39 | |
| *** mili has quit IRC | 17:39 | |
| claudiub | johnthetubaguy: will do. | 17:41 |
| *** Sukhdev has quit IRC | 17:41 | |
| *** Sukhdev has joined #openstack-nova | 17:42 | |
| openstackgerrit | Tracy Jones proposed openstack/nova: Cleanup of compute api reboot method https://review.openstack.org/127427 | 17:43 |
| edleafe | does anyone here understand how the doc builds when running 'tox -e docs' work? Trying to debug a bad reference and getting nowhere | 17:43 |
| *** tjones has joined #openstack-nova | 17:43 | |
| *** baoli has joined #openstack-nova | 17:43 | |
| tjones | https://review.openstack.org/#/c/127427/ daily rebase… | 17:44 |
| *** marzif_ has quit IRC | 17:44 | |
| *** Marga_ has quit IRC | 17:46 | |
| openstackgerrit | Jordan Pittier proposed openstack/nova: libvirt:on snapshot delete, use qemu-img to blockRebase if VM is stopped https://review.openstack.org/192736 | 17:46 |
| *** Marga_ has joined #openstack-nova | 17:47 | |
| *** tjones has left #openstack-nova | 17:48 | |
| dansmith | jaypipes: I'm basing my fix on your set, so I'll fix the thing I just commented on | 17:49 |
| jaypipes | ok | 17:49 |
| *** jordanP has quit IRC | 17:51 | |
| dansmith | jaypipes: you're also randomly reordering the position of pci_devices in Instance.. that's accidental, right? | 17:51 |
| jaypipes | yes, sorry.. | 17:52 |
| dansmith | k, will fix that too | 17:53 |
| *** jaypipes has left #openstack-nova | 17:54 | |
| *** jaypipes has joined #openstack-nova | 17:54 | |
| *** penick has joined #openstack-nova | 17:55 | |
| *** dave-mccowan has joined #openstack-nova | 17:56 | |
| *** SourabhP has quit IRC | 17:57 | |
| *** xyang1 has joined #openstack-nova | 17:58 | |
| *** flwang has quit IRC | 17:58 | |
| *** dave-mcc_ has joined #openstack-nova | 17:58 | |
| dansmith | jaypipes: so, looking at your code now makes me wonder... | 17:58 |
| dansmith | jaypipes: the existing code will delete things from self.pci_devs if they are DELETED in the database | 17:58 |
| dansmith | jaypipes: your code will only do that if they're "changed" during this round | 17:59 |
| dansmith | is that intentional? | 17:59 |
| *** annashen has joined #openstack-nova | 17:59 | |
| *** annashen has quit IRC | 17:59 | |
| *** dave-mccowan has quit IRC | 18:01 | |
| jaypipes | dansmith: I don't see how my code is functionally different from the original aside from not having a new list comprehension create a set of new pci device items from the original self.pci_devs... | 18:01 |
| dansmith | jaypipes: because save() will refresh the device (in our list) from the database | 18:02 |
| dansmith | I'm not sure that anything other than the compute node would delete a pci device, so maybe it doesn't matter in practice | 18:02 |
| dansmith | no, wait, we don't call save() on them unless they're changed | 18:03 |
| dansmith | so nevermind | 18:03 |
| *** geekinutah has joined #openstack-nova | 18:03 | |
| jaypipes | :) | 18:03 |
| dansmith | jaypipes: okay, so the reason I'm barking up this tree is.. are you really just concerned about the list comprehension or what? | 18:03 |
| dansmith | because if I do this batch save, | 18:04 |
| dansmith | we drop a ton of rpc overhead, | 18:04 |
| jaypipes | dansmith: that would be ideal :) | 18:04 |
| dansmith | but I have to reconstruct the list in a similar way | 18:04 |
| dansmith | or I have to at least iterate twice, once to catch the modified ones and again to reset changes on them | 18:04 |
| dansmith | and just iterating the list twice seems like more than worth the gain by making a single rpc call to me | 18:05 |
| jaypipes | dansmith: I'm more concerned actually with just being able to deal with the list of PCI devices like a normal list (or a PciDeviceList object) instead of constantly re-creating it every time save() is called. | 18:05 |
| *** rushil has quit IRC | 18:05 | |
| jaypipes | but this isn't a critical thing. | 18:05 |
| dansmith | okay | 18:06 |
| jaypipes | I have more important things (like getting rid of the PciDeviceStats class as something we use for resource tracking. | 18:06 |
| dansmith | well, let me do a thing and see if you hate it | 18:06 |
| *** rushil has joined #openstack-nova | 18:07 | |
| *** bapalm has joined #openstack-nova | 18:07 | |
| *** bapalm has quit IRC | 18:07 | |
| *** bapalm has joined #openstack-nova | 18:08 | |
| *** salv-orlando has joined #openstack-nova | 18:10 | |
| *** flwang has joined #openstack-nova | 18:11 | |
| *** VW_ has quit IRC | 18:11 | |
| *** mili has joined #openstack-nova | 18:11 | |
| *** VW_ has joined #openstack-nova | 18:12 | |
| *** ildikov has joined #openstack-nova | 18:12 | |
| *** VW__ has joined #openstack-nova | 18:13 | |
| *** VW_ has quit IRC | 18:13 | |
| jaypipes | k | 18:17 |
| *** sudipto has quit IRC | 18:17 | |
| *** yamahata has quit IRC | 18:20 | |
| *** salv-orlando has quit IRC | 18:22 | |
| openstackgerrit | Dan Smith proposed openstack/nova: pci: Use PciDeviceList for PciDevTracker.pci_devs https://review.openstack.org/210948 | 18:23 |
| openstackgerrit | Dan Smith proposed openstack/nova: pci: Move whitelist filtering inside PCI tracker https://review.openstack.org/210182 | 18:23 |
| openstackgerrit | Dan Smith proposed openstack/nova: pci: Remove get_pci_devices_filter() method https://review.openstack.org/210183 | 18:23 |
| openstackgerrit | Dan Smith proposed openstack/nova: pci: Use fields.Enum type for PCI device status https://review.openstack.org/210180 | 18:23 |
| openstackgerrit | Dan Smith proposed openstack/nova: pci: Use fields.Enum type for PCI device type https://review.openstack.org/210181 | 18:23 |
| openstackgerrit | Dan Smith proposed openstack/nova: WIP: Add PciDeviceList.save_batch() https://review.openstack.org/211288 | 18:23 |
| dansmith | jaypipes: doesn't pass tests yet, but see what you think ^ | 18:23 |
| *** josecastroleon has joined #openstack-nova | 18:24 | |
| *** baoli has quit IRC | 18:25 | |
| *** marzif_ has joined #openstack-nova | 18:25 | |
| *** baoli_ has joined #openstack-nova | 18:26 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: objects: add missing enum values to DiskBus field https://review.openstack.org/200280 | 18:26 |
| *** bapalm__ has joined #openstack-nova | 18:27 | |
| *** bapalm has quit IRC | 18:30 | |
| *** salv-orlando has joined #openstack-nova | 18:31 | |
| *** SourabhP has joined #openstack-nova | 18:32 | |
| dansmith | rlrossit: test_obj_relationships_not_past_current_parent_version just caught me | 18:35 |
| rlrossit | dansmith: good :) | 18:35 |
| rlrossit | (that is a good thing right?) | 18:36 |
| dansmith | yes | 18:36 |
| dansmith | I was about to make a mistake and not know it | 18:36 |
| rlrossit | ok I didn't know if you had a good case that was failing on you | 18:36 |
| *** Sukhdev has quit IRC | 18:37 | |
| dansmith | nope, it caught me because I added a new relation but forgot to bump the actualversion | 18:37 |
| *** dustins has quit IRC | 18:40 | |
| *** READ10 has joined #openstack-nova | 18:41 | |
| *** penick has quit IRC | 18:42 | |
| *** READ10 has quit IRC | 18:42 | |
| *** dustins has joined #openstack-nova | 18:43 | |
| *** Tedster has quit IRC | 18:44 | |
| *** claudiub has quit IRC | 18:44 | |
| *** Tedster has joined #openstack-nova | 18:44 | |
| *** yamahata has joined #openstack-nova | 18:45 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Add PciDeviceList.save_batch() https://review.openstack.org/211288 | 18:45 |
| *** Nikolay_St has joined #openstack-nova | 18:45 | |
| dansmith | jaypipes: also, you know you're failing unit tests because you're not clobbering that list anymore, right? :D | 18:45 |
| *** penick has joined #openstack-nova | 18:47 | |
| *** otter768 has joined #openstack-nova | 18:47 | |
| jaypipes | dansmith: *sigh*, I'll take a look... | 18:50 |
| dansmith | jaypipes: it's just because we don't have .append() on instancelist | 18:51 |
| jaypipes | right | 18:51 |
| dansmith | it's a quick fix, I can do it for you if you want | 18:51 |
| jaypipes | dansmith: if you have the code open, sure :) | 18:51 |
| dansmith | sure | 18:51 |
| *** otter768 has quit IRC | 18:52 | |
| dansmith | incoming | 18:53 |
| openstackgerrit | Dan Smith proposed openstack/nova: pci: Use PciDeviceList for PciDevTracker.pci_devs https://review.openstack.org/210948 | 18:53 |
| openstackgerrit | Dan Smith proposed openstack/nova: Add PciDeviceList.save_batch() https://review.openstack.org/211288 | 18:53 |
| * dansmith runs off for a bit | 18:54 | |
| *** josecastroleon has quit IRC | 18:54 | |
| *** dave-mcc_ has quit IRC | 18:55 | |
| *** rushil has quit IRC | 18:58 | |
| *** penick has quit IRC | 18:59 | |
| *** rushil has joined #openstack-nova | 19:00 | |
| *** baoli_ has quit IRC | 19:01 | |
| *** baoli has joined #openstack-nova | 19:02 | |
| *** mctaylor has joined #openstack-nova | 19:04 | |
| *** agireud_ has joined #openstack-nova | 19:05 | |
| *** agireud has quit IRC | 19:06 | |
| *** agireud_ is now known as agireud | 19:06 | |
| *** dave-mccowan has joined #openstack-nova | 19:07 | |
| *** bapalm_ has quit IRC | 19:08 | |
| *** VW__ has quit IRC | 19:10 | |
| *** exploreshaifali has joined #openstack-nova | 19:11 | |
| *** VW_ has joined #openstack-nova | 19:11 | |
| *** Sukhdev has joined #openstack-nova | 19:14 | |
| *** VW_ has quit IRC | 19:15 | |
| *** fawadkhaliq has joined #openstack-nova | 19:18 | |
| *** browne has quit IRC | 19:18 | |
| *** VW_ has joined #openstack-nova | 19:20 | |
| *** vilobhmm has joined #openstack-nova | 19:21 | |
| openstackgerrit | Dan Smith proposed openstack/nova: Add PciDeviceList.save_batch() https://review.openstack.org/211288 | 19:24 |
| *** moshele has joined #openstack-nova | 19:30 | |
| jaypipes | cfriesen_: what's a good word for "a grouping of like compute hardware that a compute provider exposes to the end user" :) | 19:34 |
| *** belmoreira has joined #openstack-nova | 19:34 | |
| *** meghal has quit IRC | 19:34 | |
| *** exploreshaifali has quit IRC | 19:40 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: convert Scality vol driver to LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202783 | 19:43 |
| openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: convert Quobyte driver to LibvirtBaseFileSystemVolumeDriver https://review.openstack.org/202782 | 19:43 |
| *** echoingumesh has joined #openstack-nova | 19:43 | |
| *** echoingu_ has joined #openstack-nova | 19:44 | |
| *** bapalm__ has quit IRC | 19:44 | |
| *** bapalm has joined #openstack-nova | 19:45 | |
| openstackgerrit | Ming Yang proposed openstack/nova: Case-insensitive filters https://review.openstack.org/201725 | 19:45 |
| openstackgerrit | Ming Yang proposed openstack/nova: Refactor get_filtered_hosts in filter host manager https://review.openstack.org/192878 | 19:45 |
| openstackgerrit | Ming Yang proposed openstack/nova: Refactor get_filtered_hosts in filter host manager https://review.openstack.org/211307 | 19:45 |
| *** bapalm has quit IRC | 19:46 | |
| *** bnemec has joined #openstack-nova | 19:46 | |
| *** bapalm has joined #openstack-nova | 19:46 | |
| *** echoingumesh has quit IRC | 19:47 | |
| *** nic has left #openstack-nova | 19:50 | |
| *** nic has joined #openstack-nova | 19:50 | |
| openstackgerrit | Belmiro Moreira proposed openstack/nova: Creates flavor* tables in API database https://review.openstack.org/201606 | 19:53 |
| *** ijw has quit IRC | 19:56 | |
| *** annegentle has quit IRC | 19:57 | |
| *** echoingu_ has quit IRC | 19:57 | |
| *** salv-orlando has quit IRC | 19:57 | |
| *** Piet has joined #openstack-nova | 19:58 | |
| *** echoingumesh has joined #openstack-nova | 19:59 | |
| *** salv-orlando has joined #openstack-nova | 20:02 | |
| *** rushil has quit IRC | 20:03 | |
| *** gabriel-bezerra has quit IRC | 20:04 | |
| *** rushil has joined #openstack-nova | 20:05 | |
| *** ijw has joined #openstack-nova | 20:06 | |
| *** meghal has joined #openstack-nova | 20:07 | |
| *** bapalm has quit IRC | 20:09 | |
| *** bapalm has joined #openstack-nova | 20:09 | |
| melwitt | alaski: this review reminded me of the update_cells=False bug with neutron you told me about awhile back https://review.openstack.org/#/c/179390/17/nova/compute/manager.py,cm | 20:10 |
| *** tojuvone has quit IRC | 20:11 | |
| *** ijw has quit IRC | 20:11 | |
| openstackgerrit | Michael Still proposed openstack/nova: libvirt: Race condition leads to instance in error https://review.openstack.org/185549 | 20:11 |
| alaski | melwitt: yeah, that should be updating cells | 20:11 |
| *** meghal has quit IRC | 20:12 | |
| *** bapalm has quit IRC | 20:12 | |
| *** bapalm has joined #openstack-nova | 20:12 | |
| melwitt | alaski: okay. let me add that to my comment then. I wasn't sure because of the existing update_cells=False | 20:12 |
| openstackgerrit | Dan Smith proposed openstack/nova: Add version counter to Service object https://review.openstack.org/201733 | 20:12 |
| alaski | melwitt: in general we should be updating cells. The only case that should be avoided was a periodic task that was getting the info_cache and causing cells updates even if the info_cache hadn't changed | 20:14 |
| *** browne has joined #openstack-nova | 20:14 | |
| alaski | I'd have to dig in more to remember all the details. but I think it came down to a method called 'get_nw_info_cache' or something setting the cache as well which was terrible | 20:15 |
| alaski | s/was/is/ | 20:16 |
| melwitt | alaski: yeah, it's get_instance_nw_info in the base_api.py that sets update_cells=False. I wasn't clear that's called by a periodic task | 20:16 |
| mriedem | gd car salespeople | 20:17 |
| mriedem | always hooking me and then shifting the terms | 20:17 |
| mriedem | gdi | 20:17 |
| rlrossit | you buying a corvette mriedem? | 20:19 |
| mriedem | i would never buy a corvette | 20:20 |
| mriedem | no, i decided last week that the maintenance costs on the wife's audi are driving me crazy and it's time to get her a new car | 20:20 |
| mriedem | so now i'm crunching numbers | 20:20 |
| rlrossit | accords are nice. In my experience of owning one for a year at least | 20:21 |
| mriedem | nice and boring | 20:21 |
| mriedem | :) | 20:21 |
| mriedem | reliable as a mfer though | 20:21 |
| ctrath | come on, it's you wife.. She deserves at least a Mercedes | 20:21 |
| *** dane-fichter has quit IRC | 20:23 | |
| rlrossit | tesla mriedem | 20:23 |
| rlrossit | do it | 20:23 |
| rlrossit | only about 100k if you get a good one | 20:23 |
| *** VW__ has joined #openstack-nova | 20:24 | |
| *** vilobhmm has quit IRC | 20:24 | |
| *** moshele has quit IRC | 20:24 | |
| clarkb | seats 7 too | 20:25 |
| rlrossit | isn't that only if you have the goofy backwards seats? | 20:26 |
| clarkb | yes | 20:26 |
| *** alex_klimov has joined #openstack-nova | 20:26 | |
| mriedem | no, you'll be hacking the tesla to pipe rap music while i'm driving and cause me to crash | 20:26 |
| clarkb | mriedem: no thats a jeep | 20:27 |
| *** ijw has joined #openstack-nova | 20:27 | |
| mriedem | those were also recently hacked? | 20:27 |
| *** VW_ has quit IRC | 20:27 | |
| ctrath | Chrysler | 20:27 |
| anish | mriedem: model s was definitely hacked at defcon | 20:28 |
| clarkb | mriedem: they did a massive "recall" | 20:28 |
| *** VW__ has quit IRC | 20:28 | |
| clarkb | was pretty bad aiui remote engine takeover | 20:28 |
| *** meghal has joined #openstack-nova | 20:28 | |
| *** fawadkhaliq has quit IRC | 20:29 | |
| mriedem | that tears it, | 20:29 |
| mriedem | time to get a 1982 Pontiac Trans Am with KITT installed | 20:29 |
| mriedem | KITT is unhackable | 20:29 |
| rlrossit | http://www.wired.com/2015/08/researchers-hacked-model-s-teslas-already/ | 20:29 |
| rlrossit | huh there it is | 20:29 |
| mriedem | throw in the members only jacket, chest hair and gold chains and i'm all set | 20:29 |
| mriedem | https://cdn-360-content.s3.amazonaws.com/uploads/2014/06/Knight-Rider.jpg | 20:30 |
| mriedem | notice there is no ring on that finger | 20:30 |
| *** ijw_ has joined #openstack-nova | 20:30 | |
| mriedem | he can't be tied down | 20:30 |
| mriedem | except through liquor and hamburgers | 20:30 |
| rlrossit | stop it with the 80's mriedem | 20:30 |
| *** VW_ has joined #openstack-nova | 20:31 | |
| *** gabriel-bezerra has joined #openstack-nova | 20:31 | |
| *** ijw__ has joined #openstack-nova | 20:31 | |
| *** skylerberg has joined #openstack-nova | 20:32 | |
| *** ijw has quit IRC | 20:32 | |
| *** meghal has quit IRC | 20:33 | |
| *** rushil has quit IRC | 20:34 | |
| *** ijw_ has quit IRC | 20:34 | |
| skylerberg | I am trying to debug a failing tempest test for my Cinder CI. It looks like it has something to do with nova-cert. Here are the logs from a recent run: http://openstack-ci.tintri.com/tintri/refs-changes-78-209578-8/ | 20:35 |
| skylerberg | testr: http://openstack-ci.tintri.com/tintri/refs-changes-78-209578-8/testr_results.html | 20:35 |
| skylerberg | nova cert log: http://openstack-ci.tintri.com/tintri/refs-changes-78-209578-8/logs/screen-n-crt.log.txt | 20:36 |
| skylerberg | Does anyone know why this might be? I am having trouble figuring this one out. | 20:37 |
| mriedem | skylerberg: there are a couple of different failures in there | 20:37 |
| mriedem | assert errors[0].reason in decoding_errors | 20:37 |
| mriedem | skylerberg: which openssl is this testing again? | 20:38 |
| mriedem | *against | 20:38 |
| mriedem | Package 1:openssl-1.0.1e-42.el7_1.9.x86_64 already installed and latest version | 20:38 |
| mriedem | is this centos 7? | 20:38 |
| skylerberg | RHEL 7.1 | 20:39 |
| mriedem | yup | 20:39 |
| mriedem | + [[ -n Red Hat Enterprise Linux Server release 7.1 (Maipo) ]] | 20:39 |
| skylerberg | I am not sure why any of this would have changed recently. After the global-requirements incident you helped me with last week, I have uninstalled all the python packages on the system, then let devstack pull them all again. | 20:41 |
| *** mctaylor has quit IRC | 20:41 | |
| *** annegentle has joined #openstack-nova | 20:41 | |
| skylerberg | That has given me up to date packages and fixed the other issues. | 20:41 |
| *** claudiub has joined #openstack-nova | 20:41 | |
| skylerberg | But after that, this test has been failing consistently. | 20:41 |
| mriedem | skylerberg: could have been an update to some other package that you didn't have before | 20:41 |
| mriedem | like cryptography | 20:42 |
| skylerberg | mriedem: Good thinking. That could very well have caused a change. | 20:42 |
| rlrossit | dansmith: can I ask you a couple questions on https://review.openstack.org/#/c/211288? | 20:43 |
| dansmith | I still have your thing open to look at, by the way | 20:44 |
| dansmith | rlrossit: but sure, shoot | 20:44 |
| *** bapalm has quit IRC | 20:44 | |
| rlrossit | dansmith: are any object lists reflected in the DB in any way? or are they just RPC helpers? | 20:44 |
| mriedem | skylerberg: if you have a run from before that was passing, i'd compare the versions of openssl, pyopenssl, pycrypto and cryptography that were being used | 20:44 |
| *** bapalm has joined #openstack-nova | 20:45 | |
| skylerberg | Yeah, I am looking at that right now. | 20:45 |
| *** bapalm_ has joined #openstack-nova | 20:46 | |
| dansmith | rlrossit: well, it depends on how you look at it | 20:46 |
| *** echoingumesh has quit IRC | 20:46 | |
| dansmith | rlrossit: to some degree, InstanceList.get_all() is reflected in the db | 20:46 |
| *** IanGovett has quit IRC | 20:46 | |
| dansmith | rlrossit: and PciDeviceList.get_by_compute_node() is the subset of the list in the db | 20:46 |
| rlrossit | dansmith: so from a read standpoint they are somewhat DB helpers? | 20:47 |
| *** moshele has joined #openstack-nova | 20:47 | |
| rlrossit | dansmith: because in the end those are just making a specific DB query right? | 20:47 |
| *** mwagner_lap has quit IRC | 20:47 | |
| dansmith | yeah | 20:48 |
| mriedem | skylerberg: https://github.com/openstack/nova/commit/452fe92787ff871417846748fc13e2a6a2899325 | 20:49 |
| mriedem | bingo | 20:49 |
| *** bapalm has quit IRC | 20:49 | |
| mriedem | that merged on 7/28 | 20:49 |
| mriedem | browne: ^ | 20:49 |
| rlrossit | dansmith: So I'm wondering if save_batch() that you added in https://review.openstack.org/#/c/211288/4/nova/objects/pci_device.py,cm could just be brought out into ObjectListBase because that function looked not at all specific to PCI devices, you could do that on any list and reduce N RPC calls to just 1. At that point whether you call it save() or batch_save() is just semantics, but if it's understood that Lists aren't represented in | 20:49 |
| *** bapalm_ has quit IRC | 20:50 | |
| dansmith | well, | 20:50 |
| dansmith | what I was getting at before is that I don't really ever want a list object to have a generic .save() | 20:50 |
| skylerberg | mriedem: That looks very promising. | 20:50 |
| dansmith | because it gives the wrong impression of what we're doing (IMHO) and is very hard or impossible to do right (IMHO) | 20:50 |
| mriedem | skylerberg: i don't know how to fix it, | 20:51 |
| mriedem | skylerberg: but that's why introduced it | 20:51 |
| mriedem | skylerberg: please get a nova bug reported though | 20:51 |
| *** vilobhmm has joined #openstack-nova | 20:51 | |
| dansmith | rlrossit: we *could* add a batch save to the base class, but I'd want to see some other examples of where this is useful | 20:51 |
| rlrossit | dansmith: so, semantics aside, call it batch_save(), but we could still add that to ObjectListBase (and in o.vo also) right? | 20:51 |
| skylerberg | Yeah, will do | 20:51 |
| *** changbl has quit IRC | 20:51 | |
| rlrossit | dansmith: examples is something I'm definitely not the expert on ;) | 20:51 |
| dansmith | rlrossit: we certainly could, but foisting a remotable on all objects is kindof a sucky thing to do I think | 20:51 |
| dansmith | think of a list object that doesn't back the DB.. what does a remotable batch_save() mean for that? | 20:52 |
| * rlrossit looks up foisting | 20:52 | |
| dansmith | and not all objects have save() even | 20:52 |
| dansmith | if we have more than one place where we really want to do this, | 20:52 |
| dansmith | I'd rather have a BatchThingy mixin that brings those in | 20:53 |
| dansmith | the other thing about this is that it doesn't sync the objects back up like a save() normally would | 20:53 |
| dansmith | it seems to be okay in this case because compute is singly authoritative for the pci devices in the list | 20:53 |
| *** IanGovett has joined #openstack-nova | 20:53 | |
| dansmith | but normally a save() operation refreshes the local object with the data from the database | 20:53 |
| rlrossit | dansmith: oh so it's not a write->read thing it's just a one way | 20:53 |
| dansmith | that's how this one works, yeah | 20:54 |
| browne | mriedem: what's the issue with that patch? sorry late to the table | 20:54 |
| dansmith | we could go to the trouble of merging back the results, but then we have to return them, which is still better than multiple rpc calls, but in this case, we don't need it for pci, so it's wasted | 20:54 |
| mriedem | browne: see the stacktraces in here http://openstack-ci.tintri.com/tintri/refs-changes-78-209578-8/logs/screen-n-crt.log.txt | 20:54 |
| rlrossit | dansmith: you got me thinking much more about this... but you at least answered my initial concern of "this looks grossly generic" | 20:55 |
| mriedem | browne: it could be an upstream issue with the cryptography library too if it doesn't handle the version of openssl on centos 7.1 | 20:55 |
| dansmith | rlrossit: anyway, it's not a bad idea, but I'd want to see like two other examples of where we'd want to do it and make sure we were being sufficiently generic and explicit | 20:55 |
| *** raildo has quit IRC | 20:55 | |
| dansmith | rlrossit: yeah, some obscure details I think :D | 20:55 |
| mriedem | browne: which is openssl-1.0.1e-42.el7_1.9.x86_64 | 20:55 |
| dansmith | rlrossit: and you learned "foist" in the process :D | 20:55 |
| browne | mriedem: ok, i can look into it. | 20:56 |
| rlrossit | dansmith: it's the way bugs bunny says "first" | 20:56 |
| dansmith | lol haha | 20:56 |
| dansmith | yeah, also true | 20:56 |
| mriedem | or the 3 stooges | 20:57 |
| rlrossit | mriedem: too old for me | 20:57 |
| mriedem | too old for anyone | 20:57 |
| *** arjan_work has quit IRC | 20:57 | |
| rlrossit | mriedem: you would enjoy this: https://www.youtube.com/watch?v=het1kl-A8qw | 20:58 |
| rlrossit | FYI all episodes of Police Squad! are on youtube | 20:58 |
| *** VW_ has quit IRC | 20:58 | |
| *** VW_ has joined #openstack-nova | 20:59 | |
| * mriedem watched airplane! again this weekend | 20:59 | |
| *** dustins has quit IRC | 21:00 | |
| mriedem | https://youtu.be/FNkpIDBtC2c?t=20 | 21:01 |
| *** vilobhmm has quit IRC | 21:02 | |
| *** thorst has quit IRC | 21:02 | |
| rlrossit | I love the slap | 21:02 |
| *** tongli has quit IRC | 21:03 | |
| rlrossit | I'm disappointed they took airplane off of netflix | 21:03 |
| *** vilobhmm has joined #openstack-nova | 21:03 | |
| *** VW_ has quit IRC | 21:03 | |
| *** belmoreira has quit IRC | 21:03 | |
| *** dustins has joined #openstack-nova | 21:03 | |
| skylerberg | browne, mriedem: Here is the bug for the issue: https://bugs.launchpad.net/nova/+bug/1483408 | 21:04 |
| openstack | Launchpad bug 1483408 in OpenStack Compute (nova) "Decryption failure after replacing openssl with cryptography lib" [Undecided,New] | 21:04 |
| *** ivasev has quit IRC | 21:05 | |
| *** vilobhmm1 has joined #openstack-nova | 21:05 | |
| browne | skylerberg: thanks. i'm work on this now. | 21:05 |
| browne | s/i'm/i'll | 21:06 |
| rlrossit | dansmith: also about that o.vo change, don't really care when you get it done as long as it's on your list. It will probably need much changing anyways | 21:06 |
| dansmith | rlrossit: heh, okay, I'll try to get to it later today | 21:06 |
| rlrossit | good enough for me, becuase my day is almost done anyways. Gives me something to do when I come in tomorrow | 21:07 |
| *** achanda has quit IRC | 21:07 | |
| openstackgerrit | Ming Yang proposed openstack/nova: Refactor get_filtered_hosts in filter host manager https://review.openstack.org/211307 | 21:07 |
| *** vilobhmm has quit IRC | 21:07 | |
| skylerberg | browne: ty | 21:09 |
| *** aysyd has quit IRC | 21:10 | |
| *** ijw has joined #openstack-nova | 21:11 | |
| openstackgerrit | Baodong (Robert) Li proposed openstack/nova: Handle port delete initiated by neutron https://review.openstack.org/179390 | 21:12 |
| *** thumpba has quit IRC | 21:12 | |
| *** thangp has quit IRC | 21:12 | |
| *** baoli has quit IRC | 21:13 | |
| *** ijw__ has quit IRC | 21:13 | |
| *** meghal has joined #openstack-nova | 21:13 | |
| *** Sukhdev has quit IRC | 21:13 | |
| *** ctrath has quit IRC | 21:15 | |
| *** rlrossit has left #openstack-nova | 21:16 | |
| *** kmARC_ has joined #openstack-nova | 21:21 | |
| *** rushil has joined #openstack-nova | 21:23 | |
| *** kmARC has joined #openstack-nova | 21:26 | |
| *** dustins has quit IRC | 21:28 | |
| *** rushil_ has joined #openstack-nova | 21:28 | |
| openstackgerrit | xing-yang proposed openstack/nova: Add os-brick based LibvirtVolumeDriver for ScaleIO https://review.openstack.org/194454 | 21:30 |
| *** rushil has quit IRC | 21:31 | |
| *** mriedem has quit IRC | 21:34 | |
| *** thorst has joined #openstack-nova | 21:34 | |
| xyang1 | mriedem: johnthetubaguy , rebased my patch, can you help approve it again? https://review.openstack.org/#/c/194454/ . Thanks! | 21:34 |
| *** samueldmq has quit IRC | 21:38 | |
| *** achanda has joined #openstack-nova | 21:40 | |
| *** VW_ has joined #openstack-nova | 21:40 | |
| *** samueldmq has joined #openstack-nova | 21:47 | |
| *** VW_ has quit IRC | 21:47 | |
| *** VW_ has joined #openstack-nova | 21:47 | |
| openstackgerrit | Peter Penchev proposed openstack/nova: Add the Nova libvirt StorPool attachment driver. https://review.openstack.org/140733 | 21:49 |
| *** VW_ has quit IRC | 21:52 | |
| *** busterswt has quit IRC | 21:54 | |
| *** echoingumesh has joined #openstack-nova | 21:54 | |
| *** rushil_ has quit IRC | 21:55 | |
| *** chuckcarmack has left #openstack-nova | 21:56 | |
| *** bapalm has joined #openstack-nova | 21:56 | |
| *** annegentle has quit IRC | 21:56 | |
| *** mwagner_lap has joined #openstack-nova | 21:57 | |
| *** echoingumesh has quit IRC | 21:59 | |
| *** meghal has quit IRC | 22:00 | |
| *** meghal has joined #openstack-nova | 22:00 | |
| *** echoingumesh has joined #openstack-nova | 22:02 | |
| *** bapalm has quit IRC | 22:02 | |
| *** bapalm has joined #openstack-nova | 22:03 | |
| *** burgerk has quit IRC | 22:04 | |
| melwitt | dansmith: curious why we don't have "append" and "remove" in ObjectListBase for things like this? https://review.openstack.org/#/c/210948/5/nova/pci/manager.py,cm | 22:04 |
| openstackgerrit | Eric Brown proposed openstack/nova: VMware: update supported vsphere 6.0 os types https://review.openstack.org/181020 | 22:06 |
| *** marzif_ has quit IRC | 22:06 | |
| *** bapalm has quit IRC | 22:07 | |
| dansmith | lol | 22:11 |
| dansmith | I guess I need to write a paper | 22:11 |
| dansmith | this'll be the third time today :) | 22:11 |
| *** mvensky has joined #openstack-nova | 22:11 | |
| dansmith | melwitt: we made a decision/goal in the beginning to not add things to the list objects that make it look like you can manipulate the state of the database in list-form | 22:12 |
| dansmith | meaning, | 22:12 |
| dansmith | you can't take a list of instances, add a new instance object to it, and call .save() on the list itself | 22:12 |
| dansmith | i.e. an instance list is mostly an immutable thing | 22:12 |
| dansmith | I guess since it confuses so many people we should either give up that goal, or stop using it like that patch wants to do | 22:13 |
| *** burt has quit IRC | 22:15 | |
| *** bnemec has quit IRC | 22:16 | |
| *** bapalm has joined #openstack-nova | 22:18 | |
| *** kylek3h has quit IRC | 22:18 | |
| *** mdrabe has quit IRC | 22:18 | |
| *** IanGovett1 has joined #openstack-nova | 22:23 | |
| *** agireud has quit IRC | 22:24 | |
| *** IanGovett has quit IRC | 22:24 | |
| *** edmondsw has quit IRC | 22:25 | |
| *** moshele has quit IRC | 22:26 | |
| *** echoingumesh has quit IRC | 22:28 | |
| *** bapalm has quit IRC | 22:29 | |
| *** meghal has quit IRC | 22:29 | |
| *** meghal has joined #openstack-nova | 22:30 | |
| melwitt | dansmith: oops, sorry! | 22:30 |
| lifeless | dansmith: I think that goal is pretty sane | 22:30 |
| *** salv-orl_ has joined #openstack-nova | 22:31 | |
| *** salv-orlando has quit IRC | 22:33 | |
| *** meghal has quit IRC | 22:33 | |
| *** meghal has joined #openstack-nova | 22:33 | |
| *** jecarey has quit IRC | 22:33 | |
| *** annegentle has joined #openstack-nova | 22:36 | |
| *** Sukhdev has joined #openstack-nova | 22:37 | |
| dansmith | melwitt: heh, it's cool :) | 22:37 |
| dansmith | lifeless: me too :) | 22:37 |
| *** jamielennox|away is now known as jamielennox | 22:38 | |
| *** rfolco has quit IRC | 22:38 | |
| *** r-daneel has quit IRC | 22:39 | |
| melwitt | dansmith: yeah, the mostly immutable aspect of it caught me. I haven't seen code modifying an ObjectList before and wondered. everything's dandy if you just make lists and look at them | 22:39 |
| *** VW_ has joined #openstack-nova | 22:40 | |
| *** samueldmq has quit IRC | 22:42 | |
| *** zzzeek has quit IRC | 22:42 | |
| edleafe | dansmith: they should have been ObjectTuple instead of ObjectList then :) | 22:43 |
| *** marcusvrn has quit IRC | 22:43 | |
| dansmith | you can have an immutable list :) | 22:43 |
| dansmith | I mean, maybe not in python, but in real life | 22:43 |
| *** VW_ has quit IRC | 22:43 | |
| *** VW_ has joined #openstack-nova | 22:44 | |
| *** tonytan4ever has quit IRC | 22:45 | |
| *** claudiub has quit IRC | 22:47 | |
| *** VW_ has quit IRC | 22:49 | |
| *** otter768 has joined #openstack-nova | 22:49 | |
| *** hemna_ is now known as hemnafk | 22:52 | |
| *** otter768 has quit IRC | 22:54 | |
| *** alex_klimov has quit IRC | 22:54 | |
| *** mjturek1 has quit IRC | 22:55 | |
| *** diogogmt has quit IRC | 22:56 | |
| *** krtaylor has quit IRC | 22:59 | |
| melwitt | seems like all the third party CI are going haywire today | 23:00 |
| *** meghal has quit IRC | 23:01 | |
| *** meghal has joined #openstack-nova | 23:02 | |
| *** thedodd has quit IRC | 23:10 | |
| *** kmARC has quit IRC | 23:10 | |
| *** mriedem has joined #openstack-nova | 23:11 | |
| *** kmARC_ has quit IRC | 23:12 | |
| *** ijw_ has joined #openstack-nova | 23:13 | |
| *** mriedem has quit IRC | 23:13 | |
| *** mriedem has joined #openstack-nova | 23:14 | |
| *** ijw has quit IRC | 23:16 | |
| *** IanGovett1 has quit IRC | 23:19 | |
| *** echoingumesh has joined #openstack-nova | 23:19 | |
| *** tpeoples has quit IRC | 23:20 | |
| *** meghal has quit IRC | 23:22 | |
| *** annegentle has quit IRC | 23:26 | |
| *** ijw_ has quit IRC | 23:31 | |
| openstackgerrit | Ed Leafe proposed openstack/nova: Move existing V2 to legacy_v2 https://review.openstack.org/211356 | 23:31 |
| *** ijw has joined #openstack-nova | 23:31 | |
| edleafe | alex_xu: johnthetubaguy: ^ Here is another attempt. This makes the steps smaller by not also moving 'contrib' at the same time. | 23:32 |
| *** ijw has quit IRC | 23:33 | |
| *** ijw has joined #openstack-nova | 23:33 | |
| *** otter768 has joined #openstack-nova | 23:34 | |
| *** slong has joined #openstack-nova | 23:35 | |
| *** changbl has joined #openstack-nova | 23:38 | |
| *** meghal has joined #openstack-nova | 23:38 | |
| *** ijw has quit IRC | 23:39 | |
| *** ijw has joined #openstack-nova | 23:40 | |
| edleafe | alex_xu: johnthetubaguy: the docs are still failing. I have no idea how it's getting the information for the auto build | 23:41 |
| *** jaypipes has quit IRC | 23:42 | |
| *** ijw_ has joined #openstack-nova | 23:44 | |
| *** ijw has quit IRC | 23:46 | |
| *** otter768 has quit IRC | 23:49 | |
| *** dannywilson has quit IRC | 23:51 | |
| *** zzzeek has joined #openstack-nova | 23:52 | |
| *** erlon has quit IRC | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!
