*** takedakn has joined #openstack-nova | 00:00 | |
*** haomaiwang has quit IRC | 00:01 | |
*** haomaiwang has joined #openstack-nova | 00:01 | |
*** dimsum__ has quit IRC | 00:03 | |
*** ZZelle_ has quit IRC | 00:09 | |
*** davideagnello has quit IRC | 00:15 | |
*** shoutm has quit IRC | 00:18 | |
*** shoutm has joined #openstack-nova | 00:21 | |
*** otter768 has joined #openstack-nova | 00:22 | |
*** oomichi has joined #openstack-nova | 00:22 | |
*** nd has joined #openstack-nova | 00:23 | |
*** otter768 has quit IRC | 00:27 | |
*** otter768_ has joined #openstack-nova | 00:27 | |
*** otter768_ has quit IRC | 00:27 | |
*** otter768 has joined #openstack-nova | 00:27 | |
*** asettle is now known as asettle-afk | 00:29 | |
*** eliqiao has joined #openstack-nova | 00:29 | |
*** haomaiwang has quit IRC | 00:36 | |
*** otter768 has quit IRC | 00:41 | |
*** takedakn has quit IRC | 00:46 | |
*** takedakn has joined #openstack-nova | 00:46 | |
*** takedakn has quit IRC | 00:47 | |
*** dimsum__ has joined #openstack-nova | 00:48 | |
*** armax has joined #openstack-nova | 01:00 | |
*** electrocucaracha has quit IRC | 01:02 | |
*** aloga has quit IRC | 01:04 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Separate API schemas for v2.0 compatible API https://review.openstack.org/221129 | 01:05 |
---|---|---|
*** aloga has joined #openstack-nova | 01:06 | |
oomichi | alex_xu: hi, morning | 01:06 |
*** ujjain has quit IRC | 01:12 | |
*** erhudy1 has quit IRC | 01:12 | |
*** ujjain- has joined #openstack-nova | 01:12 | |
*** apuimedo_ has quit IRC | 01:15 | |
*** apuimedo has quit IRC | 01:15 | |
*** apuimedo_ has joined #openstack-nova | 01:16 | |
*** apuimedo has joined #openstack-nova | 01:16 | |
*** claudiub|2 has quit IRC | 01:17 | |
*** Marga_ has joined #openstack-nova | 01:19 | |
*** zhangjn has joined #openstack-nova | 01:19 | |
*** Marga_ has quit IRC | 01:20 | |
*** Marga_ has joined #openstack-nova | 01:21 | |
*** asettle-afk is now known as asettle | 01:22 | |
*** shoutm has quit IRC | 01:23 | |
*** armax has quit IRC | 01:28 | |
*** shoutm has joined #openstack-nova | 01:28 | |
alex_xu | oomichi: hi, morning | 01:31 |
oomichi | alex_xu: :) | 01:31 |
oomichi | alex_xu: I am trying to separate v2.0 comp schema from v2.1 ones. | 01:32 |
oomichi | alex_xu: and that is almost done | 01:32 |
*** otter768 has joined #openstack-nova | 01:32 | |
oomichi | alex_xu: can I update your patch based on that? | 01:32 |
alex_xu | oomichi: cool, actually I take look at a little also | 01:32 |
alex_xu | oomichi: sure | 01:32 |
oomichi | alex_xu: thanks:) | 01:32 |
alex_xu | oomichi: np, thanks for the patch | 01:32 |
alex_xu | oomichi: the scheduler-hints one? | 01:33 |
oomichi | alex_xu: yeah | 01:33 |
alex_xu | oomichi: cool, that is hard one, hard than relax validation of server name | 01:33 |
alex_xu | oomichi: will help on review after you update | 01:33 |
*** haomaiwang has joined #openstack-nova | 01:35 | |
*** zhenguo has joined #openstack-nova | 01:35 | |
*** Marga_ has quit IRC | 01:35 | |
oomichi | alex_xu: thanks again :) | 01:36 |
alex_xu | oomichi: np, thanks for update | 01:36 |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Fix a few typos https://review.openstack.org/208749 | 01:37 |
*** eliqiao has quit IRC | 01:38 | |
*** dimsum__ has quit IRC | 01:40 | |
openstackgerrit | Jeffrey Zhang proposed openstack/nova: use graduated oslo.policy https://review.openstack.org/198065 | 01:42 |
*** eliqiao has joined #openstack-nova | 01:43 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Separate API schemas for v2.0 compatible API https://review.openstack.org/221129 | 01:45 |
*** lyanchih has joined #openstack-nova | 01:46 | |
*** shoutm has quit IRC | 01:48 | |
*** chenzeng has joined #openstack-nova | 01:48 | |
*** shoutm has joined #openstack-nova | 01:50 | |
*** armax has joined #openstack-nova | 01:51 | |
*** david-ly_ has joined #openstack-nova | 01:51 | |
*** krtaylor has quit IRC | 01:52 | |
*** baoli has joined #openstack-nova | 01:54 | |
*** david-lyle has quit IRC | 01:54 | |
*** haomaiwang has quit IRC | 02:01 | |
*** haomaiwang has joined #openstack-nova | 02:01 | |
*** otter768 has quit IRC | 02:04 | |
*** krtaylor has joined #openstack-nova | 02:05 | |
*** otter768 has joined #openstack-nova | 02:06 | |
*** pixelbeat has joined #openstack-nova | 02:08 | |
*** tojuvone has joined #openstack-nova | 02:11 | |
*** zxyf has joined #openstack-nova | 02:15 | |
*** davideagnello has joined #openstack-nova | 02:15 | |
*** baoli has quit IRC | 02:16 | |
*** davideagnello has quit IRC | 02:21 | |
*** apuimedo_ has quit IRC | 02:23 | |
*** tjones has joined #openstack-nova | 02:25 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 02:30 |
*** longsube has joined #openstack-nova | 02:30 | |
*** zxyf has quit IRC | 02:33 | |
*** zxyf has joined #openstack-nova | 02:33 | |
*** armax has quit IRC | 02:40 | |
*** dimsum__ has joined #openstack-nova | 02:40 | |
oomichi | alex_xu: are you still there? | 02:42 |
alex_xu | oomichi: yea, but I'm in meeting | 02:42 |
oomichi | alex_xu: ok, please ping me after that | 02:43 |
alex_xu | oomichi: ok | 02:43 |
*** dimsum__ has quit IRC | 02:46 | |
*** tjones has quit IRC | 02:47 | |
openstackgerrit | Takashi NATSUME proposed openstack/nova: Fix cinder volume stuck in swap_volume https://review.openstack.org/207385 | 02:49 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add API schema for different_cell filter https://review.openstack.org/220893 | 02:49 |
*** shoutm_ has joined #openstack-nova | 02:53 | |
*** shoutm has quit IRC | 02:54 | |
*** baoli has joined #openstack-nova | 02:55 | |
*** longsube has quit IRC | 02:58 | |
*** dave-mcc_ has quit IRC | 02:58 | |
*** tbh has joined #openstack-nova | 02:59 | |
*** tri2sing has quit IRC | 03:01 | |
*** haomaiwang has quit IRC | 03:01 | |
*** haomaiwang has joined #openstack-nova | 03:01 | |
*** tri2sing has joined #openstack-nova | 03:01 | |
tbh | Hi, may I know why we need to set the management url for novaclient like this https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/nova.py#L456 | 03:02 |
*** shoutm_ has quit IRC | 03:03 | |
*** tri2sing has quit IRC | 03:03 | |
*** armax has joined #openstack-nova | 03:03 | |
*** shoutm has joined #openstack-nova | 03:03 | |
*** nd has quit IRC | 03:04 | |
*** armax has quit IRC | 03:04 | |
*** nd has joined #openstack-nova | 03:11 | |
nd | Hello !!! Could anyone help me please to understand how I can configure separate nova-api for metadata and separate for tenants? | 03:11 |
*** nd has left #openstack-nova | 03:12 | |
alex_xu | oomichi: hi, I'm back | 03:13 |
oomichi | alex_xu: cool, I guess I cannot make it today irc meeting | 03:14 |
alex_xu | oomichi: ok, but I think I know you point | 03:14 |
oomichi | alex_xu: sorry about that, but I'd like to talk about it with you before | 03:14 |
oomichi | alex_xu: yeah, and I found another point now | 03:15 |
alex_xu | oomichi: ok, no problem | 03:15 |
alex_xu | oomichi: cool | 03:15 |
oomichi | alex_xu: did you see my latest comment on https://review.openstack.org/#/c/217727/ ? | 03:15 |
alex_xu | oomichi: yea, I saw that | 03:16 |
oomichi | alex_xu: relax of validation seems acceptable on v2.1 also without microversion, if we get a consensus about that | 03:16 |
alex_xu | oomichi: waiting, I saw a wrong comment | 03:17 |
oomichi | alex_xu: I dropped my -1 on that | 03:17 |
oomichi | alex_xu: I'm fine current patch if we build a consensus on today irc meeting | 03:18 |
alex_xu | oomichi: -1 on what? | 03:18 |
oomichi | alex_xu: I removed my -1 | 03:18 |
oomichi | alex_xu: now | 03:18 |
alex_xu | oomichi: heh, cool :) | 03:19 |
alex_xu | oomichi: we have good discussion around this, hope we can get consensus on this | 03:19 |
oomichi | alex_xu: my previous -1 is because the patch doesn't contain microversion bump | 03:19 |
oomichi | alex_xu: but it seems unnecessary on current doc | 03:19 |
oomichi | alex_xu: yeah, I hope so | 03:19 |
alex_xu | oomichi: the doc is live doc I think | 03:19 |
oomichi | alex_xu: : ) | 03:19 |
alex_xu | oomichi: if we think the doc missing something, we can fix the doc | 03:20 |
alex_xu | oomichi: anyway our goal is do the right thing. | 03:20 |
oomichi | alex_xu: yeah, but validation change seems still a little gray for necesasry/unnecessary microversion bump | 03:20 |
oomichi | alex_xu: concensus is necessary around this | 03:20 |
*** VW_ has joined #openstack-nova | 03:20 | |
alex_xu | oomichi: yea, we need think about those be careful | 03:20 |
alex_xu | oomichi: this one https://review.openstack.org/#/c/220386/ I think it needn't microversion | 03:21 |
alex_xu | oomichi: because it is bug | 03:21 |
oomichi | alex_xu: ok, I can be out of today irc meeting because you already know my idea and I think that is the same as you | 03:21 |
alex_xu | oomichi: but this one https://review.openstack.org/#/c/219696 we need think about more | 03:21 |
alex_xu | oomichi: no problem, I bring your opinion to the meeting | 03:22 |
oomichi | alex_xu: yeah, thanks | 03:22 |
alex_xu | oomichi: np | 03:22 |
*** shoutm_ has joined #openstack-nova | 03:22 | |
*** VW_ has quit IRC | 03:22 | |
oomichi | alex_xu: sorry, I need to go lunch, see you :) | 03:23 |
*** VW_ has joined #openstack-nova | 03:23 | |
*** humble_ has joined #openstack-nova | 03:23 | |
alex_xu | oomichi: yea, me too, see you | 03:23 |
*** shoutm has quit IRC | 03:24 | |
*** humble__ has joined #openstack-nova | 03:24 | |
*** vilobhmm_11 has joined #openstack-nova | 03:25 | |
*** wanghua has quit IRC | 03:25 | |
*** humble_ has quit IRC | 03:27 | |
*** VW_ has quit IRC | 03:28 | |
*** pixelbeat has quit IRC | 03:29 | |
*** liusheng has joined #openstack-nova | 03:32 | |
*** otter768 has quit IRC | 03:35 | |
*** otter768 has joined #openstack-nova | 03:37 | |
*** zxyf has quit IRC | 03:42 | |
*** zxyf has joined #openstack-nova | 03:43 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 03:45 |
*** shoutm_ has quit IRC | 03:46 | |
*** otter768 has quit IRC | 03:46 | |
*** zxyf has quit IRC | 03:50 | |
*** zxyf has joined #openstack-nova | 03:50 | |
*** zhangjn_ has joined #openstack-nova | 03:52 | |
*** vivekd has joined #openstack-nova | 03:54 | |
*** rajesht has joined #openstack-nova | 03:54 | |
*** baoli has quit IRC | 03:55 | |
*** zhangjn has quit IRC | 03:56 | |
*** jamielennox is now known as jamielennox|away | 03:56 | |
*** armax has joined #openstack-nova | 03:57 | |
openstackgerrit | Li Yingjun proposed openstack/nova: Add missing delete policies in the sample file https://review.openstack.org/175251 | 03:59 |
*** haomaiwang has quit IRC | 04:01 | |
*** haomaiwang has joined #openstack-nova | 04:01 | |
*** shoutm has joined #openstack-nova | 04:03 | |
*** deepthi has joined #openstack-nova | 04:03 | |
*** tri2sing has joined #openstack-nova | 04:03 | |
*** lyanchih has quit IRC | 04:04 | |
*** tbh has quit IRC | 04:05 | |
*** oomichi has quit IRC | 04:05 | |
*** tri2sing has quit IRC | 04:08 | |
*** tbh has joined #openstack-nova | 04:13 | |
*** vivekd has quit IRC | 04:17 | |
*** vilobhmm_11 has quit IRC | 04:20 | |
*** Sree has joined #openstack-nova | 04:22 | |
*** Sree has quit IRC | 04:23 | |
*** vilobhmm_11 has joined #openstack-nova | 04:23 | |
*** chenzeng has quit IRC | 04:23 | |
*** Sree has joined #openstack-nova | 04:24 | |
*** ijw has quit IRC | 04:24 | |
*** ijw has joined #openstack-nova | 04:24 | |
*** zhangjn_ has quit IRC | 04:27 | |
*** unicell1 has joined #openstack-nova | 04:33 | |
*** unicell has quit IRC | 04:34 | |
*** ijw has quit IRC | 04:34 | |
*** ijw has joined #openstack-nova | 04:35 | |
*** yamahata has joined #openstack-nova | 04:37 | |
*** zxyf has quit IRC | 04:37 | |
*** zxyf has joined #openstack-nova | 04:38 | |
*** vivekd has joined #openstack-nova | 04:39 | |
*** zxyf has quit IRC | 04:42 | |
*** zxyf has joined #openstack-nova | 04:43 | |
*** chhavi has joined #openstack-nova | 04:51 | |
*** ildikov has quit IRC | 04:53 | |
*** hparekh has joined #openstack-nova | 04:54 | |
*** tri2sing has joined #openstack-nova | 04:54 | |
*** lyanchih has joined #openstack-nova | 04:58 | |
*** zxyf has quit IRC | 04:59 | |
*** haomaiwang has quit IRC | 05:01 | |
*** haomaiwang has joined #openstack-nova | 05:01 | |
*** tbh has quit IRC | 05:01 | |
*** davideagnello has joined #openstack-nova | 05:16 | |
*** josecastroleon1 has joined #openstack-nova | 05:22 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Remove unused parameter overwrite in elevated https://review.openstack.org/202885 | 05:22 |
*** josecastroleon has quit IRC | 05:23 | |
*** armax has quit IRC | 05:24 | |
*** lyanchih has quit IRC | 05:31 | |
*** zxyf has joined #openstack-nova | 05:31 | |
*** armax has joined #openstack-nova | 05:31 | |
*** shoutm_ has joined #openstack-nova | 05:31 | |
*** shoutm has quit IRC | 05:34 | |
*** davideagnello has quit IRC | 05:38 | |
*** otter768 has joined #openstack-nova | 05:47 | |
*** armax has quit IRC | 05:48 | |
*** bkopilov has joined #openstack-nova | 05:49 | |
*** otter768 has quit IRC | 05:52 | |
*** ftersin has joined #openstack-nova | 05:56 | |
*** irenab has joined #openstack-nova | 05:58 | |
*** chhavi has quit IRC | 05:59 | |
*** venkat_p has joined #openstack-nova | 06:00 | |
*** tri2sing has quit IRC | 06:00 | |
*** haomaiwang has quit IRC | 06:01 | |
*** alexpilotti_ has joined #openstack-nova | 06:01 | |
*** haomaiwang has joined #openstack-nova | 06:01 | |
*** lyanchih has joined #openstack-nova | 06:01 | |
*** irenab has quit IRC | 06:01 | |
*** MooohT has joined #openstack-nova | 06:03 | |
*** ftersin has quit IRC | 06:03 | |
*** ftersin has joined #openstack-nova | 06:04 | |
MooohT | Hi there. How can I add metadata tag to instances using nova python-client APIs? | 06:04 |
*** lpetrut has joined #openstack-nova | 06:05 | |
MooohT | I found it: http://docs.openstack.org/developer/python-novaclient/ref/v2/servers.html | 06:07 |
*** VikasC has joined #openstack-nova | 06:09 | |
*** matrohon has quit IRC | 06:14 | |
*** chhavi has joined #openstack-nova | 06:16 | |
*** garyk has joined #openstack-nova | 06:21 | |
openstackgerrit | Abhijeet Malawade proposed openstack/nova: Pass bdm info to _get_instance_disk_info method https://review.openstack.org/221162 | 06:21 |
*** lpetrut has quit IRC | 06:22 | |
*** rajesht has quit IRC | 06:24 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Transifex https://review.openstack.org/212367 | 06:25 |
*** mpaolino has joined #openstack-nova | 06:26 | |
*** baoli has joined #openstack-nova | 06:26 | |
*** rdopiera has joined #openstack-nova | 06:27 | |
*** josecastroleon has joined #openstack-nova | 06:29 | |
*** josecastroleon1 has quit IRC | 06:30 | |
*** baoli has quit IRC | 06:31 | |
*** Murali has joined #openstack-nova | 06:32 | |
*** salv-orlando has joined #openstack-nova | 06:33 | |
*** MooohT has quit IRC | 06:43 | |
*** lsmola has joined #openstack-nova | 06:47 | |
*** sudipto has joined #openstack-nova | 06:50 | |
*** irenab has joined #openstack-nova | 06:53 | |
openstackgerrit | Xiaowei Qian proposed openstack/python-novaclient: Modify "nova keypair-show" Positional arguments help information CLI "nova keypair-show <Name or ID>", Positional arguments help information supports ID , but does not actually support, So modify the help information. https://review.openstack.org/221170 | 06:57 |
openstackgerrit | Xiaowei Qian proposed openstack/python-novaclient: Modify "nova keypair-show" Positional arguments help information CLI "nova keypair-show <Name or ID>", Positional arguments help information supports ID, but does not actually support, So modify the help information. https://review.openstack.org/221170 | 06:59 |
*** haomaiwang has quit IRC | 07:01 | |
*** haomaiwang has joined #openstack-nova | 07:01 | |
*** Sree has quit IRC | 07:01 | |
*** apuimedo_ has joined #openstack-nova | 07:03 | |
*** gszasz has joined #openstack-nova | 07:03 | |
*** yamahata has quit IRC | 07:07 | |
*** ildikov has joined #openstack-nova | 07:10 | |
*** moshele has joined #openstack-nova | 07:10 | |
jwcroppe | bauzas: awake yet? | 07:11 |
jwcroppe | bauzas: https://review.openstack.org/#/c/219153/ is awaiting you ... Jenkins finally passed. :-) | 07:12 |
*** fifieldt has joined #openstack-nova | 07:13 | |
*** alexschm has joined #openstack-nova | 07:13 | |
bauzas | jwcroppe: I do, but only had yet one shot of caffeine | 07:14 |
bauzas | jwcroppe: fair, that's in my queue | 07:14 |
jwcroppe | bauzas: sounds good - this turned out much nicer | 07:15 |
jwcroppe | bauzas: I'll actually be in Paris and Rennes week of 9.20 | 07:16 |
*** vilobhmm_11 has quit IRC | 07:18 | |
*** ijw_ has joined #openstack-nova | 07:18 | |
bauzas | jwcroppe: ack, but I'm definitely not living there :) | 07:18 |
bauzas | so any beer should wait till Tokyo | 07:19 |
*** zhangjn has joined #openstack-nova | 07:19 | |
*** moshele has quit IRC | 07:20 | |
*** Jeffrey4l has joined #openstack-nova | 07:20 | |
*** liusheng has quit IRC | 07:23 | |
*** Tedster has quit IRC | 07:26 | |
*** Tedster has joined #openstack-nova | 07:27 | |
*** park__ has quit IRC | 07:27 | |
*** moshele has joined #openstack-nova | 07:27 | |
*** yassine__ has joined #openstack-nova | 07:30 | |
*** zhangjn_ has joined #openstack-nova | 07:30 | |
*** pbrooko has joined #openstack-nova | 07:31 | |
jwcroppe | bauzas: +1 | 07:31 |
*** asettle has quit IRC | 07:32 | |
*** deepakcs has joined #openstack-nova | 07:33 | |
*** pbrooko has quit IRC | 07:33 | |
*** zhangjn has quit IRC | 07:34 | |
*** zhangjn_ has quit IRC | 07:35 | |
*** davideagnello has joined #openstack-nova | 07:38 | |
*** jlanoux has joined #openstack-nova | 07:40 | |
*** davideagnello has quit IRC | 07:43 | |
*** achanda has joined #openstack-nova | 07:43 | |
*** irenab has quit IRC | 07:43 | |
*** pbrooko has joined #openstack-nova | 07:44 | |
*** pbrooko has quit IRC | 07:46 | |
*** pbrooko has joined #openstack-nova | 07:46 | |
*** Sree has joined #openstack-nova | 07:47 | |
*** otter768 has joined #openstack-nova | 07:48 | |
*** lyanchih has quit IRC | 07:48 | |
openstackgerrit | Xiaowei Qian proposed openstack/python-novaclient: Modify "nova keypair-show" Positional arguments help information CLI "nova keypair-show <Name or ID>", Positional arguments help information supports ID, but does not actually support, So modify the help information. https://review.openstack.org/221181 | 07:52 |
*** otter768 has quit IRC | 07:53 | |
*** alex_klimov has joined #openstack-nova | 07:59 | |
*** zxyf has quit IRC | 08:00 | |
*** haomaiwang has quit IRC | 08:01 | |
*** haomaiwang has joined #openstack-nova | 08:01 | |
*** lpetrut has joined #openstack-nova | 08:01 | |
*** lyanchih has joined #openstack-nova | 08:02 | |
*** ijw_ has quit IRC | 08:02 | |
*** lucasagomes has joined #openstack-nova | 08:06 | |
*** SourabhP has joined #openstack-nova | 08:07 | |
*** moshele has quit IRC | 08:07 | |
*** SourabhP_ has joined #openstack-nova | 08:09 | |
*** matrohon has joined #openstack-nova | 08:09 | |
*** jcoufal has joined #openstack-nova | 08:09 | |
*** SourabhP has quit IRC | 08:11 | |
*** SourabhP_ is now known as SourabhP | 08:11 | |
*** ociuhandu has quit IRC | 08:12 | |
openstackgerrit | John Garbutt proposed openstack/nova: Freeze v1 Instance and InstanceList schema hashes https://review.openstack.org/220689 | 08:14 |
*** romainh has joined #openstack-nova | 08:14 | |
*** gszasz has quit IRC | 08:16 | |
*** pixelbeat has joined #openstack-nova | 08:18 | |
openstackgerrit | Marian Horban proposed openstack/nova: [WIP]Remove wsgi functionality https://review.openstack.org/221118 | 08:18 |
*** Jeffrey4l has quit IRC | 08:23 | |
*** Jeffrey4l has joined #openstack-nova | 08:24 | |
*** danpb has joined #openstack-nova | 08:24 | |
*** achanda has quit IRC | 08:25 | |
bauzas | johnthetubaguy: heya, have a few secs for answering a process question about https://blueprints.launchpad.net/nova/+spec/instance-tasks-api ? | 08:27 |
bauzas | johnthetubaguy: should I keep this one or open another one less icehouse-related? | 08:27 |
*** achanda has joined #openstack-nova | 08:28 | |
johnthetubaguy | bauzas: I would start a new one, if I was doing that | 08:28 |
bauzas | johnthetubaguy: ack | 08:28 |
*** moshele has joined #openstack-nova | 08:30 | |
*** pedroalvarez has quit IRC | 08:30 | |
*** jistr has joined #openstack-nova | 08:30 | |
*** pedroalvarez has joined #openstack-nova | 08:31 | |
*** exploreshaifali has joined #openstack-nova | 08:31 | |
lyanchih | Hi, I found one bug which is nova api micro version unsync between horizon and nova-client. | 08:32 |
*** pbrooko has quit IRC | 08:33 | |
lyanchih | In latest nova-client, it will assume to use latest version of implemention in api when api version is null. | 08:33 |
*** irenab has joined #openstack-nova | 08:34 | |
lyanchih | Request body will been adjust to match latest version of schema in nova. | 08:35 |
*** SourabhP has quit IRC | 08:35 | |
lyanchih | But request header will not mark as latest nova api version. If nova’s default micro version is oldest, nova will possible raise unexcept property. | 08:36 |
*** gszasz has joined #openstack-nova | 08:39 | |
lyanchih | There are two way to fix. One is set default nova micro version to latest in horizon, the other is setting to latest of api micro version header in nova-client when users(such as horizon) don’t assign api_version. | 08:40 |
*** andreykurilin has quit IRC | 08:43 | |
*** andreykurilin has joined #openstack-nova | 08:44 | |
*** humble_ has joined #openstack-nova | 08:44 | |
*** pbrooko has joined #openstack-nova | 08:45 | |
*** derekh has joined #openstack-nova | 08:46 | |
*** humble__ has quit IRC | 08:48 | |
*** achanda has quit IRC | 08:52 | |
*** aix has quit IRC | 08:53 | |
*** snikitin has quit IRC | 08:56 | |
*** VikasC has quit IRC | 08:57 | |
*** pbrooko has quit IRC | 08:59 | |
*** pbrooko has joined #openstack-nova | 08:59 | |
*** haomaiwang has quit IRC | 09:01 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add checks for volume status when rebuilding https://review.openstack.org/217567 | 09:01 |
*** haomaiwa_ has joined #openstack-nova | 09:01 | |
*** ildikov has quit IRC | 09:02 | |
*** VikasC has joined #openstack-nova | 09:04 | |
*** chhavi has quit IRC | 09:04 | |
johnthetubaguy | lyanchih: horizon should be hardcoding a version (not setting a version at all, is probably the correct thing to do) | 09:05 |
johnthetubaguy | lyanchih: nova-client should only auto negociate with the CLI, basically just to get the most information, but thats not how the consumers of that should work | 09:06 |
johnthetubaguy | lyanchih: now its totally possible thats not what has happened, which is bad | 09:06 |
johnthetubaguy | lyanchih: actually, maybe I miss-read your message, I am expecting Horizon will not use the version = latest header, right now it probably doesn't set that header at all, and that is just fine | 09:07 |
*** humble__ has joined #openstack-nova | 09:07 | |
gridinv | guys, anybody can help with pci-passthrough? | 09:08 |
lyanchih | But if we don’t assign nova micro version, some feature will fail | 09:08 |
lyanchih | johnthetubaguy: For example, add keypair | 09:08 |
lyanchih | johnthetubaguy: Yes, I also though it will be more adative if we hardcode version in horizon. | 09:09 |
*** humble_ has quit IRC | 09:10 | |
*** wuhg has quit IRC | 09:11 | |
*** kiran-r has joined #openstack-nova | 09:11 | |
johnthetubaguy | lyanchih: the feature should just work without the micro version added, well unless you need a new bit of that API like x509 | 09:11 |
johnthetubaguy | lyanchih: in that case horizon should just hard code the version it want's to use for x509, but if that version is not available, then that cloud does not support that feature, so I guess horizon would hide that option, or something like that? | 09:13 |
*** chhavi has joined #openstack-nova | 09:13 | |
*** rotbeard has joined #openstack-nova | 09:13 | |
johnthetubaguy | lyanchih: this is great feedback though, I think alex_xu and sdague are good folks to reach out to about the docs we are starting to write on all these details | 09:14 |
*** _gridinv has joined #openstack-nova | 09:14 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add checks for volume status when rebuilding https://review.openstack.org/217567 | 09:14 |
*** e0ne has joined #openstack-nova | 09:16 | |
lyanchih | johnthetubaguy: Thx. But there is api version conflict between horizon and nova-client for latest horizon and about nova-client 2.7.0. | 09:16 |
lyanchih | johnthetubaguy: This is bug page https://bugs.launchpad.net/horizon/+bug/1493207 | 09:17 |
openstack | Launchpad bug 1493205 in OpenStack Dashboard (Horizon) "duplicate for #1493207 Create Keypair failed on latest DevStack" [Undecided,New] - Assigned to Chung Chih, Hung (lyanchih) | 09:17 |
*** aix has joined #openstack-nova | 09:18 | |
johnthetubaguy | lyanchih: hmm, looking | 09:21 |
*** afazekas_ has joined #openstack-nova | 09:22 | |
*** afazekas_ has quit IRC | 09:22 | |
johnthetubaguy | lyanchih: any chance you could point me at the bit of horizon that makes the keypair call? | 09:22 |
johnthetubaguy | lyanchih: sounds like this just broke when python-novaclient was upgraded? | 09:22 |
*** afazekas_ has joined #openstack-nova | 09:23 | |
lyanchih | johnthetubaguy: Horizon will not set api version to nova-client, so nova micro version will not set | 09:23 |
lyanchih | Yes, latest version | 09:23 |
lyanchih | johnthetubaguy: Nova-client needs to been upgrade to latest version in requirments before few days. | 09:24 |
*** Jeffrey4l has quit IRC | 09:24 | |
lyanchih | https://github.com/openstack/requirements/commit/0fe3bfeb758322878b8fa29ea5cfe8df3c1f28ac | 09:24 |
johnthetubaguy | yeah, so this is totally a python-novaclient bug | 09:24 |
lyanchih | But I though it shouldn’t be nova-client bug. | 09:24 |
lyanchih | It just listen horizon. | 09:25 |
johnthetubaguy | lyanchih: so am on not sure, you should have just upgraded, and it should have just worked, so it feels like a client bug | 09:25 |
lyanchih | johnthetubaguy: I found some horizon code to you. | 09:25 |
lyanchih | https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/nova.py#L448 | 09:26 |
*** armax has joined #openstack-nova | 09:27 | |
lyanchih | johnthetubaguy: Horizon wouldn’t tell nova-client which micro version we should use. Therefore nova-client will not set micro version header. | 09:28 |
johnthetubaguy | lyanchih: this all looks totally correct: https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/nova.py#L559 | 09:29 |
johnthetubaguy | lyanchih: so I think the bug is that python-novaclient is sending the wrong format for the selected version | 09:29 |
johnthetubaguy | the selected version being 2.0/2.1 by deafult | 09:29 |
johnthetubaguy | it could also be a Nova bug, but I am assuming tempest would have caught those kinds of things | 09:30 |
lyanchih | johnthetubaguy: You mean horizon may use 2.0/2.1 version by default | 09:30 |
lyanchih | ? | 09:30 |
johnthetubaguy | lyanchih: yes, that should just work | 09:30 |
johnthetubaguy | the API is backwards compatible, so you can keep using the old verison just fine | 09:30 |
johnthetubaguy | seems python-novaclient is getting ahead of its-self | 09:31 |
johnthetubaguy | but I will go read that code, to find out | 09:31 |
lyanchih | johnthetubaguy: Oh, I know why happen, let me find the position. | 09:31 |
lyanchih | johnthetubaguy: https://github.com/openstack/python-novaclient/blob/master/novaclient/api_versions.py#L347 | 09:32 |
lyanchih | johnthetubaguy: https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/keypairs.py#L82 | 09:32 |
lyanchih | johnthetubaguy: Nova-client will use latest version of implement when user don’t assign api_version | 09:33 |
johnthetubaguy | lyanchih: ah, so the log does say its sending the type, and it totally shouldn't | 09:33 |
johnthetubaguy | lyanchih: it does on the CLI, it shouldn't though the regular way | 09:33 |
lyanchih | johnthetubaguy: I don’t know whether it is regular way. But maybe we should add more condition. | 09:35 |
*** gszasz has quit IRC | 09:35 | |
*** salv-orlando has quit IRC | 09:36 | |
*** Jeffrey4l has joined #openstack-nova | 09:36 | |
johnthetubaguy | lyanchih: so the key bit is you should have not been affected by the upgrade | 09:37 |
lyanchih | johnthetubaguy: Besides nova CLI will use latest micro version, is it correct? | 09:37 |
johnthetubaguy | lyanchih: yes, but please ignore that as a bad example | 09:37 |
*** NightKhaos has quit IRC | 09:39 | |
*** ildikov has joined #openstack-nova | 09:39 | |
*** davideagnello has joined #openstack-nova | 09:39 | |
lyanchih | johnthetubaguy: So we shouldn’t use version above 2.1, if users didn’t assign micro version? | 09:41 |
*** Marga_ has joined #openstack-nova | 09:41 | |
johnthetubaguy | lyanchih: we should really fix python-novaclient, it seems broken | 09:41 |
*** e0ne has quit IRC | 09:41 | |
johnthetubaguy | lyanchih: but a quick fix would but what the unit test does: cs.api_version = api_versions.APIVersion("2.0") | 09:42 |
*** NightKhaos has joined #openstack-nova | 09:42 | |
lyanchih | johnthetubaguy: If nova-client use version above 2.1, it should guarante request header shoudn’t have micro version? | 09:42 |
lyanchih | johnthetubaguy: Oh, yes, Default version | 09:43 |
johnthetubaguy | so I think 2.1 will generate the v2.1 header, which would also work, but only on v2.1 endpoints | 09:43 |
bauzas | johnthetubaguy: FWIW https://blueprints.launchpad.net/nova/+spec/instance-tasks-and-actions | 09:43 |
bauzas | johnthetubaguy: I'll loop back with alaski | 09:44 |
lyanchih | johnthetubaguy it will not generate micro header when api_version is null. :( | 09:44 |
*** davideagnello has quit IRC | 09:44 | |
johnthetubaguy | bauzas: you getting a spec up for review? | 09:44 |
bauzas | johnthetubaguy: yep | 09:44 |
bauzas | johnthetubaguy: a first draft | 09:44 |
johnthetubaguy | bauzas: I think its really going to have to group of specs, not all in a single spec | 09:45 |
bauzas | johnthetubaguy: lots of bits are missing some opinions | 09:45 |
johnthetubaguy | lyanchih: thats totally correct | 09:45 |
bauzas | johnthetubaguy: that's my thoughts too | 09:45 |
bauzas | johnthetubaguy: the BP is more an epci | 09:45 |
bauzas | epic | 09:45 |
johnthetubaguy | lyanchih: the client will send the correct version with that they, and it should work | 09:45 |
bauzas | johnthetubaguy: not sure if a 1:N relationship between BP and specs is correct tho | 09:45 |
johnthetubaguy | bauzas: epics go in devref for now | 09:45 |
johnthetubaguy | bauzas: you will need lots of blueprints | 09:45 |
bauzas | ack | 09:46 |
johnthetubaguy | bauzas: blueprint and spec is always 1:1 | 09:46 |
johnthetubaguy | bauzas: see the cells devref, something like that I think is the best place to start | 09:46 |
*** dimsum__ has joined #openstack-nova | 09:46 | |
bauzas | johnthetubaguy: okay, so I should rather write a tasks manifesto | 09:46 |
johnthetubaguy | bauzas: just covering the high level big strokes, not details, they all go in the specs | 09:46 |
johnthetubaguy | bauzas: yup, I think thats the best place to start | 09:46 |
bauzas | okay | 09:47 |
bauzas | wfm | 09:47 |
bauzas | johnthetubaguy: I keep the BP as a placeholder for saying "eh, someone is working on that" | 09:47 |
bauzas | :p | 09:47 |
johnthetubaguy | bauzas: I would also get the separate specs up for review, once the devref is done, that might help concentrate the mind on the steps needed | 09:47 |
johnthetubaguy | bauzas: we will almost certainly want to share out all this work, FWIW | 09:47 |
bauzas | totally agreed, that needs to be a group thing | 09:48 |
bauzas | but as long as I remember, we need people to step in :) | 09:48 |
johnthetubaguy | yup, design the flow of work to help with that, ideally | 09:48 |
*** otter768 has joined #openstack-nova | 09:49 | |
*** jlvillal has quit IRC | 09:50 | |
*** jlvillal has joined #openstack-nova | 09:50 | |
lyanchih | johnthetubaguy: Do you prefer we can fix it by api_versions.APIVersion(“2.0”) at fist? | 09:50 |
openstackgerrit | John Garbutt proposed openstack/python-novaclient: WIP: show up an error when not specifying version https://review.openstack.org/221222 | 09:50 |
*** dims_ has joined #openstack-nova | 09:50 | |
johnthetubaguy | lyanchih: in summary, no, we need to fix python-novaclient | 09:51 |
johnthetubaguy | lyanchih: but horizon could add that anyways, and it would unblock you | 09:51 |
johnthetubaguy | if that makes sense | 09:51 |
*** matrohon has quit IRC | 09:51 | |
lyanchih | johnthetubaguy: What about to add default setting named DEFAULT_NOVA_MICRO_API_VERSION in horizon? | 09:52 |
johnthetubaguy | lyanchih: that seems like a bad move, honestly | 09:52 |
johnthetubaguy | lyanchih: it will need to be a negotiation process, long term, and v2.0 will always be available to you, in theory | 09:53 |
*** otter768 has quit IRC | 09:54 | |
johnthetubaguy | lyanchih: I just uploaded this in an attempt to "prove" the bug: https://review.openstack.org/221222 | 09:54 |
*** dimsum__ has quit IRC | 09:55 | |
lyanchih | johnthetubaguy: Ok….is this needs to discuss in nova meeting? | 09:56 |
openstackgerrit | Rajesh Tailor proposed openstack/nova: Fix order of arguments in assertEqual https://review.openstack.org/221228 | 09:56 |
johnthetubaguy | lyanchih: I don't think so, although we could raise it here, there is a nova API meeting today though, I can raise it there | 09:57 |
johnthetubaguy | lyanchih: we agreed the opposite approach, as I understand it, this is the worst possible approach | 09:57 |
*** shoutm_ has quit IRC | 09:57 | |
*** e0ne has joined #openstack-nova | 09:57 | |
sdague | morning folks | 09:58 |
johnthetubaguy | sdague: good morning, we have a fun one here: https://review.openstack.org/#/c/221222/ | 09:59 |
johnthetubaguy | sdague: I am just digging a little right now | 09:59 |
johnthetubaguy | sdague: PS, hope you had a good break over the long weekend | 09:59 |
*** ildikov has quit IRC | 10:00 | |
lyanchih | johnthetubaguy: Nova meeting and nova API meeting is different meeting? | 10:00 |
sdague | johnthetubaguy: it involved a lot of home repair, some planned, some unplanned. :) | 10:00 |
*** haomaiwa_ has quit IRC | 10:01 | |
*** haomaiwang has joined #openstack-nova | 10:01 | |
sdague | so, what exactly is the issue there, sorry, just starting first cup of cofee | 10:01 |
openstackgerrit | Marian Horban proposed openstack/nova: [WIP]Remove wsgi functionality https://review.openstack.org/221118 | 10:01 |
johnthetubaguy | sdague: doh, ups and downs | 10:01 |
johnthetubaguy | lyanchih: yeah, one is the project meeting, one is a subteam meeting, the API specific meeting is today, the other one is thursday, thats the main reason | 10:02 |
johnthetubaguy | sdague: so seems like python-novaclient has broken horizons keypair support | 10:02 |
*** IanGovett has joined #openstack-nova | 10:02 | |
lyanchih | johnthetubaguy: Thx. | 10:02 |
johnthetubaguy | sdague: seems like we default to sending no version headers, but the 2.2 version of the request, which blows up: https://launchpad.net/bugs/1493207 | 10:03 |
openstack | Launchpad bug 1493205 in OpenStack Dashboard (Horizon) "duplicate for #1493207 Create Keypair failed on latest DevStack" [Undecided,New] - Assigned to Chung Chih, Hung (lyanchih) | 10:03 |
johnthetubaguy | lyanchih: no problem | 10:03 |
sdague | ok, so the issue is that keypairs changed in 2.2, and we only have the 2.2 code in the client | 10:03 |
johnthetubaguy | sdague: I uploaded this in an attempt to "prove" what is happening: https://review.openstack.org/#/c/221222/ | 10:03 |
sdague | we should have both the 2.1 and 2.2 code | 10:03 |
johnthetubaguy | sdague: seems we have the correct code, but when the version is null we are not using the old code | 10:04 |
lyanchih | johnthetubaguy: Client also have 2.1 code. But client will use latest code default | 10:04 |
lyanchih | Oh, sorry. I mark wrong. | 10:04 |
*** humble_ has joined #openstack-nova | 10:06 | |
*** ociuhandu has joined #openstack-nova | 10:07 | |
*** humble__ has quit IRC | 10:10 | |
*** kse has quit IRC | 10:12 | |
*** ildikov has joined #openstack-nova | 10:14 | |
lyanchih | johnthetubaguy: How can I know result of discussion about that. | 10:15 |
openstackgerrit | John Garbutt proposed openstack/python-novaclient: WIP: when no version given, default to v2.0 https://review.openstack.org/221222 | 10:16 |
johnthetubaguy | lyanchih: you can join the meeting if you like its in just under two hours time in #openstack-meeting | 10:17 |
johnthetubaguy | lyanchih: when does your working day end? | 10:18 |
johnthetubaguy | lyanchih: I can put a comment on the bug too | 10:18 |
lyanchih | Oh, it is night in my time zone. lol | 10:19 |
lyanchih | johnthetubaguy: Thank you. | 10:20 |
*** humble_ has quit IRC | 10:21 | |
johnthetubaguy | lyanchih: ah, so totally go have a sleep, lets see what we can do before you wake up, drop my an email if the rail goes cold, and I will try follow up on it for you | 10:21 |
*** jlvillal has quit IRC | 10:22 | |
*** gszasz has joined #openstack-nova | 10:25 | |
*** Sree has quit IRC | 10:26 | |
*** Sree has joined #openstack-nova | 10:26 | |
*** jlanoux_ has joined #openstack-nova | 10:28 | |
*** _kiran_ has joined #openstack-nova | 10:29 | |
*** romainh has quit IRC | 10:29 | |
*** irenab has quit IRC | 10:29 | |
*** kiran-r has quit IRC | 10:30 | |
*** Sree has quit IRC | 10:30 | |
*** jlanoux has quit IRC | 10:31 | |
*** irenab has joined #openstack-nova | 10:31 | |
*** irenab has quit IRC | 10:33 | |
*** aix has quit IRC | 10:35 | |
*** aix has joined #openstack-nova | 10:36 | |
*** irenab has joined #openstack-nova | 10:37 | |
*** irenab has quit IRC | 10:37 | |
*** irenab has joined #openstack-nova | 10:38 | |
*** shoutm has joined #openstack-nova | 10:39 | |
*** baoli has joined #openstack-nova | 10:42 | |
*** jlanoux has joined #openstack-nova | 10:44 | |
*** Marga_ has quit IRC | 10:46 | |
*** baoli has quit IRC | 10:47 | |
*** jlanoux_ has quit IRC | 10:47 | |
*** ZZelle has quit IRC | 10:49 | |
*** ZZelle has joined #openstack-nova | 10:49 | |
*** claudiub has joined #openstack-nova | 10:57 | |
*** VikasC has quit IRC | 10:57 | |
*** lyanchih has quit IRC | 10:58 | |
*** Marga_ has joined #openstack-nova | 10:58 | |
*** salv-orlando has joined #openstack-nova | 11:00 | |
*** chenzeng has joined #openstack-nova | 11:00 | |
*** haomaiwang has quit IRC | 11:01 | |
*** 92AAB1O7Y has joined #openstack-nova | 11:01 | |
*** jlvillal has joined #openstack-nova | 11:03 | |
*** ildikov has quit IRC | 11:04 | |
*** ildikov has joined #openstack-nova | 11:08 | |
*** tojuvone has quit IRC | 11:11 | |
*** _kiran_ is now known as kiran-r | 11:11 | |
*** 92AAB1O7Y has quit IRC | 11:12 | |
*** kjelly_ has joined #openstack-nova | 11:12 | |
ZZelle | garyk, hi | 11:14 |
*** romainh has joined #openstack-nova | 11:16 | |
*** smatzek has joined #openstack-nova | 11:17 | |
*** lucasagomes is now known as lucas-hungry | 11:19 | |
*** Marga_ has quit IRC | 11:20 | |
garyk | ZZelle: hi | 11:21 |
ZZelle | garyk, do you we could expect some support if i request a rfe for https://review.openstack.org/186716 ? | 11:22 |
ZZelle | garyk, do you think we could expect some support if i request a rfe for https://review.openstack.org/186716 ? | 11:22 |
garyk | ZZelle: i hope so. | 11:24 |
*** marcusvrn_ has joined #openstack-nova | 11:25 | |
garyk | ZZelle: i'll ping rado and ask him to address matts concerns | 11:25 |
ZZelle | garyk, i already did | 11:26 |
garyk | ok, thanks. like is tough in nova … | 11:26 |
garyk | like => life | 11:26 |
*** thorst has joined #openstack-nova | 11:26 | |
ZZelle | garyk, perhaps it's better that rado (change owner) requests the RFE? | 11:26 |
garyk | this change makes things a lot more efficient than they are | 11:26 |
garyk | ZZelle: it is an improvement. i hope that an optimization will be considered | 11:27 |
garyk | but i am not sure | 11:27 |
*** jaypipes has joined #openstack-nova | 11:31 | |
*** sudipto has quit IRC | 11:32 | |
johnthetubaguy | ZZelle: this looks like a feature, so to make sure we can tell our users about whats going on, and get you the code review attention you need inside such a big project as Nova, we follow this process, as we have the last few releases: https://wiki.openstack.org/wiki/Nova/Liberty_Release_Schedule | 11:34 |
johnthetubaguy | ZZelle: any questions let me know | 11:34 |
johnthetubaguy | ZZelle: this would have just needed a blueprint approved a a nova meeting, but we are in feature freeze right now, so we can concentrate on bug fixes | 11:35 |
* johnthetubaguy runs off for some lunch | 11:36 | |
*** inara has quit IRC | 11:37 | |
*** kolesovdv has joined #openstack-nova | 11:38 | |
*** davideagnello has joined #openstack-nova | 11:40 | |
*** davideagnello has quit IRC | 11:45 | |
*** inara has joined #openstack-nova | 11:49 | |
*** otter768 has joined #openstack-nova | 11:50 | |
*** Sree has joined #openstack-nova | 11:50 | |
*** deepthi has quit IRC | 11:51 | |
*** gmann_ has joined #openstack-nova | 11:52 | |
*** otter768 has quit IRC | 11:55 | |
*** chenzeng has quit IRC | 11:55 | |
*** rfolco has joined #openstack-nova | 11:56 | |
*** jecarey has quit IRC | 11:56 | |
*** Jeffrey4l has quit IRC | 11:57 | |
*** mklyus has joined #openstack-nova | 11:57 | |
*** bkopilov has quit IRC | 12:00 | |
alex_xu | nova api meeting is running | 12:00 |
*** mwagner_lap has quit IRC | 12:01 | |
*** karimb has joined #openstack-nova | 12:01 | |
*** e0ne has quit IRC | 12:01 | |
*** alexpilotti_ has quit IRC | 12:03 | |
*** aysyd has joined #openstack-nova | 12:03 | |
*** tojuvone has joined #openstack-nova | 12:03 | |
*** e0ne has joined #openstack-nova | 12:04 | |
openstackgerrit | Rajesh Tailor proposed openstack/nova: Fix order of arguments in assertEqual https://review.openstack.org/221271 | 12:09 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add checks for volume status when rebuilding https://review.openstack.org/217567 | 12:10 |
*** baoli has joined #openstack-nova | 12:11 | |
*** venkat_p has quit IRC | 12:11 | |
*** raildo-afk is now known as raildo | 12:12 | |
*** Jeffrey4l has joined #openstack-nova | 12:13 | |
*** zhangjn has joined #openstack-nova | 12:15 | |
*** rajesht has joined #openstack-nova | 12:17 | |
*** zhangjn has quit IRC | 12:17 | |
*** scottda has joined #openstack-nova | 12:17 | |
*** dave-mccowan has joined #openstack-nova | 12:18 | |
*** markvoelker has joined #openstack-nova | 12:19 | |
dims_ | jamielennox|away: please take a look at this review when you get a chance - https://review.openstack.org/#/c/220767/ | 12:19 |
dims_ | tdurakov: ping ^^ | 12:19 |
*** deepakcs has quit IRC | 12:20 | |
*** markvoelker has quit IRC | 12:20 | |
*** markvoelker has joined #openstack-nova | 12:20 | |
*** liusheng has joined #openstack-nova | 12:21 | |
*** Marga_ has joined #openstack-nova | 12:21 | |
*** Marga_ has quit IRC | 12:26 | |
*** e0ne has quit IRC | 12:26 | |
*** liusheng has quit IRC | 12:27 | |
*** armax has quit IRC | 12:27 | |
*** burgerk has joined #openstack-nova | 12:29 | |
*** lucas-hungry is now known as lucasagomes | 12:33 | |
*** salv-orlando has quit IRC | 12:34 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Manifesto for working on Tasks https://review.openstack.org/221280 | 12:36 |
bauzas | johnthetubaguy: alaski: see above ^ | 12:36 |
*** shoutm has quit IRC | 12:39 | |
openstackgerrit | Alexander Schmidt proposed openstack/nova: libvirt: Acquire TCP ports for console during live migration https://review.openstack.org/215102 | 12:40 |
*** Sree has quit IRC | 12:40 | |
*** edmondsw has joined #openstack-nova | 12:41 | |
*** Jeffrey4l has quit IRC | 12:42 | |
*** vivekd_ has joined #openstack-nova | 12:42 | |
*** bswartz has quit IRC | 12:42 | |
*** vivekd has quit IRC | 12:44 | |
*** vivekd_ is now known as vivekd | 12:44 | |
*** rlrossit has joined #openstack-nova | 12:44 | |
*** salv-orlando has joined #openstack-nova | 12:44 | |
*** matrohon has joined #openstack-nova | 12:46 | |
openstackgerrit | John Garbutt proposed openstack/python-novaclient: WIP: when no version given, default to v2.0 https://review.openstack.org/221222 | 12:48 |
*** ildikov has quit IRC | 12:51 | |
openstackgerrit | John Garbutt proposed openstack/python-novaclient: When no version given, default to v2.0 https://review.openstack.org/221222 | 12:53 |
*** Sree has joined #openstack-nova | 12:54 | |
*** ijuwang has joined #openstack-nova | 12:55 | |
*** nelsnelson has joined #openstack-nova | 12:58 | |
*** mdrabe has joined #openstack-nova | 12:59 | |
*** vladikr has joined #openstack-nova | 13:00 | |
bauzas | soooo | 13:00 |
*** erhudy has joined #openstack-nova | 13:01 | |
bauzas | sdague: alex_xu: question for you about a bug in the AZ API (and metadata) | 13:01 |
alex_xu | bauzas: yea | 13:01 |
bauzas | sdague: alex_xu: there is a corner case when the instance is not updated with an host (because it's not scheduled yet) | 13:01 |
*** zhangjn has joined #openstack-nova | 13:01 | |
bauzas | sdague: alex_xu: in that case, when looking at the instance, it returns the default AZ | 13:02 |
bauzas | sdague: alex_xu: while it should return None instead | 13:02 |
*** ildikov has joined #openstack-nova | 13:02 | |
bauzas | sdague: alex_xu: since we have a cache, it makes the output flakey | 13:02 |
*** armax has joined #openstack-nova | 13:02 | |
bauzas | sdague: alex_xu: so there was an abandoned change targeting to return None instead of the default AZ | 13:03 |
bauzas | but we had a concern about the API change | 13:03 |
*** lyanchih has joined #openstack-nova | 13:03 | |
bauzas | so, my question is, should we bump a microversion for that ? | 13:03 |
*** Chandan_p has joined #openstack-nova | 13:03 | |
bauzas | or just correct the broken behaviour | 13:03 |
bauzas | ? | 13:03 |
alex_xu | bauzas: if None is valid value for az field, then it needn't | 13:03 |
*** slagle_ is now known as slagle | 13:03 | |
*** Sree has quit IRC | 13:04 | |
bauzas | alex_xu: but it would not return the same AZ | 13:04 |
bauzas | so it would be an UX change | 13:04 |
alex_xu | bauzas: I think it's ok. the value can be changed | 13:05 |
sdague | bauzas: how big a window is this? | 13:05 |
bauzas | sdague: alex_xu: https://review.openstack.org/#/c/149562/9/nova/availability_zones.py,cm was targeting that but needed a rebase | 13:06 |
bauzas | so I was about to provide that | 13:06 |
sdague | bauzas: where is this cached? | 13:06 |
*** rotbeard has quit IRC | 13:06 | |
sdague | I guess that's my only concern | 13:06 |
bauzas | sdague: in the AZ helper | 13:06 |
bauzas | sdague: lemme show you where | 13:06 |
sdague | would None not be cached? | 13:06 |
sdague | and was it ever possible to get back None before? | 13:07 |
*** MarcF has joined #openstack-nova | 13:07 | |
bauzas | sdague: https://github.com/openstack/nova/blob/master/nova/availability_zones.py#L176-L180 | 13:07 |
*** Piet has quit IRC | 13:07 | |
sdague | I think that's the issue for me, if None was possible before or not | 13:07 |
johnthetubaguy | claudiub: can I ask about the hyper-v VLAN support? can you quickly point at the code that implements that? | 13:07 |
*** e0ne has joined #openstack-nova | 13:08 | |
bauzas | sdague: that's another race cond that I tackled in https://review.openstack.org/#/c/172906/ | 13:08 |
bauzas | sdague: I see | 13:08 |
johnthetubaguy | claudiub: I totally see that now | 13:08 |
*** burgerk has quit IRC | 13:08 | |
bauzas | sdague: I need to doublecheck if it was possible, but my first guess is that while it's possible to return an empty string, it was never actually returned | 13:08 |
bauzas | sdague: every time that an instance was having no host field, it was return the default AZ, which means 'nova' | 13:09 |
claudiub | johnthetubaguy: hi. the neutron-hyperv-agent takes care of that, during the port binding | 13:09 |
johnthetubaguy | claudiub: oh wait, maybe I don't... | 13:09 |
bauzas | (by default) | 13:09 |
claudiub | johnthetubaguy: https://github.com/stackforge/networking-hyperv/blob/master/hyperv/neutron/hyperv_neutron_agent.py#L180 | 13:09 |
johnthetubaguy | claudiub: so that is about the nova-network support, not the neutron support | 13:09 |
*** marzif has joined #openstack-nova | 13:09 | |
*** tongli has joined #openstack-nova | 13:10 | |
johnthetubaguy | claudiub: I was checking in here, got confused, but I don't see it handling VLANs: https://github.com/openstack/nova/blob/master/nova/virt/hyperv/vif.py#L72 | 13:10 |
*** marzif has quit IRC | 13:10 | |
*** haomaiwang has joined #openstack-nova | 13:10 | |
*** changbl has quit IRC | 13:11 | |
*** gmann_ has quit IRC | 13:11 | |
*** mklyus has quit IRC | 13:11 | |
*** edleafe has quit IRC | 13:11 | |
*** marzif has joined #openstack-nova | 13:11 | |
claudiub | johnthetubaguy: ah, I see. but I thought that some features in the hypervisor support matrix could be implemented in other projects, like neutron, as I've seen something like that | 13:12 |
johnthetubaguy | claudiub: that entry is not very clear, given its next to Flat I very much assumed its about nova-network | 13:13 |
bauzas | sdague: confirmed, we were always returning the default AZ because https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/extended_availability_zone.py#L30 never returns None because of https://github.com/openstack/nova/blob/master/nova/availability_zones.py#L105-L106 | 13:13 |
*** jecarey has joined #openstack-nova | 13:14 | |
johnthetubaguy | claudiub: maybe we could add a note saying "only via neutron" or something? | 13:14 |
johnthetubaguy | claudiub: although I am not sure the others all work with neutron VLAN | 13:14 |
sdague | bauzas: so in the new version would you return an empty string, or None? | 13:14 |
bauzas | sdague: yep | 13:14 |
*** ivasev has joined #openstack-nova | 13:15 | |
sdague | bauzas: no, which one | 13:15 |
*** romainh has quit IRC | 13:15 | |
claudiub | johnthetubaguy: for example network security groups in the hypervisor support matrix for vmware vCenter it says: this supported by the Neutron NSX plugins. | 13:15 |
*** smatzek has quit IRC | 13:15 | |
bauzas | sdague: well, the former proposal was returning an empty string | 13:15 |
claudiub | johnthetubaguy: http://docs.openstack.org/developer/nova/support-matrix.html#networking_securitygroups | 13:16 |
bauzas | sdague: https://review.openstack.org/#/c/149562/11/nova/api/openstack/compute/plugins/v3/extended_availability_zone.py,cm | 13:16 |
johnthetubaguy | claudiub: yeah, thats my suggestion above, add a note | 13:16 |
*** dustins has joined #openstack-nova | 13:17 | |
sdague | bauzas: ok, but still a string type | 13:17 |
bauzas | sdague: it touches also the metadata | 13:17 |
bauzas | sdague: yup | 13:17 |
bauzas | sdague: technically, still a string type yeah | 13:17 |
claudiub | johnthetubaguy: ok, sure. | 13:18 |
sdague | that seems fine, I think there should be a release note on it | 13:18 |
*** artom has joined #openstack-nova | 13:19 | |
sdague | I'm not convinced that there should be an API bump, because that means we'd be honoring the old behavior, which is very clearly wrong info, for a long time | 13:19 |
sdague | the old approach only gave you correct info by accident | 13:19 |
*** pilgrimstack1 has joined #openstack-nova | 13:19 | |
*** zhangjn has quit IRC | 13:20 | |
*** Marga_ has joined #openstack-nova | 13:20 | |
alex_xu | bauzas: at least tempest not allow None https://github.com/openstack/tempest/blob/master/tempest/api_schema/response/compute/v2_1/servers.py#L167 | 13:20 |
*** kjelly_ has quit IRC | 13:20 | |
pilgrimstack1 | hi, looking for a rate limit feature to trully limits the instance/min a user can call | 13:21 |
johnthetubaguy | sdague: the bump could advertise the fix, but not sure its worth it | 13:21 |
pilgrimstack1 | do you know how to limit? | 13:21 |
bauzas | sdague: okay, sounds fair | 13:21 |
bauzas | alex_xu: yeah, forget the None thing, we should return an empty string | 13:22 |
sdague | johnthetubaguy: I think release notes could advertise it as well | 13:22 |
johnthetubaguy | sdague: I was meaning in a client discovery sense | 13:22 |
johnthetubaguy | if the client actually cared about that | 13:22 |
sdague | if we were going to do None, I'd say it was an API bump | 13:22 |
pilgrimstack1 | rate-limit just limit calls, how to limit max_count in a call for exemple ? | 13:22 |
sdague | as it would be likely to trigger type errors | 13:22 |
sdague | bauzas: that patch is correctly not caching the empty string, right? | 13:23 |
johnthetubaguy | pilgrimstack1: its not really part of Nova (we used to have a prototype, but it was a bit broken and never got fixed, as I understand it), I would ask on #openstack to see what tools others use to do that | 13:23 |
*** marzif has quit IRC | 13:23 | |
*** marzif_ has joined #openstack-nova | 13:23 | |
johnthetubaguy | pilgrimstack1: we do have quotas, but thats more about limiting the number of servers created, rather than ratelimiting | 13:24 |
*** Marga_ has quit IRC | 13:24 | |
*** Jeffrey4l has joined #openstack-nova | 13:24 | |
bauzas | sdague: nope | 13:24 |
bauzas | sdague: it caches None | 13:25 |
sdague | caching None seems wrong as well | 13:25 |
bauzas | sdague: https://review.openstack.org/#/c/172906/4/nova/availability_zones.py,cm | 13:25 |
pilgrimstack1 | johnthetubaguy: right, use case: As an operator, I want to provide big quota to my users but I want to protect my scheduler to become crazy with calls like max_count: 10000 | 13:25 |
*** marzif_ has quit IRC | 13:26 | |
bauzas | sdague: that's another changfe | 13:26 |
*** marzif_ has joined #openstack-nova | 13:26 | |
bauzas | sdague: lemme clarify | 13:26 |
johnthetubaguy | pilgrimstack1: you can use something like HA proxy to rate limit the API requests, the folks in #openstack are likely able to help you with that more, this is a developer focused rather than usage focused channel | 13:27 |
*** exploreshaifali has quit IRC | 13:27 | |
bauzas | sdague: since the cache is keyed by host names, it means that if one instance was having no host, it was returning the default AZ (and consequently overriding the cache value that default AZ) | 13:27 |
bauzas | sdague: which meant that if you were running two instances, one scheduled and one not, you were flapping between the default AZ and the actual AZ | 13:28 |
bauzas | sdague: hence my change in https://review.openstack.org/#/c/172906/4/nova/availability_zones.py,cm | 13:28 |
bauzas | sdague: because the AZ value for a cache should still be related to an host | 13:28 |
*** marzif has joined #openstack-nova | 13:29 | |
*** marzif_ has quit IRC | 13:29 | |
pilgrimstack1 | johnthetubaguy: ok, I asked on ops IRC and ML but no response, I'll try on #openstack and I probably generate a BP on Nova if nothing exist | 13:29 |
*** jlanoux_ has joined #openstack-nova | 13:29 | |
sdague | bauzas: so this is all done because - instance.get('availability_zone') is another db call ? | 13:29 |
pilgrimstack1 | johnthetubaguy: you tald "we used to have a prototype, but it was a bit broken and never got fixed", do you have the review or BP? | 13:30 |
johnthetubaguy | pilgrimstack1: things like reducing the number of greenlets on the scheduler, and using the caching scheduler are things you might want to try too, that should reduce the impact on your scheduler, but hopefully the ops folks can reach out with more specifics | 13:30 |
johnthetubaguy | pilgrimstack1: its the old rate limits code, its basically recommended that you configure a loadbalncer instead, as that will do a better job of ratelimitng across mutliple api nodes | 13:31 |
*** romainh has joined #openstack-nova | 13:31 | |
*** jlanoux has quit IRC | 13:32 | |
bauzas | sdague: well, no, it looks at the returned API resource | 13:33 |
sdague | I was talking about the cache | 13:33 |
bauzas | sdague: oh my bad | 13:33 |
sdague | so, availability_zone is defined on the instance model now | 13:34 |
bauzas | sdague: so, yeah | 13:34 |
bauzas | sdague: and defaulted to None | 13:34 |
sdague | so, can't we delete all this cache gymnastics then | 13:34 |
sdague | and translate None => '' API purposes | 13:34 |
*** chhavi has quit IRC | 13:35 | |
sdague | like, if I'm reading models.py correctly, we should be able to delete all the memcache code in availability_zones.py | 13:36 |
bauzas | sdague: that sounds a possible good approach | 13:36 |
bauzas | sdague: just trust the instance AZ and if None, then get the host AZ | 13:36 |
bauzas | forget the latter | 13:36 |
sdague | right | 13:36 |
bauzas | just trust the instance AZ | 13:36 |
*** Marga_ has joined #openstack-nova | 13:37 | |
sdague | that seems massively simpler | 13:37 |
bauzas | right | 13:37 |
*** Marga_ has quit IRC | 13:37 | |
sdague | there is a lot of gorp in here that I think it all irrelevant now | 13:37 |
bauzas | totally agreeing on that | 13:37 |
sdague | though jaypipes might know more about it's legacy | 13:37 |
bauzas | the AZ code is just gorp | 13:37 |
sdague | right, but in this case, it actually looks like it's all noop gorp | 13:37 |
*** Marga_ has joined #openstack-nova | 13:37 | |
bauzas | sdague: jaypipes and I are violently agreeing it's gorp :) | 13:37 |
sdague | ok, does he agree we can delete this whole cache layer because it's no longer doing anything | 13:38 |
bauzas | but I can defer to jay, for sure | 13:38 |
bauzas | sdague: I can wait for him :) | 13:38 |
sdague | ok | 13:38 |
bauzas | jaypipes: around ? | 13:38 |
sdague | anyway, so in summary | 13:38 |
sdague | returning AZ as '' for the API should be fine in the window before it's scheduled | 13:39 |
bauzas | yep | 13:39 |
sdague | deleting the entire caching layer for AZ looks like a thing we should do, because it's not clear what it's done | 13:39 |
sdague | doing | 13:39 |
bauzas | sdague: I'm just verifying when the instance model is updated with its correct AZ | 13:39 |
sdague | bauzas: great | 13:39 |
*** kiran-r has quit IRC | 13:40 | |
bauzas | meh, that's with the options ?! | 13:40 |
bauzas | so, before the scheduler is called ? | 13:40 |
bauzas | wtf | 13:40 |
sdague | bauzas: sounds like you found some more awesome :) | 13:41 |
bauzas | sdague: oh I think I understood why this hack | 13:41 |
bauzas | sdague: so, inst.AZ is just the semantics for saying what the user wants (using the --az hint) | 13:41 |
bauzas | sdague: never changed | 13:42 |
sdague | oh ok | 13:42 |
bauzas | sdague: so, that's why we hook at the host | 13:42 |
bauzas | in the AZ helper | 13:42 |
bauzas | sdague: that said, I feel we can still remove the cache | 13:43 |
sdague | ok, so could you also patch the models.py to add that comment about what that field is there for? | 13:44 |
bauzas | sdague: sure I can | 13:44 |
sdague | that seems like something better in a comment then having to read a bunch of other code | 13:44 |
bauzas | sdague: a separate change | 13:44 |
sdague | bauzas: yes, a separate change | 13:44 |
sdague | bauzas: what API calls get this for an instance? | 13:45 |
bauzas | sdague: https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/extended_availability_zone.py#L30 | 13:45 |
*** VW_ has joined #openstack-nova | 13:46 | |
bauzas | sdague: I had an internal old bug about that, lemme see if it's public | 13:46 |
bauzas | sdague: it makes Horizon flapping AZs | 13:46 |
sdague | so that's exposing on all detailed status calls? | 13:47 |
openstackgerrit | Rajesh Tailor proposed openstack/nova: Fix order of arguments in assertEqual https://review.openstack.org/221304 | 13:47 |
bauzas | sdague: https://bugzilla.redhat.com/show_bug.cgi?id=1170242 | 13:48 |
openstack | bugzilla.redhat.com bug 1170242 in openstack-nova "Inconsistent info of availability zone (az) if the default az is replaced" [Medium,Closed: errata] - Assigned to sbauza | 13:48 |
*** takedakn has joined #openstack-nova | 13:49 | |
bauzas | sdague: which is duplicate of https://bugs.launchpad.net/nova/+bug/1390033 | 13:49 |
openstack | Launchpad bug 1390033 in OpenStack Compute (nova) "Inconsistent info of availability zone (az) if the default az is replaced" [Low,In progress] - Assigned to Alexis Lee (alexisl) | 13:49 |
*** mwagner_lap has joined #openstack-nova | 13:49 | |
sdague | well, I think the None change is fine. And the real question is how much is the cache really helping vs. getting in the way. It seems like a premature optimization. | 13:49 |
bauzas | sdague: exactly | 13:50 |
sdague | and if that info is really needed on the instance regularly, we should denormalize it and stick it on the instance. | 13:50 |
bauzas | sdague: I'll wait for jaypipes's thoughts on that | 13:50 |
jaypipes | bauzas, sdague: yes, the caching layer should be ripped out, IMHO. | 13:50 |
*** ctrath has joined #openstack-nova | 13:51 | |
sdague | yeh, let's wait for jaypipes, and once your respin your patch I'm conceptually +2, just need to look at details | 13:51 |
sdague | jaypipes: oh, there you are :) | 13:51 |
bauzas | jaypipes: that's my thoughts too | 13:51 |
*** chhavi has joined #openstack-nova | 13:51 | |
*** burt has joined #openstack-nova | 13:51 | |
*** otter768 has joined #openstack-nova | 13:51 | |
bauzas | jaypipes: it introduces more problems than it solves | 13:51 |
sdague | yeh | 13:51 |
sdague | bauzas: ok, so I think we're agreed, typey typey | 13:51 |
bauzas | sdague: zactly | 13:51 |
bauzas | codey codey | 13:52 |
*** kolesovdv has quit IRC | 13:52 | |
bauzas | sdague: jaypipes: thanks | 13:54 |
*** otter768 has quit IRC | 13:56 | |
*** r-daneel has joined #openstack-nova | 13:57 | |
danpb | dansmith: fancy blessing these 2 now your object stuff is merged https://review.openstack.org/#/c/189323/ https://review.openstack.org/#/c/189362/ | 13:58 |
dansmith | danpb: yep, sorry | 13:58 |
*** tojuvone has quit IRC | 13:58 | |
*** jcoufal has quit IRC | 14:00 | |
*** amotoki has joined #openstack-nova | 14:00 | |
*** emagana has joined #openstack-nova | 14:00 | |
*** haomaiwang has quit IRC | 14:01 | |
danpb | dansmith: np, thanks | 14:01 |
*** haomaiwang has joined #openstack-nova | 14:01 | |
*** jistr is now known as jistr|call | 14:01 | |
*** ctrath has quit IRC | 14:02 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova: WIP: Use legacy engineFacade from oslo_db.enginefacade https://review.openstack.org/221310 | 14:02 |
*** Marga_ has quit IRC | 14:03 | |
openstackgerrit | Steven Kaufer proposed openstack/nova: Sorting and pagination params used as filters https://review.openstack.org/147298 | 14:03 |
*** marzif_ has joined #openstack-nova | 14:03 | |
*** marzif has quit IRC | 14:03 | |
*** eharney has joined #openstack-nova | 14:04 | |
*** cfriesen has joined #openstack-nova | 14:05 | |
dansmith | sdague: so question | 14:07 |
dansmith | sdague: when we move to multinode grenade for the partial job, would it be feasible to have three nodes, one on stable, one on master, one on proposed? | 14:07 |
*** ctrath has joined #openstack-nova | 14:07 | |
dansmith | I know that means three nodes instead of two, but that would be really awesome from a coverage perspective | 14:07 |
dansmith | we had a breakage in kilo that we didn't realize until we started on L and got kilo in the grenade job, and being able to test against master would have helped us find that earlier | 14:08 |
*** scheuran has joined #openstack-nova | 14:09 | |
*** scheuran has quit IRC | 14:10 | |
*** marzif_ has quit IRC | 14:11 | |
*** marzif has joined #openstack-nova | 14:11 | |
*** mriedem has joined #openstack-nova | 14:12 | |
*** dguitarbite has quit IRC | 14:12 | |
*** Marga_ has joined #openstack-nova | 14:13 | |
*** mmedvede has joined #openstack-nova | 14:14 | |
*** irenab has quit IRC | 14:15 | |
openstackgerrit | Paul Carlton proposed openstack/nova: Mask the token used to allow access to vnc console https://review.openstack.org/220622 | 14:15 |
*** diana_clarke has joined #openstack-nova | 14:15 | |
*** irenab has joined #openstack-nova | 14:16 | |
*** Marga_ has quit IRC | 14:17 | |
sdague | dansmith: I don't know how much more effort 3 would take from an infra perspective | 14:18 |
dansmith | sdague: infra meaning getting nodepool to carve off a few instead of a pair? | 14:19 |
sdague | yep | 14:19 |
dansmith | it would surely be least expensive to do three nodes in one job vs. two partial jobs for master and stable I think | 14:19 |
*** jistr|call is now known as jistr | 14:20 | |
*** burgerk has joined #openstack-nova | 14:20 | |
sdague | ok, so lets plan to have a longer test plan conversation later on this, because I think we need to figure out what the right overall set of nova jobs is at this point. | 14:21 |
*** yamahata has joined #openstack-nova | 14:21 | |
*** smatzek has joined #openstack-nova | 14:22 | |
dansmith | sure | 14:22 |
dansmith | presumably we're going to drop the testing of two API paths, which frees up a little more resource | 14:22 |
dansmith | I also wonder if there's really value in running the non-partial grenade job | 14:23 |
*** dustins has quit IRC | 14:25 | |
*** smatzek_ has joined #openstack-nova | 14:26 | |
*** zhangjn has joined #openstack-nova | 14:26 | |
*** zhangjn has quit IRC | 14:26 | |
*** dims_ has quit IRC | 14:26 | |
*** dimsum__ has joined #openstack-nova | 14:27 | |
*** bkopilov has joined #openstack-nova | 14:27 | |
*** baoli has quit IRC | 14:29 | |
*** smatzek has quit IRC | 14:29 | |
*** electrocucaracha has joined #openstack-nova | 14:29 | |
*** baoli_ has joined #openstack-nova | 14:30 | |
*** rotbeard has joined #openstack-nova | 14:30 | |
*** irenab has quit IRC | 14:31 | |
*** irenab has joined #openstack-nova | 14:32 | |
*** vishwanathj has joined #openstack-nova | 14:32 | |
*** Murali has quit IRC | 14:32 | |
*** unicell has joined #openstack-nova | 14:33 | |
*** alexschm has quit IRC | 14:33 | |
*** unicell1 has quit IRC | 14:33 | |
*** gszasz_ has joined #openstack-nova | 14:34 | |
*** gszasz has quit IRC | 14:34 | |
*** raildo is now known as raildo-afk | 14:34 | |
*** ed__ has joined #openstack-nova | 14:34 | |
*** ed__ is now known as edleafe | 14:35 | |
sdague | well, that's the only thing that tests that nova-compute can restart and not shut down all the guests when it's offline | 14:35 |
sdague | which, it used to do | 14:35 |
*** irenab has quit IRC | 14:35 | |
sdague | though, I guess if we force landing some resources on each node, we might be ok | 14:36 |
openstackgerrit | LinZhang proposed openstack/nova: Now, More and more enterprises use OpenStack as Desktop Virtualization Platform, it need improving remote display performance and playing music/sound files. https://review.openstack.org/221326 | 14:36 |
*** irenab has joined #openstack-nova | 14:36 | |
*** raildo-afk is now known as raildo | 14:37 | |
*** zhangjn has joined #openstack-nova | 14:37 | |
*** jcoufal has joined #openstack-nova | 14:37 | |
*** hparekh has quit IRC | 14:37 | |
*** vivekd has quit IRC | 14:37 | |
*** teju has joined #openstack-nova | 14:38 | |
edleafe | String freeze question: on https://review.openstack.org/#/c/214311/6/nova/api/openstack/__init__.py,cm L340 there is an old reference to 'V3' in a LOG.info string. Should I update that? | 14:38 |
*** Marga_ has joined #openstack-nova | 14:38 | |
*** Marga_ has quit IRC | 14:38 | |
*** Marga_ has joined #openstack-nova | 14:38 | |
*** zhangjn has quit IRC | 14:39 | |
*** takedakn has quit IRC | 14:39 | |
*** Marga_ has quit IRC | 14:39 | |
johnthetubaguy | been chatting through string freeze with Daisy in #openstack-l18n, do people like the idea of this new plan for string freeze: https://wiki.openstack.org/wiki/Nova/Liberty_Release_Schedule#String_Freeze | 14:40 |
johnthetubaguy | sdague: you might have a better memory than me about what we have done before, but does the above make sense to you? | 14:40 |
*** obedmr has joined #openstack-nova | 14:41 | |
*** Marga_ has joined #openstack-nova | 14:42 | |
*** clarkb has quit IRC | 14:42 | |
mriedem | edleafe: hmm, that is a translated string | 14:42 |
sdague | johnthetubaguy: that seems fine | 14:42 |
*** tpeoples has joined #openstack-nova | 14:43 | |
bauzas | question to all, I thought that tearDown was removed from all the unittests in favor of addCleanup but I saw https://github.com/openstack/nova/blob/master/nova/tests/unit/test_availability_zones.py#L48 | 14:43 |
sdague | is there some commit message we should specify if we need to break any of the freezes to make it easier to see, or are they able to catch all those with tooling | 14:43 |
bauzas | is there any consensus on removing that ? | 14:43 |
*** clarkb has joined #openstack-nova | 14:44 | |
johnthetubaguy | sdague: I got the impression their tooling will just catch it OK, DocImpact is still the same I guess, just adding that in | 14:44 |
sdague | johnthetubaguy: I thought DocImpact went to the docs team tracker | 14:44 |
sdague | so not the right place | 14:44 |
mriedem | edleafe: given the guidelines in the wiki, it seems updating the message on L340 would be ok | 14:44 |
mriedem | "Add a translatable string identical to an existing message that is already marked for translation and has the same meaning and context. The available translation will be re-used automatically." | 14:44 |
johnthetubaguy | sdague: yeah, it does, its just for string freeze that impact docs, they should get tracked that way | 14:45 |
sdague | bauzas: yes, addCleanup is better | 14:45 |
johnthetubaguy | mriedem: yeah, that too | 14:45 |
bauzas | sdague: okay, but any rule related to that ? just like mox vs. mock ? | 14:45 |
*** tjones has joined #openstack-nova | 14:45 | |
sdague | mostly, teardown only runs if your test passes | 14:45 |
sdague | addCleanup runs whether or not the test passes | 14:46 |
bauzas | sdague: yeah I know that, just wondering whether it was a miss or not | 14:47 |
bauzas | sdague: but looking at the other tests, it seems it's yet more common than I thought | 14:47 |
sdague | there was not giant set of fixups | 14:47 |
sdague | it's a thing that gets changed when you are near the code if you remember | 14:48 |
edleafe | mriedem: thanks | 14:48 |
johnthetubaguy | mriedem: trying to negotiate relaxing the string freeze a little, does this make sense as a proposal? https://wiki.openstack.org/wiki/Nova/Liberty_Release_Schedule#String_Freeze | 14:48 |
* johnthetubaguy open to all comments on the above | 14:49 | |
*** rfolco has quit IRC | 14:49 | |
mriedem | johnthetubaguy: will review after the call i'm on ends | 14:49 |
jwcroppe | jaypipes: morning, you around? | 14:51 |
openstackgerrit | Ed Leafe proposed openstack/nova: Remove 'v3' from extension code https://review.openstack.org/214311 | 14:51 |
openstackgerrit | Ed Leafe proposed openstack/nova: Remove more 'v3' references from the code https://review.openstack.org/214290 | 14:51 |
*** Chandan_p has quit IRC | 14:51 | |
*** david-ly_ is now known as david-lyle | 14:53 | |
jaypipes | jwcroppe: I'm in meeting hell for two hours. :( | 14:53 |
jwcroppe | jaypipes: no problem - know how that goes. Fixed another metrics thing when you get a moment - https://review.openstack.org/#/c/219153/ | 14:54 |
*** ctrath has quit IRC | 14:54 | |
*** dustins has joined #openstack-nova | 14:54 | |
*** tsekiyama has joined #openstack-nova | 14:55 | |
openstackgerrit | Paul Carlton proposed openstack/nova: Mask the token used to allow access to vnc console https://review.openstack.org/220622 | 14:55 |
*** ctrath has joined #openstack-nova | 14:55 | |
*** ctrath has quit IRC | 14:57 | |
*** dustins has quit IRC | 14:57 | |
*** zzzeek has joined #openstack-nova | 14:57 | |
*** cbits has joined #openstack-nova | 14:58 | |
*** angdraug has joined #openstack-nova | 14:58 | |
*** obondarev has quit IRC | 14:59 | |
mriedem | johnthetubaguy: i dont really have any issues with https://wiki.openstack.org/wiki/Nova/Liberty_Release_Schedule#String_Freeze | 15:00 |
*** fifieldt has quit IRC | 15:00 | |
mriedem | johnthetubaguy: except that it doesn't seem like a change from the original wiki, except for the POV parts | 15:00 |
*** ctrath has joined #openstack-nova | 15:00 | |
*** apuimedo_ has quit IRC | 15:00 | |
*** garyk1 has joined #openstack-nova | 15:01 | |
*** haomaiwang has quit IRC | 15:01 | |
*** haomaiwang has joined #openstack-nova | 15:01 | |
*** haomaiwang has quit IRC | 15:01 | |
*** garyk has quit IRC | 15:02 | |
*** dustins has joined #openstack-nova | 15:02 | |
*** cbits has left #openstack-nova | 15:03 | |
*** tri2sing has joined #openstack-nova | 15:03 | |
*** tjones has quit IRC | 15:04 | |
*** rfolco has joined #openstack-nova | 15:04 | |
johnthetubaguy | mriedem: well we had been pushing back on logs being added, due to the freeze, at least in some cases | 15:05 |
*** gszasz_ has quit IRC | 15:05 | |
johnthetubaguy | mriedem: wanted to clarify we can still add strings for logs | 15:05 |
mriedem | johnthetubaguy: the string freeze wiki says don't add new translated log messages | 15:06 |
mriedem | oh, hrm | 15:06 |
mriedem | i guess i missed that point then | 15:07 |
johnthetubaguy | mriedem: yeah, adding a little bit | 15:07 |
johnthetubaguy | mriedem: turns out we don't really need to do that for the full time | 15:07 |
johnthetubaguy | mriedem: basically if we think untranslated is better than not changing it, then its cool until we that drop dead date (RC1) | 15:08 |
*** teju has quit IRC | 15:08 | |
johnthetubaguy | mriedem: just working on getting agreement for that plan, its basically their suggestion | 15:08 |
*** andrearosa has quit IRC | 15:10 | |
*** Piet has joined #openstack-nova | 15:10 | |
johnthetubaguy | mriedem: it doesn't seem like they translate all our our strings anyways, so seems like a better trade off to let those in | 15:12 |
mriedem | i agree that untranslated is better than wrong | 15:13 |
mriedem | until rc1 | 15:13 |
mriedem | and yeah, not all languages are translated anyway | 15:13 |
mriedem | i thought if like <10% of the catalog was translated they just drop that language | 15:13 |
*** ijw_ has joined #openstack-nova | 15:14 | |
*** changbl has joined #openstack-nova | 15:14 | |
mriedem | so if you're trying to deploy openstack and you only speak Mapia, sorry | 15:14 |
*** andrearosa has joined #openstack-nova | 15:14 | |
*** ijw_ has quit IRC | 15:15 | |
*** gszasz_ has joined #openstack-nova | 15:18 | |
johnthetubaguy | mriedem: yeah, thats true I think | 15:18 |
*** salv-orlando has quit IRC | 15:20 | |
*** hparekh has joined #openstack-nova | 15:21 | |
*** mvandijk has joined #openstack-nova | 15:22 | |
*** rushil has joined #openstack-nova | 15:23 | |
*** mvandijk has left #openstack-nova | 15:24 | |
*** yamahata has quit IRC | 15:24 | |
*** dims_ has joined #openstack-nova | 15:25 | |
*** hparekh has quit IRC | 15:25 | |
*** gszasz_ has quit IRC | 15:25 | |
*** yamahata has joined #openstack-nova | 15:26 | |
*** garyk has joined #openstack-nova | 15:26 | |
*** garyk1 has quit IRC | 15:27 | |
*** afazekas_ has quit IRC | 15:28 | |
*** bradjones has joined #openstack-nova | 15:28 | |
*** bradjones has quit IRC | 15:28 | |
*** bradjones has joined #openstack-nova | 15:28 | |
*** dimsum__ has quit IRC | 15:29 | |
*** electrocucaracha has quit IRC | 15:29 | |
claudiub | johnthetubaguy: hi. I don't quite remember and the midcycle etherpad doesn't help, but were there any discussions related to exposing to the scheduler host capabilities / features, in order to ensure proper scheduling of instances that require certain features? | 15:30 |
*** salv-orlando has joined #openstack-nova | 15:30 | |
johnthetubaguy | claudiub: you beyond what you can do today with host aggregates and flavor extra specs, etc? | 15:30 |
claudiub | johnthetubaguy: yeah | 15:31 |
*** electrocucaracha has joined #openstack-nova | 15:31 | |
johnthetubaguy | claudiub: we spoke about the ideas around something to replace flavor extra_specs and things, but not seen a full vision on that yet | 15:32 |
johnthetubaguy | claudiub: whats the specific use case you are thinking about? | 15:33 |
*** baoli_ has quit IRC | 15:33 | |
*** baoli has joined #openstack-nova | 15:34 | |
claudiub | johnthetubaguy: well, that's on the request side of things. It seems recently I keep hitting some problems regarding our newer features. So, what I would like, is being able to just specify in the image_meta or flavor extra specs or whatever that I would want instances with: generation 2 vm, os_secure_boot enabled, os_vtpm enabled etc. etc. | 15:35 |
*** thorst has quit IRC | 15:35 | |
*** inara has quit IRC | 15:35 | |
claudiub | johnthetubaguy: the thing is, it is hard to find a proper host that satisfy a request like this, because the scheduler is not aware of any of the hosts' capabilities | 15:36 |
claudiub | johnthetubaguy: so, it can lead to plenty of failures, until it finds a proper host | 15:36 |
*** salv-orlando has quit IRC | 15:36 | |
claudiub | johnthetubaguy: a solution would be to force a hypervisor_version in the image meta, but it's been said again and again that we shouldn't use that for something like this. | 15:37 |
claudiub | johnthetubaguy: or force hosts, which doesn't help in case of cold migrations / resizes, where you are at the mercy of the scheduling gods. :) | 15:37 |
*** irenab has quit IRC | 15:38 | |
*** irenab has joined #openstack-nova | 15:39 | |
*** inara has joined #openstack-nova | 15:41 | |
*** garyk has quit IRC | 15:42 | |
*** devlaps has joined #openstack-nova | 15:43 | |
johnthetubaguy | claudiub: sorry, I just jumped on a call, I will have to get back to you | 15:43 |
mriedem | doffm_: what was the novaclient bug number again for the i18n stuff? | 15:45 |
*** edtubill has joined #openstack-nova | 15:45 | |
doffm_ | mriedem: https://bugs.launchpad.net/python-novaclient/+bug/1492444 | 15:45 |
openstack | Launchpad bug 1492444 in python-novaclient "There is no working i18n for novaclient." [Low,Confirmed] - Assigned to Mark Doffman (mjdoffma) | 15:45 |
openstackgerrit | Jean-Daniel Bonnetot proposed openstack/nova-specs: Rate-limits can limit API calls, but on POST */servers, there is a possibility to specify max_count and ask large number of instances in a very short time. As operator, I want to rate-limit the real instance creation, not only the API calls. https://review.openstack.org/221375 | 15:46 |
openstackgerrit | Vladyslav Drok proposed openstack/nova: DO NOT MERGE - Triggering experimental pipeline https://review.openstack.org/220229 | 15:46 |
*** doffm_ is now known as doffm | 15:46 | |
*** mdrabe has quit IRC | 15:48 | |
openstackgerrit | Jean-Daniel Bonnetot proposed openstack/nova-specs: Limit the number of instances that a user can spawn in a time window https://review.openstack.org/221375 | 15:48 |
*** andrey-mp has joined #openstack-nova | 15:51 | |
johnthetubaguy | claudiub: reading your messages now | 15:51 |
*** yassine__ has quit IRC | 15:51 | |
johnthetubaguy | claudiub: is this a host version issue? | 15:51 |
johnthetubaguy | claudiub: we do have a filter for that I thought, let me dig one sec | 15:52 |
andrey-mp | mriedem: please read bug https://bugs.launchpad.net/nova/+bug/1489581 could you comment it? | 15:52 |
openstack | Launchpad bug 1489581 in OpenStack Compute (nova) "test_create_ebs_image_and_check_boot is race failing" [Critical,Triaged] | 15:52 |
*** otter768 has joined #openstack-nova | 15:52 | |
*** matrohon has quit IRC | 15:52 | |
*** karimb has quit IRC | 15:52 | |
johnthetubaguy | claudiub: something like this one? https://github.com/openstack/nova/blob/master/nova/scheduler/filters/image_props_filter.py#L76 | 15:53 |
claudiub | johnthetubaguy: that filter will only check the hypervisor_version_requires, hypervisor_type, vm_mode and architecture image properties. | 15:54 |
johnthetubaguy | claudiub: I was thinking the hypervisor version would do the trick for your case? I guess not? | 15:54 |
*** romainh has left #openstack-nova | 15:55 | |
claudiub | johnthetubaguy: not for all cases, unfortunately. That's what we use at the moment, but it's not enough | 15:55 |
*** VikasC has joined #openstack-nova | 15:56 | |
johnthetubaguy | claudiub: where does that break down? I am miss-understanding the context here | 15:56 |
danpb | johnthetubaguy: so currently you can have certain features that require a min version of a hypervisor to work | 15:56 |
johnthetubaguy | oh, I suppose secure boot needs to be configured on some subset of hosts, or something like that? | 15:56 |
danpb | the only way to deal with that is for cloud admins to set up filters matching on versions, which sucks | 15:57 |
*** otter768 has quit IRC | 15:57 | |
claudiub | johnthetubaguy: for example, for the vTPM feature we have, it is not enough to just use the hypervisor_version_requires. there might be the possibility for that feature to not be enabled on some hosts, or not setup properly and the feature to not work properly | 15:57 |
danpb | because the admin shouldn't need to know about what version nova is expecting for a certain feature | 15:57 |
*** rushil has quit IRC | 15:57 | |
*** hemna_ is now known as hemna | 15:57 | |
claudiub | johnthetubaguy: scheduler should avoid such hosts. | 15:57 |
danpb | we'd really need for Nova compute to be able to report what features it supports | 15:57 |
johnthetubaguy | danpb: no, certain images require a specific version due to driver issues | 15:58 |
danpb | so the schedular can do feature matches directly, instead of version matches | 15:58 |
johnthetubaguy | danpb: agreed, in the general case | 15:58 |
claudiub | danpb: agreed | 15:58 |
*** r-daneel has quit IRC | 15:58 | |
danpb | eg, an image which requires the vTPM feature, can be tagged 'vtpm' not 'version 3.2.1' | 15:58 |
johnthetubaguy | danpb: yep it totally should | 15:58 |
danpb | there may be some cases where doing version comparisons in the schedular is useful, but IMHO it is probably a minority of cases | 15:58 |
johnthetubaguy | danpb: agreed | 15:59 |
claudiub | johnthetubaguy: plus, windows 10, which can have hyper-v enabled, has hypervisor_version 10.0, but does not have the vTPM feature. | 15:59 |
johnthetubaguy | danpb: was just trying to establish the specific case | 15:59 |
danpb | we have a similar scenario with migration | 15:59 |
danpb | where you can only migrate between certain versions of QEMU | 15:59 |
danpb | so it'd be really nice if we could express this to avoid the schedular trying to place the guest on a host it can';t migrate to | 16:00 |
*** Marga_ has quit IRC | 16:00 | |
danpb | currently you'd have to manually partitition up all your hosts in host aggregates | 16:00 |
danpb | which becomes a rather tedious exercise | 16:00 |
*** tsekiyama has quit IRC | 16:00 | |
*** amrith has joined #openstack-nova | 16:01 | |
johnthetubaguy | yeah, I much prefer the idea of stuff just working properly out the box for these situations | 16:01 |
johnthetubaguy | although need to be sure to expose the limitations to the admin too (thats just a set of APIs thats needed) | 16:01 |
*** andrey-mp has quit IRC | 16:01 | |
bauzas | jaypipes: sdague: able to restore https://review.openstack.org/#/c/149562/ ? | 16:02 |
bauzas | jaypipes: sdague: since it was abandoned, I don't want to steal it with a new change but I can't push a new version | 16:02 |
bauzas | jaypipes: sdague: as cores, you should be able to do so | 16:02 |
sdague | bauzas: restored | 16:02 |
sdague | have at | 16:02 |
bauzas | sdague: coolness | 16:02 |
amrith | greetings folks | 16:03 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Consolidate code to get the correct availability zone of an instance https://review.openstack.org/149562 | 16:03 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Add some explanation for the instance AZ field https://review.openstack.org/221383 | 16:03 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Remove cache from the AZ helper https://review.openstack.org/221384 | 16:03 |
amrith | we are seeing some new failures in trove that seem to be bubbling up from Nova | 16:03 |
amrith | Here's an error message | 16:03 |
amrith | 2015-09-08 14:30:18.540 10512 ERROR trove.taskmanager.models [-] Invalid input for field/attribute 0. Value: {u'boot_index': 0, u'uuid': u'a3586599-6b4a-4a67-af1a-dd63488de46c', u'source_type': u'', u'device_name': u'vdb', u'volume_size': u'1', u'volume_id': u'a3586599-6b4a-4a67-af1a-dd63488de46c', u'delete_on_termination': u'1'}. Additional properties are not allowed (u'source_type', u'boot_index', u'uuid' were | 16:03 |
amrith | unexpected) (HTTP 400) (Request-ID: req-f86f4db0-440c-4f67-9b1e-5db3606e38c4) | 16:03 |
amrith | take a look at http://logs.openstack.org/72/219972/1/check/gate-trove-functional-dsvm-mysql/65f8e2b/logs/screen-tr-tmgr.txt.gz#_2015-09-08_14_30_18_540 | 16:03 |
*** shoutm has joined #openstack-nova | 16:03 | |
*** promulo__ has quit IRC | 16:03 | |
*** mdrabe has joined #openstack-nova | 16:03 | |
bauzas | sdague: jaypipes: FYI, see above for https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:az_fix,n,z | 16:03 |
amrith | Would someone on the nova team suggest what we're supposed to do as this is currently causing our gate to fail. | 16:04 |
claudiub | johnthetubaguy: danpb: anyways, is there any work being done or someone's working on that? blueprint? spec? | 16:04 |
johnthetubaguy | claudiub: danpb: I have not heard of anything been actively done on this right now | 16:04 |
*** annegentle has joined #openstack-nova | 16:05 | |
danpb | i've not heard of anyone looking at it either | 16:05 |
johnthetubaguy | claudiub: I had started a write up of the flavor issues that started to touch on this: https://review.openstack.org/#/c/178628/ | 16:05 |
johnthetubaguy | bauzas: I just remembered, I have this patch that may or may not be interesting: https://review.openstack.org/#/c/178635/5 | 16:06 |
johnthetubaguy | claudiub: it would be great if we can try and categories all the use cases at work here, so we can work out a better way forward | 16:06 |
*** irenab has quit IRC | 16:06 | |
*** Apoorva has joined #openstack-nova | 16:06 | |
bauzas | johnthetubaguy: heh, that's not like if I was following that change :p | 16:07 |
bauzas | johnthetubaguy: but yeah, good point, totally forgot it | 16:07 |
*** irenab has joined #openstack-nova | 16:07 | |
johnthetubaguy | bauzas: its on my big list of TODOs, just its quite low down | 16:07 |
*** pixelbeat has quit IRC | 16:07 | |
claudiub | johnthetubaguy: we can at least start with a blueprint and WIP spec, right? Until we have all the usecases defined. | 16:07 |
johnthetubaguy | claudiub: totally worth a go | 16:08 |
*** mvandijk has joined #openstack-nova | 16:08 | |
*** zhenguo has quit IRC | 16:08 | |
claudiub | johnthetubaguy: cool. | 16:08 |
amrith | is the issue we're seeing in trove related to the nova client 2.28.1 change? | 16:08 |
johnthetubaguy | claudiub: honestly, we keep hacking bit on the side, so I would love some kind of unified view, soon ish, that discussion really helped clear out a few things in my mind | 16:08 |
amrith | ^^ anyone ^^ | 16:08 |
johnthetubaguy | claudiub: I think getting a spec up for that specific case should really help though | 16:08 |
bauzas | johnthetubaguy: well, I actually remembered https://etherpad.openstack.org/p/YVR-nova-error-handling before writing the tasks manifesto, but I guess your devref change is related to that :) | 16:09 |
andreykurilin | Hi everyone! It looks like "create an image and boot a server from it" in Nova V2.1 is not fully backward-compatible. Can anyone confirm that commands, which I try is correct? | 16:09 |
bauzas | alaski: around ? | 16:09 |
bauzas | alaski: FWIW, I'd be interested in getting some feedback for https://review.openstack.org/#/c/221280/ | 16:09 |
andreykurilin | http://paste.openstack.org/show/450439/ which is based on http://docs.rackspace.com/servers/api/v2/cs-devguide/content/create_volume_from_image_and_boot.html | 16:09 |
andreykurilin | sdague: ^ | 16:09 |
johnthetubaguy | amrith: that trove issue seems similar to some of the stuff sdague is looking into around the API | 16:09 |
alaski | bauzas: yep | 16:09 |
claudiub | johnthetubaguy: sure, I can start writing a spec for that this week. We could discuss this further there. | 16:10 |
johnthetubaguy | claudiub: sounds good | 16:10 |
*** yamahata has quit IRC | 16:10 | |
alaski | bauzas: it's in the queue, not quite to it yet | 16:10 |
bauzas | alaski: no worries, just wanted to make sure you were in the loop | 16:10 |
bauzas | alaski: honestly, I put that as an initial version for opening up some effort | 16:10 |
amrith | johnthetubaguy, thanks, am also reading similar comments from andreykurilin | 16:10 |
amrith | just now | 16:10 |
*** ijw_ has joined #openstack-nova | 16:10 | |
*** artom has quit IRC | 16:10 | |
bauzas | alaski: and getting feedback | 16:11 |
alaski | bauzas: appreciate it | 16:11 |
alaski | bauzas: I'm keen to go through it | 16:11 |
bauzas | alaski: because it's like chicken-and-egg, and I want to write down our rationale | 16:11 |
amrith | andreykurilin, the error you are seeing is identical to what trove is seeing in gate. | 16:11 |
johnthetubaguy | amrith: we switched the API under the hood to new code, in theory it should be identical, but its not quite, it seems | 16:11 |
*** jistr has quit IRC | 16:11 | |
andreykurilin | amrith: also, rally gates affected too | 16:11 |
bauzas | alaski: whether we need a new Tasks object or we can leave with an InstanceActions object is actually something I really wonder | 16:12 |
amrith | johnthetubaguy, andreykurilin thanks. We'll hold of rechecks on trove till we can get this fixed. | 16:12 |
*** abramley has joined #openstack-nova | 16:12 | |
alaski | bauzas: I think there are good reasons to not re-use InstanceActions, I can comment on the review | 16:12 |
*** unicell has quit IRC | 16:12 | |
bauzas | alaski: comments welcome | 16:12 |
*** shoutm has quit IRC | 16:13 | |
johnthetubaguy | amrith: actually, thinking about it, its more than that, I think it could be changes to switch the gate from v2.0 to v2.1 by default, (in the service catalog), it probably means its actually an invalid request to the v2.1 API (we make sure there are not extra attributes in there) | 16:13 |
bauzas | alaski: I just want to avoid http://www.liaison.com/wp-content/uploads/2015/02/solution-images__xkcd-blog-cartoon.png | 16:14 |
amrith | johnthetubaguy, there are no extra attributes in the request being sent by trove | 16:14 |
alaski | bauzas: agreed :) | 16:14 |
alaski | bauzas: I think there's a constraint on instanceactions that keeps it from being useful here | 16:15 |
amrith | consistent with andreykurilin's illustration. | 16:15 |
johnthetubaguy | amrith: it seems like source_type boot_index and uuid not allowed for that API request | 16:15 |
amrith | johnthetubaguy, we don't put those in the request | 16:15 |
alaski | bauzas: but I'll look at it again and see | 16:15 |
bauzas | alaski: yeah, hence your comments welcome | 16:15 |
amrith | see andreykurilin's simpler illustration | 16:15 |
amrith | at http://paste.openstack.org/show/450439/ | 16:15 |
johnthetubaguy | amrith: oh wait, I think I know what this is now | 16:15 |
andreykurilin | johnthetubaguy: it can be added by novaclient | 16:15 |
*** ijw_ has quit IRC | 16:15 | |
*** jlanoux_ has quit IRC | 16:16 | |
*** yamahata has joined #openstack-nova | 16:16 | |
amrith | andreykurilin, it must be; it ain't in the request produced by Trove, it is when it makes it to Nova (server). Someone in the middle is adding it. | 16:16 |
johnthetubaguy | amrith: I suspect it could be related to this bug horizon spotted with python-novaclient: https://review.openstack.org/#/c/221222/ | 16:16 |
amrith | is a solution therefore that Trove specify a version (let me see if we can even do that) | 16:17 |
*** rdopiera has quit IRC | 16:17 | |
johnthetubaguy | amrith: oh wait, maybe thats another issue... just saw your paste with the CLI failing | 16:17 |
andreykurilin | johnthetubaguy: https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L499-L512 | 16:17 |
amrith | johnthetubaguy, to give credit where it is due, the paste is andreykurilin's ;) | 16:18 |
*** garyk has joined #openstack-nova | 16:18 | |
*** moshele has quit IRC | 16:18 | |
*** alex_klimov has quit IRC | 16:18 | |
amrith | abramley pointed me to https://github.com/openstack/nova/commit/a9090bb5f50310702408aee340af9d4dad9474cf and https://review.openstack.org/#/c/165932/ | 16:18 |
johnthetubaguy | amrith: my bad | 16:19 |
bauzas | alaski: I know you're a busy man, but that is also worth of interest https://review.openstack.org/#/c/220666/ in particular given http://logs.openstack.org/66/220666/1/check/gate-tempest-dsvm-cells/91e55b8/logs/screen-n-cell-region.txt.gz?level=TRACE#_2015-09-04_21_37_41_728 | 16:20 |
johnthetubaguy | amrith: afraid I have to run off for a few hours, but hopefully the other folks still around can help with that | 16:21 |
amrith | andreykurilin are you logging this in LP? | 16:21 |
amrith | johnthetubaguy thanks much | 16:21 |
alaski | bauzas: okay | 16:22 |
andreykurilin | amrith: not yet:) wait a moment | 16:22 |
bauzas | alaski: it was just a FYI, continuing to dig | 16:22 |
* amrith takes a deep breath | 16:22 | |
bauzas | alaski: just means that we were having a conflict because of the save which was wedging the other save | 16:22 |
*** b3nt_pin has joined #openstack-nova | 16:22 | |
*** artom has joined #openstack-nova | 16:23 | |
*** b3nt_pin is now known as Guest41612 | 16:23 | |
*** Marga_ has joined #openstack-nova | 16:23 | |
*** beagles_ has joined #openstack-nova | 16:23 | |
alaski | bauzas: yeah. you had a proposal up to catch that right? | 16:24 |
*** Guest41612 has quit IRC | 16:24 | |
bauzas | alaski: I was just catching the new exception, but that was not explaining why we were raising that exception, hence my DNM change | 16:24 |
bauzas | alaski: so I'm continuing to look at why | 16:25 |
bauzas | time for dinner, see ya | 16:25 |
bauzas | ttyl | 16:25 |
*** tjones has joined #openstack-nova | 16:26 | |
*** smatzek_ has quit IRC | 16:26 | |
*** smatzek has joined #openstack-nova | 16:26 | |
andreykurilin | amrith, johnthetubaguy: https://bugs.launchpad.net/python-novaclient/+bug/1493446 | 16:26 |
openstack | Launchpad bug 1493446 in python-novaclient "booting a server from volume in Nova V2.1 is not fully backward-compatible" [Undecided,New] | 16:26 |
*** pixelbeat has joined #openstack-nova | 16:27 | |
amrith | andreykurilin, thanks | 16:27 |
*** artom has quit IRC | 16:28 | |
alaski | bauzas: gotcha | 16:28 |
*** edleafe has quit IRC | 16:29 | |
*** lyanchih has quit IRC | 16:29 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/220669 | 16:30 |
*** nic has joined #openstack-nova | 16:30 | |
*** edleafe has joined #openstack-nova | 16:31 | |
*** thorst has joined #openstack-nova | 16:31 | |
*** dims_ has quit IRC | 16:31 | |
*** dimsum__ has joined #openstack-nova | 16:32 | |
*** whenry has quit IRC | 16:32 | |
*** achanda has joined #openstack-nova | 16:32 | |
jwcroppe | edleafe: FYI - thanks... I addressed your comments in https://review.openstack.org/#/c/219153/ | 16:32 |
edleafe | jwcroppe: cool. Adding it to my list | 16:33 |
*** mpaolino has quit IRC | 16:34 | |
andreykurilin | johnthetubaguy: about https://review.openstack.org/#/c/221222/ : this problem should be fixed at horizon side. they use novaclient incorrect. Only novaclient.client should be used as entry point, but they use novaclient.v2.client directly... https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/nova.py#L448-L454 | 16:35 |
*** dannywilson has joined #openstack-nova | 16:36 | |
openstackgerrit | dane-fichter proposed openstack/nova: Nova support for image-signing https://review.openstack.org/189843 | 16:37 |
*** zhangjn has joined #openstack-nova | 16:38 | |
jwcroppe | edleafe: thanks | 16:39 |
*** andreykurilin__ has joined #openstack-nova | 16:39 | |
*** mdbooth has quit IRC | 16:39 | |
*** Guest60469 is now known as mgagne | 16:40 | |
*** mgagne has joined #openstack-nova | 16:40 | |
openstackgerrit | Marian Horban proposed openstack/nova: [WIP]Remove wsgi functionality https://review.openstack.org/221118 | 16:40 |
*** derekh has quit IRC | 16:42 | |
*** vilobhmm_11 has joined #openstack-nova | 16:44 | |
*** davideagnello has joined #openstack-nova | 16:44 | |
*** amotoki has quit IRC | 16:46 | |
*** winston-d has quit IRC | 16:46 | |
*** Jeffrey4l has quit IRC | 16:49 | |
*** tsekiyama has joined #openstack-nova | 16:50 | |
*** danpb has quit IRC | 16:51 | |
*** pbrooko has quit IRC | 16:53 | |
*** achanda has quit IRC | 16:56 | |
*** achanda_ has joined #openstack-nova | 16:56 | |
*** lpetrut has quit IRC | 16:56 | |
*** e0ne has quit IRC | 16:56 | |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient: Enable i18n with Babel. https://review.openstack.org/221407 | 16:56 |
*** earlephilhower has quit IRC | 16:57 | |
*** aix has quit IRC | 16:58 | |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient: Enable i18n with Babel. https://review.openstack.org/221407 | 16:59 |
mriedem | doffm: ^ i updated the pot file with the latest changes | 16:59 |
*** VW_ has quit IRC | 16:59 | |
*** VW_ has joined #openstack-nova | 17:00 | |
*** tsekiyama has quit IRC | 17:00 | |
*** VW_ has quit IRC | 17:00 | |
*** VW_ has joined #openstack-nova | 17:00 | |
mriedem | doffm: i'm wondering if the domain needs to be python-novaclient per https://wiki.openstack.org/wiki/Translations#Integrating_translations_into_your_project | 17:01 |
*** unicell has joined #openstack-nova | 17:02 | |
*** Jeffrey4l has joined #openstack-nova | 17:02 | |
*** harlowja has joined #openstack-nova | 17:03 | |
*** afazekas_ has joined #openstack-nova | 17:05 | |
*** dannywilson has quit IRC | 17:06 | |
*** unicell has quit IRC | 17:06 | |
*** unicell has joined #openstack-nova | 17:06 | |
*** lucasagomes is now known as lucas-dinner | 17:06 | |
*** Marga_ has quit IRC | 17:07 | |
*** Marga_ has joined #openstack-nova | 17:07 | |
*** achanda_ has quit IRC | 17:08 | |
*** Marga_ has quit IRC | 17:08 | |
*** Marga_ has joined #openstack-nova | 17:09 | |
*** ijw_ has joined #openstack-nova | 17:10 | |
openstackgerrit | Matt Riedemann proposed openstack/python-novaclient: Enable i18n with Babel. https://review.openstack.org/221407 | 17:11 |
*** Marga_ has quit IRC | 17:11 | |
*** yamahata has quit IRC | 17:11 | |
*** yamahata has joined #openstack-nova | 17:14 | |
*** kaushikc has joined #openstack-nova | 17:14 | |
PaulMurray | dansmith, I have a question about bdm - do you know what no_device is intended for (apart from the obvious from its name)? | 17:14 |
*** tsekiyama has joined #openstack-nova | 17:14 | |
*** kaushikc is now known as kaushikc1 | 17:14 | |
dansmith | PaulMurray: um | 17:15 |
*** Marga_ has joined #openstack-nova | 17:15 | |
dansmith | PaulMurray: short answer is no | 17:15 |
PaulMurray | ok thanks, one for the list I think | 17:16 |
dansmith | yeah, I'm sure ndipanov knows, but he's not around today I think | 17:16 |
*** kaushikc1 has quit IRC | 17:16 | |
dansmith | it's an older flag, so it might have some interesting legacy meaning | 17:17 |
PaulMurray | I looked for him - seems it was added in cactus, so maybe someone with a long memory | 17:17 |
dansmith | well, he must know what it was used for with all his BDM experience | 17:17 |
dansmith | looking at where it's used isn't revealing anything to me | 17:17 |
*** pixelbeat has quit IRC | 17:18 | |
PaulMurray | yeah, I dug around and couldn't figure it out | 17:18 |
*** dabo- has joined #openstack-nova | 17:20 | |
*** achanda has joined #openstack-nova | 17:21 | |
*** zhangjn has quit IRC | 17:21 | |
*** electrocucaracha has quit IRC | 17:21 | |
mriedem | rlrossit: i swear i was going to just go through https://review.openstack.org/#/c/197135/ but now it has to be rebased | 17:21 |
*** irenab has quit IRC | 17:22 | |
*** electrocucaracha has joined #openstack-nova | 17:23 | |
*** afazekas_ has quit IRC | 17:24 | |
*** tsekiyama has quit IRC | 17:24 | |
*** Apoorva has quit IRC | 17:25 | |
*** tri2sing has quit IRC | 17:25 | |
*** Apoorva has joined #openstack-nova | 17:26 | |
*** ociuhandu has quit IRC | 17:26 | |
*** earlephilhower has joined #openstack-nova | 17:27 | |
*** electrocucaracha has quit IRC | 17:28 | |
*** tjones has quit IRC | 17:28 | |
*** lsmola has quit IRC | 17:29 | |
*** tri2sing has joined #openstack-nova | 17:29 | |
*** tjones has joined #openstack-nova | 17:32 | |
*** nelsnelson has quit IRC | 17:34 | |
*** Jeffrey4l has quit IRC | 17:35 | |
*** dabo- has quit IRC | 17:36 | |
*** artom has joined #openstack-nova | 17:39 | |
*** nelsnelson has joined #openstack-nova | 17:39 | |
mriedem | dansmith: so with the rpc api, when you change kwargs on a method you have to handle that depending on which version of the api you can handle, like removing kwargs you can't handle, | 17:41 |
mriedem | dansmith: so i wonder why we don't have the same issue with changing kwargs in versioned object methods https://review.openstack.org/#/c/197135/3/nova/objects/fixed_ip.py | 17:42 |
mriedem | i know we've done this before though | 17:42 |
*** exploreshaifali has joined #openstack-nova | 17:42 | |
*** lhcheng has joined #openstack-nova | 17:43 | |
dansmith | mriedem: I'm not sure what you mean | 17:43 |
dansmith | mriedem: that patch is adding one, defaulting to None, so as long as the db method being called tolerates =None, things should be fine | 17:43 |
*** dabo- has joined #openstack-nova | 17:46 | |
*** yamahata has quit IRC | 17:46 | |
*** mvandijk has left #openstack-nova | 17:46 | |
*** e0ne has joined #openstack-nova | 17:47 | |
mriedem | was just thinking about when we update for example compute rpc api and add a new kwarg to a method, we sometimes check the version we can send and if we can't send the version that added the new kwarg we have to remove it else the operation will fail with an unexpected kwarg | 17:49 |
mriedem | but objects magically handles that for us? | 17:49 |
*** rlrossit has left #openstack-nova | 17:49 | |
dansmith | mriedem: no, it doesn't, we just make the rule that conductor always has to be newest and we don't have to worry about the rest | 17:50 |
dansmith | regular rpc can go to/from any node, so it's not as clear cut | 17:50 |
mriedem | ah, ok | 17:50 |
mriedem | i was missing the part about newest being the rule | 17:50 |
*** otter768 has joined #openstack-nova | 17:53 | |
doffm | mriedem: Not sure about the domain name. Keystoneclient uses just 'keystoneclient'. Will check it out. | 17:56 |
mriedem | doffm: the docs said to use the project name | 17:56 |
mriedem | i'm guessing it has to be that way for how transifex proposes the changes | 17:56 |
mriedem | it probably expects a certain form | 17:56 |
*** beagles has quit IRC | 17:56 | |
*** otter768 has quit IRC | 17:57 | |
*** electrocucaracha has joined #openstack-nova | 17:59 | |
*** nelsnelson has quit IRC | 17:59 | |
*** tri2sing has quit IRC | 17:59 | |
*** baoli has quit IRC | 18:00 | |
*** yamahata has joined #openstack-nova | 18:00 | |
mriedem | doffm: or, python-keystoneclient doesn't have a translation job setup in the project-config repo, like in here for magnumclient: https://review.openstack.org/#/c/182998/4/jenkins/jobs/projects.yaml | 18:00 |
doffm | mriedem: Likely. Ha. I just looked at magnumclient. | 18:00 |
doffm | Yes, domain name and transifex project should probably be the project name. | 18:00 |
*** beagles has joined #openstack-nova | 18:01 | |
mriedem | doffm: note that the i18n team is moving off transifex | 18:01 |
*** aix has joined #openstack-nova | 18:01 | |
mriedem | and onto zanata https://translate-dev.openstack.org/ | 18:01 |
*** beagles is now known as Guest74068 | 18:01 | |
*** baoli has joined #openstack-nova | 18:01 | |
*** r-daneel has joined #openstack-nova | 18:02 | |
*** SourabhP has joined #openstack-nova | 18:03 | |
*** nelsnelson has joined #openstack-nova | 18:03 | |
*** rushil has joined #openstack-nova | 18:04 | |
*** dabo- has quit IRC | 18:08 | |
*** edleafe- has joined #openstack-nova | 18:08 | |
*** Guest74068 has quit IRC | 18:09 | |
mriedem | doffm: confirmed it has to be python-novaclient given the script for the updates | 18:11 |
mriedem | http://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/scripts/common_translation_update.sh#n38 | 18:11 |
*** browne has joined #openstack-nova | 18:11 | |
*** b3nt_pin has joined #openstack-nova | 18:12 | |
*** b3nt_pin is now known as Guest36435 | 18:13 | |
doffm | mriedem: Thanks. I wouldn't have found that easily. | 18:13 |
doffm | Or at all. :) | 18:13 |
mriedem | doffm: sure you would, it's in the wiki https://wiki.openstack.org/wiki/Translations#Setup_import_and_export_of_translations | 18:15 |
doffm | Oh yeah, project-config - translation jobs. | 18:16 |
*** sachin has quit IRC | 18:18 | |
*** armax has quit IRC | 18:19 | |
dansmith | lucas-dinner: jlvillal: help me understand where I'm wrong here: https://review.openstack.org/#/c/209457/2 | 18:20 |
*** rlrossit has joined #openstack-nova | 18:24 | |
jlvillal | dansmith: lucas-dinner: Reading your comment and looking at the code, I think I see what you mean. Before it had a test with the state set to ACTIVE. Which doesn't seem to exist anymore. | 18:24 |
melwitt | dansmith: going along with the ironic driver theme, I'd like your opinion on this patch that fixes a regression introduced by new nova code that auto-creates bdm for ephemeral https://review.openstack.org/#/c/205271/ | 18:24 |
dansmith | jlvillal: right | 18:24 |
jlvillal | dansmith: I will let lucas-dinner respond, but I think he is off for the evening. | 18:24 |
dansmith | melwitt: oh you would would you? | 18:24 |
melwitt | dansmith: yeah! | 18:25 |
*** moshele has joined #openstack-nova | 18:25 | |
*** rushil has quit IRC | 18:25 | |
melwitt | dansmith: I think it's okay because the ironic driver was already making a (bad) assumption of /dev/sda1 and this is putting it back in line with that. and they have opened a new bug to fix the root cause which is ironic not using nova bdm in the first place | 18:26 |
dansmith | hrm. | 18:26 |
dansmith | melwitt: yeah, I dunno, I say we wait and let ndipanov opine | 18:28 |
mriedem | this is interesting: https://review.openstack.org/#/c/220622/4/nova/console/websocketproxy.py - the change is attempting to mask 'token' from the logs, but there is an InvalidToken exception which basically says, 'token %s is invalid or expired' - so how to handle that? mask the token in the error message or re-write the error message to make it more generic? | 18:28 |
dansmith | I thought we had a unique requirement on the device name | 18:28 |
melwitt | dansmith: okay. I'll add him to the review | 18:28 |
*** rlrossit has left #openstack-nova | 18:29 | |
*** rlrossit has joined #openstack-nova | 18:29 | |
*** e0ne has quit IRC | 18:29 | |
*** Apoorva_ has joined #openstack-nova | 18:30 | |
*** ssurana has joined #openstack-nova | 18:31 | |
*** openstackgerrit has quit IRC | 18:31 | |
melwitt | mriedem: if the token is masked in other log messages, I'd say mask it in the error message so a person could at least correlate them | 18:32 |
*** openstackgerrit has joined #openstack-nova | 18:32 | |
mriedem | melwitt: i agree if we're going to mask the token in the logs it shouldn't be in an exception message, but 'token *** is invalid or expired' is weird | 18:32 |
mriedem | it's unhelpful at best | 18:33 |
*** Apoorva has quit IRC | 18:33 | |
melwitt | mriedem: yeah. I was thinking mask == {SHA1}blah so if it's in the logs as that, the exception message could have it too then someone debugging could correlate messages together (maybe that's already possible with request id) | 18:35 |
mriedem | ah | 18:36 |
mriedem | that would make more sense, | 18:36 |
mriedem | in this change it's just using strutils.mask_password so it turns into *** | 18:36 |
*** ssurana has quit IRC | 18:36 | |
melwitt | ah, I see | 18:36 |
melwitt | in the clients I've seen all that turn into the "{SHA1}blah" strings | 18:37 |
*** ociuhandu has joined #openstack-nova | 18:39 | |
*** achanda has quit IRC | 18:40 | |
*** achanda has joined #openstack-nova | 18:41 | |
*** zzzeek_ has joined #openstack-nova | 18:42 | |
*** baoli has quit IRC | 18:43 | |
*** zzzeek has quit IRC | 18:43 | |
*** zzzeek_ is now known as zzzeek | 18:43 | |
*** artom has quit IRC | 18:43 | |
*** moshele has quit IRC | 18:50 | |
*** electrocucaracha has quit IRC | 18:54 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Remove cache from the AZ helper https://review.openstack.org/221384 | 18:55 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Consolidate code to get the correct availability zone of an instance https://review.openstack.org/149562 | 18:55 |
*** chhavi has quit IRC | 18:57 | |
*** achanda has quit IRC | 18:57 | |
bauzas | alaski, melwitt: we have a bug with cells vs. API v2.1 fixed by https://review.openstack.org/#/c/220893/4 | 18:57 |
bauzas | alaski: melwitt: the above LGTM | 18:58 |
*** electrocucaracha has joined #openstack-nova | 18:59 | |
alaski | isn't there a patch to relax all of that validation? | 18:59 |
bauzas | alaski: yup, but that one is for v2.1 | 19:00 |
*** derekh has joined #openstack-nova | 19:00 | |
alaski | I thought we were relaxing v2.1 as well? | 19:00 |
bauzas | alaski: IIUC, relaxing the validation only applies to v2.0 over v2.1 | 19:00 |
bauzas | alaski: I think you hit a good point | 19:00 |
bauzas | alaski: but since relaxing the api validation can be subject to discussion, I'd rather pick that one quickly and discuss on relaxing for out-of-tree separately | 19:01 |
alaski | shouldn't this have a microversion then, given the current state of things? | 19:03 |
alaski | though I would rather it now | 19:04 |
alaski | *not | 19:04 |
bauzas | alaski: I'd defer that point to sdague | 19:04 |
bauzas | alaski: but I think that's a bugfix not requiring a microversion | 19:04 |
*** apuimedo has quit IRC | 19:05 | |
bauzas | alaski: because it wouldn't change the response, just ignoring the hint | 19:05 |
*** Marga_ has quit IRC | 19:06 | |
alaski | would it ignore the hint or return a badrequest? | 19:07 |
bauzas | alaski: are we that strong ? | 19:07 |
bauzas | lemme check | 19:07 |
*** tri2sing has joined #openstack-nova | 19:07 | |
*** rfolco has quit IRC | 19:07 | |
alaski | I thought that's what the validation did, but I lost track at some point | 19:08 |
alaski | if it's changing from ignoring to not ignoring then a microversion doesn't seem necessary. if it changes from a failure to success then it seems warranted | 19:08 |
bauzas | sec, checking | 19:09 |
*** baoli has joined #openstack-nova | 19:09 | |
bauzas | alaski: honestly, given it was an oomichi's change, I trusted him for microversions :D | 19:10 |
*** tri2sing has quit IRC | 19:11 | |
alaski | yeah. since it doesn't match what I thought we were doing I want to make sure I have the right mental model here | 19:12 |
*** tri2sing has joined #openstack-nova | 19:12 | |
*** isq_ has quit IRC | 19:13 | |
*** baoli has quit IRC | 19:15 | |
*** pbrooko has joined #openstack-nova | 19:15 | |
*** baoli has joined #openstack-nova | 19:16 | |
*** pbrooko has quit IRC | 19:18 | |
bauzas | alaski: ok, I'm unable to clearly identify if the schema is strict or not | 19:19 |
bauzas | alaski: I'm going to remove my +1 and ask that question to oomichi instead | 19:19 |
openstackgerrit | Tomoki Sekiyama proposed openstack/nova: libvirt: Make behavior of os_require_quiesce consistent https://review.openstack.org/167819 | 19:24 |
scottda | mriedem: jaypipes I've tested the patch for 'nova-manage volume force_detach' and it's working as expected, if you'd like to have a look: | 19:26 |
scottda | https://review.openstack.org/#/c/184537/ | 19:26 |
*** isq_ has joined #openstack-nova | 19:26 | |
*** aysyd has quit IRC | 19:27 | |
*** adam_g` is now known as adam_g | 19:27 | |
*** adam_g has quit IRC | 19:28 | |
*** adam_g has joined #openstack-nova | 19:28 | |
*** Guest78740 is now known as BobBall | 19:28 | |
mriedem | melwitt: is this a change you were following? https://review.openstack.org/#/c/149942/ | 19:29 |
bauzas | alaski: thansk for having commented https://review.openstack.org/#/c/221280/ | 19:29 |
mriedem | melwitt: well, i guess as of june | 19:29 |
bauzas | alaski: tbh, I was looking for a spec but missed the one you said | 19:29 |
jaypipes | scottda: you got it. will try to get to that today or tomorrow. | 19:30 |
*** aysyd has joined #openstack-nova | 19:30 | |
melwitt | mriedem: oh yeah, I remember that one | 19:31 |
mriedem | melwitt: it seems like a huge mess | 19:31 |
mriedem | b/c it touches several different operations, not just snapshot | 19:31 |
mriedem | also rescue and reboot | 19:31 |
mriedem | touches all of the virt drivers but only implements it for libvirt | 19:31 |
*** aix has quit IRC | 19:32 | |
melwitt | mriedem: I agree. there's a really big problem and that patch handles just one case of it. and at the core of it is a neutron feature that removes a bridge when it looks like there's nothing attached anymore, which is something that happens a lot during normal operations. some people have worked around by disabling the feature on the neutron side | 19:32 |
mriedem | melwitt: i was going to say, that seems like the better solution | 19:34 |
mriedem | just say, thanks but no thanks, i'll manage cleaning these up myself | 19:34 |
melwitt | mriedem: and I use the word "handles" conservatively, it reduces the race I guess | 19:34 |
*** tjones has quit IRC | 19:35 | |
mriedem | i need to read up on why https://bugs.launchpad.net/nova/+bug/1293540/comments/7 isn't useful here | 19:35 |
openstack | Launchpad bug 1293540 in OpenStack Compute (nova) "nova should make sure the bridge exists before resuming a VM after an offline snapshot" [Low,In progress] - Assigned to Luo Gangyi (luogangyi) | 19:35 |
BobBall | Is anyone aware of object conversions that still need to be merged around image_meta? Getting a recently introduced stack trace around image_meta.id not being accessible? http://paste.openstack.org/show/450677/ | 19:36 |
melwitt | mriedem: the author says because nova would have to call "plug" in order to execute that code. I think regardless, if neutron happened to remove the bridge after nova "ensure bridge" it would still end up with the error | 19:37 |
mriedem | melwitt: oh i see, even if linuxnet_interface_driver was set, if the virt driver isn't calling plug_vifs, which is what the patch adds, it doesn't matter | 19:38 |
mriedem | and yeah, i agree, that doesn't resolve the issue - neutron still destroys the thing that nova wants to use | 19:38 |
mriedem | i guess we need an idea of persistent bridges in neutron....or something | 19:38 |
*** achanda has joined #openstack-nova | 19:38 | |
*** pixelbeat has joined #openstack-nova | 19:39 | |
mriedem | or like, lock a bridge while doing an operation or something and unlock when done | 19:39 |
*** yamahata has quit IRC | 19:39 | |
melwitt | it might reduce the chances of it happening enough to be worth it, to just "ensure bridge" | 19:40 |
mriedem | or just use nova-network | 19:41 |
mriedem | but dansmith would be against such a thing :) | 19:41 |
dansmith | me against nova-network? not likely... | 19:42 |
*** wverdugo500 has joined #openstack-nova | 19:43 | |
melwitt | mriedem: neutron has a config setting to disable the auto bridge removal, I saw mentioned in a related bug. and I thought similar, a lock/unlock (with a timeout I guess) to tell neutron not to touch the bridge when it's expected the vif will disappear temporarily. | 19:43 |
mriedem | melwitt: know the name of the option? | 19:44 |
melwitt | looking for it | 19:44 |
melwitt | mriedem: https://bugs.launchpad.net/neutron/+bug/1328546/comments/9 is where I saw mention about it | 19:45 |
openstack | Launchpad bug 1328546 in neutron "Race condition when hard rebooting instance" [High,Fix released] - Assigned to Li Ma (nick-ma-z) | 19:45 |
*** achanda has quit IRC | 19:45 | |
*** andreykurilin__ has quit IRC | 19:46 | |
mriedem | melwitt: ah, he did that locally | 19:48 |
mriedem | and created a cron to delete the empty bridges | 19:48 |
mriedem | that's probably a better solution in neutron - have a config option to delete emptry bridges immediately (if you want) but then a periodic task to cleanup on a cron otherwise | 19:48 |
mriedem | mestery: HenryG: ^ are you around? | 19:48 |
melwitt | mriedem: oh, so not configurable? I misunderstood it | 19:49 |
mriedem | melwitt: i read mgagne's comment as he patched it himself https://bugs.launchpad.net/neutron/+bug/1328546/comments/9 | 19:49 |
openstack | Launchpad bug 1328546 in neutron "Race condition when hard rebooting instance" [High,Fix released] - Assigned to Li Ma (nick-ma-z) | 19:49 |
alaski | bauzas: np. I'm happy to see this effort proceed a bit | 19:49 |
mriedem | "I locally fix it by disabling remove_empty_bridges and using a cron to delete empty bridges instead." | 19:50 |
*** ZZelle_ has joined #openstack-nova | 19:50 | |
melwitt | mriedem: I think you're right, I'm looking for a config setting named that and so far not finding anything. I assumed a config because of the word "disabling" | 19:50 |
bauzas | alaski: yeah, I'm having a bit more time for helping on that with mitaka | 19:50 |
lucas-dinner | dansmith, jlvillal hi there, sorry I was out for dinner. I think the reasoning at the time I coded it is that _unprovision() is already tested on it's own tests https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/ironic/test_driver.py#L1214-L1265 | 19:51 |
lucas-dinner | dansmith, jlvillal so the idea was just to check if destroy() was actually calling it instead of testing _unprovision() as part of destroy() | 19:51 |
* lucas-dinner re-looks | 19:52 | |
mriedem | melwitt: given comment 10 from sc68cal, https://bugs.launchpad.net/neutron/+bug/1328546/comments/10 | 19:52 |
openstack | Launchpad bug 1328546 in neutron "Race condition when hard rebooting instance" [High,Fix released] - Assigned to Li Ma (nick-ma-z) | 19:52 |
mriedem | the linuxbridge ci job is also hitting this race | 19:52 |
mriedem | https://review.openstack.org/#/c/197162/ | 19:53 |
*** otter768 has joined #openstack-nova | 19:54 | |
*** Tedster has quit IRC | 19:54 | |
mriedem | damn | 19:54 |
mriedem | https://review.openstack.org/#/q/I4ccc96566a5770384eacbbdc492bf09a514f5b31,n,z | 19:54 |
mriedem | well, seems this is invalid for nova now :) | 19:54 |
*** amrith is now known as _amrith_ | 19:54 | |
melwitt | mriedem: haha! I was not expecting that | 19:54 |
melwitt | mriedem: nice find. I had just searched for calls in github and didn't notice they were only in unit tests | 19:55 |
mriedem | melwitt: yeah, so i'm -2 on the nova change now | 19:55 |
melwitt | case closed | 19:56 |
dansmith | lucas-dinner: okay, I might have been misunderstanding the arrangement of set_provision_state in the old test | 19:56 |
dansmith | lucas-dinner: however, that link makes me think that you're now duplicating some of those tests with the new one in this patch, no? | 19:56 |
*** jecarey has quit IRC | 19:56 | |
lucas-dinner | dansmith, that set_provision_state() was just a mock call to set the provison_state of the node to None so it would exit the looping call | 19:57 |
lucas-dinner | dansmith, checking it | 19:58 |
*** otter768 has quit IRC | 19:58 | |
*** derekh is now known as derekh_afk | 19:58 | |
dansmith | lucas-dinner: I also don't much like the resetting of the mocks during the loop | 19:59 |
lucas-dinner | dansmith, not really, the link are tests for the _unprovision() method | 19:59 |
dansmith | it'd be cleaner to have the mocks on a helper function | 19:59 |
lucas-dinner | the test I changed is the test for the destroy() method that calls _unprovision() | 19:59 |
*** yamahata has joined #openstack-nova | 19:59 | |
dansmith | lucas-dinner: so then are they or are they not checking destroy() works for ACTIVE? | 19:59 |
lucas-dinner | which is mocked, I just wanna assert that destroy() is calling it as expected (as unittests) | 19:59 |
lucas-dinner | dansmith, yeah, I will update that patch to test it | 20:00 |
dansmith | lucas-dinner: it kinda seems like you should run through *all* the states, and only expect the unprovision call if/when we're testing one in the unprovision list | 20:00 |
lucas-dinner | perhaps I will leave as it was before and just add things on top | 20:00 |
lucas-dinner | dansmith, +1 | 20:00 |
dansmith | okay, thanks | 20:00 |
lucas-dinner | I will mark it as WIP and improve the test coverage tomorrow morning | 20:00 |
lucas-dinner | dansmith, thanks for capturing it! | 20:00 |
dansmith | lucas-dinner: okay, ping me tomorrow and I'll re-look | 20:01 |
lucas-dinner | dansmith, will do! thanks for the review | 20:01 |
dansmith | np | 20:01 |
*** dimsum__ is now known as dims | 20:03 | |
*** dustins has quit IRC | 20:04 | |
*** dims is now known as Guest80071 | 20:04 | |
bauzas | alaski: ah-ah I see your long term view you provided re: tasks | 20:07 |
*** dkliban has joined #openstack-nova | 20:07 | |
alaski | yeah, it's just something I keep in mind when thinking about it. But we're a long ways from that, and haven't decided that it's the proper direction | 20:07 |
*** dkliban has left #openstack-nova | 20:07 | |
*** Guest80071 is now known as dims__ | 20:08 | |
*** unicell has quit IRC | 20:11 | |
*** unicell has joined #openstack-nova | 20:12 | |
*** obedmr_ has joined #openstack-nova | 20:12 | |
openstackgerrit | melanie witt proposed openstack/python-novaclient: Add unit tests for different help commands https://review.openstack.org/221488 | 20:13 |
*** obedmr has quit IRC | 20:15 | |
dansmith | jlvillal: how come all my attempts to make lucas-dinner rage end up fail? seems like he's far too willing to appease reviewers, which confuses me. | 20:15 |
*** smatzek_ has joined #openstack-nova | 20:18 | |
*** smatzek has quit IRC | 20:21 | |
*** smatzek_ has quit IRC | 20:22 | |
mriedem | scottda: remind me about that change later this week | 20:23 |
mriedem | can't get into it right now | 20:23 |
scottda | mriedem: no problem, will do | 20:23 |
mgagne | mriedem: can I be of any help? | 20:26 |
mriedem | mgagne: only if you want to confirm a thing, related to https://review.openstack.org/#/c/149942/ | 20:27 |
mriedem | mgagne: you had commented about a workaround https://bugs.launchpad.net/neutron/+bug/1328546/comments/9 | 20:27 |
openstack | Launchpad bug 1328546 in neutron "Race condition when hard rebooting instance" [High,Fix released] - Assigned to Li Ma (nick-ma-z) | 20:27 |
lucas-dinner | dansmith, lol I rather just get things done (-: | 20:27 |
mriedem | mgagne: which led me to https://review.openstack.org/#/q/I4ccc96566a5770384eacbbdc492bf09a514f5b31,n,z | 20:28 |
mgagne | mriedem: yep. this patch fixed all my problem =) | 20:28 |
mriedem | mgagne: so i'm assuming ^ resolves both issues, since the root issue was the neutron linuxbridge agent removing empty bridges | 20:28 |
mriedem | mgagne: awesome | 20:28 |
*** edleafe has quit IRC | 20:28 | |
*** mpaolino has joined #openstack-nova | 20:28 | |
dansmith | lucas-dinner: imagine that.. | 20:30 |
mgagne | mriedem: my local patch introduced a config to toggle or not the removal of empty bridge. I ended up completely removing the config and permanently NOT removing empty bridges. I do have a cron but I'm not sure if it could retrigger the offline snapshot issue you pointed out. We are not actively using snapshots so we don't know if there could be an other race or not with the cron. | 20:30 |
*** mpaolino has quit IRC | 20:31 | |
*** mpaolino has joined #openstack-nova | 20:31 | |
*** exploreshaifali has quit IRC | 20:31 | |
mgagne | mriedem: this is the script I use, patch against OpenStack Neutron Kilo (Ubuntu package): https://gist.github.com/mgagne/cbc9762cec9fa24294be | 20:34 |
openstackgerrit | Ed Leafe proposed openstack/python-novaclient: When no version given, default to v2.0 https://review.openstack.org/221222 | 20:34 |
*** raildo is now known as raildo-afk | 20:34 | |
mriedem | mgagne: any reason you didn't propose that to neutron upstream? | 20:36 |
*** mpaolino has quit IRC | 20:36 | |
*** ekarlso has quit IRC | 20:38 | |
*** isq_ has quit IRC | 20:38 | |
mgagne | mriedem: as an operator, it's often a matter of lack of time. | 20:39 |
mgagne | mriedem: proposing a fix is one thing, keeping up with reviews and revisions is where it's hard | 20:39 |
mriedem | ok, i dumped https://gist.github.com/mgagne/cbc9762cec9fa24294be in the bug comments for people to at least find it later | 20:41 |
mriedem | might still be worth pushing up at some point as a tool | 20:41 |
mgagne | sure, I'll propose a patch right now and see where it goes | 20:41 |
mriedem | don't blame me when mestery doesn't review it though :) | 20:41 |
mgagne | hehe | 20:41 |
mestery | mriedem: which bug? | 20:41 |
*** achanda has joined #openstack-nova | 20:41 | |
mriedem | 1328546 | 20:41 |
mriedem | mgagne: add me to the review when it's up and i'll check it out | 20:42 |
*** tjones has joined #openstack-nova | 20:42 | |
*** raildo-afk is now known as raildo | 20:44 | |
*** tongli has quit IRC | 20:44 | |
*** clduser_ has quit IRC | 20:44 | |
*** Marga_ has joined #openstack-nova | 20:46 | |
*** derekh_afk has quit IRC | 20:48 | |
*** salv-orlando has joined #openstack-nova | 20:48 | |
*** jecarey has joined #openstack-nova | 20:50 | |
*** achanda has quit IRC | 20:51 | |
*** jwang_ has joined #openstack-nova | 20:54 | |
*** VW__ has joined #openstack-nova | 20:54 | |
*** achanda has joined #openstack-nova | 20:54 | |
*** tri2sing_ has joined #openstack-nova | 20:55 | |
*** raildo is now known as raildo-afk | 20:56 | |
*** patrickeast has quit IRC | 20:56 | |
*** VW_ has quit IRC | 20:57 | |
*** patrickeast has joined #openstack-nova | 20:57 | |
*** jwang has quit IRC | 20:57 | |
*** ekarlso has joined #openstack-nova | 20:57 | |
*** ekarlso has quit IRC | 20:57 | |
*** ekarlso has joined #openstack-nova | 20:57 | |
*** tri2sing has quit IRC | 20:57 | |
*** gmmaha has joined #openstack-nova | 20:59 | |
*** gmmaha has quit IRC | 20:59 | |
*** gmmaha has joined #openstack-nova | 21:00 | |
*** aix has joined #openstack-nova | 21:01 | |
*** _amrith_ is now known as amrith | 21:01 | |
*** karimb has joined #openstack-nova | 21:07 | |
*** clduser has joined #openstack-nova | 21:07 | |
*** changbl has quit IRC | 21:07 | |
*** gmmaha has quit IRC | 21:07 | |
*** gmmaha has joined #openstack-nova | 21:08 | |
*** marzif has quit IRC | 21:09 | |
*** marzif has joined #openstack-nova | 21:09 | |
*** ivasev has quit IRC | 21:10 | |
*** aysyd has quit IRC | 21:10 | |
openstackgerrit | Andrew Laski proposed openstack/nova: Cells: Limit instances pulled in _heal_instances https://review.openstack.org/176925 | 21:11 |
*** baoli has quit IRC | 21:12 | |
*** burgerk has quit IRC | 21:12 | |
BobBall | mriedem: Thanks for adding me to that neutron-related patch. Glad to see it's probably not needed :) | 21:13 |
mriedem | me too :) | 21:14 |
mriedem | doffm: congrats :) https://review.openstack.org/#/c/221407/ | 21:23 |
*** bswartz has joined #openstack-nova | 21:23 | |
*** obedmr_ has quit IRC | 21:24 | |
*** IanGovett has quit IRC | 21:27 | |
doffm | mriedem: :) | 21:29 |
*** BobBall is now known as BoBall_AWOL | 21:30 | |
*** obedmr has joined #openstack-nova | 21:32 | |
*** achanda has quit IRC | 21:35 | |
*** achanda has joined #openstack-nova | 21:35 | |
*** devlaps has quit IRC | 21:38 | |
*** claudiub has quit IRC | 21:40 | |
*** mriedem is now known as mriedem_away | 21:42 | |
*** achanda_ has joined #openstack-nova | 21:44 | |
*** achanda has quit IRC | 21:44 | |
*** darrenc_ is now known as darrenc | 21:47 | |
*** wanghua has joined #openstack-nova | 21:48 | |
*** xyang1 has joined #openstack-nova | 21:49 | |
*** humble_ has joined #openstack-nova | 21:49 | |
*** jamielennox|away is now known as jamielennox | 21:51 | |
*** wanghua has quit IRC | 21:53 | |
*** otter768 has joined #openstack-nova | 21:55 | |
*** marcusvrn_ has quit IRC | 21:55 | |
*** lucas-dinner has quit IRC | 21:56 | |
*** VW_ has joined #openstack-nova | 21:56 | |
*** edmondsw has quit IRC | 21:57 | |
*** achanda_ has quit IRC | 21:58 | |
*** otter768 has quit IRC | 21:59 | |
*** VW__ has quit IRC | 22:00 | |
*** tri2sing_ has quit IRC | 22:00 | |
*** VW_ has quit IRC | 22:01 | |
*** achanda has joined #openstack-nova | 22:02 | |
*** tri2sing has joined #openstack-nova | 22:02 | |
*** derekh has joined #openstack-nova | 22:03 | |
johnthetubaguy | andreykurilin: ah, interesting, do we document the use of client vs v2.client? | 22:05 |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [BugFix] Change parameters for legacy bdm https://review.openstack.org/221525 | 22:05 |
*** pixelbeat has quit IRC | 22:05 | |
johnthetubaguy | actually, I need to go sleep, lets leave this for now | 22:06 |
* johnthetubaguy zzzz | 22:06 | |
*** asettle has joined #openstack-nova | 22:06 | |
*** rushil has joined #openstack-nova | 22:06 | |
*** Marga_ has quit IRC | 22:07 | |
*** Marga_ has joined #openstack-nova | 22:07 | |
*** burt has quit IRC | 22:09 | |
*** achanda has quit IRC | 22:09 | |
*** achanda has joined #openstack-nova | 22:09 | |
*** Piet has quit IRC | 22:11 | |
*** mdrabe has quit IRC | 22:12 | |
*** achanda_ has joined #openstack-nova | 22:13 | |
*** annegentle has quit IRC | 22:13 | |
*** achanda has quit IRC | 22:13 | |
*** tpeoples has quit IRC | 22:14 | |
*** edtubill has quit IRC | 22:14 | |
*** derekh has quit IRC | 22:24 | |
mgagne | mriedem_away: FYI https://review.openstack.org/#/c/221508/ | 22:25 |
*** r-daneel has quit IRC | 22:26 | |
*** mwagner_lap has quit IRC | 22:28 | |
*** alex_xu has quit IRC | 22:28 | |
*** rushil has quit IRC | 22:30 | |
*** zzzeek has quit IRC | 22:30 | |
*** alex_xu has joined #openstack-nova | 22:30 | |
*** zzzeek has joined #openstack-nova | 22:30 | |
*** rushil has joined #openstack-nova | 22:30 | |
*** jecarey has quit IRC | 22:31 | |
*** dannywilson has joined #openstack-nova | 22:32 | |
*** dannywilson has quit IRC | 22:32 | |
*** dannywilson has joined #openstack-nova | 22:33 | |
*** xyang1 has quit IRC | 22:36 | |
*** Sukhdev_ has joined #openstack-nova | 22:36 | |
*** earlephilhower has quit IRC | 22:42 | |
*** thorst has quit IRC | 22:43 | |
*** hparekh has joined #openstack-nova | 22:47 | |
*** tpeoples has joined #openstack-nova | 22:48 | |
*** ctrath has quit IRC | 22:49 | |
*** Marga__ has joined #openstack-nova | 22:49 | |
*** krtaylor has quit IRC | 22:49 | |
*** Marga_ has quit IRC | 22:51 | |
*** karimb has quit IRC | 22:53 | |
*** rushil has quit IRC | 22:54 | |
*** achanda has joined #openstack-nova | 22:55 | |
*** achanda_ has quit IRC | 22:55 | |
*** browne has quit IRC | 22:59 | |
*** Piet has joined #openstack-nova | 23:00 | |
*** Guest36435 is now known as beagles | 23:00 | |
*** achanda_ has joined #openstack-nova | 23:01 | |
*** achanda has quit IRC | 23:01 | |
*** rubasov has quit IRC | 23:05 | |
*** eharney has quit IRC | 23:06 | |
*** adreznec has quit IRC | 23:09 | |
openstackgerrit | Nicolas Simonds proposed openstack/nova: libvirt: Fix/implement revert-resize for RBD-backed images https://review.openstack.org/187395 | 23:09 |
openstackgerrit | Nicolas Simonds proposed openstack/nova: libvirt: Split out resize_image logic from create_image https://review.openstack.org/187857 | 23:09 |
*** hemna is now known as hemnafk | 23:10 | |
*** isq has joined #openstack-nova | 23:11 | |
*** ZZelle_ has quit IRC | 23:14 | |
*** asettle is now known as asettle-afk | 23:15 | |
*** rlrossit has left #openstack-nova | 23:16 | |
*** Sukhdev_ has quit IRC | 23:17 | |
*** adreznec has joined #openstack-nova | 23:17 | |
*** erlon has quit IRC | 23:18 | |
*** Sukhdev has joined #openstack-nova | 23:19 | |
*** obedmr has quit IRC | 23:20 | |
*** achanda has joined #openstack-nova | 23:23 | |
*** achanda_ has quit IRC | 23:23 | |
openstackgerrit | Nicolas Simonds proposed openstack/nova: libvirt: make snapshot use RBD snapshot/clone when available https://review.openstack.org/205282 | 23:24 |
*** oomichi has joined #openstack-nova | 23:32 | |
*** kse has joined #openstack-nova | 23:34 | |
*** hparekh has quit IRC | 23:34 | |
*** nic has quit IRC | 23:34 | |
*** VikasC has quit IRC | 23:35 | |
mikal | Morning | 23:36 |
*** emagana has quit IRC | 23:37 | |
*** asettle-afk is now known as asettle | 23:38 | |
*** Sukhdev has quit IRC | 23:38 | |
*** ijw_ has quit IRC | 23:40 | |
*** Sukhdev has joined #openstack-nova | 23:40 | |
*** salv-orlando has quit IRC | 23:41 | |
*** asettle has quit IRC | 23:48 | |
*** shoutm has joined #openstack-nova | 23:49 | |
*** asettle has joined #openstack-nova | 23:49 | |
*** browne has joined #openstack-nova | 23:50 | |
*** ijuwang has quit IRC | 23:52 | |
*** electrocucaracha has quit IRC | 23:55 | |
*** otter768 has joined #openstack-nova | 23:55 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!