*** jwcroppe has quit IRC | 00:00 | |
*** markvoelker has quit IRC | 00:01 | |
*** kylek3h has joined #openstack-nova | 00:01 | |
*** otter768 has joined #openstack-nova | 00:02 | |
*** Sukhdev has quit IRC | 00:07 | |
*** Sukhdev has joined #openstack-nova | 00:07 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/221934 | 00:07 |
---|---|---|
*** otter768 has quit IRC | 00:08 | |
*** zxyf has quit IRC | 00:13 | |
*** otter768 has joined #openstack-nova | 00:15 | |
*** changbl has quit IRC | 00:17 | |
*** shoutm has quit IRC | 00:17 | |
*** zxyf has joined #openstack-nova | 00:17 | |
*** shoutm has joined #openstack-nova | 00:20 | |
*** tjones1 has left #openstack-nova | 00:23 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Check for unformatted logged messages during test runs https://review.openstack.org/221973 | 00:27 |
*** kylek3h_ has joined #openstack-nova | 00:31 | |
*** thorst has quit IRC | 00:32 | |
*** ijw__ has joined #openstack-nova | 00:32 | |
*** darrenc_afk is now known as darrenc | 00:32 | |
*** ijw_ has quit IRC | 00:33 | |
*** kylek3h has quit IRC | 00:34 | |
*** mnestratov has quit IRC | 00:39 | |
*** tsekiyam_ has joined #openstack-nova | 00:40 | |
*** jecarey has joined #openstack-nova | 00:42 | |
*** tsekiyam_ has quit IRC | 00:44 | |
*** tsekiyama has quit IRC | 00:44 | |
*** armax has joined #openstack-nova | 00:50 | |
*** takedakn has joined #openstack-nova | 00:50 | |
*** dave-mccowan has joined #openstack-nova | 00:50 | |
*** rfolco has quit IRC | 00:52 | |
*** mriedem has joined #openstack-nova | 00:53 | |
*** mriedem1 has quit IRC | 00:53 | |
*** kylek3h_ has quit IRC | 00:57 | |
*** markvoelker has joined #openstack-nova | 00:58 | |
*** Apoorva has quit IRC | 00:59 | |
*** Apoorva has joined #openstack-nova | 01:00 | |
*** rushil has quit IRC | 01:00 | |
*** Apoorva has quit IRC | 01:02 | |
*** markvoelker has quit IRC | 01:02 | |
*** Apoorva has joined #openstack-nova | 01:03 | |
*** READ10 has quit IRC | 01:03 | |
*** jwcroppe has joined #openstack-nova | 01:03 | |
*** jwcroppe has quit IRC | 01:03 | |
*** vilobhmm_11 has quit IRC | 01:04 | |
*** jwcroppe has joined #openstack-nova | 01:04 | |
*** vilobhmm_11 has joined #openstack-nova | 01:04 | |
*** jwcroppe_ has joined #openstack-nova | 01:05 | |
*** jwcroppe has quit IRC | 01:08 | |
openstackgerrit | Alex Xu proposed openstack/nova: Allow leading/trailing whitespaces for name fields in Nova API https://review.openstack.org/220791 | 01:12 |
*** bswartz has quit IRC | 01:15 | |
*** dims_ has joined #openstack-nova | 01:16 | |
*** bswartz has joined #openstack-nova | 01:16 | |
*** hanzhang has joined #openstack-nova | 01:17 | |
*** armax has quit IRC | 01:17 | |
*** dims has quit IRC | 01:19 | |
*** Jeffrey4l has joined #openstack-nova | 01:20 | |
*** lyanchih has joined #openstack-nova | 01:22 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: CONF.allow_resize_to_same_host should check only once in controller https://review.openstack.org/186236 | 01:24 |
*** zxyf has quit IRC | 01:24 | |
*** zxyf has joined #openstack-nova | 01:25 | |
*** achanda has quit IRC | 01:26 | |
*** otter768 has quit IRC | 01:27 | |
*** takedakn has quit IRC | 01:28 | |
*** vilobhmm_11 has quit IRC | 01:28 | |
*** achanda has joined #openstack-nova | 01:29 | |
*** haomaiwang has joined #openstack-nova | 01:29 | |
*** lyanchih has quit IRC | 01:30 | |
*** Daisy has joined #openstack-nova | 01:30 | |
*** Daisy has quit IRC | 01:31 | |
*** Daisy has joined #openstack-nova | 01:31 | |
*** Daisy_ has joined #openstack-nova | 01:32 | |
*** otter768 has joined #openstack-nova | 01:32 | |
*** takedakn has joined #openstack-nova | 01:33 | |
*** diogogmt has joined #openstack-nova | 01:33 | |
*** Daisy_ has quit IRC | 01:34 | |
*** Daisy_ has joined #openstack-nova | 01:35 | |
*** SourabhP has quit IRC | 01:35 | |
*** Daisy has quit IRC | 01:35 | |
*** tpeoples has quit IRC | 01:36 | |
*** Daisy_ has quit IRC | 01:39 | |
*** whenry has joined #openstack-nova | 01:40 | |
*** Daisy has joined #openstack-nova | 01:42 | |
*** armax has joined #openstack-nova | 01:42 | |
*** baoli has joined #openstack-nova | 01:43 | |
mriedem | when your neighbor's dog is outside barking for 8 hours, it's time to call animal control | 01:43 |
*** Sukhdev has quit IRC | 01:43 | |
*** Marga_ has quit IRC | 01:45 | |
*** ijw__ has quit IRC | 01:47 | |
*** Apoorva has quit IRC | 01:48 | |
*** vishwanathj has quit IRC | 01:50 | |
*** erhudy1 has quit IRC | 01:55 | |
*** baoli has quit IRC | 01:56 | |
*** vilobhmm_11 has joined #openstack-nova | 01:56 | |
*** r-daneel has quit IRC | 01:57 | |
*** kylek3h has joined #openstack-nova | 01:57 | |
*** hanzhang has quit IRC | 01:58 | |
*** hanzhang has joined #openstack-nova | 01:58 | |
*** haomaiwang has quit IRC | 02:01 | |
*** haomaiwang has joined #openstack-nova | 02:01 | |
*** kylek3h has quit IRC | 02:02 | |
*** dannywilson has quit IRC | 02:04 | |
*** baoli has joined #openstack-nova | 02:04 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 02:12 |
*** daisy_ has joined #openstack-nova | 02:12 | |
*** Daisy has quit IRC | 02:12 | |
*** daisy_ is now known as daisy | 02:12 | |
*** Daisy_ has joined #openstack-nova | 02:13 | |
*** bkopilov has quit IRC | 02:14 | |
*** dave-mccowan has quit IRC | 02:16 | |
*** armax has quit IRC | 02:16 | |
*** Daisy_ has quit IRC | 02:17 | |
*** tpeoples has joined #openstack-nova | 02:20 | |
*** yamahata has quit IRC | 02:20 | |
*** andrewbogott has joined #openstack-nova | 02:21 | |
*** asettle has quit IRC | 02:22 | |
*** humble__ has joined #openstack-nova | 02:22 | |
*** VW_ has joined #openstack-nova | 02:22 | |
andrewbogott | I just upgraded to Kilo and now lifecycle events are erroring out with | 02:23 |
andrewbogott | "TRACE oslo_messaging.rpc.dispatcher KeyError: ‘metadata'" | 02:23 |
andrewbogott | Is this a known/familiar issue? | 02:23 |
mriedem | andrewbogott: i feel like that was a known thing | 02:24 |
mriedem | not seeing a bug in LP for that though | 02:24 |
*** Apoorva has joined #openstack-nova | 02:24 | |
*** wanghua has joined #openstack-nova | 02:24 | |
andrewbogott | I see a bug but there’s no resolution... | 02:24 |
andrewbogott | mriedem: https://bugs.launchpad.net/nova/+bug/1484738 looks like it | 02:25 |
openstack | Launchpad bug 1484738 in OpenStack Compute (nova) "keyerror when refreshing instance security groups" [Undecided,New] - Assigned to Zhenzan Zhou (zhenzan-zhou) | 02:25 |
*** shyu has joined #openstack-nova | 02:25 | |
*** humble_ has quit IRC | 02:25 | |
andrewbogott | (This is important to me because I’m trying to get notifications sent to designate-sink. I don’t know if that bug is killing all my notifications or not, but it seems like a likely candidate.) | 02:26 |
mriedem | andrewbogott: is that the same trace you're seeing? | 02:26 |
mriedem | in _deallocate_network ? | 02:26 |
mriedem | similar to https://bugs.launchpad.net/nova/+bug/1452510 | 02:27 |
openstack | Launchpad bug 1452510 in OpenStack Compute (nova) "TestVolumeBootPattern KeyError: 'metadata' " [Undecided,Invalid] | 02:27 |
*** jecarey has quit IRC | 02:27 | |
*** humble__ has quit IRC | 02:27 | |
andrewbogott | mriedem: looks the same to me… https://dpaste.de/L8fR | 02:27 |
*** unicell has quit IRC | 02:28 | |
mriedem | ok, let me look in the kilo code, might be an obvious issue | 02:28 |
*** alejandrito has joined #openstack-nova | 02:28 | |
andrewbogott | thank you! | 02:29 |
andrewbogott | I jabbed at the code in a few places and made the exceptions go away, but not without making notifications go away with them | 02:29 |
mriedem | my guess would be we're not pre-loading metadata when we get the intsance from the db | 02:30 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Check for unformatted logged messages during test runs https://review.openstack.org/221973 | 02:31 |
mriedem | andrewbogott: btw, are you on trunk stable/kilo or like 2015.1? | 02:32 |
andrewbogott | I’m using the cloud archive | 02:32 |
andrewbogott | nova-compute 1:2015.1.1-0ubuntu1~cloud2 | 02:32 |
mriedem | nova-network? | 02:33 |
andrewbogott | afraid so :( | 02:34 |
*** dave-mccowan has joined #openstack-nova | 02:34 | |
mriedem | i was wondering if it was https://review.openstack.org/#/c/211162/ | 02:35 |
*** penick has quit IRC | 02:36 | |
*** vilobhmm_11 has quit IRC | 02:36 | |
*** Daisy_ has joined #openstack-nova | 02:36 | |
mriedem | i think that was actually an AttributeError though, not a KeyError | 02:36 |
andrewbogott | hm, that’s in the right ballpark at least | 02:36 |
andrewbogott | I agree, though, that doesn’t seem like it would throw the error I’m seeing | 02:38 |
mriedem | andrewbogott: actually | 02:38 |
mriedem | https://github.com/openstack/nova/blob/stable/kilo/nova/compute/manager.py#L434 | 02:38 |
mriedem | the object_compat decorator is used there | 02:38 |
mriedem | and that's trying to load metadata on the object | 02:38 |
mriedem | but this thing isn't an object | 02:38 |
mriedem | i think that's your bug | 02:38 |
andrewbogott | why are we in except KeyError: in the first place? | 02:39 |
mriedem | oh, sec | 02:39 |
*** y_sawai has joined #openstack-nova | 02:44 | |
mriedem | nope i'm not seeing it | 02:46 |
mriedem | i'm not seeing anything changed here in master either | 02:46 |
mriedem | but the code looks obviously wrong | 02:46 |
*** daisy has quit IRC | 02:46 | |
andrewbogott | Seems like it must be triggered by my config, otherwise everyone would see the bug all the time | 02:46 |
andrewbogott | vs. google only turning up a couple of cases | 02:47 |
*** Daisy_ is now known as Daisy | 02:47 | |
*** ctrath has joined #openstack-nova | 02:49 | |
*** otter768 has quit IRC | 02:50 | |
mriedem | andrewbogott: look at this https://github.com/openstack/nova/blob/stable/kilo/nova/compute/manager.py#L421 | 02:50 |
mriedem | metas there | 02:50 |
mriedem | it's defined after the _load_instance method | 02:50 |
*** venkat_p has joined #openstack-nova | 02:51 | |
mriedem | that seems....wrong | 02:51 |
*** ctrath has quit IRC | 02:53 | |
*** VW_ has quit IRC | 02:53 | |
mriedem | metas must work by some scope rules or something, because we get here: https://github.com/openstack/nova/blob/stable/kilo/nova/objects/instance.py#L506 | 02:53 |
*** VW_ has joined #openstack-nova | 02:54 | |
andrewbogott | The thing about it being defined after _load_instance doesn’t seem wrong to me. But I can try reordering it here and see if it makes a difference... | 02:55 |
*** otter768 has joined #openstack-nova | 02:55 | |
*** ctrath has joined #openstack-nova | 02:55 | |
*** markvoelker has joined #openstack-nova | 02:55 | |
*** kylek3h has joined #openstack-nova | 02:55 | |
mriedem | no that's not the issue | 02:55 |
mriedem | whatever originally got the instance object from the db didn't join on 'metadata' | 02:56 |
mriedem | so it's not in the instance db object when we try to turn it into an instance rpc object | 02:56 |
mriedem | and the object_compat decorator isn't checking for that | 02:56 |
mriedem | so the decorator is asking for a thing that the instance db object can't provide and we explode | 02:56 |
mriedem | so two ways to fix, fix the original db get and join on metadata, or check in the decorator if those fields are actually in the object before the conversion | 02:57 |
mriedem | latter is probably better since it's more general | 02:57 |
*** Daisy has quit IRC | 02:57 | |
*** Daisy has joined #openstack-nova | 02:57 | |
mriedem | yeah, trigger_members_refresh and trigger_rules_refresh in nova/compute/api get the security groups and join on the instances table, so we get the instances but not the extra attributes in the instances, like metadata | 02:58 |
mriedem | so the object_compat decorator blindly expecting them is wrong | 02:58 |
*** VW_ has quit IRC | 02:59 | |
*** armax has joined #openstack-nova | 02:59 | |
*** Daisy_ has joined #openstack-nova | 02:59 | |
*** Daisy has quit IRC | 02:59 | |
*** kylek3h has quit IRC | 03:00 | |
mriedem | andrewbogott: i'll see if i can cook up a patch quick that you can try out | 03:00 |
andrewbogott | Hm, the fact that this is a general bug probably means that it is /not/ the reason that I’m not getting notifications :( | 03:00 |
andrewbogott | But, yes, I will definitely test your patch :) | 03:00 |
*** haomaiwang has quit IRC | 03:01 | |
*** jecarey has joined #openstack-nova | 03:01 | |
*** haomaiwa_ has joined #openstack-nova | 03:01 | |
*** humble_ has joined #openstack-nova | 03:03 | |
*** dave-mccowan has quit IRC | 03:04 | |
mriedem | looks like at some point in liberty the secgroup refresh code in nova.compute.api was changed to get instance objects by security group id, and that goes through the instance object which is pre-loading some expected attributes, like system_metadata, so that might explain why it's not an issue in liberty | 03:04 |
mriedem | https://review.openstack.org/#/c/187537/ | 03:05 |
mriedem | ^ is why it's not a problem in liberty, that gets the instance object before going to compute manager so the object_compat decorator doesn't try to call _from_db_object | 03:05 |
*** y_sawai has quit IRC | 03:06 | |
*** wanghua has quit IRC | 03:06 | |
* andrewbogott nods | 03:07 | |
mriedem | we can't backport that fix to kilo since it has rpc api versoin changes | 03:08 |
mriedem | fixing object_compat should be easy though, working that now | 03:08 |
andrewbogott | I could just hotfix the changes in https://review.openstack.org/#/c/187537/10/nova/compute/rpcapi.py but I’m not clear if they rely on other liberty changes... | 03:08 |
*** alejandrito has quit IRC | 03:10 | |
*** tojuvone has joined #openstack-nova | 03:11 | |
*** zxyf has quit IRC | 03:14 | |
*** otter768 has quit IRC | 03:14 | |
mriedem | you don't want to hot fix rpc api changes | 03:17 |
mriedem | my fix will be clean | 03:17 |
mriedem | squeeky | 03:17 |
mriedem | testing it quick | 03:17 |
*** tjones has joined #openstack-nova | 03:20 | |
*** ctrath has quit IRC | 03:21 | |
*** dims_ has quit IRC | 03:23 | |
*** apmelton has quit IRC | 03:26 | |
*** d34dh0r53 has quit IRC | 03:27 | |
*** d34dh0r53 has joined #openstack-nova | 03:28 | |
*** apmelton has joined #openstack-nova | 03:28 | |
*** ijw_ has joined #openstack-nova | 03:29 | |
*** VW_ has joined #openstack-nova | 03:29 | |
*** links has joined #openstack-nova | 03:30 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Don't expect meta attributes in object_compat that aren't in the db obj https://review.openstack.org/222022 | 03:31 |
mriedem | andrewbogott: mikal: dansmith: ^ | 03:31 |
mriedem | melwitt: ^ | 03:31 |
*** claudiub has quit IRC | 03:33 | |
andrewbogott | mriedem: that certainly makes my logs quieter | 03:34 |
mriedem | \o/ | 03:34 |
mriedem | already patched? | 03:34 |
andrewbogott | yep | 03:35 |
mriedem | cool | 03:36 |
mriedem | i'll backport to stable/kilo quick | 03:36 |
andrewbogott | great! | 03:36 |
mriedem | this is probably actually also busted in juno | 03:36 |
mriedem | this code hasn't changed in a long time | 03:36 |
andrewbogott | Might be, I didn’t go log-diving until the kilo upgrade | 03:37 |
andrewbogott | Tragically, my primary issue (no notifications) is still present. But it’s one less culprit to glare at :) | 03:37 |
mriedem | here is the kilo backport - it was actually clean, which is nice for a change https://review.openstack.org/#/c/222023/ | 03:38 |
*** achanda has quit IRC | 03:38 | |
*** achanda has joined #openstack-nova | 03:38 | |
mriedem | alright, calling it a night | 03:43 |
*** bkopilov has joined #openstack-nova | 03:43 | |
*** mriedem has quit IRC | 03:43 | |
*** zxyf has joined #openstack-nova | 03:44 | |
*** deepthi has joined #openstack-nova | 03:44 | |
*** Daisy_ has quit IRC | 03:45 | |
*** jecarey has quit IRC | 03:48 | |
*** tjones has quit IRC | 03:55 | |
*** kylek3h has joined #openstack-nova | 03:56 | |
*** changbl has joined #openstack-nova | 03:56 | |
*** VW_ has quit IRC | 03:57 | |
*** VW_ has joined #openstack-nova | 03:57 | |
*** haomaiwa_ has quit IRC | 04:01 | |
*** kylek3h has quit IRC | 04:01 | |
*** haomaiwang has joined #openstack-nova | 04:01 | |
*** VW_ has quit IRC | 04:02 | |
*** Sree has joined #openstack-nova | 04:04 | |
*** ijw_ has quit IRC | 04:05 | |
*** morgan has quit IRC | 04:06 | |
*** morganfainberg has joined #openstack-nova | 04:07 | |
*** morganfainberg is now known as morgan | 04:09 | |
*** baoli has quit IRC | 04:10 | |
*** VikasC has joined #openstack-nova | 04:10 | |
*** marzif has joined #openstack-nova | 04:10 | |
*** asettle has joined #openstack-nova | 04:13 | |
*** maishsk has quit IRC | 04:22 | |
*** dims has joined #openstack-nova | 04:23 | |
*** dims has quit IRC | 04:30 | |
*** vilobhmm_11 has joined #openstack-nova | 04:30 | |
*** garyk has quit IRC | 04:32 | |
*** y_sawai has joined #openstack-nova | 04:40 | |
openstackgerrit | Alex Xu proposed openstack/nova: Allow leading/trailing whitespaces for name fields in Nova API https://review.openstack.org/220791 | 04:43 |
openstackgerrit | Alex Xu proposed openstack/nova: Add version parameter for servers schema extension points. https://review.openstack.org/222032 | 04:43 |
*** asettle has quit IRC | 04:43 | |
*** sudipto has joined #openstack-nova | 04:48 | |
openstackgerrit | Alex Xu proposed openstack/nova: Allow leading/trailing whitespaces for name fields in Nova API https://review.openstack.org/220791 | 04:54 |
*** markvoelker has quit IRC | 04:55 | |
*** fifieldt has joined #openstack-nova | 04:58 | |
*** yamahata has joined #openstack-nova | 04:59 | |
*** haomaiwang has quit IRC | 05:01 | |
*** Marga_ has joined #openstack-nova | 05:01 | |
*** haomaiwa_ has joined #openstack-nova | 05:02 | |
*** nelsnels_ has joined #openstack-nova | 05:03 | |
*** nelsnelson has quit IRC | 05:03 | |
*** unicell has joined #openstack-nova | 05:04 | |
*** Sree has quit IRC | 05:06 | |
*** Sree has joined #openstack-nova | 05:06 | |
openstackgerrit | Ankit Agrawal proposed openstack/nova: libvirt: Race condition leads to instance in error https://review.openstack.org/185549 | 05:09 |
*** Marga_ has quit IRC | 05:09 | |
*** Daisy has joined #openstack-nova | 05:14 | |
*** otter768 has joined #openstack-nova | 05:15 | |
*** rajesht has joined #openstack-nova | 05:15 | |
*** zxyf has quit IRC | 05:16 | |
*** zxyf has joined #openstack-nova | 05:16 | |
*** ijw_ has joined #openstack-nova | 05:16 | |
*** Sukhdev has joined #openstack-nova | 05:19 | |
*** chhavi has joined #openstack-nova | 05:20 | |
*** otter768 has quit IRC | 05:20 | |
*** rajesht has quit IRC | 05:21 | |
*** Daisy has quit IRC | 05:23 | |
*** Daisy has joined #openstack-nova | 05:23 | |
*** maishsk has joined #openstack-nova | 05:24 | |
openstackgerrit | Alex Xu proposed openstack/nova: Check unknown event name when create external server event https://review.openstack.org/222033 | 05:26 |
*** vishwanathj has joined #openstack-nova | 05:27 | |
*** vishwanathj has quit IRC | 05:28 | |
*** maishsk has quit IRC | 05:29 | |
*** maishsk has joined #openstack-nova | 05:36 | |
*** maishsk has quit IRC | 05:41 | |
*** moshele has joined #openstack-nova | 05:41 | |
*** takedakn has quit IRC | 05:47 | |
*** zhangjn has joined #openstack-nova | 05:51 | |
*** zhangjn has joined #openstack-nova | 05:52 | |
*** jerrygb has joined #openstack-nova | 05:53 | |
*** fifieldt has quit IRC | 05:56 | |
*** markvoelker has joined #openstack-nova | 05:56 | |
*** kylek3h has joined #openstack-nova | 05:57 | |
*** haomaiwa_ has quit IRC | 06:01 | |
*** chhavi has quit IRC | 06:01 | |
*** markvoelker has quit IRC | 06:01 | |
*** haomaiwang has joined #openstack-nova | 06:01 | |
*** kylek3h has quit IRC | 06:01 | |
*** chhavi has joined #openstack-nova | 06:03 | |
*** y_sawai has quit IRC | 06:05 | |
*** chhavi has quit IRC | 06:07 | |
*** ajayaa has joined #openstack-nova | 06:11 | |
*** Murali has joined #openstack-nova | 06:11 | |
*** humble__ has joined #openstack-nova | 06:13 | |
*** garyk has joined #openstack-nova | 06:14 | |
*** humble_ has quit IRC | 06:17 | |
*** alex_klimov has joined #openstack-nova | 06:17 | |
*** jerrygb has quit IRC | 06:19 | |
*** maishsk has joined #openstack-nova | 06:20 | |
*** Jeffrey4l has quit IRC | 06:20 | |
*** Apoorva has quit IRC | 06:20 | |
*** chhavi has joined #openstack-nova | 06:23 | |
*** ajayaa has quit IRC | 06:25 | |
*** humble_ has joined #openstack-nova | 06:25 | |
*** vipul has quit IRC | 06:28 | |
*** humble__ has quit IRC | 06:28 | |
*** vipul has joined #openstack-nova | 06:28 | |
openstackgerrit | Alex Xu proposed openstack/nova: Allow leading/trailing whitespaces for name fields in Nova API https://review.openstack.org/220791 | 06:29 |
*** Jeffrey4l has joined #openstack-nova | 06:33 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: resize-revert can break anti-affinity policy https://review.openstack.org/160110 | 06:37 |
*** vilobhmm_111 has joined #openstack-nova | 06:37 | |
*** ajayaa has joined #openstack-nova | 06:37 | |
*** vilobhmm_11 has quit IRC | 06:39 | |
*** achanda has quit IRC | 06:39 | |
*** rdopiera has joined #openstack-nova | 06:39 | |
*** achanda has joined #openstack-nova | 06:39 | |
*** mcarden has quit IRC | 06:40 | |
*** moshele has quit IRC | 06:41 | |
*** penick has joined #openstack-nova | 06:43 | |
*** alexschm has joined #openstack-nova | 06:45 | |
*** achanda has quit IRC | 06:48 | |
*** gibi has joined #openstack-nova | 06:49 | |
*** vilobhmm_111 has quit IRC | 06:49 | |
*** mnestratov has joined #openstack-nova | 06:49 | |
*** irenab has joined #openstack-nova | 06:50 | |
*** achanda has joined #openstack-nova | 06:53 | |
*** achanda has quit IRC | 06:54 | |
*** penick has quit IRC | 06:56 | |
*** Sree has quit IRC | 06:59 | |
*** mpaolino has joined #openstack-nova | 06:59 | |
*** achanda has joined #openstack-nova | 07:00 | |
*** cfriesen has quit IRC | 07:01 | |
*** haomaiwang has quit IRC | 07:01 | |
*** haomaiwang has joined #openstack-nova | 07:01 | |
*** bfic has joined #openstack-nova | 07:01 | |
*** lsmola has joined #openstack-nova | 07:02 | |
*** romainh has joined #openstack-nova | 07:03 | |
*** abhishekk has joined #openstack-nova | 07:03 | |
*** guest098 has joined #openstack-nova | 07:04 | |
*** achanda has quit IRC | 07:06 | |
*** achanda has joined #openstack-nova | 07:06 | |
*** jcoufal has joined #openstack-nova | 07:07 | |
*** browne has quit IRC | 07:08 | |
*** guest098 has quit IRC | 07:10 | |
*** rajesht has joined #openstack-nova | 07:11 | |
*** achanda has quit IRC | 07:12 | |
*** rubasov has quit IRC | 07:12 | |
*** apuimedo has joined #openstack-nova | 07:13 | |
*** ankit_ag has joined #openstack-nova | 07:14 | |
*** otter768 has joined #openstack-nova | 07:16 | |
*** ijw_ has quit IRC | 07:17 | |
*** Sukhdev has quit IRC | 07:19 | |
*** otter768 has quit IRC | 07:20 | |
*** deepakcs has joined #openstack-nova | 07:33 | |
openstackgerrit | Alex Xu proposed openstack/nova: Add version parameter for servers schema extension points https://review.openstack.org/222032 | 07:33 |
openstackgerrit | Alex Xu proposed openstack/nova: Allow leading/trailing whitespaces for name fields in Nova API https://review.openstack.org/220791 | 07:33 |
openstackgerrit | Alex Xu proposed openstack/nova: Check unknown event name when create external server event https://review.openstack.org/222033 | 07:35 |
*** rajesht has quit IRC | 07:35 | |
*** guest234 has joined #openstack-nova | 07:36 | |
*** guest234 has quit IRC | 07:36 | |
*** rajesht has joined #openstack-nova | 07:37 | |
*** matrohon has joined #openstack-nova | 07:39 | |
*** rajesht has left #openstack-nova | 07:40 | |
*** rajesht has joined #openstack-nova | 07:41 | |
*** moshele has joined #openstack-nova | 07:41 | |
*** rajesht has left #openstack-nova | 07:41 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [BugFix] Change parameters for legacy bdm https://review.openstack.org/221525 | 07:41 |
*** rajesht has joined #openstack-nova | 07:42 | |
*** jlanoux has joined #openstack-nova | 07:43 | |
*** rajesht has quit IRC | 07:43 | |
*** rajesht has joined #openstack-nova | 07:43 | |
openstackgerrit | Marian Horban proposed openstack/nova: [WIP]Remove wsgi functionality https://review.openstack.org/219248 | 07:46 |
*** xgsa has joined #openstack-nova | 07:46 | |
*** Daisy has quit IRC | 07:46 | |
*** Sree has joined #openstack-nova | 07:48 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Restrict direct usage of novaclient.v2.client https://review.openstack.org/221706 | 07:49 |
*** amotoki has joined #openstack-nova | 07:55 | |
*** rotbeard has joined #openstack-nova | 07:55 | |
*** markvoelker has joined #openstack-nova | 07:57 | |
*** kylek3h has joined #openstack-nova | 07:58 | |
*** bapalm has quit IRC | 07:58 | |
*** jmccrory has quit IRC | 07:59 | |
*** julien_ZTE has joined #openstack-nova | 07:59 | |
*** StevenK has quit IRC | 07:59 | |
*** mikal has quit IRC | 07:59 | |
*** shoutm_ has joined #openstack-nova | 08:00 | |
*** bapalm has joined #openstack-nova | 08:00 | |
*** haomaiwang has quit IRC | 08:01 | |
*** jistr has joined #openstack-nova | 08:01 | |
*** haomaiwang has joined #openstack-nova | 08:01 | |
*** Sree_ has joined #openstack-nova | 08:01 | |
*** maishsk has quit IRC | 08:01 | |
*** mikal has joined #openstack-nova | 08:01 | |
*** shoutm has quit IRC | 08:01 | |
*** StevenK has joined #openstack-nova | 08:02 | |
*** Sree_ is now known as Guest9112 | 08:02 | |
*** markvoelker has quit IRC | 08:02 | |
*** kylek3h has quit IRC | 08:02 | |
*** claudiub has joined #openstack-nova | 08:03 | |
*** Sree has quit IRC | 08:03 | |
*** tpeoples has quit IRC | 08:03 | |
*** jmccrory has joined #openstack-nova | 08:03 | |
*** oomichi has joined #openstack-nova | 08:08 | |
*** danpb has joined #openstack-nova | 08:09 | |
*** yassine__ has joined #openstack-nova | 08:10 | |
julien_ZTE | Hi, I use Fuel to deploy 3 control nodes. There are huge number of messages in nova-api.log in one node which vip__management exists. About 2MB per second will be written into the file. The harddisk will soon run out of resources. I find that large number of green socket errors in the file nova-api. Maybe 3 or 4 hours, the file get 40GB size. There are 10K link in this node, | 08:10 |
julien_ZTE | and 90% are relevant with 11211 port. I think the port 11211 is used by Memcached. | 08:10 |
julien_ZTE | some log information liks this: | 08:10 |
julien_ZTE | Exception RuntimeError: Exception 'Exception mRuntimeErrorRuntimeErroraException : : 'xm'aixmRuntimeErroriammu: xmu 'rmi mmureme ccururarsxiseiocinumor nsd ueimdopentp h dtr hException eee pcxtRuntimeErrorceh: xu er'ecedmsxeaecixedieomd unee mwdhd iedep'rtedlch in u' e in re<bound method GreenSocket.__del__ of <eventlet.greenio.GreenSocket object at 0xae3aad0>> <bound method | 08:10 |
julien_ZTE | GreenSocket.__del__ of <eventlet.greenio.GreenSocket object at 0xab12d90>>sxc ignored | 08:10 |
julien_ZTE | ignored | 08:10 |
julien_ZTE | caeedelliido nwgn ha dPiyltehpotehn ceaxlcloibnjeeegc dtead'' in in <bound method GreenSocket.__del__ of <eventlet.greenio.GreenSocket object at 0xaeb3350>>P ignored | 08:10 |
julien_ZTE | ython obj<bound method GreenSocket.__del__ of <eventlet.greenio.GreenSocket object at 0xabe05d0>> ignored | 08:10 |
julien_ZTE | ect' in <bound method GreenSocket.__del__ of <eventlet.greenio.GreenSocket object at 0xacab590>> ignored | 08:10 |
julien_ZTE | Exception Exception RuntimeError: 'maximum recursionRuntimeError dep: 'tmh eaxixcmueem derecd'urs in i<bound method GreenSocket.__del__ of <eventlet.greenio.GreenSocket object at 0xab12d90>>on ignored | 08:10 |
julien_ZTE | depth exException ceedeRuntimeErrord' in : '<bound method GreenSocket.__del__ of <eventlet.greenio.GreenSocket object at 0xae3aad0>>max ignored | 08:10 |
julien_ZTE | imum recursion depth exceeded while calling a Python object' in <bound method GreenSocket.__del__ of <eventlet.greenio.GreenSocket object at 0xaeb3350>> ignored | 08:10 |
julien_ZTE | Exception Exception RuntimeErrorRuntimeError: ': max'imumam recursionxi dException empumRuntimeErrort: h Exception 'emRuntimeErrorrx: acexecie'udrmmseaduix'om in inm<bound method GreenSocket.__del__ of <eventlet.greenio.GreenSocket object at 0xab12d90>> ignored | 08:10 |
julien_ZTE | duemprteh ceurrxscieeeodne cdduer'si in ptoh<bound method GreenSocket.__del__ of <eventlet.greenio.GreenSocket object at 0xabe05d0>> ne x ignored | 08:10 |
julien_ZTE | cededede' in p<bound method GreenSocket.__del__ of <eventlet.greenio.GreenSocket object at 0xae3aad0>>th ignored | 08:10 |
julien_ZTE | Exception excRuntimeError: 'emedeaximdum recurs whiion deplth eexceede d whilec calalingl a Pytlhoni objectn' in <bound method GreenSocket.__del__ of <eventlet.greenio.GreenSocket object at 0xaeb3350>>g ignored | 08:10 |
bauzas | julien_ZTE: you're not in the right channel, and I could have your attention about https://paste.openstack.org | 08:11 |
julien_ZTE | Thanks | 08:11 |
bauzas | julien_ZTE: see the channel subject above | 08:11 |
julien_ZTE | #info bauzas, sorry I make a mistake | 08:12 |
bauzas | BoBall_AWOL: FYI, it seems Xen CI went away http://zuul.openstack.xenproject.org/scoreboard/?project=openstack/nova&user=jenkins,citrix_xenserver_ci,XenProject-CI&timeframe=24 | 08:12 |
*** marzif has quit IRC | 08:13 | |
*** maishsk has joined #openstack-nova | 08:13 | |
*** lucasagomes has joined #openstack-nova | 08:15 | |
*** takedakn has joined #openstack-nova | 08:16 | |
*** takedakn has quit IRC | 08:19 | |
*** jerrygb has joined #openstack-nova | 08:19 | |
*** jerrygb has quit IRC | 08:24 | |
*** jcoufal has quit IRC | 08:25 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add microversions schema unit test for None https://review.openstack.org/222068 | 08:26 |
*** Sree has joined #openstack-nova | 08:27 | |
*** Sree__ has joined #openstack-nova | 08:27 | |
*** claudiub has quit IRC | 08:28 | |
*** moshele has quit IRC | 08:28 | |
*** Guest9112 has quit IRC | 08:28 | |
oomichi | johnthetubaguy: hello | 08:29 |
*** claudiub has joined #openstack-nova | 08:29 | |
*** karimb has joined #openstack-nova | 08:30 | |
*** Sree has quit IRC | 08:31 | |
johnthetubaguy | oomichi: hi | 08:34 |
*** takedakn has joined #openstack-nova | 08:34 | |
*** Sree has joined #openstack-nova | 08:35 | |
johnthetubaguy | oomichi: hows things? | 08:35 |
oomichi | johnthetubaguy: great :) can we talk about https://review.openstack.org/#/c/221642/3/doc/source/api_microversion_dev.rst ? | 08:35 |
johnthetubaguy | oomichi: oh, yes, totally | 08:36 |
oomichi | johnthetubaguy: I'd like to make scheduler-hint params exception from microversion bump | 08:36 |
johnthetubaguy | oomichi: so honestly, I was thinking its more important to bump once we relax, as there is no obvious way to tell your scheduler hit is being interpreted vs ignored | 08:37 |
*** chhavi has quit IRC | 08:37 | |
*** Sree___ has joined #openstack-nova | 08:37 | |
*** Sree__ has quit IRC | 08:38 | |
bauzas | johnthetubaguy: oomichi: I just left a comment | 08:38 |
bauzas | johnthetubaguy: oomichi: I feel that we should contract our API for in-tree hints | 08:39 |
bauzas | johnthetubaguy: oomichi: and stop using the hints as placeholder for something we don't control | 08:40 |
bauzas | johnthetubaguy: that impacts the change that you're doing | 08:40 |
*** Sree has quit IRC | 08:40 | |
bauzas | johnthetubaguy: I still need to consider porting that to v2.1 as a whole | 08:40 |
oomichi | bauzas: yeah, right. but I don't think it is nice to bump microversion for in-tree hints | 08:40 |
oomichi | bauzas: johnthetubaguy: I think microversions is based on one single API idea | 08:41 |
bauzas | oomichi: what I'd like to avoid is to share the discussion between modularity (in-tree hints needing or not versioning) and extensibility (out-of-tree hints) | 08:41 |
*** chhavi has joined #openstack-nova | 08:41 | |
johnthetubaguy | oomichi: how do users tell when a scheduler hit has been added, if we don't add it in a new micro version? | 08:42 |
bauzas | oomichi: well, I'd rather consider that we assess that v2.15 for example doesn't work with FooFilter exposing 'foo' hint | 08:42 |
oomichi | bauzas: users can use the API with the same way/parameters on any clouds for interoperability | 08:42 |
*** claudiub has quit IRC | 08:42 | |
oomichi | bauzas: that is based on microversions I think | 08:42 |
bauzas | oomichi: yeah, I'm +1 with johnthetubaguy | 08:42 |
bauzas | oomichi: right, so I feel we should expose that we propose another possibility, hence microversioning | 08:43 |
oomichi | bauzas: then I will remove extensions from API | 08:43 |
oomichi | bauzas: but schedulers/filters depend on each cloud environment | 08:43 |
oomichi | bauzas: that is different from a single same API | 08:43 |
bauzas | oomichi: well, the API contract just guarantees that all the existing filters will work, but it doesn't make any assumption about which hints are actually provided | 08:44 |
*** claudiub has joined #openstack-nova | 08:44 | |
oomichi | bauzas: that means even if specifying the same microversion, the behavior is different between clouds | 08:44 |
bauzas | oomichi: to be clear, if all hints are optional, we're good | 08:44 |
johnthetubaguy | oomichi: so in my head, I am trying to ignore the out of tree things, and just do the best we can for those purely using upstream | 08:44 |
bauzas | johnthetubaguy: +2 | 08:45 |
bauzas | we need to contract our API | 08:45 |
johnthetubaguy | oomichi: now, I get that the API definition is very weak, because we are allowing clouds to still add stuff in there right now | 08:45 |
oomichi | johnthetubaguy: then, so why we relax validation for out-of-tree? | 08:45 |
oomichi | johnthetubaguy: without microversion bump | 08:45 |
*** y_sawai has joined #openstack-nova | 08:45 | |
bauzas | oomichi: that's what I said in the review, we should relax for v2.0 compat only IMHO | 08:46 |
johnthetubaguy | oomichi: I see it as a transition process, we need to work out a better way thats properly discoverable and validated fully, in some future version | 08:46 |
oomichi | johnthetubaguy: I guess we will face this kind of problem in the future also | 08:46 |
bauzas | yup | 08:46 |
alex_xu | oomichi: because in real world, people use out of tree filters | 08:46 |
oomichi | alex_xu: yeah, that's right | 08:46 |
bauzas | alex_xu: but those are not consistent across all clouds, right? while in-tree hints *are* | 08:46 |
oomichi | and the doc seems to consider out-of-tree filter | 08:46 |
johnthetubaguy | alex_xu: so I want those out of tree things to be discoverable and versioned | 08:46 |
johnthetubaguy | alex_xu: but we just don't have that done yet | 08:46 |
johnthetubaguy | so while we fix that, we just allow any stuff through thats not recognised upstream | 08:47 |
bauzas | I see out-of-tree hints as 2nd-class citizens, but definitely not treating the same way as in-tree hints | 08:47 |
johnthetubaguy | but I don't see why we can't make the addition of upstream filters advertised in micro versions | 08:47 |
bauzas | +1 | 08:47 |
alex_xu | johnthetubaguy: I still think, our api contract shouldn't include anyting about out of tree | 08:47 |
johnthetubaguy | at some point, I expect a microversion will stop allowing out of tree things through, and instead add a contract that deals with out of tree things advertising themselves | 08:47 |
oomichi | johnthetubaguy: because deployers can select favorit scheduers for own env | 08:48 |
bauzas | oomichi: the API contract only exposes what's possible | 08:48 |
johnthetubaguy | oomichi: sure, we don't do that properly now, but we can in the future | 08:48 |
johnthetubaguy | and that would be a microversion bump | 08:48 |
bauzas | right | 08:48 |
*** ijw_ has joined #openstack-nova | 08:48 | |
alex_xu | bauzas: +1 | 08:49 |
bauzas | oomichi: I mean, we can accept that someone provides the same_host hint, even if the SameHostFilter is not active | 08:49 |
johnthetubaguy | by the way, we do need a way to tell users what they are allowed to do at some point | 08:49 |
oomichi | johnthetubaguy: I feel impossible to do that in the future, because available schedulers should depend on each compute capacity on each cloud | 08:49 |
oomichi | johnthetubaguy: eg. same_host | 08:49 |
bauzas | oomichi: later, we could see in your change how to make sure it's potentially returning something else than 202, but that's another story | 08:49 |
johnthetubaguy | oomichi: what I am saying is I think its possible to expose those in a discoverable and validated way in the API, by giving people a more advanced plugin mecahnism | 08:50 |
*** Sree has joined #openstack-nova | 08:50 | |
johnthetubaguy | now part of me wants to now allow them at all, but it doesn't feel very practical at this point | 08:51 |
*** claudiub has quit IRC | 08:51 | |
*** derekh has joined #openstack-nova | 08:51 | |
oomichi | johnthetubaguy: if some cloud compute node don't have big capacity, they tend to disable same_host hint. | 08:51 |
alex_xu | question: whether all the new filters can be backport to old version nova? | 08:51 |
oomichi | johnthetubaguy: we cannot deny it, then available parameters are different from clouds. | 08:51 |
bauzas | oomichi: I feel it's a different case from serving a BadRequest | 08:52 |
johnthetubaguy | oomichi: today, no, in the future, we sure could | 08:52 |
johnthetubaguy | oomichi: its more a policy thing, rather than validation though | 08:52 |
*** Sree__ has joined #openstack-nova | 08:52 | |
johnthetubaguy | there are two steps there, just like, is it a valid snapshot request, and am I allowed to create a snapshot | 08:52 |
bauzas | oomichi: probably not a 400 but rather another code | 08:52 |
oomichi | johnthetubaguy: that means we will deny out-of-tree scheduler as the policy | 08:53 |
oomichi | johnthetubaguy: ? | 08:53 |
*** ijw_ has quit IRC | 08:53 | |
johnthetubaguy | oomichi: well, no, we would provide a way for out of tree things to plug into our system, given them time to transition, and then go back to full validation | 08:54 |
*** Sree___ has quit IRC | 08:54 | |
bauzas | oomichi: IMHO for a temporary period, we could consider accepting them, but then we would microversion | 08:54 |
bauzas | yeah that what johnthetubaguy said | 08:54 |
bauzas | and not using the hints attribute IMHO | 08:54 |
oomichi | bauzas: what "not using the hints attribute" means ? out-of-tree scheduler should not add a new attribute to scheduler-hint? | 08:55 |
*** Sree has quit IRC | 08:56 | |
bauzas | oomichi: sorry I was not clear | 08:56 |
*** Sree has joined #openstack-nova | 08:56 | |
bauzas | oomichi: I mean that os:scheduler_hints is a property that is versioned, so consequently not accepting extensibility | 08:56 |
oomichi | johnthetubaguy: go back to full validation seems very hard to do that. I am sure we will get negative feedback again :( | 08:56 |
bauzas | oomichi: out-of-tree hints should be proposed thru another property | 08:57 |
johnthetubaguy | oomichi: not if we have a way for folks to work with that | 08:57 |
johnthetubaguy | oomichi: and give them time to move over | 08:57 |
bauzas | +1 | 08:57 |
johnthetubaguy | oomichi: and we describe the user benefits to them | 08:57 |
*** Sree__ has quit IRC | 08:57 | |
oomichi | bauzas: ah, I see. but another attibute also will be denied due to aP: False. | 08:58 |
*** e0ne has joined #openstack-nova | 08:58 | |
johnthetubaguy | oomichi: not if the scheduler filter tells the validation logic about its extra info | 08:58 |
*** markvoelker has joined #openstack-nova | 08:58 | |
bauzas | oomichi: then we should accept another attribute | 08:58 |
bauzas | yeah that | 08:58 |
johnthetubaguy | oomichi: so I have an idea to move this debate forward... | 08:59 |
oomichi | bauzas: no, that means we just move the problem to the other place. | 08:59 |
oomichi | johnthetubaguy: please :) | 08:59 |
johnthetubaguy | oomichi: lets merge this independent of the docs change: https://review.openstack.org/#/c/220893/6 | 08:59 |
*** SourabhP has joined #openstack-nova | 08:59 | |
johnthetubaguy | oomichi: thats totally valid, because it applies to older version of the API, so I am fine with that | 08:59 |
bauzas | oomichi: no, that means that we publicly discriminate the level of support :) | 08:59 |
johnthetubaguy | oomichi: second, lets split this patch into two: https://review.openstack.org/#/c/221642/3 | 09:00 |
johnthetubaguy | oomichi: we all agree on the attribute thing, and lets have another patch about the scheduler hint thing | 09:00 |
johnthetubaguy | oomichi: that way we can move forward, then talk about the scheduler thing at the next API meeting, or similar | 09:00 |
*** haomaiwang has quit IRC | 09:01 | |
bauzas | disclaimer, I'm not super expert with all the terminology so sorry if I'm unclear and you feeling I'm arguing :/ | 09:01 |
*** haomaiwang has joined #openstack-nova | 09:01 | |
bauzas | johnthetubaguy: I +1 to the plan | 09:01 |
*** maishsk has quit IRC | 09:01 | |
oomichi | johnthetubaguy: the second is ok, it is nice to go forward :) | 09:01 |
*** y_sawai has quit IRC | 09:02 | |
oomichi | johnthetubaguy: but the first is already gotten your +2 | 09:02 |
johnthetubaguy | oomichi: I can re-apply that, thats no worries | 09:02 |
*** markvoelker has quit IRC | 09:02 | |
johnthetubaguy | oomichi: so I think the core disagreement here is the future of out of tree plugins that affect the API | 09:03 |
oomichi | johnthetubaguy: OK, I got it. and do that:) | 09:03 |
oomichi | johnthetubaguy: yeah, right. | 09:04 |
*** jmccrory has quit IRC | 09:04 | |
oomichi | johnthetubaguy: and that thing happen always like API extensions | 09:04 |
oomichi | johnthetubaguy: there is a lot of out-of-tree features in the world | 09:05 |
oomichi | johnthetubaguy: I cannot say our company also... | 09:05 |
johnthetubaguy | oomichi: yep, now at some point, we will either ban them, or find a nice place for them to live inside the API | 09:05 |
*** shoutm has joined #openstack-nova | 09:05 | |
*** jmccrory has joined #openstack-nova | 09:06 | |
oomichi | bauzas: you seems trying to do difficult thing: *discriminate* ;) | 09:06 |
*** eglynn has joined #openstack-nova | 09:07 | |
alex_xu | johnthetubaguy: oomichi there are patches ready for the server name bug https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/1491511,n,z sorry for insert the advertisement | 09:07 |
bauzas | oomichi: like I often say, my English is my best enemy | 09:07 |
johnthetubaguy | alex_xu: oomichi: is there any chance we can get the API entry tidied up in here: https://etherpad.openstack.org/p/liberty-nova-priorities-tracking | 09:07 |
*** shoutm_ has quit IRC | 09:07 | |
*** e0ne has quit IRC | 09:07 | |
oomichi | bauzas: yeah, the word is difficult to me also ;) | 09:08 |
alex_xu | johnthetubaguy: yea, let me check | 09:08 |
bauzas | oomichi: I just want to explain to the users the difference that can be between an in-tree hint that guarantees you to have the same consistent behaviour between clouds, and out-of-tree hints where the semantics could be very widely different | 09:08 |
johnthetubaguy | alex_xu: awesome, thank you | 09:08 |
oomichi | bauzas: but the idea also is hard to do that, because many features want to be first | 09:08 |
alex_xu | johnthetubaguy: np | 09:08 |
alex_xu | johnthetubaguy: can I remove the already merged stuff? | 09:09 |
oomichi | bauzas: yeah, that is demerit of out-of-tree | 09:10 |
*** ociuhandu has quit IRC | 09:10 | |
oomichi | johnthetubaguy: alex_xu: by the way, how much relaxing validation is necessary? | 09:11 |
oomichi | alex_xu seems trying to make validation as the same as v2.0 | 09:11 |
oomichi | but I feel some patch seems overkill | 09:11 |
oomichi | do we have any actual validation problem data/info? | 09:12 |
johnthetubaguy | oomichi: anything that worked properly, should continue to work properly, really | 09:12 |
johnthetubaguy | but its a case by case thing really | 09:12 |
oomichi | johnthetubaguy: the words seems difficult for me :) | 09:12 |
*** jmccrory has quit IRC | 09:12 | |
*** e0ne has joined #openstack-nova | 09:12 | |
*** bnemec has quit IRC | 09:13 | |
johnthetubaguy | oomichi: ah, sorry, I am basically saying, I don't know, I will take a look at the patches and see | 09:13 |
oomichi | to be hoenst, and for example, https://review.openstack.org/#/c/220791 is very hard for me. | 09:13 |
oomichi | johnthetubaguy: ok, I got it. | 09:13 |
johnthetubaguy | oomichi: so we need scripts people wrote for v2.0 to keep working | 09:14 |
oomichi | I read the history of commit log of v2.0 code, and there is no reason of current validation way about that. | 09:14 |
johnthetubaguy | oomichi: now bad stuff can get better error messages, and earlier error messages, and thats fine | 09:14 |
*** bnemec has joined #openstack-nova | 09:14 | |
oomichi | launchpad report also doesn't contain enough reason. | 09:14 |
johnthetubaguy | oomichi: there doesn't need to be a reason though, its our API contract, even if it happened by accident | 09:15 |
oomichi | johnthetubaguy: yeah, if accident happenes, I can accept it. | 09:15 |
*** jmccrory has joined #openstack-nova | 09:15 | |
oomichi | but some validation seems very unclear for use case. | 09:15 |
*** claudiub has joined #openstack-nova | 09:15 | |
oomichi | johnthetubaguy: anyways, it is nice to get some script users are using on v2.0 ;) | 09:16 |
johnthetubaguy | oomichi: agreed, but v2.0 compatibility mode has to be compatible | 09:16 |
*** otter768 has joined #openstack-nova | 09:17 | |
oomichi | johnthetubaguy: totally agree, but I'd like to be against some patches if strange;) | 09:17 |
openstackgerrit | Alexander Schmidt proposed openstack/nova: libvirt: Acquire TCP ports for console during live migration https://review.openstack.org/215102 | 09:18 |
johnthetubaguy | oomichi: trouble is, it could require all names start with the unicode character for the pile of poo, and we would have to enforce that | 09:18 |
*** jcoufal has joined #openstack-nova | 09:18 | |
* alex_xu go to meeting for a while | 09:18 | |
johnthetubaguy | oomichi: I know thats crazy annoying, but the contract needs to stay the same | 09:19 |
johnthetubaguy | oomichi: oh, I see you added the unit test for https://review.openstack.org/#/c/221129/3 as a follow on patch, thats cool | 09:19 |
oomichi | johnthetubaguy: do we need to strip white speces also? | 09:19 |
oomichi | johnthetubaguy: that is not my favorit api behaivor :( | 09:20 |
oomichi | johnthetubaguy: thanks :) | 09:20 |
johnthetubaguy | oomichi: that one is tricky, honestly, it feels like the right thing to do is follow what v2 did | 09:20 |
*** apuimedo has quit IRC | 09:20 | |
*** jerrygb has joined #openstack-nova | 09:20 | |
oomichi | yeah, maybe we need to follow "The first rule of kernel maintenance: YOU DO NOT BREAK USER SPACE!" | 09:21 |
oomichi | for v2.0 contract also. | 09:21 |
*** tojuvone_ has joined #openstack-nova | 09:21 | |
*** tojuvone has quit IRC | 09:21 | |
*** otter768 has quit IRC | 09:21 | |
*** tojuvone_ has quit IRC | 09:22 | |
*** tojuvone_ has joined #openstack-nova | 09:22 | |
danpb | lEDK | 09:23 |
*** tojuvone_ has quit IRC | 09:23 | |
*** penick has joined #openstack-nova | 09:24 | |
*** tojuvone has joined #openstack-nova | 09:24 | |
*** jerrygb has quit IRC | 09:26 | |
johnthetubaguy | oomichi: yeah, thats where I am at right now | 09:26 |
oomichi | johnthetubaguy: I know :) even if users are using API with wrong way | 09:27 |
johnthetubaguy | oomichi: tempest was using the API wrong, as an example | 09:27 |
johnthetubaguy | oomichi: it was our fault for making it easy to use the API wrongly, at least we are fixing that now, in a controlled way, so thats awesome | 09:28 |
oomichi | johnthetubaguy: oops, nice point. and sometime, I approved such tempest patch which did it :( | 09:29 |
johnthetubaguy | oomichi: its totally fine, you have been campaigning to fix this for years, just glad to see it getting somewhere, its awesome stuff :) | 09:31 |
*** dims has joined #openstack-nova | 09:31 | |
oomichi | johnthetubaguy: thanks so much :-) | 09:31 |
oomichi | johnthetubaguy: and you also worked/reviewed hardly for strong validation when implementing framework part. that was good input | 09:33 |
johnthetubaguy | oomichi: no problem, its important stuff | 09:33 |
openstackgerrit | Bartosz Fic proposed openstack/nova: libvirt: Rollback on dest host after deleting vm during live migration https://review.openstack.org/185958 | 09:33 |
*** chhavi has quit IRC | 09:34 | |
openstackgerrit | Marian Horban proposed openstack/nova: [WIP]Remove wsgi functionality https://review.openstack.org/219248 | 09:35 |
*** e0ne has quit IRC | 09:35 | |
*** lpetrut has joined #openstack-nova | 09:36 | |
*** alexpilotti_ has joined #openstack-nova | 09:37 | |
*** SourabhP_ has joined #openstack-nova | 09:37 | |
*** dims has quit IRC | 09:38 | |
*** oomichi has quit IRC | 09:38 | |
*** SourabhP has quit IRC | 09:40 | |
*** SourabhP_ is now known as SourabhP | 09:40 | |
*** julien_ZTE has quit IRC | 09:41 | |
*** Jeffrey4l has quit IRC | 09:41 | |
*** e0ne has joined #openstack-nova | 09:42 | |
*** aix has quit IRC | 09:45 | |
johnthetubaguy | garyk: hey, I promised to catch up with you this morning about those patches | 09:46 |
johnthetubaguy | garyk: let me know when its a good time to catch up | 09:46 |
*** pixelbeat has joined #openstack-nova | 09:46 | |
openstackgerrit | Rajesh Tailor proposed openstack/nova: Fix order of arguments in assertEqual https://review.openstack.org/222093 | 09:48 |
*** gszasz has joined #openstack-nova | 09:49 | |
*** dims has joined #openstack-nova | 09:49 | |
rajesht | johnthetubaguy, jaypipes: its small fix https://review.openstack.org/#/c/221739/ | 09:49 |
rajesht | johnthetubaguy, jaypipes: thanks :) | 09:49 |
*** ijw_ has joined #openstack-nova | 09:50 | |
*** SourabhP_ has joined #openstack-nova | 09:50 | |
*** SourabhP has quit IRC | 09:51 | |
*** SourabhP_ is now known as SourabhP | 09:51 | |
*** ijw_ has quit IRC | 09:54 | |
*** zhangjn has quit IRC | 09:56 | |
*** salv-orl_ has joined #openstack-nova | 09:56 | |
*** matrohon has quit IRC | 09:57 | |
*** kylek3h has joined #openstack-nova | 09:59 | |
*** salv-orlando has quit IRC | 10:00 | |
*** haomaiwang has quit IRC | 10:01 | |
*** haomaiwang has joined #openstack-nova | 10:01 | |
alex_xu | johnthetubaguy: oomichi, hope this better https://etherpad.openstack.org/p/liberty-nova-priorities-tracking | 10:01 |
johnthetubaguy | alex_xu: thats almost beautiful, thanks for the updates | 10:02 |
alex_xu | johnthetubaguy: np | 10:02 |
* alex_xu go home and dinner, back after few hours | 10:02 | |
*** kylek3h has quit IRC | 10:04 | |
*** salv-orl_ has quit IRC | 10:04 | |
*** salv-orl_ has joined #openstack-nova | 10:05 | |
*** penick has quit IRC | 10:07 | |
*** salv-orl_ has quit IRC | 10:10 | |
*** salv-orlando has joined #openstack-nova | 10:11 | |
*** aix has joined #openstack-nova | 10:13 | |
*** salv-orl_ has joined #openstack-nova | 10:13 | |
*** SourabhP has quit IRC | 10:15 | |
*** salv-orlando has quit IRC | 10:16 | |
*** kmartin has quit IRC | 10:20 | |
*** asselin_ has quit IRC | 10:20 | |
openstackgerrit | Roman Podoliaka proposed openstack/nova: novnc: move config options into [novnc] group https://review.openstack.org/222113 | 10:20 |
*** salv-orlando has joined #openstack-nova | 10:25 | |
*** pbrooko has joined #openstack-nova | 10:25 | |
*** salv-orl_ has quit IRC | 10:26 | |
*** Sree has quit IRC | 10:26 | |
*** Sree has joined #openstack-nova | 10:26 | |
*** Sree has quit IRC | 10:30 | |
*** alex_klimov has quit IRC | 10:31 | |
*** bfic has quit IRC | 10:31 | |
*** zhenguo has quit IRC | 10:33 | |
*** smatzek has joined #openstack-nova | 10:37 | |
*** humble__ has joined #openstack-nova | 10:40 | |
*** humble_ has quit IRC | 10:40 | |
*** irenab has quit IRC | 10:41 | |
*** irenab has joined #openstack-nova | 10:42 | |
*** alexpilotti_ has quit IRC | 10:43 | |
*** salv-orl_ has joined #openstack-nova | 10:48 | |
*** shyu has quit IRC | 10:48 | |
*** ZZelle has quit IRC | 10:49 | |
*** ZZelle has joined #openstack-nova | 10:49 | |
*** ijw_ has joined #openstack-nova | 10:51 | |
*** salv-orlando has quit IRC | 10:51 | |
*** salv-orl_ has quit IRC | 10:51 | |
*** salv-orlando has joined #openstack-nova | 10:52 | |
*** pbrooko has quit IRC | 10:52 | |
*** ijw_ has quit IRC | 10:56 | |
*** markvoelker has joined #openstack-nova | 10:59 | |
garyk | johnthetubaguy: sorry been out. | 11:00 |
garyk | i saw the comments on the patch. i'll address them | 11:00 |
*** moshele has joined #openstack-nova | 11:00 | |
*** haomaiwang has quit IRC | 11:01 | |
*** haomaiwang has joined #openstack-nova | 11:01 | |
johnthetubaguy | garyk: cool, no worries, I was mostly trying to get my head around the code in there, totally agreed with your intent | 11:01 |
johnthetubaguy | garyk: I also have a (hopefully quick) vmware question on this patch: https://review.openstack.org/#/c/205269/4 | 11:02 |
johnthetubaguy | garyk: I am wondering if we could just always turn that odd, and not worry about adding a new config variable? | 11:02 |
*** ociuhandu has joined #openstack-nova | 11:02 | |
*** robcresswell has joined #openstack-nova | 11:03 | |
*** takedakn has quit IRC | 11:04 | |
*** markvoelker has quit IRC | 11:04 | |
*** gerhardq1x has quit IRC | 11:04 | |
garyk | johnthetubaguy: i think that this should maybe even be a image property. | 11:05 |
robcresswell | Hello! I'm one of the horizon folks, just reviewing https://review.openstack.org/#/c/220838 which allows shelve/unshelve of an instance. Code looks good, but I'm unfamiliar with the difference between shelve and shelve_offload. The API call here appears to be to shelve rather than shelve offload, but the status set after is "Shelved Offloaded". Just wondering if anyone could explain further, o | 11:06 |
robcresswell | r point me at some docs? | 11:06 |
robcresswell | Gah, long message. | 11:06 |
johnthetubaguy | garyk: I could see an argument for that, true | 11:06 |
johnthetubaguy | garyk: I just wonder why we can't just have it on for every instance, is it likely to cause a problem? | 11:06 |
johnthetubaguy | robcresswell: so the best person to ask is alaski | 11:07 |
garyk | but due to the fact that i am really not familiar with this and my guess is the the guy posting the patch has a real issue with it that the config parameter is a valid option at the moment | 11:07 |
robcresswell | johnthetubaguy: Ah, thanks. Do you happen to know their tz? | 11:07 |
*** ociuhandu_ has joined #openstack-nova | 11:08 | |
*** achanda has joined #openstack-nova | 11:08 | |
johnthetubaguy | robcresswell: east coast US I think, he is in NC if my memory is correct | 11:08 |
*** ociuhandu has quit IRC | 11:08 | |
danpb | garyk: i don't really see a point in a config variable or image prop - it should just be turned on all the time | 11:08 |
*** ociuhandu_ is now known as ociuhandu | 11:08 | |
robcresswell | Cool, I'll return in a few hours. Thanks for your help | 11:08 |
garyk | danpb: why? | 11:09 |
danpb | because all non-virtualized hardware provides a disk serial by default | 11:09 |
garyk | danpb: i am not familiar with this support so i really do not have a strong opinion here. from what i have read it is valid for windows os's | 11:09 |
johnthetubaguy | robcresswell: its either the snapshot having been taken, or the instance having been removed from the host, and I would have to go digging to check that now, better to ask the person who will know I think | 11:09 |
garyk | danpb: ok. | 11:09 |
danpb | the /dev/disk/by-id/ links are formed automatically based on the unique disk serial string exposed by drives | 11:09 |
danpb | the libvirt driver has them enabled unconditionally and all real hardware provides them | 11:10 |
danpb | unless the vmware implementation somehow leaks sensitive data there's no compelling reason to turn it off | 11:10 |
robcresswell | johnthetubaguy: Yeah, I don't want to waste anyones time at this point in the cycle. Just wrapping up some of our FFEs. | 11:10 |
*** gerhardqux has joined #openstack-nova | 11:10 | |
johnthetubaguy | danpb: OK, I was thinking similar lines, I don't remember it being an option in the past | 11:10 |
garyk | danpb: ok, makes sense. i just would like to test it prior if possible to see that it does not cause issues | 11:10 |
johnthetubaguy | robcresswell: cool, let me know if you can't get an answer, and I can go for a dig | 11:11 |
robcresswell | johnthetubaguy: Thanks, much appreciated. | 11:11 |
johnthetubaguy | garyk: +1, the CI should cover that OK I think? | 11:11 |
garyk | johnthetubaguy: correct | 11:12 |
*** achanda has quit IRC | 11:12 | |
*** humble__ has quit IRC | 11:12 | |
garyk | johnthetubaguy: danpb: http://kb.vmware.com/selfservice/microsites/search.do?language=en_US&cmd=displayKC&externalId=2079220 | 11:15 |
*** deepthi has quit IRC | 11:15 | |
garyk | there may be issues with snapshots when this is True | 11:15 |
garyk | this could be for older ESX versions, but that might be something we want to support | 11:16 |
garyk | in the kb it said that the issue is resolved in 5.5 so i am ok i guess | 11:17 |
johnthetubaguy | garyk: whats our min supported version now? I forget? | 11:17 |
danpb | garyk: IIUC, the issue with snapshots is about when you change that for an already running guest | 11:17 |
johnthetubaguy | garyk: ah, cool, seems its fixed in 5.1 with a hotfix as well | 11:17 |
garyk | the min supported version is 5.1 - but all of the people who are using the driver are using 5.5 onwards. | 11:17 |
*** alex_klimov has joined #openstack-nova | 11:17 | |
garyk | when i wanted to set 5.5. in the last cycle there were objects from cores to do that | 11:18 |
garyk | objects => objections | 11:18 |
*** otter768 has joined #openstack-nova | 11:18 | |
*** ijw_ has joined #openstack-nova | 11:18 | |
johnthetubaguy | garyk: yeah, we need deprecation cycles for that kind of thing | 11:18 |
johnthetubaguy | garyk: anyways, looks like we should be safe | 11:18 |
* johnthetubaguy goes for some lunch | 11:19 | |
openstackgerrit | Alexander Schmidt proposed openstack/nova: libvirt: Acquire TCP ports for console during live migration https://review.openstack.org/215102 | 11:19 |
*** salv-orl_ has joined #openstack-nova | 11:21 | |
*** amrith has left #openstack-nova | 11:21 | |
*** jerrygb has joined #openstack-nova | 11:21 | |
*** otter768 has quit IRC | 11:23 | |
*** ijw_ has quit IRC | 11:23 | |
*** salv-orl_ has quit IRC | 11:24 | |
*** salv-orl_ has joined #openstack-nova | 11:24 | |
*** shoutm has quit IRC | 11:24 | |
*** salv-orlando has quit IRC | 11:25 | |
*** jerrygb has quit IRC | 11:26 | |
*** shoutm has joined #openstack-nova | 11:26 | |
*** cbits has joined #openstack-nova | 11:27 | |
*** cbits has left #openstack-nova | 11:27 | |
*** kylek3h has joined #openstack-nova | 11:29 | |
*** apuimedo has joined #openstack-nova | 11:29 | |
sdague | johnthetubaguy: did you get your novaclient patch sorted? | 11:30 |
*** irenab has quit IRC | 11:30 | |
*** deepakcs has quit IRC | 11:31 | |
*** irenab has joined #openstack-nova | 11:32 | |
*** kylek3h has quit IRC | 11:33 | |
*** pbrooko has joined #openstack-nova | 11:34 | |
*** salv-orl_ has quit IRC | 11:34 | |
*** aix has quit IRC | 11:34 | |
*** salv-orlando has joined #openstack-nova | 11:35 | |
*** aix has joined #openstack-nova | 11:35 | |
openstackgerrit | Alexander Schmidt proposed openstack/nova: libvirt: Acquire TCP ports for console during live migration https://review.openstack.org/215102 | 11:36 |
openstackgerrit | Sergey Nikitin proposed openstack/nova: WIP: Use legacy engineFacade from oslo_db.enginefacade https://review.openstack.org/221310 | 11:38 |
*** dave-mccowan has joined #openstack-nova | 11:38 | |
alex_xu | sdague: you mean this one https://review.openstack.org/221222? | 11:38 |
*** thorst has joined #openstack-nova | 11:44 | |
openstackgerrit | Alex Xu proposed openstack/nova: Allow leading/trailing whitespaces for name fields in Nova API https://review.openstack.org/220791 | 11:45 |
*** VikasC has quit IRC | 11:46 | |
*** rajesht has quit IRC | 11:48 | |
openstackgerrit | Sudipta Biswas proposed openstack/nova: add helper method to obtain image client version https://review.openstack.org/222150 | 11:49 |
*** jamielennox is now known as jamielennox|away | 11:49 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [BugFix] Change parameters for legacy bdm https://review.openstack.org/221525 | 11:50 |
*** rajesht has joined #openstack-nova | 11:51 | |
openstackgerrit | Alex Xu proposed openstack/nova: Add version parameter for servers schema extension points https://review.openstack.org/222032 | 11:51 |
openstackgerrit | Alex Xu proposed openstack/nova: Allow leading/trailing whitespaces for name fields in Nova API https://review.openstack.org/220791 | 11:51 |
*** venkat_p has quit IRC | 11:51 | |
garyk | sdague: can you please look at https://review.openstack.org/221146 - this will unlock all of the neutro external CI's (it has a lot of karma from neutron folk) | 11:51 |
*** ociuhandu has quit IRC | 11:51 | |
*** mwagner_lap has joined #openstack-nova | 11:52 | |
alex_xu | sdague: appreciate if you can take a look at https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/1491511,n,z when you have time. it's about server name validation bug. thanks in advance! | 11:52 |
*** markvoelker has joined #openstack-nova | 11:55 | |
*** rfolco has joined #openstack-nova | 11:56 | |
*** ankit_ag has quit IRC | 11:57 | |
*** bkopilov has quit IRC | 11:59 | |
*** haomaiwang has quit IRC | 12:01 | |
*** haomaiwang has joined #openstack-nova | 12:01 | |
sdague | alex_xu: yeh 221222 | 12:02 |
sdague | I'm not convinced that it's not a problem. We shouldn't make our libraries hard to use | 12:02 |
sdague | garyk: done | 12:02 |
*** jistr is now known as jistr|mtg | 12:03 | |
garyk | sdague: thank you! | 12:04 |
*** sudipto has quit IRC | 12:04 | |
alex_xu | sdague: yea, the other is going to fix the problem of how they use nova client | 12:04 |
sdague | alex_xu: so that's fine, but the fact that we do a very silly thing by default seems wrong | 12:04 |
alex_xu | sdague: and there is patch from andreykurilin https://review.openstack.org/221706 for log some warning | 12:04 |
alex_xu | sdague: yea, actually I'm a little think about that also. in theory we should keep the same behavior | 12:06 |
*** READ10 has joined #openstack-nova | 12:06 | |
sdague | so I'm fine with andreykurilin's patches | 12:06 |
sdague | however, I still think we should not do a bad thing here | 12:06 |
andreykurilin | sdague: thanks:) | 12:07 |
sdague | andreykurilin: one import issue in patch #2 | 12:07 |
sdague | but conceptually fine | 12:07 |
sdague | however, I do think that if people call it the way horizon did, it should set sane defaults and kind of work | 12:08 |
sdague | the idea that we'd send no version, but default to max version, just seems wrong | 12:08 |
*** diogogmt has quit IRC | 12:08 | |
alex_xu | yea, I also prefer to fix tha | 12:08 |
andreykurilin | sdague: I want to left warning import inside function, since it's needed in <1% of use cases | 12:09 |
sdague | andreykurilin: sure, but warnings don't always expose. | 12:10 |
sdague | anyway, seems like we could set the defaults slightly differently to not mismatch our expectations here | 12:10 |
andreykurilin | sdague, alex_xu: the way horizon did, can be fixed by one line in novaclient.v2.client.Client.__init__ . something like "if api_version is None: api_version = APIVersion("2.0")" | 12:10 |
alex_xu | andreykurilin: sounds cool | 12:11 |
sdague | andreykurilin: that sounds reasonable, can you do that patch | 12:11 |
*** zhangjn has joined #openstack-nova | 12:12 | |
*** kolesovdv has joined #openstack-nova | 12:12 | |
andreykurilin | sdague: sure | 12:12 |
alex_xu | andreykurilin: cool, thanks | 12:12 |
*** zhangjn has quit IRC | 12:13 | |
*** zhangjn has joined #openstack-nova | 12:13 | |
*** kylek3h has joined #openstack-nova | 12:13 | |
* alex_xu plan to take a rest, and enjoy the times with baby daughter | 12:14 | |
*** kse has quit IRC | 12:14 | |
*** moshele has quit IRC | 12:15 | |
*** moshele has joined #openstack-nova | 12:15 | |
*** zhangjn has quit IRC | 12:16 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Deprecate 'novaclient.client.get_client_class' https://review.openstack.org/221789 | 12:18 |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Set api_version to 2.0 by default for v2.Client https://review.openstack.org/222162 | 12:18 |
andreykurilin | sdague, alex_xu: ^ | 12:19 |
*** changbl has quit IRC | 12:22 | |
*** dims has quit IRC | 12:22 | |
*** salv-orl_ has joined #openstack-nova | 12:23 | |
*** dims has joined #openstack-nova | 12:23 | |
johnthetubaguy | andreykurilin: please to remind me to do a new client release to include all these patches of yours in the liberty version (we may need to do backports and things) | 12:25 |
sdague | andreykurilin: thank you | 12:26 |
*** salv-orlando has quit IRC | 12:27 | |
johnthetubaguy | sdague: does this warning need translating? https://review.openstack.org/#/c/221789/3/novaclient/client.py,cm | 12:28 |
*** salv-orlando has joined #openstack-nova | 12:29 | |
*** burgerk has joined #openstack-nova | 12:29 | |
*** zzzeek has joined #openstack-nova | 12:29 | |
andreykurilin | johnthetubaguy: when all needed patches will be merged in master, I'll send backports to liberty and ping you:) | 12:29 |
johnthetubaguy | andreykurilin: sounds cool, thank you | 12:30 |
*** salv-orl_ has quit IRC | 12:30 | |
*** Marga_ has joined #openstack-nova | 12:31 | |
*** Marga_ has quit IRC | 12:31 | |
sdague | johnthetubaguy: are we actually translating novaclient? | 12:32 |
johnthetubaguy | andreykurilin: do you know about the comment I added on 221789? I am unsure if we have to translate those warning strings? do you know what is done else where in novaclient? | 12:32 |
johnthetubaguy | sdague: so I am unsure | 12:32 |
*** Marga_ has joined #openstack-nova | 12:32 | |
andreykurilin | sdague: we started translation | 12:32 |
johnthetubaguy | sdague: I noticed _ was imported at the top of there, so I was unsure | 12:32 |
sdague | ok, so yeh, probably we should translate that string then | 12:32 |
andreykurilin | https://github.com/openstack/python-novaclient/commit/e612205ab850b291a78e539d15923c8716d90158 | 12:32 |
sdague | johnthetubaguy: good catch | 12:33 |
*** armax has quit IRC | 12:33 | |
johnthetubaguy | andreykurilin: was that a good idea though? given we are looking to replace it, ideally. | 12:33 |
johnthetubaguy | anyways, thats for another time | 12:33 |
johnthetubaguy | lets just be self-consistent for now | 12:34 |
*** haomaiwang has quit IRC | 12:35 | |
*** bswartz has quit IRC | 12:36 | |
*** salv-orl_ has joined #openstack-nova | 12:36 | |
*** salv-orlando has quit IRC | 12:36 | |
*** linkmark has joined #openstack-nova | 12:37 | |
*** e0ne has quit IRC | 12:37 | |
* jaypipes has returned from the land of the dead | 12:39 | |
*** jerrygb has joined #openstack-nova | 12:40 | |
*** rlrossit has joined #openstack-nova | 12:40 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova-specs: Proposes the RequestSpec object for Mitaka https://review.openstack.org/220312 | 12:41 |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Deprecate 'novaclient.client.get_client_class' https://review.openstack.org/221789 | 12:41 |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Restrict direct usage of novaclient.v2.client https://review.openstack.org/221706 | 12:41 |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Set api_version to 2.0 by default for v2.Client https://review.openstack.org/222162 | 12:41 |
andreykurilin | johnthetubaguy, sdague: I updated patches with tranlation. Please re-approve them:) | 12:42 |
*** dustins has joined #openstack-nova | 12:42 | |
bauzas | jaypipes: visited France ? | 12:42 |
* bauzas jk | 12:42 | |
*** kodokuu has joined #openstack-nova | 12:42 | |
andreykurilin | johnthetubaguy: I can't say was it good idea or not, because I don't know alternative:) | 12:43 |
*** jerrygb has quit IRC | 12:45 | |
*** moshele has quit IRC | 12:45 | |
*** xyang1 has joined #openstack-nova | 12:45 | |
jaypipes | bauzas: lol :) | 12:45 |
*** rods has joined #openstack-nova | 12:46 | |
* bauzas saw a documentary yesterday called "French Bashing" | 12:46 | |
bauzas | just awesomeness | 12:46 |
*** aysyd has joined #openstack-nova | 12:47 | |
johnthetubaguy | bauzas: was that an english documentary ;) | 12:47 |
bauzas | johnthetubaguy: even not, a French one | 12:47 |
johnthetubaguy | andreykurilin: don't you need to add _(...) to that string you added? I know we don't normally update the pot when we add a string, at least in Nova | 12:48 |
johnthetubaguy | bauzas: crazy | 12:48 |
bauzas | yeah, kinda self-beating | 12:49 |
*** vladikr has joined #openstack-nova | 12:49 | |
*** kodokuu has quit IRC | 12:50 | |
andreykurilin | johnthetubaguy: I already added _LW(..), which is enough:) about pot files: this process is unclear for me - when and how it should be updated? | 12:50 |
bauzas | andreykurilin: lemme find some docs | 12:51 |
johnthetubaguy | andreykurilin: I think the pot just happens when we do a release an update the translation, or something like that | 12:51 |
johnthetubaguy | andreykurilin: I don't see the _LW(...) I might be going blind | 12:51 |
andreykurilin | ok, will remove changes of pot files | 12:51 |
*** julien_ZTE has joined #openstack-nova | 12:51 | |
bauzas | andreykurilin: https://wiki.openstack.org/wiki/Translations#Python_Projects_.28General.29 | 12:51 |
bauzas | andreykurilin: the pot files are done by the i18n team | 12:52 |
andreykurilin | johnthetubaguy: wait a moment please. need a minute to update patches | 12:52 |
*** jistr|mtg is now known as jistr | 12:52 | |
johnthetubaguy | andreykurilin: no problems | 12:52 |
andreykurilin | bauzas: thanks for the link | 12:54 |
*** y_sawai has joined #openstack-nova | 12:55 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Deprecate 'novaclient.client.get_client_class' https://review.openstack.org/221789 | 12:55 |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Restrict direct usage of novaclient.v2.client https://review.openstack.org/221706 | 12:55 |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: Set api_version to 2.0 by default for v2.Client https://review.openstack.org/222162 | 12:55 |
andreykurilin | johnthetubaguy: done | 12:55 |
bauzas | andreykurilin: oh it seems you have to provide at least the main pot to make sure the CI can catch it, see https://review.openstack.org/#/c/182848/ | 12:55 |
johnthetubaguy | bauzas: they already did all that I think | 12:56 |
bauzas | ack | 12:56 |
andreykurilin | yes, novaclient already has such file | 12:56 |
andreykurilin | *added few days ago | 12:56 |
bauzas | okay, then you just have to follow the above link | 12:57 |
* johnthetubaguy wonders if he just made the backport harder, oops | 12:57 | |
*** andreykurilin__ has joined #openstack-nova | 12:58 | |
bauzas | meh, can't find the client in Transifex ? | 12:59 |
bauzas | I mean the python-novaclient | 12:59 |
johnthetubaguy | bauzas: maybe that bit has not been done, hmm | 13:00 |
bauzas | johnthetubaguy: surely | 13:00 |
bauzas | that's i18n duty here | 13:00 |
*** armax has joined #openstack-nova | 13:02 | |
bauzas | andreykurilin: johnthetubaguy: who is actually asking for translating the client? I can see that both the job and transifex are missing, and per the docs, that's the project which should request for that, not the translations team | 13:03 |
*** armax has quit IRC | 13:04 | |
bauzas | AFAICS, only magnum is having its client translated atm | 13:04 |
bauzas | (and openstackclient) | 13:05 |
*** takedakn has joined #openstack-nova | 13:05 | |
*** armax has joined #openstack-nova | 13:08 | |
*** ctrath has joined #openstack-nova | 13:09 | |
johnthetubaguy | yeah, I am thinking we should skip ours, to give openstackclient more of a chance | 13:09 |
johnthetubaguy | but lets discuss that later | 13:09 |
*** baoli has joined #openstack-nova | 13:10 | |
*** zhenguo has joined #openstack-nova | 13:11 | |
*** edmondsw has joined #openstack-nova | 13:12 | |
*** takedakn has quit IRC | 13:15 | |
*** baoli_ has joined #openstack-nova | 13:16 | |
bauzas | johnthetubaguy: agreed | 13:17 |
*** otter768 has joined #openstack-nova | 13:19 | |
*** baoli has quit IRC | 13:19 | |
*** mdrabe has joined #openstack-nova | 13:22 | |
*** links has quit IRC | 13:23 | |
*** otter768 has quit IRC | 13:23 | |
openstackgerrit | John Garbutt proposed openstack/nova: VMware: enable a resize of instance with no root disk https://review.openstack.org/173802 | 13:24 |
*** sudipto has joined #openstack-nova | 13:27 | |
garyk | johnthetubaguy: did that need to be rebased. it has been in review since april? | 13:27 |
*** VW_ has joined #openstack-nova | 13:28 | |
garyk | in addition to that there is a critical security bug that has got the sub team karma but that ironically is get no eyes | 13:28 |
*** moshele has joined #openstack-nova | 13:28 | |
johnthetubaguy | garyk: I am lazy and it need a recheck, seems good just to check it was rebased | 13:28 |
*** mriedem has joined #openstack-nova | 13:28 | |
johnthetubaguy | garyk: can you send me a link and I can take a look? | 13:28 |
garyk | https://review.openstack.org/220410 | 13:29 |
garyk | it also has ci +1 | 13:29 |
johnthetubaguy | garyk: ah, I see that in the etherpad now, didn't see it for the other ones | 13:29 |
garyk | we gave up on adding the other other ones as they were not being reviewed. | 13:30 |
johnthetubaguy | garyk: as I said, people have promised to start looking at that, most the midcycle, as people had not really looked at it before then, some of the other sections do seem to be getting traction now | 13:31 |
tonyb | alex_xu: If you're around can you look at https://review.openstack.org/#/c/203809/ and see if you're still -1? | 13:31 |
*** changbl has joined #openstack-nova | 13:31 | |
garyk | yes, i understand that. it just seems like real issues are being over looked. | 13:31 |
johnthetubaguy | garyk: if we can get the most important ones in that list, we can do our best to get to them | 13:32 |
mriedem | garyk: for a long time wasn't https://review.openstack.org/#/c/220410/ being fixed by some other change? | 13:32 |
mriedem | i'm thinking of this https://review.openstack.org/#/c/197192/ | 13:32 |
BoBall_AWOL | bauzas: Curious... Thanks. | 13:32 |
garyk | mriedem: no, they are two different issues. | 13:33 |
mriedem | different bugs i guess | 13:33 |
*** e0ne has joined #openstack-nova | 13:33 | |
mriedem | fwiw i wasn't getting into https://review.openstack.org/#/c/197192/ until you were +1 on it | 13:33 |
garyk | that patch also is really off the grid and the real change should be https://review.openstack.org/218639 | 13:33 |
*** jecarey has joined #openstack-nova | 13:33 | |
garyk | that just needs a few more unit tests | 13:33 |
*** sudipto has quit IRC | 13:33 | |
garyk | i am still working on those tests at the moment and hopefully will have a patch in the coming days | 13:35 |
*** browne has joined #openstack-nova | 13:36 | |
*** smatzek has quit IRC | 13:37 | |
andreykurilin | bauzas, johnthetubaguy : novaclient uses oslo.i18n for historical reasons and several days ago, mriedem started a thread to know these reasons ( http://lists.openstack.org/pipermail/openstack-dev/2015-September/073698.html ). After the first letter, doffm starts to fully enabling internationalization | 13:39 |
*** oomichi has joined #openstack-nova | 13:40 | |
*** jerrygb has joined #openstack-nova | 13:41 | |
oomichi | johnthetubaguy: sdague: hi, can you take a look at openstack-specs: https://review.openstack.org/#/c/181393/ ? | 13:42 |
mriedem | andreykurilin: is there a question? | 13:43 |
oomichi | that will be nice input for the next working items of Mitaka, I guess | 13:43 |
*** zhangjn has joined #openstack-nova | 13:43 | |
*** zhangjn has quit IRC | 13:43 | |
mriedem | this is an upgrade issue in kilo and juno, would be good to get it in so the backports can start moving: https://review.openstack.org/#/c/222022/ | 13:44 |
*** thangp has joined #openstack-nova | 13:44 | |
andreykurilin | mriedem: hi! not from me:) | 13:45 |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Set vif and allocated when associating fixed ip https://review.openstack.org/197135 | 13:45 |
*** jerrygb has quit IRC | 13:45 | |
*** sudipto has joined #openstack-nova | 13:45 | |
andreykurilin | mriedem: bauzas wrote: ...who is actually asking for translating the client? I can see that both the job and transifex are missing, and per the docs, that's the project which should request for that, not the translations team | 13:45 |
alex_xu | tonyb: does https://review.openstack.org/#/c/203809/ distinguish endian? | 13:45 |
mriedem | andreykurilin: ah, yeah, | 13:46 |
mriedem | it's trivial to get translation jobs setup for novaclient | 13:47 |
mriedem | so we went ahead and did it | 13:47 |
mriedem | doffm: did you find out how we are supposed to request a python-novaclient project in zanata? | 13:47 |
tonyb | alex_xu: Yes in that it compares guestarch to arch.PPC64 ,which is big endian, but doesn't include arch.PPC64LE | 13:47 |
mriedem | the wiki instructions were written for transifex which is being sunset for openstack i18n | 13:47 |
*** browne has quit IRC | 13:48 | |
alex_xu | tonyb: ah, I see now, thanks for the explain, I will remove -1 | 13:48 |
tonyb | alex_xu: thanks. | 13:48 |
alex_xu | tonyb: np | 13:48 |
tonyb | alex_xu: PPC64* is a bit "special" ;P | 13:48 |
alex_xu | tonyb: yea :) | 13:49 |
tonyb | alex_xu: FWIW I have tested F21 (ppc64le) with spice and it works but I'd hesitate to call it supported. | 13:50 |
andreykurilin | mriedem: btw, while you are here - can you look at series of small patches started by https://review.openstack.org/#/c/221706 ? it was previously approved, but I forgot about _(), so I was forced to resubmit patches | 13:50 |
*** ajayaa has quit IRC | 13:51 | |
*** Piet has quit IRC | 13:52 | |
alex_xu | tonyb: anyway I still felt the instance failed after boot looks bad experience for the user. | 13:52 |
timello | alex_xu, tonyb, thank you for the reviews and comments. I'd appreciate if we can get approval there. | 13:52 |
doffm | mriedem: No. I'll ask in i18n today. Or send to list. It looks like everything that has a transifex project has been moved over. | 13:52 |
alex_xu | timello: yea, good luck | 13:53 |
*** whenry has quit IRC | 13:53 | |
tonyb | alex_xu: Yes I agree but the way the code is right now we can't really do better than timello's patch. | 13:53 |
alex_xu | tonyb: yea | 13:53 |
timello | I agree with alex_xu comments... the ideal would be to tell the operator asap | 13:54 |
tonyb | alex_xu: Is a silent failure better or worse than an ERROR? | 13:54 |
*** obedmr has joined #openstack-nova | 13:54 | |
alex_xu | tonyb: slient is worse | 13:54 |
mriedem | doffm: https://translate-dev.openstack.org/project/view/python-novaclient | 13:54 |
mriedem | doffm: i'm asking in #openstack-i18n what else needs to be done | 13:54 |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [BugFix] Change parameters for legacy bdm https://review.openstack.org/221525 | 13:55 |
tonyb | alex_xu: right so this is better. | 13:55 |
tonyb | alex_xu: still a bad user experience but better | 13:55 |
*** shoutm has quit IRC | 13:55 | |
* tonyb read a lot of kernel code on this review | 13:55 | |
alex_xu | tonyb: yea, I also didn't find out better way in current | 13:56 |
*** lmtaylor has joined #openstack-nova | 13:57 | |
*** zhangjn has joined #openstack-nova | 13:58 | |
*** dannywilson has joined #openstack-nova | 13:59 | |
BoBall_AWOL | bauzas: No idea what's going on - but I'm on vacation so I've just disabled the CI | 14:00 |
johnthetubaguy | mriedem: I guess there is no harm in it, I was just wondering we should hold off on translations if we have the openstackclient on its way? | 14:00 |
mriedem | timello: rfolco: is there a bug for this? https://review.openstack.org/#/c/203809/ | 14:00 |
mriedem | johnthetubaguy: translations are free | 14:00 |
mriedem | and lots of people aren't using osc | 14:01 |
*** whenry has joined #openstack-nova | 14:01 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add microversion bump exception for scheduler-hint https://review.openstack.org/221642 | 14:01 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add API schema for different_cell filter https://review.openstack.org/220893 | 14:01 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add microversion rule when adding attr to request https://review.openstack.org/222197 | 14:01 |
johnthetubaguy | mriedem: true | 14:01 |
*** smatzek has joined #openstack-nova | 14:01 | |
*** oomichi is now known as oomichi_away | 14:03 | |
rfolco | mriedem, there isn't a bug, it's the only failure on unit tests for ppc64 | 14:03 |
tonyb | mriedem: No I don't think there is an bug for that review. | 14:04 |
mriedem | seems like there should be | 14:04 |
openstackgerrit | Vladyslav Drok proposed openstack/nova: DO NOT MERGE - Triggering experimental pipeline https://review.openstack.org/220229 | 14:04 |
rfolco | mriedem, we can open one | 14:04 |
mriedem | rlrossit: timello: also, not sure about the new exception given string freeze | 14:04 |
mriedem | johnthetubaguy: https://review.openstack.org/#/c/203809/ - maybe that's ok given soft string freeze | 14:04 |
*** browne has joined #openstack-nova | 14:05 | |
*** mdrabe has quit IRC | 14:06 | |
*** shoutm has joined #openstack-nova | 14:07 | |
*** bkopilov has joined #openstack-nova | 14:08 | |
tonyb | mriedem: given the new "soft" string freeze I agree (FWIW) | 14:08 |
openstackgerrit | Claudiu Belu proposed openstack/nova-specs: Adds spec for exposing host capabilities https://review.openstack.org/222200 | 14:09 |
*** whenry has quit IRC | 14:09 | |
timello | mriedem: ok, will fix, thanks. | 14:10 |
mriedem | timello: so i guess just need a bug for that change and then i'm +2 | 14:10 |
mriedem | the zkvm guys will need to add a follow on change for s390/s390x | 14:10 |
mriedem | since that doesn't support spice | 14:10 |
mriedem | and he who controls the spice controls the galaxy | 14:10 |
timello | hehe | 14:10 |
timello | seems true | 14:11 |
alexschm | mriedem: what change are you referring to? | 14:11 |
*** whenry has joined #openstack-nova | 14:11 | |
mriedem | https://review.openstack.org/#/c/203809/ | 14:11 |
mriedem | timello: https://www.youtube.com/watch?v=mWq15lDh8yM&feature=youtu.be&t=50 | 14:13 |
mriedem | it's not every day i get to make a dune reference | 14:13 |
*** aswadr has joined #openstack-nova | 14:13 | |
*** dannywilson has quit IRC | 14:14 | |
*** abhishekk has left #openstack-nova | 14:14 | |
*** jerrygb has joined #openstack-nova | 14:15 | |
alexschm | yeah right timello, you could add S390 and S390X in that check as well | 14:16 |
*** tpeoples has joined #openstack-nova | 14:16 | |
alexschm | timello: I'll also add that comment via review | 14:16 |
timello | mriedem: haha, possibly blocked by country, I couldn't see it... argh | 14:16 |
timello | alexschm: cool, thanks | 14:16 |
tonyb | mriedem: "This video is not available" :( | 14:16 |
*** haomaiwang has joined #openstack-nova | 14:16 | |
mriedem | too bad | 14:16 |
timello | does google provide premium account for youtube? :) | 14:17 |
sdague | mriedem: ++ for dune ref | 14:18 |
mriedem | \o/ i'm glad someone got it | 14:18 |
*** electrocucaracha has joined #openstack-nova | 14:18 | |
timello | lol | 14:19 |
*** whenry has quit IRC | 14:19 | |
*** whenry has joined #openstack-nova | 14:19 | |
*** electrocucaracha has quit IRC | 14:19 | |
tonyb | mriedem: okay after reading the scrollback I see the dune reference | 14:20 |
tonyb | mriedem: it was obvious really | 14:20 |
mriedem | it's really the only thing one should think of first when talking about spice console | 14:20 |
tonyb | mriedem: :) | 14:21 |
*** electrocucaracha has joined #openstack-nova | 14:21 | |
*** marzif has joined #openstack-nova | 14:23 | |
*** vishwanathj has joined #openstack-nova | 14:23 | |
alexschm | Does anyone know yet what's going on with gate-grenade-dsvm right now? | 14:23 |
mriedem | alexschm: link? | 14:23 |
alexschm | it seems to be failing consistently | 14:23 |
alexschm | http://ci-watch.tintri.com/project?project=nova | 14:23 |
*** whenry has quit IRC | 14:24 | |
*** vishwanathj has quit IRC | 14:24 | |
mriedem | yup http://status.openstack.org/elastic-recheck/data/uncategorized.html | 14:25 |
mriedem | looking | 14:25 |
*** oomichi_away has quit IRC | 14:25 | |
mriedem | sdague: ^ you seen anything? | 14:25 |
*** Piet has joined #openstack-nova | 14:25 | |
mriedem | bad PyECLib install | 14:26 |
alexschm | src/c/pyeclib_c/pyeclib_c.c:32:25: fatal error: erasurecode.h: No such file or directory | 14:26 |
*** pkholkin has quit IRC | 14:26 | |
mriedem | yup | 14:26 |
mriedem | did that library put out a new release? | 14:26 |
*** tdurakov has quit IRC | 14:26 | |
mriedem | yup | 14:26 |
mriedem | https://pypi.python.org/pypi/PyECLib/1.0.9 | 14:26 |
sdague | alexschm: a lot of those are check queue | 14:26 |
mriedem | released 9/10 | 14:26 |
mriedem | sdague: it's all over the gate too | 14:27 |
sdague | mriedem: is it | 14:27 |
mriedem | yeah, uncategorized page is blowing up | 14:27 |
mriedem | opening a bug and getting a query up | 14:27 |
sdague | ah, yeh - gate-grenade-dsvm | 14:28 |
sdague | http://tinyurl.com/oowkhhb | 14:28 |
sdague | so that's because kilo isn't protected, right? | 14:28 |
mriedem | probably | 14:28 |
*** y_sawai has quit IRC | 14:29 | |
mriedem | yup https://github.com/openstack/requirements/blob/stable/kilo/global-requirements.txt#L102 | 14:29 |
sdague | pyeclib is also just a disaster of packaging | 14:29 |
mriedem | i'll push the cap | 14:29 |
*** y_sawai has joined #openstack-nova | 14:29 | |
*** diogogmt has joined #openstack-nova | 14:29 | |
mriedem | bug https://bugs.launchpad.net/openstack-gate/+bug/1494347 | 14:29 |
openstack | Launchpad bug 1494347 in OpenStack-Gate "PyECLib 0.9.0 released on 9/10 blowing up grenade jobs due to "src/c/pyeclib_c/pyeclib_c.c:32:25: fatal error: erasurecode.h: No such file or directory"" [Undecided,New] | 14:29 |
*** whenry has joined #openstack-nova | 14:29 | |
*** agireud has joined #openstack-nova | 14:29 | |
*** y_sawai has quit IRC | 14:29 | |
mriedem | sdague: heh, yeah, we had guys in china trying to package that for ppc64 and s390x too :) | 14:30 |
mriedem | not fun | 14:30 |
*** kumar has joined #openstack-nova | 14:30 | |
sdague | they include a tarball of the c library inside the package | 14:30 |
*** marzif has quit IRC | 14:30 | |
*** eharney has joined #openstack-nova | 14:30 | |
mriedem | yup | 14:30 |
mriedem | i know all too well | 14:30 |
mriedem | and there are like optional backends but the one that's bundled is the default and at one point it was trying to build it regardless of whether or not you were going to use it | 14:31 |
sdague | can you report an upstream bug as well? | 14:31 |
mriedem | plus some weird licensing issues | 14:31 |
mriedem | sure | 14:31 |
*** marzif has joined #openstack-nova | 14:31 | |
sdague | it looks like haypo has committed some to it, maybe figure out if he know's what's up | 14:32 |
*** kolesovdv has quit IRC | 14:32 | |
*** Daisy has joined #openstack-nova | 14:33 | |
sdague | so it looks like they thought they were working around this, but didn't understand the stable branch issue - https://bitbucket.org/kmgreen2/pyeclib/issues/69/need-a-release-108-with-python-3-fixes#comment-21621170 | 14:34 |
edleafe | :qa | 14:34 |
edleafe | jeez | 14:34 |
tonyb | edleafe: yes you should quit everything without saving ;P | 14:34 |
edleafe | tonyb: I've found that's best | 14:35 |
edleafe | :) | 14:35 |
tonyb | edleafe: ;P | 14:35 |
johnthetubaguy | tonyb: so I guess you are in texas this week? | 14:35 |
tonyb | johnthetubaguy: nope, just up late | 14:35 |
johnthetubaguy | tonyb: ah, fair enough | 14:35 |
tonyb | johnthetubaguy: which I shoudl fix given there is a nova meeting in 6.5 hours ;P | 14:36 |
tonyb | johnthetubaguy: it was a good guess though | 14:36 |
johnthetubaguy | tonyb: :) | 14:36 |
*** mdrabe has joined #openstack-nova | 14:36 | |
alexschm | sdague mriedem: looks like installing liberasurecode was made optional | 14:36 |
sdague | alexschm: where? | 14:37 |
alexschm | sdague mriedem: https://bitbucket.org/kmgreen2/pyeclib/commits/01ab5ddd6d9f11107c401c4e31ff28e526aca5ab | 14:37 |
mriedem | so a feature | 14:37 |
alexschm | no they meant to set it to "yes" by default | 14:38 |
alexschm | but I don't see any code setting install_libec = True | 14:38 |
alexschm | or install.initialize_options() is never called... | 14:39 |
*** tonytan4ever has joined #openstack-nova | 14:40 | |
*** y_sawai has joined #openstack-nova | 14:41 | |
*** shoutm has quit IRC | 14:42 | |
openstackgerrit | LinZhang proposed openstack/nova: Promoting visual machine performance(video, sound and other) in SPICE https://review.openstack.org/221326 | 14:42 |
*** cfriesen has joined #openstack-nova | 14:42 | |
*** salv-orl_ has quit IRC | 14:43 | |
*** salv-orlando has joined #openstack-nova | 14:43 | |
*** edtubill has joined #openstack-nova | 14:43 | |
*** whenry has quit IRC | 14:43 | |
*** salv-orlando has quit IRC | 14:44 | |
*** salv-orlando has joined #openstack-nova | 14:44 | |
*** moshele has quit IRC | 14:46 | |
mriedem | alexschm: sdague: right so the bug to pyeclib upstream is that they introduced that option but didn't default to the old behavior for backward compat | 14:46 |
*** claudiub has quit IRC | 14:47 | |
*** Daisy has quit IRC | 14:47 | |
*** whenry has joined #openstack-nova | 14:47 | |
*** Marga_ has quit IRC | 14:47 | |
*** Daisy has joined #openstack-nova | 14:48 | |
*** claudiub has joined #openstack-nova | 14:49 | |
*** ijuwang has joined #openstack-nova | 14:49 | |
bauzas | mriedem: so I was asking this translation question because there is no python client in Transifex nor for the CI translation job but only magnumclient and openstackclient | 14:49 |
*** moshele has joined #openstack-nova | 14:49 | |
mriedem | alexschm: sdague: https://bitbucket.org/kmgreen2/pyeclib/issues/76/pyeclib-109-fails-to-install-if-not | 14:50 |
bauzas | mriedem: so, the novaclient is not yet having a Transifex project nor a CI job | 14:50 |
openstackgerrit | dane-fichter proposed openstack/nova: Nova support for image-signing https://review.openstack.org/189843 | 14:50 |
openstackgerrit | Ed Leafe proposed openstack/nova: Add missing information to docstring https://review.openstack.org/222228 | 14:51 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Handle race in allocate_for_instance https://review.openstack.org/221803 | 14:51 |
*** mmedvede has joined #openstack-nova | 14:52 | |
*** zhangjn has quit IRC | 14:52 | |
*** lmtaylor has quit IRC | 14:52 | |
mriedem | bauzas: doffm is working on that | 14:52 |
bauzas | mriedem: okay, cool then | 14:52 |
*** Daisy has quit IRC | 14:52 | |
*** tdurakov has joined #openstack-nova | 14:53 | |
*** aix has quit IRC | 14:53 | |
*** pkholkin has joined #openstack-nova | 14:53 | |
*** burgerk has quit IRC | 14:53 | |
bauzas | doffm: in case you don't know, https://wiki.openstack.org/wiki/Translations#Python_Projects_.28General.29 | 14:53 |
mriedem | bauzas: he does | 14:54 |
mriedem | plus that's mostly out of date now | 14:54 |
mriedem | b/c of the move to zanata | 14:54 |
bauzas | awesomeness | 14:54 |
mriedem | we're in the #openstack-i18n channel working with clarkb | 14:54 |
bauzas | I reviewed that a couple of years for Blazar, hence me helping if needed | 14:55 |
bauzas | *ago | 14:55 |
mriedem | alexschm: btw, thanks for bringing up the grenade issues :) | 14:55 |
doffm | bauzas: Thanks. That part should be set up. | 14:55 |
*** e0ne has quit IRC | 14:55 | |
doffm | bauzas: Working on translation jobs. | 14:55 |
bauzas | mriedem: eh, moving out of Transifex ? | 14:57 |
doffm | bauzas: to Zanata. | 14:58 |
bauzas | doffm: oh, good to know, ty | 14:58 |
doffm | https://translate-dev.openstack.org/project/view/python-novaclient | 14:58 |
bauzas | I see... | 14:58 |
mriedem | bauzas: http://lists.openstack.org/pipermail/openstack-i18n/2015-September/thread.html | 14:59 |
*** marzif has quit IRC | 14:59 | |
bauzas | mriedem: thanks | 14:59 |
mriedem | <# | 14:59 |
mriedem | oops, <3 | 15:00 |
*** haomaiwang has quit IRC | 15:00 | |
*** kmartin has joined #openstack-nova | 15:00 | |
alexschm | mriedem: np, thanks for following up on this! | 15:01 |
*** vishwanathj has joined #openstack-nova | 15:03 | |
*** casusbelli has joined #openstack-nova | 15:03 | |
*** e0ne has joined #openstack-nova | 15:03 | |
*** rotbeard has quit IRC | 15:03 | |
claudiub | johnthetubaguy: hi. any thoughts on lily's comments on: https://review.openstack.org/#/c/213982/ ? | 15:04 |
*** Marga_ has joined #openstack-nova | 15:04 | |
johnthetubaguy | claudiub: I haven't see the comments, I will take a look | 15:04 |
PaulMurray | anyone know when ndipanov will be back? I guess he is on vacation or something | 15:04 |
*** READ10 has quit IRC | 15:05 | |
*** andreykurilin__ has quit IRC | 15:06 | |
bauzas | PaulMurray: next week | 15:06 |
PaulMurray | bauzas, thanks | 15:06 |
*** rdopiera has quit IRC | 15:06 | |
*** eharney has quit IRC | 15:06 | |
*** apuimedo has quit IRC | 15:06 | |
*** hemnafk is now known as hemna | 15:07 | |
openstackgerrit | Tiago Mello proposed openstack/nova: libvirt: Handle unsupported Spice feature per arch https://review.openstack.org/203809 | 15:07 |
openstackgerrit | dane-fichter proposed openstack/nova: Nova support for image-signing https://review.openstack.org/189843 | 15:08 |
*** irenab has quit IRC | 15:09 | |
johnthetubaguy | claudiub: I replied to her comment, I still think its worth adding a note, because I think its meant to be about nova-network | 15:09 |
*** sudipto has quit IRC | 15:09 | |
*** pbrooko has quit IRC | 15:11 | |
*** lmtaylor1 has joined #openstack-nova | 15:12 | |
*** lmtaylor1 has left #openstack-nova | 15:13 | |
*** pbrooko has joined #openstack-nova | 15:13 | |
claudiub | johnthetubaguy: i think she was referring to the fact that, on a first glance, looking at the operation.set-admin-password row in that support matrix, it seems that only xen supports setting the admin password at all, that the password cannot be changed for other hypervisors. which isn't true and it looks misguiding. | 15:13 |
mriedem | danpb: still happy with this? https://review.openstack.org/#/c/203809/ | 15:14 |
johnthetubaguy | claudiub: I agree its misleading | 15:14 |
*** jistr is now known as jistr|mtg | 15:14 | |
claudiub | johnthetubaguy: but if you're going to add that new feature classification file, i guess it won't matter that much anyways :) | 15:14 |
johnthetubaguy | claudiub: its going to take time, its worth fixing that | 15:14 |
*** gszasz has quit IRC | 15:14 | |
*** salv-orlando has quit IRC | 15:15 | |
*** Murali has quit IRC | 15:15 | |
dansmith | johnthetubaguy: https://review.openstack.org/#/c/220730/1 | 15:16 |
sdague | mriedem: did you see my alternative approach for testing the log messages are fully consumed? | 15:16 |
dansmith | johnthetubaguy: ready for you to reapply your +2 | 15:16 |
mriedem | sdague: not yet | 15:16 |
johnthetubaguy | dansmith: oh sweet, looking | 15:16 |
johnthetubaguy | oh, dietz merged it | 15:17 |
dansmith | johnthetubaguy: like seconds ago | 15:17 |
johnthetubaguy | yeah, I refreshed an my chance had gone | 15:18 |
johnthetubaguy | all good | 15:18 |
dansmith | johnthetubaguy: yeah, it was a little yellow "updated.." tag for me, so it was literally seconds after I asked | 15:18 |
dansmith | makes me wonder if he's really ... you | 15:18 |
johnthetubaguy | dansmith: he has much more hair than I do | 15:19 |
*** eharney has joined #openstack-nova | 15:19 | |
dansmith | heh | 15:19 |
*** claudiub has quit IRC | 15:19 | |
*** otter768 has joined #openstack-nova | 15:19 | |
*** alexschm has quit IRC | 15:20 | |
*** rushil has joined #openstack-nova | 15:21 | |
openstackgerrit | garyk proposed openstack/nova: Neutron: configure requested amount of fixed_ips https://review.openstack.org/163864 | 15:21 |
*** dannywilson has joined #openstack-nova | 15:22 | |
ctrath | mriedem: ^^ why does the guest architecture need to be checked? If spice is not enabled, shouldn't it behave the same for all platforms? | 15:23 |
mriedem | ctrath: that's probably a better question for timello | 15:23 |
ctrath | ok | 15:23 |
ctrath | I'll add a comment in the patch | 15:24 |
*** otter768 has quit IRC | 15:24 | |
mriedem | ctrath: i assume it's a chicken/egg issue, this is building the guest config to spawn the libvirt domain (guest) | 15:24 |
mriedem | and you can't determine if spice console doesn't work until you try accessing it from the guest, at which point you've already created the guest with the thing that doesn't work | 15:25 |
ctrath | mriedem: I see. So the conf is for all guests | 15:25 |
*** emagana has joined #openstack-nova | 15:25 | |
*** jistr|mtg is now known as jistr | 15:26 | |
*** aix has joined #openstack-nova | 15:26 | |
mriedem | ctrath: CONF.spice.enabled would be read for all guest boots, yes | 15:28 |
mriedem | since it's a global option | 15:28 |
mriedem | i added a comment that we should probably update the help text for that option to indicate it doesn't work on ppc64/s390x | 15:28 |
mriedem | so someone doesn't try to use it and find they can't boot an instance | 15:29 |
*** neiljerram_bb has joined #openstack-nova | 15:29 | |
*** dave-mccowan has quit IRC | 15:30 | |
mriedem | timello: https://review.openstack.org/#/c/203809/ - -1 b/c we should update the CONF.spice.enabled help text | 15:30 |
*** xgsa has quit IRC | 15:30 | |
mriedem | man _get_guest_config is a big method | 15:30 |
dansmith | yeah, it's a mess | 15:31 |
mriedem | danpb: _get_guest_config is 377 LOC right now | 15:31 |
mriedem | danpb: we should maybe break that up a bit in mitaka? | 15:31 |
mriedem | i pity the fool that tries unit testing that thing | 15:31 |
dansmith | I was reviewing some tests for a change to it recently and it was bad | 15:31 |
dansmith | yeah | 15:31 |
mriedem | step 1: copy existing 100 LOC unit test | 15:32 |
mriedem | step 2: change 1 thing | 15:32 |
mriedem | step 3: run test | 15:32 |
* johnthetubaguy shudder | 15:32 | |
danpb | mriedem: yep, addressing config building stuff is one of the reasons for the creation of the host.py + guest.py classes | 15:34 |
mriedem | https://bugs.launchpad.net/nova/+bug/1494374 | 15:34 |
openstack | Launchpad bug 1494374 in OpenStack Compute (nova) "nova.virt.libvirt.driver._get_guest_config method is nearly 400 LOC and should be broken up" [Undecided,New] | 15:34 |
mriedem | for mitaka | 15:34 |
danpb | mriedem: i'd like to see all the config code moved out of driver.py and into designer.py, and only rely on host+guest classes + instance object | 15:34 |
*** diogogmt_ has joined #openstack-nova | 15:36 | |
mriedem | danpb: sure, as long as we don't just move _get_guest_config in it's entirety to the guest class | 15:36 |
*** diogogmt has quit IRC | 15:37 | |
*** diogogmt_ is now known as diogogmt | 15:37 | |
*** garyk has quit IRC | 15:38 | |
*** julien_ZTE has quit IRC | 15:39 | |
*** julien_ZTE has joined #openstack-nova | 15:39 | |
bauzas | johnthetubaguy: could I just ask you to recheck https://review.openstack.org/#/c/149562/16 and re-+2 if you want ? | 15:39 |
bauzas | also https://review.openstack.org/#/c/172906/6 is needing a +W :) | 15:40 |
danpb | mriedem: well that'd be the first step, but obviously some refactoring would take place after that | 15:41 |
danpb | you don';t want to move + refactor code at the same time, as that makes diffs impossible to review | 15:41 |
*** burgerk has joined #openstack-nova | 15:41 | |
*** pbrooko has quit IRC | 15:42 | |
mriedem | i agree | 15:42 |
mriedem | backports are also terribad | 15:42 |
*** dave-mccowan has joined #openstack-nova | 15:43 | |
*** browne has quit IRC | 15:44 | |
*** tdurakov has quit IRC | 15:46 | |
*** ijw_ has joined #openstack-nova | 15:46 | |
*** pkholkin has quit IRC | 15:48 | |
*** tdurakov_ has joined #openstack-nova | 15:52 | |
*** pkholkin has joined #openstack-nova | 15:52 | |
*** e0ne has quit IRC | 15:56 | |
*** angdraug has joined #openstack-nova | 15:58 | |
*** kgalanov has joined #openstack-nova | 15:59 | |
*** casusbelli has quit IRC | 16:01 | |
*** e0ne has joined #openstack-nova | 16:02 | |
*** tonytan4ever has quit IRC | 16:03 | |
*** tjones has joined #openstack-nova | 16:03 | |
*** jlanoux has quit IRC | 16:05 | |
*** VW_ has quit IRC | 16:07 | |
*** VW_ has joined #openstack-nova | 16:08 | |
*** asselin has joined #openstack-nova | 16:11 | |
*** neiljerram_bb has quit IRC | 16:11 | |
*** VW_ has quit IRC | 16:12 | |
*** eglynn has quit IRC | 16:13 | |
*** Apoorva has joined #openstack-nova | 16:17 | |
*** _diana_ has quit IRC | 16:18 | |
*** Apoorva has quit IRC | 16:18 | |
*** Apoorva has joined #openstack-nova | 16:19 | |
*** tjones has quit IRC | 16:21 | |
mdrabe | Can I get an eye or two on https://review.openstack.org/#/c/221905/ please. Small one liner s/str/six.text_type change | 16:21 |
mriedem | mdrabe: a unit test would be nice | 16:23 |
mriedem | with unicode in it | 16:23 |
*** garyk has joined #openstack-nova | 16:24 | |
dansmith | I just said that | 16:24 |
mriedem | jinx? | 16:24 |
*** tsekiyama has joined #openstack-nova | 16:25 | |
mriedem | dansmith: i don't see serialize_args in oslo.versionedobjects? | 16:25 |
dansmith | mriedem: is there a point or just an observation? :) | 16:26 |
mriedem | there is a point | 16:26 |
mriedem | is it going away? | 16:26 |
dansmith | it's kindof nova specific | 16:26 |
mriedem | i was looking to see if the same bug existed in ovo | 16:26 |
dansmith | it's one of the things we intentionally didn't copy into o.vo I think | 16:27 |
mriedem | oh i see for the error handling stuff | 16:27 |
dansmith | because it's fairly hacky | 16:27 |
*** tjones has joined #openstack-nova | 16:27 | |
mriedem | funny, we check six.string_types just below that line | 16:27 |
*** browne has joined #openstack-nova | 16:27 | |
*** lpetrut has quit IRC | 16:28 | |
hemna | mriedem, ping | 16:31 |
*** VW_ has joined #openstack-nova | 16:31 | |
mriedem | pong | 16:31 |
hemna | mriedem, our QA guy here has found a problem with block migration here : https://bugs.launchpad.net/nova/+bug/1493512 | 16:31 |
openstack | Launchpad bug 1493512 in OpenStack Compute (nova) "n-cpu misreports shared storage when attempting to block migrate" [Undecided,New] | 16:31 |
hemna | not sure if you guys have seen it yet | 16:32 |
*** unicell has quit IRC | 16:32 | |
*** ijw_ has quit IRC | 16:33 | |
mriedem | haven't heard of it | 16:33 |
mriedem | i file that under ndipanov :) | 16:33 |
*** baoli_ has quit IRC | 16:33 | |
mriedem | but he's conveniently gone | 16:33 |
hemna | ok thanks, just wanted to give you a heads up. | 16:34 |
mriedem | hemna: this is lvm? ceph? other? | 16:34 |
mriedem | oh, nfs | 16:34 |
mriedem | :( | 16:34 |
openstackgerrit | Lucas Alvares Gomes proposed openstack/nova: Ironic: Add support for microversion https://review.openstack.org/221848 | 16:34 |
*** sseverson has joined #openstack-nova | 16:35 | |
hemna | mriedem, sseverson filed the bug | 16:36 |
sseverson | mriedem: I'm the troublemaker. :) | 16:36 |
mriedem | so it sounds like a regression from kilo | 16:36 |
hemna | sseverson, is this still a boot from cinder volume ? | 16:37 |
mriedem | appears so | 16:37 |
hemna | sseverson, on the 2nd attempt (comment #2) | 16:37 |
sseverson | hemna: Yeah, it was. | 16:37 |
mriedem | ftersin: ^ any ideas here? | 16:37 |
*** romainh has left #openstack-nova | 16:37 | |
hemna | sseverson, ok, can you confirm it still happens with an LVM based boot volume ? | 16:37 |
sseverson | hemna: I'll give it a shot right now. | 16:38 |
hemna | sseverson, just to get 3PAR (volume) out of the way | 16:38 |
mriedem | sseverson: i was going to say, in comment 2 you say block migration does not work at all, but we have a multi-node block migration job with lvm working in the gate | 16:38 |
hemna | sseverson, and just to confirm, this is 2 n-cpu nodes without any shared storage ? | 16:38 |
hemna | mriedem, yah, that's what makes me go..hrmm... | 16:38 |
*** moshele has quit IRC | 16:39 | |
sseverson | hemna, mriedem: I tried fully blowing away everything and restacking from scratch, only using the two nodes that had no shared storage between them. | 16:39 |
*** y_sawai has quit IRC | 16:39 | |
*** ftersin has quit IRC | 16:40 | |
*** claudiub has joined #openstack-nova | 16:40 | |
*** jistr has quit IRC | 16:40 | |
hemna | sseverson, ok, just test it in that same setup w/ lvm | 16:40 |
hemna | I'm not sure how/why lvm vs. other cinder drivers makes any difference here, but it's a data point. | 16:40 |
mriedem | does stacking with NFS set some flags that aren't set with LVM? | 16:41 |
sseverson | hemna: I should attach my nova.conf too. | 16:41 |
mriedem | which makes nova assume shared storage? | 16:41 |
mriedem | yeahy | 16:41 |
hemna | sseverson, yah, and cinder.conf fwiw | 16:41 |
mriedem | like, why use nfs if you don't plan on using shared storage? | 16:42 |
*** bradjones|away is now known as bradjones | 16:42 | |
hemna | mriedem, the nova code looks like it tests for the existence of a file in the nova instances dir, and if it does, then it's marked as shared storage | 16:42 |
*** achanda has joined #openstack-nova | 16:42 | |
*** ftersin has joined #openstack-nova | 16:43 | |
hemna | mriedem, https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L5338 | 16:43 |
mriedem | hrm | 16:44 |
mriedem | i always get confused going down the rabbit hole where that code is used | 16:44 |
mriedem | in the libvirt driver and the compute manager | 16:44 |
hemna | yah, I'm kinda lost a bit there | 16:44 |
hemna | but this might be something here: | 16:44 |
hemna | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L5198-L5205 | 16:44 |
hemna | that comment kinda smells like it might be it. | 16:44 |
hemna | boot from volume w/o any local storage = return True, which would cause that exception being raised ? | 16:45 |
hemna | I bet that's it. | 16:45 |
hemna | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L5222-L5226 | 16:46 |
sseverson | mriedem, hemna: Local volume did not immediately fail. It's migrating now. | 16:46 |
hemna | sseverson, same flavor ? | 16:46 |
hemna | sseverson, any local storage in the flavor chosen ? | 16:46 |
sseverson | No, the flavor I was using before was not using local storage. | 16:46 |
hemna | ah ok, that's it then (me thinks) | 16:46 |
*** eharney has quit IRC | 16:47 | |
hemna | that method _is_shared_block_storage, specifically tests for a boot from volume and no local storage | 16:47 |
ftersin | mriedem: i don't know something about that now. will look at it later | 16:47 |
mriedem | hemna: that code your pointing at has ben around since kilo | 16:47 |
*** alex_klimov has quit IRC | 16:47 | |
mriedem | maybe we don't care, but i thought the bug sounded like a regression since i thought sseverson said in there this used to work | 16:48 |
*** dims_ has joined #openstack-nova | 16:48 | |
mriedem | unless 'used to' was juno or something | 16:48 |
mriedem | cactus :) | 16:48 |
sseverson | hemna, mriedem: I need to try this again, I wasn't using a Cinder LVM volume. That was boot from image, not boot from Cinder volume. | 16:50 |
hemna | mriedem, so it looks like this just isn't supported at all | 16:51 |
hemna | and is a 'feature' :P | 16:51 |
sseverson | This will take a moment, I don't have LVM setup in Cinder atm. | 16:51 |
*** dims has quit IRC | 16:51 | |
hemna | boot from Cinder volume, with a flavor that has no local storage. | 16:51 |
*** aswadr has quit IRC | 16:51 | |
*** lsmola has quit IRC | 16:53 | |
*** nic has joined #openstack-nova | 16:53 | |
*** e0ne has quit IRC | 16:54 | |
*** mpaolino has quit IRC | 16:55 | |
*** jcoufal has quit IRC | 16:56 | |
*** lpetrut has joined #openstack-nova | 16:58 | |
*** ijw_ has joined #openstack-nova | 16:59 | |
openstackgerrit | Tiago Mello proposed openstack/nova: libvirt: Handle unsupported Spice feature per arch https://review.openstack.org/203809 | 17:00 |
*** Marga_ has quit IRC | 17:03 | |
*** Marga_ has joined #openstack-nova | 17:03 | |
*** unicell has joined #openstack-nova | 17:04 | |
*** baoli has joined #openstack-nova | 17:04 | |
*** raildo is now known as raildo-afk | 17:04 | |
*** Apoorva has quit IRC | 17:05 | |
*** Apoorva has joined #openstack-nova | 17:05 | |
*** derekh has quit IRC | 17:06 | |
mriedem | today the cafeteria here is celebrating customer appreciation by giving away a free apple to each person | 17:07 |
*** lucasagomes has quit IRC | 17:07 | |
mriedem | i don't consider that customer appreciation | 17:07 |
*** baoli_ has joined #openstack-nova | 17:07 | |
*** zhenguo has quit IRC | 17:07 | |
*** raildo-afk is now known as raildo | 17:07 | |
ctrath | haha.. they did have ice cream a few weeks back | 17:08 |
mriedem | drats | 17:08 |
*** baoli has quit IRC | 17:08 | |
mriedem | thanks obama | 17:08 |
ctrath | lol | 17:09 |
*** aix has quit IRC | 17:09 | |
*** changbl has quit IRC | 17:09 | |
*** ociuhandu has joined #openstack-nova | 17:09 | |
*** electrocucaracha has quit IRC | 17:10 | |
*** vilobhmm_11 has joined #openstack-nova | 17:11 | |
*** nikhil_k_ is now known as nikhil_k-bbiab | 17:14 | |
openstackgerrit | Matt Rabe proposed openstack/nova: Use six.text_type instead of str in serialize_args https://review.openstack.org/221905 | 17:15 |
*** electrocucaracha has joined #openstack-nova | 17:16 | |
*** lpetrut has quit IRC | 17:19 | |
*** otter768 has joined #openstack-nova | 17:20 | |
*** yassine__ has quit IRC | 17:21 | |
*** eharney has joined #openstack-nova | 17:22 | |
*** salv-orlando has joined #openstack-nova | 17:24 | |
*** otter768 has quit IRC | 17:25 | |
openstackgerrit | Matt Rabe proposed openstack/nova: Use six.text_type instead of str in serialize_args https://review.openstack.org/221905 | 17:26 |
*** tonytan4ever has joined #openstack-nova | 17:28 | |
*** salv-orlando has quit IRC | 17:29 | |
*** lpetrut has joined #openstack-nova | 17:30 | |
*** salv-orlando has joined #openstack-nova | 17:30 | |
*** achanda has quit IRC | 17:31 | |
*** achanda has joined #openstack-nova | 17:32 | |
*** emagana has quit IRC | 17:32 | |
*** emagana has joined #openstack-nova | 17:32 | |
*** erlon has joined #openstack-nova | 17:36 | |
*** armax has quit IRC | 17:37 | |
*** emagana has quit IRC | 17:37 | |
*** emagana has joined #openstack-nova | 17:38 | |
*** eharney has quit IRC | 17:41 | |
*** armax has joined #openstack-nova | 17:42 | |
*** salv-orlando has quit IRC | 17:48 | |
*** armax has quit IRC | 17:50 | |
*** electrocucaracha has quit IRC | 17:51 | |
openstackgerrit | Andrey Kurilin proposed openstack/python-novaclient: [BugFix] Change parameters for legacy bdm https://review.openstack.org/221525 | 17:51 |
ericksonsantos | Hi, Does anyone know if there is a case in which the quota limit of a resource is updated automatically, I mean... without calling explicitly nova quota-updated? | 17:51 |
ericksonsantos | s/updated/update | 17:51 |
*** angdraug has quit IRC | 17:53 | |
*** Marga_ has quit IRC | 17:54 | |
*** Marga_ has joined #openstack-nova | 17:54 | |
mriedem | ericksonsantos: haven't heard of that | 17:54 |
jwcroppe_ | dansmith: if you get a moment today between other things - mind taking a gander at metrics-related https://review.openstack.org/#/c/219153/ - I reworked some things a bit to make this cleaner based on some of your earlier comments | 17:55 |
*** jwcroppe_ is now known as jwcroppe | 17:56 | |
jwcroppe | dansmith: and finally deleted that gross 1-second check in there too that nobody understood :) | 17:56 |
*** kumar has quit IRC | 17:57 | |
ericksonsantos | mriedem, nice, thanks. | 17:58 |
*** obedmr has quit IRC | 18:00 | |
*** dave-mccowan has quit IRC | 18:00 | |
*** karimb has quit IRC | 18:00 | |
*** SourabhP has joined #openstack-nova | 18:02 | |
*** penick has joined #openstack-nova | 18:03 | |
mriedem | rlrossit: very close on https://review.openstack.org/#/c/197135/ | 18:03 |
mriedem | a couple of small test things and then i'm +2 | 18:03 |
*** dave-mccowan has joined #openstack-nova | 18:03 | |
sdague | so, http://tinyurl.com/oergv7q - folks feeling comfortable enough to make the v2.0 api compat jobs voting? I think things have leveled off pretty well after we got all the configs out there correclty | 18:05 |
dansmith | jwcroppe: I think that's better, but why not just explicitly call update_data() from the top side when you want to instead of passing the flag all the way down | 18:05 |
dansmith | jwcroppe: s/$/?/ | 18:06 |
*** eharney has joined #openstack-nova | 18:08 | |
jwcroppe | dansmith: I assume you mean calling it from the base monitor? Originally update_data was a 'private' method and I figured there might be other ways implementations would want to handle that... this provides some of that flexibility without a new 'abstract' method (but of course adds the new param to get_metric) | 18:09 |
dansmith | jwcroppe: yeah, it breaks that calling convention already, and also changes the behavior of when _update is called anyway | 18:10 |
dansmith | so if you're going to do that (and jaypipes agrees that it's okay) you might as well make it less hacky, IMHO | 18:10 |
jwcroppe | dansmith: that'd be a simple change... we're just adding another public method to the metric | 18:11 |
dansmith | cleaner than adding an argument that will break existing people for sure, yeah | 18:11 |
jwcroppe | dansmith: luckily this interface is new in Liberty, so I think either way we go can work without much havok | 18:12 |
dansmith | jwcroppe: you don't get to use that excuse, but yes, lower impact than something long-lived | 18:13 |
dansmith | remember, many people deploy from master.. | 18:13 |
jwcroppe | dansmith: right | 18:13 |
*** e0ne has joined #openstack-nova | 18:13 | |
*** Marga_ has quit IRC | 18:14 | |
*** Marga_ has joined #openstack-nova | 18:14 | |
jwcroppe | dansmith: either way folks will need to make a change... I actually didn't think changing the signature of the get_metric() was too hacky. "Give me the metric data, or give me the metric data and refresh the underlying data before doing so." I'm on the fence... we can also see what jaypipes thinks. Sounds like you'd rather see _update_data promoted to public? | 18:16 |
jaypipes | I wouldn't. | 18:16 |
jwcroppe | dansmith: it'll be a quick change regardless | 18:17 |
*** nikhil_k-bbiab is now known as nikhil_k | 18:17 | |
jaypipes | or at least, I'm opposed to going back to the decorator previously there that did the hacky timestamp cache thing. | 18:17 |
dansmith | jwcroppe: changing the signature isn't hacky, the pass-refresh-arg-the-first-time is, IMHO | 18:17 |
dansmith | jaypipes: that's not what we're talking about | 18:17 |
*** e0ne has quit IRC | 18:17 | |
*** changbl has joined #openstack-nova | 18:17 | |
jaypipes | dansmith: k | 18:17 |
jwcroppe | dansmith: yeah, unfortunately I don't have a good way to work around that since the metrics are a 'group' and they're queried independently | 18:18 |
dansmith | jaypipes: https://review.openstack.org/#/c/219153/12/nova/compute/monitors/base.py,cm | 18:18 |
*** tjones has left #openstack-nova | 18:18 | |
dansmith | jwcroppe: the other way to look at this is that it's the fault of the underlying stats-getting thing that is not caching smartly and taking a long time on each call, right? | 18:19 |
dansmith | jwcroppe: so you could make the provider pop data out of the cache each time it is asked for a metric, and only refresh the cache if the metric isn't there | 18:19 |
dansmith | which would mean we only query once per round | 18:20 |
jaypipes | dansmith: yeah, so I'm pretty opposed to going back to having the update_data() thing be public (it used to be part of the interface), along with a timestamp decorator. | 18:20 |
jaypipes | dansmith: the reason is because monitor classes should be free to use whatever caching scheme they want to -- including not caching anything at all. | 18:20 |
dansmith | jaypipes: well, this is a plugin interface now, so passing refresh=True breaks all existing implementations, and is the same exact thing as actually calling update_data() except less clear | 18:20 |
jaypipes | dansmith: the interface is fine as it is. | 18:21 |
jaypipes | I don't understand any need to change it. | 18:21 |
dansmith | jaypipes: have you read the backlog on that review? | 18:21 |
dansmith | jaypipes: the complaint is that libvirt sometimes takes a long time to make the call to get the data, which ends up skewing the results | 18:22 |
dansmith | the real complaint comes from the desire to have user..io..sys all add up to 100% each time, which I think is kinda weak anyway, but... | 18:22 |
jwcroppe | jaypipes: right, the issue is that the metrics are sometimes returning results based off different data | 18:22 |
jwcroppe | dansmith: it's really strange to see a 'set' of metrics for *.percent not add up to 100 | 18:23 |
*** VW_ has quit IRC | 18:23 | |
dansmith | jwcroppe: ever used top? :) | 18:23 |
jwcroppe | dansmith: lol | 18:23 |
*** VW_ has joined #openstack-nova | 18:23 | |
jwcroppe | dansmith: I think the data is just more meaningful if the metrics are based off a common set of stats, that's all | 18:24 |
dansmith | I understand that desire | 18:24 |
*** kfox1111 has joined #openstack-nova | 18:25 | |
*** SourabhP has quit IRC | 18:25 | |
dansmith | I think this data is extremely rough even when it adds up to 100% and the decisions made from it are even more rough | 18:25 |
jwcroppe | jaypipes: does the nature of the change make sense after reading the commit msg/LP bug? | 18:25 |
dansmith | jaypipes: so I'm fine making the libvirt driver do this smarterly such that we need not change anything at the top | 18:26 |
jwcroppe | dansmith: IMO, it's also nice to see that whacky 1-second check gone too | 18:26 |
*** VW__ has joined #openstack-nova | 18:26 | |
kfox1111 | johnthetubaguy: you alive? | 18:27 |
*** VW_ has quit IRC | 18:27 | |
jaypipes | I guess I'd just prefer to see the add_metrics_to_list() method overridden for the virt_driver CPU monitor. | 18:28 |
jaypipes | instead of making _update_data() public and trying to couple part of the main plugin interface to this particular problem. | 18:28 |
dansmith | hmm | 18:28 |
dansmith | that seems like it'd be replacing a pretty critical piece of the base functionality | 18:29 |
jaypipes | which was, frankly, the problem I had with the original interface. | 18:29 |
jwcroppe | dansmith: it feels like changing libvirt is strange here... if each of these metrics were individual things, I think leaving it as is makes sense. However since we're cutting a 'set' of metrics, it seems like we should have a way to tell the system 'use the same set of data from which to derive your metrics' | 18:29 |
dansmith | jwcroppe: I'm not proposing changing libvirt, but the libvirt stats getting metric provider | 18:29 |
jaypipes | jwcroppe: and I am proposing to have "that way to tell the system..." be just overriding the add_metrics_to_list() method. | 18:30 |
*** vilobhmm_11 has quit IRC | 18:30 | |
*** vilobhmm_11 has joined #openstack-nova | 18:30 | |
jaypipes | jwcroppe: the system doesn't need to know or care that the metrics are a "set", does it? | 18:30 |
*** danpb has quit IRC | 18:31 | |
jwcroppe | jaypipes: hmm - well we publish a set of metrics via RPC notifier and in the compute_nodes.metrics column | 18:31 |
jaypipes | jwcroppe: I suppose alternately, I could support having a new base class called MetricSetMonitorBase or something that overrode the add_metrics_to_list() implementation with some caching-like system. | 18:31 |
jwcroppe | jaypipes: that's how I ran across this to begin with - I read a group of metrics from the DB and notices the results didn't align very well | 18:31 |
dansmith | jaypipes: the other solution could be to put a comment somewhere that says: "These need not all be super consistent because this is cloud (this means you, jwcroppe)" | 18:32 |
dansmith | I'd be fine with that too :) | 18:32 |
jaypipes | lol, no I get the impetus behind this change. I just would like a more elegant solution than the refresh_data thing. | 18:33 |
jwcroppe | dansmith: haha | 18:33 |
jaypipes | jwcroppe: do you get what I am saying about adding a MetricSetMonitorBase class? | 18:34 |
jwcroppe | jaypipes: the current base metric code seems like it's missing something tho, since we are publishing a group of metrics as a single entity. And then there is also this line, which neither Sylvain nor I could figure out the purpose of - https://github.com/openstack/nova/blob/master/nova/compute/monitors/cpu/virt_driver.py#L52 | 18:35 |
jwcroppe | jaypipes: yes, I do - and the CPU stats would extend that, I assume? | 18:36 |
jwcroppe | cpu/virt_driver::Monitor would extend the MetricSetMonitorBase, I think is what you're proposing | 18:36 |
sseverson | hemna, mriedem: Sorry this last test took awhile. I tested twice, once with a Lefhand volume and once with a LVM volume. In both cases I ended up with the same error. I should add I tried in both directions with the tests as well. | 18:38 |
jaypipes | jwcroppe: that line came from the original code, but basically, it just makes sure that the call to driver.get_host_cpu_stats() is only ever done once in a second time interval. | 18:38 |
jwcroppe | jaypipes: I have to think about that a bit, but aren't we still going to fall victim to not understanding when the data needs to be refreshed since the metrics are still queried individually? | 18:38 |
*** matrohon has joined #openstack-nova | 18:39 | |
jwcroppe | jaypipes: I guess we can override the add_metrics_to_list() function, update the data once and then add the values | 18:40 |
hemna | sseverson, so that's with a flavor that had no local volumes right ? | 18:40 |
jaypipes | jwcroppe: not really. I mean, if it took >1 second in between calling get_host_cpu_stats() and the final call to get the cpu.frequency metric, I suppose there could have been an additional call to get_host_cpu_stats(). but that's pretty unlikely. | 18:40 |
sseverson | hemna: That's correct. | 18:40 |
*** tonytan4ever has quit IRC | 18:40 | |
jwcroppe | jaypipes: the root cause of this problem was that get_host_cpu_stats() did take over 1 second | 18:41 |
hemna | sseverson, ok, so from what I can tell, that case is specifically checked for in the code on purpose. so my guess is it's not supported for whatever reason | 18:41 |
jaypipes | jwcroppe: ah. well in that case, yeah, this system is foo-bared :) | 18:41 |
sseverson | hemna: By "that case" you mean an instance with a cinder volume? | 18:41 |
jwcroppe | jaypipes: and hence this patch :) | 18:42 |
hemna | sseverson, an instance booted from cinder volume, and the flavor chosen has no local storage. | 18:42 |
sseverson | hemna: If that's the case the exceptions should definitely be reworded. | 18:42 |
jaypipes | jwcroppe: k, reviewed the patch. lemme know if something isn't clear, ok? | 18:44 |
jaypipes | jwcroppe: thank you for your effort on these bugs, it is very much appreciated. and apologies for not being around the last few days much. | 18:44 |
hemna | sseverson, I made a comment in the bug | 18:44 |
jwcroppe | jaypipes: so if we revisit what you were saying... perhaps we could introduce another layer in between the virt_driver and the base monitor, call it MetricSetMonitorBase. (1) In there, we'd have to override add_metrics_to_list() and ensure the "update_data" is only called once. (2) The CPU virt_driver would extend MetricSetMonitorBase and (3) CPU virt_driver's get_metric would no longer call _update_data() since th | 18:44 |
jwcroppe | e parent object handles it. | 18:44 |
sseverson | hemna: Thanks | 18:45 |
jaypipes | jwcroppe: well, almost. :) You wouldn't want a single get_metric() method on the MetricSetMonitorBase class, since the plugin is specifically designed to treat the metrics as an indivisible set. | 18:45 |
mriedem | doffm: here is a thing you could work on, should be relatively easy https://bugs.launchpad.net/oslo.log/+bug/1493976 | 18:46 |
openstack | Launchpad bug 1493976 in oslo.log "oslo_log.fixtures should be provided via extras at runtime" [Low,Triaged] - Assigned to Matt Riedemann (mriedem) | 18:46 |
* dansmith doesn't understand this approach at all | 18:46 | |
jaypipes | jwcroppe: so, I would create a new root base Monitor class with only the add_metrics_to_list() public method. Then, make a MetricMonitorBase class that looks the same as the existing one, and a new MetricSetMonitorBase that re-implements the add_metrics_to_list() method in a way that treats the metrics as an atomic set of things. | 18:47 |
jwcroppe | jaypipes: get_metric() is defined in the top-most monitor class, so it's there regardless... unless you're talking about a bigger overhaul | 18:48 |
jwcroppe | jaypipes: ahh ok, so you are talking about bigger surgery (which is fine, just wasn't sure how much we wanted to refactor this) | 18:49 |
jwcroppe | jaypipes: perhaps overhauling this code is enough of an excuse to get me out of taking my niece to a Taylor Swift concert tomorrow evening | 18:51 |
doffm | mriedem: Ok, thanks. Will take a look. | 18:52 |
*** tonytan4ever has joined #openstack-nova | 18:52 | |
mriedem | doffm: i threw an example in the bug report of a change i'm doing in oslo.db that is similar | 18:54 |
mriedem | doffm: we probably can't actually land those changes until mitaka since they will require a major version bump in the library | 18:54 |
jwcroppe | dansmith: does this last set of thoughts make sense about refactoring the class hierarchy a bit? | 18:54 |
dansmith | jwcroppe: no, I don't really like it, but that's fine.. my opinion doesn't matter | 18:55 |
*** angdraug has joined #openstack-nova | 18:55 | |
jwcroppe | dansmith: I'd like to see if we can find something mutually agreeable that also solves the problem. Unfortunately we've got a bit of a mess to start with here... | 18:57 |
jaypipes | jwcroppe: lol on the concert excuse :) | 18:57 |
*** jecarey has quit IRC | 18:58 | |
jaypipes | dansmith: your opinion matters a hell of a lot. what solution do you prefer? | 18:58 |
jwcroppe | jaypipes: I'm embarrassed to admit what we had to pay for those tickets for her | 18:58 |
dansmith | jwcroppe: I'm this >< close to tweeting something that will embarrass you | 18:59 |
jwcroppe | dansmith: oh no | 18:59 |
dansmith | jaypipes: it's fine, you and jwcroppe do whatever you think is best here | 18:59 |
*** penick_ has joined #openstack-nova | 19:00 | |
*** derekh has joined #openstack-nova | 19:00 | |
*** claudiub has quit IRC | 19:01 | |
jwcroppe | dansmith: don't worry, I'll smooth our solution over with you in Tokyo and buy you a granola bar | 19:01 |
*** penick has quit IRC | 19:01 | |
*** penick_ is now known as penick | 19:01 | |
dansmith | I'll need it | 19:01 |
*** matrohon has quit IRC | 19:01 | |
* dansmith has a strict no-tentacle policy | 19:02 | |
jwcroppe | I'm bringing boxes of them. | 19:02 |
jwcroppe | I don't eat anything out of the water. | 19:02 |
dansmith | I took 12 pounds of probars to hong kong | 19:02 |
dansmith | jwcroppe: same | 19:02 |
edleafe | jwcroppe: dansmith: tentacles are delicious! | 19:03 |
dansmith | edleafe: more for you | 19:03 |
edleafe | yay! | 19:03 |
jwcroppe | dansmith: hmm... maybe we're on to something. Granola stand.... $5 per bar. | 19:03 |
dansmith | jwcroppe: you're literally the second person I've met with an avowed policy against it, so I think our market is small | 19:03 |
jwcroppe | anyway, I will try to refactor this patch and see how it feels over the next couple days, in between getting my hearing back from the screaming kids | 19:04 |
dansmith | although I do live in a port city | 19:04 |
edleafe | dansmith: dunno, jaypipes was pretty vocal about not liking japanese food | 19:04 |
*** salv-orlando has joined #openstack-nova | 19:04 | |
jwcroppe | dansmith: I've never even *tried* anything from the sea, if you can believe it | 19:04 |
dansmith | edleafe: he eats a ton more classes of food than I do | 19:04 |
dansmith | jwcroppe: fish sticks are about all I have tried | 19:04 |
jwcroppe | dansmith: you're a braver soul than I | 19:05 |
dansmith | I was force fed them as a child, so not really | 19:05 |
dansmith | now, if we could come up with some religion that banned these sorts of foods, that would help me out | 19:05 |
dansmith | explaining why I don't eat sea bugs gets tiring | 19:05 |
edleafe | dansmith: you could start your own | 19:06 |
dansmith | but if I could whip out a pamphlet or something, that would save time | 19:06 |
edleafe | dansmith: you'd make a lot more money than selling granola bars | 19:06 |
dansmith | think of the tax breaks! | 19:06 |
edleafe | dansmith: exactly! https://www.youtube.com/watch?v=7y1xJAVZxXg | 19:07 |
jwcroppe | dansmith: "sea bugs" - lol | 19:07 |
jwcroppe | dansmith: I just tell people to take a closer look at it... that's all the explanation I ever need | 19:08 |
dansmith | heh | 19:08 |
jwcroppe | "No thanks, this fruit roll-up is much preferred." | 19:08 |
dansmith | edleafe: lol, yeah he's hilarious | 19:09 |
dansmith | jwcroppe: fruit rollups win against basically everything though, so that's not too fair | 19:09 |
edleafe | jwcroppe: yeah, just don't look too close at those, either :) | 19:10 |
*** dims_ has quit IRC | 19:11 | |
*** smatzek_ has joined #openstack-nova | 19:11 | |
*** dims has joined #openstack-nova | 19:11 | |
*** salv-orlando has quit IRC | 19:12 | |
*** smatzek has quit IRC | 19:14 | |
mriedem | jogo: what was your gate graphite tracker link again? | 19:17 |
*** achanda has quit IRC | 19:18 | |
*** ociuhandu has quit IRC | 19:18 | |
mdrabe | mriedem, dansmith https://review.openstack.org/#/c/221905/4 updated with UT :) | 19:20 |
*** achanda has joined #openstack-nova | 19:20 | |
mriedem | mdrabe: ok, after this meeting | 19:20 |
*** otter768 has joined #openstack-nova | 19:21 | |
*** achanda has quit IRC | 19:22 | |
*** achanda_ has joined #openstack-nova | 19:22 | |
*** Sukhdev has joined #openstack-nova | 19:23 | |
*** tongli has joined #openstack-nova | 19:23 | |
mriedem | anyone know where na0no is? | 19:25 |
mriedem | http://ci-watch.tintri.com/project?project=nova&time=7+days | 19:25 |
mriedem | intel pci ci is off the rails | 19:25 |
mriedem | btw, has anyone not seen http://ci-watch.tintri.com/project?project=nova&time=7+days ? | 19:25 |
*** otter768 has quit IRC | 19:26 | |
*** pixelbeat has quit IRC | 19:28 | |
kashyap | What is "tintri"? | 19:28 |
*** penick has quit IRC | 19:29 | |
*** derekh has quit IRC | 19:29 | |
kashyap | It's loading super-slow. . . | 19:29 |
kashyap | That looks neat, a nice table of CI results! | 19:29 |
* kashyap gets back to 2 weeks worth of email, post vacation. | 19:31 | |
*** xiaohui has quit IRC | 19:33 | |
mriedem | kashyap: 7 days is slow | 19:34 |
mriedem | 24 hours is default and faster | 19:34 |
*** xiaohui has joined #openstack-nova | 19:34 | |
mriedem | it's hosted somewhere else, but 3rd party workgroup is working on having infra host that when all of the cats are herded and agree on some solution like this | 19:34 |
mriedem | i'm not really invovled, that's all me repeating what i think i heard | 19:34 |
kashyap | No worries, thanks for the pointer. | 19:35 |
mriedem | kashyap: now that you're back | 19:35 |
mriedem | i can dump some thing son you | 19:35 |
kashyap | :-) | 19:35 |
mriedem | like why this fails https://review.openstack.org/#/c/218355/ | 19:35 |
* kashyap clicks, will read through once I finish dinner. I'm getting stares here. | 19:36 | |
mriedem | just lash out at the people staring | 19:36 |
bauzas | mriedem: oh, yummy ! http://ci-watch.tintri.com/project?project=nova&time=7+days | 19:38 |
mriedem | bauzas: yeah so i can harp on people on a more regular basis :) | 19:38 |
*** Apoorva has quit IRC | 19:39 | |
bauzas | heh, I knew http://zuul.openstack.xenproject.org/scoreboard/?project=openstack/nova&user=jenkins,citrix_xenserver_ci,XenProject-CI&timeframe=24 but that was only for Xen CIs | 19:40 |
*** matrohon has joined #openstack-nova | 19:40 | |
bauzas | so I was just hassling BoBall_AWOL :) | 19:40 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Check for unformatted logged messages during test runs https://review.openstack.org/221973 | 19:43 |
*** zzzeek has quit IRC | 19:44 | |
*** lpetrut has quit IRC | 19:44 | |
mriedem | mdrabe: i don't think your test will pass py34 | 19:45 |
*** ociuhandu has joined #openstack-nova | 19:46 | |
*** salv-orlando has joined #openstack-nova | 19:46 | |
*** ijw_ has quit IRC | 19:49 | |
*** yamahata has quit IRC | 19:52 | |
*** alex_klimov has joined #openstack-nova | 19:53 | |
mriedem | sdague: i updated https://review.openstack.org/#/c/221973/5,publish to use your suggestion; some tests still fail and it's not clear to me right now why, since the code looks ok | 19:53 |
mriedem | i posted it anyway just to get the latest changes up | 19:54 |
*** tongli has quit IRC | 19:54 | |
*** jecarey has joined #openstack-nova | 19:54 | |
mdrabe | mriedem: which part you thinkin will break? | 19:54 |
openstackgerrit | xing-yang proposed openstack/nova: Fix ScaleIO commands in rootwrap filters https://review.openstack.org/222346 | 19:55 |
mriedem | mdrabe: unichr | 19:56 |
mriedem | comments are in the review | 19:56 |
*** achanda_ has quit IRC | 19:56 | |
mdrabe | yep you're right | 19:58 |
*** jerrygb has quit IRC | 19:58 | |
mriedem | mdrabe: please repeat that | 19:59 |
mriedem | o-) | 19:59 |
mdrabe | :) | 19:59 |
mriedem | https://jenkins05.openstack.org/job/gate-nova-python34/2032/console | 19:59 |
mriedem | NameError: name 'unichr' is not defined | 19:59 |
kashyap | mriedem: Still reading through (about 4 bugs involved), but wow, some serious sleuthing in there! | 19:59 |
*** claudiub has joined #openstack-nova | 20:00 | |
mriedem | kashyap: oh it's terrible | 20:00 |
mriedem | kashyap: i need to updat ethat change again though to not pass the explicit device name in on the volume attach | 20:00 |
mriedem | since it doesn't seem to make a difference (and it shouldn't) | 20:00 |
kashyap | Yeah, lots of details to catch up there. I saw the referenced commit from your fix. Device naming seems messy | 20:00 |
mriedem | i think that change would literally be the only test in tempest that does a volume attach w/o specifying a device name | 20:01 |
mriedem | which is actually what we want to people to do - not specify a device name | 20:01 |
mriedem | danpb's other comment when we were talking about this last week was to not do the instance snapshot | 20:01 |
mriedem | which i was going to try next | 20:01 |
kashyap | Yeah, since Liberty even a user-supplied name will be ignored anyway, as you note in the commit message. | 20:01 |
*** gyee has joined #openstack-nova | 20:01 | |
mriedem | right, so i got it passing on liberty with not passing the device name, but it was failing on stable | 20:02 |
mriedem | so as a test i started passing the device name, and then it was failing on liberty and stable, | 20:02 |
mriedem | so go figure | 20:02 |
mriedem | plus the volume attach is async in libvirt / qemu which makes this worse | 20:02 |
*** amotoki has quit IRC | 20:03 | |
mriedem | i created a nova bug for mitaka to add an event listener to the libvirt driver so we can wait for qemu to tell us that the device is actually attached | 20:03 |
kashyap | Jeez, yeah. I need a fresh mind to test this. Looking through comments, total of about 6-7 bugs plus 5 separate changes seem to be involved | 20:03 |
kashyap | And, this is being investigated for a few weeks already I presume | 20:03 |
*** claudiub|2 has joined #openstack-nova | 20:04 | |
mriedem | yeah | 20:05 |
mriedem | off and on | 20:05 |
mriedem | i get burned out looking at it | 20:05 |
mriedem | :) | 20:05 |
kashyap | Yeah, was reading this comment in related to what you say about `detach-device` -- https://bugs.launchpad.net/nova/+bug/1492026/comments/6 | 20:05 |
openstack | Launchpad bug 1492026 in OpenStack Compute (nova) "Attached volume partition sometimes doesn't show up in guest if previous volume detach was not complete" [Low,Confirmed] | 20:05 |
*** salv-orlando has quit IRC | 20:05 | |
kashyap | Can imagine. You already most of the investigation recording the details along the way. Good work! | 20:06 |
kashyap | s/most/did most/ | 20:06 |
*** claudiub has quit IRC | 20:06 | |
*** dave-mccowan has quit IRC | 20:09 | |
*** Apoorva has joined #openstack-nova | 20:11 | |
mriedem | yar | 20:14 |
mriedem | i'm going to be afk for awhile | 20:14 |
*** mriedem has quit IRC | 20:14 | |
*** salv-orlando has joined #openstack-nova | 20:15 | |
*** salv-orlando has quit IRC | 20:16 | |
*** ijw_ has joined #openstack-nova | 20:16 | |
*** salv-orlando has joined #openstack-nova | 20:17 | |
kashyap | Yeah, hitting the hay now, late here too. Will catch up on the details tomorrow. | 20:17 |
*** yamahata has joined #openstack-nova | 20:18 | |
*** salv-orlando has quit IRC | 20:21 | |
*** smatzek_ has quit IRC | 20:21 | |
*** dustins has quit IRC | 20:26 | |
*** matrohon has quit IRC | 20:26 | |
*** pbrooko has joined #openstack-nova | 20:27 | |
*** Daisy has joined #openstack-nova | 20:27 | |
*** dustins has joined #openstack-nova | 20:28 | |
*** isq has quit IRC | 20:30 | |
*** jerrygb has joined #openstack-nova | 20:30 | |
*** salv-orlando has joined #openstack-nova | 20:31 | |
*** ijuwang has quit IRC | 20:31 | |
*** dave-mccowan has joined #openstack-nova | 20:31 | |
*** nic has quit IRC | 20:31 | |
*** Daisy has quit IRC | 20:32 | |
*** karimb has joined #openstack-nova | 20:34 | |
*** mriedem has joined #openstack-nova | 20:37 | |
*** ijuwang has joined #openstack-nova | 20:37 | |
*** pbrooko has quit IRC | 20:38 | |
*** vladikr has quit IRC | 20:40 | |
*** aix has joined #openstack-nova | 20:40 | |
*** mriedem has quit IRC | 20:41 | |
*** lpetrut has joined #openstack-nova | 20:42 | |
*** nic has joined #openstack-nova | 20:45 | |
openstackgerrit | Matt Rabe proposed openstack/nova: Use six.text_type instead of str in serialize_args https://review.openstack.org/221905 | 20:47 |
*** mriedem has joined #openstack-nova | 20:47 | |
*** ZZelle_ has joined #openstack-nova | 20:48 | |
*** achanda has joined #openstack-nova | 20:48 | |
*** lpetrut has quit IRC | 20:50 | |
mikal | Morning | 20:51 |
*** thangp has quit IRC | 20:51 | |
*** tonytan4ever has quit IRC | 20:52 | |
*** achanda has quit IRC | 20:54 | |
*** burgerk has quit IRC | 20:55 | |
mriedem | yar | 20:55 |
mriedem | nova.virt.libvirt.driver._volume_snapshot_delete is also huge | 20:55 |
*** tonytan4ever has joined #openstack-nova | 20:57 | |
*** Marga_ has quit IRC | 20:58 | |
*** Marga_ has joined #openstack-nova | 20:58 | |
*** raildo is now known as raildo-afk | 20:58 | |
dansmith | mikal: I have a very special favor to ask | 20:58 |
*** dustins has quit IRC | 20:59 | |
mikal | dansmith: oh god | 20:59 |
mikal | dansmith: this is how it begins | 20:59 |
mikal | dansmith: also, meeting, yes? | 20:59 |
dansmith | heh | 20:59 |
dansmith | yes | 20:59 |
*** garyk has quit IRC | 21:01 | |
*** thorst has quit IRC | 21:01 | |
*** achanda has joined #openstack-nova | 21:02 | |
*** diogogmt has quit IRC | 21:05 | |
*** dave-mccowan has quit IRC | 21:06 | |
*** eharney has quit IRC | 21:07 | |
kfox1111 | johnthetubaguy: you alive? | 21:08 |
johnthetubaguy | kfox1111: ish | 21:09 |
openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: Implements attach_interface and detach_interface method https://review.openstack.org/214493 | 21:09 |
kfox1111 | johnthetubaguy: I am supposed to: | 21:09 |
kfox1111 | 17:29 < johnthetubaguy> kfox1111: so in all honesty, all my reviewer are likely to be slammed until liberty-3 is tagged, at this point, at that point I hope to assign priorities to specs, this is an important ish one (medium ish) | 21:09 |
kfox1111 | 17:30 < johnthetubaguy> kfox1111: remind me I said that the week after liberty-3! | 21:09 |
kfox1111 | my calendar reminder just went off. :) | 21:10 |
*** aysyd has quit IRC | 21:10 | |
*** tjones has joined #openstack-nova | 21:12 | |
johnthetubaguy | kfox1111: oh, very good point | 21:12 |
johnthetubaguy | kfox1111: I am totally going to start looking at specs tomorrow, well I did mean to start today | 21:13 |
johnthetubaguy | kfox1111: appreciate the reminder :) | 21:13 |
johnthetubaguy | kfox1111: do you have the link? | 21:13 |
kfox1111 | thanks. :) | 21:13 |
kfox1111 | yeah, hold on. | 21:13 |
kfox1111 | https://review.openstack.org/#/c/222293/ | 21:13 |
dansmith | johnthetubaguy: really? you're going to focus on specs starting now? | 21:13 |
johnthetubaguy | dansmith: well, I was going to peak, rather than focus | 21:14 |
johnthetubaguy | dansmith: although granted its a bit early, was going to asses the damage really | 21:14 |
*** mwagner_lap has quit IRC | 21:14 | |
dansmith | but assigning priority? | 21:14 |
*** eglynn has joined #openstack-nova | 21:15 | |
dansmith | I'd like to have input into that process, but don't really feel like I can do that while we're headed for rc | 21:15 |
*** achanda has quit IRC | 21:15 | |
*** achanda has joined #openstack-nova | 21:15 | |
johnthetubaguy | yeah, post RC is probably more sensible | 21:15 |
openstackgerrit | Ryan Rossiter proposed openstack/nova: Set vif and allocated when associating fixed ip https://review.openstack.org/197135 | 21:15 |
*** Piet has quit IRC | 21:16 | |
alaski | +1 to specs waiting until after RC | 21:16 |
*** bswartz has joined #openstack-nova | 21:17 | |
*** Marga_ has quit IRC | 21:17 | |
kfox1111 | ok. I'll move my reminderer. :) | 21:17 |
*** rfolco has quit IRC | 21:17 | |
krtaylor | mriedem, re: meeting topic 3rd party CI dashboard - the one you listed is temporary, the infra hosted one will be put up once this spec is approved https://review.openstack.org/#/c/194437/ | 21:17 |
*** Marga_ has joined #openstack-nova | 21:17 | |
mriedem | krtaylor: ok, i won't hold my breath | 21:18 |
krtaylor | hehheh, me either | 21:18 |
kfox1111 | you mean afer rc1 or after the final release? | 21:19 |
*** edmondsw has quit IRC | 21:19 | |
*** unicell has quit IRC | 21:20 | |
kfox1111 | cause the week after the release is basically the summit. | 21:20 |
*** unicell1 has joined #openstack-nova | 21:20 | |
dansmith | kfox1111: after rc1 is not necessarily unbusy | 21:20 |
dansmith | kfox1111: to be honest, I don't see how we can prioritize specs until after the summit anyway | 21:20 |
dansmith | because, you know, that's where we decide the priorities | 21:20 |
kfox1111 | k. | 21:20 |
*** otter768 has joined #openstack-nova | 21:22 | |
*** Sukhdev has quit IRC | 21:23 | |
tonyb | mriedem: when the meetign is over do you have a few to help me understand a juno versioning problem? | 21:26 |
openstackgerrit | Matt Rabe proposed openstack/nova: Use six.text_type instead of str in serialize_args https://review.openstack.org/221905 | 21:26 |
*** otter768 has quit IRC | 21:27 | |
mriedem | tonyb: potentially | 21:27 |
mikal | dansmith: so, you were tricking me into something horrible? | 21:27 |
mriedem | rlrossit: +2 on https://review.openstack.org/#/c/197135/ | 21:27 |
dansmith | mikal: I was going to challenge you to keep the meeting short | 21:27 |
rlrossit | mriedem: I saw.. yeehaw | 21:27 |
rlrossit | thanks! | 21:27 |
mikal | dansmith: oh, ok | 21:28 |
mikal | dansmith: sorry, I will talk faster next time | 21:28 |
dansmith | mikal: thanks :) | 21:28 |
mikal | dansmith: I also feel bad that I haven't talked to you about objects for notifications yet | 21:28 |
mikal | dansmith: and presumably should do that thing sometime | 21:28 |
dansmith | yeah, sometime | 21:28 |
* dansmith slinks away | 21:28 | |
mikal | Heh | 21:28 |
tonyb | mriedem: So python-ceilometer client has a upper limit of <=1.0.13 in juno and tha's been release (along with 1.0.14) so if I need to do a new release I'm kinda stuck | 21:29 |
* mikal runs away to have brekky before his next meeting | 21:30 | |
mriedem | brekky | 21:30 |
mriedem | adorable | 21:30 |
tonyb | mriedem: I was thinking of doing something like <=1.1.0,!=1.0.14 in juno and then potentially something similer in kilo but that seem gross | 21:30 |
mriedem | tonyb: backup, you need to do a python-ceilometerclient release for juno? | 21:30 |
tonyb | mriedem: I think so. | 21:32 |
*** tjones has left #openstack-nova | 21:32 | |
tonyb | mriedem: it has uncapped requirements which means it's getting oslo 2.x libraries and breaking | 21:33 |
*** electrocucaracha has joined #openstack-nova | 21:33 | |
*** achanda has quit IRC | 21:33 | |
tonyb | mriedem: I though to fix that I needed to get the requirements merged from g-r and then tag that as a release so that others can consume it | 21:33 |
*** achanda has joined #openstack-nova | 21:34 | |
tonyb | mriedem: http://logs.openstack.org/05/206705/3/check/gate-horizon-python27/3e84064/console.html#_2015-08-22_19_19_15_770 | 21:34 |
*** xiaohui has quit IRC | 21:34 | |
mriedem | is there a bug tracking the break? | 21:35 |
tonyb | mriedem: It's all fallout form the swiftclient thing. | 21:35 |
*** xiaohui has joined #openstack-nova | 21:35 | |
mriedem | tonyb: maybe we should go to #openstack-stable | 21:35 |
tonyb | mriedem: but no I haven't opened bugs for each of the problems, just the olso* ones | 21:35 |
mriedem | since this isn't nova related | 21:35 |
tonyb | wow that's a thing? | 21:36 |
mriedem | big time | 21:36 |
jroll | mikal: I notice you have a list of people to ping at the beginning of nova meetings - how do I get on that list? :) | 21:37 |
*** jecarey has quit IRC | 21:38 | |
dansmith | jroll: ironic folks not welcomed | 21:38 |
jroll | butbutbut | 21:38 |
dansmith | jroll: also, it's ont he wiki | 21:38 |
dansmith | you can add yo'sef | 21:38 |
jroll | sweet | 21:38 |
jroll | thanks | 21:38 |
*** rlrossit has left #openstack-nova | 21:40 | |
*** stevemar has joined #openstack-nova | 21:40 | |
stevemar | sdague: maybe you remember this ... there was a discussion about removing the 'policy_dir' option from oslo.policy? https://bugs.launchpad.net/oslo.policy/+bug/1428332 | 21:42 |
openstack | Launchpad bug 1428332 in oslo.policy "remove the policy_dirs option" [Medium,Confirmed] | 21:42 |
stevemar | i just wanted to make sure that nova doesn't need this option, i saw that theres a patch to use oslo.policy that is being reviewed, but not sure if it needs that option | 21:42 |
*** VW__ has quit IRC | 21:43 | |
*** VW_ has joined #openstack-nova | 21:43 | |
*** VW_ has quit IRC | 21:48 | |
*** apuimedo has joined #openstack-nova | 21:48 | |
*** derekh has joined #openstack-nova | 21:51 | |
openstackgerrit | Daniel Wallace proposed openstack/python-novaclient: make sure os_password is set for auth_plugins https://review.openstack.org/221921 | 21:52 |
*** mcarden has joined #openstack-nova | 21:53 | |
*** tonytan4ever has quit IRC | 21:54 | |
*** edtubill has left #openstack-nova | 21:55 | |
*** signed8bit has joined #openstack-nova | 21:55 | |
*** julien_ZTE has quit IRC | 21:57 | |
*** agireud has quit IRC | 21:58 | |
*** signed8bit has quit IRC | 21:59 | |
*** rushil has quit IRC | 22:02 | |
*** alex_klimov has quit IRC | 22:05 | |
*** Piet has joined #openstack-nova | 22:05 | |
*** erlon has quit IRC | 22:08 | |
*** mdrabe has quit IRC | 22:10 | |
*** marzif has joined #openstack-nova | 22:10 | |
*** ijw_ has quit IRC | 22:11 | |
*** rushil has joined #openstack-nova | 22:11 | |
*** VW_ has joined #openstack-nova | 22:15 | |
*** eglynn has quit IRC | 22:16 | |
*** marzif_ has joined #openstack-nova | 22:18 | |
*** marzif has quit IRC | 22:18 | |
*** dims_ has joined #openstack-nova | 22:20 | |
*** davideag_ has joined #openstack-nova | 22:21 | |
*** VW__ has joined #openstack-nova | 22:22 | |
*** davideagnello has quit IRC | 22:23 | |
*** dims has quit IRC | 22:23 | |
*** VW_ has quit IRC | 22:26 | |
*** VW__ has quit IRC | 22:26 | |
*** isq has joined #openstack-nova | 22:29 | |
*** yamahata has quit IRC | 22:30 | |
*** ctrath has quit IRC | 22:30 | |
*** yamahata has joined #openstack-nova | 22:31 | |
*** Marga_ has quit IRC | 22:32 | |
*** ijw_ has joined #openstack-nova | 22:33 | |
*** ijw_ has quit IRC | 22:33 | |
*** Marga_ has joined #openstack-nova | 22:35 | |
*** tonytan4ever has joined #openstack-nova | 22:35 | |
*** Marga_ has quit IRC | 22:36 | |
*** achanda has quit IRC | 22:37 | |
*** Marga_ has joined #openstack-nova | 22:37 | |
*** linkmark has quit IRC | 22:38 | |
*** dave-mccowan has joined #openstack-nova | 22:39 | |
*** Marga_ has quit IRC | 22:43 | |
*** Marga_ has joined #openstack-nova | 22:43 | |
*** tpeoples has quit IRC | 22:44 | |
*** tpeoples has joined #openstack-nova | 22:45 | |
*** SourabhP has joined #openstack-nova | 22:46 | |
*** thorst has joined #openstack-nova | 22:47 | |
*** unicell has joined #openstack-nova | 22:47 | |
*** unicell1 has quit IRC | 22:48 | |
*** tpeoples has quit IRC | 22:49 | |
*** marzif_ has quit IRC | 22:52 | |
*** unicell has quit IRC | 22:52 | |
*** dannywilson has quit IRC | 22:52 | |
*** unicell has joined #openstack-nova | 22:52 | |
*** dannywilson has joined #openstack-nova | 22:53 | |
*** davideagnello has joined #openstack-nova | 22:55 | |
*** salv-orl_ has joined #openstack-nova | 22:56 | |
*** tonytan4ever has quit IRC | 22:56 | |
*** SourabhP has quit IRC | 22:57 | |
*** davideag_ has quit IRC | 22:58 | |
*** emagana has quit IRC | 22:59 | |
*** salv-orlando has quit IRC | 22:59 | |
*** baoli_ has quit IRC | 23:01 | |
*** baoli has joined #openstack-nova | 23:02 | |
*** IanGovett has joined #openstack-nova | 23:03 | |
*** SourabhP has joined #openstack-nova | 23:04 | |
*** xyang1 has quit IRC | 23:05 | |
*** ijuwang has quit IRC | 23:06 | |
*** IanGovett has quit IRC | 23:06 | |
*** baoli has quit IRC | 23:07 | |
*** tjones has joined #openstack-nova | 23:07 | |
*** tjones has left #openstack-nova | 23:08 | |
*** baoli has joined #openstack-nova | 23:08 | |
*** rushil has quit IRC | 23:10 | |
*** achanda has joined #openstack-nova | 23:17 | |
*** apuimedo has quit IRC | 23:17 | |
*** browne has quit IRC | 23:20 | |
*** thorst has quit IRC | 23:22 | |
*** SourabhP has quit IRC | 23:22 | |
*** nic has quit IRC | 23:22 | |
*** otter768 has joined #openstack-nova | 23:23 | |
*** otter768 has quit IRC | 23:28 | |
*** karimb has quit IRC | 23:28 | |
*** mmedvede has quit IRC | 23:29 | |
*** pixelbeat has joined #openstack-nova | 23:35 | |
*** ZZelle_ has quit IRC | 23:35 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add microversion bump exception for scheduler-hint https://review.openstack.org/221642 | 23:37 |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add API schema for different_cell filter https://review.openstack.org/220893 | 23:37 |
*** promulo has joined #openstack-nova | 23:37 | |
*** dave-mccowan has quit IRC | 23:39 | |
*** diana_clarke has quit IRC | 23:41 | |
*** rushil has joined #openstack-nova | 23:41 | |
*** salv-orl_ has quit IRC | 23:43 | |
*** kse has joined #openstack-nova | 23:44 | |
*** hemna is now known as hemnafk | 23:44 | |
*** SourabhP has joined #openstack-nova | 23:46 | |
*** baoli has quit IRC | 23:47 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add microversions schema unit test for None https://review.openstack.org/222068 | 23:47 |
*** angdraug has quit IRC | 23:50 | |
*** shoutm has joined #openstack-nova | 23:51 | |
*** dannywilson has quit IRC | 23:53 | |
*** aix has quit IRC | 23:53 | |
*** dannywilson has joined #openstack-nova | 23:55 | |
*** SourabhP has quit IRC | 23:56 | |
*** tonytan4ever has joined #openstack-nova | 23:57 | |
*** dannywilson has quit IRC | 23:58 | |
*** Sukhdev has joined #openstack-nova | 23:58 | |
openstackgerrit | Tomoki Sekiyama proposed openstack/nova: Fix multipath iSCSI encrypted volume attach failure https://review.openstack.org/196482 | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!