*** salv-orlando has quit IRC | 00:00 | |
*** pixelbeat has quit IRC | 00:01 | |
*** inara has quit IRC | 00:03 | |
*** zhangjn has joined #openstack-nova | 00:04 | |
*** inara has joined #openstack-nova | 00:07 | |
*** EinstCrazy has quit IRC | 00:08 | |
*** IanGovett has quit IRC | 00:10 | |
*** Marga_ has joined #openstack-nova | 00:10 | |
*** achanda has quit IRC | 00:12 | |
*** Marga_ has quit IRC | 00:15 | |
*** sseverson has quit IRC | 00:18 | |
*** asettle has quit IRC | 00:24 | |
*** Kennan_Vacation2 has quit IRC | 00:25 | |
*** ijw has quit IRC | 00:28 | |
*** Kennan_Vacation has joined #openstack-nova | 00:30 | |
*** Kennan_Vacation is now known as Kennan | 00:34 | |
*** zhangjn has quit IRC | 00:34 | |
*** salv-orlando has joined #openstack-nova | 00:37 | |
*** markvoelker has joined #openstack-nova | 00:38 | |
*** zhangjn has joined #openstack-nova | 00:39 | |
*** zhangjn has quit IRC | 00:42 | |
*** markvoelker has quit IRC | 00:42 | |
*** salv-orlando has quit IRC | 00:43 | |
*** zhangjn has joined #openstack-nova | 00:44 | |
*** ijw has joined #openstack-nova | 00:45 | |
*** salv-orlando has joined #openstack-nova | 00:48 | |
*** ijw has quit IRC | 00:49 | |
*** ijw has joined #openstack-nova | 00:50 | |
*** salv-orlando has quit IRC | 00:53 | |
*** zhangjn has quit IRC | 00:53 | |
*** salv-orlando has joined #openstack-nova | 00:53 | |
*** zhangjn has joined #openstack-nova | 00:55 | |
*** alexpilotti has quit IRC | 00:59 | |
*** salv-orlando has quit IRC | 00:59 | |
*** EinstCrazy has joined #openstack-nova | 01:00 | |
*** zhangjn has quit IRC | 01:02 | |
*** david-lyle has joined #openstack-nova | 01:03 | |
*** zhangjn has joined #openstack-nova | 01:09 | |
openstackgerrit | Claudiu Belu proposed openstack/nova: Adds HostCapabilities database model and migration https://review.openstack.org/228279 | 01:09 |
---|---|---|
openstackgerrit | Claudiu Belu proposed openstack/nova: Adds HostCapabilities object model https://review.openstack.org/228280 | 01:09 |
*** Marga_ has joined #openstack-nova | 01:11 | |
*** ircuser-1 has joined #openstack-nova | 01:13 | |
openstackgerrit | Claudiu Belu proposed openstack/nova-specs: Adds os-win dependency spec https://review.openstack.org/227827 | 01:13 |
*** achanda has joined #openstack-nova | 01:13 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs: Add project id and user id information in os-server-group API https://review.openstack.org/209917 | 01:15 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: DB:support for migration objects multi-statuses https://review.openstack.org/169604 | 01:15 |
*** zul has joined #openstack-nova | 01:16 | |
*** Marga_ has quit IRC | 01:16 | |
*** otter768 has joined #openstack-nova | 01:20 | |
*** dave-mccowan has quit IRC | 01:24 | |
*** otter768 has quit IRC | 01:25 | |
*** dims_ has quit IRC | 01:28 | |
*** diogogmt has quit IRC | 01:28 | |
*** rushil_ has quit IRC | 01:28 | |
*** mdrabe has joined #openstack-nova | 01:28 | |
*** diogogmt has joined #openstack-nova | 01:29 | |
*** baoli has joined #openstack-nova | 01:29 | |
*** ujjain has quit IRC | 01:33 | |
*** Kennan2 has joined #openstack-nova | 01:33 | |
openstackgerrit | Claudiu Belu proposed openstack/nova-specs: Adds spec for exposing host capabilities https://review.openstack.org/222200 | 01:34 |
*** isq_ has joined #openstack-nova | 01:34 | |
*** rushil has joined #openstack-nova | 01:34 | |
*** mdrabe has quit IRC | 01:35 | |
*** frickler has quit IRC | 01:36 | |
*** doffm_ has joined #openstack-nova | 01:36 | |
*** mwagner_ has joined #openstack-nova | 01:36 | |
*** frickler has joined #openstack-nova | 01:36 | |
*** dosaboy_ has joined #openstack-nova | 01:36 | |
*** haomaiwang has joined #openstack-nova | 01:37 | |
*** DuncanT_ has joined #openstack-nova | 01:38 | |
*** mnaser_ has joined #openstack-nova | 01:38 | |
*** ujjain has joined #openstack-nova | 01:38 | |
*** ujjain has quit IRC | 01:38 | |
*** ujjain has joined #openstack-nova | 01:38 | |
*** Kennan has quit IRC | 01:38 | |
*** mnaser has quit IRC | 01:38 | |
*** mnaser_ is now known as mnaser | 01:38 | |
*** dosaboy has quit IRC | 01:38 | |
*** isq has quit IRC | 01:38 | |
*** doffm has quit IRC | 01:38 | |
*** sileht has quit IRC | 01:38 | |
*** baoli has quit IRC | 01:38 | |
*** mwagner_lap has quit IRC | 01:38 | |
*** DuncanT has quit IRC | 01:38 | |
*** edleafe has quit IRC | 01:38 | |
*** tr3buchet has quit IRC | 01:38 | |
*** vilobhmm11 has quit IRC | 01:38 | |
*** strictlyb is now known as sb | 01:39 | |
*** edleafe- has joined #openstack-nova | 01:39 | |
*** sileht has joined #openstack-nova | 01:39 | |
*** dimsum__ has joined #openstack-nova | 01:40 | |
*** eliqiao has joined #openstack-nova | 01:41 | |
*** haomaiwang has quit IRC | 01:41 | |
*** haomaiwang has joined #openstack-nova | 01:41 | |
*** DuncanT_ is now known as DuncanT | 01:44 | |
*** tr3buchet has joined #openstack-nova | 01:48 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add pep8 check for assertEqual argument order https://review.openstack.org/227650 | 01:54 |
*** Marga_ has joined #openstack-nova | 01:54 | |
*** Marga_ has quit IRC | 01:57 | |
*** Marga_ has joined #openstack-nova | 01:57 | |
*** haomaiwang has quit IRC | 02:01 | |
*** haomaiwang has joined #openstack-nova | 02:01 | |
*** vilobhmm11 has joined #openstack-nova | 02:03 | |
*** wanghua has joined #openstack-nova | 02:05 | |
*** penick has joined #openstack-nova | 02:06 | |
*** penick has quit IRC | 02:07 | |
*** markvoelker has joined #openstack-nova | 02:08 | |
*** vilobhmm11 has quit IRC | 02:09 | |
*** markvoelker has quit IRC | 02:13 | |
*** otter768 has joined #openstack-nova | 02:22 | |
*** su_zhang has joined #openstack-nova | 02:26 | |
*** armax has joined #openstack-nova | 02:28 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 02:30 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Drop outdated sqlite downgrade script https://review.openstack.org/212891 | 02:31 |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add checks for volume status when rebuilding https://review.openstack.org/217567 | 02:31 |
*** pratikmallya has joined #openstack-nova | 02:37 | |
*** asettle has joined #openstack-nova | 02:45 | |
*** dimsum__ has quit IRC | 02:48 | |
*** karimb has quit IRC | 02:50 | |
*** haomaiwang has quit IRC | 03:01 | |
*** haomaiwang has joined #openstack-nova | 03:01 | |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'dummy' status with migration_status.DUMMY. https://review.openstack.org/228177 | 03:02 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'failed' status with migration_status.FAILED. https://review.openstack.org/228176 | 03:02 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'post-migrating' status with migration_status.POST_MIGRATING. https://review.openstack.org/228166 | 03:02 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'finished' statuses with migration_status.FINISHED. https://review.openstack.org/228167 | 03:02 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'migrating' status with migration_status.MIGRATING. https://review.openstack.org/228164 | 03:02 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'running' status with migration_status.MIGRATING. https://review.openstack.org/228165 | 03:02 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'preparing' status with migration_status.PREPARING. https://review.openstack.org/228162 | 03:02 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'pre-migrating' status with migration_status.PRE_MIGRATING. https://review.openstack.org/228163 | 03:02 |
openstackgerrit | Tang Chen proposed openstack/nova: Introduce constants to indicate live migration status. https://review.openstack.org/228161 | 03:02 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'reverted' status with migration_status.REVERTED. https://review.openstack.org/228174 | 03:02 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'error' status with migration_status.ERROR. https://review.openstack.org/228175 | 03:02 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'confirmed' status with migration_status.CONFIRMED. https://review.openstack.org/228172 | 03:02 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'reverting' status with migration_status.REVERTING. https://review.openstack.org/228173 | 03:02 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'queued' status with migration_status.QUEUED. https://review.openstack.org/228170 | 03:02 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'confirming' status with migration_status.CONFIRMING. https://review.openstack.org/228171 | 03:02 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'completed' status with migration_status.FINISHED. https://review.openstack.org/228168 | 03:02 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'done' status with migration_status.FINISHED. https://review.openstack.org/228169 | 03:02 |
*** yuner027 has quit IRC | 03:07 | |
*** cfriesen__ has joined #openstack-nova | 03:07 | |
*** yuner027 has joined #openstack-nova | 03:08 | |
*** Venkatesh has joined #openstack-nova | 03:08 | |
*** shyu has joined #openstack-nova | 03:09 | |
*** dimsum__ has joined #openstack-nova | 03:09 | |
*** dims_ has joined #openstack-nova | 03:10 | |
*** bnemec has quit IRC | 03:12 | |
*** dimsum__ has quit IRC | 03:14 | |
*** baoli has joined #openstack-nova | 03:16 | |
*** unicell has quit IRC | 03:19 | |
*** unicell has joined #openstack-nova | 03:19 | |
*** diogogmt has quit IRC | 03:24 | |
*** dimsum__ has joined #openstack-nova | 03:25 | |
*** dimsum__ has quit IRC | 03:27 | |
*** dims_ has quit IRC | 03:28 | |
*** haomaiwang has quit IRC | 03:29 | |
openstackgerrit | Man Li Qi proposed openstack/nova: VMware: Ensure all the disk files of VM could be deleted along with VM deletion https://review.openstack.org/228285 | 03:31 |
*** achanda has quit IRC | 03:32 | |
*** eliqiao has left #openstack-nova | 03:32 | |
*** achanda has joined #openstack-nova | 03:33 | |
*** otter768 has quit IRC | 03:37 | |
openstackgerrit | Man Li Qi proposed openstack/nova: VMware: Ensure all the disk files of VM could be deleted along with VM deletion https://review.openstack.org/228285 | 03:39 |
*** baoli has quit IRC | 03:39 | |
*** achanda has quit IRC | 03:41 | |
*** deepthi has joined #openstack-nova | 03:42 | |
*** lpetrut has joined #openstack-nova | 03:43 | |
*** lykinsbd has joined #openstack-nova | 03:44 | |
*** haomaiwa_ has joined #openstack-nova | 04:01 | |
*** armax has quit IRC | 04:03 | |
*** vilobhmm11 has joined #openstack-nova | 04:04 | |
*** VikasC has joined #openstack-nova | 04:10 | |
*** lennyb has quit IRC | 04:18 | |
*** lennyb has joined #openstack-nova | 04:19 | |
*** scheuran has joined #openstack-nova | 04:22 | |
*** scheuran has quit IRC | 04:22 | |
*** dimsum__ has joined #openstack-nova | 04:27 | |
*** Sree has joined #openstack-nova | 04:32 | |
*** ijw has quit IRC | 04:33 | |
*** Sree has quit IRC | 04:33 | |
*** dimsum__ has quit IRC | 04:34 | |
*** Sree has joined #openstack-nova | 04:34 | |
openstackgerrit | Alex Xu proposed openstack/nova: Adjust the relationship of Instance and PciDeviceList https://review.openstack.org/228299 | 04:39 |
*** Sree_ has joined #openstack-nova | 04:41 | |
*** Sree_ is now known as Guest99788 | 04:41 | |
*** mdbooth has quit IRC | 04:44 | |
*** Sree has quit IRC | 04:44 | |
*** salv-orlando has joined #openstack-nova | 04:47 | |
*** deepakcs has joined #openstack-nova | 04:48 | |
*** mdbooth has joined #openstack-nova | 04:49 | |
*** pradipta has joined #openstack-nova | 04:57 | |
*** haomaiwa_ has quit IRC | 05:01 | |
*** toabctl has quit IRC | 05:01 | |
*** haomaiwang has joined #openstack-nova | 05:01 | |
*** Venkatesh has quit IRC | 05:02 | |
openstackgerrit | Hiroyuki Eguchi proposed openstack/nova-specs: Live migrate local disk https://review.openstack.org/228302 | 05:04 |
*** toabctl has joined #openstack-nova | 05:04 | |
*** salv-orlando has quit IRC | 05:06 | |
*** salv-orlando has joined #openstack-nova | 05:09 | |
*** Venkatesh has joined #openstack-nova | 05:11 | |
*** achanda has joined #openstack-nova | 05:12 | |
*** lpetrut has quit IRC | 05:15 | |
openstackgerrit | Alex Xu proposed openstack/nova: Correct Instance class type check to work with InstanceV1 https://review.openstack.org/228304 | 05:17 |
*** lpetrut has joined #openstack-nova | 05:18 | |
openstackgerrit | Hiroyuki Eguchi proposed openstack/nova-specs: Live migrate local disk https://review.openstack.org/228302 | 05:19 |
*** salv-orlando has quit IRC | 05:20 | |
*** cfriesen__ has quit IRC | 05:21 | |
*** rushil has quit IRC | 05:30 | |
*** garyk has joined #openstack-nova | 05:32 | |
*** salv-orlando has joined #openstack-nova | 05:33 | |
*** emagana has joined #openstack-nova | 05:36 | |
*** salv-orlando has quit IRC | 05:37 | |
*** otter768 has joined #openstack-nova | 05:38 | |
*** otter768 has quit IRC | 05:43 | |
*** EinstCrazy has quit IRC | 05:47 | |
*** EinstCrazy has joined #openstack-nova | 05:48 | |
*** sahid has joined #openstack-nova | 05:48 | |
*** Marga_ has quit IRC | 05:49 | |
*** Marga_ has joined #openstack-nova | 05:52 | |
*** oomichi has joined #openstack-nova | 05:53 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add pep8 check for assertEqual argument order https://review.openstack.org/227650 | 05:53 |
*** ildikov has quit IRC | 05:55 | |
oomichi | johnthetubaguy: hello | 05:55 |
*** claudiub has joined #openstack-nova | 05:56 | |
*** boris-42 has joined #openstack-nova | 05:56 | |
*** sudipto has joined #openstack-nova | 05:57 | |
*** ijw has joined #openstack-nova | 06:00 | |
*** haomaiwang has quit IRC | 06:01 | |
*** haomaiwang has joined #openstack-nova | 06:01 | |
*** rajesht has joined #openstack-nova | 06:03 | |
*** nkrinner has joined #openstack-nova | 06:05 | |
openstackgerrit | Alex Xu proposed openstack/nova: Adjust the relationship of Instance and PciDeviceList https://review.openstack.org/228299 | 06:07 |
openstackgerrit | Alex Xu proposed openstack/nova: Correct Instance type check to work with InstanceV1 https://review.openstack.org/228304 | 06:07 |
*** tjones has quit IRC | 06:09 | |
openstackgerrit | Alex Xu proposed openstack/nova: Adjust the relationship of Instance and PciDeviceList https://review.openstack.org/228299 | 06:11 |
openstackgerrit | Alex Xu proposed openstack/nova: Correct Instance type check to work with InstanceV1 https://review.openstack.org/228304 | 06:12 |
openstackgerrit | Alex Xu proposed openstack/nova: Correct Instance type check to work with InstanceV1 https://review.openstack.org/228304 | 06:13 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'post-migrating' status with migration_status.POST_MIGRATING. https://review.openstack.org/228166 | 06:15 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'finished' statuses with migration_status.FINISHED. https://review.openstack.org/228167 | 06:15 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'migrating' status with migration_status.MIGRATING. https://review.openstack.org/228164 | 06:15 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'running' status with migration_status.MIGRATING. https://review.openstack.org/228165 | 06:15 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'preparing' status with migration_status.PREPARING. https://review.openstack.org/228162 | 06:15 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'pre-migrating' status with migration_status.PRE_MIGRATING. https://review.openstack.org/228163 | 06:15 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'dummy' status with migration_status.DUMMY. https://review.openstack.org/228177 | 06:15 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'failed' status with migration_status.FAILED. https://review.openstack.org/228176 | 06:15 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'reverted' status with migration_status.REVERTED. https://review.openstack.org/228174 | 06:15 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'error' status with migration_status.ERROR. https://review.openstack.org/228175 | 06:15 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'confirmed' status with migration_status.CONFIRMED. https://review.openstack.org/228172 | 06:15 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'reverting' status with migration_status.REVERTING. https://review.openstack.org/228173 | 06:15 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'queued' status with migration_status.QUEUED. https://review.openstack.org/228170 | 06:15 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'confirming' status with migration_status.CONFIRMING. https://review.openstack.org/228171 | 06:15 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'completed' status with migration_status.FINISHED. https://review.openstack.org/228168 | 06:15 |
openstackgerrit | Tang Chen proposed openstack/nova: Replace 'done' status with migration_status.FINISHED. https://review.openstack.org/228169 | 06:15 |
*** marzif has joined #openstack-nova | 06:19 | |
*** mpaolino has joined #openstack-nova | 06:26 | |
*** yuner027 has quit IRC | 06:29 | |
*** ijw_ has joined #openstack-nova | 06:30 | |
*** dimsum__ has joined #openstack-nova | 06:31 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Imported Translations from Zanata https://review.openstack.org/227138 | 06:32 |
*** ijw has quit IRC | 06:32 | |
*** Kennan2 is now known as Kennan | 06:33 | |
*** yuner027 has joined #openstack-nova | 06:35 | |
*** dimsum__ has quit IRC | 06:36 | |
*** marzif has quit IRC | 06:39 | |
*** mpaolino has quit IRC | 06:40 | |
*** su_zhang has quit IRC | 06:46 | |
oomichi | johnthetubaguy: can you take a look at https://review.openstack.org/#/c/228276/ ? | 06:46 |
oomichi | johnthetubaguy: that is a project-config patch. we can avoid gate test time when changing hacking | 06:47 |
*** rdopiera has joined #openstack-nova | 06:49 | |
*** e0ne has joined #openstack-nova | 06:49 | |
openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: adds os-win library https://review.openstack.org/212102 | 06:52 |
openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: removes *Utils modules and unit tests https://review.openstack.org/215917 | 06:52 |
*** mpaolino has joined #openstack-nova | 06:53 | |
openstackgerrit | Rajesh Tailor proposed openstack/nova: Fix quota-update when nova-compute startup finish https://review.openstack.org/170118 | 06:54 |
*** yuner027 has quit IRC | 06:54 | |
*** yuner027 has joined #openstack-nova | 06:55 | |
*** kiran-r has joined #openstack-nova | 06:55 | |
*** achanda has quit IRC | 06:56 | |
*** e0ne has quit IRC | 06:59 | |
*** lpetrut has quit IRC | 06:59 | |
*** achanda has joined #openstack-nova | 06:59 | |
*** haomaiwang has quit IRC | 07:01 | |
*** haomaiwa_ has joined #openstack-nova | 07:01 | |
*** pratikmallya has quit IRC | 07:02 | |
*** achanda has quit IRC | 07:02 | |
*** e0ne has joined #openstack-nova | 07:03 | |
*** e0ne has quit IRC | 07:05 | |
*** asettle has quit IRC | 07:06 | |
rajesht | oomichi: you around ?? | 07:06 |
*** Alexus has joined #openstack-nova | 07:06 | |
*** ijw_ has quit IRC | 07:07 | |
*** rdopiera has quit IRC | 07:08 | |
*** rdopiera has joined #openstack-nova | 07:08 | |
*** HaoJun has joined #openstack-nova | 07:08 | |
oomichi | rajesht: hi | 07:09 |
*** e0ne has joined #openstack-nova | 07:09 | |
rajesht | oomichi: want to talk regarding https://review.openstack.org/#/c/227650/ assertEqual pep8 patch | 07:09 |
openstackgerrit | Rui Chen proposed openstack/nova: Execute _init_instance() concurrently https://review.openstack.org/223572 | 07:09 |
oomichi | rajesht: go ahead | 07:09 |
*** pradipta has quit IRC | 07:09 | |
rajesht | oomichi: IMO it will not fix issues where variables are passed as assertEqual argument ?? | 07:10 |
rajesht | oomichi: like https://github.com/openstack/nova/blob/master/nova/tests/unit/compute/test_compute_mgr.py#L567 | 07:10 |
*** matrohon has joined #openstack-nova | 07:10 | |
rajesht | oomichi: Am I right ?? | 07:10 |
openstackgerrit | Rui Chen proposed openstack/nova: Fix booting fail when unlimited project quota https://review.openstack.org/219596 | 07:10 |
oomichi | rajesht: yeah, you are right. it is difficult to handle these cases in pep8 check. and I don't think it is worth to do that in the first step | 07:11 |
*** ildikov has joined #openstack-nova | 07:11 | |
rajesht | oomichi: yeah, I think its impossible to add in pep8, if you need to set any of my assertEqual patch to set as dependent. let me know | 07:12 |
*** lpetrut has joined #openstack-nova | 07:13 | |
rajesht | oomichi: anyways one last question. Should I rebase my assertEqual patches ? If those can be considered for existing such scenraios. | 07:13 |
openstackgerrit | Rui Chen proposed openstack/nova: Remove useless get_instance_faults() https://review.openstack.org/223434 | 07:14 |
oomichi | rajesht: yeah, it is great to do that. but before doing that, I'd like to ask johnthetubaguy to get his opinion for moving forward :) | 07:14 |
rajesht | oomichi: thank a lot for ur time.. pls inform me as well about his opinion. :) | 07:15 |
*** salv-orlando has joined #openstack-nova | 07:21 | |
*** atuvenie has joined #openstack-nova | 07:22 | |
*** salv-orlando has quit IRC | 07:25 | |
*** ijw has joined #openstack-nova | 07:31 | |
*** jwcroppe has joined #openstack-nova | 07:39 | |
openstackgerrit | Alex Xu proposed openstack/nova: Correct Instance type check to work with InstanceV1 https://review.openstack.org/228304 | 07:39 |
*** otter768 has joined #openstack-nova | 07:39 | |
*** jlanoux has joined #openstack-nova | 07:40 | |
*** otter768 has quit IRC | 07:44 | |
openstackgerrit | Rui Chen proposed openstack/nova: Create image for suspended instance booted from volume https://review.openstack.org/223382 | 07:47 |
*** jamielennox is now known as jamielennox|away | 07:50 | |
*** lpetrut has quit IRC | 07:52 | |
openstackgerrit | Rui Chen proposed openstack/nova: Only return latest fault of each instance in db api https://review.openstack.org/223392 | 07:55 |
*** MarcF has joined #openstack-nova | 07:55 | |
*** e0ne has quit IRC | 07:57 | |
*** Guest99546 is now known as BobBall | 07:57 | |
*** romainh has joined #openstack-nova | 07:57 | |
*** haomaiwa_ has quit IRC | 08:01 | |
*** haomaiwang has joined #openstack-nova | 08:01 | |
*** e0ne has joined #openstack-nova | 08:01 | |
*** Murali has joined #openstack-nova | 08:01 | |
*** mpaolino has quit IRC | 08:06 | |
bauzas | good morning Nova | 08:09 |
claudiub | bonjour monsieur. :D | 08:10 |
*** derekh has joined #openstack-nova | 08:12 | |
*** derekh has quit IRC | 08:12 | |
*** derekh has joined #openstack-nova | 08:13 | |
bauzas | claudiub: "ohayo gozaimasu" should we say rather | 08:13 |
*** markus_z has joined #openstack-nova | 08:15 | |
*** oomichi has quit IRC | 08:18 | |
*** mpaolino has joined #openstack-nova | 08:19 | |
*** jordanP has joined #openstack-nova | 08:21 | |
jordanP | Hi. I am missing a +2 for a patch that has been there since June and that closes 2 bugs: https://review.openstack.org/#/c/192736/ If a core could have a look I'd appreciate that. Thanks | 08:22 |
*** dguitarbite has quit IRC | 08:25 | |
*** kiran-r has quit IRC | 08:26 | |
openstackgerrit | Hiroyuki Eguchi proposed openstack/nova: Rollback of live-migration fails with the NFS driver https://review.openstack.org/228351 | 08:27 |
*** dguitarbite has joined #openstack-nova | 08:28 | |
*** tdurakov has joined #openstack-nova | 08:31 | |
*** yassine__ has joined #openstack-nova | 08:32 | |
alex_xu | johnthetubaguy: dansmith ndipanov appreciate if you can take a look at https://bugs.launchpad.net/nova/+bug/1500289 looks like our upgrade broken. | 08:32 |
openstack | Launchpad bug 1500289 in OpenStack Compute (nova) "Booting instance failed with Kilo stable compute node and liberty controller" [Critical,In progress] - Assigned to Alex Xu (xuhj) | 08:32 |
*** dimsum__ has joined #openstack-nova | 08:33 | |
bauzas | alex_xu: did you bisect ? | 08:34 |
bauzas | alex_xu: have you found the regression ? | 08:34 |
*** digimonde has joined #openstack-nova | 08:34 | |
alex_xu | bauzas: I tested the upgrade kilo stable to liberty, the booting instance failed | 08:34 |
bauzas | alex_xu: nvm, I see the change | 08:35 |
bauzas | alex_xu: I'm still wondering why grenade didn't catch that | 08:36 |
alex_xu | bauzas: I remember grenade only test the offline upgrade, not the live upgrade | 08:36 |
bauzas | alex_xu: right, but we also have partial_ncpu | 08:37 |
alex_xu | bauzas: which one run partial old ncpu? | 08:38 |
*** dimsum__ has quit IRC | 08:38 | |
alex_xu | s/which/that | 08:38 |
bauzas | alex_xu: so, IIRC, you have an old devstack running n-cpu, and a new devstack not running n-cpu | 08:40 |
bauzas | alex_xu: which means that old devstack is running kilo and new is running master | 08:40 |
bauzas | that said, now that we branched liberty, I don't know yet if grenade made the change | 08:41 |
bauzas | alex_xu: because master is now mitaka, and consequently, kilo -> mitaka is not supported | 08:41 |
ndipanov | so I thought we fixed that bug alex_xu ? | 08:41 |
alex_xu | bauzas: emm...that is worth wondering why it didn't catch this error | 08:41 |
alex_xu | ndipanov: no, when I try to upgrade tag'2015.1.0' to stable/liberty, still failed | 08:42 |
bauzas | alex_xu: to be clear, is your controller running liberty (not master) and your n-cpu running stable kilo ? | 08:42 |
ndipanov | that bug is horrible | 08:42 |
alex_xu | bauzas: yes, stable/liberty | 08:42 |
ndipanov | so there was also a bug with the backporting code | 08:42 |
ndipanov | that may still be in kilo | 08:43 |
ndipanov | that will actually drop the pci_device field by mistake | 08:43 |
alex_xu | ndipanov: yes, I think after that backport, the code should works, but if the before that backport, it still failed | 08:43 |
ndipanov | I don't get it | 08:43 |
ndipanov | that fix for the backporting code where ti would downgrade instance to 1.1 | 08:44 |
ndipanov | which is what I think is causing your stacktrace | 08:44 |
alex_xu | ndipanov: if user upgrade to the backport commit, then he will be fine upgrade to liberty. | 08:44 |
ndipanov | which commit is that | 08:44 |
*** haomaiwang has quit IRC | 08:44 | |
*** tdurakov has quit IRC | 08:44 | |
*** haomaiwang has joined #openstack-nova | 08:45 | |
ndipanov | so I though that we support upgrades | 08:45 |
ndipanov | from stable-1 milestone to latest stable | 08:45 |
ndipanov | and from | 08:45 |
ndipanov | latest stable to latest next release | 08:45 |
ndipanov | if that works than this is not something we need to fix I think | 08:45 |
ndipanov | but I may be confused with what we actually support | 08:46 |
alex_xu | oops, just find one more fix for kilo https://review.openstack.org/#/c/203169/1 | 08:47 |
alex_xu | too much history for this bug... | 08:48 |
ndipanov | alex_xu, so I think that we really don't support what you are saying | 08:48 |
alex_xu | ndipanov: I think if user running the code before https://review.openstack.org/#/c/203169/1, then he upgrade to stable/liberty will failed | 08:48 |
*** tutij7 has joined #openstack-nova | 08:48 | |
ndipanov | yeah but that's not supported | 08:48 |
ndipanov | so too bad | 08:48 |
tutij7 | Hi | 08:48 |
tutij7 | may i ask a question about numa awareness | 08:48 |
alex_xu | ok, I begin to confuse | 08:48 |
ndipanov | you either upgrade kilo-1 -> kilo-2 -> liberty | 08:49 |
ndipanov | but maybe not | 08:49 |
ndipanov | maybe we should support kilo-1 -> liberty | 08:49 |
tutij7 | Do you guys know about such a thing that nova stores information about numa in database | 08:49 |
*** tdurakov has joined #openstack-nova | 08:49 | |
ndipanov | tutij7, yeah | 08:49 |
alex_xu | ndipanov: I thought we support kilo-1 to liberty | 08:49 |
ndipanov | alex_xu, maybe we do | 08:49 |
ndipanov | I thought not | 08:49 |
bauzas | not sure | 08:49 |
alex_xu | ndipanov: and we support any commit to any commit in one release, right? | 08:49 |
ndipanov | yes | 08:49 |
tutij7 | thanks ndipanov | 08:49 |
ndipanov | but well no | 08:49 |
ndipanov | alex_xu, I think - yes | 08:50 |
ndipanov | we do claim to support that | 08:50 |
tutij7 | but does nova store information about which pCPU used for numa | 08:50 |
bauzas | alex_xu: IMHO you should update to the latest minor stable before upgrading the major | 08:50 |
tutij7 | i mean for pinning | 08:50 |
tutij7 | which is not | 08:50 |
ndipanov | tutij7, yes | 08:50 |
tutij7 | then we can boot another vm that is not using the pinned pCPU | 08:50 |
ndipanov | tutij7, yes | 08:51 |
bauzas | that said, it's only MHO and I'd definitely hold for some stable cores' advices | 08:51 |
ndipanov | alex_xu, there was a document written by johnthetubaguy recently | 08:51 |
ndipanov | that makes it clear about what we support | 08:51 |
tutij7 | so it means that we can boot a vm that has pinning, another with non-pinning on the same compute host | 08:51 |
tutij7 | ? | 08:51 |
ndipanov | it's in doc somewhere | 08:51 |
ndipanov | tutij7, that's a good question | 08:51 |
alex_xu | ndipanov: there are some describs http://docs.openstack.org/developer/nova/project_scope.html | 08:52 |
ndipanov | that won't work | 08:52 |
tutij7 | yeah | 08:52 |
tutij7 | i think so, too | 08:52 |
tutij7 | :D | 08:52 |
ndipanov | tutij7, but thats by design | 08:52 |
ndipanov | basically you can't mix cpu pinned and "free" instances on the same compute host | 08:52 |
tutij7 | Will it be supported in the upstream version | 08:52 |
ndipanov | never | 08:52 |
tutij7 | may be M version | 08:52 |
ndipanov | nope | 08:53 |
alex_xu | ndipanov: here https://review.openstack.org/#/c/201529/6/doc/source/upgrades.rst which said "Upgrade between stable releases N to N+1 (e.g. kilo to liberty)" | 08:53 |
alex_xu | bauzas: ^ actually we said we supported | 08:53 |
tutij7 | could you please tell me the reason for that | 08:53 |
tutij7 | thank you su much | 08:53 |
bauzas | alex_xu: that's what I'm looking at | 08:53 |
ndipanov | tutij7, the design was - if you want cpu pinning - all of your instances need to go to a separate host aggregate | 08:53 |
ndipanov | so what you do is set up your flavors like that | 08:54 |
bauzas | alex_xu: currently reading the stable wiki and the upgrades devref | 08:54 |
tutij7 | got that | 08:54 |
ndipanov | and then the scheduler will never place a "free" instance on the same host as a pinned one | 08:54 |
tutij7 | you make my day | 08:54 |
ndipanov | it's not massively well documented | 08:54 |
ndipanov | but check this out | 08:54 |
ndipanov | http://redhatstackblog.redhat.com/2015/05/05/cpu-pinning-and-numa-topology-awareness-in-openstack-compute/ | 08:54 |
ndipanov | tutij7, ^ | 08:55 |
ndipanov | this blog basically tells you how to do it | 08:55 |
bauzas | alex_xu: honestly, from a git pov, can't see how you can backport something from stable-kilo to 2015.1.X tag | 08:55 |
tutij7 | yeah, i have read it before | 08:55 |
bauzas | alex_xu: because we branch for majors but we tag for minors | 08:55 |
sudipto | tutij7, Just to add to ndipanov , You can't mix and match - cpus because they float around for user processes. If you have a situation where you have 5 pcpus, and you pin 2 of them - then allow the other applications to have floating CPUs - there won't be way to control the 2 pinned cpus to not execute other user application (in this case your floating VMs) | 08:55 |
tutij7 | i just wonder that if we have any upstream design for this situation | 08:55 |
*** danpb has joined #openstack-nova | 08:56 | |
alex_xu | bauzas: yea, but people may running at that point | 08:56 |
alex_xu | emm....at least we should clear what we want to support | 08:57 |
bauzas | alex_xu: that's why I think you need to migrate first to the latest tag, before upgrading to to major | 08:57 |
ndipanov | tutij7, for what? having pinned and "free" instances on the same host? | 08:57 |
*** kiran-r has joined #openstack-nova | 08:57 | |
tutij7 | yes | 08:57 |
tutij7 | :D | 08:57 |
ndipanov | tutij7, well... | 08:57 |
tutij7 | it seems ridiculous | 08:57 |
alex_xu | bauzas: ok, let me think | 08:57 |
ndipanov | well... | 08:57 |
ndipanov | so | 08:57 |
tutij7 | but actually i got that question and i do not know how to answer it properly | 08:57 |
ndipanov | tutij7, what's the question | 08:58 |
johnthetubaguy | bauzas: alex_xu: the idea of the point releases is there should be no upgrade impact, so in theory if you need a fix just roll to the latest point release, or something like that | 08:58 |
bauzas | alex_xu: check https://wiki.openstack.org/wiki/StableBranch#Proposing_Fixes | 08:58 |
bauzas | johnthetubaguy: right | 08:58 |
tutij7 | the question is: Can that situation happen in the upstream version | 08:58 |
johnthetubaguy | bauzas: alex_xu: yeah, we only backport to the stable branch, and then possible release a new version (via a tag) from that branch | 08:58 |
tutij7 | ? | 08:58 |
tutij7 | or do we have any usecase for that | 08:58 |
*** exploreshaifali has joined #openstack-nova | 08:59 | |
alex_xu | johnthetubaguy: yea | 08:59 |
ndipanov | tutij7, if you set it up correctly using host aggregates than it can't happen | 08:59 |
ndipanov | tutij7, I am not sure what the usecase might be | 08:59 |
bauzas | johnthetubaguy: so the process means that an operator should upgrade to the latest point release before applying the major | 08:59 |
tutij7 | yeah, i got that | 08:59 |
bauzas | which makes sense again, from a git standpoint | 08:59 |
johnthetubaguy | bauzas: erm, hmm, good question, not sure we enforce that | 09:00 |
alex_xu | emm...I don't think so | 09:00 |
sudipto | unless you don't have homogeneous setups - where every user application is pinned to a certain cpu - there are chances that the other non-pinned applications would start using the pinned cpus. If that's the kind of way to explain it... | 09:00 |
*** lpetrut has joined #openstack-nova | 09:00 | |
bauzas | johnthetubaguy: lemme give you my thoughts | 09:00 |
ndipanov | sudipto, but that's what aggregates are for to make sure that never happens | 09:00 |
tutij7 | what i thought before that nova will remember the pinned pCPU, then other VMs booted with floating pCPU wont get those pinned pCPU remembered by Nova | 09:00 |
*** karimb has joined #openstack-nova | 09:00 | |
sudipto | ndipanov, absolutely :) | 09:00 |
bauzas | johnthetubaguy: given I have a fix to backport | 09:00 |
*** haomaiwang has quit IRC | 09:01 | |
ndipanov | tutij7, no - that won't happen because it makes practically ALL instances pinned | 09:01 |
sudipto | ndipanov, i was just trying to explain - why it's done that way... | 09:01 |
bauzas | johnthetubaguy: I then propose it to stable/liberty (provided master is still liberty) | 09:01 |
*** haomaiwang has joined #openstack-nova | 09:01 | |
ndipanov | sudipto, ah right | 09:01 |
bauzas | johnthetubaguy: then, it's merged in the stable branch | 09:01 |
bauzas | johnthetubaguy: in the meantime, before it's merged, there could have been a new tag for a point release | 09:01 |
bauzas | johnthetubaguy: so that my fix wouldn't be shipped with that stable release | 09:02 |
johnthetubaguy | bauzas: well, we allow anyone to use any commit, in theory | 09:02 |
tutij7 | actually that is what i thought in my logic:D | 09:02 |
tutij7 | and now everything is clear | 09:02 |
tutij7 | thanks you guys so much | 09:02 |
ndipanov | tutij7, and that's not what we want for nova | 09:02 |
tutij7 | :yeah, i got that | 09:02 |
bauzas | johnthetubaguy: I don't see how we can fix a .z point release given it's a tag :/ | 09:02 |
ndipanov | because the thinking is - if you need pinning - that's a very specific case that is different than standard overcommit cloud vms | 09:02 |
tutij7 | ah ha | 09:03 |
alex_xu | bauzas: why we need fix that, user only need upgrade | 09:03 |
johnthetubaguy | ndipanov: that does sound a pain to work with, is there a log message we could add to warn people they have it setup wrongly? | 09:03 |
bauzas | alex_xu: in the example ndipanov explained, the upgrade was broken and the fix provided to the stable branch | 09:03 |
ndipanov | johnthetubaguy, nope | 09:03 |
tutij7 | have a nice day guys | 09:04 |
tutij7 | :) | 09:04 |
ndipanov | johnthetubaguy, but that's through with any of those features that require host_setup + filter + extra_specs | 09:04 |
johnthetubaguy | ndipanov: can't we just log when we first spot pinnend and on pinned on the same box? | 09:04 |
ndipanov | johnthetubaguy, we could in theory yes | 09:04 |
johnthetubaguy | ndipanov: most of them don't fight quite as badly as all that | 09:05 |
ndipanov | that would probably be a very good fix | 09:05 |
johnthetubaguy | ndipanov: yeah, just to say "hey read the manual, you screwed up here big time" | 09:05 |
*** salv-orlando has joined #openstack-nova | 09:05 | |
ndipanov | scheduler complaining when it sees something it knows it can't honor | 09:05 |
ndipanov | let me come up with something like that | 09:05 |
alex_xu | bauzas: the fix may needn't a backport | 09:05 |
johnthetubaguy | ndipanov: sweet, thank you | 09:05 |
johnthetubaguy | alex_xu: bauzas: one something is released, its out there, we can have a new release with less known issues, but thats about it really | 09:06 |
bauzas | johnthetubaguy: alex_xu: need to get into the details to see when and where the patches were landed | 09:08 |
johnthetubaguy | bauzas: so I am missing a bit of the scrollback, whats the debate about? | 09:08 |
bauzas | johnthetubaguy: https://bugs.launchpad.net/nova/+bug/1500289 | 09:08 |
openstack | Launchpad bug 1500289 in OpenStack Compute (nova) "Booting instance failed with Kilo stable compute node and liberty controller" [Critical,In progress] - Assigned to Alex Xu (xuhj) | 09:08 |
bauzas | alex_xu: which version of stable/kilo were you running? | 09:09 |
johnthetubaguy | bauzas: oh yeah, thats are almost impossible to fix, I know we have some issues with some commits in kilo stable | 09:09 |
alex_xu | johnthetubaguy: ^ the compute node run at tag 2015.1.0 | 09:09 |
alex_xu | bauzas: tag 2015.1.0 | 09:09 |
*** salv-orl_ has joined #openstack-nova | 09:09 | |
bauzas | johnthetubaguy: alex_xu: so my take is that there is a 2015.1.1 that can possibly include the bugfix | 09:10 |
*** achanda has joined #openstack-nova | 09:10 | |
*** salv-orlando has quit IRC | 09:10 | |
johnthetubaguy | alex_xu: oh wow thats messed up, I see what you mean now | 09:10 |
bauzas | johnthetubaguy: alex_xu: so I'm trying to see which patch fixes the problem, when it has been landed on stable/kilo and if we support upgrades from a non-latest point release | 09:11 |
johnthetubaguy | bauzas: alex_xu: surely this is the instance v2 object issue | 09:11 |
bauzas | johnthetubaguy: because like I said to alex_xu, grenade n-cpu is perfectly happy with upgrading from kilo to liberty | 09:11 |
bauzas | johnthetubaguy: tbc I'm trying to identify if that bug is invalid | 09:12 |
bauzas | because not supported (old n-cpu point release | 09:12 |
johnthetubaguy | bauzas: it looks totally valid to me | 09:13 |
alex_xu | johnthetubaguy: bauzas just note, that bug actually show two issues and the fixed at here https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/1500289,n,z | 09:13 |
johnthetubaguy | bauzas: kilo release, with no patches, should upgrade cleanly | 09:13 |
bauzas | johnthetubaguy: the compute is 2015.1.0, not 2015.1.1 | 09:13 |
johnthetubaguy | bauzas: thats totally fine | 09:13 |
alex_xu | yea | 09:13 |
bauzas | johnthetubaguy: well, given an upgrade is broken, how can we fix the upgrade if we allow to upgrade from the first SHA of the branch ? | 09:14 |
*** apuimedo has joined #openstack-nova | 09:14 | |
* alex_xu what is first SHA means | 09:15 | |
*** pratikmallya has joined #openstack-nova | 09:15 | |
johnthetubaguy | bauzas: we have not yet released liberty, so we have time | 09:15 |
bauzas | johnthetubaguy: IIUC, the problem is on the stable release, ie. on the compute node :/ | 09:16 |
johnthetubaguy | bauzas: maybe, but you can't change that code | 09:16 |
bauzas | johnthetubaguy: okay, I see your point then | 09:16 |
alex_xu | bauzas: so that is this patch https://review.openstack.org/228299 it only fix for liberty stable | 09:16 |
*** Guest63150 has joined #openstack-nova | 09:17 | |
johnthetubaguy | alex_xu: there is a gremlin in here, I think: https://review.openstack.org/#/c/228304/4 | 09:17 |
alex_xu | johnthetubaguy: that one https://review.openstack.org/#/c/228304/5/nova/compute/manager.py is different, it won't check whether instance is list or not. For other case is check instance is novaobject or not | 09:19 |
johnthetubaguy | alex_xu: so this is a tricky one: https://review.openstack.org/#/c/228299/3/nova/objects/instance.py,cm does this still work with all 2015.1.x | 09:19 |
johnthetubaguy | alex_xu: but its check for the object not the object list, I think? it later creates the object list from the single instance | 09:20 |
bauzas | johnthetubaguy: alex_xu: oh that reminds me that we need to fix only kilo->liberty, not liberty->mitaka, because dansmith removed all the hassling bits of version pinning within the conductor | 09:21 |
*** pratikma_ has joined #openstack-nova | 09:21 | |
openstackgerrit | Rui Chen proposed openstack/nova-specs: Task states improvement https://review.openstack.org/216578 | 09:21 |
alex_xu | johnthetubaguy: yes, add 'not' in the check. That means not list then convert it to list | 09:22 |
johnthetubaguy | alex_xu: oh... | 09:22 |
openstackgerrit | John Garbutt proposed openstack/nova: Adjust the relationship of Instance and PciDeviceList https://review.openstack.org/228299 | 09:22 |
*** pratikmallya has quit IRC | 09:24 | |
johnthetubaguy | bauzas: hmm, the commit to fix this does seem to assuming folks upgrade kilo, before upgrading to liberty, thats quite a gotcha :( https://review.openstack.org/#/c/201280/ | 09:26 |
*** zhenguo has quit IRC | 09:26 | |
* bauzas is puzzled with all the commits | 09:27 | |
*** karimb has quit IRC | 09:28 | |
*** ijw has quit IRC | 09:28 | |
bauzas | so, IIUC the original problem is with https://review.openstack.org/#/c/140289/ that merged in Kilo | 09:29 |
johnthetubaguy | alex_xu: OK, so I think these changes make sense to me, but totally need dansmith to take a look | 09:29 |
*** ijw has joined #openstack-nova | 09:29 | |
bauzas | agreed | 09:29 |
johnthetubaguy | alex_xu: can we rewrite this to look like a straight revert, because I think thats basically what it is: https://review.openstack.org/#/c/228299/4 | 09:30 |
*** vilobhmm11 has quit IRC | 09:30 | |
alex_xu | johnthetubaguy: yes, can I remove the 'FIXME' in the https://review.openstack.org/#/c/202616/2/nova/objects/instance.py when revert? | 09:32 |
*** tdurakov has quit IRC | 09:32 | |
*** ijw has quit IRC | 09:33 | |
*** e0ne has quit IRC | 09:33 | |
johnthetubaguy | alex_xu: I way really thinking something more like adding this at the top: "this is basically a revert of commit: XXXX", rather than it strictly being a revert, sorry, I was very unclear there. | 09:34 |
alex_xu | johnthetubaguy: np, it's fine, let me update it | 09:35 |
*** su_zhang has joined #openstack-nova | 09:35 | |
*** tdurakov has joined #openstack-nova | 09:35 | |
*** dimsum__ has joined #openstack-nova | 09:36 | |
*** e0ne has joined #openstack-nova | 09:38 | |
bauzas | alex_xu: johnthetubaguy: okay, FWIW I think your change is valid | 09:39 |
alex_xu | bauzas: thanks | 09:39 |
bauzas | alex_xu: you tho need to backport it to stable/liberty | 09:39 |
alex_xu | bauzas: yea | 09:39 |
bauzas | johnthetubaguy: btw. ttx -2'd a RC2 proposal, any idea when the RC2 window will be defined ? | 09:40 |
*** otter768 has joined #openstack-nova | 09:40 | |
*** su_zhang has quit IRC | 09:40 | |
johnthetubaguy | bauzas: I think its about giving folks more time to test RC1 | 09:42 |
bauzas | johnthetubaguy: okay, I see | 09:42 |
johnthetubaguy | bauzas: we did talk about opening that early this week | 09:42 |
bauzas | okay | 09:42 |
bauzas | that makes sense :) | 09:42 |
*** HaoJun has quit IRC | 09:44 | |
*** dimsum__ has quit IRC | 09:45 | |
*** tojuvone__ is now known as tojuvone | 09:45 | |
*** otter768 has quit IRC | 09:45 | |
*** asettle has joined #openstack-nova | 09:50 | |
rajesht | can anyone help me out what should be done in this case https://review.openstack.org/#/c/163798/ | 09:50 |
*** dimsum__ has joined #openstack-nova | 09:51 | |
johnthetubaguy | rajesht: we added the projection on purpose, it would be a shame to drop that protection | 09:52 |
*** jaypipes has joined #openstack-nova | 09:52 | |
*** sc68cal has quit IRC | 09:52 | |
rajesht | johnthetubaguy: which projection/protection ? | 09:53 |
openstackgerrit | sahid proposed openstack/nova: libvirt: add realtime support https://review.openstack.org/197569 | 09:53 |
johnthetubaguy | rajesht: the bit where we stop multiple deletes | 09:53 |
johnthetubaguy | being sent | 09:54 |
rajesht | johnthetubaguy: In this case also, we are doing that. There won't be multiple delete/force-delete request. | 09:55 |
johnthetubaguy | rajesht: I would rather see ways to monitor the task, and automatically re-run if its appears to have been lost after some timeout | 09:55 |
*** achanda has quit IRC | 09:55 | |
openstackgerrit | Alex Xu proposed openstack/nova: Adjust the relationship of Instance and PciDeviceList https://review.openstack.org/228299 | 09:55 |
openstackgerrit | Alex Xu proposed openstack/nova: Correct Instance type check to work with InstanceV1 https://review.openstack.org/228304 | 09:55 |
rajesht | johnthetubaguy: if instnace task_state is already deleting, then force-delete will change task state to 'force-deleting' | 09:55 |
alex_xu | johnthetubaguy: bauzas updated ^ and fix the failed unittest | 09:55 |
*** jwcroppe has quit IRC | 09:55 | |
rajesht | if task_state is force-deleting then there is no way to send either delete or force-delete request | 09:55 |
* alex_xu offline for a hour, back later | 09:56 | |
*** sc68cal has joined #openstack-nova | 09:56 | |
*** sc68cal has quit IRC | 09:56 | |
*** sc68cal has joined #openstack-nova | 09:56 | |
rajesht | As of now, force-delete is only working if instance task_state is None, | 09:56 |
*** jwcroppe has joined #openstack-nova | 09:56 | |
rajesht | johnthetubaguy: IMO force-delete api should be able to delete instance irrespective of task_state as per its name | 09:57 |
*** pratikma_ has quit IRC | 09:59 | |
*** haomaiwang has quit IRC | 10:01 | |
*** haomaiwang has joined #openstack-nova | 10:01 | |
*** huats has quit IRC | 10:01 | |
*** huats has joined #openstack-nova | 10:02 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova-specs: Add notification for service status change https://review.openstack.org/182350 | 10:04 |
*** xgsa has quit IRC | 10:06 | |
*** Guest99788 has quit IRC | 10:06 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Fix the help text of monkey_patch config param https://review.openstack.org/219722 | 10:07 |
*** Sree has joined #openstack-nova | 10:07 | |
*** romainh has quit IRC | 10:10 | |
*** exploreshaifali has quit IRC | 10:11 | |
*** Sree has quit IRC | 10:11 | |
*** xgsa has joined #openstack-nova | 10:13 | |
*** jlanoux has quit IRC | 10:15 | |
*** jlanoux has joined #openstack-nova | 10:17 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova-specs: Add support for shared volumes between guests https://review.openstack.org/212508 | 10:17 |
*** kiran-r has quit IRC | 10:22 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova-specs: Add support for shared volumes between guests https://review.openstack.org/212508 | 10:23 |
*** xgsa has quit IRC | 10:23 | |
Venkatesh | johnthetubaguy: Can you review this patch https://review.openstack.org/#/c/212016/ | 10:24 |
Venkatesh | ? | 10:24 |
*** Guest63150 has quit IRC | 10:25 | |
*** vkmc has quit IRC | 10:30 | |
johnthetubaguy | rajesht: so I see you protect against multiple force deletes now, which makes sense | 10:30 |
*** jlvillal has quit IRC | 10:31 | |
*** jlvillal has joined #openstack-nova | 10:31 | |
openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: adds os-win library https://review.openstack.org/212102 | 10:31 |
*** vkmc has joined #openstack-nova | 10:33 | |
*** mpaolino has quit IRC | 10:34 | |
*** snikitin has joined #openstack-nova | 10:41 | |
*** smatzek has joined #openstack-nova | 10:41 | |
*** tdurakov has quit IRC | 10:42 | |
*** ildikov has quit IRC | 10:43 | |
*** e0ne has quit IRC | 10:44 | |
*** pratikmallya has joined #openstack-nova | 10:47 | |
*** e0ne has joined #openstack-nova | 10:49 | |
*** pratikma_ has joined #openstack-nova | 10:49 | |
*** pratikmallya has quit IRC | 10:53 | |
*** mpaolino has joined #openstack-nova | 10:53 | |
*** alex_klimov has joined #openstack-nova | 10:53 | |
*** e0ne has quit IRC | 10:57 | |
*** pixelbeat has joined #openstack-nova | 10:58 | |
rajesht | johnthetubaguy: thanks :) | 10:58 |
*** xgsa has joined #openstack-nova | 11:00 | |
*** haomaiwang has quit IRC | 11:01 | |
*** haomaiwa_ has joined #openstack-nova | 11:01 | |
*** e0ne has joined #openstack-nova | 11:01 | |
*** mpaolino has quit IRC | 11:05 | |
*** jichen has joined #openstack-nova | 11:06 | |
openstackgerrit | John Garbutt proposed openstack/nova: Correct Instance type check to work with InstanceV1 https://review.openstack.org/228304 | 11:11 |
*** zhangjn has quit IRC | 11:26 | |
*** deepakcs has quit IRC | 11:26 | |
*** shyu has quit IRC | 11:27 | |
*** zhangjn has joined #openstack-nova | 11:29 | |
*** salv-orl_ has quit IRC | 11:30 | |
*** salv-orlando has joined #openstack-nova | 11:31 | |
Alexus | johnthetubaguy: thanks for the update | 11:35 |
*** salv-orlando has quit IRC | 11:35 | |
*** salv-orlando has joined #openstack-nova | 11:36 | |
* Alexus is alex_xu phone account | 11:36 | |
*** jordanP has quit IRC | 11:37 | |
*** otter768 has joined #openstack-nova | 11:41 | |
openstackgerrit | Marian Horban proposed openstack/nova: Fix Status-Line in HTTP response https://review.openstack.org/223235 | 11:41 |
*** e0ne has quit IRC | 11:43 | |
*** otter768 has quit IRC | 11:46 | |
*** tdurakov has joined #openstack-nova | 11:46 | |
*** haomaiwa_ has quit IRC | 11:46 | |
*** e0ne has joined #openstack-nova | 11:47 | |
*** jichen has quit IRC | 11:48 | |
*** zhangjn has quit IRC | 11:48 | |
*** jichen has joined #openstack-nova | 11:48 | |
*** EinstCrazy has quit IRC | 11:49 | |
*** thorst has joined #openstack-nova | 11:49 | |
*** jordanP has joined #openstack-nova | 11:49 | |
*** romainh has joined #openstack-nova | 11:50 | |
tdurakov | /msg nickserv identify 5014321 | 11:51 |
ndipanov | oops | 11:52 |
*** VikasC has quit IRC | 11:52 | |
*** jamielennox|away is now known as jamielennox | 11:52 | |
*** vladikr has joined #openstack-nova | 11:52 | |
*** jwcroppe has quit IRC | 11:53 | |
*** jwcroppe has joined #openstack-nova | 11:53 | |
tdurakov | ndipanov omg:) | 11:53 |
*** raildo-afk is now known as raildo | 11:57 | |
*** jwcroppe has quit IRC | 11:58 | |
*** thorst has quit IRC | 11:59 | |
*** thorst has joined #openstack-nova | 12:00 | |
openstackgerrit | Daniel Berrange proposed openstack/nova: Introduce VNC Security Proxy Framework https://review.openstack.org/115483 | 12:02 |
openstackgerrit | Daniel Berrange proposed openstack/nova: Add VeNCrypt (TLS/x509) Security Proxy Driver https://review.openstack.org/115484 | 12:02 |
*** deepthi has quit IRC | 12:03 | |
jordanP | johnthetubaguy, hi. I know you must be very busy now,but if you have 5min could you have a look at https://review.openstack.org/#/c/192736/ i try to land this in Liberty for 3 months, mriedem already +2ed it. It's a bug fix with 2 associated bug reports. It will also help the cinder team if/when they will add snapshot support for the generic NFS driver. thanks | 12:06 |
*** agireud has quit IRC | 12:08 | |
*** Haojun has joined #openstack-nova | 12:09 | |
*** agireud has joined #openstack-nova | 12:10 | |
openstackgerrit | Daniel Berrange proposed openstack/nova: Introduce VNC Security Proxy Framework https://review.openstack.org/115483 | 12:11 |
openstackgerrit | Daniel Berrange proposed openstack/nova: Add VeNCrypt (TLS/x509) Security Proxy Driver https://review.openstack.org/115484 | 12:11 |
*** zhangjn has joined #openstack-nova | 12:11 | |
*** zhangjn has quit IRC | 12:11 | |
*** zhangjn has joined #openstack-nova | 12:12 | |
*** bswartz has quit IRC | 12:12 | |
*** zhangjn has quit IRC | 12:12 | |
*** EinstCrazy has joined #openstack-nova | 12:12 | |
*** Daisy_ has joined #openstack-nova | 12:12 | |
*** zhangjn has joined #openstack-nova | 12:13 | |
*** marcusvrn_ has joined #openstack-nova | 12:14 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova: Added server tags support in nova-api https://review.openstack.org/128940 | 12:16 |
openstackgerrit | Daniel Berrange proposed openstack/nova-specs: Libvirt real time instances https://review.openstack.org/139688 | 12:18 |
Haojun | help | 12:20 |
Haojun | Sorry, wrong type... | 12:20 |
*** Daisy_ has quit IRC | 12:21 | |
*** tdurakov has quit IRC | 12:22 | |
johnthetubaguy | jordanP: sorry, I don't know that part of the code well enough | 12:22 |
*** baoli has joined #openstack-nova | 12:22 | |
jordanP | johnthetubaguy, yeah but I tried to ping and ping again those who know this part... | 12:23 |
*** lascii is now known as alaski | 12:24 | |
*** salv-orlando has quit IRC | 12:24 | |
*** salv-orlando has joined #openstack-nova | 12:25 | |
johnthetubaguy | jordanP: it has a +2 now, that should get it attention more quickly now, its tricky, we have well over 500 patches up for review right now | 12:25 |
*** aysyd has joined #openstack-nova | 12:25 | |
*** edleafe- is now known as edleafe | 12:25 | |
jordanP | johnthetubaguy, I know you can't do a lot about this but I am frustrated by this. I have 2 patches that I try to land for months, I am super reactive to all comments I have, I filled bug reports, properly unit test everything, I waited, pinged people again and again. And I feel I am going to miss the deadline. I know you know that already, and I understand why it's like this, but it's frustrating | 12:26 |
*** tdurakov has joined #openstack-nova | 12:27 | |
*** Sree has joined #openstack-nova | 12:27 | |
*** Daisy has joined #openstack-nova | 12:27 | |
johnthetubaguy | jordanP: totally agreed, trying our best to make sure folks review things like this first, with proper tracking, trying to recruit more reviews and mentor more folks to do better reviews, trying to push more code our of Nova so we have less to do, we are woking on it, but all the time we have more and more patches coming in. | 12:28 |
*** rfolco has joined #openstack-nova | 12:28 | |
johnthetubaguy | jordanP: liberty RC1 has been branches, so currently this is heading into mitaka without a backport (with we could do if we get this merged) | 12:29 |
tdurakov | johnthetubaguy, hi, if you have some time could you review https://review.openstack.org/#/c/225910/ ? | 12:30 |
jordanP | yeah that's what I was afraid of. I'll just wait. | 12:31 |
johnthetubaguy | tdurakov: I am starting to go through the specs, with the oldest first | 12:31 |
*** Daisy has quit IRC | 12:32 | |
*** Daisy has joined #openstack-nova | 12:32 | |
*** Daisy has quit IRC | 12:33 | |
*** Daisy has joined #openstack-nova | 12:33 | |
*** jamielennox is now known as jamielennox|away | 12:33 | |
*** edmondsw has joined #openstack-nova | 12:35 | |
*** pratikma_ has quit IRC | 12:36 | |
openstackgerrit | Radomir Dopieralski proposed openstack/nova: Handle 404 responses from neutron when polling for floating IPs https://review.openstack.org/216746 | 12:38 |
*** ildikov has joined #openstack-nova | 12:38 | |
openstackgerrit | Radomir Dopieralski proposed openstack/nova: Handle 404 responses from neutron when polling for floating IPs https://review.openstack.org/216746 | 12:41 |
*** rubasov has joined #openstack-nova | 12:44 | |
*** dimsum__ is now known as dims | 12:45 | |
*** derekh has quit IRC | 12:45 | |
*** sudipto has quit IRC | 12:46 | |
*** markvoelker has joined #openstack-nova | 12:46 | |
*** asettle has quit IRC | 12:48 | |
*** annegentle has joined #openstack-nova | 12:52 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova-specs: Add soft policies for server-group feature https://review.openstack.org/212504 | 12:54 |
*** breitz has joined #openstack-nova | 12:54 | |
*** asettle has joined #openstack-nova | 12:55 | |
*** rushil has joined #openstack-nova | 12:56 | |
*** rushil_ has joined #openstack-nova | 12:57 | |
*** derekh has joined #openstack-nova | 12:58 | |
*** Venkatesh has quit IRC | 13:01 | |
*** rushil has quit IRC | 13:01 | |
*** tdurakov has quit IRC | 13:03 | |
*** rlrossit has joined #openstack-nova | 13:03 | |
*** baoli has quit IRC | 13:04 | |
*** mdrabe has joined #openstack-nova | 13:04 | |
*** baoli has joined #openstack-nova | 13:05 | |
*** karimb has joined #openstack-nova | 13:06 | |
*** diegows has joined #openstack-nova | 13:06 | |
*** ctrath has joined #openstack-nova | 13:07 | |
*** dave-mccowan has joined #openstack-nova | 13:07 | |
*** tdurakov has joined #openstack-nova | 13:08 | |
*** tdurakov has quit IRC | 13:09 | |
*** tdurakov has joined #openstack-nova | 13:10 | |
*** dims_ has joined #openstack-nova | 13:15 | |
*** Daisy has quit IRC | 13:15 | |
*** asettle has quit IRC | 13:16 | |
*** dims has quit IRC | 13:17 | |
*** tdurakov has quit IRC | 13:17 | |
*** ijuwang has joined #openstack-nova | 13:17 | |
*** tdurakov has joined #openstack-nova | 13:18 | |
*** VW has joined #openstack-nova | 13:20 | |
bauzas | alex_xu: still there ? | 13:21 |
*** tdurakov has quit IRC | 13:21 | |
bauzas | alex_xu: I'm reviewing https://review.openstack.org/#/c/228304/ and I'm a bit unhappy | 13:21 |
*** tdurakov has joined #openstack-nova | 13:21 | |
openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: adds os-win library https://review.openstack.org/212102 | 13:22 |
*** dustins has joined #openstack-nova | 13:23 | |
*** mc_nair has joined #openstack-nova | 13:23 | |
*** sayali has quit IRC | 13:24 | |
*** xyhuang has joined #openstack-nova | 13:25 | |
bauzas | alex_xu: see my comment in https://review.openstack.org/#/c/228304/7/nova/objects/request_spec.py,cm | 13:26 |
*** sayali has joined #openstack-nova | 13:26 | |
*** jwcroppe has joined #openstack-nova | 13:27 | |
*** vladikr has quit IRC | 13:28 | |
alex_xu | bauzas: I'm here | 13:28 |
*** vladikr has joined #openstack-nova | 13:28 | |
alex_xu | bauzas: your comment looks like make sense, that one specific for ensure the instance is Instance obj, not just NovaObject, right? | 13:29 |
bauzas | alex_xu: so, that sounds a bit nitpicking but I could be a bit worried by any possible side effect of releasing the check to base.NovaObject instead of objects.instance | 13:29 |
openstackgerrit | Daniel Berrange proposed openstack/nova: Introduce VNC Security Proxy Framework https://review.openstack.org/115483 | 13:30 |
openstackgerrit | Daniel Berrange proposed openstack/nova: Add VeNCrypt (TLS/x509) Security Proxy Driver https://review.openstack.org/115484 | 13:30 |
bauzas | alex_xu: yeah, that makes it a bit clearer, tho we're exposing a private base class | 13:30 |
bauzas | alex_xu: so, I just feel something is wrong either way | 13:30 |
*** obedmr has joined #openstack-nova | 13:30 | |
alex_xu | bauzas: only for this https://review.openstack.org/#/c/228304/7/nova/objects/request_spec.py right, others looks like ok for just ensure the it is NovaObject | 13:31 |
*** mriedem has joined #openstack-nova | 13:31 | |
bauzas | alex_xu: well see https://review.openstack.org/#/c/228304/7/nova/compute/manager.py,cm | 13:31 |
bauzas | alex_xu: I could just pass a dict and profit | 13:32 |
bauzas | but maybe johnthetubaguy is having a different thought ? | 13:33 |
*** eharney has joined #openstack-nova | 13:33 | |
alex_xu | bauzas: you mean pass list, dict I think it's wrong | 13:34 |
dansmith | alex_xu: what did you want me to look at? | 13:34 |
bauzas | dansmith: disclaimer, take a coffee first | 13:34 |
*** smatzek has quit IRC | 13:35 | |
alex_xu | dansmith: good morning, this bug https://launchpad.net/bugs/1500289 :) | 13:35 |
openstack | Launchpad bug 1500289 in OpenStack Compute (nova) "Booting instance failed with Kilo stable compute node and liberty controller" [Critical,In progress] - Assigned to John Garbutt (johngarbutt) | 13:35 |
johnthetubaguy | bauzas: yeah, its not as defensive as before, but it just feels nicer | 13:35 |
johnthetubaguy | oh dear, I hate how it keeps giving me bugs | 13:35 |
bauzas | alex_xu: tbc, I can pass a Foo, it will still hydrate the ObjectList | 13:35 |
bauzas | johnthetubaguy: sure, but we have base objects for keeping compatibility between v1 and v2 | 13:36 |
alex_xu | bauzas: ok, that sounds make sense | 13:36 |
bauzas | johnthetubaguy: what is just worrying me is that we expose those private objects | 13:36 |
alex_xu | bauzas: but this is ok for NovaObject I think https://review.openstack.org/#/c/228304/7/nova/scheduler/utils.py | 13:36 |
bauzas | if we decide to check against them | 13:36 |
johnthetubaguy | bauzas: yeah, seems messy, where as most of the calls are if dict do X, if object do Y, and that seemed to read OK to me | 13:37 |
*** alexpilotti has joined #openstack-nova | 13:37 | |
bauzas | alex_xu: well, then passing a Foo could give you an AttributeError... | 13:37 |
*** acc_ has joined #openstack-nova | 13:38 | |
*** sambetts is now known as sambetts_afk | 13:38 | |
dansmith | alex_xu: bauzas: we should have ndipanov look at this since he was the one that originally found and fixed it | 13:38 |
*** AJaeger has joined #openstack-nova | 13:39 | |
dansmith | I assume this is passing in grenade because we don't pass any pci stuff? | 13:39 |
bauzas | dansmith: that was my wonders of this morning | 13:39 |
AJaeger | Could I get another review and approval on a cleanup of translations, please? https://review.openstack.org/#/c/227461/ | 13:39 |
tdurakov | bauzas, hi Sylvain, got question about instance.availability_zone field. Are we treating it as scheduler hint yet? | 13:39 |
bauzas | tdurakov: not | 13:39 |
bauzas | no | 13:39 |
ndipanov | dansmith, I think they are hitting a case where there is a set of commits on kilo that wont' allow you to go to liberty without going to kilo-tip frist | 13:39 |
openstackgerrit | Sergey Nikitin proposed openstack/nova: Added server tags support in nova-api https://review.openstack.org/128940 | 13:39 |
ndipanov | which is what I think we anticipated | 13:40 |
dansmith | ndipanov: ah, well, we knew that was going to be a problem | 13:40 |
dansmith | ndipanov: yeah | 13:40 |
*** Piet has quit IRC | 13:40 | |
tdurakov | bauzas, so it became actual az info for instance? | 13:40 |
dansmith | alex_xu: can you confirm that you're on the latest kilo revision? | 13:40 |
alex_xu | dansmith: no, I'm on the first version of kilo | 13:40 |
dansmith | alex_xu: that's the problem | 13:40 |
bauzas | dansmith: I think grenade doesn't detect the problem because it gets the latest stable/kilo release | 13:40 |
bauzas | which includes the fix | 13:41 |
dansmith | alex_xu: you have to be on the latest kilo | 13:41 |
dansmith | bauzas: yep | 13:41 |
*** yuner027 has quit IRC | 13:41 | |
bauzas | dansmith: I just discussed that this morning with johnthetubaguy and alex_xu | 13:41 |
dansmith | ah, sorry | 13:41 |
bauzas | and I was wondering if the bug was Invalid | 13:41 |
dansmith | just catching up | 13:41 |
alex_xu | dansmith: ok...but we said we support that... | 13:41 |
bauzas | nah, np, just giving you a quick summaru | 13:41 |
*** Alexus has quit IRC | 13:41 | |
alex_xu | dansmith: we doc in dev ref https://review.openstack.org/#/c/201529/6/doc/source/upgrades.rst | 13:42 |
dansmith | alex_xu: who said that? I don't think we've ever said anything like that, but in this case, there's a fix, so you need to roll to the latest before you can move | 13:42 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: scheduler:refactor group info in filter_properties https://review.openstack.org/148275 | 13:42 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: api: add soft-affinity policies for server groups https://review.openstack.org/147520 | 13:42 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: scheduler: add num of instance per host in a group https://review.openstack.org/148277 | 13:42 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: object:count members per hosts in InstanceGroup https://review.openstack.org/147517 | 13:42 |
openstackgerrit | Balazs Gibizer proposed openstack/nova: scheduler: add soft-(anti-)affinity weighers https://review.openstack.org/147516 | 13:42 |
bauzas | dansmith: but eventually, johnthetubaguy provided a good explanation for saying we should support any point release upgrade | 13:42 |
*** otter768 has joined #openstack-nova | 13:42 | |
dansmith | bauzas: it'd be nice, but if we have bugs like this and have to have them applied to older code before they can support an upgrade, there's not much we can do about it | 13:42 |
bauzas | dansmith: here is the problem : I think we never discussed about that specific policy, neither we documented it :) | 13:43 |
tdurakov | bauzas, ping, btw what about default AZ, called nova? | 13:43 |
mriedem | the best you can do is try and handle a case like that in the liberty code, if people are'nt going to upgrade to a fix pack in kilo | 13:43 |
dansmith | bauzas: yeah, agreed | 13:43 |
*** ccarmack has joined #openstack-nova | 13:44 | |
bauzas | dansmith: so, I'm all for a discussion about that, should we ask our operators to upgrade 2015.1.0 to 2015.1.1 before upgrading to Liberty ? (note, that's an open question) | 13:44 |
alex_xu | ^ same question | 13:44 |
*** burt has joined #openstack-nova | 13:44 | |
*** zzzeek has joined #openstack-nova | 13:44 | |
dansmith | bauzas: I think that we could optionally not require it all the time, but if we have a critical fix like this, then I think it's fine to put it in the release notes that you have to | 13:44 |
mriedem | bauzas: i think it's fair to expect people to be at the latest fix pack on n-1 before upgrading to n | 13:44 |
bauzas | tdurakov: sorry, missed your ping | 13:44 |
dansmith | mriedem: +1 | 13:44 |
bauzas | mriedem: that was my original thoguht | 13:44 |
tdurakov | [16:40] <tdurakov> bauzas, so it became actual az info for instance? | 13:45 |
bauzas | tdurakov: no no, instance.az is set once forever | 13:45 |
tdurakov | hm | 13:45 |
dansmith | bauzas: mriedem: if we had to choose a stricter policy to adhere to, I'd vote to make it always an official requirement, even if not technically necessary | 13:45 |
alex_xu | that make sense | 13:45 |
tdurakov | bauzas, what about live-migration then? | 13:45 |
johnthetubaguy | dansmith: mriedem: it seems like we could support upgrade from 2015.1.0 with that one patch added, but I guess it messes up something else? | 13:46 |
bauzas | dansmith: I'm +1 to that, I just feel we should document that policy so we could all vote on that :) | 13:46 |
dansmith | johnthetubaguy: that messes everything up, yes :) | 13:46 |
*** otter768 has quit IRC | 13:46 | |
dansmith | bauzas: sure | 13:46 |
mriedem | bauzas: you want to write it up? | 13:46 |
bauzas | mriedem: I'm the messenger :) | 13:47 |
bauzas | mriedem: but sure I can write down some stuff | 13:47 |
bauzas | at least, people could really use the word "blame" | 13:47 |
dansmith | johnthetubaguy: upgrading from 2015.1.0 to 2015.1.latest is an easy thing to do, doesn't require downtime or complicated deployments | 13:47 |
dansmith | bauzas: I'll be glad to do it if you prefer | 13:47 |
johnthetubaguy | dansmith: yeah, agreed | 13:47 |
bauzas | dansmith: feel free to do so, your upgrade mojo is better than mine IMHO | 13:48 |
johnthetubaguy | dansmith: I can live with a release note for this | 13:48 |
dansmith | johnthetubaguy: shall I just tweak this doc review of yours? | 13:48 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Only create volumes with instance.az if cinder.cross_az_attach is False https://review.openstack.org/227564 | 13:48 |
dansmith | ndipanov: didn't we put something in release notes? | 13:48 |
ndipanov | dansmith, I think we did add a doc impact at least | 13:48 |
dansmith | johnthetubaguy: first bullet: https://wiki.openstack.org/wiki/ReleaseNotes/Liberty#Upgrade_Notes | 13:48 |
johnthetubaguy | dansmith: we can do, I have a few reviews up to try and split that all up so it makes sense, first, I can un WIP those now | 13:49 |
*** achanda has joined #openstack-nova | 13:49 | |
dansmith | johnthetubaguy: I mean this: https://review.openstack.org/#/c/201529/6 | 13:49 |
johnthetubaguy | dansmith: I totally did not see that somehow, cool | 13:49 |
bauzas | oh man | 13:49 |
johnthetubaguy | dansmith: yeah, thats the one | 13:49 |
bauzas | I searched litterally over the world to get some info about a stable policy | 13:49 |
dansmith | johnthetubaguy: I'll amend that | 13:49 |
bauzas | this morning | 13:49 |
bauzas | and *that* was in the relnotes | 13:50 |
* bauzas hides | 13:50 | |
dansmith | heh | 13:50 |
alex_xu | dansmith: actually in that bug, there is another issue, I guess that should be fixed https://review.openstack.org/228304 | 13:50 |
*** artom has joined #openstack-nova | 13:50 | |
dansmith | alex_xu: that's the wrong fix, but I'll comment | 13:50 |
openstackgerrit | John Garbutt proposed openstack/nova: docs: add the scheduler evolution plans https://review.openstack.org/192260 | 13:50 |
alex_xu | dansmith: oops, thanks | 13:51 |
*** dane-fichter has joined #openstack-nova | 13:51 | |
*** annegentle has quit IRC | 13:51 | |
bauzas | alex_xu: yeah https://review.openstack.org/228304 is still valid IMHO | 13:51 |
alex_xu | bauzas: yea, thanks | 13:51 |
*** achanda has quit IRC | 13:51 | |
dansmith | indeed | 13:51 |
AJaeger | mriedem, dansmith: Sorry to ping directly - Could I get another review and approval on a cleanup of translations, please? https://review.openstack.org/#/c/227461/ | 13:52 |
*** jaypipes has quit IRC | 13:53 | |
mriedem | AJaeger: is that needed for liberty? | 13:53 |
AJaeger | mriedem: There'S a liberty version of that patch at https://review.openstack.org/227465 | 13:53 |
dansmith | alex_xu: ah, bauzas already said the right thing, but I -1'd for good measure | 13:54 |
AJaeger | And that'S why I want it in - like we did with kilo, ttx asked me for such a cleanup... | 13:54 |
dansmith | bauzas++ | 13:54 |
alex_xu | dansmith: ok thanks, and thanks bauzas :) | 13:54 |
*** tdurakov has quit IRC | 13:54 | |
AJaeger | mriedem: you will not loose any translations, everything is on our translation server - just loose files that are really partially translated *for now* | 13:55 |
bauzas | I would also love to get feedback from a specific ML thread | 13:56 |
mriedem | AJaeger: in the case of https://review.openstack.org/#/c/227461/1/nova/locale/ja/LC_MESSAGES/nova-log-info.po - there are translations in there | 13:56 |
mriedem | AJaeger: while not 100% it seems a waste to throw that out | 13:56 |
bauzas | http://lists.openstack.org/pipermail/openstack-dev/2015-September/075403.html | 13:56 |
AJaeger | mriedem: 143 translated messages. - out of 280 | 13:56 |
bauzas | ^ is missing the [nova] tag so I want to make sure we don't miss it :) | 13:57 |
AJaeger | The translation team, ttx, and myself decided to remove everything less than 66 %. | 13:57 |
*** nelsnelson has joined #openstack-nova | 13:57 | |
AJaeger | mriedem: A file that is only half translated will give an English message half the time - far too often | 13:57 |
mriedem | AJaeger: https://review.openstack.org/#/c/227461/1/nova/locale/ja/LC_MESSAGES/nova-log-info.po looks 100% translated | 13:58 |
mriedem | AJaeger: or am i missing something with ja? | 13:58 |
AJaeger | mriedem : http://paste.openstack.org/show/474434 | 13:58 |
AJaeger | mriedem: the po files only contains *translated strings, we do not store untranslated ones anymore | 13:59 |
AJaeger | So, you need to compare like I did in the paste | 13:59 |
mriedem | oh the po vs the pot | 13:59 |
AJaeger | The master file has 280 strings, ja has 143 translated | 13:59 |
openstackgerrit | Dan Smith proposed openstack/nova: docs: split up upgrade and upgrade futures https://review.openstack.org/201529 | 13:59 |
AJaeger | mriedem: Yeah. | 13:59 |
AJaeger | thanks, mriedem ! | 14:01 |
*** baoli has quit IRC | 14:01 | |
mriedem | +1 on the stable/liberty change, i don't have +2 there | 14:02 |
*** pratikmallya has joined #openstack-nova | 14:02 | |
*** smatzek has joined #openstack-nova | 14:02 | |
*** su_zhang has joined #openstack-nova | 14:02 | |
*** baoli has joined #openstack-nova | 14:02 | |
*** ildikov has quit IRC | 14:03 | |
*** andreykurilin__ has joined #openstack-nova | 14:03 | |
*** pratikma_ has joined #openstack-nova | 14:04 | |
*** stevemar has joined #openstack-nova | 14:05 | |
*** ildikov has joined #openstack-nova | 14:06 | |
*** yamahata has quit IRC | 14:06 | |
*** pratikmallya has quit IRC | 14:07 | |
*** alexpilotti has quit IRC | 14:08 | |
openstackgerrit | Alex Xu proposed openstack/nova: Correct Instance type check to work with InstanceV1 https://review.openstack.org/228304 | 14:13 |
alex_xu | dansmith: johnthetubaguy bauzas ndipanov ^ just updated, thanks all the review and discussion! | 14:13 |
*** tjones has joined #openstack-nova | 14:13 | |
*** whenry has quit IRC | 14:13 | |
garyk | johnthetubaguy: can you please look at https://review.openstack.org/227386 - this is a liberty approved spec and the code is mostly approved upstream | 14:16 |
*** Sree has quit IRC | 14:17 | |
*** haomaiwang has joined #openstack-nova | 14:17 | |
*** Sree has joined #openstack-nova | 14:17 | |
*** annegentle has joined #openstack-nova | 14:18 | |
openstackgerrit | Chuck Carmack proposed openstack/nova: Remove security group tests from tempest-dsvm-cells-rc https://review.openstack.org/226043 | 14:21 |
*** Sree has quit IRC | 14:22 | |
*** xyang1 has joined #openstack-nova | 14:22 | |
*** atuvenie has quit IRC | 14:22 | |
*** achanda has joined #openstack-nova | 14:22 | |
*** Sree has joined #openstack-nova | 14:23 | |
dansmith | alex_xu: that patch looks good to me.. Have you confirmed that it actually fixes the issue it claims to? | 14:23 |
alex_xu | dansmith: yea, I tested it in my env | 14:24 |
dansmith | alex_xu: since we didn't have any tests failing, and since this doesn't add new tests... | 14:24 |
dansmith | okay cool | 14:24 |
bauzas | yeah, that should be good | 14:24 |
*** Murali has quit IRC | 14:24 | |
*** tsekiyama has joined #openstack-nova | 14:24 | |
dansmith | I'll be ripping it all out soon anyway :) | 14:24 |
ndipanov | yay | 14:25 |
*** mtanino has joined #openstack-nova | 14:26 | |
bauzas | dansmith: waiting the grenade change, you said ? | 14:27 |
*** emagana has quit IRC | 14:27 | |
*** jichen has quit IRC | 14:28 | |
*** tdurakov has joined #openstack-nova | 14:28 | |
*** jichen has joined #openstack-nova | 14:29 | |
*** sayali has quit IRC | 14:30 | |
dansmith | bauzas: I don't think it's going to have an impact, but we have to wait for it anyway :) | 14:30 |
mriedem | sahid: ndipanov: looking at https://bugs.launchpad.net/nova/+bug/1419577/ - do you think we could do similar to https://review.openstack.org/#/c/202770/ but in the rollback method? | 14:30 |
openstack | Launchpad bug 1419577 in OpenStack Compute (nova) "when live-migrate failed, lun-id couldn't be rollback in havana" [High,Confirmed] | 14:30 |
dansmith | bauzas: or did you mean a grenade patch to test this? | 14:30 |
bauzas | dansmith: both of them :) | 14:30 |
mriedem | https://bugs.launchpad.net/nova/+bug/1419577/ was an old OSSA that was marked as won't fix but i don't really know why, i think because you needed admin access to the hosts to cause the live migration failure? | 14:30 |
bauzas | dansmith: ie. we should have a running grenade env for testing, but we could perhaps test it explicitely | 14:31 |
ndipanov | mriedem, looks like we probably should | 14:31 |
dansmith | bauzas: this would be really difficult to test with grenade, because we don't have control over the from/to revisions that we test, plus I think we'd need a tempest test that does pci | 14:31 |
*** n0ano has quit IRC | 14:31 | |
dansmith | bauzas: since this is simple and tested locally by alex, I'm thinking we should just land it | 14:31 |
ndipanov | mriedem, we should be fixing this in brick ultimately | 14:31 |
*** sayali has joined #openstack-nova | 14:31 | |
ndipanov | all the more reason to fix it properly | 14:31 |
*** e0ne has quit IRC | 14:32 | |
bauzas | that's cool then | 14:32 |
bauzas | I'm fine, I don't want to overrule | 14:32 |
*** n0ano has joined #openstack-nova | 14:33 | |
*** tjones has quit IRC | 14:33 | |
*** e0ne has joined #openstack-nova | 14:34 | |
*** dims has joined #openstack-nova | 14:35 | |
openstackgerrit | John Garbutt proposed openstack/nova: Add a summary of the architecture evolution work https://review.openstack.org/200001 | 14:35 |
*** dims_ has quit IRC | 14:35 | |
*** sambetts_afk has quit IRC | 14:35 | |
*** sambetts has joined #openstack-nova | 14:36 | |
*** tonytan4ever has joined #openstack-nova | 14:37 | |
mriedem | ndipanov: the change here https://review.openstack.org/#/c/202770/17/nova/virt/libvirt/driver.py actually looks like what nova.virt.block_device already does when attaching a volume | 14:37 |
mriedem | this https://github.com/openstack/nova/blob/master/nova/virt/block_device.py#L220 | 14:38 |
*** zhangjn has quit IRC | 14:38 | |
*** tpeoples has joined #openstack-nova | 14:38 | |
*** achanda has quit IRC | 14:40 | |
*** zhangjn has joined #openstack-nova | 14:42 | |
*** zhangjn has quit IRC | 14:43 | |
*** zhangjn has joined #openstack-nova | 14:43 | |
*** zhangjn has quit IRC | 14:44 | |
*** electrocucaracha has joined #openstack-nova | 14:44 | |
ndipanov | mriedem, yeah that looks like it was designed for that case | 14:44 |
*** electrocucaracha has quit IRC | 14:45 | |
openstackgerrit | John Garbutt proposed openstack/nova: docs: rerganize the API concept docs https://review.openstack.org/226253 | 14:45 |
*** zzzeek_ has joined #openstack-nova | 14:45 | |
bauzas | johnthetubaguy: now that you fast-approved the spec, could you help seeing less red crosses ? :) https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/request-spec-object,n,z | 14:45 |
bauzas | help me* | 14:45 |
johnthetubaguy | bauzas: ah, you need to point at the new blueprint, I think | 14:46 |
bauzas | johnthetubaguy: oh, I didn't, did I ? | 14:47 |
bauzas | johnthetubaguy: lemme see | 14:47 |
bauzas | right | 14:47 |
bauzas | okay, prepare your screens to the flood | 14:47 |
*** electrocucaracha has joined #openstack-nova | 14:48 | |
*** digimonde has quit IRC | 14:48 | |
johnthetubaguy | sdague: alex_xu: updated that API doc tweak, in the hope we can get folks to fill more of that out before we release: https://review.openstack.org/#/c/226253/ | 14:48 |
*** zzzeek has quit IRC | 14:48 | |
*** zzzeek_ is now known as zzzeek | 14:48 | |
*** electrocucaracha has quit IRC | 14:49 | |
*** vkmc has quit IRC | 14:50 | |
*** vkmc has joined #openstack-nova | 14:50 | |
*** zhangjn has joined #openstack-nova | 14:50 | |
*** AJaeger has left #openstack-nova | 14:51 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify Scheduler RPC API select_dests() https://review.openstack.org/199205 | 14:51 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Use RequestSpec object in the FilterScheduler https://review.openstack.org/188487 | 14:51 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Prepare filters for using RequestSpec object https://review.openstack.org/197912 | 14:51 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify left filters for RequestSpec https://review.openstack.org/202678 | 14:51 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify conductor to use RequestSpec object https://review.openstack.org/203078 | 14:51 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify metric-related filters for RequestSpec https://review.openstack.org/202676 | 14:51 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify NUMA, PCI and num_instances filters for RequestSpec https://review.openstack.org/202677 | 14:51 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Use RequestSpec in the ChanceScheduler https://review.openstack.org/199051 | 14:51 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify Aggregate filters for RequestSpec https://review.openstack.org/202674 | 14:51 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify default filters for RequestSpec https://review.openstack.org/202675 | 14:51 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Modify Affinity filter for RequestSpec https://review.openstack.org/202673 | 14:51 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Use RequestSpec object in HostManager https://review.openstack.org/191251 | 14:51 |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Remove reservation_id from the logs when a schedule fails https://review.openstack.org/217798 | 14:51 |
*** zhangjn has quit IRC | 14:51 | |
*** electrocucaracha has joined #openstack-nova | 14:53 | |
*** pradipta has joined #openstack-nova | 14:58 | |
*** greghaynes has joined #openstack-nova | 14:58 | |
*** hemnafk is now known as hemna | 15:00 | |
*** Sree has quit IRC | 15:00 | |
*** burgerk has joined #openstack-nova | 15:00 | |
*** haomaiwang has quit IRC | 15:01 | |
*** thangp has joined #openstack-nova | 15:01 | |
*** haomaiwang has joined #openstack-nova | 15:01 | |
*** rhedlind has left #openstack-nova | 15:03 | |
*** artom has quit IRC | 15:06 | |
*** zhangjn has joined #openstack-nova | 15:07 | |
*** terryyao has joined #openstack-nova | 15:10 | |
*** ZZelle has quit IRC | 15:10 | |
*** ZZelle has joined #openstack-nova | 15:11 | |
*** mariojv is now known as jvmario | 15:16 | |
*** tonytan4ever has quit IRC | 15:17 | |
*** ericksonsantos has quit IRC | 15:19 | |
*** mdrabe has quit IRC | 15:19 | |
*** armax has joined #openstack-nova | 15:20 | |
*** nkrinner has quit IRC | 15:25 | |
*** browne has joined #openstack-nova | 15:27 | |
*** mwagner_ has quit IRC | 15:27 | |
*** annegentle has quit IRC | 15:29 | |
*** annegentle has joined #openstack-nova | 15:30 | |
garyk | johnthetubaguy: regarding a spec approved in liberty - do we need to create a new bp. for example https://blueprints.launchpad.net/openstack/?searchtext=vmware-limits is no longer available | 15:30 |
garyk | what do you suggest? | 15:30 |
johnthetubaguy | garyk: its normally because it was partially completed | 15:31 |
*** VW has quit IRC | 15:31 | |
johnthetubaguy | garyk: it should still be available to check | 15:31 |
openstackgerrit | Ed Leafe proposed openstack/nova: Replace os.path.join() for URLs https://review.openstack.org/218309 | 15:31 |
*** jdurgin1 has joined #openstack-nova | 15:31 | |
*** VW has joined #openstack-nova | 15:31 | |
johnthetubaguy | garyk: https://blueprints.launchpad.net/nova/+spec/vmware-limits | 15:31 |
*** terryyao has quit IRC | 15:32 | |
johnthetubaguy | garyk: yeah, it normal to create vmware-limits-mitaka to keep it going | 15:32 |
garyk | ah, ok | 15:32 |
johnthetubaguy | garyk: its annoying really, that launchpad search doesn't bring up completed blueprints | 15:32 |
garyk | not sure that i unerstand - do i need to create a new one? | 15:33 |
johnthetubaguy | yes, you need to create a new one, because the old one is now completed | 15:33 |
garyk | ok, thanks. guess that i need to updtae all patches to point to that. | 15:33 |
garyk | ok, thanks | 15:33 |
*** ctrath has quit IRC | 15:35 | |
*** mdrabe has joined #openstack-nova | 15:35 | |
*** VW has quit IRC | 15:35 | |
*** ctrath has joined #openstack-nova | 15:37 | |
*** ildikov has quit IRC | 15:38 | |
openstackgerrit | garyk proposed openstack/nova-specs: Propose VMware limits, reservation and shares https://review.openstack.org/227386 | 15:40 |
garyk | johnthetubaguy: updated the bp ^ | 15:40 |
*** sseverson has joined #openstack-nova | 15:41 | |
*** artom has joined #openstack-nova | 15:41 | |
johnthetubaguy | garyk: OK, hope to do another sweep of those soon | 15:42 |
garyk | ok, thanks | 15:42 |
garyk | i you need another broom let me know | 15:42 |
*** salv-orl_ has joined #openstack-nova | 15:42 | |
*** otter768 has joined #openstack-nova | 15:43 | |
*** VW has joined #openstack-nova | 15:43 | |
*** salv-orlando has quit IRC | 15:45 | |
*** tdurakov has quit IRC | 15:45 | |
*** tjones has joined #openstack-nova | 15:46 | |
*** dims has quit IRC | 15:46 | |
*** dims has joined #openstack-nova | 15:46 | |
*** otter768 has quit IRC | 15:47 | |
*** rdopiera has quit IRC | 15:47 | |
openstackgerrit | garyk proposed openstack/nova: VMware: add in vif resource limitations https://review.openstack.org/180202 | 15:51 |
*** dane-fichter has quit IRC | 15:53 | |
ndipanov | dansmith, do you remember of the top of your head what's the tag to mark a spec already approved in prev release? | 15:56 |
*** haomaiwang has quit IRC | 15:57 | |
*** MarcF has quit IRC | 15:58 | |
*** jdurgin1 has quit IRC | 15:58 | |
*** wlehman has joined #openstack-nova | 15:59 | |
*** Apoorva has joined #openstack-nova | 15:59 | |
*** yamahata has joined #openstack-nova | 15:59 | |
bauzas | ndipanov: Previously-Approved | 15:59 |
bauzas | (not dansmith tho) | 16:00 |
*** wlehman has quit IRC | 16:00 | |
*** wlehman has joined #openstack-nova | 16:00 | |
*** jlanoux has quit IRC | 16:02 | |
*** tutij7 has quit IRC | 16:03 | |
*** sahid has quit IRC | 16:03 | |
*** wlehman has quit IRC | 16:04 | |
*** willsama has joined #openstack-nova | 16:05 | |
dansmith | ndipanov: I'm inclined to believe bauzas | 16:06 |
bauzas | gosh | 16:07 |
bauzas | should it had a "in bauzas", I could be seen as a prophet | 16:07 |
openstackgerrit | Marian Horban proposed openstack/nova: Fix Status-Line in HTTP response https://review.openstack.org/223235 | 16:10 |
*** lpetrut has quit IRC | 16:11 | |
*** su_zhang has quit IRC | 16:11 | |
*** alex_klimov has quit IRC | 16:12 | |
*** eharney has quit IRC | 16:12 | |
*** zhangjn has quit IRC | 16:13 | |
johnthetubaguy | dansmith: bauzas: ndipanov: yeah, its in the readme for the specs repo | 16:13 |
johnthetubaguy | https://github.com/openstack/nova-specs#previously-approved-specifications | 16:14 |
johnthetubaguy | got a link to find them all in here: https://etherpad.openstack.org/p/mitaka-nova-spec-review-tracking | 16:14 |
*** n0ano has quit IRC | 16:15 | |
ndipanov | johnthetubaguy, bauzas dansmith thanks guys | 16:15 |
*** zhangjn has joined #openstack-nova | 16:15 | |
*** Sree has joined #openstack-nova | 16:16 | |
*** whenry has joined #openstack-nova | 16:17 | |
*** unicell has quit IRC | 16:17 | |
mriedem | dansmith: ndipanov: garyk: claudiub: would appreciate review on this stable/juno backport for a related security issue https://review.openstack.org/#/c/228517/ | 16:18 |
garyk | mriedem: sure | 16:19 |
*** zhangjn_ has joined #openstack-nova | 16:20 | |
garyk | mriedem: you can +W now | 16:20 |
*** zhangjn_ has quit IRC | 16:20 | |
ndipanov | mriedem, will take a look | 16:20 |
mriedem | garyk: thanks | 16:20 |
*** zhangjn has quit IRC | 16:21 | |
*** zhangjn has joined #openstack-nova | 16:21 | |
openstackgerrit | Nikola Dipanov proposed openstack/nova-specs: spec for host-state-level-locking blueprint https://review.openstack.org/228528 | 16:21 |
mriedem | ndipanov: i think ^ is related to https://bugs.launchpad.net/nova/+bug/1419577 because in that ossa bug the reporter is talking about migration from host A to B and devices still mapped on A, then migration from B to A fails | 16:21 |
openstack | Launchpad bug 1419577 in OpenStack Compute (nova) "when live-migrate failed, lun-id couldn't be rollback in havana" [High,Confirmed] | 16:21 |
mriedem | ndipanov: and that's what that patch fixed (the A to B case) | 16:21 |
*** matrohon has quit IRC | 16:22 | |
*** Haojun has quit IRC | 16:22 | |
*** e0ne has quit IRC | 16:22 | |
*** EinstCrazy has quit IRC | 16:23 | |
*** jichen has quit IRC | 16:24 | |
*** e0ne has joined #openstack-nova | 16:24 | |
openstackgerrit | garyk proposed openstack/nova: VMware: add in vif resource limitations https://review.openstack.org/180202 | 16:26 |
*** eharney has joined #openstack-nova | 16:28 | |
openstackgerrit | garyk proposed openstack/nova: VMware: add in vif resource limitations https://review.openstack.org/180202 | 16:29 |
*** jordanP has quit IRC | 16:30 | |
*** xgsa has quit IRC | 16:31 | |
*** baoli has quit IRC | 16:31 | |
*** ctrath has quit IRC | 16:31 | |
ndipanov | mriedem, need to drop off now - but will look tomorrow morning | 16:31 |
mriedem | ndipanov: ok, np | 16:31 |
*** baoli has joined #openstack-nova | 16:32 | |
*** tonytan4ever has joined #openstack-nova | 16:32 | |
*** Kennan2 has joined #openstack-nova | 16:36 | |
*** Kennan has quit IRC | 16:36 | |
*** willsama has quit IRC | 16:39 | |
openstackgerrit | garyk proposed openstack/nova: Objects: add limits, reservations and shares to ImageMetaProps object https://review.openstack.org/188321 | 16:39 |
*** alejandrito has joined #openstack-nova | 16:39 | |
*** bnemec has joined #openstack-nova | 16:40 | |
*** achanda has joined #openstack-nova | 16:40 | |
openstackgerrit | garyk proposed openstack/nova: VMware: support limits via image meta data https://review.openstack.org/180942 | 16:41 |
*** wverdugo500 has joined #openstack-nova | 16:41 | |
openstackgerrit | garyk proposed openstack/nova: Objects: add limits, reservations and shares to ImageMetaProps object https://review.openstack.org/188321 | 16:42 |
openstackgerrit | garyk proposed openstack/nova: VMware: support limits via image meta data https://review.openstack.org/180942 | 16:43 |
*** nic has joined #openstack-nova | 16:43 | |
*** sudipto has joined #openstack-nova | 16:45 | |
*** vkmc is now known as vkmc-afk | 16:47 | |
*** su_zhang has joined #openstack-nova | 16:51 | |
*** davideagnello has joined #openstack-nova | 16:52 | |
*** tjones has quit IRC | 16:53 | |
*** achanda has quit IRC | 16:54 | |
*** penick has joined #openstack-nova | 16:54 | |
*** mwagner_ has joined #openstack-nova | 16:55 | |
*** derekh has quit IRC | 16:55 | |
*** tjones has joined #openstack-nova | 16:56 | |
*** ZZelle_ has joined #openstack-nova | 16:56 | |
*** zhangjn has quit IRC | 16:56 | |
*** ctrath has joined #openstack-nova | 16:57 | |
*** unicell has joined #openstack-nova | 16:58 | |
*** penick has quit IRC | 17:00 | |
*** romainh has left #openstack-nova | 17:00 | |
*** salv-orl_ has quit IRC | 17:02 | |
*** penick has joined #openstack-nova | 17:04 | |
*** Sree has quit IRC | 17:07 | |
*** Sree has joined #openstack-nova | 17:07 | |
*** willsama has joined #openstack-nova | 17:09 | |
*** pradipta has quit IRC | 17:09 | |
*** jaypipes has joined #openstack-nova | 17:09 | |
*** stevemar has quit IRC | 17:13 | |
*** vilobhmm11 has joined #openstack-nova | 17:16 | |
*** r-daneel has joined #openstack-nova | 17:16 | |
*** stevemar has joined #openstack-nova | 17:19 | |
*** bnemec has quit IRC | 17:20 | |
*** apuimedo has quit IRC | 17:21 | |
*** karimb has quit IRC | 17:22 | |
*** browne has quit IRC | 17:23 | |
*** apuimedo has joined #openstack-nova | 17:23 | |
*** danpb has quit IRC | 17:24 | |
*** tjones has left #openstack-nova | 17:25 | |
*** Piet has joined #openstack-nova | 17:28 | |
openstackgerrit | Giridhar Jayavelu proposed openstack/nova: VMware: Append disk type to image cache folder name https://review.openstack.org/227104 | 17:31 |
*** VW_ has joined #openstack-nova | 17:32 | |
*** bnemec has joined #openstack-nova | 17:32 | |
*** vilobhmm111 has joined #openstack-nova | 17:34 | |
*** VW has quit IRC | 17:35 | |
*** vilobhmm11 has quit IRC | 17:36 | |
*** alexpilotti has joined #openstack-nova | 17:36 | |
mriedem | sdague: if you're around there were a couple of related changes i wanted to talk about | 17:36 |
*** VW_ has quit IRC | 17:37 | |
*** Marga_ has quit IRC | 17:37 | |
*** jwcroppe has quit IRC | 17:38 | |
*** jwcroppe has joined #openstack-nova | 17:39 | |
*** xyhuang has quit IRC | 17:42 | |
jwcroppe | jaypipes: you around? | 17:43 |
jaypipes | jwcroppe: yes (mostly) | 17:43 |
*** otter768 has joined #openstack-nova | 17:43 | |
*** VW has joined #openstack-nova | 17:44 | |
jwcroppe | jaypipes: no problem, just wondering if you had any feedback on that metrics refactoring to fix that 'set' bug - https://review.openstack.org/#/c/219153/? looks like we got another comment on it... or do you want to push this to M? | 17:44 |
jwcroppe | jaypipes: I've been running this for a while now and it's working quite well, FWIW | 17:45 |
jaypipes | jwcroppe: I'll leave the question about whether to push this to M to others to decide. Lemme do a review of this. Gimme ten minutes or so. | 17:46 |
jwcroppe | jaypipes: sounds good | 17:46 |
dansmith | it's not a push to M thing at this point it's a "do we backport to L" thing | 17:46 |
*** electrocucaracha has quit IRC | 17:46 | |
jwcroppe | dansmith: good point | 17:47 |
sdague | mriedem: I'm around, what's up? | 17:48 |
*** otter768 has quit IRC | 17:48 | |
mriedem | sdague: i was looking at https://review.openstack.org/#/c/138664/ and https://review.openstack.org/#/c/225278/ - the latter came about because ndipanov wanted to see the error handling closer to the caller (i think), | 17:48 |
mriedem | sdague: the problem is initialize_connection is called in more places than just the block_device module | 17:49 |
mriedem | so i'm thinking the original change, to handle it in cinder.py, is the better way to go | 17:49 |
mriedem | sdague: wanted to get your thoughts on that before herding the authors of those changes | 17:49 |
*** Sree has quit IRC | 17:49 | |
*** electrocucaracha has joined #openstack-nova | 17:49 | |
sdague | yeh, I agree, keeping this all in cinder.py seems the better go | 17:51 |
mriedem | ok, so i think it just needs a rebase and the comments apply | 17:52 |
mriedem | sdague: also, were you ok with xyang1's reply on the reason for the 500 and 504 checks? | 17:52 |
openstackgerrit | Giridhar Jayavelu proposed openstack/nova: VMware: create vif with resource limitations https://review.openstack.org/196171 | 17:52 |
sdague | man, that was a long time ago, let me reread that | 17:52 |
*** VW has quit IRC | 17:52 | |
*** VW has joined #openstack-nova | 17:53 | |
mriedem | sdague: fwiw, i had the same comments in the latter change https://review.openstack.org/#/c/225278/3/nova/virt/block_device.py | 17:54 |
*** achanda has joined #openstack-nova | 17:54 | |
mriedem | we decided to not check for the 500 and just rollback on any failure | 17:54 |
sdague | yeh, so the blanket 500 still seems a little odd to me | 17:54 |
sdague | because it's so vague | 17:55 |
mriedem | b/c that's how we handle the same kind of thing in the neutronv2 api | 17:55 |
mriedem | yeah | 17:55 |
mriedem | in neutronv2.api.allocate_for_instance we just rollback on NeutronClientException of any kind | 17:55 |
*** baoli has quit IRC | 17:57 | |
mriedem | xyang1: do you work with jeegn chen? https://review.openstack.org/#/c/138664/ | 17:59 |
mriedem | xyang1: i think we should just cleanup that change | 17:59 |
xyang1 | mriedem: he is gone, I can clean up that patch | 17:59 |
mriedem | ok, cool, thanks | 17:59 |
*** achanda has quit IRC | 17:59 | |
xyang1 | mriedem: so do you want error code checking or not | 17:59 |
mriedem | no | 17:59 |
mriedem | for the same reasons we dropped it in your change | 18:00 |
*** Marga_ has joined #openstack-nova | 18:00 | |
xyang1 | mriedem: so do you want me to do that same change but in cinder.py? | 18:00 |
mriedem | yeah, basically | 18:00 |
xyang1 | mriedem: sure, will do | 18:00 |
xyang1 | mriedem: I cannot update Jeegn's patch because it was abandoned. So I'll just update my patch, is that ok | 18:01 |
mriedem | xyang1: i restored it | 18:02 |
*** bnemec has quit IRC | 18:02 | |
mriedem | there are updated comments inline | 18:02 |
xyang1 | mriedem: ok, thanks | 18:02 |
xyang1 | mriedem: I'll update it and abandon mine later | 18:02 |
*** VW has quit IRC | 18:03 | |
*** VW has joined #openstack-nova | 18:03 | |
mriedem | sounds good | 18:03 |
*** browne has joined #openstack-nova | 18:03 | |
*** gabriel-bezerra has quit IRC | 18:04 | |
melwitt | zzzeek: hi, I saw your comments on the review for the backport of catching DBReferenceError https://review.openstack.org/#/c/227451/ I had thought that in the context of updating a field of Instance, if a FK constraint fails, it implies that the Instance row doesn't exist. is that not necessarily true? | 18:06 |
mriedem | garyk: what should be done with this super old confirmed vmware live migratoin bug? https://bugs.launchpad.net/nova/+bug/1192192 | 18:06 |
openstack | Launchpad bug 1192192 in OpenStack Compute (nova) "Nova initiated Live Migration regression for vmware VCDriver" [Medium,Confirmed] - Assigned to Sabari Murugesan (smurugesan) | 18:06 |
zzzeek | melwitt: if the target row has other FKs to other things, then those other things might not exist | 18:07 |
zzzeek | melwitt: so i proposed testing that the error targets the columns that are specific to the parent instance you want to report on | 18:07 |
mriedem | rlrossit: yes the vcenter driver supports live migration in juno https://github.com/openstack/nova/blob/stable/juno/nova/virt/vmwareapi/vmops.py#L1106 | 18:07 |
mriedem | rlrossit: oh maybe not....hrm https://bugs.launchpad.net/nova/+bug/1192192 | 18:08 |
openstack | Launchpad bug 1192192 in OpenStack Compute (nova) "Nova initiated Live Migration regression for vmware VCDriver" [Medium,Confirmed] - Assigned to Sabari Murugesan (smurugesan) | 18:08 |
melwitt | zzzeek: I see. that makes sense | 18:08 |
mriedem | rlrossit: the nova hypervisor support matrix says the vcenter driver doesn't support live migration per that bug ^ | 18:08 |
garyk | mriedem: it is on my to do list | 18:09 |
mriedem | garyk: ok, so basically no live migration with vmware driver right? | 18:09 |
mriedem | garyk: i was confused b/c it looked like the code was implemented in vmops | 18:09 |
garyk | mriedem: no, live migration is not supported via nova | 18:10 |
garyk | the solution at the moment it to use vmotion on the backend | 18:10 |
mriedem | ok | 18:10 |
garyk | i am still working on the nova support | 18:10 |
mriedem | how does nova get synced up with the backend instance details once they've moved hosts?> | 18:10 |
mriedem | or is that just hidden by the cluster? | 18:10 |
garyk | from VC 6.0 one can do vmotion across clusters | 18:11 |
garyk | that is the only way that we can do live migration in nova - as each 'node' is a cluster | 18:11 |
garyk | so we can only live migrate from one cluster to anoterh | 18:11 |
*** su_zhang has quit IRC | 18:11 | |
garyk | if we want to move from one host to another then we need and api extension for that | 18:11 |
*** su_zhang_ has joined #openstack-nova | 18:12 | |
garyk | i am not optimistic of getting a patch like that approved upstream | 18:12 |
mriedem | garyk: so https://github.com/openstack/nova/blob/stable/juno/nova/virt/vmwareapi/vmops.py#L1106 only works if you have vcenter >= 6? | 18:12 |
*** markus_z has quit IRC | 18:12 | |
mriedem | i'm just wondering if there needs to be a fail fast version check in there | 18:13 |
garyk | mriedem: i honestly do not think that the code has every worked - it may have worked when there was the esx drivers. but it certainly does not work today | 18:13 |
mriedem | garyk: ok, should we just gut https://github.com/openstack/nova/blob/stable/juno/nova/virt/vmwareapi/vmops.py#L1106 and raise an exception right away saying it doesn't work? | 18:13 |
garyk | mriedem: yes, that is what we should do until i fix the problem. i'll post a patch for that tomorrow | 18:13 |
*** tonytan4ever has quit IRC | 18:14 | |
mriedem | ok, thanks | 18:14 |
garyk | np | 18:14 |
mriedem | feel free to add me to the review once it's up | 18:14 |
garyk | ok, will do | 18:14 |
*** tonytan4ever has joined #openstack-nova | 18:14 | |
*** hitalia has joined #openstack-nova | 18:16 | |
*** raildo is now known as raildo-afk | 18:16 | |
*** gabriel-bezerra has joined #openstack-nova | 18:17 | |
*** eharney has quit IRC | 18:18 | |
*** mestery_afk is now known as mestery | 18:22 | |
*** gabriel-bezerra has quit IRC | 18:23 | |
*** yamahata has quit IRC | 18:25 | |
*** baoli has joined #openstack-nova | 18:26 | |
bauzas | IIUC, functional tests are using requests only? | 18:27 |
bauzas | I mean the requests lib | 18:28 |
*** krtaylor has quit IRC | 18:33 | |
*** angdraug has joined #openstack-nova | 18:34 | |
*** scheuran has joined #openstack-nova | 18:38 | |
*** scheuran has quit IRC | 18:38 | |
*** gongysh has quit IRC | 18:39 | |
openstackgerrit | Sudipta Biswas proposed openstack/nova: use helper method to remove version hardcoding https://review.openstack.org/228578 | 18:39 |
*** gongysh has joined #openstack-nova | 18:39 | |
*** salv-orlando has joined #openstack-nova | 18:45 | |
*** vkmc-afk is now known as vkmc | 18:45 | |
*** ijw has joined #openstack-nova | 18:45 | |
*** sudipto has quit IRC | 18:51 | |
*** pixelbeat has quit IRC | 18:51 | |
*** sambetts has quit IRC | 18:52 | |
*** su_zhang_ has quit IRC | 18:53 | |
*** annegentle has quit IRC | 18:53 | |
*** sambetts has joined #openstack-nova | 18:54 | |
*** achanda has joined #openstack-nova | 18:56 | |
*** boris-42 has quit IRC | 18:59 | |
*** penick has quit IRC | 18:59 | |
*** achanda has quit IRC | 19:00 | |
*** pratikmallya has joined #openstack-nova | 19:00 | |
*** baoli has quit IRC | 19:01 | |
*** Piet has quit IRC | 19:03 | |
*** pratikma_ has quit IRC | 19:04 | |
*** penick has joined #openstack-nova | 19:05 | |
*** pixelbeat has joined #openstack-nova | 19:07 | |
*** mc_nair_ has joined #openstack-nova | 19:07 | |
*** mc_nair has quit IRC | 19:10 | |
*** raorn has quit IRC | 19:12 | |
*** andreykurilin has quit IRC | 19:13 | |
*** raorn has joined #openstack-nova | 19:13 | |
*** Marga_ has quit IRC | 19:17 | |
*** Marga_ has joined #openstack-nova | 19:17 | |
*** andreykurilin has joined #openstack-nova | 19:17 | |
openstackgerrit | Giridhar Jayavelu proposed openstack/nova: Configure memory resource allocation during instance resize operation https://review.openstack.org/204219 | 19:23 |
openstackgerrit | Giridhar Jayavelu proposed openstack/nova: Configure disk resource allocation during instance resize operation https://review.openstack.org/204220 | 19:23 |
openstackgerrit | Giridhar Jayavelu proposed openstack/nova: Configure vif resource allocation during instance resize operation https://review.openstack.org/204221 | 19:23 |
*** annegentle has joined #openstack-nova | 19:25 | |
*** ijw has quit IRC | 19:28 | |
*** e0ne has quit IRC | 19:28 | |
openstackgerrit | Giridhar Jayavelu proposed openstack/nova: VMware: memory limits during resize operation https://review.openstack.org/204219 | 19:28 |
openstackgerrit | Giridhar Jayavelu proposed openstack/nova: VMware: disk limits during resize operation https://review.openstack.org/204220 | 19:28 |
openstackgerrit | Giridhar Jayavelu proposed openstack/nova: VMware: vif limits during resize operation https://review.openstack.org/204221 | 19:28 |
*** ociuhandu has joined #openstack-nova | 19:28 | |
*** yamahata has joined #openstack-nova | 19:31 | |
*** VW_ has joined #openstack-nova | 19:34 | |
*** VW has quit IRC | 19:35 | |
mriedem | fyi we have volume-backed live migration testing now in the gate https://review.openstack.org/#/c/165233/ | 19:36 |
*** pratikma_ has joined #openstack-nova | 19:39 | |
*** e0ne has joined #openstack-nova | 19:41 | |
*** packet has joined #openstack-nova | 19:41 | |
melwitt | mriedem: nice! | 19:41 |
*** hitalia has quit IRC | 19:42 | |
*** pratikmallya has quit IRC | 19:42 | |
*** electrocucaracha has quit IRC | 19:43 | |
*** baoli has joined #openstack-nova | 19:44 | |
*** otter768 has joined #openstack-nova | 19:44 | |
*** baoli has quit IRC | 19:45 | |
*** baoli has joined #openstack-nova | 19:45 | |
*** salv-orlando has quit IRC | 19:45 | |
*** otter768 has quit IRC | 19:49 | |
*** rfolco has quit IRC | 19:50 | |
*** su_zhang has joined #openstack-nova | 19:50 | |
*** jlvillal has quit IRC | 19:51 | |
*** jlvillal has joined #openstack-nova | 19:51 | |
*** matrohon has joined #openstack-nova | 19:53 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: [WIP] Moar py34 tests! https://review.openstack.org/228600 | 19:54 |
*** cfriesen has joined #openstack-nova | 19:54 | |
*** rfolco has joined #openstack-nova | 19:56 | |
*** achanda has joined #openstack-nova | 19:56 | |
*** gabriel-bezerra has joined #openstack-nova | 19:57 | |
*** raildo-afk is now known as raildo | 19:57 | |
*** rfolco has quit IRC | 19:57 | |
*** yamahata has quit IRC | 19:58 | |
bauzas | does anyone know if largeops job is having again a problem ? http://goo.gl/G9Zazy | 19:58 |
*** yamahata has joined #openstack-nova | 19:58 | |
*** su_zhang has quit IRC | 19:58 | |
bauzas | mriedem: ^ | 19:58 |
mriedem | well let's take a look | 19:59 |
openstackgerrit | xing-yang proposed openstack/nova: Rollback is needed if attach_volume times out https://review.openstack.org/138664 | 19:59 |
bauzas | mriedem: http://logs.openstack.org/87/188487/35/check/gate-tempest-dsvm-large-ops/3ca28fc/console.html#_2015-09-28_15_54_16_819 | 20:00 |
mriedem | bauzas: yeah i'm seeing the same | 20:00 |
bauzas | sounds a performance regression like we had previously | 20:00 |
mriedem | in another log | 20:00 |
mriedem | the other thing had a more obvious error | 20:01 |
xyang1 | mriedem: updated the patch | 20:01 |
mriedem | bauzas: i do remember looking at a large ops fail a week or two ago and seeing some weirdness between when the network was allocated and when we timed out, | 20:01 |
mriedem | like it was missing some logging in the compute manager | 20:01 |
mriedem | so i was wondering if we hung up on some lock around networking | 20:01 |
*** achanda has quit IRC | 20:01 | |
bauzas | mriedem: yup, I remember that stotu | 20:01 |
bauzas | sotry | 20:01 |
*** tonytan4ever has quit IRC | 20:01 | |
bauzas | heh | 20:01 |
dansmith | bauzas: go to sleep :) | 20:02 |
bauzas | s-t-o-r-y | 20:02 |
*** lpetrut has joined #openstack-nova | 20:02 | |
mriedem | actually, i wasn't seeing the prep block device stuff happening in the logs | 20:02 |
mriedem | xyang1: cool, thanks | 20:02 |
mriedem | bauzas: so we might need some debug logging adding to the _prep_block_device flow in compute manager | 20:02 |
mriedem | bauzas: http://logs.openstack.org/23/226923/5/gate/gate-tempest-dsvm-large-ops/826845d/logs/screen-n-cpu-1.txt.gz#_2015-09-28_15_00_00_455 | 20:03 |
mriedem | Instance disappeared before build. _do_build_and_run_instance /opt/stack/new/nova/nova/compute/manager.py:1883 | 20:03 |
mriedem | too bad that's debug level or we could check logstash | 20:03 |
bauzas | meh | 20:04 |
bauzas | an InstanceNotFound? | 20:04 |
mriedem | bauzas: want to report a bug for this? | 20:04 |
bauzas | mriedem: sure I can | 20:05 |
mriedem | then we can do some debug logging changes for it? | 20:05 |
*** karimb has joined #openstack-nova | 20:05 | |
*** eharney has joined #openstack-nova | 20:05 | |
mriedem | well, | 20:05 |
mriedem | the build lock was acquired 5 minutes before http://logs.openstack.org/23/226923/5/gate/gate-tempest-dsvm-large-ops/826845d/logs/screen-n-cpu-1.txt.gz#_2015-09-28_14_55_35_708 | 20:05 |
bauzas | mriedem: I guess you verified the NotFound was re- to the same failing req-id ? | 20:06 |
mriedem | then we get the lock http://logs.openstack.org/23/226923/5/gate/gate-tempest-dsvm-large-ops/826845d/logs/screen-n-cpu-1.txt.gz#_2015-09-28_15_00_00_142 | 20:06 |
mriedem | and then the instance is gone, probably b/c the test timed out and deleted it | 20:06 |
bauzas | oh yeah | 20:06 |
mriedem | the request id is of no use here | 20:06 |
mriedem | req-249ad84f-c95d-47a8-839b-e359e4f14505 shows up 1711 times in n-cpu | 20:06 |
mriedem | looks like RT claims are taking awhile | 20:08 |
*** electrocucaracha has joined #openstack-nova | 20:08 | |
mriedem | which would lead me to believe there is a performance regression with the claims stuff ndipanov recently put in the RT | 20:08 |
mriedem | wow | 20:09 |
mriedem | http://logs.openstack.org/23/226923/5/gate/gate-tempest-dsvm-large-ops/826845d/logs/screen-n-cpu-1.txt.gz#_2015-09-28_14_59_29_549 | 20:09 |
mriedem | Lock "compute_resources" acquired by "nova.compute.resource_tracker.update_usage" :: waited 40.236s | 20:09 |
mriedem | that seems like a long time for the fake virt driver | 20:09 |
*** ks1 has joined #openstack-nova | 20:10 | |
bauzas | mriedem: you're quicker than me | 20:10 |
dansmith | unfortunately he's quicker than most :( | 20:11 |
bauzas | 11sec for updating the stats indeed | 20:11 |
*** salv-orlando has joined #openstack-nova | 20:11 | |
bauzas | so the RT is very bad in perf | 20:11 |
bauzas | good catch | 20:12 |
bauzas | trying to get some other metrics | 20:12 |
*** david-lyle has quit IRC | 20:14 | |
*** JoshNang has quit IRC | 20:17 | |
*** JoshNang has joined #openstack-nova | 20:17 | |
*** JoshNang has quit IRC | 20:18 | |
mriedem | http://goo.gl/j9Jkx4 | 20:18 |
mriedem | shows this spiking in the last 24 hours | 20:18 |
mriedem | but i'm not seeing anything merged in the last 24 hours in nova that looks related | 20:18 |
bauzas | mriedem: yup | 20:18 |
bauzas | mriedem: hence my ping | 20:19 |
bauzas | what's good with a long series is that you know when the gate has some problems :) | 20:19 |
bauzas | mriedem: I'm not exactly sure we have a performance problem | 20:20 |
*** baoli has quit IRC | 20:21 | |
mriedem | seeing a lot of this in nova-network also | 20:22 |
mriedem | Lock "dnsmasq_start" acquired by "nova.network.linux_net.restart_dhcp" :: waited 15.360s | 20:22 |
mriedem | that's usually 0 but sometimes it's around 15 seconds | 20:23 |
*** ks1 has quit IRC | 20:23 | |
bauzas | well, the regression started yesterday - a Sunday | 20:23 |
*** rfolco has joined #openstack-nova | 20:24 | |
mriedem | would kind of be nice to flag a warning when a lock or some action takes a certain % of rpc_response_timeout | 20:24 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Identify more py34 tests that already pass https://review.openstack.org/228600 | 20:25 |
mriedem | is there anything useful in the GMR here? http://logs.openstack.org/23/226923/5/gate/gate-tempest-dsvm-large-ops/826845d/logs/screen-n-cpu-1.txt.gz#_2015-09-28_15_02_53_503 | 20:26 |
*** hitalia has joined #openstack-nova | 20:26 | |
*** su_zhang has joined #openstack-nova | 20:27 | |
*** smatzek has quit IRC | 20:29 | |
*** raildo is now known as raildo-afk | 20:29 | |
*** electroc_ has joined #openstack-nova | 20:32 | |
dims | sdague: "should mostly all be flowers and unicorns" :) | 20:33 |
*** digimonde has joined #openstack-nova | 20:34 | |
*** electrocucaracha has quit IRC | 20:35 | |
sdague | dims: I'm glad I added a little sunshine to your day | 20:35 |
mriedem | bauzas: so CONF.max_concurrent_builds is what controls how many we can run at one time, and that defaults to 10 | 20:35 |
mriedem | bauzas: i'm wondering if we should increase that for the large ops test | 20:35 |
mriedem | because it seems we're starving trying to get into that build semaphore | 20:36 |
*** boris-42 has joined #openstack-nova | 20:37 | |
mriedem | or we should at least make CONF.max_concurrent_builds = CONF.rpc_conn_pool_size which defaults to 30 | 20:38 |
dansmith | how long are spawns taking though? | 20:38 |
dansmith | if they're mostly no-ops then it really shouldn't matter | 20:39 |
mriedem | looking | 20:39 |
dansmith | and if we're not doing any IO, then we're not lacking parallelism | 20:39 |
dansmith | s/IO/things that cause us to switch/ | 20:39 |
*** achanda has joined #openstack-nova | 20:39 | |
*** rfolco has quit IRC | 20:40 | |
bauzas | mriedem: meh, my kernel tainted | 20:41 |
mriedem | we do not do a great job of logging what we're doing in the build flow in the compute manager, we leave a lot of that to the virt driver | 20:41 |
mriedem | bauzas: gross | 20:41 |
bauzas | okay, I see the above | 20:42 |
alaski | mriedem: yeah, a *lot* of the build process is just shoved behind spawn() | 20:42 |
bauzas | well, my concern is to see why we should increase that limit | 20:42 |
bauzas | alaski: yeah that | 20:42 |
bauzas | the virt drivers can take a while | 20:42 |
mriedem | heh | 20:43 |
mriedem | While synchronizing instance power states, found 224 instances in the database and 222 instances on the hypervisor. | 20:43 |
dansmith | mriedem: that means we're only holding up two instances right? | 20:46 |
mriedem | alaski: do you see value in just having a simple debug log that tracks time spent before and after calling _build_and_run_instance in compute manager? | 20:46 |
alaski | mriedem: yes. I see more value in a notification, though that doesn't help the gate much | 20:47 |
mriedem | dansmith: we are leaking something here | 20:48 |
mriedem | at first instance build is taking around 20 seconds | 20:48 |
mriedem | then over time it takes about 90 seconds | 20:48 |
mriedem | http://logs.openstack.org/23/226923/5/gate/gate-tempest-dsvm-large-ops/826845d/logs/screen-n-cpu-1.txt.gz#_2015-09-28_14_50_33_619 | 20:48 |
dansmith | mriedem: well, we have to pull the image right? | 20:49 |
dansmith | seems like a long time for a cirros though, even under load | 20:49 |
mriedem | well, it's weird, if you run down through the n-cpu log looking at: "nova.compute.manager._locked_do_build_and_run_instance" :: held | 20:50 |
mriedem | it increases and increases and then resets | 20:50 |
mtreinish | dansmith: isn't large ops with the fake virt driver? | 20:50 |
*** yamahata has quit IRC | 20:50 | |
dansmith | mriedem: that lock doesn't mean anything though, as it's just per-instance right? | 20:50 |
mriedem | yrd | 20:50 |
mriedem | mtreinish: yes | 20:50 |
*** yamahata has joined #openstack-nova | 20:50 | |
dansmith | mtreinish: yeah, but the fake virt driver does some real virt drivery things for simulation I think | 20:50 |
dansmith | it' | 20:50 |
dansmith | it's not just all nops I don't think | 20:51 |
mriedem | it does some resource tracking things | 20:51 |
mriedem | sdague: added that in kilo i think | 20:51 |
dansmith | there was talk about making it even more real recently for testing | 20:51 |
mtreinish | ok, I wasn't sure. I guess it still pulls an image thats why we enable glance on that job | 20:51 |
*** lpetrut has quit IRC | 20:51 | |
mriedem | dansmith: sure, but _locked_do_build_and_run_instance is the lock around building the instance, which is what i'm wondering takes so long | 20:52 |
mriedem | toward the end of the test run, it's taking 277 seconds to build an instance | 20:52 |
dansmith | mriedem: and the semaphore is inside the lock, right? | 20:52 |
mriedem | yes | 20:52 |
dansmith | mriedem: so it should increase if they all arrive at the same time, and the last one has to wait for the semaphore for the whole thing | 20:52 |
*** tonytan4ever has joined #openstack-nova | 20:52 | |
mriedem | yeah, and the timeout in the test is 300 seconds | 20:53 |
mriedem | actually it's 196 seconds... | 20:53 |
mriedem | Details: (TestLargeOpsScenario:test_large_ops_scenario_3) Server f228d638-116f-4431-b890-ebf0b4b6ef2d failed to reach ACTIVE status and task state "None" within the required time (196 s). Current status: BUILD. Current task state: scheduling. | 20:53 |
dansmith | well, bumping up the concurrent limit is easy to test, but it still seems like that just papers over some other problem | 20:53 |
bauzas | right | 20:54 |
bauzas | that's my worries | 20:54 |
dansmith | I'd start putting log statements everywhere and looking at the timing to figure out what it is | 20:55 |
mriedem | the only other thing i saw taking time was the restart_dhcp stuff in nova-net and the RT._update_usage stuff | 20:55 |
mriedem | yeah, that was my next step | 20:55 |
mriedem | bauzas: do you have a bug? | 20:55 |
bauzas | mriedem: the RT._update_usage() was not exactly huge | 20:55 |
bauzas | mriedem: nope, creating it now | 20:55 |
*** yamahata has quit IRC | 20:55 | |
mriedem | bauzas: it seemed big for a fake virt driver | 20:55 |
bauzas | I had something and then linux said hi | 20:55 |
*** yamahata has joined #openstack-nova | 20:55 | |
*** Piet has joined #openstack-nova | 20:56 | |
sdague | mriedem: is this a new spike? | 21:00 |
mriedem | sdague: yeah http://goo.gl/j9Jkx4 | 21:00 |
bauzas | mriedem: https://bugs.launchpad.net/nova/+bug/1500615 | 21:00 |
openstack | Launchpad bug 1500615 in OpenStack Compute (nova) "Large Ops scenario is taking too long" [Critical,New] | 21:00 |
sdague | mriedem: did that run afoul of the worker change? | 21:01 |
bauzas | sdague: when did that change introduced ? | 21:01 |
mriedem | https://review.openstack.org/#/c/226831/ | 21:01 |
bauzas | sdague: just saw your email | 21:01 |
dansmith | this is nova compute | 21:02 |
dansmith | so no workers | 21:02 |
sdague | ok, if it's fully inside n-cpu, then never mind | 21:02 |
dansmith | unless conductor is just so much faster because of the change that it's choking n-cpu | 21:02 |
sdague | conductor got cut way back in that change as well | 21:02 |
dansmith | like we used to do with n-net | 21:02 |
dansmith | but I think that's quite unlikely | 21:02 |
mriedem | sdague: workers went from 4 to 2 right? | 21:03 |
sdague | mriedem: yeh | 21:03 |
sdague | and conductors from 8 to 2 | 21:03 |
mriedem | oh, geez | 21:03 |
sdague | because before conductor was n cpu instead of n cpu / 2 | 21:03 |
*** kevinbenton has quit IRC | 21:03 | |
dansmith | now... | 21:04 |
dansmith | n-cpu might be slowed a bit by less availability of conductor workers | 21:04 |
*** yassine__ has quit IRC | 21:04 | |
dansmith | less actual parallelism | 21:04 |
*** kevinbenton has joined #openstack-nova | 21:04 | |
sdague | dansmith: is there a way to test that backing up? or to see if that's the problem? | 21:06 |
dansmith | I dunno, I'm thinking | 21:06 |
openstackgerrit | Marian Horban proposed openstack/nova: [WIP]Remove wsgi functionality https://review.openstack.org/219248 | 21:06 |
dansmith | does sar give us per-process usage? | 21:06 |
*** hemna has quit IRC | 21:07 | |
sdague | we're using dstat, not sar | 21:07 |
sdague | and the thing we've got is most expensive process | 21:08 |
dansmith | does dstat give us per-process usage? | 21:08 |
sdague | http://logs.openstack.org/23/226923/5/gate/gate-tempest-dsvm-large-ops/826845d/logs/screen-dstat.txt.gz | 21:08 |
sdague | which does seem to be conductor for a lot of that run | 21:08 |
dansmith | yeah lots of conductor in there | 21:08 |
mikal | Mornign | 21:08 |
sdague | so, perhaps for largeops we want to bump API_WORKERS explicitly to a higher number | 21:09 |
*** ociuhandu has quit IRC | 21:09 | |
dansmith | and that gets both conductor and api? | 21:09 |
sdague | yep | 21:09 |
dansmith | can we do that as a test and do some runs on it? | 21:09 |
mriedem | we can | 21:09 |
*** burgerk has quit IRC | 21:09 | |
*** ociuhandu has joined #openstack-nova | 21:09 | |
*** david-lyle has joined #openstack-nova | 21:09 | |
sdague | https://github.com/openstack-dev/devstack/blob/8e2597fa79d5390062747bcd7719c41ca6e6ccb1/lib/nova#L620-L624 | 21:10 |
dansmith | and that becomes ncpus for conductor and n/2 for api? | 21:11 |
mriedem | used to be | 21:11 |
mriedem | before https://review.openstack.org/#/c/226831/ | 21:11 |
sdague | right, it was before | 21:11 |
sdague | now API_WORKERS is n/4 | 21:11 |
dansmith | so now it's what? | 21:11 |
sdague | and it's used for both | 21:11 |
*** ociuhandu has quit IRC | 21:11 | |
dansmith | so two conductors? | 21:11 |
sdague | yes | 21:11 |
dansmith | ahh, okay | 21:11 |
dansmith | so the good news is, | 21:12 |
*** hemna has joined #openstack-nova | 21:12 | |
dansmith | before we needed lots of workers just because we were blocking and being stupid | 21:12 |
dansmith | but it's clear that here we need more workers because we actually need them | 21:12 |
dansmith | just cpu bandwidth-wise | 21:12 |
*** thorst has quit IRC | 21:12 | |
sdague | right, because spawning 175 vms at once stresses this thing out | 21:12 |
sdague | go figure | 21:12 |
mriedem | 100 actually | 21:12 |
dansmith | which is probably reasonable :) | 21:12 |
dansmith | so it was 8 or 4 before? | 21:13 |
sdague | yeh, so conductor is now cpu bound in this config | 21:13 |
sdague | it was 8 before | 21:13 |
dansmith | right, okay so can we try 4? | 21:13 |
sdague | because it's just using oslo.processutils which doesn't do the /2 | 21:13 |
dansmith | okay | 21:13 |
dansmith | but we want 2 for api and 4 (or however many we need) for conductor right? | 21:13 |
sdague | well, that's the question | 21:13 |
dansmith | so we either need a tweak in there or a *2 | 21:13 |
dansmith | er, a new conf or a *2 | 21:14 |
*** kevinbenton has quit IRC | 21:14 | |
sdague | because we could also just largeops bump up API_WORKERS | 21:14 |
sdague | and get more n-api workers as well | 21:14 |
dansmith | well, I think there's no reason not to keep api cut down if it's okay to do so | 21:14 |
dansmith | that was a lot of negatives | 21:14 |
dansmith | I think we should keep n-api as low as is reasonable unless there is a reason to bump it | 21:14 |
sdague | yeh, it just simplifies things to keep them bound together, because for everything but the fakevirt case that's better | 21:14 |
dansmith | if it's not too much churn | 21:14 |
dansmith | yeah, I know | 21:14 |
sdague | so, lets do the broad fix first, and just do /2 for both | 21:15 |
sdague | and see what happens | 21:15 |
dansmith | *2? | 21:15 |
sdague | and if we want to optimize later, we can | 21:15 |
sdague | well, nproc / 2 | 21:15 |
dansmith | ah | 21:15 |
sdague | so yes, *2 from current value | 21:15 |
dansmith | yep cool | 21:16 |
mriedem | API_WORKERS=${API_WORKERS:=$(( ($(nproc)/2)<2 ? 2 : ($(nproc)/2) ))} | 21:16 |
mriedem | if [[ "$VIRT_DRIVER" = 'fake' ]]; then | 21:16 |
mriedem | etc | 21:16 |
sdague | mriedem: yeh | 21:16 |
mriedem | alaski: you know if osprofiler was instrumented through nova we'd already have this timing information | 21:17 |
* mriedem opens can of worms | 21:17 | |
alaski | heh | 21:18 |
*** matrohon has quit IRC | 21:18 | |
alaski | I need to take a look at that project again. I really have no idea how invasive it would be | 21:18 |
sdague | very | 21:18 |
* dansmith backs away slowly | 21:18 | |
mriedem | i could mention his name who must not be named | 21:18 |
sdague | anyway | 21:19 |
dansmith | mriedem: don't make me kickban you | 21:19 |
alaski | in that case I'll stop thinking about it now | 21:19 |
*** rlrossit has left #openstack-nova | 21:19 | |
mriedem | i'm about to leave anyway | 21:19 |
sdague | well, this was why I posted that email about the worker change, I knew something might go wrong | 21:19 |
dansmith | this is fairly minor damage though | 21:19 |
sdague | yeh | 21:20 |
sdague | agreed | 21:20 |
*** dustins has quit IRC | 21:21 | |
*** dave-mccowan has quit IRC | 21:23 | |
mriedem | mtreinish: large ops does a batch 100 server boot 3 times right, and actually does the wait for delete between each test run? | 21:23 |
mriedem | so we're not trying to boot 100 instances while we are still deleting like 40 of a previous run or something | 21:24 |
mtreinish | err, that sounds right, I'd have to double check all thge details though | 21:24 |
bauzas | sdague: mriedem: dansmith: thanks for having spotted a possible solution, need to drop off :) | 21:24 |
dansmith | mriedem: I think that's right | 21:24 |
dansmith | I'm about to run off for a few too | 21:24 |
mriedem | dansmith: were you pushing that devstack change? | 21:24 |
dansmith | mriedem: I'm not, I thought sdague was | 21:25 |
mriedem | heh | 21:25 |
mriedem | i think he was telling you how | 21:25 |
mriedem | i'll do it | 21:25 |
*** thangp has quit IRC | 21:25 | |
dansmith | oh, I can do it if you want to leave | 21:25 |
*** mwagner_ has quit IRC | 21:25 | |
mriedem | i have 20 minutes | 21:25 |
dansmith | plenty of time | 21:25 |
sdague | oh, sorry, yeh I was just explaining what needed to be done :) | 21:25 |
sdague | and I have to go make dinner, so running. I'll look in the morning at the runs | 21:26 |
*** karimb has quit IRC | 21:26 | |
mriedem | i've learned by now that by this time of day sdague is more in the mode of telling others what he'd do | 21:26 |
mriedem | :) | 21:26 |
dansmith | heh | 21:26 |
openstackgerrit | Giridhar Jayavelu proposed openstack/nova: VMware: disk limits during resize operation https://review.openstack.org/204220 | 21:26 |
dansmith | okay, well, I'm going to run off then and will look at it when I get back | 21:26 |
openstackgerrit | Giridhar Jayavelu proposed openstack/nova: VMware: vif limits during resize operation https://review.openstack.org/204221 | 21:26 |
sdague | :) | 21:26 |
dansmith | and give my all important +1 | 21:26 |
*** vilobhmm111 has quit IRC | 21:28 | |
mriedem | we could just leave workers at default (nproc) for largeops.... | 21:28 |
mriedem | it kind of makes sense - if that's not sane, it shouldn't be the default in the code probably | 21:29 |
*** stevemar has quit IRC | 21:29 | |
*** stevemar has joined #openstack-nova | 21:29 | |
mriedem | but i see all of my comrades have left me | 21:29 |
mtreinish | mriedem: err, I just double checked it'll create 100 servers 3 times | 21:30 |
mtreinish | and then cleanup all 300 during tearDownClass | 21:30 |
mriedem | oh damn | 21:30 |
mtreinish | not between each set of 100 | 21:30 |
mriedem | it just waits for all 100 to go active and then moves on | 21:30 |
*** vilobhmm11 has joined #openstack-nova | 21:31 | |
mtreinish | mriedem: https://github.com/openstack/tempest/blob/master/tempest/scenario/test_large_ops.py#L62 | 21:31 |
*** dave-mccowan has joined #openstack-nova | 21:31 | |
*** annegentle has quit IRC | 21:31 | |
*** smatzek has joined #openstack-nova | 21:32 | |
*** stevemar has quit IRC | 21:32 | |
mriedem | hrm, devstack can also run apache which uses $API_WORKERS | 21:34 |
mriedem | would be nice to just set API_WORKERS globally in stackrc if largeops | 21:35 |
*** penick has quit IRC | 21:40 | |
*** bapalm_ has quit IRC | 21:41 | |
*** bapalm has joined #openstack-nova | 21:42 | |
*** salv-orl_ has joined #openstack-nova | 21:42 | |
*** digimonde has quit IRC | 21:43 | |
*** su_zhang_ has joined #openstack-nova | 21:44 | |
*** salv-orlando has quit IRC | 21:45 | |
*** otter768 has joined #openstack-nova | 21:45 | |
*** willsama has quit IRC | 21:46 | |
*** kevinbenton has joined #openstack-nova | 21:47 | |
*** su_zhang has quit IRC | 21:47 | |
*** mriedem is now known as mriedem_away | 21:49 | |
*** otter768 has quit IRC | 21:51 | |
*** alex_klimov has joined #openstack-nova | 21:52 | |
*** su_zhang has joined #openstack-nova | 21:53 | |
*** mudassirlatif has joined #openstack-nova | 21:54 | |
*** su_zhang_ has quit IRC | 21:56 | |
*** ctrath has quit IRC | 22:01 | |
*** krtaylor has joined #openstack-nova | 22:02 | |
*** hitalia has quit IRC | 22:04 | |
*** Apoorva has quit IRC | 22:05 | |
*** smatzek has quit IRC | 22:05 | |
*** nic has quit IRC | 22:06 | |
*** packet has quit IRC | 22:07 | |
*** hitalia has joined #openstack-nova | 22:07 | |
*** rushil_ has quit IRC | 22:08 | |
*** alejandrito has quit IRC | 22:09 | |
*** vilobhmm111 has joined #openstack-nova | 22:09 | |
*** mdrabe has quit IRC | 22:10 | |
*** vilobhmm11 has quit IRC | 22:10 | |
*** xyang1 has quit IRC | 22:12 | |
*** bswartz has joined #openstack-nova | 22:12 | |
*** stevemar has joined #openstack-nova | 22:12 | |
*** VW has joined #openstack-nova | 22:15 | |
*** dims has quit IRC | 22:17 | |
*** setuid has quit IRC | 22:17 | |
*** stevemar has quit IRC | 22:17 | |
*** burt has quit IRC | 22:18 | |
*** VW_ has quit IRC | 22:18 | |
*** setuid has joined #openstack-nova | 22:19 | |
*** ijw has joined #openstack-nova | 22:19 | |
*** VW has quit IRC | 22:20 | |
*** alex_klimov has quit IRC | 22:20 | |
*** stevemar has joined #openstack-nova | 22:21 | |
openstackgerrit | Ryan McNair proposed openstack/nova: Add retry logic for removing device with LibVirt https://review.openstack.org/227851 | 22:21 |
*** ijw_ has joined #openstack-nova | 22:23 | |
*** stevemar_ has joined #openstack-nova | 22:23 | |
*** claudiub has quit IRC | 22:24 | |
*** ijw has quit IRC | 22:24 | |
*** Piet has quit IRC | 22:25 | |
*** stevemar has quit IRC | 22:25 | |
*** mwagner_ has joined #openstack-nova | 22:26 | |
*** stevemar_ has quit IRC | 22:28 | |
*** stevemar has joined #openstack-nova | 22:30 | |
*** tpeoples has quit IRC | 22:31 | |
*** stevemar_ has joined #openstack-nova | 22:31 | |
*** tonytan4ever has quit IRC | 22:31 | |
*** su_zhang has quit IRC | 22:32 | |
*** stevemar has quit IRC | 22:34 | |
*** mc_nair_ has quit IRC | 22:35 | |
*** stevemar_ has quit IRC | 22:36 | |
*** stevemar has joined #openstack-nova | 22:36 | |
*** penick has joined #openstack-nova | 22:37 | |
*** su_zhang has joined #openstack-nova | 22:39 | |
*** asettle has joined #openstack-nova | 22:39 | |
*** agireud has quit IRC | 22:39 | |
*** e0ne has quit IRC | 22:40 | |
*** stevemar has quit IRC | 22:41 | |
*** ijuwang has quit IRC | 22:42 | |
*** obedmr has quit IRC | 22:46 | |
*** nic has joined #openstack-nova | 22:46 | |
*** salv-orl_ has quit IRC | 22:51 | |
*** alexpilotti has quit IRC | 22:51 | |
*** Apoorva has joined #openstack-nova | 22:58 | |
*** thorst has joined #openstack-nova | 23:02 | |
*** markvoelker has quit IRC | 23:03 | |
*** krtaylor has quit IRC | 23:05 | |
*** hemna is now known as hemnafk | 23:06 | |
*** thorst has quit IRC | 23:10 | |
*** ijw_ has quit IRC | 23:10 | |
*** ijw has joined #openstack-nova | 23:11 | |
openstackgerrit | melanie witt proposed openstack/nova: Fix Instance unit test for DBReferenceError https://review.openstack.org/228659 | 23:12 |
openstackgerrit | melanie witt proposed openstack/nova: Check DBReferenceError foreign key in Instance.save https://review.openstack.org/228660 | 23:12 |
*** gzhai1 has quit IRC | 23:13 | |
*** jamielennox|away is now known as jamielennox | 23:13 | |
*** gzhai1 has joined #openstack-nova | 23:13 | |
*** bnemec has joined #openstack-nova | 23:14 | |
*** Piet_ has joined #openstack-nova | 23:14 | |
*** ircuser-1 has quit IRC | 23:15 | |
*** bnemec has quit IRC | 23:18 | |
*** bnemec has joined #openstack-nova | 23:18 | |
*** yamahata has quit IRC | 23:25 | |
*** tpeoples has joined #openstack-nova | 23:26 | |
*** mudassirlatif has quit IRC | 23:26 | |
*** jwcroppe_ has joined #openstack-nova | 23:34 | |
*** tjones has joined #openstack-nova | 23:34 | |
*** tjones has left #openstack-nova | 23:34 | |
*** jwcroppe has quit IRC | 23:38 | |
*** Apoorva is now known as apoorvad | 23:38 | |
*** jwcroppe_ has quit IRC | 23:39 | |
*** yamahata has joined #openstack-nova | 23:40 | |
*** Alexus has joined #openstack-nova | 23:41 | |
*** ircuser-1 has joined #openstack-nova | 23:41 | |
*** agireud has joined #openstack-nova | 23:41 | |
*** nic has quit IRC | 23:42 | |
*** krtaylor has joined #openstack-nova | 23:43 | |
*** tpeoples has quit IRC | 23:46 | |
*** otter768 has joined #openstack-nova | 23:46 | |
*** markvoelker has joined #openstack-nova | 23:46 | |
*** ZZelle_ has quit IRC | 23:51 | |
*** otter768 has quit IRC | 23:51 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add pep8 check for assertEqual argument order https://review.openstack.org/227650 | 23:52 |
*** tjones has joined #openstack-nova | 23:53 | |
*** tjones has left #openstack-nova | 23:53 | |
*** gzhai1 has quit IRC | 23:54 | |
*** gzhai1 has joined #openstack-nova | 23:55 | |
openstackgerrit | Ken'ichi Ohmichi proposed openstack/nova: Add pep8 check for assertEqual argument order https://review.openstack.org/227650 | 23:58 |
*** achanda has quit IRC | 23:58 | |
*** pratikmallya has joined #openstack-nova | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!