*** SourabhP has quit IRC | 00:00 | |
*** yamahata has quit IRC | 00:01 | |
*** edmondsw has quit IRC | 00:01 | |
*** mgoddard has joined #openstack-nova | 00:02 | |
*** diogogmt has quit IRC | 00:03 | |
*** knikolla has quit IRC | 00:06 | |
*** kse has joined #openstack-nova | 00:07 | |
*** su_zhang_ has quit IRC | 00:08 | |
*** ctrath has quit IRC | 00:08 | |
*** VW has joined #openstack-nova | 00:09 | |
*** tsekiyam_ has joined #openstack-nova | 00:09 | |
*** mtanino has quit IRC | 00:12 | |
*** mgoddard has quit IRC | 00:13 | |
*** tsekiyama has quit IRC | 00:13 | |
*** tsekiyam_ has quit IRC | 00:14 | |
*** Kennan has quit IRC | 00:16 | |
*** mgoddard has joined #openstack-nova | 00:17 | |
dims | sdague: looks like this partial ncpu job is green - https://jenkins06.openstack.org/job/gate-grenade-dsvm-partial-ncpu/6497/console | 00:17 |
---|---|---|
*** tjones has quit IRC | 00:19 | |
*** Daisy has quit IRC | 00:22 | |
*** mgoddard has quit IRC | 00:22 | |
*** mgoddard has joined #openstack-nova | 00:27 | |
*** asettle is now known as asettle-afk | 00:29 | |
*** markvoelker has joined #openstack-nova | 00:30 | |
*** jwcroppe has joined #openstack-nova | 00:32 | |
*** dsanders has quit IRC | 00:33 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/nova: Update rpc version aliases for liberty https://review.openstack.org/230132 | 00:34 |
dims | melwitt: done! | 00:34 |
dims | yes, the last 1.15 too | 00:34 |
melwitt | dims: okay :) I realized I forgot to also highlight that one the first time | 00:35 |
*** cfriesen has quit IRC | 00:35 | |
*** markvoelker has quit IRC | 00:35 | |
dansmith | melwitt: oops, thanks for catching those | 00:36 |
dansmith | I was going fast | 00:36 |
dims | melwitt: i totally skipped the comments as i was just trying to see if i could get the grenade to pass and thankfully dan picked it up | 00:36 |
dims | thanks to both of you! | 00:36 |
melwitt | dansmith: yeah, I figured :) | 00:37 |
*** tpeoples has quit IRC | 00:38 | |
dansmith | oof, still another hour at least for the requirements patch to merge | 00:38 |
*** mgoddard has quit IRC | 00:39 | |
dims | dansmith: which one? | 00:42 |
dansmith | dims: the pillow fix | 00:42 |
dansmith | everything south of that is going to fail | 00:42 |
*** VW has quit IRC | 00:42 | |
dims | dansmith: ah yes | 00:42 |
*** mgoddard has joined #openstack-nova | 00:42 | |
*** VW has joined #openstack-nova | 00:43 | |
*** achanda has quit IRC | 00:47 | |
*** VW has quit IRC | 00:47 | |
*** ctrath has joined #openstack-nova | 00:50 | |
*** ctrath has quit IRC | 00:51 | |
*** mgoddard has quit IRC | 00:52 | |
openstackgerrit | Dan Smith proposed openstack/nova: Extend the ServiceTooOld exception with more data https://review.openstack.org/230227 | 00:54 |
*** exploreshaifali has joined #openstack-nova | 00:57 | |
*** baoli has joined #openstack-nova | 00:59 | |
*** gyee has quit IRC | 00:59 | |
*** baoli has quit IRC | 01:00 | |
*** baoli has joined #openstack-nova | 01:00 | |
*** mgoddard has joined #openstack-nova | 01:01 | |
*** baoli_ has joined #openstack-nova | 01:01 | |
*** EinstCrazy has joined #openstack-nova | 01:02 | |
*** baoli has quit IRC | 01:04 | |
*** knikolla has joined #openstack-nova | 01:06 | |
*** mgoddard has quit IRC | 01:07 | |
*** yamahata has joined #openstack-nova | 01:08 | |
*** knikolla has quit IRC | 01:11 | |
*** mgoddard has joined #openstack-nova | 01:11 | |
*** pm90_ has joined #openstack-nova | 01:11 | |
*** exploreshaifali has quit IRC | 01:11 | |
*** EinstCrazy has quit IRC | 01:12 | |
*** ctrath has joined #openstack-nova | 01:14 | |
*** davideagnello has quit IRC | 01:16 | |
*** baoli_ has quit IRC | 01:17 | |
*** whenry has quit IRC | 01:17 | |
*** setuid has quit IRC | 01:18 | |
*** setuid has joined #openstack-nova | 01:20 | |
*** apoorvad has quit IRC | 01:24 | |
*** su_zhang_ has joined #openstack-nova | 01:26 | |
*** mgoddard has quit IRC | 01:30 | |
*** su_zhang_ has quit IRC | 01:30 | |
*** ssurana has quit IRC | 01:30 | |
*** apoorvad has joined #openstack-nova | 01:31 | |
*** vilobhmm11 has quit IRC | 01:33 | |
*** dims has quit IRC | 01:34 | |
*** mgoddard has joined #openstack-nova | 01:34 | |
*** yamahata has quit IRC | 01:34 | |
*** mudassirlatif has quit IRC | 01:34 | |
*** mdrabe has joined #openstack-nova | 01:37 | |
*** zzzeek has joined #openstack-nova | 01:40 | |
*** angdraug has quit IRC | 01:44 | |
*** mestery has quit IRC | 01:45 | |
*** mestery has joined #openstack-nova | 01:46 | |
*** EinstCrazy has joined #openstack-nova | 01:46 | |
*** ssurana has joined #openstack-nova | 01:49 | |
*** achanda has joined #openstack-nova | 01:51 | |
*** nelsnelson has quit IRC | 01:51 | |
*** nelsnelson has joined #openstack-nova | 01:52 | |
*** penick has quit IRC | 01:52 | |
*** unicell has quit IRC | 01:52 | |
*** mgoddard has quit IRC | 01:55 | |
*** asettle-afk is now known as asettle | 01:55 | |
* tonyb waits for a flurry of g-r syncs | 01:56 | |
*** mgoddard has joined #openstack-nova | 01:59 | |
*** signed8bit has joined #openstack-nova | 02:02 | |
mriedem | alaski: at some point tomorrow you might want to look at this, i'm scratching my head over why the cells job is passing on the tempest compute api security group tests if cells v1 doesn't support security groups | 02:03 |
mriedem | http://logs.openstack.org/43/226043/10/check/gate-tempest-dsvm-cells/b28ebdb/console.html#_2015-09-29_18_44_27_266 | 02:03 |
*** browne has quit IRC | 02:03 | |
mriedem | running from the change that enables those tests in the blacklist rc file https://review.openstack.org/#/c/226043/ | 02:03 |
*** nelsnelson has quit IRC | 02:05 | |
*** mgoddard has quit IRC | 02:05 | |
*** nelsnelson has joined #openstack-nova | 02:05 | |
*** rfolco has joined #openstack-nova | 02:07 | |
*** mcarden has quit IRC | 02:12 | |
*** mgoddard has joined #openstack-nova | 02:13 | |
*** jwcroppe has quit IRC | 02:13 | |
*** dsanders has joined #openstack-nova | 02:14 | |
*** dave-mccowan has quit IRC | 02:14 | |
*** EinstCrazy has quit IRC | 02:14 | |
*** apoorvad_ has joined #openstack-nova | 02:15 | |
*** apoorvad has quit IRC | 02:18 | |
*** dsanders has quit IRC | 02:18 | |
*** apoorvad_ has quit IRC | 02:19 | |
*** mgoddard has quit IRC | 02:19 | |
*** ctrath has quit IRC | 02:23 | |
*** VW has joined #openstack-nova | 02:24 | |
*** VW has quit IRC | 02:26 | |
*** VW has joined #openstack-nova | 02:26 | |
*** mgoddard has joined #openstack-nova | 02:27 | |
openstackgerrit | Tony Breeds proposed openstack/nova: Add Pillow to test-requirements.txt https://review.openstack.org/230245 | 02:31 |
*** pm90_ has quit IRC | 02:32 | |
*** markvoelker has joined #openstack-nova | 02:32 | |
*** mgoddard has quit IRC | 02:35 | |
*** markvoelker has quit IRC | 02:36 | |
*** signed8bit has quit IRC | 02:40 | |
*** zzzeek has quit IRC | 02:42 | |
*** mgoddard has joined #openstack-nova | 02:43 | |
*** nelsnelson has quit IRC | 02:44 | |
*** r-daneel has quit IRC | 02:44 | |
*** nelsnelson has joined #openstack-nova | 02:46 | |
*** otter768 has quit IRC | 02:47 | |
*** mgoddard has quit IRC | 02:48 | |
*** otter768 has joined #openstack-nova | 02:48 | |
*** mgoddard has joined #openstack-nova | 02:49 | |
*** asettle is now known as asettle-napnap | 02:49 | |
*** asettle-napnap has quit IRC | 02:50 | |
*** signed8bit has joined #openstack-nova | 02:51 | |
*** browne has joined #openstack-nova | 02:51 | |
*** stevemar has joined #openstack-nova | 02:54 | |
*** ferest has joined #openstack-nova | 02:55 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: VMware: raise NotImplementedError for live migration methods https://review.openstack.org/228893 | 02:57 |
*** stevemar has quit IRC | 02:59 | |
*** ferest has quit IRC | 03:00 | |
*** nelsnelson has quit IRC | 03:02 | |
*** changbl has joined #openstack-nova | 03:03 | |
*** rfolco has quit IRC | 03:07 | |
*** agireud has joined #openstack-nova | 03:08 | |
*** changbl has quit IRC | 03:08 | |
*** knikolla has joined #openstack-nova | 03:10 | |
*** knikolla has quit IRC | 03:13 | |
*** knikolla has joined #openstack-nova | 03:14 | |
*** tpeoples has joined #openstack-nova | 03:15 | |
*** mriedem has quit IRC | 03:15 | |
*** baoli has joined #openstack-nova | 03:20 | |
*** mdrabe has quit IRC | 03:20 | |
*** mgoddard has quit IRC | 03:24 | |
*** mgoddard has joined #openstack-nova | 03:25 | |
*** stevemar_ has joined #openstack-nova | 03:28 | |
*** links has joined #openstack-nova | 03:31 | |
*** signed8bit has quit IRC | 03:33 | |
*** mgoddard has quit IRC | 03:34 | |
*** knikolla has quit IRC | 03:37 | |
*** mgoddard has joined #openstack-nova | 03:39 | |
*** otter768 has quit IRC | 03:40 | |
*** otter768 has joined #openstack-nova | 03:40 | |
*** stevemar_ has quit IRC | 03:41 | |
*** stevemar has joined #openstack-nova | 03:42 | |
*** salv-orlando has joined #openstack-nova | 03:43 | |
*** mgoddard has quit IRC | 03:44 | |
*** salv-orl_ has quit IRC | 03:45 | |
*** mgoddard has joined #openstack-nova | 03:49 | |
*** nelsnelson has joined #openstack-nova | 03:51 | |
tonyb | Thems that can please look at: https://review.openstack.org/#/c/230245/ as a tempoary de-wedge the gate fix | 03:54 |
*** tpeoples has quit IRC | 03:57 | |
*** mgoddard has quit IRC | 03:57 | |
*** bnemec has quit IRC | 04:02 | |
*** mgoddard has joined #openstack-nova | 04:06 | |
*** stevemar_ has joined #openstack-nova | 04:07 | |
*** stevemar has quit IRC | 04:09 | |
*** yamahata has joined #openstack-nova | 04:10 | |
*** ssurana has quit IRC | 04:11 | |
*** mgoddard has quit IRC | 04:14 | |
*** ssurana has joined #openstack-nova | 04:15 | |
*** baoli has quit IRC | 04:16 | |
*** VW has quit IRC | 04:19 | |
*** VW has joined #openstack-nova | 04:20 | |
*** mgoddard has joined #openstack-nova | 04:22 | |
*** VW has quit IRC | 04:24 | |
*** yamahata has quit IRC | 04:26 | |
*** mgoddard has quit IRC | 04:29 | |
*** markvoelker has joined #openstack-nova | 04:33 | |
*** pm90_ has joined #openstack-nova | 04:33 | |
*** stevemar has joined #openstack-nova | 04:34 | |
*** stevemar_ has quit IRC | 04:34 | |
*** mgoddard has joined #openstack-nova | 04:36 | |
*** vilobhmm11 has joined #openstack-nova | 04:38 | |
*** stevemar has quit IRC | 04:39 | |
*** yasu has joined #openstack-nova | 04:44 | |
*** apoorvad has joined #openstack-nova | 04:48 | |
*** vilobhmm111 has joined #openstack-nova | 04:48 | |
*** stevemar has joined #openstack-nova | 04:50 | |
*** vilobhmm11 has quit IRC | 04:50 | |
*** yasu has quit IRC | 04:52 | |
*** nelsnelson has quit IRC | 04:55 | |
*** twinklechawla has joined #openstack-nova | 04:56 | |
*** jwcroppe has joined #openstack-nova | 04:58 | |
*** asettle has joined #openstack-nova | 05:02 | |
*** jwcroppe has quit IRC | 05:02 | |
*** mgoddard has quit IRC | 05:02 | |
*** vishwanathj has quit IRC | 05:04 | |
*** crinkle has quit IRC | 05:04 | |
*** stevemar has quit IRC | 05:05 | |
*** stevemar has joined #openstack-nova | 05:06 | |
*** mragupat has joined #openstack-nova | 05:06 | |
*** mgoddard has joined #openstack-nova | 05:07 | |
*** markvoelker has quit IRC | 05:07 | |
openstackgerrit | Michael Still proposed openstack/nova-specs: Locking servers by service token https://review.openstack.org/203880 | 05:08 |
*** stevemar has quit IRC | 05:10 | |
*** mgoddard has quit IRC | 05:11 | |
*** mudassirlatif has joined #openstack-nova | 05:11 | |
*** agireud has quit IRC | 05:19 | |
*** mgoddard has joined #openstack-nova | 05:20 | |
*** twinklechawla has quit IRC | 05:22 | |
*** apoorvad has quit IRC | 05:24 | |
*** mgoddard has quit IRC | 05:24 | |
*** nkrinner has joined #openstack-nova | 05:27 | |
*** agireud has joined #openstack-nova | 05:29 | |
*** yasu has joined #openstack-nova | 05:32 | |
*** mgoddard has joined #openstack-nova | 05:33 | |
openstackgerrit | venkatesh proposed openstack/nova: make the driver.Scheduler as abstract class https://review.openstack.org/212016 | 05:33 |
*** twinklechawla has joined #openstack-nova | 05:34 | |
*** asettle has quit IRC | 05:37 | |
*** mgoddard has quit IRC | 05:41 | |
*** mgoddard has joined #openstack-nova | 05:42 | |
*** su_zhang_ has joined #openstack-nova | 05:43 | |
*** twinklechawla has quit IRC | 05:43 | |
*** e0ne has joined #openstack-nova | 05:45 | |
*** mgoddard has quit IRC | 05:48 | |
*** stevemar has joined #openstack-nova | 05:50 | |
*** SourabhP has joined #openstack-nova | 05:50 | |
*** stevemar_ has joined #openstack-nova | 05:51 | |
*** nelsnelson has joined #openstack-nova | 05:51 | |
*** mgoddard has joined #openstack-nova | 05:52 | |
*** oomichi has quit IRC | 05:53 | |
*** SourabhP_ has joined #openstack-nova | 05:54 | |
*** SourabhP has quit IRC | 05:54 | |
*** SourabhP_ is now known as SourabhP | 05:54 | |
*** stevemar has quit IRC | 05:55 | |
*** nelsnelson has quit IRC | 05:56 | |
*** e0ne has quit IRC | 05:56 | |
*** mgoddard has quit IRC | 05:58 | |
*** mgoddard has joined #openstack-nova | 05:58 | |
openstackgerrit | Pawel Koniszewski proposed openstack/nova-specs: Force live migration https://review.openstack.org/229040 | 05:59 |
*** twinklechawla has joined #openstack-nova | 06:03 | |
*** SourabhP has quit IRC | 06:03 | |
*** SourabhP has joined #openstack-nova | 06:06 | |
*** unicell has joined #openstack-nova | 06:06 | |
*** su_zhang_ has quit IRC | 06:07 | |
*** SourabhP has quit IRC | 06:13 | |
*** SourabhP has joined #openstack-nova | 06:14 | |
*** scheuran has joined #openstack-nova | 06:16 | |
*** twinklechawla has quit IRC | 06:16 | |
*** Venkatesh has joined #openstack-nova | 06:17 | |
*** twinklechawla has joined #openstack-nova | 06:17 | |
*** garyk has quit IRC | 06:18 | |
Venkatesh | johnthetubaguy : Can you review the patch https://review.openstack.org/#/c/212016/ | 06:18 |
Venkatesh | ? | 06:18 |
*** garyk1 has joined #openstack-nova | 06:18 | |
Venkatesh | I removed pass in abc method | 06:18 |
*** twinklechawla has quit IRC | 06:19 | |
*** twinklechawla has joined #openstack-nova | 06:21 | |
*** nkrinner has quit IRC | 06:22 | |
*** nkrinner has joined #openstack-nova | 06:22 | |
*** SourabhP has quit IRC | 06:23 | |
*** mgoddard has quit IRC | 06:23 | |
*** mgoddard has joined #openstack-nova | 06:24 | |
*** SourabhP has joined #openstack-nova | 06:25 | |
*** twinklechawla has quit IRC | 06:26 | |
*** vilobhmm111 has quit IRC | 06:29 | |
*** mragupat has quit IRC | 06:30 | |
openstackgerrit | Adelina Tuvenie proposed openstack/nova: Replace function.func_name with function.__name__ https://review.openstack.org/229578 | 06:36 |
*** medberry has quit IRC | 06:39 | |
*** mgoddard has quit IRC | 06:40 | |
*** mgoddard has joined #openstack-nova | 06:44 | |
*** med_ has joined #openstack-nova | 06:45 | |
*** med_ is now known as Guest43458 | 06:46 | |
*** mgoddard has quit IRC | 06:49 | |
*** rdopiera has joined #openstack-nova | 06:51 | |
*** crinkle has joined #openstack-nova | 06:51 | |
*** pm90_ has quit IRC | 06:51 | |
*** achanda has quit IRC | 06:51 | |
*** nelsnelson has joined #openstack-nova | 06:52 | |
*** mgoddard has joined #openstack-nova | 06:54 | |
*** romainh has joined #openstack-nova | 06:55 | |
*** nelsnelson has quit IRC | 06:57 | |
*** rdopiera has quit IRC | 06:58 | |
*** rdopiera has joined #openstack-nova | 06:58 | |
*** achanda has joined #openstack-nova | 06:59 | |
*** mgoddard has quit IRC | 07:00 | |
*** lpetrut has joined #openstack-nova | 07:03 | |
*** ganeshk has joined #openstack-nova | 07:05 | |
*** yasu has quit IRC | 07:06 | |
openstackgerrit | Angapov Vasily proposed openstack/nova: Added RBD direct image download scheme for Nova https://review.openstack.org/230295 | 07:07 |
ganeshk | hello, I created one controller and compute node on two vms. Then, created instance on each using "nova boot" from respective commad line. How do I conform that instance belong to particular node.? | 07:07 |
*** agireud has quit IRC | 07:08 | |
*** achanda has quit IRC | 07:10 | |
*** mgoddard has joined #openstack-nova | 07:12 | |
*** agireud has joined #openstack-nova | 07:13 | |
*** achanda has joined #openstack-nova | 07:15 | |
openstackgerrit | Angapov Vasily proposed openstack/nova: Added RBD direct image download scheme for Nova https://review.openstack.org/230295 | 07:15 |
rdopiera | ganeshk: if you do "server show" on the instance, it lists the name of its hypervisor | 07:18 |
*** jichen has joined #openstack-nova | 07:18 | |
*** Marga_ has quit IRC | 07:21 | |
*** mudassirlatif has quit IRC | 07:22 | |
ganeshk | rdopiera I took cirros image for instance. command not working | 07:22 |
ganeshk | rdopiera: | 07:25 |
*** SourabhP_ has joined #openstack-nova | 07:25 | |
*** SourabhP has quit IRC | 07:26 | |
*** SourabhP_ is now known as SourabhP | 07:26 | |
ganeshk | rdopiera: "virsh list --all" command is listing all instances on controller node. | 07:27 |
*** SourabhP has quit IRC | 07:34 | |
*** SourabhP has joined #openstack-nova | 07:36 | |
*** matrohon has joined #openstack-nova | 07:38 | |
*** jlanoux has joined #openstack-nova | 07:39 | |
ganeshk | Can anyone help me create an instance on specific compute node from controller node.? | 07:41 |
*** achanda has quit IRC | 07:42 | |
*** SourabhP has quit IRC | 07:43 | |
*** haomaiwang has joined #openstack-nova | 07:44 | |
*** mudassirlatif has joined #openstack-nova | 07:45 | |
*** yasu has joined #openstack-nova | 07:46 | |
*** openstackgerrit has quit IRC | 07:46 | |
*** openstackgerrit has joined #openstack-nova | 07:47 | |
*** garyk1 has quit IRC | 07:48 | |
rdopiera | ganeshk: what is "not working" exactly? | 07:50 |
ganeshk | server show | 07:50 |
rdopiera | what did you do exactly? | 07:51 |
ganeshk | ssh cirros@<ip of instance> | 07:52 |
ganeshk | server show | 07:52 |
*** nelsnelson has joined #openstack-nova | 07:53 | |
bauzas | ganeshk: mmm, see the topic name | 07:53 |
rdopiera | don't ssh into the instance, just run your 'openstack' command line, and do 'server list' then 'server show <UUID>' | 07:53 |
bauzas | ganeshk: you can use aggregates or AZs for choosing which compute node | 07:54 |
rdopiera | just like you did nova boot | 07:54 |
*** mgoddard has quit IRC | 07:54 | |
bauzas | good morning Nova btw. | 07:56 |
*** bauzas is now known as bauwser | 07:56 | |
*** haypo has joined #openstack-nova | 07:56 | |
*** SourabhP has joined #openstack-nova | 07:58 | |
*** nelsnelson has quit IRC | 07:58 | |
*** mgoddard has joined #openstack-nova | 07:58 | |
*** ganeshk has quit IRC | 07:59 | |
*** matrohon has quit IRC | 08:00 | |
*** haomaiwang has quit IRC | 08:01 | |
*** haomaiwa_ has joined #openstack-nova | 08:01 | |
*** stevemar_ has quit IRC | 08:01 | |
*** xgsa has joined #openstack-nova | 08:01 | |
*** matrohon has joined #openstack-nova | 08:01 | |
*** stevemar has joined #openstack-nova | 08:02 | |
bauwser | tonyb: still around, captain ? | 08:03 |
*** lpetrut has quit IRC | 08:03 | |
bauwser | tonyb: I need more insights on the Pillow issue (sounded very student pillow war to me) | 08:03 |
*** derekh has joined #openstack-nova | 08:04 | |
*** jichen has quit IRC | 08:04 | |
*** browne has quit IRC | 08:04 | |
bauwser | tonyb: so IIRC, merging https://review.openstack.org/#/c/230245/1 would help but it would need a rebase for any change? | 08:04 |
haypo | hi. dummy question: is master open for Mitaka? | 08:05 |
bauwser | haypo: yep, see setup.cfg | 08:05 |
haypo | bauwser: that's great, thanks | 08:05 |
*** jichen has joined #openstack-nova | 08:05 | |
bauwser | haypo: Liberty has a stable branch but is not yet released | 08:05 |
*** danpb has joined #openstack-nova | 08:06 | |
*** stevemar has quit IRC | 08:06 | |
haypo | bauwser: ah ok, i was waiting for the RC1, i expected the switch to mitaka to happen only after the RC1 | 08:06 |
*** alex_klimov has joined #openstack-nova | 08:07 | |
haypo | working on a stable branch makes sense, ok | 08:07 |
bauwser | haypo: http://lists.openstack.org/pipermail/openstack-dev/2015-September/075605.html | 08:07 |
bauwser | haypo: RC1 was released | 08:07 |
bauwser | haypo: for the moment, we leave operators to look at RC1 to create bugs if needed | 08:07 |
bauwser | and then the stable team will open the RC2 window (for merging the needed backports) | 08:08 |
haypo | bauwser: "RC1 was released" oops, i missed the announcement :-p | 08:08 |
bauwser | :) | 08:09 |
*** lpetrut has joined #openstack-nova | 08:13 | |
*** yasu has quit IRC | 08:15 | |
*** yasu has joined #openstack-nova | 08:16 | |
bauwser | johnthetubaguy: not sure you saw http://lists.openstack.org/pipermail/openstack-dev/2015-October/076030.html but we need https://review.openstack.org/#/c/230245/1 as a workaround for unbreaking the gate | 08:16 |
*** oomichi has joined #openstack-nova | 08:16 | |
bauwser | johnthetubaguy: then I'll rebase https://review.openstack.org/#/c/230132/ | 08:16 |
bauwser | johnthetubaguy: which is unblocking grenade IIRC | 08:17 |
*** pixelbeat has joined #openstack-nova | 08:18 | |
*** jichen has quit IRC | 08:18 | |
*** harlowja has quit IRC | 08:19 | |
*** kylek3h_ has joined #openstack-nova | 08:19 | |
*** jichen has joined #openstack-nova | 08:19 | |
bauwser | danpb: actually, it seems you're up too :) | 08:20 |
bauwser | danpb: if you can see the above ^, we need https://review.openstack.org/#/c/230245/1 to have Jenkins happy | 08:20 |
*** jichen has quit IRC | 08:21 | |
*** pedroalvarez has quit IRC | 08:21 | |
*** jichen has joined #openstack-nova | 08:21 | |
bauwser | ooooh, oomichi there too :D | 08:22 |
*** jichen has quit IRC | 08:22 | |
bauwser | oomichi: your help could be awesome for +2'ing https://review.openstack.org/#/c/230245/1 | 08:22 |
*** pedroalvarez has joined #openstack-nova | 08:22 | |
*** kylek3h has quit IRC | 08:22 | |
*** jichen has joined #openstack-nova | 08:22 | |
*** jichen has quit IRC | 08:23 | |
oomichi | bauwser: +A :) | 08:23 |
*** jichen has joined #openstack-nova | 08:23 | |
bauwser | cool | 08:23 |
*** jwcroppe has joined #openstack-nova | 08:23 | |
bauwser | oomichi: thanks :) | 08:24 |
*** jistr has joined #openstack-nova | 08:24 | |
*** ZZelle has quit IRC | 08:27 | |
*** mgoddard has quit IRC | 08:29 | |
*** ganeshk has joined #openstack-nova | 08:29 | |
*** SourabhP has quit IRC | 08:29 | |
ganeshk | I want to create an instance on compute node. Please help me some way to do that. | 08:30 |
*** kylek3h_ has quit IRC | 08:32 | |
*** mgoddard has joined #openstack-nova | 08:33 | |
*** alex_klimov has quit IRC | 08:34 | |
*** alex_klimov has joined #openstack-nova | 08:34 | |
*** kylek3h_ has joined #openstack-nova | 08:35 | |
*** mgoddard has quit IRC | 08:38 | |
*** jwcroppe has quit IRC | 08:40 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova-specs: Add notification for service status change https://review.openstack.org/182350 | 08:42 |
*** rotbeard has joined #openstack-nova | 08:43 | |
openstackgerrit | lyanchih proposed openstack/nova: libvirt - Unrescue will not remove rescue disk when image_type=rbd https://review.openstack.org/205766 | 08:43 |
*** alexschm has joined #openstack-nova | 08:44 | |
*** mgoddard has joined #openstack-nova | 08:47 | |
*** links has quit IRC | 08:50 | |
openstackgerrit | lyanchih proposed openstack/nova: libvirt: serial console ports count upper limit needs to be checked https://review.openstack.org/207373 | 08:50 |
johnthetubaguy | bauwser: sounds like thats been approved a few times now | 08:50 |
*** jichen has quit IRC | 08:50 | |
bauwser | johnthetubaguy: yup, oomichi did | 08:51 |
bauwser | johnthetubaguy: so I'm monitoring zuul to repropose https://review.openstack.org/#/c/230132/4 | 08:51 |
*** karimb has joined #openstack-nova | 08:51 | |
johnthetubaguy | oh, we always forget the alias | 08:52 |
*** jichen has joined #openstack-nova | 08:52 | |
bauwser | johnthetubaguy: yup, and AFAIU, it blocks grenade | 08:53 |
*** mgoddard has quit IRC | 08:53 | |
johnthetubaguy | it shouldn't | 08:53 |
johnthetubaguy | you can just use the version number | 08:53 |
johnthetubaguy | its just a helping hand | 08:54 |
bauwser | johnthetubaguy: I don't have the whole story, I saw something like that being discussed yesterday | 08:54 |
*** aix has joined #openstack-nova | 08:54 | |
johnthetubaguy | yeah, its not a hard fail, its just handy | 08:54 |
johnthetubaguy | I added this in here: https://wiki.openstack.org/wiki/Nova/ReleaseChecklist | 08:54 |
*** jichen has quit IRC | 08:54 | |
*** mgoddard has joined #openstack-nova | 08:54 | |
johnthetubaguy | its just nicer to set the name in the conf file rather than the number, but both should should, if I remember that all correctly | 08:55 |
openstackgerrit | lyanchih proposed openstack/nova: Add unit tests for libvirt fibrechannel/iser/iscsi/aoe volume drivers after os-brick https://review.openstack.org/208401 | 08:55 |
bauwser | (09:51:18) dims_: [22:42:25] sdague: mriedem: the grenade failed later - looks like we need to define liberty levels in master? (WIP - https://review.openstack.org/230132) | 08:55 |
bauwser | johnthetubaguy: ^ | 08:55 |
bauwser | johnthetubaguy: anyway, I don't want to overthink | 08:55 |
bauwser | johnthetubaguy: I was just wondering if a recheck was enough for https://review.openstack.org/#/c/230132/4 or if I should rebase | 08:56 |
*** BobBall has quit IRC | 08:56 | |
bauwser | johnthetubaguy: given a recheck picks the SHA on top of the latest master IIRC | 08:56 |
*** mudassirlatif has quit IRC | 08:56 | |
*** jichen has joined #openstack-nova | 08:57 | |
*** e0ne has joined #openstack-nova | 08:57 | |
*** jichen has quit IRC | 08:57 | |
tonyb | bauwser: Yeah, you wont need to rebase just recheck once 230245 merges | 08:58 |
*** jichen has joined #openstack-nova | 08:58 | |
bauwser | tonyb: okay, cool | 08:58 |
bauwser | tonyb: was there a e-r query ? | 08:58 |
tonyb | bauwser: but I'm not really here | 08:58 |
*** jichen has quit IRC | 08:58 | |
bauwser | at least a bug | 08:58 |
bauwser | tonyb: lol | 08:59 |
bauwser | enjoy your WE :) | 08:59 |
tonyb | bauwser: Yeah ther are both Matt made them I shoudl have done it :/ | 08:59 |
*** ssurana has quit IRC | 08:59 | |
bauwser | tonyb: cool, will find | 08:59 |
bauwser | tonyb: go off ! | 08:59 |
*** jichen has joined #openstack-nova | 08:59 | |
tonyb | https://review.openstack.org/#/c/230256/ | 09:00 |
tonyb | bauwser: ^^ | 09:00 |
*** haomaiwa_ has quit IRC | 09:01 | |
*** twinklechawla has joined #openstack-nova | 09:01 | |
*** twinklechawla has left #openstack-nova | 09:01 | |
bauwser | tonyb: coolness :) | 09:01 |
*** ganeshk has quit IRC | 09:01 | |
*** haomaiwang has joined #openstack-nova | 09:01 | |
*** markvoelker has joined #openstack-nova | 09:04 | |
*** markvoelker has quit IRC | 09:09 | |
openstackgerrit | Andreas Jaeger proposed openstack/nova: Cleanup of Translations https://review.openstack.org/230328 | 09:10 |
*** lpetrut has quit IRC | 09:10 | |
*** Madasi has quit IRC | 09:14 | |
*** rods has quit IRC | 09:14 | |
*** openstack has joined #openstack-nova | 09:22 | |
johnthetubaguy | yeah | 09:22 |
johnthetubaguy | thats the client though, I think? | 09:22 |
*** alexpilotti has quit IRC | 09:22 | |
*** e0ne has quit IRC | 09:23 | |
*** openstackstatus has joined #openstack-nova | 09:23 | |
*** ChanServ sets mode: +v openstackstatus | 09:23 | |
*** ndipanov has joined #openstack-nova | 09:23 | |
bauwser | johnthetubaguy: yup | 09:23 |
bauwser | johnthetubaguy: lemme find you mriedem's changes | 09:23 |
bauwser | johnthetubaguy: but he was waiting for doffm to work on supporting 2.6 too | 09:24 |
bauwser | (btw. pillow cap https://review.openstack.org/#/c/230245/1 is merged, anyone can resubmit a recheck) | 09:24 |
openstackgerrit | lyanchih proposed openstack/nova: Add unit tests for libvirt fibrechannel/iser/iscsi/aoe volume drivers after os-brick https://review.openstack.org/208401 | 09:25 |
bauwser | johnthetubaguy: https://review.openstack.org/#/c/230024/ | 09:26 |
bauwser | johnthetubaguy: and https://review.openstack.org/#/c/230149/1 for supporting the console changes with v2.6 | 09:26 |
johnthetubaguy | bauwser: ah, yeah, thats the ones I am on right now, cool | 09:29 |
*** marzif has joined #openstack-nova | 09:29 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova-specs: Add support for shared volumes between guests https://review.openstack.org/212508 | 09:30 |
bauwser | johnthetubaguy: oh, ttx +2/+W the RC2 proposed patches, that's cool | 09:30 |
*** e0ne has joined #openstack-nova | 09:31 | |
*** salv-orlando has quit IRC | 09:33 | |
gibi | lxsli: hi! could you check back to the butfix https://review.openstack.org/#/c/221803/? I answered your concerns. Thanks! | 09:34 |
alexschm | johnthetubaguy: do you have some time to discuss the "serial console and live migration" bugfix? | 09:34 |
alexschm | johnthetubaguy: https://review.openstack.org/#/c/215102/ | 09:34 |
*** gszasz has joined #openstack-nova | 09:35 | |
alexschm | johnthetubaguy: Markus outlined that the change will only allow a live migration when the patch is present on the source and target hypervisor, which is the ehavior we'd like to have | 09:35 |
*** nelsnelson has joined #openstack-nova | 09:36 | |
*** marzif has quit IRC | 09:37 | |
johnthetubaguy | alexschm: that breaks our upgrade process though | 09:37 |
*** marzif has joined #openstack-nova | 09:37 | |
alexschm | you mean the process of upgrading nova code? | 09:38 |
johnthetubaguy | alexschm: we support mixed versions of nova-compute during the upgrade, so during that time, live-migrate will be broken, which goes against our upgrade policy, as I understand it | 09:38 |
johnthetubaguy | alexschm: yes, during a live upgrade of nova | 09:38 |
johnthetubaguy | alexschm: you expand the DB, then roll the control plane to a new version (RPC pinned at old version), then slowly update each compute node, then unpin the control plane | 09:38 |
alexschm | yeah that's right, but live migration (when using serial console) is broken without the patch also | 09:38 |
alexschm | the bugfix enables it in the first place, so there should not be any existing user expecting live migration to work fine without the patch | 09:39 |
johnthetubaguy | alexschm: ah, good point, its broken before anyways, I just re-read, and I see we only touch the serial code path | 09:40 |
*** nelsnelson has quit IRC | 09:41 | |
johnthetubaguy | alexschm: oh wait... | 09:41 |
alexschm | johnthetubaguy: yes without the patch, the TCP ports used for serial console is not allocated on the target hypervisor, which can cause weird behvavior | 09:41 |
johnthetubaguy | alexschm: I missed a bit, it does seem like you would get a KeyError during the upgrade | 09:41 |
alexschm | the port may be in use on the target already and the bookkepping of ports that are in use is broken after the migration | 09:42 |
johnthetubaguy | alexschm: now just checking for the presence of the host key should be enough | 09:42 |
johnthetubaguy | alexschm: I mean for cases there there are no serial consoles | 09:42 |
johnthetubaguy | oh wait, thats nonsense | 09:42 |
alexschm | when there are no serial consoles, I think the attributes are not read from res_data, but let me check that again | 09:44 |
*** dims__ has joined #openstack-nova | 09:44 | |
johnthetubaguy | alexschm: so for a moment there, I was reading the setting of the attributes as reading, somehow | 09:46 |
johnthetubaguy | alexschm: yeah, sorry about the delay on that, I missed the bit about it only affecting previously broken code, so no need to jump through hoops trying to make it work | 09:46 |
alexschm | johnthetubaguy: ok | 09:47 |
*** xgsa has quit IRC | 09:47 | |
johnthetubaguy | alexschm: it would be cool if we could get serial ports enabled in the new mutli host test that is testing live-migrate now | 09:47 |
alexschm | johnthetubaguy: I looked through the code again and the attributes should only be read when serial console is enabled | 09:47 |
johnthetubaguy | alexschm: yeah, it looks like we are safe :) | 09:47 |
alexschm | johnthebuaguy: yeah I agree, not sure if VNC or spice is used there right now... | 09:48 |
*** Venkatesh_ has quit IRC | 09:48 | |
johnthetubaguy | alexschm: I would normally say add a note in the git commit message to say about that, but its not worth it given you would loose the +2 you already have on there | 09:48 |
*** Venkatesh_ has joined #openstack-nova | 09:48 | |
alexschm | johnthetubaguy: ok I'll think about the multi host test and check what's used there, it would be great to have a new test case there for live migration + serial console | 09:50 |
johnthetubaguy | alexschm: thanks, I am keen we stop breaking live-migrate soon! | 09:54 |
*** claudiub has joined #openstack-nova | 09:55 | |
*** xgsa has joined #openstack-nova | 09:56 | |
openstackgerrit | Daniel Berrange proposed openstack/nova-specs: Virtual guest device role tagging https://review.openstack.org/195662 | 09:58 |
*** haomaiwang has quit IRC | 10:01 | |
*** haomaiwang has joined #openstack-nova | 10:01 | |
openstackgerrit | Tomi Juvonen proposed openstack/nova-specs: Get valid server state https://review.openstack.org/192246 | 10:04 |
*** exploreshaifali has joined #openstack-nova | 10:06 | |
claudiub | mriedem: on? | 10:10 |
*** Venkatesh_ has quit IRC | 10:10 | |
*** twinklechawla has joined #openstack-nova | 10:12 | |
*** MarcF has joined #openstack-nova | 10:12 | |
*** pcaruana has joined #openstack-nova | 10:13 | |
claudiub | johnthetubaguy: hello. We have a problem, our hyper-v ci builds are failing because there is no python-novaclient 2.30.1 relase on pypi. | 10:14 |
claudiub | johnthetubaguy: although that release exists on github | 10:15 |
johnthetubaguy | claudiub: oh dear, thats interesting | 10:15 |
johnthetubaguy | claudiub: how do you pick what to install? | 10:15 |
johnthetubaguy | claudiub: most folks are just using pip I guess | 10:15 |
claudiub | johnthetubaguy: http://64.119.130.115/nova/228141/7/devstack_logs/stack.sh.txt.gz | 10:16 |
claudiub | johnthetubaguy: No matching distribution found for python-novaclient===2.30.1 (from -c /opt/stack/requirements/upper-constraints.txt (line 263)) | 10:16 |
*** twinklechawla has quit IRC | 10:16 | |
*** Guest3515 is now known as PaulMurray | 10:16 | |
*** IanGovett has joined #openstack-nova | 10:17 | |
johnthetubaguy | claudiub: just digging a little | 10:18 |
claudiub | johnthetubaguy: this is the patch to openstack/releases for python-novaclient 2.30.1: https://review.openstack.org/#/c/229952/ | 10:19 |
claudiub | johnthetubaguy: this is the patch to openstack/requirements, raising the upper-constraints to 2.30.1 https://review.openstack.org/#/c/229956/ | 10:19 |
johnthetubaguy | claudiub: yes, just digging into requrrements | 10:20 |
openstackgerrit | sulochan-acharya proposed openstack/nova: xapi-tools: fixes cache cleaner script https://review.openstack.org/209526 | 10:20 |
*** e0ne has quit IRC | 10:21 | |
johnthetubaguy | claudiub: so I got confused, thats only on the liberty branch, master still has 2.30.0 | 10:21 |
claudiub | johnthetubaguy: I thought master was on 2.31 | 10:22 |
claudiub | johnthetubaguy: and yeah, that's for liberty | 10:22 |
johnthetubaguy | its been released, but I don't think upper constraints have been raised | 10:22 |
johnthetubaguy | https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L260 | 10:22 |
*** jichen has quit IRC | 10:23 | |
claudiub | johnthetubaguy: 2.31.0 was tagged 18 hours ago | 10:23 |
bauwser | johnthetubaguy: yup I remember asking the question to mriedem, the .z version was for stable branches hence 2.30.1 for liberty and 2.31 for master | 10:23 |
*** jichen has joined #openstack-nova | 10:23 | |
*** jichen has quit IRC | 10:24 | |
claudiub | yeah, that's what i remember as well | 10:24 |
johnthetubaguy | claudiub: so is your pypi mirror out of date? | 10:24 |
johnthetubaguy | claudiub: the install seems to work OK for me, and I see this: https://pypi.python.org/packages/source/p/python-novaclient/python-novaclient-2.30.1.tar.gz | 10:24 |
*** jichen has joined #openstack-nova | 10:24 | |
johnthetubaguy | bauwser: we do actually use .Z on master as well at times | 10:24 |
claudiub | johnthetubaguy: let me check | 10:26 |
*** yasu has quit IRC | 10:26 | |
bauwser | johnthetubaguy: oh okay | 10:29 |
*** e0ne has joined #openstack-nova | 10:34 | |
*** mwagner_ has quit IRC | 10:34 | |
*** Daisy has joined #openstack-nova | 10:35 | |
*** jaypipes has joined #openstack-nova | 10:36 | |
johnthetubaguy | claudiub: found a way to list versions: https://pypi.python.org/simple/python-novaclient/ | 10:36 |
johnthetubaguy | bauwser: its just straight semver really, see 2.28.1 | 10:37 |
jaypipes | morning fellers. | 10:37 |
*** twinklechawla has joined #openstack-nova | 10:37 | |
johnthetubaguy | jaypipes: good morning | 10:37 |
*** gilliard_ has joined #openstack-nova | 10:37 | |
*** gilliard_ is now known as teamazing_logbot | 10:37 | |
PaulMurray | ndipanov, you there? I have a couple of questions about https://review.openstack.org/#/c/221732/ | 10:38 |
*** jaypipes is now known as leakypipes | 10:38 | |
claudiub | johnthetubaguy: awesome, thanks.can't check the cache right now, the people who have access to it are in the us, so will have to ping them in a couple of hours. | 10:38 |
johnthetubaguy | claudiub: doh, no worries | 10:38 |
*** exploreshaifali has quit IRC | 10:39 | |
*** Daisy has quit IRC | 10:40 | |
*** rdo has quit IRC | 10:41 | |
*** teamazing_logbot has left #openstack-nova | 10:42 | |
*** BobBall has joined #openstack-nova | 10:43 | |
*** rdo has joined #openstack-nova | 10:44 | |
sdague | so, all our patches are blocked because of a huge chain of dependencies for a single sequence diagram | 10:44 |
*** exploreshaifali has joined #openstack-nova | 10:45 | |
sdague | http://docs.openstack.org/developer/nova/vmstates.html the one at the bottom of that page | 10:45 |
sdague | johnthetubaguy: how do you feel about just commenting that diagram out for now | 10:45 |
sdague | because, I'm not sure it's hugely useful | 10:45 |
*** twinklechawla1 has joined #openstack-nova | 10:45 | |
johnthetubaguy | sdague: I think we had a fix in the pipe, but I am cool trying that too | 10:45 |
bauwser | sdague: the Pillow change just merged | 10:45 |
johnthetubaguy | yeah, I thought we just pinned it | 10:46 |
ndipanov | PaulMurray, yeeees | 10:46 |
bauwser | sdague: https://review.openstack.org/#/c/230245/1 | 10:46 |
sdague | doesn't seem to help | 10:46 |
sdague | look at the gate | 10:46 |
ndipanov | let me read the comments first | 10:46 |
sdague | we've got 2 things failing in the gate | 10:46 |
sdague | which should be consuming that | 10:46 |
johnthetubaguy | sdague: ah, if we are still broken, lets just comment it out | 10:47 |
ndipanov | ok there are no comments | 10:47 |
bauwser | sdague: tonyb's change makes the gate happy | 10:47 |
bauwser | sdague: so I wonder if it's just a matter of rebasing | 10:47 |
*** ndipanov is now known as ndipanoff | 10:47 | |
PaulMurray | ndipanov, hi - I get the feeling you didn't believe the use case? | 10:47 |
ndipanoff | the Windows one - I believe | 10:48 |
johnthetubaguy | bauwser: hmm, so that patch did seem happy, thats true | 10:48 |
ndipanoff | the failover one | 10:48 |
*** twinklechawla has quit IRC | 10:48 | |
PaulMurray | ndipanoff, but apart from that - I think you preferred the swap volume option | 10:48 |
ndipanoff | well I think it's a bit of a stretch to say - if only we had this feature in nova we could easily do this kind of thing | 10:48 |
bauwser | sdague: FWIW, asked just a recheck on https://review.openstack.org/#/c/230132/4 when tonyb's change mergede | 10:49 |
ndipanoff | PaulMurray, well | 10:49 |
sdague | bauwser: right, there are things in the gate | 10:49 |
ndipanoff | I don't like doing it this way | 10:49 |
sdague | that are failing | 10:49 |
sdague | those are already on top of that | 10:49 |
bauwser | sdague: but that's perhaps needing a rebase, not just a recheckl | 10:49 |
PaulMurray | ndipanoff, the use case has actually been implemented. They hack nova to make up for the fact it can't do it | 10:49 |
sdague | no, everything in the gate is rebased to master | 10:49 |
ndipanoff | PaulMurray, get some more people to comment | 10:50 |
bauwser | sdague: okay, I was lazy, I haven't checked zuul once the pillow cap merged, lemme look | 10:50 |
ndipanoff | but yes overall I prefer either doing shelve or adding a swap root volume | 10:50 |
PaulMurray | ndipanoff, swap sounds more possible - shelve can dismantle the infrastructure, so it defeats the objective. | 10:51 |
PaulMurray | ndipanoff, I am looking for the best way to acheive this, so very open to alternative suggestions | 10:51 |
PaulMurray | I realise there are issues to be dealt with | 10:51 |
*** frickler has quit IRC | 10:51 | |
johnthetubaguy | ndipanoff: PaulMurray: oh, swap root makes sense, I guess we stop users booting something without a disk attached that way? | 10:51 |
ndipanoff | yeah and probably a lot of other edge cases | 10:52 |
PaulMurray | johnthetubaguy, yes, it means there is always a disk | 10:52 |
ndipanoff | I really don't see what "flexibility" we lose | 10:52 |
bauwser | sdague: so, for the moment, I can't tell whether 230132,4 is okay since it hasn't yet checked the failing jobs | 10:52 |
PaulMurray | ndipanoff, not a lot I guess | 10:52 |
openstackgerrit | Angapov Vasily proposed openstack/nova: Added RBD direct image download scheme for Nova https://review.openstack.org/230295 | 10:53 |
sdague | bauwser: but you see all the fails at the top right | 10:53 |
bauwser | sdague: but 230132,4 is probably the first one rechecked *after* tonyb's change merged | 10:53 |
PaulMurray | ndipanoff, its to do with dictating when they move the disks and that the swap takes longer than just attach | 10:53 |
bauwser | sdague: yup yup | 10:53 |
sdague | bauwser: that means the fix doesn't work | 10:53 |
ndipanoff | PaulMurray, yeah I see in the doc | 10:53 |
PaulMurray | ndipanoff, so it increases the failover time | 10:53 |
bauwser | sdague: what I'm saying is that 230132 is the first that was rebased after the fix | 10:54 |
sdague | bauwser: no, what you are saying is that you don't understand how zuul works | 10:54 |
PaulMurray | ndipanoff, but I agree that it can be a reasonable compromise | 10:54 |
sdague | *everything* in the gate pipeline is rebased | 10:54 |
*** jichen has quit IRC | 10:54 | |
bauwser | sdague: okay, fair enough :) | 10:54 |
sdague | by zuul | 10:54 |
sdague | so it's mergable | 10:54 |
sdague | in one long rebase chain | 10:54 |
johnthetubaguy | yeah, its all rebase on top of each other so it can merged in parallallel right? | 10:54 |
johnthetubaguy | or something spelt correctly | 10:55 |
sdague | otherwise we wouldn't be guarunteed that we could actually merge after the tests run | 10:55 |
ndipanoff | PaulMurray, get some more opinions - I may be overestimating how big of an impact this will have | 10:55 |
bauwser | I see | 10:55 |
PaulMurray | ndipanoff, ok - thanks | 10:55 |
ndipanoff | what would be good is listing out what happens for all the nova operations | 10:55 |
*** ig0r_ has joined #openstack-nova | 10:55 | |
ndipanoff | so resize, delete, live-mig etc. | 10:55 |
*** jichen has joined #openstack-nova | 10:55 | |
*** jichen has quit IRC | 10:55 | |
sdague | unless something else is terribly broken here | 10:56 |
ndipanoff | how will this affect them | 10:56 |
bauwser | sdague: so, IIUC, 230132 is rebased on top of 228744 ? | 10:56 |
PaulMurray | ndipanoff, yes, I'll have a go | 10:56 |
sdague | yes | 10:56 |
ndipanoff | PaulMurray, excellent | 10:56 |
*** ig0r_ has quit IRC | 10:56 | |
sdague | well, right now, no | 10:56 |
sdague | because, 744 failed | 10:56 |
sdague | so it got pulled out of the rebase line | 10:56 |
bauwser | sdague: see, 230132 just passed pep8 | 10:56 |
*** e0ne has quit IRC | 10:57 | |
sdague | http://docs.openstack.org/infra/publications/zuul/#(18) | 10:57 |
bauwser | sdague: gotcha | 10:57 |
*** jichen has joined #openstack-nova | 10:57 | |
*** jichen has quit IRC | 10:58 | |
bauwser | sdague: since 230132 is now rebased on master containing the cap, we should be good while it was not the case previously because it was rebased on top of 744 which was on top of a master not containing the fix AFAICU | 10:58 |
sdague | right, but the fact that the other patches did not means something is way out of whack here, and this probably passed by accident given that not all images in all clouds are synced | 10:58 |
ndipanoff | johnthetubaguy, status code change does not need a microversion right? | 10:58 |
bauwser | okay | 10:58 |
sdague | bauwser: you still do not seem to understand that 744 is also on top of that patch | 10:59 |
johnthetubaguy | ndipanoff: it probably does, usually we add an alias to hide some changes like that | 10:59 |
sdague | the patches that are failing also have that patch in place | 10:59 |
ndipanoff | sigh | 10:59 |
johnthetubaguy | ndipanoff: mostly for the folks who don't expect that status to exist | 10:59 |
ndipanoff | johnthetubaguy, https://review.openstack.org/#/c/216746/ | 10:59 |
bauwser | sdague: okay, I trust you | 10:59 |
johnthetubaguy | ndipanoff: we don't want to break them | 10:59 |
*** takedakn has joined #openstack-nova | 10:59 | |
ndipanoff | it's 500 -> 404 in some obscure cases | 11:00 |
johnthetubaguy | ndipanoff: sorry, so we don't bump for those | 11:00 |
ndipanoff | as I thought | 11:00 |
*** jichen has joined #openstack-nova | 11:00 | |
*** jichen has quit IRC | 11:00 | |
*** eglynn has joined #openstack-nova | 11:00 | |
johnthetubaguy | ndipanoff: I thought you mean server/instance status for some reason | 11:00 |
bauwser | sdague: so, even if 744 is failing, 132 is still rebased on top of it, I see | 11:00 |
johnthetubaguy | ndipanoff: we did write that down somewhere, let me check | 11:00 |
ndipanoff | cool | 11:00 |
sdague | bauwser: no | 11:00 |
*** haomaiwang has quit IRC | 11:01 | |
sdague | the fix patch merged | 11:01 |
*** twinklechawla1 has quit IRC | 11:01 | |
*** haomaiwang has joined #openstack-nova | 11:01 | |
sdague | every nova patch in the gate is rebased on top of that | 11:01 |
bauwser | sdague: so we're good ? :) | 11:01 |
sdague | every nova patch in the gate is rebased on top of any nova patches in front of it | 11:01 |
sdague | bauwser: no, because we have 2 patches in the gate that are failing even with the fix applied | 11:02 |
johnthetubaguy | ndipanoff: http://docs.openstack.org/developer/nova/api_microversion_dev.html#f1 | 11:02 |
sdague | which means it's not a full fix | 11:02 |
bauwser | sdague: https://jenkins03.openstack.org/job/gate-nova-python27/2638/console was containing Pillow==3.0.0 | 11:03 |
bauwser | ^ is the 744 job | 11:04 |
ndipanoff | johnthetubaguy, thanks - makes a lot of sense | 11:04 |
*** markvoelker has joined #openstack-nova | 11:05 | |
johnthetubaguy | ndipanoff: in this case, I think everyone assumed 404 was one of the previous options, so its just a simple bug fix | 11:05 |
johnthetubaguy | ndipanoff: so yeah, I am with you on that | 11:06 |
johnthetubaguy | gmann: did you see your conversation there ^, does that sound correct? | 11:06 |
ndipanoff | awesome | 11:06 |
*** jichen has joined #openstack-nova | 11:07 | |
sdague | bauwser: yes, and what I'm saying is "THAT USED THE PATCH THAT TRIED TO PIN IT" | 11:07 |
sdague | because that's how zuul worked | 11:08 |
*** jichen has quit IRC | 11:08 | |
*** jichen has joined #openstack-nova | 11:08 | |
*** markvoelker has quit IRC | 11:09 | |
johnthetubaguy | sdague: lets just pull the dependency for now, and work this out later | 11:09 |
johnthetubaguy | sdague: I guess this also hits stable | 11:09 |
*** zz_john5223 is now known as john5223 | 11:11 | |
gmann | johnthetubaguy: hummm, so we assumed that 404 was expected code by user for this case even API never returned that. | 11:12 |
openstackgerrit | Sean Dague proposed openstack/nova: remove sphinxcontrib-seqdiag https://review.openstack.org/230373 | 11:12 |
*** jichen has joined #openstack-nova | 11:12 | |
sdague | gmann: 404 is always expected | 11:12 |
sdague | I thought we had a call out for that one | 11:12 |
sdague | 404 is resource not found, that's returned at higher levels all the time, and always something that needs to be expected | 11:13 |
gmann | sdague: for uri non-existcase? | 11:13 |
sdague | gmann: right, exactly | 11:13 |
gmann | sdague: yea, we missed that in our microversion doc :) | 11:14 |
*** ildikov has quit IRC | 11:14 | |
sdague | yeh, you want to patch that? | 11:14 |
gmann | sdague: yea, will put quickly | 11:14 |
bauwser | sdague: okay, thanks for your explanation, I see | 11:14 |
*** salv-orlando has joined #openstack-nova | 11:15 | |
sdague | bauwser: so, there could be other factors here, it's confusing at best | 11:15 |
bauwser | sdague: okay, I guess your point is good, we can temporarily remove the picture in http://docs.openstack.org/developer/nova/vmstates.html until we are sure that Pillow is either capped or fixed | 11:16 |
sdague | bauwser: right | 11:17 |
sdague | also... we should consider whether for 1 seq diagram it's worth requring a c compiler to build docs | 11:17 |
*** jichen has quit IRC | 11:17 | |
sdague | or if we should just build that as an svg | 11:18 |
bauwser | agreed | 11:18 |
bauwser | sounds a big stuff for just an easy diagram | 11:18 |
gmann | johnthetubaguy: is it fine comment on - https://review.openstack.org/#/c/216746/9/nova/api/openstack/compute/legacy_v2/contrib/floating_ips.py | 11:18 |
sdague | it's not even a great diagram | 11:18 |
sdague | I think it was mostly jogo experimenting with some things | 11:19 |
gmann | johnthetubaguy: actually for legacy it fix only index not all method as done on v2.1 | 11:19 |
*** salv-orlando has quit IRC | 11:20 | |
*** jichen has joined #openstack-nova | 11:22 | |
*** jichen has quit IRC | 11:22 | |
johnthetubaguy | sdague: we have some stuff passing in gate now, which is confusing, you thinking it could be cloud image specific? | 11:23 |
*** jichen has joined #openstack-nova | 11:23 | |
*** nelsnelson has joined #openstack-nova | 11:24 | |
openstackgerrit | jichenjc proposed openstack/nova-specs: Allow adjust ephemeral disks during resize https://review.openstack.org/145736 | 11:26 |
*** twinklechawla has joined #openstack-nova | 11:27 | |
*** twinklechawla has left #openstack-nova | 11:27 | |
johnthetubaguy | gmann: yeah, good spot, just changing my vote | 11:28 |
sdague | johnthetubaguy: it might be, there are various mirrors which may or may not be up to date, and various images that might have different stuff | 11:28 |
sdague | anyway, from the big picture perspective, it sems like a lot of infrastructure, for 1 diagram | 11:29 |
*** frickler has joined #openstack-nova | 11:29 | |
*** nelsnelson has quit IRC | 11:29 | |
johnthetubaguy | sdague: yeah, I see the passing ones installed 2.9.0 and the failures were still installing 3.0.0 but I have no idea why they were different | 11:30 |
johnthetubaguy | well we do have plans for more diagrams, but yes | 11:30 |
johnthetubaguy | gmann: I was looking at the unit tests, that appears to be covered, but missed in the code, how did that happen? | 11:30 |
openstackgerrit | jichenjc proposed openstack/nova: Add DiskFormat as Enum in fields https://review.openstack.org/229854 | 11:31 |
sdague | it was added here - https://github.com/openstack/nova/commit/7b352048bf4ddd5a475be8ae6542bd3b52ec1c70 | 11:31 |
sdague | it used to be an image | 11:31 |
sdague | it's new enough, there is no backport needed | 11:32 |
*** john5223 is now known as zz_john5223 | 11:32 | |
*** salv-orlando has joined #openstack-nova | 11:32 | |
sdague | it's funny, my review comments were "Long term I think the sequence diagram is just too busy to be useful here." | 11:33 |
*** zz_john5223 is now known as john5223 | 11:33 | |
sdague | I guess liberty backport | 11:33 |
sdague | if we go this route | 11:33 |
gmann | johnthetubaguy: oh yea, let me check, UT should fail | 11:33 |
johnthetubaguy | sdague: yeah, it seems a good option | 11:33 |
leakypipes | flaper87: http://bitly.com/tc-review-dashboard <-- this link has a problem with it.. | 11:33 |
sdague | leakypipes: under what browser? | 11:34 |
sdague | also, probably a -dev not nova topic | 11:34 |
leakypipes | sure, sorry | 11:35 |
* johnthetubaguy runs off for some lunch | 11:37 | |
*** jichen has quit IRC | 11:38 | |
*** jichen has joined #openstack-nova | 11:38 | |
openstackgerrit | Daniel Berrange proposed openstack/nova-specs: Virt image properties boot time override https://review.openstack.org/230382 | 11:39 |
*** aysyd has joined #openstack-nova | 11:40 | |
*** jichen has joined #openstack-nova | 11:42 | |
*** yassine_ has joined #openstack-nova | 11:42 | |
openstackgerrit | Ghanshyam Mann proposed openstack/nova: Add a note about the 500->404 not requiring a microversion https://review.openstack.org/230383 | 11:44 |
gmann | sdague: johnthetubaguy : for 404 in doc - https://review.openstack.org/230383 | 11:44 |
*** lpetrut has quit IRC | 11:46 | |
*** pcaruana has quit IRC | 11:47 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: Switch to oslo.cache lib https://review.openstack.org/203049 | 11:48 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: WIP: Use legacy engineFacade from oslo_db.enginefacade https://review.openstack.org/221310 | 11:52 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: WIP: use oslo_db.enginefacade https://review.openstack.org/225065 | 11:53 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: WIP: use oslo_db.enginefacade https://review.openstack.org/226788 | 11:53 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: WIP: use oslo_db.enginefacade https://review.openstack.org/228979 | 11:53 |
*** ZZelle has joined #openstack-nova | 11:57 | |
*** baoli has joined #openstack-nova | 11:57 | |
gmann | johnthetubaguy: got it for UT pass for legacy - https://review.openstack.org/#/c/216746/9/nova/tests/unit/api/openstack/compute/test_floating_ips.py | 11:59 |
*** baoli_ has joined #openstack-nova | 11:59 | |
gmann | johnthetubaguy: actually In those test, exception.FloatingIpPoolNotFound is thrown even before going to mocked "get_floating_ip_by_address" method. | 12:00 |
gmann | johnthetubaguy: which makes those tests pass for legacy also. | 12:00 |
gmann | johnthetubaguy: just put my comment on review | 12:00 |
*** haomaiwang has quit IRC | 12:01 | |
*** e0ne has joined #openstack-nova | 12:01 | |
openstackgerrit | Sergey Nikitin proposed openstack/nova: Remove get_all method from servicegroup API https://review.openstack.org/214629 | 12:01 |
*** haomaiwang has joined #openstack-nova | 12:01 | |
*** zul has quit IRC | 12:01 | |
openstackgerrit | Flavio Percoco proposed openstack/nova-specs: Complete nova support for Glance's v2 https://review.openstack.org/229891 | 12:02 |
*** baoli has quit IRC | 12:02 | |
*** zul has joined #openstack-nova | 12:04 | |
*** lpetrut has joined #openstack-nova | 12:05 | |
*** markvoelker has joined #openstack-nova | 12:05 | |
*** markvoelker has quit IRC | 12:09 | |
*** markvoelker has joined #openstack-nova | 12:09 | |
*** haomaiwang has quit IRC | 12:10 | |
*** 20WAB697A has joined #openstack-nova | 12:11 | |
johnthetubaguy | gmann: ah, so that would do it | 12:11 |
johnthetubaguy | gmann: thanks for digging! | 12:11 |
gmann | johnthetubaguy: np :) | 12:12 |
*** otter768 has quit IRC | 12:12 | |
*** ociuhandu has joined #openstack-nova | 12:13 | |
*** otter768 has joined #openstack-nova | 12:14 | |
*** exploreshaifali has quit IRC | 12:17 | |
*** MarcF has quit IRC | 12:17 | |
*** romainh has quit IRC | 12:18 | |
*** mwagner_ has joined #openstack-nova | 12:19 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: Switch to oslo.cache lib https://review.openstack.org/203049 | 12:20 |
*** romainh has joined #openstack-nova | 12:20 | |
*** MarcF has joined #openstack-nova | 12:21 | |
openstackgerrit | Claudiu Belu proposed openstack/nova: Hyper-V: adds os-win library https://review.openstack.org/212102 | 12:22 |
*** otter768 has quit IRC | 12:22 | |
*** otter768 has joined #openstack-nova | 12:23 | |
*** 20WAB697A has quit IRC | 12:25 | |
*** ociuhandu has quit IRC | 12:27 | |
*** VW has joined #openstack-nova | 12:29 | |
openstackgerrit | Timofey Durakov proposed openstack/nova: Wrap setup_networks_on_host with try/except https://review.openstack.org/227897 | 12:29 |
openstackgerrit | jichenjc proposed openstack/nova: Prevent build more than one default ephemeral disk https://review.openstack.org/213762 | 12:33 |
*** thumpba has joined #openstack-nova | 12:34 | |
openstackgerrit | Bartosz Fic proposed openstack/nova: Block migrate with attached volumes copies volumes to themselves https://review.openstack.org/227278 | 12:35 |
openstackgerrit | garyk proposed openstack/nova: VMware: raise NotImplementedError for live migration methods https://review.openstack.org/228893 | 12:36 |
*** edmondsw has joined #openstack-nova | 12:37 | |
*** VW has quit IRC | 12:40 | |
*** VW has joined #openstack-nova | 12:40 | |
*** jichen has quit IRC | 12:40 | |
*** VW has quit IRC | 12:41 | |
*** VW_ has joined #openstack-nova | 12:41 | |
*** jichen has joined #openstack-nova | 12:42 | |
*** MVenesio has joined #openstack-nova | 12:43 | |
*** jichen has quit IRC | 12:45 | |
*** ildikov has joined #openstack-nova | 12:46 | |
*** MVenesio_ has joined #openstack-nova | 12:47 | |
*** jichen has joined #openstack-nova | 12:48 | |
*** thumpba_ has joined #openstack-nova | 12:48 | |
*** VW_ has quit IRC | 12:48 | |
*** rfolco has joined #openstack-nova | 12:49 | |
*** VW has joined #openstack-nova | 12:49 | |
*** jichen has quit IRC | 12:49 | |
johnthetubaguy | sdague: I was just thinking, were those failed jobs earlier all stable branch ones? | 12:49 |
sdague | johnthetubaguy: oh, I don't know | 12:49 |
sdague | that's possible | 12:50 |
*** eharney has joined #openstack-nova | 12:50 | |
johnthetubaguy | we did just approve a bunch this morning, just dawned on me | 12:50 |
*** MVenesio has quit IRC | 12:50 | |
sdague | ah, ok, that might be it | 12:50 |
sdague | so, maybe the fix does work, it just needs backports | 12:51 |
sdague | that being said, I'm still not convinced the diagram is hugely useful | 12:51 |
johnthetubaguy | yeah, just backport the requirements pin (I guess that means we have not caught them all yet) | 12:52 |
bauwser | so, MHO is that #1 the fix is working *but* I agree with sdague we should remove that diagram and find another solution before reproviding it | 12:52 |
*** jichen has joined #openstack-nova | 12:52 | |
*** thumpba has quit IRC | 12:52 | |
sdague | yep | 12:52 |
johnthetubaguy | yeah, not arguing against that, its probably out of date by now anyways | 12:52 |
sdague | ok, here is the backport - https://review.openstack.org/#/c/230414/ | 12:53 |
*** VW has quit IRC | 12:53 | |
ndipanoff | danpb, hey if you have a sec - would appreciate your comment on this: https://bugs.launchpad.net/nova/+bug/1489442 | 12:54 |
openstack | Launchpad bug 1489442 in OpenStack Compute (nova) "Invalid order of volumes with adding a volume in boot operation" [Undecided,New] - Assigned to Feodor Tersin (ftersin) | 12:54 |
*** MVenesio_ has quit IRC | 12:54 | |
*** MVenesio has joined #openstack-nova | 12:55 | |
*** karimb has quit IRC | 12:56 | |
*** karimb has joined #openstack-nova | 12:56 | |
*** mdrabe has joined #openstack-nova | 12:56 | |
bauwser | btw. I just noticed something a bit funny | 12:56 |
*** dustins has joined #openstack-nova | 12:57 | |
bauwser | http://docs.openstack.org/developer/nova/vmstates.html vs. http://docs.openstack.org/developer/nova/devref/vmstates.html | 12:57 |
bauwser | the former is the master branch, the latter is 2015.1.1 | 12:57 |
bauwser | that's confusing but I don't get why we still have this | 12:57 |
bauwser | and all the pages are like this | 12:58 |
bauwser | like | 12:58 |
bauwser | http://docs.openstack.org/developer/nova/aggregates.html vs. http://docs.openstack.org/developer/nova/devref/aggregates.html | 12:59 |
*** salv-orlando has quit IRC | 12:59 | |
*** dave-mccowan has joined #openstack-nova | 13:00 | |
bauwser | johnthetubaguy: ^seen that ? any idea why ? | 13:00 |
bauwser | IIRC, devref was the former URL, so people who bookmarked it are stuck with the Kilo version | 13:01 |
*** bmotz has left #openstack-nova | 13:02 | |
*** ganeshk has joined #openstack-nova | 13:04 | |
*** jichen has quit IRC | 13:08 | |
*** rlrossit has joined #openstack-nova | 13:08 | |
*** xyang1 has joined #openstack-nova | 13:10 | |
*** pm90_ has joined #openstack-nova | 13:14 | |
*** karimb has quit IRC | 13:15 | |
*** raildo-afk is now known as raildo | 13:16 | |
johnthetubaguy | bauwser: I have a feeling the defref bit just never got deleted | 13:16 |
*** ctrath has joined #openstack-nova | 13:16 | |
johnthetubaguy | bauwser: would be good if you can try fix that with infra? | 13:16 |
bauwser | johnthetubaguy: sure, I'll discuss that with them | 13:16 |
openstackgerrit | garyk proposed openstack/nova-specs: VMware: expand opaque network support https://review.openstack.org/230425 | 13:17 |
*** asettle has joined #openstack-nova | 13:22 | |
*** karimb has joined #openstack-nova | 13:23 | |
*** VW has joined #openstack-nova | 13:23 | |
openstackgerrit | John Garbutt proposed openstack/nova: VMware: add support for provider network portgroup https://review.openstack.org/199477 | 13:25 |
*** haomaiwa_ has joined #openstack-nova | 13:25 | |
*** pm90__ has joined #openstack-nova | 13:25 | |
claudiub | johnthetubaguy: should we also put specs on that new mitaka priority tracking list? | 13:25 |
*** mriedem has joined #openstack-nova | 13:26 | |
*** mestery_ is now known as mestery | 13:26 | |
johnthetubaguy | claudiub: yes, please do, that should help them get more attention, there are two Hyper-V ones on there already | 13:26 |
*** Daisy has joined #openstack-nova | 13:27 | |
*** Daisy has quit IRC | 13:27 | |
claudiub | johnthetubaguy: oh, right, there are 2 lists: one for specs and one for nova commits. | 13:27 |
*** Daisy_ has joined #openstack-nova | 13:28 | |
sdague | bauwser: this has happened quite often actually, because we're just doing static publish and not a real cms, so deletes are all orphaned | 13:28 |
johnthetubaguy | claudiub: the general code list has a link to the spec specific stuff | 13:28 |
*** tpeoples has joined #openstack-nova | 13:28 | |
bauwser | sdague: yup, I'm just asking the question to -doc | 13:28 |
*** pm90_ has quit IRC | 13:28 | |
bauwser | sdague: ideally we should provide a .htacces redirect IMHO | 13:28 |
bauwser | to get devref pages calling ../ | 13:28 |
bauwser | I mean redirecting to | 13:29 |
claudiub | johnthetubaguy: yep, you're right, didn't see it. :) | 13:29 |
bauwser | sdague: but that would still probably need to remove devref directory | 13:29 |
johnthetubaguy | claudiub: no worries | 13:30 |
sdague | yeh, .htaccess redirects would be good | 13:30 |
*** amotoki has joined #openstack-nova | 13:30 | |
*** xnox has joined #openstack-nova | 13:31 | |
*** ijuwang has joined #openstack-nova | 13:32 | |
ganeshk | Hello, I setup controller node and compute node of contrail with devstack. Now, I am able to create instance in controller node, but, not able to create it on compute node. Can anyone understand this, Please help me with this. | 13:33 |
mriedem | ganeshk: see channel topic please | 13:35 |
*** Daisy_ has quit IRC | 13:37 | |
*** haomaiwa_ has quit IRC | 13:37 | |
*** Daisy has joined #openstack-nova | 13:38 | |
ganeshk | mriedem: Actually, I am using "nova boot" command to create instances. I thought, here I can get some help. | 13:38 |
*** haomaiwang has joined #openstack-nova | 13:38 | |
mriedem | this is not a support channel | 13:38 |
*** obedmr has joined #openstack-nova | 13:39 | |
ganeshk | mriedem: Ok. Thanks for that. | 13:39 |
*** nkrinner has quit IRC | 13:39 | |
*** mestery has quit IRC | 13:40 | |
*** Daisy has quit IRC | 13:42 | |
*** haomaiwang has quit IRC | 13:43 | |
*** haomaiwang has joined #openstack-nova | 13:44 | |
*** alaski is now known as lascii | 13:45 | |
mriedem | sdague: can you see if this is on the right track? https://review.openstack.org/#/c/230024/ - we were talking about backporting that to stable/liberty for the client | 13:45 |
sdague | mriedem: that seems fine to me | 13:47 |
mriedem | cool | 13:47 |
mriedem | doffm: has a patch up for supporting 2.6 but it needed functional tests | 13:47 |
mriedem | i'm not sure how easy those are going to be with the remote console API | 13:47 |
mriedem | https://review.openstack.org/#/c/230149/ | 13:47 |
sdague | it shouldn't be too bad, you don't have to test the remote console actually has things in it, you just need to make sure the API contract is working | 13:49 |
sdague | the current bug is because a resource is 404ing | 13:49 |
mriedem | yeah | 13:49 |
*** nelsnelson has joined #openstack-nova | 13:49 | |
*** stevemar has joined #openstack-nova | 13:50 | |
*** edleafe is now known as figleaf | 13:50 | |
*** stevemar has quit IRC | 13:50 | |
*** asettle has quit IRC | 13:51 | |
*** asettle has joined #openstack-nova | 13:51 | |
openstackgerrit | Daniel Berrange proposed openstack/nova-specs: Virtual instance rescue with stable disk devices https://review.openstack.org/230442 | 13:52 |
*** lykinsbd_ has quit IRC | 13:52 | |
*** jwcroppe has joined #openstack-nova | 13:52 | |
*** artom has joined #openstack-nova | 13:53 | |
*** ganeshk has left #openstack-nova | 13:53 | |
dansmith | are we still not out of the woods with the requirement thing? | 13:53 |
dims__ | dansmith: pillow got merged to both g-r and nova requirements i believe | 13:54 |
dansmith | oh, I might be looking at old results | 13:54 |
dansmith | ah, yep my bad | 13:55 |
*** rajesht has joined #openstack-nova | 13:55 | |
*** vladikr has joined #openstack-nova | 13:55 | |
*** rajesht has left #openstack-nova | 13:55 | |
*** mriedem1 has joined #openstack-nova | 13:55 | |
*** alejandrito has joined #openstack-nova | 13:55 | |
*** mriedem has quit IRC | 13:55 | |
*** asettle has quit IRC | 13:56 | |
*** asettle has joined #openstack-nova | 13:56 | |
*** asettle has quit IRC | 13:57 | |
*** vladikr has quit IRC | 13:59 | |
openstackgerrit | Daniel Berrange proposed openstack/nova-specs: Virtual guest device role tagging https://review.openstack.org/195662 | 14:00 |
*** jecarey has joined #openstack-nova | 14:00 | |
*** mriedem1 is now known as mriedem_meeting | 14:00 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Add checks for volume status when rebuilding https://review.openstack.org/217567 | 14:00 |
*** haomaiwang has quit IRC | 14:01 | |
*** lbeliveau has joined #openstack-nova | 14:01 | |
*** stevemar has joined #openstack-nova | 14:02 | |
tpeoples | Looking for reviews on https://review.openstack.org/#/c/220634/ if anyone has time; patch is small..thanks | 14:02 |
*** haomaiwa_ has joined #openstack-nova | 14:04 | |
openstackgerrit | Zhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails https://review.openstack.org/202379 | 14:04 |
lbeliveau | tpeoples: Will have a look, please have a look at https://review.openstack.org/#/c/216049/ if you have time | 14:05 |
*** stevemar_ has joined #openstack-nova | 14:05 | |
*** stevemar has quit IRC | 14:06 | |
*** asettle has joined #openstack-nova | 14:07 | |
lbeliveau | tpeoples: looks like you work on same problem, but provided a different fix | 14:08 |
*** takedakn1 has joined #openstack-nova | 14:08 | |
*** takedakn has quit IRC | 14:09 | |
*** takedakn1 is now known as takedakn | 14:09 | |
*** asettle has quit IRC | 14:09 | |
tpeoples | lbeliveau: yes, similar | 14:09 |
*** burgerk has joined #openstack-nova | 14:10 | |
*** rajesht has joined #openstack-nova | 14:11 | |
bauwser | dansmith: dims__: yup, all is okay | 14:11 |
bauwser | dims__: dansmith: https://review.openstack.org/#/c/230245/1 is merged | 14:11 |
*** jasond has joined #openstack-nova | 14:11 | |
bauwser | dims__: dansmith: https://review.openstack.org/#/c/230132/4 is merged too | 14:12 |
dansmith | bauwser: yeah, I was looking at the wrong set of results | 14:12 |
*** haomaiwa_ has quit IRC | 14:12 | |
*** ociuhandu has joined #openstack-nova | 14:12 | |
bauwser | ack | 14:12 |
bauwser | so rechecks should be okay | 14:12 |
*** haomaiwa_ has joined #openstack-nova | 14:13 | |
jasond | is discover_extensions preferred to list_extensions in novaclient? | 14:13 |
bauwser | but we discussed with sdague about removing the unnecessary diagram which created the problem | 14:13 |
*** rajesht has quit IRC | 14:14 | |
*** thumpba_ has quit IRC | 14:14 | |
*** dims__ has quit IRC | 14:14 | |
*** dims__ has joined #openstack-nova | 14:15 | |
lbeliveau | tpeoples: no offense, but next time please do a quick search in the bugs db to make sure if somebody haven't reported the problem before | 14:16 |
tpeoples | lbeliveau: your bug report has no mention of what mine does, i did search specifically for the pci_device_pools field since that is what i am concerned with | 14:18 |
*** kairo has joined #openstack-nova | 14:18 | |
*** bswartz has quit IRC | 14:18 | |
*** erhudy has joined #openstack-nova | 14:19 | |
*** su_zhang_ has joined #openstack-nova | 14:24 | |
tpeoples | lbeliveau: fwiw, lgtm. your change gets me what i need too | 14:25 |
jroll | hey friends, I have a fun liberty upgrade bug: https://bugs.launchpad.net/nova/+bug/1502177 | 14:25 |
openstack | Launchpad bug 1502177 in OpenStack Compute (nova) "Existing Ironic instances report negative available RAM for the node after upgrade " [Undecided,New] | 14:25 |
jroll | johnthetubaguy: ^ | 14:26 |
jroll | probably going to want to backport that, it can make an upgrade go real bad like | 14:26 |
*** takedakn has quit IRC | 14:26 | |
* jroll hacks on a patch | 14:27 | |
sdague | bauwser: ok, the stable/liberty backport bounced off requirements not being set yet, that's approved nwo | 14:27 |
*** thangp has joined #openstack-nova | 14:28 | |
lbeliveau | tpeoples: thanks, reviewed yours as well | 14:28 |
*** tonytan4ever has joined #openstack-nova | 14:28 | |
johnthetubaguy | jroll: OK, added the kilo-rc-potential tag, we have just opened RC2, thats likely to close on Tuesday, if that helps with timeframes | 14:28 |
*** exploreshaifali has joined #openstack-nova | 14:29 | |
jroll | johnthetubaguy: liberty-rc-potential? :) | 14:29 |
*** mgoddard_ has joined #openstack-nova | 14:29 | |
jroll | I have a fix, it's the unit tests that will be a pain, going to try to get that up today | 14:29 |
johnthetubaguy | jroll: lol, yeah | 14:30 |
*** mestery has joined #openstack-nova | 14:30 | |
* johnthetubaguy hides secret time machine | 14:31 | |
*** haomaiwa_ has quit IRC | 14:33 | |
*** mgoddard has quit IRC | 14:33 | |
*** rotbeard has quit IRC | 14:33 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/230467 | 14:34 |
*** electrocucaracha has joined #openstack-nova | 14:35 | |
*** haomaiwang has joined #openstack-nova | 14:35 | |
*** yamahata has joined #openstack-nova | 14:36 | |
*** bswartz has joined #openstack-nova | 14:36 | |
*** electrocucaracha has quit IRC | 14:37 | |
lascii | mriedem_meeting: for those security group tests with cells, they work because they don't attempt to use the security group for an instance. | 14:39 |
*** haomaiwang has quit IRC | 14:40 | |
lascii | the groups can be created/listed/deleted but it will only affect the top level cell. the failures happen when they can't be joined on the instance object within a child cell | 14:40 |
lascii | since they're not synced down | 14:40 |
*** electrocucaracha has joined #openstack-nova | 14:40 | |
*** signed8bit has joined #openstack-nova | 14:42 | |
*** tsekiyama has joined #openstack-nova | 14:43 | |
*** stevemar_ is now known as stevemar | 14:43 | |
dansmith | oh my manners | 14:44 |
*** dansmith is now known as superdan | 14:44 | |
*** karimb has quit IRC | 14:47 | |
dims__ | sdague: superdan: picked a random tox functional run and seems like it's not running anything - http://logs.openstack.org/01/208401/6/check/gate-nova-tox-functional/bd61b9f/console.html | 14:50 |
superdan | oh my | 14:50 |
bauwser | the "finished: SUCCESS" is pure awesomeness | 14:52 |
johnthetubaguy | :( | 14:52 |
johnthetubaguy | I thought we had a test to make sure we always run more than one test, maybe thats only for the unit tests? | 14:53 |
*** achanda has joined #openstack-nova | 14:53 | |
superdan | we did, yeah | 14:53 |
*** ociuhandu has quit IRC | 14:53 | |
*** pixelbeat has quit IRC | 14:54 | |
*** russellb is now known as rustlebee | 14:55 | |
sdague | mtreinish: ? | 14:55 |
*** pixelbeat has joined #openstack-nova | 14:55 | |
sdague | my guess, os-testr broke something | 14:55 |
mtreinish | sdague: that's baked into subunit-trace so it should be for anything using pretty-tox or ostestr | 14:56 |
dims__ | sdague: superdan: jjb bug per infra - gate-requirements-tox-validate was also not running anything | 14:56 |
sdague | oh, it's a jjb bug | 14:56 |
dims__ | y | 14:56 |
sdague | ok | 14:56 |
*** mtanino has joined #openstack-nova | 14:57 | |
mtreinish | sdague: heh, you had me worried I pushed an os-testr release yesterday | 14:57 |
mtreinish | that changed subunit-trace | 14:57 |
*** exploreshaifali has quit IRC | 14:58 | |
*** mgoddard_ has quit IRC | 14:58 | |
*** mgoddard has joined #openstack-nova | 14:58 | |
*** gszasz has quit IRC | 14:58 | |
*** mriedem_meeting is now known as mriedem | 14:59 | |
dims__ | mtreinish: :) | 14:59 |
mriedem | lascii: ok | 14:59 |
*** ccarmack has joined #openstack-nova | 14:59 | |
mtreinish | dims__: well, we didn't add any tests for that 1 liner so you never know | 14:59 |
*** jasond has left #openstack-nova | 14:59 | |
mriedem | lascii: i -1ed the tempest change since the compute api security group tests needed to be skipped if we have compute-feature-enabled.security_groups=False | 15:00 |
*** zzzeek has joined #openstack-nova | 15:00 | |
*** yamahata has quit IRC | 15:00 | |
*** yamahata has joined #openstack-nova | 15:00 | |
*** achanda has quit IRC | 15:01 | |
*** ociuhandu has joined #openstack-nova | 15:01 | |
lascii | yep | 15:01 |
*** andrewbogott has joined #openstack-nova | 15:02 | |
*** browne has joined #openstack-nova | 15:02 | |
*** Marga_ has joined #openstack-nova | 15:02 | |
*** ansiwen has quit IRC | 15:03 | |
*** Marga_ has quit IRC | 15:03 | |
*** takedakn has joined #openstack-nova | 15:04 | |
*** Marga_ has joined #openstack-nova | 15:04 | |
openstackgerrit | Daniel Berrange proposed openstack/nova-specs: Libvirt real time instances https://review.openstack.org/139688 | 15:05 |
danpb | johnthetubaguy: the only change in that real-time spec is to fix the URL, so can you +2 it again :-) | 15:05 |
*** lpetrut has quit IRC | 15:06 | |
*** pm90__ has quit IRC | 15:07 | |
*** Daisy has joined #openstack-nova | 15:08 | |
mriedem | baoli_: can you take a look at this? https://review.openstack.org/#/c/227160/ | 15:08 |
*** SourabhP has joined #openstack-nova | 15:09 | |
baoli_ | mriedem: sure | 15:09 |
*** kairo has quit IRC | 15:09 | |
johnthetubaguy | danpb: ah, sweet, re-applied | 15:09 |
*** SourabhP_ has joined #openstack-nova | 15:10 | |
*** electrocucaracha has quit IRC | 15:10 | |
openstackgerrit | Jim Rollenhagen proposed openstack/nova: Ironic: Fix bad capacity reporting if instance_info is unset https://review.openstack.org/230487 | 15:10 |
danpb | guess we'll need to have blitz on reviewing specs before the summit arrives | 15:10 |
*** rdopiera has quit IRC | 15:10 | |
*** artom has quit IRC | 15:11 | |
bauwser | jroll: just saw your ^ | 15:11 |
jroll | bauwser: yeah, still need to drop the fix in | 15:12 |
jroll | tis a fun one though | 15:12 |
jroll | bauwser: since I forgot it in commit message https://bugs.launchpad.net/nova/+bug/1502177 | 15:12 |
openstack | Launchpad bug 1502177 in OpenStack Compute (nova) "Existing Ironic instances report negative available RAM for the node after upgrade " [Undecided,New] | 15:12 |
*** matrohon has quit IRC | 15:12 | |
*** Daisy has quit IRC | 15:12 | |
bauwser | jroll: yeah, looking at the impact | 15:13 |
jroll | bauwser: well, it managed to make for a very long night last night when we deployed it :) | 15:13 |
*** lpetrut has joined #openstack-nova | 15:13 | |
*** SourabhP has quit IRC | 15:13 | |
bauwser | heh | 15:13 |
*** lsmola has quit IRC | 15:14 | |
*** rook has quit IRC | 15:15 | |
*** rook has joined #openstack-nova | 15:16 | |
*** SourabhP_ has quit IRC | 15:17 | |
*** rook has quit IRC | 15:17 | |
*** rook has joined #openstack-nova | 15:18 | |
*** obedmr has quit IRC | 15:19 | |
openstackgerrit | Jim Rollenhagen proposed openstack/nova: Ironic: Fix bad capacity reporting if instance_info is unset https://review.openstack.org/230487 | 15:20 |
*** davideagnello has joined #openstack-nova | 15:20 | |
jroll | bauwser: ^ with fix | 15:20 |
* jroll running tests locally and such | 15:21 | |
bauwser | jroll: I have an internal bug which is quite related, I need to understand more the previous fix in https://bugs.launchpad.net/ironic/+bug/1301279 | 15:21 |
openstack | Launchpad bug 1301279 in OpenStack Compute (nova) "Changing node's properties in Ironic after node is deployed will count as available resources in Nova" [Medium,Fix released] - Assigned to Zhenguo Niu (niu-zglinux) | 15:21 |
*** obedmr_ has joined #openstack-nova | 15:22 | |
bauwser | jroll: what do mean Ironic properties ? | 15:22 |
jroll | bauwser: so a node object in ironic has node.properties[memory_mb], etc, in the DB | 15:22 |
jroll | that's what the RT reads for resources | 15:22 |
bauwser | jroll: that's what I understand | 15:22 |
bauwser | jroll: is it set by the operator ? | 15:22 |
jroll | yes | 15:23 |
bauwser | jroll: okay, is it modified later ? the bug reports it's possible | 15:23 |
jroll | that previous bug fixes a case where, you deploy an instance. while the instance is deployed, you change memory_mb in ironic. now nova says that node has some free RAM | 15:23 |
jroll | right, so I don't understand at all why an operator would modify it later, but apparently someone did and ran into this bug | 15:23 |
*** obedmr_ has quit IRC | 15:23 | |
jroll | seems silly to me | 15:23 |
*** alexschm has quit IRC | 15:24 | |
jroll | but in a pet environment, someone might ask to upgrade RAM on an existing deployed box | 15:24 |
jroll | the most manual of resizes :D | 15:24 |
*** romainh has quit IRC | 15:24 | |
*** takedakn has quit IRC | 15:24 | |
*** SourabhP has joined #openstack-nova | 15:25 | |
jroll | bauwser: I'm really sad this bit me, because I pointed it out on the review, but I trusted people instead of testing myself :( | 15:25 |
*** ctrath1 has joined #openstack-nova | 15:25 | |
bauwser | jroll: okay I see | 15:26 |
*** hemnafk is now known as hemna | 15:27 | |
*** pm90_ has joined #openstack-nova | 15:28 | |
*** ctrath has quit IRC | 15:28 | |
mriedem | gah | 15:28 |
mriedem | is there a change up for that Pillow thing? | 15:28 |
*** pm90__ has joined #openstack-nova | 15:29 | |
dims__ | mriedem: g-r master + liberty yes, nova master yes | 15:29 |
mriedem | is the nova master change merged? | 15:29 |
mriedem | what requires Pillow anyway? | 15:30 |
*** jdurgin1 has joined #openstack-nova | 15:30 | |
jroll | mriedem: sphinxcontrib-seqdiag | 15:31 |
mriedem | hells bells | 15:31 |
jroll | and yeah, master is merged | 15:31 |
*** pm90_ has quit IRC | 15:32 | |
bauwser | jroll: tbc, there can be only one instance per ironic node, right ? the winner takes all ? | 15:32 |
jroll | bauwser: correct | 15:33 |
mriedem | we should move the deps from test-requirements that are needed to build nova docs and slap those into setup.cfg with an [extras] thing | 15:33 |
mriedem | so that docs dependencies don't break unit test runs | 15:33 |
bauwser | mriedem: see Vek comment on the ML | 15:33 |
danpb | mriedem: sdague suggested on the list its better if we just kill off use of pillow entirely | 15:34 |
mriedem | sure, but, still | 15:34 |
mriedem | we could do both | 15:34 |
bauwser | and I agree with sdague, until we find a better solution | 15:34 |
*** lpetrut has quit IRC | 15:36 | |
openstackgerrit | Dan Smith proposed openstack/nova-specs: Stay consistent with the word "flavor" https://review.openstack.org/230498 | 15:36 |
openstackgerrit | Dan Smith proposed openstack/nova-specs: Fix misspellings of "scheduler" https://review.openstack.org/230499 | 15:36 |
danpb | superdan: lol, thanks for fixing my engrish :-) | 15:37 |
superdan | danpb: :) | 15:37 |
mriedem | did you check for colour? | 15:37 |
mriedem | or 'shedular' (more the pronunciation than the spelling) | 15:38 |
danpb | who wants to write a unit test to check spelling :-) | 15:38 |
*** thumpba has joined #openstack-nova | 15:38 | |
*** thumpba has quit IRC | 15:38 | |
mriedem | omg i made that joke before seeing https://review.openstack.org/#/c/230499/ | 15:38 |
*** scheuran has quit IRC | 15:39 | |
*** thumpba has joined #openstack-nova | 15:39 | |
superdan | mriedem: I did, no colours :) | 15:40 |
superdan | mriedem: re your comment, at least I'm taking responsibility for my OCD | 15:41 |
mriedem | heh | 15:41 |
mriedem | unclean, UNCLEAN! | 15:42 |
mriedem | it's fine. my 4 year old daughter aligns her placemats at right angles already. i'm pretty sure she got that from me. | 15:42 |
*** MarcF has quit IRC | 15:42 | |
*** alex_klimov has quit IRC | 15:44 | |
openstackgerrit | Dan Smith proposed openstack/nova-specs: Fix misspellings of "scheduler" https://review.openstack.org/230499 | 15:44 |
openstackgerrit | Dan Smith proposed openstack/nova-specs: Stay consistent with the word "flavor" https://review.openstack.org/230498 | 15:44 |
claudiub | johnthetubaguy: still around? | 15:45 |
*** mgoddard_ has joined #openstack-nova | 15:45 | |
*** VW has quit IRC | 15:45 | |
*** VW has joined #openstack-nova | 15:46 | |
*** obedmr has joined #openstack-nova | 15:47 | |
*** jlanoux has quit IRC | 15:47 | |
*** electrocucaracha has joined #openstack-nova | 15:47 | |
*** PaulMurray is now known as ptm_away | 15:47 | |
*** ptm_away has quit IRC | 15:48 | |
*** mgoddard has quit IRC | 15:48 | |
*** VW has quit IRC | 15:50 | |
*** VW has joined #openstack-nova | 15:50 | |
*** tsekiyama has quit IRC | 15:50 | |
*** lpetrut has joined #openstack-nova | 15:51 | |
*** SourabhP has quit IRC | 15:52 | |
*** amotoki has quit IRC | 15:56 | |
*** jecarey has quit IRC | 15:56 | |
*** mgoddard_ has quit IRC | 15:58 | |
*** mgoddard has joined #openstack-nova | 15:58 | |
*** su_zhang_ has quit IRC | 15:58 | |
*** ijw has joined #openstack-nova | 15:59 | |
*** sajeesh has joined #openstack-nova | 16:01 | |
superdan | ccarmack: 1501558 | 16:04 |
superdan | oops | 16:04 |
superdan | ccarmack: https://review.openstack.org/#/c/230227 | 16:04 |
ccarmack | thanks...looking | 16:04 |
*** jogo is now known as flashgordon | 16:05 | |
johnthetubaguy | claudiub: hey, sorry, was in a call about defcore fun, can I help? | 16:06 |
openstackgerrit | Jim Rollenhagen proposed openstack/nova: Ironic: Fix bad capacity reporting if instance_info is unset https://review.openstack.org/230487 | 16:06 |
*** artom has joined #openstack-nova | 16:07 | |
*** artom has quit IRC | 16:07 | |
*** artom has joined #openstack-nova | 16:07 | |
*** lpetrut has quit IRC | 16:08 | |
*** lpetrut has joined #openstack-nova | 16:08 | |
*** jdurgin1 has quit IRC | 16:09 | |
*** haypo has left #openstack-nova | 16:09 | |
*** salv-orlando has joined #openstack-nova | 16:11 | |
ccarmack | superdan: I just had one nitty comment | 16:12 |
*** eglynn has quit IRC | 16:13 | |
superdan | ccarmack: well, I see your point, but I was going for what is there | 16:13 |
superdan | if you expand it, | 16:13 |
superdan | your way would be like this: | 16:13 |
superdan | This service version v2 is older than the minimum version (v3) of the rest of the deployment | 16:13 |
*** artom has quit IRC | 16:13 | |
superdan | I was trying to avoid the "version vX" alliteration, | 16:14 |
superdan | although I see it's there for the minimum one | 16:14 |
superdan | so maybe I'll just leave the version word in both places and remove the 'v' prefix to X | 16:14 |
ccarmack | superdan: I'm a grammar guy, but v2 isn't a service, its a version | 16:14 |
*** apoorvad has joined #openstack-nova | 16:14 | |
ccarmack | I'm *not | 16:14 |
*** artom has joined #openstack-nova | 16:15 | |
superdan | right, but if you remove the parenthetical it reads "this service is older..." | 16:15 |
superdan | but yeah I see what you mean | 16:15 |
superdan | hang on let me try something | 16:15 |
ccarmack | yea, remove the 'v' prefix | 16:15 |
superdan | well, or this: | 16:16 |
superdan | "This service is older (v2) than the minimum (v3) version of the rest of the deployment" | 16:16 |
*** karimb has joined #openstack-nova | 16:16 | |
ccarmack | that looks good also | 16:16 |
superdan | removing the v would work too, but I worry about people not realizing that the numbers are the versions | 16:16 |
ccarmack | I like that | 16:16 |
superdan | okay, let's go with that | 16:16 |
ccarmack | ok | 16:17 |
bauwser | sdague: meh https://review.openstack.org/#/c/230414/ | 16:17 |
*** ssurana has joined #openstack-nova | 16:17 | |
*** SourabhP has joined #openstack-nova | 16:17 | |
bauwser | sdague: g-r is not updated with the Pillow cap, right? | 16:18 |
openstackgerrit | Dan Smith proposed openstack/nova: Extend the ServiceTooOld exception with more data https://review.openstack.org/230227 | 16:18 |
superdan | ccarmack: ^ | 16:18 |
*** vishwanathj has joined #openstack-nova | 16:18 | |
ccarmack | superdan: +1'd it | 16:19 |
superdan | ccarmack: thanks :) | 16:19 |
ccarmack | yup | 16:20 |
*** emagana has joined #openstack-nova | 16:22 | |
*** nic has joined #openstack-nova | 16:22 | |
*** tonytan4ever has quit IRC | 16:22 | |
*** ZZelle has quit IRC | 16:23 | |
*** mudassirlatif has joined #openstack-nova | 16:23 | |
*** salv-orlando has quit IRC | 16:24 | |
*** emagana_ has joined #openstack-nova | 16:25 | |
*** tjones has joined #openstack-nova | 16:25 | |
*** tonytan4ever has joined #openstack-nova | 16:26 | |
*** emagana has quit IRC | 16:27 | |
*** SourabhP_ has joined #openstack-nova | 16:27 | |
*** unicell1 has joined #openstack-nova | 16:28 | |
*** SourabhP has quit IRC | 16:28 | |
*** Daisy has joined #openstack-nova | 16:29 | |
*** unicell has quit IRC | 16:29 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/230467 | 16:29 |
*** e0ne has quit IRC | 16:31 | |
sdague | bauwser: we just approved it | 16:31 |
bauwser | sdague: ack | 16:31 |
claudiub | johnthetubaguy: sorry, didn't see your reply. | 16:31 |
johnthetubaguy | claudiub: no problems | 16:31 |
claudiub | johnthetubaguy: so, we have an interesting... problem... | 16:31 |
bauwser | sdague: my ping was just for helping you in case you forgot to provide the patch to g-r :) | 16:32 |
sdague | bauwser: so it should work if you recheck it now | 16:32 |
*** diogogmt has joined #openstack-nova | 16:32 | |
bauwser | sdague: cool, doing it | 16:32 |
*** SourabhP_ has quit IRC | 16:32 | |
claudiub | johnthetubaguy: so, there is a scenario where spawning isntances on a host will fail, even though the scheduler says it's a good node for that instance | 16:32 |
johnthetubaguy | claudiub: yes, seen that with XenServer too actually | 16:33 |
sdague | bauwser: yeh, merged - https://review.openstack.org/#/c/230228/ 17 minutes ago | 16:33 |
claudiub | johnthetubaguy: so, Hyper-V creates a memory file on the local disk, for each instance, and it has the size of the allocated memory | 16:33 |
johnthetubaguy | claudiub: oh, is that for suspend or something? | 16:33 |
claudiub | johnthetubaguy: so, spawning instances with large disks, plus large-ish memory, will end up with not having enough local disk | 16:34 |
johnthetubaguy | claudiub: ah, gotcha | 16:34 |
johnthetubaguy | claudiub: I think you might need to implement this virt driver method: https://github.com/openstack/nova/blob/master/nova/virt/xenapi/driver.py#L157 | 16:35 |
johnthetubaguy | claudiub: although, that doesn't actually help the scheduler right now | 16:35 |
johnthetubaguy | claudiub: but it should fix the resource tracker | 16:35 |
claudiub | johnthetubaguy: I was thinking, maybe hyper-v is not the only one that does this kind of thing. i think vmware also does this. can we maybe add a config option, like: driver_creates_vm_mem_file or something more catchy, and use that in the resource tracker? | 16:37 |
claudiub | johnthetubaguy: to update the used local disk to be instance's disk size + instance memory size | 16:37 |
claudiub | johnthetubaguy: + ephemeral | 16:37 |
johnthetubaguy | claudiub: can't you just do something similar to that above method? https://github.com/openstack/nova/blob/master/nova/virt/xenapi/driver.py#L157 | 16:37 |
johnthetubaguy | claudiub: just its for disk and not memory, in your case | 16:38 |
claudiub | johnthetubaguy: it seems that method :returns: memory overhead | 16:39 |
*** ociuhandu has quit IRC | 16:39 | |
claudiub | johnthetubaguy: yeah, we're interested in the disk part. | 16:39 |
johnthetubaguy | claudiub: yeah, just return the disk part | 16:39 |
*** ansiwen has joined #openstack-nova | 16:39 | |
claudiub | johnthetubaguy: ok, will have to see how is that being used and if it helps solve the issue. Thanks. :D | 16:39 |
*** karmatronic has joined #openstack-nova | 16:39 | |
*** karmatronic has quit IRC | 16:39 | |
*** karmatronic has joined #openstack-nova | 16:39 | |
johnthetubaguy | claudiub: we added that for memory overhead in Xen, its more critical for us because we don't use any memory overcommit or page sharing | 16:40 |
johnthetubaguy | claudiub: just for context | 16:40 |
*** kairo has joined #openstack-nova | 16:40 | |
johnthetubaguy | claudiub: I suspect it needs a tweak, but it seems very close: https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L172 | 16:40 |
johnthetubaguy | claudiub: https://github.com/openstack/nova/blob/master/nova/compute/claims.py#L98 | 16:41 |
*** penick has joined #openstack-nova | 16:41 | |
claudiub | johnthetubaguy: yeah, I think that might work. I'll create a bug report for this and upload a commit for it. Thanks for the help. :) | 16:41 |
johnthetubaguy | claudiub: no worries | 16:41 |
johnthetubaguy | claudiub: so there is a follow on bit, where you might need the scheduler to do a better estimation, but the retry loops and things should mean thats enough most of the time, I think | 16:43 |
*** kairo_ has joined #openstack-nova | 16:45 | |
*** vilobhmm11 has joined #openstack-nova | 16:45 | |
*** kairo has quit IRC | 16:45 | |
bauwser | a possible regression found https://bugs.launchpad.net/nova/+bug/1501914 | 16:45 |
openstack | Launchpad bug 1501914 in OpenStack Compute (nova) "Liberty devstack failed to launch instance w/ NetApp eSeries." [Undecided,New] | 16:45 |
bauwser | mriedem: ^ do you think it could be related with os-brick ? | 16:46 |
*** kairo_ has quit IRC | 16:48 | |
*** diogogmt_ has joined #openstack-nova | 16:48 | |
*** dims__ is now known as dimsum__ | 16:49 | |
bauwser | I'm not a bdm expert and I need to go, if any people could just check it's not a regression... :) | 16:49 |
*** diogogmt has quit IRC | 16:50 | |
bauwser | mriedem: nevermind the os-brick question, it was silly | 16:51 |
*** diogogmt_ has quit IRC | 16:53 | |
*** yamahata has quit IRC | 16:53 | |
*** tonytan4ever has quit IRC | 16:53 | |
bauwser | ndipanoff: not sure you saw the above ^ | 16:54 |
*** kairo has joined #openstack-nova | 16:55 | |
johnthetubaguy | bauwser: that sounds a bit like the client issue again | 16:55 |
*** davideagnello has quit IRC | 16:56 | |
*** apuimedo has quit IRC | 16:56 | |
*** amotoki has joined #openstack-nova | 16:56 | |
*** john5223 is now known as zz_john5223 | 16:57 | |
bauwser | johnthetubaguy: I'm definitely not a good person for a volume problem, hence me passing :) | 16:59 |
bauwser | johnthetubaguy: but it sounds a regression, as the reporter verified | 16:59 |
johnthetubaguy | bauwser: so I took a quick peak, it looks like cinder failed to create the volume, so it seems like it could be an non-nova issue | 16:59 |
*** Marga_ has quit IRC | 16:59 | |
bauwser | johnthetubaguy: that was one of my thoughts, could you move the project? | 17:00 |
*** diogogmt has joined #openstack-nova | 17:00 | |
johnthetubaguy | bauwser: I just marked it as incomplete for now, till thats confirmed | 17:00 |
bauwser | johnthetubaguy: ack, thanks | 17:00 |
johnthetubaguy | its possible we send the wrong request, I guess | 17:00 |
bauwser | johnthetubaguy: oh ok, so we're polling the state in Cinder | 17:01 |
bauwser | johnthetubaguy: I thought it was a nova check | 17:01 |
bauwser | johnthetubaguy: or is it a callback ? | 17:01 |
bauwser | just for my knowledge | 17:01 |
*** harlowja has joined #openstack-nova | 17:01 | |
johnthetubaguy | I think thats the bit where we are creating a volume in cinder, and polling to see if its completed | 17:01 |
*** davideagnello has joined #openstack-nova | 17:01 | |
bauwser | okay | 17:01 |
*** amotoki has quit IRC | 17:01 | |
bauwser | anyway, need to silently walk away from keyboard | 17:02 |
bauwser | weekend, folks | 17:02 |
*** electrocucaracha has quit IRC | 17:02 | |
*** yassine_ has quit IRC | 17:03 | |
*** tonytan4ever has joined #openstack-nova | 17:03 | |
*** tjones has left #openstack-nova | 17:04 | |
openstackgerrit | Chuck Carmack proposed openstack/nova: Make the server group invalid format message more verbose https://review.openstack.org/218468 | 17:04 |
*** danpb has quit IRC | 17:04 | |
*** signed8bit has quit IRC | 17:05 | |
*** vilobhmm11 has quit IRC | 17:05 | |
*** electrocucaracha has joined #openstack-nova | 17:07 | |
*** lpetrut has quit IRC | 17:08 | |
*** signed8bit has joined #openstack-nova | 17:08 | |
*** tpeoples has quit IRC | 17:09 | |
*** jistr has quit IRC | 17:10 | |
*** READ10 has joined #openstack-nova | 17:13 | |
*** ociuhandu has joined #openstack-nova | 17:14 | |
*** achanda has joined #openstack-nova | 17:16 | |
*** su_zhang_ has joined #openstack-nova | 17:17 | |
johnthetubaguy | bauwser: have a good one, I should do the same now | 17:18 |
*** derekh has quit IRC | 17:18 | |
*** yamahata has joined #openstack-nova | 17:18 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/230467 | 17:19 |
*** ctrath has joined #openstack-nova | 17:19 | |
*** ctrath1 has quit IRC | 17:19 | |
*** Daisy has quit IRC | 17:20 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient: Updated from global requirements https://review.openstack.org/230583 | 17:20 |
*** vishwanathj is now known as vishwanathj_ | 17:20 | |
*** Daisy has joined #openstack-nova | 17:21 | |
*** ociuhandu has quit IRC | 17:22 | |
*** nelsnelson has quit IRC | 17:25 | |
openstackgerrit | Chuck Carmack proposed openstack/nova: XMake the server group invalid format message more verbose https://review.openstack.org/218468 | 17:25 |
*** Daisy has quit IRC | 17:26 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/nova: Updated from global requirements https://review.openstack.org/230467 | 17:26 |
*** vishwanathj_ is now known as vishwanathj | 17:27 | |
*** mriedem has quit IRC | 17:28 | |
*** aysyd has quit IRC | 17:29 | |
*** aysyd has joined #openstack-nova | 17:29 | |
*** ildikov has quit IRC | 17:31 | |
*** mdrabe has quit IRC | 17:31 | |
*** mriedem has joined #openstack-nova | 17:32 | |
*** SourabhP has joined #openstack-nova | 17:33 | |
*** SourabhP has quit IRC | 17:34 | |
*** SourabhP has joined #openstack-nova | 17:35 | |
*** Marga_ has joined #openstack-nova | 17:36 | |
*** lhcheng has joined #openstack-nova | 17:36 | |
lhcheng | hello, what's the difference between discover_extension and list_extensions in novaclient? | 17:37 |
*** ChanServ has quit IRC | 17:37 | |
*** ijw has quit IRC | 17:38 | |
*** SourabhP_ has joined #openstack-nova | 17:38 | |
*** SourabhP has quit IRC | 17:39 | |
*** SourabhP_ is now known as SourabhP | 17:39 | |
superdan | johnthetubaguy: still around? | 17:40 |
*** ChanServ has joined #openstack-nova | 17:40 | |
*** cameron.freenode.net sets mode: +o ChanServ | 17:40 | |
*** browne has quit IRC | 17:42 | |
*** browne has joined #openstack-nova | 17:42 | |
mriedem | sdague: so we want to bring https://review.openstack.org/#/c/230024/ back to stable/liberty and release as 2.30.2 right? | 17:43 |
*** vilobhmm11 has joined #openstack-nova | 17:44 | |
*** vilobhmm111 has joined #openstack-nova | 17:46 | |
*** anish__ is now known as anish | 17:47 | |
*** SourabhP has quit IRC | 17:47 | |
*** burt has quit IRC | 17:49 | |
*** vilobhmm11 has quit IRC | 17:49 | |
*** burt has joined #openstack-nova | 17:49 | |
*** SourabhP has joined #openstack-nova | 17:51 | |
ccarmack | mriedem: I replied to your comments on https://review.openstack.org/#/c/225199/ - FYI | 17:51 |
*** burt has quit IRC | 17:52 | |
*** burt has joined #openstack-nova | 17:53 | |
*** rlrossit has quit IRC | 17:53 | |
*** SourabhP_ has joined #openstack-nova | 17:53 | |
*** mgoddard has quit IRC | 17:54 | |
*** SourabhP has quit IRC | 17:55 | |
*** SourabhP_ is now known as SourabhP | 17:55 | |
*** rlrossit has joined #openstack-nova | 17:55 | |
*** SourabhP has quit IRC | 17:59 | |
*** nelsnelson has joined #openstack-nova | 18:00 | |
*** SourabhP has joined #openstack-nova | 18:00 | |
*** e0ne has joined #openstack-nova | 18:01 | |
*** unicell1 has quit IRC | 18:01 | |
*** burt has quit IRC | 18:02 | |
*** burt has joined #openstack-nova | 18:03 | |
*** burt has quit IRC | 18:03 | |
*** yamahata has quit IRC | 18:03 | |
*** burt has joined #openstack-nova | 18:04 | |
*** claudiub has quit IRC | 18:04 | |
*** emagana_ has quit IRC | 18:06 | |
*** ociuhandu has joined #openstack-nova | 18:07 | |
*** ZZelle has joined #openstack-nova | 18:07 | |
mriedem | compute API goes directly to nova-compute somewhere? http://docs.openstack.org/developer/nova/architecture.html | 18:14 |
mriedem | where does that happen, beyond maybe the weird code to find a bdm device name? | 18:15 |
lascii | mriedem: a few things like stop/start | 18:15 |
mriedem | you mean like self.compute_rpcapi.start_instance(context, instance) right? | 18:16 |
lascii | yeah | 18:16 |
mriedem | ok forget i asked that | 18:18 |
*** SourabhP_ has joined #openstack-nova | 18:19 | |
*** SourabhP has quit IRC | 18:19 | |
*** SourabhP_ is now known as SourabhP | 18:20 | |
mgagne | is there a way to override the instance userdata when rebuilding an instance? (not injected_files, the actual userdata) | 18:20 |
*** artom has quit IRC | 18:21 | |
*** andrearosa has quit IRC | 18:21 | |
*** devananda is now known as deva_brb | 18:22 | |
openstackgerrit | Chuck Carmack proposed openstack/nova: Make the server group invalid format message more verbose https://review.openstack.org/218468 | 18:23 |
openstackgerrit | Andrew Laski proposed openstack/python-novaclient: Test that microversions are not skipped https://review.openstack.org/230603 | 18:25 |
lascii | mriedem: sdague ^ | 18:25 |
openstackgerrit | Jim Rollenhagen proposed openstack/nova: Ironic: Fix bad capacity reporting if instance_info is unset https://review.openstack.org/230487 | 18:25 |
*** vladikr has joined #openstack-nova | 18:25 | |
jroll | ^ now with passing tests | 18:25 |
*** devananda has joined #openstack-nova | 18:25 | |
*** ildikov has joined #openstack-nova | 18:26 | |
superdan | jroll: so I guess I'm confused.. what changed across the upgrade boundary? | 18:28 |
mriedem | lascii: fancy | 18:28 |
jroll | superdan: existing instances before applying the commit in the bug, don't have instance_info[stuff] set | 18:28 |
*** e0ne has quit IRC | 18:28 | |
jroll | superdan: the patcher.py changes in that commit caused nova to set that data | 18:29 |
openstackgerrit | Andrew Laski proposed openstack/python-novaclient: Test that microversions are not skipped https://review.openstack.org/230603 | 18:29 |
lascii | mriedem: fixed a spelling mistake | 18:29 |
*** SourabhP has quit IRC | 18:29 | |
*** thangp has quit IRC | 18:29 | |
superdan | jroll: so you guys don't have a grenade job I guess? | 18:30 |
*** unicell has joined #openstack-nova | 18:30 | |
superdan | because even simple case grenade catches this kind of stuff | 18:30 |
*** Marga_ has quit IRC | 18:30 | |
lascii | we do, we just call it production | 18:30 |
*** SourabhP has joined #openstack-nova | 18:30 | |
superdan | lascii: I meant the ironic project | 18:30 |
lascii | gotcha | 18:31 |
*** salv-orlando has joined #openstack-nova | 18:31 | |
jroll | heh | 18:31 |
jroll | what lascii said | 18:32 |
*** electroc_ has joined #openstack-nova | 18:32 | |
jroll | superdan: but, no, we have an experimental grenade job, it's on my priority list to get that up and running | 18:32 |
lascii | superdan: I think this would only be caught if enough capacity had been used before the upgrade | 18:32 |
jroll | superdan: I think that's upgrade ironic though? or maybe upgrade both? I can't remember | 18:32 |
jroll | lascii: and the right cells/scheduler filters | 18:33 |
superdan | lascii: sounds like it would just be triggered if there were any instances in the db before the upgrade, which grenade does do | 18:33 |
jroll | well | 18:33 |
lascii | triggered, but not cause a noticeable issue | 18:33 |
jroll | those would report negative resources | 18:33 |
jroll | but we probably wouldn't see it | 18:33 |
jroll | idk if tempest jobs test that the correct amount of resources are exposed as available | 18:34 |
superdan | jroll: they probably can't easily because of parallel jobs | 18:34 |
superdan | but still | 18:34 |
*** SourabhP_ has joined #openstack-nova | 18:34 | |
superdan | we'd see the "malformed" log message at least right? | 18:34 |
jroll | superdan: yeah, I would like to think I would have checked logs, but I'm not sure | 18:34 |
*** electrocucaracha has quit IRC | 18:34 | |
*** SourabhP has quit IRC | 18:35 | |
*** SourabhP_ is now known as SourabhP | 18:35 | |
jroll | nah, it does a .get(key, 0) | 18:35 |
jroll | the warning is only if it isn't an int | 18:35 |
superdan | yeah | 18:35 |
superdan | well, I'm just saying we should try to do better going forward | 18:35 |
jroll | totally | 18:35 |
superdan | so, | 18:36 |
jroll | I actually raised the question on the review, but trusted people that said it'd be fine | 18:36 |
superdan | grenade has several phases for checking this stuff | 18:36 |
superdan | before tempest runs on the new side for example | 18:36 |
superdan | which is specifically aimed at checking things like this we know could be out of whack | 18:36 |
superdan | so if we had such a job, I'd be saying we need a check in there | 18:36 |
*** su_zhang_ has quit IRC | 18:36 | |
jroll | I agree | 18:36 |
jroll | like I said, this is on my priority list | 18:37 |
jroll | my priority list for testing things: full tempest, grenade, functional stuffs | 18:37 |
superdan | sure, I'm not faulting you | 18:37 |
*** su_zhang_ has joined #openstack-nova | 18:37 | |
superdan | I just don't like messing up upgrades is all | 18:37 |
jroll | oh I know | 18:37 |
jroll | ditto | 18:37 |
jroll | I was one of the people debugging this at 10pm last night | 18:38 |
jroll | I do care about upgrades :) | 18:38 |
superdan | yeah I know your paycheck actually depends on not screwing this up at a very direct level :) | 18:39 |
jroll | lol | 18:39 |
*** SourabhP has quit IRC | 18:39 | |
*** SourabhP has joined #openstack-nova | 18:42 | |
*** su_zhang_ has quit IRC | 18:43 | |
*** su_zhang_ has joined #openstack-nova | 18:44 | |
*** eglynn has joined #openstack-nova | 18:45 | |
lhcheng | hello, anyone around to help with novaclient question? :) trying to figure out what's the difference between discover_extension and list_extensions methods? | 18:45 |
superdan | jroll: I'm missing why you test the instance_info and props for the cpus or vcpus | 18:46 |
superdan | jroll: they're just static data from the top of that test file right? | 18:47 |
*** salv-orlando has quit IRC | 18:47 | |
*** jichen has joined #openstack-nova | 18:47 | |
*** jichen has quit IRC | 18:47 | |
jroll | superdan: not sure what your question is? | 18:48 |
*** e0ne has joined #openstack-nova | 18:48 | |
jroll | superdan: I'm making sure that parse_instance_info returns the right thing based on if instance_info is present or not | 18:48 |
*** ijw has joined #openstack-nova | 18:48 | |
superdan | you mean _parse_node_instance_info() ? | 18:49 |
*** jichen has joined #openstack-nova | 18:49 | |
jroll | yeah | 18:49 |
mriedem | ccarmack: (9:39:37 AM) lascii: mriedem_meeting: for those security group tests with cells, they work because they don't attempt to use the security group for an instance. | 18:49 |
*** jichen has quit IRC | 18:49 | |
superdan | oh, I see, get_test_node() is creating a node thing from that data | 18:49 |
mriedem | (9:40:14 AM) lascii: the groups can be created/listed/deleted but it will only affect the top level cell. the failures happen when they can't be joined on the instance object within a child cell | 18:50 |
mriedem | (9:40:21 AM) lascii: since they're not synced down | 18:50 |
*** jichen has joined #openstack-nova | 18:50 | |
ccarmack | mriedem: doesn't devstack have a child cell? | 18:51 |
superdan | jroll: I think it would have been clearer to me if you had made the if on 276 just fetch the right cpus value and then compare expected_cpus, result['vcpus'] | 18:51 |
superdan | jroll: but that's fine | 18:51 |
ccarmack | mriedem, Iascii: I guess I would have expected it to fail in devstack on the child cell | 18:52 |
jroll | superdan: good point, mind leaving a comment and I'll grab it if I spin another? | 18:53 |
jroll | or I can even just do it now | 18:53 |
superdan | jroll: okay | 18:53 |
lascii | ccarmack: there is a child cell for the cells job | 18:53 |
*** lbeliveau has quit IRC | 18:53 | |
lascii | ccarmack: but it never comes into play when the compute/api method just does a db read/update | 18:53 |
*** SourabhP has quit IRC | 18:55 | |
*** jichen has joined #openstack-nova | 18:55 | |
*** cfriesen has joined #openstack-nova | 18:56 | |
*** SourabhP has joined #openstack-nova | 18:56 | |
dimsum__ | lascii: mriedem: since it's late on friday, here's a review request with no code changes :) can one of you please take a peek? https://review.openstack.org/#/c/229069/ | 18:57 |
openstackgerrit | Jim Rollenhagen proposed openstack/nova: Ironic: Fix bad capacity reporting if instance_info is unset https://review.openstack.org/230487 | 18:57 |
*** ansiwen has quit IRC | 18:57 | |
jroll | superdan: ^ thanks for review | 18:57 |
openstackgerrit | Anne Gentle proposed openstack/nova: docs: re-organise the API concept docs https://review.openstack.org/226253 | 18:57 |
openstackgerrit | Anne Gentle proposed openstack/nova: Rearranges to create new Compute API Guide https://review.openstack.org/230186 | 18:57 |
lascii | dimsum__: yep, I was already +2 on that one | 18:57 |
mriedem | ccarmack: the cells compute API extends the normal nova.compute.API: https://github.com/openstack/nova/blob/master/nova/compute/cells_api.py#L162 | 18:57 |
mriedem | and in the normal nova compute API, it just talks directly to the DB to the security group CRUD operatoins | 18:58 |
ccarmack | Iascii, mriedem: I'm a little slow here, you said it would on the child cell when attempting to join the security group into the instance | 18:58 |
superdan | jroll: ah, I was also not really processing that the props change for the other keys were needed, | 18:58 |
superdan | jroll: too focused on the cpus/vcpus disparity I guess | 18:58 |
ccarmack | mriedem: yes, I saw alaski 's comment | 18:58 |
mriedem | ccarmack: i think that means when it goes to the child cell to talk to nova-compute to refresh firewall rules for the security group | 18:58 |
lascii | ccarmack: on another operation, like boot, there would be a failure when a db lookup happened in the child cell | 18:59 |
superdan | lascii: I permit you to +W jroll's patch | 18:59 |
openstackgerrit | Anne Gentle proposed openstack/nova: Rearranges to create new Compute API Guide https://review.openstack.org/230186 | 18:59 |
jroll | "permit" heh | 18:59 |
ccarmack | Iascii: ok, got it... it does seem better to fail earlier on addSecurityGroup rather than later with a db error on boot ?? | 19:00 |
lascii | superdan: heh. Should I have knelt for that? | 19:00 |
*** bswartz has quit IRC | 19:00 | |
*** ansiwen has joined #openstack-nova | 19:00 | |
lascii | kneeled? whatever | 19:00 |
superdan | lascii: if it makes you more comfortable, I'm fine with it | 19:00 |
ccarmack | Iascii: is the security group limitation for cells a permanent thing, or just in v1? | 19:02 |
lascii | just v1 | 19:02 |
ccarmack | Iascii: since v1 is experimental (?) and security groups will be ok in v2. there's no reason to add that check to the API ? | 19:03 |
lascii | ccarmack: if you added the check to compute/cells_api.py that is v1 only code that would eventually get removed | 19:03 |
lascii | I have no strong feelings either way on adding the check or not | 19:03 |
lascii | also that's an L in my name :) | 19:04 |
ccarmack | L | 19:04 |
ccarmack | I thougth it was eye - ascii | 19:04 |
superdan | lascii: it's too bad, or you could be IaaSki | 19:04 |
ccarmack | Lascii: I'll add the check it that ok | 19:05 |
mriedem | lower case l | 19:05 |
*** marcusvrn_ has quit IRC | 19:05 | |
mriedem | I has a serif | 19:05 |
*** ansiwen has quit IRC | 19:05 | |
mriedem | upper case I | 19:05 |
ccarmack | I thought Lascii was big on the ascii char set for some reason | 19:05 |
superdan | |ascii | 19:05 |
mriedem | he is | 19:05 |
lascii | I like that one | 19:05 |
mriedem | it's his hobby, hence his friday nick | 19:05 |
ccarmack | we all have our thing | 19:06 |
*** ansiwen has joined #openstack-nova | 19:06 | |
superdan | [ascii | 19:06 |
superdan | 1ascii | 19:06 |
ccarmack | I'll do a patch for the api check...my first cells coding | 19:07 |
mriedem | heh, i wonder what the process is around adding backward incompatible cells v1 API changes.... | 19:07 |
mriedem | it might be a black hole polar vortex | 19:07 |
ccarmack | oh, forget that | 19:07 |
ccarmack | would it be a microversion? | 19:08 |
mriedem | no... | 19:08 |
* lascii ponders printing an ascii chart to put on the wall now | 19:08 | |
*** Marga_ has joined #openstack-nova | 19:08 | |
*** e0ne has quit IRC | 19:08 | |
mriedem | it would probably be a thing that anyone that deploys cells v1 would never see | 19:08 |
*** erlon has quit IRC | 19:08 | |
mriedem | which is why lascii is indifferent | 19:08 |
lascii | yeah, it really shouldn't affect any users | 19:09 |
mriedem | it might make ccarmack's series to cleanup that tempest rc blacklist easier | 19:09 |
mriedem | to see if anything is missed in tempest | 19:09 |
*** thedodd has joined #openstack-nova | 19:10 | |
dimsum__ | lascii: thanks! | 19:10 |
*** wolsen has quit IRC | 19:10 | |
ccarmack | mriedem: wouldn't cells tempest fail anyway on the server boot? | 19:10 |
mriedem | ccarmack: i don't think so, unless the test plans on ssh'ing into the guest | 19:11 |
mriedem | and i don' think the validation flag is set in that job for the api tests | 19:11 |
mriedem | superdan: you may or may not have an opinion on this, but i feel like it's probably come up before - how to repr objects in the logs https://review.openstack.org/#/c/227116/ | 19:13 |
mriedem | in this case an object list | 19:13 |
bauwser | mriedem: looking at https://bugs.launchpad.net/nova/+bug/1501831 | 19:13 |
openstack | Launchpad bug 1501831 in OpenStack Compute (nova) "Evacuate libvirt instance failed with error 'Cannot load 'disk_format' in the base class'" [Undecided,New] | 19:13 |
superdan | mriedem: damn right I have an opinion | 19:14 |
*** davideagnello has quit IRC | 19:14 | |
bauwser | mriedem: IIUC, that's only when the instance is volume-backed or not ? | 19:15 |
mgagne | anyone familiar with python-libvirt? I'm trying to use migrateToURI3 and pass a parameter with multiple values (list of strings) and I can't seem to be able. The operation fails with 'Unknown type of "migrate_disks" field' (list of strings) or 'invalid argument: disk target vda,hdd not found' when joining the strings with ',' | 19:15 |
*** jecarey has joined #openstack-nova | 19:15 | |
*** tsekiyama has joined #openstack-nova | 19:16 | |
mriedem | bauwser: looking | 19:16 |
bauwser | trying to identify the impact | 19:17 |
*** wolsen has joined #openstack-nova | 19:17 | |
bauwser | mriedem: asked to you because you updated to New, heh | 19:17 |
bauwser | :p | 19:17 |
mriedem | well, instance boot fails apparently | 19:18 |
mriedem | er evacuate in this case | 19:18 |
mriedem | i'm checking the code | 19:18 |
mriedem | ijuwang: ^ is that bug recreated with upstream nova compute manager or powervc? | 19:19 |
ijuwang | powervc | 19:19 |
*** andrearosa has joined #openstack-nova | 19:20 | |
mriedem | bauwser: didn't ndipanoff just redo a bunch of the rebuild_instance flow in the compute manager? | 19:20 |
ijuwang | it really depends on whether {} could ever be the image_meta during evacuate | 19:20 |
*** su_zhang_ has quit IRC | 19:20 | |
mriedem | yeah i suppose here https://github.com/openstack/nova/blob/stable/liberty/nova/compute/manager.py#L2653 | 19:21 |
ijuwang | it was set to None.. and during PowerVC evacuate of PowerKVM instance, we hit that issue | 19:21 |
*** mwagner_ has quit IRC | 19:21 | |
mriedem | because of https://github.com/openstack/nova/blob/stable/liberty/nova/compute/manager.py#L2655 | 19:21 |
bauwser | mriedem: it was mostly for claiming AFAIK | 19:21 |
bauwser | mriedem: but maybe we are not talking from the same | 19:21 |
mriedem | yeah i'm looking for where driver.spawn is called | 19:21 |
*** su_zhang_ has joined #openstack-nova | 19:21 | |
mriedem | ah here https://github.com/openstack/nova/blob/stable/liberty/nova/compute/manager.py#L2722 | 19:22 |
mriedem | that's the recreate code i'm used to | 19:22 |
*** e0ne has joined #openstack-nova | 19:22 | |
ijuwang | image_ref is set to None during evacuate in the api code | 19:24 |
bauwser | so yeah, IIUC image_ref is set to None | 19:24 |
bauwser | yeah that | 19:24 |
*** subscope has joined #openstack-nova | 19:24 | |
bauwser | mriedem: ijuwang: yep https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3336 | 19:25 |
*** subscope_ has joined #openstack-nova | 19:25 | |
*** baoli_ has quit IRC | 19:26 | |
*** marcusvrn_ has joined #openstack-nova | 19:26 | |
*** baoli has joined #openstack-nova | 19:26 | |
bauwser | mriedem: ijuwang: so basically, we're going thru this path until the driver spawns | 19:26 |
mriedem | but where does image_meta get turned into an object? | 19:26 |
ijuwang | spawn | 19:26 |
ijuwang | in the driver | 19:26 |
bauwser | yey | 19:27 |
ijuwang | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L2427 | 19:27 |
bauwser | mriedem: https://review.openstack.org/#/c/188119/ | 19:27 |
mriedem | https://github.com/openstack/nova/blob/stable/liberty/nova/virt/libvirt/driver.py#L2427 | 19:27 |
mriedem | yeah | 19:27 |
bauwser | mriedem: so, you see, it seems we have a regression... | 19:29 |
mriedem | so.... | 19:30 |
bauwser | Critical I guess | 19:30 |
bauwser | hence me hassling folks like mriedem | 19:30 |
mriedem | image_meta (the dict) must not have disk_format in it, or it's None and ImageMeta.from_dict defaults it to {} | 19:30 |
mriedem | which basically creates an empty ImageMeta object | 19:30 |
mriedem | so you'd have to lazy-load any attributes on it | 19:30 |
mriedem | b/c image_ref is coming in as None from the API, yeah, so image_meta is {} when we convert to an object | 19:31 |
bauwser | right | 19:32 |
mriedem | ok | 19:32 |
mriedem | yeah, derp | 19:32 |
mriedem | and we don't test evacuate in the gate b/c $reasons | 19:32 |
bauwser | yup, unless I missed something | 19:32 |
*** vladikr has quit IRC | 19:32 | |
mriedem | this is probably critical yeah since it impacts planned maintenance which is a thing people do to upgrade to liberty... | 19:33 |
mriedem | sweet | 19:33 |
ccarmack | mriedem: I'm curious, what is $reason set to? | 19:33 |
bauwser | ok, I guess the change is probably low-hanging-fruit | 19:33 |
ccarmack | mriedem: why is it not tested in the gate? | 19:34 |
mriedem | ccarmack: it's been awhile since i've dug into it, but i think the service has to be down to evacuate | 19:34 |
bauwser | indeed | 19:34 |
mriedem | and that's kind of hard in a single-node devstack run with multiple test workers | 19:34 |
*** pm90__ has quit IRC | 19:34 | |
bauwser | != live-migrate | 19:34 |
openstack | bauwser: Error: "=" is not a valid command. | 19:34 |
bauwser | dammit | 19:35 |
*** stevemar has quit IRC | 19:35 | |
*** david-lyle has quit IRC | 19:35 | |
bauwser | evacuate => host down, rebuild a new vm != live-migrate where it copies the instance | 19:35 |
*** david-lyle has joined #openstack-nova | 19:35 | |
bauwser | so, lemme think about the fix | 19:36 |
mriedem | bauwser: so i'm thinking: if image_meta.get('disk_format', None) == 'iso': | 19:36 |
mriedem | is the fix | 19:36 |
mriedem | i can push that quick | 19:36 |
ijuwang | i tried that | 19:36 |
mriedem | and yeah it was regressed here https://review.openstack.org/#/c/188119/25/nova/virt/libvirt/blockinfo.py | 19:36 |
ijuwang | that i didn't work | 19:36 |
*** SourabhP_ has joined #openstack-nova | 19:36 | |
*** deva_brb is now known as deva_irssi | 19:36 | |
ijuwang | i don't think we can use .get anymore | 19:36 |
mriedem | ijuwang: did you do image_meta.get('disk_format') or get('disk_format', None) | 19:36 |
bauwser | ijuwang: .get is provided | 19:36 |
mriedem | because the None is important to avoid the lazy load | 19:36 |
bauwser | ijuwang: as a method for the ImageMetaProps | 19:37 |
mriedem | let me run a change quick | 19:37 |
ijuwang | but we are not doing ImageMetaProps .. it's against ImageMeta | 19:37 |
openstackgerrit | jichenjc proposed openstack/nova: devref: change error messages no need microversion https://review.openstack.org/218491 | 19:37 |
*** SourabhP has quit IRC | 19:37 | |
*** nelsnelson has quit IRC | 19:37 | |
*** SourabhP_ is now known as SourabhP | 19:38 | |
mriedem | ijuwang: i'm going to put a change together that you can try | 19:38 |
mriedem | give me a few | 19:38 |
bauwser | ijuwang: right, we should perhaps use obj_attr_is_set() instead | 19:38 |
ijuwang | i don't have the env anymore.. let me set another one up | 19:38 |
bauwser | mriedem: like I said, obj_attr_is_set is a workaround | 19:40 |
bauwser | mriedem: that's a dirty one tho | 19:40 |
mriedem | superdan: won't image_meta.get('disk_format', None) avoid lazy-loading that attribute if it isn't set? | 19:40 |
mriedem | on an ImageMeta object | 19:40 |
bauwser | mriedem: because I'd prefer to hydrate the object correctly rather | 19:40 |
superdan | mriedem: should, but I think he had a special case for that object | 19:40 |
*** e0ne has quit IRC | 19:40 | |
mriedem | there was the image_meta.properties.get() stuff | 19:40 |
bauwser | superdan: no, it's for ImageMetaProps | 19:40 |
*** su_zhan__ has joined #openstack-nova | 19:40 | |
bauwser | superdan: here, the load is for ImageMeta, the parent obj | 19:41 |
*** thedodd has quit IRC | 19:41 | |
mriedem | anyway, a unit test should tell me if it works or not | 19:41 |
bauwser | mriedem: well, obj_attr_is_set does the trick | 19:41 |
mriedem | yeah but i'd like to avoid that | 19:42 |
bauwser | agreed | 19:42 |
bauwser | hence my above point, we should rather hydrate the object correctly | 19:42 |
bauwser | using from_() method | 19:42 |
bauwser | I mean, correcting from_dict() maybe | 19:43 |
bauwser | or we could default the field to None | 19:43 |
*** su_zha___ has joined #openstack-nova | 19:44 | |
*** su_zha___ has quit IRC | 19:44 | |
bauwser | superdan: but it would require a bump, right ? | 19:44 |
*** su_zhang_ has quit IRC | 19:44 | |
superdan | no? | 19:44 |
superdan | bauwser: can you link me to what you're talking about? | 19:44 |
mriedem | bauwser: i don't know what we'd create it from though, image_meta is literally {} | 19:44 |
mriedem | superdan: https://bugs.launchpad.net/nova/+bug/1501831 | 19:44 |
openstack | Launchpad bug 1501831 in OpenStack Compute (nova) "Evacuate libvirt instance failed with error 'Cannot load 'disk_format' in the base class'" [Critical,In progress] - Assigned to Matt Riedemann (mriedem) | 19:44 |
*** su_zhan__ has quit IRC | 19:44 | |
*** SourabhP has quit IRC | 19:45 | |
bauwser | superdan: so https://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L64 is not defaulted | 19:45 |
*** david-ly_ has joined #openstack-nova | 19:45 | |
bauwser | superdan: since the from_dict() only hydrates what's in the dict, it leaves some fields unset | 19:45 |
bauwser | superdan: and it then creates the above bug ^ | 19:45 |
bauwser | superdan: because of a story starting with image_ref=None in the api and then passing an empty dict | 19:46 |
bauwser | superdan: so the resulted ImageMeta object is litterally empty | 19:46 |
mriedem | https://github.com/openstack/nova/blob/stable/liberty/nova/virt/libvirt/blockinfo.py#L432 | 19:47 |
*** yamahata has joined #openstack-nova | 19:47 | |
mriedem | which blows up there ^ | 19:47 |
superdan | we either need to decide whether we want to depend on that field being set | 19:47 |
bauwser | superdan: which just explodes the evacuate method | 19:47 |
superdan | if not, then the libvirt driver should be going something like .get('foo', 0) | 19:47 |
*** SourabhP has joined #openstack-nova | 19:47 | |
mriedem | the latter is what i'm writing a patch against | 19:48 |
superdan | or.get('disk_format', 'raw') I guess | 19:48 |
mriedem | disk_format is nullable | 19:48 |
bauwser | superdan: the original version was using the .get() dict method | 19:48 |
superdan | bauwser: yeah, so that's what we should do I think | 19:48 |
bauwser | superdan: https://review.openstack.org/#/c/188119/25/nova/virt/libvirt/blockinfo.py | 19:48 |
mriedem | superdan: yup, doing that now | 19:48 |
superdan | bauwser: the libvirt driver should know that nothing was specified | 19:48 |
mriedem | running the test | 19:48 |
bauwser | so adding a new .get() method to ImageMeta ? | 19:49 |
bauwser | mriedem: ^ | 19:49 |
*** david-lyle has quit IRC | 19:49 | |
mriedem | no | 19:49 |
*** david-ly_ has quit IRC | 19:49 | |
superdan | bauwser: and disk_format shouldn't be nullable because "no disk format" makes no sense | 19:49 |
bauwser | superdan: that, I agree :) | 19:49 |
mriedem | damn | 19:49 |
mriedem | AttributeError: 'ImageMeta' object has no attribute 'get' | 19:49 |
bauwser | mriedem: yeah hence my point | 19:49 |
mriedem | b/c ImageMeta doesn't extend the dictcmpat object | 19:49 |
bauwser | mriedem: .get is only for ImageMetaProps like I said :D | 19:49 |
*** setuid has quit IRC | 19:49 | |
bauwser | mriedem: and that too :D | 19:50 |
superdan | mriedem: because it doesn't inherit from the dict mixin | 19:50 |
mriedem | yup | 19:50 |
mriedem | NovaObjectDictCompat | 19:50 |
mriedem | shite | 19:50 |
bauwser | that's new object-style :) | 19:50 |
mriedem | so i'm guessing we don't want to add NovaObjectDictCompat back into ImageMeta | 19:50 |
superdan | mriedem: but you can add the .get() easily, no bump required, but it'd be more objecty to just check obj_attr_is_set() | 19:50 |
superdan | mriedem: no | 19:50 |
*** setuid has joined #openstack-nova | 19:51 | |
bauwser | superdan: yeah like I said to mriedem, we can use obj_attr_is_set but it exposes that's an object | 19:51 |
*** ctrath has quit IRC | 19:51 | |
bauwser | but that's a quick fix | 19:51 |
superdan | I don't understand "but it exposes", but yes, that's how I'd do it | 19:51 |
mriedem | bauwser: yeah, it's already exposed as an object b/c of dot notation | 19:51 |
mriedem | alright, i'll do the other more explicit thing | 19:51 |
bauwser | okay, so I was BT paired with superdan | 19:51 |
mriedem | i'm just wondering what else is doing this | 19:52 |
bauwser | yeah, hence me wondering what could be a proper from_dict() | 19:52 |
*** thumpba has quit IRC | 19:53 | |
bauwser | since we have no nullable strings, I think we should have a from_dict() which would litterally hydrate all fields | 19:53 |
bauwser | because that's a contract | 19:53 |
*** ctrath has joined #openstack-nova | 19:53 | |
mriedem | well, or at least default the nullable ones to '' like it's doing | 19:53 |
mriedem | in from_dict() | 19:53 |
*** burgerk_ has joined #openstack-nova | 19:54 | |
bauwser | mriedem: in ImageMeta, I can't see fields that are nullable but the persisting ones | 19:54 |
bauwser | mriedem: so, it means that an instance of that object should have all the fields set | 19:54 |
bauwser | that's MHO | 19:54 |
bauwser | but maybe superdan unpaired BT on that one | 19:54 |
mriedem | i meant this https://github.com/openstack/nova/blob/stable/liberty/nova/objects/image_meta.py#L112 | 19:54 |
bauwser | ah | 19:55 |
* bauwser facepalm | 19:55 | |
mriedem | like setdefault(self, field, '') | 19:55 |
bauwser | yeah that too | 19:55 |
mriedem | self.setdefault(field, '') | 19:55 |
superdan | bauwser: I disagree.. you need to know whether they specified a disk format or not. Nullable means "can have None" and that doesn't make sense for something like disk_format | 19:55 |
superdan | disk_format=None doesn't mean "take the default". Not setting it at all means "take the default" | 19:56 |
bauwser | superdan: yeah that's my point, I was unclear | 19:56 |
mriedem | yeah i didn't want to go down this route b/c of the weird nullable vs '' change in there | 19:56 |
superdan | bauwser: okay | 19:56 |
bauwser | superdan: since the field is not nullable, we should hydrate some default value | 19:56 |
bauwser | when calling from_dict | 19:56 |
bauwser | but that's MHO | 19:56 |
*** mwagner_ has joined #openstack-nova | 19:57 | |
*** burgerk has quit IRC | 19:57 | |
superdan | bauwser: no, I disagree! | 19:57 |
bauwser | ahah | 19:57 |
bauwser | okay, fair enough | 19:57 |
bauwser | :) | 19:57 |
*** su_zhang_ has joined #openstack-nova | 19:57 | |
superdan | bauwser: because we can't do that at the API layer for every virt driver.. all we have to do is communicate that they didn't ask for anything, which is the virt driver's cue | 19:57 |
bauwser | so, then, obj_attr_is_set :) | 19:58 |
bauwser | superdan: heu, I don't get your point, but that's fair | 19:58 |
bauwser | your object skils are far better than mine :D | 19:59 |
*** thumpba has joined #openstack-nova | 19:59 | |
bauwser | because .from_dict() was called by the virt driver | 19:59 |
*** apoorvad has quit IRC | 19:59 | |
*** burgerk_ has quit IRC | 19:59 | |
superdan | yes, but from_dict is not owned by the driver | 20:00 |
superdan | anyway, obj_attr_is_set() for now, yes | 20:00 |
bauwser | superdan: oooooh I see | 20:00 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: check if ImageMeta.disk_format is set before accessing it https://review.openstack.org/230625 | 20:01 |
superdan | melwitt: sorry I missed a comment without a -1? | 20:01 |
melwitt | superdan: I didn't know if it was missed yet but I thought maybe I should put it just in case | 20:02 |
*** pixelbeat has quit IRC | 20:02 | |
bauwser | mriedem: FWIW, +1'd | 20:03 |
mriedem | ijuwang: https://review.openstack.org/230625 if you can test that | 20:04 |
superdan | melwitt: you should pretty much always -1 my patches if you have a comment you want me to see.. my workflow and review email processing doesn't reward niceness :) | 20:04 |
mriedem | bauwser: <3 | 20:04 |
bauwser | mriedem: no, me <3 | 20:04 |
*** jichen has quit IRC | 20:04 | |
ijuwang | sure.. I just finished setting up the env.. I will try it next | 20:04 |
melwitt | superdan: got it :) | 20:04 |
*** jichen has joined #openstack-nova | 20:05 | |
melwitt | superdan: I'll remove -1 obviously if it turns out my comment/question was wacky | 20:05 |
*** jichen has quit IRC | 20:05 | |
*** jichen has joined #openstack-nova | 20:06 | |
*** karmatronic has quit IRC | 20:06 | |
*** pm90_ has joined #openstack-nova | 20:07 | |
*** jichen has quit IRC | 20:09 | |
*** jichen has joined #openstack-nova | 20:10 | |
*** pm90_ has quit IRC | 20:10 | |
*** pm90_ has joined #openstack-nova | 20:11 | |
*** jichen has joined #openstack-nova | 20:11 | |
openstackgerrit | Andrew Laski proposed openstack/python-novaclient: Test that microversions are not skipped https://review.openstack.org/230603 | 20:11 |
*** jichen has quit IRC | 20:11 | |
superdan | melwitt: replied to your exception thing, see what you hink | 20:12 |
superdan | obviously the thing on the base patch is right | 20:12 |
superdan | I mean you're right | 20:12 |
ccarmack | superdan, bauwser, mriedem: stupid question on https://review.openstack.org/#/c/230625/1/nova/virt/libvirt/blockinfo.py ... could the == operator be overloaded? | 20:12 |
* melwitt looks | 20:12 | |
*** apoorvad has joined #openstack-nova | 20:12 | |
superdan | ccarmack: no | 20:12 |
*** tsekiyama has quit IRC | 20:12 | |
bauwser | ccarmack: no | 20:12 |
bauwser | hah | 20:13 |
ccarmack | ... because it can't be done in python, or is a bad idea in this case? | 20:13 |
bauwser | because it would hide the logic | 20:13 |
mriedem | it can be done | 20:13 |
mriedem | with __eq__ | 20:13 |
mriedem | but that doesn't mean it should be done | 20:14 |
bauwser | yup, but that's errorprone | 20:14 |
*** signed8bit is now known as signed8bit_ZZZzz | 20:14 | |
superdan | mriedem: it can't unless you implement that on field and do some weird monkeywork | 20:14 |
ccarmack | seems like it makes it easier for the virt programmer | 20:14 |
mriedem | superdan: i know | 20:14 |
superdan | mriedem: because the deref is what triggers | 20:14 |
mriedem | but it can be done | 20:14 |
mriedem | true | 20:14 |
superdan | and what do you compare with? | 20:14 |
superdan | not None | 20:14 |
mriedem | None.__eq__ is bad | 20:14 |
superdan | you can't compare to None for testing "is set" because then that conflates with if it's actually none | 20:15 |
*** jichen has joined #openstack-nova | 20:15 | |
mriedem | let's just monkey patch __eq__ in python | 20:15 |
mriedem | can we do that? | 20:15 |
superdan | heh | 20:15 |
*** jichen has quit IRC | 20:15 | |
superdan | how about we patch ccarmack.__eq__ ? | 20:15 |
ccarmack | nm :-X | 20:15 |
mriedem | is it possible to hack the interpreter? | 20:15 |
*** signed8bit_ZZZzz is now known as signed8bit | 20:16 | |
*** jichen has joined #openstack-nova | 20:16 | |
mriedem | surely sqlalchemy has solved this problem :) | 20:16 |
*** jichen has joined #openstack-nova | 20:16 | |
superdan | it always has dict behavior | 20:16 |
superdan | so yeah | 20:16 |
superdan | and we could do that | 20:17 |
*** jichen has quit IRC | 20:17 | |
superdan | we could keep __contains__ | 20:17 |
*** READ10 has quit IRC | 20:17 | |
superdan | so you could do "if 'foo' in image_meta" | 20:17 |
*** kairo has quit IRC | 20:17 | |
*** tsekiyama has joined #openstack-nova | 20:17 | |
*** thumpba has quit IRC | 20:17 | |
*** jichen has joined #openstack-nova | 20:17 | |
mriedem | yeah | 20:17 |
mriedem | https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L704 | 20:18 |
*** jichen has quit IRC | 20:18 | |
mriedem | i kind of actually like that better | 20:18 |
superdan | right, that went with the dict splitout | 20:18 |
mriedem | but that's dict compat | 20:18 |
superdan | but we could pull it back | 20:18 |
mriedem | into VersionedObject? | 20:18 |
superdan | yeah | 20:18 |
bauwser | mmm | 20:18 |
superdan | I mean, not for this fix of course | 20:18 |
mriedem | let's do it! | 20:18 |
mriedem | yeah | 20:18 |
mriedem | you don't want to update ovo, release, require min new version and then backport all? | 20:19 |
superdan | the thing we want to not be part of the base object is like __getitem__ and iteritems and stuff | 20:19 |
mriedem | my stats would be insane! | 20:19 |
bauwser | honestly, I thought we were wanting to remove the dict compat? | 20:19 |
superdan | heh | 20:19 |
superdan | bauwser: yes | 20:19 |
*** SourabhP has quit IRC | 20:19 | |
mriedem | if x in y: is much cleaner than if y.obj_attr_is_set(x) and y.x == z: imo | 20:19 |
superdan | bauwser: what I'm saying is that __contains__ doesn't need to be dict | 20:19 |
bauwser | fair point | 20:20 |
mriedem | yar | 20:20 |
superdan | lots of non dicts have __contains__ | 20:20 |
bauwser | agreed | 20:20 |
*** jichen has joined #openstack-nova | 20:20 | |
*** jichen has quit IRC | 20:20 | |
bauwser | that just means it's a iterable | 20:20 |
superdan | no | 20:20 |
bauwser | uh, a container | 20:20 |
bauwser | my bad | 20:20 |
superdan | yes, a container | 20:20 |
*** jichen has joined #openstack-nova | 20:21 | |
*** jichen has quit IRC | 20:21 | |
*** jichen has joined #openstack-nova | 20:21 | |
bauwser | superdan: mriedem: https://www.youtube.com/watch?v=7GL6LH6ufhM | 20:22 |
superdan | heh | 20:22 |
superdan | everybody wants to be like mriedem | 20:23 |
*** jichen has quit IRC | 20:23 | |
superdan | nobody wants to be like su_zhang_ | 20:23 |
superdan | er, superdan | 20:23 |
superdan | heh | 20:23 |
melwitt | lol | 20:23 |
mriedem | racist! | 20:23 |
superdan | su_zhang_: tab completion fail, my apologies :X | 20:23 |
bauwser | lol | 20:23 |
su_zhang_ | fine | 20:23 |
melwitt | I know I want to be like mriedem. that's why I say hells bells whenever I can | 20:23 |
superdan | yeah :/ | 20:23 |
melwitt | :| | 20:24 |
mriedem | oh that's classic | 20:24 |
rlrossit | I thought to be like mriedem you had to say gdi all the time | 20:24 |
*** david-lyle has joined #openstack-nova | 20:24 | |
mriedem | superdan: so if i want __contains__ in VersionedObject in ovo, can it live in both that and the dict compat class temporarily? or do we assume that all classes that extend dict compat also extend VersionedObject? | 20:25 |
mriedem | seems like a bad assumption to make | 20:25 |
*** jichen has joined #openstack-nova | 20:25 | |
superdan | mriedem: it can be in both | 20:25 |
mriedem | or make it it's own mixin that both take | 20:25 |
superdan | nah, just do it in the base | 20:25 |
*** jichen has quit IRC | 20:25 | |
mriedem | ok | 20:25 |
openstackgerrit | Dan Smith proposed openstack/nova: Add get_minimum_version() to Service object and DB API https://review.openstack.org/223320 | 20:26 |
openstackgerrit | Dan Smith proposed openstack/nova: Allow automatic determination of compute_rpc version by service https://review.openstack.org/223321 | 20:26 |
openstackgerrit | Dan Smith proposed openstack/nova: Extend the ServiceTooOld exception with more data https://review.openstack.org/230227 | 20:26 |
openstackgerrit | Dan Smith proposed openstack/nova: Make service create/update fail if version is too old https://review.openstack.org/229049 | 20:26 |
superdan | mriedem: thanks for catching that ^ | 20:26 |
*** jichen has joined #openstack-nova | 20:26 | |
superdan | dammit | 20:26 |
superdan | melwitt: | 20:26 |
mriedem | ccarmack: see, don't feel bad, something constructive came out of your eq question | 20:26 |
superdan | what is wrong with me | 20:26 |
*** jichen has quit IRC | 20:26 | |
*** jichen has joined #openstack-nova | 20:27 | |
melwitt | ... :) | 20:27 |
*** jichen has quit IRC | 20:27 | |
bauwser | superdan: go to sleep ! | 20:27 |
bauwser | :p | 20:27 |
superdan | melwitt: yeah, I know you know what's wrong and don't want to say :) | 20:27 |
superdan | bauwser: touche | 20:27 |
bauwser | anyway, seems a nice opportunity for | 20:28 |
*** bauwser is now known as bauzas | 20:28 | |
bauzas | bye folks | 20:28 |
superdan | o/ | 20:28 |
mriedem | bauzas: later | 20:28 |
melwitt | superdan: it's fun to pretend I do | 20:28 |
*** leakypipes has quit IRC | 20:28 | |
superdan | heh | 20:28 |
*** aysyd has quit IRC | 20:30 | |
*** jichen has joined #openstack-nova | 20:30 | |
*** VW has quit IRC | 20:32 | |
*** VW has joined #openstack-nova | 20:32 | |
*** SourabhP has joined #openstack-nova | 20:33 | |
*** jichen has quit IRC | 20:34 | |
*** jichen has joined #openstack-nova | 20:35 | |
*** jichen has quit IRC | 20:35 | |
*** jichen has joined #openstack-nova | 20:36 | |
*** jichen has quit IRC | 20:36 | |
*** jichen has joined #openstack-nova | 20:37 | |
*** VW has quit IRC | 20:37 | |
*** jichen has joined #openstack-nova | 20:40 | |
*** jichen has quit IRC | 20:40 | |
*** jichen has joined #openstack-nova | 20:41 | |
ijuwang | mriedem: it works.. | 20:43 |
mriedem | cool | 20:43 |
*** ZZelle has quit IRC | 20:44 | |
mriedem | ijuwang: want to ack in the change to note you've verified it fixes the bug? | 20:44 |
*** jichen has quit IRC | 20:44 | |
ijuwang | sure | 20:44 |
*** jichen has joined #openstack-nova | 20:45 | |
*** jichen has quit IRC | 20:46 | |
*** jichen has joined #openstack-nova | 20:46 | |
*** jichen has joined #openstack-nova | 20:47 | |
*** ZZelle has joined #openstack-nova | 20:47 | |
*** jichen has quit IRC | 20:47 | |
ijuwang | mriedem: btw, there is a lower priority issue I submitted a fix, what I need to do to get some review.. https://review.openstack.org/#/c/227039/ | 20:47 |
*** tsekiyama has quit IRC | 20:47 | |
*** zzzeek has quit IRC | 20:48 | |
*** ccarmack has left #openstack-nova | 20:52 | |
*** angdraug has joined #openstack-nova | 20:53 | |
openstackgerrit | xing-yang proposed openstack/nova: Rollback is needed if initialize_connection times out https://review.openstack.org/138664 | 20:55 |
*** raildo is now known as raildo-afk | 20:56 | |
openstackgerrit | Dan Smith proposed openstack/nova: Allow automatic determination of compute_rpc version by service https://review.openstack.org/223321 | 20:57 |
openstackgerrit | Dan Smith proposed openstack/nova: Extend the ServiceTooOld exception with more data https://review.openstack.org/230227 | 20:57 |
openstackgerrit | Dan Smith proposed openstack/nova: Make service create/update fail if version is too old https://review.openstack.org/229049 | 20:57 |
*** amotoki has joined #openstack-nova | 20:58 | |
*** tsekiyama has joined #openstack-nova | 20:58 | |
*** amotoki has quit IRC | 21:03 | |
*** tsekiyam_ has joined #openstack-nova | 21:03 | |
*** dustins has quit IRC | 21:03 | |
*** mtanino has quit IRC | 21:04 | |
*** MVenesio has quit IRC | 21:06 | |
*** tsekiyama has quit IRC | 21:07 | |
*** tsekiyam_ has quit IRC | 21:07 | |
*** thumpba has joined #openstack-nova | 21:10 | |
*** stevemar has joined #openstack-nova | 21:12 | |
*** su_zhang_ has quit IRC | 21:14 | |
*** ociuhandu has quit IRC | 21:18 | |
*** salv-orlando has joined #openstack-nova | 21:19 | |
*** nelsnelson has joined #openstack-nova | 21:21 | |
*** nelsnelson has quit IRC | 21:23 | |
*** nelsnels_ has joined #openstack-nova | 21:23 | |
*** vilobhmm111 has quit IRC | 21:25 | |
*** vilobhmm11 has joined #openstack-nova | 21:25 | |
*** pm90__ has joined #openstack-nova | 21:26 | |
*** diogogmt_ has joined #openstack-nova | 21:26 | |
*** salv-orlando has quit IRC | 21:27 | |
*** diogogmt has quit IRC | 21:29 | |
*** diogogmt_ is now known as diogogmt | 21:29 | |
*** pm90_ has quit IRC | 21:29 | |
mriedem | flashgordon: you're on the TC ballot? | 21:30 |
flashgordon | mriedem: it appears so | 21:32 |
flashgordon | if I win, I will go to the summit | 21:32 |
*** signed8bit is now known as signed8bit_ZZZzz | 21:36 | |
*** su_zhang_ has joined #openstack-nova | 21:38 | |
*** pixelbeat has joined #openstack-nova | 21:41 | |
mriedem | mikal: lascii: _cerberus_: this is marked as critical and liberty-rc-potential since it impacts evacuate (which impacts maintenance which impacts upgrades), so asking for a look so i can backport to stable/liberty https://review.openstack.org/#/c/230625/ | 21:42 |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: check if ImageMeta.disk_format is set before accessing it https://review.openstack.org/230625 | 21:44 |
*** bnemec has joined #openstack-nova | 21:44 | |
mriedem | sona | 21:44 |
mriedem | *sonofa | 21:44 |
mriedem | .gitreview isn't updated for stalbe/liberty | 21:44 |
mriedem | damn | 21:44 |
superdan | heh | 21:45 |
*** yamahata has quit IRC | 21:45 | |
*** marcusvrn_ has quit IRC | 21:45 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: check if ImageMeta.disk_format is set before accessing it https://review.openstack.org/230625 | 21:46 |
mriedem | superdan: can you reapply the +2 there? | 21:46 |
*** rlrossit has left #openstack-nova | 21:48 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: libvirt: check if ImageMeta.disk_format is set before accessing it https://review.openstack.org/230625 | 21:49 |
*** tonytan4ever has quit IRC | 21:49 | |
superdan | if you stop dicking with it | 21:49 |
*** thumpba has quit IRC | 21:49 | |
*** ctrath has quit IRC | 21:49 | |
mriedem | yeah i had to remove the commit message change so i can push it again | 21:49 |
mriedem | i think i'm done now | 21:50 |
mriedem | and leaving | 21:50 |
*** mriedem has quit IRC | 21:51 | |
*** signed8bit_ZZZzz is now known as signed8bit | 21:55 | |
*** karimb has quit IRC | 21:55 | |
*** subscope_ has quit IRC | 21:56 | |
*** burt has quit IRC | 21:57 | |
*** su_zhang_ has quit IRC | 22:00 | |
*** ijw has quit IRC | 22:02 | |
openstackgerrit | Jim Rollenhagen proposed openstack/nova: Ironic: Fix bad capacity reporting if instance_info is unset https://review.openstack.org/230487 | 22:02 |
jroll | lascii: superdan fffuuuu | 22:03 |
jroll | when I fixed that test I nuked my stupid pep8 fixc | 22:03 |
jroll | fix* | 22:03 |
superdan | done | 22:03 |
*** xyang1 has quit IRC | 22:03 | |
jroll | thanks | 22:04 |
*** ijw has joined #openstack-nova | 22:04 | |
*** SourabhP has quit IRC | 22:05 | |
*** bnemec has quit IRC | 22:06 | |
*** yamahata has joined #openstack-nova | 22:07 | |
*** VW has joined #openstack-nova | 22:08 | |
*** dave-mccowan has quit IRC | 22:08 | |
*** eglynn has quit IRC | 22:08 | |
*** dimsum__ has quit IRC | 22:09 | |
*** SourabhP has joined #openstack-nova | 22:09 | |
*** stevemar has quit IRC | 22:14 | |
*** stevemar has joined #openstack-nova | 22:14 | |
*** SourabhP has quit IRC | 22:16 | |
openstackgerrit | Deepti Ramakrishna proposed openstack/nova-specs: Data Security Enforcements In Nova https://review.openstack.org/230677 | 22:16 |
*** zz_john5223 is now known as john5223 | 22:18 | |
*** stevemar has quit IRC | 22:18 | |
*** pm90_ has joined #openstack-nova | 22:24 | |
*** lhcheng has quit IRC | 22:24 | |
*** pm90___ has joined #openstack-nova | 22:25 | |
*** pm90__ has quit IRC | 22:25 | |
*** VW_ has joined #openstack-nova | 22:26 | |
*** su_zhang_ has joined #openstack-nova | 22:26 | |
*** jwcroppe has quit IRC | 22:26 | |
*** VW has quit IRC | 22:29 | |
*** pm90_ has quit IRC | 22:29 | |
*** subscope has quit IRC | 22:30 | |
*** VW_ has quit IRC | 22:30 | |
openstackgerrit | melanie witt proposed openstack/nova: Check DBReferenceError foreign key in Instance.save https://review.openstack.org/228660 | 22:35 |
openstackgerrit | melanie witt proposed openstack/nova: Fix Instance unit test for DBReferenceError https://review.openstack.org/228659 | 22:35 |
*** obedmr has quit IRC | 22:36 | |
*** rustlebee is now known as russellb | 22:39 | |
*** SourabhP has joined #openstack-nova | 22:40 | |
*** david-lyle has quit IRC | 22:45 | |
*** edmondsw has quit IRC | 22:46 | |
*** david-lyle has joined #openstack-nova | 22:47 | |
*** ijuwang has quit IRC | 22:47 | |
*** jasondotstar is now known as jasondotstar|afk | 22:48 | |
*** marzif has quit IRC | 22:49 | |
*** ijw has quit IRC | 22:51 | |
*** pixelbeat has quit IRC | 22:51 | |
*** IanGovett has quit IRC | 22:55 | |
*** signed8b_ has joined #openstack-nova | 22:57 | |
*** jwcroppe has joined #openstack-nova | 22:58 | |
*** signed8bit has quit IRC | 22:59 | |
*** amotoki has joined #openstack-nova | 22:59 | |
*** jwcroppe has quit IRC | 22:59 | |
*** jwcroppe has joined #openstack-nova | 23:00 | |
*** ijw has joined #openstack-nova | 23:01 | |
*** ijw has quit IRC | 23:01 | |
*** dimsum__ has joined #openstack-nova | 23:02 | |
*** amotoki has quit IRC | 23:04 | |
*** otter768 has quit IRC | 23:04 | |
*** otter768 has joined #openstack-nova | 23:05 | |
*** jwcroppe has quit IRC | 23:05 | |
*** su_zhang_ has quit IRC | 23:05 | |
*** eharney has quit IRC | 23:09 | |
*** alejandrito has quit IRC | 23:10 | |
*** MVenesio has joined #openstack-nova | 23:17 | |
*** MVenesio has quit IRC | 23:18 | |
*** electroc_ has quit IRC | 23:18 | |
*** electrocucaracha has joined #openstack-nova | 23:19 | |
*** electrocucaracha has quit IRC | 23:19 | |
*** manishg has joined #openstack-nova | 23:19 | |
*** kolesovdv has joined #openstack-nova | 23:21 | |
*** achanda_ has joined #openstack-nova | 23:22 | |
*** signed8b_ is now known as signed8bit_ZZZzz | 23:22 | |
*** hemna is now known as hemnafk | 23:24 | |
*** achanda has quit IRC | 23:25 | |
*** achanda_ has quit IRC | 23:26 | |
*** pm90_ has joined #openstack-nova | 23:30 | |
*** pm90___ has quit IRC | 23:34 | |
*** deva_irssi has quit IRC | 23:43 | |
*** dimsum__ has quit IRC | 23:46 | |
*** erhudy has quit IRC | 23:49 | |
*** diogogmt_ has joined #openstack-nova | 23:51 | |
*** SourabhP has quit IRC | 23:51 | |
*** diogogmt has quit IRC | 23:52 | |
*** diogogmt_ is now known as diogogmt | 23:52 | |
*** tjones has joined #openstack-nova | 23:52 | |
*** pm90_ has quit IRC | 23:54 | |
*** tjones has left #openstack-nova | 23:54 | |
*** diogogmt has quit IRC | 23:54 | |
*** diogogmt has joined #openstack-nova | 23:56 | |
*** otter768 has quit IRC | 23:56 | |
*** otter768 has joined #openstack-nova | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!