Friday, 2015-10-02

*** SourabhP has quit IRC00:00
*** yamahata has quit IRC00:01
*** edmondsw has quit IRC00:01
*** mgoddard has joined #openstack-nova00:02
*** diogogmt has quit IRC00:03
*** knikolla has quit IRC00:06
*** kse has joined #openstack-nova00:07
*** su_zhang_ has quit IRC00:08
*** ctrath has quit IRC00:08
*** VW has joined #openstack-nova00:09
*** tsekiyam_ has joined #openstack-nova00:09
*** mtanino has quit IRC00:12
*** mgoddard has quit IRC00:13
*** tsekiyama has quit IRC00:13
*** tsekiyam_ has quit IRC00:14
*** Kennan has quit IRC00:16
*** mgoddard has joined #openstack-nova00:17
dimssdague: looks like this partial ncpu job is green - https://jenkins06.openstack.org/job/gate-grenade-dsvm-partial-ncpu/6497/console00:17
*** tjones has quit IRC00:19
*** Daisy has quit IRC00:22
*** mgoddard has quit IRC00:22
*** mgoddard has joined #openstack-nova00:27
*** asettle is now known as asettle-afk00:29
*** markvoelker has joined #openstack-nova00:30
*** jwcroppe has joined #openstack-nova00:32
*** dsanders has quit IRC00:33
openstackgerritDavanum Srinivas (dims) proposed openstack/nova: Update rpc version aliases for liberty  https://review.openstack.org/23013200:34
dimsmelwitt: done!00:34
dimsyes, the last 1.15 too00:34
melwittdims: okay :) I realized I forgot to also highlight that one the first time00:35
*** cfriesen has quit IRC00:35
*** markvoelker has quit IRC00:35
dansmithmelwitt: oops, thanks for catching those00:36
dansmithI was going fast00:36
dimsmelwitt: i totally skipped the comments as i was just trying to see if i could get the grenade to pass and thankfully dan picked it up00:36
dimsthanks to both of you!00:36
melwittdansmith: yeah, I figured :)00:37
*** tpeoples has quit IRC00:38
dansmithoof, still another hour at least for the requirements patch to merge00:38
*** mgoddard has quit IRC00:39
dimsdansmith: which one?00:42
dansmithdims: the pillow fix00:42
dansmitheverything south of that is going to fail00:42
*** VW has quit IRC00:42
dimsdansmith: ah yes00:42
*** mgoddard has joined #openstack-nova00:42
*** VW has joined #openstack-nova00:43
*** achanda has quit IRC00:47
*** VW has quit IRC00:47
*** ctrath has joined #openstack-nova00:50
*** ctrath has quit IRC00:51
*** mgoddard has quit IRC00:52
openstackgerritDan Smith proposed openstack/nova: Extend the ServiceTooOld exception with more data  https://review.openstack.org/23022700:54
*** exploreshaifali has joined #openstack-nova00:57
*** baoli has joined #openstack-nova00:59
*** gyee has quit IRC00:59
*** baoli has quit IRC01:00
*** baoli has joined #openstack-nova01:00
*** mgoddard has joined #openstack-nova01:01
*** baoli_ has joined #openstack-nova01:01
*** EinstCrazy has joined #openstack-nova01:02
*** baoli has quit IRC01:04
*** knikolla has joined #openstack-nova01:06
*** mgoddard has quit IRC01:07
*** yamahata has joined #openstack-nova01:08
*** knikolla has quit IRC01:11
*** mgoddard has joined #openstack-nova01:11
*** pm90_ has joined #openstack-nova01:11
*** exploreshaifali has quit IRC01:11
*** EinstCrazy has quit IRC01:12
*** ctrath has joined #openstack-nova01:14
*** davideagnello has quit IRC01:16
*** baoli_ has quit IRC01:17
*** whenry has quit IRC01:17
*** setuid has quit IRC01:18
*** setuid has joined #openstack-nova01:20
*** apoorvad has quit IRC01:24
*** su_zhang_ has joined #openstack-nova01:26
*** mgoddard has quit IRC01:30
*** su_zhang_ has quit IRC01:30
*** ssurana has quit IRC01:30
*** apoorvad has joined #openstack-nova01:31
*** vilobhmm11 has quit IRC01:33
*** dims has quit IRC01:34
*** mgoddard has joined #openstack-nova01:34
*** yamahata has quit IRC01:34
*** mudassirlatif has quit IRC01:34
*** mdrabe has joined #openstack-nova01:37
*** zzzeek has joined #openstack-nova01:40
*** angdraug has quit IRC01:44
*** mestery has quit IRC01:45
*** mestery has joined #openstack-nova01:46
*** EinstCrazy has joined #openstack-nova01:46
*** ssurana has joined #openstack-nova01:49
*** achanda has joined #openstack-nova01:51
*** nelsnelson has quit IRC01:51
*** nelsnelson has joined #openstack-nova01:52
*** penick has quit IRC01:52
*** unicell has quit IRC01:52
*** mgoddard has quit IRC01:55
*** asettle-afk is now known as asettle01:55
* tonyb waits for a flurry of g-r syncs01:56
*** mgoddard has joined #openstack-nova01:59
*** signed8bit has joined #openstack-nova02:02
mriedemalaski: at some point tomorrow you might want to look at this, i'm scratching my head over why the cells job is passing on the tempest compute api security group tests if cells v1 doesn't support security groups02:03
mriedemhttp://logs.openstack.org/43/226043/10/check/gate-tempest-dsvm-cells/b28ebdb/console.html#_2015-09-29_18_44_27_26602:03
*** browne has quit IRC02:03
mriedemrunning from the change that enables those tests in the blacklist rc file https://review.openstack.org/#/c/226043/02:03
*** nelsnelson has quit IRC02:05
*** mgoddard has quit IRC02:05
*** nelsnelson has joined #openstack-nova02:05
*** rfolco has joined #openstack-nova02:07
*** mcarden has quit IRC02:12
*** mgoddard has joined #openstack-nova02:13
*** jwcroppe has quit IRC02:13
*** dsanders has joined #openstack-nova02:14
*** dave-mccowan has quit IRC02:14
*** EinstCrazy has quit IRC02:14
*** apoorvad_ has joined #openstack-nova02:15
*** apoorvad has quit IRC02:18
*** dsanders has quit IRC02:18
*** apoorvad_ has quit IRC02:19
*** mgoddard has quit IRC02:19
*** ctrath has quit IRC02:23
*** VW has joined #openstack-nova02:24
*** VW has quit IRC02:26
*** VW has joined #openstack-nova02:26
*** mgoddard has joined #openstack-nova02:27
openstackgerritTony Breeds proposed openstack/nova: Add Pillow to test-requirements.txt  https://review.openstack.org/23024502:31
*** pm90_ has quit IRC02:32
*** markvoelker has joined #openstack-nova02:32
*** mgoddard has quit IRC02:35
*** markvoelker has quit IRC02:36
*** signed8bit has quit IRC02:40
*** zzzeek has quit IRC02:42
*** mgoddard has joined #openstack-nova02:43
*** nelsnelson has quit IRC02:44
*** r-daneel has quit IRC02:44
*** nelsnelson has joined #openstack-nova02:46
*** otter768 has quit IRC02:47
*** mgoddard has quit IRC02:48
*** otter768 has joined #openstack-nova02:48
*** mgoddard has joined #openstack-nova02:49
*** asettle is now known as asettle-napnap02:49
*** asettle-napnap has quit IRC02:50
*** signed8bit has joined #openstack-nova02:51
*** browne has joined #openstack-nova02:51
*** stevemar has joined #openstack-nova02:54
*** ferest has joined #openstack-nova02:55
openstackgerritMatt Riedemann proposed openstack/nova: VMware: raise NotImplementedError for live migration methods  https://review.openstack.org/22889302:57
*** stevemar has quit IRC02:59
*** ferest has quit IRC03:00
*** nelsnelson has quit IRC03:02
*** changbl has joined #openstack-nova03:03
*** rfolco has quit IRC03:07
*** agireud has joined #openstack-nova03:08
*** changbl has quit IRC03:08
*** knikolla has joined #openstack-nova03:10
*** knikolla has quit IRC03:13
*** knikolla has joined #openstack-nova03:14
*** tpeoples has joined #openstack-nova03:15
*** mriedem has quit IRC03:15
*** baoli has joined #openstack-nova03:20
*** mdrabe has quit IRC03:20
*** mgoddard has quit IRC03:24
*** mgoddard has joined #openstack-nova03:25
*** stevemar_ has joined #openstack-nova03:28
*** links has joined #openstack-nova03:31
*** signed8bit has quit IRC03:33
*** mgoddard has quit IRC03:34
*** knikolla has quit IRC03:37
*** mgoddard has joined #openstack-nova03:39
*** otter768 has quit IRC03:40
*** otter768 has joined #openstack-nova03:40
*** stevemar_ has quit IRC03:41
*** stevemar has joined #openstack-nova03:42
*** salv-orlando has joined #openstack-nova03:43
*** mgoddard has quit IRC03:44
*** salv-orl_ has quit IRC03:45
*** mgoddard has joined #openstack-nova03:49
*** nelsnelson has joined #openstack-nova03:51
tonybThems that can please look at: https://review.openstack.org/#/c/230245/ as a tempoary de-wedge the gate fix03:54
*** tpeoples has quit IRC03:57
*** mgoddard has quit IRC03:57
*** bnemec has quit IRC04:02
*** mgoddard has joined #openstack-nova04:06
*** stevemar_ has joined #openstack-nova04:07
*** stevemar has quit IRC04:09
*** yamahata has joined #openstack-nova04:10
*** ssurana has quit IRC04:11
*** mgoddard has quit IRC04:14
*** ssurana has joined #openstack-nova04:15
*** baoli has quit IRC04:16
*** VW has quit IRC04:19
*** VW has joined #openstack-nova04:20
*** mgoddard has joined #openstack-nova04:22
*** VW has quit IRC04:24
*** yamahata has quit IRC04:26
*** mgoddard has quit IRC04:29
*** markvoelker has joined #openstack-nova04:33
*** pm90_ has joined #openstack-nova04:33
*** stevemar has joined #openstack-nova04:34
*** stevemar_ has quit IRC04:34
*** mgoddard has joined #openstack-nova04:36
*** vilobhmm11 has joined #openstack-nova04:38
*** stevemar has quit IRC04:39
*** yasu has joined #openstack-nova04:44
*** apoorvad has joined #openstack-nova04:48
*** vilobhmm111 has joined #openstack-nova04:48
*** stevemar has joined #openstack-nova04:50
*** vilobhmm11 has quit IRC04:50
*** yasu has quit IRC04:52
*** nelsnelson has quit IRC04:55
*** twinklechawla has joined #openstack-nova04:56
*** jwcroppe has joined #openstack-nova04:58
*** asettle has joined #openstack-nova05:02
*** jwcroppe has quit IRC05:02
*** mgoddard has quit IRC05:02
*** vishwanathj has quit IRC05:04
*** crinkle has quit IRC05:04
*** stevemar has quit IRC05:05
*** stevemar has joined #openstack-nova05:06
*** mragupat has joined #openstack-nova05:06
*** mgoddard has joined #openstack-nova05:07
*** markvoelker has quit IRC05:07
openstackgerritMichael Still proposed openstack/nova-specs: Locking servers by service token  https://review.openstack.org/20388005:08
*** stevemar has quit IRC05:10
*** mgoddard has quit IRC05:11
*** mudassirlatif has joined #openstack-nova05:11
*** agireud has quit IRC05:19
*** mgoddard has joined #openstack-nova05:20
*** twinklechawla has quit IRC05:22
*** apoorvad has quit IRC05:24
*** mgoddard has quit IRC05:24
*** nkrinner has joined #openstack-nova05:27
*** agireud has joined #openstack-nova05:29
*** yasu has joined #openstack-nova05:32
*** mgoddard has joined #openstack-nova05:33
openstackgerritvenkatesh proposed openstack/nova: make the driver.Scheduler as abstract class  https://review.openstack.org/21201605:33
*** twinklechawla has joined #openstack-nova05:34
*** asettle has quit IRC05:37
*** mgoddard has quit IRC05:41
*** mgoddard has joined #openstack-nova05:42
*** su_zhang_ has joined #openstack-nova05:43
*** twinklechawla has quit IRC05:43
*** e0ne has joined #openstack-nova05:45
*** mgoddard has quit IRC05:48
*** stevemar has joined #openstack-nova05:50
*** SourabhP has joined #openstack-nova05:50
*** stevemar_ has joined #openstack-nova05:51
*** nelsnelson has joined #openstack-nova05:51
*** mgoddard has joined #openstack-nova05:52
*** oomichi has quit IRC05:53
*** SourabhP_ has joined #openstack-nova05:54
*** SourabhP has quit IRC05:54
*** SourabhP_ is now known as SourabhP05:54
*** stevemar has quit IRC05:55
*** nelsnelson has quit IRC05:56
*** e0ne has quit IRC05:56
*** mgoddard has quit IRC05:58
*** mgoddard has joined #openstack-nova05:58
openstackgerritPawel Koniszewski proposed openstack/nova-specs: Force live migration  https://review.openstack.org/22904005:59
*** twinklechawla has joined #openstack-nova06:03
*** SourabhP has quit IRC06:03
*** SourabhP has joined #openstack-nova06:06
*** unicell has joined #openstack-nova06:06
*** su_zhang_ has quit IRC06:07
*** SourabhP has quit IRC06:13
*** SourabhP has joined #openstack-nova06:14
*** scheuran has joined #openstack-nova06:16
*** twinklechawla has quit IRC06:16
*** Venkatesh has joined #openstack-nova06:17
*** twinklechawla has joined #openstack-nova06:17
*** garyk has quit IRC06:18
Venkateshjohnthetubaguy : Can you review the patch https://review.openstack.org/#/c/212016/06:18
Venkatesh?06:18
*** garyk1 has joined #openstack-nova06:18
VenkateshI removed pass in abc method06:18
*** twinklechawla has quit IRC06:19
*** twinklechawla has joined #openstack-nova06:21
*** nkrinner has quit IRC06:22
*** nkrinner has joined #openstack-nova06:22
*** SourabhP has quit IRC06:23
*** mgoddard has quit IRC06:23
*** mgoddard has joined #openstack-nova06:24
*** SourabhP has joined #openstack-nova06:25
*** twinklechawla has quit IRC06:26
*** vilobhmm111 has quit IRC06:29
*** mragupat has quit IRC06:30
openstackgerritAdelina Tuvenie proposed openstack/nova: Replace function.func_name with function.__name__  https://review.openstack.org/22957806:36
*** medberry has quit IRC06:39
*** mgoddard has quit IRC06:40
*** mgoddard has joined #openstack-nova06:44
*** med_ has joined #openstack-nova06:45
*** med_ is now known as Guest4345806:46
*** mgoddard has quit IRC06:49
*** rdopiera has joined #openstack-nova06:51
*** crinkle has joined #openstack-nova06:51
*** pm90_ has quit IRC06:51
*** achanda has quit IRC06:51
*** nelsnelson has joined #openstack-nova06:52
*** mgoddard has joined #openstack-nova06:54
*** romainh has joined #openstack-nova06:55
*** nelsnelson has quit IRC06:57
*** rdopiera has quit IRC06:58
*** rdopiera has joined #openstack-nova06:58
*** achanda has joined #openstack-nova06:59
*** mgoddard has quit IRC07:00
*** lpetrut has joined #openstack-nova07:03
*** ganeshk has joined #openstack-nova07:05
*** yasu has quit IRC07:06
openstackgerritAngapov Vasily proposed openstack/nova: Added RBD direct image download scheme for Nova  https://review.openstack.org/23029507:07
ganeshkhello, I created one controller and compute node on two vms. Then, created instance on each using "nova boot" from respective commad line. How do I conform that instance belong to particular node.?07:07
*** agireud has quit IRC07:08
*** achanda has quit IRC07:10
*** mgoddard has joined #openstack-nova07:12
*** agireud has joined #openstack-nova07:13
*** achanda has joined #openstack-nova07:15
openstackgerritAngapov Vasily proposed openstack/nova: Added RBD direct image download scheme for Nova  https://review.openstack.org/23029507:15
rdopieraganeshk: if you do "server show" on the instance, it lists the name of its hypervisor07:18
*** jichen has joined #openstack-nova07:18
*** Marga_ has quit IRC07:21
*** mudassirlatif has quit IRC07:22
ganeshkrdopiera I took cirros image for instance. command not working07:22
ganeshkrdopiera:07:25
*** SourabhP_ has joined #openstack-nova07:25
*** SourabhP has quit IRC07:26
*** SourabhP_ is now known as SourabhP07:26
ganeshkrdopiera: "virsh list --all" command is listing all instances on controller node.07:27
*** SourabhP has quit IRC07:34
*** SourabhP has joined #openstack-nova07:36
*** matrohon has joined #openstack-nova07:38
*** jlanoux has joined #openstack-nova07:39
ganeshkCan anyone help me create an instance on specific compute node from controller node.?07:41
*** achanda has quit IRC07:42
*** SourabhP has quit IRC07:43
*** haomaiwang has joined #openstack-nova07:44
*** mudassirlatif has joined #openstack-nova07:45
*** yasu has joined #openstack-nova07:46
*** openstackgerrit has quit IRC07:46
*** openstackgerrit has joined #openstack-nova07:47
*** garyk1 has quit IRC07:48
rdopieraganeshk: what is "not working" exactly?07:50
ganeshkserver show07:50
rdopierawhat did you do exactly?07:51
ganeshkssh cirros@<ip of instance>07:52
ganeshkserver show07:52
*** nelsnelson has joined #openstack-nova07:53
bauzasganeshk: mmm, see the topic name07:53
rdopieradon't ssh into the instance, just run your 'openstack' command line, and do 'server list' then 'server show <UUID>'07:53
bauzasganeshk: you can use aggregates or AZs for choosing which compute node07:54
rdopierajust like you did nova boot07:54
*** mgoddard has quit IRC07:54
bauzasgood morning Nova btw.07:56
*** bauzas is now known as bauwser07:56
*** haypo has joined #openstack-nova07:56
*** SourabhP has joined #openstack-nova07:58
*** nelsnelson has quit IRC07:58
*** mgoddard has joined #openstack-nova07:58
*** ganeshk has quit IRC07:59
*** matrohon has quit IRC08:00
*** haomaiwang has quit IRC08:01
*** haomaiwa_ has joined #openstack-nova08:01
*** stevemar_ has quit IRC08:01
*** xgsa has joined #openstack-nova08:01
*** matrohon has joined #openstack-nova08:01
*** stevemar has joined #openstack-nova08:02
bauwsertonyb: still around, captain ?08:03
*** lpetrut has quit IRC08:03
bauwsertonyb: I need more insights on the Pillow issue (sounded very student pillow war to me)08:03
*** derekh has joined #openstack-nova08:04
*** jichen has quit IRC08:04
*** browne has quit IRC08:04
bauwsertonyb: so IIRC, merging https://review.openstack.org/#/c/230245/1 would help but it would need a rebase for any change?08:04
haypohi. dummy question: is master open for Mitaka?08:05
bauwserhaypo: yep, see setup.cfg08:05
haypobauwser: that's great, thanks08:05
*** jichen has joined #openstack-nova08:05
bauwserhaypo: Liberty has a stable branch but is not yet released08:05
*** danpb has joined #openstack-nova08:06
*** stevemar has quit IRC08:06
haypobauwser: ah ok, i was waiting for the RC1, i expected the switch to mitaka to happen only after the RC108:06
*** alex_klimov has joined #openstack-nova08:07
haypoworking on a stable branch makes sense, ok08:07
bauwserhaypo: http://lists.openstack.org/pipermail/openstack-dev/2015-September/075605.html08:07
bauwserhaypo: RC1 was released08:07
bauwserhaypo: for the moment, we leave operators to look at RC1 to create bugs if needed08:07
bauwserand then the stable team will open the RC2 window (for merging the needed backports)08:08
haypobauwser: "RC1 was released" oops, i missed the announcement :-p08:08
bauwser:)08:09
*** lpetrut has joined #openstack-nova08:13
*** yasu has quit IRC08:15
*** yasu has joined #openstack-nova08:16
bauwserjohnthetubaguy: not sure you saw http://lists.openstack.org/pipermail/openstack-dev/2015-October/076030.html but we need https://review.openstack.org/#/c/230245/1 as a workaround for unbreaking the gate08:16
*** oomichi has joined #openstack-nova08:16
bauwserjohnthetubaguy: then I'll rebase https://review.openstack.org/#/c/230132/08:16
bauwserjohnthetubaguy: which is unblocking grenade IIRC08:17
*** pixelbeat has joined #openstack-nova08:18
*** jichen has quit IRC08:18
*** harlowja has quit IRC08:19
*** kylek3h_ has joined #openstack-nova08:19
*** jichen has joined #openstack-nova08:19
bauwserdanpb: actually, it seems you're up too :)08:20
bauwserdanpb: if you can see the above ^, we need https://review.openstack.org/#/c/230245/1 to have Jenkins happy08:20
*** jichen has quit IRC08:21
*** pedroalvarez has quit IRC08:21
*** jichen has joined #openstack-nova08:21
bauwserooooh, oomichi there too :D08:22
*** jichen has quit IRC08:22
bauwseroomichi: your help could be awesome for +2'ing https://review.openstack.org/#/c/230245/108:22
*** pedroalvarez has joined #openstack-nova08:22
*** kylek3h has quit IRC08:22
*** jichen has joined #openstack-nova08:22
*** jichen has quit IRC08:23
oomichibauwser: +A :)08:23
*** jichen has joined #openstack-nova08:23
bauwsercool08:23
*** jwcroppe has joined #openstack-nova08:23
bauwseroomichi: thanks :)08:24
*** jistr has joined #openstack-nova08:24
*** ZZelle has quit IRC08:27
*** mgoddard has quit IRC08:29
*** ganeshk has joined #openstack-nova08:29
*** SourabhP has quit IRC08:29
ganeshkI want to create an instance on compute node. Please help me some way to do that.08:30
*** kylek3h_ has quit IRC08:32
*** mgoddard has joined #openstack-nova08:33
*** alex_klimov has quit IRC08:34
*** alex_klimov has joined #openstack-nova08:34
*** kylek3h_ has joined #openstack-nova08:35
*** mgoddard has quit IRC08:38
*** jwcroppe has quit IRC08:40
openstackgerritBalazs Gibizer proposed openstack/nova-specs: Add notification for service status change  https://review.openstack.org/18235008:42
*** rotbeard has joined #openstack-nova08:43
openstackgerritlyanchih proposed openstack/nova: libvirt - Unrescue will not remove rescue disk when image_type=rbd  https://review.openstack.org/20576608:43
*** alexschm has joined #openstack-nova08:44
*** mgoddard has joined #openstack-nova08:47
*** links has quit IRC08:50
openstackgerritlyanchih proposed openstack/nova: libvirt: serial console ports count upper limit needs to be checked  https://review.openstack.org/20737308:50
johnthetubaguybauwser: sounds like thats been approved a few times now08:50
*** jichen has quit IRC08:50
bauwserjohnthetubaguy: yup, oomichi did08:51
bauwserjohnthetubaguy: so I'm monitoring zuul to repropose https://review.openstack.org/#/c/230132/408:51
*** karimb has joined #openstack-nova08:51
johnthetubaguyoh, we always forget the alias08:52
*** jichen has joined #openstack-nova08:52
bauwserjohnthetubaguy: yup, and AFAIU, it blocks grenade08:53
*** mgoddard has quit IRC08:53
johnthetubaguyit shouldn't08:53
johnthetubaguyyou can just use the version number08:53
johnthetubaguyits just a helping hand08:54
bauwserjohnthetubaguy: I don't have the whole story, I saw something like that being discussed yesterday08:54
*** aix has joined #openstack-nova08:54
johnthetubaguyyeah, its not a hard fail, its just handy08:54
johnthetubaguyI added this in here: https://wiki.openstack.org/wiki/Nova/ReleaseChecklist08:54
*** jichen has quit IRC08:54
*** mgoddard has joined #openstack-nova08:54
johnthetubaguyits just nicer to set the name in the conf file rather than the number, but both should should, if I remember that all correctly08:55
openstackgerritlyanchih proposed openstack/nova: Add unit tests for libvirt fibrechannel/iser/iscsi/aoe volume drivers after os-brick  https://review.openstack.org/20840108:55
bauwser(09:51:18) dims_: [22:42:25] sdague: mriedem: the grenade failed later - looks like we need to define liberty levels in master? (WIP - https://review.openstack.org/230132)08:55
bauwserjohnthetubaguy: ^08:55
bauwserjohnthetubaguy: anyway, I don't want to overthink08:55
bauwserjohnthetubaguy: I was just wondering if a recheck was enough for https://review.openstack.org/#/c/230132/4 or if I should rebase08:56
*** BobBall has quit IRC08:56
bauwserjohnthetubaguy: given a recheck picks the SHA on top of the latest master IIRC08:56
*** mudassirlatif has quit IRC08:56
*** jichen has joined #openstack-nova08:57
*** e0ne has joined #openstack-nova08:57
*** jichen has quit IRC08:57
tonybbauwser: Yeah, you wont need to rebase just recheck once 230245 merges08:58
*** jichen has joined #openstack-nova08:58
bauwsertonyb: okay, cool08:58
bauwsertonyb: was there a e-r query ?08:58
tonybbauwser: but I'm not really here08:58
*** jichen has quit IRC08:58
bauwserat least a bug08:58
bauwsertonyb: lol08:59
bauwserenjoy your WE :)08:59
tonybbauwser: Yeah ther are both Matt made them I shoudl have done it :/08:59
*** ssurana has quit IRC08:59
bauwsertonyb: cool, will find08:59
bauwsertonyb: go off !08:59
*** jichen has joined #openstack-nova08:59
tonybhttps://review.openstack.org/#/c/230256/09:00
tonybbauwser: ^^09:00
*** haomaiwa_ has quit IRC09:01
*** twinklechawla has joined #openstack-nova09:01
*** twinklechawla has left #openstack-nova09:01
bauwsertonyb: coolness :)09:01
*** ganeshk has quit IRC09:01
*** haomaiwang has joined #openstack-nova09:01
*** markvoelker has joined #openstack-nova09:04
*** markvoelker has quit IRC09:09
openstackgerritAndreas Jaeger proposed openstack/nova: Cleanup of Translations  https://review.openstack.org/23032809:10
*** lpetrut has quit IRC09:10
*** Madasi has quit IRC09:14
*** rods has quit IRC09:14
*** openstack has joined #openstack-nova09:22
johnthetubaguyyeah09:22
johnthetubaguythats the client though, I think?09:22
*** alexpilotti has quit IRC09:22
*** e0ne has quit IRC09:23
*** openstackstatus has joined #openstack-nova09:23
*** ChanServ sets mode: +v openstackstatus09:23
*** ndipanov has joined #openstack-nova09:23
bauwserjohnthetubaguy: yup09:23
bauwserjohnthetubaguy: lemme find you mriedem's changes09:23
bauwserjohnthetubaguy: but he was waiting for doffm to work on supporting 2.6 too09:24
bauwser(btw. pillow cap https://review.openstack.org/#/c/230245/1 is merged, anyone can resubmit a recheck)09:24
openstackgerritlyanchih proposed openstack/nova: Add unit tests for libvirt fibrechannel/iser/iscsi/aoe volume drivers after os-brick  https://review.openstack.org/20840109:25
bauwserjohnthetubaguy: https://review.openstack.org/#/c/230024/09:26
bauwserjohnthetubaguy: and https://review.openstack.org/#/c/230149/1 for supporting the console changes with v2.609:26
johnthetubaguybauwser: ah, yeah, thats the ones I am on right now, cool09:29
*** marzif has joined #openstack-nova09:29
openstackgerritBalazs Gibizer proposed openstack/nova-specs: Add support for shared volumes between guests  https://review.openstack.org/21250809:30
bauwserjohnthetubaguy: oh, ttx +2/+W the RC2 proposed patches, that's cool09:30
*** e0ne has joined #openstack-nova09:31
*** salv-orlando has quit IRC09:33
gibilxsli: hi! could you check back to the butfix https://review.openstack.org/#/c/221803/? I answered your concerns. Thanks!09:34
alexschmjohnthetubaguy: do you have some time to discuss the "serial console and live migration" bugfix?09:34
alexschmjohnthetubaguy: https://review.openstack.org/#/c/215102/09:34
*** gszasz has joined #openstack-nova09:35
alexschmjohnthetubaguy: Markus outlined that the change will only allow a live migration when the patch is present on the source and target hypervisor, which is the ehavior we'd like to have09:35
*** nelsnelson has joined #openstack-nova09:36
*** marzif has quit IRC09:37
johnthetubaguyalexschm: that breaks our upgrade process though09:37
*** marzif has joined #openstack-nova09:37
alexschmyou mean the process of upgrading nova code?09:38
johnthetubaguyalexschm: we support mixed versions of nova-compute during the upgrade, so during that time, live-migrate will be broken, which goes against our upgrade policy, as I understand it09:38
johnthetubaguyalexschm: yes, during a live upgrade of nova09:38
johnthetubaguyalexschm: you expand the DB, then roll the control plane to a new version (RPC pinned at old version), then slowly update each compute node, then unpin the control plane09:38
alexschmyeah that's right, but live migration (when using serial console) is broken without the patch also09:38
alexschmthe bugfix enables it in the first place, so there should not be any existing user expecting live migration to work fine without the patch09:39
johnthetubaguyalexschm: ah, good point, its broken before anyways, I just re-read, and I see we only touch the serial code path09:40
*** nelsnelson has quit IRC09:41
johnthetubaguyalexschm: oh wait...09:41
alexschmjohnthetubaguy: yes without the patch, the TCP ports used for serial console is not allocated on the target hypervisor, which can cause weird behvavior09:41
johnthetubaguyalexschm: I missed a bit, it does seem like you would get a KeyError during the upgrade09:41
alexschmthe port may be in use on the target already and the bookkepping of ports that are in use is broken after the migration09:42
johnthetubaguyalexschm: now just checking for the presence of the host key should be enough09:42
johnthetubaguyalexschm: I mean for cases there there are no serial consoles09:42
johnthetubaguyoh wait, thats nonsense09:42
alexschmwhen there are no serial consoles, I think the attributes are not read from res_data, but let me check that again09:44
*** dims__ has joined #openstack-nova09:44
johnthetubaguyalexschm: so for a moment there, I was reading the setting of the attributes as reading, somehow09:46
johnthetubaguyalexschm: yeah, sorry about the delay on that, I missed the bit about it only affecting previously broken code, so no need to jump through hoops trying to make it work09:46
alexschmjohnthetubaguy: ok09:47
*** xgsa has quit IRC09:47
johnthetubaguyalexschm: it would be cool if we could get serial ports enabled in the new mutli host test that is testing live-migrate now09:47
alexschmjohnthetubaguy: I looked through the code again and the attributes should only be read when serial console is enabled09:47
johnthetubaguyalexschm: yeah, it looks like we are safe :)09:47
alexschmjohnthebuaguy: yeah I agree, not sure if VNC or spice is used there right now...09:48
*** Venkatesh_ has quit IRC09:48
johnthetubaguyalexschm: I would normally say add a note in the git commit message to say about that, but its not worth it given you would loose the +2 you already have on there09:48
*** Venkatesh_ has joined #openstack-nova09:48
alexschmjohnthetubaguy: ok I'll think about the multi host test and check what's used there, it would be great to have a new test case there for live migration + serial console09:50
johnthetubaguyalexschm: thanks, I am keen we stop breaking live-migrate soon!09:54
*** claudiub has joined #openstack-nova09:55
*** xgsa has joined #openstack-nova09:56
openstackgerritDaniel Berrange proposed openstack/nova-specs: Virtual guest device role tagging  https://review.openstack.org/19566209:58
*** haomaiwang has quit IRC10:01
*** haomaiwang has joined #openstack-nova10:01
openstackgerritTomi Juvonen proposed openstack/nova-specs: Get valid server state  https://review.openstack.org/19224610:04
*** exploreshaifali has joined #openstack-nova10:06
claudiubmriedem: on?10:10
*** Venkatesh_ has quit IRC10:10
*** twinklechawla has joined #openstack-nova10:12
*** MarcF has joined #openstack-nova10:12
*** pcaruana has joined #openstack-nova10:13
claudiubjohnthetubaguy: hello. We have a problem, our hyper-v ci builds are failing because there is no python-novaclient 2.30.1 relase on pypi.10:14
claudiubjohnthetubaguy: although that release exists on github10:15
johnthetubaguyclaudiub: oh dear, thats interesting10:15
johnthetubaguyclaudiub: how do you pick what to install?10:15
johnthetubaguyclaudiub: most folks are just using pip I guess10:15
claudiubjohnthetubaguy: http://64.119.130.115/nova/228141/7/devstack_logs/stack.sh.txt.gz10:16
claudiubjohnthetubaguy: No matching distribution found for python-novaclient===2.30.1 (from -c /opt/stack/requirements/upper-constraints.txt (line 263))10:16
*** twinklechawla has quit IRC10:16
*** Guest3515 is now known as PaulMurray10:16
*** IanGovett has joined #openstack-nova10:17
johnthetubaguyclaudiub: just digging a little10:18
claudiubjohnthetubaguy: this is the patch to openstack/releases for python-novaclient 2.30.1: https://review.openstack.org/#/c/229952/10:19
claudiubjohnthetubaguy: this is the patch to openstack/requirements, raising the upper-constraints to 2.30.1 https://review.openstack.org/#/c/229956/10:19
johnthetubaguyclaudiub: yes, just digging into requrrements10:20
openstackgerritsulochan-acharya proposed openstack/nova: xapi-tools: fixes cache cleaner script  https://review.openstack.org/20952610:20
*** e0ne has quit IRC10:21
johnthetubaguyclaudiub: so I got confused, thats only on the liberty branch, master still has 2.30.010:21
claudiubjohnthetubaguy: I thought master was on 2.3110:22
claudiubjohnthetubaguy: and yeah, that's for liberty10:22
johnthetubaguyits been released, but I don't think upper constraints have been raised10:22
johnthetubaguyhttps://github.com/openstack/requirements/blob/master/upper-constraints.txt#L26010:22
*** jichen has quit IRC10:23
claudiubjohnthetubaguy: 2.31.0 was tagged 18 hours ago10:23
bauwserjohnthetubaguy: yup I remember asking the question to mriedem, the .z version was for stable branches hence 2.30.1 for liberty and 2.31 for master10:23
*** jichen has joined #openstack-nova10:23
*** jichen has quit IRC10:24
claudiubyeah, that's what i remember as well10:24
johnthetubaguyclaudiub: so is your pypi mirror out of date?10:24
johnthetubaguyclaudiub: the install seems to work OK for me, and I see this: https://pypi.python.org/packages/source/p/python-novaclient/python-novaclient-2.30.1.tar.gz10:24
*** jichen has joined #openstack-nova10:24
johnthetubaguybauwser: we do actually use .Z on master as well at times10:24
claudiubjohnthetubaguy: let me check10:26
*** yasu has quit IRC10:26
bauwserjohnthetubaguy: oh okay10:29
*** e0ne has joined #openstack-nova10:34
*** mwagner_ has quit IRC10:34
*** Daisy has joined #openstack-nova10:35
*** jaypipes has joined #openstack-nova10:36
johnthetubaguyclaudiub: found a way to list versions: https://pypi.python.org/simple/python-novaclient/10:36
johnthetubaguybauwser: its just straight semver really, see 2.28.110:37
jaypipesmorning fellers.10:37
*** twinklechawla has joined #openstack-nova10:37
johnthetubaguyjaypipes: good morning10:37
*** gilliard_ has joined #openstack-nova10:37
*** gilliard_ is now known as teamazing_logbot10:37
PaulMurrayndipanov, you there? I have a couple of questions about https://review.openstack.org/#/c/221732/10:38
*** jaypipes is now known as leakypipes10:38
claudiubjohnthetubaguy: awesome, thanks.can't check the cache right now, the people who have access to it are in the us, so will have to ping them in a couple of hours.10:38
johnthetubaguyclaudiub: doh, no worries10:38
*** exploreshaifali has quit IRC10:39
*** Daisy has quit IRC10:40
*** rdo has quit IRC10:41
*** teamazing_logbot has left #openstack-nova10:42
*** BobBall has joined #openstack-nova10:43
*** rdo has joined #openstack-nova10:44
sdagueso, all our patches are blocked because of a huge chain of dependencies for a single sequence diagram10:44
*** exploreshaifali has joined #openstack-nova10:45
sdaguehttp://docs.openstack.org/developer/nova/vmstates.html the one at the bottom of that page10:45
sdaguejohnthetubaguy: how do you feel about just commenting that diagram out for now10:45
sdaguebecause, I'm not sure it's hugely useful10:45
*** twinklechawla1 has joined #openstack-nova10:45
johnthetubaguysdague: I think we had a fix in the pipe, but I am cool trying that too10:45
bauwsersdague: the Pillow change just merged10:45
johnthetubaguyyeah, I thought we just pinned it10:46
ndipanovPaulMurray, yeeees10:46
bauwsersdague: https://review.openstack.org/#/c/230245/110:46
sdaguedoesn't seem to help10:46
sdaguelook at the gate10:46
ndipanovlet me read the comments first10:46
sdaguewe've got 2 things failing in the gate10:46
sdaguewhich should be consuming that10:46
johnthetubaguysdague: ah, if we are still broken, lets just comment it out10:47
ndipanovok there are no comments10:47
bauwsersdague: tonyb's change makes the gate happy10:47
bauwsersdague: so I wonder if it's just a matter of rebasing10:47
*** ndipanov is now known as ndipanoff10:47
PaulMurrayndipanov, hi - I get the feeling you didn't believe the use case?10:47
ndipanoffthe Windows one - I believe10:48
johnthetubaguybauwser: hmm, so that patch did seem happy, thats true10:48
ndipanoffthe failover one10:48
*** twinklechawla has quit IRC10:48
PaulMurrayndipanoff, but apart from that - I think you preferred the swap volume option10:48
ndipanoffwell I think it's a bit of a stretch to say - if only we had this feature in nova we could easily do this kind of thing10:48
bauwsersdague: FWIW, asked just a recheck on https://review.openstack.org/#/c/230132/4 when tonyb's change mergede10:49
ndipanoffPaulMurray, well10:49
sdaguebauwser: right, there are things in the gate10:49
ndipanoffI don't like doing it this way10:49
sdaguethat are failing10:49
sdaguethose are already on top of that10:49
bauwsersdague: but that's perhaps needing a rebase, not just a recheckl10:49
PaulMurrayndipanoff, the use case has actually been implemented. They hack nova to make up for the fact it can't do it10:49
sdagueno, everything in the gate is rebased to master10:49
ndipanoffPaulMurray, get some more people to comment10:50
bauwsersdague: okay, I was lazy, I haven't checked zuul once the pillow cap merged, lemme look10:50
ndipanoffbut yes overall I prefer either doing shelve or adding a swap root volume10:50
PaulMurrayndipanoff, swap sounds more possible - shelve can dismantle the infrastructure, so it defeats the objective.10:51
PaulMurrayndipanoff, I am looking for the best way to acheive this, so very open to alternative suggestions10:51
PaulMurrayI realise there are issues to be dealt with10:51
*** frickler has quit IRC10:51
johnthetubaguyndipanoff: PaulMurray: oh, swap root makes sense, I guess we stop users booting something without a disk attached that way?10:51
ndipanoffyeah and probably a lot of other edge cases10:52
PaulMurrayjohnthetubaguy, yes, it means there is always a disk10:52
ndipanoffI really don't see what "flexibility" we lose10:52
bauwsersdague: so, for the moment, I can't tell whether 230132,4 is okay since it hasn't yet checked the failing jobs10:52
PaulMurrayndipanoff, not a lot I guess10:52
openstackgerritAngapov Vasily proposed openstack/nova: Added RBD direct image download scheme for Nova  https://review.openstack.org/23029510:53
sdaguebauwser: but you see all the fails at the top right10:53
bauwsersdague: but 230132,4 is probably the first one rechecked *after* tonyb's change merged10:53
PaulMurrayndipanoff, its to do with dictating when they move the disks and that the swap takes longer than just attach10:53
bauwsersdague: yup yup10:53
sdaguebauwser: that means the fix doesn't work10:53
ndipanoffPaulMurray, yeah I see in the doc10:53
PaulMurrayndipanoff, so it increases the failover time10:53
bauwsersdague: what I'm saying is that 230132 is the first that was rebased after the fix10:54
sdaguebauwser: no, what you are saying is that you don't understand how zuul works10:54
PaulMurrayndipanoff, but I agree that it can be a reasonable compromise10:54
sdague*everything* in the gate pipeline is rebased10:54
*** jichen has quit IRC10:54
bauwsersdague: okay, fair enough :)10:54
sdagueby zuul10:54
sdagueso it's mergable10:54
sdaguein one long rebase chain10:54
johnthetubaguyyeah, its all rebase on top of each other so it can merged in parallallel right?10:54
johnthetubaguyor something spelt correctly10:55
sdagueotherwise we wouldn't be guarunteed that we could actually merge after the tests run10:55
ndipanoffPaulMurray, get some more opinions - I may be overestimating how big of an impact this will have10:55
bauwserI see10:55
PaulMurrayndipanoff, ok - thanks10:55
ndipanoffwhat would be good is listing out what happens for all the nova operations10:55
*** ig0r_ has joined #openstack-nova10:55
ndipanoffso resize, delete, live-mig etc.10:55
*** jichen has joined #openstack-nova10:55
*** jichen has quit IRC10:55
sdagueunless something else is terribly broken here10:56
ndipanoffhow will this affect them10:56
bauwsersdague: so, IIUC, 230132 is rebased on top of 228744 ?10:56
PaulMurrayndipanoff, yes, I'll have a go10:56
sdagueyes10:56
ndipanoffPaulMurray, excellent10:56
*** ig0r_ has quit IRC10:56
sdaguewell, right now, no10:56
sdaguebecause, 744 failed10:56
sdagueso it got pulled out of the rebase line10:56
bauwsersdague: see, 230132 just passed pep810:56
*** e0ne has quit IRC10:57
sdaguehttp://docs.openstack.org/infra/publications/zuul/#(18)10:57
bauwsersdague: gotcha10:57
*** jichen has joined #openstack-nova10:57
*** jichen has quit IRC10:58
bauwsersdague: since 230132 is now rebased on master containing the cap, we should be good while it was not the case previously because it was rebased on top of 744 which was on top of a master not containing the fix AFAICU10:58
sdagueright, but the fact that the other patches did not means something is way out of whack here, and this probably passed by accident given that not all images in all clouds are synced10:58
ndipanoffjohnthetubaguy, status code change does not need a microversion right?10:58
bauwserokay10:58
sdaguebauwser: you still do not seem to understand that 744 is also on top of that patch10:59
johnthetubaguyndipanoff: it probably does, usually we add an alias to hide some changes like that10:59
sdaguethe patches that are failing also have that patch in place10:59
ndipanoffsigh10:59
johnthetubaguyndipanoff: mostly for the folks who don't expect that status to exist10:59
ndipanoffjohnthetubaguy, https://review.openstack.org/#/c/216746/10:59
bauwsersdague: okay, I trust you10:59
johnthetubaguyndipanoff: we don't want to break them10:59
*** takedakn has joined #openstack-nova10:59
ndipanoffit's 500 -> 404 in some obscure cases11:00
johnthetubaguyndipanoff: sorry, so we don't bump for those11:00
ndipanoffas I thought11:00
*** jichen has joined #openstack-nova11:00
*** jichen has quit IRC11:00
*** eglynn has joined #openstack-nova11:00
johnthetubaguyndipanoff: I thought you mean server/instance status for some reason11:00
bauwsersdague: so, even if 744 is failing, 132 is still rebased on top of it, I see11:00
johnthetubaguyndipanoff: we did write that down somewhere, let me check11:00
ndipanoffcool11:00
sdaguebauwser: no11:00
*** haomaiwang has quit IRC11:01
sdaguethe fix patch merged11:01
*** twinklechawla1 has quit IRC11:01
*** haomaiwang has joined #openstack-nova11:01
sdagueevery nova patch in the gate is rebased on top of that11:01
bauwsersdague: so we're good ? :)11:01
sdagueevery nova patch in the gate is rebased on top of any nova patches in front of it11:01
sdaguebauwser: no, because we have 2 patches in the gate that are failing even with the fix applied11:02
johnthetubaguyndipanoff: http://docs.openstack.org/developer/nova/api_microversion_dev.html#f111:02
sdaguewhich means it's not a full fix11:02
bauwsersdague: https://jenkins03.openstack.org/job/gate-nova-python27/2638/console was containing Pillow==3.0.011:03
bauwser^ is the 744 job11:04
ndipanoffjohnthetubaguy, thanks - makes a lot of sense11:04
*** markvoelker has joined #openstack-nova11:05
johnthetubaguyndipanoff: in this case, I think everyone assumed 404 was one of the previous options, so its just a simple bug fix11:05
johnthetubaguyndipanoff: so yeah, I am with you on that11:06
johnthetubaguygmann: did you see your conversation there ^, does that sound correct?11:06
ndipanoffawesome11:06
*** jichen has joined #openstack-nova11:07
sdaguebauwser: yes, and what I'm saying is "THAT USED THE PATCH THAT TRIED TO PIN IT"11:07
sdaguebecause that's how zuul worked11:08
*** jichen has quit IRC11:08
*** jichen has joined #openstack-nova11:08
*** markvoelker has quit IRC11:09
johnthetubaguysdague: lets just pull the dependency for now, and work this out later11:09
johnthetubaguysdague: I guess this also hits stable11:09
*** zz_john5223 is now known as john522311:11
gmannjohnthetubaguy: hummm, so we assumed that 404 was expected code by user for this case even API never returned that.11:12
openstackgerritSean Dague proposed openstack/nova: remove sphinxcontrib-seqdiag  https://review.openstack.org/23037311:12
*** jichen has joined #openstack-nova11:12
sdaguegmann: 404 is always expected11:12
sdagueI thought we had a call out for that one11:12
sdague404 is resource not found, that's returned at higher levels all the time, and always something that needs to be expected11:13
gmannsdague: for uri non-existcase?11:13
sdaguegmann: right, exactly11:13
gmannsdague: yea, we missed that in our microversion doc :)11:14
*** ildikov has quit IRC11:14
sdagueyeh, you want to patch that?11:14
gmannsdague: yea, will put quickly11:14
bauwsersdague: okay, thanks for your explanation, I see11:14
*** salv-orlando has joined #openstack-nova11:15
sdaguebauwser: so, there could be other factors here, it's confusing at best11:15
bauwsersdague: okay, I guess your point is good, we can temporarily remove the picture in http://docs.openstack.org/developer/nova/vmstates.html until we are sure that Pillow is either capped or fixed11:16
sdaguebauwser: right11:17
sdaguealso... we should consider whether for 1 seq diagram it's worth requring a c compiler to build docs11:17
*** jichen has quit IRC11:17
sdagueor if we should just build that as an svg11:18
bauwseragreed11:18
bauwsersounds a big stuff for just an easy diagram11:18
gmannjohnthetubaguy: is it fine comment on - https://review.openstack.org/#/c/216746/9/nova/api/openstack/compute/legacy_v2/contrib/floating_ips.py11:18
sdagueit's not even a great diagram11:18
sdagueI think it was mostly jogo experimenting with some things11:19
gmannjohnthetubaguy: actually for legacy it fix only index not all method as done on v2.111:19
*** salv-orlando has quit IRC11:20
*** jichen has joined #openstack-nova11:22
*** jichen has quit IRC11:22
johnthetubaguysdague: we have some stuff passing in gate now, which is confusing, you thinking it could be cloud image specific?11:23
*** jichen has joined #openstack-nova11:23
*** nelsnelson has joined #openstack-nova11:24
openstackgerritjichenjc proposed openstack/nova-specs: Allow adjust ephemeral disks during resize  https://review.openstack.org/14573611:26
*** twinklechawla has joined #openstack-nova11:27
*** twinklechawla has left #openstack-nova11:27
johnthetubaguygmann: yeah, good spot, just changing my vote11:28
sdaguejohnthetubaguy: it might be, there are various mirrors which may or may not be up to date, and various images that might have different stuff11:28
sdagueanyway, from the big picture perspective, it sems like a lot of infrastructure, for 1 diagram11:29
*** frickler has joined #openstack-nova11:29
*** nelsnelson has quit IRC11:29
johnthetubaguysdague: yeah, I see the passing ones installed 2.9.0 and the failures were still installing 3.0.0 but I have no idea why they were different11:30
johnthetubaguywell we do have plans for more diagrams, but yes11:30
johnthetubaguygmann: I was looking at the unit tests, that appears to be covered, but missed in the code, how did that happen?11:30
openstackgerritjichenjc proposed openstack/nova: Add DiskFormat as Enum in fields  https://review.openstack.org/22985411:31
sdagueit was added here - https://github.com/openstack/nova/commit/7b352048bf4ddd5a475be8ae6542bd3b52ec1c7011:31
sdagueit used to be an image11:31
sdagueit's new enough, there is no backport needed11:32
*** john5223 is now known as zz_john522311:32
*** salv-orlando has joined #openstack-nova11:32
sdagueit's funny, my review comments were "Long term I think the sequence diagram is just too busy to be useful here."11:33
*** zz_john5223 is now known as john522311:33
sdagueI guess liberty backport11:33
sdagueif we go this route11:33
gmannjohnthetubaguy: oh yea, let me check, UT should fail11:33
johnthetubaguysdague: yeah, it seems a good option11:33
leakypipesflaper87: http://bitly.com/tc-review-dashboard <-- this link has a problem with it..11:33
sdagueleakypipes: under what browser?11:34
sdaguealso, probably a -dev not nova topic11:34
leakypipessure, sorry11:35
* johnthetubaguy runs off for some lunch11:37
*** jichen has quit IRC11:38
*** jichen has joined #openstack-nova11:38
openstackgerritDaniel Berrange proposed openstack/nova-specs: Virt image properties boot time override  https://review.openstack.org/23038211:39
*** aysyd has joined #openstack-nova11:40
*** jichen has joined #openstack-nova11:42
*** yassine_ has joined #openstack-nova11:42
openstackgerritGhanshyam Mann proposed openstack/nova: Add a note about the 500->404 not requiring a microversion  https://review.openstack.org/23038311:44
gmannsdague: johnthetubaguy : for 404 in doc -  https://review.openstack.org/23038311:44
*** lpetrut has quit IRC11:46
*** pcaruana has quit IRC11:47
openstackgerritPavel Kholkin proposed openstack/nova: Switch to oslo.cache lib  https://review.openstack.org/20304911:48
openstackgerritPavel Kholkin proposed openstack/nova: WIP: Use legacy engineFacade from oslo_db.enginefacade  https://review.openstack.org/22131011:52
openstackgerritPavel Kholkin proposed openstack/nova: WIP: use oslo_db.enginefacade  https://review.openstack.org/22506511:53
openstackgerritPavel Kholkin proposed openstack/nova: WIP: use oslo_db.enginefacade  https://review.openstack.org/22678811:53
openstackgerritPavel Kholkin proposed openstack/nova: WIP: use oslo_db.enginefacade  https://review.openstack.org/22897911:53
*** ZZelle has joined #openstack-nova11:57
*** baoli has joined #openstack-nova11:57
gmannjohnthetubaguy: got it for UT pass for legacy - https://review.openstack.org/#/c/216746/9/nova/tests/unit/api/openstack/compute/test_floating_ips.py11:59
*** baoli_ has joined #openstack-nova11:59
gmannjohnthetubaguy: actually In those test, exception.FloatingIpPoolNotFound is thrown even before going to mocked "get_floating_ip_by_address" method.12:00
gmannjohnthetubaguy: which makes those tests pass for legacy also.12:00
gmannjohnthetubaguy: just put my comment on review12:00
*** haomaiwang has quit IRC12:01
*** e0ne has joined #openstack-nova12:01
openstackgerritSergey Nikitin proposed openstack/nova: Remove get_all method from servicegroup API  https://review.openstack.org/21462912:01
*** haomaiwang has joined #openstack-nova12:01
*** zul has quit IRC12:01
openstackgerritFlavio Percoco proposed openstack/nova-specs: Complete nova support for Glance's v2  https://review.openstack.org/22989112:02
*** baoli has quit IRC12:02
*** zul has joined #openstack-nova12:04
*** lpetrut has joined #openstack-nova12:05
*** markvoelker has joined #openstack-nova12:05
*** markvoelker has quit IRC12:09
*** markvoelker has joined #openstack-nova12:09
*** haomaiwang has quit IRC12:10
*** 20WAB697A has joined #openstack-nova12:11
johnthetubaguygmann: ah, so that would do it12:11
johnthetubaguygmann: thanks for digging!12:11
gmannjohnthetubaguy: np :)12:12
*** otter768 has quit IRC12:12
*** ociuhandu has joined #openstack-nova12:13
*** otter768 has joined #openstack-nova12:14
*** exploreshaifali has quit IRC12:17
*** MarcF has quit IRC12:17
*** romainh has quit IRC12:18
*** mwagner_ has joined #openstack-nova12:19
openstackgerritPavel Kholkin proposed openstack/nova: Switch to oslo.cache lib  https://review.openstack.org/20304912:20
*** romainh has joined #openstack-nova12:20
*** MarcF has joined #openstack-nova12:21
openstackgerritClaudiu Belu proposed openstack/nova: Hyper-V: adds os-win library  https://review.openstack.org/21210212:22
*** otter768 has quit IRC12:22
*** otter768 has joined #openstack-nova12:23
*** 20WAB697A has quit IRC12:25
*** ociuhandu has quit IRC12:27
*** VW has joined #openstack-nova12:29
openstackgerritTimofey Durakov proposed openstack/nova: Wrap setup_networks_on_host with try/except  https://review.openstack.org/22789712:29
openstackgerritjichenjc proposed openstack/nova: Prevent build more than one default ephemeral disk  https://review.openstack.org/21376212:33
*** thumpba has joined #openstack-nova12:34
openstackgerritBartosz Fic proposed openstack/nova: Block migrate with attached volumes copies volumes to themselves  https://review.openstack.org/22727812:35
openstackgerritgaryk proposed openstack/nova: VMware: raise NotImplementedError for live migration methods  https://review.openstack.org/22889312:36
*** edmondsw has joined #openstack-nova12:37
*** VW has quit IRC12:40
*** VW has joined #openstack-nova12:40
*** jichen has quit IRC12:40
*** VW has quit IRC12:41
*** VW_ has joined #openstack-nova12:41
*** jichen has joined #openstack-nova12:42
*** MVenesio has joined #openstack-nova12:43
*** jichen has quit IRC12:45
*** ildikov has joined #openstack-nova12:46
*** MVenesio_ has joined #openstack-nova12:47
*** jichen has joined #openstack-nova12:48
*** thumpba_ has joined #openstack-nova12:48
*** VW_ has quit IRC12:48
*** rfolco has joined #openstack-nova12:49
*** VW has joined #openstack-nova12:49
*** jichen has quit IRC12:49
johnthetubaguysdague: I was just thinking, were those failed jobs earlier all stable branch ones?12:49
sdaguejohnthetubaguy: oh, I don't know12:49
sdaguethat's possible12:50
*** eharney has joined #openstack-nova12:50
johnthetubaguywe did just approve a bunch this morning, just dawned on me12:50
*** MVenesio has quit IRC12:50
sdagueah, ok, that might be it12:50
sdagueso, maybe the fix does work, it just needs backports12:51
sdaguethat being said, I'm still not convinced the diagram is hugely useful12:51
johnthetubaguyyeah, just backport the requirements pin (I guess that means we have not caught them all yet)12:52
bauwserso, MHO is that #1 the fix is working *but* I agree with sdague we should remove that diagram and find another solution before reproviding it12:52
*** jichen has joined #openstack-nova12:52
*** thumpba has quit IRC12:52
sdagueyep12:52
johnthetubaguyyeah, not arguing against that, its probably out of date by now anyways12:52
sdagueok, here is the backport - https://review.openstack.org/#/c/230414/12:53
*** VW has quit IRC12:53
ndipanoffdanpb, hey if you have a sec - would appreciate your comment on this: https://bugs.launchpad.net/nova/+bug/148944212:54
openstackLaunchpad bug 1489442 in OpenStack Compute (nova) "Invalid order of volumes with adding a volume in boot operation" [Undecided,New] - Assigned to Feodor Tersin (ftersin)12:54
*** MVenesio_ has quit IRC12:54
*** MVenesio has joined #openstack-nova12:55
*** karimb has quit IRC12:56
*** karimb has joined #openstack-nova12:56
*** mdrabe has joined #openstack-nova12:56
bauwserbtw. I just noticed something a bit funny12:56
*** dustins has joined #openstack-nova12:57
bauwserhttp://docs.openstack.org/developer/nova/vmstates.html vs. http://docs.openstack.org/developer/nova/devref/vmstates.html12:57
bauwserthe former is the master branch, the latter is 2015.1.112:57
bauwserthat's confusing but I don't get why we still have this12:57
bauwserand all the pages are like this12:58
bauwserlike12:58
bauwserhttp://docs.openstack.org/developer/nova/aggregates.html vs. http://docs.openstack.org/developer/nova/devref/aggregates.html12:59
*** salv-orlando has quit IRC12:59
*** dave-mccowan has joined #openstack-nova13:00
bauwserjohnthetubaguy: ^seen that ? any idea why ?13:00
bauwserIIRC, devref was the former URL, so people who bookmarked it are stuck with the Kilo version13:01
*** bmotz has left #openstack-nova13:02
*** ganeshk has joined #openstack-nova13:04
*** jichen has quit IRC13:08
*** rlrossit has joined #openstack-nova13:08
*** xyang1 has joined #openstack-nova13:10
*** pm90_ has joined #openstack-nova13:14
*** karimb has quit IRC13:15
*** raildo-afk is now known as raildo13:16
johnthetubaguybauwser: I have a feeling the defref bit just never got deleted13:16
*** ctrath has joined #openstack-nova13:16
johnthetubaguybauwser: would be good if you can try fix that with infra?13:16
bauwserjohnthetubaguy: sure, I'll discuss that with them13:16
openstackgerritgaryk proposed openstack/nova-specs: VMware: expand opaque network support  https://review.openstack.org/23042513:17
*** asettle has joined #openstack-nova13:22
*** karimb has joined #openstack-nova13:23
*** VW has joined #openstack-nova13:23
openstackgerritJohn Garbutt proposed openstack/nova: VMware: add support for provider network portgroup  https://review.openstack.org/19947713:25
*** haomaiwa_ has joined #openstack-nova13:25
*** pm90__ has joined #openstack-nova13:25
claudiubjohnthetubaguy: should we also put specs on that new mitaka priority tracking list?13:25
*** mriedem has joined #openstack-nova13:26
*** mestery_ is now known as mestery13:26
johnthetubaguyclaudiub: yes, please do, that should help them get more attention, there are two Hyper-V ones on there already13:26
*** Daisy has joined #openstack-nova13:27
*** Daisy has quit IRC13:27
claudiubjohnthetubaguy: oh, right, there are 2 lists: one for specs and one for nova commits.13:27
*** Daisy_ has joined #openstack-nova13:28
sdaguebauwser: this has happened quite often actually, because we're just doing static publish and not a real cms, so deletes are all orphaned13:28
johnthetubaguyclaudiub: the general code list has a link to the spec specific stuff13:28
*** tpeoples has joined #openstack-nova13:28
bauwsersdague: yup, I'm just asking the question to -doc13:28
*** pm90_ has quit IRC13:28
bauwsersdague: ideally we should provide a .htacces redirect IMHO13:28
bauwserto get devref pages calling ../13:28
bauwserI mean redirecting to13:29
claudiubjohnthetubaguy: yep, you're right, didn't see it. :)13:29
bauwsersdague: but that would still probably need to remove devref directory13:29
johnthetubaguyclaudiub: no worries13:30
sdagueyeh, .htaccess redirects would be good13:30
*** amotoki has joined #openstack-nova13:30
*** xnox has joined #openstack-nova13:31
*** ijuwang has joined #openstack-nova13:32
ganeshkHello, I setup controller node and compute node of contrail with devstack. Now, I am able to create instance in controller node, but, not able to create it on compute node. Can anyone understand this, Please help me with this.13:33
mriedemganeshk: see channel topic please13:35
*** Daisy_ has quit IRC13:37
*** haomaiwa_ has quit IRC13:37
*** Daisy has joined #openstack-nova13:38
ganeshkmriedem: Actually, I am using "nova boot" command to create instances. I thought, here I can get some help.13:38
*** haomaiwang has joined #openstack-nova13:38
mriedemthis is not a support channel13:38
*** obedmr has joined #openstack-nova13:39
ganeshkmriedem: Ok. Thanks for that.13:39
*** nkrinner has quit IRC13:39
*** mestery has quit IRC13:40
*** Daisy has quit IRC13:42
*** haomaiwang has quit IRC13:43
*** haomaiwang has joined #openstack-nova13:44
*** alaski is now known as lascii13:45
mriedemsdague: can you see if this is on the right track? https://review.openstack.org/#/c/230024/ - we were talking about backporting that to stable/liberty for the client13:45
sdaguemriedem: that seems fine to me13:47
mriedemcool13:47
mriedemdoffm: has a patch up for supporting 2.6 but it needed functional tests13:47
mriedemi'm not sure how easy those are going to be with the remote console API13:47
mriedemhttps://review.openstack.org/#/c/230149/13:47
sdagueit shouldn't be too bad, you don't have to test the remote console actually has things in it, you just need to make sure the API contract is working13:49
sdaguethe current bug is because a resource is 404ing13:49
mriedemyeah13:49
*** nelsnelson has joined #openstack-nova13:49
*** stevemar has joined #openstack-nova13:50
*** edleafe is now known as figleaf13:50
*** stevemar has quit IRC13:50
*** asettle has quit IRC13:51
*** asettle has joined #openstack-nova13:51
openstackgerritDaniel Berrange proposed openstack/nova-specs: Virtual instance rescue with stable disk devices  https://review.openstack.org/23044213:52
*** lykinsbd_ has quit IRC13:52
*** jwcroppe has joined #openstack-nova13:52
*** artom has joined #openstack-nova13:53
*** ganeshk has left #openstack-nova13:53
dansmithare we still not out of the woods with the requirement thing?13:53
dims__dansmith: pillow got merged to both g-r and nova requirements i believe13:54
dansmithoh, I might be looking at old results13:54
dansmithah, yep my bad13:55
*** rajesht has joined #openstack-nova13:55
*** vladikr has joined #openstack-nova13:55
*** rajesht has left #openstack-nova13:55
*** mriedem1 has joined #openstack-nova13:55
*** alejandrito has joined #openstack-nova13:55
*** mriedem has quit IRC13:55
*** asettle has quit IRC13:56
*** asettle has joined #openstack-nova13:56
*** asettle has quit IRC13:57
*** vladikr has quit IRC13:59
openstackgerritDaniel Berrange proposed openstack/nova-specs: Virtual guest device role tagging  https://review.openstack.org/19566214:00
*** jecarey has joined #openstack-nova14:00
*** mriedem1 is now known as mriedem_meeting14:00
openstackgerritZhenyu Zheng proposed openstack/nova: Add checks for volume status when rebuilding  https://review.openstack.org/21756714:00
*** haomaiwang has quit IRC14:01
*** lbeliveau has joined #openstack-nova14:01
*** stevemar has joined #openstack-nova14:02
tpeoplesLooking for reviews on https://review.openstack.org/#/c/220634/ if anyone has time; patch is small..thanks14:02
*** haomaiwa_ has joined #openstack-nova14:04
openstackgerritZhenyu Zheng proposed openstack/nova: Resize: Return to initial state instead of ACTIVE when resize fails  https://review.openstack.org/20237914:04
lbeliveautpeoples: Will have a look, please have a look at https://review.openstack.org/#/c/216049/ if you have time14:05
*** stevemar_ has joined #openstack-nova14:05
*** stevemar has quit IRC14:06
*** asettle has joined #openstack-nova14:07
lbeliveautpeoples: looks like you work on same problem, but provided a different fix14:08
*** takedakn1 has joined #openstack-nova14:08
*** takedakn has quit IRC14:09
*** takedakn1 is now known as takedakn14:09
*** asettle has quit IRC14:09
tpeopleslbeliveau: yes, similar14:09
*** burgerk has joined #openstack-nova14:10
*** rajesht has joined #openstack-nova14:11
bauwserdansmith: dims__: yup, all is okay14:11
bauwserdims__: dansmith: https://review.openstack.org/#/c/230245/1 is merged14:11
*** jasond has joined #openstack-nova14:11
bauwserdims__: dansmith: https://review.openstack.org/#/c/230132/4 is merged too14:12
dansmithbauwser: yeah, I was looking at the wrong set of results14:12
*** haomaiwa_ has quit IRC14:12
*** ociuhandu has joined #openstack-nova14:12
bauwserack14:12
bauwserso rechecks should be okay14:12
*** haomaiwa_ has joined #openstack-nova14:13
jasondis discover_extensions preferred to list_extensions in novaclient?14:13
bauwserbut we discussed with sdague about removing the unnecessary diagram which created the problem14:13
*** rajesht has quit IRC14:14
*** thumpba_ has quit IRC14:14
*** dims__ has quit IRC14:14
*** dims__ has joined #openstack-nova14:15
lbeliveautpeoples: no offense, but next time please do a quick search in the bugs db to make sure if somebody haven't reported the problem before14:16
tpeopleslbeliveau: your bug report has no mention of what mine does, i did search specifically for the pci_device_pools field since that is what i am concerned with14:18
*** kairo has joined #openstack-nova14:18
*** bswartz has quit IRC14:18
*** erhudy has joined #openstack-nova14:19
*** su_zhang_ has joined #openstack-nova14:24
tpeopleslbeliveau: fwiw, lgtm.  your change gets me what i need too14:25
jrollhey friends, I have a fun liberty upgrade bug: https://bugs.launchpad.net/nova/+bug/150217714:25
openstackLaunchpad bug 1502177 in OpenStack Compute (nova) "Existing Ironic instances report negative available RAM for the node after upgrade " [Undecided,New]14:25
jrolljohnthetubaguy: ^14:26
jrollprobably going to want to backport that, it can make an upgrade go real bad like14:26
*** takedakn has quit IRC14:26
* jroll hacks on a patch14:27
sdaguebauwser: ok, the stable/liberty backport bounced off requirements not being set yet, that's approved nwo14:27
*** thangp has joined #openstack-nova14:28
lbeliveautpeoples: thanks, reviewed yours as well14:28
*** tonytan4ever has joined #openstack-nova14:28
johnthetubaguyjroll: OK, added the kilo-rc-potential tag, we have just opened RC2, thats likely to close on Tuesday, if that helps with timeframes14:28
*** exploreshaifali has joined #openstack-nova14:29
jrolljohnthetubaguy: liberty-rc-potential? :)14:29
*** mgoddard_ has joined #openstack-nova14:29
jrollI have a fix, it's the unit tests that will be a pain, going to try to get that up today14:29
johnthetubaguyjroll: lol, yeah14:30
*** mestery has joined #openstack-nova14:30
* johnthetubaguy hides secret time machine14:31
*** haomaiwa_ has quit IRC14:33
*** mgoddard has quit IRC14:33
*** rotbeard has quit IRC14:33
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/23046714:34
*** electrocucaracha has joined #openstack-nova14:35
*** haomaiwang has joined #openstack-nova14:35
*** yamahata has joined #openstack-nova14:36
*** bswartz has joined #openstack-nova14:36
*** electrocucaracha has quit IRC14:37
lasciimriedem_meeting: for those security group tests with cells, they work because they don't attempt to use the security group for an instance.14:39
*** haomaiwang has quit IRC14:40
lasciithe groups can be created/listed/deleted but it will only affect the top level cell.  the failures happen when they can't be joined on the instance object within a child cell14:40
lasciisince they're not synced down14:40
*** electrocucaracha has joined #openstack-nova14:40
*** signed8bit has joined #openstack-nova14:42
*** tsekiyama has joined #openstack-nova14:43
*** stevemar_ is now known as stevemar14:43
dansmithoh my manners14:44
*** dansmith is now known as superdan14:44
*** karimb has quit IRC14:47
dims__sdague: superdan: picked a random tox functional run and seems like it's not running anything - http://logs.openstack.org/01/208401/6/check/gate-nova-tox-functional/bd61b9f/console.html14:50
superdanoh my14:50
bauwserthe "finished: SUCCESS" is pure awesomeness14:52
johnthetubaguy:(14:52
johnthetubaguyI thought we had a test to make sure we always run more than one test, maybe thats only for the unit tests?14:53
*** achanda has joined #openstack-nova14:53
superdanwe did, yeah14:53
*** ociuhandu has quit IRC14:53
*** pixelbeat has quit IRC14:54
*** russellb is now known as rustlebee14:55
sdaguemtreinish: ?14:55
*** pixelbeat has joined #openstack-nova14:55
sdaguemy guess, os-testr broke something14:55
mtreinishsdague: that's baked into subunit-trace so it should be for anything using pretty-tox or ostestr14:56
dims__sdague: superdan: jjb bug per infra - gate-requirements-tox-validate was also not running anything14:56
sdagueoh, it's a jjb bug14:56
dims__y14:56
sdagueok14:56
*** mtanino has joined #openstack-nova14:57
mtreinishsdague: heh, you had me worried I pushed an os-testr release yesterday14:57
mtreinishthat changed subunit-trace14:57
*** exploreshaifali has quit IRC14:58
*** mgoddard_ has quit IRC14:58
*** mgoddard has joined #openstack-nova14:58
*** gszasz has quit IRC14:58
*** mriedem_meeting is now known as mriedem14:59
dims__mtreinish: :)14:59
mriedemlascii: ok14:59
*** ccarmack has joined #openstack-nova14:59
mtreinishdims__: well, we didn't add any tests for that 1 liner so you never know14:59
*** jasond has left #openstack-nova14:59
mriedemlascii: i -1ed the tempest change since the compute api security group tests needed to be skipped if we have compute-feature-enabled.security_groups=False15:00
*** zzzeek has joined #openstack-nova15:00
*** yamahata has quit IRC15:00
*** yamahata has joined #openstack-nova15:00
*** achanda has quit IRC15:01
*** ociuhandu has joined #openstack-nova15:01
lasciiyep15:01
*** andrewbogott has joined #openstack-nova15:02
*** browne has joined #openstack-nova15:02
*** Marga_ has joined #openstack-nova15:02
*** ansiwen has quit IRC15:03
*** Marga_ has quit IRC15:03
*** takedakn has joined #openstack-nova15:04
*** Marga_ has joined #openstack-nova15:04
openstackgerritDaniel Berrange proposed openstack/nova-specs: Libvirt real time instances  https://review.openstack.org/13968815:05
danpbjohnthetubaguy: the only change in that real-time spec is to fix the URL, so can you +2 it again :-)15:05
*** lpetrut has quit IRC15:06
*** pm90__ has quit IRC15:07
*** Daisy has joined #openstack-nova15:08
mriedembaoli_: can you take a look at this? https://review.openstack.org/#/c/227160/15:08
*** SourabhP has joined #openstack-nova15:09
baoli_mriedem: sure15:09
*** kairo has quit IRC15:09
johnthetubaguydanpb: ah, sweet, re-applied15:09
*** SourabhP_ has joined #openstack-nova15:10
*** electrocucaracha has quit IRC15:10
openstackgerritJim Rollenhagen proposed openstack/nova: Ironic: Fix bad capacity reporting if instance_info is unset  https://review.openstack.org/23048715:10
danpbguess we'll need to have blitz on reviewing specs before the summit arrives15:10
*** rdopiera has quit IRC15:10
*** artom has quit IRC15:11
bauwserjroll: just saw your ^15:11
jrollbauwser: yeah, still need to drop the fix in15:12
jrolltis a fun one though15:12
jrollbauwser: since I forgot it in commit message https://bugs.launchpad.net/nova/+bug/150217715:12
openstackLaunchpad bug 1502177 in OpenStack Compute (nova) "Existing Ironic instances report negative available RAM for the node after upgrade " [Undecided,New]15:12
*** matrohon has quit IRC15:12
*** Daisy has quit IRC15:12
bauwserjroll: yeah, looking at the impact15:13
jrollbauwser: well, it managed to make for a very long night last night when we deployed it :)15:13
*** lpetrut has joined #openstack-nova15:13
*** SourabhP has quit IRC15:13
bauwserheh15:13
*** lsmola has quit IRC15:14
*** rook has quit IRC15:15
*** rook has joined #openstack-nova15:16
*** SourabhP_ has quit IRC15:17
*** rook has quit IRC15:17
*** rook has joined #openstack-nova15:18
*** obedmr has quit IRC15:19
openstackgerritJim Rollenhagen proposed openstack/nova: Ironic: Fix bad capacity reporting if instance_info is unset  https://review.openstack.org/23048715:20
*** davideagnello has joined #openstack-nova15:20
jrollbauwser: ^ with fix15:20
* jroll running tests locally and such15:21
bauwserjroll: I have an internal bug which is quite related, I need to understand more the previous fix in https://bugs.launchpad.net/ironic/+bug/130127915:21
openstackLaunchpad bug 1301279 in OpenStack Compute (nova) "Changing node's properties in Ironic after node is deployed will count as available resources in Nova" [Medium,Fix released] - Assigned to Zhenguo Niu (niu-zglinux)15:21
*** obedmr_ has joined #openstack-nova15:22
bauwserjroll: what do mean Ironic properties ?15:22
jrollbauwser: so a node object in ironic has node.properties[memory_mb], etc, in the DB15:22
jrollthat's what the RT reads for resources15:22
bauwserjroll: that's what I understand15:22
bauwserjroll: is it set by the operator ?15:22
jrollyes15:23
bauwserjroll: okay, is it modified later ? the bug reports it's possible15:23
jrollthat previous bug fixes a case where, you deploy an instance. while the instance is deployed, you change memory_mb in ironic. now nova says that node has some free RAM15:23
jrollright, so I don't understand at all why an operator would modify it later, but apparently someone did and ran into this bug15:23
*** obedmr_ has quit IRC15:23
jrollseems silly to me15:23
*** alexschm has quit IRC15:24
jrollbut in a pet environment, someone might ask to upgrade RAM on an existing deployed box15:24
jrollthe most manual of resizes :D15:24
*** romainh has quit IRC15:24
*** takedakn has quit IRC15:24
*** SourabhP has joined #openstack-nova15:25
jrollbauwser: I'm really sad this bit me, because I pointed it out on the review, but I trusted people instead of testing myself :(15:25
*** ctrath1 has joined #openstack-nova15:25
bauwserjroll: okay I see15:26
*** hemnafk is now known as hemna15:27
*** pm90_ has joined #openstack-nova15:28
*** ctrath has quit IRC15:28
mriedemgah15:28
mriedemis there a change up for that Pillow thing?15:28
*** pm90__ has joined #openstack-nova15:29
dims__mriedem: g-r master + liberty yes, nova master yes15:29
mriedemis the nova master change merged?15:29
mriedemwhat requires Pillow anyway?15:30
*** jdurgin1 has joined #openstack-nova15:30
jrollmriedem: sphinxcontrib-seqdiag15:31
mriedemhells bells15:31
jrolland yeah, master is merged15:31
*** pm90_ has quit IRC15:32
bauwserjroll: tbc, there can be only one instance per ironic node, right ? the winner takes all ?15:32
jrollbauwser: correct15:33
mriedemwe should move the deps from test-requirements that are needed to build nova docs and slap those into setup.cfg with an [extras] thing15:33
mriedemso that docs dependencies don't break unit test runs15:33
bauwsermriedem: see Vek comment on the ML15:33
danpbmriedem: sdague suggested on the list its better if we just kill off use of pillow entirely15:34
mriedemsure, but, still15:34
mriedemwe could do both15:34
bauwserand I agree with sdague, until we find a better solution15:34
*** lpetrut has quit IRC15:36
openstackgerritDan Smith proposed openstack/nova-specs: Stay consistent with the word "flavor"  https://review.openstack.org/23049815:36
openstackgerritDan Smith proposed openstack/nova-specs: Fix misspellings of "scheduler"  https://review.openstack.org/23049915:36
danpbsuperdan: lol, thanks for fixing my engrish :-)15:37
superdandanpb: :)15:37
mriedemdid you check for colour?15:37
mriedemor 'shedular' (more the pronunciation than the spelling)15:38
danpbwho wants to write a unit test to check spelling :-)15:38
*** thumpba has joined #openstack-nova15:38
*** thumpba has quit IRC15:38
mriedemomg i made that joke before seeing https://review.openstack.org/#/c/230499/15:38
*** scheuran has quit IRC15:39
*** thumpba has joined #openstack-nova15:39
superdanmriedem: I did, no colours :)15:40
superdanmriedem: re your comment, at least I'm taking responsibility for my OCD15:41
mriedemheh15:41
mriedemunclean, UNCLEAN!15:42
mriedemit's fine. my 4 year old daughter aligns her placemats at right angles already. i'm pretty sure she got that from me.15:42
*** MarcF has quit IRC15:42
*** alex_klimov has quit IRC15:44
openstackgerritDan Smith proposed openstack/nova-specs: Fix misspellings of "scheduler"  https://review.openstack.org/23049915:44
openstackgerritDan Smith proposed openstack/nova-specs: Stay consistent with the word "flavor"  https://review.openstack.org/23049815:44
claudiubjohnthetubaguy: still around?15:45
*** mgoddard_ has joined #openstack-nova15:45
*** VW has quit IRC15:45
*** VW has joined #openstack-nova15:46
*** obedmr has joined #openstack-nova15:47
*** jlanoux has quit IRC15:47
*** electrocucaracha has joined #openstack-nova15:47
*** PaulMurray is now known as ptm_away15:47
*** ptm_away has quit IRC15:48
*** mgoddard has quit IRC15:48
*** VW has quit IRC15:50
*** VW has joined #openstack-nova15:50
*** tsekiyama has quit IRC15:50
*** lpetrut has joined #openstack-nova15:51
*** SourabhP has quit IRC15:52
*** amotoki has quit IRC15:56
*** jecarey has quit IRC15:56
*** mgoddard_ has quit IRC15:58
*** mgoddard has joined #openstack-nova15:58
*** su_zhang_ has quit IRC15:58
*** ijw has joined #openstack-nova15:59
*** sajeesh has joined #openstack-nova16:01
superdanccarmack: 150155816:04
superdanoops16:04
superdanccarmack: https://review.openstack.org/#/c/23022716:04
ccarmackthanks...looking16:04
*** jogo is now known as flashgordon16:05
johnthetubaguyclaudiub: hey, sorry, was in a call about defcore fun, can I help?16:06
openstackgerritJim Rollenhagen proposed openstack/nova: Ironic: Fix bad capacity reporting if instance_info is unset  https://review.openstack.org/23048716:06
*** artom has joined #openstack-nova16:07
*** artom has quit IRC16:07
*** artom has joined #openstack-nova16:07
*** lpetrut has quit IRC16:08
*** lpetrut has joined #openstack-nova16:08
*** jdurgin1 has quit IRC16:09
*** haypo has left #openstack-nova16:09
*** salv-orlando has joined #openstack-nova16:11
ccarmacksuperdan: I just had one nitty comment16:12
*** eglynn has quit IRC16:13
superdanccarmack: well, I see your point, but I was going for what is there16:13
superdanif you expand it,16:13
superdanyour way would be like this:16:13
superdanThis service version v2 is older than the minimum version (v3) of the rest of the deployment16:13
*** artom has quit IRC16:13
superdanI was trying to avoid the "version vX" alliteration,16:14
superdanalthough I see it's there for the minimum one16:14
superdanso maybe I'll just leave the version word in both places and remove the 'v' prefix to X16:14
ccarmacksuperdan:  I'm a grammar guy, but v2 isn't a service, its a version16:14
*** apoorvad has joined #openstack-nova16:14
ccarmackI'm *not16:14
*** artom has joined #openstack-nova16:15
superdanright, but if you remove the parenthetical it reads "this service is older..."16:15
superdanbut yeah I see what you mean16:15
superdanhang on let me try something16:15
ccarmackyea, remove the 'v' prefix16:15
superdanwell, or this:16:16
superdan"This service is older (v2) than the minimum (v3) version of the rest of the deployment"16:16
*** karimb has joined #openstack-nova16:16
ccarmackthat looks good also16:16
superdanremoving the v would work too, but I worry about people not realizing that the numbers are the versions16:16
ccarmackI like that16:16
superdanokay, let's go with that16:16
ccarmackok16:17
bauwsersdague: meh https://review.openstack.org/#/c/230414/16:17
*** ssurana has joined #openstack-nova16:17
*** SourabhP has joined #openstack-nova16:17
bauwsersdague: g-r is not updated with the Pillow cap, right?16:18
openstackgerritDan Smith proposed openstack/nova: Extend the ServiceTooOld exception with more data  https://review.openstack.org/23022716:18
superdanccarmack: ^16:18
*** vishwanathj has joined #openstack-nova16:18
ccarmacksuperdan: +1'd it16:19
superdanccarmack: thanks :)16:19
ccarmackyup16:20
*** emagana has joined #openstack-nova16:22
*** nic has joined #openstack-nova16:22
*** tonytan4ever has quit IRC16:22
*** ZZelle has quit IRC16:23
*** mudassirlatif has joined #openstack-nova16:23
*** salv-orlando has quit IRC16:24
*** emagana_ has joined #openstack-nova16:25
*** tjones has joined #openstack-nova16:25
*** tonytan4ever has joined #openstack-nova16:26
*** emagana has quit IRC16:27
*** SourabhP_ has joined #openstack-nova16:27
*** unicell1 has joined #openstack-nova16:28
*** SourabhP has quit IRC16:28
*** Daisy has joined #openstack-nova16:29
*** unicell has quit IRC16:29
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/23046716:29
*** e0ne has quit IRC16:31
sdaguebauwser: we just approved it16:31
bauwsersdague: ack16:31
claudiubjohnthetubaguy: sorry, didn't see your reply.16:31
johnthetubaguyclaudiub: no problems16:31
claudiubjohnthetubaguy: so, we have an interesting... problem...16:31
bauwsersdague: my ping was just for helping you in case you forgot to provide the patch to g-r :)16:32
sdaguebauwser: so it should work if you recheck it now16:32
*** diogogmt has joined #openstack-nova16:32
bauwsersdague: cool, doing it16:32
*** SourabhP_ has quit IRC16:32
claudiubjohnthetubaguy: so, there is a scenario where spawning isntances on a host will fail, even though the scheduler says it's a good node for that instance16:32
johnthetubaguyclaudiub: yes, seen that with XenServer too actually16:33
sdaguebauwser: yeh, merged - https://review.openstack.org/#/c/230228/ 17 minutes ago16:33
claudiubjohnthetubaguy: so, Hyper-V creates a memory file on the local disk, for each instance, and it has the size of the allocated memory16:33
johnthetubaguyclaudiub: oh, is that for suspend or something?16:33
claudiubjohnthetubaguy: so, spawning instances with large disks, plus large-ish memory, will end up with not having enough local disk16:34
johnthetubaguyclaudiub: ah, gotcha16:34
johnthetubaguyclaudiub: I think you might need to implement this virt driver method: https://github.com/openstack/nova/blob/master/nova/virt/xenapi/driver.py#L15716:35
johnthetubaguyclaudiub: although, that doesn't actually help the scheduler right now16:35
johnthetubaguyclaudiub: but it should fix the resource tracker16:35
claudiubjohnthetubaguy: I was thinking, maybe hyper-v is not the only one that does this kind of thing. i think vmware also does this. can we maybe add a config option, like: driver_creates_vm_mem_file or something more catchy, and use that in the resource tracker?16:37
claudiubjohnthetubaguy: to update the used local disk to be instance's disk size + instance memory size16:37
claudiubjohnthetubaguy: + ephemeral16:37
johnthetubaguyclaudiub: can't you just do something similar to that above method? https://github.com/openstack/nova/blob/master/nova/virt/xenapi/driver.py#L15716:37
johnthetubaguyclaudiub: just its for disk and not memory, in your case16:38
claudiubjohnthetubaguy: it seems that method :returns: memory overhead16:39
*** ociuhandu has quit IRC16:39
claudiubjohnthetubaguy: yeah, we're interested in the disk part.16:39
johnthetubaguyclaudiub: yeah, just return the disk part16:39
*** ansiwen has joined #openstack-nova16:39
claudiubjohnthetubaguy: ok, will have to see how is that being used and if it helps solve the issue. Thanks. :D16:39
*** karmatronic has joined #openstack-nova16:39
*** karmatronic has quit IRC16:39
*** karmatronic has joined #openstack-nova16:39
johnthetubaguyclaudiub: we added that for memory overhead in Xen, its more critical for us because we don't use any memory overcommit or page sharing16:40
johnthetubaguyclaudiub: just for context16:40
*** kairo has joined #openstack-nova16:40
johnthetubaguyclaudiub: I suspect it needs a tweak, but it seems very close: https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L17216:40
johnthetubaguyclaudiub: https://github.com/openstack/nova/blob/master/nova/compute/claims.py#L9816:41
*** penick has joined #openstack-nova16:41
claudiubjohnthetubaguy: yeah, I think that might work. I'll create a bug report for this and upload a commit for it. Thanks for the help. :)16:41
johnthetubaguyclaudiub: no worries16:41
johnthetubaguyclaudiub: so there is a follow on bit, where you might need the scheduler to do a better estimation, but the retry loops and things should mean thats enough most of the time, I think16:43
*** kairo_ has joined #openstack-nova16:45
*** vilobhmm11 has joined #openstack-nova16:45
*** kairo has quit IRC16:45
bauwsera possible regression found https://bugs.launchpad.net/nova/+bug/150191416:45
openstackLaunchpad bug 1501914 in OpenStack Compute (nova) "Liberty devstack failed to launch instance w/ NetApp eSeries." [Undecided,New]16:45
bauwsermriedem: ^ do you think it could be related with os-brick ?16:46
*** kairo_ has quit IRC16:48
*** diogogmt_ has joined #openstack-nova16:48
*** dims__ is now known as dimsum__16:49
bauwserI'm not a bdm expert and I need to go, if any people could just check it's not a regression... :)16:49
*** diogogmt has quit IRC16:50
bauwsermriedem: nevermind the os-brick question, it was silly16:51
*** diogogmt_ has quit IRC16:53
*** yamahata has quit IRC16:53
*** tonytan4ever has quit IRC16:53
bauwserndipanoff: not sure you saw the above ^16:54
*** kairo has joined #openstack-nova16:55
johnthetubaguybauwser: that sounds a bit like the client issue again16:55
*** davideagnello has quit IRC16:56
*** apuimedo has quit IRC16:56
*** amotoki has joined #openstack-nova16:56
*** john5223 is now known as zz_john522316:57
bauwserjohnthetubaguy: I'm definitely not a good person for a volume problem, hence me passing :)16:59
bauwserjohnthetubaguy: but it sounds a regression, as the reporter verified16:59
johnthetubaguybauwser: so I took a quick peak, it looks like cinder failed to create the volume, so it seems like it could be an non-nova issue16:59
*** Marga_ has quit IRC16:59
bauwserjohnthetubaguy: that was one of my thoughts, could you move the project?17:00
*** diogogmt has joined #openstack-nova17:00
johnthetubaguybauwser: I just marked it as incomplete for now, till thats confirmed17:00
bauwserjohnthetubaguy: ack, thanks17:00
johnthetubaguyits possible we send the wrong request, I guess17:00
bauwserjohnthetubaguy: oh ok, so we're polling the state in Cinder17:01
bauwserjohnthetubaguy: I thought it was a nova check17:01
bauwserjohnthetubaguy: or is it a callback ?17:01
bauwserjust for my knowledge17:01
*** harlowja has joined #openstack-nova17:01
johnthetubaguyI think thats the bit where we are creating a volume in cinder, and polling to see if its completed17:01
*** davideagnello has joined #openstack-nova17:01
bauwserokay17:01
*** amotoki has quit IRC17:01
bauwseranyway, need to silently walk away from keyboard17:02
bauwserweekend, folks17:02
*** electrocucaracha has quit IRC17:02
*** yassine_ has quit IRC17:03
*** tonytan4ever has joined #openstack-nova17:03
*** tjones has left #openstack-nova17:04
openstackgerritChuck Carmack proposed openstack/nova: Make the server group invalid format message more verbose  https://review.openstack.org/21846817:04
*** danpb has quit IRC17:04
*** signed8bit has quit IRC17:05
*** vilobhmm11 has quit IRC17:05
*** electrocucaracha has joined #openstack-nova17:07
*** lpetrut has quit IRC17:08
*** signed8bit has joined #openstack-nova17:08
*** tpeoples has quit IRC17:09
*** jistr has quit IRC17:10
*** READ10 has joined #openstack-nova17:13
*** ociuhandu has joined #openstack-nova17:14
*** achanda has joined #openstack-nova17:16
*** su_zhang_ has joined #openstack-nova17:17
johnthetubaguybauwser: have a good one, I should do the same now17:18
*** derekh has quit IRC17:18
*** yamahata has joined #openstack-nova17:18
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/23046717:19
*** ctrath has joined #openstack-nova17:19
*** ctrath1 has quit IRC17:19
*** Daisy has quit IRC17:20
openstackgerritOpenStack Proposal Bot proposed openstack/python-novaclient: Updated from global requirements  https://review.openstack.org/23058317:20
*** vishwanathj is now known as vishwanathj_17:20
*** Daisy has joined #openstack-nova17:21
*** ociuhandu has quit IRC17:22
*** nelsnelson has quit IRC17:25
openstackgerritChuck Carmack proposed openstack/nova: XMake the server group invalid format message more verbose  https://review.openstack.org/21846817:25
*** Daisy has quit IRC17:26
openstackgerritOpenStack Proposal Bot proposed openstack/nova: Updated from global requirements  https://review.openstack.org/23046717:26
*** vishwanathj_ is now known as vishwanathj17:27
*** mriedem has quit IRC17:28
*** aysyd has quit IRC17:29
*** aysyd has joined #openstack-nova17:29
*** ildikov has quit IRC17:31
*** mdrabe has quit IRC17:31
*** mriedem has joined #openstack-nova17:32
*** SourabhP has joined #openstack-nova17:33
*** SourabhP has quit IRC17:34
*** SourabhP has joined #openstack-nova17:35
*** Marga_ has joined #openstack-nova17:36
*** lhcheng has joined #openstack-nova17:36
lhchenghello, what's the difference between discover_extension and list_extensions in novaclient?17:37
*** ChanServ has quit IRC17:37
*** ijw has quit IRC17:38
*** SourabhP_ has joined #openstack-nova17:38
*** SourabhP has quit IRC17:39
*** SourabhP_ is now known as SourabhP17:39
superdanjohnthetubaguy: still around?17:40
*** ChanServ has joined #openstack-nova17:40
*** cameron.freenode.net sets mode: +o ChanServ17:40
*** browne has quit IRC17:42
*** browne has joined #openstack-nova17:42
mriedemsdague: so we want to bring https://review.openstack.org/#/c/230024/ back to stable/liberty and release as 2.30.2 right?17:43
*** vilobhmm11 has joined #openstack-nova17:44
*** vilobhmm111 has joined #openstack-nova17:46
*** anish__ is now known as anish17:47
*** SourabhP has quit IRC17:47
*** burt has quit IRC17:49
*** vilobhmm11 has quit IRC17:49
*** burt has joined #openstack-nova17:49
*** SourabhP has joined #openstack-nova17:51
ccarmackmriedem: I replied to your comments on https://review.openstack.org/#/c/225199/ - FYI17:51
*** burt has quit IRC17:52
*** burt has joined #openstack-nova17:53
*** rlrossit has quit IRC17:53
*** SourabhP_ has joined #openstack-nova17:53
*** mgoddard has quit IRC17:54
*** SourabhP has quit IRC17:55
*** SourabhP_ is now known as SourabhP17:55
*** rlrossit has joined #openstack-nova17:55
*** SourabhP has quit IRC17:59
*** nelsnelson has joined #openstack-nova18:00
*** SourabhP has joined #openstack-nova18:00
*** e0ne has joined #openstack-nova18:01
*** unicell1 has quit IRC18:01
*** burt has quit IRC18:02
*** burt has joined #openstack-nova18:03
*** burt has quit IRC18:03
*** yamahata has quit IRC18:03
*** burt has joined #openstack-nova18:04
*** claudiub has quit IRC18:04
*** emagana_ has quit IRC18:06
*** ociuhandu has joined #openstack-nova18:07
*** ZZelle has joined #openstack-nova18:07
mriedemcompute API goes directly to nova-compute somewhere? http://docs.openstack.org/developer/nova/architecture.html18:14
mriedemwhere does that happen, beyond maybe the weird code to find a bdm device name?18:15
lasciimriedem: a few things like stop/start18:15
mriedemyou mean like self.compute_rpcapi.start_instance(context, instance) right?18:16
lasciiyeah18:16
mriedemok forget i asked that18:18
*** SourabhP_ has joined #openstack-nova18:19
*** SourabhP has quit IRC18:19
*** SourabhP_ is now known as SourabhP18:20
mgagneis there a way to override the instance userdata when rebuilding an instance? (not injected_files, the actual userdata)18:20
*** artom has quit IRC18:21
*** andrearosa has quit IRC18:21
*** devananda is now known as deva_brb18:22
openstackgerritChuck Carmack proposed openstack/nova: Make the server group invalid format message more verbose  https://review.openstack.org/21846818:23
openstackgerritAndrew Laski proposed openstack/python-novaclient: Test that microversions are not skipped  https://review.openstack.org/23060318:25
lasciimriedem: sdague ^18:25
openstackgerritJim Rollenhagen proposed openstack/nova: Ironic: Fix bad capacity reporting if instance_info is unset  https://review.openstack.org/23048718:25
*** vladikr has joined #openstack-nova18:25
jroll^ now with passing tests18:25
*** devananda has joined #openstack-nova18:25
*** ildikov has joined #openstack-nova18:26
superdanjroll: so I guess I'm confused.. what changed across the upgrade boundary?18:28
mriedemlascii: fancy18:28
jrollsuperdan: existing instances before applying the commit in the bug, don't have instance_info[stuff] set18:28
*** e0ne has quit IRC18:28
jrollsuperdan: the patcher.py changes in that commit caused nova to set that data18:29
openstackgerritAndrew Laski proposed openstack/python-novaclient: Test that microversions are not skipped  https://review.openstack.org/23060318:29
lasciimriedem: fixed a spelling mistake18:29
*** SourabhP has quit IRC18:29
*** thangp has quit IRC18:29
superdanjroll: so you guys don't have a grenade job I guess?18:30
*** unicell has joined #openstack-nova18:30
superdanbecause even simple case grenade catches this kind of stuff18:30
*** Marga_ has quit IRC18:30
lasciiwe do, we just call it production18:30
*** SourabhP has joined #openstack-nova18:30
superdanlascii: I meant the ironic project18:30
lasciigotcha18:31
*** salv-orlando has joined #openstack-nova18:31
jrollheh18:31
jrollwhat lascii said18:32
*** electroc_ has joined #openstack-nova18:32
jrollsuperdan: but, no, we have an experimental grenade job, it's on my priority list to get that up and running18:32
lasciisuperdan: I think this would only be caught if enough capacity had been used before the upgrade18:32
jrollsuperdan: I think that's upgrade ironic though? or maybe upgrade both? I can't remember18:32
jrolllascii: and the right cells/scheduler filters18:33
superdanlascii: sounds like it would just be triggered if there were any instances in the db before the upgrade, which grenade does do18:33
jrollwell18:33
lasciitriggered, but not cause a noticeable issue18:33
jrollthose would report negative resources18:33
jrollbut we probably wouldn't see it18:33
jrollidk if tempest jobs test that the correct amount of resources are exposed as available18:34
superdanjroll: they probably can't easily because of parallel jobs18:34
superdanbut still18:34
*** SourabhP_ has joined #openstack-nova18:34
superdanwe'd see the "malformed" log message at least right?18:34
jrollsuperdan: yeah, I would like to think I would have checked logs, but I'm not sure18:34
*** electrocucaracha has quit IRC18:34
*** SourabhP has quit IRC18:35
*** SourabhP_ is now known as SourabhP18:35
jrollnah, it does a .get(key, 0)18:35
jrollthe warning is only if it isn't an int18:35
superdanyeah18:35
superdanwell, I'm just saying we should try to do better going forward18:35
jrolltotally18:35
superdanso,18:36
jrollI actually raised the question on the review, but trusted people that said it'd be fine18:36
superdangrenade has several phases for checking this stuff18:36
superdanbefore tempest runs on the new side for example18:36
superdanwhich is specifically aimed at checking things like this we know could be out of whack18:36
superdanso if we had such a job, I'd be saying we need a check in there18:36
*** su_zhang_ has quit IRC18:36
jrollI agree18:36
jrolllike I said, this is on my priority list18:37
jrollmy priority list for testing things: full tempest, grenade, functional stuffs18:37
superdansure, I'm not faulting you18:37
*** su_zhang_ has joined #openstack-nova18:37
superdanI just don't like messing up upgrades is all18:37
jrolloh I know18:37
jrollditto18:37
jrollI was one of the people debugging this at 10pm last night18:38
jrollI do care about upgrades :)18:38
superdanyeah I know your paycheck actually depends on not screwing this up at a very direct level :)18:39
jrolllol18:39
*** SourabhP has quit IRC18:39
*** SourabhP has joined #openstack-nova18:42
*** su_zhang_ has quit IRC18:43
*** su_zhang_ has joined #openstack-nova18:44
*** eglynn has joined #openstack-nova18:45
lhchenghello, anyone around to help with  novaclient question? :) trying to figure out what's the difference between discover_extension and list_extensions methods?18:45
superdanjroll: I'm missing why you test the instance_info and props for the cpus or vcpus18:46
superdanjroll: they're just static data from the top of that test file right?18:47
*** salv-orlando has quit IRC18:47
*** jichen has joined #openstack-nova18:47
*** jichen has quit IRC18:47
jrollsuperdan: not sure what your question is?18:48
*** e0ne has joined #openstack-nova18:48
jrollsuperdan: I'm making sure that parse_instance_info returns the right thing based on if instance_info is present or not18:48
*** ijw has joined #openstack-nova18:48
superdanyou mean _parse_node_instance_info() ?18:49
*** jichen has joined #openstack-nova18:49
jrollyeah18:49
mriedemccarmack: (9:39:37 AM) lascii: mriedem_meeting: for those security group tests with cells, they work because they don't attempt to use the security group for an instance.18:49
*** jichen has quit IRC18:49
superdanoh, I see, get_test_node() is creating a node thing from that data18:49
mriedem(9:40:14 AM) lascii: the groups can be created/listed/deleted but it will only affect the top level cell.  the failures happen when they can't be joined on the instance object within a child cell18:50
mriedem(9:40:21 AM) lascii: since they're not synced down18:50
*** jichen has joined #openstack-nova18:50
ccarmackmriedem: doesn't devstack have a child cell?18:51
superdanjroll: I think it would have been clearer to me if you had made the if on 276 just fetch the right cpus value and then compare expected_cpus, result['vcpus']18:51
superdanjroll: but that's fine18:51
ccarmackmriedem, Iascii: I guess I would have expected it to fail in devstack on the child cell18:52
jrollsuperdan: good point, mind leaving a comment and I'll grab it if I spin another?18:53
jrollor I can even just do it now18:53
superdanjroll: okay18:53
lasciiccarmack: there is a child cell for the cells job18:53
*** lbeliveau has quit IRC18:53
lasciiccarmack: but it never comes into play when the compute/api method just does a db read/update18:53
*** SourabhP has quit IRC18:55
*** jichen has joined #openstack-nova18:55
*** cfriesen has joined #openstack-nova18:56
*** SourabhP has joined #openstack-nova18:56
dimsum__lascii: mriedem: since it's late on friday, here's a review request with no code changes :) can one of you please take a peek? https://review.openstack.org/#/c/229069/18:57
openstackgerritJim Rollenhagen proposed openstack/nova: Ironic: Fix bad capacity reporting if instance_info is unset  https://review.openstack.org/23048718:57
*** ansiwen has quit IRC18:57
jrollsuperdan: ^ thanks for review18:57
openstackgerritAnne Gentle proposed openstack/nova: docs: re-organise the API concept docs  https://review.openstack.org/22625318:57
openstackgerritAnne Gentle proposed openstack/nova: Rearranges to create new Compute API Guide  https://review.openstack.org/23018618:57
lasciidimsum__: yep, I was already +2 on that one18:57
mriedemccarmack: the cells compute API extends the normal nova.compute.API: https://github.com/openstack/nova/blob/master/nova/compute/cells_api.py#L16218:57
mriedemand in the normal nova compute API, it just talks directly to the DB to the security group CRUD operatoins18:58
ccarmackIascii, mriedem:  I'm a little slow here, you said it would on the child cell when attempting to join the security group into the instance18:58
superdanjroll: ah, I was also not really processing that the props change for the other keys were needed,18:58
superdanjroll: too focused on the cpus/vcpus disparity I guess18:58
ccarmackmriedem: yes, I saw alaski 's comment18:58
mriedemccarmack: i think that means when it goes to the child cell to talk to nova-compute to refresh firewall rules for the security group18:58
lasciiccarmack: on another operation, like boot, there would be a failure when a db lookup happened in the child cell18:59
superdanlascii: I permit you to +W jroll's patch18:59
openstackgerritAnne Gentle proposed openstack/nova: Rearranges to create new Compute API Guide  https://review.openstack.org/23018618:59
jroll"permit" heh18:59
ccarmackIascii: ok, got it... it does seem better to fail earlier on addSecurityGroup rather than later with a db error on boot ??19:00
lasciisuperdan: heh.  Should I have knelt for that?19:00
*** bswartz has quit IRC19:00
*** ansiwen has joined #openstack-nova19:00
lasciikneeled?  whatever19:00
superdanlascii: if it makes you more comfortable, I'm fine with it19:00
ccarmackIascii:  is the security group limitation for cells a permanent thing, or just in v1?19:02
lasciijust v119:02
ccarmackIascii: since v1 is experimental (?) and security groups will be ok in v2. there's no reason to add that check to the API ?19:03
lasciiccarmack: if you added the check to compute/cells_api.py that is v1 only code that would eventually get removed19:03
lasciiI have no strong feelings either way on adding the check or not19:03
lasciialso that's an L in my name :)19:04
ccarmackL19:04
ccarmackI thougth it was eye - ascii19:04
superdanlascii: it's too bad, or you could be IaaSki19:04
ccarmackLascii: I'll add the check it that ok19:05
mriedemlower case l19:05
*** marcusvrn_ has quit IRC19:05
mriedemI has a serif19:05
*** ansiwen has quit IRC19:05
mriedemupper case I19:05
ccarmackI thought Lascii was big on the ascii char set for some reason19:05
superdan|ascii19:05
mriedemhe is19:05
lasciiI like that one19:05
mriedemit's his hobby, hence his friday nick19:05
ccarmackwe all have our thing19:06
*** ansiwen has joined #openstack-nova19:06
superdan[ascii19:06
superdan1ascii19:06
ccarmackI'll do a patch for the api check...my first cells coding19:07
mriedemheh, i wonder what the process is around adding backward incompatible cells v1 API changes....19:07
mriedemit might be a black hole polar vortex19:07
ccarmackoh, forget that19:07
ccarmackwould it be a microversion?19:08
mriedemno...19:08
* lascii ponders printing an ascii chart to put on the wall now19:08
*** Marga_ has joined #openstack-nova19:08
*** e0ne has quit IRC19:08
mriedemit would probably be a thing that anyone that deploys cells v1 would never see19:08
*** erlon has quit IRC19:08
mriedemwhich is why lascii is indifferent19:08
lasciiyeah, it really shouldn't affect any users19:09
mriedemit might make ccarmack's series to cleanup that tempest rc blacklist easier19:09
mriedemto see if anything is missed in tempest19:09
*** thedodd has joined #openstack-nova19:10
dimsum__lascii: thanks!19:10
*** wolsen has quit IRC19:10
ccarmackmriedem: wouldn't cells tempest fail anyway on the server boot?19:10
mriedemccarmack: i don't think so, unless the test plans on ssh'ing into the guest19:11
mriedemand i don' think the validation flag is set in that job for the api tests19:11
mriedemsuperdan: you may or may not have an opinion on this, but i feel like it's probably come up before - how to repr objects in the logs https://review.openstack.org/#/c/227116/19:13
mriedemin this case an object list19:13
bauwsermriedem: looking at https://bugs.launchpad.net/nova/+bug/150183119:13
openstackLaunchpad bug 1501831 in OpenStack Compute (nova) "Evacuate libvirt instance failed with error 'Cannot load 'disk_format' in the base class'" [Undecided,New]19:13
superdanmriedem: damn right I have an opinion19:14
*** davideagnello has quit IRC19:14
bauwsermriedem: IIUC, that's only when the instance is volume-backed or not ?19:15
mgagneanyone familiar with python-libvirt? I'm trying to use migrateToURI3 and pass a parameter with multiple values (list of strings) and I can't seem to be able. The operation fails with 'Unknown type of "migrate_disks" field' (list of strings) or 'invalid argument: disk target vda,hdd not found' when joining the strings with ','19:15
*** jecarey has joined #openstack-nova19:15
*** tsekiyama has joined #openstack-nova19:16
mriedembauwser: looking19:16
bauwsertrying to identify the impact19:17
*** wolsen has joined #openstack-nova19:17
bauwsermriedem: asked to you because you updated to New, heh19:17
bauwser:p19:17
mriedemwell, instance boot fails apparently19:18
mriedemer evacuate in this case19:18
mriedemi'm checking the code19:18
mriedemijuwang: ^ is that bug recreated with upstream nova compute manager or powervc?19:19
ijuwangpowervc19:19
*** andrearosa has joined #openstack-nova19:20
mriedembauwser: didn't ndipanoff just redo a bunch of the rebuild_instance flow in the compute manager?19:20
ijuwangit really depends on whether {} could ever be the image_meta during evacuate19:20
*** su_zhang_ has quit IRC19:20
mriedemyeah i suppose here https://github.com/openstack/nova/blob/stable/liberty/nova/compute/manager.py#L265319:21
ijuwangit was set to None.. and during PowerVC evacuate of PowerKVM instance, we hit that issue19:21
*** mwagner_ has quit IRC19:21
mriedembecause of https://github.com/openstack/nova/blob/stable/liberty/nova/compute/manager.py#L265519:21
bauwsermriedem: it was mostly for claiming AFAIK19:21
bauwsermriedem: but maybe we are not talking from the same19:21
mriedemyeah i'm looking for where driver.spawn is called19:21
*** su_zhang_ has joined #openstack-nova19:21
mriedemah here https://github.com/openstack/nova/blob/stable/liberty/nova/compute/manager.py#L272219:22
mriedemthat's the recreate code i'm used to19:22
*** e0ne has joined #openstack-nova19:22
ijuwangimage_ref is set to None during evacuate in the api code19:24
bauwserso yeah, IIUC image_ref is set to None19:24
bauwseryeah that19:24
*** subscope has joined #openstack-nova19:24
bauwsermriedem: ijuwang: yep https://github.com/openstack/nova/blob/master/nova/compute/api.py#L333619:25
*** subscope_ has joined #openstack-nova19:25
*** baoli_ has quit IRC19:26
*** marcusvrn_ has joined #openstack-nova19:26
*** baoli has joined #openstack-nova19:26
bauwsermriedem: ijuwang: so basically, we're going thru this path until the driver spawns19:26
mriedembut where does image_meta get turned into an object?19:26
ijuwangspawn19:26
ijuwangin the driver19:26
bauwseryey19:27
ijuwanghttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L242719:27
bauwsermriedem: https://review.openstack.org/#/c/188119/19:27
mriedemhttps://github.com/openstack/nova/blob/stable/liberty/nova/virt/libvirt/driver.py#L242719:27
mriedemyeah19:27
bauwsermriedem: so, you see, it seems we have a regression...19:29
mriedemso....19:30
bauwserCritical I guess19:30
bauwserhence me hassling folks like mriedem19:30
mriedemimage_meta (the dict) must not have disk_format in it, or it's None and ImageMeta.from_dict defaults it to {}19:30
mriedemwhich basically creates an empty ImageMeta object19:30
mriedemso you'd have to lazy-load any attributes on it19:30
mriedemb/c image_ref is coming in as None from the API, yeah, so image_meta is {} when we convert to an object19:31
bauwserright19:32
mriedemok19:32
mriedemyeah, derp19:32
mriedemand we don't test evacuate in the gate b/c $reasons19:32
bauwseryup, unless I missed something19:32
*** vladikr has quit IRC19:32
mriedemthis is probably critical yeah since it impacts planned maintenance which is a thing people do to upgrade to liberty...19:33
mriedemsweet19:33
ccarmackmriedem: I'm curious, what is $reason set to?19:33
bauwserok, I guess the change is probably low-hanging-fruit19:33
ccarmackmriedem: why is it not tested in the gate?19:34
mriedemccarmack: it's been awhile since i've dug into it, but i think the service has to be down to evacuate19:34
bauwserindeed19:34
mriedemand that's kind of hard in a single-node devstack run with multiple test workers19:34
*** pm90__ has quit IRC19:34
bauwser!= live-migrate19:34
openstackbauwser: Error: "=" is not a valid command.19:34
bauwserdammit19:35
*** stevemar has quit IRC19:35
*** david-lyle has quit IRC19:35
bauwserevacuate => host down, rebuild a new vm != live-migrate where it copies the instance19:35
*** david-lyle has joined #openstack-nova19:35
bauwserso, lemme think about the fix19:36
mriedembauwser: so i'm thinking: if image_meta.get('disk_format', None) == 'iso':19:36
mriedemis the fix19:36
mriedemi can push that quick19:36
ijuwangi tried that19:36
mriedemand yeah it was regressed here https://review.openstack.org/#/c/188119/25/nova/virt/libvirt/blockinfo.py19:36
ijuwang that i didn't work19:36
*** SourabhP_ has joined #openstack-nova19:36
*** deva_brb is now known as deva_irssi19:36
ijuwangi don't think we can use .get anymore19:36
mriedemijuwang: did you do image_meta.get('disk_format') or get('disk_format', None)19:36
bauwserijuwang: .get is provided19:36
mriedembecause the None is important to avoid the lazy load19:36
bauwserijuwang: as a method for the ImageMetaProps19:37
mriedemlet me run a change quick19:37
ijuwangbut we are not doing ImageMetaProps .. it's against ImageMeta19:37
openstackgerritjichenjc proposed openstack/nova: devref: change error messages no need microversion  https://review.openstack.org/21849119:37
*** SourabhP has quit IRC19:37
*** nelsnelson has quit IRC19:37
*** SourabhP_ is now known as SourabhP19:38
mriedemijuwang: i'm going to put a change together that you can try19:38
mriedemgive me a few19:38
bauwserijuwang: right, we should perhaps use obj_attr_is_set() instead19:38
ijuwangi don't have the env anymore.. let me set another one up19:38
bauwsermriedem: like I said, obj_attr_is_set is a workaround19:40
bauwsermriedem: that's a dirty one tho19:40
mriedemsuperdan: won't image_meta.get('disk_format', None) avoid lazy-loading that attribute if it isn't set?19:40
mriedemon an ImageMeta object19:40
bauwsermriedem: because I'd prefer to hydrate the object correctly rather19:40
superdanmriedem: should, but I think he had a special case for that object19:40
*** e0ne has quit IRC19:40
mriedemthere was the image_meta.properties.get() stuff19:40
bauwsersuperdan: no, it's for ImageMetaProps19:40
*** su_zhan__ has joined #openstack-nova19:40
bauwsersuperdan: here, the load is for ImageMeta, the parent obj19:41
*** thedodd has quit IRC19:41
mriedemanyway, a unit test should tell me if it works or not19:41
bauwsermriedem: well, obj_attr_is_set does the trick19:41
mriedemyeah but i'd like to avoid that19:42
bauwseragreed19:42
bauwserhence my above point, we should rather hydrate the object correctly19:42
bauwserusing from_() method19:42
bauwserI mean, correcting from_dict() maybe19:43
bauwseror we could default the field to None19:43
*** su_zha___ has joined #openstack-nova19:44
*** su_zha___ has quit IRC19:44
bauwsersuperdan: but it would require a bump, right ?19:44
*** su_zhang_ has quit IRC19:44
superdanno?19:44
superdanbauwser: can you link me to what you're talking about?19:44
mriedembauwser: i don't know what we'd create it from though, image_meta is literally {}19:44
mriedemsuperdan: https://bugs.launchpad.net/nova/+bug/150183119:44
openstackLaunchpad bug 1501831 in OpenStack Compute (nova) "Evacuate libvirt instance failed with error 'Cannot load 'disk_format' in the base class'" [Critical,In progress] - Assigned to Matt Riedemann (mriedem)19:44
*** su_zhan__ has quit IRC19:44
*** SourabhP has quit IRC19:45
bauwsersuperdan: so https://github.com/openstack/nova/blob/master/nova/objects/image_meta.py#L64 is not defaulted19:45
*** david-ly_ has joined #openstack-nova19:45
bauwsersuperdan: since the from_dict() only hydrates what's in the dict, it leaves some fields unset19:45
bauwsersuperdan: and it then creates the above bug ^19:45
bauwsersuperdan: because of a story starting with image_ref=None in the api and then passing an empty dict19:46
bauwsersuperdan: so the resulted ImageMeta object is litterally empty19:46
mriedemhttps://github.com/openstack/nova/blob/stable/liberty/nova/virt/libvirt/blockinfo.py#L43219:47
*** yamahata has joined #openstack-nova19:47
mriedemwhich blows up there ^19:47
superdanwe either need to decide whether we want to depend on that field being set19:47
bauwsersuperdan: which just explodes the evacuate method19:47
superdanif not, then the libvirt driver should be going something like .get('foo', 0)19:47
*** SourabhP has joined #openstack-nova19:47
mriedemthe latter is what i'm writing a patch against19:48
superdanor.get('disk_format', 'raw') I guess19:48
mriedemdisk_format is nullable19:48
bauwsersuperdan: the original version was using the .get() dict method19:48
superdanbauwser: yeah, so that's what we should do I think19:48
bauwsersuperdan: https://review.openstack.org/#/c/188119/25/nova/virt/libvirt/blockinfo.py19:48
mriedemsuperdan: yup, doing that now19:48
superdanbauwser: the libvirt driver should know that nothing was specified19:48
mriedemrunning the test19:48
bauwserso adding a new .get() method to ImageMeta ?19:49
bauwsermriedem: ^19:49
*** david-lyle has quit IRC19:49
mriedemno19:49
*** david-ly_ has quit IRC19:49
superdanbauwser: and disk_format shouldn't be nullable because "no disk format" makes no sense19:49
bauwsersuperdan: that, I agree :)19:49
mriedemdamn19:49
mriedemAttributeError: 'ImageMeta' object has no attribute 'get'19:49
bauwsermriedem: yeah hence my point19:49
mriedemb/c ImageMeta doesn't extend the dictcmpat object19:49
bauwsermriedem: .get is only for ImageMetaProps like I said :D19:49
*** setuid has quit IRC19:49
bauwsermriedem: and that too :D19:50
superdanmriedem: because it doesn't inherit from the dict mixin19:50
mriedemyup19:50
mriedemNovaObjectDictCompat19:50
mriedemshite19:50
bauwserthat's new object-style :)19:50
mriedemso i'm guessing we don't want to add NovaObjectDictCompat back into ImageMeta19:50
superdanmriedem: but you can add the .get() easily, no bump required, but it'd be more objecty to just check obj_attr_is_set()19:50
superdanmriedem: no19:50
*** setuid has joined #openstack-nova19:51
bauwsersuperdan: yeah like I said to mriedem, we can use obj_attr_is_set but it exposes that's an object19:51
*** ctrath has quit IRC19:51
bauwserbut that's a quick fix19:51
superdanI don't understand "but it exposes", but yes, that's how I'd do it19:51
mriedembauwser: yeah, it's already exposed as an object b/c of dot notation19:51
mriedemalright, i'll do the other more explicit thing19:51
bauwserokay, so I was BT paired with superdan19:51
mriedemi'm just wondering what else is doing this19:52
bauwseryeah, hence me wondering what could be a proper from_dict()19:52
*** thumpba has quit IRC19:53
bauwsersince we have no nullable strings, I think we should have a from_dict() which would litterally hydrate all fields19:53
bauwserbecause that's a contract19:53
*** ctrath has joined #openstack-nova19:53
mriedemwell, or at least default the nullable ones to '' like it's doing19:53
mriedemin from_dict()19:53
*** burgerk_ has joined #openstack-nova19:54
bauwsermriedem: in ImageMeta, I can't see fields that are nullable but the persisting ones19:54
bauwsermriedem: so, it means that an instance of that object should have all the fields set19:54
bauwserthat's MHO19:54
bauwserbut maybe superdan unpaired BT on that one19:54
mriedemi meant this https://github.com/openstack/nova/blob/stable/liberty/nova/objects/image_meta.py#L11219:54
bauwserah19:55
* bauwser facepalm19:55
mriedemlike setdefault(self, field, '')19:55
bauwseryeah that too19:55
mriedemself.setdefault(field, '')19:55
superdanbauwser: I disagree.. you need to know whether they specified a disk format or not. Nullable means "can have None" and that doesn't make sense for something like disk_format19:55
superdandisk_format=None doesn't mean "take the default". Not setting it at all means "take the default"19:56
bauwsersuperdan: yeah that's my point, I was unclear19:56
mriedemyeah i didn't want to go down this route b/c of the weird nullable vs '' change in there19:56
superdanbauwser: okay19:56
bauwsersuperdan: since the field is not nullable, we should hydrate some default value19:56
bauwserwhen calling from_dict19:56
bauwserbut that's MHO19:56
*** mwagner_ has joined #openstack-nova19:57
*** burgerk has quit IRC19:57
superdanbauwser: no, I disagree!19:57
bauwserahah19:57
bauwserokay, fair enough19:57
bauwser:)19:57
*** su_zhang_ has joined #openstack-nova19:57
superdanbauwser: because we can't do that at the API layer for every virt driver.. all we have to do is communicate that they didn't ask for anything, which is the virt driver's cue19:57
bauwserso, then, obj_attr_is_set :)19:58
bauwsersuperdan: heu, I don't get your point, but that's fair19:58
bauwseryour object skils are far better than mine :D19:59
*** thumpba has joined #openstack-nova19:59
bauwserbecause .from_dict() was called by the virt driver19:59
*** apoorvad has quit IRC19:59
*** burgerk_ has quit IRC19:59
superdanyes, but from_dict is not owned by the driver20:00
superdananyway, obj_attr_is_set() for now, yes20:00
bauwsersuperdan: oooooh I see20:00
openstackgerritMatt Riedemann proposed openstack/nova: libvirt: check if ImageMeta.disk_format is set before accessing it  https://review.openstack.org/23062520:01
superdanmelwitt: sorry I missed a comment without a -1?20:01
melwittsuperdan: I didn't know if it was missed yet but I thought maybe I should put it just in case20:02
*** pixelbeat has quit IRC20:02
bauwsermriedem: FWIW, +1'd20:03
mriedemijuwang: https://review.openstack.org/230625 if you can test that20:04
superdanmelwitt: you should pretty much always -1 my patches if you have a comment you want me to see.. my workflow and review email processing doesn't reward niceness :)20:04
mriedembauwser: <320:04
bauwsermriedem: no, me <320:04
*** jichen has quit IRC20:04
ijuwangsure.. I just finished setting up the env.. I will try it next20:04
melwittsuperdan: got it :)20:04
*** jichen has joined #openstack-nova20:05
melwittsuperdan: I'll remove -1 obviously if it turns out my comment/question was wacky20:05
*** jichen has quit IRC20:05
*** jichen has joined #openstack-nova20:06
*** karmatronic has quit IRC20:06
*** pm90_ has joined #openstack-nova20:07
*** jichen has quit IRC20:09
*** jichen has joined #openstack-nova20:10
*** pm90_ has quit IRC20:10
*** pm90_ has joined #openstack-nova20:11
*** jichen has joined #openstack-nova20:11
openstackgerritAndrew Laski proposed openstack/python-novaclient: Test that microversions are not skipped  https://review.openstack.org/23060320:11
*** jichen has quit IRC20:11
superdanmelwitt: replied to your exception thing, see what you hink20:12
superdanobviously the thing on the base patch is right20:12
superdanI mean you're right20:12
ccarmacksuperdan, bauwser, mriedem: stupid question on https://review.openstack.org/#/c/230625/1/nova/virt/libvirt/blockinfo.py ... could the == operator be overloaded?20:12
* melwitt looks20:12
*** apoorvad has joined #openstack-nova20:12
superdanccarmack: no20:12
*** tsekiyama has quit IRC20:12
bauwserccarmack: no20:12
bauwserhah20:13
ccarmack... because it can't be done in python, or is a bad idea in this case?20:13
bauwserbecause it would hide the logic20:13
mriedemit can be done20:13
mriedemwith __eq__20:13
mriedembut that doesn't mean it should be done20:14
bauwseryup, but that's errorprone20:14
*** signed8bit is now known as signed8bit_ZZZzz20:14
superdanmriedem: it can't unless you implement that on field and do some weird monkeywork20:14
ccarmackseems like it makes it easier for the virt programmer20:14
mriedemsuperdan: i know20:14
superdanmriedem: because the deref is what triggers20:14
mriedembut it can be done20:14
mriedemtrue20:14
superdanand what do you compare with?20:14
superdannot None20:14
mriedemNone.__eq__ is bad20:14
superdanyou can't compare to None for testing "is set" because then that conflates with if it's actually none20:15
*** jichen has joined #openstack-nova20:15
mriedemlet's just monkey patch __eq__ in python20:15
mriedemcan we do that?20:15
superdanheh20:15
*** jichen has quit IRC20:15
superdanhow about we patch ccarmack.__eq__ ?20:15
ccarmacknm :-X20:15
mriedemis it possible to hack the interpreter?20:15
*** signed8bit_ZZZzz is now known as signed8bit20:16
*** jichen has joined #openstack-nova20:16
mriedemsurely sqlalchemy has solved this problem :)20:16
*** jichen has joined #openstack-nova20:16
superdanit always has dict behavior20:16
superdanso yeah20:16
superdanand we could do that20:17
*** jichen has quit IRC20:17
superdanwe could keep __contains__20:17
*** READ10 has quit IRC20:17
superdanso you could do "if 'foo' in image_meta"20:17
*** kairo has quit IRC20:17
*** tsekiyama has joined #openstack-nova20:17
*** thumpba has quit IRC20:17
*** jichen has joined #openstack-nova20:17
mriedemyeah20:17
mriedemhttps://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L70420:18
*** jichen has quit IRC20:18
mriedemi kind of actually like that better20:18
superdanright, that went with the dict splitout20:18
mriedembut that's dict compat20:18
superdanbut we could pull it back20:18
mriedeminto VersionedObject?20:18
superdanyeah20:18
bauwsermmm20:18
superdanI mean, not for this fix of course20:18
mriedemlet's do it!20:18
mriedemyeah20:18
mriedemyou don't want to update ovo, release, require min new version and then backport all?20:19
superdanthe thing we want to not be part of the base object is like __getitem__ and iteritems and stuff20:19
mriedemmy stats would be insane!20:19
bauwserhonestly, I thought we were wanting to remove the dict compat?20:19
superdanheh20:19
superdanbauwser: yes20:19
*** SourabhP has quit IRC20:19
mriedemif x in y: is much cleaner than if y.obj_attr_is_set(x) and y.x == z: imo20:19
superdanbauwser: what I'm saying is that __contains__ doesn't  need to be dict20:19
bauwserfair point20:20
mriedemyar20:20
superdanlots of non dicts have __contains__20:20
bauwseragreed20:20
*** jichen has joined #openstack-nova20:20
*** jichen has quit IRC20:20
bauwserthat just means it's a iterable20:20
superdanno20:20
bauwseruh, a container20:20
bauwsermy bad20:20
superdanyes, a container20:20
*** jichen has joined #openstack-nova20:21
*** jichen has quit IRC20:21
*** jichen has joined #openstack-nova20:21
bauwsersuperdan: mriedem: https://www.youtube.com/watch?v=7GL6LH6ufhM20:22
superdanheh20:22
superdaneverybody wants to be like mriedem20:23
*** jichen has quit IRC20:23
superdannobody wants to be like su_zhang_20:23
superdaner, superdan20:23
superdanheh20:23
melwittlol20:23
mriedemracist!20:23
superdansu_zhang_: tab completion fail, my apologies :X20:23
bauwserlol20:23
su_zhang_fine20:23
melwittI know I want to be like mriedem. that's why I say hells bells whenever I can20:23
superdanyeah :/20:23
melwitt:|20:24
mriedemoh that's classic20:24
rlrossitI thought to be like mriedem you had to say gdi all the time20:24
*** david-lyle has joined #openstack-nova20:24
mriedemsuperdan: so if i want __contains__ in VersionedObject in ovo, can it live in both that and the dict compat class temporarily? or do we assume that all classes that extend dict compat also extend VersionedObject?20:25
mriedemseems like a bad assumption to make20:25
*** jichen has joined #openstack-nova20:25
superdanmriedem: it can be in both20:25
mriedemor make it it's own mixin that both take20:25
superdannah, just do it in the base20:25
*** jichen has quit IRC20:25
mriedemok20:25
openstackgerritDan Smith proposed openstack/nova: Add get_minimum_version() to Service object and DB API  https://review.openstack.org/22332020:26
openstackgerritDan Smith proposed openstack/nova: Allow automatic determination of compute_rpc version by service  https://review.openstack.org/22332120:26
openstackgerritDan Smith proposed openstack/nova: Extend the ServiceTooOld exception with more data  https://review.openstack.org/23022720:26
openstackgerritDan Smith proposed openstack/nova: Make service create/update fail if version is too old  https://review.openstack.org/22904920:26
superdanmriedem: thanks for catching that ^20:26
*** jichen has joined #openstack-nova20:26
superdandammit20:26
superdanmelwitt:20:26
mriedemccarmack: see, don't feel bad, something constructive came out of your eq question20:26
superdanwhat is wrong with me20:26
*** jichen has quit IRC20:26
*** jichen has joined #openstack-nova20:27
melwitt... :)20:27
*** jichen has quit IRC20:27
bauwsersuperdan: go to sleep !20:27
bauwser:p20:27
superdanmelwitt: yeah, I know you know what's wrong and don't want to say :)20:27
superdanbauwser: touche20:27
bauwseranyway, seems a nice opportunity for20:28
*** bauwser is now known as bauzas20:28
bauzasbye folks20:28
superdano/20:28
mriedembauzas: later20:28
melwittsuperdan: it's fun to pretend I do20:28
*** leakypipes has quit IRC20:28
superdanheh20:28
*** aysyd has quit IRC20:30
*** jichen has joined #openstack-nova20:30
*** VW has quit IRC20:32
*** VW has joined #openstack-nova20:32
*** SourabhP has joined #openstack-nova20:33
*** jichen has quit IRC20:34
*** jichen has joined #openstack-nova20:35
*** jichen has quit IRC20:35
*** jichen has joined #openstack-nova20:36
*** jichen has quit IRC20:36
*** jichen has joined #openstack-nova20:37
*** VW has quit IRC20:37
*** jichen has joined #openstack-nova20:40
*** jichen has quit IRC20:40
*** jichen has joined #openstack-nova20:41
ijuwangmriedem: it works..20:43
mriedemcool20:43
*** ZZelle has quit IRC20:44
mriedemijuwang: want to ack in the change to note you've verified it fixes the bug?20:44
*** jichen has quit IRC20:44
ijuwangsure20:44
*** jichen has joined #openstack-nova20:45
*** jichen has quit IRC20:46
*** jichen has joined #openstack-nova20:46
*** jichen has joined #openstack-nova20:47
*** ZZelle has joined #openstack-nova20:47
*** jichen has quit IRC20:47
ijuwangmriedem: btw, there is a lower priority issue I submitted a fix, what I need to do to get some review.. https://review.openstack.org/#/c/227039/20:47
*** tsekiyama has quit IRC20:47
*** zzzeek has quit IRC20:48
*** ccarmack has left #openstack-nova20:52
*** angdraug has joined #openstack-nova20:53
openstackgerritxing-yang proposed openstack/nova: Rollback is needed if initialize_connection times out  https://review.openstack.org/13866420:55
*** raildo is now known as raildo-afk20:56
openstackgerritDan Smith proposed openstack/nova: Allow automatic determination of compute_rpc version by service  https://review.openstack.org/22332120:57
openstackgerritDan Smith proposed openstack/nova: Extend the ServiceTooOld exception with more data  https://review.openstack.org/23022720:57
openstackgerritDan Smith proposed openstack/nova: Make service create/update fail if version is too old  https://review.openstack.org/22904920:57
*** amotoki has joined #openstack-nova20:58
*** tsekiyama has joined #openstack-nova20:58
*** amotoki has quit IRC21:03
*** tsekiyam_ has joined #openstack-nova21:03
*** dustins has quit IRC21:03
*** mtanino has quit IRC21:04
*** MVenesio has quit IRC21:06
*** tsekiyama has quit IRC21:07
*** tsekiyam_ has quit IRC21:07
*** thumpba has joined #openstack-nova21:10
*** stevemar has joined #openstack-nova21:12
*** su_zhang_ has quit IRC21:14
*** ociuhandu has quit IRC21:18
*** salv-orlando has joined #openstack-nova21:19
*** nelsnelson has joined #openstack-nova21:21
*** nelsnelson has quit IRC21:23
*** nelsnels_ has joined #openstack-nova21:23
*** vilobhmm111 has quit IRC21:25
*** vilobhmm11 has joined #openstack-nova21:25
*** pm90__ has joined #openstack-nova21:26
*** diogogmt_ has joined #openstack-nova21:26
*** salv-orlando has quit IRC21:27
*** diogogmt has quit IRC21:29
*** diogogmt_ is now known as diogogmt21:29
*** pm90_ has quit IRC21:29
mriedemflashgordon: you're on the TC ballot?21:30
flashgordonmriedem: it appears so21:32
flashgordonif I win, I will go to the summit21:32
*** signed8bit is now known as signed8bit_ZZZzz21:36
*** su_zhang_ has joined #openstack-nova21:38
*** pixelbeat has joined #openstack-nova21:41
mriedemmikal: lascii: _cerberus_: this is marked as critical and liberty-rc-potential since it impacts evacuate (which impacts maintenance which impacts upgrades), so asking for a look so i can backport to stable/liberty https://review.openstack.org/#/c/230625/21:42
openstackgerritMatt Riedemann proposed openstack/nova: libvirt: check if ImageMeta.disk_format is set before accessing it  https://review.openstack.org/23062521:44
*** bnemec has joined #openstack-nova21:44
mriedemsona21:44
mriedem*sonofa21:44
mriedem.gitreview isn't updated for stalbe/liberty21:44
mriedemdamn21:44
superdanheh21:45
*** yamahata has quit IRC21:45
*** marcusvrn_ has quit IRC21:45
openstackgerritMatt Riedemann proposed openstack/nova: libvirt: check if ImageMeta.disk_format is set before accessing it  https://review.openstack.org/23062521:46
mriedemsuperdan: can you reapply the +2 there?21:46
*** rlrossit has left #openstack-nova21:48
openstackgerritMatt Riedemann proposed openstack/nova: libvirt: check if ImageMeta.disk_format is set before accessing it  https://review.openstack.org/23062521:49
*** tonytan4ever has quit IRC21:49
superdanif you stop dicking with it21:49
*** thumpba has quit IRC21:49
*** ctrath has quit IRC21:49
mriedemyeah i had to remove the commit message change so i can push it again21:49
mriedemi think i'm done now21:50
mriedemand leaving21:50
*** mriedem has quit IRC21:51
*** signed8bit_ZZZzz is now known as signed8bit21:55
*** karimb has quit IRC21:55
*** subscope_ has quit IRC21:56
*** burt has quit IRC21:57
*** su_zhang_ has quit IRC22:00
*** ijw has quit IRC22:02
openstackgerritJim Rollenhagen proposed openstack/nova: Ironic: Fix bad capacity reporting if instance_info is unset  https://review.openstack.org/23048722:02
jrolllascii: superdan fffuuuu22:03
jrollwhen I fixed that test I nuked my stupid pep8 fixc22:03
jrollfix*22:03
superdandone22:03
*** xyang1 has quit IRC22:03
jrollthanks22:04
*** ijw has joined #openstack-nova22:04
*** SourabhP has quit IRC22:05
*** bnemec has quit IRC22:06
*** yamahata has joined #openstack-nova22:07
*** VW has joined #openstack-nova22:08
*** dave-mccowan has quit IRC22:08
*** eglynn has quit IRC22:08
*** dimsum__ has quit IRC22:09
*** SourabhP has joined #openstack-nova22:09
*** stevemar has quit IRC22:14
*** stevemar has joined #openstack-nova22:14
*** SourabhP has quit IRC22:16
openstackgerritDeepti Ramakrishna proposed openstack/nova-specs: Data Security Enforcements In Nova  https://review.openstack.org/23067722:16
*** zz_john5223 is now known as john522322:18
*** stevemar has quit IRC22:18
*** pm90_ has joined #openstack-nova22:24
*** lhcheng has quit IRC22:24
*** pm90___ has joined #openstack-nova22:25
*** pm90__ has quit IRC22:25
*** VW_ has joined #openstack-nova22:26
*** su_zhang_ has joined #openstack-nova22:26
*** jwcroppe has quit IRC22:26
*** VW has quit IRC22:29
*** pm90_ has quit IRC22:29
*** subscope has quit IRC22:30
*** VW_ has quit IRC22:30
openstackgerritmelanie witt proposed openstack/nova: Check DBReferenceError foreign key in Instance.save  https://review.openstack.org/22866022:35
openstackgerritmelanie witt proposed openstack/nova: Fix Instance unit test for DBReferenceError  https://review.openstack.org/22865922:35
*** obedmr has quit IRC22:36
*** rustlebee is now known as russellb22:39
*** SourabhP has joined #openstack-nova22:40
*** david-lyle has quit IRC22:45
*** edmondsw has quit IRC22:46
*** david-lyle has joined #openstack-nova22:47
*** ijuwang has quit IRC22:47
*** jasondotstar is now known as jasondotstar|afk22:48
*** marzif has quit IRC22:49
*** ijw has quit IRC22:51
*** pixelbeat has quit IRC22:51
*** IanGovett has quit IRC22:55
*** signed8b_ has joined #openstack-nova22:57
*** jwcroppe has joined #openstack-nova22:58
*** signed8bit has quit IRC22:59
*** amotoki has joined #openstack-nova22:59
*** jwcroppe has quit IRC22:59
*** jwcroppe has joined #openstack-nova23:00
*** ijw has joined #openstack-nova23:01
*** ijw has quit IRC23:01
*** dimsum__ has joined #openstack-nova23:02
*** amotoki has quit IRC23:04
*** otter768 has quit IRC23:04
*** otter768 has joined #openstack-nova23:05
*** jwcroppe has quit IRC23:05
*** su_zhang_ has quit IRC23:05
*** eharney has quit IRC23:09
*** alejandrito has quit IRC23:10
*** MVenesio has joined #openstack-nova23:17
*** MVenesio has quit IRC23:18
*** electroc_ has quit IRC23:18
*** electrocucaracha has joined #openstack-nova23:19
*** electrocucaracha has quit IRC23:19
*** manishg has joined #openstack-nova23:19
*** kolesovdv has joined #openstack-nova23:21
*** achanda_ has joined #openstack-nova23:22
*** signed8b_ is now known as signed8bit_ZZZzz23:22
*** hemna is now known as hemnafk23:24
*** achanda has quit IRC23:25
*** achanda_ has quit IRC23:26
*** pm90_ has joined #openstack-nova23:30
*** pm90___ has quit IRC23:34
*** deva_irssi has quit IRC23:43
*** dimsum__ has quit IRC23:46
*** erhudy has quit IRC23:49
*** diogogmt_ has joined #openstack-nova23:51
*** SourabhP has quit IRC23:51
*** diogogmt has quit IRC23:52
*** diogogmt_ is now known as diogogmt23:52
*** tjones has joined #openstack-nova23:52
*** pm90_ has quit IRC23:54
*** tjones has left #openstack-nova23:54
*** diogogmt has quit IRC23:54
*** diogogmt has joined #openstack-nova23:56
*** otter768 has quit IRC23:56
*** otter768 has joined #openstack-nova23:56

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!