*** markvoelker has quit IRC | 00:00 | |
*** zhangjn has joined #openstack-nova | 00:01 | |
*** otter768 has joined #openstack-nova | 00:01 | |
*** pixelb has joined #openstack-nova | 00:02 | |
*** ijuwang has quit IRC | 00:02 | |
*** jerrygb has quit IRC | 00:03 | |
*** heyongli has quit IRC | 00:05 | |
*** pratikma_ has quit IRC | 00:06 | |
*** heyongli has joined #openstack-nova | 00:06 | |
*** zhangjn has quit IRC | 00:08 | |
*** browne has quit IRC | 00:09 | |
*** amotoki has joined #openstack-nova | 00:09 | |
*** Daisy_ has joined #openstack-nova | 00:10 | |
*** EinstCrazy has quit IRC | 00:10 | |
*** EinstCrazy has joined #openstack-nova | 00:12 | |
*** amotoki has quit IRC | 00:14 | |
*** heyongli has quit IRC | 00:15 | |
*** heyongli has joined #openstack-nova | 00:16 | |
*** Marga_ has quit IRC | 00:17 | |
*** diogogmt has quit IRC | 00:19 | |
*** EinstCrazy has quit IRC | 00:23 | |
*** ssurana has quit IRC | 00:24 | |
*** heyongli has quit IRC | 00:25 | |
*** heyongli has joined #openstack-nova | 00:26 | |
openstackgerrit | Shraddha Pandhe proposed openstack/nova: Do not mask original spawn failure if shutdown_instance fails https://review.openstack.org/240347 | 00:27 |
---|---|---|
*** salv-orlando has quit IRC | 00:27 | |
*** angdraug has quit IRC | 00:27 | |
*** otter768 has quit IRC | 00:28 | |
*** heyongli has quit IRC | 00:36 | |
*** heyongli has joined #openstack-nova | 00:37 | |
*** shz has quit IRC | 00:40 | |
*** shz has joined #openstack-nova | 00:41 | |
*** pumaranikar has joined #openstack-nova | 00:43 | |
*** heyongli has quit IRC | 00:46 | |
*** heyongli has joined #openstack-nova | 00:47 | |
*** su_zhang has quit IRC | 00:47 | |
*** gonzalo2kx has joined #openstack-nova | 00:51 | |
*** jdurgin has quit IRC | 00:51 | |
*** eliqiao1 is now known as eliqiao | 00:52 | |
*** zzzeek has quit IRC | 00:52 | |
*** zzzeek has joined #openstack-nova | 00:53 | |
*** r-daneel has quit IRC | 00:55 | |
*** xyang1 has quit IRC | 00:55 | |
*** heyongli has quit IRC | 00:56 | |
*** heyongli has joined #openstack-nova | 00:57 | |
*** RuiChen has quit IRC | 00:58 | |
*** zzzeek has quit IRC | 00:59 | |
*** RuiChen has joined #openstack-nova | 00:59 | |
*** zzzeek has joined #openstack-nova | 00:59 | |
*** EinstCrazy has joined #openstack-nova | 01:00 | |
*** markvoelker has joined #openstack-nova | 01:00 | |
*** Daisy_ has quit IRC | 01:00 | |
*** asettle has joined #openstack-nova | 01:01 | |
*** zhangjn has joined #openstack-nova | 01:01 | |
*** Daisy_ has joined #openstack-nova | 01:01 | |
*** tjones has joined #openstack-nova | 01:02 | |
*** ndipanov has joined #openstack-nova | 01:04 | |
*** markvoelker has quit IRC | 01:05 | |
*** Daisy_ has quit IRC | 01:05 | |
*** heyongli has quit IRC | 01:06 | |
*** heyongli has joined #openstack-nova | 01:07 | |
*** EinstCra_ has joined #openstack-nova | 01:09 | |
*** zhenguo has joined #openstack-nova | 01:09 | |
*** hemna is now known as hemnafk | 01:10 | |
*** browne has joined #openstack-nova | 01:11 | |
*** eliqiao_summit has joined #openstack-nova | 01:12 | |
*** EinstCr__ has joined #openstack-nova | 01:12 | |
*** eliqiao_summit has quit IRC | 01:13 | |
*** su_zhang has joined #openstack-nova | 01:13 | |
*** EinstCrazy has quit IRC | 01:13 | |
*** mc_nair has quit IRC | 01:14 | |
*** tpeoples has joined #openstack-nova | 01:14 | |
*** kylek3h has quit IRC | 01:15 | |
*** kylek3h has joined #openstack-nova | 01:15 | |
*** su_zhang has quit IRC | 01:15 | |
*** EinstCra_ has quit IRC | 01:16 | |
*** su_zhang has joined #openstack-nova | 01:16 | |
*** tjones has left #openstack-nova | 01:16 | |
*** heyongli has quit IRC | 01:17 | |
*** heyongli has joined #openstack-nova | 01:18 | |
*** jogo has joined #openstack-nova | 01:19 | |
*** achanda has quit IRC | 01:20 | |
*** tpeoples has quit IRC | 01:23 | |
openstackgerrit | Zhang Ni proposed openstack/nova-specs: Add volume type to create server API https://review.openstack.org/241059 | 01:23 |
*** kylek3h has quit IRC | 01:23 | |
*** heyongli has quit IRC | 01:27 | |
*** Murali__ has quit IRC | 01:27 | |
*** heyongli has joined #openstack-nova | 01:28 | |
*** mtanino has quit IRC | 01:28 | |
openstackgerrit | Zhang Ni proposed openstack/nova-specs: Improve nova attach volume api to support disk-bus https://review.openstack.org/241063 | 01:33 |
*** ildikov has joined #openstack-nova | 01:34 | |
*** rfolco has joined #openstack-nova | 01:36 | |
*** su_zhang has quit IRC | 01:36 | |
*** heyongli has quit IRC | 01:37 | |
*** jerrygb has joined #openstack-nova | 01:38 | |
*** heyongli has joined #openstack-nova | 01:38 | |
*** emagana has quit IRC | 01:39 | |
*** EinstCr__ has quit IRC | 01:41 | |
openstackgerrit | Zhang Ni proposed openstack/nova-specs: Add volume type to create server API https://review.openstack.org/241065 | 01:42 |
*** achanda has joined #openstack-nova | 01:44 | |
openstackgerrit | Zhang Ni proposed openstack/nova-specs: Add local-to-instance to create server api https://review.openstack.org/241066 | 01:44 |
*** Daisy_ has joined #openstack-nova | 01:45 | |
*** heyongli has quit IRC | 01:47 | |
*** heyongli has joined #openstack-nova | 01:48 | |
*** dims has quit IRC | 01:49 | |
*** tpeoples has joined #openstack-nova | 01:50 | |
*** achanda has quit IRC | 01:52 | |
*** achanda has joined #openstack-nova | 01:54 | |
*** josecastroleon has quit IRC | 01:57 | |
*** heyongli has quit IRC | 01:58 | |
*** Daisy_ has quit IRC | 01:58 | |
*** Daisy_ has joined #openstack-nova | 01:58 | |
*** heyongli has joined #openstack-nova | 01:59 | |
*** markvoelker has joined #openstack-nova | 02:01 | |
*** Daisy_ has quit IRC | 02:02 | |
*** erlarese has joined #openstack-nova | 02:06 | |
*** markvoelker has quit IRC | 02:06 | |
*** heyongli has quit IRC | 02:08 | |
*** dims has joined #openstack-nova | 02:08 | |
*** heyongli has joined #openstack-nova | 02:09 | |
*** amotoki has joined #openstack-nova | 02:10 | |
*** erlarese has quit IRC | 02:13 | |
*** haomaiwang has joined #openstack-nova | 02:14 | |
*** amotoki has quit IRC | 02:15 | |
*** venkat_p has joined #openstack-nova | 02:17 | |
*** heyongli has quit IRC | 02:18 | |
*** heyongli has joined #openstack-nova | 02:19 | |
*** kylek3h has joined #openstack-nova | 02:21 | |
*** unicell has quit IRC | 02:23 | |
*** heyongli has quit IRC | 02:28 | |
*** otter768 has joined #openstack-nova | 02:29 | |
*** kylek3h has quit IRC | 02:29 | |
*** heyongli has joined #openstack-nova | 02:29 | |
*** rfolco has quit IRC | 02:29 | |
*** otter768 has quit IRC | 02:33 | |
*** seanw1 has quit IRC | 02:34 | |
*** seanw1 has joined #openstack-nova | 02:35 | |
*** jwcroppe has joined #openstack-nova | 02:37 | |
*** klkumar has joined #openstack-nova | 02:38 | |
*** heyongli has quit IRC | 02:39 | |
*** heyongli has joined #openstack-nova | 02:40 | |
*** emagana has joined #openstack-nova | 02:43 | |
*** Daisy has joined #openstack-nova | 02:47 | |
openstackgerrit | Chet Burgess proposed openstack/nova-specs: RBD instance snapshots https://review.openstack.org/188244 | 02:47 |
*** heyongli has quit IRC | 02:49 | |
*** vilobhmm11 has quit IRC | 02:49 | |
*** heyongli has joined #openstack-nova | 02:50 | |
*** salv-orlando has joined #openstack-nova | 02:51 | |
*** edtubill has joined #openstack-nova | 02:56 | |
*** hparekh2 has joined #openstack-nova | 02:58 | |
*** hparekh has quit IRC | 02:59 | |
*** heyongli has quit IRC | 02:59 | |
*** heyongli has joined #openstack-nova | 03:00 | |
*** haomaiwang has quit IRC | 03:01 | |
*** haomaiwang has joined #openstack-nova | 03:01 | |
*** markvoelker has joined #openstack-nova | 03:02 | |
*** Daisy has quit IRC | 03:05 | |
*** Daisy has joined #openstack-nova | 03:05 | |
*** markvoelker has quit IRC | 03:07 | |
*** edtubill has quit IRC | 03:09 | |
*** mdrabe has joined #openstack-nova | 03:09 | |
*** heyongli has quit IRC | 03:09 | |
*** Daisy has quit IRC | 03:10 | |
*** ssurana has joined #openstack-nova | 03:10 | |
*** heyongli has joined #openstack-nova | 03:10 | |
*** salv-orlando has quit IRC | 03:12 | |
*** jwcroppe has quit IRC | 03:12 | |
*** jwcroppe has joined #openstack-nova | 03:13 | |
*** Daisy has joined #openstack-nova | 03:13 | |
*** tpeoples has quit IRC | 03:13 | |
*** ssurana has left #openstack-nova | 03:14 | |
*** spandhe has quit IRC | 03:15 | |
*** dave-mccowan has quit IRC | 03:17 | |
*** jwcroppe has quit IRC | 03:17 | |
*** heyongli has quit IRC | 03:20 | |
*** heyongli has joined #openstack-nova | 03:21 | |
*** eliqiao has left #openstack-nova | 03:23 | |
*** otter768 has joined #openstack-nova | 03:24 | |
*** kylek3h has joined #openstack-nova | 03:26 | |
*** dims has quit IRC | 03:28 | |
*** heyongli has quit IRC | 03:30 | |
*** heyongli has joined #openstack-nova | 03:31 | |
*** kylek3h has quit IRC | 03:33 | |
*** klkumar has quit IRC | 03:37 | |
*** veena has joined #openstack-nova | 03:37 | |
*** klkumar has joined #openstack-nova | 03:38 | |
*** heyongli has quit IRC | 03:40 | |
*** heyongli has joined #openstack-nova | 03:41 | |
*** chenzeng has joined #openstack-nova | 03:46 | |
*** armax has quit IRC | 03:47 | |
*** heyongli has quit IRC | 03:50 | |
*** heyongli has joined #openstack-nova | 03:51 | |
*** links has joined #openstack-nova | 03:53 | |
*** haomaiwang has quit IRC | 04:01 | |
*** heyongli has quit IRC | 04:01 | |
*** 17WAAY74W has joined #openstack-nova | 04:01 | |
*** klkumar has quit IRC | 04:01 | |
*** Daisy has quit IRC | 04:01 | |
*** heyongli has joined #openstack-nova | 04:02 | |
*** Daisy has joined #openstack-nova | 04:02 | |
*** stackdump has joined #openstack-nova | 04:02 | |
*** Daisy has quit IRC | 04:07 | |
*** stackdump has quit IRC | 04:07 | |
*** pumaranikar has quit IRC | 04:07 | |
*** salv-orlando has joined #openstack-nova | 04:09 | |
*** heyongli has quit IRC | 04:11 | |
*** amotoki has joined #openstack-nova | 04:11 | |
*** heyongli has joined #openstack-nova | 04:12 | |
*** klkumar has joined #openstack-nova | 04:13 | |
*** hparekh2 has quit IRC | 04:15 | |
*** otter768 has quit IRC | 04:15 | |
*** amotoki has quit IRC | 04:15 | |
*** Sree has joined #openstack-nova | 04:16 | |
*** Sree has quit IRC | 04:17 | |
*** hparekh has joined #openstack-nova | 04:17 | |
*** Sree has joined #openstack-nova | 04:17 | |
*** klkumar has quit IRC | 04:20 | |
*** unicell has joined #openstack-nova | 04:20 | |
*** heyongli has quit IRC | 04:21 | |
*** heyongli has joined #openstack-nova | 04:22 | |
*** unicell1 has joined #openstack-nova | 04:24 | |
*** unicell has quit IRC | 04:24 | |
*** chenzeng has quit IRC | 04:27 | |
*** Daisy has joined #openstack-nova | 04:27 | |
*** pradipta has joined #openstack-nova | 04:27 | |
*** Daisy has quit IRC | 04:28 | |
*** deepakcs has joined #openstack-nova | 04:28 | |
*** kylek3h has joined #openstack-nova | 04:30 | |
*** heyongli has quit IRC | 04:31 | |
*** heyongli has joined #openstack-nova | 04:32 | |
*** gongysh has joined #openstack-nova | 04:33 | |
*** salv-orlando has quit IRC | 04:34 | |
*** klkumar has joined #openstack-nova | 04:37 | |
*** kylek3h has quit IRC | 04:39 | |
*** sahid has joined #openstack-nova | 04:40 | |
*** heyongli has quit IRC | 04:42 | |
*** heyongli has joined #openstack-nova | 04:43 | |
*** jdurgin has joined #openstack-nova | 04:47 | |
*** klkumar has quit IRC | 04:50 | |
*** heyongli has quit IRC | 04:52 | |
*** klkumar has joined #openstack-nova | 04:52 | |
*** heyongli has joined #openstack-nova | 04:53 | |
*** mdrabe has quit IRC | 04:56 | |
*** boris-42 has quit IRC | 04:58 | |
*** 17WAAY74W has quit IRC | 05:01 | |
*** haomaiwa_ has joined #openstack-nova | 05:01 | |
*** pixelb has quit IRC | 05:02 | |
*** heyongli has quit IRC | 05:02 | |
*** markvoelker has joined #openstack-nova | 05:03 | |
*** heyongli has joined #openstack-nova | 05:03 | |
*** ndipanov has quit IRC | 05:04 | |
*** markvoelker has quit IRC | 05:07 | |
*** spandhe has joined #openstack-nova | 05:08 | |
*** heyongli has quit IRC | 05:12 | |
*** heyongli has joined #openstack-nova | 05:13 | |
*** jdurgin has quit IRC | 05:18 | |
*** heyongli has quit IRC | 05:23 | |
openstackgerrit | Lianhao Lu proposed openstack/nova-specs: Add new API to list compute node metric names https://review.openstack.org/180049 | 05:24 |
*** heyongli has joined #openstack-nova | 05:24 | |
*** salv-orlando has joined #openstack-nova | 05:31 | |
*** heyongli has quit IRC | 05:33 | |
*** heyongli has joined #openstack-nova | 05:34 | |
*** vilobhmm11 has joined #openstack-nova | 05:36 | |
*** kylek3h has joined #openstack-nova | 05:36 | |
*** hparekh has quit IRC | 05:38 | |
*** baoli has quit IRC | 05:38 | |
*** baoli has joined #openstack-nova | 05:39 | |
*** hparekh has joined #openstack-nova | 05:39 | |
*** EinstCrazy has joined #openstack-nova | 05:40 | |
*** sileht has joined #openstack-nova | 05:40 | |
*** heyongli has quit IRC | 05:43 | |
openstackgerrit | sahid proposed openstack/nova: libvirt: add cpu schedular priority config https://review.openstack.org/197567 | 05:44 |
openstackgerrit | sahid proposed openstack/nova: libvirt: rework membacking config to support future features https://review.openstack.org/197566 | 05:44 |
*** kylek3h has quit IRC | 05:44 | |
openstackgerrit | sahid proposed openstack/nova: virt: add constraint to handle realtime policy https://review.openstack.org/197568 | 05:44 |
openstackgerrit | sahid proposed openstack/nova: libvirt: add realtime support https://review.openstack.org/197569 | 05:44 |
*** heyongli has joined #openstack-nova | 05:44 | |
*** signed8bit has quit IRC | 05:45 | |
*** baoli has quit IRC | 05:45 | |
*** spandhe has quit IRC | 05:46 | |
*** jamielennox is now known as jamielennox|away | 05:47 | |
*** irenab has quit IRC | 05:50 | |
*** EinstCra_ has joined #openstack-nova | 05:51 | |
*** heyongli has quit IRC | 05:53 | |
*** EinstCrazy has quit IRC | 05:54 | |
*** heyongli has joined #openstack-nova | 05:54 | |
*** salv-orlando has quit IRC | 05:55 | |
*** jwcroppe has joined #openstack-nova | 05:57 | |
*** amotoki has joined #openstack-nova | 05:57 | |
*** jamielennox|away is now known as jamielennox | 05:58 | |
*** chenzeng has joined #openstack-nova | 05:58 | |
openstackgerrit | Jianghua Wang proposed openstack/nova: XenAPI: Expose labels for ephemeral disks https://review.openstack.org/213094 | 06:00 |
*** haomaiwa_ has quit IRC | 06:01 | |
*** haomaiwang has joined #openstack-nova | 06:01 | |
*** veena has quit IRC | 06:01 | |
*** amotoki has quit IRC | 06:02 | |
*** gonzalo2kx has quit IRC | 06:03 | |
*** heyongli has quit IRC | 06:04 | |
*** heyongli has joined #openstack-nova | 06:04 | |
*** emagana has quit IRC | 06:06 | |
*** jerrygb has quit IRC | 06:14 | |
*** heyongli has quit IRC | 06:14 | |
*** heyongli has joined #openstack-nova | 06:15 | |
*** otter768 has joined #openstack-nova | 06:16 | |
*** cfarquhar has quit IRC | 06:19 | |
*** cfarquhar has joined #openstack-nova | 06:21 | |
*** cfarquhar has quit IRC | 06:21 | |
*** cfarquhar has joined #openstack-nova | 06:21 | |
*** otter768 has quit IRC | 06:21 | |
*** heyongli has quit IRC | 06:24 | |
*** heyongli has joined #openstack-nova | 06:25 | |
*** klkumar has quit IRC | 06:32 | |
*** irenab has joined #openstack-nova | 06:33 | |
*** heyongli has quit IRC | 06:34 | |
*** heyongli has joined #openstack-nova | 06:35 | |
*** kylek3h has joined #openstack-nova | 06:41 | |
*** cfarquhar has quit IRC | 06:43 | |
*** heyongli has quit IRC | 06:45 | |
*** heyongli has joined #openstack-nova | 06:45 | |
*** garyk has joined #openstack-nova | 06:47 | |
*** salv-orlando has joined #openstack-nova | 06:48 | |
*** kylek3h has quit IRC | 06:48 | |
*** openstackstatus has quit IRC | 06:49 | |
*** markvoelker has joined #openstack-nova | 06:50 | |
*** alex_klimov has joined #openstack-nova | 06:50 | |
*** openstackstatus has joined #openstack-nova | 06:50 | |
*** ChanServ sets mode: +v openstackstatus | 06:50 | |
*** cfarquhar has joined #openstack-nova | 06:51 | |
*** cfarquhar has quit IRC | 06:51 | |
*** cfarquhar has joined #openstack-nova | 06:51 | |
*** heyongli has quit IRC | 06:55 | |
*** markvoelker has quit IRC | 06:55 | |
*** heyongli has joined #openstack-nova | 06:56 | |
*** asettle has quit IRC | 06:57 | |
*** haomaiwang has quit IRC | 06:58 | |
*** cfriesen_ has quit IRC | 06:59 | |
*** josecastroleon has joined #openstack-nova | 07:00 | |
*** haomaiwang has joined #openstack-nova | 07:01 | |
*** amotoki has joined #openstack-nova | 07:03 | |
*** heyongli has quit IRC | 07:05 | |
*** heyongli has joined #openstack-nova | 07:06 | |
*** klkumar has joined #openstack-nova | 07:06 | |
*** sudipto has joined #openstack-nova | 07:08 | |
*** EinstCra_ has quit IRC | 07:13 | |
*** jerrygb has joined #openstack-nova | 07:15 | |
*** heyongli has quit IRC | 07:15 | |
*** heyongli has joined #openstack-nova | 07:16 | |
*** nkrinner has joined #openstack-nova | 07:17 | |
*** boris-42 has joined #openstack-nova | 07:18 | |
*** gongysh has quit IRC | 07:18 | |
*** gongysh has joined #openstack-nova | 07:19 | |
*** jerrygb has quit IRC | 07:19 | |
*** markus_z has joined #openstack-nova | 07:21 | |
*** chenzeng has quit IRC | 07:21 | |
*** heyongli has quit IRC | 07:26 | |
*** heyongli has joined #openstack-nova | 07:26 | |
*** jamielennox is now known as jamielennox|away | 07:29 | |
*** chenzeng has joined #openstack-nova | 07:33 | |
*** ihrachys has joined #openstack-nova | 07:34 | |
*** heyongli has quit IRC | 07:36 | |
*** heyongli has joined #openstack-nova | 07:37 | |
openstackgerrit | Hans Lindgren proposed openstack/nova: Avoid costly lazy-loads in compute manager during instance builds https://review.openstack.org/241000 | 07:38 |
*** alexschm has joined #openstack-nova | 07:39 | |
*** rk4n has joined #openstack-nova | 07:40 | |
openstackgerrit | Hans Lindgren proposed openstack/nova: Use TimeFixture from oslo_utils to override time in tests https://review.openstack.org/237616 | 07:42 |
*** deepakcs has quit IRC | 07:45 | |
*** kylek3h has joined #openstack-nova | 07:46 | |
openstackgerrit | Hans Lindgren proposed openstack/nova: Remove and deprecate conductor provider_fw_rule_get_all() https://review.openstack.org/216241 | 07:46 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Remove unused provider firewall rules functionality in nova https://review.openstack.org/184027 | 07:46 |
openstackgerrit | Hans Lindgren proposed openstack/nova: Remove provider_fw_rules tables and associated db api methods https://review.openstack.org/216242 | 07:46 |
*** salv-orlando has quit IRC | 07:46 | |
*** heyongli has quit IRC | 07:46 | |
*** heyongli has joined #openstack-nova | 07:47 | |
*** lsmola has joined #openstack-nova | 07:48 | |
*** sudipto has quit IRC | 07:50 | |
*** zigo has quit IRC | 07:53 | |
*** kylek3h has quit IRC | 07:54 | |
*** zigo has joined #openstack-nova | 07:55 | |
*** danpb has joined #openstack-nova | 07:55 | |
*** rdopiera has joined #openstack-nova | 07:56 | |
*** heyongli has quit IRC | 07:56 | |
openstackgerrit | huan proposed openstack/nova: Resolve Nova/Neutron race condition https://review.openstack.org/241127 | 07:56 |
*** gcb has joined #openstack-nova | 07:57 | |
*** heyongli has joined #openstack-nova | 07:57 | |
*** baoli has joined #openstack-nova | 07:57 | |
*** josecastroleon has quit IRC | 07:58 | |
*** rdopiera has quit IRC | 07:58 | |
tangchen | hi, I have a question. If I want to add a new state_machine field into class Migration, and initialize it when Migration object is initialized, how should I do it ? | 07:58 |
*** rdopiera has joined #openstack-nova | 07:58 | |
tangchen | I tried to add a __init__() to class Migration. | 07:58 |
tangchen | But it seems that I cannot initialize the 'fields' in it. | 07:58 |
*** haomaiwang has quit IRC | 08:01 | |
*** haomaiwang has joined #openstack-nova | 08:01 | |
*** baoli has quit IRC | 08:02 | |
*** lsmola has quit IRC | 08:03 | |
*** heyongli has quit IRC | 08:07 | |
*** heyongli has joined #openstack-nova | 08:07 | |
*** jlanoux has joined #openstack-nova | 08:08 | |
*** rk4n has quit IRC | 08:09 | |
*** aix has quit IRC | 08:10 | |
*** davideagnello has quit IRC | 08:10 | |
*** vilobhmm11 has quit IRC | 08:12 | |
openstackgerrit | Balazs Gibizer proposed openstack/nova: Deprecate nova-manage service subcommand https://review.openstack.org/240858 | 08:15 |
*** heyongli has quit IRC | 08:17 | |
*** heyongli has joined #openstack-nova | 08:18 | |
*** lsmola has joined #openstack-nova | 08:19 | |
*** achanda has quit IRC | 08:25 | |
*** haomaiwang has quit IRC | 08:25 | |
*** Sree has quit IRC | 08:27 | |
*** heyongli has quit IRC | 08:27 | |
*** matrohon has joined #openstack-nova | 08:27 | |
*** Sree has joined #openstack-nova | 08:28 | |
*** haomaiwang has joined #openstack-nova | 08:28 | |
*** heyongli has joined #openstack-nova | 08:28 | |
*** xek has joined #openstack-nova | 08:28 | |
*** Sree_ has joined #openstack-nova | 08:29 | |
*** Sree_ has quit IRC | 08:29 | |
openstackgerrit | zhu.rong proposed openstack/nova: Add subunit.log to gitignore https://review.openstack.org/241131 | 08:29 |
*** Sree_ has joined #openstack-nova | 08:30 | |
*** jichen has joined #openstack-nova | 08:30 | |
*** markmc has quit IRC | 08:30 | |
*** Sree_ is now known as Guest88564 | 08:30 | |
*** salv-orlando has joined #openstack-nova | 08:32 | |
*** ihrachys has quit IRC | 08:32 | |
*** Sree has quit IRC | 08:32 | |
*** ihrachys has joined #openstack-nova | 08:33 | |
*** eglynn__ has quit IRC | 08:34 | |
*** Sree has joined #openstack-nova | 08:34 | |
*** chenzeng has quit IRC | 08:35 | |
openstackgerrit | zhu.rong proposed openstack/nova: Add subunit.log to gitignore https://review.openstack.org/241131 | 08:35 |
*** heyongli has quit IRC | 08:37 | |
*** ZZelle has quit IRC | 08:37 | |
*** Guest88564 has quit IRC | 08:38 | |
*** ihrachys has quit IRC | 08:38 | |
*** ZZelle has joined #openstack-nova | 08:38 | |
*** heyongli has joined #openstack-nova | 08:38 | |
*** subscope has joined #openstack-nova | 08:39 | |
*** josecastroleon has joined #openstack-nova | 08:39 | |
*** ccard has joined #openstack-nova | 08:40 | |
openstackgerrit | Shraddha Pandhe proposed openstack/nova: Remove unnecessary destroy call from Ironic virt driver https://review.openstack.org/240357 | 08:41 |
*** venkat_p has joined #openstack-nova | 08:44 | |
*** venkat_p has quit IRC | 08:45 | |
*** Sree has quit IRC | 08:46 | |
*** Sree has joined #openstack-nova | 08:47 | |
*** heyongli has quit IRC | 08:48 | |
*** heyongli has joined #openstack-nova | 08:48 | |
*** aix has joined #openstack-nova | 08:49 | |
*** kylek3h has joined #openstack-nova | 08:51 | |
*** markvoelker has joined #openstack-nova | 08:52 | |
*** markvoelker has quit IRC | 08:56 | |
*** apuimedo has joined #openstack-nova | 08:57 | |
*** heyongli has quit IRC | 08:58 | |
*** kylek3h has quit IRC | 08:58 | |
*** sudipto has joined #openstack-nova | 08:58 | |
*** heyongli has joined #openstack-nova | 08:59 | |
*** jistr has joined #openstack-nova | 09:00 | |
*** haomaiwang has quit IRC | 09:01 | |
*** haomaiwang has joined #openstack-nova | 09:01 | |
*** subscope has quit IRC | 09:01 | |
*** subscope has joined #openstack-nova | 09:04 | |
*** Jeffrey4l has quit IRC | 09:04 | |
*** ihrachys has joined #openstack-nova | 09:05 | |
*** heyongli has quit IRC | 09:08 | |
bauzas | good (jetlagged) morning Nova | 09:09 |
*** heyongli has joined #openstack-nova | 09:09 | |
*** sudipto has quit IRC | 09:10 | |
*** pixelb has joined #openstack-nova | 09:10 | |
*** yassine has joined #openstack-nova | 09:12 | |
*** apoorvad has joined #openstack-nova | 09:14 | |
*** romainh has joined #openstack-nova | 09:15 | |
*** e0ne has joined #openstack-nova | 09:15 | |
*** jerrygb has joined #openstack-nova | 09:16 | |
*** Jeffrey4l has joined #openstack-nova | 09:17 | |
*** rk4n has joined #openstack-nova | 09:18 | |
*** heyongli has quit IRC | 09:18 | |
*** eglynn__ has joined #openstack-nova | 09:19 | |
*** eglynn__ has quit IRC | 09:19 | |
*** heyongli has joined #openstack-nova | 09:19 | |
*** eglynn__ has joined #openstack-nova | 09:20 | |
*** lennyb1 has joined #openstack-nova | 09:21 | |
*** jerrygb has quit IRC | 09:21 | |
*** lennyb1 has quit IRC | 09:21 | |
*** MarcF has joined #openstack-nova | 09:22 | |
*** sudipto has joined #openstack-nova | 09:23 | |
*** achanda has joined #openstack-nova | 09:25 | |
*** lennyb has quit IRC | 09:26 | |
*** heyongli has quit IRC | 09:29 | |
*** jwcroppe_ has joined #openstack-nova | 09:29 | |
*** heyongli has joined #openstack-nova | 09:29 | |
*** jwcroppe_ has quit IRC | 09:31 | |
*** jwcroppe has quit IRC | 09:31 | |
*** achanda has quit IRC | 09:31 | |
*** jwcroppe has joined #openstack-nova | 09:33 | |
openstackgerrit | ShaoHe Feng proposed openstack/nova: remove the redundant policy check for SecurityGroupsOutputController https://review.openstack.org/159369 | 09:34 |
* alex_xu can't access gerrit, the server return 503... | 09:35 | |
* alex_xu can access now... | 09:35 | |
*** jwcroppe has quit IRC | 09:38 | |
openstackgerrit | Timofey Durakov proposed openstack/nova-specs: nova-api hypervisor.cpu_info change from string to json object https://review.openstack.org/183057 | 09:39 |
*** heyongli has quit IRC | 09:39 | |
*** heyongli has joined #openstack-nova | 09:40 | |
*** subscope has quit IRC | 09:40 | |
*** salv-orlando has quit IRC | 09:41 | |
johnthetubaguy | tangchen: sounds like you might not have called the super classes __init__() method maybe? | 09:43 |
johnthetubaguy | tangchen: although I think you probably want to look at getting the correct kind of field, and it should just work, like an object field pointing at some migration class? | 09:43 |
*** derekh has joined #openstack-nova | 09:45 | |
*** aix has quit IRC | 09:45 | |
*** heyongli has quit IRC | 09:49 | |
*** heyongli has joined #openstack-nova | 09:50 | |
*** jwcroppe has joined #openstack-nova | 09:52 | |
*** markvoelker has joined #openstack-nova | 09:53 | |
*** kylek3h has joined #openstack-nova | 09:55 | |
*** aix has joined #openstack-nova | 09:57 | |
johnthetubaguy | markus_z: I have added some of the special review days on here, what do you think about the bug ones? https://wiki.openstack.org/wiki/Nova/Mitaka_Release_Schedule | 09:58 |
*** markvoelker has quit IRC | 09:58 | |
* markus_z looking | 09:58 | |
*** subscope has joined #openstack-nova | 09:59 | |
*** heyongli has quit IRC | 09:59 | |
*** heyongli has joined #openstack-nova | 10:00 | |
*** haomaiwang has quit IRC | 10:01 | |
markus_z | johnthetubaguy: To be honest, I think the participation was pretty low last time. | 10:01 |
*** aix has quit IRC | 10:01 | |
*** haomaiwa_ has joined #openstack-nova | 10:01 | |
markus_z | johnthetubaguy: I would try the "bug shaming" in the meetings or on the ML this time. | 10:01 |
johnthetubaguy | markus_z: yeah, I tried to pick a better day of the week, in the hope that makes a difference | 10:01 |
johnthetubaguy | markus_z: true, if that works, we could have a bug fixing day, or something | 10:02 |
markus_z | johnthetubaguy: I doubt that the date would make a difference. | 10:02 |
kashyap | markus_z: Yeah, people often forget I guess | 10:02 |
bauzas | markus_z: johnthetubaguy: honestly, the regression check we had during RCs was really needed | 10:02 |
johnthetubaguy | regression check? | 10:02 |
bauzas | markus_z: johnthetubaguy: I'd love to see it again | 10:02 |
bauzas | sorry, I mean checking which bugs were new and were regressions | 10:02 |
*** zhenguo has quit IRC | 10:03 | |
markus_z | bauzas: Hm, I must have missed that :-| | 10:03 |
johnthetubaguy | oh, right, yeah, thats usually a good thing to check | 10:03 |
bauzas | during the RC phase, we found 3 critical ones and one high | 10:03 |
*** kylek3h has quit IRC | 10:04 | |
bauzas | markus_z: what do you really need for bug triaging ? | 10:04 |
markus_z | bauzas: At best we discover such things as soon as the new ones get triaged. | 10:04 |
Guest60083 | markus_z, hi, have you checked this one? https://review.openstack.org/#/c/183057/ | 10:04 |
kashyap | Maybe a "bug fix week". | 10:04 |
*** Guest60083 is now known as tdurakov | 10:04 | |
markus_z | Guest60083: It's on my todo list, didn't yet have the chance | 10:05 |
bauzas | markus_z: the main problem I had is that some bugs are created (hence NEW) and then a proposal is made (which made it IN PROGRESS) | 10:05 |
bauzas | so, I missed some bugfixes which were really important for not having regressions | 10:05 |
markus_z | bauzas: ok, I see your point. | 10:05 |
tdurakov | markus_z, thanks, i've updated it, so it's almost ready to be merged | 10:05 |
bauzas | fortunately, 2 of them were done by an IBM guy from mriedem_away's team | 10:06 |
johnthetubaguy | kashyap: I was always thinking about if folks will not do one day, they will not do a week, but actually, that might help as folks might have free time that week | 10:06 |
* kashyap brb, on phone | 10:06 | |
*** jamielennox|away is now known as jamielennox | 10:06 | |
*** aix has joined #openstack-nova | 10:06 | |
markus_z | johnthetubaguy: Having a dedicated point in time to do triaging/fixing bugs could also lead to a delay. | 10:07 |
markus_z | johnthetubaguy: like, "yeah, not right now, let's do that in the bug fix week" | 10:07 |
markus_z | bauzas: How was the "regression check" done? A query of non-prioritized bugs? | 10:08 |
johnthetubaguy | markus_z: true, thats the downside, its stuff we should be doing all the time, but a big push to deal with the backlog, but yeah, it can have that effect | 10:08 |
*** ihrachys_ has joined #openstack-nova | 10:08 | |
bauzas | markus_z: just basically verifying every 4 days that nothing was coming | 10:08 |
bauzas | like important | 10:09 |
bauzas | arrrh | 10:09 |
bauzas | 4 *hours* | 10:09 |
markus_z | johnthetubaguy: I'm not entirely against the idea, but I think the participation won't grow. | 10:09 |
bauzas | my brain is still unmounted | 10:09 |
*** jhesketh has quit IRC | 10:09 | |
*** ihrachys has quit IRC | 10:10 | |
*** heyongli has quit IRC | 10:10 | |
bauzas | we certainly need to have that post feature freeze IMHO | 10:10 |
*** huanxie has joined #openstack-nova | 10:10 | |
*** sudipto has quit IRC | 10:10 | |
*** jhesketh has joined #openstack-nova | 10:10 | |
*** heyongli has joined #openstack-nova | 10:10 | |
markus_z | johnthetubaguy: The announcement on the ML last time had next to no response. | 10:11 |
*** ccard has quit IRC | 10:12 | |
huanxie | hi johnthetubaguy, I'm huan from citrix. One quick question, for xen driver nova/neutron race condition problem, should we treat it as a bugfix or a new blueprint? | 10:12 |
*** zhangjn has quit IRC | 10:12 | |
*** zhangjn has joined #openstack-nova | 10:13 | |
bauzas | markus_z: well, that's not because people don't answer to ML that they don't do bugfixing :) | 10:13 |
markus_z | johnthetubaguy: I'll post a request on the ML to update the subteam contacts for bugs https://wiki.openstack.org/wiki/Nova/BugTriage | 10:13 |
markus_z | bauzas: True, but the few samples I took last time showed that johnthetubaguy you and kashyap were participating. :) | 10:14 |
markus_z | apologies to everyone I missed :) | 10:14 |
*** zhangjn has quit IRC | 10:17 | |
*** heyongli has quit IRC | 10:20 | |
*** subscope has quit IRC | 10:20 | |
*** subscope has joined #openstack-nova | 10:20 | |
*** heyongli has joined #openstack-nova | 10:21 | |
johnthetubaguy | huanxie: hi, good question, honestly, it could be either, I would start it as a bug fix, we can add a blueprint if we need to later | 10:21 |
bauzas | PaulMurray: you there ? | 10:23 |
bauzas | PaulMurray: I just checked the flights to BRS and unfortunately there are a few of them in weekdays | 10:23 |
bauzas | PaulMurray: that said, I'm lucky enough to get a direct flight from GVA but I feel some information should be fulfilled soon for people wanting to land on LHR | 10:24 |
bauzas | with the transportation options | 10:24 |
bauzas | PaulMurray: I was also looking at the hotel prices and the venue distance | 10:25 |
bauzas | PaulMurray: I dunno if HP has some ways to get for room blocks :) | 10:26 |
PaulMurray | bauzas, hi | 10:26 |
PaulMurray | bauzas, sorting out room booking in next couple of days | 10:26 |
huanxie | johnthetubaguy: thanks a lot, will raise a bug for this fix | 10:26 |
bauzas | oh coolness ! | 10:26 |
PaulMurray | bauzas, I'll put something together about ways to get here too | 10:26 |
bauzas | PaulMurray: yeah I think the latter (transportation) is probably the more important as of now | 10:27 |
bauzas | PaulMurray: because of budget estimates :) | 10:27 |
PaulMurray | I fly BRS-GVA often - GVA is a pain for easyjet, but shouldn't be a peak time for them | 10:27 |
PaulMurray | getting a bus from LHR to bristol costs about £40 return fare | 10:28 |
PaulMurray | they are very good | 10:28 |
bauzas | yup, it's easyjet AFAIK | 10:28 |
johnthetubaguy | right bus or train from LHR is a good option | 10:28 |
*** achanda has joined #openstack-nova | 10:28 | |
bauzas | given that the flight is around 100EUR for people in EU like me, taking train for 50EUR is just 1.5 the price :p | 10:29 |
*** jianghua has joined #openstack-nova | 10:29 | |
bauzas | and I don't give too much credit to LHR :) | 10:29 |
*** heyongli has quit IRC | 10:30 | |
johnthetubaguy | LHR is worth avoiding for short trips, but from the US, you are more likely to be able to go direct | 10:30 |
bauzas | ++ | 10:31 |
*** heyongli has joined #openstack-nova | 10:31 | |
*** jianghua has quit IRC | 10:32 | |
*** achanda has quit IRC | 10:34 | |
*** josecastroleon has quit IRC | 10:37 | |
bauzas | PaulMurray: 2 hours for the train from BRS to LHR ? | 10:38 |
*** zhangjn has joined #openstack-nova | 10:38 | |
*** zhangjn has quit IRC | 10:38 | |
*** alex_xu has quit IRC | 10:40 | |
tangchen | johnthetubaguy: I think if I write a __init__() in class Migration, it needs to take all fields as its parameters, otherwise the callers won't be able to create a Migration object properly. But if I take all the parameters, I cannot assign them to the fields in __init__() because it will give this error:AttributeError: 'Migration' object has no attribute '_changed_fields' | 10:40 |
*** heyongli has quit IRC | 10:40 | |
*** zhangjn has joined #openstack-nova | 10:40 | |
johnthetubaguy | tangchen: can't you just do the (*args, **kwargs) trick? but yeah, the constructor isn't usually the correct place to change things, its probably the from_primitive stuff, or from the DB stuff that is more useful | 10:41 |
*** heyongli has joined #openstack-nova | 10:41 | |
tangchen | johnthetubaguy: And also, if I want to initialize the state machine depending on the migration_type, I cannot refer to migration_type in __init__(). | 10:41 |
*** ihrachys_ has quit IRC | 10:42 | |
rajesht | johnthetubaguy: could you please review https://review.openstack.org/#/c/215483/ | 10:43 |
danpb | bauzas: yeah, that's approx right duration | 10:43 |
rajesht | johnthetubaguy: thanks :) | 10:43 |
tangchen | johnthetubaguy: BTW, migration_type and hidden are set to non-nullable. But actually we can leave them as None when create Migration object. | 10:43 |
*** salv-orlando has joined #openstack-nova | 10:43 | |
tangchen | johnthetubaguy: Is there any way to fix it ? | 10:43 |
bauzas | danpb: ack, thanks - was considering 3 or 4 nights | 10:44 |
danpb | bauzas: though not sure which station will be best - depends on what hotel PaulMurray suggests we use | 10:44 |
*** abhishekk has joined #openstack-nova | 10:44 | |
abhishekk | alaski: hi you around? | 10:44 |
danpb | as it seems HP offices are not in the center of the city, rather on the outskirts | 10:44 |
bauzas | yup I saw that | 10:44 |
*** alex_xu has joined #openstack-nova | 10:44 | |
* danpb wonders if it is HP or HPE offices :-) | 10:44 | |
*** ihrachys has joined #openstack-nova | 10:45 | |
bauzas | lol | 10:45 |
bauzas | HPE :) | 10:45 |
bauzas | see PaulMurray's email :p | 10:45 |
andrearosa | HP office here in bristol are not in the center but just 10 mins of train from the Bristol Temple meads station which is located in city center | 10:45 |
PaulMurray | bauzas, 2hrs yes - you need two trains - LHR to london paddington then paddington to bristol | 10:45 |
johnthetubaguy | tangchen: so not sure whats best there, feels like the caller should add in an appropriate statemachine to express the type | 10:45 |
bauzas | tangchen: IIUC, you want to add a new field and populate it whenever it's needed ? | 10:45 |
PaulMurray | bauzas, bus is also 2hrs and goes direct to bristol city centre | 10:45 |
bauzas | PaulMurray: okay, I feel I'll then stick with EasyJet and GVA | 10:46 |
bauzas | that's far more flexible | 10:46 |
bauzas | I mean GVA/BRS | 10:46 |
johnthetubaguy | tangchen: yeah, what bauzas said | 10:46 |
*** thorst has joined #openstack-nova | 10:46 | |
bauzas | there is something in the object helper factory | 10:47 |
bauzas | obj_set_defaults() | 10:47 |
bauzas | that you can use for setting a field to a default | 10:47 |
bauzas | tangchen: | 10:47 |
bauzas | ^ | 10:47 |
* bauzas is still booting | 10:47 | |
tangchen | bauzas, johnthetubaguy: I want to add a new field in to class Migration. It is an object of a class. But which class depends on the migration_type field. | 10:47 |
*** rotbeard has joined #openstack-nova | 10:48 | |
bauzas | tangchen: like this https://github.com/openstack/nova/blob/master/nova/objects/request_spec.py#L345-L353 | 10:48 |
PaulMurray | johnthetubaguy, bauzas danpb as a quick spot poll : there are hotels more or less walking distance from our site on edge of bristol | 10:48 |
PaulMurray | or hotels in city centre | 10:48 |
bauzas | PaulMurray: I guess the most crucial point is that : do they all provide good beers ? | 10:49 |
*** flyingtt has joined #openstack-nova | 10:49 | |
PaulMurray | city centre is a bit of a treak to our site but is better for evening | 10:49 |
bauzas | we need to face the UK winter y'know | 10:49 |
danpb | PaulMurray: what's transport like between city center & your site | 10:49 |
*** Sree has quit IRC | 10:49 | |
danpb | eg its desirable to avoid having to pay for taxis each morning & evening | 10:49 |
PaulMurray | best in a car or taxi | 10:49 |
andrearosa | bauzas: there is no difference between seasons here in uk :( | 10:49 |
bauzas | andrearosa: no worries, it's just right in the middle of the ski season :p | 10:50 |
*** salv-orlando has quit IRC | 10:50 | |
andrearosa | correct | 10:50 |
bauzas | danpb: checked car rentals, not really expensive AFAICT - like 100EUR for 4 days | 10:50 |
*** heyongli has quit IRC | 10:51 | |
bauzas | danpb: I'd even say 70EUR for 3 days | 10:51 |
tangchen | bauzas, johnthetubaguy: Let me see for a while. Thanks. :) | 10:51 |
bauzas | tangchen: just upload something WIP in Gerrit and CC me, I'll help you okay? | 10:51 |
*** heyongli has joined #openstack-nova | 10:51 | |
tangchen | bauzas: OK, thank you very much. :) | 10:52 |
bauzas | tangchen: having a state in an object is fine, I just care about how you handle the state transitions | 10:52 |
bauzas | tangchen: btw I guess it would be an enum ? | 10:52 |
*** subscope has quit IRC | 10:53 | |
*** josecastroleon has joined #openstack-nova | 10:53 | |
openstackgerrit | garyk proposed openstack/nova-specs: VMware: expand opaque network support https://review.openstack.org/230425 | 10:54 |
tangchen | bauzas: I'm using automaton.machine.FiniteMachine. And it is not a Enum now. Please refer to these three BP. | 10:54 |
danpb | PaulMurray: if the hotels are reasonable, i'd probably tend towards staying withint walking distnace of office | 10:54 |
tangchen | [1] https://blueprints.launchpad.net/nova/+spec/migration-state-machine | 10:54 |
tangchen | [2] https://blueprints.launchpad.net/nova/+spec/migration-state-field-machine | 10:54 |
danpb | PaulMurray: to avoid having todo a 20-30 min drive/taxi each morning / evening in rush hour | 10:55 |
tangchen | [3] https://blueprints.launchpad.net/nova/+spec/migration-type-refactor | 10:55 |
bauzas | tangchen: is that somehow related to ndipanov's work ? | 10:55 |
tangchen | bauzas: Thanks. :) | 10:55 |
tangchen | yes | 10:55 |
*** gongysh has quit IRC | 10:55 | |
tangchen | bauzas: I'm taking it from him. | 10:55 |
tangchen | bauzas: And we have discussed it several times in IRC and emails. The BP will show the direction it is going. | 10:56 |
*** yassine has quit IRC | 10:56 | |
tangchen | bauzas: But I think I have some trouble in doing the coding. | 10:56 |
*** haomaiwa_ has quit IRC | 10:57 | |
*** gongysh has joined #openstack-nova | 10:57 | |
*** MarcF has quit IRC | 10:57 | |
*** ihrachys_ has joined #openstack-nova | 10:58 | |
*** daemontool has quit IRC | 10:58 | |
*** daemontool has joined #openstack-nova | 10:59 | |
*** salv-orlando has joined #openstack-nova | 10:59 | |
*** ihrachys has quit IRC | 10:59 | |
*** ildikov has quit IRC | 11:00 | |
*** kylek3h has joined #openstack-nova | 11:01 | |
*** heyongli has quit IRC | 11:01 | |
*** jwcroppe has quit IRC | 11:01 | |
*** heyongli has joined #openstack-nova | 11:02 | |
*** ildikov has joined #openstack-nova | 11:02 | |
*** salv-orlando has quit IRC | 11:02 | |
*** aysyd has joined #openstack-nova | 11:05 | |
*** markvoelker has joined #openstack-nova | 11:09 | |
*** dims has joined #openstack-nova | 11:09 | |
*** kylek3h has quit IRC | 11:09 | |
*** romainh has quit IRC | 11:10 | |
*** heyongli has quit IRC | 11:11 | |
*** heyongli has joined #openstack-nova | 11:12 | |
*** markvoelker has quit IRC | 11:13 | |
*** apoorvad has quit IRC | 11:15 | |
*** ihrachys_ has quit IRC | 11:16 | |
tangchen | bauzas: I read the URL you gave me. But I don't it is what I want. The from/to_dict() is used to limit the attributes to be some suitable values, right ? | 11:20 |
openstackgerrit | Anna Babich proposed openstack/python-novaclient: Functional tests for os-extended-server-attributes https://review.openstack.org/232605 | 11:21 |
*** gszasz has joined #openstack-nova | 11:21 | |
*** heyongli has quit IRC | 11:21 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/nova: Filter out inactive compute before computing avaible resources https://review.openstack.org/180155 | 11:22 |
*** heyongli has joined #openstack-nova | 11:22 | |
tangchen | bauzas: What I want to do is initialize one field depending on the values of some other fields. | 11:23 |
tangchen | bauzas: I failed to do it in __init__(). | 11:23 |
*** alex_xu has quit IRC | 11:24 | |
*** alex_xu has joined #openstack-nova | 11:25 | |
johnthetubaguy | tangchen: not sure that sounds like a good idea, why can the person creating the migration object setup the statemachine by setting a field on the object? maybe do the simple thing first, then see how best improve that? | 11:26 |
tangchen | johnthetubaguy: My idea is make state machine a field of Migration, and depending on the migration_type field, we can initialize the state machine to different class. | 11:28 |
tangchen | johnthetubaguy: And yes, I'm spliting the current state machine into 3 different ones for 3 different migration types. | 11:29 |
*** stackdump has joined #openstack-nova | 11:29 | |
*** rfolco has joined #openstack-nova | 11:30 | |
tangchen | johnthetubaguy: The 3 new ones will be simpler and easier to understand. And they are the same as the old one before if we take them together.. | 11:30 |
johnthetubaguy | tangchen: I would just try being explicit first, and see how bad it looks, it might be neater than trying to link those two fields | 11:30 |
tangchen | johnthetubaguy: I think I can post a first version patches for you guys to see. | 11:30 |
johnthetubaguy | tangchen: I think thats a good way forward | 11:30 |
tangchen | johnthetubaguy: Sure. :) | 11:31 |
*** jlanoux has quit IRC | 11:31 | |
*** heyongli has quit IRC | 11:32 | |
*** heyongli has joined #openstack-nova | 11:32 | |
*** stackdump has quit IRC | 11:33 | |
*** jamielennox is now known as jamielennox|away | 11:35 | |
johnthetubaguy | danpb: I am adding you as the main contact for the os-vif-lib, if thats OK? adding jaypipes into the list too, but he already has his name against the scheduler | 11:36 |
*** josecastroleon has quit IRC | 11:36 | |
*** deepakcs has joined #openstack-nova | 11:36 | |
*** ihrachys has joined #openstack-nova | 11:37 | |
danpb | johnthetubaguy: sure, that's fine | 11:39 |
johnthetubaguy | danpb: thanks | 11:40 |
danpb | i'll aim to create an etherpad somewhere to coordinate / track progress once we get going | 11:40 |
*** jlanoux has joined #openstack-nova | 11:40 | |
*** heyongli has quit IRC | 11:42 | |
*** heyongli has joined #openstack-nova | 11:43 | |
*** mgoddard_ has joined #openstack-nova | 11:44 | |
*** mgoddard has quit IRC | 11:44 | |
*** jlanoux_ has joined #openstack-nova | 11:44 | |
kashyap | Noticed people were already adding comments to this - https://etherpad.openstack.org/p/mitaka-nova-os-vif-lib | 11:45 |
*** dave-mccowan has joined #openstack-nova | 11:45 | |
*** jlanoux has quit IRC | 11:47 | |
johnthetubaguy | danpb: would be good if we can just use the regular priority etherpad if thats possible | 11:50 |
*** jang1 has joined #openstack-nova | 11:51 | |
danpb | johnthetubaguy: i thought that was just for tracking pending reviews ? | 11:51 |
*** smatzek has joined #openstack-nova | 11:51 | |
danpb | if its ok to have more general discussion points in it, i cna use it | 11:51 |
*** heyongli has quit IRC | 11:52 | |
*** jang1 is now known as jang | 11:52 | |
*** heyongli has joined #openstack-nova | 11:53 | |
*** markmc has joined #openstack-nova | 11:54 | |
* alex_xu reminders nova api meeting in 5 mins | 11:55 | |
*** daemontool has quit IRC | 12:01 | |
*** heyongli has quit IRC | 12:02 | |
*** jerrygb has joined #openstack-nova | 12:03 | |
*** jerrygb has quit IRC | 12:03 | |
openstackgerrit | John Garbutt proposed openstack/nova-specs: Add Mitaka Priorities https://review.openstack.org/240959 | 12:03 |
*** heyongli has joined #openstack-nova | 12:04 | |
openstackgerrit | John Garbutt proposed openstack/nova-specs: Add Mitaka Priorities https://review.openstack.org/240959 | 12:05 |
*** jlanoux_ has quit IRC | 12:05 | |
*** salv-orlando has joined #openstack-nova | 12:06 | |
*** kylek3h has joined #openstack-nova | 12:06 | |
*** aix has quit IRC | 12:07 | |
*** browne has quit IRC | 12:09 | |
*** klkumar has quit IRC | 12:09 | |
*** markvoelker has joined #openstack-nova | 12:09 | |
*** josecastroleon has joined #openstack-nova | 12:10 | |
*** subscope has joined #openstack-nova | 12:10 | |
*** inteq has quit IRC | 12:11 | |
*** aix has joined #openstack-nova | 12:12 | |
*** heyongli has quit IRC | 12:13 | |
*** yassine has joined #openstack-nova | 12:13 | |
*** heyongli has joined #openstack-nova | 12:14 | |
*** kylek3h has quit IRC | 12:14 | |
*** thorst has quit IRC | 12:14 | |
*** markvoelker has quit IRC | 12:14 | |
*** salv-orl_ has joined #openstack-nova | 12:15 | |
*** salv-orlando has quit IRC | 12:15 | |
*** Jeffrey4l has quit IRC | 12:16 | |
*** Jeffrey4l has joined #openstack-nova | 12:18 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: Use EngineFacade from oslo_db.enginefacade https://review.openstack.org/221310 | 12:18 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: enginefacade: 'service' https://review.openstack.org/241178 | 12:18 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: enginefacade: 'instance_info' and 'instance_extra' https://review.openstack.org/225065 | 12:21 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: enginefacade: 'cell_mapping' https://review.openstack.org/226788 | 12:21 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: enginefacade: 'key_pair' and 'cell' https://review.openstack.org/239915 | 12:21 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: enginefacade: 'instance_mapping' https://review.openstack.org/228979 | 12:21 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: enginefacade: 'network' https://review.openstack.org/240253 | 12:21 |
openstackgerrit | Alexander Schmidt proposed openstack/nova-specs: libvirt: iothreads for disk devices https://review.openstack.org/230968 | 12:21 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: enginefacade: 'certificate' and 'pci_device' https://review.openstack.org/240275 | 12:22 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: WIP: enginefacade: 'floating_ip' https://review.openstack.org/240513 | 12:22 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: WIP: enginefacade: 'fixed_ip' https://review.openstack.org/240811 | 12:22 |
openstackgerrit | Gábor Antal proposed openstack/nova: Replaced deprecated timeutils methods (isotime() and strtime()) https://review.openstack.org/241179 | 12:22 |
gibi | johnthetubaguy: hi! do you have a minute or two? (I dont want to steal your lunchtime) | 12:22 |
johnthetubaguy | gibi: no problems, ask away | 12:22 |
gibi | I'd like to create the notification subteam. I read up what it takes to do it and here are my plans | 12:22 |
gibi | 1) create a wiki named Meetings/NovaNotification | 12:22 |
gibi | 2) link it under Nova#Nova_subteams | 12:22 |
gibi | 3) define the mission and tasks | 12:22 |
gibi | 4) send out a mail on the mailing list as an advertisement | 12:22 |
gibi | 5) try to find a meeting slot that good for the interested participants | 12:22 |
gibi | Am I missing something? | 12:22 |
*** heyongli has quit IRC | 12:23 | |
*** klkumar has joined #openstack-nova | 12:24 | |
*** achanda has joined #openstack-nova | 12:24 | |
jroll | gibi: 6) a patch here http://git.openstack.org/cgit/openstack-infra/irc-meetings/ | 12:24 |
*** heyongli has joined #openstack-nova | 12:24 | |
jroll | :) | 12:24 |
*** subscope has quit IRC | 12:24 | |
gibi | jroll: to book a meeting slot, yes, thanks :) | 12:24 |
*** thorst has joined #openstack-nova | 12:25 | |
johnthetubaguy | gibi: so now you write that out, we should probably update the subteam doc here: https://wiki.openstack.org/wiki/Nova#Nova_subteams | 12:26 |
*** achanda has quit IRC | 12:26 | |
*** subscope has joined #openstack-nova | 12:26 | |
jroll | mariojv: ^ fyi you may be interested in this | 12:26 |
gibi | johnthetubaguy: I pretty much used the information from there to make my plan | 12:27 |
johnthetubaguy | jroll: yeah, I was going to try catch you, we are reworking how our notifications work | 12:27 |
johnthetubaguy | gibi: cool, just thinking about making it easier | 12:27 |
jroll | johnthetubaguy: yeah, and we're doing the thing | 12:27 |
jroll | johnthetubaguy: drastic changes other than versioned schema? | 12:27 |
johnthetubaguy | gibi: I was thinking about the entry on here as well: https://etherpad.openstack.org/p/mitaka-nova-priorities-tracking | 12:28 |
johnthetubaguy | jroll: nope, just the versioned stuff | 12:28 |
jroll | cool | 12:28 |
gibi | johnthetubaguy: ok, make sense, I will add a section | 12:28 |
jroll | johnthetubaguy: o.vo, I assume? | 12:28 |
johnthetubaguy | jroll: although being clear its not intended as an end user async API, its more structured logging | 12:28 |
johnthetubaguy | jroll: yeah | 12:28 |
gibi | jroll: yes, o.vo | 12:28 |
jroll | yep | 12:28 |
jroll | \o/ | 12:28 |
johnthetubaguy | jroll: gibi has a great spec on the details | 12:29 |
gibi | jroll: versioned notification api spec https://review.openstack.org/#/c/224755/ | 12:29 |
jroll | thanks | 12:29 |
johnthetubaguy | jroll: we could extract that to be an openstack spec if we wanted to make sure we agree, I suppose, but we shouldn't block us both making progress on getting that sorted | 12:29 |
*** salv-orl_ has quit IRC | 12:29 | |
johnthetubaguy | gibi: sorry, to answer your previous question, that looks good | 12:30 |
*** alex_klimov has quit IRC | 12:30 | |
gibi | johnthetubaguy: OK, I will do the typing then :) | 12:30 |
gibi | johnthetubaguy: thanks | 12:30 |
jroll | johnthetubaguy: we could... I assume the hard parts around your spec is compatibility and such, with a greenfield thing it shouldn't be difficult (final last words) | 12:31 |
*** kylek3h has joined #openstack-nova | 12:31 | |
*** kylek3h has quit IRC | 12:31 | |
gibi | jroll: compatibility is handled by emitting old notifications as well for some time | 12:31 |
*** kylek3h has joined #openstack-nova | 12:31 | |
*** zhangjn has quit IRC | 12:31 | |
*** salv-orlando has joined #openstack-nova | 12:31 | |
*** klkumar has quit IRC | 12:33 | |
*** jeblair has quit IRC | 12:33 | |
*** heyongli has quit IRC | 12:33 | |
*** EmilienM has quit IRC | 12:33 | |
*** zhangjn has joined #openstack-nova | 12:34 | |
*** heyongli has joined #openstack-nova | 12:34 | |
jroll | gibi: right | 12:34 |
*** jeblair has joined #openstack-nova | 12:34 | |
jroll | spec lgtm, I suspect we'll take much of that for ironic | 12:35 |
johnthetubaguy | cools | 12:36 |
*** EmilienM has joined #openstack-nova | 12:36 | |
*** asselin has quit IRC | 12:37 | |
*** deepakcs has quit IRC | 12:37 | |
*** jwcroppe has joined #openstack-nova | 12:38 | |
gibi | jroll: cool, if you have further questions you can find me here. :) | 12:38 |
jroll | gibi: cool, mariojv is leading that work so expect a ping from him :P | 12:38 |
gibi | jroll, mariojv: cool :) | 12:40 |
*** jwcroppe has quit IRC | 12:41 | |
*** thorst_ has joined #openstack-nova | 12:41 | |
*** jwcroppe has joined #openstack-nova | 12:42 | |
*** thorst has quit IRC | 12:43 | |
*** thorst_ is now known as thorst | 12:43 | |
*** heyongli has quit IRC | 12:43 | |
*** heyongli has joined #openstack-nova | 12:45 | |
*** mgoddard__ has joined #openstack-nova | 12:45 | |
johnthetubaguy | gibi: I updated the wiki page a little, incase that helps: https://wiki.openstack.org/wiki/Nova#Nova_subteams | 12:45 |
*** jwcroppe has quit IRC | 12:46 | |
*** mgoddard__ has quit IRC | 12:46 | |
*** mgoddard__ has joined #openstack-nova | 12:47 | |
openstackgerrit | John Garbutt proposed openstack/nova-specs: Add Mitaka Priorities https://review.openstack.org/240959 | 12:48 |
*** mgoddard_ has quit IRC | 12:48 | |
*** lixiaoy1 has joined #openstack-nova | 12:48 | |
*** lixiaoy1 has quit IRC | 12:49 | |
*** subscope has quit IRC | 12:50 | |
*** baoli has joined #openstack-nova | 12:50 | |
gibi | johnthetubaguy: it helps, thanks. | 12:50 |
*** baoli_ has joined #openstack-nova | 12:51 | |
johnthetubaguy | gibi: cool | 12:51 |
* johnthetubaguy runs away for lunch | 12:51 | |
gibi | johnthetubaguy: enjoy! | 12:51 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: enginefacade: 'compute_node' https://review.openstack.org/241189 | 12:52 |
*** heyongli has quit IRC | 12:54 | |
*** heyongli has joined #openstack-nova | 12:55 | |
*** baoli has quit IRC | 12:55 | |
*** Jeffrey4l has quit IRC | 12:55 | |
*** abhishekk has quit IRC | 12:55 | |
*** links has quit IRC | 12:56 | |
*** thorst has quit IRC | 12:57 | |
*** subscope has joined #openstack-nova | 12:58 | |
*** boris-42 has quit IRC | 12:58 | |
*** subscope has quit IRC | 13:00 | |
*** asselin has joined #openstack-nova | 13:00 | |
*** jerrygb has joined #openstack-nova | 13:01 | |
alexschm | danpb: in the AIO mode spec you commented that the aio setting has no effect for network based disks | 13:02 |
*** thorst has joined #openstack-nova | 13:03 | |
danpb | alexschm: yep | 13:03 |
alexschm | danpb: is this only true for kernel based rbd or does it also apply to NFS, iSCSI and glusterfs? | 13:03 |
danpb | alexschm: ok, i meant disks that use <disk type='network'> | 13:03 |
danpb | ie, QEMU is the network client | 13:03 |
*** alex_klimov has joined #openstack-nova | 13:04 | |
danpb | disks that use kernel drivers via the host block layer are relevant for aio setting | 13:04 |
openstackgerrit | Jay Pipes proposed openstack/nova-specs: Adds pci-generate-stats spec https://review.openstack.org/240852 | 13:04 |
*** heyongli has quit IRC | 13:04 | |
alexschm | danpb: ah okay I get the difference now | 13:04 |
*** heyongli has joined #openstack-nova | 13:05 | |
*** root__ has joined #openstack-nova | 13:05 | |
alexschm | danpb: I'll incorporate your comments in the spec, did you make any progress regarding the performance measurements? :) | 13:05 |
*** jlanoux has joined #openstack-nova | 13:07 | |
*** romainh has joined #openstack-nova | 13:07 | |
danpb | alexschm: talking to our perf team today to find out status of it | 13:13 |
alexschm | danpb: that's great, thank you! | 13:14 |
*** heyongli has quit IRC | 13:14 | |
*** heyongli has joined #openstack-nova | 13:15 | |
*** burgerk has joined #openstack-nova | 13:16 | |
*** josecastroleon has quit IRC | 13:17 | |
*** thorst has quit IRC | 13:18 | |
*** makkie- has joined #openstack-nova | 13:20 | |
openstackgerrit | Pavel Kholkin proposed openstack/nova: enginefacade: 'compute_node' https://review.openstack.org/241189 | 13:21 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: enginefacade: 'service' https://review.openstack.org/241178 | 13:21 |
openstackgerrit | Pavel Kholkin proposed openstack/nova: enginefacade: 'compute_node' https://review.openstack.org/241189 | 13:21 |
*** abramley_ has joined #openstack-nova | 13:22 | |
*** gerhardq1x has joined #openstack-nova | 13:22 | |
*** makkie_ has quit IRC | 13:22 | |
*** abramley has quit IRC | 13:22 | |
*** gerhardqux has quit IRC | 13:22 | |
*** abramley_ is now known as abramley | 13:22 | |
*** lsmola has quit IRC | 13:22 | |
*** lsmola has joined #openstack-nova | 13:22 | |
*** thorst has joined #openstack-nova | 13:24 | |
*** heyongli has quit IRC | 13:24 | |
*** pratikmallya has joined #openstack-nova | 13:25 | |
*** heyongli has joined #openstack-nova | 13:25 | |
*** thorst_ has joined #openstack-nova | 13:26 | |
*** thorst has quit IRC | 13:28 | |
*** thorst_ has quit IRC | 13:31 | |
*** edmondsw has joined #openstack-nova | 13:31 | |
*** Sree has joined #openstack-nova | 13:33 | |
*** rmstar has joined #openstack-nova | 13:33 | |
*** thorst has joined #openstack-nova | 13:34 | |
*** mwagner has joined #openstack-nova | 13:34 | |
*** heyongli has quit IRC | 13:35 | |
*** mgoddard has joined #openstack-nova | 13:35 | |
*** heyongli has joined #openstack-nova | 13:36 | |
*** mgoddard__ has quit IRC | 13:36 | |
*** gcb has quit IRC | 13:37 | |
*** salv-orlando has quit IRC | 13:37 | |
*** njirap has joined #openstack-nova | 13:37 | |
*** gcb has joined #openstack-nova | 13:37 | |
*** subscope has joined #openstack-nova | 13:38 | |
openstackgerrit | garyk proposed openstack/nova-specs: VMware: expand opaque network support https://review.openstack.org/230425 | 13:40 |
garyk | mriedem_away: ^ | 13:40 |
*** cristicalin has joined #openstack-nova | 13:44 | |
*** signed8bit has joined #openstack-nova | 13:45 | |
*** heyongli has quit IRC | 13:45 | |
openstackgerrit | Pawel Koniszewski proposed openstack/nova-specs: Pause VM during live migration https://review.openstack.org/229040 | 13:45 |
*** heyongli has joined #openstack-nova | 13:46 | |
bauzas | jaypipes: dansmith: eh, just catching up my gerrit backlog, happy to see you reviewing the ReqSpec changes | 13:47 |
cristicalin | anybody know if there is a version of https://launchpad.net/nova/+bug/1457517 for juno ? | 13:49 |
openstack | Launchpad bug 1457517 in nova (Ubuntu Vivid) "Unable to boot from volume when flavor disk too small" [High,Fix released] | 13:49 |
cristicalin | I see it tagged for kilo and liberty only | 13:49 |
*** josecastroleon has joined #openstack-nova | 13:50 | |
PaulMurray | johnthetubaguy, looking at https://review.openstack.org/#/c/240959/ | 13:51 |
PaulMurray | there is one item in our list that is related to resize instead of live migrate | 13:51 |
PaulMurray | is it worth mentioning? | 13:51 |
PaulMurray | Its the one about storage pools. | 13:52 |
*** alejandrito has joined #openstack-nova | 13:52 | |
PaulMurray | johnthetubaguy, see 6 on https://etherpad.openstack.org/p/mitaka-live-migration | 13:53 |
*** lpetrut has joined #openstack-nova | 13:54 | |
*** subscope has quit IRC | 13:55 | |
*** raildo-afk is now known as raildo | 13:55 | |
*** heyongli has quit IRC | 13:55 | |
*** heyongli has joined #openstack-nova | 13:56 | |
johnthetubaguy | PaulMurray: I guess storage pools helps with both? | 13:58 |
*** RA_ has joined #openstack-nova | 13:58 | |
*** mdrabe has joined #openstack-nova | 13:59 | |
*** rlrossit has joined #openstack-nova | 14:01 | |
PaulMurray | johnthetubaguy, not really, it removes the need for an external mechanism for copying disks - it lets libvirt take care of things, but its really used in cold migration | 14:01 |
bauzas | alex_xu: still around ? | 14:01 |
alex_xu | bauzas: yea, I'm here | 14:02 |
bauzas | alex_xu: I don't understand your point in https://review.openstack.org/#/c/191251/37/nova/scheduler/host_manager.py,cm for numa | 14:02 |
johnthetubaguy | PaulMurray: oh, I thought that would help with the block migration during live-migrate as well, maybe I got the wrong end of the stick there | 14:02 |
*** pixelb has quit IRC | 14:02 | |
PaulMurray | johnthetubaguy, unless I understand wrong - maybe danpb can comment | 14:02 |
*** zul_ is now known as zul | 14:02 | |
alex_xu | bauzas: sorry, I didn't explain clearly | 14:02 |
danpb | no block live migration is completely separate | 14:03 |
johnthetubaguy | PaulMurray: I don't really want to add resize in the priority list, but I OK with you folks adding the storage pools stuff in there, I think that has values | 14:03 |
johnthetubaguy | danpb: OK, cool | 14:03 |
danpb | that uses an nbd server builtin to qemu | 14:03 |
markus_z | tdurakov: That's OK from a zKVM POV => https://review.openstack.org/#/c/183057/8 | 14:03 |
bauzas | PaulMurray: I'm fine with your email about 1500UTC, but you didn't said which day :) | 14:03 |
alex_xu | bauzas: give me a sec find some link to explain that | 14:03 |
*** su_zhang has joined #openstack-nova | 14:04 | |
bauzas | alex_xu: sure | 14:04 |
johnthetubaguy | danpb: when we do the exclude list of config drive, do we end up doing a regular copy for that one, or is it just NDB for that too? | 14:04 |
danpb | i can't remmeber how we deal with config drive right now | 14:05 |
*** pixelb has joined #openstack-nova | 14:05 | |
danpb | but with new libvirt we'll be copying it via the nbd channel, as with all other disks we care about copying | 14:05 |
*** heyongli has quit IRC | 14:05 | |
PaulMurray | johnthetubaguy, do you mean add storage pools to the description of live migrate in https://review.openstack.org/#/c/240959/4 ? | 14:05 |
*** salv-orlando has joined #openstack-nova | 14:05 | |
*** heyongli has joined #openstack-nova | 14:06 | |
*** mc_nair has joined #openstack-nova | 14:06 | |
alex_xu | bauzas: line 279 of https://review.openstack.org/#/c/191251/37/nova/scheduler/host_manager.py will caclualte an numa toplogy for target host and assign to request spec obj | 14:07 |
*** ccarmack has left #openstack-nova | 14:07 | |
*** lpetrut has quit IRC | 14:08 | |
bauzas | alex_xu: hum, no | 14:08 |
bauzas | alex_xu: consume_from_instance() is used for decrementing the resource usage from each HostState when an instance is provided | 14:08 |
alex_xu | bauzas: but hardware.numa_fit_instance_to_host return an new numatopology object | 14:09 |
openstackgerrit | John Garbutt proposed openstack/nova-specs: Add Mitaka Priorities https://review.openstack.org/240959 | 14:09 |
alex_xu | which numa topology object is based on host topology | 14:09 |
bauzas | alex_xu: that's hard to explain so I'll summarize | 14:10 |
bauzas | alex_xu: basically, what the user asks for NUMA is quite abstract | 14:10 |
*** mrkz has joined #openstack-nova | 14:10 | |
*** markvoelker has joined #openstack-nova | 14:10 | |
bauzas | alex_xu: so the scheduler just checks what's possible or not | 14:10 |
bauzas | alex_xu: but once the host is found for the asked instance, then it transforms the numa request into something better said for the host | 14:11 |
alex_xu | bauzas: yes | 14:11 |
bauzas | alex_xu: that's what the hardware.fit_instance_to_host does | 14:11 |
*** subscope has joined #openstack-nova | 14:12 | |
*** changbl has quit IRC | 14:12 | |
alex_xu | yes, right. but that hide some user initial request | 14:12 |
*** thorst has quit IRC | 14:12 | |
alex_xu | for example, page_size https://github.com/openstack/nova/blob/master/nova/virt/hardware.py#L654 | 14:12 |
bauzas | alex_xu: not exactly because the user didn't asked for some specific PCI devices | 14:12 |
*** gongysh has quit IRC | 14:12 | |
alex_xu | bauzas: that is the reason why we shouldn't save the new topology into request spec obj | 14:13 |
alex_xu | we should keep request spec obj to store the initial request | 14:13 |
*** w_verdugo has joined #openstack-nova | 14:13 | |
*** venkat_p has joined #openstack-nova | 14:13 | |
*** gongysh has joined #openstack-nova | 14:13 | |
*** venkat_p has quit IRC | 14:14 | |
bauzas | alex_xu: well, it's already done by this way for the original stuff | 14:14 |
*** cfriesen_ has joined #openstack-nova | 14:14 | |
bauzas | alex_xu: like the instance object is a dict, it's a mutable object | 14:14 |
alex_xu | bauzas: for page size case, if user request MEMPAGES_LARGE, but the scheduler calculate a page size depend on the target host. and we save that page size in request spec obj. in next scheduling(migration), the MEMPAGES_LARGE will be forget | 14:15 |
bauzas | alex_xu: so I'm not changing the behaviour | 14:15 |
*** thorst has joined #openstack-nova | 14:15 | |
bauzas | alex_xu: then the helper is buggy, not my change :) | 14:15 |
*** markvoelker has quit IRC | 14:15 | |
alex_xu | bauzas: yea, I'm not say your patch wrong :) | 14:15 |
*** obondarev has joined #openstack-nova | 14:15 | |
*** heyongli has quit IRC | 14:16 | |
*** obondarev has quit IRC | 14:16 | |
*** obondarev has joined #openstack-nova | 14:16 | |
bauzas | alex_xu: tbc, do you agree with the fact that the original consume_from_instance() method already wedges that? | 14:16 |
*** heyongli has joined #openstack-nova | 14:17 | |
*** mriedem_away is now known as mriedem | 14:17 | |
alex_xu | bauzas: I just saw line 164 in https://review.openstack.org/#/c/197912/35/nova/scheduler/filter_scheduler.py reset the hosts fields. I'm thinking maybe we should reset numa toplogy field also. But maybe this is part of persist request spec, not your patch. so nvm | 14:17 |
alex_xu | bauzas: emm....yea | 14:18 |
*** xyang1 has joined #openstack-nova | 14:18 | |
*** jichen has quit IRC | 14:18 | |
bauzas | alex_xu: I don't want to regress because the helper is buggy but I can surely workaroud by using a different attribute for sure | 14:19 |
*** otter768 has joined #openstack-nova | 14:19 | |
bauzas | sahid: you there N | 14:20 |
*** ijuwang has joined #openstack-nova | 14:20 | |
*** electrocucaracha has joined #openstack-nova | 14:20 | |
*** ccarmack has joined #openstack-nova | 14:20 | |
bauzas | sahid: since ndipanov is on PTO, I'm hassling some other numa guy :p | 14:20 |
ccarmack | garyk: We are setting up openstack to manage a Vcenter. We have nova working. Is it possible to use neutron, or do we need NSX (or nova network)? | 14:22 |
garyk | ccarmack: there are a numbr of choices: | 14:23 |
garyk | 1. ya good old nova network | 14:23 |
*** unicell has joined #openstack-nova | 14:23 | |
garyk | 2. Neutron | 14:23 |
garyk | That can be used in a number of forms: | 14:23 |
alex_xu | bauzas: you mean the 'different attributes' like request_spec.config_options? | 14:23 |
garyk | ccarmack: you can choose your neutron drivers. There are a number of different options out there that support the VC | 14:24 |
bauzas | alex_xu: sorry I meant a temporary variable | 14:24 |
bauzas | alex_xu: like fitted_numa_topo | 14:24 |
*** otter768 has quit IRC | 14:24 | |
bauzas | alex_xu: since we only need that for pci_requests IIUC | 14:25 |
bauzas | but I'd defer that to sahid | 14:25 |
alex_xu | bauzas: that fitted_numa_topo should be passed to compute node | 14:25 |
garyk | ccarmack: from the vmware_nsx repo you can choose one of the NSX plugins or a very simple DVS plugin - that will let an admin create provider networks for tenants | 14:25 |
*** unicell1 has quit IRC | 14:25 | |
*** klkumar has joined #openstack-nova | 14:26 | |
garyk | ccarmack: you can also try one of the other VC networking solutions which I am not really familair with and have some nova patching that needs to be done - networking-vsphere and vmware-dvs | 14:26 |
*** heyongli has quit IRC | 14:26 | |
*** njirap has quit IRC | 14:26 | |
openstackgerrit | Pawel Koniszewski proposed openstack/nova-specs: Pause VM during live migration https://review.openstack.org/229040 | 14:26 |
ccarmack | garyk: we don't want to use NSX, so I think we'll try the DVS plugin (although we have simple switch) | 14:26 |
*** heyongli has joined #openstack-nova | 14:27 | |
mriedem | garyk: what do people use for vmware networking if their vcenter is < 5.5? dvswitch? | 14:27 |
garyk | mriedem: there are a number of options for that: | 14:27 |
bauzas | alex_xu: we're not passing back the request spec | 14:27 |
garyk | 1. simple dvs neutron (vmware_nsx) | 14:27 |
bauzas | alex_xu: the returned call is only (host, node, limits) | 14:27 |
garyk | 2. NSX|V (that requires NSX) | 14:27 |
ccarmack | mriedem: our Vcenter is 5.5 | 14:28 |
*** su_zhang has quit IRC | 14:28 | |
alex_xu | bauzas: yea, true, I missed that | 14:28 |
garyk | 3. one of the other neutron plugins (mirantis and hp have their offerenings) | 14:28 |
mriedem | ccarmack: i'm not asking for the same reasons you are | 14:28 |
ccarmack | ok | 14:28 |
bauzas | alex_xu: IIUC, that's only pci_stats.apply_requests which persists that | 14:28 |
mriedem | garyk: is vmware_nsx the same as the NSX-MH plugin mentioned in https://review.openstack.org/#/c/230425/ ? | 14:28 |
garyk | ccarmack: i can help with the plaugins in the vmware_nsx repo | 14:28 |
*** ctrath has joined #openstack-nova | 14:28 | |
ccarmack | garyk: ok, thanks. We don't have DVS, we have simple. | 14:29 |
bauzas | alex_xu: which is just horrible if you want my opinion, but that's something we discussed during the summit and we said we need some PCI refactoring | 14:29 |
openstackgerrit | Pawel Koniszewski proposed openstack/nova-specs: Pause VM during live migration https://review.openstack.org/229040 | 14:29 |
garyk | mriedem: the vmware_nsx is the repo of the plugin that our team supports. there are 4 at the moment | 14:29 |
tdurakov | johnthetubaguy, hi, could you help with merging this spec: https://review.openstack.org/#/c/183057/ | 14:29 |
mriedem | garyk: wow | 14:29 |
tdurakov | markus_z, thanks a lot) | 14:29 |
garyk | i. NSX-MH, 2,NSXv 3. Simple DVS and 4. NSXv3 (which will deprecate the NSX-MH) | 14:29 |
mriedem | when will there be a neutron vmware plugin of power that rules them all? | 14:29 |
*** dustins has joined #openstack-nova | 14:30 | |
garyk | mriedem: as soon as the NSXv3 is released | 14:30 |
ccarmack | garyk: we also followed the instructions in the ML : http://lists.openstack.org/pipermail/openstack-operators/2015-October/008383.html | 14:30 |
ccarmack | garyk: we created port groups in the Vcenter with matching names to the bridges created on the openstack node | 14:31 |
mriedem | garyk: so of those 4, if i have vcenter < 5.5, which can i use? 2 and 3? | 14:31 |
bauzas | meh, I missed the gate stability :) | 14:31 |
garyk | mriedem: for that 2 and or 3 | 14:31 |
*** mgoddard_ has joined #openstack-nova | 14:31 | |
alex_xu | bauzas: yea | 14:31 |
mriedem | ok | 14:31 |
garyk | mriedem: 3 is very limited - no security groups and l3 support. We use it for testing and POC's | 14:32 |
mriedem | garyk: yeah, i read some vmware / vio blog about those 2 | 14:32 |
garyk | mriedem: #2 has a full fledged neutron stack. | 14:32 |
garyk | ccarmack: if you need any help getting the stuff setup then pease feel free to reach out to me | 14:33 |
ccarmack | thanks garyk, I might do that | 14:33 |
alex_xu | bauzas: will we save request spec in the scheduler? | 14:34 |
*** jwcroppe has joined #openstack-nova | 14:34 | |
*** mgoddard has quit IRC | 14:34 | |
garyk | ccarmack: i also found this one today - https://github.com/Mirantis/vmware-dvs | 14:35 |
ccarmack | garyk: do all of those drivers require NSX, because we don't have that | 14:35 |
ccarmack | looking | 14:35 |
garyk | ccarmack: no, the simple DVS does not require NSX | 14:35 |
ccarmack | ok | 14:35 |
garyk | you can use a simple DVS for that | 14:35 |
bauzas | alex_xu: no | 14:36 |
bauzas | never | 14:36 |
johnthetubaguy | tdurakov: its on my radar, I want to start pushing on spec reviews over the next week or so | 14:36 |
*** heyongli has quit IRC | 14:36 | |
alex_xu | bauzas: so line 153 at https://review.openstack.org/#/c/197912/35/nova/scheduler/filter_scheduler.py is purpose for what? | 14:36 |
bauzas | mriedem: meh, seems a new bug http://logstash.openstack.org/#dashboard/file/logstash.json?query=message:%5C%22Invalid%20volume:%20Volume%20still%20has%201%20dependent%20snapshots%5C%22%20AND%20build_name:%5C%22gate-tempest-dsvm-cells%5C%22 | 14:36 |
alex_xu | bauzas: sorry, 163 | 14:37 |
*** ccarmack has quit IRC | 14:37 | |
bauzas | the cells job is so in happiness | 14:37 |
*** heyongli has joined #openstack-nova | 14:37 | |
mriedem | bauzas: i think i've seen that one | 14:37 |
mriedem | before today i mean | 14:37 |
*** smatzek has quit IRC | 14:37 | |
mriedem | the ebs test in tempest that broke, the guy was trying to get it re-instated, maybe that happened | 14:37 |
mriedem | checking | 14:38 |
tdurakov | johnthetubaguy, ok, thanks, looks like everything is ok now with the spec, so no blocker for merging it. | 14:38 |
bauzas | mriedem: for the cells job, it's new | 14:38 |
*** burgerk has quit IRC | 14:38 | |
bauzas | alex_xu: oh that | 14:38 |
*** salv-orlando has quit IRC | 14:39 | |
*** salv-orlando has joined #openstack-nova | 14:39 | |
mriedem | bauzas: yup https://github.com/openstack/tempest/commit/35fd828aad02456f9d95f95123c1fcd3d54c1f56 | 14:40 |
mriedem | that's the one | 14:40 |
*** RA_ has quit IRC | 14:41 | |
bauzas | mriedem: erm | 14:41 |
*** burt has joined #openstack-nova | 14:41 | |
bauzas | mriedem: so we need to exclude it in the rc file | 14:41 |
*** electrocucaracha has quit IRC | 14:42 | |
mriedem | bauzas: it might not just be cells | 14:42 |
mriedem | checking that now | 14:42 |
bauzas | mriedem: I just did and that blows up | 14:43 |
bauzas | alex_xu: so, there is no clear call to have the hosts change unset | 14:43 |
bauzas | alex_xu: I left it because it was clearer that it was not needed | 14:44 |
*** krtaylor has quit IRC | 14:44 | |
alex_xu | bauzas: ok, I see now | 14:46 |
*** heyongli has quit IRC | 14:46 | |
*** Sree has quit IRC | 14:47 | |
bauzas | mriedem: so, I'd advocate for reverting the change to skip the test | 14:47 |
alex_xu | bauzas: that comment lead me to think about we will save the spec obj later | 14:47 |
*** heyongli has joined #openstack-nova | 14:47 | |
andrearosa | review please for an old patch: https://review.openstack.org/184537 /cc mriedem | 14:47 |
*** e0ne has quit IRC | 14:48 | |
mriedem | andrearosa: yeah been meaning to get back on that, been doing some specs | 14:48 |
alex_xu | bauzas: but nvm, it isn't something biggy. anyway thanks for the talk and explain :) | 14:48 |
mriedem | bauzas: i have to filter out some of the garbage with voting:"1" | 14:49 |
mriedem | looks like it's failing a lot of non-voting jobs | 14:49 |
andrearosa | mriedem: cool! | 14:49 |
*** rajesht_ has joined #openstack-nova | 14:49 | |
*** mdrabe_ has joined #openstack-nova | 14:50 | |
*** pradk has joined #openstack-nova | 14:50 | |
andrearosa | mriedem: you talk about that patch? | 14:50 |
*** ccarmack has joined #openstack-nova | 14:50 | |
mriedem | bauzas: we already had a query for the old failure on that ebs test, it's still there, but results are, weird http://status.openstack.org/elastic-recheck/index.html#1489581 | 14:50 |
bauzas | mriedem: probably my message pattern is a bit not good | 14:51 |
mriedem | andrearosa: ? | 14:51 |
andrearosa | mriedem: nevermind I thought you were talking to me | 14:51 |
mriedem | ok | 14:51 |
mriedem | just saying i've been reviewing specs lately | 14:51 |
mriedem | rather than code/bugs | 14:51 |
*** garyk has quit IRC | 14:52 | |
*** rajesht has quit IRC | 14:52 | |
*** mdrabe has quit IRC | 14:52 | |
bauzas | mriedem: so tbh, I feel that the issue wasn't resolved when the proposal to unskip the test was merged :) | 14:54 |
*** irenab has quit IRC | 14:54 | |
bauzas | mriedem: because launchpad doesn't show me a clear solution path for that bug | 14:54 |
bauzas | except the skip/unskip thing | 14:54 |
bauzas | nevermind my previous concern, I'm blind | 14:56 |
*** heyongli has quit IRC | 14:57 | |
*** sfinucan has joined #openstack-nova | 14:57 | |
*** tpeoples has joined #openstack-nova | 14:57 | |
*** krtaylor has joined #openstack-nova | 14:57 | |
*** ctrath has quit IRC | 14:57 | |
*** alexpilotti has joined #openstack-nova | 14:58 | |
*** heyongli has joined #openstack-nova | 14:58 | |
mriedem | bauzas: yeah it's not clear to me either what the fix was | 14:58 |
*** tonytan4ever has joined #openstack-nova | 14:58 | |
*** smatzek has joined #openstack-nova | 15:01 | |
*** pradipta has quit IRC | 15:01 | |
*** READ10 has joined #openstack-nova | 15:02 | |
johnthetubaguy | danpb: could you move this over to mitaka, then I can apply the +2 +W https://review.openstack.org/#/c/193668 | 15:02 |
*** ctrath has joined #openstack-nova | 15:02 | |
johnthetubaguy | danpb: I would do that, but just jumping into a meeting | 15:03 |
*** e0ne has joined #openstack-nova | 15:03 | |
bauzas | mriedem: oh interesting | 15:03 |
bauzas | mriedem: my change wasn't racing on the same thing http://logs.openstack.org/87/188487/39/check/gate-tempest-dsvm-cells/6a75b7f/console.html#_2015-11-03_14_23_00_122 | 15:03 |
bauzas | mriedem: so https://review.openstack.org/#/c/217804/ is now OK but the later self.create_volume isn't | 15:04 |
danpb | johnthetubaguy: ok will do | 15:05 |
bauzas | s/create_volume/create_server | 15:05 |
*** heyongli has quit IRC | 15:07 | |
*** heyongli has joined #openstack-nova | 15:08 | |
mriedem | what is causing the "Boot sequence for the instance is invalid"? | 15:09 |
*** burgerk has joined #openstack-nova | 15:09 | |
bauzas | mriedem: that's what I'm digging | 15:10 |
mriedem | me too | 15:10 |
mriedem | we could probably use some more verbose logging around that kind of failure | 15:10 |
bauzas | mriedem: I was obfuscated by the teardown | 15:10 |
*** pumaranikar has joined #openstack-nova | 15:12 | |
bauzas | oh oh | 15:13 |
openstackgerrit | Andrea Rosa proposed openstack/nova-specs: Allow more instance operations during live migration https://review.openstack.org/226199 | 15:14 |
bauzas | http://logs.openstack.org/87/188487/39/check/gate-tempest-dsvm-cells/6a75b7f/logs/screen-n-api.txt.gz#_2015-11-03_14_18_39_220 | 15:14 |
*** wanghua has joined #openstack-nova | 15:14 | |
openstackgerrit | Alexander Schmidt proposed openstack/nova-specs: Libvirt: AIO mode for disk devices https://review.openstack.org/232514 | 15:15 |
*** wanghua has quit IRC | 15:15 | |
*** wanghua has joined #openstack-nova | 15:16 | |
*** thorst has quit IRC | 15:16 | |
*** heyongli has quit IRC | 15:17 | |
*** thorst has joined #openstack-nova | 15:18 | |
*** heyongli has joined #openstack-nova | 15:18 | |
*** klkumar has quit IRC | 15:19 | |
*** alexschm has quit IRC | 15:20 | |
*** jaypipes has quit IRC | 15:21 | |
*** thorst has quit IRC | 15:23 | |
*** thorst has joined #openstack-nova | 15:24 | |
*** dims has quit IRC | 15:24 | |
mriedem | bauzas: yeah, i know, but that's the same thing tempest logs, which isn't very helpful | 15:24 |
*** dims has joined #openstack-nova | 15:24 | |
mriedem | i found the code but it's not helping me | 15:24 |
bauzas | mriedem: so it's a cells job | 15:24 |
mriedem | no boot from volume? | 15:25 |
bauzas | mriedem: which means that the _validate_bdms() call is not made the same way unless I'm wrong | 15:25 |
*** dustins has quit IRC | 15:25 | |
*** markvoelker has joined #openstack-nova | 15:26 | |
bauzas | mriedem: because of the https://github.com/openstack/nova/blob/master/nova/compute/__init__.py#L39 | 15:26 |
*** gszasz has quit IRC | 15:27 | |
*** heyongli has quit IRC | 15:27 | |
mriedem | well, tempest\.scenario\.test_volume_boot_pattern\.TestVolumeBootPattern\.test_volume_boot_pattern is skipped for cells, probably for the same reason | 15:28 |
mriedem | we should have a support matrix for cells | 15:28 |
mriedem | so i don't have to ask alaski every time if boot from volume is supported or not | 15:28 |
*** heyongli has joined #openstack-nova | 15:28 | |
bauzas | mriedem: see https://github.com/openstack/nova/blob/master/nova/compute/cells_api.py#L201-L206 | 15:28 |
*** dustins has joined #openstack-nova | 15:28 | |
bauzas | in theory, the child cell should create the volume | 15:29 |
*** tongli has joined #openstack-nova | 15:29 | |
johnthetubaguy | mriedem: so it works for us downstream with cells | 15:29 |
johnthetubaguy | bauzas: yeah, its created in the child cell | 15:29 |
johnthetubaguy | now "works" its a relative term, it works for the things we test | 15:29 |
bauzas | just trying to get the correct path | 15:29 |
johnthetubaguy | gotcha | 15:29 |
johnthetubaguy | mriedem: the feature classification effort, I want to re-kick that, as it would be able to talk about cells and have those details listed | 15:30 |
openstackgerrit | Ryan McNair proposed openstack/nova: Add retry logic for detaching device using LibVirt https://review.openstack.org/227851 | 15:30 |
*** markvoelker has quit IRC | 15:31 | |
*** mdrabe_ has quit IRC | 15:31 | |
bauzas | so, now I'm trying to identify whether the validate_bdms() that raises the exception is done by the original super call to create_server or if it's coming from the cells scheduler creating the instance | 15:31 |
*** gszasz has joined #openstack-nova | 15:31 | |
mriedem | bauzas: _create_block_device_mapping comes after _validate_bdm, which is what blows up | 15:32 |
mriedem | cells api just no-ops _create_block_device_mapping | 15:32 |
bauzas | right | 15:32 |
mriedem | i'd like to find the actual boot from volume request in the tempest logs | 15:33 |
*** subscope has quit IRC | 15:33 | |
bauzas | but if so, where is done the BDM creation ? | 15:33 |
*** mgoddard_ has quit IRC | 15:33 | |
mriedem | i think _validate_bdm is just validating the request | 15:33 |
*** mgoddard has joined #openstack-nova | 15:33 | |
mriedem | sanity checking | 15:33 |
*** Kennan has quit IRC | 15:34 | |
mriedem | nvm i guess it is a list of bdm objects, just not created in the db yet | 15:34 |
*** rlrossit has quit IRC | 15:34 | |
mriedem | _check_and_transform_bdm does that conversion | 15:35 |
openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Build timeouts task filters deleting instances https://review.openstack.org/240017 | 15:35 |
*** jistr has quit IRC | 15:37 | |
*** e0ne has quit IRC | 15:37 | |
mriedem | bauzas: hmm, wtf, why is test_volume_boot_pattern even running on the cells job here? | 15:37 |
mriedem | http://logs.openstack.org/87/188487/39/check/gate-tempest-dsvm-cells/6a75b7f/logs/screen-n-api.txt.gz#_2015-11-03_14_18_39_221 | 15:37 |
*** klkumar has joined #openstack-nova | 15:37 | |
mriedem | that should be getting skipped https://github.com/openstack/nova/blob/master/devstack/tempest-dsvm-cells-rc#L73 | 15:37 |
*** heyongli has quit IRC | 15:38 | |
* bauzas checks the console log to verify the test path | 15:38 | |
*** heyongli has joined #openstack-nova | 15:39 | |
*** rlrossit has joined #openstack-nova | 15:40 | |
mriedem | hmm http://logs.openstack.org/87/188487/39/check/gate-tempest-dsvm-cells/6a75b7f/console.html#_2015-11-03_14_21_56_912 | 15:40 |
*** HenryG has quit IRC | 15:40 | |
mriedem | tempest.scenario.test_volume_boot_pattern.TestVolumeBootPatternV2.test_create_ebs_image_and_check_boot [229.632832s] ... FAILED | 15:40 |
*** RuiChen has quit IRC | 15:40 | |
mriedem | r="$r|(?:tempest\.scenario\.test_volume_boot_pattern\.TestVolumeBootPatternV2\.test_volume_boot_pattern*)" | 15:40 |
mriedem | ah, because we only skip the one test | 15:40 |
bauzas | mriedem: because the RC doesn't exclude that one | 15:40 |
mriedem | not the entire class | 15:40 |
mriedem | yeah | 15:40 |
bauzas | yeah that | 15:40 |
mriedem | we should just skip all of tempest.scenario.test_volume_boot_pattern | 15:41 |
bauzas | sorry, I feel like it's 11pm now for me, thanks jetlag :) | 15:41 |
*** subscope has joined #openstack-nova | 15:41 | |
*** HenryG has joined #openstack-nova | 15:41 | |
bauzas | I'll drop off soon | 15:41 |
bauzas | mriedem: so yeah, I did a recheck but I'll propose a change against removing the whole class and CC alaski | 15:42 |
*** pixelb has quit IRC | 15:42 | |
mriedem | i can do it too if you need to drop off | 15:43 |
bauzas | mriedem: just writing it now | 15:43 |
*** pixelb has joined #openstack-nova | 15:43 | |
mriedem | k | 15:43 |
*** nkrinner has quit IRC | 15:43 | |
bauzas | I don't really need to drop off, just taking a few time off - because my brain is fried (c) johnthetubaguy | 15:43 |
mriedem | john copyrighted that? | 15:44 |
*** browne has joined #openstack-nova | 15:44 | |
openstackgerrit | Andrea Rosa proposed openstack/nova-specs: Allow more instance operations during live migration https://review.openstack.org/226199 | 15:44 |
*** alexschm has joined #openstack-nova | 15:46 | |
mriedem | btw this is the bdm request http://logs.openstack.org/87/188487/39/check/gate-tempest-dsvm-cells/6a75b7f/console.html#_2015-11-03_14_23_00_145 | 15:46 |
mriedem | "block_device_mapping_v2": [{"destination_type": "volume", "boot_index": 0, "uuid": "553083ac-40f2-4225-ac4d-a1d021eb7fb1", "source_type": "volume", "delete_on_termination": true}] | 15:46 |
*** jdurgin has joined #openstack-nova | 15:47 | |
*** tdurakov has quit IRC | 15:47 | |
openstackgerrit | Sylvain Bauza proposed openstack/nova: Exclude all BDMv2 checks for cells https://review.openstack.org/241258 | 15:47 |
bauzas | mriedem: I need to decrypt the very obfuscate validate_bdms() method :) | 15:48 |
*** Guest65445 has joined #openstack-nova | 15:48 | |
mriedem | yeah we need some logging before we raise that InvalidBDM exception | 15:48 |
bauzas | because the boot index seems correct to me | 15:48 |
*** heyongli has quit IRC | 15:48 | |
mriedem | b/c boot_index was 0 | 15:48 |
*** w_verdugo has quit IRC | 15:48 | |
*** heyongli has joined #openstack-nova | 15:49 | |
bauzas | but 0 was in boot_indexes nope ? :) | 15:49 |
bauzas | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1293 | 15:49 |
mriedem | it was | 15:49 |
*** w_verdugo has joined #openstack-nova | 15:49 | |
mriedem | so must have been _subsequent_list(boot_indexes) ? | 15:49 |
mriedem | and return all(el + 1 == l[i + 1] for i, el in enumerate(l[:-1])) is very clear | 15:50 |
*** mdrabe has joined #openstack-nova | 15:50 | |
bauzas | my point :) | 15:50 |
openstackgerrit | Alexander Schmidt proposed openstack/nova-specs: Libvirt: AIO mode for disk devices https://review.openstack.org/232514 | 15:52 |
mariojv | jroll: gibi: thanks for the ping - i would be interested in attending that meeting | 15:53 |
*** breitz has quit IRC | 15:53 | |
jroll | mariojv: check out the spec too :) | 15:53 |
mariojv | was planning on writing up the ironic notifications spec later this week, i'll be sure to read that before getting much further | 15:53 |
*** breitz has joined #openstack-nova | 15:54 | |
mriedem | bauzas: yeah so _subsequent_list is just checking for gaps, but with a list of [0] it seems odd that'd fail | 15:54 |
mriedem | unless we have more than just 0 | 15:54 |
mriedem | maybe we have 0 in there multiple times... | 15:55 |
mriedem | i'll push a change with logging | 15:55 |
*** achanda has joined #openstack-nova | 15:56 | |
*** inteq has joined #openstack-nova | 15:57 | |
*** su_zhang has joined #openstack-nova | 15:57 | |
gibi | mariojv: great! Could you share your time preference for the meeting on the ML thread? | 15:58 |
mriedem | why does it remove the last element from the list? | 15:58 |
mriedem | we need ndipanov around probably | 15:58 |
mriedem | danpb: are you around? | 15:58 |
*** heyongli has quit IRC | 15:58 | |
*** heyongli has joined #openstack-nova | 15:59 | |
kashyap | markus_z: I guess is it okay to elide contacts that are not active any more on the bug triage wiki? | 16:01 |
*** jistr has joined #openstack-nova | 16:01 | |
markus_z | kashyap: yepp, sure | 16:02 |
markus_z | kashyap: which one do you have in mind? | 16:02 |
*** pratikmallya has quit IRC | 16:02 | |
kashyap | markus_z: directxman (Solly Ross?) I don't see him active any more on libvirt component | 16:02 |
markus_z | kashyap: Ah, ok, too bad. :( | 16:03 |
mriedem | solly isn't working on nova anymore | 16:03 |
kashyap | Yeah, that's what I meant | 16:03 |
*** diogogmt has joined #openstack-nova | 16:03 | |
danpb | mriedem: hi | 16:04 |
*** angdraug has joined #openstack-nova | 16:04 | |
mriedem | danpb: the cells job is failing on a boot from volume test hitting this https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1283-L1294 | 16:04 |
mriedem | do you know why _subsequent_list is removing the last element fromthe bdm boot index list? | 16:05 |
danpb | no, never seen that code before | 16:05 |
* danpb goes to look at git history | 16:05 | |
mariojv | gibi: done, thanks for setting this up :) | 16:05 |
*** achanda has quit IRC | 16:05 | |
gibi | mariojv: thanks for joining. :) | 16:06 |
kashyap | On a related note: "Instances failes to boot from volume" https://bugs.launchpad.net/nova/+bug/1357677 | 16:06 |
*** gongysh has quit IRC | 16:06 | |
openstack | Launchpad bug 1357677 in OpenStack Compute (nova) "Instances failes to boot from volume" [High,Confirmed] | 16:06 |
*** humble__ has joined #openstack-nova | 16:07 | |
mriedem | danpb: https://github.com/openstack/nova/commit/0ef7e15e225efcce3e02098cb1d57f9f40181f82 doesn't tell me much | 16:07 |
danpb | mriedem: wierd, damned if i really understand what that's doing & git logs aren't much help | 16:07 |
*** wanghua has quit IRC | 16:07 | |
mriedem | yeah | 16:07 |
danpb | unfortnuately nikola is on PTO for the whole week | 16:07 |
mriedem | i heard | 16:07 |
mriedem | ftersin might know but not around either | 16:07 |
*** gongysh has joined #openstack-nova | 16:07 | |
*** cristicalin has quit IRC | 16:08 | |
*** heyongli has quit IRC | 16:08 | |
openstackgerrit | Dan Smith proposed openstack/nova-specs: nova-api hypervisor.cpu_info change from string to json object https://review.openstack.org/183057 | 16:09 |
*** heyongli has joined #openstack-nova | 16:09 | |
*** zhangjn has quit IRC | 16:09 | |
dansmith | johnthetubaguy: I think this is ready: https://review.openstack.org/#/c/183057/9 | 16:10 |
*** mtanino has joined #openstack-nova | 16:10 | |
*** klkumar has quit IRC | 16:12 | |
*** su_zhang has quit IRC | 16:12 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Add debug logging for when boot sequence is invalid in _validate_bdm https://review.openstack.org/241270 | 16:12 |
mriedem | bauzas: ^ | 16:12 |
*** edtubill has joined #openstack-nova | 16:12 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: Add debug logging for when boot sequence is invalid in _validate_bdm https://review.openstack.org/241270 | 16:14 |
*** dustins has quit IRC | 16:16 | |
dansmith | mriedem: your patch failed pci ci | 16:16 |
* dansmith cracks himself up | 16:16 | |
*** dhellmann has quit IRC | 16:16 | |
mriedem | i'll abandon | 16:16 |
dansmith | mriedem: you want me to +2 that? | 16:16 |
mriedem | as you wish | 16:17 |
dansmith | i.e. you're expecting to land this not just use it as recheck bait, right? | 16:17 |
mriedem | yes | 16:17 |
mriedem | it should also fail the cells job and give us more details | 16:17 |
mriedem | otherwise i need to borrow sdague's special decoder ring for that code | 16:17 |
*** mtanino has quit IRC | 16:18 | |
dansmith | mriedem: you don't want to dump the BDMs as well? if you get some weird ordering, will that tell you what you really want to know, which is which BDM is broken? | 16:18 |
*** dhellmann has joined #openstack-nova | 16:18 | |
*** heyongli has quit IRC | 16:19 | |
mriedem | could.... | 16:19 |
mriedem | repr on the bdm object should make it ok, but it's a list - that doesn't repr nicely does it? | 16:19 |
*** heyongli has joined #openstack-nova | 16:20 | |
dansmith | it should I think | 16:20 |
*** dustins has joined #openstack-nova | 16:20 | |
*** otter768 has joined #openstack-nova | 16:20 | |
*** stackdump has joined #openstack-nova | 16:21 | |
*** alexpilotti has quit IRC | 16:21 | |
*** danpb has quit IRC | 16:21 | |
andrearosa | gibi: still around? | 16:21 |
dansmith | mriedem: | 16:21 |
dansmith | >>> repr(objects.InstanceList(objects=[objects.Instance(uuid='fake')])) | 16:21 |
dansmith | 'InstanceList(objects=[Instance(fake)])' | 16:21 |
mriedem | hmm, i thought someone had a change up at one point to do something like that with pci device list and we nacked saying it should be done in ovo | 16:22 |
*** gszasz has quit IRC | 16:22 | |
dansmith | mriedem: that was an object field I think | 16:22 |
*** thorst has quit IRC | 16:23 | |
*** pratikmallya has joined #openstack-nova | 16:24 | |
*** dims_ has joined #openstack-nova | 16:24 | |
*** josecastroleon has quit IRC | 16:24 | |
*** alexschm has quit IRC | 16:24 | |
*** dims has quit IRC | 16:24 | |
*** alexpilotti has joined #openstack-nova | 16:25 | |
*** otter768 has quit IRC | 16:25 | |
mriedem | http://logs.openstack.org/87/188487/39/check/gate-tempest-dsvm-cells/6a75b7f/logs/screen-n-cpu.txt.gz#_2015-11-03_14_08_57_036 | 16:25 |
mriedem | ok yeah, i guess it just does <?> for subobjects | 16:25 |
dansmith | no, <?> means it's unset | 16:26 |
*** thorst has joined #openstack-nova | 16:26 | |
mriedem | oh | 16:26 |
*** mtanino has joined #openstack-nova | 16:26 | |
*** markus_z has quit IRC | 16:27 | |
*** ccard has joined #openstack-nova | 16:27 | |
*** heyongli has quit IRC | 16:29 | |
*** tpeoples has quit IRC | 16:29 | |
*** sahid has quit IRC | 16:29 | |
*** emagana has joined #openstack-nova | 16:29 | |
*** heyongli has joined #openstack-nova | 16:30 | |
*** pratikmallya has quit IRC | 16:30 | |
*** pratikmallya has joined #openstack-nova | 16:30 | |
*** Piet has quit IRC | 16:31 | |
*** klkumar has joined #openstack-nova | 16:31 | |
*** edtubill has quit IRC | 16:34 | |
*** pratikma_ has joined #openstack-nova | 16:34 | |
*** gszasz has joined #openstack-nova | 16:34 | |
mriedem | dansmith: http://paste.openstack.org/show/477872/ | 16:34 |
* dansmith doesn't know why people use paste.o.o | 16:34 | |
dansmith | so. slow. | 16:34 |
mriedem | ovo 0.12.0 | 16:35 |
dansmith | oh, right | 16:35 |
mriedem | are you using trunk? | 16:35 |
dansmith | no, you're right, I just picked lucky | 16:35 |
mriedem | ok | 16:35 |
dansmith | so what happens is it tries to summarize the objects in the list with their uuid field, if present | 16:35 |
mriedem | ah | 16:35 |
dansmith | so you're right, iterate yourself a new list and repr() that | 16:35 |
*** jaypipes has joined #openstack-nova | 16:36 | |
*** pratikmallya has quit IRC | 16:37 | |
mriedem | i suppose all_mappings.objects is out of the question | 16:37 |
mriedem | seems we could just do that for the object list repr | 16:37 |
mriedem | return repr(self.objects) | 16:38 |
dansmith | you can just do list(ll_mappings) | 16:38 |
*** edtubill has joined #openstack-nova | 16:38 | |
*** rdopiera has quit IRC | 16:38 | |
mriedem | aight | 16:38 |
dansmith | we can | 16:38 |
dansmith | I was just trying to be smart and summarize | 16:38 |
mriedem | repr(verbose=False) :) | 16:39 |
mriedem | not a thing, i know | 16:39 |
dansmith | heh | 16:39 |
*** heyongli has quit IRC | 16:39 | |
*** tpeoples has joined #openstack-nova | 16:39 | |
*** pratikma_ is now known as pratikmallya | 16:40 | |
*** heyongli has joined #openstack-nova | 16:40 | |
*** sneti has joined #openstack-nova | 16:40 | |
*** hemnafk is now known as hemna | 16:41 | |
mriedem | ok i see where the stringify happens https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/fields.py#L526 | 16:42 |
*** romainh has quit IRC | 16:42 | |
*** changbl has joined #openstack-nova | 16:43 | |
*** markvoelker has joined #openstack-nova | 16:45 | |
*** lsmola has quit IRC | 16:46 | |
*** mgoddard_ has joined #openstack-nova | 16:47 | |
*** njirap has joined #openstack-nova | 16:47 | |
*** aix has quit IRC | 16:48 | |
*** heyongli has quit IRC | 16:49 | |
*** mgoddard has quit IRC | 16:50 | |
*** heyongli has joined #openstack-nova | 16:50 | |
mriedem | dansmith: dumping the bdm list might not be helpful anyway, the boot index list is sorted | 16:55 |
mriedem | unless we dump both | 16:55 |
dansmith | mriedem: sure, but I assume checking the sorting isn't what you're going for.. if there are two with the same index, you want to see the two conflicts, right? | 16:56 |
dansmith | but regardless, if you think this is enough that's fine | 16:56 |
dansmith | was just trying to think ahead | 16:56 |
mriedem | right, and we can construct the boot index list and assume it's sorted from the bdm list in the logs i guess | 16:56 |
mriedem | so i will go with the bdm list | 16:56 |
openstackgerrit | Matt Riedemann proposed openstack/nova: Add debug logging for when boot sequence is invalid in _validate_bdm https://review.openstack.org/241270 | 16:57 |
*** edtubill has quit IRC | 16:59 | |
*** Murali_ has joined #openstack-nova | 16:59 | |
*** humble__ has quit IRC | 16:59 | |
*** su_zhang has joined #openstack-nova | 16:59 | |
*** heyongli has quit IRC | 17:00 | |
*** electrocucaracha has joined #openstack-nova | 17:00 | |
*** mgoddard_ has quit IRC | 17:00 | |
*** heyongli has joined #openstack-nova | 17:01 | |
*** thorst has quit IRC | 17:03 | |
*** thorst has joined #openstack-nova | 17:03 | |
*** jlanoux has quit IRC | 17:04 | |
*** vilobhmm11 has joined #openstack-nova | 17:05 | |
*** erlon has joined #openstack-nova | 17:05 | |
*** thorst has quit IRC | 17:08 | |
*** ssurana has joined #openstack-nova | 17:08 | |
*** subscope has quit IRC | 17:10 | |
*** heyongli has quit IRC | 17:10 | |
*** su_zhang has quit IRC | 17:10 | |
*** klkumar has quit IRC | 17:10 | |
sfinucan | dansmith: Did you see the discussion mriedem and I had about this patch yesterday? https://review.openstack.org/#/c/202647/9 | 17:10 |
*** heyongli has joined #openstack-nova | 17:11 | |
dansmith | sfinucan: apparently not | 17:11 |
sfinucan | Mind if I fill you in? :) | 17:12 |
dansmith | nope, go for it | 17:12 |
sfinucan | OK, so that review (and others) seems to be raising issues about undefined references to '_BaseInstance' | 17:14 |
sfinucan | even though your patch, which I've set as a dependency, has removed that | 17:14 |
mriedem | to be fair, it's only your changes that are hitting that issue (according to logstash) | 17:14 |
mriedem | it almost seems like the fetch isn't pulling down the dependency | 17:14 |
sfinucan | Yeah, but it's only my issues that depend on Dan's change | 17:14 |
dansmith | but my patch isn't hitting those, correct? | 17:15 |
*** stackdump has quit IRC | 17:15 | |
mriedem | right | 17:15 |
sfinucan | exactly | 17:15 |
sfinucan | Maybe I should just remove that dependency as I don't technically need it | 17:15 |
mriedem | i also did a git review on sfinucan's change and pull both down, tests passed | 17:15 |
mriedem | so not sure what's going on | 17:15 |
sfinucan | but then I'll have to add unused obj_relationship variables to be consistent | 17:16 |
dansmith | yeah, looks like the dep is correct to me | 17:16 |
dansmith | sfinucan: how about we just merge my thing? :) | 17:16 |
mriedem | alternatively you could try using Depends-On in the commit message | 17:16 |
dansmith | it was +2ed by johnthetubaguy previously just rebased | 17:16 |
dansmith | mriedem: yeah, good call | 17:16 |
sfinucan | Sure - give me core rights ;) | 17:16 |
sfinucan | (I kid) | 17:16 |
sfinucan | That's fine with me. Any ETA though? | 17:16 |
johnthetubaguy | can I help by re-applying my +2? | 17:17 |
*** mgoddard has joined #openstack-nova | 17:17 | |
mriedem | dansmith: so john +2ed with reservations it sounded like | 17:17 |
mriedem | yes | 17:17 |
mriedem | then i'll take a look at it | 17:17 |
dansmith | yeah, but I don't think they made any sense | 17:17 |
mriedem | ouch | 17:17 |
dansmith | I think he might be confused about where this starts and stops or something | 17:17 |
dansmith | because this is exactly like all our rpc bumps | 17:18 |
dansmith | in terms of the window | 17:18 |
dansmith | and has been open for longer than those normally are anyway | 17:18 |
*** edtubill has joined #openstack-nova | 17:18 | |
dansmith | johnthetubaguy: oh, I missed that you popped in.. what is your concern about the support window? | 17:19 |
mriedem | and this was the liberty change right? https://review.openstack.org/#/c/217819/ | 17:19 |
*** thorst has joined #openstack-nova | 17:19 | |
dansmith | johnthetubaguy: we were going to bump objects across liberty, which means dropping the old stuff now, right? | 17:19 |
vilobhmm11 | johnthetubaguy : ping | 17:19 |
dansmith | mriedem: aye | 17:19 |
johnthetubaguy | been around all day, but busy interviewing | 17:19 |
mriedem | leaving rax huh | 17:20 |
mriedem | :P | 17:20 |
dansmith | heh | 17:20 |
johnthetubaguy | lol, it was the other way around | 17:20 |
mriedem | twitter tells me that ibm is hiring | 17:20 |
mriedem | oh i see | 17:20 |
*** heyongli has quit IRC | 17:20 | |
johnthetubaguy | I think I was worrying about the tag, and loosing features, but I was probably overthinking it | 17:20 |
dansmith | johnthetubaguy: what tag? | 17:21 |
johnthetubaguy | so the deprecation tag | 17:21 |
johnthetubaguy | although the context was those deploying off truck | 17:21 |
*** heyongli has joined #openstack-nova | 17:21 | |
johnthetubaguy | we need them to cross one edge, then cross another | 17:21 |
johnthetubaguy | we could just define that to the the release, or we define a time window | 17:22 |
dansmith | johnthetubaguy: are you talking about standard-deprecation or UpgradeImpact? | 17:22 |
johnthetubaguy | either, I think we are good now | 17:22 |
johnthetubaguy | dansmith: sorry, bad mutli-tasking, I think thats standard-deprecation | 17:22 |
mriedem | so mitaka won't support kilo computes, but i'm not sure we ever claimed n-2 support did we? | 17:22 |
dansmith | johnthetubaguy: this doesn't affect features, so I'm not sure how that has any impact here | 17:22 |
*** ctrath has quit IRC | 17:23 | |
*** thorst has quit IRC | 17:23 | |
mriedem | we have a wiki for the standard rpc version bump stuff right? | 17:24 |
*** thorst has joined #openstack-nova | 17:24 | |
*** yassine has quit IRC | 17:24 | |
dansmith | mriedem: yeah, and this follows the same model | 17:24 |
mriedem | https://wiki.openstack.org/wiki/RpcMajorVersionUpdates | 17:25 |
dansmith | yep | 17:25 |
mriedem | "For example, support for a new API version is added just before the release of Icehouse and support for the old version is dropped once Juno development opens." | 17:25 |
mriedem | so we added instance v2 in liberty, we drop v1 in mitaka | 17:25 |
dansmith | mriedem: johnthetubaguy: I should put UpgradeImpact on this patch to make sure CDers know they need to have rolled past the v2 patch | 17:25 |
dansmith | but otherwise I think we're good | 17:25 |
johnthetubaguy | dansmith: I was thinking more about the time frame where you need to upgrade from, incase you end up hitting instance 1.x -> 2.x without the bit were they both work | 17:25 |
*** alexpilotti has quit IRC | 17:25 | |
johnthetubaguy | dansmith: sorry, yeah, I think thats the bit we need | 17:26 |
johnthetubaguy | dansmith: that should do it | 17:26 |
dansmith | johnthetubaguy: they have both worked for at least a month now, which is longer than most RPC bumps :) | 17:26 |
johnthetubaguy | dansmith: +1 | 17:26 |
*** pratikmallya has quit IRC | 17:26 | |
johnthetubaguy | dansmith: in summary, I think I was just overthinking it before | 17:27 |
mriedem | yeah upgrade impact is needed on the drop change per the wiki | 17:28 |
*** emagana has quit IRC | 17:28 | |
openstackgerrit | Dan Smith proposed openstack/nova: Drop Instance v1.x support https://review.openstack.org/220690 | 17:28 |
dansmith | johnthetubaguy: mriedem ^ | 17:28 |
vilobhmm11 | johnthetubaguy : wanted to talk regarding https://review.openstack.org/#/c/208078/5 ; you have some time ? | 17:29 |
dansmith | this one was DNM for a long time, so I just never re-updated the commit message I guess | 17:29 |
vilobhmm11 | since you mentioned we don;t need a spec for this problem | 17:29 |
*** thorst has quit IRC | 17:29 | |
*** pratikmallya has joined #openstack-nova | 17:29 | |
*** klkumar has joined #openstack-nova | 17:29 | |
*** heyongli has quit IRC | 17:30 | |
*** heyongli has joined #openstack-nova | 17:31 | |
johnthetubaguy | vilobhmm11: I am a bit distracted right now, but I think we need to get that blueprint on the blueprint review list | 17:31 |
dansmith | johnthetubaguy: I think you were right, no spec or bp for this | 17:32 |
dansmith | it's just a bug | 17:32 |
dansmith | we definitely do not want an rpc call | 17:32 |
dansmith | vilobhmm11: just check for storage before starting the snapshot on the compute manager side | 17:32 |
johnthetubaguy | dansmith: cool, lets drop the -2 and drop the BP | 17:33 |
dansmith | vilobhmm11: if not enough storage instance goes to error state like any other failed operation | 17:33 |
openstackgerrit | John Garbutt proposed openstack/nova-specs: Snapshot failure makes instance unusable https://review.openstack.org/208078 | 17:33 |
dansmith | johnthetubaguy: drop the -2? you mean abandon the spec, right? | 17:33 |
*** ctrath has joined #openstack-nova | 17:33 | |
*** gszasz has quit IRC | 17:33 | |
*** unicell has quit IRC | 17:34 | |
johnthetubaguy | dansmith: bummer, yes | 17:34 |
mriedem | done | 17:35 |
johnthetubaguy | mriedem: ah, yeah, thanks | 17:35 |
vilobhmm11 | johnthetubaguy, dansmith : the only reason why i proposed for extra rpc was the snapshot location mount might be different from instance dir mount in which case the storage computation will be different ; the current rpc checks for the space under $instances_path but if snapshots_directory = $instances_path/snapshots is diff say /var/snap then we need a seperate rpc toc ompute space for it… | 17:36 |
*** ctrath has quit IRC | 17:36 | |
mriedem | dansmith: humor me on an upgrade question per https://review.openstack.org/#/c/217819/ | 17:36 |
*** ihrachys has quit IRC | 17:36 | |
dansmith | vilobhmm11: if you're on the compute node you don't need an RPC though | 17:36 |
mriedem | dansmith: the "Note that since services like api and conductor will be sending v2 objects to older computes," part is just refering to api/conductor being at liberty level, right | 17:36 |
vilobhmm11 | johnthetubaguy, dansmith : thanks for your input ! ok makes sense | 17:36 |
dansmith | mriedem: yep | 17:37 |
mriedem | b/c with that change all objects.Instance are now 2.0 unless we have to compat to a kilo compute sending an objects.Instance 1.x | 17:37 |
dansmith | yes | 17:37 |
mriedem | k | 17:37 |
mriedem | good thing i read and retained at least 20% of your blog series | 17:38 |
dansmith | heh | 17:38 |
*** ccarmack has quit IRC | 17:38 | |
mriedem | do we by chance explode anywhere if i have a < kilo compute trying to talk to liberty? | 17:38 |
vilobhmm11 | dansmith : sure..I understand that..my concern was mostly related to $instances_path $snapshots_directory being different..but hopefully the approach you suggested should take care of it…depending on what is under consideration ( instance_path/snapshot_dir) | 17:38 |
vilobhmm11 | thanks! | 17:38 |
dansmith | mriedem: no, but we did get that check in recently, so going forward we'll have those protections | 17:39 |
dansmith | mriedem: which was this: https://review.openstack.org/#/c/229049/ | 17:40 |
*** ctrath has joined #openstack-nova | 17:40 | |
*** heyongli has quit IRC | 17:41 | |
*** markmc has quit IRC | 17:41 | |
*** davideagnello has joined #openstack-nova | 17:41 | |
*** heyongli has joined #openstack-nova | 17:42 | |
*** ccarmack has joined #openstack-nova | 17:43 | |
*** njirap has quit IRC | 17:45 | |
*** edtubill has quit IRC | 17:45 | |
mriedem | uh oh | 17:46 |
mriedem | "Enforce that we are not older that the minimum version" | 17:46 |
mriedem | bug report on the typo there | 17:46 |
*** tonytan4ever has quit IRC | 17:48 | |
dansmith | mriedem: sfinucan I'm now hitting that _baseinstance thing on my rebased patch | 17:50 |
dansmith | which I think is related to something else I merged to fix a thing, which needs cleaning up in this now | 17:50 |
mriedem | yeah | 17:50 |
mriedem | self.assertIsInstance(actual_inst, instance._BaseInstance) | 17:50 |
mriedem | that's all over nova.tests.unit.objects.test_instance | 17:51 |
dansmith | yeah | 17:51 |
*** heyongli has quit IRC | 17:51 | |
openstackgerrit | Gábor Antal proposed openstack/nova: Check prefix with startswith() instead of slicing https://review.openstack.org/234170 | 17:51 |
*** heyongli has joined #openstack-nova | 17:52 | |
*** vilobhmm11 has quit IRC | 17:52 | |
openstackgerrit | Dan Smith proposed openstack/nova: Drop Instance v1.x support https://review.openstack.org/220690 | 17:54 |
dansmith | mriedem: johnthetubaguy: fixed ^ .. just a unit test change for that changed class name | 17:54 |
mriedem | done | 17:55 |
*** thorst has joined #openstack-nova | 17:55 | |
*** ildikov has quit IRC | 17:55 | |
dansmith | thanks | 17:57 |
mriedem | i like TestServiceVersion | 17:57 |
mriedem | was just reading back over https://github.com/openstack/nova/commit/38601b0aff01f953b8e95d817747594d2018555f | 17:57 |
mriedem | glad we have a test that is tracking the service version history since it's in 2 places now | 17:57 |
*** klkumar has quit IRC | 17:58 | |
dansmith | mriedem: two places? | 17:58 |
dansmith | the SERVICE_VERSION history is not equal to the version history for the Service object | 17:58 |
mriedem | well, nova.compute.manager / rpcapi, and now nova.objects.service | 17:58 |
dansmith | ah, I see what you mean | 17:59 |
mriedem | i know | 17:59 |
mriedem | i saw we had compute_rpc 4.5 in service history and thought, great, now we have to track in two places, i hope we have an automated check for that | 17:59 |
mriedem | and blamo! | 17:59 |
dansmith | :) | 17:59 |
dansmith | mriedem: did you see this? https://review.openstack.org/#/c/233289/ | 17:59 |
dansmith | that's major awesome, IMHO | 17:59 |
dansmith | speaking of that, sdague: when are you thinking we'll swap to the multinode partial job? | 18:00 |
*** derekh has quit IRC | 18:00 | |
mriedem | "we can always set this!" | 18:00 |
dansmith | sdague: maybe thursday so we can watch it on friday? | 18:00 |
mriedem | like, omg! | 18:00 |
mriedem | that is nice | 18:00 |
mriedem | i think i saw talk of it in passing | 18:00 |
dansmith | I need to figure out a sighup handler for that | 18:01 |
*** heyongli has quit IRC | 18:01 | |
mriedem | was looking at the dependent nova change that requires nova-compute as the name | 18:02 |
*** su_zhang has joined #openstack-nova | 18:02 | |
*** heyongli has joined #openstack-nova | 18:02 | |
mriedem | and that it handles other names, which is i think a way that some people run multi-hypervisor envs | 18:02 |
*** ctrath1 has joined #openstack-nova | 18:04 | |
*** ctrath has quit IRC | 18:04 | |
*** alex_klimov has quit IRC | 18:05 | |
*** su_zhang has quit IRC | 18:07 | |
*** tonytan4ever has joined #openstack-nova | 18:07 | |
*** salv-orl_ has joined #openstack-nova | 18:07 | |
*** mriedem has quit IRC | 18:09 | |
edleafe | curl \ | 18:09 |
edleafe | --data-urlencode sig="`\ | 18:09 |
edleafe | geez | 18:09 |
*** salv-orlando has quit IRC | 18:09 | |
*** ccarmack has quit IRC | 18:10 | |
*** eglynn__ has quit IRC | 18:11 | |
*** ZZelle_ has joined #openstack-nova | 18:11 | |
*** su_zhang has joined #openstack-nova | 18:11 | |
*** heyongli has quit IRC | 18:11 | |
*** heyongli has joined #openstack-nova | 18:12 | |
*** unicell has joined #openstack-nova | 18:16 | |
johnthetubaguy | dansmith: hey, welcome back by the way, how was the weekend in tokyo? | 18:17 |
dansmith | johnthetubaguy: slightly better than the rest of the week I suppose, but still rather miserable | 18:17 |
*** stackdump has joined #openstack-nova | 18:17 | |
dansmith | johnthetubaguy: I found a good gyoza place, so I at a lot of that :) | 18:17 |
dansmith | needless to say, we've already planned meals for the rest of the week to make up for the trip :) | 18:18 |
*** mmdurrant has joined #openstack-nova | 18:18 | |
*** ZZelle_ has quit IRC | 18:21 | |
*** otter768 has joined #openstack-nova | 18:21 | |
*** ZZelle_ has joined #openstack-nova | 18:22 | |
*** heyongli has quit IRC | 18:22 | |
*** heyongli has joined #openstack-nova | 18:23 | |
*** ZZelle_ has quit IRC | 18:23 | |
*** mriedem has joined #openstack-nova | 18:23 | |
johnthetubaguy | dansmith: good plan | 18:23 |
*** ccarmack has joined #openstack-nova | 18:23 | |
johnthetubaguy | dansmith: I would have liked a bit more time to explore some places | 18:23 |
*** ZZelle_ has joined #openstack-nova | 18:23 | |
dansmith | johnthetubaguy: well, we should have traded places then :) | 18:23 |
johnthetubaguy | dansmith: I accidentally tested that raw chicken was OK on the Friday night, that bit made me worried about the flight home, but turns out, it was fine | 18:24 |
dansmith | gross | 18:24 |
*** READ10 has quit IRC | 18:24 | |
dansmith | I think the japanese are just trying to keep me out... which is fine | 18:25 |
mriedem | ccarmack: you can ask browne your vmware questions if garyk isn't around | 18:25 |
*** otter768 has quit IRC | 18:26 | |
johnthetubaguy | dansmith: there was a big pot of marinade, raw stuff in, cook, dip back in, serve. Spotted that after we finished most of it, and I am fine, but I dunno, I am a bit sensitive about that stuff, tasted good | 18:26 |
johnthetubaguy | dansmith: heh | 18:26 |
dansmith | johnthetubaguy: ah, self-cooking? I did that with beef with good success | 18:26 |
johnthetubaguy | dansmith: ah, this was someone else cooking, I would have skipped the dip at the end myself | 18:27 |
dansmith | johnthetubaguy: okay wait, you said "raw chicken is okay" but it was cooked and by someone else? now I'm confused :) | 18:28 |
johnthetubaguy | dansmith: ah, it was the raw meat and cooked meat all dunked into the same pot of sauce that worried me | 18:28 |
dansmith | ah, I see | 18:28 |
dansmith | yeah, I like my stuff well cooked | 18:28 |
*** achanda has joined #openstack-nova | 18:28 | |
dansmith | taylor would have not liked that | 18:29 |
johnthetubaguy | yeah, I mean raw chicken was an option, so I guess it must be safe, but try tell my brain that | 18:29 |
*** angdraug has quit IRC | 18:30 | |
*** jichen has joined #openstack-nova | 18:30 | |
*** ZZelle_ has quit IRC | 18:31 | |
johnthetubaguy | dansmith: oh, in other news, I put the a quick draft of the priorities up: https://review.openstack.org/#/c/240959/ | 18:31 |
*** ZZelle_ has joined #openstack-nova | 18:31 | |
openstackgerrit | John Garbutt proposed openstack/nova-specs: Add Mitaka Priorities https://review.openstack.org/240959 | 18:31 |
*** ZZelle_ has quit IRC | 18:31 | |
dansmith | johnthetubaguy: cool | 18:32 |
*** heyongli has quit IRC | 18:32 | |
*** bauzas has quit IRC | 18:32 | |
*** heyongli has joined #openstack-nova | 18:33 | |
diana_clarke | mriedem: I'm not convinced that this should be filed under oslo (vs nova). https://bugs.launchpad.net/oslo.service/+bug/1510234 | 18:35 |
openstack | Launchpad bug 1510234 in oslo.service "Heartbeats stop when time is changed" [Undecided,Confirmed] | 18:35 |
*** rk4n has quit IRC | 18:35 | |
belliott | johnthetubaguy: yeah i never got sick either :) | 18:36 |
mriedem | diana_clarke: where does the fix go? | 18:36 |
diana_clarke | mriedem: But I can see how my initial description would lead you to think that. Do you mind if I pop it back to nova for now, hoping to catch the eye of someone on the Nova team with ideas. | 18:36 |
belliott | salmonella isn't ported to japan | 18:36 |
johnthetubaguy | belliott: :) | 18:36 |
diana_clarke | mriedem: There is no fix so far... | 18:36 |
dansmith | johnthetubaguy: is "prioritizing" proper spelling in the queen's english? | 18:37 |
*** bnemec has quit IRC | 18:37 | |
belliott | dansmith: i enjoyed the food, but i started dreaming about pizza | 18:38 |
dansmith | belliott: by week's end I was about to start gnawing on the tables | 18:38 |
*** ctrath1 has quit IRC | 18:38 | |
*** rlrossit has quit IRC | 18:38 | |
johnthetubaguy | dansmith: possibly... although I am really not the right person to ask | 18:39 |
mriedem | diana_clarke: harass harlowja until he fixes it :) | 18:39 |
diana_clarke | :) | 18:39 |
*** jistr has quit IRC | 18:39 | |
dansmith | johnthetubaguy: I know, joke.. one clarity comment | 18:39 |
johnthetubaguy | dansmith: heh | 18:40 |
diana_clarke | harlowja: If you have the time, I would love to hear any thoughts you have on the following issue: https://bugs.launchpad.net/oslo.service/+bug/1510234 Thanks! | 18:40 |
openstack | Launchpad bug 1510234 in oslo.service "Heartbeats stop when time is changed" [Undecided,Confirmed] | 18:40 |
diana_clarke | dansmith: Welcome back! You up for another round of reviews for the following patch? https://review.openstack.org/#/c/229964/ | 18:41 |
johnthetubaguy | mriedem: btw, are the priorities the ones you expected? | 18:41 |
*** bnemec has joined #openstack-nova | 18:41 | |
dansmith | diana_clarke: I'll let someone else hit that one | 18:41 |
dansmith | johnthetubaguy: other than that nit, I'm good to go | 18:42 |
dansmith | johnthetubaguy: did you want to collect a gaggle of core votes on that before we merge? | 18:42 |
*** heyongli has quit IRC | 18:42 | |
diana_clarke | dansmith: Okie dokie, thanks for other passes. #cheers | 18:42 |
dansmith | johnthetubaguy: if the non-present cores all agree, that's probably what you want | 18:42 |
*** ccarmack has quit IRC | 18:43 | |
dansmith | alaski: are you back full-time, minus poo and feedings? | 18:43 |
*** ctrath has joined #openstack-nova | 18:43 | |
alaski | dansmith: I am starting Thursday | 18:43 |
*** heyongli has joined #openstack-nova | 18:43 | |
dansmith | alaski: okay | 18:43 |
openstackgerrit | John Garbutt proposed openstack/nova-specs: Add Mitaka Priorities https://review.openstack.org/240959 | 18:44 |
johnthetubaguy | talking of feedings, I should go do some cooking | 18:44 |
*** rlrossit has joined #openstack-nova | 18:45 | |
*** mriedem has quit IRC | 18:45 | |
*** salv-orl_ has quit IRC | 18:46 | |
*** gonzalo2kx has joined #openstack-nova | 18:46 | |
*** bauzas has joined #openstack-nova | 18:46 | |
*** baoli_ has quit IRC | 18:46 | |
*** salv-orlando has joined #openstack-nova | 18:47 | |
*** ccarmack has joined #openstack-nova | 18:47 | |
*** Piet has joined #openstack-nova | 18:47 | |
*** jichen has quit IRC | 18:48 | |
*** pixelb has quit IRC | 18:48 | |
*** mriedem has joined #openstack-nova | 18:49 | |
*** vilobhmm11 has joined #openstack-nova | 18:51 | |
harlowja | diana_clarke will look at | 18:51 |
*** heyongli has quit IRC | 18:52 | |
harlowja | diana_clarke i think https://bugs.launchpad.net/oslo.service/+bug/1510234/comments/1 is what i've heard is a way to fix this, i thought victor stinner had an open eventlet bug to try to change that... | 18:53 |
openstack | Launchpad bug 1510234 in oslo.service "Heartbeats stop when time is changed" [Undecided,Confirmed] | 18:53 |
*** ZZelle_ has joined #openstack-nova | 18:53 | |
*** heyongli has joined #openstack-nova | 18:53 | |
harlowja | so u might want to poke him, he's usually on irc under name 'haypo' | 18:54 |
diana_clarke | harlowja: Yup, I got that tip from Victor but it doesn't fix the nova-conductor service for some reason. I'm not sure if there's an open eventlet bug for it as well, but he didn't mention it when I pinged him about this last week. That said, it was summit. | 18:54 |
harlowja | diana_clarke i think i've heard him say it was a eventlet bug or something he was fixing, can't quite remember | 18:55 |
*** thorst has quit IRC | 18:55 | |
harlowja | it was before the summit when he told me about that, so i might be forgetting it :-P | 18:55 |
harlowja | imho its really an eventlet one, not a oslo.service one... | 18:55 |
harlowja | and all that | 18:55 |
mriedem | do we care about centralized config options? https://review.openstack.org/#/c/227948/ | 18:55 |
mriedem | i don't really | 18:56 |
diana_clarke | harlowja: thanks! I'll see if I can find an open eventlet bug, and otherwise dig some more. | 18:56 |
harlowja | diana_clarke cools | 18:56 |
mriedem | i care about good help text for config options, but we don't need a spec or bp for that | 18:56 |
dansmith | mriedem: I care about them for the config generation reason | 18:58 |
*** ctrath has quit IRC | 18:59 | |
mriedem | for centralizing? | 18:59 |
mriedem | we already have config generation | 18:59 |
*** pixelb has joined #openstack-nova | 18:59 | |
*** gonzalo2kx has quit IRC | 19:00 | |
mriedem | http://docs.openstack.org/developer/nova/sample_config.html | 19:00 |
dansmith | mriedem: yeah, but it requires a full environment to do it | 19:00 |
mriedem | you mean for the dependent library options? | 19:01 |
*** thorst has joined #openstack-nova | 19:01 | |
dansmith | mriedem: the single act of consolidation seemed overwhelmingly popular at the meetup side, FWIW | 19:01 |
dansmith | I don't really care to seem them collected, but others do, so meh | 19:01 |
*** artom has joined #openstack-nova | 19:01 | |
mriedem | consolidation of the nova options in nova doesn't fix needing a venv with the oslo libs to pull their options into nova.conf.sample | 19:01 |
dansmith | correct, | 19:02 |
*** ctrath has joined #openstack-nova | 19:02 | |
dansmith | but it does fix needing an environment fat enough to import any file we have that has config options in it | 19:03 |
*** heyongli has quit IRC | 19:03 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: Add 'hw_cpu_threads_policy' to ImageMetaProps https://review.openstack.org/202647 | 19:03 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=separate' scheduling https://review.openstack.org/202652 | 19:03 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Make use of 'InstanceNUMACell.cpu_policy' field https://review.openstack.org/202653 | 19:03 |
openstackgerrit | Stephen Finucane proposed openstack/nova: trivial: Make use of 'CPUAllocation' enum values https://review.openstack.org/202654 | 19:03 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=isolate' scheduling https://review.openstack.org/202655 | 19:03 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Add 'cpu_policy' and 'cpu_threads_policy' fields https://review.openstack.org/202648 | 19:03 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=avoid' filtering https://review.openstack.org/202649 | 19:03 |
openstackgerrit | Stephen Finucane proposed openstack/nova: trivial: Add some logs to 'numa_topology_filter' https://review.openstack.org/202650 | 19:03 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Add 'hw:cpu_threads_policy=require' scheduling https://review.openstack.org/202651 | 19:03 |
*** ctrath1 has joined #openstack-nova | 19:03 | |
mriedem | alright, i yield, i probably just need to remove myself from that spec review | 19:03 |
*** heyongli has joined #openstack-nova | 19:04 | |
dansmith | I also think that better help text is good, and that making source files start with 500 lines of text is bad | 19:04 |
dansmith | so if we're going to do the former, I think we have to move them to retain sanity | 19:04 |
* bauzas waves back | 19:07 | |
*** ctrath has quit IRC | 19:07 | |
*** angdraug has joined #openstack-nova | 19:08 | |
*** Murali__ has joined #openstack-nova | 19:09 | |
*** stackdump has quit IRC | 19:10 | |
*** Murali_ has quit IRC | 19:11 | |
mriedem | cburgess: thanks for cleaning up https://review.openstack.org/#/c/188244/ | 19:11 |
*** heyongli has quit IRC | 19:13 | |
*** heyongli has joined #openstack-nova | 19:14 | |
*** e0ne has joined #openstack-nova | 19:14 | |
bauzas | mriedem: so back, digging into the cells job failure again | 19:15 |
bauzas | thanks for https://review.openstack.org/#/c/241270/3 | 19:15 |
mriedem | bauzas: yeah so i think we can drop the rc chnage | 19:16 |
mriedem | b/c this isn't failing often enough to need to skip it | 19:16 |
bauzas | mriedem: I actually provided the change for discussing it :) | 19:16 |
mriedem | orly | 19:16 |
mriedem | i actually thought this was blocking everything | 19:17 |
mriedem | when we were first looking i mean | 19:17 |
bauzas | mriedem: yup, I needed to see how many cells failures were there | 19:17 |
sfinucan | johnthetubaguy: you commented way back when that I didn't need to submit a spec for the CPU thread pinning changes (https://review.openstack.org/#/c/194221/) | 19:17 |
*** marzif has joined #openstack-nova | 19:17 | |
bauzas | mriedem: but for sure, I can abandon it | 19:17 |
sfinucan | Seeing as this feature is now being targeted for Mitaka, should I move the spec or just delete it? | 19:18 |
bauzas | graphite doesn't show me a bad behaviour for the cells job | 19:18 |
*** pixelb has quit IRC | 19:18 | |
bauzas | mriedem: http://goo.gl/xGnRW6 | 19:19 |
mriedem | yeah, i'd also like to hit the failures with the debug logging in place, | 19:19 |
mriedem | maybe we're doing something dumb | 19:19 |
sfinucan | edleafe: Are you here? | 19:19 |
*** alejandrito has quit IRC | 19:21 | |
*** thorst has quit IRC | 19:22 | |
*** thorst has joined #openstack-nova | 19:23 | |
*** heyongli has quit IRC | 19:23 | |
ccarmack | browne: are you there? | 19:24 |
*** heyongli has joined #openstack-nova | 19:24 | |
*** marzif is now known as daemontool | 19:25 | |
bauzas | mriedem: what I can't understand is why we have an exception given if boot_indexes is equal to [0] | 19:25 |
bauzas | mriedem: because the conditional shouldn't fail | 19:25 |
cburgess | mriedem: my pleasure | 19:27 |
*** salv-orlando has quit IRC | 19:30 | |
*** thorst has quit IRC | 19:30 | |
*** thorst has joined #openstack-nova | 19:31 | |
*** thorst has quit IRC | 19:31 | |
*** thorst has joined #openstack-nova | 19:32 | |
*** heyongli has quit IRC | 19:33 | |
*** heyongli has joined #openstack-nova | 19:34 | |
*** baoli has joined #openstack-nova | 19:35 | |
*** su_zhang has quit IRC | 19:39 | |
*** jerrygb has quit IRC | 19:39 | |
*** jerrygb has joined #openstack-nova | 19:40 | |
*** aysyd has quit IRC | 19:41 | |
mriedem | bauzas: yeah, that's what the debug logging is for | 19:42 |
*** aysyd has joined #openstack-nova | 19:42 | |
bauzas | mriedem: to be clear, the request body doesn't provide a volume request, just an image from a snapshot | 19:43 |
*** aysyd has quit IRC | 19:43 | |
*** heyongli has quit IRC | 19:44 | |
bauzas | mriedem: so the block_device_mapping attribute should be instancied by seeing the image metadata AFAICT | 19:44 |
*** heyongli has joined #openstack-nova | 19:44 | |
*** e0ne has quit IRC | 19:45 | |
*** jerrygb has quit IRC | 19:45 | |
mriedem | there is a block_device_mapping_v2 dict in the req body | 19:45 |
mriedem | unless i'm misunderstanding your point | 19:45 |
*** thorst has quit IRC | 19:45 | |
mriedem | http://logs.openstack.org/87/188487/39/check/gate-tempest-dsvm-cells/6a75b7f/console.html#_2015-11-03_14_23_00_145 | 19:46 |
*** thorst has joined #openstack-nova | 19:46 | |
*** pratikmallya has quit IRC | 19:46 | |
bauzas | mriedem: nope that's not the same request | 19:46 |
mriedem | oh maybe that's the first create server | 19:47 |
mriedem | yeah | 19:47 |
bauzas | mriedem: the issue is there https://github.com/openstack/tempest/blob/master/tempest/scenario/test_volume_boot_pattern.py#L181 | 19:47 |
bauzas | the body is Body: {"server": {"imageRef": "7d649ce7-8c34-4ab2-9aa9-8f28a93677ea", "flavorRef": "42", "name": "tempest-TestVolumeBootPatternV2-1285706979"}} | 19:47 |
*** hparekh has quit IRC | 19:47 | |
bauzas | so only an image ref | 19:47 |
*** armax has joined #openstack-nova | 19:48 | |
bauzas | mriedem: so bdm is instanciated by check_and_transform_bdms here | 19:49 |
*** armax has quit IRC | 19:49 | |
bauzas | https://github.com/openstack/nova/blob/master/nova/compute/api.py#L803-L804 | 19:50 |
*** thorst has quit IRC | 19:50 | |
*** smatzek has quit IRC | 19:50 | |
*** aysyd has joined #openstack-nova | 19:50 | |
*** aysyd has quit IRC | 19:50 | |
edleafe | sfinucan: I'm here | 19:51 |
sfinucan | edleafe: thought it might be easier discuss this here https://review.openstack.org/#/c/202654/ Gerrit's commenting system is rubbish | 19:52 |
sfinucan | Or maybe not. I don't know what the etiquette here is | 19:52 |
mriedem | bauzas: yeah, we just don't log anything up to that point | 19:53 |
*** markmc has joined #openstack-nova | 19:53 | |
edleafe | sfinucan: either is fine. Gerrit is better for async comments | 19:53 |
bauzas | mriedem: well, I'm looking at g-api.log to see the image metadata | 19:53 |
*** browne has quit IRC | 19:54 | |
*** rotbeard has quit IRC | 19:54 | |
edleafe | sfinucan: you will be inconsistent either way then | 19:54 |
*** heyongli has quit IRC | 19:54 | |
edleafe | sfinucan: think it's better to keep the number of "magic" values in tests to a minimum | 19:54 |
edleafe | sfinucan: for the same reason that using the constants in the code is clearer than using the literals | 19:55 |
*** eglynn__ has joined #openstack-nova | 19:55 | |
*** hparekh has joined #openstack-nova | 19:55 | |
*** heyongli has joined #openstack-nova | 19:55 | |
*** achanda has quit IRC | 19:55 | |
sfinucan | edleafe: Yup, I agree. Like I said though, it seems the majority of tests go with the magic values approach. I didn't know if there was a reason | 19:55 |
sfinucan | Maybe it implicitly tests the constants value or something, idk | 19:56 |
edleafe | sfinucan: I shudder at the sheer amount of magic values in our tests | 19:56 |
bauzas | er, g-api doesn't provide neither the request body nor the returned data | 19:56 |
sfinucan | edleafe: Yup, it seems tests are held to a lower standard than "real code" | 19:56 |
mriedem | bauzas: tempest logs will | 19:57 |
mriedem | i'm checking there | 19:57 |
sfinucan | OK, I'm happy to change so long as I don't get caught to revert it | 19:57 |
*** jerrygb has joined #openstack-nova | 19:57 | |
mriedem | http://logs.openstack.org/87/188487/39/check/gate-tempest-dsvm-cells/6a75b7f/logs/tempest.txt.gz#_2015-11-03_14_18_29_118 | 19:57 |
mriedem | bauzas: ^ | 19:57 |
*** mgoddard has quit IRC | 19:58 | |
mriedem | bauzas: there are 2 bdms in the image metadata | 19:58 |
mriedem | duplicates | 19:58 |
*** mgoddard has joined #openstack-nova | 19:58 | |
mriedem | so 2 boot_index=0 bdms | 19:58 |
*** aysyd has joined #openstack-nova | 19:59 | |
bauzas | right, that's what I'm seeing | 19:59 |
* alaski waves | 19:59 | |
mriedem | o/ | 20:00 |
bauzas | \o/ | 20:00 |
mriedem | howdy stranger | 20:00 |
* mriedem does arnold voice from total recall | 20:00 | |
alaski | heh | 20:00 |
mriedem | https://www.youtube.com/watch?v=2ofcgepilzg | 20:00 |
mriedem | ha | 20:00 |
alaski | if y'all are discussing what I think you're discussing it's a bad interaction between cells and how bdms are created/updated | 20:00 |
mriedem | so we race to update it and get duplicate entries | 20:01 |
mriedem | i seem to remember you and ndipanov talking about that | 20:01 |
alaski | yeah | 20:02 |
alaski | the root problem is that there's just an update or create command, not a specific update | 20:02 |
*** dustins has quit IRC | 20:02 | |
mriedem | was there another bug tracking that? | 20:02 |
alaski | and no uniqueness enforcement of device name, which is what Nova uses as a key for that db entry | 20:02 |
alaski | there should be, but I'm not actually sure | 20:03 |
*** ctrath1 has quit IRC | 20:03 | |
bauzas | so it's when snapshotting ? | 20:03 |
alaski | bauzas: I think the bug happens generally, it's just noticed on this test that does snapshotting | 20:03 |
bauzas | alaski: okay, because I was looking at https://github.com/openstack/tempest/blob/master/tempest/scenario/test_volume_boot_pattern.py#L181 which was failing | 20:04 |
*** heyongli has quit IRC | 20:04 | |
mriedem | b/c the image meta has duplicated bdm info | 20:04 |
bauzas | right, which was created by the snapshot | 20:04 |
alaski | mriedem: I can't find an open bug that I've contributed to about this | 20:05 |
*** heyongli has joined #openstack-nova | 20:05 | |
mriedem | "the root problem is that there's just an update or create command, not a specific update" - where is that? | 20:05 |
alaski | bauzas: the snapshot exposes it because it writes the duplicate info. but the duplication happens without a snapshot as far as I can tell | 20:05 |
*** thorst has joined #openstack-nova | 20:05 | |
bauzas | alaski: I see | 20:06 |
bauzas | alaski: so that's a race | 20:06 |
mriedem | yeah it has to be a race b/c we don't fail 100% on this | 20:06 |
bauzas | most of the time, it works | 20:06 |
alaski | mriedem: bdm_update_or_create_at_top in cells/messaging.py | 20:07 |
bauzas | oh man, looks like a analog problem to the instance save | 20:07 |
alaski | there are some safeguards in place to help prevent this, but something is being missed | 20:07 |
alaski | what complicates this further is that I think the bdm can exist in the api first, or the cell. But I hadn't finished tracking down all origin points of a bdm | 20:08 |
alaski | because I would like the cell to just say create, or update. But I'm not sure yet how we can know when to do which | 20:09 |
openstackgerrit | Stephen Finucane proposed openstack/nova-specs: Add virt-driver CPU thread pinning https://review.openstack.org/241355 | 20:09 |
*** aysyd has quit IRC | 20:09 | |
mriedem | oops, cells does it again | 20:09 |
alaski | did you just channel britney spears? | 20:09 |
mriedem | yes | 20:09 |
mriedem | i would have linked youtube but too many ads | 20:10 |
*** aysyd has joined #openstack-nova | 20:10 | |
*** ctrath has joined #openstack-nova | 20:12 | |
alaski | I think there's two parts to a solution. add a uniqueness constraint to bdms so we can't create dupes, though it probably shouldn't be device_name which is the current likely candidate. and figure out how to have cells send create, or update, not create_or_update. | 20:12 |
mriedem | ok so i see where bdm_update_or_create_at_top checks for the dev_name and volume_id | 20:12 |
*** baoli has quit IRC | 20:12 | |
mriedem | why can't we call block_device_mapping_get_all_by_instance before block_device_mapping_update_or_create ? | 20:13 |
*** heyongli has quit IRC | 20:14 | |
bauzas | so I'm trying to understand the race | 20:15 |
*** pratikmallya has joined #openstack-nova | 20:15 | |
alaski | mriedem: in the cell, or the api? | 20:15 |
mriedem | in cells/messaging.bdm_update_or_create_at_top | 20:15 |
mriedem | where create is NOne | 20:15 |
*** heyongli has joined #openstack-nova | 20:15 | |
mriedem | "We allow empty device names so they will be set later by the manager." - so much for a unique constraint on device_name, unless you have other columns in that constraint | 20:16 |
*** rfolco has quit IRC | 20:18 | |
alaski | mriedem: so that might work, but I've been away from this for too long to remember the exact details and if that would help. really I would start with additional logging to figure out which of the multiple cases in bdm_update_or_create_at_top are problematic | 20:19 |
*** timello_ has quit IRC | 20:19 | |
*** egarbade- has quit IRC | 20:19 | |
*** ekhugen has quit IRC | 20:19 | |
*** thorst has quit IRC | 20:19 | |
alaski | mriedem: right, device name is problematic for uniqueness. It's really problematic that it's how we refer to bdms rather than a uuid of some sort | 20:19 |
mriedem | we have an index on bdm device_name and instance_uuid, maybe that's the UC? | 20:20 |
*** thorst has joined #openstack-nova | 20:20 | |
mriedem | i can add some logging to see where we are in bdm_update_or_create_at_top | 20:20 |
mriedem | so we can maybe walk back a failure | 20:20 |
*** egarbade- has joined #openstack-nova | 20:20 | |
bauzas | alaski: I wonder how it can end up having duplicates in a racy way | 20:20 |
*** ekhugen has joined #openstack-nova | 20:21 | |
alaski | bauzas: I'm not sure of the exact mechanism. part of why I want a unique constraint is that it would expose the race by failing | 20:22 |
bauzas | alaski: I understand your point | 20:22 |
*** timello_ has joined #openstack-nova | 20:22 | |
mriedem | if this failed more often, we could just push a DNM patch that creates a UC and recheck it until we hit the duplicate create failure | 20:23 |
alaski | bauzas: my best reasoning at this point is that multiple update_or_create messages are coming in quick succession and therefore both leading to creates | 20:23 |
mriedem | bauzas: nova.compute.api.API._create_block_device_mapping calls bdm.update_or_create | 20:23 |
*** thorst has quit IRC | 20:24 | |
*** heyongli has quit IRC | 20:25 | |
*** heyongli has joined #openstack-nova | 20:25 | |
*** tonytan4ever has quit IRC | 20:26 | |
bauzas | alaski: I see, so that the 2nd create_or_update would check before the first one really updates the DB | 20:26 |
bauzas | alaski: if so, not sure if an UC could help, right? | 20:26 |
bauzas | oh, it would fail tho | 20:26 |
bauzas | nvm | 20:26 |
alaski | yeah | 20:27 |
*** thorst has joined #openstack-nova | 20:27 | |
*** ctrath has quit IRC | 20:27 | |
bauzas | what's pretty interesting with http://logs.openstack.org/87/188487/39/check/gate-tempest-dsvm-cells/6a75b7f/logs/tempest.txt.gz#_2015-11-03_14_18_29_118 is that the 2 BDMs have different snapshot ids | 20:27 |
mriedem | would it help if in nova.compute.api.create_db_entry_for_new_instance, if num_instances == 1 we just do bdm.create instead of update_or_create? | 20:28 |
mriedem | that papers over the race probably, but is also probably a bigger use case | 20:28 |
mriedem | seems that update_or_create is for multi instance boot | 20:28 |
mriedem | bauzas: heh, https://review.openstack.org/#/c/241270/ failed on the ebs bug | 20:30 |
mriedem | so we at least have that now | 20:30 |
mriedem | http://logs.openstack.org/70/241270/3/check/gate-tempest-dsvm-cells/747b65a/logs/screen-n-api.txt.gz#_2015-11-03_19_36_12_175 | 20:30 |
mriedem | dansmith: ^ | 20:31 |
dansmith | cool | 20:31 |
bauzas | mriedem: well, it's consistent with what we found | 20:31 |
bauzas | mriedem: ie. we have 2 BDM objects | 20:31 |
mriedem | i'll push up a logging patch for cells.messaging.bdm_update_or_create_at_top on top of that change in a series | 20:31 |
mriedem | yup | 20:31 |
*** alex_klimov has joined #openstack-nova | 20:32 | |
mriedem | do objects have __eq__ :) we could just set(all_mappings) and voila! | 20:32 |
*** erhudy has joined #openstack-nova | 20:32 | |
bauzas | there is a base method for that obj_equal_prims | 20:32 |
bauzas | IIRC | 20:32 |
bauzas | which verifies 2 primitives | 20:33 |
*** ctrath has joined #openstack-nova | 20:33 | |
*** heyongli has quit IRC | 20:35 | |
mriedem | alaski: why does cells bdm_update_or_create_at_top remove the bdm id? | 20:35 |
mriedem | items_to_remove = ['id'] | 20:35 |
dansmith | right, but no __eq__ for a reasn | 20:35 |
*** heyongli has joined #openstack-nova | 20:36 | |
mriedem | i was joking anyway | 20:37 |
mriedem | hmm | 20:37 |
mriedem | vol_id = bdm['volume_id'] | 20:37 |
mriedem | in this test we have a snapshot_id, not a volume_id | 20:37 |
alaski | mriedem: there's no guarantee that the 'id' in each db will match. and trying to set it could lead to a colision | 20:37 |
mriedem | oh right | 20:38 |
mriedem | oh cells | 20:38 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Ensure 'CONF' settings are loaded dynamically https://review.openstack.org/241361 | 20:38 |
mriedem | ok, so i see one problem in the cells code | 20:39 |
mriedem | easy fix | 20:39 |
alaski | I would say that I don't envy someone trying to run cells in production, except that I'm one of them | 20:39 |
mriedem | https://github.com/openstack/nova/blob/master/nova/cells/messaging.py#L1176 | 20:40 |
mriedem | "Search for it.. try matching either # device_name or volume_id." | 20:40 |
mriedem | volume_id is null | 20:40 |
mriedem | http://paste.openstack.org/show/477896/ | 20:40 |
sfinucan | dansmith: Could I get your input on the following change? mriedem had some concerns that you're best positioned to address https://review.openstack.org/#/c/237762/ | 20:40 |
mriedem | so that filtering is busted | 20:40 |
mriedem | we have a snapshot_id | 20:40 |
mriedem | s owe should filter on that | 20:40 |
mriedem | i'll push a change | 20:40 |
dansmith | sfinucan: oh, I commented on that this morning and then forgot to hit the submit button | 20:41 |
sfinucan | :) | 20:41 |
dansmith | sfinucan: check now | 20:41 |
mriedem | we could also have an image_id in the bdm | 20:42 |
alaski | mriedem: nice catch | 20:42 |
mriedem | \o/ | 20:42 |
mriedem | we might not even be getting that far | 20:42 |
mriedem | as far as i can tell | 20:42 |
mriedem | so i'll push the loging changes first | 20:42 |
*** achanda has joined #openstack-nova | 20:45 | |
*** heyongli has quit IRC | 20:45 | |
*** dustins has joined #openstack-nova | 20:45 | |
sfinucan | dansmith: mriedem was concerned that there might be instances hanging around with 'always' stored in the database | 20:45 |
dansmith | sfinucan: did you read my comment? | 20:46 |
*** heyongli has joined #openstack-nova | 20:46 | |
dansmith | sfinucan: it seemed like we are treating non-NULL as true, so it probably doesn't matter what is stored in the DB | 20:46 |
sfinucan | dansmith: I did | 20:46 |
sfinucan | dansmith: I think I may be mixing this issue up with an issue from the subsequent patch | 20:47 |
sfinucan | which removes that non-NULL == true nonsense :) | 20:47 |
mriedem | yeah, the issue is in the 2nd chnage | 20:48 |
mriedem | that builds on this | 20:48 |
sfinucan | so for that change, I don't think there's an issue | 20:48 |
mriedem | https://review.openstack.org/#/c/92899/11/nova/virt/configdrive.py | 20:48 |
sfinucan | we never actually stored 'always' in the database | 20:48 |
sfinucan | or any value from 'force_config_drive', actually | 20:48 |
sfinucan | that's the whole point of this bug https://bugs.launchpad.net/nova/+bug/1303714 | 20:49 |
openstack | Launchpad bug 1303714 in OpenStack Compute (nova) "force_config_drive=True don't go to db" [Wishlist,In progress] - Assigned to Stephen Finucane (sfinucan) | 20:49 |
dansmith | okay let me look t the second one | 20:49 |
openstackgerrit | Chet Burgess proposed openstack/nova-specs: RBD instance snapshots https://review.openstack.org/188244 | 20:50 |
cburgess | mriedem: I fixed the minor nits on that RBD spec if you want to +2 it again... :) | 20:50 |
mriedem | cburgess: done | 20:52 |
vilobhmm11 | dansmith : qq | 20:52 |
vilobhmm11 | compute_nodes['free_disk_gb'] and compute_nodes['disk_available_least'] is coming -ve irrespective of enough available space on the compute….is there a better value to rely on which the resource tracker might update reflecting current state of the hypervisor/compute | 20:52 |
dansmith | vilobhmm11: ask jaypipes or bauzas | 20:53 |
vilobhmm11 | bauzas , jaypipes : ^^ | 20:53 |
bauzas | me not understanding | 20:53 |
*** mrkz has quit IRC | 20:54 | |
bauzas | vilobhmm11: you mean that the semantics of those fields are pretty unclear? | 20:54 |
*** pixelb has joined #openstack-nova | 20:54 | |
*** boris-42 has joined #openstack-nova | 20:55 | |
*** heyongli has quit IRC | 20:55 | |
vilobhmm11 | bauzas : please check http://paste.openstack.org/show/477899/ | 20:55 |
dansmith | sfinucan: I'm not sure I can validate your use of bool_from_string() | 20:56 |
dansmith | sfinucan: since it's not clear to me we're always storing bool-like things there.. '' is falsey, so why not just use that? | 20:56 |
vilobhmm11 | her even thought 1.2 TB is availabel for /home the compute_nodes['free_disk_gb'] and compute_nodes['disk_available_least'] is coming -ve | 20:56 |
vilobhmm11 | why so ? | 20:56 |
*** heyongli has joined #openstack-nova | 20:56 | |
sfinucan | dansmith: Yeah, I figured that would be a tricky point | 20:56 |
jaypipes | vilobhmm11: what does "is coming -ve" mean? | 20:57 |
sfinucan | The function is being used in bool-like manner, so I thought it made sense to return a bool-like value | 20:57 |
sfinucan | It's a semantical (is that a word?) thing. Maybe it's not a practical thing, however. | 20:57 |
vilobhmm11 | jaypipes : shows negative values if you check this http://paste.openstack.org/show/477899/ | 20:57 |
jaypipes | vilobhmm11: "is coming -ve" means "shows negative values"? | 20:58 |
*** aysyd has quit IRC | 20:58 | |
dansmith | sfinucan: bool('') will return False | 20:58 |
vilobhmm11 | jaypipes : yes…sorry if it was not clear | 20:58 |
jaypipes | vilobhmm11: I guess I'm just an old fart that doesn't know you young folks' hip speak :) | 20:59 |
mriedem | bool_from_string() can enforce strict usage | 20:59 |
sfinucan | Yes, but bool('False') will return true | 20:59 |
vilobhmm11 | jaypipes : :P | 20:59 |
openstackgerrit | Matt Riedemann proposed openstack/nova: cells: add debug logging to bdm_update_or_create_at_top https://review.openstack.org/241366 | 20:59 |
sfinucan | mriedem: I avoided using that to allow the '' corner case :) | 20:59 |
jaypipes | vilobhmm11: what is your disk_allocation_ratio on that compute node? | 20:59 |
dansmith | sfinucan: are we actually storing 'False' in there? because other code seems to assume anything in that column means True | 21:00 |
dansmith | sfinucan: I gotta go to a meeting now | 21:00 |
sfinucan | dansmith: No problem | 21:00 |
sfinucan | And I'm attempting to do so, yes | 21:00 |
*** ctrath has quit IRC | 21:00 | |
sfinucan | Don't recall if it's in that patch or a follow up one ... | 21:00 |
vilobhmm11 | jaypiepes : 1.0 | 21:00 |
sfinucan | I'll see what else I can come up with | 21:00 |
vilobhmm11 | jaypipes : ^^ | 21:00 |
mriedem | alaski: would you mind taking a run through this debug series https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/1489581,n,z | 21:00 |
jaypipes | vilobhmm11: you using shared storage by any chance? | 21:01 |
vilobhmm11 | jaypipes : nope its local store..everything on Hypervisor | 21:01 |
*** su_zhang has joined #openstack-nova | 21:02 | |
alaski | mriedem: sure | 21:02 |
jaypipes | vilobhmm11: heh, weird... | 21:02 |
mriedem | alaski: btw the bottom one failed b/c of the bug we're trying to debug | 21:03 |
*** tonytan4ever has joined #openstack-nova | 21:03 | |
cburgess | Who are the spec core reviewers? | 21:03 |
jaypipes | cburgess: Ditka. And God. | 21:03 |
bauzas | vilobhmm11: sorry got distracted | 21:04 |
cburgess | I suspect thats a joke that I don't get. | 21:04 |
jaypipes | vilobhmm11: ah, I think I see now.. | 21:04 |
vilobhmm11 | jaypipes : question is simple if I have 58% capacity available in /home then why are negative values being reported by resource tracker => compute nodes under 'free_disk_gb' and eventually to 'disk_available_least' as disk_available_least = free_disk_gb - disk_overcommit_size | 21:04 |
vilobhmm11 | disk_overcommit_size = virtual size of disks of all instance instance - used disk size of all instances | 21:04 |
bauzas | vilobhmm11: so disk_available_least is reported by the driver as a sanity check for making sure that the nova db is consistent with the physical disk | 21:05 |
*** ctrath has joined #openstack-nova | 21:05 | |
jaypipes | vilobhmm11: so it seems that local_gb is being set from your /home mount, weirdly... and the free_disk_gb is being calculated by adding all the used values from all your mounts... really odd. | 21:05 |
*** heyongli has quit IRC | 21:06 | |
jaypipes | sorry, meant that local_gb_used is being calculated... | 21:06 |
jaypipes | vilobhmm11: ^ | 21:06 |
bauzas | jaypipes: vilobhmm11: that really depends on the driver | 21:06 |
vilobhmm11 | jaypipes : let me do the math please hold on… | 21:06 |
bauzas | disk_avail_least is directly updated from what the virt driver returns | 21:06 |
*** heyongli has joined #openstack-nova | 21:06 | |
*** su_zhang has quit IRC | 21:07 | |
mriedem | jaypipes: trick question, ditka is god | 21:07 |
mriedem | cburgess: these are the palms you need to grease https://review.openstack.org/#/admin/groups/302,members | 21:07 |
cburgess | mriedem Was trying to figure out how to get that out of gerit. | 21:08 |
cburgess | Thanks | 21:08 |
bauzas | vilobhmm11: jaypipes: while free_disk_gb is calculated from the diff (total - used) in RT | 21:08 |
mriedem | cburgess: the filter box here https://review.openstack.org/#/admin/groups/ | 21:08 |
cburgess | Cool | 21:08 |
*** mrkz has joined #openstack-nova | 21:08 | |
*** ZZelle__ has joined #openstack-nova | 21:09 | |
cburgess | mriedem Yeah just trying to get this thing merged. I'll bring it up in the next meeting and see if another spec core can give it some attention in the next week or so. | 21:09 |
cburgess | mriedem Thats for the support. | 21:09 |
*** ZZelle_ has quit IRC | 21:09 | |
*** ZZelle_ has joined #openstack-nova | 21:10 | |
*** alex_xu has quit IRC | 21:10 | |
bauzas | vilobhmm11: what's your virt driver? | 21:10 |
*** alex_xu has joined #openstack-nova | 21:12 | |
vilobhmm11 | bauzas , jaypipes : local_gb_used = 787 G while as reported by compute_nodes['local_gb_used'] = 3525 ? bauzas : libvirt sure agree regarding free_disk_gb calc https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L576 | 21:12 |
bauzas | vilobhmm11: that's because of RT.update_usage() which counts the root_gb and ephemeral_gb disk space for each instance | 21:15 |
dansmith | cburgess: get jaypipes to ack that RBD spec and then I'll approve | 21:15 |
*** heyongli has quit IRC | 21:16 | |
*** jerrygb has quit IRC | 21:16 | |
*** alex_xu has quit IRC | 21:16 | |
vilobhmm11 | bauzas : http://paste.openstack.org/show/477899/ if you see /home its used is 787G so it does not included the root_gb and ephemeral_gb disk space for each instance ? | 21:17 |
*** heyongli has joined #openstack-nova | 21:17 | |
bauzas | vilobhmm11: that's not working that way | 21:17 |
vilobhmm11 | bauzas : ok | 21:17 |
bauzas | vilobhmm11: so the local_gb is reported by the driver | 21:17 |
*** su_zhang has joined #openstack-nova | 21:18 | |
bauzas | vilobhmm11: then local_gb_used is calculated by update_avail_resource() periodically which sums up the instances disk space | 21:18 |
vilobhmm11 | bauzas : ok.. | 21:19 |
bauzas | and then free_disk_gb is just (local_gb - local_gb_used) which can be negative | 21:19 |
jaypipes | cburgess: never mind... an old Saturday Night Live joke.. | 21:20 |
*** changbl has quit IRC | 21:20 | |
vilobhmm11 | bauzas : so in my case looks like the local_gb calculation is right since 2TB = 2014 GB and local_gb calculation should be based of instance_path (done by virt driver) ? | 21:20 |
bauzas | vilobhmm11: I'm not really a libvirt expert, so I guess it's related to instance_path right | 21:21 |
*** changbl has joined #openstack-nova | 21:21 | |
vilobhmm11 | but somehow the local_gb_used is coming wrong ? I think thats what jaypipes was earlier referring to | 21:21 |
bauzas | vilobhmm11: could you please list all of your instances on the host and do the math ? | 21:22 |
*** rk4n has joined #openstack-nova | 21:22 | |
*** alex_xu has joined #openstack-nova | 21:22 | |
*** rajesht_ has quit IRC | 21:23 | |
bauzas | root_gb + ephemeral_gb | 21:23 |
*** rajesht has joined #openstack-nova | 21:23 | |
vilobhmm11 | bauzas : I tried this please check : http://paste.openstack.org/show/477903/ | 21:23 |
vilobhmm11 | SELECT SUM(root_gb + ephemeral_gb) AS total_gb FROM instances WHERE node = 'foobar'; | 21:23 |
bauzas | nah, please deleted=0 | 21:24 |
vilobhmm11 | bauzas : my bad ..please check this now http://paste.openstack.org/show/477904/ reports 3525 as reported by compute_nodes['local_gb_used'] | 21:25 |
*** jamielennox|away is now known as jamielennox | 21:25 | |
bauzas | vilobhmm11: so you see ? | 21:26 |
openstackgerrit | Pushkar Umaranikar proposed openstack/nova: Build timeouts task filters deleting instances https://review.openstack.org/240017 | 21:26 |
*** heyongli has quit IRC | 21:26 | |
bauzas | vilobhmm11: like I said local_gb is returned by the virt driver, but local_gb_used is only updated by calling the DB | 21:26 |
dansmith | sfinucan: DST screwed me on the meeting | 21:26 |
dansmith | sfinucan: so where did we leave off? | 21:26 |
*** heyongli has joined #openstack-nova | 21:27 | |
sfinucan | dansmith: DST is a bad idea and should go away | 21:27 |
sfinucan | but until then | 21:27 |
dansmith | yes | 21:27 |
sfinucan | we were discussing how to handle the '' = False value for config drive | 21:27 |
*** ZZelle__ has quit IRC | 21:27 | |
sfinucan | I'd like to actually store 'False' or 'false' in the database - the way it's done now is confusing | 21:28 |
sfinucan | so that's what I've been trying to do. There's a bug for it https://bugs.launchpad.net/nova/+bug/1193438 | 21:28 |
openstack | Launchpad bug 1193438 in OpenStack Compute (nova) "config_drive DB column cleanup" [Low,Invalid] - Assigned to Stephen Finucane (sfinucan) | 21:28 |
vilobhmm11 | bauzas : whatever we discussed till now makes sense…one last peice is missing but again if you see /home is @TB = 2014 GB (reported by virt driver) how can it include 3525 GB of instance storage. The actual usage as shown by the file system is just 787 GB http://paste.openstack.org/show/477904/ | 21:29 |
vilobhmm11 | 2TB | 21:29 |
dansmith | sfinucan: okay, but converting everyone to something nice isn't worth the effort | 21:29 |
jaypipes | dansmith: reviewed the RBD spec. good from me. | 21:29 |
dansmith | jaypipes: cool thanks | 21:29 |
bauzas | vilobhmm11: because you can allocate more disk space than what's really eaten | 21:30 |
bauzas | like say, I want to spin off a 10GB vm | 21:30 |
dansmith | sfinucan: doing so generates non-trivial work and barriers for large deployments | 21:30 |
dansmith | sfinucan: deployments with tons of existing instances | 21:31 |
bauzas | in general, it will end up only eating far less than 10 GB | 21:31 |
vilobhmm11 | bauzas : yes | 21:31 |
dansmith | sfinucan: so we can totally plan to make it a boolean on the object (which is all that matters for developers) in v3, and if we were going to do anything with the DB, we should head down the road of converting to a boolean I think, which is doable, but non-trivial | 21:31 |
bauzas | vilobhmm11: so that's why it's really important to check 2 things | 21:31 |
sfinucan | dansmith: yeah, I know :( | 21:32 |
bauzas | #1 that the real data usage is more than the free disk space calculated by the list of instances | 21:32 |
sfinucan | OK, and how would be go about doing that? | 21:32 |
bauzas | s/real data usage/real data space left/ | 21:32 |
sfinucan | Is it something that should be done now, or should I just drop the 'bool_from_string' call and wait? | 21:32 |
dansmith | sfinucan: we'd create a new column and migrate data to the new column during save() | 21:32 |
bauzas | #2 that what the user asks is less than what we calculated as free | 21:32 |
mriedem | dansmith: you could link your blog post on this - there is an example in there | 21:33 |
sfinucan | ah - online data migrations? | 21:33 |
dansmith | sfinucan: unless there is a really good reason to do it, I wouldn't want to do this ever | 21:33 |
sfinucan | dansmith: yeah, there isn't really | 21:33 |
mriedem | https://bugs.launchpad.net/nova/+bug/1244725 | 21:33 |
openstack | Launchpad bug 1193438 in OpenStack Compute (nova) "duplicate for #1244725 config_drive DB column cleanup" [Low,Invalid] - Assigned to Stephen Finucane (sfinucan) | 21:33 |
sfinucan | I think we discussed this before - strictly a nice to have | 21:33 |
mriedem | was the original bug | 21:33 |
dansmith | sfinucan: okay, so put a note in Instance to change config_drive to a boolean in v3 and be done with it | 21:34 |
dansmith | sfinucan: alternately, you could make the object ensure that, for all layers above, config_drive is some known value, assuming it won't break any existing stuff | 21:34 |
sfinucan | dansmith: So a wrapper of sorts? | 21:34 |
sfinucan | If <db_value> == '', return False? | 21:35 |
*** su_zhang has quit IRC | 21:35 | |
sfinucan | that kind of thing | 21:35 |
dansmith | i.e. self.config_drive = str(db_instance['config_drive'] == 'mandatory').lower() | 21:35 |
dansmith | you'd do it in the instance object _from_db_obj() method | 21:35 |
sfinucan | oh | 21:35 |
vilobhmm11 | bauzas : for irc://irc.freenode.net:6667/#1 that the real data usage is more than the free disk space calculated by the list of instances ; the real data space left [1.1 TB] > the free disk space calculated by the list of instances [-1511 GB] | 21:35 |
dansmith | sfinucan: but actually, there is deployed code that considers "false" to be truthy, so you can't even do that | 21:35 |
vilobhmm11 | bauzas : is that correct ? ref is http://paste.openstack.org/show/477904/ /home | 21:36 |
bauzas | vilobhmm11: the "real disk space" is disk_available_least, given by the driver | 21:36 |
dansmith | sfinucan: unless you add a backport rule for older instances that converts 'false' back to '' | 21:36 |
dansmith | sfinucan: hopefully I'm demonstrating why it's not worth making this purely cosmetic change? :) | 21:36 |
sfinucan | Ugh - sounds like a mess | 21:36 |
*** heyongli has quit IRC | 21:36 | |
sfinucan | dansmith: yes, very effectively :) | 21:36 |
dansmith | it's just kinda the reality of never wanting to break very large deployments of our stuff | 21:37 |
*** dims_ has quit IRC | 21:37 | |
dansmith | idealism doesn't really have a place :) | 21:37 |
vilobhmm11 | bauzas : so for number 1 : compute_nodes['disk_available_least'] = -1642 which is less than free disk space calculated by the list of instances [-1511 GB] | 21:37 |
*** heyongli has joined #openstack-nova | 21:37 | |
sfinucan | so it seems, heh | 21:37 |
sfinucan | so in this case, pre-V3 or any real changes | 21:38 |
*** su_zhang has joined #openstack-nova | 21:38 | |
*** pratikmallya has quit IRC | 21:38 | |
*** lbelivea has joined #openstack-nova | 21:38 | |
*** baoli has joined #openstack-nova | 21:38 | |
*** lbelivea has quit IRC | 21:39 | |
sfinucan | I at least need to drop that 'bool_from_string' call, or convert it to bool | 21:39 |
*** lbelivea has joined #openstack-nova | 21:39 | |
sfinucan | so any string is regarded as "truthy" | 21:39 |
sfinucan | plus whatever else reviews might yield | 21:39 |
sfinucan | ? | 21:39 |
*** spandhe has joined #openstack-nova | 21:39 | |
dansmith | I guess | 21:40 |
sfinucan | OK, I'll try that | 21:40 |
mriedem | https://review.openstack.org/#/c/92899/ actually points at a couple of bugs | 21:40 |
bauzas | vilobhmm11: right, https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L5085-L5088 | 21:40 |
sfinucan | and fix that weird Python34 issue | 21:40 |
mriedem | which means it's not cosmetic | 21:40 |
dansmith | mriedem: no, that issue isn't cosmetic, but changing the value we store in the db arbitrarily is | 21:41 |
sfinucan | mriedem: No, it's not but storing false is | 21:41 |
sfinucan | yeah, what he said ^^^ | 21:41 |
spandhe | mriedem: thanks for the review and comments on https://review.openstack.org/#/c/240347/4 | 21:41 |
*** gyee has joined #openstack-nova | 21:42 | |
*** alex_klimov has quit IRC | 21:43 | |
vilobhmm11 | bauzas : so now even if the operator(or anyone) tries to spin off micro VM is shouldn't go through if micro[root_gb] + micro[ephemeral_gb] = 8gb > free_disk_gb (-1511 ) ? | 21:43 |
bauzas | vilobhmm11: it should go thru this https://github.com/openstack/nova/blob/master/nova/scheduler/filters/disk_filter.py#L51-L53 | 21:44 |
vilobhmm11 | bauzas : looks like while booting the actual file system free space is checked (as reported by the virt driver) | 21:45 |
openstackgerrit | Shraddha Pandhe proposed openstack/nova: Remove unnecessary destroy call from Ironic virt driver https://review.openstack.org/240357 | 21:45 |
*** heyongli has quit IRC | 21:47 | |
*** heyongli has joined #openstack-nova | 21:47 | |
bauzas | vilobhmm11: right but it also checks the libvirt domains | 21:48 |
*** dims has joined #openstack-nova | 21:48 | |
bauzas | vilobhmm11: that's an interesting discussion but I'll have to drop off - my brain is out of fuel | 21:50 |
lbelivea | bauzas: Can you please have a look at https://bugs.launchpad.net/nova/+bug/1512880 ? We have this working on our private fork of upstream. We are looking to upstream our fixes (which are multiple). Do you have some guidance on how to split the many commits ? | 21:50 |
openstack | Launchpad bug 1512880 in OpenStack Compute (nova) "Failed cold migration with SR-IOV" [Undecided,New] | 21:50 |
*** baoli has quit IRC | 21:50 | |
openstackgerrit | Stephen Lowrie proposed openstack/nova: Update lxc-rc file to exclude volume tests https://review.openstack.org/241377 | 21:51 |
*** baoli has joined #openstack-nova | 21:51 | |
bauzas | lbelivea: not sure I understand your need, you want to know how to split a git patch into many gerrit changes ? | 21:53 |
bauzas | lbelivea: for SRIOV, I'm deferring that to ndipanov and sahid, but the former is on vacation while the latter is not on that TZ | 21:54 |
*** dims has quit IRC | 21:54 | |
*** jamielennox is now known as jamielennox|away | 21:55 | |
lbelivea | bauzas: No. I want to get going and submit multiple fixes/reviews. Each one of them fixing a small piece of the puzzle ... I was wondering if it makes sense to first fix the neutronv2 code for updating the neutron ports. But this will not be sufficiant for having a fully working solution for cold migration. | 21:56 |
*** rowagner has joined #openstack-nova | 21:56 | |
bauzas | lbelivea: so that's my 2nd point, you should ask that to ndipanov when he's back (next week) | 21:57 |
lbelivea | bauzas: Go it. Thanks ! | 21:57 |
*** heyongli has quit IRC | 21:57 | |
*** salv-orlando has joined #openstack-nova | 21:58 | |
*** heyongli has joined #openstack-nova | 21:58 | |
* bauzas umount /dev/brain | 21:58 | |
*** burt has quit IRC | 21:58 | |
*** baoli has quit IRC | 22:00 | |
*** baoli has joined #openstack-nova | 22:01 | |
rowagner | Hello, I'm trying to use heat to deploy a few RHEL servers, but instead of deploying in parallel, they deploy sequentially. Is there some setting in heat.conf or something that I have to set to allow multiple servers to deploy in parallel? | 22:03 |
*** kmartin_ is now known as kmartin | 22:06 | |
*** baoli has quit IRC | 22:07 | |
*** heyongli has quit IRC | 22:07 | |
sfinucan | rowagner: Wrong channel I think. That kind of question should go on #openstack | 22:08 |
sfinucan | See the message of the day | 22:08 |
*** heyongli has joined #openstack-nova | 22:08 | |
*** daemontool has quit IRC | 22:08 | |
*** baoli has joined #openstack-nova | 22:09 | |
*** baoli has quit IRC | 22:10 | |
*** baoli has joined #openstack-nova | 22:11 | |
*** rk4n has quit IRC | 22:13 | |
*** tongli has quit IRC | 22:13 | |
*** Piet has quit IRC | 22:14 | |
*** slagle has quit IRC | 22:14 | |
*** pixelb has quit IRC | 22:14 | |
*** browne has joined #openstack-nova | 22:15 | |
*** pratikmallya has joined #openstack-nova | 22:15 | |
*** rlrossit has left #openstack-nova | 22:15 | |
*** daemontool has joined #openstack-nova | 22:16 | |
*** jerrygb has joined #openstack-nova | 22:17 | |
*** eglynn__ has quit IRC | 22:17 | |
*** heyongli has quit IRC | 22:17 | |
*** pratikma_ has joined #openstack-nova | 22:18 | |
*** smurke has joined #openstack-nova | 22:18 | |
*** RA_ has joined #openstack-nova | 22:18 | |
*** heyongli has joined #openstack-nova | 22:18 | |
*** pratikmallya has quit IRC | 22:21 | |
*** jerrygb has quit IRC | 22:22 | |
*** baoli has quit IRC | 22:22 | |
*** baoli has joined #openstack-nova | 22:23 | |
*** thorst has quit IRC | 22:26 | |
*** thorst has joined #openstack-nova | 22:26 | |
*** salv-orlando has quit IRC | 22:26 | |
*** sorrison has joined #openstack-nova | 22:27 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: cells: bdm_update_or_create_at_top needs to check snapshot/image id https://review.openstack.org/241390 | 22:27 |
*** sorrison has left #openstack-nova | 22:28 | |
*** heyongli has quit IRC | 22:28 | |
*** heyongli has joined #openstack-nova | 22:28 | |
*** su_zhang has quit IRC | 22:29 | |
*** thorst has quit IRC | 22:31 | |
*** jerrygb has joined #openstack-nova | 22:32 | |
*** burgerk has quit IRC | 22:32 | |
*** smurke has quit IRC | 22:32 | |
*** changbl has quit IRC | 22:34 | |
*** baoli has quit IRC | 22:35 | |
*** baoli has joined #openstack-nova | 22:35 | |
*** vilobhmm111 has joined #openstack-nova | 22:35 | |
*** vilobhmm11 has quit IRC | 22:36 | |
*** heyongli has quit IRC | 22:38 | |
openstackgerrit | Stephen Finucane proposed openstack/nova: force_config_drive: StrOpt -> BoolOpt https://review.openstack.org/237762 | 22:38 |
openstackgerrit | Stephen Finucane proposed openstack/nova: Forcing a configdrive in cfg should populate DB https://review.openstack.org/92899 | 22:39 |
*** armax has joined #openstack-nova | 22:39 | |
*** heyongli has joined #openstack-nova | 22:39 | |
*** baoli has quit IRC | 22:39 | |
*** baoli has joined #openstack-nova | 22:39 | |
*** baoli has quit IRC | 22:40 | |
*** baoli has joined #openstack-nova | 22:44 | |
openstackgerrit | Matt Riedemann proposed openstack/nova: DO NOT MERGE: create unique constraint on block_device_mapping table https://review.openstack.org/241397 | 22:46 |
mriedem | alaski: yar ^ | 22:46 |
*** mc_nair has quit IRC | 22:47 | |
*** heyongli has quit IRC | 22:48 | |
*** baoli has quit IRC | 22:48 | |
*** baoli has joined #openstack-nova | 22:49 | |
*** heyongli has joined #openstack-nova | 22:49 | |
*** mriedem has quit IRC | 22:49 | |
*** ZZelle_ has quit IRC | 22:52 | |
*** dave-mccowan has quit IRC | 22:53 | |
*** ctrath has quit IRC | 22:55 | |
*** su_zhang has joined #openstack-nova | 22:55 | |
*** ccarmack has quit IRC | 22:55 | |
*** baoli has quit IRC | 22:55 | |
*** baoli has joined #openstack-nova | 22:56 | |
*** thorst has joined #openstack-nova | 22:58 | |
*** tonytan4ever has quit IRC | 22:58 | |
*** heyongli has quit IRC | 22:58 | |
openstackgerrit | Mark Doffman proposed openstack/nova: Properly preallocate qcow images. https://review.openstack.org/241401 | 22:59 |
*** heyongli has joined #openstack-nova | 22:59 | |
*** jamielennox|away is now known as jamielennox | 23:00 | |
*** jhesketh has quit IRC | 23:00 | |
*** jhesketh has joined #openstack-nova | 23:01 | |
*** thorst has quit IRC | 23:02 | |
*** jaypipes has quit IRC | 23:03 | |
*** electrocucaracha has quit IRC | 23:04 | |
*** Murali__ has quit IRC | 23:05 | |
*** baoli has quit IRC | 23:07 | |
*** baoli has joined #openstack-nova | 23:08 | |
*** heyongli has quit IRC | 23:09 | |
*** heyongli has joined #openstack-nova | 23:09 | |
*** slagle has joined #openstack-nova | 23:10 | |
*** Piet has joined #openstack-nova | 23:11 | |
*** tpeoples has quit IRC | 23:11 | |
*** davideagnello has quit IRC | 23:11 | |
*** mdrabe has quit IRC | 23:11 | |
*** pradk has quit IRC | 23:15 | |
*** thorst has joined #openstack-nova | 23:16 | |
*** baoli has quit IRC | 23:17 | |
*** baoli has joined #openstack-nova | 23:17 | |
*** heyongli has quit IRC | 23:19 | |
*** pumaranikar has quit IRC | 23:20 | |
*** heyongli has joined #openstack-nova | 23:20 | |
*** thorst has quit IRC | 23:20 | |
*** electrocucaracha has joined #openstack-nova | 23:21 | |
*** sileht has quit IRC | 23:24 | |
*** ctrath has joined #openstack-nova | 23:24 | |
*** thorst has joined #openstack-nova | 23:24 | |
*** dustins has quit IRC | 23:24 | |
*** salv-orlando has joined #openstack-nova | 23:25 | |
*** sneti has quit IRC | 23:25 | |
*** smatzek has joined #openstack-nova | 23:25 | |
*** IanGovett has joined #openstack-nova | 23:26 | |
*** dims has joined #openstack-nova | 23:27 | |
*** thorst has quit IRC | 23:28 | |
*** thorst has joined #openstack-nova | 23:28 | |
*** lbelivea has quit IRC | 23:29 | |
*** baoli has quit IRC | 23:29 | |
*** heyongli has quit IRC | 23:29 | |
*** baoli has joined #openstack-nova | 23:30 | |
*** heyongli has joined #openstack-nova | 23:30 | |
*** dims has quit IRC | 23:30 | |
*** thorst has quit IRC | 23:33 | |
*** mtanino has quit IRC | 23:35 | |
*** angdraug has quit IRC | 23:35 | |
*** smatzek has quit IRC | 23:39 | |
*** baoli has quit IRC | 23:39 | |
*** heyongli has quit IRC | 23:39 | |
*** ijuwang has quit IRC | 23:40 | |
*** armax has quit IRC | 23:40 | |
*** heyongli has joined #openstack-nova | 23:40 | |
*** jerrygb has quit IRC | 23:43 | |
*** josecastroleon has joined #openstack-nova | 23:44 | |
*** salv-orlando has quit IRC | 23:48 | |
*** heyongli has quit IRC | 23:50 | |
*** heyongli has joined #openstack-nova | 23:50 | |
*** angdraug has joined #openstack-nova | 23:55 | |
*** inteq has quit IRC | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!